[SCM] Samba Shared Repository - branch master updated
Andreas Schneider
asn at samba.org
Fri May 7 07:19:02 UTC 2021
The branch, master has been updated
via ac78b921daf bootstrap: Add Fedora 34 CI runner
via 75556656644 bootstrap: Remove libnsl as we dropped NIS support
via 8f12793ca5e lib:replace: Do not build strndup test with gcc 11 or newer
via 17ae9974f36 Fix gcc11 compiler issue "-Werror=stringop-overflow="
via 0e1695df7fe Fix gcc11 compiler issue "-Werror=maybe-uninitialized"
from 24d574f7828 s3: utils: Remove debug2html utility. Not used, installed or tested.
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit ac78b921dafa3372eee747caabd094fb5a05cf6b
Author: Andreas Schneider <asn at samba.org>
Date: Thu May 6 15:24:06 2021 +0200
bootstrap: Add Fedora 34 CI runner
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri May 7 07:18:02 UTC 2021 on sn-devel-184
commit 755566566440a4432db09e7cdc1733eb43354095
Author: Andreas Schneider <asn at samba.org>
Date: Thu May 6 15:36:20 2021 +0200
bootstrap: Remove libnsl as we dropped NIS support
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 8f12793ca5e7c9aa7c23a17400986878ae110e70
Author: Andreas Schneider <asn at samba.org>
Date: Thu May 6 19:07:04 2021 +0200
lib:replace: Do not build strndup test with gcc 11 or newer
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14699
gcc11 with -O3 detects that the size is incorrect:
lib/replace/tests/testsuite.c:286:13: error: ‘strndup’ specified bound 10 exceeds source size 4 [-Werror=stringop-overread]
286 | x = strndup("bla", 10);
| ^~~~~~~~~~~~~~~~~~
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 17ae9974f36ce8929f0c50c357dd4f88fbf37d7c
Author: Günther Deschner <gd at samba.org>
Date: Mon May 3 21:27:58 2021 +0200
Fix gcc11 compiler issue "-Werror=stringop-overflow="
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14699
[3548/3991] Compiling source3/winbindd/winbindd_pam.c
../../source3/winbindd/winbindd_pam.c: In function ‘winbindd_dual_pam_auth_cached’:
../../source3/winbindd/winbindd_pam.c:1069:18: error: ‘winbindd_get_creds’ accessing 128 bytes in a region of size 8 [-Werror=stringop-overflow=]
1069 | result = winbindd_get_creds(domain,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
1070 | state->mem_ctx,
| ~~~~~~~~~~~~~~~
1071 | &sid,
| ~~~~~
1072 | &my_info3,
| ~~~~~~~~~~
1073 | &cached_nt_pass,
| ~~~~~~~~~~~~~~~~
1074 | &cached_salt);
| ~~~~~~~~~~~~~
../../source3/winbindd/winbindd_pam.c:1069:18: note: referencing argument 5 of type ‘const uint8_t **’ {aka ‘const unsigned char **’}
../../source3/winbindd/winbindd_pam.c:1069:18: error: ‘winbindd_get_creds’ accessing 128 bytes in a region of size 8 [-Werror=stringop-overflow=]
../../source3/winbindd/winbindd_pam.c:1069:18: note: referencing argument 6 of type ‘const uint8_t **’ {aka ‘const unsigned char **’}
In file included from ../../source3/winbindd/winbindd.h:359,
from ../../source3/winbindd/winbindd_pam.c:26:
../../source3/winbindd/winbindd_proto.h:251:10: note: in a call to function ‘winbindd_get_creds’
251 | NTSTATUS winbindd_get_creds(struct winbindd_domain *domain,
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
Guenther
Signed-off-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 0e1695df7fe8952b5c503cf7ab1ff31784736988
Author: Günther Deschner <gd at samba.org>
Date: Mon May 3 21:27:43 2021 +0200
Fix gcc11 compiler issue "-Werror=maybe-uninitialized"
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14699
../../source4/dsdb/common/util_links.c: In function ‘ndr_guid_compare’:
../../source4/dsdb/common/util_links.c:38:29: error: ‘v1_data’ may be used uninitialized [-Werror=maybe-uninitialized]
38 | struct ldb_val v1 = data_blob_const(v1_data, sizeof(v1_data));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../source4/../lib/util/samba_util.h:48,
from ../../source4/include/includes.h:62,
from ../../source4/dsdb/common/util_links.c:22:
../../lib/util/data_blob.h:116:20: note: by argument 1 of type ‘const void *’ to ‘data_blob_const’ declared here
116 | _PUBLIC_ DATA_BLOB data_blob_const(const void *p, size_t length);
| ^~~~~~~~~~~~~~~
../../source4/dsdb/common/util_links.c:37:17: note: ‘v1_data’ declared here
37 | uint8_t v1_data[16];
| ^~~~~~~
cc1: all warnings being treated as errors
[1729/3991] Compiling source3/smbd/smbXsrv_open.c
../../libcli/auth/smbencrypt.c: In function ‘decode_wkssvc_join_password_buffer’:
../../libcli/auth/smbencrypt.c:1045:32: error: ‘_confounder’ may be used uninitialized [-Werror=maybe-uninitialized]
1045 | DATA_BLOB confounder = data_blob_const(_confounder, 8);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../source4/../lib/util/samba_util.h:48,
from ../../source4/include/includes.h:62,
from ../../libcli/auth/smbencrypt.c:24:
../../lib/util/data_blob.h:116:20: note: by argument 1 of type ‘const void *’ to ‘data_blob_const’ declared here
116 | _PUBLIC_ DATA_BLOB data_blob_const(const void *p, size_t length);
| ^~~~~~~~~~~~~~~
../../libcli/auth/smbencrypt.c:1044:17: note: ‘_confounder’ declared here
1044 | uint8_t _confounder[8];
| ^~~~~~~~~~~
cc1: all warnings being treated as errors
[2624/3991] Compiling source4/torture/rpc/samr.c
../../source3/rpc_client/cli_samr.c: In function ‘dcerpc_samr_chgpasswd_user2’:
../../source3/rpc_client/cli_samr.c:158:33: error: ‘old_nt_hash’ may be used uninitialized [-Werror=maybe-uninitialized]
158 | DATA_BLOB session_key = data_blob_const(old_nt_hash, 16);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../source3/../lib/util/samba_util.h:48,
from ../../source3/include/includes.h:256,
from ../../source3/rpc_client/cli_samr.c:24:
../../lib/util/data_blob.h:116:20: note: by argument 1 of type ‘const void *’ to ‘data_blob_const’ declared here
116 | _PUBLIC_ DATA_BLOB data_blob_const(const void *p, size_t length);
| ^~~~~~~~~~~~~~~
../../source3/rpc_client/cli_samr.c:152:17: note: ‘old_nt_hash’ declared here
152 | uint8_t old_nt_hash[16];
| ^~~~~~~~~~~
../../source3/rpc_client/cli_samr.c: In function ‘dcerpc_samr_chgpasswd_user3’:
../../source3/rpc_client/cli_samr.c:365:33: error: ‘old_nt_hash’ may be used uninitialized [-Werror=maybe-uninitialized]
365 | DATA_BLOB session_key = data_blob_const(old_nt_hash, 16);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../source3/../lib/util/samba_util.h:48,
from ../../source3/include/includes.h:256,
from ../../source3/rpc_client/cli_samr.c:24:
../../lib/util/data_blob.h:116:20: note: by argument 1 of type ‘const void *’ to ‘data_blob_const’ declared here
116 | _PUBLIC_ DATA_BLOB data_blob_const(const void *p, size_t length);
| ^~~~~~~~~~~~~~~
../../source3/rpc_client/cli_samr.c:358:17: note: ‘old_nt_hash’ declared here
358 | uint8_t old_nt_hash[16];
| ^~~~~~~~~~~
cc1: all warnings being treated as errors
[3399/3991] Compiling source3/rpcclient/cmd_spotlight.c
../../source3/smbd/smbXsrv_open.c: In function ‘smbXsrv_open_set_replay_cache’:
../../source3/smbd/smbXsrv_open.c:936:26: error: ‘data’ may be used uninitialized [-Werror=maybe-uninitialized]
936 | DATA_BLOB blob = data_blob_const(data, ARRAY_SIZE(data));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../source3/../lib/util/samba_util.h:48,
from ../../source3/include/includes.h:256,
from ../../source3/smbd/smbXsrv_open.c:21:
../../lib/util/data_blob.h:116:20: note: by argument 1 of type ‘const void *’ to ‘data_blob_const’ declared here
116 | _PUBLIC_ DATA_BLOB data_blob_const(const void *p, size_t length);
| ^~~~~~~~~~~~~~~
../../source3/smbd/smbXsrv_open.c:935:17: note: ‘data’ declared here
935 | uint8_t data[SMBXSRV_OPEN_REPLAY_CACHE_FIXED_SIZE];
| ^~~~
cc1: all warnings being treated as errors
../../source3/rpcclient/cmd_spotlight.c: In function ‘cmd_mdssvc_fetch_properties’:
../../source3/rpcclient/cmd_spotlight.c:60:18: error: ‘share_path’ may be used uninitialized [-Werror=maybe-uninitialized]
60 | status = dcerpc_mdssvc_open(b, mem_ctx,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
61 | &device_id,
| ~~~~~~~~~~~
62 | &unkn1,
| ~~~~~~~
63 | &unkn2,
| ~~~~~~~
64 | argv[2],
| ~~~~~~~~
65 | argv[1],
| ~~~~~~~~
66 | share_path,
| ~~~~~~~~~~~
67 | &share_handle);
| ~~~~~~~~~~~~~~
In file included from ../../source3/rpcclient/cmd_spotlight.c:24:
source3/../librpc/gen_ndr/ndr_mdssvc_c.h:26:10: note: by argument 8 of type ‘const char *’ to ‘dcerpc_mdssvc_open’ declared here
26 | NTSTATUS dcerpc_mdssvc_open(struct dcerpc_binding_handle *h,
| ^~~~~~~~~~~~~~~~~~
../../source3/rpcclient/cmd_spotlight.c:40:14: note: ‘share_path’ declared here
40 | char share_path[1025];
| ^~~~~~~~~~
cc1: all warnings being treated as errors
../../source4/torture/rpc/samr.c: In function ‘test_ChangePasswordUser2’:
../../source4/torture/rpc/samr.c:2266:19: error: ‘old_nt_hash’ may be used uninitialized [-Werror=maybe-uninitialized]
2266 | = data_blob_const(old_nt_hash, sizeof(old_nt_hash));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../source4/../lib/util/samba_util.h:48,
from ../../source4/include/includes.h:62,
from ../../source4/torture/rpc/samr.c:24:
../../lib/util/data_blob.h:116:20: note: by argument 1 of type ‘const void *’ to ‘data_blob_const’ declared here
116 | _PUBLIC_ DATA_BLOB data_blob_const(const void *p, size_t length);
| ^~~~~~~~~~~~~~~
../../source4/torture/rpc/samr.c:2263:17: note: ‘old_nt_hash’ declared here
2263 | uint8_t old_nt_hash[16], new_nt_hash[16];
| ^~~~~~~~~~~
../../source4/torture/rpc/samr.c: In function ‘test_ChangePasswordUser2_ntstatus’:
../../source4/torture/rpc/samr.c:2371:19: error: ‘old_nt_hash’ may be used uninitialized [-Werror=maybe-uninitialized]
2371 | = data_blob_const(old_nt_hash, sizeof(old_nt_hash));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../source4/../lib/util/samba_util.h:48,
from ../../source4/include/includes.h:62,
from ../../source4/torture/rpc/samr.c:24:
../../lib/util/data_blob.h:116:20: note: by argument 1 of type ‘const void *’ to ‘data_blob_const’ declared here
116 | _PUBLIC_ DATA_BLOB data_blob_const(const void *p, size_t length);
| ^~~~~~~~~~~~~~~
../../source4/torture/rpc/samr.c:2368:17: note: ‘old_nt_hash’ declared here
2368 | uint8_t old_nt_hash[16], new_nt_hash[16];
| ^~~~~~~~~~~
../../source4/torture/rpc/samr.c: In function ‘test_ChangePasswordUser3’:
../../source4/torture/rpc/samr.c:2478:38: error: ‘old_nt_hash’ may be used uninitialized [-Werror=maybe-uninitialized]
2478 | DATA_BLOB old_nt_hash_blob = data_blob_const(old_nt_hash, 16);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../source4/../lib/util/samba_util.h:48,
from ../../source4/include/includes.h:62,
from ../../source4/torture/rpc/samr.c:24:
../../lib/util/data_blob.h:116:20: note: by argument 1 of type ‘const void *’ to ‘data_blob_const’ declared here
116 | _PUBLIC_ DATA_BLOB data_blob_const(const void *p, size_t length);
| ^~~~~~~~~~~~~~~
../../source4/torture/rpc/samr.c:2473:17: note: ‘old_nt_hash’ declared here
2473 | uint8_t old_nt_hash[16], new_nt_hash[16];
| ^~~~~~~~~~~
../../source4/torture/rpc/samr.c: In function ‘test_ChangePasswordRandomBytes’:
../../source4/torture/rpc/samr.c:2794:19: error: ‘old_nt_hash’ may be used uninitialized [-Werror=maybe-uninitialized]
2794 | = data_blob_const(old_nt_hash,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
2795 | sizeof(old_nt_hash));
| ~~~~~~~~~~~~~~~~~~~~
In file included from ../../source4/../lib/util/samba_util.h:48,
from ../../source4/include/includes.h:62,
from ../../source4/torture/rpc/samr.c:24:
../../lib/util/data_blob.h:116:20: note: by argument 1 of type ‘const void *’ to ‘data_blob_const’ declared here
116 | _PUBLIC_ DATA_BLOB data_blob_const(const void *p, size_t length);
| ^~~~~~~~~~~~~~~
../../source4/torture/rpc/samr.c:2792:17: note: ‘old_nt_hash’ declared here
2792 | uint8_t old_nt_hash[16], new_nt_hash[16];
| ^~~~~~~~~~~
cc1: all warnings being treated as errors
Guenther
Signed-off-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
-----------------------------------------------------------------------
Summary of changes:
.gitlab-ci-main.yml | 16 ++++++++--------
bootstrap/.gitlab-ci.yml | 4 ++--
bootstrap/config.py | 17 +++++++----------
bootstrap/generated-dists/Vagrantfile | 14 +++++++-------
bootstrap/generated-dists/centos7/bootstrap.sh | 1 -
bootstrap/generated-dists/centos7/packages.yml | 1 -
bootstrap/generated-dists/centos8/bootstrap.sh | 1 -
bootstrap/generated-dists/centos8/packages.yml | 1 -
bootstrap/generated-dists/fedora33/bootstrap.sh | 1 -
bootstrap/generated-dists/fedora33/packages.yml | 1 -
.../generated-dists/{fedora32 => fedora34}/Dockerfile | 2 +-
.../generated-dists/{fedora32 => fedora34}/bootstrap.sh | 1 -
.../generated-dists/{fedora32 => fedora34}/locale.sh | 0
.../generated-dists/{fedora32 => fedora34}/packages.yml | 1 -
bootstrap/generated-dists/opensuse151/bootstrap.sh | 1 -
bootstrap/generated-dists/opensuse151/packages.yml | 1 -
bootstrap/generated-dists/opensuse152/bootstrap.sh | 1 -
bootstrap/generated-dists/opensuse152/packages.yml | 1 -
bootstrap/sha1sum.txt | 2 +-
lib/replace/tests/testsuite.c | 11 +++++++++++
libcli/auth/smbencrypt.c | 2 +-
source3/rpc_client/cli_samr.c | 4 ++--
source3/rpcclient/cmd_spotlight.c | 2 +-
source3/smbd/smbXsrv_open.c | 2 +-
source3/winbindd/winbindd_creds.c | 4 ++--
source3/winbindd/winbindd_proto.h | 4 ++--
source4/dsdb/common/util_links.c | 2 +-
source4/torture/rpc/samr.c | 8 ++++----
28 files changed, 51 insertions(+), 55 deletions(-)
rename bootstrap/generated-dists/{fedora32 => fedora34}/Dockerfile (92%)
rename bootstrap/generated-dists/{fedora32 => fedora34}/bootstrap.sh (98%)
rename bootstrap/generated-dists/{fedora32 => fedora34}/locale.sh (100%)
rename bootstrap/generated-dists/{fedora32 => fedora34}/packages.yml (98%)
Changeset truncated at 500 lines:
diff --git a/.gitlab-ci-main.yml b/.gitlab-ci-main.yml
index b0f81e674bb..af51a233561 100644
--- a/.gitlab-ci-main.yml
+++ b/.gitlab-ci-main.yml
@@ -42,7 +42,7 @@ variables:
# Set this to the contents of bootstrap/sha1sum.txt
# which is generated by bootstrap/template.py --render
#
- SAMBA_CI_CONTAINER_TAG: f25e1fa0a828f428ade0e4f37d8a646ff1e207d4
+ SAMBA_CI_CONTAINER_TAG: 66bfd3037078ebaa3395adfd563e8cc78d49d4d3
#
# We use the ubuntu1804 image as default as
# it matches what we have on sn-devel-184.
@@ -60,8 +60,8 @@ variables:
SAMBA_CI_CONTAINER_IMAGE_debian10: debian10
SAMBA_CI_CONTAINER_IMAGE_opensuse151: opensuse151
SAMBA_CI_CONTAINER_IMAGE_opensuse152: opensuse152
- SAMBA_CI_CONTAINER_IMAGE_fedora32: fedora32
SAMBA_CI_CONTAINER_IMAGE_fedora33: fedora33
+ SAMBA_CI_CONTAINER_IMAGE_fedora34: fedora34
SAMBA_CI_CONTAINER_IMAGE_centos7: centos7
SAMBA_CI_CONTAINER_IMAGE_centos8: centos8
@@ -342,7 +342,7 @@ samba-ad-dc-4b-mitkrb5:
samba-fips:
extends: .shared_template
variables:
- SAMBA_CI_JOB_IMAGE: ${SAMBA_CI_CONTAINER_IMAGE_fedora33}
+ SAMBA_CI_JOB_IMAGE: ${SAMBA_CI_CONTAINER_IMAGE_fedora34}
.private_test_only:
extends: .private_runner_test
@@ -454,7 +454,7 @@ pages:
coverity:
extends: .shared_runner_build_image
variables:
- SAMBA_CI_JOB_IMAGE: ${SAMBA_CI_CONTAINER_IMAGE_fedora33}
+ SAMBA_CI_JOB_IMAGE: ${SAMBA_CI_CONTAINER_IMAGE_fedora34}
stage: build
script:
- wget https://scan.coverity.com/download/linux64 --post-data "token=$COVERITY_SCAN_TOKEN&project=$COVERITY_SCAN_PROJECT_NAME" -O /tmp/coverity_tool.tgz
@@ -546,15 +546,15 @@ centos8-samba-o3:
variables:
SAMBA_CI_JOB_IMAGE: ${SAMBA_CI_CONTAINER_IMAGE_centos8}
-fedora32-samba-o3:
+fedora33-samba-o3:
extends: .samba-o3-template
variables:
- SAMBA_CI_JOB_IMAGE: ${SAMBA_CI_CONTAINER_IMAGE_fedora32}
+ SAMBA_CI_JOB_IMAGE: ${SAMBA_CI_CONTAINER_IMAGE_fedora33}
-fedora33-samba-o3:
+fedora34-samba-o3:
extends: .samba-o3-template
variables:
- SAMBA_CI_JOB_IMAGE: ${SAMBA_CI_CONTAINER_IMAGE_fedora33}
+ SAMBA_CI_JOB_IMAGE: ${SAMBA_CI_CONTAINER_IMAGE_fedora34}
#
# Keep the samba-o3 sections at the end ...
diff --git a/bootstrap/.gitlab-ci.yml b/bootstrap/.gitlab-ci.yml
index 1a8376daa4c..5e5856b1e90 100644
--- a/bootstrap/.gitlab-ci.yml
+++ b/bootstrap/.gitlab-ci.yml
@@ -103,10 +103,10 @@ ubuntu2004:
debian10:
extends: .build_image_template
-fedora32:
+fedora33:
extends: .build_image_template
-fedora33:
+fedora34:
extends: .build_image_template
centos8:
diff --git a/bootstrap/config.py b/bootstrap/config.py
index 8383aeb392d..bfd5b947d07 100644
--- a/bootstrap/config.py
+++ b/bootstrap/config.py
@@ -126,7 +126,6 @@ PKGS = [
('', 'rpcgen'), # required for test
# refer: https://fedoraproject.org/wiki/Changes/SunRPCRemoval
('', 'libtirpc-devel'), # for <rpc/rpc.h> header on fedora
- ('', 'libnsl2-devel'), # for <rpcsvc/yp_prot.h> header on fedora
('', 'rpcsvc-proto-devel'), # for <rpcsvc/rquota.h> header
('mawk', 'gawk'),
@@ -473,25 +472,25 @@ RPM_DISTS = {
'liburing-devel': '', # not available yet, Add me back, once available!
}
},
- 'fedora32': {
- 'docker_image': 'fedora:32',
- 'vagrant_box': 'fedora/32-cloud-base',
+ 'fedora33': {
+ 'docker_image': 'fedora:33',
+ 'vagrant_box': 'fedora/33-cloud-base',
'bootstrap': DNF_BOOTSTRAP,
'replace': {
'lsb-release': 'redhat-lsb',
'libsemanage-python': 'python3-libsemanage',
'policycoreutils-python': 'python3-policycoreutils',
- 'perl-FindBin': '',
}
},
- 'fedora33': {
- 'docker_image': 'fedora:33',
- 'vagrant_box': 'fedora/33-cloud-base',
+ 'fedora34': {
+ 'docker_image': 'fedora:34',
+ 'vagrant_box': 'fedora/34-cloud-base',
'bootstrap': DNF_BOOTSTRAP,
'replace': {
'lsb-release': 'redhat-lsb',
'libsemanage-python': 'python3-libsemanage',
'policycoreutils-python': 'python3-policycoreutils',
+ 'perl-FindBin': '',
}
},
'opensuse151': {
@@ -508,7 +507,6 @@ RPM_DISTS = {
'jansson-devel': 'libjansson-devel',
'keyutils-libs-devel': 'keyutils-devel',
'krb5-workstation': 'krb5-client',
- 'libnsl2-devel': 'libnsl-devel',
'libsemanage-python': 'python2-semanage',
'openldap-devel': 'openldap2-devel',
'perl-Archive-Tar': 'perl-Archive-Tar-Wrapper',
@@ -540,7 +538,6 @@ RPM_DISTS = {
'jansson-devel': 'libjansson-devel',
'keyutils-libs-devel': 'keyutils-devel',
'krb5-workstation': 'krb5-client',
- 'libnsl2-devel': 'libnsl-devel',
'libsemanage-python': 'python2-semanage',
'openldap-devel': 'openldap2-devel',
'perl-Archive-Tar': 'perl-Archive-Tar-Wrapper',
diff --git a/bootstrap/generated-dists/Vagrantfile b/bootstrap/generated-dists/Vagrantfile
index 042e45238d3..42da0161e40 100644
--- a/bootstrap/generated-dists/Vagrantfile
+++ b/bootstrap/generated-dists/Vagrantfile
@@ -31,13 +31,6 @@ Vagrant.configure("2") do |config|
v.vm.provision :shell, path: "debian10/locale.sh"
end
- config.vm.define "fedora32" do |v|
- v.vm.box = "fedora/32-cloud-base"
- v.vm.hostname = "fedora32"
- v.vm.provision :shell, path: "fedora32/bootstrap.sh"
- v.vm.provision :shell, path: "fedora32/locale.sh"
- end
-
config.vm.define "fedora33" do |v|
v.vm.box = "fedora/33-cloud-base"
v.vm.hostname = "fedora33"
@@ -45,6 +38,13 @@ Vagrant.configure("2") do |config|
v.vm.provision :shell, path: "fedora33/locale.sh"
end
+ config.vm.define "fedora34" do |v|
+ v.vm.box = "fedora/34-cloud-base"
+ v.vm.hostname = "fedora34"
+ v.vm.provision :shell, path: "fedora34/bootstrap.sh"
+ v.vm.provision :shell, path: "fedora34/locale.sh"
+ end
+
config.vm.define "opensuse151" do |v|
v.vm.box = "opensuse/openSUSE-15.1-x86_64"
v.vm.hostname = "opensuse151"
diff --git a/bootstrap/generated-dists/centos7/bootstrap.sh b/bootstrap/generated-dists/centos7/bootstrap.sh
index 7a6659d8e9a..00dd22b891f 100755
--- a/bootstrap/generated-dists/centos7/bootstrap.sh
+++ b/bootstrap/generated-dists/centos7/bootstrap.sh
@@ -53,7 +53,6 @@ yum install -y \
libbsd-devel \
libcap-devel \
libicu-devel \
- libnsl2-devel \
libpcap-devel \
libsemanage-python \
libtasn1-devel \
diff --git a/bootstrap/generated-dists/centos7/packages.yml b/bootstrap/generated-dists/centos7/packages.yml
index ef6bbf82670..3f5e8331b40 100644
--- a/bootstrap/generated-dists/centos7/packages.yml
+++ b/bootstrap/generated-dists/centos7/packages.yml
@@ -39,7 +39,6 @@ packages:
- libbsd-devel
- libcap-devel
- libicu-devel
- - libnsl2-devel
- libpcap-devel
- libsemanage-python
- libtasn1-devel
diff --git a/bootstrap/generated-dists/centos8/bootstrap.sh b/bootstrap/generated-dists/centos8/bootstrap.sh
index b9f2df67645..131a62fa6a9 100755
--- a/bootstrap/generated-dists/centos8/bootstrap.sh
+++ b/bootstrap/generated-dists/centos8/bootstrap.sh
@@ -62,7 +62,6 @@ yum install -y \
libcap-devel \
libcephfs-devel \
libicu-devel \
- libnsl2-devel \
libpcap-devel \
libtasn1-devel \
libtasn1-tools \
diff --git a/bootstrap/generated-dists/centos8/packages.yml b/bootstrap/generated-dists/centos8/packages.yml
index 4e45f1c15e1..54c80b53107 100644
--- a/bootstrap/generated-dists/centos8/packages.yml
+++ b/bootstrap/generated-dists/centos8/packages.yml
@@ -42,7 +42,6 @@ packages:
- libcap-devel
- libcephfs-devel
- libicu-devel
- - libnsl2-devel
- libpcap-devel
- libtasn1-devel
- libtasn1-tools
diff --git a/bootstrap/generated-dists/fedora33/bootstrap.sh b/bootstrap/generated-dists/fedora33/bootstrap.sh
index fce2626eaee..5d5e31aa534 100755
--- a/bootstrap/generated-dists/fedora33/bootstrap.sh
+++ b/bootstrap/generated-dists/fedora33/bootstrap.sh
@@ -54,7 +54,6 @@ dnf install -y \
libcap-devel \
libcephfs-devel \
libicu-devel \
- libnsl2-devel \
libpcap-devel \
libtasn1-devel \
libtasn1-tools \
diff --git a/bootstrap/generated-dists/fedora33/packages.yml b/bootstrap/generated-dists/fedora33/packages.yml
index 9fb68c1c539..1a291ab1ff6 100644
--- a/bootstrap/generated-dists/fedora33/packages.yml
+++ b/bootstrap/generated-dists/fedora33/packages.yml
@@ -43,7 +43,6 @@ packages:
- libcap-devel
- libcephfs-devel
- libicu-devel
- - libnsl2-devel
- libpcap-devel
- libtasn1-devel
- libtasn1-tools
diff --git a/bootstrap/generated-dists/fedora32/Dockerfile b/bootstrap/generated-dists/fedora34/Dockerfile
similarity index 92%
rename from bootstrap/generated-dists/fedora32/Dockerfile
rename to bootstrap/generated-dists/fedora34/Dockerfile
index d8a75cf8445..0ce89448a5f 100644
--- a/bootstrap/generated-dists/fedora32/Dockerfile
+++ b/bootstrap/generated-dists/fedora34/Dockerfile
@@ -3,7 +3,7 @@
# See also bootstrap/config.py
#
-FROM fedora:32
+FROM fedora:34
# pass in with --build-arg while build
ARG SHA1SUM
diff --git a/bootstrap/generated-dists/fedora32/bootstrap.sh b/bootstrap/generated-dists/fedora34/bootstrap.sh
similarity index 98%
rename from bootstrap/generated-dists/fedora32/bootstrap.sh
rename to bootstrap/generated-dists/fedora34/bootstrap.sh
index 1a585d2f133..104aaa6c444 100755
--- a/bootstrap/generated-dists/fedora32/bootstrap.sh
+++ b/bootstrap/generated-dists/fedora34/bootstrap.sh
@@ -54,7 +54,6 @@ dnf install -y \
libcap-devel \
libcephfs-devel \
libicu-devel \
- libnsl2-devel \
libpcap-devel \
libtasn1-devel \
libtasn1-tools \
diff --git a/bootstrap/generated-dists/fedora32/locale.sh b/bootstrap/generated-dists/fedora34/locale.sh
similarity index 100%
rename from bootstrap/generated-dists/fedora32/locale.sh
rename to bootstrap/generated-dists/fedora34/locale.sh
diff --git a/bootstrap/generated-dists/fedora32/packages.yml b/bootstrap/generated-dists/fedora34/packages.yml
similarity index 98%
rename from bootstrap/generated-dists/fedora32/packages.yml
rename to bootstrap/generated-dists/fedora34/packages.yml
index ee3a0a6d2ff..a5b4e3dd544 100644
--- a/bootstrap/generated-dists/fedora32/packages.yml
+++ b/bootstrap/generated-dists/fedora34/packages.yml
@@ -43,7 +43,6 @@ packages:
- libcap-devel
- libcephfs-devel
- libicu-devel
- - libnsl2-devel
- libpcap-devel
- libtasn1-devel
- libtasn1-tools
diff --git a/bootstrap/generated-dists/opensuse151/bootstrap.sh b/bootstrap/generated-dists/opensuse151/bootstrap.sh
index df136a64ae8..cc8aa11c95f 100755
--- a/bootstrap/generated-dists/opensuse151/bootstrap.sh
+++ b/bootstrap/generated-dists/opensuse151/bootstrap.sh
@@ -52,7 +52,6 @@ zypper --non-interactive install \
libcephfs-devel \
libicu-devel \
libjansson-devel \
- libnsl-devel \
libpcap-devel \
libtasn1-devel \
libtirpc-devel \
diff --git a/bootstrap/generated-dists/opensuse151/packages.yml b/bootstrap/generated-dists/opensuse151/packages.yml
index 9f224e86c36..b0f78414437 100644
--- a/bootstrap/generated-dists/opensuse151/packages.yml
+++ b/bootstrap/generated-dists/opensuse151/packages.yml
@@ -40,7 +40,6 @@ packages:
- libcephfs-devel
- libicu-devel
- libjansson-devel
- - libnsl-devel
- libpcap-devel
- libtasn1-devel
- libtirpc-devel
diff --git a/bootstrap/generated-dists/opensuse152/bootstrap.sh b/bootstrap/generated-dists/opensuse152/bootstrap.sh
index ab9b2e52370..e71d8157f82 100755
--- a/bootstrap/generated-dists/opensuse152/bootstrap.sh
+++ b/bootstrap/generated-dists/opensuse152/bootstrap.sh
@@ -52,7 +52,6 @@ zypper --non-interactive install \
libcephfs-devel \
libicu-devel \
libjansson-devel \
- libnsl-devel \
libpcap-devel \
libtasn1-devel \
libtirpc-devel \
diff --git a/bootstrap/generated-dists/opensuse152/packages.yml b/bootstrap/generated-dists/opensuse152/packages.yml
index 8a65ed8c688..0010d0b415d 100644
--- a/bootstrap/generated-dists/opensuse152/packages.yml
+++ b/bootstrap/generated-dists/opensuse152/packages.yml
@@ -40,7 +40,6 @@ packages:
- libcephfs-devel
- libicu-devel
- libjansson-devel
- - libnsl-devel
- libpcap-devel
- libtasn1-devel
- libtirpc-devel
diff --git a/bootstrap/sha1sum.txt b/bootstrap/sha1sum.txt
index af96c13b35e..e2800636e59 100644
--- a/bootstrap/sha1sum.txt
+++ b/bootstrap/sha1sum.txt
@@ -1 +1 @@
-f25e1fa0a828f428ade0e4f37d8a646ff1e207d4
+66bfd3037078ebaa3395adfd563e8cc78d49d4d3
diff --git a/lib/replace/tests/testsuite.c b/lib/replace/tests/testsuite.c
index ce344d6549e..b4b038af8c7 100644
--- a/lib/replace/tests/testsuite.c
+++ b/lib/replace/tests/testsuite.c
@@ -283,6 +283,15 @@ static int test_strndup(void)
return false;
}
+#ifdef __GNUC__
+# if __GNUC__ < 11
+ /*
+ * This code will not compile with gcc11 -O3 anymore.
+ *
+ * error: ‘strndup’ specified bound 10 exceeds source size 4 [-Werror=stringop-overread]
+ * x = strndup("bla", 10);
+ * ^~~~~~~~~~~~~~~~~~
+ */
x = strndup("bla", 10);
cmp = strcmp(x, "bla");
free(x);
@@ -290,6 +299,8 @@ static int test_strndup(void)
printf("failure: strndup [\ninvalid\n]\n");
return false;
}
+# endif
+#endif /* __GNUC__ */
printf("success: strndup\n");
return true;
diff --git a/libcli/auth/smbencrypt.c b/libcli/auth/smbencrypt.c
index 337e89ef559..468374699f7 100644
--- a/libcli/auth/smbencrypt.c
+++ b/libcli/auth/smbencrypt.c
@@ -1041,7 +1041,7 @@ WERROR decode_wkssvc_join_password_buffer(TALLOC_CTX *mem_ctx,
DATA_BLOB *session_key,
char **pwd)
{
- uint8_t _confounder[8];
+ uint8_t _confounder[8] = { 0 };
DATA_BLOB confounder = data_blob_const(_confounder, 8);
uint8_t pwbuf[516] = {0};
DATA_BLOB decrypt_pwbuf = data_blob_const(pwbuf, 516);
diff --git a/source3/rpc_client/cli_samr.c b/source3/rpc_client/cli_samr.c
index acd96480a20..25b54298b32 100644
--- a/source3/rpc_client/cli_samr.c
+++ b/source3/rpc_client/cli_samr.c
@@ -149,7 +149,7 @@ NTSTATUS dcerpc_samr_chgpasswd_user2(struct dcerpc_binding_handle *h,
struct samr_Password old_nt_hash_enc;
struct samr_Password old_lanman_hash_enc;
- uint8_t old_nt_hash[16];
+ uint8_t old_nt_hash[16] = { 0 };
uint8_t old_lanman_hash[16];
uint8_t new_nt_hash[16];
uint8_t new_lanman_hash[16];
@@ -355,7 +355,7 @@ NTSTATUS dcerpc_samr_chgpasswd_user3(struct dcerpc_binding_handle *h,
struct samr_Password old_nt_hash_enc;
struct samr_Password old_lanman_hash_enc;
- uint8_t old_nt_hash[16];
+ uint8_t old_nt_hash[16] = { 0 };
uint8_t old_lanman_hash[16];
uint8_t new_nt_hash[16];
uint8_t new_lanman_hash[16];
diff --git a/source3/rpcclient/cmd_spotlight.c b/source3/rpcclient/cmd_spotlight.c
index 661ada7efb8..24db9893df6 100644
--- a/source3/rpcclient/cmd_spotlight.c
+++ b/source3/rpcclient/cmd_spotlight.c
@@ -37,7 +37,7 @@ static NTSTATUS cmd_mdssvc_fetch_properties(
uint32_t unkn1 = 23;
uint32_t unkn2 = 0;
struct policy_handle share_handle;
- char share_path[1025];
+ char share_path[1025] = { 0 };
uint32_t mds_status;
uint32_t flags; /* server always returns 0x6b000001 ? */
uint32_t unkn3; /* server always returns 0 ? */
diff --git a/source3/smbd/smbXsrv_open.c b/source3/smbd/smbXsrv_open.c
index b007d61410e..b6ea51a5f66 100644
--- a/source3/smbd/smbXsrv_open.c
+++ b/source3/smbd/smbXsrv_open.c
@@ -932,7 +932,7 @@ static NTSTATUS smbXsrv_open_set_replay_cache(struct smbXsrv_open *op)
.idle_time = op->idle_time,
.local_id = op->local_id,
};
- uint8_t data[SMBXSRV_OPEN_REPLAY_CACHE_FIXED_SIZE];
+ uint8_t data[SMBXSRV_OPEN_REPLAY_CACHE_FIXED_SIZE] = { 0 };
DATA_BLOB blob = data_blob_const(data, ARRAY_SIZE(data));
enum ndr_err_code ndr_err;
NTSTATUS status;
diff --git a/source3/winbindd/winbindd_creds.c b/source3/winbindd/winbindd_creds.c
index 2d7aacf36a9..97262bbf87b 100644
--- a/source3/winbindd/winbindd_creds.c
+++ b/source3/winbindd/winbindd_creds.c
@@ -33,8 +33,8 @@ NTSTATUS winbindd_get_creds(struct winbindd_domain *domain,
TALLOC_CTX *mem_ctx,
const struct dom_sid *sid,
struct netr_SamInfo3 **info3,
- const uint8_t *cached_nt_pass[NT_HASH_LEN],
- const uint8_t *cred_salt[NT_HASH_LEN])
+ const uint8_t **cached_nt_pass,
+ const uint8_t **cred_salt)
{
struct netr_SamInfo3 *info;
NTSTATUS status;
diff --git a/source3/winbindd/winbindd_proto.h b/source3/winbindd/winbindd_proto.h
index 04edf3489bb..fec5d691dd8 100644
--- a/source3/winbindd/winbindd_proto.h
+++ b/source3/winbindd/winbindd_proto.h
@@ -252,8 +252,8 @@ NTSTATUS winbindd_get_creds(struct winbindd_domain *domain,
TALLOC_CTX *mem_ctx,
const struct dom_sid *sid,
struct netr_SamInfo3 **info3,
- const uint8_t *cached_nt_pass[NT_HASH_LEN],
- const uint8_t *cred_salt[NT_HASH_LEN]);
+ const uint8_t **cached_nt_pass,
+ const uint8_t **cred_salt);
NTSTATUS winbindd_store_creds(struct winbindd_domain *domain,
const char *user,
const char *pass,
diff --git a/source4/dsdb/common/util_links.c b/source4/dsdb/common/util_links.c
index 9e9e2b0161a..08fc2d657bb 100644
--- a/source4/dsdb/common/util_links.c
+++ b/source4/dsdb/common/util_links.c
@@ -34,7 +34,7 @@
*/
int ndr_guid_compare(const struct GUID *guid1, const struct GUID *guid2)
{
- uint8_t v1_data[16];
+ uint8_t v1_data[16] = { 0 };
struct ldb_val v1 = data_blob_const(v1_data, sizeof(v1_data));
uint8_t v2_data[16];
struct ldb_val v2 = data_blob_const(v2_data, sizeof(v2_data));
diff --git a/source4/torture/rpc/samr.c b/source4/torture/rpc/samr.c
index 5863a6d1ee6..6c901c3c2ab 100644
--- a/source4/torture/rpc/samr.c
+++ b/source4/torture/rpc/samr.c
@@ -2260,7 +2260,7 @@ static bool test_ChangePasswordUser2(struct dcerpc_pipe *p, struct torture_conte
struct samr_Password nt_verifier, lm_verifier;
char *oldpass;
struct dcerpc_binding_handle *b = p->binding_handle;
- uint8_t old_nt_hash[16], new_nt_hash[16];
+ uint8_t old_nt_hash[16] = { 0 }, new_nt_hash[16];
uint8_t old_lm_hash[16], new_lm_hash[16];
DATA_BLOB old_nt_hash_blob
= data_blob_const(old_nt_hash, sizeof(old_nt_hash));
@@ -2365,7 +2365,7 @@ static bool test_ChangePasswordUser2_ntstatus(struct dcerpc_pipe *p, struct tort
struct samr_Password nt_verifier, lm_verifier;
const char *oldpass;
struct dcerpc_binding_handle *b = p->binding_handle;
- uint8_t old_nt_hash[16], new_nt_hash[16];
+ uint8_t old_nt_hash[16] = { 0 }, new_nt_hash[16];
--
Samba Shared Repository
More information about the samba-cvs
mailing list