[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Mon Jun 28 20:04:01 UTC 2021


The branch, master has been updated
       via  b5339048001 s3: VFS: fake_acls. Add missing NULL check for return of cp_smb_filename().
      from  c2fde31b1c2 s3: smbd: Cleanup - rename get_ea_names_from_file() -> get_ea_names_from_fsp().

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit b5339048001890f4e0ea0b19fdf15f988878c735
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jun 28 10:20:49 2021 -0700

    s3: VFS: fake_acls. Add missing NULL check for return of cp_smb_filename().
    
    Found by Coverity.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Jun 28 20:03:33 UTC 2021 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source3/modules/vfs_fake_acls.c | 5 +++++
 1 file changed, 5 insertions(+)


Changeset truncated at 500 lines:

diff --git a/source3/modules/vfs_fake_acls.c b/source3/modules/vfs_fake_acls.c
index 79735a81233..15cfff63f44 100644
--- a/source3/modules/vfs_fake_acls.c
+++ b/source3/modules/vfs_fake_acls.c
@@ -116,6 +116,11 @@ static int fake_acls_stat(vfs_handle_struct *handle,
 			 */
 			smb_fname_cp = cp_smb_filename(talloc_tos(),
 						       smb_fname);
+			if (smb_fname_cp == NULL) {
+				errno = ENOMEM;
+				return -1;
+			}
+
 			/* Recursion guard. */
 			in_openat_pathref_fsp = true;
 			status = openat_pathref_fsp(handle->conn->cwd_fsp,


-- 
Samba Shared Repository



More information about the samba-cvs mailing list