[SCM] Samba Shared Repository - branch master updated

Stefan Metzmacher metze at samba.org
Wed Jun 16 14:44:01 UTC 2021

The branch, master has been updated
       via  c9350fef6e1 heimdal_build: Improve error and warning handling on old and new compilers
      from  263c95aee38 s3: smbd: Fix smbd crash on dangling symlink with posix connection calling several non-posix info levels.


- Log -----------------------------------------------------------------
commit c9350fef6e1141858ae2c3f200f3aaca5a8a29b8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Jun 16 16:51:14 2021 +1200

    heimdal_build: Improve error and warning handling on old and new compilers
    The previous commit 1eadeaed0a6ca3a58eb9fd176a7ae5bcc28f64ef had a couple of
    errors, the unpicky flags were being set on all builds (not just old
    compiler builds) due to confusing variable names, and Ubuntu 16.04
    would not build (for fuzzing) because it thought some variables
    were maybe-uninitialized.
    This keeps stricter warnings->errors on modern compilers while
    allowing the full build, even in the near future when a modern
    Heimdal is imported.
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Wed Jun 16 14:43:17 UTC 2021 on sn-devel-184


Summary of changes:
 source4/heimdal_build/wscript_build     | 3 ++-
 source4/heimdal_build/wscript_configure | 3 +++
 2 files changed, 5 insertions(+), 1 deletion(-)

Changeset truncated at 500 lines:

diff --git a/source4/heimdal_build/wscript_build b/source4/heimdal_build/wscript_build
index 28a1fb5240d..0c59fb85f3f 100644
--- a/source4/heimdal_build/wscript_build
+++ b/source4/heimdal_build/wscript_build
@@ -266,8 +266,9 @@ def HEIMDAL_LIBRARY(libname, source, deps, vnum, version_script, includes='', cf
 def HEIMDAL_CFLAGS(use_hostcc=False, extra_cflags=[]):
-    if not bld.env.enable_heimdal_warnings:
+    if bld.env.allow_heimdal_warnings:
         cflags_unpicky += bld.env.HEIMDAL_UNPICKY_WNO_STRICT_OVERFLOW_CFLAGS
         # old compilers on centos7 or ubuntu1604 need this
     allow_warnings = bld.env.allow_heimdal_warnings
diff --git a/source4/heimdal_build/wscript_configure b/source4/heimdal_build/wscript_configure
index 3978d38c1a3..c4a3b1de99f 100644
--- a/source4/heimdal_build/wscript_configure
+++ b/source4/heimdal_build/wscript_configure
@@ -91,6 +91,9 @@ else:
+                          '-Wno-error=maybe-uninitialized',
+                          testflags=True)
     Logs.info("Allowing warnings in Heimdal code as this compiler does "
               "not support enough -Wno-error flags (bad)")

Samba Shared Repository

More information about the samba-cvs mailing list