[SCM] Samba Shared Repository - branch v4-13-test updated

Karolin Seeger kseeger at samba.org
Thu Jan 7 10:51:01 UTC 2021

The branch, v4-13-test has been updated
       via  fc15ff8951f Do not create an empty DB when accessing a sam.ldb
      from  c5159bd6d76 bootstrap: Cope with case changes in CentOS 8 repo names


- Log -----------------------------------------------------------------
commit fc15ff8951f791ba53f25b44c105093c1cdb9bac
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 23 19:35:37 2020 +1300

    Do not create an empty DB when accessing a sam.ldb
    Samba already does this for samba-tool and doing this should make
    our errors more sensible, particularly in BIND9 if not provisioned
    with the correct --dns-backend=DLZ_BIND9
    The old error was like:
     named[62954]: samba_dlz: Unable to get basedn for
      - NULL Base DN invalid for a base search.
    The new error will be like (in this case from the torture test):
     Failed to connect to Failed to connect to
     Unable to open tdb '/home/abartlet/samba/st/chgdcpass/bind-dns/dns/sam.ldb':
     No such file or directory: Operations error
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14579
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    (cherry picked from commit d49e96bc45ea5e2d3364242dad36fe9094b7cc42)
    Autobuild-User(v4-13-test): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(v4-13-test): Thu Jan  7 10:50:10 UTC 2021 on sn-devel-184


Summary of changes:
 source4/dsdb/samdb/samdb.c | 3 +++
 1 file changed, 3 insertions(+)

Changeset truncated at 500 lines:

diff --git a/source4/dsdb/samdb/samdb.c b/source4/dsdb/samdb/samdb.c
index 10db0c50395..d5890dec03e 100644
--- a/source4/dsdb/samdb/samdb.c
+++ b/source4/dsdb/samdb/samdb.c
@@ -63,6 +63,9 @@ int samdb_connect_url(TALLOC_CTX *mem_ctx,
 	*ldb_ret = NULL;
 	*errstring = NULL;
+	/* We create sam.ldb in provision, and never anywhere else */
 	if (remote_address == NULL) {
 		ldb = ldb_wrap_find(url, ev_ctx, lp_ctx,
 				    session_info, NULL, flags);

Samba Shared Repository

More information about the samba-cvs mailing list