[SCM] Samba Shared Repository - branch master updated
Volker Lendecke
vlendec at samba.org
Tue Apr 20 06:43:01 UTC 2021
The branch, master has been updated
via 667fd04ccd5 s3:passdb: Fix 'return 1' in secrets_store_creds()
from 62782a1482c lib: Fix a typo
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 667fd04ccd500bc6b5f619450b577f62d8a234ab
Author: pavel.filipensky <pavel.filipensky at gmail.com>
Date: Fri Apr 16 14:24:15 2021 +0200
s3:passdb: Fix 'return 1' in secrets_store_creds()
The recently introduced function secrets_store_creds() should always
use 'return false' in case of a failure. It is not only spelling issue
since 'return 1' actually means 'return true'.
Signed-off-by: Pavel Filipensky <pavel.filipensky at gmail.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Apr 20 06:42:50 UTC 2021 on sn-devel-184
-----------------------------------------------------------------------
Summary of changes:
source3/passdb/secrets.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Changeset truncated at 500 lines:
diff --git a/source3/passdb/secrets.c b/source3/passdb/secrets.c
index be9cc0039d3..fdacafa11c9 100644
--- a/source3/passdb/secrets.c
+++ b/source3/passdb/secrets.c
@@ -169,7 +169,7 @@ bool secrets_store_creds(struct cli_credentials *creds)
ok = secrets_store(SECRETS_AUTH_DOMAIN, p, strlen(p) + 1);
if (!ok) {
DBG_ERR("Failed storing auth domain name\n");
- return 1;
+ return false;
}
--
Samba Shared Repository
More information about the samba-cvs
mailing list