[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Fri Oct 23 15:33:02 UTC 2020


The branch, master has been updated
       via  3b5b23ea848 examples:auth: Do not install example plugin
       via  6e25613a314 s3:modules: Do not install vfs modules only used for testing
       via  2d89ddb012d unittests: Mark test binaries for selftest
       via  8fa0d3331b2 buildtools: Do not install binaries which are for selftest
       via  9bc9f8ce66e s3:script: Fix test_dfree_quota.sh
      from  63a4e883582 smbd: split out POSIX info_levels from smbd_do_setfilepathinfo() into own function

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 3b5b23ea848d82ec0a6d01d4e1cbb62c4c3cbb3b
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Oct 23 08:57:12 2020 +0200

    examples:auth: Do not install example plugin
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14550
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Oct 23 15:32:08 UTC 2020 on sn-devel-184

commit 6e25613a3141000ac1b7e8edb146dfc320972e8b
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Oct 23 08:53:43 2020 +0200

    s3:modules: Do not install vfs modules only used for testing
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14550
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 2d89ddb012d1d84871da10a61a0449f88d4eba5e
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Oct 22 17:41:01 2020 +0200

    unittests: Mark test binaries for selftest
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14550
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 8fa0d3331b2b2c450d86bffec0a6f39320fcb8c0
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Oct 22 17:40:01 2020 +0200

    buildtools: Do not install binaries which are for selftest
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14550
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 9bc9f8ce66ef02d7d77cfd31dc2a72102d546d75
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Oct 22 11:08:19 2020 +0200

    s3:script: Fix test_dfree_quota.sh
    
    source3/script/tests/test_dfree_quota.sh: line 200: [: missing `]'
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14550
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 buildtools/wafsamba/wafsamba.py          |  6 ++++--
 examples/auth/wscript_build              |  3 ++-
 source3/modules/wscript_build            | 12 ++++++++----
 source3/script/tests/test_dfree_quota.sh |  2 +-
 testsuite/unittests/wscript              |  6 +++---
 5 files changed, 18 insertions(+), 11 deletions(-)


Changeset truncated at 500 lines:

diff --git a/buildtools/wafsamba/wafsamba.py b/buildtools/wafsamba/wafsamba.py
index 9f6ee4f5c7f..9dd6d05b91b 100644
--- a/buildtools/wafsamba/wafsamba.py
+++ b/buildtools/wafsamba/wafsamba.py
@@ -365,8 +365,10 @@ def SAMBA_BINARY(bld, binname, source,
                  for_selftest=False):
     '''define a Samba binary'''
 
-    if for_selftest and not bld.CONFIG_GET('ENABLE_SELFTEST'):
-        enabled=False
+    if for_selftest:
+        install=False
+        if not bld.CONFIG_GET('ENABLE_SELFTEST'):
+            enabled=False
 
     if not enabled:
         SET_TARGET_TYPE(bld, binname, 'DISABLED')
diff --git a/examples/auth/wscript_build b/examples/auth/wscript_build
index 91f5302918b..03221238e5f 100644
--- a/examples/auth/wscript_build
+++ b/examples/auth/wscript_build
@@ -6,4 +6,5 @@ bld.SAMBA3_MODULE('auth_skel',
                  deps='samba-util',
                  init_function='',
                  internal_module=bld.SAMBA3_IS_STATIC_MODULE('auth_skel'),
-                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('auth_skel'))
+                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('auth_skel'),
+                 install=False)
diff --git a/source3/modules/wscript_build b/source3/modules/wscript_build
index c4f3db22296..36b047ef79b 100644
--- a/source3/modules/wscript_build
+++ b/source3/modules/wscript_build
@@ -114,7 +114,8 @@ bld.SAMBA3_MODULE('vfs_fake_acls',
                  deps='samba-util',
                  init_function='',
                  internal_module=bld.SAMBA3_IS_STATIC_MODULE('vfs_fake_acls'),
-                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('vfs_fake_acls'))
+                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('vfs_fake_acls'),
+                 install=False)
 
 bld.SAMBA3_MODULE('vfs_recycle',
                  subsystem='vfs',
@@ -622,21 +623,24 @@ bld.SAMBA3_MODULE('vfs_fake_dfq',
                  source='vfs_fake_dfq.c',
                  init_function='',
                  internal_module=bld.SAMBA3_IS_STATIC_MODULE('vfs_fake_dfq'),
-                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('vfs_fake_dfq'))
+                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('vfs_fake_dfq'),
+                 install=False)
 
 bld.SAMBA3_MODULE('vfs_error_inject',
                  subsystem='vfs',
                  source='vfs_error_inject.c',
                  init_function='',
                  internal_module=bld.SAMBA3_IS_STATIC_MODULE('vfs_error_inject'),
-                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('vfs_error_inject'))
+                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('vfs_error_inject'),
+                 install=False)
 
 bld.SAMBA3_MODULE('vfs_delay_inject',
                  subsystem='vfs',
                  source='vfs_delay_inject.c',
                  init_function='',
                  internal_module=bld.SAMBA3_IS_STATIC_MODULE('vfs_delay_inject'),
-                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('vfs_delay_inject'))
+                 enabled=bld.SAMBA3_IS_ENABLED_MODULE('vfs_delay_inject'),
+                 install=False)
 
 bld.SAMBA3_MODULE('vfs_widelinks',
                  subsystem='vfs',
diff --git a/source3/script/tests/test_dfree_quota.sh b/source3/script/tests/test_dfree_quota.sh
index e86d431180a..a1403a8c4ba 100755
--- a/source3/script/tests/test_dfree_quota.sh
+++ b/source3/script/tests/test_dfree_quota.sh
@@ -197,7 +197,7 @@ test_smbcquotas() {
 	return $status
 }
 
-if [ $protocol != "SMB3" -a $protocol != "NT1"]; then
+if [ $protocol != "SMB3" ] && [ $protocol != "NT1" ]; then
 	echo "unsupported protocol $protocol" | subunit_fail_test "Test dfree quota"
 	failed=`expr $failed + 1`
 fi
diff --git a/testsuite/unittests/wscript b/testsuite/unittests/wscript
index 40fcb01ad57..2b4b37b92de 100644
--- a/testsuite/unittests/wscript
+++ b/testsuite/unittests/wscript
@@ -9,7 +9,7 @@ def build(bld):
     bld.SAMBA_BINARY('test_krb5samba',
                      source='test_krb5_samba.c',
                      deps='krb5samba cmocka',
-                     install=False)
+                     for_selftest=True)
 
     bld.SAMBA_BINARY('test_sambafs_srv_pipe',
                      source='test_sambafs_srv_pipe.c',
@@ -18,7 +18,7 @@ def build(bld):
                           RPC_SAMR
                           cmocka
                           ''',
-                     install=False)
+                     for_selftest=True)
 
     bld.SAMBA_BINARY('test_lib_util_modules',
                      source='test_lib_util_modules.c',
@@ -26,7 +26,7 @@ def build(bld):
                           samba-modules
                           cmocka
                           ''',
-                     install=False)
+                     for_selftest=True)
 
     bld.SAMBA_MODULE('rpc_test_dummy_module',
                      source='rpc_test_dummy_module.c',


-- 
Samba Shared Repository



More information about the samba-cvs mailing list