[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Mon Jun 22 10:00:01 UTC 2020


The branch, master has been updated
       via  f9dd67355ba Fix usage of ldap_get_values_len for msDS-AdditionalDnsHostName
      from  c5bb40ec8c6 vfs_shadow_copy2: Fix a log message

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit f9dd67355ba35539d7ae1774d5135fd05d747b3f
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sat Jun 20 17:17:33 2020 +0200

    Fix usage of ldap_get_values_len for msDS-AdditionalDnsHostName
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14406
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Jun 22 09:59:04 UTC 2020 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source3/libads/ldap.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index 51ceb447254..36e73440495 100755
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -3707,8 +3707,12 @@ static char **get_addl_hosts(ADS_STRUCT *ads, TALLOC_CTX *mem_ctx,
 	}
 
 	for (i = 0; i < *num_values; i++) {
-		if (!pull_utf8_talloc(mem_ctx, &ret[i], values[i]->bv_val,
-				      &converted_size)) {
+		ret[i] = NULL;
+		if (!convert_string_talloc(mem_ctx, CH_UTF8, CH_UNIX,
+					   values[i]->bv_val,
+					   strnlen(values[i]->bv_val,
+						   values[i]->bv_len),
+					   &ret[i], &converted_size)) {
 			ldap_value_free_len(values);
 			return NULL;
 		}


-- 
Samba Shared Repository



More information about the samba-cvs mailing list