[SCM] Samba Shared Repository - branch master updated

Samuel Cabrero scabrero at samba.org
Tue Jul 7 13:44:02 UTC 2020


The branch, master has been updated
       via  61e93698e59 s4:rpc_server: Implement epmapper LookupHandleFree
       via  072cdbd3713 s4:torture: Do not skip epmapper lookup terminate test in samba4
       via  054f58e468c selftest: Split samba4 epmapper expected failures into individual tests
      from  31d187be0f4 s4:selftest: test for smbtorture subunit names with and without --fullname

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 61e93698e597ad9e2480464df94b5f2ceb57bb24
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Mon Jun 29 12:49:33 2020 +0200

    s4:rpc_server: Implement epmapper LookupHandleFree
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Samuel Cabrero <scabrero at samba.org>
    Autobuild-Date(master): Tue Jul  7 13:43:14 UTC 2020 on sn-devel-184

commit 072cdbd371312311377f7a4449dddb18e4605462
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Mon Jun 29 12:46:50 2020 +0200

    s4:torture: Do not skip epmapper lookup terminate test in samba4
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 054f58e468c48e1223441db73e33302454646699
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Mon Jun 29 12:45:33 2020 +0200

    selftest: Split samba4 epmapper expected failures into individual tests
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 selftest/knownfail                         |  4 +++-
 source4/rpc_server/epmapper/rpc_epmapper.c | 11 ++++++++++-
 source4/torture/rpc/epmapper.c             |  4 ----
 3 files changed, 13 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/selftest/knownfail b/selftest/knownfail
index 9b25d22eae0..c5f1f447838 100644
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -87,7 +87,9 @@
 ^samba4.local.registry.*.local.security
 ^samba4.rpc.wkssvc
 ^samba4.rpc.handles.*.lsarpc-shared
-^samba4.rpc.epmapper
+^samba4.rpc.epmapper.*.Lookup_simple
+^samba4.rpc.epmapper.*.Map_simple
+^samba4.rpc.epmapper.*.Map_full
 ^samba4.rpc.lsalookup on ncalrpc
 ^samba4.rpc.lsalookup on ncacn_np
 ^samba4.rpc.lsalookup with seal,padcheck
diff --git a/source4/rpc_server/epmapper/rpc_epmapper.c b/source4/rpc_server/epmapper/rpc_epmapper.c
index 462553dfe6f..1634b9f4eaf 100644
--- a/source4/rpc_server/epmapper/rpc_epmapper.c
+++ b/source4/rpc_server/epmapper/rpc_epmapper.c
@@ -261,7 +261,16 @@ failed:
 static error_status_t dcesrv_epm_LookupHandleFree(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx, 
 					   struct epm_LookupHandleFree *r)
 {
-	DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+	struct dcesrv_handle *h = NULL;
+
+	r->out.entry_handle = r->in.entry_handle;
+
+	DCESRV_PULL_HANDLE_FAULT(h, r->in.entry_handle, HTYPE_LOOKUP);
+	TALLOC_FREE(h);
+
+	ZERO_STRUCTP(r->out.entry_handle);
+
+	return EPMAPPER_STATUS_OK;
 }
 
 static error_status_t dcesrv_epm_InqObject(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx, 
diff --git a/source4/torture/rpc/epmapper.c b/source4/torture/rpc/epmapper.c
index f32d122b36e..be0acc0946e 100644
--- a/source4/torture/rpc/epmapper.c
+++ b/source4/torture/rpc/epmapper.c
@@ -437,10 +437,6 @@ static bool test_LookupHandleFree(struct torture_context *tctx,
 	NTSTATUS status;
 	struct epm_LookupHandleFree r;
 
-	if (torture_setting_bool(tctx, "samba4", false)) {
-		torture_skip(tctx, "Skip Insert test against Samba4");
-	}
-
 	if (ndr_policy_handle_empty(entry_handle)) {
 		torture_comment(tctx,
 				"epm_LookupHandleFree failed - empty policy_handle\n");


-- 
Samba Shared Repository



More information about the samba-cvs mailing list