[SCM] Samba Shared Repository - branch v4-12-stable created

Stefan Metzmacher metze at samba.org
Tue Jan 21 13:31:37 UTC 2020


The branch, v4-12-stable has been created
        at  85478847a1f6bf8027a1a91df23ae746042620db (commit)

- Log -----------------------------------------------------------------
commit 85478847a1f6bf8027a1a91df23ae746042620db
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Dec 20 18:16:13 2019 +1100

    WHATSNEW: Add CTDB changes for 4.12
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Tue Jan 21 13:05:00 UTC 2020 on sn-devel-184

commit aa2977e1519b76b2c70871032bbc5ab85f8a0c45
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 10 14:25:39 2020 +1100

    ctdb-mutex: Change default re-check time for fcntl helper to 5s
    
    Testing against a commonly used cluster filesystem has shown no
    performance impact, as expected.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 14b1dffc27def76f1c69ff820f4e03dc50ddf4b6
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 10 15:45:48 2020 +1100

    ctdb-tests: Add some tests to check recovery from recovery lock issues
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 64501f519319f83fb6281da50c76275782ee1f6c
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 10 14:04:14 2020 +1100

    ctdb-tests: Put recovery lock for local daemons into a subdirectory
    
    This makes it more like the way it works with a cluster filesystem.
    It also allows the subdirectory to be manipulated in tests.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 93fc31858f91c1b4080a223fed905eaac66a90d2
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 17 15:30:01 2020 +1100

    ctdb-tests: Add local_daemons.sh option for recovery lock recheck interval
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 13658324a3ab30213ff50c21308f287ef3a131fd
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Mon Dec 16 13:57:47 2019 +1300

    CVE-2019-19344 kcc dns scavenging: Fix use after free in dns_tombstone_records_zone
    
    ldb_msg_add_empty reallocates the underlying element array, leaving
    old_el pointing to freed memory.
    
    This patch takes two defensive copies of the ldb message, and performs
    the updates on them rather than the ldb messages in the result.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14050
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(master): Tue Jan 21 11:38:38 UTC 2020 on sn-devel-184

commit 34a8cee348d3dfea18e92a4ae829ae797a652192
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 29 20:58:47 2019 +1300

    CVE-2019-14907 lib/util: Do not print the failed to convert string into the logs
    
    The string may be in another charset, or may be sensitive and
    certainly may not be terminated.  It is not safe to just print.
    
    Found by Robert Święcki using a fuzzer he wrote for smbd.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14208
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 86023642c3961f00d0e4e6c71086739d9d568276
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 18:26:11 2019 +1300

    repl_meta_data: Only reset replMetaData entry for name if we made a conflict name here
    
    We previously set it for any rename
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 9e126852a6912e545641a506491f425a987e3b80
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 18:15:16 2019 +1300

    repl_meta_data: Do not set *rename = true unless there has been a conflict on the incoming DN
    
    The normal case of a partner-sent rename is not a cause for updating the replPropertyMetaData
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 512ea17983e7cca78778d493c75b4401a438dfbb
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 17:55:13 2019 +1300

    repl_meta_data: Add comment explaining what is being renamed after the conflict is resolved
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 2b1828276b365a30131ac6ea543ac344941b8088
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 12 14:44:57 2019 +1300

    CVE-2019-14902 dsdb: Change basis of descriptor module deferred processing to be GUIDs
    
    We can not process on the basis of a DN, as the DN may have changed in a rename,
    not only that this module can see, but also from repl_meta_data below.
    
    Therefore remove all the complex tree-based change processing, leaving only
    a tree-based sort of the possible objects to be changed, and a single
    stopped_dn variable containing the DN to stop processing below (after
    a no-op change).
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit b7030f9a8bd67f454c17d065d9af9199748aa6d3
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 18:26:42 2019 +1300

    CVE-2019-14902 repl_meta_data: Set renamed = true (and so do SD inheritance) after any rename
    
    Previously if there was a conflict, but the incoming object would still
    win, this was not marked as a rename, and so inheritence was not done.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 4c62210098df44c6c4cbd0a3d41734e11286106c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 26 15:50:35 2019 +1300

    CVE-2019-14902 repl_meta_data: Fix issue where inherited Security Descriptors were not replicated.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 520d2ae187e83b1cefb4d0c9bf823a051db6b14f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 18:05:54 2019 +1300

    CVE-2019-14902 repl_meta_data: schedule SD propagation to a renamed DN
    
    We need to check the SD of the parent if we rename, it is not the same as an incoming SD change.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 3f3791765c6fd554b8f7708df0101d3c58339a27
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 17:54:23 2019 +1300

    CVE-2019-14902 dsdb: Ensure we honour both change->force_self and change->force_children
    
    If we are renaming a DN we can be in a situation where we need to
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 5d714c1cea1beadc9ca07935217e0174d9d48ac6
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 26 16:17:32 2019 +1300

    CVE-2019-14902 dsdb: Add comments explaining why SD propagation needs to be done here
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 545d205e5b203983855c10558ad3a326c13b712e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 26 15:44:32 2019 +1300

    CVE-2019-14902 dsdb: Explain that descriptor_sd_propagation_recursive() is proctected by a transaction
    
    This means we can trust the DB did not change between the two search
    requests.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit febe15ab2e109721a7f8ef996c3fe4d82106c42c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Dec 16 11:29:27 2019 +1300

    selftest: Add test to confirm ACL inheritence really happens
    
    While we have a seperate test (sec_descriptor.py) that confirms inheritance in
    general we want to lock in these specific patterns as this test covers
    rename.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit d64670bab82f21fc16fb9ffb32f713c0cae2f9e3
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Dec 10 15:16:24 2019 +1300

    CVE-2019-14902 selftest: Add test for a special case around replicated renames
    
    It appears Samba is currently string-name based in the ACL inheritence code.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 7b19e221aeefb4a93990aa589636df471cb8d47e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 28 17:16:16 2019 +1300

    CVE-2019-14902 selftest: Add test for replication of inherited security descriptors
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 558bd7c83d08523a9e88414195d9703df38e9af2
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 1 13:52:38 2019 +1000

    util: Add detection of libunwind
    
    The current detection doesn't seem to work, so libunwind doesn't seem
    to be used.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Tue Jan 21 08:12:17 UTC 2020 on sn-devel-184

commit 5ff83809a2be567b69714373ab13bde09f72705c
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 17 13:47:02 2020 +1100

    s3: lib: dbwrap_ctdb: Ensure value_valid is set when creating empty record
    
    Fixes:
    
      PANIC: assert failed at ../../lib/dbwrap/dbwrap.c(82): rec->value_valid
      PANIC (pid 902392): assert failed: rec->value_valid
      BACKTRACE: 16 stack frames:
       #0 bin/shared/libsamba-util.so.0(log_stack_trace+0x30) [0x7fb161f69cb0]
       #1 bin/shared/libsmbconf.so.0(smb_panic_s3+0x23) [0x7fb1619f4863]
       #2 bin/shared/libsamba-util.so.0(smb_panic+0x2f) [0x7fb161f69daf]
       #3 bin/shared/private/libdbwrap-samba4.so(dbwrap_record_get_value+0x27) [0x7fb160a04c57]
       #4 bin/shared/libsamba-passdb.so.0(+0x2d27c) [0x7fb1618e627c]
       #5 bin/shared/libsamba-passdb.so.0(pdb_add_aliasmem+0x33) [0x7fb1618db663]
       #6 bin/shared/libsamba-passdb.so.0(+0x1edbb) [0x7fb1618d7dbb]
       #7 bin/shared/libsamba-passdb.so.0(create_builtin_administrators+0x167) [0x7fb1618d8217]
       #8 bin/shared/private/libauth-samba4.so(finalize_local_nt_token+0x39d) [0x7fb16194bd5d]
       #9 bin/shared/private/libauth-samba4.so(create_local_nt_token_from_info3+0x304) [0x7fb16194c3f4]
       #10 bin/shared/private/libauth-samba4.so(create_local_token+0x3d6) [0x7fb161945106]
       #11 bin/shared/private/libauth-samba4.so(+0x154b4) [0x7fb1619474b4]
       #12 bin/shared/private/libauth-samba4.so(init_guest_session_info+0x58) [0x7fb161947798]
       #13 ./bin/smbd(main+0x80f) [0x55944ef8f91f]
       #14 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7fb161076bbb]
       #15 ./bin/smbd(_start+0x2a) [0x55944ef90f8a]
    
    This is a similar, additional fix to commit
    36ea1e188d5ea8d40c47ffc466a494c1160e471c.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Jan 20 04:25:57 UTC 2020 on sn-devel-184

commit 4dd026d0d33ab5d3c6cc22d63a74917c1c2c2f27
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 17 16:00:18 2020 +0100

    smbd: Fix claiming version
    
    We now have to do an explicit DOWNGRADE when we want to change from
    G_LOCK_WRITE to G_LOCK_READ.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sun Jan 19 19:58:01 UTC 2020 on sn-devel-184

commit 25bcf0e7890a690f5f573dc5e8392807c403948c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 8 16:07:30 2020 +0100

    lib: Use closefrom() in smbrun.c
    
    INSURE is never defined or used.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 42a3e2e503baef456082d40617a7639a9e226491
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 17 11:28:31 2020 +0100

    ctdbd: Use struct initialization
    
    2 lines less
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b274bc698ed26c6897beee6051532244bc30d2ec
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 19 12:29:56 2020 +0100

    dsdb: Use write_data() to write to the password check script
    
    A simple write() might be interrupted or do short writes. Highly
    unlikely, but if it happens, it will be impossible to diagnose.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 229518ec01b495e0133d83d3560a432a08307c0b
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 19 12:29:39 2020 +0100

    dsdb: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 37eb87d2be88e0e47c72287033e9c829e9625d41
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 19 11:50:57 2020 +0100

    lib: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cffcc39f185031bc85bcf0c770892b115058a831
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Jan 18 18:35:42 2020 +1000

    heimdal_build: Remove bashism from --address-sanitizer build rule
    
    export FOO=bar is a Bash extension, and is not required in this case, we only need the asn1_compile
    to run under the variable, there are no further commands in this sub-shell.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Sat Jan 18 12:25:16 UTC 2020 on sn-devel-184

commit 7606800b798a31d62e69f61d441201e5db2f0d8a
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Jan 17 10:56:00 2020 +0100

    smbd: avoid calling vfs_file_id_from_sbuf() if statinfo is not valid
    
    When we're about to create a file, the stat info will be all zero, so
    vfs_file_id_from_sbuf() would return a bogus file_id. This is normally not a
    problem, as open_file() itself also calls vfs_file_id_from_sbuf() after having
    created the file.
    
    This is however a problem when using the VFS module fileid, as that is doing
    caching of /etc/mtab and failing to find smb_fname->st.st_ex_dev (all zero in
    this case when creating a new file) in the mtab cache will trigger a mtab reload
    which can be *very* expensive.
    
    Copying many small files to a Samba server in this situation will result in
    abysimal performance.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14237
    
    Pair-Programmed-With: Jeremy Allison <jra at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Jan 17 22:38:14 UTC 2020 on sn-devel-184

commit c9adf47ac5a5aa0dd12572c34b08cc51f15b2e97
Author: Anoop C S <anoopcs at redhat.com>
Date:   Wed Aug 14 18:03:01 2019 +0530

    vfs_glusterfs: Return fake fd from pipe() during open
    
    GlusterFS currently doesn't have an API implementation to set flags on
    open file descriptor. Thus we use pipe() to provide valid file descriptor
    from the system.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14241
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Fri Jan 17 17:14:43 UTC 2020 on sn-devel-184

commit 6c7b722b3fa3d6383a22fb517d3cb5572115c365
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 17 10:19:32 2020 +1300

    fuzz_oLschema2ldif: check multiple possible NULLs
    
    Address sanitizer will object to a theoretically possible NULL dereference
    so we can't ignore these checks in set-up.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Jan 17 14:33:18 UTC 2020 on sn-devel-184

commit 6786ec2c9638f13efed8cba156e174644804a61e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 17 09:59:26 2020 +1300

    fuzzing: check for NULL on ldb_init()
    
    We simply return 0 because failure here is not a problem with the code we
    are actually trying to fuzz. Without this asan is unhappy.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 75367e4b0675047c6b21447473c779547d6b51b6
Author: Günther Deschner <gd at samba.org>
Date:   Thu Jan 16 14:53:19 2020 +0100

    librpc: add clusapi_GroupSetControlCode enum
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Jan 16 21:34:27 UTC 2020 on sn-devel-184

commit ac5b7427022333a312b504cdde9d725676274c93
Author: Günther Deschner <gd at samba.org>
Date:   Thu Jan 16 14:38:56 2020 +0100

    s4-torture: increase various bufsizes to better deal with Windows 2019 clusters
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 83bbc5cc42ee33e93bb583886b09c38bde767570
Author: Günther Deschner <gd at samba.org>
Date:   Thu Jan 16 11:19:52 2020 +0100

    s4-torture: fix copy/paste error in clusapi group test
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit edf21f5e3034b104cfe99e97f62478194d23283e
Author: Günther Deschner <gd at samba.org>
Date:   Mon Jan 13 14:37:40 2020 +0100

    s4-torture: add clusapi GroupSet tests
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 21157c66abb349c97d02a1a104a6e1cfcb577542
Author: Günther Deschner <gd at samba.org>
Date:   Mon Jan 13 18:30:14 2020 +0100

    s4-torture: fix asserts in clusapi_NodeControl tests
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit efe353edf486ee2ab351735a8f927fe607046bb1
Author: Günther Deschner <gd at samba.org>
Date:   Mon Jan 13 16:11:26 2020 +0100

    s4-torture: save cluster version in clusapi test context
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8dca8aaf95bd5fe74c71dc2530a6e57feeee6416
Author: Günther Deschner <gd at samba.org>
Date:   Fri Jan 10 16:44:39 2020 +0100

    librpc: add various new clusapi functions and types
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4bc481c5cb7d772f473171949a3d522788bb7dcf
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jan 16 14:12:02 2020 +1300

    samba-tool gpo: improve UNC parsing
    
    The "UNC doesn't start with \\\\ or //" message was unreachable due to
    a logic error, and an UNC starting with \\ would have been split on
    / if there were enough /s in the string.
    
    The unreachable exception was first noticed by Gerhard Lausser in a
    github pull request (https://github.com/samba-team/samba/pull/123),
    but that patch no longer applies with this more thorough rewrite.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ebced94a8721ffd25386bda452a1857fa92b9899
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:13:17 2020 +0100

    torture: Test smbcontrol close-denied-share
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Jan 15 22:51:14 UTC 2020 on sn-devel-184

commit 5394885167fac40a910613272f10b7077e59f05c
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jan 13 15:19:58 2020 +0100

    smbd: Add close-denied-share message
    
    This is like close-share, but kicks out only active users where share
    access controls are changed such that now access would be denied
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c9850e3d80320a5d13a69194246cce3f09f4ba3e
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jan 13 15:37:25 2020 +0100

    smbd: Move sharename check of conn_force_tdis() into a callback
    
    Next commit will have an additional check
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 733f798074b76ed8b96272a29c8cb91eef7a7118
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 15 12:40:38 2020 +0100

    texpect: Avoid duplicate sys_write()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4fabe1d1072147c609f2e8a2c86da04724564cb2
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 15 12:37:59 2020 +0100

    texpect: Reformat long line
    
    There will be more deps soon
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4371982619d4fb0b784813950055a0f19e0e8667
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 15 12:37:22 2020 +0100

    texpect: Use lib/replace's closefrom()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2198da1b9bf79e86112aeeb8e9653f6a82f69e8d
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Jan 14 17:12:33 2020 +0100

    s3:libsmb: Fix querying all names registered within broadcast area
    
    Wait for additional replies until timeout when '*' is given to nmblookup
    as name.
    
    Introduced by 8da8c36b53cc115f0d446b666fc24fc9423d808e.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=8927
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0fcc2e93192b8737b0a711ed2ca118e4e833f3fe
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 15:44:27 2020 +1300

    fuzz: add nmblib/parse_packet target
    
    We want to ensure that parse_packet() can parse a packet without
    crashing, and that that parsed packet won't cause trouble further down
    the line.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Wed Jan 15 21:24:31 UTC 2020 on sn-devel-184

commit f4bafcca863f1f11b07dfec960495a84184f2317
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 17:33:03 2020 +1300

    fuzz: ldb binary decode/enode
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit da4786003fef39737734e1a5cbf752442f7793b1
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 12:35:54 2020 +1300

    fuzz: add ldb ldif fuzzer
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 13bd82db64be827c3472255531ee79501f07f129
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 12:35:30 2020 +1300

    fuzz: ldb_dn parsing
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 79460b1b9f3452d6d68014b84f4a9dc3988bd916
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Tue Jan 14 14:42:26 2020 +1300

    lib ldb common: Fix memory leak
    
    TALLOC_FREE the ldb_control allocated in ldb_parse_control_from_string
    when none of the cases match.
    
    Credit to OSS-Fuzz
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 6b8a683884950603a690a2e7e3b267c21e458d6b
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Jan 14 15:19:40 2020 +0100

    tests: Test samba-tool user setprimarygroup command
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Jan 15 13:30:53 UTC 2020 on sn-devel-184

commit fd1c905ec3b21f7fcc61f9bc827a56e3a3038381
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Jan 14 15:10:09 2020 +0100

    tests: Test samba-tool user getgroups command
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d73a9d1a8d81bf7d7bc9aeab5198931b2a7fb582
Author: Björn Baumbach <bb at sernet.de>
Date:   Wed Dec 18 11:56:03 2019 +0100

    selftest: create working directory for blackbox test
    
    Required to run test separately.
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a77f758df117638ea22b7589323b71d5f5261bd9
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed May 16 13:00:16 2018 +0200

    samba-tool: implement user getgroups command
    
    samba-tool user getgroups command to list a users group memberships.
    
    Pair-programmed-with: Björn Baumbach <bb at sernet.de>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8403527bbd132ee639fdd3926bf55d15bd8dea56
Author: Björn Baumbach <bb at sernet.de>
Date:   Wed May 16 10:19:16 2018 +0200

    samba-tool: implement user setprimary group command (set primaryGroupID)
    
    Introduce an option to set the primaryGroupID attribute of a user account.
    
    Pair-programmed-with: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d512b27563b32f7bcb35da21781e87473830c906
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Jan 13 16:43:21 2020 +0100

    clitar: use modern DBG macros
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Jan 14 20:42:10 UTC 2020 on sn-devel-184

commit 199f44ff87504b5e323bcccb0b3e7922c328ad38
Author: Björn Jacke <bj at sernet.de>
Date:   Tue Jan 7 12:04:49 2020 +0100

    smbtar: adopt for new tar verbose option
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d2d5007936ba4f48edad61c7613bed07c31da463
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Jan 4 21:47:59 2020 +0100

    smbclient/tar: add verbose mode
    
    A verbose mode got lost with the introduction of libarchive support.
    
    The verbose mode is optional, default is quiet mode.
    
    The output format is close to the verbose output format of POSIX tar
    implementations and should be good parsable.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=11642
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9e67b6b9515d1bc456c9f0f4edd0aea430b6d870
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jan 13 15:23:45 2020 +0100

    smbd: Protect against non-string "close-share" sharenames
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit be0a5ab852a66a041f0d6c6a96abbe296476b13a
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:10:05 2020 +0100

    test3: Fix usage check for test_sharesec.sh
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 46565a049ed7e3ba0ead9b756960e400142db7b0
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:05:00 2020 +0100

    lib: Avoid an unnecessary include
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8100b56b55352983c0965f99c6f8ba515e55a929
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:03:45 2020 +0100

    lib: Remove "msg_ctx" from server_id_watch_send()
    
    Not needed
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4546aff887c3bf9babb663f014d147dc2052a463
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:02:27 2020 +0100

    lib: Use tevent version of timeval_current_ofs()
    
    We have tevent available anyway, use that infrastructure
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 75ddd1d6ab84028a422d4be1c115880fc564c089
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 11:21:01 2020 +0100

    nfs4acl: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dc74b437c2ed245a7baeee633efba37909761d4b
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jan 14 14:36:52 2020 +0100

    docs-xml: 'mangled names = illegal' is the new default
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Jan 14 15:18:02 UTC 2020 on sn-devel-184

commit de768710e1677c591bf1b360a5de1321ad3a4d91
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Jan 13 13:02:29 2020 +0100

    tests/DNS: add MX/SRV record tests with multiple spaces
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13788
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Björn Baumbach <bb at samba.org>
    
    Autobuild-User(master): Björn Baumbach <bb at sernet.de>
    Autobuild-Date(master): Tue Jan 14 11:58:20 UTC 2020 on sn-devel-184

commit af7a0e3371e1ae219239a91cb665097abbd50f3e
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Jan 13 00:21:41 2020 +0100

    samba-tool: fix adding of dns SRV/MX/SOA records
    
    Thanks to Denis Cardon for finding
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13788
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Björn Baumbach <bb at samba.org>

commit 89ed960b1da48ddcc459514871963b87503fd9ad
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Jan 13 12:49:42 2020 +0100

    tests/DNS: \n.COM shouldn't be a valid DNS record
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13788
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Björn Baumbach <bb at samba.org>

commit b07eff31de43adb0cd6eab217ca85cd5ba6f3621
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 16:06:33 2020 +1300

    net_ads_gpo: remove old '#if 0' blocks
    
    I think the dump_gpo() calls do enough, and this code has done nothing
    for a decade.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Mon Jan 13 23:52:26 UTC 2020 on sn-devel-184

commit 7c01a44f18b679709d141b2d05e576ee084039b4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 15:45:45 2020 +1300

    libgpo: parse_gp_ext: do not crash upon no ext_strings
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a18ffe26b3be13e45622172c4ade258cfc8fa783
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jan 6 10:14:11 2020 +0100

    smbd: RIP user_struct
    
    At last, the nail in the coffin. :)
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Jan 13 21:09:01 UTC 2020 on sn-devel-184

commit 5f85090d78c11c9c4ef58954b947a8bc71481e18
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:24:47 2020 +0100

    smbd: use smbXsrv_session_info_lookup() in become_user_without_service()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cdab99ba1e7ef48faeacf7ec45651ce5b48dc5d4
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:21:06 2020 +0100

    smbd: remove using vuser from smbd_smb2_tree_connect()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1d797a839d4f96da649ff13bf8c6c7ea4b52ae44
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:16:38 2020 +0100

    smbd: don't use vuser in make_connection()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 758c42ec5dd3dd8bba7b4f74741dc9b02cfb0d73
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:09:26 2020 +0100

    smbd: remove unused vuser arg from make_connection_smb2()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 893aba4d65b6f2bdcd49ba3618f882fad0d5df49
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:07:23 2020 +0100

    smbd: remove unused vuser arg from make_connection_smb1()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9ef30c75b065876fee05103a4ad1b0d70d2d86c6
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:06:23 2020 +0100

    smbd: use req->session instead of vuser->session in make_connection_smb1()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8be0ca8e19b861d13038769289325537c101072b
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 16:26:03 2020 +0100

    smbd: remove use of user_struct from reply_ulogoffX()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4b89100dc8d7620657fa1e6335d47df97188c102
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 14:47:51 2020 +0100

    smbd: use smbXsrv_session_local_traverse() in id_in_use()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 18b43aeb5747f0982e4296960f23986a5f536960
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 11:42:05 2020 +0100

    smbd: add smbXsrv_session_local_traverse()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d2b5f85d221626ce505143c7c129c41603dcb24a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jan 6 10:12:32 2020 +0100

    smbd: remove enum server_allocated_state magic from get_valid_user_struct()
    
    This has been obsoleted a long time ago by
    a129e271b5385853fb39a8e54b56b508b00a3e41.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c3d22018679c6aa83c4a5ae3e480532a3f5eccca
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jan 6 08:20:14 2020 +0100

    smbd: use get_valid_smbXsrv_session() in invalidate_vuid()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dd9735b1da73b6c27feda32230e3fc843746fd2b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jan 6 08:19:18 2020 +0100

    smbd: add get_valid_smbXsrv_session()
    
    In memory of get_valid_user_struct() and functionally equivalent it only returns
    the session if session setup was successfully completed and
    session->global->auth_session_info is valid.
    
    This function is similar to smbXsrv_session_local_lookup() and it's wrappers,
    but it doesn't implement the state checks of those. get_valid_smbXsrv_session()
    is NOT meant to be called to validate the session wire-id of incoming SMB
    requests, it MUST only be used in later internal processing where the session
    wire-id has already been validated.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a22b503819ce19f8857484bb6c2ee21ce6b75a7f
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 08:07:31 2020 +0100

    smbd: use session->global->auth_session_info in switch_message()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 54d626cc77e33c47912489d234df667d3d394f75
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 18:38:59 2020 +0100

    smbd: remove dependency on session->compat in smbXsrv_session_logoff()
    
    This is not needed anymore because a previous commit changes this to use
    session->global->session_wire_id insteaf of session->compat->vuid, so we're not
    depending on session->compat anymore.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 25524c8e78b0a927bcea5851d7282af0f0a0654e
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 15:20:05 2020 +0100

    smbd: use smbXsrv_session_info_lookup() in api_reply()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c3f890fb1e982603c7f24033fc1e5d73535fbbb8
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 12:15:29 2020 +0100

    smbd: use smbXsrv_session_info_lookup() in api_WWkstaUserLogon()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 46f51912aea157433537af27097a0127c7626085
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 09:47:38 2020 +0100

    smbd: share level security is long gone...
    
    vuid will always be valid as will be vuser.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 57d4689273f01bb458c33ff6577e1ac3f179ece9
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 01:06:45 2020 +0100

    smbd: use smbXsrv_session_info_lookup() in change_to_user_and_service()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e80aca04278e6bfd35744ca852549669cee8a8e2
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 01:06:24 2020 +0100

    smbd: introduce smbXsrv_session_info_lookup()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 96fd0ddd02eae05024102b5ed8dc7fb158ed1785
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 30 10:28:25 2019 +0100

    smbd: remove vuser arg from make_connection_snum()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c1d0a70d19ec03f8a1fd770e53db7a921af1282d
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 30 10:26:26 2019 +0100

    smbd: use session->global->auth_session_info in make_connection_snum()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 61fa0f99768bf3519cafd2c49d0b774bc4c22841
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 14:33:00 2019 +0100

    smbd: remove vuid from struct user_struct
    
    The previous commit removed all users of struct user_struct.vuid.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bcadd7d798e0cc9bb58835ecac1799dfea8a4cb8
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 14:33:00 2019 +0100

    smbd: use session->global->session_wire_id instead of session->compat->vuid
    
    session->compat->vuid is set to session->global->session_wire_id after a
    successful session setup, so both variables will always carry the same value. Cf
    the next commit which removes vuid from user_struct.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5992f8fa93adfcd6fc9e5c0632fc36f02ce271ca
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 14:34:42 2019 +0100

    smbd: pass smbXsrv_session to make_connection_snum()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8aae1ef5c0b9c50f892e01316fdac5dc6504ecbb
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 08:31:45 2019 +0100

    smbd: move homes_snum from struct user_struct to struct smbXsrv_session
    
    No change in behaviour. A first step in removing user_struct.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit aa27bceff194bf1d6665bcb66dd3ba750a59b598
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 08:30:22 2019 +0100

    smbd: add session to struct smb_request
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 15ee379ef11d86670aeea7fa4b8bf740dd259593
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jan 10 15:55:29 2020 -0800

    s3: lib: dbwrap. Cleanup. Add a couple of missing 'return NULL' statements on talloc fail.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 36ea1e188d5ea8d40c47ffc466a494c1160e471c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jan 10 15:52:31 2020 -0800

    s3: lib: dbwrap_ctdb: Ensure value_valid is set true if we find the record in the marshall buffer.
    
    Found by "Christopher O Cowan - Christopher.O.Cowan at ibm.com" <Christopher.O.Cowan at ibm.com>
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit c6d880a115095c336b8b74f45854a99abb1bbb87
Author: Alexander Bokovoy <ab at samba.org>
Date:   Tue Jan 7 19:25:53 2020 +0200

    s3-rpcserver: fix security level check for DsRGetForestTrustInformation
    
    Harmonize _netr_DsRGetForestTrustInformation with source4/ logic which
    didn't change since DCE RPC channel refactoring.
    
    With the current code we return RPC faul as can be seen in the logs:
    
    2019/12/11 17:12:55.463081,  1, pid=20939, effective(1284200000, 1284200000), real(1284200000, 0), class=rpc_parse] ../librpc/ndr/ndr.c:471(ndr_print_function_debug)
           netr_DsRGetForestTrustInformation: struct netr_DsRGetForestTrustInformation
              in: struct netr_DsRGetForestTrustInformation
                  server_name              : *
                      server_name              : '\\some-dc.example.com'
                  trusted_domain_name      : NULL
                  flags                    : 0x00000000 (0)
    [2019/12/11 17:12:55.463122,  4, pid=20939, effective(1284200000, 1284200000), real(1284200000, 0), class=rpc_srv] ../source3/rpc_server/srv_pipe.c:1561(api_rpcTNP)
      api_rpcTNP: fault(5) return.
    
    This is due to this check in processing a request:
            if (!(p->pipe_bound && (p->auth.auth_type != DCERPC_AUTH_TYPE_NONE)
                           && (p->auth.auth_level != DCERPC_AUTH_LEVEL_NONE))) {
                    p->fault_state = DCERPC_FAULT_ACCESS_DENIED;
                    return WERR_ACCESS_DENIED;
            }
    
    and since we get AuthZ response,
    
      Successful AuthZ: [netlogon,ncacn_np] user [EXAMPLE]\[admin] [S-1-5-21-1234567-890123456-500] at [Wed, 11 Dec 2019 17:12:55.461164 UTC]
      Remote host [ipv4:Y.Y.Y.Y:59017] local host [ipv4:X.X.X.X:445]
    [2019/12/11 17:12:55.461584,  4, pid=20939, effective(0, 0), real(0, 0)] ../lib/audit_logging/audit_logging.c:141(audit_log_json)
      JSON Authorization: {"timestamp": "2019-12-11T17:12:55.461491+0000",
       "type": "Authorization", "Authorization": {"version": {"major": 1, "minor": 1},
       "localAddress": "ipv4:X.X.X.X:445", "remoteAddress": "ipv4:Y.Y.Y.Y:59017",
       "serviceDescription": "netlogon", "authType": "ncacn_np",
       "domain": "EXAMPLE", "account": "admin", "sid": "S-1-5-21-1234567-890123456-500",
       "sessionId": "c5a2386f-f2cc-4241-9a9e-d104cf5859d5", "logonServer": "SOME-DC",
       "transportProtection": "SMB", "accountFlags": "0x00000010"}}
    
    this means we are actually getting anonymous DCE/RPC access to netlogon
    on top of authenticated SMB connection. In such case we have exactly
    auth_type set to DCERPC_AUTH_TYPE_NONE and auth_level set to
    DCERPC_AUTH_LEVEL_NONE in the pipe->auth. Thus, returning an error.
    
    Update the code to follow the same security level check as in s4 variant
    of the call.
    
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Mon Jan 13 15:05:28 UTC 2020 on sn-devel-184

commit beb386b584bdff25c714feb7f76d73b65ed072e7
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jan 9 17:40:02 2020 +1300

    fuzz: add a fuzzer for parsing ldb controls
    
    We have had issues here in the past.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sun Jan 12 21:21:30 UTC 2020 on sn-devel-184

commit 16ca385013ae588e8f2b696af03013980926cac1
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jan 9 19:19:56 2020 +1300

    ldb controls: fix typo in bypassoperational message
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1d35962128c93c48cd477601359182b63610ab69
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jan 9 17:01:22 2020 +1300

    fuzz_ldap_decode: do not print to stdout
    
    The fuzzer doesn't care and it slows things down
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e1c6e7d18b446b55634bb4807c6d1a9e9346bd6c
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Dec 13 12:08:47 2019 +1300

    decode_ndr_X_crash: always find pipe in honggfuzz file
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e61ddeef4cc35402b623dbb655ab06058866bfc4
Author: David Disseldorp <ddiss at samba.org>
Date:   Thu Jan 9 16:01:22 2020 +0100

    vfs_ceph: drop support for pre-hammer libcephfs versions
    
    The last Ceph Hammer release (0.94.10) came in Feb 2017, as is no longer
    supported upstream. Drop support for building Samba vfs_ceph against
    version prior to 0.94.0.
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at samba.org>
    
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Sat Jan 11 14:59:36 UTC 2020 on sn-devel-184

commit 888002f99e113bceec5329b0962b4068e0df49ce
Author: David Disseldorp <ddiss at samba.org>
Date:   Thu Jan 9 17:11:39 2020 +0100

    vfs_ceph: drop support for building without statx
    
    libcephfs statx became available with the Kraken (11.2.0) release of
    Ceph in Jan 2017. Versions prior to this are no longer supported
    upstream, so we can drop support within Samba vfs_ceph.
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at samba.org>

commit 748379c66bc3d5131a9346c4c7a973d514b35563
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 14:21:46 2020 -0800

    s3: smbd: msdfs: Change create_msdfs_link() to call SMB_VFS_CREATE_DFS_PATHAT().
    
    No change in the (rather strange) logic.
    
    First step in abstracting MSDFS storage from direct symlink calls.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Jan 10 21:05:25 UTC 2020 on sn-devel-184

commit 54f9da44356b16efca56cc85f2552624bbe81876
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 13:36:08 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in time_audit.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 23df92810b3367b58e8a629d7ee42cf7d167373d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 13:33:23 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in full_audit.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 51fd875661640a7d305b87961b3a0201be350414
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 13:13:29 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in snapper.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 6a46c5f207d1792be048e0233f173286cde0560e
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 13:06:36 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in shadow_copy2.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 235e59481d9ca8e1a522e966399266fde1feb708
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 14:48:33 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in gluster.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 421d26a890f0e09feb94d9b445a51fc14ca24615
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 14:39:43 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in ceph.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit b0b9dd2f8693edc87840f04259e8f31fb55f601c
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 10:13:14 2020 -0800

    s3: VFS: Add SMB_VFS_CREATE_DFS_PATHAT().
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 86a31defbf212d188281d5d963b12eedf1960e8b
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Wed Jan 8 09:39:30 2020 +1300

    ndr basic: Check ndr_token_store return code
    
    Fix for
    
    *** CID 1457529:  Error handling issues  (CHECKED_RETURN)
    /librpc/ndr/ndr_basic.c: 786 in ndr_push_full_ptr()
    ...
    ID 1457529:  Error handling issues  (CHECKED_RETURN)
        Calling "ndr_token_store" without checking return value (as is done
        elsewhere 14 out of 17 times).
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Thu Jan  9 21:49:00 UTC 2020 on sn-devel-184

commit 60b72f589e2a912682516f1d28c84cc713248a0a
Author: David Disseldorp <ddiss at samba.org>
Date:   Thu Jan 9 18:20:39 2020 +0100

    vfs_ceph: assert renameat() fsps match cwd
    
    As discussed with Jeremy in bug 14232, the vfs_ceph.renameat_fn
    implementation currently ignores srcfsp and dstfsp. As a result,
    relative smb_fname_src/smb_fname_dest paths will be processed as
    relative to cwd.
    This is currently a valid assumption, as srcfsp and dstfsp should
    always match conn->cwd_fsp. Add an assert to clarify this.
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Jan  9 20:20:05 UTC 2020 on sn-devel-184

commit 4b95ea37cb3d080f22d5c748364dd3b233b76e50
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 5 14:11:54 2020 +0100

    ntlm_auth: Add type-safety instead of a simple cast
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 91f069cc16bedf7a89c488afed7c6b705aefb03c
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 5 14:11:20 2020 +0100

    ntlm_auth: Add a NULL check
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d78b4a841e2ea7b279ae1f3039216723d24220d4
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 9 14:43:02 2020 +0100

    printing: Avoid EBADF from EPOLL_CTL_DEL
    
    TALLOC_FREE the fde before closing the fd. Otherwise the fde
    destructor tries to remove a nonexisting fd from the epoll set.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1cd20731ab1e10d1b68b649c8588bbccb624c07e
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 9 14:42:43 2020 +0100

    printing: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 17e692a9fa6b1475855aef5e425c4e4d6b1fd3bc
Author: Günther Deschner <gd at samba.org>
Date:   Mon May 9 12:10:22 2016 +0200

    s3-rpcclient: add clusapi_resume_node command.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Jan  9 01:15:34 UTC 2020 on sn-devel-184

commit c9077f16283bdc04068ee669baa99baca8238532
Author: Günther Deschner <gd at samba.org>
Date:   Mon May 9 12:07:47 2016 +0200

    s3-rpcclient: add clusapi_pause_node command.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 94157af26107fc12af5c10bedb4ca5af6eeed73e
Author: Günther Deschner <gd at samba.org>
Date:   Wed Jan 8 17:25:13 2020 +0100

    s3-rpcclient: give slightly better descriptions to clusapi commands
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c433dac59818d580bdccb0d0e0daac71ccf01ee2
Author: Günther Deschner <gd at samba.org>
Date:   Mon Dec 23 16:53:37 2019 +0100

    librpc: pidlify spoolss_EnumPerMachineConnections
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c9bebbcc464e98abeeb008551657532a1831a96f
Author: Günther Deschner <gd at samba.org>
Date:   Tue Jan 7 14:58:15 2020 +0100

    librpc/ndr: provide infrastructure for NDR_SPOOLSS_{PUSH|PULL}_ENUM macros
    
    The new macros allow the same macro convenience for enum functions without
    level discriminator.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1038613878b7c40d4d313697cc0e4e527582afdb
Author: Günther Deschner <gd at samba.org>
Date:   Mon Dec 23 16:50:28 2019 +0100

    librpc: better naming for NDR_SPOOLSS_{PUSH|PULL}_ENUM variants
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 210a8f35b66326263e8466a5b58dffa6e0405c56
Author: Günther Deschner <gd at samba.org>
Date:   Fri Dec 20 13:43:25 2019 +0100

    s4-torture: add test for spoolss_EnumPerMachineConnections
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0a76a7c3c258aa84fab96d03347f8e6e8d067fa8
Author: Günther Deschner <gd at samba.org>
Date:   Sun Sep 22 03:34:56 2019 +0200

    s4-torture: add test for spoolss AddPerMachineConnection
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d642c9a2a8df3002c30d420f3cd34b447a711212
Author: Günther Deschner <gd at samba.org>
Date:   Sun Sep 22 03:34:27 2019 +0200

    s3-rpcclient: add delpermachineconnection command
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d3c2833f1bb5622c438ec1c7b287e53fce83a6c2
Author: Günther Deschner <gd at samba.org>
Date:   Mon Dec 23 12:42:53 2019 +0100

    s3-rpcclient: add addpermachineconnection command
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ce00972afc205af4f93cde5c3e30a07ec222670c
Author: Günther Deschner <gd at samba.org>
Date:   Thu Dec 1 21:32:18 2016 +0100

    s3-rpcclient: add enumpermachineconnections command
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a340aecdd025352bd0cefc1be1aac7526dfe1748
Author: Günther Deschner <gd at samba.org>
Date:   Thu Dec 19 13:49:53 2019 +0100

    s3-rpcclient: properly check and initialize buffers in getdriverpackagepath
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 479cf55397062cf38d16d08e4c48b2d1e26ceb99
Author: Günther Deschner <gd at samba.org>
Date:   Thu Dec 1 21:31:52 2016 +0100

    librpc: add IDL for spoolss_EnumPerMachineConnections
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8ceddba1f3b1aad4c2935e5a1207277f591cace8
Author: Günther Deschner <gd at samba.org>
Date:   Mon Sep 19 17:03:44 2016 +0200

    s3-rpcclient: add cmd_spoolss_get_core_printer_drivers
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e17c8e1b405690d7d38443c8f18c489fc98c1011
Author: Günther Deschner <gd at samba.org>
Date:   Tue Jan 7 15:52:40 2020 +0100

    librpc: fix IDL for spoolss_GetCorePrinterDrivers()
    
    The charset determination makes it more difficult to deal with the real
    REG_MULTI_SZ nature of that element.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ba53e284e689987641f446fb71ddf1f31aee100b
Author: Anoop C S <anoopcs at redhat.com>
Date:   Wed Jan 8 10:24:24 2020 -0800

    s3: lib: dbwrap: Set rec->value_valid to avoid backtrace in `smbstatus`
    
    Following backtrace is observed on executing `smbstatus` with at least
    one SMB client connection established:
    
    PANIC: assert failed at ../../lib/dbwrap/dbwrap.c(82): rec->value_valid
    PANIC (pid 350270): assert failed: rec->value_valid
    BACKTRACE: 15 stack frames:
     #0 /usr/local/lib/libsamba-util.so.0(log_stack_trace+0x1f)
    [0x7fbbd9b32047]
     #1 /usr/local/lib/libsmbconf.so.0(smb_panic_s3+0x74) [0x7fbbd9c1e6ff]
     #2 /usr/local/lib/libsamba-util.so.0(smb_panic+0x28) [0x7fbbd9b32012]
     #3 /usr/local/lib/samba/libdbwrap-
    samba4.so(dbwrap_record_get_value+0x86) [0x7fbbd95800ac]
     #4 /usr/local/lib/samba/libsmbd-base-samba4.so(+0x28f563)
    [0x7fbbd999e563]
     #5 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x7851)
    [0x7fbbd92c7851]
     #6 /usr/local/lib/samba/libsamba-cluster-support-
    samba4.so(ctdbd_traverse+0x4ca) [0x7fbbd92cc641]
     #7 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x73eb)
    [0x7fbbd92c73eb]
     #8 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x7a52)
    [0x7fbbd92c7a52]
     #9 /usr/local/lib/samba/libdbwrap-samba4.so(dbwrap_traverse_read+0x35)
    [0x7fbbd9580de5]
     #10 /usr/local/lib/samba/libsmbd-base-
    samba4.so(smbXsrv_tcon_global_traverse+0xc5) [0x7fbbd999e7d9]
     #11 smbstatus(connections_forall_read+0x114) [0x55d17872b8ee]
     #12 smbstatus(main+0x7b2) [0x55d17872a2f3]
     #13 /lib64/libc.so.6(__libc_start_main+0xf3) [0x7fbbd93a21a3]
     #14 smbstatus(_start+0x2e) [0x55d17872894e]
    Can not dump core: corepath not set up
    
    Assertion on rec->value_valid fails as it is uninitialized in the
    following functions:
    
    traverse_read_callback
    traverse_persistent_callback_read
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Jan  8 23:24:58 UTC 2020 on sn-devel-184

commit 55fbd4c05b477e95920b53b94eda2572e075e6e1
Author: Björn Jacke <bjacke at samba.org>
Date:   Tue Jan 7 10:21:18 2020 +0100

    docs-xml/winbindnssinfo: clarify interaction with idmap_ad etc.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14122
    RN: docs: clarify interaction between winbind nss info and idmap backend
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Jan  8 15:37:46 UTC 2020 on sn-devel-184

commit 4ff13c0174605e45d7d3b26fbb4226d9613b1c98
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 16:08:56 2020 -0700

    vfs_gpfs: Update message for requesting sharemode on stream
    
    User newer debug macro and print full path to affected file.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Jan  8 01:26:46 UTC 2020 on sn-devel-184

commit 5c20ef88ab07f52b7354668873c5d51b58748d12
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:52:14 2020 -0700

    vfs_gpfs: Log failed gpfs_set_share call as error
    
    Any other error code from gpfs_set_share should never happen. Print a
    error message in case this is ever encountered.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 47a2c6707b2f9a9c42673629b82640122c53a609
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:49:39 2020 -0700

    vfs_gpfs: Print message when share modes are disabled in file system
    
    GPFS file systems can be configured without support for share modes. As
    this results in an unique error code, print a message explaining this
    situation and the required config changes.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 191e375d2071de5e44110155230da7e0c4b64d54
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:42:05 2020 -0700

    vfs_gpfs: Explicitly log when share mode has been denied
    
    As this denies access to a file, provide a better error message for
    easier troubleshooting.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a64978e0dc006b9b14541c60379d61e170355468
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:40:07 2020 -0700

    vfs_gpfs: Use early return in sharemode function
    
    This removes one level of indentation.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 03705f4c2fbac6534a925d7511749d4daa378b2e
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:25:22 2020 -0700

    vfs_gpfs: Switch share mode helper function to return int
    
    Follow the convention to return 0 on success and -1 when hitting an
    error.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f03c4485a2e50d496875fb157d5405e2afa7a0f5
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:23:41 2020 -0700

    vfs_gpfs: Remove logging for unsupported file system
    
    The gpfs_set_share API call has been around for a long time and
    definitely all supported GPFS versions have it. Remove the check and
    fallback for old versions without this API.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ef52a907fe80fdb1cd199a21a68126a7bf9b33cb
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:14:17 2020 -0700

    vfs_gpfs: Only clear sharemode on close when sharemode has been taken
    
    This avoids a redundant error message in case the call to acquire the
    sharemode had failed before.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c993480eeff7ff6aee7c4f90f103dcb8d1cd3c6f
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:07:29 2020 -0700

    vfs_gpfs: Log error if clearing of sharemode fails on close
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d912895590170bdd8c720304c664a2259d6a9228
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:00:32 2020 -0700

    vfs_gpfs: Add comment explaining why sharemode is dropped in close call.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 56cf9b15f0a42323d94a407a4de7fae9b039a326
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 13:53:13 2020 -0700

    vfs_gpfs: Remove unncessary check from close function
    
    The fsp has a valid file descriptor when this function is called. No
    need for the additional check.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5d5763ea8ce14f81107462e7f2dff09b6aec1fbc
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:56:07 2020 -0700

    vfs_gpfs: Cleanup debug message file system share mode
    
    Use the newer debug macro and the full variable names.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit eff66787c646e6ce6375929f7d61e9f1b5a0e202
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 11:40:50 2020 -0700

    vfs_gpfs: Cleanup clearing file system share mode
    
    The VFS flock function is called with a zero access_mask to indicate
    that the share mode should be cleared. Adjust the check to directly
    check the access_mask and provide a better message to indicate this
    case.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 79a50e75b24e7c236f7a5422c7676d45bbe93365
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Dec 30 15:39:43 2019 -0700

    vfs_gpfs: Move mapping to sharemode deny to helper function
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 05c54b72c5ad3c8bce18f9a38413032e5224e644
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Dec 30 15:33:03 2019 -0700

    vfs_gpfs: Move mapping from access mask to sharemode allow to helper function
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 208007b86c407e98a796dfae30affade05abe4f7
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Dec 30 15:20:05 2019 -0700

    vfs_gpfs: Remove check for open file in share mode function
    
    The calling code already ensures that the file is open with a valid file
    descriptor.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 00fb46c7f2f678aa601e4def2b53702d6fabf2e5
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:52:48 2020 -0700

    vfs_time_audit: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b306a7361e9d8e2f50f87e8904fc622da799864e
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:51:17 2020 -0700

    vfs_streams_xattr: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 86c2578a55507804f7ccd7d3a9656ceaa90fb302
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:45:06 2020 -0700

    vfs_gpfs: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0d5794f6f92dbfc2400b73ed3a0376a050b28b50
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:41:00 2020 -0700

    vfs_glusterfs: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4667399457fee5b49c931c81cb963c6771f03a8d
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:38:00 2020 -0700

    vfs_full_audit: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 83f59ac00e965a63b81873026e0e8d1c5a72f939
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:09:23 2020 -0700

    vfs_ceph: Rename argument for flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 537d226ed93fdbccf236b7f79bb32802254a2356
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:08:38 2020 -0700

    vfs_catia: Rename argument for flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 974aae418f68e7dac1e9277d8b8df4b41f0cfa8c
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:06:40 2020 -0700

    vfs_not_implemented: Rename argument for flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e8d9a21435ae4266093e355feda1c9bac6f9956e
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:05:57 2020 -0700

    vfs: Rename argument for kernel_flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ad8e6863c3791e50bc80418bc94f4970ed6b0e68
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 11:58:38 2020 -0700

    system: Rename argument for kernel_flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7f75dec865256049e99f7fcf46317cd2d53e95d1
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 22:58:06 2020 +0100

    auth: Simplify struct auth4_context
    
    The fake async code has been pushed down into the 3 users, remove the sync
    callback. Overall it's more lines of code, but the central interface is
    simplified.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Jan  6 23:34:00 UTC 2020 on sn-devel-184

commit add8fd21c08f1225191b0794a92206f5c9248d23
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 17:22:36 2020 +0100

    ntlm_auth: Replace winbind_pw_check() by _send and _recv
    
    This is just fake async, but it avoids one use of a sync function
    pointer in auth4_context
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 066c4eeaa4fc36052eb30c3aeb6d0be4c82ae1ef
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 17:22:36 2020 +0100

    ntlm_auth: Replace local_pw_check() by _send and _recv
    
    This is just fake async, but it avoids one use of a sync function
    pointer in auth4_context
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d3d2e6df9c17202c37e8f6beeb0da2738838181c
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 17:22:36 2020 +0100

    auth3: Replace auth3_check_password() by _send and _recv
    
    This is just fake async, but it avoids one use of a sync function
    pointer in auth4_context
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 004e553174623422e68055f727098b0a711eb1a2
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Jan 3 15:39:34 2020 +0100

    winbindd_pam.c: split winbindd_dual_pam_auth_samlogon
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Jan  6 20:33:55 UTC 2020 on sn-devel-184

commit e4ad0013787a726bfc3d1ba3644b60a6c77ace37
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:24:13 2020 +0100

    auth: Avoid casts in ntlm_check.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Mon Jan  6 03:12:20 UTC 2020 on sn-devel-184

commit e02d24c0875eb04a53c19119148f5203374382e0
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:04:02 2020 +0100

    auth: Check for talloc failure in smb_sess_key_ntlmv2()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4014d91b9a68aa2161421896a82d84e4211e480e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:10:00 2020 +0100

    auth: Slightly simplify smb_pwd_check_ntlmv1()
    
    Do an early return for the failure case
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 2bd941cc12245728b374edc0f71f5938c887a566
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:04:02 2020 +0100

    auth: Check for talloc failure in smb_pwd_check_ntlmv1()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit b78cc8210d3fe75af5236a16841060bbcc553cde
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:10:00 2020 +0100

    auth: Slightly simplify smb_pwd_check_ntlmv2()
    
    Do an early return for the failure case
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 8ec4e4b668d009f9c79ce324dce0d512e16d4cb9
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:04:02 2020 +0100

    auth: Check for talloc failure in smb_pwd_check_ntlmv2()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 59cb155a27f21a55bdc588d38c8080cd29562a7e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 13:47:14 2020 +0100

    auth: Remove the "typedef auth_methods"
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 33d4d482718fca10030b5a569f17cb1a2637fc8a
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 12:42:03 2020 +0100

    winbind: Fix CID 1456624 Uninitialized scalar variable
    
    Coverity does not get that for (rc!=0) gnutls_error_to_ntstatus()
    never returns NT_STATUS_OK
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit d034e839df0898d9db0dc00c1ccf2f113f1787f1
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 15:02:44 2020 +0100

    auth3: Avoid a casts in auth3_check_password()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit bcf944445837e7cdd611dc89fe931575fa771017
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 12:51:04 2020 +0100

    auth3: Simplify auth_get_ntlm_challenge()
    
    Use generate_random_buffer() directly on the talloc'ed buffer
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit b2f070349326bbdb69415524f0a9fa8d54c18049
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 12:41:16 2020 +0100

    auth3: Check for talloc failure
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 7283413a3faf4048a46e77c4ac5ed7a8bb804ff6
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 12:28:49 2020 +0100

    tests: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 03b42aeb811ae7260a9a9e197212767877484a78
Author: Björn Jacke <bj at sernet.de>
Date:   Fri Jan 3 15:29:34 2020 +0100

    python/loadparm: check for AD DC required VFS modules
    
    same as the previous commit, just for python's testparm code
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10560
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Fri Jan  3 22:19:47 UTC 2020 on sn-devel-184

commit 4d4443d1e539c1ce0f7245fbcffbf22df8355b2d
Author: David Disseldorp <ddiss at samba.org>
Date:   Fri Jan 3 14:31:28 2020 +0100

    loadparm: check for AD DC required VFS modules
    
    When Samba is running as a domain controller and the "vfs objects"
    parameter is not set, then the dfs_samba4 and acl_xattr modules are
    automatically enabled.
    However, if the "vfs objects" is defined, then the setting is left
    as-is. This means that attempts to us other VFS modules have the side
    effect of disabling the dfs_samba4 and acl_xattr modules, causing
    unexpected behaviour, which is then blamed on the VFS modules that were
    explicitly defined.
    
    This change ensures that when running as a domain controller, Samba logs
    an error if the required VFS modules are not enabled by an explicit
    "vfs objects" definition.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10560
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Björn Jacke <bjacke at samba.org>

commit 1d0ffcf30e625e7570daa800cf5adf3113c99ce5
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 22 18:20:12 2019 +0100

    smbd: Remove an unused parameter from defer_open()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Fri Jan  3 01:30:24 UTC 2020 on sn-devel-184

commit ed3ee452549f5c25800dd7da1c6dc30a826fe28f
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Dec 16 16:47:38 2019 +0100

    smbd: Avoid a "? True : False"
    
    VALID_STAT() already is a boolean expression
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 5954a0688ae7fa992f8b5a19793b8662ca2794e1
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Dec 7 14:13:04 2019 +0100

    lsasd: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit fd406528b79a2fe4aefe0e04495cdaebe381e3d1
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 1 16:21:12 2019 +0100

    dsdb: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit f53c8fbd7ff2be62c1c488cd56507516d85c670d
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 1 16:10:18 2019 +0100

    audit_log: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 605bb4e9077aca1fa06c1c5beca42ca3b91308f7
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Dec 30 13:56:14 2019 +0100

    ntlm_auth: Fix a DEBUG message
    
    This is not routine auth_generic_prepare
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit ba97f408d81e98863732a8c6bcb59de7a8fedd6b
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 11:15:48 2020 +0100

    lib: Remove an unused variable from security_token_debug()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 9edf15afc219a1a782ec1e4d29909361bbabc744
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Nov 28 14:00:58 2019 +1100

    ctdb-tests: Skip some tests that don't work with IPv6
    
    See the comments added to the tests.
    
    It may be possible to rewrite these so they do something sane for
    IPv6... some other time.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14227
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Fri Jan  3 00:00:55 UTC 2020 on sn-devel-184

commit 693080abe4d8bec96280af5a6aa668251a98ec5d
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Dec 13 11:09:04 2019 +1100

    ctdb-scripts: Strip square brackets when gathering connection info
    
    ss added square brackets around IPv6 addresses in versions > 4.12.0
    via commit aba9c23a6e1cb134840c998df14888dca469a485.  CentOS 7 added
    this feature somewhere mid-release.  So, backward compatibility is
    obviously needed.
    
    As per the comment protocol/protocol_util.c should probably print and
    parse such square brackets.  However, for backward compatibility the
    brackets would have to be stripped in both places in
    update_tickles()...  or added to the ss output when missing.  Best to
    leave this until we have a connection tracking daemon.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14227
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit df5040b186753acf72600042753d312bd5945429
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Jan 1 10:05:07 2020 +0100

    Happy New Year 2020!
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Wed Jan  1 12:04:52 UTC 2020 on sn-devel-184

commit 40ecc2f6f015b86b49326bff4b1cbcab8263f1ac
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 20 16:20:00 2019 +0100

    lib: Fix contending with a READ lock
    
    When contending a WRITE with an existing READ, the contender puts
    himself into the exclusive slot, waiting for the READers to go
    away. If the async lock request is canceled before we got the lock, we
    need to remove ourselves again. This is done in the destructor of the
    g_lock_lock_state. In the successful case, the destructor needs to go
    away.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sun Dec 22 18:57:17 UTC 2019 on sn-devel-184

commit 12638d48a63e90d7d5568d00e39c7041f96675ae
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 22 14:05:17 2019 +0100

    torture3: Add a test that contends with a READ, not a WRITE lock
    
    This walks different code paths in the subsequent locker. And the one
    that we did not test so far is in fact buggy
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bc00eaca703be97709d0706f746930b3a13bb44b
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 22 14:01:07 2019 +0100

    torture3: Parametrize lock4_child()s locktype
    
    We'll call it twice soon
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bf592a1905984042aeb57ddef654229ffb2ee39b
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Dec 21 10:47:37 2019 +0100

    torture3: Introduce "key" helper variable
    
    Call string_term_tdb_data() once instead of three times
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 30f9e1dd596a0dc4894f17b07a7e2e58dcb75c16
Author: awalker <awalker at ixsystems.com>
Date:   Fri Aug 30 15:30:57 2019 -0400

    vfs_zfsacl: fix issue with ACL inheritance in zfsacl
    
    Add parameter zfsacl:map_dacl_protected to address issue preventing Windows Clients
    from disabling inheritance on ACLs. FreeBSD does not currently expose the ACL_PROTECTED
    NFS4.1 flag, but it does expose ACE4_INHERITED_ACE. When the parameter is enabled,
    map the absence of ACE4_INHERITED_ACE to SEC_DESC_DACL_PROTECTED.
    
    See also the discussion at
    
    https://gitlab.com/samba-team/samba/merge_requests/719
    
    Signed-off-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Dec 20 23:24:54 UTC 2019 on sn-devel-184

commit 063fadd322e54ee12689485457ce15a1bb8c0769
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Oct 19 15:37:45 2019 +0200

    vfs_zfsacl: pass config to zfs_get_nt_acl_common()
    
    Not used for now, that comes next.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cd313d0ade15556875ebec060b047a2c6e087b62
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Oct 19 15:36:15 2019 +0200

    vfs_zfsacl: pass nfs4_params to smb_set_nt_acl_nfs4()
    
    Now that we parse nfs4_params in the VFS connect in this module, we can pass it
    to smb_set_nt_acl_nfs4() which avoids having smb_set_nt_acl_nfs4() parse
    it *every time* it's called.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2c7699e7202bef6b8d40c829a4e1515a838f0f6d
Author: awalker <awalker at ixsystems.com>
Date:   Fri Aug 30 15:17:26 2019 -0400

    vfs_zfsacl: add manpage entry for zfsacl:denymissingspecial
    
    Signed-off-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 31d5e945a44e5b8a59933b3516f4235e6057ceb7
Author: awalker <awalker at ixsystems.com>
Date:   Fri Aug 30 15:15:37 2019 -0400

    vfs_zfsacl: load parameters on connect
    
    Convert zfsacl:denymissingspecial so that the parameter loads on connect.
    
    Signed-off-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 33212832b0e61b3c5176b819c34957adeaf6fe5e
Author: David Mulder <dmulder at suse.com>
Date:   Tue Dec 10 13:49:28 2019 -0700

    Convert samba4.base.rw1 test to smb2
    
    Signed-off-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 946beafb621c6a5353a87c40264f53a253249c52
Author: David Mulder <dmulder at suse.com>
Date:   Tue Dec 10 07:47:12 2019 -0700

    Convert samba4.base.*attr tests to smb2
    
    Signed-off-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 670205acab186448e175433225bfebacf3500900
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 10:17:38 2019 +0100

    s3: remove unused session_keystr from struct user_struct
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Fri Dec 20 13:06:20 UTC 2019 on sn-devel-184

commit 5db4a881f6ae74561d0ffd309992896f6681712d
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 22 18:08:56 2019 +0100

    s3: remove unused macro FSP_BELONGS_CONN()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1fa05e5c76e718142326915f8671299217a093df
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 15:24:23 2019 +0100

    s3: simplify create_conn_struct_as_root()
    
    Now that all callers pass in a valid session_info, we can remove handling of
    session_info=NULL. Add an assert(session_info != NULL) just in case... :)
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ee5bf29662ebb164e4be8811c2fcc9bfde88add3
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:58:57 2019 +0100

    pysmbd: add "session_info" arg tp py_smbd_create_file()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7121d475794b951d9bee13d50e6be125f8cc7c2f
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:57:53 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_mkdir()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5cef3a13b880ee058f633e68a9b35996365b5c29
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:56:18 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_get_sys_acl()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a9184a109902bc899920411b7a8893f934c2fd27
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:54:40 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_set_sys_acl()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9b2c415d2c614c8980fc800fa1cf967d69eb7975
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:52:49 2019 +0100

    pysmbd: make "session_info" arg to py_smbd_get_nt_acl() mandatory
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 437af4d07944f201c26cd0ebc4a5622e342d0f4c
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:49:42 2019 +0100

    pysmbd: make "session_info" arg to py_smbd_set_nt_acl() mandatory
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a4f3860da31a42c3905cdd8f7ff7103bf901394d
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:14:45 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_unlink()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit da2a9857d0397d75ac45fc62440ad29bbd0388a1
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:14:07 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_chown()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e6d40e6f9c022c5e571255cd4ff248d5a188b45f
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:13:30 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_set_simple_acl()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9807d69ef4178d4a2c974fed5708ad2d487d0c19
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 15:32:17 2019 +0100

    python/tests: use a system session_info in posixacl.py
    
    Previously posixacl.py passed None as session_info object from
    get_session_info().
    
    That meant that the if/else branch referring to session_info:
    
            if nwrap_winbind_active or session_info:
                 self.assertEquals(posix_acl.acl[1].a_perm, 7)
             else:
                 self.assertEquals(posix_acl.acl[1].a_perm, 6)
    
    must be tweaked to take into account that session info is now either
    
    * a system session_info in which case we must continue to use the if branch in
      the code, or
    
    * a user session_info in which case we must continue to go through the else
      branch
    
    Using
    
      is_user_session = not session_info.security_token.is_system()
    
    in place of just "session_info" does the trick.
    
    Cf the classes SessionedPosixAclMappingTests and
    UnixSessionedPosixAclMappingTests in posixacl.py, those are the ones that
    trigger test execution with a user session.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 927c87d253c42282e8f62038363399f7643fcc76
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:58:32 2019 +0100

    pysmbd: reformat py_smbd_create_file() kwnames
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d80259d819ecdb149ec5d7b9f90eb44eca421320
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:57:20 2019 +0100

    pysmbd: reformat py_smbd_mkdir() kwnames
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9ff378677afbe3298293779c9168769e15f2d021
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:55:54 2019 +0100

    pysmbd: reformat py_smbd_get_sys_acl() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit af1f6e9fd165223505c7c5ec59d94bbc3a41dc55
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:54:04 2019 +0100

    pysmbd: reformat py_smbd_set_sys_acl() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 33f33dc08e3ece38cf20924c0513f0857f8eb6d8
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:21:03 2019 +0100

    pysmbd: reformat py_smbd_get_nt_acl() kwnames
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 59a6c9a4ce01ce1762be6cf0191db4df211d3b06
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:16:52 2019 +0100

    pysmbd: reformat py_smbd_have_posix_acls() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b08c955ae92db8aae57f821c4080d225b6b01944
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 12:59:32 2019 +0100

    pysmbd: reformat py_smbd_unlink() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 399ebb56865202414cd2b5a8f1880d8c3e8a697a
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 12:58:08 2019 +0100

    pysmbd: reformat py_smbd_chown() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9796ebcec4f98d81608e8e3d500745b1dc5f9101
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 12:54:11 2019 +0100

    pysmbd: reformat py_smbd_set_simple_acl() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit cfc0ca73374c8a0c418d6738753a10ab872688f6
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 18:00:26 2019 +0100

    python: move system_session_unix to new auth_util.py
    
    system_session_unix() will be used by many more callers soon.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 459233b96238e319d8b37c471359bdeb4d26aadf
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 14:42:04 2019 +0100

    smbd: pass session_info to create_conn_struct_tos()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d68d8c6538287a8b6a4bbe4b43bf0621440592d8
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 14:41:03 2019 +0100

    s3:rpc_server: pass session_info to get_nt_acl_no_snum()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7fb188c119274a0e84b279ac13a0d696c4884c78
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 14:40:21 2019 +0100

    s3:rpc_server: pass session_info to elog_check_access()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 0e57dbb8466f06c0992dd207acddc8fece47309c
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:19:37 2019 +0100

    smbd: pass session info to create_conn_struct_tos_cwd()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 10fa50a8454f0d7a68f17b26e00e0787325f2dfe
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:53:36 2019 +0100

    smbd: pass session_info to form_junctions()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d6a5aa6d0fdc6f6057a07e8421b71e40d0f845f9
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:51:16 2019 +0100

    smbd: pass session info to count_dfs_links()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 457c91406aae65689db4df12dd236d2359d7eb88
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:31:04 2019 +0100

    s3: pass session_info to enum_msdfs_links()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8d457a83dd126ac46f498c19a15089c2314625e1
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:27:51 2019 +0100

    smbd: pass session_info to junction_to_local_path_tos()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e12a724f0ddf0280b43cbd8107d34fe316585795
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:25:44 2019 +0100

    s3: pass session_info to remove_msdfs_link()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8a0ad072ac0e056ccd34f59f49c6391a50c17c74
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:23:38 2019 +0100

    s3: pass session_info to create_msdfs_link()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8517bb109c886fcc0b281dd715934138075bab1b
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:19:03 2019 +0100

    s3: pass session info to get_referred_path()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a85d257c1ec3a4505f2a4fcbec0f7e1f60dbff91
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 20 10:50:09 2019 +1300

    librpc: Do not access name[-1] trying to push "" into a dnsp_name
    
    This simply matches the behaviour from before e7b1acaddf2ccc7de0301cc67f72187ab450e7b5
    when the logic for a trailing . was added.  This matches what is added in
    the dnsRecord attribute for a name of "." over the dnsserver RPC
    management interface and is based on what Windows does for that name
    in (eg) an MX record.
    
    No a security bug because we use talloc and so name will be just the
    end of the talloc header.
    
    Credit to OSS-Fuzz
    
    Found using the fuzz_ndr_X fuzzer
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Fri Dec 20 11:33:52 UTC 2019 on sn-devel-184

commit 16557e4480a7502d45186854546d502479be156f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 20 11:34:38 2019 +1300

    selftest: Confirm parse of dnsProperty records
    
    This confirms a name of "." will round-trip correctly.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 49197368d4dc6925ce7713d46d8adb93c51da433
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 20 16:33:54 2019 +1300

    WHATSNEW: Celebrate the end of smbdes and the almost-end of in-tree AES
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 30cbc5b90e4951a0ea924c204ff73e15c9750ace
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 19 11:20:30 2019 +1300

    s4-smbd: Also restart prefork children lost to SIGKILL (-9)
    
    Samba 4.10 and later versions have a process restart capability to greatly
    reduce the impact of crashes due to a NULL pointer de-reference or abort().
    
    However SIGKILL was deliberatly omitted.
    
    Sadly this is the most likely case, due to the OOM killer, as raised here:
    
    https://lists.samba.org/archive/samba-technical/2019-November/134529.html
    
    Subsequent discussion (offline) has been to agree that we should restart in
    this case.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14221
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b28d1dca86d33efac9d03b35c5c9804e02ddfb9a
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 16 16:45:38 2019 +0100

    librpc: Add test for ndr_string_length()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Dec 20 09:01:30 UTC 2019 on sn-devel-184

commit f11e207e01c52566c47e350ff240fe95392de0c3
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 16 15:50:17 2019 +0100

    librpc: Fix string length checking in ndr_pull_charset_to_null()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14219
    
    Pair-Programmed-With: Guenther Deschner <gd at samba.org>
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0bd479140c18ab79479ced4f25f366744c3afe18
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Dec 19 16:31:46 2019 +1300

    upgradedns: ensure lmdb lock files linked
    
    Ensure that the '-lock' files for the dns partitions as well as the data
    files are linked when running
      samba_dnsupgrade --dns-backend=BIND9_DLZ
    failure to create these links can cause corruption of the corresponding
    data file.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14199
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f0cebbe4dd0317e2abfcbe252977383e6f37f3bd
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Dec 19 16:31:24 2019 +1300

    test upgradedns: ensure lmdb lock files linked
    
    Add tests to check that the '-lock' files for the dns partitions as well as
    the data files are linked when running
        samba_dnsupgrade --dns-backend=BIND9_DLZ
    failure to create these links can cause corruption of the corresponding
    data file.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14199
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1cf2397226d1ba6d0ff91c58da77b989e30b0420
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in chgdcpass
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Fri Dec 20 07:34:42 UTC 2019 on sn-devel-184

commit 2e5188f520d0d452c7ac211ef7cf2791a320ec1f
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in rodc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 629254ec5b0d60a342f071aa1e67c22822d940a4
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in fl2008r2dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 3518151cb2474ff9000b87e9f08d13290adfadae
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in fl2003dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit bd141ead0dd238834aa13f0801463de8563f1dde
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in fl2000dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit fbcf1ab7087e6d80aa1336aa0cad5c6e7fec62ee
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in vampire_dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit db24892d0e1f5b87dc1b4fb297fde07c919f1dfb
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in promoted_dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 01141d06af858cefdd9a98364122a923cbd312b3
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 13:03:28 2019 +0100

    selftest: make fl2008dc an alias for ad_dc, not ad_dc_ntvfs
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit bba0cafa951eee2cbe3a0e87e486c600a24818db
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 13:03:28 2019 +0100

    selftest: make ad_dc_slowtests an alias for ad_dc, not ad_dc_ntvfs
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8d1206c92094fce98d42d379bcd07275a51fd50c
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 13:32:04 2019 +0100

    selftest: make ad_dc_default an alias for ad_dc, not ad_dc_ntvfs
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ac115db1fcaae7913dd1e62a5558272e235264e6
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 17:43:37 2019 +0100

    selftest: run samba.tests.samba_tool.user against ad_dc_ntvfs:local explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f3f22851ff12014452202c1eba4d96ac8db33645
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 16:52:41 2019 +0100

    selftest: run samba.ldap.referrals against ad_dc_ntvfs explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 0f5b66230d08f27af0ae6f53038271462053ab25
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 16:52:29 2019 +0100

    selftest: run samba4.ldap.dirsync.python against ad_dc_ntvfs explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 88a381389c370b697d194c1217d1609bea854c23
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 16:49:34 2019 +0100

    selftest: run samba.tests.dcerpc.srvsvc against ad_dc_ntvfs explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7974e55024f9d0479a375ffc990293941ff90303
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 16:14:49 2019 +0100

    selftest: run rpc.srvsvc and rpc.mgmt against ad_dc_ntvfs explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 9174968b01565a13b046a14a46e9cb77ea4cb5c2
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 13:39:31 2019 +0100

    selftest: hardcode ad_dc_ntvfs for the rpc.netlogon testsuite
    
    The rpc.netlogon testsuite has a test that verifies LSA over netlogon which is
    only enabled in the ad_dc_ntvfs env.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 2d2809be7b17afd0a6054e93c9e5491a31356a1d
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 13:35:29 2019 +0100

    selftest: make testenv name logic more flexible for the rpc testcases
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit c20179a4f86bbaad75b0f87376257080760c650b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 14:17:50 2019 +0100

    selftest: use ad_dc_ntvfs env instead of ad_dc_default for samba4.ldb.ldaps
    
    ad_dc_default is currently an alias for ad_dc_ntvfs, so this is currently no
    change in behaviour, but this is going to change.
    
    As the ad_dc_ntvfs env specifies "ldap server require strong auth =
    allow_sasl_over_tls" and this is needed for the test, we have to let the test
    use the ad_dc_ntvfs env explicitly.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8b04590e4d8f817ad6d194bb9d622c18734e3011
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 25 11:11:13 2019 +0100

    libsmbclient: If over SMB1 first try to do a posix stat on the file.
    
    Disable in future, if server doesn't support this.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Dec 19 15:44:25 UTC 2019 on sn-devel-184

commit b3e3cb3bbd86a53b48ee009adf811d48dd50dc8b
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 25 11:10:49 2019 +0100

    s3:libsmb: Add a setup_stat_from_stat_ex() function
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0fe9dc5219beaf605da9c7922053f7324507b50e
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 25 11:09:52 2019 +0100

    s3:libsmb: Return a 'struct stat' buffer for SMBC_getatr()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bf9a3a7aa1913238ae2c997ce00369d0dbae3a08
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 25 11:06:57 2019 +0100

    s3:libsmb: Add try_posixinfo to SMBSRV struct. Only enable for SMB1 with UNIX for now.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ea51a426e506bd6456814ecddcb63441859f9d89
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Dec 18 13:27:26 2019 +0100

    s3:libsmb: Generate the inode only based on the path component
    
    Currently we use the full smb url which includes also username and
    password.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dd694bdc643ad294475ddf2dd42b537ffeb7e8dc
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 26 08:21:27 2019 +0100

    s3:script: Try to fix a Perl warning
    
    Scalar value @ENV{"BASH_ENV"} better written as $ENV{"BASH_ENV"} at
    /tmp/samba-testbase/b23/samba-ad-dc-1/source3/script/tests/printing/modprinter.pl
    line 134.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1bfb384018deb2ee5c27dbea9fa2cdd98901fdcc
Author: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Date:   Mon Dec 16 10:28:53 2019 +0100

    source4/utils/oLschema2ldif: include stdint.h before cmocka.h
    
    This fix the following build failure:
    
    In file included from /home/fabrice/buildroot/output/host/opt/ext-toolchain/lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/include/stdint.h:9:0,
                     from /home/fabrice/buildroot/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/inttypes.h:27,
                     from ../../lib/replace/../replace/replace.h:64,
                     from ../../source4/include/includes.h:23,
                     from ../../source4/utils/oLschema2ldif/test.c:25:
    /home/fabrice/buildroot/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27: error: conflicting types for ‘uintptr_t’
     typedef unsigned long int uintptr_t;
                               ^
    In file included from ../../source4/utils/oLschema2ldif/test.c:23:0:
    /home/fabrice/buildroot/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/cmocka.h:132:28: note: previous declaration of ‘uintptr_t’ was here
           typedef unsigned int uintptr_t;
    
    Fixes:
     - http://autobuild.buildroot.org/results/9507739b3d5d51024ee9c60b74c2f85d5004e7e2
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14218
    
    Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Dec 18 16:57:52 UTC 2019 on sn-devel-184

commit f8799bf076d647d73aa749f3864d022a366c3904
Author: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Date:   Sun Dec 15 17:08:24 2019 +0100

    lib/ldb/tests: include stdint.h before cmocka.h
    
    This fix the following build failures:
    
    [2466/3864] Linking bin/default/lib/ldb/ldbmodify
    In file included from /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/include/stdint.h:9:0,
                     from ../../lib/tevent/tevent.h:31,
                     from ../../lib/ldb/include/ldb.h:51,
                     from ../../lib/ldb/tests/test_ldb_dn.c:25:
    /home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27: error: conflicting types for 'uintptr_t'
     typedef unsigned long int uintptr_t;
                               ^
    In file included from ../../lib/ldb/tests/test_ldb_dn.c:23:0:
    /home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/cmocka.h:132:28: note: previous declaration of 'uintptr_t' was here
           typedef unsigned int uintptr_t;
                                ^
    
    In file included from /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/include/stdint.h:9:0,
                     from ../../lib/tevent/tevent.h:31,
                     from ../../lib/ldb/tests/ldb_key_value_test.c:48:
    /home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27: error: conflicting types for 'uintptr_t'
     typedef unsigned long int uintptr_t;
                               ^
    In file included from ../../lib/ldb/tests/ldb_key_value_test.c:43:0:
    /home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/cmocka.h:132:28: note: previous declaration of 'uintptr_t' was here
           typedef unsigned int uintptr_t;
                                ^
    
    Fixes:
     - http://autobuild.buildroot.org/results/9507739b3d5d51024ee9c60b74c2f85d5004e7e2
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14218
    
    Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f0eb1e623f76d3dbd0c22f96cabebd1041c147df
Author: Torsten Fohrer <torsten.fohrer at sbe.de>
Date:   Sun Dec 15 16:58:40 2019 +0100

    Avoiding bad call flags with python 3.8, using METH_NOARGS instead of zero.
    
    (C) SBE network solutions GmbH
    
    Signed-off-by: Torsten Fohrer <torsten.fohrer at sbe.de>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Dec 18 14:33:58 UTC 2019 on sn-devel-184

commit 5fd65edc91b0f56e044428a32676b079aec9377d
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Aug 13 13:15:58 2019 +0200

    samba_kcc: avoid ValueError when local connections are less than 2
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Björn Baumbach <bb at sernet.de>
    Autobuild-Date(master): Wed Dec 18 11:37:53 UTC 2019 on sn-devel-184

commit f8f3b33ea58a03dc3c17b03256530b6990ce9191
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Dec 14 18:35:51 2019 +0100

    lib/replace: prefer <sys/xattr.h> over <attr/xattr.h>
    
    This prevents the following compile error that may happens if "system/filesys.h"
    is included before "system/capability.h" on Ubuntu 16.04:
    
      [1802/4407] Compiling source3/lib/system.c
      In file included from ../../lib/replace/system/filesys.h:112:0,
                       from ../../source3/include/vfs.h:29,
                       from ../../source3/include/smb.h:150,
                       from ../../source3/include/includes.h:284,
                       from ../../source3/lib/system.c:23:
      /usr/include/x86_64-linux-gnu/sys/xattr.h:32:3: error: expected identifier before numeric constant
         XATTR_CREATE = 1, /* set value, fail if attr already exists.  */
         ^
    
    The above error is from compiling a source tree which includes a change that
    adds an include "system/filesys.h" to the top of "source3/include/vfs.h".
    
    "source3/lib/system.c" has the following includes:
    
      #include "includes.h"
      #include "system/syslog.h"
      #include "system/capability.h"
      #include "system/passwd.h"
      #include "system/filesys.h"
      #include "../lib/util/setid.h"
    
    The first include of "includes.h" pulls in "vfs.h" which will pull in
    "system/filesys.h" with the mentioned change. "system/filesys.h" pulls in
    <attr/xattr.h> which has this define
    
      #define XATTR_CREATE  0x1
    
    Later in "source3/lib/system.c" "system/capability.h" is included which includes
    <sys/xattr.h> on Ubuntu 16.04 (not in later versions of glibc). This defines the
    XATTR_* values as an enum:
    
      enum {
        XATTR_CREATE = 1,     /* set value, fail if attr already exists.  */
        XATTR_REPLACE = 2     /* set value, fail if attr does not exist.  */
      };
    
    The previous define of XATTR_CREATE as 1 makes this
    
      enum {
        1 = 1,     /* set value, fail if attr already exists.  */
        2 = 2     /* set value, fail if attr does not exist.  */
      };
    
    which is invalid C. The compiler error diagnostic is a bit confusing, as it
    prints the original enum from the include file.
    
    See also:
    
    <https://bugs.freedesktop.org/show_bug.cgi?id=78741>
    <https://bugs.launchpad.net/ubuntu/+source/attr/+bug/1288091>
    <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756097>
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Björn Baumbach <bb at samba.org>

commit ad9a81c6a933558e8ae5ccbdcb329e9effc82bb0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 15:56:55 2019 +1300

    librpc: Move winstation.idl to the top level and exclude from fuzzing
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Dec 18 08:05:05 UTC 2019 on sn-devel-184

commit 5eac5813cc42ab4f17858e61cc512bace4d3bad2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 15:34:34 2019 +1300

    lib/fuzzing and librpc: Do not generate fuzzers for pointless targets
    
    We need to focus the fuzzing effort on reachable code, and these IDL
    are just historical artifacts, many are entirely [todo] and have
    no samba client nor server.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit bbc4ebbcaf3e602cf11816a24e58f4dc3eed7d8d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 14:48:38 2019 +1300

    lib/fuzzer: Allow coverage build for oss-fuzz
    
    This still does not seem to be enough but it is one step towards a working
    coverage build.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4d9753dfbd8a2d66d86f60aabee627826247aa38
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Wed Dec 18 11:17:51 2019 +1300

    lib ldb: fix use after free
    
    Fix ASAN detected use after free.  No security implications as  the
    talloc_free is followed immediately by the print statement and the value
    printed is an integer
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0e651b4508d44e4343c83e1c157d919150aee489
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 12:19:37 2019 +1300

    librpc: Fix manually written printer for drsuapi_DsAttributeValue
    
    Credit to OSS-Fuzz
    
    Found using the ndr_fuzz_X target.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 5ccb5e23c96a6555e03fac66a382780df56bcfe6
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 12:20:35 2019 +1300

    sefltest: Demonstrate crash in manually written printer for drsuapi_DsAttributeValue
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 5a989d6670911e16aed9061a8c6a74676f4c8a8e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 12:01:01 2019 +1300

    lib/fuzzing: Allow load of fuzz inputs as files on the command line
    
    This is easier to put under gdb.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 66d12eb98aba10948f829d08b4144969ead5ddbb
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 22:41:10 2019 +1300

    lib/fuzzing: Initialise st buffer in fuzz_ndr_X
    
    An NDR pull of a function will fill in either the in. or out.
    elements of this structure, but never both.
    
    However, some structures have size_is() in the out. that reference
    the in. elements.  This is the reason for the --context-file option
    in ndrdump.
    
    We have a special handler in the fuzzing case embedded in the
    pidl-generated output to cope with this, by filling in pointers
    for elements declared [ref,in] but it relies on the in-side
    (at least) of the buffer being zeroed.
    
    So zero the buffer before we start.  Sadly this means things
    like valgrind can not find a use of uninitialised data, but that
    is a price we have to pay.
    
    Credit to OSS-Fuzz
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 1141fbe9842c57fca7ee1175665638a0c1f5a181
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Dec 11 16:19:59 2019 +0100

    smbd: Convert share_mode_data->num_share_modes into a boolean8
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Dec 18 00:05:13 UTC 2019 on sn-devel-184

commit 4a60e577db51b0ee5b450d643872463d6939ccee
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Dec 11 10:02:54 2019 +0100

    smbd: Don't store "num_share_modes" in locking.tdb
    
    With the last commit we don't store the share mode entry count
    anymore. With this commit we go one step further and avoid storing
    it. If there's valid record in locking.tdb, there is a corresponding
    record in share_entries.tdb, so there's no point storing that once
    more explicitly.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9734bad37b8bc4b2815f2bff4c0f48d33fb76c4d
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 18:15:40 2019 +0100

    smbd: Use share_mode_data->num_share_modes as a boolean
    
    This is a micro-commit showing that we don't actually need
    share_mode_data->num_share_modes as a number *counting* the share mode
    entries in share_entries.tdb anymore. Instead, we are only using it as
    an indication for share_mode_lock_destructor() to see whether share
    entries are around or not, i.e. whether it's worth keeping or deleting
    the record in locking.tdb.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 42ce74994e98dda95c32d3fcbd66d825f6d84519
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 17 14:23:16 2019 +0100

    smbd: Avoid a direct access to share_mode_data->num_share_modes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 15977f5df85980ff0adbb372e4a4f0d51dde39dc
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 17 14:20:48 2019 +0100

    smbd: Introduce share_mode_have_entries()
    
    This hides a use of share_mode_data->num_share_modes in
    share_mode_lock.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0df06f51ffbc200b0525e175e7ac58795fd93bab
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 14:41:57 2019 +0100

    smbd: Avoid a reference to share_mode_data->num_share_modes
    
    share_mode_data->num_share_modes will go away soon, count the values
    directly while walking the array.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5a2fa45741db6d157705f81a8830907e34f07120
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 10:39:12 2019 +0100

    smbd: Avoid a reference to share_mode_data->num_share_modes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 21eff9d18d23ddc232a566eca51a6f32e30f0c11
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 10:36:21 2019 +0100

    smbd: Pass num_share_modes to share_mode_entry_do() callback
    
    mark_share_mode_disconnected_fn() will need this, the information is
    easily available and should not hurt the other callers.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3e5f1be8eace95cffa9d7e4cfd55eedca9ce2ceb
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 15:46:20 2019 +0100

    net: Use share_mode_count_entries()
    
    Avoid a reference to share_mode_data->num_share_modes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 28d9c418605356db65e90b1386d890308f3ab41f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 15:45:22 2019 +0100

    smbd: Add share_mode_count_entries()
    
    In order to not write the share mode on every open/close, we need to get rid of
    share_mode_data->num_share_modes. "net tdb" needs this information precisely
    though, and it's pretty cheap to calculate.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 54293f92cd83efc3a5a78fc29a85643921da9d32
Author: David Disseldorp <ddiss at samba.org>
Date:   Thu Dec 12 22:14:50 2019 +0100

    vfs_ceph_snapshots: fix root relative path handling
    
    For file paths relative to root, ceph_snap_get_parent_path() may return
    an empty parent dir string, in which case the CephFS snashot path should
    be ".snap".
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14216
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fca2d3e0d1fa5af59e7b729f7c1d126f7b81e149
Author: Anoop C S <anoopcs at redhat.com>
Date:   Tue Nov 12 19:58:43 2019 +0530

    s3: VFS: glusterfs: Reset nlinks for symlink entries during readdir
    
    On receiving an already initialized stat_ex buffer for readdir() call we
    invoke readdirplus() GlusterFS API, an optimized variant of readdir(),
    which then returns stat information along with dir entry result. But for
    symlink entries we don't know if link or target info is needed. In that
    case it is better to leave this decision back to caller by resetting
    nlinks value inside stat information to make it invalid.
    
    This was also preventing us from displaying msdfs link as directories
    inside the share.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14182
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Günther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Dec 17 21:53:07 UTC 2019 on sn-devel-184

commit 2241ce8e86f35f9bcfd4567aeb8e8a00cb53f7d7
Author: Simo Sorce <idra at samba.org>
Date:   Mon Dec 16 16:23:41 2019 -0500

    mit-kdb: Fix license on header file
    
    Signed-off-by: Simo Sorce <idra at samba.org>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Dec 17 09:24:56 UTC 2019 on sn-devel-184

commit 5d34c8874d6732ffb95458b79b742664744ef605
Author: Günther Deschner <gd at samba.org>
Date:   Fri Aug 26 15:39:56 2016 +0200

    s3-rpc_server: always print the full PDU.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 97ad50544aaecd07b4a8f39cd329ed484aa38d6e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 14:40:03 2019 +0100

    smbd: Use explicit share_mode_wakeup_waiters()
    
    We don't need to unparse the locking.tdb record, we just need to wake
    up waiters when removing an oplock
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Dec 16 20:27:59 UTC 2019 on sn-devel-184

commit 1c188c3716a76a290e9e7f529ead782bea936690
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 14:40:03 2019 +0100

    smbd: Use explicit share_mode_wakeup_waiters()
    
    We don't need to unparse the locking.tdb record, we just need to wake
    up waiters when downgrading a lease
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6abcc83366f5f3203e9454b444c7d0ada7fed41e
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 18:55:39 2019 +0100

    smbd: Explicitly state when modifying share_mode_data
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fe7f241225db97d02a060118a342c824ab51e471
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 16:31:35 2019 +0100

    torture4: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 810fd90a6fb3cd95f0025321d080aad04afa994d
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 16:06:43 2019 +0100

    smbd: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f42e089a6efa36adc0d835cb51a1a612b40fa1c9
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 16:05:05 2019 +0100

    smbd: Avoid casts in open_directory()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit af2d54bfce8e389473cdb546155dc58d547011f9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Dec 13 11:48:05 2019 -0800

    s3: smbd: msdfs: Factor out the code to create a msdfs:referral,list into a separate function.
    
    This will allow it to be called from other places once the get/set_msdfs
    calls are moved into being first class VFS functions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Mon Dec 16 15:32:08 UTC 2019 on sn-devel-184

commit cc1ec0a9f135ec32c05ae04d0b3bd47fdef5d47d
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Dec 13 09:52:31 2019 -0800

    s3: smbd: cleanup. Change 'int referral_count' -> 'size_t referral_count' in struct junction_map.
    
    This is a non-negative count. Fix remaing code to not mix int and size_t.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2048ff3adc4dbff659dfb5d747f0cb93baad06ee
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Dec 13 09:39:55 2019 -0800

    s3: smbd: msdfs: Cleanup, don't mix int and size_t types for a count variable.
    
    Add integer wrap check.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 48ed60d7fd0b567c2450020b8ccaa2c6ff8913e3
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 12 10:46:21 2019 +0100

    lib/replace: work around an API conflict between ncurses and XFS xattr API
    
    Compile error:
    
      [4530/4693] Compiling source3/utils/regedit_list.c
      In file included from ../../source3/utils/regedit_list.h:24,
                       from ../../source3/utils/regedit_list.c:20:
      /usr/include/curses.h:611:28: error: conflicting types for ‘attr_get’
        611 | extern NCURSES_EXPORT(int) attr_get (attr_t *, NCURSES_PAIRS_T *, void *); /* generated */
            |                            ^~~~~~~~
      compilation terminated due to -Wfatal-errors.
    
    Both ncurses and XFS xattr API provide a get_attr() function. As a workaround
    avoid including <sys|attr/attributes.h> if <attr|sys/xattr.h> is present.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Dec 12 20:22:51 UTC 2019 on sn-devel-184

commit 82aff583b7f7e018ad4a1db92dc635df8e5ebe7b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 12:45:42 2019 +1300

    libndr: Return enum ndr_err_code from ndr_{pull,push}_steal_switch_value()
    
    This breaks the ABI so we merge this into the unreleased libndr-1.0.0.
    
    The advantage of the new functions is there (except for print, which
    is unchanged) is an error raised when the token is not found, so
    we can be confident in the changes to the token behaviour.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Dec 12 03:56:23 UTC 2019 on sn-devel-184

commit d30c377d8c4e8a83b2722b771aa72d219eb69b46
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 27 15:20:32 2019 +1300

    librpc/ndr: Remove ndr_{push,pull}_get_switch_value()
    
    By removing this we know we do not need to worry about this list
    growing without bounds.  We merge this into the recently created but
    not yet released ABI 1.0.0
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a44717394df9dc14a87eb2b9b8d23e2532e6f4c9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 27 16:36:04 2019 +1300

    librpc: Remove last callers of ndr_push_get_switch_value()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit b880bda589aa136bb954a757f25f8763b74aefd4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 26 18:35:36 2019 +1300

    librpc: Remove last callers of ndr_pull_get_switch_value()
    
    By removing this we know we do not need to worry about this list
    growing without bounds.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 92a7c5a7262cb78fb6307e9168a540154cbe2f71
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 19 17:38:50 2019 +1300

    librpc: Do not follow a NULL pointer when calculating the size of a union
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 456cdb7fa35f2b5778c7a5c852acc6180cbe03b4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 15 20:04:41 2019 +1300

    pidl: Mismatch between set and get of relative base pointers
    
    The set was within the switch, the get was before the switch.
    
    The difference is shown when there is an empty default element.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 362d70ff2fb6fb6265fce03da6b09dd4756dc604
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 19 16:58:57 2019 +1300

    librpc: Do not follow a NULL pointer when calculating the size of a structure
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 5eb560d25e9104dc02477a6bf819d0c37e8afb86
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 15 20:04:41 2019 +1300

    pidl: Mismatch between set and get of relative base pointers
    
    The set was within the switch, the get was before the switch.
    
    The difference is shown when there is an empty default element.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e08461b2845183224b9775b54be4acaaba705ecd
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 12:02:03 2019 +1300

    pidl: Add and use ndr_print_steal_switch_value(), removing ndr_print_get_switch_value()
    
    This avoids really long token lists for switch values
    that will not be needed past this point.
    
    The function name is changed to clarify what exactly is being
    done here, and the old function is removed to ensure it is
    not being used anywhere else.
    
    Merge the removal of ndr_print_get_switch_value into
    just-tagged librpc/ABI/ndr-1.0.0.sigs as this
    has not been put into any release yet.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e1a15710a4c1c96c9d9fdf932357749cc5ed4d7a
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 27 16:01:02 2019 +1300

    librpc/ndr: Add ndr_push_steal_switch_value()
    
    This will allow generated code to instead push and pop union values onto the
    switch_list stack, which is more memory efficient than creating a single large
    list to be scannned and eventually discarded.
    
    Merge into unreleased ABI 1.0.0
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 603f23b19c90d6a1be4ac50e5984e6f9c8a63ba2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 15 16:59:12 2019 +1300

    pidl: Generate and consume the switch level token for both NDR_SCALARS and NDR_BUFFERS in ndr_pull()
    
    This means what was previously a list becomes a single variable that
    could be passed as a function paraemter, but this is avoided for now
    because it would change the ABI and be more intrusive.
    
    Before this, a client could cause a NDR token containing the swith level
    to be allocated for each and every element in the array that they
    promised they were sending (without having to actually send them).
    
    Found by Michael Hanselmann using Honggfuzz and an fuzzer for Samba's
    NDR layer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f7bcf227f7bac1817ecabbe3dccaebdd9a81a2f9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 15:30:55 2019 +1300

    librpc: Set the switch_value before NDR_BUFFERS to prepare for new libndr behaviour
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a22a22e4a8a2efad86833d21958bc6abf57f74e7
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sun Nov 17 19:32:50 2019 +1300

    negoex: Set the switch_value before NDR_BUFFERS to prepare for new libndr behaviour
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit ae43093b79ad59a090e72c22249a65b54a2a6a97
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 16 09:37:30 2019 +1300

    s4-libcli/rap: Set the switch_value before NDR_BUFFERS to prepare for new libndr behaviour
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 7a0ed44b0e65e742a778915d493e17f04c43b2ef
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 16 07:59:58 2019 +1300

    ndr: Restrict size of ndr_token lists to avoid memory abuse by malicious clients
    
    This is designed to stop a very large number of tokens from being stored for
    arrays of structures containing relative pointers in particular.
    
    This was one part of the minimum patch for CVE-2019-14908 before
    being downgraded as not a security-release worthy issue.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4501663f6e523a988f4edd287a1374cab3c9a127
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 10:38:01 2019 +1300

    libndr: Do not overwrite token list with NULL on allocation failure
    
    This was one part of the minimum patch for CVE-2019-14908 before
    being downgraded as not a security-release worthy issue.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit bcffdc9a895c8aa572819ddd4fca451038990402
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 16:56:44 2019 +1300

    selftest: Add test for ndr_size_struct() faulting on a NULL pointer
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f56fa3bb6a0e2275114a6f4dd27640af1e15018b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 16:49:13 2019 +1300

    selftest: Add test for ndr_size_union() faulting on a NULL pointer
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 6ef50145494125c8e67c034ddb1816a567524984
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 16:02:31 2019 +1300

    selftest: Add example xattr_NTACL packets to demonstrate switch/union behaviour
    
    This is a good example with both buffers and scalars in the union.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit cf83eec565f2879c06874cdd390ab3a043c132f8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 14:46:32 2019 +1300

    selftest: Add test for structure with NDR_BUFFERS only in a union
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 3f69c6b1328cda318f78620d19616411705b7034
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Mar 7 11:35:07 2019 +0100

    selftest: Do not force the endpoint for fsrvp tests
    
    The test suite will bind to the srvsvc interface, let it find the
    correct endpoint through the endpoint mapper.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Dec 12 02:00:19 UTC 2019 on sn-devel-184

commit 4a608b281cf945b0550d1bf81971f690a5e7ed8a
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Nov 4 18:39:10 2019 +0100

    s4:torture/rpc: Fix torture comment in mdssvc.c
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e24ce0023fa00a33d22f5f475e9280a8cad612c3
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Fri Sep 6 15:16:01 2019 +0200

    pidl:NDR/Server: Allow to define endpoint server shutdown functions
    
    The next commits will register legacy api_struct when the endpoint server
    is initialized. This commit adds a shutdown function which will be used
    to unregister the legacy api_struct.
    
    The shutdown function will be also used to replace the rpc_srv_callbacks
    struct shutdown member used, for example, by the spoolss service to
    cleanup before exiting.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 79af978c815e6ad94797742c8755f4fe8142160e
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 1 16:59:07 2019 +0200

    librpc:core: Add a function to reinitialize the dcesrv_context
    
    Clears all registered endpoints and interfaces, association groups and
    broken connections.
    
    To be used by S3 forked daemons.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 90eb485cf9d8eaecfab31044e52e8f41b3a51452
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Fri Sep 6 14:38:29 2019 +0200

    librpc:core: Add public functions to initialize endpoint servers
    
    The dcesrv_init_registered_ep_servers() will be used by the S3 server to
    initialize all registered endpoint servers (for embedded services), and
    the dcesrv_init_ep_server() function will be used by the external
    daemons to initialize the required ones.
    
    As serveral S3 services may require to initialize another one before
    itself (svcctl and eventlog for example require winreg) a boolean flag is
    added to track the initialization status.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 39dfc5c82b2345f2eee7d14f6f2cc3ee8b2aef3d
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 5 18:54:02 2019 +0100

    librpc:core: Split dcesrv context init and endpoint servers init
    
    The S4 server will initialize the endpoint servers specified in smb.conf,
    but the S3 server need to initialize all registered endpoint servers (the
    embedded ones).
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fee5c6a4247aeac71318186bbff7708d25de5912
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Dec 2 11:20:31 2019 +1300

    librpc/idl/dnsserver.idl: Ensure DnsProperty id matches what is pulled from the stored buffer
    
    There are two concerns here, assuming the attacker can place arbitary values
    in a dnsProperty attribute over LDAP (eg is a DNS administrator).
    
    This comes from the fact that id is used as the switch value at the C layer
    but at the NDR layer the wDataLength value is considered first.
    
    One concern is that a pull/push round-trip could include server memory:
    
     The previous switch_is() behaviour could store the server memory back
     into the attribute.
    
     However this pattern of pull/push only happens in ndrdump and fuzzing tools, as
     dnsserver_db_do_reset_dword() operates only on the uint32/bitmap union
     arms, and fully initialises those.
    
    The other is that a pull of the attacker-supplied value could
    cause the server to expose memory.
    
     This would be over the network via DNS or the RPC dnsserver protocols.
     However at all times the ndr_pull_struct_blob is passed zeroed memory.
    
    The final concern (which fuzz_ndr_X found) is that in the ndr_size_dnsPropertyData()
    the union descriminent is only id.
    
     This has no impact as only zeroed memory is used so there will be a
     zero value in all scalars, including data->d_ns_servers.AddrArray.
    
     Therefore the server will not crash processing the attacker-supplied blob
    
    [MS-DNSP] 2.3.2.1 dnsProperty has no mention of this special behaviour.
    https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dnsp/445c7843-e4a1-4222-8c0f-630c230a4c80
    
    This was known as CVE-2019-14908 before being triaged back to a normal bug.
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X fuzzer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14206
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit ee4617ec5f4017e7ee3bbc29102054e7b64f3e3a
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Mon Dec 9 09:19:47 2019 +1300

    librpc dnsp test: Ensure length matches union selector
    
    Ensure that a dnsp_DnsProperty is rejected if the length data does not not
    correspond to the length indicated by the union id.  It was possible for
    the union to be referencing memory past the end of the structure.
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X fuzzer.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14206
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 049f0c3870179aa4977f5d9c49e18566f166412e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 12 07:35:55 2019 +1300

    lib/krb5_wrap: Remove unused smb_krb5_get_allowed_weak_crypto()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Wed Dec 11 22:18:47 UTC 2019 on sn-devel-184

commit 545711ffeaaa12689a4e9a14f23ba5a4afef2180
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 11 14:09:25 2019 +1300

    lib/fuzzing: Fix argument order to ldb_filter_from_tree in fuzz_ldb_parse_tree
    
    Found by the oss-fuzz CI tooling.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Dec 11 04:21:28 UTC 2019 on sn-devel-184

commit e6fc8e79aee289f79b5fba7b7c2974d476702b1e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 11 13:03:43 2019 +1300

    lib/fuzzing: Split up automatically build fuzzers into TYPE_{IN,OUT,STRUCT}
    
    The advise is that a fuzz target should be as small as possible
    so we split this up.  Splitting up by function would build too
    many fuzzers, but this should help a little.
    
    See for example:
    https://github.com/google/fuzzing/blob/master/docs/good-fuzz-target.md#large-apis
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit 6e5aefc2d3095f0fb6535e6ab3a4ec12b898794f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 11 12:48:24 2019 +1300

    lib/fuzzing: Ensure mem_ctx is freed each time fuzz_ldb_parse_tree is run
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit 0be0c044b6769da39b0feb8d7b655a2760413086
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 22:52:06 2019 +1300

    autobuild: extend autobuild with samba-fuzz job to build the fuzzers in AFL mode using oss-fuzz scripts
    
    This helps ensure the build_samba.sh file keeps working and the fuzzers build
    (because they are excluded from the main build).
    
    This is not in the default autobuild because it uses too much
    space on sn-devel (4GB).
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit d349d344f8872e25526fdb76a38523477baa4366
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Dec 10 10:59:49 2019 +1300

    autobuild.py: Avoid listing jobs twice
    
    We use the tasks table instead, to avoid the issue shown in the previous commit.
    
    Now we just have to keep .gitlab-ci.yml and the tasks table in sync.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit df38d511045311b9b7c68c94aad800c69088e331
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Dec 10 10:58:47 2019 +1300

    autobuild.py: Add missing samba-simpleserver job
    
    This was missed when the job was split out in f0e8dd1a08698884209873bb84002d7b34db016c.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit de02a553999903058dd69ea8aaff2e248a6ad55c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Dec 10 10:47:12 2019 +1300

    .gitlab-ci.yml: Align tasks with "pages" dependency to get comprehensive code coverage
    
    These two lists can get out of skew very easily.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit fbd97ee822337534006ffcd14e08c8068e178266
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 10:56:44 2019 +0100

    smbd: Fix a leases.tdb record leak
    
    If we set e->stale=true in the share_mode_forall_entries() callback,
    the share entry will be removed directly. Thus further down
    share_mode_forall_leases() won't find anything anymore. Only find
    possibly still connected entries in the first walk, and then remove
    the share_entries.tdb record straight away after the leases and
    brlocks have been removed.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Dec 10 21:57:05 UTC 2019 on sn-devel-184

commit 7535359602e8b33e38ef1e0e38dc070773a39ea8
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 11:48:07 2019 +0100

    torture: Run durable_v2_reconnect_delay_msec with leases
    
    This will show a leases.tdb record leak. If you SIGSTOP the smbtorture
    process while it's in the 10-second wait, you will find locking.tdb
    and share_entries.tdb empty after the scavenger has cleaned up. But
    there will be an entry in leases.tdb left.
    
    I have no clue how to test this properly, or how to have a reasonably
    cheap assert in smbd during normal operations. The problem is that
    this leak can't really be distinguished from a "normal" leak that a
    crashed smbd would leave behind. Possibly we need a background job
    walking leases.tdb to clean this up properly.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 79b2ee8dc2382354750601ee3d57912442c09817
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 11:31:22 2019 +0100

    torture4: Use generate_random_u64() instead of random()
    
    random() returns an int, which is not necessarily a uint64
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 20b9cae63d5a5881cc6100a2533fab683cc307aa
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Dec 10 18:06:29 2019 +0100

    lib:crypto: Build intel aes-ni only if GnuTLS doesn't provide AES CMAC
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Dec 10 20:30:57 UTC 2019 on sn-devel-184

commit 6713617724bfe4cba633f0e61052a703c4ca9f3e
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Dec 10 18:03:57 2019 +0100

    lib:crypto: Only build AES code if we need AES CMAC
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 337c51c9f503adef58c9b875bfb4f522cfb7d9ae
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Dec 10 18:01:43 2019 +0100

    lib:crypto: Remove our implementation of AES GCM
    
    We require GnuTLS >= 3.4.7 which provides AES GCM.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c3250ff7ab66fb45c9b5a66c7e3a9453fb22777b
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Dec 10 17:52:36 2019 +0100

    lib:crypto: Remove our implementation of AES CCM
    
    We require GnuTLS >= 3.4.7 which provides AES CCM.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit bc0c876a9ebbec1a31856a9e7147a481c69ba434
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 5 11:37:05 2019 +1300

    pidl:NDR/Parser: only include structs in ndr_interface_public_struct
    
    We only have ndrdump and the fuzzers set up for structures, not BITMAPS,
    ENUMS etc.
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Tue Dec 10 17:45:46 UTC 2019 on sn-devel-184

commit 238d08b07d0178940c28839518c9f1afbc605378
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 11:00:57 2019 +1300

    selftest: Confirm that ndrdump struct mode is not available for enums
    
    These are not passed by pointer so the structure dump system does not work
    for these.  It is best to dump the containing structure instead.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 73f436260620a97e307110ec45311e9e5dd321ce
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 11:12:48 2019 +0100

    CVE-2019-14870: mit-kdc: enforce delegation_not_allowed flag
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(master): Tue Dec 10 10:44:01 UTC 2019 on sn-devel-184

commit 84de46f5347288a3683ba083f529137efa8028e9
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Oct 28 02:54:09 2019 +0200

    CVE-2019-14870: heimdal: enforce delegation_not_allowed in S4U2Self
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>

commit df72956adee55fbe60d49bd9d58d9df53d4f2198
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Oct 30 15:59:16 2019 +0100

    CVE-2019-14870: heimdal: add S4U test for delegation_not_allowed
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>

commit aa17d5fcaf7fe0f628856cda902cbd8be7e6ecb4
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sun Oct 27 14:02:00 2019 +0200

    samba-tool: add user-sensitive command to set not-delegated flag
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>

commit aaf037dfb3454cea048489b23ad96c415096dddf
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Oct 30 11:50:57 2019 +1300

    CVE-2019-14861: Test to demonstrate the bug
    
    This test does not fail every time, but when it does it casues a segfault which
    takes out the rpc_server master process, as this hosts the dnsserver pipe.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit defb23732515e3c638d0081f5e4043fbb35d303c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 29 14:15:36 2019 +1300

    CVE-2019-14861: s4-rpc/dnsserver: Avoid crash in ldb_qsort() via dcesrv_DnssrvEnumRecords)
    
    dns_name_compare() had logic to put @ and the top record in the tree being
    enumerated first, but if a domain had both then this would break the
    older qsort() implementation in ldb_qsort() and cause a read of memory
    before the base pointer.
    
    By removing this special case (not required as the base pointer
    is already seperatly located, no matter were it is in the
    returned records) the crash is avoided.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 4333e41c2243781ae788db8ee7fa6897b0a7e334
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Oct 21 12:12:10 2019 +1300

    CVE-2019-14861: s4-rpc_server: Remove special case for @ in dns_build_tree()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit a25a2e4513e48d0408b1f5e78ada0b3569d3426d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 29 17:25:28 2019 +1300

    CVE-2019-14861: s4-rpc/dnsserver: Confirm sort behaviour in dcesrv_DnssrvEnumRecords
    
    The sort behaviour for child records is not correct in Samba so
    we add a flapping entry.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 8b06cabc7d735f8a780b832ddb7d5ab2989e661f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Dec 7 17:35:26 2019 +1300

    bootstrap: Add chrpath as a required package
    
    This is used to test build.sh, part of the oss-fuzz integration, and so also that we
    correctly build our fuzzers.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Dec 10 09:15:43 UTC 2019 on sn-devel-184

commit 96184c10b8d048a67e57b7b838a1da2a1588455c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Dec 7 13:37:10 2019 +1300

    build: Skip build of python bindings when in fuzzing mode
    
    This will just save a bit of time and space.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 4c8388fb19865c7e0aa6facf43b6cbd1906a6b2c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sun Dec 8 07:45:58 2019 +1300

    lib/fuzzing Truncate the original files after RUNPATH manipulation in build.sh
    
    This saves space on the rackspace runners in particular.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 5e5d18c5b1e710a747ede56efe10792957f11552
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sun Dec 8 07:44:45 2019 +1300

    lib/fuzzing Add comments to explain RUNPATH manipulation in build.sh
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 5bb9ecdf15febb492bf9b65f5811ca0b59fefec8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Dec 7 13:01:58 2019 +1300

    lib/fuzzing: Support an oss-fuzz build with either address or undefined behaviour sanitizers
    
    Add handler for $SANITIZER in build.sh
    
    This allows a build with the undefined behaviour sanitizer.
    
    Otherwise we fail the oss-fuzz CI because the UBSan build links with ASan.
    
    Once this in in then https://github.com/google/oss-fuzz/pull/3094
    can be merged to oss-fuzz.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit f79caf3b6bf4b3c4942874af70cfa8c912959faa
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sun Dec 8 07:22:33 2019 +1300

    lib/fuzzing: Remove oss-fuzz build.sh stub from the Samba repo
    
    We need to ship the stub build.sh in the oss-fuzz repo, not ours.
    This is because otherwise the travis CI checks skip the build
    (it thinks we are not set up yet, or have been disabled).
    
    See https://github.com/google/oss-fuzz/pull/3094 for the PR
    creating a similar file there.  This is very similar to how
    janus-gateway operates, so this is an accepted pattern.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 8382fa6408ef5efc45260e332579a6d9ee648d87
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Dec 7 12:06:37 2019 +1300

    oss-fuzz: Align build.sh sh parameters with pattern from the oss-fuzz project
    
    We should run build_samba.sh with -eux to ensure we exit on failure,
    refuse to use an unset varible and print the commands we are running.
    
    (The suggested build.sh on the oss-fuzz side uses -eu).
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 47c7f549955b8c01d5fbe09a0f9ccc3503b94c63
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Dec 6 11:10:05 2019 +1300

    fuzz/decode_ndr_X_crash: -f to filter crashes by regex
    
    If you go:
    
    $ ./lib/fuzzing/decode_ndr_X_crash -H HONGGFUZZ_REPORT.txt -f 'SIG[^V]' > ./crash.sh
    
    you will get all the crashes and not the timeouts (which have SIGVTALARM).
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1d98ced841f83d7305a570297908fd1270de42e0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 21:23:06 2019 +1300

    lib/fuzzing: Add mode for the AFL fuzzer
    
    This is helpful for ensuring the fuzzers still compile in autobuild as no
    library support is required.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit f4ff9a079414953b17f49857ecfca6c0e479c32f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 22:07:26 2019 +1300

    lib/fuzzing: Also confirm we can make a string filter from the parsed tree in fuzz_ldb_parse_tree
    
    This also avoids tree being an unused variable.
    
    This is similar to doing an ndr_push() in ndr_fuzz_X, it
    catches some of the cases where the parse is successful but
    the application code could misinterpret the structure.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 000d86f537866a3c83f06d7b128532119df45dd9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 21:39:49 2019 +1300

    lib/fuzzing: Tell the compiler we know we are ignoring errors in fuzz_reg_parse
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit a9a8bcf731659f0898f70759e78a9909f018ae48
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 30 20:23:18 2019 +1300

    lib/fuzzer: Allow building a fuzz binary for just one interface
    
    This helps direct the fuzzer at a particular function that we are concerned about.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit c16e4dcad9cb8dc16ceacb94b9ba6ce094f4e507
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 30 20:22:26 2019 +1300

    lib/fuzzer: Remove rudundent install=False flag from fuzz_ndr_X build rule
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 6f7a9e87887e50160df6a06b09d8454eef9208a1
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 29 12:07:34 2019 +1300

    lib/fuzzing: Link only the required NDR_ subsystems into ndr_fuzz_X binaries
    
    This reduces the binary size and shows that we are linked against the correct
    ndr_table_ global variable.  This might help the fuzzing engine know there
    is not much more of the binary to find if unreachable code is not included.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 3ca76f59070020ea188bea88bece38d8c9036f59
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 29 12:06:01 2019 +1300

    librpc: Fill in full deps for NDR_* subsystems
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit c35fe03a63cae908d879328fe4238ed1df1b158d
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Dec 4 11:57:02 2019 +1300

    fuzzing/decode_ndr_X: read crashes from a HONGGFUZZ report
    
    In theory, you should be able to run honggfuzz and go
    
    $ lib/fuzzing/decode_ndr_X_crash -H HONGGFUZZ-REPORT.txt > crash-crash-crash.sh
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit afe866086c00d433e270a94c782f551e5b00263b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Dec 4 11:35:40 2019 +1300

    lib/fuzzing/decode_ndr_X: print less by default, avoid pipe
    
    ndrdump can now take base64 input directly.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c0043e2352691e5ee3885558e5c1894dda342a70
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Nov 5 14:26:56 2019 +1300

    fuzzing: Add script decode_ndr_X_crash to decode crash results
    
    This interprets a file that crashes an fuzz_ndr_X binary
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e737988641905180d7d9a4e5cc88a85637deaab6
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Nov 6 17:27:08 2019 +1300

    dcerpc: developer option to save ndr_fuzz_X seeds
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Pair-programmed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7b265830ad6796dbbe721f7abfd62a19c2185b65
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Oct 31 16:28:28 2019 +1300

    lib/fuzzing: add fuzz_ndr_X
    
    This NDR fuzzer links with each "interface" in the IDL files to
    create avsingle binary.  This tries to matches what the fuzzing
    engines desire.
    
    It started as a copy of ndrdump but very little of that remains
    in place.
    
    The fancy build rules try to avoid needing a lof of boilerplate
    in the wscript_build files and ensure new fuzzers are generated
    and run when new IDL is added automatically.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Pair-programmed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit ef5d79e24ba8aec226419e594de0cf91c24d7fc4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:44:52 2019 +1300

    pidl/tests/samba-ndr.pl: remove duplicate import
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Dec 10 04:16:31 UTC 2019 on sn-devel-184

commit fbe402edf55cc4dda8820645c7c4e20862969803
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:43:52 2019 +1300

    pidl s4::Python: silence warnings
    
    - do not redeclare variables in the same scope.
    - use $1 instead of \1, which perl just prefers.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 51a11afecf590a26b784c1d2e484829330efa44f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:43:02 2019 +1300

    pidl Parse::Pidl::NDR: silence two warnings about undefined strings
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3c90c9de6f45af60d9db5f40ec0dad6318e53e3d
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:42:22 2019 +1300

    pidl Parse::Pidl::NDR: add HRESULT alignment
    
    this is a guess
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 33255102acd755cacceafd2a082722ed0fbc695f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:41:42 2019 +1300

    pidl Parse::Pidl::NDR: warn of unknown scalar alignments
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4de002a0f77dba8345ca6c395a855a5c053a8dd4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 23:05:56 2019 +1300

    pidl s4::NDR::Parser: silence a warning
    
    At level 0 there is no previous level so $pl is undefined thus so is ->{TYPE}
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit aefce8e7c0d82241ab6ecfab7d714338b331bc52
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 22:52:23 2019 +1300

    pidl s4::NDR::Parser: correct has_fast_array logic
    
    Here we fix two bugs that cancelled each other out completely, so this
    patch leaves us with exactly the same functionally as before.
    
    Bug 1: In perl, return is *syntactically* a function.
    
    That means 'return X or Y' is read as 'return(X) or Y', as in the
    'open(X) or die "..."' construct -- Y is only evaluated if return
    returns false. But return never returns, so Y is dead code. If in
    doubt, try these:
    
    perl -e "sub x {return 0 or die;} x"
    perl -e "sub x {return (0 or die);} x"
    
    What we *meant* here is 'return (X or Y)', BUT it turns out we were
    confused -- the Y case was bogus.
    
    Bug 2: string arrays never had "fast array logic" in the first place.
    
    The fast array logic is for arrays of bytes, and can be fast (i.e.
    memcpy) because there is no endianness to worry about. A string array
    is an array of pointers not bytes.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2765b5c1a27232b990537415718e98449617641b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 23:37:08 2019 +1300

    pidl s4::NDR::Parser: read hex numbers as numbers for ranges
    
    Hex numbers in IDL are not parsed as numbers, resulting in warnings
    like
    
    Argument 0x2000 isn't numeric in numeric lt (<) at /home/douglas/src/samba/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm line 981
    
    not to mention problematic code. We add a utility function to convert
    these numbers to numbers.
    
    A typical difference this makes is:
    
     --- old/default/librpc/gen_ndr/ndr_dcerpc.c     2019-11-30 23:40:32.915816967 +1300
     +++ new/default/librpc/gen_ndr/ndr_dcerpc.c     2019-11-30 17:00:09.055733660 +1300
     @@ -1893,7 +1893,7 @@
             if (ndr_flags & NDR_SCALARS) {
                     NDR_CHECK(ndr_pull_align(ndr, 4));
                     NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, &r->ReceiveWindowSize));
     -               if (r->ReceiveWindowSize > 0x40000) {
     +               if (r->ReceiveWindowSize < 8192 || r->ReceiveWindowSize > 262144) {
                             return ndr_pull_error(ndr, NDR_ERR_RANGE, "value out of range");
                     }
                     NDR_CHECK(ndr_pull_trailer_align(ndr, 4));
    
    Where the minimum ("0x2000" == 8192) was read as a string, thus
    treated as zero.
    
    The treatment as zero was introduced in 142b2a61f8a77b3065ce4c78b459ab714d6d190a
    accidentially, which shows why warnings are important.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit efef4366f18515ec78cb025928c20fb7986cd98f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 22:34:54 2019 +1300

    pidl: use perl warnings
    
    Warnings are good. If we turn on warnings with 'use warnings', we will
    see bugs that have lain latent for years.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b6913830bf626c8d7059f4cda3a4fc1bb3081973
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 5 09:56:44 2019 +1300

    librpc/ndr: Do not follow a client-supplied NULL pointer in _print_drsuapi_DsAttributeValue_attid()
    
    This is not a security issue as it only happens when printing the structure
    during debugging, not normal production.
    
    Found by Michael Hanselmann using an NDR fuzzer and Hongfuzz.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit f786cdf5e84f70c9a0ca206c761d453d42e72251
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 5 11:10:14 2019 +1300

    selftest: Add ndrdump tests for malformed drsuapi traffic
    
    Thanks to Douglas Bagnall for the samples, produced from seeds
    generated by Samba's make test traffic, fuzzed by ndr_fuzz_X
    and Hongfuzz.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 83ffe6752d589180eac96d7b8e7d1a54e3476bfd
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 13:48:52 2019 +0100

    pidl: Remove Parse/Yapp/Driver.pm
    
    This file is provided by Parse::Yapp and on install we overwrite the
    orignal file.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Dec 10 01:54:02 UTC 2019 on sn-devel-184

commit fe2577a40c19c99c29dd54c7c43e12f3d43493be
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Oct 21 20:03:04 2019 +0300

    smbdes: remove old unused DES builtin-crypto
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b5d8f1f78a04719c6a5d15aa92ae398be326fe56
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 15:13:19 2019 +0100

    sess_crypt_blob can only crypt blobs whose size divides by 8
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a75ca8d5d515aef1229acf5a30489ee5f5ced3e1
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 14:02:03 2019 +0100

    session: convert sess_crypt_blob to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dcc33103d5c0927bb3757974d4663df888dce95e
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 16:02:16 2019 +0100

    smbdes: convert des_crypt112_16 to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 254739137bdaebca31163f1683bfd7111dfefe67
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 15:41:02 2019 +0100

    smbdes: convert des_crypt112 to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dce944e8a1119034f184336f6b71a28080152a0a
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 15:28:39 2019 +0100

    smbdes: convert E_old_pw_hash to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c57f429574243adbcd43dca4f35d125df8d69ba0
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Nov 8 17:49:48 2019 +0100

    smbdes: convert des_crypt128() to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a5548af018643f2e78c482e33ef0e6073db149e4
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Nov 8 15:40:01 2019 +0100

    smbdes: convert E_P24() and SMBOWFencrypt to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2eef12904f2c08257394a2ee869960f7c2e09112
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Nov 8 12:04:48 2019 +0100

    smbdes: remove D_P16() (not used)
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9fb6361a8b09fd575bab2f5572fa9e10bd538eed
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 7 16:16:26 2019 +0100

    smbdes: convert E_P16() to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit ecee1998034b84026ab604dbe4400d9e53dcafd4
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 7 18:40:03 2019 +0100

    smbdes: convert sam_rid_crypt() to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit bbcf568f317960229caa7486322858093f5d0d04
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 7 13:39:20 2019 +0100

    SMBsesskeygen_lm_sess_key: use gnutls and return NTSTATUS
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 38189f76d8b958fff8a6351f3fb21f6ed04b76da
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 7 12:53:52 2019 +0100

    netlogon_creds_des_encrypt/decrypt_LMKey: use gnutls and return NTSTATUS
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0f855f1ab955e3ecf47689c5e4578eb67ebe8f27
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sat Oct 19 23:48:19 2019 +0300

    smbdes: add des_crypt56_gnutls() using DES-CBC with zeroed IV
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2c470c8035be6d70ce3fc8d1e12be284566a7037
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 23:44:10 2019 +0100

    selftest: test sess_crypt_blob
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 6c5f153e4793c0613dd843b1566bd27632912a7c
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 00:14:31 2019 +0100

    selftest: test SMBsesskeygen_lm_sess_key
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a4ec427e54b52307ee2e22079449ff3e59279298
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 20:02:49 2019 +0100

    selftest: test des_crypt112_16
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 394debac6b2f0838cde5d850335e0cdff14b411d
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 19:49:09 2019 +0100

    selftest: test des_crypt112 and fix (unused) decryption
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e2f8f686d1e3fce91f10aadb9667854cf2a1219a
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 19:10:18 2019 +0100

    selftest: test des_crypt128
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 8f042ba532fc645f2389a0a9d3e83d27c070fde4
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 18:49:58 2019 +0100

    selftest: test E_old_pw_hash
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dfad082596a53a7c6225da427447922fd4b7f0e2
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 18:26:13 2019 +0100

    selftest: test E_P24 and SMBOWFencrypt
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0923f94bdc21a80cbf40aaa65c4928c13c298d82
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 16:08:49 2019 +0100

    selftest: test sam_rid_crypt
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7044a41a30e43dda34eecb6df3da82ed5d568eec
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 09:46:18 2019 +0100

    selftest: test E_P16
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 07b4606f893fabd50c2685307d58e86f55defae5
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sat Nov 9 17:47:33 2019 +0100

    libcli/auth: test des_crypt56() and add test_gnutls to selftest
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 01f531ba6ba1306e99d2e4715dadae073eb0a8ec
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Dec 6 08:49:54 2019 +0100

    auth:tests: Only enable torture_gnutls_aes_128_cfb() on GnuTLS >= 3.6.11
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1c65f1fddba77e94edc5338af81c9a25e0d4e970
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Dec 6 08:12:34 2019 +0100

    auth:tests: Improve debug output of test_gnutls
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit adfdcc4791b9a5706c48789bfbb46f256ee10538
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 10:47:46 2019 +0100

    s3:lib: Move NULL check before messaging_dgm_out_rearm_idle_timer()
    
    We dereference out in messaging_dgm_out_rearm_idle_timer().
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 8753d5f4567e1bc39c25ea11d444bed6d0afea46
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 10:45:31 2019 +0100

    s3:smbd: Fix possible NULL deref in smbd_do_qfilepathinfo()
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cfa0526100575a7684879bb64f5e492c578bef87
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 10:35:55 2019 +0100

    s3:torture: Do not segfault if cli is NULL
    
    This can happen if we fail early and cli hasn't been initialized yet.
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 94c3c12df11dccdc34ef91f3065240f34a7244be
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 10:22:52 2019 +0100

    s3:rpc_server: Fix string compare for utmp entries
    
    The members of struct utmp are marked as nonstring. This means they
    might not be nil-terminated.
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c2e55821bc5db1a33ecd2f7550a75ebdbe7613f9
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 09:58:42 2019 +0100

    s4:lib: Make sure we close fd's in error path
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit bb2296f68a36a3b85a5702062a5e488f9d6616dc
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Dec 9 13:49:47 2019 +0100

    build: Fix the build without system gssapi headers
    
    source4/heimdal/lib/gssapi/gssapi/gssapi_krb5.h and gssapi_spnego.h
    have an #include <gssapi.h> which they need to find via the -I paths
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Tue Dec 10 00:29:55 UTC 2019 on sn-devel-184

commit a5e3db5b5125c2f9921a51837ac8d696b8f4260e
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 9 18:56:59 2019 +0100

    lib: spelling fix
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Mon Dec  9 19:23:10 UTC 2019 on sn-devel-184

commit f2a91426b791d1fc1b1655dfd4b8af5d50142d08
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 21:26:24 2019 +0100

    smbd: Give a better error message for non-existing share modes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Mon Dec  9 17:33:42 UTC 2019 on sn-devel-184

commit b6ffbc7d923cbe8c51a02e70d7ea8d2b8035b10e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 15:45:56 2019 +0100

    net: Extend some debug information
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 37fa97b20e30c13cd59f2a58f61d09a3ff761ac4
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 13:23:06 2019 +0100

    smbd: Call reopen_logs() in the notifyd
    
    If you have per-process logfiles with %d, the notifyd will get its
    own logfile
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 27c69b58929ea45bd7108372468cf6c63b80c449
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 13:22:06 2019 +0100

    smbd: Call reopen_logs() in the smbd scavenger
    
    If you have per-process logfiles with %d, the scavenger will get its
    own logfile
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a34d75f6f7e56a76b4e3d5399742e5ac837bafdd
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 12:52:09 2019 +0100

    torture: Use sizeof() where appropriate
    
    One magic number less that needs to be verified manually
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f576c02bf9365ff538a46dadfe8ce1f1aa19664c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Dec 4 14:43:02 2019 +0100

    smbd: Use NULL instead of 0 for a pointer type
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e1230f6e45bb076af9f6efda04405b0874430681
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 6 16:48:19 2019 +0000

    lib: add a comment to nt_time_to_full_timespec()
    
    Add a hint explaining why and how -1 should be treated differently in the
    future. Also make use of the helper function make_omit_timespec().
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f0813cbf4f507462b5b9aa0e913483232e51bea5
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 6 16:45:04 2019 +0000

    lib: harden full_timespec_to_nt_time()
    
    This protects against overflows when tv_sec is less then
    TIME_FIXUP_CONSTANT_INT.
    
    It also correctly limits the range of returned values to be
    [NTTIME_MIN, NTTIME_MAX].
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 99d153fad120e0a9335ec474296f55a2e258561a
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 6 16:44:37 2019 +0000

    lib: add NTTIME_MAX, NTTIME_MIN, NTTIME_OMIT and NTTIME_FREEZE definitions
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 67f455c3d576a0bc3174fd10cf4f3244621b6b13
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Nov 29 08:28:28 2019 +0100

    s3:smbspool: Leave early if we print as root
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Mon Dec  9 14:18:11 UTC 2019 on sn-devel-184

commit c95d32f685d989c91e62a734229d2bd241291315
Author: Mikhail Novosyolov <m.novosyolov at rosalinux.ru>
Date:   Sun Nov 3 01:47:51 2019 +0300

    s3:smbspool: print a hint about smbspool_krb5_wrapper
    
    When I first met with the situation that Kerberos kredentials cache of root
    user was looked for instead of the one of the printing task creator,
    it took a lot of time to understand that smbspool_krb5_wrapper will resolve this.
    
    Signed-off-by: Mikhail Novosyolov <m.novosyolov at rosalinux.ru>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 58a90358e2e8ff70c65eb49a21d00c5ce775ba54
Author: Mikhail Novosyolov <m.novosyolov at rosalinux.ru>
Date:   Sun Nov 3 01:28:13 2019 +0300

    s3:smbspool_krb5_wrapper: ignore unknown values of AUTH_INFO_REQUIRED
    
    To make smbspool_krb5_wrapper usable as a default destination for symlink
    /usr/lib/cups/backend/smb in Linux ditros, it has to be well-prepared
    for any possible values of AUTH_INFO_REQUIRED set by cupsd and correctly
    pass printing tasks to smbspool if it sees that Kerberos authentication
    is not needed.
    
    Discussed here: https://lists.samba.org/archive/samba-technical/2019-October/134470.html
    
    Signed-off-by: Mikhail Novosyolov <m.novosyolov at rosalinux.ru>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 6201b30421f616ec3f118321fd2998435792a4cc
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 28 09:38:08 2019 +0100

    s3:smbspool_krb5_wrapper: Map AUTH_INFO_REQUIRED=none to anonymous
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 1b42ccfc23eaa8f5b007928bc8bb65b944359f36
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 28 09:35:34 2019 +0100

    s3:smbspool: Map AUTH_INFO_REQUIRED=none to anonymous connection
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 8987d7eef4f2e1cb1ed29c3607bb6218f6cf668d
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Nov 8 14:32:44 2019 +0100

    s3:selfest: Do not print the env twice
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Dec  9 11:57:52 UTC 2019 on sn-devel-184

commit b05be655a9218add833d41a1765166de92431897
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 6 14:54:45 2019 +0000

    s3:tests: Remove the -I SERVER_IP so that Kerberos auth works
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit 241f3709de5bc8db39ec47976428e0284b79fb16
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date:   Fri Dec 6 00:07:11 2019 -0500

    docs-xml/Samba-Developers-Guide/vfs.xml: Fix incorrect VFS func names.
    
    Use SMB_VFS_P{READ,WRITE} since the others have been retired.
    
    Also, fix up the definitions.
    
    Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sun Dec  8 21:50:52 UTC 2019 on sn-devel-184

commit 5b8b9cd1c4d0065d6987658fdd8e9ec0a7c37a6b
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 6 10:27:22 2019 +0000

    s4:smbtorture: also test for date >> UINT32_MAX in timestamps test
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9c81aa9dabc3dcb96fef169521bc7cb6e601a2e9
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 21:27:09 2019 +0100

    smbd: Fix a share_entries.tdb record leak
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8435128582adf81a18e9d929970074d4f2326d20
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 21:33:28 2019 +0100

    smbd: Test cleanup of disconnected durable handle records
    
    Right now this panics the scavenger daemon, preventing it from doing
    its work. The reopen we expect to fail with
    NT_STATUS_OBJECT_NAME_NOT_FOUND thus succeeds. I know that we should
    more precisely detect the scavenger crash and with Jeremy's pattern in
    46899ecf836 this would be possible. However, this is C code right now,
    and scanning the logfile for the panic is more I have time for right
    now. The test successfully indicates failure, as the next commit will
    show.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f3802023feb9e5dfa82d2174437b7576470f575b
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 15:34:25 2019 +0100

    selftest: Make durable_v2_delay more specific
    
    It will grow another subtest soon
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0bc3e7499b9a8a9d360f6c9454210f3cad334f90
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 12:44:18 2019 +0100

    smbd: Panic if there's a leak in share_entries.tdb
    
    Hopefully dbwrap_tdb's dbwrap_exists is cheap enough for this to not
    impact performance too much. I could not measure any difference in an
    open/close benchmark, but at some point things might pile up and we
    might have to make this a #ifdef DEVELOPER
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 415fb7d2df4fdefd8aa78edde29abf64a008341b
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:30:05 2019 +0100

    build: Trim the deps of 'smbconf'
    
    This does not pull in gensec anymore
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4ff3e8ee8e1ec0d21db9d103dd6fb04c24c3eaaa
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:49:55 2019 +0100

    build: util_cmdline depends on cli_credentials
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cf9a029758459399a9ad93f6bd1e393cee644fdc
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:48:20 2019 +0100

    build: secrets3 need E_md4hash and kerberos functions
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 61b86d30d0218aab274601dd8d7d5c1ff6b5cf4f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:25:21 2019 +0100

    smbd: Make lp_use_sendfile() static to reply.c
    
    This is the only place where it's used. Also, via
    smb_signing_is_active it pulls in the dependency on
    'cli_smb_common' (which pulls in all of gensec) into the 'smbconf'
    library. Without this, 'smbconf' is happy with just 'samba-hostconfig'
    instead of 'cli_smb_common'
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9e640226621e11c2bd44450c3c284d9f72bfa714
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:20:36 2019 +0100

    build: Explicitly depend on samba-modules where needed
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cec30b2e063a4965fee2d4d9e8a50979a4f7647d
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:18:07 2019 +0100

    build: gencache.c in 'samba3core' needs crc32()
    
    This comes from zlib, make the dependency explicit
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2f2961a1170cd6fcd0f95e30bd243c051276c125
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:16:44 2019 +0100

    build: libcli/http does not need samba3core, only gensec
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 42035d1159718a39bd00a3289300c91ec62ecf50
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:40:00 2019 +0100

    build: messaging.c uses talloc_report_printf()
    
    This used to be talloc_report_str()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 63600b4f7841e0a81e40599947dbc62e07078aa2
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:39:18 2019 +0100

    build: Multi-line a long list of deps
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e79e943824ad0960916585d09d0dd6061f7518f9
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 17:17:42 2019 +0100

    ldb:tests: Add missing null check for ldb_kv_private
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Dec  6 11:13:24 UTC 2019 on sn-devel-184

commit 9323b5c50042738b4afbea3dc0db0ddbc096f99c
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 17:15:01 2019 +0100

    ldb:tests: Add missing size check for tdb
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit e464e40c977cd6592240763c7dbb9c45ff16470f
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 17:14:31 2019 +0100

    ldb:tests: Use assert_in_range() in test_get_size()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit 9a1072ddb6b5ddf7916496068cf9c155eb7762c8
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 17:02:39 2019 +0100

    ldb: Avoid a possible NULL pointer dereference
    
    Found by cppcheck.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit fe2901e1074afbc488e92a6b930a9430f09063d9
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 3 18:46:25 2019 +0100

    WHATSNEW: document SMB_VFS_NTIMES() interface change
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Dec  6 01:45:21 UTC 2019 on sn-devel-184

commit 69691dd0cd5fac292bfb1c1dc28136ae253bbc76
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 2 16:30:50 2019 +0100

    smbd: fix handling of sentinel timestamp values
    
    This implements two core changes:
    
    * use NTTIME instead of struct timespec at the database layer
    
    * use struct timespec { .tv_nsec = SAMBA_UTIME_OMIT } as special sentinel
      value in smbd when processing timestamps
    
    Using NTTIME at the database layer is only done to avoid storing the special
    struct timespec sentinel values on disk. Instead, with NTTIME the sentinel value
    for an "unset" timestamp is just 0 on-disk.
    
    The NTTIME value of 0 gets translated by nt_time_to_full_timespec() to the
    struct timespec sentinel value { .tv_nsec = SAMBA_UTIME_OMIT }.
    
    The function is_omit_timespec() can be used to check this.
    
    Beside nt_time_to_full_timespec(), there are various other new time conversion
    functions with *full* in their name that can be used to safely convert between
    different types with the changed sentinel value.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6e58cfab98d958c8008c77b0d909a3384de28d7b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 2 16:21:42 2019 +0100

    s3: add init_smb_file_time()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c6beb71813c015fddda02190e8093c335a2de411
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 1 09:01:20 2019 +0100

    smbclient: use cli_setpathinfo_ext() in utimes command
    
    This allows correct processing of sentinel date values.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1b9c31ef6ae8ffe1ee052b34d5013032cd37838a
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 1 09:01:13 2019 +0100

    libsmb: add cli_setpathinfo_ext()
    
    This takes a struct timespec instead of just time_t as cli_setpathinfo_basic()
    does. This is needed to pass sentinel values -1 in the smbclient utime command.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2a82caf57ed10e8c838c157314248a124848c571
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 3 18:36:38 2019 +0100

    smbclient: use full_timespec_to_nt_time()
    
    Needed to support dates corresponding to (time_t)0 and (time_t)-1.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 02f18a3980cfa10ccb8448f0f125ae9164648997
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 29 16:17:08 2019 +0000

    s3:lib: use nt_time_to_full_timespec() in interpret_long_date()
    
    interpret_long_date() is now only used in the client. To enable correct
    processing of dates before the UNIX epoch, call nt_time_to_full_timespec().
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7d4be660bbd90c04657ffb3e46b585f164657c5a
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 3 09:55:47 2019 +0100

    smbd: use pull_long_date_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e8c9559847503f20cf87f1dbe353ee7d9796ad64
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 15:26:07 2019 +0100

    s3:lib: add pull_long_date_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 572d4e3a56eef00e29f93482daa21647af7310d0
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Nov 30 21:29:07 2019 +0100

    smbd: use put_long_date_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b1a3445e3dbd9c08bc733377f7c3b95a9e8d2755
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 29 15:28:54 2019 +0000

    s3:lib: add put_long_date_full_timespec()
    
    put_long_date_full_timespec() will be used in the fileserver to marshall struct
    timespec timestamps that are sent to the client. By using
    full_timespec_to_nt_time() which supports tv_sec=0 and negative values, we can
    return timestamps to clients with a date before the UNIX epoch.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e3ad7e36a3fc8f5bd000481ac34c8fd3d2d747fd
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 28 15:46:27 2019 +0000

    s3:lib: let round_timespec() handle SAMBA_UTIME_OMIT
    
    This ensures callers are not required to do the check themselves and we don't
    clobber omit-timespecs in this function.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f2af647e7dd9fce537ce1c82e965486eee79aa27
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 29 08:43:21 2019 +0000

    lib: canonicalize pull_dos_date3()
    
    Returns 0xFFFFFFFF as (time_t)-1. This avoids misenterpreting 0xFFFFFFFF as a
    valid time_t value (0xFFFFFFFF = Sun 07 Feb 2106 06:28:15 AM GMT) on 64-bit
    platforms where time_t is 64-bit.
    
    Currently direct and indirect callers of pull_dos_date3() rely on the fact that
    the resulting time_t is checked with null_time() which also checks for
    0xFFFFFFFF as sentinel value amongst 0 and -1:
    
            return t == 0 ||
                    t == (time_t)0xFFFFFFFF ||
                    t == (time_t)-1;
    
    By returning -1 instead of 0xFFFFFFFF, callers can safely pass the result to
    unix_to_nt_time() which *doesn't* check for 0xFFFFFFFF, only -1.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7a69f642d7b138255a73ef42ab6dd9a5e50e5309
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Dec 4 15:05:19 2019 +0100

    lib: add time_t_to_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 928694af7e79edd0a48e43bb48af6fab9d32da89
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 27 15:31:50 2019 +0000

    lib: add timespec_string_buf()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2b938b4d339de095c670661600431bd6383a747b
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 22 11:47:22 2019 +0100

    lib: use nt_time_to_unix_full() in nt_time_string()
    
    This enables printing time values before the UNIX epoch coming in over the wire
    in smbclient allinfo command.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2e687d0e4dba9a0f94e532726e1f3dceaa3ed840
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 15:07:51 2019 +0100

    lib: add nt_time_to_full_time_t()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6f9a824fdad1deb9e738850638328d04731b9d7a
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Dec 4 12:46:11 2019 +0100

    lib: add full_timespec_to_time_t()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit af142df467fd434d5d45d55a3fd4c017bf673c7e
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 15:00:19 2019 +0100

    lib: add nt_time_to_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7c1d8957353867470bbcb32cae19467b06f0e25d
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 21 16:47:33 2019 +0100

    torture: add a timestamps torture testsuite
    
    Add a test that shows that setting timestamps to the special
    values (time_t) 4294967295, 0, -1 and anything below is broken.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b5dc6aa7202957d6a68eb27150796ef669e81369
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Dec 4 12:11:05 2019 +0100

    lib: add full_timespec_to_nt_time()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit eb42beeb1bf06aa78a67407bd74216230b8b0ef5
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 17:22:17 2019 +0000

    lib: add functions dealing with struct timespec UTIME_OMIT
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 96418cb15606a0969a50096e1c0e5de9c9e48d9a
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 27 11:28:30 2019 +0000

    lib: provide UTIME_NOW|OMIT defines under our own namespace
    
    We may want to add additional defines in the future in order to deal with
    NTTIME(-1) and NTTIME(-2) coming in over the wire. They have special semantics
    attached to them, -1 requests "no automatic write time updates" on a filehandle
    and -2 reenables them.
    
    We could use something like
    
      #define SAMBA_UTIME_FREEZE (SAMBA_UTIME_OMIT - 1)
      #define SAMBA_UTIME_THAW (SAMBA_UTIME_FREEZE - 1)
    
    in the future.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5fe42bdcde1d686c885445a718f181a49953c918
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 27 11:28:08 2019 +0000

    replace: ensure UTIME_NOW and UTIME_OMIT are always available
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d95be9135890279a845cc6712a15236aaa87e4d7
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 21 16:44:37 2019 +0100

    s3:tests: add a blackbox test that confirms broken timestamp behaviour
    
    This blackbox test confirms that Samba returns NTTIME=0 when a filesystem object
    has a UNIX timestamp value of 0, ie UNIX epoch start 1.1.1970.
    
    Here's an example output from running smbstatus allinfo on such a file:
    
      $ bin/smbclient -U slow%x //localhost/test -c "allinfo time_0_1970"
      altname: T11662~T
      create_time:    NTTIME(0)
      access_time:    NTTIME(0)
      write_time:     NTTIME(0)
      change_time:    NTTIME(0)
      attributes:  (80)
      stream: [::$DATA], 0 bytes
    
    If you look at it with smbclient ls command, it munges the output to be 1970 so
    you don't notice the problem:
    
      $ bin/smbclient -U slow%x //localhost/test -c "ls time_0_1970"
        time_0_1970                         N        0  Thu Jan  1 01:00:00 1970
    
    The test also test other time_t values -1 and 4294967295 that are used as
    sentinel values in Samba code and shows that handling these values is equally
    broken.
    
    Same for time_t values < -1.
    
    Note that I'm adding a blackbox test *and* a torture test, as with this blackbox
    test I can directly control the server side, but with smbtorture I have to go
    through the SMB stack to create the files which doesn't work currently.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 397ecd1feb3c46b861df7d37228b3033f27a06fa
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 21 12:29:51 2019 +0100

    s3:lib: remove unused uint64s_nt_time_to_unix_abs()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit eefc8ee8e31c108114b6114df4ad006d33af1f4b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Dec 4 12:10:27 2019 +0100

    bootstrap: add debian10 support
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Fri Dec  6 00:16:45 UTC 2019 on sn-devel-184

commit 41f6248effa5f5c0606a13da289c8a77abb30bce
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Dec 4 19:52:56 2019 +0100

    bootstrap: use runners with 'docker' and 'gce' tags for the image creation
    
    As we currently have the 'shared' tag on our private runners, they
    maybe selected for image creation, but it fails there.
    
    A lot of shared runners provide 'docker' and 'gce' and they are able to
    generate the images.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 809247973d9441c3d5249a7143cde6e858935d79
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 28 10:18:29 2019 +0000

    s3:locking: simplify code in get_share_mode_lock()
    
    The call to get_static_share_mode_data() is identical in the if/else branches,
    so move it behind them.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Dec  5 20:12:23 UTC 2019 on sn-devel-184

commit e30607aff3149395ce908d8ebfcac0fe56daa1ae
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 20 16:32:59 2019 +0000

    s4/smb_server: Fix handling of SMB2 messages after Netbios session setup
    
    On receiving a special NBT packet (e.g. session setup) the samba daemon
    effectively sets up SMB1 as the negotiated protocol (in terms of
    software handling of the messages) even though no SMB protocol
    has yet been negotiated. If the next message after the nbt session setup
    is a SMB2 message it will be handled by the SMB1 callbacks and will be
    rejected. This is evident when using smbclient (with -p 139) option
    in an env where SMB1 cannot be negotiated [*]
    
    This change doesn't set up the SMB1 callbacks on receipt of NBT special
    messages but lets the generic callback in place. Once either SMB1 (or)
    SMB2 is established (by receipt of a 'real' SMB or >=SMB2 message) then
    the proper callbacks will be set as normal.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Thu Dec  5 18:44:40 UTC 2019 on sn-devel-184

commit 5010535ec14d4e1f4dd83450432fc51a8ab53646
Author: Noel Power <noel.power at suse.com>
Date:   Fri Nov 22 17:01:45 2019 +0000

    s3/utils: Make sure we can negotiate protocol based on smb.conf settings
    
    net_rpc_check was hardcoded to check for rpc using SMB1 only. We
    should negotiate protocols based on the client max|min protocol settings
    
    this commit also removes the entry for
       samba3.blackbox.net.misc.lookup share list
    
    from knownfails as this test should now pass following this change.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 66443fe9340f1ae3894016fd7be51780f4c631b4
Author: Noel Power <noel.power at suse.com>
Date:   Fri Nov 22 16:53:08 2019 +0000

    s3/script/tests: Add simple test for net share list
    
    Adding a test for the net share list command. Currently this
    command will fail because of a bug in the net command when it tries
    to see if rpc is supported. This change adds a known fail to swallow
    this error. A future commit will fix the net command and remove the
    known fail
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit aca1c949023bf4ac620fe8d21a5e2a6e12c48dae
Author: Noel Power <noel.power at suse.com>
Date:   Tue Nov 19 12:38:18 2019 +0000

    s3/utils: net time always hardcoded to use SMB1
    
    net time ... cmd ignores any configuration to do with min/max protocols
    and connects allways with smb1
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 921f9f797f125d5e7cfe5505cd4287d23c2ae8f9
Author: Noel Power <noel.power at suse.com>
Date:   Thu Nov 21 12:31:31 2019 +0000

    s3/script/tests: Use protocol param passed to selectively run tests
    
    samba3.blackbox.smbclient_s3 passes NT1 or SMB3 to run tests however
    the PROTOCOL param is not used consistently within the script which
    results in NT1 and SMB3 traffic being produced during testing. This
    obviously causes issues when running the tests in an test environment
    where SMB1 cannot be negiotiated. These changes fix this
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a6451609993639616edcb6ee262381d5155774a1
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 27 20:06:10 2019 +0000

    s3/selftest: allow samba3.blackbox.smbclient_ntlm.plain run SMB1 & SMB3
    
    samba3.blackbox.smbclient_ntlm.plain used test SMB3 & NT1 protocols
    in one test. These changes:
      *  modify the test driver script test_smbclient_ntlm.sh to take a
         protocol as param
      *  modify the test description generators to pass NT1 & SMB3
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 980f7736fc0c569af6142288ac444775941426c3
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 27 19:44:23 2019 +0000

    s3/selftest: run samba3.blackbox.preserve_case with SMB1 & >=SMB2
    
    adjust test generators to run SMB1 & >=SMB2 versions of
    samba3.blackbox.preserve_case test.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f26c678a2ca550de6207634a8ea1461699cf54d6
Author: Noel Power <noel.power at suse.com>
Date:   Tue Nov 19 15:45:35 2019 +0000

    s3/script/tests: Allow test script to accept option protocol list
    
    test_preserve_case.sh tests a range of protocols, this however
    fails when running against the normal test env (which have min
    protocol of SMB2) because one of the protocols is NT1. This change
    allows tests to pass the protocol (or list of protocols) so that
    tests can be split.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f56314a97c508e105cd2b981730cd4fd25b0c6e4
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 11:05:57 2019 +0100

    s3/selftest: Run samba3.blackbox.net.misc with smb1/smb2
    
    samba3.blackbox.net.misc now can run with >=SMB2 or SMB1 protocols,
    adjust previous test definition and add new one
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d4d2e0175a4fef00566efa276a779a4ec23794d2
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 27 19:37:26 2019 +0000

    s3/selftest: split SMB1 & SMB2 parts of samba3.blackbox.dfree_quota
    
    samba3.blackbox.dfree_quota was almost exclusively a SMB3 test, only
    one part was testing legacy SMB1 behaviour, this change splits this
    out so the SMB1 part can be run independantly.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7c0ccbe1a004b96ccf726bda01262e5394c4d0b6
Author: Noel Power <noel.power at suse.com>
Date:   Tue Nov 19 14:11:21 2019 +0000

    s3/script/tests: Prepare to split samba3.blackbox.net.misc for SMB1/SMB2
    
    modify test_net_misc.sh to accept optional protocol, no protocol
    specified and it behaves more or less as before (expect this time the
    client max protocol is explicitly speficied)
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b4b25128b878cc4c41973de9c5ef5e9d0109a6a4
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 27 19:25:49 2019 +0000

    s3/selftest: allow samba3.blackbox.dfree_command run NT1 & SMB3 tests
    
    samba3.blackbox.dfree_command was a single test that run both NT1 &
    SMB3 tests together. This allow the protocol to be passed into the test
    script so the test can be divided into SMB1 & >=SM2 tests.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2ffccf9c016a91818e6617a53c5f9d54f5c70c8b
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 10:38:17 2019 +0100

    selftest: fix a flapping test
    
    The previous approach of using ls | grep $NAME for testing whether the previous
    directory removal succeeded will fail in case $NAME is a substring of any
    directory entrie's name.
    
    Eg
    
      NAME=tmp.123
    
    and the directory contains an unrelated entry
    
      tmp.123456
    
    Using allinfo instead should fix this.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ea1c62f3c7180e9ad5024bfcaea2d905f0b7996f
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Dec 4 13:54:04 2019 +0100

    ldb:tests: Allow test filtering in ldb_mod_op_test
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Dec  5 17:13:36 UTC 2019 on sn-devel-184

commit 520bb70dfd65d0a5236aa83cb8d662be62169e54
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Dec 4 13:29:26 2019 +0100

    ldb:tests: Avoid that the debug function overwrites memory
    
    We are setting ldb_debug_string() as the ldb debug function. The context
    we give it is only valid as long as we're in that function.
    
    On failure, we jump to the teardown function. The pointer for
    debug_string isn't valid anymore, but the ldb debug system still points
    to that address, and when we store the location of the allocated string,
    we overwrite memory, in that case something from talloc and a
    talloc_free() then jumps into the nirvana.
    
    Thanks to Florian Weimer who helped debugging this.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>

commit 8db0c1bff6f42feabd2e4d9dfb13ae12cc29607b
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:53:09 2019 -0800

    s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol].proto_reply_fn() succeeds.
    
    Otherwise we can end up with negprot.done set, but
    without smbXsrv_connection_init_tables() being called.
    
    This can cause a client self-crash.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Dec  4 21:27:24 UTC 2019 on sn-devel-184

commit 46899ecf836d350c0c29b615869851da7d0ad6fb
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Dec 2 17:23:21 2019 -0800

    python: tests. Add test for fuzzing smbd crash bug.
    
    Mark knownfail for now.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e84910d919e02feab2a297fccbbf95f333e32119
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:46:16 2019 -0800

    s3: smbd: Ensure we exit if supported_protocols[protocol].proto_reply_fn() fails.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit f4caa4159bd3db5127e114718e606867348a4f47
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:43:25 2019 -0800

    s3: smbd: Change (*proto_reply_fn()) to return an NTSTATUS.
    
    That way the caller can know if the negprot really
    succeeded or not.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 836219c479b047403d2b0839a6b92ad637dbaea0
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:21:06 2019 -0800

    s3: smbd: Change reply_smb20xx() to return NTSTATUS.
    
    Not yet used.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit a2d81d77c111379cbb6bd732c717307974eace0a
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:17:29 2019 -0800

    s3: smbd: Ensure we exit on smbd_smb2_process_negprot() fail.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 868bc05cf5d575e20edcce241e3af1d0fa6d9824
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:14:29 2019 -0800

    s3: smbd: Allow smbd_smb2_process_negprot() to return NTSTATUS as it can fail.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit eddd6c52678b28131d5dba67e6a8eaf4e5696a92
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 22:41:06 2019 +1300

    pidl: don't export parser class methods
    
    These methods are not used or usable as exported functions. The
    correct (and actual) usage is along these lines;
    
        require Parse::Pidl::Samba3::ClientNDR;
        my $generator = new Parse::Pidl::Samba3::ClientNDR();
        my ($c_code,$h_code) = $generator->Parse($ndr, $header, $c_header);
    
    where the methods are either explicitly referenced (new A::B::C),
    or are called from the blessed object, neither of which need
    exporting.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Dec  4 06:35:06 UTC 2019 on sn-devel-184

commit 8429418a88e803592f57e1997bfbe0f639f422c0
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:59:31 2019 +1300

    pidl s4/TDR: use Parse::Pidl::Base
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 12f6698f76e29854d5097a266fb4e1658d88ae96
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 17:43:20 2019 +1300

    pidl s4/TDR: use conventional ->{res} name
    
    rather than ->{ret}, meaning this class can be moved to a Pidl::Base subclass
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fd68ba8a10adf7439f842a787943b1ec4580d837
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:55:15 2019 +1300

    pidl: s4/NDR/Parser uses Pidl::Base
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 574c8db54cf1ba06516a5036269bffd81e20d602
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:49:06 2019 +1300

    pidl s4/NDR/Client: use Pidl::Base
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3fc222a1225658706444fd8118f9477b6a4baba4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:37:43 2019 +1300

    pidl s4/NDR/Client: fix pidl_both()
    
    This function was clearly meant to be adding output to both the .c and
    .h files, but was only adding it to the .h due to a typo.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 803d9cf8dd7d1767a7d9ac6e846450eb99ba8d5e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:31:27 2019 +1300

    pidl s4::Python uses Pidl::Base
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5513558bb422132632da08574d02f3a568622138
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:30:48 2019 +1300

    pidl:: adjust s4::Python pidl_hdr() to be the same as others
    
    The common case is for pidl_hdr() to add a "\n", which we can
    easily do here, allowing this to be merged into the Pidl::Base borg.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4f0fba18867faa0578d63c26054d04afd7f8b019
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:25:54 2019 +1300

    pidl Samba3::ClientNDR uses Pidl::Base
    
    We need to modify the '@ISA = ' line, because it overwrites
    the inheritance from Pidl::Base.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a78f69cb7d374adae470ac5e3dd9f3ac8175292e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:22:22 2019 +1300

    pidl: optionally annotate output for debug purposes
    
    It can sometimes be hard to tell which bit of pidl generated which bit
    of C. This commit wants to help.
    
    If the PIDL_DEVELOPER environment variable is set (via waf
    --pidl-developer or some other means), pidl will annotate *most* C
    indicating which lines were generated by which bits of pidl. It looks
    something like this:
    
    _PUBLIC_ enum ndr_err_code ndr_push_auth_session_info(struct ndr_push *ndr, int ndr_flags, const struct auth_session_info *r)
    {  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseTypePushFunction  lib/Parse/Pidl/Samba4/NDR/Parser.pm:3079
    	NDR_PUSH_CHECK_FLAGS(ndr, ndr_flags);  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseStructPush  lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
    	if (ndr_flags & NDR_SCALARS) {
    		NDR_CHECK(ndr_push_align(ndr, 5));  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseStructPushPrimitives  lib/Parse/Pidl/Samba4/NDR/Parser.pm:1448
    		NDR_CHECK(ndr_push_unique_ptr(ndr, r->security_token));  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParsePtrPush  lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
    		NDR_CHECK(ndr_push_unique_ptr(ndr, r->unix_token));
    		NDR_CHECK(ndr_push_unique_ptr(ndr, r->info));
    		NDR_CHECK(ndr_push_unique_ptr(ndr, r->unix_info));
    		NDR_CHECK(ndr_push_uint3264(ndr, NDR_SCALARS, 0));
    		/* [ignore] 'torture' */  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseElementPushLevel  lib/Parse/Pidl/Samba4/NDR/Parser.pm:729
    		NDR_CHECK(ndr_push_DATA_BLOB(ndr, NDR_SCALARS, r->session_key));  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseDataPush  lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
    		NDR_CHECK(ndr_push_uint3264(ndr, NDR_SCALARS, 0));  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParsePtrPush  lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
    		/* [ignore] 'credentials' */  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseElementPushLevel  lib/Parse/Pidl/Samba4/NDR/Parser.pm:729
    
    The comments starting with '//:PIDL:' have the function name, the filename,
    and line number. The comment follows the ordinary output, and uses the '//'
    style so as not to interfere with multiline /* */ comments if they happen
    to exist.
    
    A '//:PIDL:' comment is added whenever the pidl function or indentation
    level changes, and very occasionally at other places if pidl runs for a
    while without either of these things happening.
    
    This does not affect pidl parsers that do not inherit from Parse::Pidl::Base,
    and is careful to have no performance impact on non-debug generation.
    
    This may help with semi-automated flow analysis.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0cb2e6ac4c730e504cf40ec328e90874a2267d7e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 15:22:16 2019 +1300

    pidl: add a base class for PIDL parsers
    
    There are about 5 object-oriented parsers, all with their own
    effectively identical but differently spelt versions of pidl(),
    pidl_hdr(), indent(), and deindent(). With this commit we add a base
    class that they can all use.
    
    The ultimate aim is to be able to add some debugging instrumentation
    that benefits all[1] the parsers.
    
    [1] The parsers (e.g. Samba::ServerNDR) which use global scope rather
    than objects will not be affected.
    
    The versions of the functions in this file follow the most
    sophisticated versions of the soon-to-be subclasses. For example, the
    pidl() function avoids spurious whitespace and puts #define at column
    0, following the Python parser.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 12cccf3447333dfd4f5e437cd57ca5ec68724fdd
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Dec 3 11:17:26 2019 +1300

    pygpo: use correct method flags
    
    The METH_KEYWORDS argument must always be combined with METH_VARARGS.
    
    In Python up to 3.7 this was checked at runtime, and as we had no callers to
    get_unix_path() in Python we never noticed. In Python 3.8 it is checked at
    import time, and everyone notices even if they aren't directly using GPOs.
    
    Found and reported by Val Kulkov.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14209
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d15a3797c7949140c872e82cc42d4f7301a9bf82
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 14:19:24 2019 +1300

    librpc: Avoid spinning on string_array elements with a short input
    
    Without this protection we will spin during decode of a string_array or nstring_array
    that is terminated by only a single NUL byte, not two as required by UTF-16.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13874
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit bf8063e369a227eecc902f90277fc59d9d0ad167
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Mon Dec 2 15:54:08 2019 +1300

    librpc ndr: Tests for ndr_pull_string
    
    Tests to ensure that ndr_pull_string handles zero and one byte length
    data correctly for both character strings and UTF-16 strings.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=13874
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7127a615cbd742695cea5865533c1ee7098ecc10
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Wed Dec 4 08:46:57 2019 +1300

    librpc ndr: Infinite loop parsing Suplemental creds
    
    Fuzzing by Michael Hanselmann found an infinite loop parsing a malformed
    supplemental credentials structure.  There are no server-side
    network-accessible calls using this code.
    
    This patch adds an ndrdump blackbox test to replicate the issue.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=13874
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 787adfbcc9381b19330f1f73c95e34d25613f6b6
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Dec 2 13:21:57 2019 +0100

    s4:heimdal_build: move krb5-types.h into include/krb5-types.h
    
    source4/heimdal_build/include/ contains public headers,
    which are needed by callers.
    
    source4/heimdal_build/*.h should only be used for building the
    in tree heimdal itself.
    
    Without this an '#include "replace.h"' can catch 'config.h' from
    source4/heimal_build/config.h before bin/default/include/config.h.
    This #defines HAVE_CLOSEFROM unconditionally before replace.h can define
    the replacement for rep_closefrom() on systems without libbsd.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Tue Dec  3 23:36:17 UTC 2019 on sn-devel-184

commit 1b583bff72cb47860abc5168cc96d9087df16604
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 1 10:07:06 2019 +0100

    auth3: Remove auth_script
    
    Did this ever really work?
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Dec  2 22:47:24 UTC 2019 on sn-devel-184

commit a82ab4a7b3baaafab91b3e8f0746de70b07c306d
Author: Puran Chand <pchand at vmware.com>
Date:   Thu Oct 31 21:02:47 2019 +0530

    s3: smbclient doc fix
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 77d3a98aa63f37a8ced01c65fdb9b05ca68c6281
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 15:44:00 2019 +0100

    smbd: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4cd6c87a3d54e37b86c03b5d4bc0c24386fdfffb
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 14:00:51 2019 +0100

    libndr: Fix a talloc context leak
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8d8d2bdfa4f988bf5fdc9e05f7f3d1b4b6c54d0d
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 21:30:39 2019 +0100

    smbd: Avoid leaking share_entries.tdb records
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 18d7bb0698361900593bfe33c8655ba32a3671cd
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Nov 28 16:07:40 2019 +0100

    smbd: Use share_mode_do_locked() in smbd_do_unlocking()
    
    We don't really need the share mode data here
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 39f9618316946783bf7ceb5baf8667e139f3301c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 19:02:43 2019 +0100

    lib: Remove unused smb_xvasprintf()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 6d1ce7dc1723e0c9f63b6b5ec08141f198049a56
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 19:00:26 2019 +0100

    winbind: Use vasprintf() in winbindd_cache
    
    Don't need to panic, we can do explicit checks in these few callers
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 34c269ad02cbb6fae0d9b9db43d6700d06de1842
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 18:55:53 2019 +0100

    lib: Remove a duplicate fdprintf() prototype
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 6ab4b87a7e61d5af6e7980380c0f307bc310e5f0
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 08:36:59 2019 +0100

    lib: Remove duplicate get_pass() prototypes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 7093356440d0828f133fe652b090125af51cd01a
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 08:35:05 2019 +0100

    lib: Make stdin_new_passwd() static
    
    It's only used in one place
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 27fc062d7ea2207242d5a2c9933f3de5fa206488
Author: Uri Simchoni <uri at samba.org>
Date:   Sun Oct 20 21:36:11 2019 +0300

    heimdal-build: avoid hard-coded /usr/include/heimdal in asn1_compile-generated code.
    
    This fixes a cross-compilation issue, as cross-compilers (rightly)
    complain if host include directories are in the include path.
    
    The fix is taken from buildroot (https://github.com/buildroot/buildroot/blob/8b11b96f41a6ffa76556c9bf03a863955871ee57/package/samba4/0006-heimdal_build-wscript_build-do-not-add-host-include-.patch) where it was applied by Bernd Kuhls <bernd.kuhls at t-online.de>.
    
    This reverts some of 3fe2bfddda6149f6bf7402720226e9285f479fef, but
    building Samba's bundled Heimdal with a system roken is not supported
    anyway.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13856
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sun Dec  1 10:22:01 UTC 2019 on sn-devel-184

commit 7c4341c736c875d048ca622217f762b895a945ba
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Wed Nov 27 23:25:52 2019 +0000

    Split winbindd into library and binary
    
    The winbindd program was built in a single target with many source file,
    making reuse of parts elsewhere impossible. With this change the
    majority of the code is built as a subsystem and included in the binary
    as a dependency.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cddc229a4689f1d1757f427cd58816c1af2e628f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 18:55:47 2019 +1300

    selftest: Test partial parse behaviour in ndrdump
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Nov 29 02:09:11 UTC 2019 on sn-devel-184

commit b866018c2c89f6118c18d7a3527a0fa6d9916b9e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 18:54:28 2019 +1300

    ndrdump: Do not run the validate step after a failure
    
    This avoids ending a failed parse with 'dump OK'
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit ef0257b1055cfea3ca0bee69d8848f5719300911
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 18:54:04 2019 +1300

    ndrdump: Improve error message when the pipes fail to dump
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit bbae56411c716d8678687cf7c559488b618e8935
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 18:53:09 2019 +1300

    ndrdump: Show the actual struct/function name in the print, not just what it was called
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 674d2cfd04e79fc35317198c5e9e88734b14a5b9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 21 11:28:36 2019 +1300

    librpc/ndr: Remove unused ndr_cab_generate_checksum()
    
    This function is not just unused, it is a problem because there is no
    enforced connection between r->ab.length and r->cbData.
    
    The last caller was removed in the previous commit.
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit bd81733bb7c5af3fb2f98bf475d53507c3955b31
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 19 16:07:50 2019 +1300

    librpc: Make CFDATA private to cab.idl and remove pull and push functions
    
    We can do this because ndr_{pull,push}_CFDATA is unused.
    
    The earlier commit 466d5e814727046dd630d5503b43874ec46a365e removed
    the link between "uint16 cbData" and the size of "DATA_BLOB ab" so
    when the new ndr_fuzz_X fusser pushed a new structure this allowed
    a read beyond the end of allocated memory.
    
    The ndr_push_cab_file() function is also manually written and
    does not rely on the value of cbData to calculate the checksum.
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer, which like ndrdump's struct mode uses the public structure
    tables.  (This is how it found the unused functions to test).
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 12b3f26eee88ac810d08197d64019f5c4cfa2a03
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Nov 26 10:56:15 2019 +0100

    samba-tool tests: re-add tests for attribute value verification using samba-tool
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 6d1a0eb8d11dc0ad62500d977fafc7411d6f39ed
Author: Björn Baumbach <bb at sernet.de>
Date:   Mon Nov 25 14:13:37 2019 +0100

    samba-tool {user,group,computer,contact} show: avoid base64 encoded strings if possible
    
    Be more user friendly and use clear text argument strings if possible.
    
    Signed-off-by: Björn Baumbach <bb at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0b04d9f2ec85f10dac8cd8723deea3a18925deea
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Nov 26 10:41:29 2019 +0100

    samba-tool tests: prepare tests for new samba-tool functionality
    
    Use ldbsearch instead of "samba-tool user show" to get base64 encoded
    attribute. Used to verify that the attribute value has been changed
    successfully.
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c35b3ef2e1e79559c4293a413f5d422908546919
Author: Björn Baumbach <bb at sernet.de>
Date:   Mon Nov 25 20:53:35 2019 +0100

    samba-tool tests: remove duplicate definitions of test functions
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9983caaa47de2dd983f704867fad509f4d7196b1
Author: Björn Baumbach <bb at sernet.de>
Date:   Mon Nov 25 16:36:03 2019 +0100

    samba-tool group show: fix a copy-paste mistake
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2b88890adada76b1146591d62eb3898096f9105c
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Nov 22 22:39:09 2019 +0100

    krb5: move disabling dns-canon to lower level init calls
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Wed Nov 27 12:24:16 UTC 2019 on sn-devel-184

commit d9d6ce6eca6ca79fec95e93ce55d6e40da993de5
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 19:44:05 2019 +0100

    krb5: remove "set_dns_canonicalize" conf option
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

commit 609a1d1d6b491c8efc1436c65b75ebf5b0003a03
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 19:26:57 2019 +0100

    Revert "selftest: system-heimdal: workaround upstream "host" canon bug"
    
    This reverts commit 15ddd95d94688ed742a2965c4b269d7c84e2d858.
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ef1c852f975e98e034cefc7fc0c2da9eb8d5a46f
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 21:05:24 2019 +0100

    heimdal: invoke gsskrb5_set_dns_canonicalize(false) in gse_context_init()
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

commit 5114f73ea72bda2b4268fece9a5d61214d7afd20
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 7 11:40:07 2019 +0100

    param: remove now unused lp_string()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 31b06f412e91f44e074241564766d9c4869fff9d
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 7 11:37:47 2019 +0100

    param: remove FN_LOCAL_STRING
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b5c6964a50be03999432fa5620be39dcb7093ad8
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 7 11:01:05 2019 +0100

    s3:param: make "servicename" a substituted option
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit eddc63be868434d3aa5a66b514b692f4d7b8833a
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 7 09:50:37 2019 +0100

    printing: use lpcfg_substituted_string() in print_run_command()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 24905ba82d2f1b9e01df7a6e03d853c5138bc148
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 19 11:53:50 2019 +0100

    docs-xml: remove explicit "constant"
    
    The constant mark applied to types "string" and "ustring". The previous patches
    in this patchset already markes all string options as either constant or
    substituted, but it's still possible to add options or change existing ones to
    be neither constant nor substituted.
    
    In order to enforce strings to be either constant or substitued, remove the
    explicit constant marker. Instead, any option that is not marked as substituted
    is implicitly made constant.
    
    This patch doesn't change behaviour and all generated files are the same before
    and after this change.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 3e81d9460bf4f0640ef7c679cd539e614929343e
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 19 10:30:46 2019 +0100

    param: remove now unused FN_GLOBAL_STRING macro
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ad2c824b1f1ab3947176924074f4264fa0f44edd
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 6 14:24:58 2019 +0100

    docs-xml: remove SWAT specific flags
    
    Most of the SWAT stuff was removed in 4a6a010e78721624813a84bfefa7a1b80eaf0abb,
    somehow these two crept back in afterwards.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ca72c4b39c8d025f237af558fbeba485d09864a0
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:20:22 2019 +0100

    smbdotconf: mark "usershare template share" with constant="1"
    
    The code uses Globals.usershare_template_share directly anyway.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9aca11aec9fd129d5636f985969d55db209cb768
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:55:12 2019 +0100

    smbdotconf: mark "rpc server dynamic port range" with constant="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 564b0b5be31593de01e6d53388ee69e48645effa
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:53:54 2019 +0100

    smbdotconf: mark "mangling method" with constant="1"
    
    From the manpage:
    
      ... controls the algorithm used for the generating
      the mangled names. Can take two different values, "hash" and
      "hash2". ...
    
    No need for variable substitution support in this option, declare it const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6f618b7c95830b73ac636032e136b11c957139be
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 19:27:41 2019 +0100

    smbdotconf: mark "ldap user suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
    directly, variable substitution isn't supported anyway, so we can just mark this
    const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9ed8292a7b2fa08e16e5d98147ecdbe859d85e77
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 19:27:41 2019 +0100

    smbdotconf: mark "ldap machine suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
    directly, variable substitution isn't supported anyway, so we can just mark this
    const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b48d30e0e12a2ddf52429b69599850c670e68160
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 19:27:41 2019 +0100

    smbdotconf: mark "ldap idmap suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
    directly, variable substitution isn't supported anyway, so we can just mark this
    const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 71e9c6e48b57f568b04eb829511492aff41745b9
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 19:27:41 2019 +0100

    smbdotconf: mark "ldap group suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
    directly, variable substitution isn't supported anyway, so we can just mark this
    const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ca2e49fe42087678f971bde26ca05c91fb6f95b3
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 09:46:21 2019 +0100

    smbdotconf: mark "ldap suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix was used
    directly in the dependent options like "ldap group suffix", we can just mark
    this option as const thereby removing substitution from "ldap suffix".
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 050c28364aa1b476d33ea726ecb6cbd9d26af5d8
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:54:23 2019 +0100

    smbdotconf: mark "ldap admin dn" with constant="1"
    
    All the other LDAP related options like "ldap user suffix" don't support
    variable substitution, so I guess it's safe to remove support for it from this
    one as well.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4d2a3c8a791a42e2162ef957de2937673d536f53
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:21:58 2019 +0100

    smbdotconf: mark "wins hook" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 2dae6473fa0dabc2e12ffcf766f81117a10944b4
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:14:37 2019 +0100

    smbdotconf: mark "usershare path" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b635c445ad5a283bce28ae7eb7a60067d8802d6c
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:12:51 2019 +0100

    smbdotconf: mark "username map script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 3c68114e73421b5b89b57582defd53faef275ca4
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:11:54 2019 +0100

    smbdotconf: mark "username map" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a0185c7efbdba9405bcfade9ad89675532a43ffe
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:07:21 2019 +0100

    smbdotconf: mark "shutdown script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fd72181fd0d9275b8b2972cf0393fd0cc4b94088
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:01:45 2019 +0100

    smbdotconf: mark "set quota command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 434d2632cb95cfe6170f554afa7c31810b298037
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:00:49 2019 +0100

    smbdotconf: mark "set primary group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7dc7b9e55491267794548f96acc2e45244cf6eac
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:58:43 2019 +0100

    smbdotconf: mark "server string" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8077804c36c44631ba09d52308fe9ad213ae7eb5
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:51:56 2019 +0100

    smbdotconf: mark "root directory" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1439c19ceef3682782a7c337302ef9b7310687ef
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:49:28 2019 +0100

    smbdotconf: mark "rename user script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6d0db70ef7379ab722daed78ff5a877b48efd083
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:46:23 2019 +0100

    smbdotconf: mark "remote browse sync" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit dbc82a9f19e2fb4b7f9d9d708a7c5ed0eb4f0778
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:39:27 2019 +0100

    smbdotconf: mark "remote announce" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5c5dbcc397f96bb9960786a3f91b7d2f4012aeff
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:24:16 2019 +0100

    smbdotconf: mark "perfcount module" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 299718ccd4f301f0ab90d2d65b05725c45b40c3a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 18 18:39:53 2019 +0100

    s3: remove a prototype that is generated by loadparm
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1743ff48ba3e0c738b5909206cfcbd2111221443
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 18 18:28:27 2019 +0100

    smbdotconf: mark "passwd program" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4551dd27840a4bd0f84a78da1920acc7ba204f88
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:13:30 2019 +0100

    smbdotconf: mark "passwd chat" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ea61dd917e671f2eee225e55aaed285a43ec7523
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:04:39 2019 +0100

    smbdotconf: mark "panic action" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f3cfef87854ccc27e037501c578fccb712791385
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:03:23 2019 +0100

    smbdotconf: mark "os2 driver map" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f47b710b2c97d60d5f8b088a8d8be26c2a1f7d79
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:59:40 2019 +0100

    smbdotconf: mark "message command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e46ea02939a13ef41b36500874baa90fa29e973e
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:52:56 2019 +0100

    smbdotconf: mark "log nt token command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4d7eaed58600342f618a3ea0307208dff0591ad0
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:50:32 2019 +0100

    smbdotconf: mark "log level" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9910b5e1da337e84479421a599badf53c1853ea9
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:36:53 2019 +0100

    smbdotconf: mark "logging" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fa5033cfb7e9b65c23fe2c0c391c59b70d8415c3
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:34:11 2019 +0100

    smbdotconf: mark "logfile" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f2a1f0c705bc2e1f0400e23892fde45de00032b4
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:52:37 2019 +0100

    smbdotconf: mark "iprint server" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9f3c05d009a7b6daf720e535e06e33a5ea13bf6b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:50:59 2019 +0100

    smbdotconf: mark "homedir map" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 330f4ac1ca6b04bd86f50489227f9d4b88d03949
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:49:47 2019 +0100

    s3:lib: add missing TALLOC_CTX parameter in call to lp_homedir_map()
    
    This seems to be dead (at least dying) code,
    is WITH_NISPLUS_HOME ever defined?
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 25039641490fdc33d7e81959bc462b5a2916d95e
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:43:45 2019 +0100

    smbdotconf: mark "get quota command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6e678cba77dac7bab2866bbfe393d624643fce1a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:42:38 2019 +0100

    smbdotconf: mark "enumports command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1377e66edfc1c6cdd40417a0b3b986bc106b6a3f
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:35:22 2019 +0100

    smbdotconf: mark "delete user script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7547d837ec62c0e019122d503097ffe6d080a3ca
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:31:57 2019 +0100

    smbdotconf: mark "delete user from group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 28391f0b61b6cfe75d8042dbb5f811fdfada3b99
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:30:37 2019 +0100

    smbdotconf: mark "delete share command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d035f850deb5e7b3eb1f1c0d86f09ea6ec2e4cc4
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:26:29 2019 +0100

    smbdotconf: mark "deleteprinter command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b1c27e724665a5fea8da3a0f15ab87f01e86aa26
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:25:09 2019 +0100

    smbdotconf: mark "delete group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 736cb9d80c9fdba0369bd740aa82d88e45e0c4b9
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:21:34 2019 +0100

    smbdotconf: mark "defaultservice" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4b1de86de2b84afda280b862d4d6e7234ebb3de8
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:19:58 2019 +0100

    smbdotconf: mark "cups server" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fb434275164c21494bbb8be7d0f36c7289b20ce0
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 16:50:41 2019 +0100

    smbdotconf: mark "next configfile" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 12e97ee3e86d72b9edad9a2ac37249ffa0d28331
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 15:27:43 2019 +0100

    smbdotconf: mark "check password script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit bf9c63a28008883a6722a129e6b0f5a6695ed6a7
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 15:24:16 2019 +0100

    smbdotconf: mark "change share command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5e8d600bc6cc12019d986f54d1dd7483a940dacd
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 15:11:04 2019 +0100

    smbdotconf: mark "auto services" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8445454008a65581c3cf684a902072324894ea67
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 15:10:28 2019 +0100

    s3:param: let lp_add_auto_services() take a const char *
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 00c4d9ec1a67c9ed0a9827a9cb2982b335ab7a9a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 14:17:43 2019 +0100

    smbdotconf: mark "add user to group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4c345289baa1d18abd9975e2079a40b8f38bb384
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 14:12:08 2019 +0100

    smbdotconf: mark "add user script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 390f53cb038ad2f64cb3eae295643656b431b12f
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 13:58:28 2019 +0100

    smbdotconf: mark "add share command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 39f8014275c34d935bdbc5e272e60f2e4ed6b426
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 13:53:49 2019 +0100

    smbdotconf: mark "addprinter command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a5db3443a2e2aa25d7f58d999bacc297cc40b14a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 13:51:47 2019 +0100

    smbdotconf: mark "addport command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b0198b18314074495eaffd590799e1f0aa098a2c
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:49:10 2019 +0100

    smbdotconf: mark "add machine script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9e35015739d790ed0d44cd74ad9f8bb308f2d35d
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:43:06 2019 +0100

    smbdotconf: mark "add group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit db75b5d6fcc3dbdf10ceace57011ede629382da8
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 16:56:47 2019 +0100

    smbdotconf: mark "abort shutdown script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8834eafcacaa01d497f488851fe4f6b339be0e30
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:33:55 2019 +0100

    smbdotconf: mark "volume" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 18bd0c38f506876fd51c2bf54672b4e257364023
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:30:58 2019 +0100

    smbdotconf: mark "veto oplock files" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 73082f938ed6673eb5a0a3a3dbf12f306c13ee24
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:29:44 2019 +0100

    smbdotconf: mark "veto files" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 17726dab60fef0c28ecaf4edb03e320d74b74470
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:20:21 2019 +0100

    smbdotconf: mark "root preexec" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b92038072f3e5debd519eda0ab07182f46e06e56
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:19:24 2019 +0100

    smbdotconf: mark "root postexec" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b98e1ad7711aac4f8914b960199c9ae3aa7cea69
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:14:34 2019 +0100

    smbdotconf: mark "printername" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e95e1c2d4f8faf9dee82e7f51f95ca8451163336
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 11:30:22 2019 +0100

    smbdotconf: mark "preexec" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4f2ee224ce8a518ae0328e152addd2a1cdcca298
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 11:23:18 2019 +0100

    smbdotconf: mark "postexec" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f7619ac22b50bf3bac96825e72e9910946d7f4d2
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 19:14:02 2019 +0100

    smbdotconf: mark "path" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 95f0f22ca5150642c77bbbbe40a921ac50861e1c
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:56:10 2019 +0100

    smbdotconf: mark "msdfs proxy" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 223c1f725a5d48f226110f6b2decd1451ea8c526
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:49:07 2019 +0100

    smbdotconf: mark "magic script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 595685c1655fb71e64ba94bca504349cb25561b2
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:47:43 2019 +0100

    smbdotconf: mark "magic output" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 86843529210e55c57327909e770259bcd8f656d2
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:44:25 2019 +0100

    smbdotconf: mark "hide files" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 78593e2f0073bbdf6225c2e5d5bbff5cc7688f5a
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:40:53 2019 +0100

    smbdotconf: mark "force user" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 2cf62e85e5fec7e977779587ab6ae051fad009aa
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 17:56:56 2019 +0100

    smbdotconf: mark "force group" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 79cff6295d11d1c708bb997d458e9d982cddd480
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 17:51:06 2019 +0100

    smbdotconf: mark "dont descend" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7e918fad6e974b06a43357ba08ea5ef7ecd7f3b5
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:54:45 2019 +0200

    smbdotconf: mark "cups options" with substitution="1"
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7973c873442ed093b71bd42ca1397c5bfd65c820
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:54:45 2019 +0200

    smbdotconf: mark "dfree command" with substitution="1"
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8e86ac18e7d6c3b3e9c5786138d1c90e699843c8
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:54:45 2019 +0200

    smbdotconf: mark "comment" with substitution="1"
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c23e3564fc2c7c9dc53c2d26ecbacb1d9682aba6
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:54:45 2019 +0200

    smbdotconf: mark "aio write behind" with substitution="1"
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ef1f0e9ffe76eaee4b92241ea39d81ea553fa841
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:52:30 2019 +0200

    param: add FN_{GLOBAL,LOCAL}_SUBSTITUTED_STRING support
    
    Pair-Programmed-With: Ralph Boehme <slow at samba.org>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>

commit 3215d357e6af97ac05266b6ab5c8861d7f124815
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 14:05:24 2019 +0200

    s3:parm: remove unused lp_parm_talloc_string()
    
    Callers should use lp_parm_substituted_string()
    directly or just use lp_parm_const_string().
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit cea386de159c6bea141aa507e7b67723fac2f007
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 14:04:27 2019 +0200

    s3:vfs_glusterfs: make use of lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f6747ccc3b7ba14834bb2c62087203129f84feed
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 14:00:29 2019 +0200

    s3:vfs_nfs4acl_xattr: make use of lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 48c7d777f220d5c82cc5c456f86f760c42e3cf7e
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 13:58:48 2019 +0200

    s3:vfs_streams_depot: make use of lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5170fc24218f387c61bf24b13a414ce7d685b2d0
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 13:56:44 2019 +0200

    s3:vfs_tsmsm: make use of lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 564049fbc949827ccbfddcdbc5f560fc4ccae4ad
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 13:38:16 2019 +0200

    s3:mdssvc: make use of lp_parm_const_string()
    
    We don't need any substitution for elasticsearch options.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 236857b43453a2460d508fb4a2d7915a5055d195
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 12:29:08 2019 +0200

    s3:param: split out lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 063c4b25b1529987eb2e59ac53cd0ad23a8f5669
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 12:07:17 2019 +0200

    s3:param: split out loadparm_s3_global_substitution from lp_string()
    
    The idea is to get rid of the global state that's
    currently used for the substitution in lp_string().
    
    In the end all callers need to pass an explicit
    const struct loadparm_substitution *sub_ctx,
    which contains all relevant information
    for the substitution. At that point lp_string() can be removed.
    
    For now we provide loadparm_s3_global_substitution()
    for callers to keep the current bahavior unchanged.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 741bbfd252c272f796d535d653c39abee3569c93
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 6 16:25:00 2019 +0100

    lib/param: introduce loadparm_substitution infrastructure
    
    Pair-Programmed-With: Ralph Boehme <slow at samba.org>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>

commit c36dd5931850ae7ed6290718ecae7c3ebf257eb4
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 15:12:35 2019 +0100

    s3:param: rename lp_string() argument ctx to mem_ctx
    
    Minimizes diff of subsequent patch.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 57fa96b47654e899808b5159579b46f4059b5971
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 10:15:41 2019 +0200

    s3:lib: remove unused str_list_substitute()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 848cd4c460a52c459bba5ff14a8b72f126378066
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 10:15:14 2019 +0200

    s3:lib: remove unused str_list_sub_basic()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ff35160dc6415e1ef5d57717d7636f38ea25a8f0
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Nov 20 11:39:20 2019 -0700

    net: Delete share ACL from 'net conf delshare'
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Nov 26 22:55:38 UTC 2019 on sn-devel-184

commit 9dddb28a1719c753e84e2631ef1e1f12460cc3df
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Nov 26 09:59:15 2019 -0700

    selftest: Add test for 'net conf delshare' also removing share ACL
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cb907fbee8373666100984693f004e37cb20cacf
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Nov 26 09:58:32 2019 -0700

    selftest: Make net command available in sharesec test
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6bf6e5364a9ad3e5d8186f1226c83ecf16637a37
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Sep 18 13:37:32 2019 -0700

    sharesec: Return NTSTATUS from delete_share_security
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1f304fc16c675f402c61f95601481e7a3e27db04
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Sep 18 13:20:35 2019 -0700

    sharesec: Return NTSTATUS from set_share_security
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6dfa5bb64fce1ddd054966bd89b07e43034c6edb
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Sep 17 12:11:59 2019 -0700

    sharesec: Return NTSTATUS from share_info_db_init
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 39f21a58b0c196ef32e66a27051837e4395bb958
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 22 12:02:22 2019 +0100

    g_lock: Speed up sync g_lock_lock()
    
    The comment "this is used in very hot code paths" is not true right now, but
    will get true soon....
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ba852a3d92fd762e0a4d4e1b3a8177a30b5e34d5
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 22 11:56:55 2019 +0100

    g_lock: Move a variable inside the block were it's used
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f849d8c0cf7b8f04dd53cad4f633628c41565d2c
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 22 11:55:52 2019 +0100

    g_lock: Factor out g_lock_cleanup_shared()
    
    This function will find a second user soon
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 038549608709d4a1b7a1650041a57d201fb6a643
Author: Guenther Deschner <gd at samba.org>
Date:   Tue Nov 26 13:10:47 2019 +0100

    s3:winbind: Also set the cmd name for bool dispatch table
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Nov 26 14:14:51 UTC 2019 on sn-devel-184

commit 97d43cf6982a4bc1bbba70997990b017b6bca213
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 26 12:45:24 2019 +0100

    s3:winbind: Print priv pipe location
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 7eb171f6e36a3f1b3101398bb8a99aab99bb5c4f
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 26 13:32:53 2019 +0100

    gitignore: Add .build.log
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 9aa03be946467698ac7509251f366e165672feaa
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 20 16:03:37 2019 +0100

    torture: Test g_lock deadlock detection
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sat Nov 23 01:25:12 UTC 2019 on sn-devel-184

commit d734547488c6fab8d136239a95db640df57dbb97
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 17:29:18 2019 +0100

    lib: Change the g_lock data model
    
    Now we have one fixed field for the exclusive lock holder and an array
    of shared locks. This way we now prioritize writers over readers: If a
    pending write comes in while readers are active, it will put itself
    into the exclusive slot. Then it waits for the readers to vanish. Only
    when all readers are gone the exclusive lock request is granted. New
    readers will just look at the exclusive slot and see it's taken. They
    will then line up as watchers, retrying whenever things change.
    
    This also means that it will be cheaper to support many shared locks:
    Granting a shared lock just means to extend the array. We don't have
    to walk the array for possible conflicts.
    
    This also adds explicit UPGRADE and DOWNGRADE operations for better
    error checking.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit effad89f6224fbaeed5ef67016bd23e645763bc9
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 5 16:36:44 2019 +0100

    lib: Add g_lock_ctx_init_backend()
    
    This will allow using the g_lock.c logic on other databases as well
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 859148479b98678ee4bfa8084a6dc56bcc10a4c5
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Oct 28 13:50:09 2019 +0100

    torture: g_lock will allow duplicate READ locks soon
    
    In the future, g_lock will not check for duplicate READ locks anymore,
    as there might be many of them and the check might be expensive
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 97ba1ee2f94e5529839a1c0852f50544dbbb83cf
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 15:31:57 2019 +0100

    lib: Make struct g_lock_rec private to g_lock.c
    
    This is no longer exposed in the API
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c9b34cd2057c05e9965464ca5e9e28b423cb418b
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Oct 25 13:35:39 2019 +0200

    g_lock: Change prototype of g_lock_dump
    
    Soon the g_lock database format will change. There will be one
    exclusive entry and an array of shared entries. In that format,
    there's no need to attach a lock_type to each entry in the g_lock
    database. Reflect this change in the g_lock_dump API
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 06b0bcdf8d0abba2f0625ff458adb56bf471b9e0
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 13:13:02 2019 +0100

    smbd: Remove share_mode_data->record
    
    In the future, there won't be a record anymore
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0a66c9735456dbcee4b59e2bf8cd91402884b894
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 13:10:54 2019 +0100

    smbd: Pass the db_record down to share_mode_data_store()
    
    Remove a dependency on share_mode_data->record
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 24f56aefb487a6b269baf55b6840670666fbf0f3
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 13:06:20 2019 +0100

    smbd: Use share_mode_watch_send()
    
    This removes some dependencies on share_mode_data->record
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2379dc29bc73bdd1598a4ddaf47240cea5fd0697
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 12:57:35 2019 +0100

    smbd: Add share_mode_watch_send/recv
    
    For now this is a simple wrapper around dbwrap_watched_watch_send()
    that will make the direct db_record reference in struct
    share_mode_data unnecessary.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 341223a00596ef1cdc63d9eb0a0b2e496bd6f0f4
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 21:46:55 2019 +0100

    dbwrap_watch: Don't store in-RAM caches
    
    The history of this file is a mess with lots of bugs. Most of the bugs
    I believe are based on the cache of database contents we maintain in
    struct dbwrap_watch_rec. This patch removes that cache and does all
    modifications directly in the backend database.
    
    This means we have to mess with the database format in a few more
    places, but I think the format is simple enough that this does not
    really hurt.
    
    I tried for a few days to split this up into small pieces that are
    easier to understand, but every time I separated out individual chunks
    I found difficult to track down bugs that are all resolved in the
    final code presented here. It's more lines of code, but I hope it's more
    robust.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e5c28fec6f900dd1d8f1ee81d2cd008a93207a1a
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 13:43:13 2019 +0100

    dbwrap_watch: Simplify struct dbwrap_watched_watch_state
    
    With the wakeup messages changed, we don't need to store what used to
    be the old message in the struct dbwrap_watched_watch_state
    anymore. We still need to store the key that is watched for removal of
    our watch entry in the request destructor
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a793cc2276ef2123bfec1bc1828224372fcd3d93
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 13:36:58 2019 +0100

    dbwrap_watch: Simplify the wakeup messages
    
    The instance ID per process globally identifies a watch instance
    across databases. It's not necessary to send the database ID and the
    watched key across, the uin64_t instance ID is sufficient.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7349612c59a518a2858a4a7bb268fa1ad14016d3
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 13:23:52 2019 +0100

    dbwrap_watch: Add a uin64_t instance to watchers
    
    Initially used for debugging purposes only
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 053405719a5bd4121a2ca1f756dc7859ebb91faf
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 12:37:21 2019 +0100

    dbwrap_watch: Encapsulate watchers in "struct dbwrap_watcher"
    
    Next patch will extend this structure
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7cea5fec29a0d425263a7ecb79d89a4f13de3f7e
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Nov 17 16:45:45 2019 +0100

    dbwrap_watch: Prevent two watchers per fetch_locked sequence
    
    This can lead to very confusing bugs, and the code right now does not
    deal with it well.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 79dcabfbabb9503eff9efe7cd32b1cb431d3ee69
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 16 13:20:14 2019 +0100

    torture3: Test the next patch: No two waiters in one do_locked()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e341911ddad078c3c0c95f7e0ec16701510cb273
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 16 12:41:13 2019 +0100

    torture3: Consolidate dbwrap_watch test initialization
    
    More lines, but less error-prone copy&paste
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ca8c23bb42e501d5fe7f47f6c59feb5e7524a0cf
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 23 12:19:38 2019 +0200

    dbwrap: Don't set rec->value in dbwrap_do_locked()
    
    We pass that via the callback now
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ffe4933c776bc89ab8a6bb09f74288b8bf7b1310
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Nov 17 14:50:51 2019 +0100

    locking: Remove a call to dbwrap_record_get_value()
    
    This makes a copy of the record values TDB_DATA.
    
    In this case, it is okay: We only do a dbwrap_record_storev modifying
    the value that we retrieved from the share_mode_lock destructor.
    
    This patch is necessary because the next commit will make the "value"
    argument to the dbwrap_do_locked() callback the only source of the
    record value. Thus for a nested share_mode_do_locked() call we have to
    maintain the record value explicitly.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1dc3c168245366d219fc8c3b116f4f5904a9cb07
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 24 16:41:47 2019 +0200

    dbwrap: Protect against invalid db_record->value
    
    After dbwrap_record_storev()/delete(), dbwrap_record_get_value()
    information is stale. Assert on the attempt to re-fetch data after it
    became stale. This can't protect against someone copying the result
    from dbwrap_record_get_value() somewhere else, but it's better than
    nothing.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5291208836ea85b1b02f5b31b577fcc9050fa8b9
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 16:02:32 2019 +0200

    vfs: Use dbwrap_do_locked() in vfs_offload_token_db_store_fsp()
    
    Less malloc
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dbf24bcb1baa588295313e4d37ce84ee6db80168
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 15:13:05 2019 +0200

    vfs: Use dbwrap_parse_record() in vfs_offload_token_db_fetch_fsp()
    
    Less malloc
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 78c96f6995aa0cb8e0ec0872bdc00bb452bc2d36
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 23 11:21:16 2019 +0200

    g_lock: Pass "data" down to g_lock_trylock()
    
    Avoid a call to dbwrap_record_get_value(), dbwrap_do_locked() already
    gave us the value.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit caef82b1fe6ae7732abcd04a3696756274c935ea
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 23 11:34:47 2019 +0200

    dbwrap: Pass "value" to dbwrap_do_locked() callback
    
    I want to reduce dbwrap_record_get_value(). It makes the caller believe it can
    make a copy of the TDB_DATA returned and that the value remains constant. It's
    not, as you can always do a dbwrap_record_store().
    
    This patch removes one requirement for getting the value out of a
    db_record via dbwrap_record_get_value(). You can still make a copy, but from an
    API perspective to me it's more obvious that "value" as a parameter to the
    callback has a limited lifetime.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a58633f64ea4e43dd3f860b4176ebae080a0a4f1
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 17:17:07 2019 +0200

    dbwrap_tdb: Return correct error from db_tdb_storev()
    
    Don't lose information to NT_STATUS_UNSUCCESSFUL
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bc2fc51abef823090f178de7e39890bdd91f9067
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 16 15:29:28 2019 +0200

    dbwrap_tdb: Avoid includes.h
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e7f0e858e00a76976c3d84c8808e9296254b42a5
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 20 11:27:10 2019 +0100

    s3:printing: Use httpConnect2 from CUPS
    
    This fixes deprecation warnings.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Nov 22 19:54:55 UTC 2019 on sn-devel-184

commit 6107c79c90fdff3fe60e0d0ef3efe57b52b21262
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 22 10:06:57 2019 +1300

    build: Do not build selftest binaries for builds without --enable-selftest
    
    Add new for_selftest option to SAMBA_BINARY() and SAMBA3_BINARY()
    
    This allows us to be much more consistent (at least in the core Samba)
    and documents clearly why the binary should not be installed.
    
    Not modified are
     - test_lp_load
     - notifyd-tests
     - gendrandperf
     - test* from examples/libsmbclient
     - dbwrap_torture
     - split_tokens
     - locktest2
     - msgtest
     - msg_sink
     - msg_source
     - versiontest
     - rpc_open_tcp
     - test_headers
    
    As these are not tested in selftest so any change would also be
    untested.  Of course they probably should be added in a different
    MR.
    
    Also not modified (because they are not tests, nor part of the
    build system) are:
     - smb2mount
     - notifydd
     - log2pacp
     - debug2html
     - smbfilter
     - destroy_netlogon_creds_cli
     - spotlight2*
     - tevent_glib_tracker
    
    These do however appear to be untested.
    
    For now, the source4 forked client tools are left unchanged:
     - smbclient4
     - nmblookup4
    
    Finally, the heimdal binaries are left as install=False as
    they are either part of the build system or end-user tools
    that we just don't want to install.  These are however tested.
    
    The motivation is commit like c34ec003b7d45aa4196ff93a0ac29694b25e5309
    and da87fa998ab71328f30bcdf5b41aee8675aee48a, which are both totally
    correct but are not needed if the selftest is not run on MacOS.
    
    There are likely other platforms or build environments where building
    our test binaries is more pain than valuable, see for example also
    https://lists.samba.org/archive/samba/2019-November/227137.html
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Fri Nov 22 11:48:59 UTC 2019 on sn-devel-184

commit f8947538b5e445ab9c1931d1f7826771ee582385
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 21 10:21:54 2019 +1300

    lib/fuzzing: Add oss-fuzz info to README.md
    
    Note that Samba has not been accepted yet, but will be soon once some requirements
    are addressed per:
    
    https://github.com/google/oss-fuzz/pull/2993
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Thu Nov 21 00:45:33 UTC 2019 on sn-devel-184

commit cc128c788562d6d86c24cbcb784e1e8fca1f06a1
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 14:22:07 2019 +1300

    lib/fuzzing/oss-fuzz: copy required libraries to the build target
    
    This is an alternative to static linking as we do not have static source
    libraries for all the things we depend on.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 4946811eb67c6e4e6abdfd64a552e7a2686feeec
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 17:17:40 2019 +1300

    lib/fuzzing/oss-fuzz: Install chrpath as we use it in the build.sh script to set -rpath
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit fbb2377d51f00617e9065a8a3daecc8f5c340ca0
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Nov 21 09:59:24 2019 +1300

    lib/fuzzing/oss-fuzz: Add build_image.sh using Samba's bootstrap tools
    
    Google's oss-fuzz environment is Ubuntu 16.04 based so we can
    just use the maintained bootstrap system rather than a manual
    package list here that will get out of date.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    Pair-programmed-by: Andrew Bartlett <abartlet at samba.org>

commit ec4f6f8fd36edfda8b949dcf7451c153f6599427
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 21 10:29:57 2019 +1300

    lib/fuzzing/oss-fuzz: add stub build.sh that will not change often
    
    This makes local development of build_samba.sh easier as it will remain in the source tree.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit f57c0238e91061698787e4a4b18fb549cc2c86f2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 14:03:13 2019 +1300

    lib/fuzzing/oss-fuzz: Add build_samba.sh for oss-fuzz
    
    We work hard to put the primary logic for oss-fuzz here, and
    where possible into waf, so that only a tiny stub needs to
    be maintained in the Google oss-fuzz repo.
    
    This will be called by build.sh (not copied directly because
    it is too easy to forget to copy in an updated version when
    doing development in the docker image).
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 92ee647858331db012db06314d98e08fe1e5eb5b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 6 12:24:18 2019 +1300

    lib/fuzzing: Use --fuzz-target-ldflags if specified
    
    This makes integration with oss-fuzz possible.  Only the fuzzer binaries should be
    linked with libFuzzer, not things like asn1_compile, so this can not be done via
    the global ADDITIONAL_LDFLAGS.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit cb240510977e60fd46ef0f35b3da77f00733829a
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Nov 1 17:18:24 2019 +1300

    build: Set fuzzer=True on fuzzer binaries
    
    This ensures that the binaries are the only binaries built
    when configured for fuzzing.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9e51bb77f82292800c6f0c0563124954d8f0c524
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Nov 15 13:34:08 2019 +0100

    s4:rpc_server: Return the status code from dcesrv_transport_session_key()
    
    Normally this returns the right status code, which normally is:
    
       NT_STATUS_NO_USER_SESSION_KEY
    
    This is consitent with the source3 samr server implmentation.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Wed Nov 20 22:29:35 UTC 2019 on sn-devel-184

commit e7cab18c8b03cdc325f6e29a98b0889ab7647779
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 20 11:08:06 2019 +0100

    vfs: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Nov 20 15:23:10 UTC 2019 on sn-devel-184

commit f7f92803f600f8d302cdbb668c42ca8b186a797f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 19 17:38:50 2019 +1300

    librpc: Check for NULL pointer in value() in ntlmssp_AUTHENTICATE
    
    This allows ndrdump --validate to avoid following a NULL pointer when re-pushing
    a valid but unusual input.
    
    It also avoids an issue if the Samba server code were to provide a response
    without an EncryptedRandomSessionKey.
    
    At this stage ntlmssp.idl is not used for this, instead the packets are
    generated with msrpc_gen().
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Nov 20 06:06:29 UTC 2019 on sn-devel-184

commit 33e9021cbee4c17ee2f11d02b99902a742d77293
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 12:14:52 2019 +1300

    selftest: Test repushing an ntlmssp AUTHENTICATE_MESSAGE
    
    This demonstrates a bug found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer where the value() evaluatuion could segfault if it was made to follow a NULL
    pointer.
    
    This also demonstrates that the --base64 mode works on file inputs.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit ac1be895d2501dc79dcff2c1e03549fe5b5a930c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 11:40:51 2019 +1300

    selftest: Confirm that NDR bugs are fixed in DCOM code
    
    Test input provided by Michael Hanselmann and found using Hongfuzz.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13875
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 1aec742575252d1efcc47a8e9023889bfb0e5709
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Oct 31 09:35:19 2019 +1300

    pidl: check the size of pulled arrays of arrays
    
    We were accidentally checking the memory just past the array instead of
    checking each member.
    
    This could have led to the size of some arrays not being checked.
    
    Found by Michael Hanselmann using Honggfuzz and an fuzzer for Samba's
    NDR layer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13877
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 536a84935ce7647f43528d6d376f6762c5e8eb78
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Oct 30 15:02:49 2019 +1300

    ndr_orpc: properly allocate empty DUALSTRINGARRAY
    
    When there is no data we still need to allocate for the terminating NULL.
    
    Found by Michael Hanselmann using Honggfuzz and an fuzzer for Samba's
    NDR layer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13875
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b1eda993b658590ebb0a8225e448ce399946ed83
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:56:14 2019 +1300

    selftest: Confirm that --base64-input and --input work and a PIDL bug is fixed.
    
    The PIDL bug is in the handling of arrays of arrays.
    
    Test input provided by Michael Hanselmann and found using Hongfuzz.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13875
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 24fa3374e041f9ad26b6f124aed0c5a61a7d551e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:55:18 2019 +1300

    python: Return the stdout when also checking error codes
    
    This will aid in checking that ndrdump behaves as expected when
    failing to parse
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 2da54d11f1e9744885558a64e72bf93b6009ae0e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:45:02 2019 +1300

    ndrdump: Still print --dump bytes after parse failure
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 0491f1727513137a5cf86073d11608b7dd8a2056
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 13:26:11 2019 +1300

    ndrdump: Invert sense of --stop-on-parse-failure into --print-after-parse-failure
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit c83ad13e5893889852cbd7d2208bf45c2b72b07c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:39:54 2019 +1300

    ndrdump: Return a different error code for ndr_pull() failures
    
    This may assist in distinguishing between "runner" and "pull" failures.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 6f0d30fd5cc921dedbc0f0741e3959b4ebc4027d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:00:52 2019 +1300

    ndrdump: Allow for base64-encoded input in a file and on the command line
    
    It has become customary to provide reproduction steps for fuzzing failures
    in terms of an ndrdump command line.  This allows the input to be provided
    as a argument or in a file rather than via base64 -d.  This makes reproducing
    the issue easier as everything can be put in a plaintext bug report.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit d4eabfb763b7c0ea6b112ea3a129977a68466977
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 09:59:07 2019 +1300

    ndrdump: Check for input decode failures
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 3194baaf88d78f86cbf821600cd69712e1cc02a2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 09:58:15 2019 +1300

    ndrdump: Add const
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit c90bc75df8446c79a9e251c7b07a59674d828505
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 13:46:53 2019 +1300

    ndrdump: TALLOC_FREE() on each exit path to allow running with leak detection
    
    This allows us to learn if there are other memory leaks not on the mem_ctx
    during the processing of the packet.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 8a6f1de67b1c2e925cce8fb20b6657a425cbaedb
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 13:44:02 2019 +1300

    ndrdump: print structure name when failing to setup
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit db6c12f1584215c21cd5e56bef13c6d1c8b608ce
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 12:17:37 2019 +1300

    ndrdump: Fix one more NTSTATUS rather than friendly ndr message
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 1af1ebe54aefd436b6ed80cb99a30282d5abd495
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 11 15:02:30 2019 +1300

    librpc: Unify packet dumping on ndr_pull() failure
    
    There were two duplicate implementations of packet dumping just for the s4 RPC server!
    
    This unifies them and makes them easier to find because they are not triggered
    from the generated server stub any more.
    
    The behaviour have unified on setting "dcesrv:stubs directory" and
    being compiled with --enable-developer.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Nov 20 02:14:56 UTC 2019 on sn-devel-184

commit 7ae46019df1c5369cfd15f99448b94e425eddcc4
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Sep 18 15:41:13 2019 -0700

    vfs_gpfs: Use update_stat_ex_create_time
    
    Make the code a bit easier to read by avoiding direct access to the
    statex struct.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Tue Nov 19 22:44:53 UTC 2019 on sn-devel-184

commit f2339fe0dde2daedfab07d51709d7584c7f00e60
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Aug 19 16:23:11 2019 -0700

    vfs_gpfs: Create fileid from filesystem metadata
    
    MacOS SMB clients require that file ids are not quickly reused when
    files are deleted and new files are created with the same name. Inode
    numbers do not satisfy that requirement, as they will be quickly reused.
    
    To address this problem, create a unique id from the available file
    system specific metadata. As that id is larger than the available 64bit,
    use a hash to generate a 64bit id for usage as fileid.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit ba5d4803bab3f8fd980a5776f375b4e57b82cc85
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Aug 19 16:06:57 2019 -0700

    vfs_gpfs: Use gpfs_fstat_x in vfs_gpfs_fget_dos_attributes
    
    This is no functional change, but allows to use additional metadata
    later on.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 2c3436f05d7f728d5993e9ac9f3de18518647a8a
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Aug 19 15:41:45 2019 -0700

    vfs_gpfs: Use gpfs_stat_x in vfs_gpfs_get_dos_attributes
    
    This is no functional change, but allows to use additional metadata
    later on.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 586ffd5b6010b833b4d5b743f69b1629c36b6e7d
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Aug 19 15:35:18 2019 -0700

    gpfswrap: Add wrappers for gpfs_fstat_x and gpfs_stat_x
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit b68b7d51681955d925b746173ad45f4319171522
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 14:29:52 2019 +0100

    vfs: Fix CID 1455914 Unused value
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Nov 19 17:37:42 UTC 2019 on sn-devel-184

commit 55b0011aaf6b9c46bece711089d89bb1a6317cfa
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 14:23:52 2019 +0100

    smbd: Fix CID 1455912 Logically dead code
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit b9e74928ab99a169c76dcd3b401da70cbd1b3985
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 14:20:14 2019 +0100

    winbind: Fix CID 1455915 Resource leak
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 51f16ec578987506a2ea07401b287b731c08c3a1
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 14:17:38 2019 +0100

    librpc: Fix CID 1455913 Use after free
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d2b5aa16500835471692c8e1fe6cd1584da89785
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Nov 18 15:00:03 2019 +0100

    whatsnew: announce removal of DES encryption type in Kerberos
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Tue Nov 19 16:12:39 UTC 2019 on sn-devel-184

commit 389d1b979b8a4235033a298a56e6c10294a515fe
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sat Nov 16 23:03:34 2019 +0100

    heimdal: do not compile weak crypto
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a53fa8ffe3e36f7921baf5d31a1052747f90aa7d
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sat Nov 16 22:46:19 2019 +0100

    selftest: allow any kdc error in mitm-s4u2self test
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 151f8c0f31d3d17b9418db3793ec14ba7dbf2143
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 12 12:00:34 2019 +0100

    selftest: mitm-s4u2self: use zlib for CRC32_checksum calc
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 88bf0c572008ac9bc84f334e4c9373817499486b
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Sep 16 15:17:08 2019 +0300

    machine_account_secrets: do not generate single DES keys
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 80f1901de0c34ba0f9993d304ccc193b88e89693
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 24 19:04:51 2019 +0300

    kerberos_keytab: do not add single DES keys to keytab
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 982aa328f6502f28cc117e15bf0f936a132ddeca
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 24 18:32:37 2019 +0300

    password_hash: do not generate single DES keys
    
    Per RFC-6649 single DES enctypes should not be used.
    
    MIT has retired single DES encryption types, see:
    https://web.mit.edu/kerberos/krb5-1.12/doc/admin/advanced/retiring-des.html
    
    As a workaround, store random keys instead, making the usage of signle DES
    encryption types virtually impossible.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e8015d8a3485092e12d610e565c8c4ee2be937b6
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 24 18:53:34 2019 +0300

    kdc/db-glue: do not fetch single DES keys from db
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit ad9016d579aa3f6d53c656fd539d821ccfbf592f
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 24 12:20:05 2019 +0300

    kerberos: remove single DES enctypes from ENC_ALL_TYPES
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 13655e59e2c76561155ded0f65a46ce34129dd7b
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 31 19:41:46 2019 +0100

    selftest: exclude msDS-SupportedEncryptionType in ldapcmp
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Pair-Programmed-With: Alexander Bokovoy <ab at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 41b40f0e557608403ff5b19704fd5363d149444a
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 6 09:17:52 2019 +0100

    selftest/remote_pac: remove test_PACVerify_workstation_des
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 42ac80fb46cfb485e8c4a26d455fa784fdd1daed
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 16 08:54:42 2019 +1300

    ndr: Include the caller location in ndr_{pull,push}_error() messages
    
    This should aid in debugging NDR parse failures.
    
    Use the ABI bump to again exclude ndr_table_misc incorrectly
    added in ABI 0.2.1.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Nov 19 14:47:46 UTC 2019 on sn-devel-184

commit 183da1f9fda6f58cdff5cefad133a86462d5942a
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 16:02:39 2019 +1300

    witness.idl: Change array type in IDL for the print function
    
    It is important that the generated print function checks r->messages
    before de-referencing r->messages[num] as r->num can be non-zero
    while r->messages is NULL.
    
    There is not witness server in Samba and print functions are only
    used during debugging and ndrdump in any case.
    
    The change in the IDL does not change the header and the IDL
    function is already nopull,nopush so only the print function changes.
    
    Found by Douglas Bagnall using Honggfuzz and a new fuzzer for
    Samba's NDR layer.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit c34ec003b7d45aa4196ff93a0ac29694b25e5309
Author: Robert Scott <code at humanleg.org.uk>
Date:   Sat Nov 16 17:46:51 2019 +0000

    utils: only compile test_oLschema2ldif if fmemopen exists
    
    in the vein of da87fa998ab71328f30bcdf5b41aee8675aee48a
    
    Signed-off-by: Robert Scott <code at humanleg.org.uk>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Nov 19 06:12:29 UTC 2019 on sn-devel-184

commit 71816984c31cd1a392355afdbfdadb0da2d05765
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 16:33:23 2019 +0100

    s4:lib:tls: Fix cert and privkey types
    
    ../../source4/lib/tls/tlscert.c:42:2: warning: ‘gnutls_x509_crt’ is
        deprecated [-Wdeprecated-declarations]
       42 |  gnutls_x509_crt cacrt, crt;
          |  ^~~~~~~~~~~~~~~
    ../../source4/lib/tls/tlscert.c:43:2: warning: ‘gnutls_x509_privkey’ is
        deprecated [-Wdeprecated-declarations]
       43 |  gnutls_x509_privkey key, cakey;
          |  ^~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e19b115dd27891896364f5e943b0ce7fcc89344e
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 10:29:55 2019 +0100

    libcli:auth: Remove unused E_md5hash()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4199d1040f09b5d95522d0cbdbaeec78b7d7b9a6
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 10:28:59 2019 +0100

    s3:winbind: Replace E_md5hash() with GnuTLS calls
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 10499507c4fd91751898696b866ce32b1e38f605
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 10:24:56 2019 +0100

    s3:winbindd: Replace E_md5hash() with GnuTLS calls
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a377214dce2e9d71f880949fe745d799c75f57a9
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 10:21:06 2019 +0100

    s3:rpc_server: Replace E_md5hash() with GnuTLS calls
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 93b9fc3da86a09be8244859ee62063b75e002b23
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Nov 15 13:38:43 2019 +1100

    build: add missing crypt dependency for auth4_unix
    
    Commit dc5788056bc removed crypt library from replace.  This breaks the
    build on fedora 30 ppc64.
    
      [2439/3956] Linking bin/default/source4/auth/ntlm/libauth4-samba4.so
      /usr/bin/ld: source4/auth/ntlm/auth_unix.c.5.o: in function `password_check':
      auth_unix.c:(.text+0x7e0): undefined reference to `crypt'
    
    crypt library is required to build ntlm auth_unix.c.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Tue Nov 19 04:47:47 UTC 2019 on sn-devel-184

commit d6fbfb276ce89ad40f47784300fb99cee9d4aac9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 16:52:48 2019 +1300

    lib/fuzzing: Free memory after successful load in fuzz_tiniparser
    
    Otherwise we have a memory leak and so fail the Google oss-fuzz check_build test.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Nov 18 21:02:52 UTC 2019 on sn-devel-184

commit 43bc0b2c763284ec63ca1e750602f6a9b354f9ae
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 15:08:18 2019 +1300

    lib/fuzzing: Avoid NULL pointer de-ref from 0-length input
    
    fmemopen() does not like 0-length input.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4aea5c0972de53c143530cc42ef6d3b8cfafb973
Author: Uri Simchoni <uri at samba.org>
Date:   Sat Nov 16 23:54:31 2019 +0200

    tevent: Release tevent 0.10.2
    
    * Upgrade waf to version 2.0.18 to fix a cross-compilation issue
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Uri Simchoni <uri at samba.org>
    Autobuild-Date(master): Mon Nov 18 11:44:08 UTC 2019 on sn-devel-184

commit 28e4ac0e7ae965745fde628d7a675e337aa45341
Author: Uri Simchoni <uri at samba.org>
Date:   Sat Nov 16 23:52:33 2019 +0200

    tdb: Release tdb 1.4.3
    
    * Upgrade waf to version 2.0.18 to fix a cross-compilation issue.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3e2eafeb4460c8b6b3c3dbf64bbc967ae1d601d0
Author: Uri Simchoni <uri at samba.org>
Date:   Sat Nov 16 23:45:51 2019 +0200

    talloc: Release talloc 2.3.1
    
    * Upgrade waf to 2.0.18 to fix a cross-compilation issue
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e856877ef88bf273cbf814ff17abad900ba7ea27
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 16 21:25:11 2019 +1300

    ndrdump: avoid use after free
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Sun Nov 17 23:54:11 UTC 2019 on sn-devel-184

commit 816869ecea06b0b936e3ead4074bb754ee8650ca
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 15 19:25:54 2019 +1300

    ndrdump: Use human-readable strings for NDR decode errors
    
    These make much more sense than the NTSTATUS values they can be forced
    to map to.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit b3bdb17a35380237f7b46cc2b453b6b6b7c7a4f8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 14 13:49:48 2019 +1300

    selftest: Test fix for ndrdump of structures by number
    
    This requires that misc.GUID not move in the IDL, so a comment is added.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 2bb642d98e1c26064907f8f671c1de864f2d8c2f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Nov 14 13:14:08 2019 +1300

    ndrdump: correctly find the public strict by number
    
    We were finding a function that happened to have the same ordinal
    number.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f1fa0d3b9dfef17a5129b53695fa454f1a8b8b68
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 11 13:53:33 2019 +1300

    librpc: Use the fact that file_save() now uses O_EXCL in dcerpc_log_packet()
    
    This avoids a race with file_exist() and demostrates a better
    way to use this function.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Nov 15 18:48:27 UTC 2019 on sn-devel-184

commit 5e63e54f589b25af550f0d4e28e3c28e0a337c0d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 11 13:52:22 2019 +1300

    lib/util: change file_save_mode() to use O_EXCL
    
    Almost all the callers are debug tools or developer debugging aids
    and these callers clearly expect to create a new file.
    
    Unchanged in behaviour is:
     - TLS certificate creation.  This already confirms the files do no exist
       prior to generation.
    
    These will now no longer overwrite the given filename
     - net ads pac save
     - net eventlog export
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 55b2cb47a9701376aa9e844390c8c4ee2d7fa6e9
Author: Björn Baumbach <bb at sernet.de>
Date:   Fri Nov 15 13:21:48 2019 +0100

    s3-build: add missing gnutls dependency
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8e8313b2b57f3e760876feb5b732d1d2774baa18
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 15:41:47 2019 +0100

    third_party: Update nss_wrapper to version 1.1.7
    
    This adds missing support for Address Sanitzer.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Nov 14 23:50:06 UTC 2019 on sn-devel-184

commit 4320196977012e02765f4804070438149d858e22
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 13 16:29:17 2019 +0100

    lib: Fix an error path memleak in schannel_get_creds_state()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b1143a0c7e9080996bb47b52df9124d296e4345b
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 13 16:02:11 2019 +0100

    vfs: Use dbwrap_delete() in acl_tdb_delete()
    
    Use the wrapper function that's already available for exactly this
    purpose.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0c2a706a11c0ac89476c07f7d7d2554ffd7c342b
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 13 16:02:11 2019 +0100

    vfs: Use dbwrap_store() in store_acl_blob_fsp()
    
    Use the wrapper function that's already available for exactly this
    purpose.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5852bb96584afab61cf2635aa25033fd5b9f3a15
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 13 15:59:54 2019 +0100

    vfs: Use direct struct assignment in store_acl_blob_fsp()
    
    2 lines less code
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f38077ea5ee0a8d3d18970e3e183c3ee516fa121
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 29 21:19:05 2019 +0000

    pidl: Handle obtaining objects from a fixed-size array
    
    Previously we would assume the array head was the talloc context
    however this is not the case if the array is a fixed size inline array
    within the parent struct.
    
    In that case the overall object's talloc context is the correct
    context to reference.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Pair-programmed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Thu Nov 14 17:36:49 UTC 2019 on sn-devel-184

commit 1261894ecaebc1a3340c42e818be25caa69f6364
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Oct 29 11:58:32 2019 +1300

    pidl/python: allocate objects with ref pointers
    
    Struct members that are marked as ref pointers need to have an object
    allocated for them.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>

commit 7e19779b66d7329e4208eaa5801cec0b6feb3754
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Oct 29 22:11:41 2019 +0000

    pytests/segfault: pidl inline arrays
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit 272e20adbbbaebd7bbf94c79f44f1ff42d2831d8
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Oct 29 12:02:04 2019 +1300

    pytests/segfaults: dcerpc ref elements segfault
    
    These are just a couple of examples.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit 4dd725b1b599968fb787c93f6eb3a42af007b21c
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Oct 24 10:41:28 2019 +1300

    pytests: rpc echo should not segfault
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit 220cf67776f16467488805ecd6d1905c708eaa17
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Jul 24 17:50:35 2019 +1200

    s4/rpc/dcerpc_connect: no crash on NULL dest_host
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit 963a639101f4c55467e33667a698fffb350a931f
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 18:32:49 2019 +1100

    ctdb-tests: Add tests for cmdline_add() api
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Thu Nov 14 12:03:46 UTC 2019 on sn-devel-184

commit e469d6c1191ab9fa78e1ced6d7aa7b37dce7c5a9
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 17:32:50 2019 +1100

    ctdb-common: Add api to add new section/commands to cmdline
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 977a6f7fad8d2985e8e898bd8dc7d3d376164e9d
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 17:29:26 2019 +1100

    ctdb-common: Change cmdline implementation to support multiple sections
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 7a008c6b74e559a3e677257be3ea57a5821e3e9c
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 17:05:53 2019 +1100

    ctdb-tests: Update cmdline tests for section name
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b2b24c91fae30edf797ed30e3c45c259aee00853
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 17:01:43 2019 +1100

    ctdb-common: Add section to group commands in cmdline
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 29948d7b1eb1337c7e3d91dc53bb3e1e42de6dd3
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Jul 9 15:37:52 2018 +1000

    ctdb-common: Generate usage message from cmdline_parse()
    
    If any of the option parsing or command parsing fails, generate usage
    message.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 0361a26e395723296899c3d48cff86d532372710
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 14 11:16:09 2019 +1300

    libcli:auth Check return code of netlogon_creds_aes_encrypt()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Nov 14 09:25:36 UTC 2019 on sn-devel-184

commit 32e75bb4cca994af80bb8440009446e4a0ff5d40
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:13:53 2019 +0100

    libcli:auth: Check return code of netlogon_creds_step_crypt()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 05f59cbcf803d57ab41b4c7fa4f81da50cd02cd6
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:12:41 2019 +0100

    libcli:auth: Check return code of netlogon_creds_step()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a64a5b7e17d80a4363774d4e35d3ee676ecf426d
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:06:20 2019 +0100

    s4:librpc: Check return code of netlogon_creds_client_authenticator()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0906848936c410f49b26f7688df7ce1a0e1097f5
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:06:20 2019 +0100

    libcli:auth: Check return code of netlogon_creds_client_authenticator()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d3fffca5e9ab45b43fa3f460ad6051356c9a00a9
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:06:20 2019 +0100

    auth:pycreds: Check return code of netlogon_creds_client_authenticator()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7c7dc855ba982a37cb5040752ca473aab3446d6c
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 09:52:53 2019 +0100

    libcli:auth: Return NTSTATUS for netlogon_creds_client_authenticator()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0ed92e3e60684bfb02b01479d985535d525a5be5
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 09:44:32 2019 +0100

    libcli:auth: Check return status of netlogon_creds_first_step()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e4ae1ba451d408b3b5c74d303493cb7c38e6e1c8
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 09:41:18 2019 +0100

    libcli:auth: Check return status of netlogon_creds_init_64bit()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2c21cd6d49d56611acb2f364473d8c2e73e74545
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 09:39:19 2019 +0100

    libcli:auth: Check return value of netlogon_creds_init_128bit()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fbfb11b0f7ebd69cc4b1b545b398a367720d5473
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 14:01:46 2019 +0100

    s4:torture: Remove calls to gnutls_global_(de)init() in backupkey test
    
    This is handled by the gnutls library constructor/destructor.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0e159b725ecf2f9a6d026170253e2d1eb73ed0c2
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 13:59:30 2019 +0100

    s4:lib: Remove gnutls_global_(de)init() from libtls
    
    This is handled by the gnutls library constructor/destructor.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit afb5cb669ceeb68bf93ef8db07abcc5d424580cd
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 13:57:53 2019 +0100

    s4:rpc_server: Remove gnutls_global_(de)init()
    
    This is done by the gnutls library constructor/destructor.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3db2ca2dcf367a6c57071a76668d19f3cbf62565
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 12:52:44 2019 +0100

    libcli:auth: Check return code of SMBOWFencrypt_ntv2()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dc75a5f27eb32caf2f2adc289bc82fb0f8042cb3
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 12:48:18 2019 +0100

    libcli:auth: Return NTSTATUS for SMBOWFencrypt_ntv2()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0914824684b3a69a9926402d447e1d5781f2ec02
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 12:45:04 2019 +0100

    libcli:auth: Check return codes of SMBsesskeygen_ntv2()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 045b9eb3f088c66e20bd19e144a2ce3597328d93
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 12:40:02 2019 +0100

    libcli:auth: Return NTSTATUS for SMBOWFencrypt_ntv2()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 83b1c21dd0fb932b81491065067a973398bdca91
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 13 15:51:08 2019 +1300

    librpc: Do not return an NDR table for a zero GUID
    
    The source3 RPC server will do a lookup by GUID and should
    not be returned a table for a zero GUID.
    
    Thankfully such a pipe would also need to have been registered
    but regardless this is not a determinsitic result so should
    be avoided.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e45feaf28da27653e9df36c7c50cbd54a792a2aa
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Nov 12 12:14:18 2019 +1100

    ctdb-tcp: Simplify freeing of transport data on shutdown
    
    The type-checking is superfluous and gets in the way of readability.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Thu Nov 14 03:45:44 UTC 2019 on sn-devel-184

commit 750f3938e4fcd6743954db6b1132751a90ee6107
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Nov 12 12:12:46 2019 +1100

    ctdb-daemon: Rename ctdb_context private_data to transport_data
    
    This gives a casual reader a useful clue.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 53f8492caafa8556d0c2d3f272d08ce5ce098c25
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Nov 12 12:04:22 2019 +1100

    ctdb-daemon: Rename ctdb_node private_data to transport_data
    
    This gives a casual reader a useful clue.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a6d99d9e5c5bc58e6d56be7a6c1dbc7c8d1a882f
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Nov 7 15:26:01 2019 +0100

    ctdb-tcp: Close inflight connecting TCP sockets after fork
    
    Commit c68b6f96f26 changed the talloc hierarchy such that outgoing TCP sockets
    while sitting in the async connect() syscall are not freed via
    ctdb_tcp_shutdown() anymore, they are hanging off a longer-running structure.
    Free this structure as well.
    
    If an outgoing TCP socket leaks into a long-running child process (possibly the
    recovery daemon), this connection will never be closed as seen by the
    destination node. Because with recent changes incoming connections will not be
    accepted as long as any incoming connection is alive, with that socket leak
    into the recovery daemon we will never again be able to successfully connect to
    the node that is affected by this leak. Further attempts to connect will be
    discarded by the destination as long as the recovery daemon keeps this socket
    alive.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
    RN: Avoid communication breakdown on node reconnect
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 231397f45ee7a328ea41214b1367632298339e44
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 1 12:33:23 2019 +0100

    smbd: Make share_mode_do_locked() pass TDB_DATA instead of a record
    
    No callback used (and should not use) the record directly, this is all
    handled within share_mode_lock.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Nov 13 21:41:09 UTC 2019 on sn-devel-184

commit 5343cec5f0a5531af85d72021dba30c31a4a3f1b
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 14:24:58 2019 -0700

    gitlab-ci: Run samba-fileserver-heimdalkrb5
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Wed Nov 13 19:14:25 UTC 2019 on sn-devel-184

commit 2efc243f1ad09eae46f6f99fb0646ecd4356c3f9
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 13:49:55 2019 -0700

    bootstrap: Add heimdal-multidev for Debian and Ubuntu
    
    This is required for testing the build with the
    configure option --with-system-heimdalkrb5.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7965a204d68196acddf553959bb3407125baf31d
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 13:45:55 2019 -0700

    autobuild: Add test for build with system heimdal library
    
    The configure option --with-system-heimdalkrb5 requires --without-ad-dc.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 85d23236200dbe013c09a4f23d982ef1baac240d
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Nov 11 13:37:25 2019 -0700

    krb5_plugin: Fix developer build with newer heimdal system library
    
    Newer heimdal versions provide a different locator plugin interface. The
    function pointer for the old method has been renamed. Use an ifdef to
    initialize the correct pointer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1aef796e302058ad3327613964fa89abaf940c1c
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Nov 11 13:08:28 2019 -0700

    krb5_plugin: Use C99 initializer
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 15ddd95d94688ed742a2965c4b269d7c84e2d858
Author: Isaac Boukris <iboukris at samba.org>
Date:   Sat Nov 9 15:36:32 2019 +0000

    selftest: system-heimdal: workaround upstream "host" canon bug
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit be2d90b60d19eca408b60fe4e1b49f9b418f1b97
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 13:15:48 2019 -0700

    wscript: Fix build with system heimdal
    
    Ubuntu has heimdal include files in /usr/include/heimdal. As the
    kerberos include files are pulled into many files through indirect
    includes, add the discovered include paths to EXTRA_INCLUDES to
    always have them available.
    
    Also set USING_SYSTEM_KRB5 when enabling the system heimdal build,
    to correctly handle the inclusion of the krb5-types.h file.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 63f8d7732756b8a8452ab22ca205a29b27b7d1f1
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 14:57:02 2019 -0700

    bootstrap: Remove nettle-devel from package list
    
    nettle is required as dependency for newer gnutls libraries. The gnutls
    development package already depends on the nettle development package,
    no need to explicitly list it.
    
    Signed-off-by: Christof Schmit <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 816205027a12d16b5de7c1fd78b4bed468a94fbb
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Tue Nov 12 14:14:53 2019 +1100

    ctdb-ib: Fix build errors for infiniband transport
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Wed Nov 13 13:31:10 UTC 2019 on sn-devel-184

commit 86e418f992e1bb1faaa099567e0f80f280d391b6
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 12 17:17:02 2019 +1300

    build: Refuse to build if ADDITIONAL_LDFLAGS or ADDITIONAL_CFLAGS do not work
    
    This avoids these being silently ignored.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Nov 13 10:29:00 UTC 2019 on sn-devel-184

commit dc5db1e8d819f442060015bc93a132cc4b3f7ad9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 14:42:24 2019 +1300

    heimdal_build: Recurse to bld.SAMBA_BINARY()
    
    This reduces a little of the duplication added when it was thought
    that having a distinct waf wrapper on heimdal might allow this to be
    ported upstream.
    
    It will also streamline building a dedicated fuzzing mode in Samba.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 92ce387ed0e02bc3ebc673bcfd7ffbb55c04f57d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 17:07:44 2019 +1300

    build: Remove workaround for missing os.path.relpath in Python < 2.6
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit dc5788056bcbccdc320aeaad4f35f726632a91a4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 6 15:44:45 2019 +1300

    build: Only link against libcrypt where needed
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 01bb7cff023719705d7442ae497c52a3f797edf4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 12 12:11:53 2019 +1300

    ndrdump: check bounds when passed functions/structs by integer
    
    The function or struct number should be >= 0 ans the underlying
    number it is compared to is uint32_t.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-programmed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Wed Nov 13 01:55:33 UTC 2019 on sn-devel-184

commit 3b9e983b648bd3738d8a5e1d53f29cd21ba63387
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 5 16:15:38 2019 +1300

    ndrdump: Fix new "struct" feature
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 78521577eb11d2d601768f3c521549793341a450
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:15:26 2019 +1300

    pidl: Generate compatability wrappers for ndr_print functions
    
    This creates wrappers that are compatible with the functions called by
    ndrdump which have an extra "int flags" parameter for NDR_IN and
    NDR_OUT.  This will make ndrdump of public structures work again.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 1bd1ae0593a233465cbd5c381199bd0fc2cb476f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:19:29 2019 +1300

    pidl: Generate the trailing ndr_table even if the UUID is not set
    
    This allows ndrdump to dump many more public structures because most
    of these are not in files with a UUID as they are not RPC protocols.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 7299b9ba907d3c55897453ad2102500b94a21b82
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 11:30:52 2019 +1300

    librpc: Allow registration of ndr tables with a zero UUID
    
    This helps ndrdump find public structures to dump
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 1b6ae21fff9a649d451c30df90f167c33452975c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:20:19 2019 +1300

    build: Prepare for pidl to generate ndr_table entries for more IDL
    
    These IDL files will soon create ndr_table entries so need to be
    linked into the ndr-table subsystem.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit dd8dfa16dea73da3e07c0e84c308f74246cc5d13
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:12:02 2019 +1300

    s3-build: Skip building the ndr_table at the tail of ndr_libnetapi.c
    
    This is not a real protocol and all the functions are set to nopull,nopush
    but do not supply replacement functions.
    
    This is the best was I could find to skip compiling the table as otherwise
    it would point to undefined functions.
    
    This does not happen until we generate the ndr_table for idl files without
    a UUID, but we will shortly do that.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit dddef1b8224a2977c6e8b56af83429b36d6119ad
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:17:41 2019 +1300

    pidl: Allow the compilation of the ndr_table to be skiped
    
    libnetapi.idl defines a large number of functions a nopull,nopush and
    no replacement is provided.
    
    This will allow the ndr_table to be generated for all other IDL files
    that may have public structures that could usefully be dumped by
    ndrdump.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 5e0442efbe738c1e1d12a237b4c0abe8a472a176
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 6 15:33:24 2019 +1300

    build: Allow warning on compile of libnetapi PIDL
    
    This not-protocol only uses the print functions, but this means some other functions
    are now unused, and as this is a special case it is better to just allow warnings
    here.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit e45e342624da1b7f5df42c34c6fdccf32fc7b0e2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 11:52:27 2019 +1300

    librpc: Do not include the ndr_table for libnet_join.idl and libnetapi.idl in the global list
    
    These are not wire protocols, there are no structures to parse.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 88c8cd7a1e7bc48a758bd00e91ca58ca91eed9d0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 11:51:11 2019 +1300

    librpc: Do not place the ndr_table for windows_event_ids.idl in the global list
    
    This is just a list of event IDs, there are no structures to parse.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 88373c472c52ddc1191c1c20e74bff7776d0e805
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 11 16:39:13 2019 +1300

    selftest: Add expected-output tests for the ndrdump struct mode
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit dfbb3049585186230a0d28a581ad22de7276614c
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Oct 30 03:05:22 2019 +0000

    ndrdump: add --stop-on-parse-failure
    
    If a data stream fails to parse as an NDR object, the default ndrdump
    action is to try to print those structures anyway, resulting perhaps in
    a NULL dereference. Sometimes you don't want to see that because it isn't
    very interesting and makes it harder to distinguish a crash in the parse
    routines. So --stop-on-parse-failure will skip the print and validate
    stages altogether if the parse failed.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>

commit a106ceb7bfe588b1888001fbba5f500c2d33e5f8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 5 09:46:13 2019 +1300

    librpc: Match interface name and file name for bkupblobs.idl
    
    This helps generate fuzzers for this IDL.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 666dbc61f1a32f78a4096373e7b94733e06bd86d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 5 10:12:01 2019 +1300

    librpc: Match interface name and file name for winsrepl.idl
    
    This helps generate fuzzers for this IDL.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 8a627b5d65b65e926f739272bb8f8191cd1a25b3
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Nov 1 17:18:37 2019 +1300

    librpc: Fix typo in "quota" name in IDL
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3fea05e01f845588eb0de63af435bfec670593be
Author: Volker Lendecke <vl at samba.org>
Date:   Mon May 27 11:24:14 2019 +0200

    smbd: Remove write cache
    
    Since this was written, our write path has changed significantly. In
    particular we have gained very flexible support for async I/O, with the
    linux io_uring in the pipeline. Caching stuff in main memory and then
    doing a blocking pwrite nowadays does not belong into the core smbd
    code. If someone wants it back, it should be doable in a VFS module.
    
    Removes: "write cache size" parameter.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Nov 13 00:20:55 UTC 2019 on sn-devel-184

commit a0aaf5c3345239959221d6c2e9cd949b8ccdf233
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:13:52 2019 +0100

    lib: Remove unused file_id_string()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Nov 12 22:18:40 UTC 2019 on sn-devel-184

commit fea35840b0504ac2fc8a3d85cb044f3d9fb345dd
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:11:38 2019 +0100

    smbd: Use file_id_str_buf() in share_mode_cleanup_disconnected()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6fe211c85d93910960438c48b86614baac7db7de
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:08:15 2019 +0100

    smbd: Use file_id_str_buf() in share_mode_memcache_fetch()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0d246a156da8047b86a8cfab00f5760a840eec60
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:05:41 2019 +0100

    smbd: Use file_id_str_buf() in share_mode_memcache_store()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c229c0508bc64bb6e2d8d29be7a7bde58d86c86e
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:01:12 2019 +0100

    lib: Remove unused file_id_string_tos()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 64349ce7176c7079ffaace037c1a58a0f24abf29
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 20:58:26 2019 +0100

    torture3: Use file_id_str_buf() in print_brl()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 79291056c5b550c0afa8e4089758ad5e44e15cf0
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 20:57:14 2019 +0100

    smbd: Use file_id_str_buf() in linux_release_kernel_oplock()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f7dc0334810723de5321f021e2d2be9d85a73939
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 20:55:29 2019 +0100

    smbd: Use file_id_str_buf() in linux_oplock_signal_handler()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b0a486fabefaabd63cd2838e503360c0865e21dc
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 18:53:19 2019 +0100

    smbd: Use file_id_str_buf() in scavenger_add_timer()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0dd11a83dc2d4487315f6654f57e7a43ba6ef98e
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 18:32:07 2019 +0100

    smbd: Use file_id_str_buf() in file_find_dif()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 420cb1778d8bb7233465459f269002b254049def
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 18:30:37 2019 +0100

    smbd: Use file_id_str_buf() in scavenger_timer()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 215e7f1fe414c38bbde1c896c16ab21f98943ef1
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 18:27:30 2019 +0100

    smbd: Use file_id_str_buf() in scavenger_schedule_disconnected()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1f5ea9d1d523cdf40c6b2c370abc7f9fa335f5cf
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Nov 7 09:16:44 2019 -0800

    s3: smbd: smb2 cleanup - restructure smbd_smb2_request_pending_timer() encrypt code to look the same as smbd_smb2_request_reply().
    
    This makes code changes in both (if needed) much easier
    to spot.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit c133a1fd6765908e49e2b1808818b515c987ab72
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Nov 7 09:13:12 2019 -0800

    s3: smbd: smb2 cleanup - remove variable tf_len - this is a constant SMB2_TF_HDR_SIZE.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit eae1a45d09ef54dd6b59803eedca672ae9433902
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Nov 7 12:02:13 2019 -0800

    s3: smbd: SMB2 - Ensure we use the correct session_id if encrypting an interim response.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14189
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 30e8f513a8bae58d7d4e88fad8f8d5497076c553
Author: David Mulder <dmulder at suse.com>
Date:   Fri Nov 8 17:10:47 2019 +0000

    Detect when command line max protocol < min protocol
    
    Due to the increased default minimum protocol
    level to SMB2, some users notice that
    specifying smbclient -m NT1 fails with
    NT_STATUS_CONNECTION_DISCONNECTED, with no SMB
    traffic on the wire. Report when the max protocol
    is set less than the min protocol.
    
    Signed-off-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Tue Nov 12 17:52:28 UTC 2019 on sn-devel-184

commit 6cf443ab1f9d0d939d721f58386669202d2fb56e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Oct 25 06:59:45 2019 +1300

    s4-libcli: Remove unused header from composite/composite.c
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14170
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sun Nov 10 22:27:47 UTC 2019 on sn-devel-184

commit 74533b151825416d98912ca8d291637324ccc499
Author: Heiko Baumann <heibau at gmail.com>
Date:   Tue Sep 3 16:30:24 2019 +0200

    Make sure backup temp directory gets deleted on exception
    
    This fix ensures that the samba-tool backup temp directory is removed
    if an exception occurs (e.g. LDAP_INVALID_CREDENTIALS).
    
    Signed-off-by: Heiko Baumann <heibau at gmail.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f9eaf4dc713bab48703a053c9446b6becabe18dc
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 8 13:30:18 2019 +0200

    dns: Always return SOA record for records we should know
    
    Regression introduced by commit 4b54e14b7cf456e327b176b365e8471e0899210b,
    where the number of returned records is not set by talloc_array_length
    when the record is not found.
    
    Found by DELL EMC at SDC SMB3 plugfest trying to perform a secure DNS
    update.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Samuel Cabrero <scabrero at samba.org>
    Autobuild-Date(master): Fri Nov  8 12:31:30 UTC 2019 on sn-devel-184

commit 8dbb8643499c495474f28071750cbfc2da5b60f0
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 8 13:29:28 2019 +0200

    dns: Extend DNS tests to check the SOA record is always returned
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f5f89b1b990a3de0e9366beef81cf1a2ce8374da
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Nov 7 12:12:45 2019 +0100

    ctdb: Use TALLOC_FREE() in a few places
    
    We have a macro for NULLing out the pointer
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Fri Nov  8 01:35:11 UTC 2019 on sn-devel-184

commit 8846887a55b0c97a1639fc6ecb228941cf16b8f2
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:46:38 2019 +0100

    s3:printing: Fix %J substition
    
    print_run_command() uses lp_print_command() which internally performs basic
    substition by calling talloc_sub_basic(). As a result. any of the variables in
    the "basic set", including "%J" are already substituted.
    
    To prevent the unwanted subtitution, we declare all affected configuration
    options as const, which disabled the basic substition.
    
    As a result print_run_command() can run manual substitution on all characters,
    including %J, in the variadic argument list *before* calling lp_string() to run
    basic substition which we had disabled before with the const.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Nov  7 16:01:21 UTC 2019 on sn-devel-184

commit ede00779ab2d881e061adb9d861879e8c68e272b
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:03:31 2019 +0100

    s3:printing: add a DEBUG statement
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 41ab92b62fbf029374b89f9d0ddf7578981f37cf
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 11:57:39 2019 +0100

    s3:lib: factor out talloc_sub_advanced() from talloc_sub_full()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 4736623c24503b3ca09c76c9dbb134ef833b2f80
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:45:44 2019 +0100

    s3: rename talloc_sub_advanced() to talloc_sub_full()
    
    We currently have the following substitution functions:
    
      talloc_sub_basic()
      talloc_sub_advanced()
    
    talloc_sub_basic() currently substitutes a subset of talloc_sub_advanced().
    
    We'll need a function X that only substitutes what talloc_sub_advanced()
    substitutes *without* what talloc_sub_basic() does.
    
    To get there rename talloc_sub_advanced() to talloc_sub_full(). A subsequent
    commit will then bring back talloc_sub_advanced() as described above.
    
    Examples with fictional replacement letters A and B. Currently:
    
      talloc_sub_basic:    A
      talloc_sub_advanced: AB
    
    New:
    
      talloc_sub_basic:    A
      talloc_sub_advanced:  B
      talloc_sub_full:     AB
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a591de28659919d2afd7ed55106cded6a0d9ab35
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 10:19:13 2019 +0100

    s3: remove unused function standard_sub_advanced()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 81ae199bb72886f2f1ed87b22b4c75b6b99c72f6
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:44:45 2019 +0100

    s3: replace standard_sub_advanced with talloc_sub_advanced in one place
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit dcb555c06a6341871b691dab3758e7de04110282
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:43:25 2019 +0100

    s3:printing: fix a long line
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 18cc62b98d47c349d542b435e603d8de72a67200
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 5 21:56:44 2019 +0100

    vfs: Use file_id_str_buf() in vfs_delay_inject_brl_lock_timer()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Nov  6 21:58:52 UTC 2019 on sn-devel-184

commit 2d5aba4d8633d9cf62f6ed7847dad9ebc41f46ce
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 5 21:54:21 2019 +0100

    smbd: Use struct initialization instead of ZERO_STRUCT()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 001371f45e5a069aa9cfaef9c35dc47b371935a8
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    vfs: Use file_id_str_buf() in smb_full_audit_file_id_create()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3f80b8abac3e4a59371017b841cc43dfe486f18e
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in set_write_time()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d04581bfe926013bda2df2beefd836555e53e8f9
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in rename_open_files()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1bbdae2234487393e4a964d59b4d772a8a758eff
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in contend_level2_oplocks_begin_default()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 56f93f21114588e7cef8cf837a57ceaad9f9b8bc
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in process_kernel_oplock_break()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6018cc5a078fbe042910d6bb07850c21d2ffd923
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in process_oplock_break_message()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 75962acade60530ff99663ffbc1ca9d0eb79ccc0
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in initial_break_processing()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6e521461c5d57ddf01904e75b80602d662da9057
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in downgrade_lease()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8dd7b129138d9b89368eb0b5f8f04300672f2e98
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in downgrade_oplock()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c7731649fde2b2336bba3de7e38a9281b3330414
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in set_file_oplock()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d6f952f4c7ca03829d199a3cf9c5b2998146462e
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Nov 3 18:52:07 2019 +0100

    smbd: Use file_id_str_buf() in set_file_oplock()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2651463e19cac9cd346e282b9b6316952c683b2e
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 2 14:08:00 2019 +0100

    ntlm_auth: Fix nonempty line endings
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 995de9c2d2e95a782b81c215efc8d4ab4b3d54b9
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 2 14:01:10 2019 +0100

    ntlm_auth: Simplify session generation
    
    We don't need to parse a text sid, we have those as binary available
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8ec9e97666653469e5bd56ef0576fb0af1406a82
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 2 13:56:49 2019 +0100

    auth: Simplify session generation
    
    We don't need to parse a text sid, we have those as binary available
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dd8aba30483649ea28199241fbc2410b1b4595a5
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 10 16:30:14 2019 +0200

    lib: Avoid includes.h in g_lock.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8febbc2bcd2a136281ad9b4b90537028b6d5c4e2
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 10 13:40:44 2019 +0200

    lib: Remove g_lock_do()
    
    This puts too much logic into this lowlevel infrastructure module,
    given the two minor external users.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9dd65d1f991722bf6686ae21e4607192fc2bf327
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 10 13:38:17 2019 +0200

    net: Avoid the use of g_lock_do()
    
    g_lock_do() does too much in g_lock.c, and it's rarely used.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d9bd074cc8c0859f4f6333080d457a551e6367a4
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 10 10:27:54 2019 +0200

    net: Avoid the use of g_lock_do()
    
    g_lock_do() does too much in g_lock.c, and it's rarely used.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit aaad4d012d83b2e203b7974f56b3f6f72d1c9141
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 21:38:42 2019 +0200

    g_lock: Avoid sys_random(), use generate_random()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d6223677bfded0aed659df4a78f318ffc180003c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 16 15:27:49 2019 +0200

    dbwrap_tdb: Avoid a use of talloc_stackframe()
    
    For really large keys (that probably don't exist), use dump_data()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 54d673742f3a81ecdfb98f66a928d119293697ba
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 21:38:04 2019 +0200

    lib: Remove #define serverid_equal server_id_equal
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b749c923373c7ccdc68ba2aed42c614e6a11d353
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 13:28:11 2019 -0700

    s3: smbd: SMB1 UNIX extensions - remove dead code.
    
    We no longer set delete_on_fail on return from mknod.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Nov  6 19:31:00 UTC 2019 on sn-devel-184

commit b784aee40ffceae8332ff3aaa74c20539857ded6
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 13:39:00 2019 -0700

    s3: smbd: SMB1 UNIX extensions - POSIX mknod should just create the object, not change attributes after.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit d8567d46bd7e371de83e4d1ee1592639eb6f0c06
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 15:04:39 2019 -0700

    s3: smbd: SMB1 UNIX extensions - only allow size change on regular file.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 4b25299c0d00b23c22be1e2a4eed3be5572e623a
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 13:35:44 2019 -0700

    3: smbd: SMB1 UNIX extensions - For POSIX mknod we can only create blk/chr/fifo/sock objects.
    
    Fail requests to create other object types.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 4ca0fcb2d4eec29fc75a285947a77974a0555bea
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 13:25:14 2019 -0700

    s3: smbd: SMB1 UNIX extensions - Ensure POSIX mknod is root-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 35bb734d638e273f2fd1a19220db5f200d3e7489
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 6 08:43:05 2019 +0100

    bootstrap: Fix centos7 image creation
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Nov  6 13:35:17 UTC 2019 on sn-devel-184

commit 6a3b19fb170d13aaed92645866af75cc508d0991
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 5 10:39:16 2019 +0100

    bootstrap: Add Fedora 31
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 1ba0a32e707618012dcf9f06ff48bb15783cf106
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 5 10:38:48 2019 +0100

    bootstrap: Remove Fedora 28 which is already EOL
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit bf99f82077876fc107adb1ed4f07dd7e1351fff9
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Nov 5 15:34:18 2019 +1100

    ctdb-tests: Make process exists test more resilient
    
    This can fail as follows:
    
    --==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--
    Running test ./tests/UNIT/tool/ctdb.process-exists.003.sh (02:26:30)
    --==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--
    ctdb.process-exists.003      - ctdbd process with multiple connections on node 0
    Setting up fake ctdbd
    <10||0|
    OK
    <10|PID 26107 exists
    |0|
    OK
    ==================================================
    Running "ctdb -d NOTICE process-exists 26107 0x1234567812345678"
    PASSED
    ==================================================
    Running "ctdb -d NOTICE process-exists 26107 0xaebbccdd12345678"
    Registered SRVID 0xaebbccdd12345678
    --------------------------------------------------
    Output (Exit status: 1):
    --------------------------------------------------
    PID 26107 with SRVID 0xaebbccdd12345678 does not exist
    --------------------------------------------------
    Required output (Exit status: 0):
    --------------------------------------------------
    PID 26107 with SRVID 0xaebbccdd12345678 exists
    
    FAILED
    connection to daemon closed, exiting
    ==========================================================================
    TEST FAILED: ./tests/UNIT/tool/ctdb.process-exists.003.sh (status 1) (duration: 0s)
    ==========================================================================
    
    This happens when dummy_client has not registered the SRVID (for its
    10th connection) before the 2nd simple_test.
    
    Change the initial wait to ensure that the SRVID is registered.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Wed Nov  6 02:46:24 UTC 2019 on sn-devel-184

commit dd9d5ec5c8de82f343369ec4b26c0f24d465ce24
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 15:22:38 2019 +1100

    ctdb-tests: Improve code quality in ctdb_init()
    
    Improve quoting and indentation.  Print a clear error if the cluster
    goes back into recovery and doesn't come back out.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 3b5ed00054e7d1e34cf33706c670e17a188c67d1
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 15:11:31 2019 +1100

    ctdb-tests: No longer retry starting the cluster
    
    Retrying like this hides bugs.  The cluster should come up first time,
    every time.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit bf47bc18bb8a94231870ef821c0352b7a15c2e28
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 17:28:22 2019 +1100

    ctdb-tcp: Drop tracking of file descriptor for incoming connections
    
    This file descriptor is owned by the incoming queue.  It will be
    closed when the queue is torn down.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
    RN: Avoid communication breakdown on node reconnect
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit d0baad257e511280ff3e5c7372c38c43df841070
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 15:29:11 2019 +1100

    ctdb-tcp: Avoid orphaning the TCP incoming queue
    
    CTDB's incoming queue handling does not check whether an existing
    queue exists, so can overwrite the pointer to the queue.  This used to
    be harmless until commit c68b6f96f26664459187ab2fbd56767fb31767e0
    changed the read callback to use a parent structure as the callback
    data.  Instead of cleaning up an orphaned queue on disconnect, as
    before, this will now free the new queue.
    
    At first glance it doesn't seem possible that 2 incoming connections
    from the same node could be processed before the intervening
    disconnect.  However, the incoming connections and disconnect occur on
    different file descriptors.  The queue can become orphaned on node A
    when the following sequence occurs:
    
    1. Node A comes up
    2. Node A accepts an incoming connection from node B
    3. Node B processes a timeout before noticing that outgoing the queue is writable
    4. Node B tears down the outgoing connection to node A
    5. Node B initiates a new connection to node A
    6. Node A accepts an incoming connection from node B
    
    Node A processes then the disconnect of the old incoming connection
    from (2) but tears down the new incoming connection from (6).  This
    then occurs until the originally affected node is restarted.
    
    However, due to the number of outgoing connection attempts and
    associated teardowns, this induces the same behaviour on the
    corresponding incoming queue on all nodes that node A attempts to
    connect to.  Therefore, other nodes become affected and need to be
    restarted too.
    
    As a result, the whole cluster probably needs to be restarted to
    recover from this situation.
    
    The problem can occur any time CTDB is started on a node.
    
    The fix is to avoid accepting new incoming connections when a queue
    for incoming connections is already present.  The connecting node will
    simply retry establishing its outgoing connection.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit e62b3a05a874db13a848573d2e2fb1c157393b9c
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 15:25:26 2019 +1100

    ctdb-tcp: Check incoming queue to see if incoming connection is up
    
    This makes it consistent with the reverse case.  Also, in_fd will soon
    be removed.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ff47cc661d432a9337ade9a232a4f49164652812
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 31 14:38:35 2019 -0700

    s3: libsmb: Ensure return from net_share_enum_rpc() sets cli->raw_status on error.
    
    Convert net_share_enum_rpc() to return an NTSTATUS and ensure the
    status is set correctly on error so SMBC_errno() can return it.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14176
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Nov  5 12:36:48 UTC 2019 on sn-devel-184

commit a58c93318d592d931d232a1a25e37abdd27a825d
Author: Jones Syue <jonessyue at qnap.com>
Date:   Fri Nov 1 15:50:29 2019 +0800

    s3:libads: Fix mem leak in ads_create_machine_acct
    
    Use 'goto done' instead of 'return' to fix machine_escaped leak.
    
    Signed-off-by: Jones Syue <jonessyue at qnap.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Nov  4 22:48:50 UTC 2019 on sn-devel-184

commit 831796b2d7c1ee13d17238b5b4a2c3d56ab6eaaf
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 4 07:47:15 2019 +0100

    gitlab-ci: Run 'samba' tests also with MIT Kerberos
    
    This runs the tests of the ktest environment.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Nov  4 14:19:17 UTC 2019 on sn-devel-184

commit 176d0f0364bc1deb3c8df2f3bb928e01f89f216b
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 4 08:40:34 2019 +0100

    libcli:smb: Do not use gnutls_aead_cipher_encryptv2() with GnuTLS 3.6.10
    
    The gnutls_aead_cipher_encryptv2() implementation was released with a
    bug. This wont be fixed before 3.6.11.
    
    See https://gitlab.com/gnutls/gnutls/merge_requests/1085
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 03205663b3e5939896c1aad93c4a45cd769b06b4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 15 15:44:34 2019 +1300

    CVE-2019-14847 dsdb: Correct behaviour of ranged_results when combined with dirsync
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14040
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Thu Oct 31 23:29:15 UTC 2019 on sn-devel-184

commit e62c535d5b7d357bed9cb998f523e7c007c59910
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 15 16:28:46 2019 +1300

    CVE-2019-14847 dsdb: Demonstrate the correct interaction of ranged_results style attributes and dirsync
    
    Incremental results are provided by a flag on the dirsync control, not
    by changing the attribute name.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14040
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 4ae0f9ce0f5ada99cf1d236377e5a1234c879ae3
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 1 06:53:56 2019 +1300

    s4-torture: Reduce flapping in SambaToolDrsTests.test_samba_tool_replicate_local
    
    This test often flaps in Samba 4.9 (where more tests and DCs run in the environment)
    with obj_1 being 3.  This is quite OK, we just need to see some changes get
    replicated, not 0 changes.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit fe60eef9781f9970d2fa0705e10a6e8e309f839e
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 28 08:34:16 2019 +0100

    docs-xml: Update krb5_ccache_type in pam_winbind.8
    
    This is a copy from pam_winbind.conf.5
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14173
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Oct 31 19:32:55 UTC 2019 on sn-devel-184

commit 0de9dad9ebc88ab044f4b946ef44f63ae2281649
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Oct 31 17:10:59 2019 +0100

    docs-xml: Improve krb5_ccache_type documentation
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit c714c996017b4167e9a7424e1aecd4437deeed22
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    docs-xml/manpages/pam_winbind.conf.5.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Thu Oct 31 02:18:12 UTC 2019 on sn-devel-184

commit 4b198163d03e97790a3c242f25bbd9949ab0aba1
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    docs-xml/manpages/pam_winbind.8.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 81df8aa7bea88f90d7ad18b00788fec8d2744a91
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    docs-xml/Samba-Developers-Guide/unix-smb.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit a456c2bb02af56ab3d966d673421aab976e632ad
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    ctdb/utils/smnotify/smnotify.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 1e73161bdd791fe97053dc2faa85b28e7ef55327
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    ctdb/utils/scsi_io/scsi_io.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit f3754b64876e7d0c073d86bb6d2e29425d9e8d31
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    ctdb/server/ctdb_daemon.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 5d2a257c2e4a929bb70e4e2a2f31ed243c2efa51
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/server/ctdb_client.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 7722bd80fcde69d13b25a1b120fd3f9ecf6dd7dd
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/server/ctdb_call.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 9fa37484c30b83bc36b1607a82c76a77fe639b71
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/include/ctdb_private.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 493705dc2746ee64a4e2cf1dc290009185853db2
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/ib/ibwrapper_test.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 540325d3cb4eee1964fc59a63d51289552293902
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/ib/ibw_ctdb.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b9d7b85afdf96b6ca443861700b9a22c6145dc6d
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/doc/readonlyrecords.txt: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit cb867b29c9ca2ef7ea7c9f80228f60b32329dd6f
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/doc/ctdb.1.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 93859b3394d87f1521f757111eb8e55633c8cde3
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/doc/ctdb-tunables.7.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 37398acca58ac9d224aa5d841197b378e1d26e68
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/doc/ctdb-statistics.7.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 1b51b444874bc254fbe7b865fab7e416f898e46a
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/common/srvid.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c71a1df18aa1b38c194e6b200b81ac44f6d6770f
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/client/client.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 522697331fc143bb04cc5136d60178533ae61afc
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    buildtools/wafsamba/wscript: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit e6cd8884256e5f433b16b4132ed825054af867e5
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    buildtools/wafsamba/samba_install.py: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit e781db805e53959150c8a385ac60d55f601dde71
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:10 2019 +0200

    source4/scripting/bin/samba_upgradeprovision: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 9092120b0dbcd45149975a11f32073d3877da406
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source4/rpc_server/lsa/lsa_lookup.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b4e0c0d38f501f5b477ac384b900fb2651a44e4d
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source4/libcli/libcli.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 7f41f1374264f854a3c7fc74d10a6a691e2f5f64
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source4/libcli/clireadwrite.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 60fcfa506db3d66b7f51ce1c25b55cb62100c763
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source4/dsdb/schema/schema_description.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 1ca79e64d8c28edcb3c9bdea3470e5a7eb8003ea
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/winbindd/winbindd_util.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 616f9d04660f14c9ccb2dab01442c56e377aa37e
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/utils/net_rpc.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 65d0ea769043637a91cb3b1c6ab9b18ff5e48060
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/smbd/reply.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b61e3233273411d693da0e516e4da09423ca92db
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/registry/reg_parse.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 9f4e97a4d5d044e5be29b503254684197ca244ee
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/registry/reg_import.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c7ceca8451f0ff7f4b0650084faed0614332b86e
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/registry/reg_format.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 07b506c213a965c900b8002766350ebb38e3c9e4
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/modules/vfs_virusfilter.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 12e71a745aedf6906b54dd03ff9d9a18c9d6b523
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/modules/vfs_recycle.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 08ffb9388ec39514a24ca87391ffe715db68db88
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    python/samba/upgradehelpers.py: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c259190db2d232a9db6d25d7cdbca649a56bd26f
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    python/samba/netcmd/gpo.py: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 6e91c52bbb9a5fe0a4057e15cd52ab56ff6682b6
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    python/samba/dbchecker.py: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 5915a40b25cebf7a480b51543cae93021fb091de
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    librpc/ndr/ndr_compression.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b0deb6799c8d40f7c4c8824e11d37594d52e7bd5
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    libgpo/gpo_filesync.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 96c7653ee774eb6f0c08a0cbb473f4c4a42a526e
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    lib/tdb/docs/tracing.txt: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit ba1887d37422f39bd36d0ab17dd1ef8efa56cb63
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    lib/replace/xattr.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c93f06b12d07783104ea833e463f7fd94c0ccb0f
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    examples/VFS/skel_transparent.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c2794780ad09b0fa9d63e4ad31a8ae3c67fa453d
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    dynconfig/wscript: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 2b060f935026e68d7ad7a5d4e614452a5119dae8
Author: Puran Chand <pchand at vmware.com>
Date:   Mon Oct 21 11:39:18 2019 +0530

    s3:smbclient added ABI signature file
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Oct 30 22:18:15 UTC 2019 on sn-devel-184

commit fe7737135a8f4b28cadc0f79e4de5363a8855a38
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 11:44:07 2019 -0700

    s4: torture: Add additional smbc_readdirplus2() tests into readdirplus_seek().
    
    Make sure we haven't broken anything :-).
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a5f850a93f5e2eb371ca0a628c94e28c3d033e0f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 11:29:19 2019 -0700

    s4: torture Add a test for smbc_readdirplus2()
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit abbbbbff376877bbe92f3695e480472a4070937a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 10:29:48 2019 -0700

    s3: libsmb: Added new API smbc_readdirplus2()
    
    Returns the same as smbc_readdirplus() but also
    can return a struct stat if passed in by the caller.
    
    struct stat is synthesized from the data
    returned by the SMB server.
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e26487aab01096492ec5ed4251039147963a8d1b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 09:45:33 2019 -0700

    s3: libsmb: Add missing ino field to internal struct smbc_dirplus_list.
    
    This should have been added to struct libsmb_file_info, but
    this is user-visible so I don't want to change this now. Adding
    it to the containing struct allows us to synthesise a struct stat
    to return from smbc_readdirplus2() to return all the info from
    the server to callers.
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 1f0715c0e5e6ff371e3b393a0b35222c8b6f49bc
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 10:48:55 2019 -0700

    s3: libsmb: Move setting all struct stat fields into setup_stat().
    
    That way we only have one place where a struct stat is synthesised
    for libsmbclient callers.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7d3b4f47be0359b496087fc40f89b815c7958dd6
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 09:34:02 2019 -0700

    s3: libsmb: Move setting st->st_ino into setup_stat.
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d44a84295b46cc6c540a9730a615a59c1f22a277
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 09:24:38 2019 -0700

    s3: libsmb: Change generate_inode()/setup_stat() to modern coding standards.
    
    Change setup_stat() to be void. It doesn't return anything. Export
    so it can be used by upcoming smbc_readdirplus2() call.
    
    Remove unused SMBCCTX *context parameters.
    Remove unused talloc_stackframe().
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f30b8b3aa1309e9daeb9a3601b537dead81e5dbb
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 29 12:11:49 2019 -0700

    s3: utils: smbtree. Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.
    
    Last unprotected call of cli_RNetShareEnum(). Not a libsmbclient
    bug here but might as well fix the last caller as part of the
    fix for the bug.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1cfcad6283da855d3e97237a7a6fd6f4d2436ee2
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 29 12:11:01 2019 -0700

    s3: libsmb: Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 41edeff416407d3eae21c7ad43d891dbacc32662
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Oct 30 15:05:13 2019 +0100

    s3:smb2_server: add message mid to SMB2 request done log message
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Oct 30 18:42:35 UTC 2019 on sn-devel-184

commit dcf51b5aa58752ddfa4fc8814c7432e34fef4330
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Oct 30 14:23:20 2019 +0100

    s3:smb2_server: modernize a debug statement
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f3df83a2c346d945487a27a9d258ee6331ea7dbb
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 24 17:15:18 2019 +0200

    lib/adouble: pass filesize to ad_unpack()
    
    ad_unpack() needs the filesize, not the capped IO size we're using in the caller
    to read up to "size" bystem from the ._ AppleDouble file.
    
    This fixes a regression introduced by bdc257a1cbac7e8c73a084b618ba642476807483
    for bug 13968.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    RN: vfs_fruit returns capped resource fork length
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Oct 30 14:52:34 UTC 2019 on sn-devel-184

commit 9a3da6bebcdb924ca2027337544d79ac2088677e
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Oct 25 15:21:32 2019 +0200

    lib/adouble: drop ad_data reallocate logic
    
    Simply set the buffer size to AD_XATTR_MAX_HDR_SIZE. When reading the
    AppleDouble file, read up to AD_XATTR_MAX_HDR_SIZE from the file.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit baaaf59e948df625b01fa8b6317ab5c3babb4e8f
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 24 17:26:08 2019 +0200

    lib/adouble: README.Coding fix: multi-line if expression
    
    Also remove a TAB.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f0c8ac47a4608eabeae334d39885aab98198b753
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 24 17:17:28 2019 +0200

    lib/adouble: fix a long line
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b63069db9fb6efb33b7b917cd5b0ee06b0da9cdc
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Oct 25 15:41:40 2019 +0200

    torture: expand test "vfs.fruit.resource fork IO" to check size
    
    Reveals a bug where the resource fork size is capped at 65454 bytes.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ef58222616fc3175f189417ce878d8413ba2d294
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Aug 6 16:32:32 2019 +0200

    CVE-2019-14833 dsdb: send full password to check password script
    
    utf8_len represents the number of characters (not bytes) of the
    password. If the password includes multi-byte characters it is required
    to write the total number of bytes to the check password script.
    Otherwise the last bytes of the password string would be ignored.
    
    Therefore we rename utf8_len to be clear what it does and does
    not represent.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12438
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(master): Tue Oct 29 11:58:45 UTC 2019 on sn-devel-184

commit d524c7ddee92a457ba680853b6c25c877d881ff8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Sep 19 11:50:01 2019 +1200

    CVE-2019-14833: Use utf8 characters in the unacceptable password
    
    This shows that the "check password script" handling has a bug.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12438
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 7ccc302b4bb9e0a9b695074959dc45e6fc4902bb
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 6 12:08:09 2019 -0700

    CVE-2019-10218 - s3: libsmb: Protect SMB2 client code from evil server returned names.
    
    Disconnect with NT_STATUS_INVALID_NETWORK_RESPONSE if so.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14071
    
    Signed-off-by: Jeremy Allison <jra at samba.org>

commit 9f7a622b2bd4a42fad3e669e83fe07c5d7115dc6
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Aug 5 13:39:53 2019 -0700

    CVE-2019-10218 - s3: libsmb: Protect SMB1 client code from evil server returned names.
    
    Disconnect with NT_STATUS_INVALID_NETWORK_RESPONSE if so.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14071
    
    Signed-off-by: Jeremy Allison <jra at samba.org>

commit 2669cecc51f8f7d6675b4dac9b345b3c5a7fc879
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Sep 13 10:56:10 2019 +0300

    libnet_join: add SPNs for additional-dns-hostnames entries
    
    and set msDS-AdditionalDnsHostName to the specified list.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Fri Oct 25 10:43:08 UTC 2019 on sn-devel-184

commit db7560ff0fb861552406bb4c422cff55c82f58bf
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Sep 17 21:38:07 2019 +0300

    docs-xml: add "additional dns hostnames" smb.conf option
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 3e65f72b141a7ee256ae581e5f48f1d930aed76a
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 18 23:15:57 2019 +0300

    libnet_join_set_machine_spn: simplify adding uniq spn to array
    
    and do not skip adding a fully qualified spn to netbios-aliases
    in case a short spn already existed.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit b8e1264ececf38681ca9a519a51e8336044673f0
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 18 21:29:47 2019 +0300

    libnet_join_set_machine_spn: simplify memory handling
    
    and avoid a possible memory leak when passing null to
    add_string_to_array() as mem_ctx.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4cbad1eb46896bbd74c5b19dbb0a8937ffde90c2
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 18 20:00:34 2019 +0300

    libnet_join_set_machine_spn: improve style and make a bit room for indentation
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 05f7e9a72a1769af9d41b1ca40fe6a14b3f069d1
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Aug 30 00:22:15 2019 +0300

    libnet_join: build dnsHostName from netbios name and lp_dnsdomain()
    
    This make the join process much more reliable, and avoids "Constraint
    violation" error when the fqdn returned from getaddrinfo has already
    got assigned an SPN.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit d0f566c4ad32d69a1cf896e2dde56fc2489bb7fc
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Oct 4 14:57:40 2019 +0200

    s4:dirsync: fix interaction of dirsync and extended_dn controls
    
    Azure AD connect reports discovery errors:
      reference-value-not-ldap-conformant
    for attributes member and manager.
    The key is that it sends the LDAP_SERVER_EXTENDED_DN_OID without
    an ExtendedDNRequestValue blob, which means the flag value should
    be treated as 0 and the HEX string format should be used.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14153
    RN: Prevent azure ad connect from reporting discovery errors:
    reference-value-not-ldap-conformant
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Oct 24 11:06:58 UTC 2019 on sn-devel-184

commit 6d43d82b49c8cd47da2f1489fe8b52d5a873a19c
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 22 12:12:32 2019 +0200

    s4:tests/dirsync: add tests for dirsync with extended_dn
    
    This demonstrates a problems that the extended_dn returned
    by the dirsync module always uses the SDDL format for GUID/SID
    components.
    
    Azure AD connect reports discovery errors:
      reference-value-not-ldap-conformant
    for attributes member and manager.
    The key is that it sends the LDAP_SERVER_EXTENDED_DN_OID without
    an ExtendedDNRequestValue blob, which means the flag value should
    be treated as 0 and the HEX string format should be used.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14153
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9471508391fd3bcf199b1e94f8d9ee2b956e8f8e
Author: Ralph Boehme <slow at samba.org>
Date:   Sat May 4 12:12:48 2019 +0200

    s3: remove now unneeded call to cmdline_messaging_context()
    
    This was only needed as dbwrap_open() had a bug where it asked for the ctdb
    connection before initializing messaging. The previous commit fixed that so we
    can now safely remove the calls to cmdline_messaging_context() from all tools
    that don't use messaging.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=13925
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Oct 24 09:33:47 UTC 2019 on sn-devel-184

commit ca95d7f41b683b4d7ac59ed6ee709d44abfe2019
Author: Ralph Boehme <slow at samba.org>
Date:   Sat May 4 12:12:04 2019 +0200

    s3:dbwrap: initialize messaging before getting the ctdb connection
    
    This is a better fix for bug #13465.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=13925
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ab71d72138fffff5fc89b246b67cc4b82ca24f05
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Oct 22 09:32:58 2019 +0200

    waf: Symlink the compile database to the source dir for clangd
    
    https://github.com/ycm-core/YouCompleteMe
    https://github.com/abingham/emacs-ycmd
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Oct 24 08:11:19 UTC 2019 on sn-devel-184

commit b28d06be7a0b730fb893b2f208af4ff864cda166
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Sep 25 18:13:26 2018 +0200

    waf: Create clang compilation database
    
    http://clang.llvm.org/docs/JSONCompilationDatabase.html
    
    This can be used by ymcd or clangd.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6de5706b4dbe70c66872abc80dd9301dccb2ee7c
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Aug 14 15:26:25 2019 +1000

    ctdb-tests: Add vacuuming tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Thu Oct 24 05:28:21 UTC 2019 on sn-devel-184

commit 49262a6bc4d5f8b81aa341294bfe04a22a6b32b6
Author: Martin Schwenke <martin at meltin.net>
Date:   Sun Sep 29 08:27:33 2019 +1000

    ctdb-tests: Add handling of process clean-up on a cluster node
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit b9654085f5facfe8a3d64667d65793146563d7f5
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 12 21:02:47 2019 +1000

    ctdb-tests: Factor out function check_cattdb_num_records()
    
    This can be use in multiple vacuuming tests.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5a6d319eea6b281e9f4c35cf6c8889856234a9fd
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Aug 1 15:33:52 2019 +1000

    ctdb-tests: Add ctdb-db-test tool
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 439ef65d290357e513103530183091a9a6fed197
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 27 16:49:01 2019 +1000

    ctdb-client: Factor out function client_db_tdb()
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 41a41d5f3e2b8e16e25221e14939dc5962997ac7
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 14:17:11 2019 +1000

    ctdb-daemon: Implement DB_VACUUM control
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit d462d64cdf001fd5d1cbf2a109df62e087ad0c49
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 15 16:36:44 2019 +1100

    ctdb-vacuum: Only schedule next vacuum event if vacuuuming is scheduled
    
    At the moment vacuuming is always scheduled.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 13cedaf0195c6bda3a3820aedb1ee65f36dfc23e
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 14:16:13 2019 +1000

    ctdb-daemon: Factor out code to create vacuuming child
    
    This changes the behaviour for some failures from exiting to simply
    attempting to schedule the next run.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5539edfdbe69d1d5f084d06753cce8ed6e524999
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Oct 4 12:06:21 2019 +1000

    ctdb-vacuum: Simplify recording of in-progress vacuuming child
    
    There can only be one, so simplify the logic.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 496204feb0e2b6eb2f3d9a74e45596a3e74ad9b1
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 10:52:05 2019 +1000

    ctdb-protocol: Add marshalling for control DB_VACUUM
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a896486b62bbcf9915727ba7bfc768fb5383f0c7
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 16:59:37 2019 +1000

    ctdb-protocol: Add marshalling for struct ctdb_db_vacuum
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit b314835341e4028f0770fa7f9a37d2d21448ddfd
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 10:34:03 2019 +1000

    ctdb-protocol: Add new control CTDB_CONTROL_DB_VACUUM
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit d0cc9edc05b6218a8e20a0a8009cbb9918ff4d02
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Tue Oct 1 15:05:10 2019 +1000

    ctdb-vacuum: Avoid processing any more packets
    
    All the vacuum operations if required have an event loop to ensure
    completion of pending operations.  Once all the steps are complete,
    there is no reason to process any more packets.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 680df07630a94b3e76edefe98ee0986e7e5e1f12
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Wed Jun 6 15:47:13 2018 +0200

    ctdb-daemon: Avoid memory leak when packet is deferred
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c6427dddf5425b267d8c09e8df18653a48679646
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:17:38 2018 +1100

    ctdb-recoverd: No need for database detach handler
    
    The only reason for recoverd attaching to databases was to migrate
    records to the local node as part of vacuuming.  Recovery daemon does
    not take part in database vacuuming any more.
    
    The actual database recovery is handled via the recovery_helper and
    recovery daemon should not need to attach to the databases any more.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit fc81729dd2d8eddea1e60e22b183894d6541c7dc
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:13:35 2018 +1100

    ctdb-recoverd: Drop VACUUM_FETCH message handling
    
    This is now implemented in the ctdb daemon using VACUMM_FETCH control.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 498932c0e8e8614bd52f3270c4d63e2b5f9e26a4
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:01:21 2018 +1100

    ctdb-vacuum: Replace VACUUM_FETCH message with control
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 86521837b684df3b7c5a0a1e3b7e606c8b91f63e
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:00:40 2018 +1100

    ctdb-vacuum: Add processing of fetch queue
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit da617f90d90151f955ee354c57bdc4bc6f6498f2
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 15:30:13 2018 +1100

    ctdb-daemon: Add implementation of VACUUM_FETCH control
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 36f9b4953a8def40681a6f02f6576795a1ba5fbe
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:28:49 2018 +1100

    ctdb-tests: Add marshalling tests for new control
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b71d8cd80f84169bacf2dd1e753e468a305c50ce
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Feb 15 11:57:44 2018 +1100

    ctdb-protocol: Add marshalling for new control VACUUM_FETCH
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 0872c52ef0497f96f53318cf7e4d31be0854adde
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Feb 15 11:57:24 2018 +1100

    ctdb-protocol: Add new control VACUUM_FETCH
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 913bd331f65e9fe3d7cb16e041cd37b01987841f
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Feb 15 12:28:11 2018 +1100

    ctdb-tests: Drop code releated to obsolete controls
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 688567f080156892270cbfb2907cd712cb77cb7a
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Feb 15 12:13:53 2018 +1100

    ctdb-protocol: Drop code related to obsolete controls
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 9f41a9fc1ee10a28d379c8fda49ccfd295d66770
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 8 13:02:41 2019 +0200

    ctdb: Avoid malloc/memcpy/free in ctdb_ltdb_fetch()
    
    Make use of tdb_parse_record()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>

commit 6e8c3ae6e9be38fdd1d1693b93c8629391799b19
Author: Heinz Hoelzl <heinz.hoelzl at gvcc.net>
Date:   Thu Oct 10 10:14:15 2019 +1300

    samba-tool: py3 compatiblity in 'user syncpasswords --daemon'
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14154
    
    Signed-off-by: Heinz Hölzl <heinz.hoelzl at gvcc.net>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Björn Baumbach <bb at sernet.de>
    
    Autobuild-User(master): Björn Baumbach <bb at sernet.de>
    Autobuild-Date(master): Wed Oct 23 15:54:43 UTC 2019 on sn-devel-184

commit 263bec1b8d0744da73dd92e4a361fb7430289ab3
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 21 17:08:08 2019 +0200

    replace: Only link libnsl and libsocket if requrired
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14168
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct 23 08:23:13 UTC 2019 on sn-devel-184

commit 1b69795c5bbc2ed24c54f8295fd3d9e4e0a0f938
Author: Christian Ambach <ambi at samba.org>
Date:   Tue Oct 22 11:02:05 2019 +0200

    s3:lib:wins fix a compile warning on Ubuntu 18.04
    
    gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1) with -O2 puts up a warning here:
    ../../source3/lib/wins_srv.c: In function ‘wins_srv_tags’:
    ../../source3/lib/wins_srv.c:235:3: error: assuming signed overflow does not
    occur when simplifying conditional to constant [-Werror=strict-overflow]
       for (j=0;j<count;j++) {
       ^~~
    cc1: all warnings being treated as errors
    
    Signed-off-by: Christian Ambach <ambi at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    
    Autobuild-User(master): Uri Simchoni <uri at samba.org>
    Autobuild-Date(master): Wed Oct 23 04:57:09 UTC 2019 on sn-devel-184

commit f37b913348e921afee3e578ff0f14b731157eb03
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Oct 21 14:38:47 2019 +0200

    smbd: Save 520 bytes of writable memory from every smbd
    
    Move what can be const from the "data" to the "text" segment
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Wed Oct 23 02:37:12 UTC 2019 on sn-devel-184

commit 0559701478d42e969c8c779d765163271ca9141e
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Oct 21 14:37:04 2019 +0200

    smbd: Remove an unused #define from mangle_hash2.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit ccc486ca1184962df57e380954747f1593317bb5
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 22 08:30:01 2019 +0200

    smbd: Mark #else/#endif with the if-#define
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit aa37668218024aff6bb6518386d4e17a91407633
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 16:42:36 2019 +1100

    ctdb-tests: Add -l option to set number of local daemons
    
    This is the only place where setting an environment variable by hand
    is recommended, so remove the anomaly.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Oct 22 21:02:11 UTC 2019 on sn-devel-184

commit fe80038d074d220487782dc837ea4bd779a6aad0
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 16:33:48 2019 +1100

    ctdb-tests: Prefix remaining environment variables with CTDB_
    
    Now they are clearly all part of CTDB.
    
    TEST_SOCKET_WRAPPER_SO_PATH gets too long in
    integration_local_daemons.bash, so change it to
    CTDB_TEST_SWRAP_SO_PATH instead of just prefixing.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit e8dc125ed2e502234135e12fe32fb387baa11a79
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 16:19:58 2019 +1100

    ctdb-tests: Drop setting of test state directory for testonly target
    
    This is the default and deciding this should be left to run_tests.sh.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit fc16b8dbc69130a039f8492563fcc5ffded2000e
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 16:19:33 2019 +1100

    ctdb-tests: Enable printing of logs on failure in autobuild
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 787662604d4f578f10981845997ccd995f11d853
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 15:53:09 2019 +1100

    ctdb-tests: Add run_tests.sh option to print logs on test failure
    
    Implement this for local daemons integration tests, dumping last 100
    lines of logs.  This makes it possible to debug some failures in
    automated tests where the logs are unavailable for analysis.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5ae330e5a56553b8809f710230101acf044c98e3
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Oct 16 17:21:51 2019 +1100

    ctdb-tests: Avoid running valgrind under valgrind
    
    When run from integration tests $CTDB already includes $VALGRIND, if
    set.  So only add $VALGRIND if $CTDB is not set.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit b8461b422d94b836eb952a3a5363cf03eb347e95
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Oct 14 10:15:07 2019 +1100

    ctdb-tests: Simplify tool unit test runner
    
    There is no good reason why the code needs to be this way.  The
    intervening code was removed years ago leaving a more complex version
    of something very simple.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ce3fdc4dee373a2f9ab55ffa83a97ac690109b09
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Mon Sep 2 04:26:08 2019 -0500

    samba-tool domain: fix an unhandled exception
    
    Uncaught exception on running 'samba-tool domain schemaupgrade'
    
    ERROR(<class 'ModuleNotFoundError'>): uncaught exception - No module named
    'markdown' File "/usr/lib64/python3.7/site-packages/samba/netcmd/__init__.py",
    line 185, in _run return self.run(*args, **kwargs) File
    "/usr/lib64/python3.7/site-packages/samba/netcmd/domain.py", line 4157, in run
    from samba.ms_schema_markdown import read_ms_markdown File
    "/usr/lib64/python3.7/site-packages/samba/ms_schema_markdown.py", line 26, in
    <module> import markdown
    
    Signed-off-by: Amit Kumar amitkuma at redhat.com
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 799b05cf7f9e49db71a731fdf9264311703fd3cf
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Tue Jul 16 02:29:44 2019 +0530

    net: 'net ads gpo getgpo' command not dumping gpo
    
    We have passed dump_gpo(debuglevel=1), hence gpo is not
    dumped at debuglevel=0. But end user will expect gpo
    to be dumped without setting debug flag.
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 6ebd0ba735e6fdddc4d7ded57879d85a42aabf05
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:57:22 2019 +0100

    s3/libsmb: clang: Fix 'the left operand of '-' is a garbage value'
    
    Fixes:
    
    source3/libsmb/clifile.c:360:19: warning: The left operand of '-' is a garbage value <--[clang]
            if (data[num_data-1] != '\0') {
                     ~~~~~~~~^
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Oct 22 18:48:43 UTC 2019 on sn-devel-184

commit 4ef40d41f606f631411991101ed826733a74a8b7
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:55:13 2019 +0100

    s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
    
    Fixes:
    
    source3/libsmb/clirap.c:1490:9: warning: Assigned value is garbage or undefined <--[clang]
                    *mode = attr;
                          ^ ~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 61621009980a4c4a8b64bde8e03370152df0cdce
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:52:46 2019 +0100

    s3/libsmb: clang: Fix 'Value stored to 'p' is never read'
    
    Fixes:
    
    source3/libsmb/clirap.c:145:3: warning: Value stored to 'p' is never read <--[clang]
                    p = rdata;
                    ^   ~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 764bb47a370c6a5d5d73b8855d141c2d4cbd6f58
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:43:30 2019 +0100

    s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
    
    Fixes:
    
    source3/libsmb/smbsock_connect.c:786:13: warning: Assigned value is garbage or undefined <--[clang]
                    state->fd = fd;
                              ^ ~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4995a0e7e05c4affc9f1f7992cef54e57d9efdc0
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:36:56 2019 +0100

    s3/libsmb: clang: Fix 'Value stored to 'create_options' is never read'
    
    It looks like the create_options are accumulated as the depending on the
    failure reasons returned for cli_smb2_create_fnum (except for when a
    directory is encountered) this looks like a mistake
    Fixes:
    
    source3/libsmb/cli_smb2_fnum.c:1870:3: warning: Value stored to 'create_options' is never read <--[clang]
                    create_options |= FILE_DIRECTORY_FILE;
                    ^
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 25a256bedf2992771b6ea1263fb5e730b27a53dc
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:27:35 2019 +0100

    s3/libsmb: clang: Fix 'Dereference of undefined pointer value'
    
    Fixes:
    
    source3/libsmb/clidfs.c:350:3: warning: Dereference of undefined pointer value <--[clang]
                    DLIST_ADD_END(referring_cli, cli);
                    ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7a4da41c1efb62f5e528907a2e6c0aab766994e1
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:22:37 2019 +0100

    s3/libsmd: clang: Fix some uninitialized value errors
    
    Fixes:
    
    source3/libsmb/clilist.c:534:14: warning: 1st function call argument is an uninitialized value <--[clang]
            num_finfo = talloc_array_length(finfo);
                        ^
    source3/libsmb/clilist.c:1007:13: warning: The right operand of '<' is a garbage value <--[clang]
            for (i=0; i<num_finfo; i++) {
                       ^~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e9dd8821adf1696f2ab292275cc0ee859e4a24c4
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:18:10 2019 +0100

    s3/libsmb: clang: Fix 'Value stored to 'p' is never read'
    
    Fixes:
    
    source3/libsmb/climessage.c:73:2: warning: Value stored to 'p' is never read <--[clang]
            p += hlen;
            ^    ~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6a9041ba437464bbe32738ae807e4053c4a5f1ef
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Oct 22 11:49:22 2019 +0200

    autobuild: rename samba-ad-member-* to samba-admem-*
    
    Needed to come around MAX pathlen limit for UNIX domain socket triggered by
    the new samba-ad-member-mitkrb5 target added in samba-ad-member-mitkrb5.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Oct 22 14:53:17 UTC 2019 on sn-devel-184

commit 1722e5fb1c3df34fd8eb3f7d215b6d9a913ee45f
Author: Marco Wang <m.aesophor at gmail.com>
Date:   Wed Aug 28 17:29:31 2019 +0800

    s3: include: printing: align function parameters
    
    Signed-off-by: Marco Wang <m.aesophor at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Oct 21 16:01:56 UTC 2019 on sn-devel-184

commit 31563f5759f9aeab35b566e77e6ec20b0c4589e1
Author: Marco Wang <m.aesophor at gmail.com>
Date:   Wed Aug 28 17:28:26 2019 +0800

    s3: include: printing: fix indentation of struct printif
    
    Signed-off-by: Marco Wang <m.aesophor at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 073dc735b4e286ff1c57cb2634832eb04a78baac
Author: Marco Wang <m.aesophor at gmail.com>
Date:   Wed Aug 28 17:26:14 2019 +0800

    s3: include: printing: move copyright notice to beginning
    
    Signed-off-by: Marco Wang <m.aesophor at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit fd5cf415a7536c9f020fff57a707caa703c33b9c
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Sep 28 14:51:43 2017 +0200

    s4:kdc: fix the principal names in samba_kdc_update_delegation_info_blob
    
    We need the target service without realm, but the proxy services with realm.
    
    I have a domain with an w2008r2 server and a samba and now both generate
    the same S4U_DELEGATION_INFO.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 90bdaaf09d9c5595170272bd0bfebaac0a90ae01
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sun Oct 13 22:32:36 2019 +0300

    selftest: add a test for PAC delegation-info blob in S4U2Proxy
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d6a4eea5fd284755d181426dba84ddd5c1ba9769
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Oct 16 00:55:04 2019 +0300

    selftest/remote_pac: split test_PACVerify() in two
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 5216fd2287260eeb4864a465121ff7870896e697
Author: Christian Schulz <chris at schocktools.de>
Date:   Mon Oct 14 15:27:36 2019 +0200

    smbstatus: fix column length for DenyMode
    
    Signed-off-by: Christian Schulz <chris at schocktools.de>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Oct 21 01:26:29 UTC 2019 on sn-devel-184

commit 7b1466cc1e0c25930ca4f8296b31f33e3a7cce2f
Author: Christian Schulz <chris at schocktools.de>
Date:   Mon Oct 14 15:24:20 2019 +0200

    smbstatus: use display print function
    
    Signed-off-by: Christian Schulz <chris at schocktools.de>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c1349c44d94b3f16daa7286a2762ad05567d8563
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Oct 18 13:31:38 2019 +0200

    s3:waf: Remove check for fdatasync
    
    This is already checked by libreplace as replace also provides it.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Sun Oct 20 14:52:40 UTC 2019 on sn-devel-184

commit 649d15bb969b6d27fd4554f49600366bb3df4712
Author: Uri Simchoni <uri at samba.org>
Date:   Wed Oct 9 21:53:43 2019 +0300

    autobuild: harden samba-xc test suite
    
    Add more checks which directly test the behavior of
    --cross-answers and --cross-execute.
    
    Previous test tested things in a round-about way, checking
    that running in all three modes (native, cross-execute,
    cross-answers) yields the same result. It was vulnerable
    to a degradation in which cross-compilation modes didn't
    work at all and were running native tests, which is
    what happened with the upgrade of waf.
    
    The added tests check the following:
    - That cross-excute with cross-answers sets the cross-answers file
    - That the content of cross-answers file actually affects the build
      configuration
    - That a missing line in cross-answers fails the build
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Uri Simchoni <uri at samba.org>
    Autobuild-Date(master): Sun Oct 20 13:29:58 UTC 2019 on sn-devel-184

commit fdfd69840902f4b13db2a204a0ca87a578b61b85
Author: Uri Simchoni <uri at samba.org>
Date:   Mon Oct 7 00:37:41 2019 +0300

    wafsamba: pass environment to cross-execute tests
    
    This can come in handy for cross-execute scripts in general, and
    is particularly required by the samba-xc test for cross-answers /
    cross-execute, because Samba sets LD_LIBRARY_PATH during rpath
    checks, and the test program needs that in order to successfully
    run.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5a4ade953420a4122c80d291ac53310abd6a279c
Author: Uri Simchoni <uri at samba.org>
Date:   Mon Oct 7 00:37:31 2019 +0300

    wafsamba: avoid pre-forking if cross-compilation is enabled
    
    Waf supports pre-forking to run configuration tests, but this
    doesn't play well with Samba's cross-compilation support, because
    Samba monkey-patches the actual fork+exec, which doesn't happen
    in a pre-forked process pool.
    
    This patch emulates the impact of WAF_NO_PREFORK env var when
    cross-compilation is enabled.
    
    The blueprint for the solution has been suggested by Thomas Nagy
    in https://bugzilla.samba.org/show_bug.cgi?id=13846#c7 (item #2)
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e00e93350288dc212fed3f1be2adf78dcb6e58e7
Author: Uri Simchoni <uri at samba.org>
Date:   Mon Oct 7 00:37:17 2019 +0300

    wafsamba: use test_args instead of exec_args to support cross-compilation
    
    exec_args seems to have been a custom addition to Samba's copy of waf.
    Upstream Waf has an identically-purposed parameter called test_args.
    
    This parameter is being used for addiing runtime args to test programs that
    are being run during configuration phases.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 09e282ec8173f2935bdb579e0396f269ce712e0d
Author: Uri Simchoni <uri at samba.org>
Date:   Mon Oct 7 00:36:42 2019 +0300

    waf: upgrade to 2.0.18
    
    This is required to get the new test_args parameter to conf.check, which
    facilitates passing arguments to configuration test programs.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0afd655e80262ea8505a2e6d0dd9cc453fbdfd8c
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 15 10:56:54 2019 +0200

    dbwrap_watch: Fix cleaning up dead watchers
    
    "wrec->num_watchers" changes in dbwrap_watch_rec_del_watcher(). In
    32d6cc84c I forgot to update the copy of that variable.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Oct 18 22:28:07 UTC 2019 on sn-devel-184

commit 75433f60522b935adb8c14fc6d0caa14c85281b3
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 15 10:55:25 2019 +0200

    dbwrap_watch: Test cleanup of dead watchers
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 50f69b60549b5d963e83a96315953e074517c096
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:53:32 2019 +0200

    librpc:core: Make dcesrv_find_endpoint public
    
    Will be used from s3 implementation when a connection is passed to other
    process where a particular association group was created.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Oct 18 17:30:39 UTC 2019 on sn-devel-184

commit e10028a05000f6b7a2a8252352ad5f720ad23e86
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:51:53 2019 +0200

    librpc:core: Return NTSTATUS for dcesrv_find_endpoint
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 08c663828c9482767b5128820f8204fd0fe4654e
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:46:59 2019 +0200

    librpc:core: Rename find_endpoint to dcesrv_find_endpoint
    
    This function will be public and available for s3 and s4 implementations.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 73948df2f1a5dbef0f073933be549e4320013913
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:44:10 2019 +0200

    librpc:core: Initialize static variable
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 6a6546b565793341f3be6a6fcf30a40a186f9ae9
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 1 16:48:01 2019 +0200

    librpc:core: Allocate struct dcesrv_interface with talloc
    
    The S3 implementation needs to reinit the dcesrv_context and free the
    endpoints list with their registered interfaces.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 52727543b05c80742e187014ce1048fe7b104bdc
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 4 17:37:01 2019 +0100

    librpc:core: Set debug class
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 491102b5b2ca56375d5a58e98f1c037298aa89f3
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:38:31 2019 +0200

    s4:rpc_server: Move core functions to core library
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 076ec9173efc2b666be36630e38beab4624638a8
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 18:39:58 2019 +0200

    s4:rpc_server: Move core structures and prototypes to core library
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 3f33fdf2e36742ec98e3406f2ecaaa4758ce2a51
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 18:05:04 2019 +0200

    librpc: Add new dcerpc server core library
    
    Next commits will move the core of s4 rpc server to this library.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 480dd6163b28d97ba89ceccbf84d7a730d7017aa
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 20:55:27 2019 +0100

    s4:rpc_server: Make functions public
    
    These functions will be moved to core dcerpc library and called from
    s4 and s3 implementations.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 0523f0b4d28ca125c207448167608d170b9c0909
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 15:59:04 2019 +0100

    s4:rpc_server: Add public function dcesrv_connection_loop_start
    
    This function starts the server loop and will be called from s3 and s4
    implementations.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 85de73354d982861cc863b4682a8043c22797faa
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 20:25:58 2019 +0100

    s4:rpc_server: Add transport termination function pointer
    
    As the dcesrv_terminate_connection function will be moved to the shared
    rpc server core library, hide the stream_terminate_connection call behind
    a function pointer.
    
    The s3 implementation will define its own termination function.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 55ad4ae7ffcb3221675070b9cb939c29e00f25f4
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 17:35:03 2019 +0200

    s4:rpc_server: Find association groups through context callbacks
    
    Split the association group management from the server code, the s3 and
    s4 implementation will handle differently.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit b0ecc8ef55dc7e8c7ce9f7f3ca325358f62debfb
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 17:26:54 2019 +0200

    s4:rpc_server: inline the dcesrv_assoc_group_find function
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 6fe23fa071d2dc6e348b175b514c99a6ce82b6f4
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 20:34:03 2019 +0100

    s4:rpc_server: Hide gensec prepare behind function pointer
    
    This function will be different for s3 and s4
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit bf097719534be55abaab931ca03b8be23ef1fe0a
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 20:03:44 2019 +0100

    s4:rpc_server: Add dcesrv_context_callbacks to dcesrv_context
    
    Add a new struct dcesrv_context_callbacks in dcesrv_context to hold pointers
    to functions whose implementation will differ between S3 and S4.
    
    The log_successful_dcesrv_authz_event implementation will differ as it
    requires an imessaging_context.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 6fcf8038e49ed7f0996ad21fb9f516de30131df7
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 16:59:49 2019 +0200

    s4:rpc_server: Do not include s4 librpc headers in dcerpc core
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 63b78894618a9badac595fbc59cea0f097feeded
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 12:03:45 2019 +0100

    librpc: Move dcerpc_log_packet from s4 librpc to common librpc
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ae9956a65e6913a73dfa68e2b5deebfeaf52c0e5
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 16:44:36 2019 +0200

    librpc: Move dcerpc_ncacn_push_auth from s4 librpc to common librpc
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit b6c8afa98c5c1f9853b09fd83b039aacc79700db
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 16:40:53 2019 +0200

    s4:librpc: Rename ncacn_push_auth to dcerpc_ncacn_push_auth
    
    Next commit will move this function to common librpc
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 83def9a945f40892aaf0e4ea6ea7845d74bbaf7c
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Jan 23 20:52:50 2019 +0100

    s4:rpc_server: Split dcerpc_generic_session_key for server and client
    
    Split the common bits of dcerpc_generic_session_key to librpc and rename
    client the specific part to dcecli_generic_session_key.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f402b937f4862843015686b8e28504fe588d0c5f
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Jan 23 20:41:54 2019 +0100

    s4:rpc_server: Remove server_id from dcerpc core structs
    
    Add a helper function to retrieve it from the stream connection.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 3d7167f4f43f5cf8ca4393d8d852bd146bf05cde
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Jan 23 20:37:21 2019 +0100

    s4:rpc_server: Remove imessaging_context from dcerpc core structs
    
    Add a helper function to retrieve the imessaging_context from the
    stream connection.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 3d529762df48205f91e4089178f7aeae240d0da8
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 13:38:29 2019 +0100

    s4:rpc_server: Rename common/reply.c to dcesrv_reply.c
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 4d7a916189c8d910c22eb46c9fe0f061d83cab59
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Mon Sep 30 23:35:55 2019 +0200

    s4:rpc_server: Cleanup includes
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d572219e1bfcd9342f0841b4faa446fd41bbb42d
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Fri Jan 25 09:54:03 2019 +0100

    s4:rpc_server: Fix debug string printing duplicated function name
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 61aaebaa356102eccd996b6c6cd2641354caa2d3
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 19 12:43:02 2019 +0100

    s4:torture: Assert connection
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e4b1354066f302475975006f5dfa8736ca34396e
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 19 12:42:11 2019 +0100

    s4:torture: Fix torture comment
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f43e08259c0f41d598f6c7632195e67f80a1f82b
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 19 12:41:38 2019 +0100

    s4:torture: Add braces
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 27b01d0aa362b3b226696b9ab7df855fe6fd1ab9
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Mon Sep 30 23:33:09 2019 +0200

    tstream_npa: Set local server name in auth requests
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e70dbe7d8aad650c6f14e7d78dca522d1ac9d898
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 1 17:21:00 2019 +0200

    s3:printing: Add spoolssd header file
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8b761b126c1a476a2ac36c90c87d0183ba34f4a8
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 1 17:14:04 2019 +0200

    s3:printing: Add header inclusion guards in queue_process.h
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8bc228900e8cbc271543add56a2fc98002548a55
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Sep 12 19:05:57 2019 +0200

    s3:smbd: Add header inclusion guards in globals.h
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 9a02c31deb1a295a5cf403aba378057dfcd44268
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Oct 18 21:11:13 2019 +1300

    lib: Explicitly refuse to truncate unix domain socket paths
    
    This avoids creating a socket like:
    
    .../winbindd_privileged/p
    
    instead of
    
    .../winbindd_privileged/pipe
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8e55a8562951924e4b1aad5a6d67fc8b309590c1
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 17 12:41:08 2019 -0700

    s3: torture: Ensure SMB1 cli_qpathinfo2() doesn't return an inode number.
    
    Piggyback on existing tests, ensure we don't regress on:
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14161
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d495074ee27a5f528d5156a69800ee58d799b1eb
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 17 11:39:02 2019 -0700

    s3: libsmb: Ensure SMB1 cli_qpathinfo2() doesn't return an inode number.
    
    The info level it uses doesn't return that, previously we
    were using the field that is returned as the EA size as
    the inode number (which is usually zero, so the code in
    libsmbclient would then synthesize an inode number from
    a hash of the pathname, which is all it can do for SMB1).
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14161
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7c83b1ade7a79770689d876e985e245f5af276ad
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Oct 16 16:47:26 2019 +1300

    dsdb: Change LDB_TYPESAFE_QSORT() to TYPESAFE_QSORT() in operational module
    
    This call does not use the context argument so no additional parameter is needed.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Oct 18 10:58:45 UTC 2019 on sn-devel-184

commit 5bc35614253b4769590813249274355fd3d2ae53
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Oct 16 16:39:35 2019 +1300

    s4-rpc_server: Change LDB_TYPESAFE_QSORT() to TYPESAFE_QSORT() in getncchanges
    
    This call does not use the context argument so no additional parameter is needed.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 517342399c0a558fc016d06ce7728f3c56ef952e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Oct 16 16:38:38 2019 +1300

    dsdb: Change LDB_TYPESAFE_QSORT() to TYPESAFE_QSORT() in repl_meta_data module
    
    This call does not use the context argument so no additional parameter is needed.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 25b1e478ec5e8ac40d41013a824311824482fa67
Author: Anoop C S <anoopcs at redhat.com>
Date:   Wed Oct 16 14:33:06 2019 +0530

    s3/dump_core: Have a newline towards the end of log message
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    
    Autobuild-User(master): Uri Simchoni <uri at samba.org>
    Autobuild-Date(master): Fri Oct 18 08:54:04 UTC 2019 on sn-devel-184

commit c4e902be7226e596d7bbba8baf4389eeab0ca8b6
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Fri Apr 12 00:46:49 2019 +0200

    Add fuzzing binary for ldb_parse_tree
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit de7c78335de63f95f97f946aec287b7bb87f6b47
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Wed Apr 10 01:20:36 2019 +0200

    Add fuzzing binary for ldap_decode
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit f9c39237adfaf1ea223e5c810d019f433af95cf0
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Wed Apr 10 00:36:03 2019 +0200

    Add fuzzing binary for lzxpress
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit a42a5a42f79cc886d752de1645638e24c600c4d0
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Thu Apr 4 02:26:26 2019 +0200

    Add fuzzing binary for regfio
    
    Checksums are better ignored during fuzzing, hence a flag is added to
    the regfio parser to disable checksums.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 6b6df73b4ce20286b1b7370750d11d0d648d7752
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Mon Sep 23 21:53:55 2019 +0000

    regfio: Allow ignoring of checksum
    
    In order to get good coverage fuzzing code has to either calculate
    checksums correctly or to disable their verification. This change
    implements the latter for the "REGF_FILE" structure used by the
    "regfio_*" family of functions.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit e477a94ffd3795d7d8aa83e899e9b0f2f9860a79
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Fri Apr 5 00:50:09 2019 +0200

    Add fuzzing binary for reg_parse
    
    A temporary file is used to store the fuzzing input.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 799a1f65f6cc80256b6e140b7763396d76d4a830
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Mon Sep 23 21:47:51 2019 +0000

    Build registry parsing code into subsystem
    
    Fuzzing code will make use of the "reg_parse_fd" function. By building
    it into the "SMBREGISTRY" subsystem it can just be linked and
    "reg_parse.c" doesn't need to be explicitly included.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 68155811aba10a498cc07bf8a1c6f3a092e6147c
Author: Rowland Penny <rowland at devstation.samdom.example.com>
Date:   Tue Jul 2 13:41:34 2019 +0100

    samba-tool: Add facility to add rfc2307 attributes to an already created user or group
    
    Signed-off-by: Rowland Penny <rpenny at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andrew Bartlet <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Oct 17 12:21:55 UTC 2019 on sn-devel-184

commit aacbd383b9e843b5d36b91ef75f6f2d2724a438b
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Fri Jun 28 04:51:57 2019 +0530

    samba-tool: Update 'samba-tool gpo list <>' description
    
    We have a command to get gpo listing from Active Directory.
    samba-tool gpo list <username>
    
    This command can list GPOs for both username and machinename,
    But command help only shows 'username'.
    
    This PR
    - Updates the option presented in help.
    - Updates name of variable used to retrieve GPO so that it's
     not misleading if someone reads code later on
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14016
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Oct 17 09:21:20 UTC 2019 on sn-devel-184

commit 6bd2f0e9c4da1cad10a778da0c86e14d69ad5036
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Fri Sep 27 01:42:20 2019 -0500

    docs: modifies 'net ads dns gethostbyname -h' Changes server to nameserver and name to hostname.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14009
    
    Signed-off-by: Amit Kumar amitkuma at redhat.com
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit dd43bb96fda3c030662b810fd82bafb03ac93aa2
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Wed Jun 26 01:18:52 2019 +0530

    docs: Add 'ads dns command' text in man net
    
    This change adds contents to man net for 'ads dns' command set.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14009
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit aed4d0637675629a33585a0198c8cbbb64371638
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Jun 6 08:40:42 2019 +1200

    libcli smb smb1cli_trans: fix ubsan warning
    
    Fix ubsan warning null pointer passed as argument 2 when the source
    pointer is NULL.  The calls to memcpy are now guarded by an
    if (len > 0)
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct 16 18:00:31 UTC 2019 on sn-devel-184

commit 50cce842a230f82018be62fca8fe1374b9b0dcd1
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Thu Jun 6 01:54:31 2019 +0530

    docs: Add 'net gpo command' text in man net
    
    This change adds contents to man net for 'net ads gpo' command
    set based on results got after executing:
    '# net ads gpo help' and subcommands
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13986
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit eb093c5d2ac77889215356ffabb915861cd4e9d5
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Fri May 31 18:57:52 2019 +0530

    s3:winbind: Don't abort when receiving a NULL SID
    
    Source code in winbind_rpc.c states that if the trusted domain
    has no SID, winbindd just aborts the session. This happens with
    MIT Kerberos realm added as trust to AD and winbindd just returns
    without processing further as there is no SID returned for the
    Linux system having kerberos support.
    
    This fix makes winbindd to skip the domain having NULL SID instead
    of aborting the request completely.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13913
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d023b29876dc1449014c3cf5d19abb6f186e166c
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Tue May 21 08:49:08 2019 +1200

    selftest: Disable RTLD_DEEPBIND if running with ASAN
    
    Disable the RTLD_DEEPBIND option for dlopen in LDB and Socket Wrapper when
    running with  AddressSanitizer. The RTLD_DEEPBIND option is not compatible
    with Address Sanitizer see
    https://github.com/google/sanitizers/issues/611
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct 16 15:41:41 UTC 2019 on sn-devel-184

commit f0abf62adcf4bda6dd7b36ce74695f8ac8ec79f6
Author: Bryan Mason <bmason at redhat.com>
Date:   Wed Sep 25 18:49:56 2019 -0700

    s3:tests: Add smbspool test for CUPS-like "sanitized" Device URI in argv[0]
    
    Before calling a backend like smbspool, CUPS will set argv[0] to the
    "sanitized" Device URI (the Device URI with username/password
    information removed).  These changes are intended to catch problems
    with smbspool that may be created by this behavior (like
    https://bugzilla.samba.org/show_bug.cgi?id=14128).
    
    source3/script/tests/smbspool_argv_wrapper.c: added to emulate
    CUPS-like behavior by setting argv[0] to the device URI before
    exec()ing smbspool.
    
    source3/script/tests/test_smbspool.sh: updated to use
    smbspool_argv_wrapper to test the CUPS-like behavior described above.
    
    Signed-off-by: Bryan Mason <bmason at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct 16 10:55:04 UTC 2019 on sn-devel-184

commit 7259197bf716f8b81dea74beefe6ee3b1239f172
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Oct 15 17:01:48 2019 +0300

    s3:libsmb: Link libsmb against pthread
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit d473f1e38c2822746030516269b4d70032cf9b2e
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Oct 15 13:52:42 2019 +0300

    nsswitch: Link stress-nss-libwbclient against pthread
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit b01169ff32188939752c064e2eb803f57a837522
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:35:37 2019 -0700

    s3: VFS: Complete the removal of SMB_VFS_CHOWN()
    
    No longer used anywhere.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Oct 15 20:07:51 UTC 2019 on sn-devel-184

commit e2863a7e395bc5b73f8d9ef7bca7c21f20c7eeb3
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:30:42 2019 -0700

    s3: VFS: vfs_full_audit: Remove chown_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the chown_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit bd807d4684b48047ab2241602bb46af38a9d0f33
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:29:30 2019 -0700

    s3: VFS: vfs_time_audit: Remove chown_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the chown_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit ce63e83a6af38a0ac5e353a0cfd6c6cc1d2daa13
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:28:38 2019 -0700

    s3: VFS: vfs_cap: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 04e70da30b2166a5cfc73484cb156c66d4e1faf5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:27:36 2019 -0700

    s3: VFS: vfs_snapper: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 1516e9e2859bb33bec5e829c1ca9011c2563d801
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:26:59 2019 -0700

    s3: VFS: vfs_shadow_copy2: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3e2c2fdf0271e48538d8004ef03aac7e9d6eec3f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:26:12 2019 -0700

    s3: VFS: vfs_media_harmony: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3e8f319606b898b803c1368154c87ee41dc2c78b
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:25:31 2019 -0700

    s3: VFS: vfs_glusterfs: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3a853a1d3b5b6c8d82a7887b35fd383bab0c6c1b
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:24:46 2019 -0700

    s3: VFS: vfs_fruit: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 774b8f9ffb287c6011518caf341fed4538bc8eb5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:24:00 2019 -0700

    s3: VFS: vfs_fake_acls: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3f8f797975931854e485fbf649b75897f0d6f775
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:23:15 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 95a6505e1bcbe89d0d39286668b04b948b1bed4f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:22:35 2019 -0700

    s3: VFS: vfs_ceph: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 48335c1f69076ffa7bdbca99a5025f61148506fd
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:21:51 2019 -0700

    s3: VFS: vfs_catia: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 2eca6d5b9551bd387e809fc77e496a2dc2c1595a
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:20:02 2019 -0700

    s3: VFS: vfs_cap: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 177f15ebb9e29a4cc6843a300f3da0ba7530332d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:18:32 2019 -0700

    s3: torture: Remove cmd_chown() - can be replicated by cmd_open()->cmd_fchown().
    
    Last user of SMB_VFS_CHOWN() in the codebase.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 634a4d13e197e01ae509c88bd6c6487008a86f71
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:14:13 2019 -0700

    s3: pysmbd: Change py_smbd_chown() to use SMB_VFS_FCHOWN() internally.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 99bfdb6e81925760af2a6e89fc6ac55768c88b78
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 8 13:46:02 2019 -0700

    s3: smbd: Remove vfs_chown_fsp().
    
    No longer used. This gets rid of another case
    where we were playing directory changing games
    that are eliminated by just using a file handle.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 2dbc68e2c0212e3e14f304e359d4d0b1ab514ce2
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 8 13:45:45 2019 -0700

    s3: smbd: set_nt_acl(). Now we know we always have a valid file handle, always use VFS_FCHOWN.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit c16cc9a7ef3dc50df511d6a39437347ebc36383e
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Oct 11 08:28:30 2019 +0200

    audit_logging: Don't spam the logs if dsdb_event is not found
    
    This gets only registered by our tests.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Oct 14 07:41:52 UTC 2019 on sn-devel-184

commit 123584294cfd153acc2d9a5be9d71c395c847a25
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 16:32:47 2019 +0200

    s3:libads: Do not turn on canonicalization flag for MIT Kerberos
    
    This partially reverts 303b7e59a286896888ee2473995fc50bb2b5ce5e.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14155
    
    Pair-Programmed-With: Isaac Boukris <iboukris at redhat.com>
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Sat Oct 12 17:39:13 UTC 2019 on sn-devel-184

commit 93c2b446755bd89c7ace8c6ee0445a361f8e17ca
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 16:59:59 2019 +0200

    testprogs: Add test for kinit with canonicalization
    
    Pair-Programmed-With: Isaac Boukris <iboukris at redhat.com>
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 0cad882380cc361a4106dc12aeb0582a6dccdd88
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 16:57:11 2019 +0200

    s4:selftest: Do not print the target env twice
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 46068d5f289948a7d478c23391e0036f69d693a4
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 15:55:50 2019 +0200

    gitlab-ci: Run several AD tests with MIT KDC
    
    This will avoid introducing regressions in either client or server code.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a06889f6d774ba62be2103da2340b98b3ada6654
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Oct 10 09:14:24 2019 +0200

    s4:selftest: Do not print the target env twice
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d888655244b4d8ec7a69a042e0ff3c074585b0de
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 20:11:03 2019 +0200

    lib:krb5_wrap: Do not create a temporary file for MEMORY keytabs
    
    The autobuild cleanup script fails with:
    
    The tree has 3 new uncommitted files!!!
    git clean -n
    Would remove MEMORY:tmp_smb_creds_SK98Lv
    Would remove MEMORY:tmp_smb_creds_kornU6
    Would remove MEMORY:tmp_smb_creds_ljR828
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 23ea12e98ed34d41aee78d8afbe574dfc7e0ff74
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 4 17:04:12 2019 +0300

    spnego: fix server handling of no optimistic exchange
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Sat Oct 12 15:51:42 UTC 2019 on sn-devel-184

commit 8a96359977249e8b19f50e5f2fe3f6ad7b7da52f
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Oct 11 00:20:16 2019 +0300

    python/tests/gensec: add spnego downgrade python tests
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Pair-Programmed-With: Andreas Schneider <asn at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit eee1e8b6ac622e22a34ebfb684e70626cdd20fc1
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Oct 11 13:23:17 2019 +0200

    python/tests/gensec: make it possible to add knownfail tests for gensec.update()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 02f538816b409f1a122fae8fd08d761e3617e798
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 4 16:39:43 2019 +0300

    selftest: add tests for no optimistic spnego exchange
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d7e57ef7dd7d583cffb7abbe42d71f4f33f2a9af
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 4 16:31:21 2019 +0300

    spnego: add client option to omit sending an optimistic token
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 90f557f3a1ed0a49e88ab0db29999f1289486cfe
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Oct 7 23:51:19 2019 +0300

    selftest: s3: add a test for spnego downgrade from krb5 to ntlm
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7e36de99d7d028a01d4c52c2974d990ef91017bb
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Oct 10 16:18:21 2019 +0200

    s3:libsmb: Do not check the SPNEGO neg token for KRB5
    
    The list is not protected and this could be a downgrade attack.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Pair-Programmed-With: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 37daeb220e461b842ad9708497699f15c5fa5df3
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 3 13:09:29 2019 +0300

    spnego: ignore server mech_types list
    
    We should not use the mech list sent by the server in the last
    'negotiate' packet in CIFS protocol, as it is not protected and
    may be subject to downgrade attacks.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit efb43ecb8e3994171efeb8f8b4231fdd420ace0b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 30 11:52:06 2019 +0200

    wscript: split function check to one per line and sort alphabetically
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Oct 10 20:13:25 UTC 2019 on sn-devel-184

commit 834d528213d60a0fc5daed46ed0e51dad578b877
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 30 11:49:28 2019 +0200

    wscript: remove all checks for _FUNC and __FUNC
    
    Those where historic artifacts not needed anymore.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 04b9369656d4a7cec1c12ea614286fbfc5495eb0
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Oct 1 17:38:57 2019 +0200

    WHATSNEW: Mention performance improvements for SMB3 encryption
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Thu Oct 10 09:41:26 UTC 2019 on sn-devel-184

commit d7bb9f54250f170ea18aad08a98862f7054d8579
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 17:08:56 2019 +1200

    librpc: Remove server build of oxidresolver.idl
    
    We do not have a server for this DCOM component so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b273924b8a2dd32a949f37be8ff53298bff81bb4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:58:35 2019 +1200

    librpc: Remove client and server build of w32time.idl
    
    We do not have a server for the Win32 Time Server so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c46191b8781b076ed872f14e01592997def44f89
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:57:48 2019 +1200

    librpc: Remove client and server build of rot.idl
    
    We do not have a client or server for this DCOM component so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 091e8fe14b51c550ea9d8360651378ebb0e3491b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:47:48 2019 +1200

    librpc: Remove s4 server build of dfs
    
    We do not have a source4 varient of the dfs server, so do not generate
    the code for it.
    
    DFS is very closely tied to SMB so we use the DFS server in
    smbd.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 718f9da0a7fb9f48660016a7baafecdb3ed6e4e0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:40:47 2019 +1200

    librpc: Remove s3 server build of unixinfo
    
    We do not have a source3 varient of the unixinfo server, so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 83fae584867babbb602da7096160bdc811dcf337
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:39:11 2019 +1200

    librpc: Add commnets on the split out of IDL files
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 759660b16a75a43b910001f9e8502d180a4ba89e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:37:31 2019 +1200

    librpc: Remove server build of remact.idl
    
    We do not have a server for the DCOM Remote activation service, so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6250fe29dd63e803d0dc3cbd8cef5944bf9911d2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:34:19 2019 +1200

    librpc: Remove s4 server build of ntsvcs
    
    We do not have a source4 varient of the ntsvcs server, so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8216c2187f1efa9cf114f705252a452e5b6721d1
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:32:38 2019 +1200

    librpc: Remove s4 server build of initshutdown
    
    We do not have a source4 varient of the initshutdown server, so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f45ceb0df99afd7cdbf05cb8d0f00b0a1b5bdd0a
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:31:07 2019 +1200

    librpc: Remove unused build of atsvc server
    
    This avoids building server-side code we do not use and so makes the build
    smaller and code auditing easier.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 81fbba8f649e4115961eb77462ca450e7a30611e
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:41:21 2019 -0700

    s3: VFS: Complete the removal of SMB_VFS_RMDIR()
    
    All users now use SMB_VFS_UNLINKAT(..., AT_REMOVEDIR).
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Thu Oct 10 07:26:43 UTC 2019 on sn-devel-184

commit 5bf96b1f0b61847771aab7be35121a1d5c15554e
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:23:44 2019 -0700

    s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the rmdir_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4fcd20cd6bfc646f4ee9319aae0bf6306f1c1a7c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:22:19 2019 -0700

    s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 14e24881c4e2839e896c3b6e8b94ecc7a990947f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:21:21 2019 -0700

    s3: VFS: vfs_syncops: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ffa09e09e87ff82d0091529230d9122358d70e96
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:17:32 2019 -0700

    s3: VFS: vfs_streams_depot: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a940c4c5ac180acf15d005fb3d4fa4a0b3e9b448
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:10:58 2019 -0700

    s3: VFS: vfs_snapper: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8bb2c7b8989411ac7ebd06ef6621b2a38acf7243
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:10:07 2019 -0700

    s3: VFS: vfs_shadow_copy2: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8e65a8c2e7ddbc3a53f7adf240cb2a31eb4fdc51
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:09:00 2019 -0700

    s3: VFS: vfs_posix_eadb: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ae28488fb0447d1e3135d5f9569a633fe75c4661
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:52:18 2019 -0700

    s3: VFS: vfs_media_harmony: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5e1e58a1e7734f0b607c24b4f71a6f6224994bab
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:51:15 2019 -0700

    s3: VFS: vfs_glusterfs: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ea386e13fc41cd1c42d6708b9898e74bfc8bb375
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:49:54 2019 -0700

    s3: VFS: vfs_extd_audit: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 09d33f5b31f591c18a29be2265a4b536f3348c2b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:44:48 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 882babe6de7b6410434868294541492181b3b4aa
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:44:08 2019 -0700

    s3: VFS: vfs_ceph: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b79c7d28738e5e9a33d5f7db9db61116295ac5d5
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:43:11 2019 -0700

    s3: VFS: vfs_catia: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b222c486b36e4cff7d827aedb90f5bfa5c3a9fd3
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:42:26 2019 -0700

    s3: VFS: vfs_cap: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8a18518edead4c828a62615365c99624e4315e69
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:41:26 2019 -0700

    s3: VFS: vfs_audit: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 26eb0e70bc8aa12890cdc23c3ea6c2e0d408848b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:40:26 2019 -0700

    s3: VFS: vfs_acl_xattr: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 19a4c5a99334ac38becdf6197e154f98c0455ff6
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:39:30 2019 -0700

    s3: VFS: vfs_acl_tdb: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 060eb647f437f4fefb4e511061e48dd62d0c3099
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:14:17 2019 -0700

    s3: VFS: vfs_fruit: Remove rmdir_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 44f9adc155fc59836580e1d9bc4820d547082fbd
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:01:55 2019 -0700

    s3: VFS: vfs_unityed_media: Remove rmdir_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 305f2b8d01c5e9ecaa599372f75656169e777c7f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 13:53:13 2019 -0700

    s3: VFS: vfs_xattr_tdb: Remove rmdir_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4ce152f1c43a2eb5c96da2f24b3829e4118774e2
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 13:51:09 2019 -0700

    s3: smbd: Change rmdir_internals() to call SMB_VFS_UNLINKAT() in rmdir cases.
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ca5e8938ce36835b5f381379560e77fb6cf9cf90
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 12:54:05 2019 -0700

    s3: smbd: Change recursive_rmdir() to call SMB_VFS_UNLINKAT() in rmdir case.
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7991a12e3f2b76220ab9885a98f4b427f035af81
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 12:51:06 2019 -0700

    s3: cmd_vfs: Change cmd_pathfunc() to call SMB_VFS_UNLINKAT() in rmdir case.
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 576a143deb3aa2ab4ba183a8e81874d6210e9026
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:03:39 2019 -0700

    s3: VFS: vfs_fruit: Change fruit_rmdir_internal() to call UNLINKAT instead of RMDIR.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c6235f297e7da35411c0effa2394bdc679e433c9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:40:34 2019 -0700

    s3: VFS: vfs_streams_depot: Change RMDIR -> UNLINKAT inside streams_depot_unlink_internal().
    
    No logic change.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9c5dc89c0b1a3c33840428d04034abe4dcfbbd7b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:38:45 2019 -0700

    s3: VFS: vfs_streams_depot: Change RMDIR -> UNLINKAT inside stream_dir().
    
    No logic change.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d9091d8fa96645886e7fb35ac95ed0f5b2f5c72a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:14:21 2019 -0700

    s3: VFS: vfs_streams_depot: Add a dirfsp parameter to streams_depot_rmdir_internal().
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 48ad93aec53e547de5919ec13056c7a4fd5cbf02
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:12:30 2019 -0700

    s3: VFS: vfs_streams_depot: Rename streams_depot_rmdir() to streams_depot_rmdir_internal().
    
    Make rmdir_fn() a wrapper function. This will
    allow us to add the dirfsp parameter.
    
    Fix DEBUG statement so it doesn't print the wrong function name.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 881ee37c81c0b94c62c92cd4debf2fe52ad7cd63
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:16:06 2019 -0700

    s3: VFS: vfs_posix_eadb: Convert streams_depot_rmdir_internal() to call UNLINKAT() instead of RMDIR().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a8507856ef1fc005a0fefa6e764663b48ec8ea1b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:07:46 2019 -0700

    s3: VFS: vfs_posix_eadb: Convert posix_eadb_rmdir_internal() to call UNLINKAT() instead of RMDIR().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3221bab80feff7f9e3af05c08f13ecb3a0cf8cde
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:06:23 2019 -0700

    s3: VFS: vfs_posix_eadb: Add a dirfsp parameter to posix_eadb_rmdir_internal().
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4e028aeaff99b4fee71925bca8d3eae0a4841947
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:04:02 2019 -0700

    s3: VFS: vfs_posix_eadb: Rename posix_eadb_rmdir() to posix_eadb_rmdir_internal().
    
    Make rmdir_fn() a wrapper function. This will
    allow us to add the dirfsp parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0df3371e7a483fd286e96f95c8a4c227e2b686ab
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:37:01 2019 -0700

    s3: VFS: vfs_acl_common: Convert rmdir_acl_common() to use UNLINKAT instead of RMDIR.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7f54bc8794b7dc48b1f0b4c500a144c830f3da74
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:34:41 2019 -0700

    s3: VFS: Change rmdir_acl_common() to take a files_struct *dirfsp pointer.
    
    Pass in the passed dirfsp if available, else handle->conn->cwd_fsp.
    
    No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1c0c3b61038631f06795fcd9a1424a666b117db1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:25:00 2019 -0700

    s3: VFS: vfs_acl_common: Change acl_common_remove_object() to use UNLINKAT instead of RMDIR.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9290510fe4d2b5ce88a6085e7047f1e6fafd6f5a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:31:59 2019 -0700

    s3: VFS: vfs_acl_xattr. Wrap rmdir_acl_common() by acl_xattr_rmdir() so we don't call it directly.
    
    This will allow adding the extra dirfsp parameter to
    rmdir_acl_common().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b4cbdddfb8729b6aa4729ea31da6090dd9e71383
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 8 17:37:56 2019 +0200

    smbd: Fix an uninitalized variable
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Oct 10 01:04:33 UTC 2019 on sn-devel-184

commit c9b6298249cd2f670e6953c9c3ef2e977f8bc565
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Aug 23 18:43:02 2019 +0200

    mdssvc.idl: pass policy_handle as pointer
    
    No change in behaviour, this just changes all functions to take the
    policy_handle argument as pointer instead of passing it by value.
    This is how all other IDLs pass it.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Oct  9 15:52:55 UTC 2019 on sn-devel-184

commit 63cbeaf0e7472a7321f27327091217c909864100
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 20 17:00:49 2019 +0200

    s3:mdssvc: fix service startup in deamon mode
    
    Changes:
    
    * Don't initialize the RPC service by calling setup_rpc_module() in the parent
      mdssd. This is not needed in the parent, only in the worker childs.
    
    * In the worker childs call setup_rpc_module() instead of init_rpc_module()
      which ensures rpc_mdssvc_init() is called with the mdssvc callback which is
      needed to initialize mdssvc via mdssvc_init_cb() -> init_service_mdssvc()
    
    * Finally rpc_setup_mdssvc() is adjusted to be a noop if mdssvc is configured to
      as external and when called by the main parent smbd via dcesrv_ep_setup() ->
      setup_rpc_modules()
    
    I've manually tested all 4 combinations of external=yes|no X module=yes|no with
    the new mdfind command.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 78a2d95511357a5ea34473e6a6d98515b4344fb5
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 20 16:50:52 2019 +0200

    s3:mdssvc: use a helper variable for the service type
    
    No change in behaviour. Simplifies a subsequent logical change.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 91f397bec0dbc24b60f74e80ee413642d955d7bc
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 20 17:00:12 2019 +0200

    mdssd: fix a debug message
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit bf02a935083c858490b9aecd8949f8a57918615a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Aug 19 15:50:36 2019 +0200

    s3: rpc_server: enable mdssvc by default
    
    Now that mdssvc is built by default and also tested in CI, enable it by default,
    running as embedded service.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit fa4c3fd9341412a9fc4a53923bf52f7433c08079
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Aug 17 11:36:55 2019 +0200

    selftest: add mdfind blackbox test
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit c85cd5c4311512fff18b04267408eb60d7c8ecdf
Author: Ralph Boehme <slow at samba.org>
Date:   Thu May 2 21:33:46 2019 +0200

    s3:utils: add mdfind
    
    A small command line tool to run macOS Spotlight searches against an SMB server
    that runs the Spotlight mdssvc RPC service, including macOS and Samba.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit da7dec0a50fa5d9f6b92403d8703cd6b7a42159c
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Jul 28 15:25:54 2019 +0200

    selftest: add end-to-end tests for mdssvc with a fake HTTP server
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit f0e8dd1a08698884209873bb84002d7b34db016c
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 30 12:00:18 2019 +0200

    selftest: split fileserver testenv into simpleserver and fileserver
    
    The simpleserver testenv continues to be built with minimal
    dependencies. fileserver otoh will be built with bells and whistles including
    JSON which I need for using the env as target for Spotlight tests.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit f479e010961e652230c7e33876058c8fb82e9019
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 30 12:47:03 2019 +0200

    s3:mdssvc: add unit tests for the Spotlight to Elasticsearch parser
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit f5510d7db3816c6a18dc333e1ae7f505fca69815
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Aug 5 16:25:01 2019 +0200

    s3:mdssvc: add Elasticsearch backend
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit c338bdf5a4aef16cb3048b18c77a0095f3fc3e53
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 13 14:16:07 2019 +0200

    s3:mdssvc: add missing mds_ctx deallocation
    
    The mds_ctx object was created in _mdssvc_open() as a talloc child of the pipe
    which means as long as the pipe is connected it's not freed.
    
    To ensure we do proper rundown of all resources including backend connections
    and pending queries, we must free the mds_ctx object.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit eb740b571d1ed5d55619c059160f236126351bd5
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 13 14:13:20 2019 +0200

    s3:mdssvc: fix a long line
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit ba899694e45aa2e691cf44098846fc0ddf3e79fd
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 13 14:11:23 2019 +0200

    s3:mdssvc: modernize a few DEBUG macros
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 08cb82d26f8f1a0dc66fadfcdee4f487ea06e010
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 13 12:55:33 2019 +0200

    s3:mdssvc: remove unused snum from struct sl_query
    
    Looks like this was never used, it's also available via mds_ctx->snum.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit afc90321ecd47ec1a8b6196c9b4aa15c2c654d41
Author: Ralph Boehme <slow at samba.org>
Date:   Fri May 10 18:49:20 2019 +0200

    build: add SAMBA_DATADIR as "samba" subdirectory of DATADIR
    
    DATADIR should have been set to this path from the beginning, too late to change
    that now as ut's used as parent for two other directory varialbles: SETUPDIR and
    CODEPAGEDIR.
    
    From <https://www.gnu.org/prep/standards/html_node/Directory-Variables.html>:
    
      datadir
    
        The directory for installing idiosyncratic read-only
        architecture-independent data files for this program. This is usually the
        same place as ‘datarootdir’, but we use the two separate variables so that
        you can move these program-specific files without altering the location for
        Info files, man pages, etc.
    
        This should normally be /usr/local/share, but write it as
        $(datarootdir). (If you are using Autoconf, write it as ‘@datadir@’.)
    
        The definition of ‘datadir’ is the same for all packages, so you should
        install your data in a subdirectory thereof. Most packages install their
        data under $(datadir)/package-name/.
    
    Currently Samba doesn't install any application specific data files, but I'm
    going to do just that in a subsequent commit.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 213ca6e4cc981b4a9550042ce927c677883810be
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Jul 28 15:08:29 2019 +0200

    s3: add mdscli Python bindings
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit b27d9afa29435b7af6335f228b8a315701b2607a
Author: Ralph Boehme <slow at samba.org>
Date:   Thu May 2 07:45:39 2019 +0200

    s3:rpc_client: add a mdssvc client library
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 873aa1e6c8495c04eb21cfc38fc5a4ad401f80fd
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Jul 28 15:05:13 2019 +0200

    librpc: add Python mdssvc bindings
    
    Not used for now, but soon.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 459b43e5776180dc1540cd845b72ff78747ecd6f
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Aug 22 16:31:30 2019 +0200

    testprogs: Add test for 'net ads join createcomputer='
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct  9 08:26:17 UTC 2019 on sn-devel-184

commit 14f320fa1e40ecc3a43dabb0cecd57430270a521
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Aug 8 14:40:04 2019 +0200

    s3:libads: Just change the machine password if account already exists
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13884
    
    Pair-Programmed-With: Guenther Deschner <gd at samba.org>
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 39b8c8b30a5d5bd70f8da3a02cf77f7592788b94
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Aug 14 10:15:19 2019 +0200

    s3:libnet: Improve debug messages
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit ce7762935051c862ecdd3e82d93096aac61dd292
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Aug 13 16:34:34 2019 +0200

    s3:libads: Fix creating machine account using LDAP
    
    This implements the same behaviour as Windows.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13884
    
    Pair-Programmed-With: Guenther Deschner <gd at samba.org>
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit b755a6438022579dab1a403c81d60b1ed7efca38
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Aug 14 12:17:20 2019 +0200

    s3:libads: Don't set supported encryption types during account creation
    
    This is already handled by libnet_join_post_processing_ads_modify()
    which calls libnet_join_set_etypes() if encrytion types should be set.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4f389c1f78cdc2424795e3b2a1ce43818c400c2d
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Aug 14 13:01:19 2019 +0200

    s3:libads: Fix detection if acount already exists in ads_find_machine_count()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 35f3e4aed1f1c2ba1c8dc50921f238937f343357
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Aug 21 12:22:32 2019 +0200

    s3:libads: Use a talloc_asprintf in ads_find_machine_acct()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 8ed993789f93624b7b60dd5314fe5472e69e903a
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Aug 13 16:30:07 2019 +0200

    s3:libads: Cleanup error code paths in ads_create_machine_acct()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit b84abb3a46211dc84e52ef95750627e4dd081f2f
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Aug 13 17:41:40 2019 +0200

    s3:libnet: Require sealed LDAP SASL connections for joining
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 456322a61319a10aaedda5244488ea4e5aa5cb64
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Aug 13 17:06:58 2019 +0200

    s3:libads: Use ldap_add_ext_s() in ads_gen_add()
    
    ldap_add_s() is marked as deprecated.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 320b5be4dce95d8dac4b3c0847faf5b730754a37
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Aug 8 14:35:38 2019 +0200

    testprogs: Fix failure count in test_net_ads.sh
    
    There are missing ` at the end of the line.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13884
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4a24d9499757dea377b4e3d8beb7f2c10fd5c5d0
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Aug 23 09:12:21 2019 +0200

    libcli:smb: Use gnutls_aead_cipher_decryptv2() for AES GCM or CCM
    
    This is a new call which has been added with GnuTLS 3.6.10 and will
    recuduce memory allocations and copying of data.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Simo Sorce <idra at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Oct  8 14:12:44 UTC 2019 on sn-devel-184

commit 70fdd4821aa811f90944bee17cc85e3ae9302279
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Aug 23 08:54:54 2019 +0200

    libcli:smb: Use gnutls_aead_cipher_encryptv2() for AES GCM or CCM
    
    This is a new call which has been added with GnuTLS 3.6.10 and will
    recuduce memory allocations and copying of data.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Simo Sorce <idra at samba.org>

commit fa255a36df87e41717d9630ea96ac9439e186062
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Aug 23 08:40:00 2019 +0200

    waf: Check for gnutls_aead_cipher_encryptv2()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Simo Sorce <idra at samba.org>

commit 5a084994144704a6c146b94f8a22cf57ce08deab
Author: Alexander Bokovoy <ab at samba.org>
Date:   Mon Oct 7 18:24:28 2019 +0300

    samba-tool: create working private krb5.conf
    
    DNS update tool uses private krb5.conf which should have enough details
    to authenticate with GSS-TSIG when running nsupdate.
    
    Unfortunately, the configuration we provide is not enough. We set
    defaults to not lookup REALM via DNS but at the same time we don't
    provide any realm definition. As result, MIT Kerberos cannot actually
    find a working realm for Samba AD deployment because it cannot query DNS
    for a realm discovery or pick it up from the configuration.
    
    Extend private krb5.conf with a realm definition that will allow MIT
    Kerberos to look up KDC over DNS.
    
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 0abd1189a60eea4501b5279ebc4bff2b5689f888
Author: Anoop C S <anoopcs at redhat.com>
Date:   Fri Sep 27 12:07:40 2019 +0530

    s3: VFS: Use SMB_VFS_FCNTL to set fd flags in open_file()
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Oct  8 09:57:19 UTC 2019 on sn-devel-184

commit 5084a69de14f24e9d804998580eefcba773fdd5a
Author: Anoop C S <anoopcs at redhat.com>
Date:   Fri Sep 27 11:19:37 2019 +0530

    s3: VFS: Add SMB_VFS_FCNTL
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c9d302f20b066267a8fd2d7ce4dc171161c9c40c
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 7 11:28:24 2019 +0200

    gitlab-ci: Add CentOS 8 to CI
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Oct  8 08:27:50 UTC 2019 on sn-devel-184

commit 9cd0d15370142b3694a51fa9b6cfffdb8e08e886
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 7 13:28:07 2019 +0200

    bootstrap: We can only build docker images on gitlab shared runners
    
    Our rackspace runners don't provide a running docker.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 42edab7bd76022dd4d5338012f29aed29a2a2d89
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 7 11:50:58 2019 +0200

    bootstrap: Remove pyhton2 packages
    
    We dropped support for python2 in Samba already.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 7bceafe8401fdbf67c065d6799ea91d9667fd096
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 14:48:54 2019 +0000

    s3/passdb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_ldap.c:1933:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
                     ^~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/passdb/pdb_ldap.c:4094:11: warning: Value stored to 'ntstatus' during its initialization is never read <--[clang]
            NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Oct  8 02:40:24 UTC 2019 on sn-devel-184

commit 78161550bac4bdbbea7f187b70413c55ef62fad2
Author: Gordon Ross <gwr at nexenta.com>
Date:   Mon May 9 13:45:07 2016 -0400

    torture: Allow running on FS that does not support EAs
    
    Signed-off-by: Gordon Ross <gordon.w.ross at gmail.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Oct  7 22:05:59 UTC 2019 on sn-devel-184

commit 222f2538636d247f6ca067e0f8a174799143b155
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 2 14:27:41 2019 +0200

    replace: Improve sys/sysctl.h check to catch warning on glibc >= 2.30
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Oct  7 11:48:24 UTC 2019 on sn-devel-184

commit 7c2745d41e808b7240358f5d0702dfe7abdc93a1
Author: Günther Deschner <gd at samba.org>
Date:   Sat Sep 28 13:10:32 2019 +0200

    libcli/auth: add gnutls test for aes-128-cfb8 cipher bug
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Oct  7 09:31:35 UTC 2019 on sn-devel-184

commit f988756599c2f7253989f2ca1dea2975dd89e6ea
Author: Günther Deschner <gd at samba.org>
Date:   Tue Sep 17 22:37:06 2019 +0200

    auth/gensec: fix AES schannel seal and unseal
    
    Workaround bug present in gnutls 3.6.8:
    
    gnutls_cipher_decrypt() uses an optimization
    internally that breaks decryption when processing
    buffers with their length not being a multiple
    of the blocksize.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Pair-Programmed-With: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 709d54d68a9c2cb3cda91d9ab63228a7adbaceb4
Author: Günther Deschner <gd at samba.org>
Date:   Fri Sep 20 18:32:43 2019 +0200

    auth/gensec: fix non-AES schannel seal
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14134
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7eae4280d23404be7d27f65a0c817bea2e0084b6
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 25 23:44:49 2019 +0200

    libcli/auth: add test for gensec_schannel code
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ea82bca8cef0d736305a7a40b3198fc55ea66af8
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 3 14:02:13 2019 -0700

    s3: smbclient: Stop an SMB2-connection from blundering into SMB1-specific calls.
    
    Fix in the same way this was done in SMBC_opendir_ctx() for libsmbclient.
    This fix means the admin no longer has to remember to set 'min client protocol ='
    when connecting to an SMB2-only server (MacOSX for example) and trying to
    list shares.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14152
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 4b62c4f7addba3ce47f1d0d5f2b64103602b7ca2
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Oct 4 10:40:18 2019 +0200

    lib/replace: Remove libaio support
    
    io_uring is the way to go these days, libaio was never really useful
    for Samba
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Oct  4 18:18:41 UTC 2019 on sn-devel-184

commit bcbadeb82656fafb68b506a3067999c03c481cd2
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Oct 4 10:36:30 2019 +0200

    ntvfs: Remove pvfs_aio.c
    
    This uses the Linux libaio that does not meet Samba's needs. If
    someone wanted to add async I/O to ntvfs, the io_uring API is the way
    to go. Second option would be to use a pthreads-based API.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0bddee8dac095016e892731abe9e5a668c38375d
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 3 17:25:10 2019 +1000

    ctdb-tests: Rename functions to test_header() and test_footer()
    
    That's all they do now.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Fri Oct  4 10:58:10 UTC 2019 on sn-devel-184

commit 435d903ad84e72e8223ae53ca46bb47c1cfe1293
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Sep 10 10:51:31 2019 +1000

    ctdb-tests: Move test duration calculation to ctdb_test_run()
    
    It makes sense to do this in one place in case other headers/footers
    are added.
    
    Reindent ctdb_test_begin() while touching this function.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 23982477f3d486815974edce08a247d7280c9578
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 12:36:05 2019 +1000

    ctdb-tests: Add handling for skipped tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 473a6fed11a2e63d9cd557f63fdb646bd040deda
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 12:31:10 2019 +1000

    ctdb-tests: Add a special failure code when a test error occurs
    
    Use it when a test is not executable.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 55dd0f047f58f9be2d1a317dfcbebe18e22201a0
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 20:57:42 2019 +1000

    ctdb-tests: Move test status interpretation to ctdb_test_run()
    
    It makes sense to do this in one place in case other headers/footers
    are added.
    
    Simplify ctdb_test_end() accordingly, reindenting because nearly all
    lines are modified.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 47c9b79262ee4101d29c977d98933bfcf22f7426
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 12:25:06 2019 +1000

    ctdb-tests: Move use of show_progress() into ctdb_test_run()
    
    This allows more variables to be set in this function because they are
    no longer in a sub-shell.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit e7e6f4067e4a0de1ccfc8650fb0e87b8b6e0d620
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 20:51:51 2019 +1000

    ctdb-tests: Simplify ctdb_test_run()
    
    Only the test file name is ever passed.
    
    Reindent while touching many existing lines.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit dc8ddbb0843abdc547055d57184e6cd1ba8e3147
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 16:08:41 2019 +1000

    ctdb-tests: Switch TEST_CLEANUP and TEST_TIMEOUT to script variables
    
    These are not used outside this script so they do not need to be
    environment variables.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 0ec83f32faddf6ef9f5fdd11ecd6d651459dd650
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 12 21:01:20 2019 +1000

    ctdb-tests: Add new test functions for running commands on nodes
    
    * ctdb_onnode()
    * testprog_onnode()
    * function_onnode()
    
    These encapsulate familiar patterns found when running
    try_command_on_node().  The new function names are more concise and
    encourage more readable tests.  Test writers can do less thinking
    about the subtleties of running different types of commands on nodes.
    For example, these functions ensure that $CTDB and $VALGRIND are used
    in the correct contexts.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 38b838b59cbece5c6a7bda40e8d411a6c56d1458
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Aug 13 21:43:32 2019 +1000

    ctdb-tests: try_command_on_node() should return status of command
    
    There is no point folding this down to 1.  Tests should be able to see
    the original value, if required.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit e494eb3e8c054a7aa56d2f201459934d1248642a
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 12 12:21:13 2019 +1000

    ctdb-tests: Drop unused function ctdb_test_check_real_cluster()
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 38138b42f7c42aca01dccd7b61784f0ddc2570f2
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 11 16:07:49 2019 +1000

    ctdb-tests: Update preamble for CLUSTER tests
    
    The main change is to source cluster.bash instead of integration.bash.
    
    While touching the preamble, the following additional changes are also
    made:
    
    * Drop test_info() definition and replace it with a comment
    
      The use of test_info() is pointless.
    
    * Drop call to ctdb_test_check_real_cluster()
    
      cluster.bash now does this.
    
    * Drop call to cluster_is_healthy()
    
      This is a holdover from when the previous test would restart daemons
      to get things ready for a test.  There was also a bug where going
      into recovery during the restart would sometimes cause the cluster
      to become unhealthy.  If we really need something like this then we
      can add it to ctdb_test_init().
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 653b35764a2b4e999dbe6a71c1de2c9554d6fc4d
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 11 15:44:20 2019 +1000

    ctdb-tests: Add cluster.bash include file
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5ad356c282044db251c395db06900b249ff07544
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 11:43:53 2019 +1000

    ctdb-tests: Add function ctdb_test_skip_on_cluster()
    
    Use it in relevant tests.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 59055f4da1ac4747c771a8acf2392b5e4599679b
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Oct 2 15:08:18 2019 +1000

    ctdb-tests: Add function ctdb_test_on_cluster()
    
    This centralises this logic.  Use it in a subset of tests - there are
    other cases but these will be cleaned up soon.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 65ca431c95e53e8686c2887d8c8ddaf67999305b
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Sep 17 16:00:13 2019 +1000

    ctdb-tests: Add functions for terminating tests on failure, skip, error
    
    This allows standard exit codes for failed and skipped tests, and test
    errors.
    
    Skipped tests currently just succeed and a test error is the same as a
    failure.  These can be easily changed later when run_tests.sh is ready
    to handle them.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 2c54f6df7164d6263624a1ed72485bf4e6690bb6
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Oct 2 17:52:31 2019 +1000

    ctdb-common: Mark VacuumLimit tunable as obsolete
    
    Use of this tunable was dropped over 5 years ago in commit
    16837bc309aa9a86fc21d7f59a8fce0b947428a3.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Fri Oct  4 07:07:21 UTC 2019 on sn-devel-184

commit 815ae644006a11301c1ee81fdd4dcbf13de38141
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Oct 2 17:51:12 2019 +1000

    ctdb-vacuum: Drop debug level of repacking message to NOTICE
    
    This occurs rarely but can adversely impact performance, so it is
    worth logging it more frequently.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a8c4e7d1f6b3375e2cdac962133919cce91f7c1d
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 23 16:11:00 2019 +1000

    ctdb-protocol: Initialise request->rdata.opcode where missing
    
    Otherwise it is uninitialised, so...
    
    ==22889== Conditional jump or move depends on uninitialised value(s)
    ==22889==    at 0x12257B: ctdb_req_control_data_len (protocol_control.c:39)
    ==22889==    by 0x1228E9: ctdb_req_control_len (protocol_control.c:1786)
    ==22889==    by 0x12A51C: ctdb_client_control_send (client_control.c:101)
    ==22889==    by 0x138BE1: ctdb_tunnel_setup_send (client_tunnel.c:100)
    ==22889==    by 0x10EE4F: tunnel_test_send (tunnel_test.c:135)
    ==22889==    by 0x10EE4F: main (tunnel_test.c:463)
    
    and similar.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 33f1c9d9654fbdcb99c23f9d23c4bbe2cc596b98
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Sep 30 16:34:35 2019 +1000

    ctdb-vacuum: Process all records not deleted on a remote node
    
    This currently skips the last record.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14147
    RN: Avoid potential data loss during recovery after vacuuming error
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit fe41238097f4354f18130c43ea3c5db0293097c7
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 19:24:18 2019 -0700

    rpcclient: Remove unused global domain sid
    
    For the auth_log tests using rpcclient this means one message less
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Oct  3 17:59:13 UTC 2019 on sn-devel-184

commit 8a094672212eb49291ff6c8c9441a0a6c71c1561
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 19:22:55 2019 -0700

    rpcclient: Remove domain sid check
    
    The samr calls can take care of this on their own
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cb0b54d9acb4a0021a09f90299fec1bad3b63107
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 19:20:17 2019 -0700

    rpcclient: Make cmd_samr.c independent of global domain_sid
    
    Pure SAMR allows us to figure out the domain sid, we don't need LSA
    for this.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dd108a171fe807b67fe8186cf96af18836bea451
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 19:19:47 2019 -0700

    rpcclient: Fix a comment
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3cac5c1bd4d47d143071891a0f21e242a28bd99f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 18:49:33 2019 -0700

    rpcclient: Move rpccli_try_samr_connects() to cmd_samr.c
    
    That's the only user, make it static to cmd_samr.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f74442b4b795d9c282cdf36e6e8ebc312bfe27ca
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 17:32:31 2019 -0700

    rpcclient: Remove rpcclient_cli_state
    
    An unneeded global
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8ca4fe65238f9b086cae842da13111596b9d0114
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 17:25:55 2019 -0700

    rpclient: Remove cmd_test
    
    I can't even properly find why this went in. It's the only user of the
    global rpcclient_cli_state, which can go if we remove this.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 398cb8a56d83a7978836ee0b65b4747d190ab630
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 26 12:37:15 2019 -0700

    s3: smbd: Fix the SMB2 server to pass SMB2-PATH-SLASH.
    
    [MS-FSA] 2.1.5.1 Server Requests an Open of a File
    
    Windows pathname specific processing.
    
    Always disallow trailing /, and also \\ on FILE_NON_DIRECTORY_FILE.
    
    We need to check this before the generic pathname parser
    as the generic pathname parser removes any trailing '/' and '\\'.
    
    Currently this is SMB2 only, but we could also add this
    check to the SMB1 NTCreateX calls if ultimately neded.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Oct  2 09:31:40 UTC 2019 on sn-devel-184

commit 5642f288c895467e32a39430af709cc48198e7c1
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 26 12:36:18 2019 -0700

    s3: torture: Add MS-FSA style terminating '/' and '\\' test - SMB2-PATH-SLASH.
    
    [MS-FSA] 2.1.5.1 Server Requests an Open of a File.
    
    Checks how to behave on both files and directories.
    
    Tested against Windows 10 server - passes. Currently smbd fails this.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 32d6cc84cf8e0cf278b5715b8a9d66b7c0a2a6d2
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 30 11:39:11 2019 +0200

    dbwrap_watch: Don't alert ourselves, fix raw.oplock.batch26 race
    
    This fixes the following flaky test:
    
    UNEXPECTED(failure): samba3.raw.oplock.batch26(nt4_dc)
    REASON: Exception: Exception: (../../source4/torture/raw/oplock.c:3718): wrong value for break_info.count got 0x2 - should be 0x1
    
    You can reproduce it with two small msleeps, which means it's a race
    condition:
    
    diff --git a/source3/smbd/open.c b/source3/smbd/open.c
    index 20b5a3e294c..126c7fc021d 100644
    --- a/source3/smbd/open.c
    +++ b/source3/smbd/open.c
    @@ -1917,6 +1917,14 @@ NTSTATUS send_break_message(struct messaging_context *msg_ctx,
     	DATA_BLOB blob;
     	NTSTATUS status;
    
    +	{
    +		static bool sent = false;
    +		if (sent) {
    +			smb_msleep(500);
    +		}
    +		sent = true;
    +	}
    +
     	if (DEBUGLVL(10)) {
     		struct server_id_buf buf;
     		DBG_DEBUG("Sending break message to %s\n",
    diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c
    index b3da84b1269..d9c4dbb9487 100644
    --- a/source3/smbd/oplock.c
    +++ b/source3/smbd/oplock.c
    @@ -858,6 +858,8 @@ static void process_oplock_break_message(struct messaging_context *msg_ctx,
     	uint16_t break_to;
     	bool break_needed = true;
    
    +	smb_msleep(100);
    +
     	msg = talloc(talloc_tos(), struct oplock_break_message);
     	if (msg == NULL) {
     		DBG_WARNING("talloc failed\n");
    
    15a8af075a2 introduced a bug where we immediately wake up ourselves
    after doing a watch_send, leading to two inter-smbd oplock break
    messages for this case. In theory, this should not matter, as in the
    oplock break handler in the destination smbd we check
    
    (fsp->sent_oplock_break != NO_BREAK_SENT)
    
    so that the break does not get sent twice. However, with the above two
    sleeps the oplock holding client could send out its oplock downgrade
    while the second inter-smbd break messages was on its way.
    
    The real fix would be to note in the share mode array that the
    inter-smbd message has already been sent, but as other users of
    dbwrap_watched_watch_send might also be affected by this bug, this fix
    should be sufficient to get rid of this flaky test.
    
    Unfortunately, dbwrap_watch.c is now pretty complex and needs some
    serious refactoring to become understandable again. But that's
    something for another day, sorry.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 64da66a75c688b0443b5d5afa4f73ac51b96c504
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 30 11:32:26 2019 +0200

    dbwrap_watch: Remove "addwatch" handling from dbwrap_watched_save()
    
    This has been moved to dbwrap_watched_watch_send()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 491b71f29b966d1fed65d5db1463353a19306db8
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 30 11:25:59 2019 +0200

    dbwrap_watch: Move reallocating watchers to dbwrap_watched_watch_send()
    
    Before 15a8af075a2 we did not have a separately allocated watchers
    array and dbwrap_watched_save() could play (too) smart tricks with
    dbwrap_record_storev(). Now that we always have watchers talloc'ed, we
    can remove those smart tricks from dbwrap_watched_save() in the next
    commit.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 88f8edf69ba04b4df28d4986199fa13730d3a165
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 30 07:48:34 2019 +0200

    dbwrap_watch: Slightly simplify dbwrap_watched_fetch_locked()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 86672659c6a757263c7bf64d152f95d89222a3e7
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 17:20:26 2019 -0700

    epmapper: Fix printf specifiers
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e3e5894b854b9fe5680f1028f2bcbb2a2cc01069
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 11:53:31 2019 -0700

    torture: Fix a comment
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9dc2cd86f6993fd681513b1b251f5bbdb01212d4
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 10:51:38 2019 -0700

    lib: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5d8493f5b459a7b91f9a5ca9dee00c968fab3d67
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 10:29:07 2019 -0700

    rpc_client: Don't pass a NULL string to talloc_asprintf
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 34a35ac15efee431a7848da51409f7dcdf95b48b
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 09:51:08 2019 -0700

    smbd: Fix CID 1453984: Null pointer dereferences (REVERSE_INULL)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b66b8a74b100be85101a7383c634d0d96cf6b0ee
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 09:24:54 2019 -0700

    lib: Fix CID 1453985: Null pointer dereferences (FORWARD_NULL)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f21af2ace2261fb6e4d4762bcd70784135b62ddb
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 07:30:15 2019 -0700

    lib: Remove some unneeded #includes from tftw.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 993d327f5d24305d96781afeb11855487323975d
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 10:31:51 2019 -0700

    s3:smbd: use is_named_stream() in a a few places
    
    This simplifies (and corrects) things in the VFS as there the caller is only
    interested in whether a name is pointing to a real named stream most of the times.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4b2e44a6ed7de9b1a25c3bf08de24dd49c7f6c1d
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 12:19:31 2019 -0700

    vfs_default: use is_named_stream() for stream check
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c190f3efa9eb4f633df28074b481ff884b67e65f
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 10:41:37 2019 -0700

    s3:smbd: add a comment explaining the File-ID semantics when a file is created
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 90a14c90c4bcede1ef5414e0800aa4c84cbcf1c9
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Sep 24 12:49:38 2019 -0700

    s3:smbd: ensure a created stream picks up the File-ID from the basefile
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 091e3fdab61217251de1cf5111f070ff295d1649
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 10:05:40 2019 -0700

    s3:lib: add is_named_stream()
    
    Add a new utility functions that checks whether a struct smb_filename points to
    a real named stream, excluding the default stream "::$DATA".
    
      foo           -> false
      foo::$DATA    -> false
      foo:bar       -> true
      foo:bar:$DATA -> true
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 780a8dcba998471bb154e8bae4391786b793e332
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 11:29:04 2019 -0700

    s3:lib: use strequal_m() in is_ntfs_default_stream_smb_fname()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3f8bc1ce3e094f943363921c46803fd5ec9f73bb
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 11:19:26 2019 -0700

    s3:lib: implement logic directly in is_ntfs_default_stream_smb_fname()
    
    This allows changing the semantics of is_ntfs_stream_smb_fname() in the next
    commit.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2584b4cdeae3f83962cd11538cd4e441104c8274
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 10:38:06 2019 -0700

    s3:lib: expand a comment with the function doc for is_ntfs_stream_smb_fname
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f9fdb8a2a6b9ad0fbb89a9734e81a8b1f527966f
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 10:18:03 2019 -0700

    s3:lib: factor out stream name asserts to helper function
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6c1647ca7a2f68825c34e9ccc18b86ef911e14ac
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 10:15:27 2019 -0700

    s3:lib: assert stream_name is NULL for POSIX paths
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d7dc85990a177954925644f9ff332b3481a03cc7
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 08:53:29 2019 -0700

    s3:lib: rework a return expression into an if block
    
    Needed to add additional stuff after the if block in the next commit.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 49a754b82d33fb523cda4151a865584ae52a2e2f
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 23 15:16:58 2019 -0700

    s3:smbd: when storing DOS attribute call dos_mode() beforehand
    
    This is required to ensure File-ID info is populated with the correct on-disk
    value, before calling file_set_dosmode() which will update the on-disk value.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e1dfaa2b038d91e43d8d34bf1526b7728dba58a5
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 23 15:15:31 2019 -0700

    s3:smbd: change the place where we call dos_mode() when processing SMB2_CREATE
    
    This is needed for ordinary file or directory opens so the QFID create context
    response gets the correct File-ID value via dos_mode() from the DOS attributes
    xattr.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 300b47442b023532bd65417fcec04d811f40ef76
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Sep 24 13:09:03 2019 -0700

    torture:smb2: add a File-ID test on directories
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 432202413f4d11d761c62f46a50747fcb9b6f0cf
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 23 15:15:01 2019 -0700

    torture:smb2: extend test for File-IDs
    
    This now hopefully covers most possible combinations of creating and opening
    files plus, checking the file's File-ID after every operation.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 84fae0ed1bb7f2ec1fad8011d42211582e46565a
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 27 08:07:24 2019 +0100

    s3: passdb: ret doesn't seem to be needed at all
    
    I was looking at the wrong hunk when examining this, ret seems redundant
    and the existing status can cover things
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Oct  1 00:28:44 UTC 2019 on sn-devel-184

commit ee6300470dc6113ac4d8a9fbb450da876eb0b07a
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 14:50:33 2019 +0100

    s3/libsmb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/libsmb/cliconnect.c:1877:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_NO_MEMORY;
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 63c9147f8631d73b52bdd36ff407e0361dcf5178
Author: Michael Adam <obnox at samba.org>
Date:   Fri Jan 11 10:44:30 2019 +0100

    winbind: provide passwd struct for group sid with ID_TYPE_BOTH mapping (again)
    
    https://git.samba.org/?p=samba.git;a=commitdiff;h=394622ef8c916cf361f8596dba4664dc8d6bfc9e
    originally introduced the above feature.
    
    This functionality was undone as part of "winbind: Restructure get_pwsid"
    https://git.samba.org/?p=samba.git;a=commitdiff;h=bce19a6efe11980933531f0349c8f5212419366a
    I think that this semantic change was accidential.
    
    This patch undoes the semantic change and re-establishes the
    functionality.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14141
    
    Signed-off-by: Michael Adam <obnox at samba.org>
    Reviewed-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Fri Sep 27 17:25:29 UTC 2019 on sn-devel-184

commit 485874d6bb328c50c9a98785e85270f28ade7497
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Sep 25 17:19:27 2019 -0700

    selftest: Test ID_TYPE_BOTH with idmap_rid module
    
    ID_TYPE_BOTH means that each user and group has two mappings, a uid and
    gid. In addition the calls to getpwent, getpwuid, getgrent and getgrgid
    always return some information, so that uid and gid can be mapped to a
    name. Establish a test to verify that the expected information is
    returned.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14141
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 18e2d6b0098232c2bd8d51320095d35bd7301920
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 14:30:29 2019 +0100

    s3/libsmb: clang: Fix 'warning: Value stored to 'p' is never read'
    
    Fixes:
    
    source3/libsmb/cliconnect.c:649:2: warning: Value stored to 'p' is never read <--[clang]
            p += ret;
            ^    ~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Sep 26 19:59:24 UTC 2019 on sn-devel-184

commit 1ca110b547622f788d94530e0e3432845c2943bf
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 14:42:41 2019 +0000

    s3/passdb: clang: Value stored to 'c' is never read
    
    source3/passdb/pdb_smbpasswd.c:405:4: warning: Value stored to 'c' is never read <--[clang]
                            c = '\0';
                            ^   ~~~~
    /home/samba/samba/source3/passdb/pdb_smbpasswd.c:809:4: warning: Value stored to 'c' is never read <--[clang]
                            c = '\0';
                            ^   ~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2138bd93bb258f2dde2c279a0ba80f9a40737aed
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 14:16:57 2019 +0000

    s3/libsmb: clang: value stored to 'idx_current' is never read
    
    Fixes:
    
    source3/libsmb/trusts_util.c:602:2: warning: Value stored to 'idx_current' is never read <--[clang]
            idx_current = idx;
            ^             ~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 388f280448b9ea459d8d884dbbbce54ab930da7b
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 13:46:40 2019 +0000

    s3/passdb: clang: Fix warning: Value stored to 'acct_ctrl' is never read
    
    Fixes:
    
    source3/passdb/pdb_ldap.c:922:3: warning: Value stored to 'acct_ctrl' is never read <--[clang]
                    acct_ctrl |= ACB_NORMAL;
                    ^            ~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6ae0fd5a348224b2a7942c81c4ef21bf11205d62
Author: Noel Power <noel.power at suse.com>
Date:   Tue Sep 17 14:43:20 2019 +0000

    s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/lib/netapi/user.c:1290:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    source3/lib/netapi/user.c:1610:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    
    source3/lib/netapi/user.c:2990:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    source3/lib/netapi/user.c:3184:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    source3/lib/netapi/user.c:3522:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9c16d8fb246911d7bbd576d7e6bce0c8fb39929f
Author: Noel Power <noel.power at suse.com>
Date:   Tue Sep 17 14:20:03 2019 +0000

    s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/rpc_client/cli_winreg.c:728:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    /source3/rpc_client/cli_winreg.c:897:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 58400d6e65f70a256ebd900c3eca1c945b71be10
Author: Noel Power <noel.power at suse.com>
Date:   Tue Sep 17 08:13:00 2019 +0000

    lib/talloc: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    ib/talloc/pytalloc_util.c:245:8: warning: Value stored to 'type_obj' during its initialization is never read <--[clang]
            void *type_obj = talloc_check_name(ptr, type_name);
                  ^~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 32d487d0746b0fc8888ed37dfbfae3245b269dd7
Author: Noel Power <noel.power at suse.com>
Date:   Tue Sep 17 08:05:28 2019 +0000

    s3/libads: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/libads/ldap.c:370:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/libads/ldap.c:417:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/libads/ldap.c:1783:13: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
                       ^~~   ~~~~~~~~~~~~~~~~~~~~~~~
    source3/libads/ldap.c:1862:13: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
                       ^~~   ~~~~~~~~~~~~~~~~~~~~~~~
    4 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a3b9986fac270797be4dbd3d453add9d2107e953
Author: Noel Power <noel.power at suse.com>
Date:   Mon Sep 16 10:43:54 2019 +0000

    s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/lib/netapi/getdc.c:173:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 25c92111dcb646f8537d89fc2d091ee3c5753d56
Author: Noel Power <noel.power at suse.com>
Date:   Mon Sep 16 10:35:49 2019 +0000

    s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/lib/netapi/group.c:1383:11: warning: Value stored to '
    status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    samba/source3/lib/netapi/group.c:1521:11: warning: Value stored to '
    status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    samba/source3/lib/netapi/group.c:1718:11: warning: Value stored to '
    status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    3 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8ea0835a6cbe8721780929b9946de65cd87dc26d
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 13 13:57:16 2019 +0000

    s3/auth: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/auth/auth.c:38:35: warning: Value stored to 'entry' during its initialization is never read <--[clang]
            struct auth_init_function_entry *entry = auth_backends;
                                             ^~~~~   ~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9759e96ff1dc8741222eb6794dc01bd5b65c282d
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 13 13:54:11 2019 +0000

    s3/auth: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/auth/auth_util.c:283:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
                     ^~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/auth/auth_util.c:2005:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
            NTSTATUS nt_status = NT_STATUS_OK;
                     ^~~~~~~~~   ~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 50ff6c965f23457bfdefa53cd043166fdec899a5
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 14:59:51 2019 +0000

    s3/libsmb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/libsmb/dsgetdcname.c:1012:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    source3/libsmb/dsgetdcname.c:1099:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit eb3ba3eeaa200660c7b48253083bffbe39d41a96
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 14:50:37 2019 +0000

    s3/libads: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/libads/ldap_utils.c:52:13: warning: Value stored to 'status' during its initialization is never read <--[clang]
            ADS_STATUS status = ADS_SUCCESS;
                       ^~~~~~   ~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 35e0122e7c7f2cdfa0f6ac4f18a8cc7c42edab24
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 13:00:05 2019 +0000

    s3/libads: clang: Fix 'Value stored to 'nt_status' is never read'
    
    Fixes:
    
    source3/libads/sasl.c:219:2: warning: Value stored to 'nt_status' is never read <--[clang]
            nt_status = NT_STATUS_MORE_PROCESSING_REQUIRED;
            ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fba666cf2a5c83ee76432f0d0d44e867c62231ba
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 15:40:50 2019 +0000

    s3/passed: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/passdb/passdb.c:2502:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b08ec1903d2ebfdcdb83c0f6e042a6d3b06992c9
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 14:48:47 2019 +0000

    s3/rpc_client: clang: 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/rpc_client/util_netlogon.c:71:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    
    source3/rpc_client/util_netlogon.c:199:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ae2e9ce5c36c9e05f785b3fa7be22074fdc4213d
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 14:22:02 2019 +0000

    s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/rpc_client/cli_lsarpc.c:182:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 38aafe0d6bba0b7651600edfe2a799dcf7d1ed2d
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 13:40:16 2019 +0000

    s3/passdb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/passdb/lookup_sid.c:836:11: warning: Value stored to 'result' during its initialization is never read <--[clang]
            NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 299eff4ac906846e8f7f605815792a9d4418f071
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 13:36:22 2019 +0000

    s3/passdb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_interface.c:65:34: warning: Value stored to 'entry' during its initialization is never read <--[clang]
            struct pdb_init_function_entry *entry = backends;
                                            ^~~~~   ~~~~~~~~
    
    /source3/passdb/pdb_interface.c:140:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
            NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2d47067c86303c43f3d7267394ef8a9ce49593d3
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 13:34:05 2019 +0000

    s3/passdb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_tdb.c:718:18: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
            NTSTATUS        nt_status = NT_STATUS_UNSUCCESSFUL;
                            ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 752f5b63d0c4e0a7cdab74128ea54ade461d18d0
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 16:25:27 2019 +0100

    s3/passdb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_util.c:41:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c534b05c8d464940cd4d46c43d6549e86014143b
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 15:57:26 2019 +0100

    s4/winbind: clang: Fixes 'Value stored during its initialization is never read'
    
    Fixes:
    
    source4/winbind/idmap.c:214:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_NONE_MAPPED;
    
    source4/winbind/idmap.c:397:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_NONE_MAPPED;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6831b6ba6f52dd865ecf09c575e4862f6dd3424b
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 15:32:13 2019 +0100

    s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/rpc_client/cli_pipe.c:397:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_OK;
                     ^~~   ~~~~~~~~~~~~
    
    source3/rpc_client/cli_pipe.c:1234:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_OK;
                     ^~~   ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 368d0cecc0bc859e321335f46b22d4334e092da1
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 15:29:03 2019 +0100

    s3/groupdb: clang: 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/groupdb/mapping_tdb.c:460:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6055134330d9e4226deb298c506dc6f792bf5d33
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 14:16:52 2019 +0100

    s3/groupdb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    ource3/groupdb/mapping.c:648:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5550367e46d2ebb2bb0bb35fa51f34ca178d2907
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 25 06:53:34 2019 +0200

    s4-torture: remove duplicate NDR_PRINT
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fd20153e8b095fa9a82a024c3f7bebd809ba132f
Author: Günther Deschner <gd at samba.org>
Date:   Tue Aug 30 19:37:18 2016 +0200

    s4-torture: dump ndr packet in ndr tests with high log level
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 86a0e4850e02efc406ae5e1ee7cdc6a61eebef76
Author: Günther Deschner <gd at samba.org>
Date:   Tue Sep 24 23:10:50 2019 +0200

    librpc/ndr: add ndr_print_netlogon_samlogon_response()
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1ec030398bdc6f912d9beb3bcd0db7860a92eede
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 10:04:03 2019 -0700

    s3: VFS: Complete the replacement of SMB_VFS_UNLINK() -> SMB_VFS_UNLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Thu Sep 26 18:40:53 UTC 2019 on sn-devel-184

commit f7f09377919cf39ccc803556b42b024874a92a2b
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:23:04 2019 -0700

    s3: VFS: vfs_full_audit: Remove unlink_fn. No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the unlink_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit eeec2b8003fb0c069188591249415077d8792d0a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 10:02:16 2019 -0700

    s3: VFS: vfs_acl_tdb: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7222d63d42fb5812197ad8f64a6af1557bd0a043
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 10:01:32 2019 -0700

    s3: VFS: vfs_acl_xattr: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6f9b6a78671491055c9ce4b05039ba698a28abb1
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 10:00:43 2019 -0700

    s3: VFS: vfs_posix_eadb: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 467251ccf97561e9717d62080c0e81bfd2a1e11f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:59:54 2019 -0700

    s3: VFS: vfs_ceph: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f856d6f41d199f93ba57c93f075a21efc89b27ec
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:59:03 2019 -0700

    s3: VFS: vfs_glusterfs: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 314358b28a573fce13750e17dd0b124a8d6a0a0e
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:57:59 2019 -0700

    s3: VFS: vfs_streams_depot: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6f68049fff82e86554eb2ef8249a38e2ba4de2f7
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:56:53 2019 -0700

    s3: VFS: vfs_syncops: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4dc8c378193f8a4a6fbb913fbb419a7949acc393
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:54:10 2019 -0700

    s3: VFS: vfs_fruit: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 55df30d5a6345b333ee312d43b548ae50107471f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:22:38 2019 -0700

    s3: VFS: vfs_recycle: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7c814ef4299178f2d313ee12ea4a38429bbe991c
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:18:07 2019 -0700

    s3: VFS: vfs_unityed_media: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3bc8527cdc7a7958c8906044dbb0e7ad21f5e336
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:16:31 2019 -0700

    s3: VFS: vfs_xattr_tdb: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 36f4d0f76e6b71a6f79ca0f3cab84b55c40028ec
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:15:38 2019 -0700

    s3: VFS: vfs_virusfilter: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b2f1b3d972602d0305b0e728200092567051def4
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:14:22 2019 -0700

    s3: VFS: vfs_time_audit: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit fc29eb2b8581019b9505c8646f1d3c2cda161554
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:13:05 2019 -0700

    s3: VFS: vfs_streams_xattr: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit eacfeac62ba086e7f615bb2849785b7d354a7d48
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:05:27 2019 -0700

    s3: VFS: vfs_snapper: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 74ec7c804d8b3305f3a494b435d0d6ecec8cd4d7
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:04:38 2019 -0700

    s3: VFS: vfs_shadow_copy2: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 64854db8ac270acf16fa98f1b6ce26d19885795d
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:04:06 2019 -0700

    s3: VFS: vfs_media_harmony: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6f9ede8ad82487c27e9253fe18eb9c20ad2918ab
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:03:10 2019 -0700

    s3: VFS: vfs_extd_audit: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 84255a99384e62dc9a950e978e85bd7c9987af98
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:02:06 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 257137ee583d98b93ca09453d00931f7927ac32a
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:01:26 2019 -0700

    s3: VFS: vfs_catia: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d4c4c688dd31ec3b27c1f6001fcc7baabb2d2f04
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:00:31 2019 -0700

    s3: VFS: vfs_cap: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1e51128424749eb68634376b01f87362d67b1186
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:59:25 2019 -0700

    s3: VFS: vfs_audit: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0535656284db66dc7bc90fea2f15b1d00a13fe10
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 15:15:05 2019 -0700

    s3: lib: adouble: Add dirfsp to ad_convert_delete_adfile(). Use UNLINKAT instead of UNLINK.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7691ce3a4b34b6a0b3f6cc2379f2f4d2b4392047
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:52:00 2019 -0700

    s3: lib: adouble: Add struct files_struct *dirfsp parameter to ad_convert().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6a55e676aa63f5ca86c53f849bab3d8fce877bc0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:21:28 2019 -0700

    s3: VFS: vfs_fruit. Change delete_invalid_meta_stream() to use UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a3bd45212607aad0df244db9178153b949cd97ad
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:19:21 2019 -0700

    s3: VFS: vfs_fruit. Change fruit_pread_meta_stream() to use UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit be586203fa5a1ecfece1d7f5390011c952d821df
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:11:46 2019 -0700

    s3: VFS: vfs_fruit. Add struct files_struct *dirfsp parameter to fruit_unlink_rsrc_adouble() and convert to UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3b1d97555910a9782987a6ab6b0b09e8ac50b792
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:10:16 2019 -0700

    s3: VFS: vfs_fruit. Add struct files_struct *dirfsp parameter to fruit_unlink_rsrc_stream() and convert to UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e79ff5dcfe8455ab956f58c31cfffeede50d9bd3
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:08:08 2019 -0700

    s3: VFS: vfs_fruit. Add files_struct *dirfsp parameter to fruit_unlink_rsrc().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 04ea1232996ddabe0ddb4a9dba56a7b8ba5262a2
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:46:00 2019 -0700

    s3: VFS: vfs_fruit. Add struct files_struct *dirfsp parameter to fruit_unlink_meta_stream() and convert to UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7f49bb9f6ffc67fe40020344700b5f9ef657a7a0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:44:21 2019 -0700

    s3: VFS: vfs_fruit. Add files_struct *dirfsp parameter to fruit_unlink_meta().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit cb5e52377ae344c63d0e28dc0531075cd1d77d6c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:43:29 2019 -0700

    s3: VFS: vfs_fruit: Convert fruit_rmdir_internal() to UNLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 92d8b3b847794ca5c5cd02c3c28b5f3d96540fdc
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:30:19 2019 -0700

    s3: VFS: vfs_fruit: Add dirfsp files_struct pointer parameter to fruit_rmdir_internal().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 96842316788615a368b30f3808a0333678266453
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:24:23 2019 -0700

    s3: VFS: vfs_fruit: Wrap fruit_rmdir() so we can add parameters.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 41a740f25120872e67240440f1f8c2f0c8763bbb
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:20:36 2019 -0700

    s3: VFS: vfs_fruit. Change fruit_unlink_internal() to call UNLNKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 762b95743c1f60249451562251b7bbc0769eeab1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:18:28 2019 -0700

    s3: VFS: vfs_fruit. Add files_struct *dirfsp to fruit_unlink_internal() so we can call UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1e6a8a3093ab118a4dc21344bfb4f41da18adc25
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:16:19 2019 -0700

    s3: VFS: vfs_fruit. Wrap Convert fruit_unlink() -> fruit_unlink_internal() so we can add parameters.
    
    Make fruit_unlink() a wrapper calling the internal version.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3bf8181f159c142a45287e996167d11980508dd6
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 12:34:31 2019 -0700

    s3: smbd: Change rmdir_internals() to call SMB_VFS_UNLINKAT() in 2 places.
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2adc0e0fdcd639a46008edff18371f181da93ed1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 12:29:41 2019 -0700

    s3: smbd: Change recursive_rmdir() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f8cff71e5f9edb97a3817bc259c0aeec6fbdba7f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 12:25:10 2019 -0700

    s3: smbd: Change close_remove_share_mode() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7f7ad9bbfd65f813f59b55e043c9e75859cb71e9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 12:23:02 2019 -0700

    s3: smbd: Change delete_all_streams() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 24516e78eebbb30df09f85cdeacf6d1ad2635d32
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 11:33:53 2019 -0700

    s3: smbd: Change smb_set_file_unix_basic() to call SMB_VFS_UNLINKAT() in 3 places.
    
    Use conn->cwd_fsp as current fsp. This is horrible code and must
    be removed.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 56b355d07959923381e60c3fc51136cc4703876f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 11:22:06 2019 -0700

    s3: pysmbd: Change py_smbd_unlink() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3d6a8d9ae0d55d92068c06651f6722b8158c25c8
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 11:20:36 2019 -0700

    s3: smbd: Change remove_msdfs_link() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 66d86efb9a19285a09940f4f359c80dfd59cddd6
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 11:17:45 2019 -0700

    s3: smbd: Change create_msdfs_link() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 244c3820a87e4273b1135959d197ec9fd30866a7
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 10:56:30 2019 -0700

    s3: cmd_vfs: Change cmd_pathfunc() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f8bdf5db6eb97458450392e2646db746a78b4d81
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:54:00 2019 -0700

    s3: VFS: vfs_acl_common: Convert unlink_acl_common(), acl_common_remove_object() to UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 63d814047f7cf04be2ab0ab2b235d58d22cfbaa2
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:50:17 2019 -0700

    s3: VFS: vfs_acl_common: Add dirfsp, flags parameters to unlink_acl_common().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6ef40bdb94093f2a7afdd0d69bf0467d86660ec8
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:44:33 2019 -0700

    s3: VFS: vfs_acl_xattr: Don't call unlink_acl_common() directly.
    
    Use a wrapper function so we can change the parameters.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 96aeaed858164bb1387c41c954e841e911ba561c
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:41:10 2019 -0700

    s3: VFS: vfs_virusfilter: Change UNLINK -> UNLINKAT in infected_file_action_delete()
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 88249762a4b430e67d7d677b2258389351cc7099
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 19 10:32:41 2019 -0700

    s3: VFS: vfs_posix_eadb: Wrap posix_eadb_unlink() into a call to posix_eadb_unlink_internal().
    
    Allows UNLINKAT parameters to be passed. Change posix_eadb_unlink_internal()
    to call UNLINKAT instead of UNLINK.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 488c65672350819e35a543313ca6c876befd1d6e
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:57:25 2019 -0700

    s3: VFS: vfs_audit. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1023ec61a9deca7a81e0cb4960b51e9b2b917c51
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:16:55 2019 -0700

    s3: VFS: vfs_virusfilter. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 70f5cbc54d7c99ea3709b77487d62ea565a99490
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:14:01 2019 -0700

    s3: VFS: vfs_unityed_media. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b355a9565dcf67304db12aa827ca582d1dd80b89
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:11:20 2019 -0700

    s3: VFS: vfs_time_audit. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 83e0cf6dc9a9017232c910940a46f8d196a2e641
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:09:27 2019 -0700

    s3: VFS: vfs_syncops. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d69a9ba7e3065ae57b7de588cf08fc1324ae5d07
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:10:24 2019 -0700

    s3: VFS: vfs_streams_xattr: Convert streams_xattr_unlink_internal() to use UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0b3b83c15314859a121ebd4b1983b643fb3a490c
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:08:26 2019 -0700

    s3: VFS: vfs_streams_xattr. Wrap Convert streams_xattr_unlink() -> streams_xattr_unlink_internal() so we can add parameters.
    
    Make streams_xattr_unlink() a wrapper calling the internal version.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d7e763ef0558473a81cecd12abc0d50dd77c0b9f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:00:24 2019 -0700

    s3: VFS: vfs_streams_xattr. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e73caaed8226b5ca0c2603930928e36a5a97396d
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:26:13 2019 -0700

    s3: VFS: vfs_streams_depot: Change streams_depot_unlink_internal() to call UNLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7b2fda0576c76b1a63d08a9266620fe87a2ad587
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:23:31 2019 -0700

    s3: VFS: vfs_streams_depot. Wrap Convert streams_depot_unlink() -> streams_depot_unlink_internal() so we can add parameters.
    
    Make streams_depot_unlink() a wrapper calling the internal version.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c81932fdfea44f466afc4726e5facd23ac92bbfa
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 13:41:10 2019 -0700

    s3: VFS: vfs_streams_depot. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 62f92f8b29a4d860ee0062de27edb466f699633d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 13:21:41 2019 -0700

    s3: VFS: vfs_snapper. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 43b9d9adfe3ac5135bee4918e2769cf912e12b7d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 13:19:39 2019 -0700

    s3: VFS: vfs_shadow_copy2. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6f0cc51b1f5fc72734b7766302eb245b484dafc2
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:30:49 2019 -0700

    s3: VFS: vfs_recycle: Change recycle_unlink_internal() to call UNLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1f8bdb3974c5eade55bf307077fb71bf0fac8147
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:22:58 2019 -0700

    s3: VFS: vfs_recycle: Wrap recycle_unlink() into a call to recycle_unlink_internal().
    
    Allows UNLINKAT parameters to be passed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8d9ff50f85cbcfb361ab6c4f78892ab09f60209f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 12:55:49 2019 -0700

    s3: VFS: vfs_recycle. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8c43f6179a92d8aab22de314626692eb1a9c8ab4
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 11:51:09 2019 -0700

    s3: VFS: vfs_media_harmony. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1ee6c9d8a42c9702914acf4d6f10342951cce7d5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 11:04:18 2019 -0700

    s3: VFS: vfs_glusterfs. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6c28a7749bb8c7c45db86647f5046d2df654653e
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:50:06 2019 -0700

    s3: VFS: vfs_full_audit. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2a4eb0782b179d621821a8ecf020f9d0278a289d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:46:02 2019 -0700

    s3: VFS: vfs_fruit. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0c16e77ae1ea0ef565c66e24297031db0b114710
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:07:40 2019 -0700

    s3: VFS: vfs_extd_audit. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 34d7b18cdeda87b0d14e94b56bfc5664b2c9356d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:05:00 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 797f24fd4df288d9dee98c3bfdc0df1dd410931c
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:03:05 2019 -0700

    s3: VFS: vfs_ceph. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f372f2f58c28ff08df3d47f810a9d4d6685662e5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 09:38:42 2019 -0700

    s3: VFS: vfs_catia. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4794e8dbb108d8fe7e09a11a5bf651dcdf55c2a2
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 09:36:34 2019 -0700

    s3: VFS: vfs_cap. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 95197108becd184dbff61dc9929606f62460e98d
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 10:12:38 2019 -0700

    s3: VFS: vfs_xattr_tdb. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 19c8cfa2871050c857c4ad8eecc8dd0f99cfafdb
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 12:01:42 2019 -0700

    s3: VFS: vfs_posix_eadb. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2a7e472e5ca02bb3c6685e38042b23ee27422a5a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 11 16:49:38 2019 -0700

    s3: VFS: vfs_acl_xattr. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2c90d2b4f0d61174a9cd35160ed0ae5d7cb2af6d
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 11 16:42:01 2019 -0700

    s3: VFS: vfs_acl_tdb. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c58692cee919259edc4b95009925d516384bbc6a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 11 14:37:31 2019 -0700

    s3: VFS: Add SMB_VFS_UNLINKAT().
    
    Currently identical to SMB_VFS_UNLINK().
    
    Next, add to all VFS modules that implement
    unlink and eventually remove unlink.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 24f04c1cc561d9f4b7fada1ca87f52bed2167f8d
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 16:32:40 2019 +1000

    ctdb-tests: Update README
    
    Bring this up to date.  Drop descriptions of command-line options
    because these tend to bit-rot - refer to "run_tests.sh -h" instead.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Thu Sep 26 06:01:33 UTC 2019 on sn-devel-184

commit 8a5c4a60e156170f8aaa738672ed6dc50712a929
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 16:00:52 2019 +1000

    ctdb-tests: Move simple tests to INTEGRATION/ subdirectory
    
    Split some tests out into database/ and failover/ subdirectories.
    Rename the remaining tests in simple/.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 658068184ff9437c11e5260e24a632439adb3d27
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 15:59:31 2019 +1000

    ctdb-tests: Move complex tests to CLUSTER/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit df6800e330d1c1fd47ce3d2f7a5814597ed46229
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 5 14:01:20 2019 +1000

    ctdb-tests: Convert local daemons include file into top-level include
    
    Do the same with the alternative code for real clusters.
    
    Both of these can now be used by other test suites.
    
    Fix some basic shellcheck warnings (e.g. avoid word-splitting by
    quoting) while moving code and add the new files to the shellcheck
    test.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 384381fbff5ca900af031fb0606a270f572f5b9e
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 15:01:49 2019 +1000

    ctdb-tests: Drop use of array in run_tests()
    
    This doesn't accomplish anything.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit c438e0db45dd803523802055cb988c10ff277063
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 14:59:38 2019 +1000

    ctdb-tests: Drop custom handling for unit tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 4046baad5c3a5155c18566f853a9a08eb7fa431a
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 25 16:37:46 2019 +1000

    ctdb-tests: Skip README files in test directories/collections
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 75393cab0f87635e829b45b200cc771a0463b6f4
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 14:47:26 2019 +1000

    ctdb-tests: Recurse into directories instead of explicitly looping
    
    run_tests() already has a loop, so use it.
    
    This means collections of test suites can be handled - but explicitly
    check valid collection names to avoid running junk.
    
    Add special cases for simple and complex.  These will be removed when
    those test suites are moved to collections.  This seems to be the
    smallest amount of churn to support bisection.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 4947fa5ffa8784c93f3c570e246b106b35f96a80
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 11:40:21 2019 +1000

    ctdb-tests: Fold find_and_run_one_test() in to run_tests()
    
    The additional function makes the logic harder to understand.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 1061bdf29dce60251a53dcc0623efb8815b144ae
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:51:17 2019 +1000

    ctdb-tests: Move tool tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 9585ece00c8c7eb215da9928e54dae92f55eaac0
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:49:53 2019 +1000

    ctdb-tests: Move takeover_helper tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit cf0b87f9b7876bc4637c3ed57782c35251d2f965
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:49:17 2019 +1000

    ctdb-tests: Move takeover tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 010c1a85fa9719b726d26c48aa3373f2e328e8f0
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:48:05 2019 +1000

    ctdb-tests: Move shellcheck tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a3cbb7eb21be56346b9357649579728d294cf3b4
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:47:21 2019 +1000

    ctdb-tests: Move onnode tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 8ed075d396ba5f6f7b7686fb0593984850923f55
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:44:45 2019 +1000

    ctdb-tests: Move eventscript tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 330a106aaa0c91074d5e64978ed6b2e84702336e
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:43:38 2019 +1000

    ctdb-tests: Move eventd tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 43ed3a6eb3ddf3434790bed2cb6abf08c5ce4c56
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:42:11 2019 +1000

    ctdb-tests: Move cunit tests to UNIT/ subdirectory
    
    The UNIT subdirectory directory will contain all unit tests.  Use an
    uppercase name to avoid conflicts with source code subdirectories.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ab232ca77f8f08879d99f88cfcd554500717075e
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 17:21:51 2019 +0200

    waf: Use waf function to add for -Wl,--as-needed
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Sep 25 16:56:40 UTC 2019 on sn-devel-184

commit 9499db075b72b147e2ff9bb78e9d5edbaac14e69
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 16:53:12 2019 +0200

    waf:replace: Do not link against libpthread if not necessary
    
    On Linux we should avoid linking everything against libpthread. Symbols
    used my most application are provided by glibc and code which deals with
    threads has to explicitly link against libpthread.  This avoids setting
    LDFLAGS=-pthread globally.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit bd0cd8e13234d684da77a65f6fdaea2572625369
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 17:40:13 2019 +0200

    third_party: Link uid_wrapper against pthread
    
    uid_wrapper uses pthread_atfork() which is only provided by libpthread.                                                                                   │····················
    So we need an explicit dependency.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 68d8a02ef57cce29e4ff3ef1b792adfc10d0b916
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 17:39:29 2019 +0200

    third_party: Link nss_wrapper against pthread
    
    nss_wrapper uses pthread_atfork() which is only provided by libpthread.
    So we need an explicit dependency.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 36e8d715bc8dc1e8466f5a5c9798df76310b7572
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 17:04:57 2019 +0200

    third_party: Only link cmocka against librt if really needed
    
    cmocka also uses clock_gettime().
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4b28239d13b17e42eb5aa4b405342f46347f3de4
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 16:10:35 2019 +0200

    pthreadpool: Only link pthreadpool against librt if we have to
    
    This calls clock_gettime() which is available in glibc on Linux. If the
    wscript in libreplace detected that librt is needed for clock_gettime()
    we have to link against it.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 480152dd6729d4c58faca6f3e4fa91ff4614c272
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 15:14:24 2019 +0200

    replace: Only link against librt if really needed
    
    fdatasync() and clock_gettime() are provided by glibc on Linux, so there
    is no need to link against librt. Checks have been added so if there are
    platforms which require it are still functional.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 952e1812fa9bdc1bac2a7ae5ebb5532f1ea31447
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 15:18:55 2019 +0200

    s3:waf: Do not check for nanosleep() as we don't use it anywhere
    
    We use usleep() in the meantime.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 3bb7ccb4635535cb9dd9333220222dcfffb2aed9
Author: Philipp Gesang <philipp.gesang at intra2net.com>
Date:   Thu Sep 19 09:03:45 2019 +0200

    s4:scripting: make samba-gpupdate heed --disable-python
    
    Signed-off-by: Philipp Gesang <philipp.gesang at intra2net.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Noel Power<npower at samba.org>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Wed Sep 25 11:06:04 UTC 2019 on sn-devel-184

commit 018c93f35a80daef74e44e32ff0ff7437eed8547
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 13:15:14 2019 +0000

    s3/librpc/crypto: clang: Fixes Value stored to 'ret' is never read
    
    Fixes:
    
    source3/librpc/crypto/gse_krb5.c:63:3: warning: Value stored to 'ret' is never read <--[clang]
                    ret = smb_krb5_kt_free_entry(krbctx, &kt_entry);
                    ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 40ddcf7bdcec547acdba090f43651cc5b953aded
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 13:12:39 2019 +0000

    s3/libads: clang: Fix Array access results in a null pointer dereference
    
    Fixes:
    
    source3/libads/cldap.c:400:6: warning: Array access (from variable 'responses') results in a null pointer dereference <--[clang]
            if (responses[0] == NULL) {
                ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d3371d8545bb4303e866e991453a0bbb05dd7656
Author: Noel Power <noel.power at suse.com>
Date:   Fri Aug 2 10:45:48 2019 +0000

    s3/librpc/crypto: clang: warning: Value stored to 'gss_maj' is never read
    
    Fixes: Value stored to 'gss_maj' is never read
    
    source3/librpc/crypto/gse.c:562:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                    gss_maj = gss_release_buffer(&gss_min, &out_data);
                    ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source3/librpc/crypto/gse.c:687:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                    gss_maj = gss_release_buffer(&gss_min, &out_data);
                    ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source3/librpc/crypto/gse.c:739:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                    gss_maj = gss_release_buffer(&gss_min, &msg_min);
                    ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source3/librpc/crypto/gse.c:742:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                    gss_maj = gss_release_buffer(&gss_min, &msg_maj);
                    ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    4 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f755de54135ab5900209d093a45d9b824687a3bf
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 15:10:30 2019 +0100

    s4/libcli/clideltree.c: clang: Value stored to 'status' is never read
    
    Fixes:
    
    source4/libcli/clideltree.c:113:3: warning: Value stored to 'status' is never read <--[clang]
    
    status = smbcli_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL, 0);
                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/clideltree.c:131:3: warning: Value stored to 'status' is never read <--[clang]
                    status = smbcli_setatr(dstate.tree, dname, FILE_ATTRIBUTE_NORMAL, 0);
                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ba55c0220767358656be125e6cecedef97317e9f
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 29 11:44:26 2019 +0000

    s4/libcli/smb2: clang: Fix 'value stored to 'status' is never read'
    
    Fixes:
    
    source4/libcli/smb2/util.c:134:3: warning: Value stored to 'status' is never read <--[clang]
                    status = smb2_util_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL);
                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/smb2/util.c:187:5: warning: Value stored to 'status' is never read <--[clang]
                                    status = smb2_util_setatr(tree, name, FILE_ATTRIBUTE_NORMAL);
                                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/smb2/util.c:209:3: warning: Value stored to 'status' is never read <--[clang]
                    status = smb2_util_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL);
                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    3 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 076216da7968b77e2a16cf21f879e9f159bc14da
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 29 11:22:29 2019 +0000

    s4/libcli/smb2: clang: Fix Passed-by-value arg contains uninitialized data
    
    Fixes:
    
    source4/libcli/smb2/getinfo.c:222:11: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'data') <--[clang]
            status = smb_raw_fsinfo_passthru_parse(b.out.blob, mem_ctx, io->generic.level, io);
                     ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 088a345f6acd84d888759c935a92737255e17b3f
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 26 16:23:45 2019 +0000

    s4/libcli/raw: clang: Fix 'Value stored to 'p' is never read'
    
    Fixes:
    
    source4/libcli/raw/clisession.c:198:4: warning: Value stored to 'p' is never read <--[clang]
                            p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->old.out.domain, p, -1, STR_TERMINATE);
                            ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/raw/clisession.c:212:5: warning: Value stored to 'p' is never read <--[clang]
                                    p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->nt1.out.domain, p, -1, STR_TERMINATE);
                                    ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/raw/clisession.c:232:3: warning: Value stored to 'p' is never read <--[clang]
                    p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->spnego.out.workgroup, p, -1, STR_TERMINATE);
                    ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a1a448b19b9565a00e3077690dbda44ed727b2e4
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 26 16:18:49 2019 +0000

    s4/libcli/raw: clang: Fix 'Dereference of null pointer'
    
    Fixes:
    
    source4/libcli/raw/rawfileinfo.c:597:2: warning: Dereference of null pointer <--[clang]
            SMBCLI_CHECK_WCT(req, 10);
            ^
    source4/libcli/raw/rawfileinfo.c:639:2: warning: Dereference of null pointer <--[clang]
            SMBCLI_CHECK_WCT(req, 11);
            ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 55c6e4bcc1b084fc391c21b387694a099a015c83
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 26 15:06:54 2019 +0000

    s4/libcli/raw: clang: Fix 'Access to field results in a deref of a null ptr
    
    Fixes:
    
    source4/libcli/raw/rawfileinfo.c:301:56: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang]
        parms->standard.out.create_time = raw_pull_dos_date2(session->transport,
                                                                             ^
    source4/libcli/raw/rawfileinfo.c:314:55: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang]
        parms->ea_size.out.create_time = raw_pull_dos_date2(session->transport,
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 517ec63004f6708c9e6b29cb33bd789b1936997b
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Sep 3 15:33:42 2019 +0200

    vfs_fileid: add "fsname_norootdir_ext" option
    
    This can be used to deliberately break lock coherency between all smbd processes
    in the whole cluster for the root directory of a share.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Sep 25 00:48:45 UTC 2019 on sn-devel-184

commit 929555b7c8e987a98b704c102323546a2034bea7
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 12 14:36:17 2019 +0200

    vfs_fileid: add extid mapping hooks
    
    For this always ends up calling fileid_extid_mapping_zero(), so no change in
    behaviour. This will change in a subsequent commit.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 0ee085b594878f5e0e83839f465303754f015459
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 08:10:26 2019 +0200

    selftest/Samba3.pm: use "winbind use krb5 enterprise principals = yes" for ad_member
    
    This demonstrates that can do krb5_auth in winbindd without knowning about trusted domains.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Tue Sep 24 19:51:29 UTC 2019 on sn-devel-184

commit e2737a74d4453a3d65e5466ddc4405d68444df27
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 08:02:38 2019 +0200

    selftest/Samba3.pm: use "winbind scan trusted domains = no" for ad_member
    
    This demonstrates that we rely on knowning about trusted domains before
    we can do krb5_auth in winbindd.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit ad6f0e056ac27ab5c078dbdbff44372da05caab2
Author: Stefan Metzmacher <metze at samba.org>
Date:   Sat Jun 10 14:38:40 2017 +0200

    selftest/tests.py: test pam_winbind for trusts domains
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 13e3811c9510cf213881527877bed40092e0b33c
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Mar 20 11:39:41 2017 +0100

    selftest: Export TRUST information in the ad_member target environment
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit f07b542c61f84a97c097208e10bf9375ddfa9a15
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 14:03:34 2019 +0200

    selftest/tests.py: test pam_winbind with a lot of username variations
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 36e95e42ea8a7e5a4091a647215d06d2ab47fab6
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 08:08:57 2019 +0200

    selftest/tests.py: test pam_winbind with krb5_auth
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 72daf99fd1ffd8269fce25d69458de35e2ae32cc
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 01:25:23 2019 +0200

    selftest/tests.py: prepare looping over pam_winbindd tests
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 3d38a8e9135bb72bc4ca079fab0eb5358942b3f1
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 01:25:58 2019 +0200

    test_pam_winbind.sh: allow different pam_winbindd config options to be specified
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 653e90485854d978dc522e689cd78c19dcc22a70
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 20 08:13:28 2019 +0200

    tests/pam_winbind.py: allow upn names to be used in USERNAME with an empty DOMAIN value
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit cd3ffaabb568db26e0de5e83178487e5947c4f09
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 08:04:42 2019 +0200

    tests/pam_winbind.py: turn pypamtest.PamTestError into a failure
    
    A failure generated by the AssertionError() checks can be added
    to selftest/knownfail.d/*.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit a77be15d28390c5d12202278adbe6b50200a2c1b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Jul 19 15:10:09 2019 +0000

    s3:winbindd: implement the "winbind use krb5 enterprise principals" logic
    
    We can use enterprise principals (e.g. upnfromB at B.EXAMPLE.COM@PRIMARY.A.EXAMPLE.COM)
    and delegate the routing decisions to the KDCs.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 9520652399696010c333a3ce7247809ce5337a91
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 11 16:44:43 2019 +0200

    docs-xml: add "winbind use krb5 enterprise principals" option
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 3bdf023956e861485be70430112ed38d0a5424f7
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 15:52:25 2019 +0200

    krb5_wrap: let smb_krb5_parse_name() accept enterprise principals
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 303b7e59a286896888ee2473995fc50bb2b5ce5e
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 16:04:30 2019 +0200

    s3:libads: ads_krb5_chg_password() should always use the canonicalized principal
    
    We should always use krb5_get_init_creds_opt_set_canonicalize()
    and krb5_get_init_creds_opt_set_win2k() for heimdal
    and expect the client principal to be changed.
    
    There's no reason to have a different logic between MIT and Heimdal.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 162b4199493c1f179e775a325a19ae7a136c418b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 16:04:30 2019 +0200

    s4:auth: kinit_to_ccache() should always use the canonicalized principal
    
    We should always use krb5_get_init_creds_opt_set_canonicalize()
    and krb5_get_init_creds_opt_set_win2k() for heimdal
    and expect the client principal to be changed.
    
    There's no reason to have a different logic between MIT and Heimdal.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 5d0bf32ec0ad21d49587e3a1520ffdc8b5ae7614
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 16:04:30 2019 +0200

    krb5_wrap: smb_krb5_kinit_password_ccache() should always use the canonicalized principal
    
    We should always use krb5_get_init_creds_opt_set_canonicalize()
    and krb5_get_init_creds_opt_set_win2k() for heimdal
    and expect the client principal to be changed.
    
    There's no reason to have a different logic between MIT and Heimdal.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 0bced73bed481a8846a6b3e68be85941914390ba
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 16:04:30 2019 +0200

    s3:libads/kerberos: always use the canonicalized principal after kinit
    
    We should always use krb5_get_init_creds_opt_set_canonicalize()
    and krb5_get_init_creds_opt_set_win2k() for heimdal
    and expect the client principal to be changed.
    
    There's no reason to have a different logic between MIT and Heimdal.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 6ed18c12c57efb2a010e0ce5196c51b48e57a4b9
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Sep 17 08:49:13 2019 +0200

    s3:libsmb: let cli_session_creds_prepare_krb5() update the canonicalized principal to cli_credentials
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 361fb0efabfb189526c851107eee49161da2293c
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Sep 17 10:08:10 2019 +0200

    s3:libsmb: avoid wrong debug message in cli_session_creds_prepare_krb5()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit bc473e5cf088a137395842540ed8eb748373a236
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Sep 16 17:14:11 2019 +0200

    s3:libads: let kerberos_kinit_password_ext() return the canonicalized principal/realm
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit db8fd3d6a315b140ebd6ccd0dcdfdcf27cd1bb38
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Sep 17 08:05:09 2019 +0200

    s4:auth: use the correct client realm in gensec_gssapi_update_internal()
    
    The function gensec_gssapi_client_creds() may call kinit and gets
    a TGT for the user. The principal provided by the user may not
    be canonicalized. The user may use 'given.last at example.com'
    but that may be mapped to glast at AD.EXAMPLE.PRIVATE in the background.
    
    It means we should use client_realm = AD.EXAMPLE.PRIVATE
    instead of client_realm = EXAMPLE.COM
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit acbf922fc2963a42d6cbe652bb32eee231020958
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 13:58:46 2019 +0200

    nsswitch: add logging to wbc_auth_error_to_pam_error() for non auth errors
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 4f5c4df316dc029f7b5ed6e8e48636dc61ecfe22
Author: Björn Jacke <bj at sernet.de>
Date:   Fri Aug 23 02:19:20 2019 +0200

    wscript_build: string concatenation efficiency cleanup
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Tue Sep 24 13:40:21 UTC 2019 on sn-devel-184

commit c9088c6aa847685613ec34d61b61e31fe0395035
Author: Björn Jacke <bj at sernet.de>
Date:   Fri Aug 23 02:21:17 2019 +0200

    pfm_verif: string concatenation efficiency cleanup
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit c7fa030aecd1de5ed32e2509ecd83828aa42c1a3
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:10:19 2019 +0200

    scripting: avoid inefficient string redefinition
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit 5ad629dcb957e45637f3a71309fa51abd87b267d
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:09:19 2019 +0200

    wscript: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit b3b6b700c47ba771baf632b3a165106c21c9ae04
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:08:18 2019 +0200

    s3/wscript: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit 32d1c3f873fc8bd89a7dc985cb8258e990dc12cd
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:07:48 2019 +0200

    posixacl.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit dd9e0f0ae1cca23920883a0e04fe5862663e400e
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:07:13 2019 +0200

    auth_log_winbind.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cf51f73e02cab85f508bcbef362ff75a7ae18d7f
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:06:19 2019 +0200

    schema.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d2d8ebcca1cc4539a7a6b48fa364e03adda1db6c
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:06:00 2019 +0200

    user.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit ce56d336f234febfd4cb3da11dd584842c24ce1d
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:05:31 2019 +0200

    gpo.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1825a7f4e2a39d03f01da37b68ba4f65dbafd04a
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:05:10 2019 +0200

    kcc_utils.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4c34a2d72569f31d59b904c3ca1c140f6084b3dd
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:04:25 2019 +0200

    traffic.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b8f4f141a2d7aed9a8af572b27e2afcc1365bf3b
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 17:59:15 2019 +1000

    ctdb-tests: Switch TEST_VAR_DIR to a local script variable
    
    This is now local to run_tests.sh.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Tue Sep 24 03:46:59 UTC 2019 on sn-devel-184

commit e78c1a0ca2254b533ffa1ab27184e73e79819962
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 16:13:45 2019 +1000

    ctdb-tests: Use CTDB_TEST_TMP_DIR in integration.bash
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 263890b36dbe23460a3d38050250d6d792907426
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 5 13:57:35 2019 +1000

    ctdb-tests: Switch simple tests to use CTDB_TEST_TMP_DIR
    
    CTDB_TEST_TMP_DIR repaces SIMPLE_TESTS_VAR_DIR.  local.bash no longer
    needs to ensure that TEST_VAR_DIR is set, since it longer uses this
    variable.  Drop the comment because state has not been maintained
    between tests for some time.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit def929954aa26116fc5356203b313b50fcb6d7a8
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 21:35:39 2019 +1000

    ctdb-tests: Switch takeover helper unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 1934f673dc7aadf8eb288d4ac1b46876d442e039
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 21:35:16 2019 +1000

    ctdb-tests: Switch tool unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 18ecdbfb02e64ae7942378efb69df7541b5859f0
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 19:58:46 2019 +1000

    ctdb-tests: Switch onnode unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 3b16aa2016e499af96c4cbb3de4cb38515e86284
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 20:13:19 2019 +1000

    ctdb-tests: Switch eventscript unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 96aa807f79df99c0fd64ea66d7f83527d5a490c2
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 21:35:54 2019 +1000

    ctdb-tests: Switch eventd unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit cbd27c0a14247477acdf158cc40864afe91e5900
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 21:47:52 2019 +1000

    ctdb-tests: Switch cunit unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit cec8f3907ef7b324035b59f9a965c198b5d03de6
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 5 13:42:26 2019 +1000

    ctdb-tests: Add new variable CTDB_TEST_TMP_DIR
    
    This is a subdirectory of TEST_VAR_DIR that is unique to the current
    test suite.  It is recreated for each individual test.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit e9ce035c2d2ef6fd177a3bb10031162586b696bd
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 16:19:52 2019 +1000

    ctdb-tests: Move setting of CTDB_TEST_SUITE_DIR to run_tests.sh
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 02edfb0f199fb7206df1f725aee56826d65716c1
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 20:54:37 2019 +1000

    ctdb-tests: Rename variable TEST_SUBDIR -> CTDB_TEST_SUITE_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit f331f3f723a4e26af2d5c356cb9b72d062df6311
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 5 15:47:13 2019 +1000

    ctdb-tests: Use local_daemons.sh onnode for local daemons tests
    
    With some upcoming changes, the setting of CTDB_BASE becomes
    problematic because it will be included unconditionally whereas it is
    currently being conveniently and almost accidentally not include in
    some contexts.
    
    So, instead of trying to coerce onnode into behaving as desired, have
    the local daemons tests use local_daemons.sh onnode directly.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ae1e8002b09f0035712df236f4b5efc85d7ad1d6
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 23 16:57:36 2019 +1000

    ctdb-tests: Use local $ctdb_base instead of $CTDB_BASE
    
    The latter might not be defined in a test.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 08fea1ced39652954ae44d8cdc4dc405b31786b6
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 23 16:13:05 2019 +1000

    ctdb-tests: Generalise pattern for matching valgrind memcheck executable
    
    On my laptop this is "memcheck-amd64-linux instead of just "memcheck".
    
    Alternatively, this part of the test could simply be skipped if
    $VALGRIND is set.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit c7e6db97de967e902529fa9e902cdcdf2a159403
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 20 08:37:28 2019 -0700

    smbd: Add an error return END_PROFILE call
    
    All other return; statements in reply_tcon_and_X have this
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Sep 23 17:06:25 UTC 2019 on sn-devel-184

commit 465e518d6cc200eefa38643e720ce64e53abac2e
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Sep 21 13:24:59 2019 +0200

    classicupgrade: fix a a bytes-like object is required, not 'str' error
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14136
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Björn Baumbach <bb at samba.org>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Mon Sep 23 12:58:20 UTC 2019 on sn-devel-184

commit ec4c5975528f3d3ab9c8813e176c6d1a2f1ca506
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Sep 23 08:57:33 2019 +0200

    fault.c: improve fault_report message text pointing to our wiki
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14139
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 89288c7e8398d86a24ea19a94908bc85a2664074
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:03:54 2019 +0200

    samba_version.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sat Sep 21 20:50:17 UTC 2019 on sn-devel-184

commit 432d9fd2214a4804a9cfefb9916e97efb9909c2c
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:02:37 2019 +0200

    samba_deps.py avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 8b43aabecbad2084169b229859bf5bfc9e2ddac0
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:02:00 2019 +0200

    samba_bundled.py avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0141c82eedbe525169546f6d30488149c3a7ed7a
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:01:22 2019 +0200

    samba_autoconf.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2291679e2b02e729e34ef848164d6630c5adc546
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 22:53:59 2019 +0200

    samba_abi.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dd0837c9a84bdbb98c9c31997c431173dfe6e714
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Aug 26 00:50:29 2019 +0200

    user.py: import tempfile module only where needed
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 01b0e5aadf9a9bb6c806850c3708933eebd08c6b
Author: Günther Deschner <gd at samba.org>
Date:   Sat Oct 28 10:44:11 2017 +0200

    spoolss: Add PRINTER_DRIVER_CATEGORY_3D driver define
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Sep 20 12:58:49 UTC 2019 on sn-devel-184

commit 2d5facc95478801580eb52d4d4441660c5fa2697
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 18 19:41:50 2019 +0200

    s4-torture: add netr_LogonGetDomainInfo NDR(64) tests
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Fri Sep 20 02:32:44 UTC 2019 on sn-devel-184

commit 634ab14f0d246fab28cf14ad9664cecf3ca5335a
Author: Günther Deschner <gd at samba.org>
Date:   Thu Sep 19 01:55:09 2019 +0200

    s4-torture: reformat test table in ndr test
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fda5b839c705725301fc17562d08a927751b890b
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 18 19:48:40 2019 +0200

    torture: add torture_suite_add_ndr_pull_io_test_flags()
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 742d8ba9c4b9e6e70898f08a50f9929662bbafb6
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 18 04:11:33 2019 +0200

    s3-rpcclient: add logongetdomaininfo command
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6e47f9ab37744d628cc6b723f4838e81202f2df6
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Jul 20 14:00:05 2015 +0200

    libcli/auth: add netlogon_creds_cli_LogonGetDomainInfo()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 8f0751b8b7cd45fc7186b467d814eb5231821e34
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 13:22:43 2019 +0200

    netlogon.idl: fix the marshalling of netr_trust_extension_container for NDR64
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 0fea2707fb05897eec3c26bd4814669832142382
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 13:22:43 2019 +0200

    netlogon.idl: fix the marshalling of netr_OsVersion for NDR64
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit c87cf54684be606aa8f9b420f5c4f710de2a363a
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Mar 20 12:40:25 2018 +0100

    security.idl: add SE_GROUP_INTEGRITY[_ENABLED] to security_GroupAttrs
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 09de6f06182ede5bee3cb0c5408ce4082c62ccc2
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Mar 20 12:39:02 2018 +0100

    librpc/idl: change from samr_GroupAttrs in samr.idl to security_GroupAttrs in security.idl
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 73b93e1a70508346e813e311179e2ed538adfe6b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Feb 1 23:44:33 2018 +0100

    security.idl: add GUID_DRS_ALLOWED_TO_AUTHENTICATE
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit a7e49897c4ad84a5d7710ac78a09802fe66f9d16
Author: Günther Deschner <gd at samba.org>
Date:   Thu Sep 12 23:27:13 2019 +0200

    misc: fix AD trust attributes in adssearch
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7ba90c17343cc9921e1d44a5055d39602dbb6ba1
Author: Günther Deschner <gd at samba.org>
Date:   Thu Sep 12 16:36:20 2019 +0200

    lsa: document new LSA trust attributes
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d78c87e665e23e6470a19a69383ede7137172c26
Author: Günther Deschner <gd at samba.org>
Date:   Thu Sep 12 16:39:10 2019 +0200

    s3-winbindd: fix forest trusts with additional trust attributes.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14130
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 82512034563870d4629d0a42813560e6d69b2b5e
Author: Günther Deschner <gd at samba.org>
Date:   Tue Sep 17 01:50:33 2019 +0200

    s3-libads: adapt to coding standards, no code changes
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Sep 19 20:48:45 UTC 2019 on sn-devel-184

commit 094862b8a67c8f1a3d37c2838bb0d684d5858da8
Author: Karolin Seeger <kseeger at samba.org>
Date:   Thu Sep 19 09:19:40 2019 +0200

    s3/vfs_shadow_copy2.c: Fix typo in comment.
    
    Signed-off-by: Karolin Seeger <kseeger at samba.org>
    Reviewed-by: Björn Jacke <bjacke at samba.org>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Thu Sep 19 14:09:44 UTC 2019 on sn-devel-184

commit 7b6e56b0f990c01d5b7a948c42e7e66c2ac596c7
Author: Karolin Seeger <kseeger at samba.org>
Date:   Thu Sep 19 09:18:44 2019 +0200

    docs: Fix typo in vfs_ceph_snapshots man page.
    
    Signed-off-by: Karolin Seeger <kseeger at samba.org>
    Reviewed-by: Björn Jacke <bjacke at samba.org>

commit d566a4d3e1019cf356b364826fa3ab0cd970818d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 20:54:03 2019 +1200

    replace: Remove crypt() reimplementation
    
    Use of Samba with plaintext authenticaiton is incredibly rare, even more
    rare is plaintext authentication on systems without a crypt() call and
    where DES based crypt() would be the right thing to do.
    
    Remove this additional cryptographic code per our current efforts
    to rely entirely on external libraries instead.
    
    Similar to the arguments in this thread about zlib discussed on
    samba-technical here:
    
    https://lists.samba.org/archive/samba-technical/2019-May/133476.html
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Sep 19 09:28:21 UTC 2019 on sn-devel-184

commit bc4e8b1abaf8431d1f507107cf60e57da75c0bef
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 30 15:08:40 2019 +0200

    messaging: Do POOL_USAGE via a socket
    
    This makes debugging run-away processes much more efficient and even
    possible at all: If the pool-usage output is more than 256MB, the
    previous code could not realloc it and threw it away. Also, it is not
    helpful for an already huge process to allocate even more.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Sep 18 21:27:30 UTC 2019 on sn-devel-184

commit 23bee5da95026d161159da74a032780a713c820a
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 30 17:09:20 2019 +0200

    lib: Add talloc_full_report_printf()
    
    Print the talloc full report into a FILE*. talloc itself provides a
    very similar function, talloc_report_full(). However, that has a
    slightly different output, in particular it does not print the
    contents of strings, which is very handy for debugging.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 930ec152123e6a7c37f38e52cc7fd32f755a6b83
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 2 11:41:05 2019 +0200

    lib: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3084928383cdeafc53b2154f458464d9174faff2
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Sep 18 09:19:37 2019 -0700

    messaging4: Pass fds to messaging handlers
    
    Boiler-plate replacement moving the (num_fds!=0) check down
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3263dd32fedf9e6c104a0c03f035b585c568a8d1
Author: Sam Zaydel <szaydel at gmail.com>
Date:   Thu Feb 7 20:07:57 2019 +0000

    Argument to control number of operations -o no longer valid
    
    (This patch, only removing manpage text, submitted by gitlab.com user
    Sam Zaydel @szaydel in MR 243 but without a Signed-off-by, so I
    (Andrew Bartlett) am adding mine to say I'm happy to say this is a
    legitimate and deliberate contribtion.)
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Sep 18 19:51:11 UTC 2019 on sn-devel-184

commit 8df123e7f7cb591f6673ccffefffc30b946f1a5b
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Wed Sep 18 03:15:47 2019 +0000

    pod2man is no longer needed
    
    Since e24e344d0da58013fd5fa404529fe1d25ef403bf.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14131
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d65b17c3f7f9959ed95b03cc09e020d7387b7931
Author: Bryan Mason <bmason at redhat.com>
Date:   Mon Sep 16 12:35:06 2019 -0700

    s3:client:Use DEVICE_URI, instead of argv[0],for Device URI
    
    CUPS sanitizes argv[0] by removing username/password, so use
    DEVICE_URI environment variable first.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14128
    
    Signed-off-by: Bryan Mason <bmason at redhat.com>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Sep 18 12:31:11 UTC 2019 on sn-devel-184

commit 55b54e72174fc018fee82ded0cb70eebb839cb5f
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 16:08:17 2019 -0700

    s3: VFS: Remove vfs_netatalk. Old, unused and unmaintained.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Sep 18 01:26:06 UTC 2019 on sn-devel-184

commit fd61e550acec6e9924a71712eef739b58c7d68e8
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 16 16:16:40 2019 -0700

    smbd: Don't always walk the share mode array in open_mode_check()
    
    share_mode_data->flags contains the "most restrictive" share mode of
    the whole array. This is maintained lazily: Whenever set_share_mode()
    is called, d->flags is updated if the new share mode got more
    restrictive. It is not updated when a file is closed, as this would
    mean we would have to walk the whole array, making sure that the
    closed handle was indeed the only most restrictive one. Instead, we
    walk the share mode array only when a conflict happens: Then we need
    to know "the truth" and recalculate it by walking the share mode
    array.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Sep 18 00:07:13 UTC 2019 on sn-devel-184

commit ac85ec5ed855d8d0bc2564cbd33a580a8db6818e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 9 16:27:48 2019 +0200

    smbd: Add share mode flags
    
    This will contain a summary of the "most restrictive" share mode and
    lease, i.e. intersection of all share_access entries and the union of
    all access_mask and leases in the share mode array. This way
    open_mode_check in the non-conflicting case will only have to look at
    the summary and not walk the share mode array.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 86b4907853e8df20ebe3ec6871aa3210f1bde201
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 9 16:16:21 2019 +0200

    smbd: Make "share_mode_flags" 16-bit wide
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9c99675bcbc530f8054de77b1a5f660dde015c62
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 16 10:01:36 2019 -0700

    smbd: Introduce share_entries.tdb - ADD COMMENT FIXME !!
    
    This moves share_modes[] from "struct share_mode_data" into a separate
    share_entries.tdb with a sorted array of fixed-length (132 byte)
    "struct share_mode_entry" entries.
    
    I know it's one huge commit, but I did not see a way to keep both data
    structures and associated code working together without a lot of code
    duplication after having centralized all the code accessing the
    share_modes[] array into a few routines.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 15a8af075a2d7b59f4d97d9804599b26325e5640
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 13 14:18:05 2019 +0200

    lib: Enable watching and storing dbwrap_watch records.
    
    Samba so far on a dbwrap_watch record either watches or stores a
    record, but never both from the same db_record instance acquired from
    a dbwrap_fetch_locked(). In one of the next commits this will change,
    we will watch a record and at the same time store data into it. This
    patch enables a watch_send() followed by a storev() by properly
    keeping the watchers around.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 72ac1764d69e165052220f2c1b5bc0d5613ef201
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Sep 15 11:58:43 2019 +0200

    smbd: Allow another database between brlock.tdb and leases.tdb
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ded3f91d80763edfab242a48baa834e669e16ed5
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Sep 15 11:56:25 2019 +0200

    lib: Allow a 4th lock order
    
    We will have another tdb soon
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d3b0ed13c223a2e4ff22026cddbc55992f35288d
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 14:37:26 2019 +0200

    torture3: Remove cleanup3
    
    This goes directly into the database, for which the format changes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 87e42c73d379738a5f87569ea630c28c9d66c148
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 2 16:25:28 2019 +0200

    smbd: Remove stale share mode entries while walking the array
    
    Previously, we did this only when writing out the locking.tdb
    record. That was because we had places where the index of a particular
    share mode entry mattered while operating on the array. This is no
    longer the case, so we can remove stale entries early.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f96aa7063e846021b69403cc9caa091c8e09b578
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 26 18:59:44 2019 +0200

    smbd: Make remove_stale_share_mode_entries() static in share_mode_lock.c
    
    ... to the place where the record is stored in the database
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5151b6d58be54d210795e7769033cb33e6c75b0a
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 26 18:56:24 2019 +0200

    smbd: Avoid calling remove_stale_share_mode_entries() in open.c
    
    All places that matter explicitly check for staleness. This cleanup
    action should only happen before writing the database
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 72a019d4e32d46ae160ecfe2c90348d005ec2449
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 26 17:09:57 2019 +0200

    smbd: Use share_mode_forall_entries() in remove_lease_if_stale()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4d512f40f9f6c1689cc4e0ace541079fda98c611
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 26 16:51:56 2019 +0200

    smbd: Pass share_mode_lock to remove_lease_if_stale()
    
    We'll want to use share_mode_forall_entries next
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ad23d0f4f57e24a36960a1fa85f527e96753e4d2
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 26 16:47:44 2019 +0200

    smbd: Pass share_mode_lock to remove_share_mode_lease()
    
    Later we'll need "lck" further down
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5709856138d3149caf019bf70f9acf673efedec7
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 26 16:45:14 2019 +0200

    smbd: Avoid duplicate assignments
    
    remove_share_mode_lease() already does this
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 609143adb68b05dbfa13db0f9289a33b53919a71
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 23 17:44:25 2019 +0200

    smbd: Remove unused share_mode_stale_pid()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e4a5a017c5d8c4aac14e3440f498374700dd7fbd
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Sep 12 13:03:53 2019 +0200

    smbd: Use share_mode_forall_entries() in share_entry_forall()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6a58f29c6205d6a4cc7f98ad0f5c6ebf1dadd385
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Sep 12 12:41:14 2019 +0200

    smbd: Use share_mode_forall_leases() in share_mode_cleanup_disconnected()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8eda954d6d7469c54855d22a97bf625f32ebdad7
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 19 13:16:53 2019 +0200

    smbd: Use share_mode_forall_leases() in lease_match()
    
    We have to break leases referenced from multiple share modes only
    once.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c7a9e0e4cdfb22e66533b5c8e20af3cfdb8ae78c
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Sep 12 11:35:34 2019 +0200

    smbd: Use share_mode_forall_leases() in delay_rename_for_lease_break()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2d9bb67d25181eba79b95df661e5a5d613b4a850
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 23 14:30:07 2019 +0200

    smbd: Use share_mode_forall_entries() in vfs_default_durable_reconnect()
    
    The durable reconnect mainly has to check that there is one and only one
    entry, and it has to reset it with the new values.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b3473efa9d3ab7ccd364ab29a3e93e900b5a49e2
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 23 14:13:41 2019 +0200

    smbd: Add reset_share_mode_entry
    
    Mostly for durable reconnect at this point
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2185db6c610433e0651543b7179cf1fbd0e2c9eb
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Sep 11 16:50:24 2019 +0200

    smbd: Pass pid/share_file_id to find_share_mode_entry()
    
    Avoid the full fsp, this makes the indexing of the share mode array
    clearer, and it makes the next commit easier
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ac119c411c4e268d7fe3c6766d3f9023ea4df456
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 26 22:05:14 2019 +0200

    smbd: Use share_mode_forall_entries() in share_mode_forall_leases()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f69310672501c0e2d0afe638a18a0e21fec17298
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 10 21:21:01 2019 +0200

    smbd: Stop passing "share_mode_lock" via share_mode_forall_leases()
    
    Why? Next commit will make share_mode_forall_leases() use
    share_mode_forall_entries(), and that does not necessarily have to
    depend on "share_mode_lock". And as we can pass the required
    information via "private_data", don't embed the "share_mode_lock"
    reference into this lowlevel library routine.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4955481a678eb69df380c3c915cef95feec92443
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 10 21:17:34 2019 +0200

    smbd: Avoid "share_mode_lock" dependency cleanup_disconnected_lease()
    
    share_mode_forall_leases() will stop passing "lck" soon.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f82aebe943534d5ab9b89dcec2150f985b574115
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 10 21:12:23 2019 +0200

    smbd: Avoid "share_mode_lock" dependency in rename_lease_fn()
    
    share_mode_forall_leases() will stop passing "lck" soon.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2a784883a889b517b86cce328f0798c92b69a2d5
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 20 14:47:27 2019 +0200

    smbd: Use share_mode_forall_entries() in delay_for_oplock()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 30e62710c6e323028555deb0eaee238c1713d7e9
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 10 21:00:29 2019 +0200

    smbd: Pass "struct file_id" to get_lease_type()
    
    It does not have to depend on the whole struct share_mode_data.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit aa94589904518e74b533dc47d56ba6811b6b997f
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Aug 18 17:49:23 2019 +0200

    smbd: Use share_mode_forall_entries() in validate_oplock_types()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 18c8b46e8176ea56f24a853d1f6c5ca484df7d81
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 16 15:56:23 2019 +0200

    smbd: Use share_mode_forall_entries() in file_has_open_streams()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 434028518403e7e1d216a4acb9b229caccc44149
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 16 15:40:55 2019 +0200

    smbd: Use share_mode_forall_entries() in rename_share_filename()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fb0b107ac2dc594fd9343f3767b3fb298909879d
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 16 13:08:23 2019 +0200

    smbd: Use share_mode_forall_entries() in open_mode_check()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cb4b20b79fb426682cdc5c84a88443e590df3df8
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 16 12:48:15 2019 +0200

    smbd: Use share_mode_forall_entries() for validate_my_share_entries()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5b1fd018a2c47106102deb74bbd72fdf0c9faf02
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 16 11:11:36 2019 +0200

    smbd: Use share_mode_forall_entries() in has_delete_on_close()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 14cc16948f0da00119cc85ebe7f9ab51b2275ece
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 21:40:07 2019 +0200

    smbd: Use share_mode_forall_entries() in has_other_nonposix_opens_fn()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f5a6fa40928f9e8c9b91f38f287fd9264de9d826
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 17:29:19 2019 +0200

    smbd: Use share_mode_forall_entries() in set_delete_on_close_lck()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5cbd3e46714f5bfdbfa54c8cef0f8145bee08094
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 13 15:21:59 2019 +0200

    smbd: Use share_mode_forall_entries() in contend_level2_oplocks_begin_default()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit eb99635d0f2a8dbd52d4a5143efe5a9716401b08
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 13 15:09:51 2019 +0200

    smbd: Add share_mode_forall_entries()
    
    Abstract away the fact that we store the share modes as an array inside
    "struct share_mode_data".
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit be799acb4558f347c6e6a82874897c7af0c0c3d8
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 13 16:04:13 2019 +0200

    smbd: Use share_entry_stale_pid() in share_mode_stale_pid()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 55e47ada9f85d5152b342d7d39226dc18bbaf162
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 13 16:00:09 2019 +0200

    smbd: Add share_entry_stale_pid()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dc7dfb1257397491f8f02d1e1c42253103235d5f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 6 11:15:27 2019 +0200

    smbd: Avoid passing a share mode entry to share_conflict()
    
    Make the real data dependencies clearer, we don't need a full
    share_entry, only its access and sharemode masks
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e69c4faeb7187922674d85c90134324725993671
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 12 12:44:39 2019 +0200

    smbd: Rewrite share_conflict()
    
    It was hard for me to understand share_conflict(), so once I understood
    it I thought this version would be easier to follow.  It violates
    README.Coding (one argument per line), but grouping the parameters to
    mask_conflict makes it clearer to me what belongs together.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e0aa1e09988690ecb8f5caa7201b4a622fc22be5
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Sep 5 09:52:10 2019 +0200

    smbd: Fix a debug message hickup
    
    Mind the missing space before "(e.g. another...". While there, avoid
    casts.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 27b63641828f6f1e7e3c8b97cb34795a75688b8f
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Sep 7 18:56:54 2019 +0200

    lib: Use server_id_cmp() in server_id_equal()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d9ce9c42cb6abd3263d639d6474a92b85776ba8d
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Sep 7 18:55:57 2019 +0200

    lib: Add server_id_cmp()
    
    Will be used later for sorting the share mode array
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ba1234d877b3364be3b2f6793e3a6fe6c238da0f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 6 11:30:23 2019 +0200

    smbd: Introduce helper variables in open_mode_check()
    
    Less bytes .text, the compiler now does not have to expect other threads to
    alter the pointers.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d12421ace457d1fdca0d97e2c680e90edf556967
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 15 12:10:52 2019 +0200

    smbd: Let fsp_lease_type() look at leases.tdb
    
    The same lease can be used via different TCP connections (yes, we have
    tests for this!). At the end of downgrade_lease() we update all fsp's
    with fsps_lease_update() that link to the lease that just was
    changed. However, this is only in the local process, this is not
    cross-smbd. So other smbds using the same lease can use stale
    information and for example get the mandatory locking wrong.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cc2e5b41646f6c18288ffb4b0ea16f4ea2cb4874
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 13 22:07:47 2019 +0200

    smbd: Add quick leases_db_get_current_state()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8d63b622df42111b603d5f6fe2fa31490eb7cd98
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 15 16:33:57 2019 +0200

    smbd: Make "current_state" show up first in the blob
    
    Believe it or not, but without this change "num_files" was first.
    Thanks Metze for this (to me at least) really, really surprising
    insight!
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 735439765a29b0b31e530998e0d46b11c298c50b
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 15 11:59:11 2019 +0200

    smbd: Make lease_type_is_exclusive() static
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 41393a648899ab2ce61c69e673240e9821735c06
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 16 11:18:00 2019 -0700

    smbd: Remove unused smbXsrv_open_hash()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e00e53344df78b54bb5978de7062bf4c1242bd46
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 16 03:54:32 2019 -0700

    smbd: Make fsp->fh->gen_id unique per process
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4f8db9b3cff9ef548a66b45f998573aea103db8c
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 16 03:50:02 2019 -0700

    vfs: Make "fd_handle->gen_id" 64-bit everywhere
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3d1da1ac308538e47017091123361cc927d8d778
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 16 05:04:06 2019 -0700

    idl: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 78fce47fc23173885143b730552599023c845963
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 16 05:26:05 2019 -0700

    smbd: Use direct struct assignments in smbXsrv_*.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e0a3cc469f2f63a663496e932426a289a831dd44
Author: Björn Baumbach <bb at sernet.de>
Date:   Mon Sep 16 16:22:37 2019 +0200

    vfs/full_audit: always log full filenames
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13565
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Sep 17 17:55:55 UTC 2019 on sn-devel-184

commit 16eb80058ca4a34df96388c26736590247b6a3f4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Sep 6 07:39:09 2019 +1200

    build: Remove tests for getdents() and getdirentries()
    
    These date back to 3a9beef2b7b25427ee4611cfc375e05cc82a1150 in 2003 and
    829e72fe9c97feaa3d45b768984a4c47b906a23a in 1998 and appear to be related
    to smbwrapper.
    
    More of these should be removed but the getdirents() test caused a timeout
    on an ARM builder in Debian.  It might just be a fluke but the tests are
    pointless regardless.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Sep 17 13:48:18 UTC 2019 on sn-devel-184

commit 5a80f399b51221fb0b8661f30d940ca24e1ce627
Author: Khem Raj <raj.khem at gmail.com>
Date:   Thu Sep 5 21:39:05 2019 -0700

    util_sec.c: Move __thread variable to global scope
    
    Make clang happy otherwise it complains about variable scope
    
    fixes
    
    source3/./lib/util_sec.c:470:4: error: '__thread' variables must have global storage
            } __thread cache;
              ^
    
    Signed-off-by: Khem Raj <raj.khem at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 98fe813d9cd360f9ac3f9836cd1de9c4a174413f
Author: Khem Raj <raj.khem at gmail.com>
Date:   Thu Sep 5 21:37:33 2019 -0700

    lib/replace/wscript: Avoid generating nested main function
    
    clang is not happy when it sees another main nested inside the main
    function and fails the test for prctl syscall, therefore avoid adding
    implicit main() here
    
    Signed-off-by: Khem Raj <raj.khem at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 84f544b55f235e2f08596bf4b7854460af008f88
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 4 14:14:22 2019 +1000

    ctdb-client: Fix some typos in debug messages
    
      tdb_sore -> tdb_store
      SCHDULE_FOR_DELETION -> SCHEDULE_FOR_DELETION
    
    Switch to modern debug macros while touching the lines.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Tue Sep 17 05:52:15 UTC 2019 on sn-devel-184

commit fc7f3b99acad0a1c5ebeb2bc3c0753ec7b31bb49
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Sep 3 15:24:52 2019 +1000

    ctdb-scripts: Drop bit-rotted shellcheck directive
    
    The code has changed so this is no longer needed.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 80cbebce7123f934562d74e5e29dae3719e9cc37
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 2 14:58:22 2019 +1000

    ctdb-scripts: Silence shellcheck warning SC2166
    
    This covers the following:
    
      SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
      SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
    
    POSIX agrees that -a and -o should not be used:
    
      https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
    
    Fixing these doesn't cause much churn.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 597039daeb88f6d97f71ecaaa55efd7e091638ea
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Jul 3 20:40:44 2019 +1000

    ctdb-utils: CID 1273087 - Resource leak
    
    Ensure that p is not leaked.
    
    This is a test program and the program exits anyway.  No need to
    backport.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 32b5ceb31936ec5447362236c1809db003561d29
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Aug 13 21:42:15 2019 +1000

    ctdb-tools: Stop deleted nodes from influencing ctdb nodestatus exit code
    
    Deleted nodes should simply be ignored.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14129
    RN: Stop deleted nodes from influencing ctdb nodestatus exit code
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 2b37d99a5fbb08954dc4c0ff20867e9fd9dd5712
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 4 15:04:05 2019 +1000

    ctdb-tests: Put the summary file inside $TEST_VAR_DIR
    
    This means less random files dropped in /tmp or similar.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 7a5a4a4494d5fd2514651e06c2206007b8422449
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 4 14:59:22 2019 +1000

    ctdb-tests: Drop run_tests -d option
    
    The usage message says it is dodgy and some test suites may not
    support it.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 2730e48360750d4fbfd66ea76a2b0f002acfcab9
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Sep 3 19:12:45 2019 +1000

    ctdb-tests: Simplify setup_ctdb()
    
    There is no point inventing a whole new set of options here.
    
    Continue to locally implement the --no-event-scripts option.  This
    must be first, though in practice only one option is ever passed to
    setup_ctdb() from ctdb_test_init().
    
    Simply pass all other options through to "local_daemons.sh setup".
    This has the side effect of causing failure when an invalid option is
    passed.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 8443798846d3e6f67eeb651f98af24272a8a4b5c
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Sep 3 17:54:29 2019 +1000

    ctdb-tests: Invert some logic so it makes sense
    
    The test should be outside the loop.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 8038f4f64f4f6a77346837c1877e352be2632cd0
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 09:01:36 2019 +1000

    ctdb-tests: Avoid shellcheck warnings
    
    SC2086 Double quote to prevent globbing and word splitting
    
    This one doesn't need the double quotes if it is contained within the
    preceding variable expansion.
    
    SC2181 Check exit code directly with e.g. 'if mycmd;', not indirectly with $?
    SC2004 $/${} is unnecessary on arithmetic variables
    
    These are straightforward.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 497ae563a0b3e45794c22acb67ccde060d34f371
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Sep 3 17:40:59 2019 +1000

    ctdb-tests: Fix zero event scripts test so it tests something
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 429502186a70f4220c8597d68a3306a073a33c4c
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 20:03:36 2019 +1000

    ctdb-tests: Drop unused code from onnode unit test ctdb stub
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit bb040f27985245449771a68606f0da2440ba1e7c
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 5 15:51:08 2019 +1000

    ctdb-tests: Only set TEST_SUBDIR when needed
    
    This is only needed for setup_ctdb_base() so only set it when calling
    this function.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 284bbca7c730235dd2df9ec2acbfc5fa6de5be42
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 5 16:15:54 2019 +1000

    ctdb-tests: Move NFS test functions to complex local script
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 2c6b098c7220a3e6d78f6040c912fc22a02f6e46
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 16:58:06 2019 +1000

    ctdb-tests: Don't run setup_ctdb_base() for real cluster
    
    This has not been needed for some time.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 8aed06ce8c802d75e7bacb289916c835164e7307
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Aug 2 16:18:32 2019 +1000

    ctdb-tests: Use db_ctdb_cattdb_count_records()
    
    Avoid reinventing the wheel.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 68684377c6970725a57ec6111cb165736468440f
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 16 19:08:11 2019 +1000

    ctdb-tests: Use ctdb_get_all_pnns()
    
    The nested, arbitrary use of onnode can cause messages from ssh on
    stderr to appear in the node list:
    
      Getting list of nodes...
      Output of "onnode -pq all ctdb pnn | grep '^[0-9][0-9]*$'":
      Warning: Permanently added '10.0.0.72' (RSA) to the list of known hosts.^M
      Warning: Permanently added '10.0.0.75' (RSA) to the list of known hosts.^M
      Warning: Permanently added '10.0.0.73' (RSA) to the list of known hosts.^M
      Warning: Permanently added '10.0.0.74' (RSA) to the list of known hosts.^M
      1
      0
      3
      2
      Create/wipe test database rec_test.tdb
      Failed to execute "Permanently added '10.0.0.72' (RSA) to the list of known hosts.^M ctdb attach rec_test.tdb" on node(s) "Warning:"
      Invalid <nodespec>
    
    Avoid that by using an existing function that does not nest ssh uses.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 522a8480fa5e886d66a2efc8d49ac4e2ac6403d7
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 16:04:36 2019 +1000

    ctdb-tests: Drop reference to unused ctdb_eventd test directory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit d51bb3137fad727baa487c4210ac4d5020bf7a1e
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Sep 11 13:58:48 2019 +1200

    whitespace: Conform to coding convention
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Fri Sep 13 12:33:32 UTC 2019 on sn-devel-184

commit a0fe965c36218c5992ed2a6fe7c7fdb00b420702
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Sep 11 13:55:37 2019 +1200

    param: Allow rpc server dynamic port range to roundtrip
    
    Originally this parameter only set two other parameters, but never set
    the original string. By setting the string as well, we can make it be
    emitted by testparm -v correctly (instead of ''), and set it back as the
    value for the parameter.
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit b730f350c2209236641d0423d4d0c00d43a24929
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date:   Thu Sep 12 11:16:50 2019 +0200

    s4:torture: fix file cleanup in smb2.create.delete
    
    Cleanup of test files created by smb2.create.delete is broken because
    READONLY is set on the test file. Clear READONLY first before doing
    the cleanup.
    
    Signed-off-by: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Sep 12 17:36:50 UTC 2019 on sn-devel-184

commit aa5b2333283871cc573b3013669c64c3edd3684c
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date:   Thu Sep 12 11:18:51 2019 +0200

    s4:torture: fix closure of test directory handle
    
    Signed-off-by: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 156eb9120e66fe58328decb035a4d926396f6a59
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date:   Thu Sep 12 10:22:58 2019 +0200

    s4:torture: correctly cast printf() argument
    
    In most cases sattrib is passed as a long int literal. Avoid
    compile errors by casting the value passed to printf().
    
    Signed-off-by: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 35cd91ee4d8fcd1034787882fb2e2e2ab9f8bd34
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jul 16 14:20:33 2019 +0200

    smbd: remove unused current_user.{need,done}_chdir stacking
    
    All become_*()/unbecome_*() functions don't alter the working
    directory. Only change_to_user_and_service*() does.
    
    Pair-Programmed-With: Ralph Boehme <slow at samba.org>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Sep 11 21:16:57 UTC 2019 on sn-devel-184

commit e9256b306ecd4299aa96b27d81800382414572a9
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jul 16 14:11:22 2019 +0200

    smbd: inline change_to_user_internal() into change_to_user_and_service()
    
    There was only one caller left.
    
    Pair-Programmed-With: Ralph Boehme <slow at samba.org>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5da24aa18e9c0ff6f2852b5421945111ef5c6b2b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Jul 19 11:14:13 2019 +0200

    smbd: rename [un]become_user*() to [un]become_user_without_service*()
    
    We should make the behavior change (that gives up some protection)
    more obvious, by changing the function names.
    
    At least some OEMs have patches relying on the 4.9/4.10 behaviour
    and we want them to detect that they have to do more work when they
    need to change directories.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 15699475d6031dd0ed5cd24e9915c574b35a233b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jul 16 14:06:09 2019 +0200

    smbd: remove directory changing from become_user*()
    
    This was the behavior in versions before 4.9 and
    it is hopefully not required by current callers of
    become_user*().
    
    Pair-Programmed-With: Ralph Boehme <slow at samba.org>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b6cf33015de596cd4295d24da4cfcee6c437e3aa
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jul 16 14:03:57 2019 +0200

    smbd: inline change_to_user_and_service() into become_user()
    
    In the next commit we'll drop the _and_service() part.
    
    Pair-Programmed-With: Ralph Boehme <slow at samba.org>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5a736db046d1922e2b7ad13baf38c42b46f2115d
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Jul 13 16:38:02 2019 +0200

    smbd: inline change_to_user_by_session()
    
    Prepares for removing changing cwd from become_user*() in a subsequent commit.
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1d6fe10ec62d447b004c0e691deb0f970268bad9
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Jul 13 16:10:53 2019 +0200

    smbd: README.Coding fixes
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1f4ec34447704dc02f08fc4f53ca988571d4769c
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Jul 13 16:20:11 2019 +0200

    smbd: rename change_to_user_by_fsp() to change_to_user_and_service_by_fsp()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d836f4a7d6ffbd3719a8be8141b7a186648556dd
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Jul 13 16:17:17 2019 +0200

    smbd: rename change_to_user() to change_to_user_and_service()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ae3cfa5da9e86a4f379df7bba8e45ef31a28bc4d
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 9 17:24:57 2019 +0100

    smbd: Enhance debugging if chdir fails
    
    This helps admins to figure out which user has a problem
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 219a189c9993893149c9beef90a9d626ee0f3fa7
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 9 17:04:34 2019 +0100

    lib: Add "utok_string"
    
    A terse, one-line unix token representation for debugging purposes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c7167e7a82974ee9a07448a1de61c523a58896c9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 16:01:20 2019 -0700

    s3: VFS: Complete the replacement of SMB_VFS_MKDIR() -> SMB_VFS_MKDIRAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Sep 11 19:44:44 UTC 2019 on sn-devel-184

commit 2cd27f472463a9ff68d1c7ef84e6cc26998469d5
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:53:12 2019 -0700

    s3: VFS: vfs_time_audit. Remove mkdir_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the mkdir_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d992708d3d51d86391f218ac72127fbc91d1971b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:52:14 2019 -0700

    s3: VFS: vfs_full_audit. Remove mkdir_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the mkdir_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a6f238f6e7567fe62b4b6f883898201518ac84d8
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:50:58 2019 -0700

    s3: VFS: vfs_xattr_tdb. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit fcccf3ea96ed046d30fa771506ce1990757c01d0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:50:19 2019 -0700

    s3: VFS: vfs_unityed_media. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0a8bd88189090f71fd10e87f53b3cdf83929d501
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:49:37 2019 -0700

    s3: VFS: vfs_syncops. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 12ab9553d4c66393c92c498a26436bc16f3f009b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:49:01 2019 -0700

    s3: VFS: vfs_snapper. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8470fe4ad0a606974636c009eaf194ccb0102fc3
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:48:20 2019 -0700

    s3: VFS: vfs_shadow_copy2. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c33eee0232f2ccc822dfb8da254e40c58afafdf0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:47:40 2019 -0700

    s3: VFS: vfs_media_harmony. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 88fa32fb6950d3f06658814d6d0420c120ec6272
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:46:58 2019 -0700

    s3: VFS: vfs_linux_xfs_sgid. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6673d23b34a1dcfe1eef3f565e9b82a89087c52c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:46:08 2019 -0700

    s3: VFS: vfs_glusterfs. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 79f4b1339af084d7ed2ca00de700d190e252413a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:45:25 2019 -0700

    s3: VFS: vfs_extd_audit. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit fa9f83d304bc9bce9c3eb04affbc19795aa70424
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:44:36 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit abbd55ff4cf47bbf3f48f34ed0738406ef419f81
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:43:50 2019 -0700

    s3: VFS: vfs_ceph. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 33221ac5270641346fddd20e866b3df327823bd5
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:43:03 2019 -0700

    s3: VFS: vfs_catia. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 450d392551753b7a2d4b0972adea2388f60aa89a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:42:10 2019 -0700

    s3: VFS: vfs_cap. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 71833b224595054ed0235a37f3d169c11f47c8bd
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:10:38 2019 -0700

    s3: VFS: vfs_audit. Remove mkdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 99e04578e35d630930e03ee1120b2a432a0edccd
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:05:36 2019 -0700

    s3: smbd: Change mkdir_internal() to call SMB_VFS_MKDIRAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e4e819c08736d73c046a6fba7437edc690fc9698
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 15:03:50 2019 -0700

    s3: pysmbd: Change py_smbd_mkdir() to call SMB_VFS_MKDIRAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d2e62772d53c3e4bec730a9bad6808f008675cd0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 10:06:23 2019 -0700

    s3: VFS: vfs_virusfilter: Change use of SMB_VFS_NEXT_MKDIR -> SMB_VFS_NEXT_MKDIRAT.
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ea93b756cb23e37d367a07480a50666633b21ef9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 10:02:27 2019 -0700

    s3: VFS: vfs_streams_depot: Change use of SMB_VFS_NEXT_MKDIR -> SMB_VFS_NEXT_MKDIRAT.
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 497c27a4694f9563145c4de90af753e747c5ad0c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 09:51:47 2019 -0700

    s3: VFS: vfs_recycle: Change use of SMB_VFS_NEXT_MKDIR -> SMB_VFS_NEXT_MKDIRAT.
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 91e24b04de059c9e3490904373f1e92db6896486
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 11:27:42 2019 -0700

    s3: torture: Change cmd_mkdir to call SMB_VFS_MKDIRAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a799866f2b4e7c38b09140af47ad165172aaf544
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 11:09:40 2019 -0700

    s3: VFS: vfs_xattr_tdb. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 63132f8b0418c6d0ed7b664d865724d657b8606a
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 11:08:05 2019 -0700

    s3: VFS: vfs_unityed_media. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b691df9c2f8a8158c0892c7461cf7ccdbe9ed1b1
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 11:03:29 2019 -0700

    s3: VFS: vfs_time_audit. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ef5bb79677f4a2cca613478c5d4b006d64b67f1b
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 10:40:04 2019 -0700

    s3: VFS: vfs_syncops. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 41f9c49eec2ed6a9a796064349d06c38bc1477fc
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 10:33:38 2019 -0700

    s3: VFS: vfs_snapper. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1bcd799517c76f31c79006fc71ed99f258e19073
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 10:32:18 2019 -0700

    s3: VFS: vfs_shadow_copy2. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0999e6865154c2fae67961c76acfb4ae6ab505d5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 10:26:53 2019 -0700

    s3: VFS: vfs_media_harmony. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5dc885a742107a8bc73262af8e7da044feab3d3e
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 10:15:18 2019 -0700

    s3: VFS: vfs_xfs_sgid. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e55ee2968de3a3d1822062c11d53d383894b7c44
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 5 09:33:32 2019 -0700

    s3: VFS: vfs_glusterfs. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d444cd4e46b836ef643bff26d940a1c5b2f3be0d
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 4 15:48:23 2019 -0700

    s3: VFS: vfs_full_audit. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d5ac30233e36072a899463b18694a24872e865dc
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 4 15:46:08 2019 -0700

    s3: VFS: vfs_extd_audit. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0c5825debf5208c3629e55b9ec946ff3021fb1e6
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 4 15:43:44 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 808bc3979f5ababbdc1b85a9566af47c4febf480
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 4 15:14:54 2019 -0700

    s3: VFS: vfs_ceph. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit be61efc8bc4be9b6db2e08b1eed6e458fc6f612c
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 4 13:55:17 2019 -0700

    s3: VFS: vfs_catia. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 84cb7db8b7a9658f668d933d54393efd69c3c41a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 4 13:53:43 2019 -0700

    s3: VFS: vfs_cap. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6a24668f23d2b58bd5076e7349efaa84c7a17548
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 4 13:38:56 2019 -0700

    s3: VFS: vfs_audit. Implement mkdirat().
    
    Currently identical to mkdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ca3bc7809949c593fd545047a898348d2f5c4da4
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 4 12:20:46 2019 -0700

    s3: VFS: Add SMB_VFS_MKDIRAT().
    
    Currently identical to SMB_VFS_MKDIR().
    
    Next, add to all VFS modules that implement
    mkdir and eventually remove mkdir.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5e7828faf3b76c82781e8707d7d7ef990224bd7e
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 14:51:29 2019 -0700

    s3: pysmbd: Ensure conn->cwd_fsp member of created connections is initialized.
    
    This is needed to correctly call the XXXAT() vfs calls.
    
    We should probably just use create_conn_struct_tos_cwd() here
    and pass $cwd instead of using create_conn_struct_tos() and
    passing "/" as the share root. We wouldn't change the current
    working directory and the created share root would be set to $cwd
    but I'm not sure what effects this may have on users of pysmbd
    in case any of them pass paths above the $cwd to these functions.
    
    Less changes to just call vfs_ChDir(conn, &cwd) which doesn't
    change the current directory and leaves the share root as "/".
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d9d704b01e21fbc6b05164a5d1fee772f1836fa9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 14:05:43 2019 -0700

    s3: torture: vfstest: Change from create_conn_struct_tos() -> create_conn_struct_tos_cwd().
    
    This does a vfs_ChDir() to the share root (not changing the
    directory) which correctly sets up the conn->cwd_fsp member
    so any XXXAT() calls correctly work inside vfstest.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0c0ca0dbd7a7a6512b37ca8a186d814eed47b373
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 6 16:02:00 2019 -0700

    s3: smbd: profile: Remove syscall_symlink entry now syscall is no longer used.
    
    Missed as part of the previous replacement of symlink -> symlinkat.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit bdda10875ed1a21a66829206c77a1ffd998c9569
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 2 12:21:56 2019 +0200

    s3:smbd: skip write-time fetching for directories.
    
    The whole logic only applies to files.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Sep 11 00:33:26 UTC 2019 on sn-devel-184

commit 436be09cfc17bcd26ae438608749a1d47acc1954
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 9 10:42:59 2019 +0200

    smbd: Do boolean short-circuiting
    
    &= does bitwise AND, and does not do boolean short-circuiting if the
    variable is already 0. As has_other_nonposix_opens() might have its
    cost, this speeds up closing a handle.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5427f73af58252f6aabb044dac267c799ec26eb6
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 26 16:22:23 2019 +0200

    smbd: Use dbwrap_do_locked() in fd_close_posix()
    
    We don't need to make a copy of the fd array
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4204ed2b82fd8e9f6faf6e05a009d0ad7742c649
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 23 18:11:57 2019 +0200

    smbd: Use dbwrap_do_locked() in add_fd_to_close_entry()
    
    Less explicit talloc. Right now dbwrap_rbt behind the scenes does a
    dbwrap_fetch_locked(), but that will eventually change.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 92c2a723b278fb0338248bfb1fd1c1f4b90dce2b
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 23 17:47:47 2019 +0200

    dbwrap: Initialize state in dbwrap_delete()
    
    Probably not required, but looks safer and gives static checkers less
    reason to complain about potentially uninitialized variable reads
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b86df6d0591d7d8f3c08d0fe0975839ba00c342c
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Sep 5 17:25:07 2019 +0200

    lib: Remove an obsolete comment
    
    At least as of 2ac9d0afa66 ctdb does not care about db prios anymore
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a9d09d4bddb2a66e146f8e157fda4d7dd160a8a4
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 16:40:00 2019 +0200

    smbd: Fix DBG typo in find_delete_on_close_token()
    
    The routine isn't called find__delete_on_close_token. Also avoid
    casts.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2448060072e9f82fc6b0d48109d70e4e491650ca
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 9 16:34:10 2019 +0200

    smbd: Use file_id_str_buf() in close_remove_share_mode()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c88cb0a13bf2bd6ec8d144c60991643b225746d3
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 9 16:32:21 2019 +0200

    smbd: Use file_id_str_buf() in setup_poll_open()
    
    While there, remove a pointless empty line
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fd691fbc94cf8da744e70bca0165e6a8356cffc5
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 9 16:30:57 2019 +0200

    smbd: Use file_id_str_buf() in defer_open()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bf2bf5b1448be3c4c8c6492a036b46a5ccd55890
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 9 16:28:57 2019 +0200

    smbstatus: Use file_id_str_buf() in print_brl()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit feccf9bb4f50bd777b0ff64700272a3496c68576
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 6 07:31:22 2019 +0200

    smbd: Use file_id_str_buf() in set_sticky_write_time()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d9263473b07abe106f79edda8f880183881b4cff
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 6 07:29:10 2019 +0200

    smbd: Use file_id_str_buf() in share_mode_str()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit de8b93b47992dc37821aa2bd83b34ba374ff0139
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 16:26:09 2019 +0200

    smbd: Use file_id_str_buf() in brl_cleanup_disconnected()
    
    Also avoid some casts and use DBG_ instead of DEBUG()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 49d18bbf29dd00414fcd52ddeed72809ba4e9002
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 16:18:00 2019 +0200

    smbd: Use file_id_str_buf() in brl_get_locks()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7e70701ab0fd7fa03e79fad62a1903d4037e9852
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 16:15:40 2019 +0200

    vfs: Use file_id_str_buf() in xattr_tdb_setattr()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5ca021bd85db7f645b963bbeb89cf6d09ed398f4
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 16:14:28 2019 +0200

    vfs: Use file_id_str_buf() in xattr_tdb_getattr()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b09c216f5aeea3c41722b938213572012290a543
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 16:12:35 2019 +0200

    lib: Use file_id_str_buf() in file_id_string()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 049b8833ae885412db3ce2d41c9e26134b4e7e7e
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 2 19:04:25 2019 +0200

    lib: Add file_id_str_buf()
    
    file_id_string() without talloc
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ba72d8231f836e364304996467f088e1ea8ca448
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 2 19:04:42 2019 +0200

    lib: Properly #ifdef __LIB_FILE_ID_H__
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 95655fe683d499d93f3844ed72ad332ef64adb96
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 9 08:08:06 2019 +0200

    vfs: restore stat fields in vfs_stat_fsp()
    
    This ensures we preserve btime, itime and File-ID.
    
    As the Durable Handles code calls vfs_stat_fsp() in the DH disconnect function,
    previously the btime was lost and NOT stored in the cookie. With this change the
    cookie will store the correct btime (and iflags), which requires us to call
    dos_mode() in the reconnect function to ensure we pass
    vfs_default_durable_reconnect_check_stat().
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Sep 10 20:22:21 UTC 2019 on sn-devel-184

commit e00e78cfeda99bd5374eff8fb4ba84873e4e46b7
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 9 08:03:53 2019 +0200

    s3:vfs: streamline vfs_stat_fsp()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ab03394969f8a4c748aea7d0d8ed37f9ced6cc30
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 9 07:57:34 2019 +0200

    s3: replace fsp_stat() with vfs_stat_fsp()
    
    Both functions do the same, they differ just in the type of the returned result.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ac18730f10ce96a607a3a07e1360b522ebf72f38
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Aug 30 14:49:47 2019 +0200

    s3:lib: add update_stat_ex_from_saved_stat()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4e49999c97f53acc7006f1dc6b6812bb0e156db5
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Aug 30 14:48:57 2019 +0200

    vfs_catia: stat info may have been updated, make sure to return changes
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 3483b75fed8985bd2968bbf8c85985107115fba8
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Aug 30 14:48:40 2019 +0200

    s3:smbd: ensure to update the File-ID in struct smb_filename
    
    Initialize the File-ID in fsp->fsp_name->st, any subsequent metadata fetch on
    this file-handle needs this, eg QFID SMB2 Create-Context or GETINFO SMB
    requests.
    
    It would be nice if SMB_VFS_SET_DOS_ATTRIBUTE() would do this, unfortunately it
    gets a const struct smb_filename.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 84abeaa60ffced276da2b28b8add6efaa6da5ca6
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 9 11:12:08 2019 +0200

    s3:lib: round itime to NTTIME resolution in make_file_id_from_itime()
    
    The rounding is needed because when a file is created via eg an SMB2 CREATE
    request, we need to calculate the correct File-ID for the QFID Create-Context or
    for a subsequent GETINFO SMB request on the same file-handle.
    
    Any later metadata request that received the File-ID will do so by going through
    dos_mode() -> ... -> parse_dos_attribute_blob(), where the File-ID will be
    calculated from the on-disk itime which has NTTIME resolution.
    
    As long as that is the only available itime backend, I'm rounding itime inside
    make_file_id_from_itime(), not in the callers.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5403bb22e6cb39baf6dc1b91558744d41e9f6f64
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Sep 3 17:50:54 2019 +0200

    lib: add round_timespec_to_nttime()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 2ecab3c60abf9baa16a6a5e3eba0fc4720def840
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Aug 30 14:49:24 2019 +0200

    s4:torture: add a file-id related test
    
    Note I'm using the share vfs_fruit_xattr because I need a share with both a
    streams and a acl_* VFS object.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14121
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 849e3842cd9a0000fb4393b6e770945b8d4d1dc2
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Sep 10 12:37:52 2019 +0200

    s4:torture/smb2: try to fix a RESOURCE_LEAK in smb2.samba3misc.localposixlock1
    
    CID 1453656:    (RESOURCE_LEAK)
    Handle variable "fd" going out of scope leaks the handle.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Sep 10 18:56:45 UTC 2019 on sn-devel-184

commit 8270b8c0b2141e3db1cba16b72d152686efe824f
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Sep 10 10:55:15 2019 +0200

    lib/torture: protect torture_assert[_goto]() with a do { } while(0) block
    
    This hopefully fixes a lot of coverity defects like:
    
    Control flow issues  (DEADCODE)
    Execution cannot reach this statement: ";".
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c6b48490ac68f23c9f172bdfa91954a960928795
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Sep 10 12:33:34 2019 +0200

    s4:torture: always add ';' after torture_assert()
    
    The next commit will require this.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f5a51061470dda55de04555f7e4dbd1058a1f3c4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Sep 5 15:48:53 2019 +1200

    Create SECURITY.md
    
    This file location is shown under "Security -> Policy" on GitHub
    and helps ensure people with a need to report a security issue
    find us the right way.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Mon Sep  9 21:13:35 UTC 2019 on sn-devel-184

commit 2b43ce6704ecf035e6734337a2dea3458153a4b2
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 20 15:53:59 2019 +0200

    s3:selftest: add delay_inject:brl_lock_windows testing
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Mon Sep  9 15:42:45 UTC 2019 on sn-devel-184

commit c2503a5c68e967054ab84ca0d8ce693200c2e002
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Aug 19 18:22:38 2019 +0200

    vfs_delay_inject: add support for brl_[un]lock_windows()
    
    This demonstrates the two ways to handle the retry:
    - smb layer retry => plock->context.smblctx = UINT64_MAX
    - vfs backend retry => plock->context.smblctx = 0
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 66d92f37c3a643d97489a59bb6d1e75e91528c20
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 8 19:26:28 2019 +0200

    s3:locking: add brl_req_guid() and brl_req_mem_ctx() helper functions
    
    This allows the vfs backend to detect a retry and keep state between
    the retries.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 7471b0f63276e707784c98b832992ff08b1898ef
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Aug 19 16:25:59 2019 +0200

    s3:smb2_lock: handle NT_STATUS_RETRY from the VFS backend
    
    This allows the VFS backends to implement async byte
    range locking.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 7d1cd6f22e7e3d95aba04c45776057945c2a5e30
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Aug 19 15:29:32 2019 +0200

    s3:blocking: handle NT_STATUS_RETRY from the VFS backend
    
    This allows the VFS backends to implement async byte
    range locking.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 8975673e3c3f9f7dbdb7ba7562bb81a62cd24e2e
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 20:09:55 2019 +0200

    s3:blocking: make use of smbd_smb1_do_locks_try() in smbd_smb1_do_locks_send()
    
    We only need the logic to call smbd_smb1_do_locks_check() and a possible
    retry once in smbd_smb1_do_locks_try().
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 6e30a89b3f00ad55391454fbaa1272074e1962f0
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 18:18:50 2019 +0200

    s3:blocking: call smbd_smb1_do_locks_setup_timeout() also in smbd_smb1_do_locks_try()
    
    This is a noop if smbd_smb1_do_locks_setup_timeout() was called before.
    
    But it allows us to use smbd_smb1_do_locks_try() in
    smbd_smb1_do_locks_send() in a following commit.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 312327106271abafeb53e62dfb71a38bf93e2d41
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Aug 16 14:55:13 2019 +0200

    s3:blocking: fix the fsp->blocked_smb1_lock_reqs handling
    
    A new request is first checks against all pending
    requests before checking the already granted locks.
    
    Before we retried the lock array of another request
    (the first in the list), but then finished current request,
    which is wrong.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 997548a5f1a14d82f1e80cce6d9ee55e85b5107c
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Aug 19 15:21:50 2019 +0200

    s3:blocking: do the timeout calculation before calling dbwrap_watched_watch_send()
    
    This makes the next commits easier to understand.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 8da7c10a58292022ee57406db9a365de9ffaf5cf
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 18:02:57 2019 +0200

    s3:blocking: split out smbd_smb1_do_locks_setup_timeout()
    
    This function can be called multiple times, but only
    the first time will setup the endtime. And the
    endtime is relative to the request time and not
    the current time.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 5a841a43f9c4f862e2d7235429363b3066cf5850
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 18:17:47 2019 +0200

    s3:blocking: use timeval_expired(&state->endtime) to stop processing
    
    This is less racy than timeval_elapsed() > 0
    as the current time is already expired and timeout = 0
    will always work correct.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit d3bc0199697fd7d6e04479321ca644a227bc4ede
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Aug 16 16:24:34 2019 +0200

    s4:torture/raw: add multilock6 test
    
    This is similar to multilock3, but uses a read-only
    (LOCKING_ANDX_SHARED_LOCK) locks for the 2nd lock
    request.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 6d4296aca0c9a9287c0c78c8f8847a560bd2ea24
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Aug 16 15:12:01 2019 +0200

    s4:torture/raw: add multilock5 test
    
    This is similar to multilock3, but uses a read-only
    (LOCKING_ANDX_SHARED_LOCK) locks for the first lock
    request.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit d3e65ceb1ec25c7b62a7e908506126269011f30d
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Aug 16 14:49:29 2019 +0200

    s4:torture/raw: add multilock4 test
    
    This is similar to multilock3, but uses read-only
    (LOCKING_ANDX_SHARED_LOCK) locks for the blocked
    requests.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 297763c6b618c07148d788b46218a0798225bf79
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Aug 16 12:13:15 2019 +0200

    s4:torture/raw: add multilock3 test
    
    This demonstrates that unrelated lock ranges
    are not blocked by other blocked requests on the same
    fsp.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 8a7039be530adcdda9e7e7621bdcf902f5ca1721
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Aug 16 12:28:39 2019 +0200

    s4:torture/raw: improvements for multilock2
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 8decf41bbb8be2b4ac463eb6ace16a8628276ab5
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Aug 2 14:50:27 2019 +0200

    s3:smb2_lock: add retry for POSIX locks
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 7155d3a2c5d7237f00cccb1802c1341cf295864e
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Aug 19 17:38:30 2019 +0200

    s4:torture/smb2: add smb2.samba3misc.localposixlock1
    
    This demonstrates that the SMB2 code path doesn't do
    any retry for local posix locks.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 359e9992be713bbecfdb19998d69e1d3f020c5e9
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 13 16:39:41 2019 +0200

    s3:smb2_lock: make use of smbd_smb2_lock_try() in smbd_smb2_lock_send()
    
    We only need the logic to call smbd_do_locks_try() and a possible
    retry once in smbd_smb2_lock_try().
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

commit 7f77e0b4e9878f1f3515206d052adc012e26aafb
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 13 16:39:41 2019 +0200

    s3:smb2_lock: let smbd_smb2_lock_try() explicitly check for the retry condition
    
    This makes it possible to reuse _try() in the _send() function in the
    next commit.
    
    We should not retry forever on a hard error.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 39d514cdc358f175d0968f4a78f8f2f05a6c1707
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 13 16:39:41 2019 +0200

    s3:smb2_lock: error out early in smbd_smb2_lock_send()
    
    We no longer expect NT_STATUS_FILE_LOCK_CONFLICT from
    the VFS layer and assert that in a future version.
    
    This makes it easier to port the same logic to smbd_smb2_lock_try().
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit d096742da1a045357f52ccd5b28d499c30e96152
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 13 16:39:41 2019 +0200

    s3:smb2_lock: split smbd_smb2_lock_retry() into _try() and _retry()
    
    This makes it possible to reuse _try() in the _send() function in the
    next commits.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit f13d13ae9da3072862a781bc926e7a06e8384337
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 13 16:14:23 2019 +0200

    s3:smb2_lock: move from 'blocking' to 'state->blocking'
    
    This will simplify the next commits.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit ad98eec6090430ba5296a5111dde2e53b9cd217a
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Aug 19 12:33:28 2019 +0200

    s3:brlock: always return LOCK_NOT_GRANTED instead of FILE_LOCK_CONFLICT
    
    Returning NT_STATUS_FILE_LOCK_CONFLICT is a SMB1 only detail
    for delayed brlock requests, which is handled in
    smbd_smb1_do_locks*().
    
    The brlock layer should be consistent even for posix locks.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Volker Lendecke <vl at samba.org>

commit aba0ee46258f3dd910421facb742fce3318a6946
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Aug 19 12:04:43 2019 +0200

    s3:blocking: maintain state->deny_status
    
    For Windows locks we start with LOCK_NOT_GRANTED and use
    FILE_LOCK_CONFLICT if we retried after a timeout.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 2a77025a1e16d897281e5840192c93fa03328681
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Aug 19 16:30:16 2019 +0200

    s4:torture/raw: assert to get LOCK_NOT_GRANTED in torture_samba3_posixtimedlock()
    
    There should not be a different if the blocker is a posix process
    instead of another smbd.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 15765644d2590d6549f8fcc01c39c56387eed654
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 17:26:43 2019 +0200

    s3:blocking: use dynamic posix lock wait intervals
    
    We want to start with a short timeout (200ms) and
    slow down to larger timeouts up to 2s for the default
    value of "lock spin time".
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 62ec58b06c38ee82bb3147c4d325413fd3a76499
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 16:44:11 2019 +0200

    s3:blocking: Remove bug reproducer from a few commits ago
    
    The problem is fixed, now we can revert the change that made it
    easier to trigger.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit e8d719d31f885d7b6d5b317165f90ec40df169c9
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 14:21:38 2019 +0200

    s3:blocking: fix posix lock retry
    
    We should evaluate the timeout condition after the very last
    retry and not before.
    
    Otherwise we'd fail to retry when waiting for posix locks.
    The problem happens if the client provided timeout is smaller
    than the 1 sec (for testing temporary 15 secs) retry.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 8fe708acb43ea36d0cbf398713b125daba180a2d
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 13 18:34:36 2019 +0200

    s3:blocking: move from 'timeout' to 'smbd_smb1_do_locks_state->timeout'
    
    This will make it possible to just use smbd_smb1_do_locks_try()
    in a later commit.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit e79fcfaaf2ecfca6c3747f6fe4be51f332ebf10d
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 13 18:34:36 2019 +0200

    s3:blocking: split smbd_smb1_do_locks_retry() into _try() and _retry()
    
    This will make it possible to have just one caller to
    smbd_do_locks_try() later and use smbd_smb1_do_locks_try()
    from within smbd_smb1_do_locks_send().
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

commit 2ec9e93a7aac2706b4a5931495d56a7b64f8d894
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 11:09:47 2019 +0200

    s3:blocking: demonstrate the posix lock retry fails
    
    This is just a temporary commit that shows the bug and its
    fix. It will be reverted once the problem is fixed.
    
    The posix lock retry fails if the client specified timeout
    is smaller than the hardcoded 1 second retry.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit ac28eec3e4af710feab3be3d4b25bfbe38294431
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 14:31:54 2019 +0200

    s3:torture: convert LOCK9 into LOCK9A and LOCK9B
    
    LOCK9A is the original test (with a timeout of -1)
    and LOCK9B is the same but with timeout of 10 seconds.
    
    LOCK9B is needed to demonstrate a server bug in the next
    commits.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit e18c8ced8e7a872deb118191595425ef6b826bfa
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 15 16:10:58 2019 +0200

    s3:torture: fix the timeout alarm handling on LOCK9
    
    smbXcli_conn_disconnect(alarm_cli->conn, NT_STATUS_OK)
    means existing requests are not finished with an error,
    but instead just keep dangling arround.
    
    Pass NT_STATUS_LOCAL_DISCONNECT in order to fail the
    cli_lock32() call after getting SIGALARM.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 3b788d97f9995e24e4005567f90a925957fb1e00
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 13 19:19:07 2019 +0200

    s3:blocking: remove unused timeval_brl_min()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit bd8884e5722cbbb7783fb4ae53e4f35b31031b01
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Aug 9 00:47:39 2019 +0200

    s3:locking: add share_mode_wakeup_waiters() helper function
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 0e5613e39d6c6bb892fed939c63b4f14b878803b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Sep 5 08:43:32 2019 +0200

    s3:locking: add/split out byte_range_{valid,overlap}() helper functions
    
    They implement the logic from [MS-FSA].
    
    The following commits will use these functions in other locations.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 8b565de1acb0fda121cb0bd4cff42d66ee027529
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 4 12:47:07 2019 +0200

    s3:smb2_lock: call change_to_user_by_fsp() when dbwrap_watched_watch* finishes
    
    This is not strictly required as fd-based calls are used,
    but it's more consistent to call SMB_VFS_BRL_LOCK_WINDOWS()
    in the same environment on retry.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 28ac2cbaf92a8619f0380f024c5a220d9fdc4622
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 4 12:50:06 2019 +0200

    s3:blocking: call change_to_user_by_fsp() when dbwrap_watched_watch* finishes
    
    This is not strictly required as fd-based calls are used,
    but it's more consistent to call SMB_VFS_BRL_LOCK_WINDOWS()
    in the same environment on retry.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14113
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit bebee47e6386476e9948089484f89d213fcc2660
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Aug 16 12:50:21 2019 +0200

    s4:torture: make rpc.handles.random-assoc test more robust
    
    We've seen failures like this:
    
      RPC-HANDLE-RANDOM-ASSOC
      connect samr pipe1
      pipe1 uses assoc_group_id[0x00000001]
      connect samr pipe2 with assoc_group_id[0xFFFFFFFF]- should fail
      Failed to bind to uuid 12345778-1234-abcd-ef00-0123456789ac for
        ncacn_np:localdc[\pipe\samr,bigendian,assoc_group_id=0xffffffff,
        abstract_syntax=12345778-1234-abcd-ef00-0123456789ac/0x00000001] NT_STATUS_UNSUCCESSFUL
      connect samr pipe3 with assoc_group_id[0x00000000]- should fail
      UNEXPECTED(failure): samba4.rpc.handles on ncacn_np with bigendian.random-assoc(ad_dc_default)
      REASON: Exception: Exception: ../../source4/torture/rpc/handles.c:546:
        status was NT_STATUS_OK, expected NT_STATUS_UNSUCCESSFUL: opening samr pipe3
    
    Prevent that it wraps to 0x00000000
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 560c3abf453597794e5ddf3782bc05d8ba4e5299
Author: David Disseldorp <ddiss at samba.org>
Date:   Sun Sep 8 15:08:54 2019 +0200

    s3:smbcontrol: avoid printing NULL help strings
    
    Some smbcontrol commands leave the .help pointer NULL, resulting in the
    following usage text:
            disconnect-dc                 (null)
            notify-cleanup                (null)
    	...
            msg-cleanup                   (null)
    
    Improve this by printing an empty string instead.
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Mon Sep  9 10:32:53 UTC 2019 on sn-devel-184

commit 3bd68261eca398895c419284db6515fd6f393f0f
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Wed Jul 31 12:13:52 2019 +1000

    ctdb-eventscripts: Remove non-posix -v option to mkdir
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Fri Sep  6 11:11:02 UTC 2019 on sn-devel-184

commit 4a7fc97daff69b8cba9c4e2da6a8e1399d6b1107
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Wed Jul 31 12:12:14 2019 +1000

    ctdb-eventscripts: Fix the regression in 01.reclock.script
    
    Commit ea7708d8c7fa674111ccea58b3cd0757765c702a simplified
    01.reclock.script and removed include of functions file which is
    required for setting CTDB_HELPER_BINDIR and for die() function.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 1006f7abe8980d2c01c181db93225353ce494b3a
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Sep 5 11:23:22 2019 +1200

    docs: Deprecate "lanman auth = yes"
    
    This feature is only available for SMB1 and we need to warn users that this
    is going away soon, and allow the removal in a future release under our rules
    for parameter deprecation.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Sep  5 04:04:18 UTC 2019 on sn-devel-184

commit 8d0d99a4d78ba408bb45e2d693049025e60e277a
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Sep 5 11:19:10 2019 +1200

    docs: Deprecate "encrypt passwords = no"
    
    This feature is only available for SMB1 and we need to warn users that this
    is going away soon, and allow the removal in a future release under our rules
    for parameter deprecation.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit 1e2d209494769cb23f10d3c8f8f294acdc9147f6
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Sep 4 11:32:58 2019 +0200

    torture: Fix the FreeBSD clang build
    
    clang complained that "full_filename==NULL" is always false, because
    it's a normal stack variable.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Sep  4 18:20:22 UTC 2019 on sn-devel-184

commit e8ac8a357aec218807f1b750c004bc2f88aa4b08
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 10:38:35 2019 +0200

    samr: Fix CID 1453463: Null pointer dereferences (NULL_RETURNS)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3a0047eaf18a1dffdedfd6625aeac9f6d7255045
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 10:35:33 2019 +0200

    dsdb: Fix CID 1453464: Error handling issues (CHECKED_RETURN)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 09946c558fade9ea64f0ef2357bf865c6e1ec441
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 3 10:29:53 2019 +0200

    dsdb: Fix CID 1453465: Null pointer dereferences (NULL_RETURNS)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ad4ef1657e9b2a088a3bfadcce196cfcceead1dc
Author: Evgeny Sinelnikov <sin at altlinux.org>
Date:   Wed Jul 31 23:17:20 2019 +0400

    s3:ldap: Fix join with don't exists machine account
    
    Add check for requested replies of existing machine object during join
    machine to domain. This solves regression fail during join with error:
    "None of the information to be translated has been translated."
    
    https://bugzilla.samba.org/show_bug.cgi?id=14007
    
    Reviewed-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Wed Sep  4 17:02:37 UTC 2019 on sn-devel-184

commit 9173ae5f7f02d2f1675d505ee3da7e62cceeafd0
Author: David Disseldorp <ddiss at samba.org>
Date:   Tue Sep 3 15:26:19 2019 +0200

    s3/lib/ctdbd_conn: assert hdr following read/recv
    
    ctdb_pkt_recv_recv() and ctdb_read_packet() give us a non-null hdr on
    success, so drop the error path check in favour of an assert.
    
    This fixes a regression in 3913b9a4088b83d6ed7f94d136a26ecfa7e16b35,
    where tevent_req_error() may be skipped in the ctdbd_parse_done()
    ctdb_pkt_recv_recv() error path.
    
    Reported-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Wed Sep  4 14:20:16 UTC 2019 on sn-devel-184

commit 123267138e993c6a87990c0022e89f4970c0ac12
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 4 10:49:32 2019 +0200

    tevent: Release tevent 0.10.1
    
    * Update waf to version 2.0.17 in order to
      fix the build with python 3.8.
    * Other minor build fixes.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Wed Sep  4 11:47:04 UTC 2019 on sn-devel-184

commit c5ea3d045af491549346890929ac3dbbce952aeb
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:45:13 2019 -0700

    s3: VFS: Complete the replacement of SMB_VFS_SYMLINK() -> SMB_VFS_SYMLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Sep  3 22:32:30 UTC 2019 on sn-devel-184

commit ea5a02e811060d674cb8603a30857161c00738df
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:39:53 2019 -0700

    s3: VFS: vfs_time_audit. Remove symlink_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the symlink_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 2fa1cd37c20ab9415d65659d0dd6e4c95e0ecca2
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:38:28 2019 -0700

    s3: VFS: vfs_full_audit. Remove symlink_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the symlink_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit a676e494cde2d533718836c4d443cfe0dd9f5aec
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:36:58 2019 -0700

    s3: VFS: vfs_unityed_media. Remove symlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 8ef64494c6d779eac9a4441661ee56586d0d5764
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:36:10 2019 -0700

    s3: VFS: vfs_syncops. Remove symlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit d492f4d1031a046989d5e141a6f05ff76de6f151
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:35:25 2019 -0700

    s3: VFS: vfs_snapper. Remove symlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit a521377e200d2813eab661be22f520e1cf7cb12b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:34:37 2019 -0700

    s3: VFS: vfs_shadow_copy2. Remove symlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 9b3d3904c65b87746dda37dc73e2c30eb5ce30dd
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:33:22 2019 -0700

    s3: VFS: vfs_media_harmony. Remove symlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit cb3b0ee853af916a18848b6c666ce55f1f1b6ec7
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:32:22 2019 -0700

    s3: VFS: vfs_glusterfs. Remove symlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 33c00a61d83a938463b801476d714d4eef576079
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:31:02 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Remove symlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 1ee61e214a5b886af04209563348104cfe5a08a9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:30:11 2019 -0700

    s3: VFS: vfs_ceph. Remove symlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit d970556b682a5cb807b50ca83bb4ff1c36d2d423
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:29:27 2019 -0700

    s3: VFS: vfs_cap. Remove symlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit daf78b0271aa1a4a3e21c077a9126aa3b6b7f859
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:16:41 2019 -0700

    s3: smbd: Change create_msdfs_link() to call SMB_VFS_SYMLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 538f78f07b6788f82dc93e17b5e8358a674d48a9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:13:21 2019 -0700

    s3: smbd: Change smb_set_file_unix_link() to call SMB_VFS_SYMLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 1354f2f5210879466c706b8b2fb902bcef32da1f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:10:47 2019 -0700

    s3: torture: Change cmd_symlink to call SMB_VFS_SYMLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 8c851da40f0482efc59b2d0e7f44e9d2b98d3d5c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:02:53 2019 -0700

    s3: VFS: vfs_unityed_media. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit f6d63ff6446cd5423a61cb32204d4dc96a11ec34
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:01:33 2019 -0700

    s3: VFS: vfs_time_audit. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 4f5de7061eb53a5115223ca26279b320a15591c8
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 14:00:12 2019 -0700

    s3: VFS: vfs_syncops. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 787487ae3ee7adcd68931d5834dbfc5e3ba1dce3
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 13:54:52 2019 -0700

    s3: VFS: vfs_snapper. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit e033047559e77706401ef7c21f21187502d528b0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 13:53:23 2019 -0700

    s3: VFS: vfs_shadow_copy2. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 2d50dfa52c8bac7f97eb95fef0a266e1fe9b1460
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 13:51:50 2019 -0700

    s3: VFS: vfs_media_harmony. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit ff3af0fccc8013862d75220bd60aa08ffe913d2a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 13:49:57 2019 -0700

    s3: VFS: vfs_glusterfs. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 29b691987909aa31e30b73c6dc352ea4df9b646f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 13:48:03 2019 -0700

    s3: VFS: vfs_full_audit. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 5665a3845a74d72d374ddfc3bea37b9fc4586b15
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 13:16:01 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 4903c9fcfe6eff17134f8bdeeaadb499eca271c1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 13:13:51 2019 -0700

    s3: VFS: vfs_ceph. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit f935989f2d4a8ffe9df4fbdfbd9618eb89ab8ef2
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 12:54:23 2019 -0700

    s3: VFS: vfs_cap. Implement symlinkat().
    
    Currently identical to symlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 42414b5bfc8f9e36d684b45997a5e9170b633220
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 30 12:01:13 2019 -0700

    s3: VFS: Add SMB_VFS_SYMLINKAT().
    
    Currently identical to SMB_VFS_SYMLINK().
    
    Next, add to all VFS modules that implement
    symlink and eventually remove symlink.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3355601fe8541994cc41f5ed800aab9b6a2294f4
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Aug 26 11:22:35 2019 -0700

    s3/4: libsmbclient test. Test using smbc_telldir/smbc_lseekdir with smbc_readdir/smbc_readdirplus/smbc_getdents.
    
    Ensure that for file access you can mix any of these
    three access methods for directory entries and the
    returned names/structs stay in sync across telldir/seekdir
    changes.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Sep  3 17:31:29 UTC 2019 on sn-devel-184

commit 0d9b1645499ce12a79a137d3482434aa5d2eb47c
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Aug 26 10:18:28 2019 -0700

    s3: libsmbclient: Fix smbc_lseekdir() to work with smbc_readdirplus().
    
    If returning files the dir_list and the dirplus_list have exactly the same
    entries, we just need to keep the next pointers in sync on seek.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 754cec7756b2ddb1cfcc3984265f01cb366beb76
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Aug 26 10:07:32 2019 -0700

    s3: libsmbclient: Ensure SMBC_getdents_ctx() also updates the readdirplus pointers.
    
    If we are returning file entries, we
    have a duplicate list in dirplus.
    
    Update dirplus_next also so readdir and
    readdirplus are kept in sync.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3d82b7d11cd7b78adc6b3642e64e3a8f251de869
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Aug 26 10:02:47 2019 -0700

    s3: libsmbclient: Ensure SMBC_readdirplus_ctx() also updates the readdir pointers.
    
    If we are returning file entries, we
    have a duplicate list in dir_list.
    
    Update dir_next also so readdir and
    readdirplus are kept in sync.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 4bca8e097f5a909c628daa4dbfa932ddc1725ebc
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Aug 26 09:54:06 2019 -0700

    s3: libsmbclient: Ensure SMBC_readdir_ctx() also updates the readdirplus pointers.
    
    If we are returning file entries, we
    have a duplicate list in dirplus.
    
    Update dirplus_next also so readdir and
    readdirplus are kept in sync.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14094
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit efd4832c2cfc4092bafb93dd4caf32d04488919f
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Jul 11 17:02:15 2019 +0200

    CVE-2019-10197: smbd: split change_to_user_impersonate() out of change_to_user_internal()
    
    This makes sure we always call chdir_current_service() even
    when we still impersonated the user. Which is important
    in order to run the SMB* request within the correct working directory
    and only if the user has permissions to enter that directory.
    
    It makes sure we always update conn->lastused_count
    in chdir_current_service() for each request.
    
    Note that vfs_ChDir() (called from chdir_current_service())
    maintains its own cache and avoids calling SMB_VFS_CHDIR()
    if possible.
    
    It means we still avoid syscalls if we get a multiple requests
    for the same session/tcon tuple.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(master): Tue Sep  3 09:27:22 UTC 2019 on sn-devel-184

commit 9ab5a51a6e770c8bd95ceca892808cf2cf670852
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jul 16 15:40:38 2019 +0200

    CVE-2019-10197: test_smbclient_s3.sh: add regression test for the no permission on share root problem
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

commit d7ed819d9f83a89f436b13437a71c85335cdb5df
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jul 30 17:16:59 2019 +0200

    CVE-2019-10197: selftest: make fsrvp_share its own independent subdirectory
    
    The next patch will otherwise break the fsrvp related tests.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

commit 509113fcffdd0f371f8b32efc900d2102ef0cef7
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jun 18 14:04:08 2019 +0200

    CVE-2019-10197: smbd: make sure we reset current_user.{need,done}_chdir in become_root()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

commit 6fae81312fad5caf948f0f0f48b84fd3f59dc944
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Jul 11 17:01:29 2019 +0200

    CVE-2019-10197: smbd: make sure that change_to_user_internal() always resets current_user.done_chdir
    
    We should not leave current_user.done_chdir as true if we didn't call
    chdir_current_service() with success.
    
    This caused problems in when calling vfs_ChDir() in pop_conn_ctx() when
    chdir_current_service() worked once on one share but later failed on another
    share.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e48c11896904fd063619a95d3fa7ceccbf2beb56
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jul 12 12:10:35 2019 -0700

    CVE-2019-10197: smbd: separate out impersonation debug info into a new function.
    
    Will be called on elsewhere on successful impersonation.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14035
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 16c3a00d2eb8471dfa4cf9ace003578331d2e1e0
Author: Björn Baumbach <bb at sernet.de>
Date:   Thu Jun 13 17:20:02 2019 +0200

    build: remove unneeded libceph-common dependency
    
    librados and libcephfs are both dependent on ceph-common, but
    ctdb_mutex_ceph_rados_helper and vfs_ceph needn't be explicitly linked
    against it.
    
    Signed-off-by: Björn Baumbach <bb at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Mon Sep  2 03:44:24 UTC 2019 on sn-devel-184

commit dfa4dcf386febdf1b77ba963f11bcc2a44f8a738
Author: David Disseldorp <ddiss at samba.org>
Date:   Tue Jun 18 14:35:02 2019 +0200

    build: drop --with-libcephfs=<path> support
    
    --with-libcephfs=<path> provides a mechanism for explicitly specifying
    header and library paths for Ceph. This adds unnecessary complexity and
    can be achieved using generic compiler environment variables (e.g.
    GCC LIBRARY_PATH and C_INCLUDE_PATH), so drop --with-libcephfs support.
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b76bf7afd07924e65cccbee7614b462312d4437c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Aug 26 14:36:49 2019 +1200

    build: Raise minimum python version to 3.5.0 for Samba 4.12
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Mon Sep  2 01:14:05 UTC 2019 on sn-devel-184

commit 29729818823161c08b09bcc8e43c3942a503b129
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 30 22:12:03 2019 +1200

    dsdb: Remove unused local_password module
    
    This was an idea about how Samba might have worked if passwords were
    not safe to be stored in a remote DB (get some kind of LDAP backend).
    
    Nothing ever used this, but it was a nice idea.  But git master is not
    the place to preserve history, even interesting ideas like splitting
    passwords from the non-password data (possible because, in the same way
    we are allowed to encrypt them, we do not allow a search on password
    values).
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit 72201055f53a9a59c90fa6fe94cbc7e968a2b35a
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 30 22:05:37 2019 +1200

    dsdb: Remove unused simple_dn module
    
    This became unused with 2b0fc74a0916a6ab0d5ac007cc5e100d4682b2ea that
    removed the last of the support for the LDAP Backend
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit af6799bf4f1509af19c74c300a0d4a889a69cbfe
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 30 20:38:01 2019 +1200

    util: Remove unused NS_GUID_string() and NS_GUID_from_string()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14063
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit cf3977585d095cac916b268629087570e0538130
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 30 20:44:57 2019 +1200

    dsdb: Remove unused entryuuid and nsuniqueid modules
    
    These were for the now removed OpenLDAP backend.  Any future work in this area will
    not involve this kind of translation, it will be done much more cleanly.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit f2e37b84da64172a07bde33a81b6cd88501967da
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:44:54 2019 +0200

    Spelling fixes s/ querys / queries /
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sun Sep  1 23:38:14 UTC 2019 on sn-devel-184

commit 4012811a6d557644b207051ff73719305f83dcef
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:43:03 2019 +0200

    Spelling fixes s/varaible/variable/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f61d72b303876dda8588ce2b27b22eb76bd09d07
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:42:54 2019 +0200

    Spelling fixes s/hightest/highest/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a24de32556dddf6994c7c5c68d7794999a7fd4cb
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:42:36 2019 +0200

    Spelling fixes s/permited/permitted/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f8f4ed7529e1ca8c9dd9994c7ba342f15994afbd
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:42:19 2019 +0200

    Spelling fixes s/accomodations/accommodations/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 2915188c953e050e12081a4c05eada1fc081feda
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:41:59 2019 +0200

    Spelling fixes s/intergration/integration/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 549a4a82e0b918809e718ea966961f3332b6d5c5
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:39:39 2019 +0200

    Spelling fixes s/preceeding/preceding/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit d605860cf40e8695a54436d768dacf345cd3552e
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:39:20 2019 +0200

    Spelling fixes s/valuie/value/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 105bb06318eecd416c8e78b5cbcd3936aa6ec8c8
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:39:12 2019 +0200

    Spelling fixes s/withing/within/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4b207f83653589d5b5b9b041e7202e47b7815ac5
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:38:52 2019 +0200

    Spelling fixes s/suceeded/succeeded/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 8b9319c455e5b90130ee05e67d5a902873f426c6
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:37:54 2019 +0200

    Spelling fixes s/whitch/which/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit b688926cd9e51a27b91ad5f9efe92af837e5e65c
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:37:10 2019 +0200

    Spelling fixes s/touble/trouble/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit d6525485df9c1e06206df2239d3069eb180c6768
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:37:02 2019 +0200

    Spelling fixes s/implentation/implementation/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 1a750eb1f7f2d5246e451d2162d8c52b6d4d5ad1
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:36:54 2019 +0200

    Spelling fixes s/staticly/statically/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 7c2ee8feab5c2e02a33d4ea4fcd7b861d6a1dbb3
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:36:47 2019 +0200

    Spelling fixes s/ingnored/ignored/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 284eaa5728b690df0dcb068fc6b1e2c401d20c57
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:36:40 2019 +0200

    Spelling fixes s/compatability/compatibility/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 5a400df01d741bddc84f03d0ad1bb241f413ac4a
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:34:49 2019 +0200

    Spelling fixes s/priveliges/privileges/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit eaa44d819d9ae6efcd5d1bc83880d101242e1c0b
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:34:38 2019 +0200

    Spelling fixes s/retreiving/retrieving/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e7407c02e7724469e856629f02df2fb2bbe5579f
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:33:05 2019 +0200

    Spelling fixes s/concatonated/concatenated/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 995f0736c668513476ce0bdc1fd073c701dfe7d0
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:33:04 2019 +0200

    Spelling fixes s/rebuilded/rebuilt/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 08cc61f9b68ff12d77b698103d2ce99f3d84f6fa
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:33:04 2019 +0200

    Spelling fixes s/accidentially/accidentally/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 875962ed36688ea7d0749f941fcda6087c0e891a
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:33:04 2019 +0200

    Spelling fixes s/substitue/substitute/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 244c05da2062fe27d4e39ccb1ae80b54c2c3d694
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:32:23 2019 +0200

    Spelling fixes s/simliar/similar/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4973eb37602be39d9cb0a8a3842bec9c548f242d
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:32:05 2019 +0200

    Spelling fixes s/explizitly/explicitly/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 802443927ace02ae48a55247dd4de9905811cacd
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:31:41 2019 +0200

    Spelling fixes s/filesytems/filesystems/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 0b8f428bf1f1241b7b60660b74060d73bea25475
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:31:25 2019 +0200

    Spelling fixes s/directores/directories/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 7cb0ca4171889d1fa4ffd99528b51cc9820f4dd9
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:20:11 2019 +0200

    Spelling fixes s/ dont / don't /
    
    Excluding examples/tridge/smb.conf
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 619e8f46d8a92d2453e1f021a2a330ebbefc7025
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:19:42 2019 +0200

    Spelling fixes s/ upto / up to /
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 736bb924f7e70564df0b94db1deaf9e26f638109
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:19:03 2019 +0200

    Spelling fixes s/ ot / to /
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 271b04aaae29be4a52d1c84f53190bec493f05a0
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:05:05 2019 +0200

    Spelling fixes s/noone/no one/
    
    Skipping source4/torture/winbind/struct_based.c
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit d9b50ce7df182e3ba8692b6d3edcd1b6489060c0
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:02:13 2019 +0200

    Spelling fixes s/recieved/received/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e6654b5f43f26a998a0a11893ed2cec842f26d16
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 22:01:54 2019 +0200

    Spelling fixes s/explicite /explicit /
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit c5e97f1aa15b11aa6becf168e3750b547e6eccfc
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:58:50 2019 +0200

    Spelling fixes s/wont /won't /
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 0459a6db3319948a59c52669193b618f812d8bf0
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:58:27 2019 +0200

    Spelling fixes s/didnt'/didn't/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a03bafbcd5b835aa248c01b4150750f8e50f43a9
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:54:14 2019 +0200

    Spelling fixes s/overriden/overridden/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 06e0f89345e09d2fb4bf0f028711e448bc181346
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:53:43 2019 +0200

    Spelling fixes s/optinally/optionally/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 49a6e109aae9f15069a0f59d9f75b5367f4192e0
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:53:35 2019 +0200

    Spelling fixes s/componet/component/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 5d0c26fc6b527ce6c385c9f3a097e07378f1c559
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:53:27 2019 +0200

    Spelling fixes s/nonexistant/nonexistent/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit dbd6bef29e6bc505d3e95a100759aca40bdfe1e5
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:53:18 2019 +0200

    Spelling fixes s/avaiable/available/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit de813400f3c01e21ad5266dcff905b6c4f020b76
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:52:56 2019 +0200

    Spelling fixes s/DISLPAY/DISPLAY/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit cdc8c05ba51b6809c22b894af66af3c3c3fa43b5
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:52:33 2019 +0200

    Spelling fixes s/serivce/service/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit fbf94dba59696188c35ba16d9dc3b3839b1ebd6e
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:52:21 2019 +0200

    Spelling fixes s/BUITIN/BUILTIN/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 54b6fa863128830fa5c87cd574976d941fa4358b
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:52:10 2019 +0200

    Spelling fixes s/emtpy/empty/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f2b30a3f6a929a56403ef95f0b0feb1d18a11c17
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:51:56 2019 +0200

    Spelling fixes s/Therefor /Therefore /
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 8196b331f30851071fdec7a7ff47bff9697dd6a7
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:50:56 2019 +0200

    Spelling fixes s/exisiting/existing/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a59e0ec8955e51bb6d9ca62d2636388e417c1d45
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:50:45 2019 +0200

    Spelling fixes s/hierachy/hierarchy/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a12d843b2c081969ed56f76a7b0f30acf9e4aa38
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:50:35 2019 +0200

    Spelling fixes s/setted/set/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e8f8d2d214b6a248df580cd1930a429a3fb7fa38
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:50:24 2019 +0200

    Spelling fixes s/encrpted/encrypted/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit b694268ee1c6059850627b883d40e4362cc64ae6
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:34:10 2019 +0200

    Spelling fixes s/succedded/succeeded/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e19c3e0387cf9a2cde973c1df9daf7a1ba426921
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:33:56 2019 +0200

    Spelling fixes s/Mirgate/Migrate/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit eff558035b29784d4ccc1c30f8b62b675220e9d0
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:32:30 2019 +0200

    Spelling fixes s/exising/existing/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4449f5d1b8d42ea862f22a80ee7156e04cb95a00
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:31:07 2019 +0200

    Spelling fixes s/convertion/conversion/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 6b47c12549c71485d775a6d1b5a631ce79c8f278
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:30:48 2019 +0200

    Spelling fixes s/autentication/authentication/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 8e727867217f797bec2c5f6618804abf0bcf4f2d
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:30:07 2019 +0200

    Spelling fixes s/integrety/integrity/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 46687a507e8236b75fa2ebfd8389241e36e73a8c
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:29:58 2019 +0200

    Spelling fixes s/Unsuported/Unsupported/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 7d1dc9716372b00794f3dcfe518f764636d9629a
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:29:47 2019 +0200

    Spelling fixes s/sepcific/specific/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit fbecbe4d9b102d7cf28d61230a0bfbef3317c8f1
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:29:40 2019 +0200

    Spelling fixes s/negotatie/negotiate/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 781eaea07f1f073a324e44030f779df22679fb61
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:29:03 2019 +0200

    Spelling fixes s/advertisment/advertisement/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 2bb4515aff3751d38fb706c6024e3bf1c044da48
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:28:41 2019 +0200

    Spelling fixes s/tempates/templates/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a1d839f7cea8a3960969df36e772276b01a1e3ac
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:11:18 2019 +0200

    Spelling fixes s/depencies/dependencies/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 5fc2c7ddb815e753ce57dc050ccf8fad9151063d
Author: Mathieu Parent <math.parent at gmail.com>
Date:   Thu Aug 29 21:34:23 2019 +0200

    Spelling fixes s/containter/container/
    
    Signed-off-by: Mathieu Parent <math.parent at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 2b0fc74a0916a6ab0d5ac007cc5e100d4682b2ea
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Mar 12 11:46:42 2019 +1300

    dsdb: Remove OpenLDAP backend complexity from samba_dsdb module
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Nadezhda Ivanova <nivanova at symas.com>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Aug 30 09:50:25 UTC 2019 on sn-devel-184

commit 3da41b51b00da97cfe63616d26555441f744ebf3
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Mar 12 11:46:28 2019 +1300

    dsdb: Remove OpenLDAP backend complexity from partitions module
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Nadezhda Ivanova <nivanova at symas.com>

commit 6d1fe2841105b7ba3a1384ef6baef399f30800a6
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Mar 12 11:43:15 2019 +1300

    dsdb: Remove LDAP backend specific modules from extended_dn_out
    
    This simplifies the code considerably.  A real attempt at an LDAP backend would need to implement this
    module in a similar way to LDB.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Nadezhda Ivanova <nivanova at symas.com>

commit a4f0a6519cde558fdedb08fbb4742dbf57ee4283
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Mar 12 10:52:24 2019 +1300

    samba-tool domain provision: Remove experimental OpenLDAP support
    
    This feature has long been obsolete, remaining only in the hope
    that it might be revived in the future.
    
    Specifically, in 2011 the S4 OpenLDAP backend HOWTO was removed:
    
     commit 1d46325af8541ea467c79cd86e65f93ce6a14ff4
     Author: Andrew Bartlett <abartlet at samba.org>
     Date:   Wed Apr 27 22:42:29 2011 +1000
    
         Remove outdated S4 OpenLDAP backend HOWTO.
    
    There is a project to revive this, hosted here:
    
    https://github.com/Symas/samba
    and
    https://github.com/Symas/samba_overlays
    
    However discussions at SambaXP with Nadezhda Ivanova
    indicate a new approach with slapd being started by Samba
    and taught to read native Samba ldb files is more likely
    in the short term.
    
    This has the advantage that Samba's provision and offline
    tooling would not need to change, with the solution looking
    more like how BIND9_DLZ has access to the Samba DB.
    
    If any of this is required then reverting these patches will be
    the least of the difficulties in bringing this to production.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Nadezhda Ivanova <nivanova at symas.com>

commit 4a2d3d8fd6318858260c3bc47443a6337da829ce
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Mar 12 11:49:01 2019 +1300

    sefltest: Remove tests for obsolete OpenLDAP backend
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Nadezhda Ivanova <nivanova at symas.com>

commit 5f70f972a5871d473f66d7c50ebb3181652b3cae
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Mar 12 11:41:12 2019 +1300

    selftest: Remove obsolete LDAP backend hooks from selftest.pl et al
    
    This removes some quite complex logic that has not been used since the LDAP
    backend project was shelved prior to 2011.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Nadezhda Ivanova <nivanova at symas.com>

commit b5b6b74b82631bf7eb09f955b7afb9c71d599522
Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
Date:   Fri Mar 1 11:04:05 2019 +1300

    paged results: tests without server_sort ctrl
    
    On windows, adding or modifying a record during a paged results search
    behaves differently depending on whether or not you supply server_sort
    control.  This patch adds tests and documentation.
    
    Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Aug 30 08:26:21 UTC 2019 on sn-devel-184

commit 961f07fb76287359e6a10263b1ea8035367e5375
Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
Date:   Tue Aug 13 18:14:12 2019 +1200

    rpc samr: EnumDomainUsers perf improvement
    
    EnumDomainUsers currently takes too long, significantly slowing down
    calls to winbind's getpwent which is a core unix API. The time is taken
    up by a GUID lookup for every record in the cached result. The advantages
    of this approach are:
    1. It meets the specified requirement that if a record yet to be returned
    	by a search in progress (with a resume handle) is deleted or
    	modified, the future returned results correctly reflect the
    	new changes.
    2. Memory footprint for a search in progress is only 16 bytes per record.
    
    But, those benefits are not worth the significant performance hit
    of the lookups, so this patch changes the function to run the search
    and cache the RIDs and names of all records matching the search when
    the request is made. This makes the memory footprint around 200 bytes
    per record or up to 2MB per concurrent search for a 100k user database.
    The speedup achieved by this change is around 50%, and in tandem with
    some winbindd improvements as part of the same task has achieved around
    15x speedup for getpwent.
    
    The lost specification compliance is unlikely to cause a problem for any
    known usage of this RPC call.
    
    Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3aea2c0f1f498fdb515cbd1d04b1ba3ce7f4cc3b
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Mar 2 05:47:20 2019 +0100

    replace/setxattr: correctly use our flags on Darwin
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Thu Aug 29 17:10:32 UTC 2019 on sn-devel-184

commit 56e0ffa11319eebbe0d8b07502aa3ec8971435d0
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Mar 2 05:39:54 2019 +0100

    xattr/setxattr: fix flag support on AIX
    
    AIX requires the flags to be 0, we need to do those checks manually.
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b8f4be98f5d22eb034a953ebefab88752bf4a099
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Mar 2 05:01:28 2019 +0100

    replace/setxattr: set reasonable and unified errno value in case the EA value was too big
    
    FreeBSD and AIX already set errno to ENAMETOOLONG, this is what we should map
    other platforms also to to finally map to the correct NT error code also.
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0be320393b85003f65d74e4e6a1b867a8d21eb1c
Author: Noel Power <noel.power at suse.com>
Date:   Fri Aug 9 16:06:20 2019 +0100

    s3/libsmb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/libsmb/cliquota.c:340:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/libsmb/cliquota.c:357:4: warning: Value stored to 'status' is never read <--[clang]
                            status = NT_STATUS_OK;
                            ^        ~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Wed Aug 28 03:06:42 UTC 2019 on sn-devel-184

commit 0c91634ebe4065bfb66c5cf575659aa1150fc2fb
Author: Noel Power <noel.power at suse.com>
Date:   Fri Aug 9 16:02:18 2019 +0100

    s3/libsmb: clang: Fix 'Value stored to 'status' is never read'
    
    Fixes:
    
    source3/libsmb/cliquota.c:340:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    /home/samba/samba/source3/libsmb/cliquota.c:357:4: warning: Value stored to 'status' is never read <--[clang]
                            status = NT_STATUS_OK;
                            ^        ~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f8b5c47ad51f8ee727122964099b1b3dc36028d9
Author: Noel Power <noel.power at suse.com>
Date:   Fri Aug 9 16:00:35 2019 +0100

    s3/libsmb: clang: Fix 'warning: Value stored to 'status' is never read'
    
    Fixes:
    
    source3/libsmb/namequery.c:2938:2: warning: Value stored to 'status' is never read <--[clang]
            status = NT_STATUS_OK;
            ^        ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 32aa8f9195ce83073a04d24583de41ddbf4836c2
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 15:24:16 2019 +0100

    s3/libsmb: clang: Fix 2nd function call argument is an uninitialized value
    
    source3/libsmb/namequery.c:2719:11: warning: 2nd function call argument is an uninitialized value <--[clang]
                                            if (!convert_ss2service(return_iplist,
                                                 ^
    source3/libsmb/namequery.c:2733:10: warning: 2nd function call argument is an uninitialized value <--[clang]
                                    if (!convert_ss2service(return_iplist,
                                         ^
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 6ef4736c3f642d5b1625f6edb8b3cfdc6e7e3736
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 15:18:03 2019 +0100

    s3/libsmb: clang: Fix Value set during its initialization is never read
    
    Fixes:
    source3/libsmb/namequery.c:2584:11: warning: Value stored to 'status' during its initialization is never read  <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 2abe785264b105fc3a5b2ce6bd3df7d24fbdf360
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 15:15:11 2019 +0100

    s3/libsmb: clang: Fix: The right operand of '<' is a garbage value
    
    Fixes:
    
    source3/libsmb/namequery.c:977:12: warning: The right operand of '<' is a garbage value <--[clang]
            for (i=0;i<count;i++) {
                      ^~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 52d20087f620704549f5a5cdcbec79cb08a36290
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 15:06:28 2019 +0100

    s3/libads: clang: Fix Value stored to 'canon_princ' is never read
    
    Fixes:
    
    source3/libads/kerberos.c:192:2: warning: Value stored to 'canon_princ' is never read <--[clang]
            canon_princ = me;
            ^             ~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 61c5b891a14e47c784e0aae272630d78bf9c7831
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 14:59:55 2019 +0100

    s3/libsmb: clang: Fix value stored to 'offset' is never read
    
    Fixes:
    
    source3/libsmb/nmblib.c:479:2: warning: Value stored to 'offset' is never read <--[clang]
            offset += 10+rec->rdlength;
            ^         ~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 2575e4066bf84d7a56f0b7126841f4ea5cc027fd
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 14:53:01 2019 +0100

    s3/libsmb: clang: Fix 'warning: Assigned value is garbage or undefined '
    
    Fixes:
    
    source3/libsmb/clireadwrite.c:1259:17: warning: Assigned value is garbage or undefined <--[clang]
            state->written += written;
                           ^  ~~~~~~~
    
    source3/libsmb/clireadwrite.c:1722:14: warning: The left operand of '>' is a garbage value <--[clang]
            if (written > expected) {
                ~~~~~~~ ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Wed Aug 28 00:22:49 UTC 2019 on sn-devel-184

commit ad8fd31441f8012ae01e972d7faeba128507c5d1
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 14:51:23 2019 +0100

    s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
    
    Fixes:
    
    source3/libsmb/clireadwrite.c:851:10: warning: Assigned value is garbage or undefined <--[clang]
                    *nread = ret;
                           ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit fcb0355a74ea1c5e446c8465dd2fb017970d408e
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 14:49:51 2019 +0100

    s3/libsmb: clang: Fix '2nd func call argument is uninitalized value'
    
    Fixes:
    
    source3/libsmb/clireadwrite.c:805:2: warning: 2nd function call argument is an uninitialized value <--[clang]
            memcpy(state->buf, buf, received);
            ^                  ~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e1ef99223684e830e4bd5c8e7b33323e25ffafc1
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 14:42:06 2019 +0100

    s3/libsmb: clang: Fix 'The left operand of '>' or '<' is a garbage value
    
    Fixes:
    
    source3/libsmb/clireadwrite.c:601:15: warning: The left operand of '>' is a garbage value <--[clang]
            if (received > expected) {
    
    source3/libsmb/clireadwrite.c:799:16: warning: The left operand of '<' is a garbage value <--[clang]
            if ((received < 0) || (received > state->buflen)) {
                 ~~~~~~~~ ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 78ca70925ca00ae96065db4fd7a963cb999f2f3d
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 14:31:07 2019 +0100

    libcli/auth: clang: Fix 'Value stored to 'status' is never read'
    
    Fixes:
    
    libcli/auth/netlogon_creds_cli.c:2622:2: warning: Value stored to 'status' is never read <--[clang]
            status = netlogon_creds_decrypt_samlogon_validation(&state->tmp_creds,
            ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e874cc909a7f12286ae2514ceb063193469a8946
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 14:28:16 2019 +0100

    s3/libsmb: clang: Fix 'Value stored to 'p' is never read' warning
    
    Fixes:
    
    source3/libsmb/clirap2.c:1197:4: warning: Value stored to 'p' is never read <--[clang]
                            p += rap_getstringp(frame,
                            ^    ~~~~~~~~~~~~~~~~~~~~~
    source3/libsmb/clirap2.c:1525:5: warning: Value stored to 'p' is never read <--[clang]
                                    p += rap_getstring(frame,
                                    ^    ~~~~~~~~~~~~~~~~~~~~
    source3/libsmb/clirap2.c:2358:3: warning: Value stored to 'p' is never read <--[clang]
                    p += WORDSIZE;            /* skip rsize */
                    ^    ~~~~~~~~
    source3/libsmb/clirap2.c:2380:3: warning: Value stored to 'p' is never read <--[clang]
                    p += rap_getstringp(frame,
                    ^    ~~~~~~~~~~~~~~~~~~~~~
    4 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit bf567380a7cc69bf4dc4cf7bad6bc774fcef6085
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 12:21:32 2019 +0100

    s3/libsmb: clang: Fix 'Value stored to 'ea_size' is never read'
    
    Fixes:
    
    source3/libsmb/clifile.c:5290:2: warning: Value stored to 'ea_size' is never read <--[clang]
            ea_size = (size_t)IVAL(rdata,0);
            ^         ~~~~~~~~~~~~~~~~~~~~~
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit ce9fef5fd5ea5475748e99ba1e72abcb557afd83
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 11:59:05 2019 +0100

    s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
    
    Fixes:
    
    source3/libsmb/clifile.c:4898:10: warning: Assigned value is garbage or undefined <--[clang]
                    *bsize = (uint64_t)old_bsize;
                           ^ ~~~~~~~~~~~~~~~~~~~
    source3/libsmb/clifile.c:4901:10: warning: Assigned value is garbage or undefined <--[clang]
                    *total = (uint64_t)old_total;
                           ^ ~~~~~~~~~~~~~~~~~~~
    source3/libsmb/clifile.c:4904:10: warning: Assigned value is garbage or undefined <--[clang]
                    *avail = (uint64_t)old_avail;
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4bb9255473dae1e55b7711a9a2851533503ddb22
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 11:40:46 2019 +0100

    s3/libsmb: clang: Fix 'The left operand of '&' is a garbage value'
    
    Fixes:
    
    source3/libsmb/clifile.c:3108:26: warning: The left operand of '&' is a garbage value <--[clang]
                (cr.file_attributes & FILE_ATTRIBUTE_DIRECTORY))
                 ~~~~~~~~~~~~~~~~~~ ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e06d34e98e1d01d04997c342255595ddf74fb388
Author: Noel Power <noel.power at suse.com>
Date:   Wed Aug 14 11:25:19 2019 +0100

    s3/libsmb: clang: Fix 'The left operand of '!=' is a garbage value'
    
    Fixes:
    
    source3/libsmb/clifile.c:789:15: warning: The left operand of '!=' is a garbage value <--[clang]
            if (num_data != 100) {
                ~~~~~~~~ ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 8190993d99284162bd8699780248bb2edfec2673
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Aug 27 12:13:51 2019 +1000

    ctdb-recoverd: Fix typo in previous fix
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Tue Aug 27 15:29:11 UTC 2019 on sn-devel-184

commit b406b928242c95d34568a79c10e4b004779da085
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Aug 26 14:39:40 2019 +1200

    WHATSNEW: Document new GnuTLS 3.4.7 requirement
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Aug 27 06:01:50 UTC 2019 on sn-devel-184

commit 2ee1764ca88c882cddcc0a17f7d83950ec709b5d
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Mar 15 16:28:12 2019 +0100

    s3:smbd: Prefer AES-GCM over AES-CCM with GnuTLS
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adapted to remove Samba AES support
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 454ed53221b1374ad8148e922b64c3788ad4998e
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Mar 15 16:25:28 2019 +0100

    libcli:smb: Prefer AES-GCM over AES-CCM with GnuTLS
    
    The AES-GCM implementation in GnuTLS is faster.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adapted to remove Samba AES support
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit f24f26aaa58b9223e2c0cfd3e5086278b27903f1
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Aug 23 09:28:28 2019 +0200

    libcli:smb: Use gnutls_error_to_ntstatus() in smb2_signing_encrypt_pdu()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit eb65fe5505e32f451d4cf5d0203abce77c05dae4
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 14 10:27:06 2019 +0100

    libcli:smb: Use smb2_signing_key in smb2_signing_encrypt_pdu()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adaped to remove Samba AES support
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit b9c4990f57aa778942c310b802437e6df1d17e04
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Aug 23 09:27:35 2019 +0200

    libcli:smb: Use gnutls_error_to_ntstatus() in smb2_signing_decrypt_pdu()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7f56e91dbe404bc1ee40e4843c4046336945b057
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 14 10:53:23 2019 +0100

    libcli:smb: Use smb2_signing_key in smb2_signing_decrypt_pdu()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adaped to remove Samba AES support
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 3d2de36d9a08354fb775a5d93a9b40012bf6966f
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Feb 26 16:43:36 2019 +0100

    libcli:smb: Support GnuTLS AES CCM and GCM in smb2_signing_decrypt_pdu()
    
    This requires GnuTLS >= 3.4.0.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adapted to remove Samba AES support
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit f43da2adf64a8ff20ce6478f656927e531bc42af
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Feb 25 18:05:16 2019 +0100

    libcli:smb: Support GnuTLS AES CCM and GCM in smb2_signing_encrypt_pdu()
    
    This requires GnuTLS >= 3.4.0.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adapted to remove Samba AES support
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 10058bcfa16d5029e61252d64d142a8aab9ec296
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Aug 27 13:16:50 2019 +1200

    ldb: Extend the ldb_dn_explode test matrix
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a8a3cef3a768aaff01227dd7b229fb7b3aef926f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Aug 27 13:16:18 2019 +1200

    ldb: Do not read beyond the end of the extended DN component when printing
    
    The print functions used in Samba NULL terminate, but do not assume they will
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 52bd2dde5ae809ecc115f7087e367327f4771e73
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Aug 22 11:09:55 2019 +1200

    ldb: Add test with == true or false to boolean if statements in ldb_dn_explode()
    
    This is beyond the normal level of clarity we expect in Samba, and is of course
    rudundent, but this is a complex routine that has confusing tests, some of
    pointers and some of boolean state values.
    
    This tries to make the code as clear as possible pending a more comprehensive
    rewrite.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 3f290e95c2c133eb2c983ecc984d3dff4809f3d3
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Aug 22 10:59:07 2019 +1200

    ldb: Rework all pointer NULL tests to use Samba's normal style
    
    Also avoid if () without braces
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a097ddf65ce56dcd2e0b072b6dd78f512a77a9da
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jul 25 12:09:16 2019 +1200

    ldb: add some dn explode tests
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 54f30f2fe3f03c9640664f9a11260b093fc57a5b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jul 26 09:49:13 2019 +1200

    ldb: don't try to save a value that isn't there
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14049
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 1521a22f4366c86ec955cb9d32b7a758315d8ce0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Aug 26 14:50:15 2019 +1200

    ldb: Call TALLOC_FREE(filtered_msg->elements) on ldb_filter_attrs() failure
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Aug 27 01:16:33 UTC 2019 on sn-devel-184

commit 2117789c35fbf6d0ed02f391f17593e11727ec3e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Aug 26 14:48:52 2019 +1200

    ldb: use TALLOC_FREE() over talloc_free() in ldb_filter_attrs()
    
    This is a macro that sets the pointer to NULL after the talloc_free()
    and is part of our standard coding practices.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit b1eec5b196e3d5a5716a5c74cf669ceaa5c0301f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Aug 26 13:04:07 2019 +1200

    ldb: Correct Pigeonhole principle validation in ldb_filter_attrs()
    
    Thankfully this only fails if the DB is corrupt and has a duplicate record.
    
    The test was at the wrong end of the loop, and was for the
    wrong boundary condition.  A write after the end of the array would
    occour before the condition was hit.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13695
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 41aaeaf1fe921311f183d5c08ff121a9ccc4c5b4
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Mon Aug 26 16:34:29 2019 +1200

    ldb tests: Fix ldb_lmdb_size_test
    
    Fix the lmdb size test which ensures that databases > 4GiB can be
    written by the lmdb backend.  This test is not run as part of the normal
    CI run as it exhausts the available disk on the test runners.
    
    It was broken by changes to LDB allowing the lmdb map size to be
    specified, and requiring GUID indexing by default.
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 085e179dcb6a06f664d5447a2bee287f0a3698f4
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 19 14:52:13 2019 +0200

    ctdb-tests: fix mem leak in ltdb_fetch
    
    Direct leak of 256 byte(s) in 8 object(s) allocated from:
        #0 0x7f11b90d9c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
        #1 0x7f11b8f395df in tdb_alloc_read ../../../lib/tdb/common/io.c:696
        #2 0x7f11b8f290ee in _tdb_fetch ../../../lib/tdb/common/tdb.c:274
        #3 0x7f11b8f29379 in tdb_fetch ../../../lib/tdb/common/tdb.c:283
        #4 0x473ecc in ltdb_fetch ../../tests/src/fake_ctdbd.c:904
        #5 0x478b40 in ltdb_transaction_update ../../tests/src/fake_ctdbd.c:993
        #6 0x41fef2 in ctdb_rec_buffer_traverse ../../protocol/protocol_types.c:1656
        #7 0x48108b in ltdb_transaction ../../tests/src/fake_ctdbd.c:1026
        #8 0x48108b in control_trans3_commit ../../tests/src/fake_ctdbd.c:2878
        #9 0x48108b in client_process_control ../../tests/src/fake_ctdbd.c:4147
        #10 0x48108b in client_process_packet ../../tests/src/fake_ctdbd.c:3839
        #11 0x4847f5 in client_read_handler ../../tests/src/fake_ctdbd.c:3806
        #12 0x44f620 in comm_read_done ../../common/comm.c:208
        #13 0x7f11b8f94fe8 in _tevent_req_notify_callback ../../../lib/tevent/tevent_req.c:141
        #14 0x7f11b8f951fd in tevent_req_finish ../../../lib/tevent/tevent_req.c:193
        #15 0x7f11b8f95265 in _tevent_req_done ../../../lib/tevent/tevent_req.c:199
        #16 0x44e876 in pkt_read_handler ../../common/pkt_read.c:133
        #17 0x44f315 in comm_fd_handler ../../common/comm.c:412
        #18 0x7f11b8f92896 in tevent_common_invoke_fd_handler ../../../lib/tevent/tevent_fd.c:138
        #19 0x7f11b8fa6937 in epoll_event_loop ../../../lib/tevent/tevent_epoll.c:736
        #20 0x7f11b8fa6937 in epoll_event_loop_once ../../../lib/tevent/tevent_epoll.c:937
        #21 0x7f11b8f9f53e in std_event_loop_once ../../../lib/tevent/tevent_standard.c:110
        #22 0x7f11b8f90f34 in _tevent_loop_once ../../../lib/tevent/tevent.c:772
        #23 0x7f11b8f955f1 in tevent_req_poll ../../../lib/tevent/tevent_req.c:300
        #24 0x485a04 in start_server ../../tests/src/fake_ctdbd.c:4450
        #25 0x485a04 in main ../../tests/src/fake_ctdbd.c:4544
        #26 0x7f11b8c60412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Mon Aug 26 10:19:30 UTC 2019 on sn-devel-184

commit 767091535613720e1f2384003b363a58be0c5849
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Aug 23 11:24:50 2019 -0700

    pthreadpool: Remove wrong comment.
    
    Commit e45d33e9 removed the sync fallback path for the case that no
    thread could be created. Remove the comment for that fallback as it does
    not make sense anymore.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Fri Aug 23 23:09:12 UTC 2019 on sn-devel-184

commit 9b4685242fc7aeeae05d50566b428fc003848365
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:59:05 2019 -0700

    s3: VFS: Complete the replacement of SMB_VFS_READLINK() -> SMB_VFS_READLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Aug 23 20:06:22 UTC 2019 on sn-devel-184

commit 5333ac35dde2b904ac520ac80eee54042c33b39f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:53:25 2019 -0700

    s3: VFS: vfs_time_audit. Remove readlink_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the mknod_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 021da2f1522b373afeb20350ab2f86aae6f785e6
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:52:43 2019 -0700

    s3: VFS: vfs_full_audit. Remove readlink_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the mknod_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 58bce531fbf2d1d52055520f86d3ac2eabdd1eb0
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:51:17 2019 -0700

    s3: VFS: vfs_unityed_media. Remove readlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 79ac8e9ecab7b9eeb07a58830cb3569faa41778b
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:50:42 2019 -0700

    s3: VFS: vfs_snapper. Remove readlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit bc55a552b02d7659efcafd5672fd0fe5aa8dd912
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:49:54 2019 -0700

    s3: VFS: vfs_shadow_copy2. Remove readlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 65deb57c01d7649920654b7906c40d0a6c26ec40
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:49:08 2019 -0700

    s3: VFS: vfs_media_harmony. Remove readlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit f7f2572a23324fdcc6aa9209332a1af995421465
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:48:17 2019 -0700

    s3: VFS: vfs_glusterfs. Remove readlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 5fe9845b313090aa4db8cc12f74a13af87dc92bb
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:47:30 2019 -0700

    s3: VFS: vfs_expand_msdfs. Remove readlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 0f160428c4b8481196a08ef4d77519af90b99d27
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:46:40 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Remove readlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 1d1cef7331ede3ffe4f06435e3100157449b2a5f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:44:41 2019 -0700

    s3: VFS: vfs_ceph. Remove readlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 9ffa8c846201fe8dc8a80c9a7dae90e6677188ee
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:43:53 2019 -0700

    s3: VFS: vfs_cap. Remove readlink_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 406bde26545ef3d86bf19319b60262ee2c13825b
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:41:27 2019 -0700

    s3: smbd: Change process_symlink_open() to call SMB_VFS_READLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 288fbe35993375bcfc5f0191185abf61621b06b9
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:39:56 2019 -0700

    s3: smbd: Change smbd_do_qfilepathinfo(): case SMB_QUERY_FILE_UNIX_LINK: to call SMB_VFS_READLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 654469740c7763c3c7a1ace6da0a68ea37682fa1
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:38:01 2019 -0700

    s3: smbd: Change is_msdfs_link_internal() to call SMB_VFS_READLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 4684e2c9270291c664c83099104e5178203265ef
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:34:13 2019 -0700

    s3: torture: Change cmd_readlink to call SMB_VFS_READLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 6f1c0d43177bb050042e808c6c2acc4e3bdddb78
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:31:29 2019 -0700

    s3: VFS: vfs_unityed_media. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 854320cd5df93f430cf8a51b1924aa9cd2d5e135
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:29:45 2019 -0700

    s3: VFS: vfs_time_audit. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit eef38b05092771f496f6614456a797848da474aa
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:28:26 2019 -0700

    s3: VFS: vfs_snapper. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 06609f3ada9a4c8fe830e8b01d4ada2dcc640523
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:26:47 2019 -0700

    s3: VFS: vfs_shadow_copy2. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 44c955a81ada0f513230653f35f0d6a0dd6d7404
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:24:49 2019 -0700

    s3: VFS: vfs_media_harmony. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 4874730c3052668a1bc8b8939ee557a77387f1f0
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:22:55 2019 -0700

    s3: VFS: vfs_glusterfs. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3bdb77ad790961f6f1df41a088e3b40b0b507e87
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:21:23 2019 -0700

    s3: VFS: vfs_full_audit. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit de17e762eadc49f565d4495b716da9f0f9837cee
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:18:16 2019 -0700

    s3: VFS: vfs_expand_msdfs. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit b692b2916de1af02ee6f56c194a0436ec0fe01c0
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 14:10:31 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit e386ddb6a7ab6f4e0dec3f7d44431e2cb8b136da
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 13:51:28 2019 -0700

    s3: VFS: vfs_ceph. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 885d804c91ada945cf4c7d721cf08f55952f6e0b
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 13:49:28 2019 -0700

    s3: VFS: vfs_cap. Implement readlinkat().
    
    Currently identical to readlink().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 515c062b9e67a9f7016bcce3a02b75ab6d61385d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 22 13:42:26 2019 -0700

    s3: VFS: Add SMB_VFS_READLINKAT().
    
    Currently identical to SMB_VFS_READLINK().
    
    Next, add to all VFS modules that implement
    readlink and eventually remove readlink.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit d8863dd8cb74bb0534457ca930a71e77c367d994
Author: Poornima G <pgurusid at redhat.com>
Date:   Wed Jul 24 15:15:33 2019 +0530

    vfs_glusterfs: Use pthreadpool for scheduling aio operations
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14098
    
    Signed-off-by: Poornima G <pgurusid at redhat.com>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Aug 23 18:40:08 UTC 2019 on sn-devel-184

commit b4816861f200bb292e26f51b15c1ce93fa9e16c6
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Jul 5 16:46:04 2019 +1200

    s4-dns: Deprecate BIND9_FLATFILE and remove "rndc command"
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Aug 22 21:24:00 UTC 2019 on sn-devel-184

commit 561e0986ac96c842239b4e8c6509e05c836707b7
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Aug 17 06:59:33 2019 +1200

    docs: Deprecate "rndc command" for Samba 4.11
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14092
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 6a8bc6b549078a09276763f2196bf54c70d5de65
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 14:49:05 2019 -0700

    s3: VFS: Complete the replacement of SMB_VFS_MKNOD() -> SMB_VFS_MKNODAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Aug 22 19:17:07 UTC 2019 on sn-devel-184

commit e37580f45a557ad9f23a7220bd8edae8e6ce7bd5
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 14:44:20 2019 -0700

    s3: VFS: vfs_time_audit. Remove mknod_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the mknod_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 569865d4a2143d07ef1afbb00df5289123257c35
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:57:58 2019 -0700

    s3: VFS: vfs_full_audit. Remove mknod_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the mknod_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 42d6d9cf4ee8a3422bda4d4b7164415ce5bd96b5
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:55:37 2019 -0700

    s3: VFS: vfs_unityed_media. Remove mknod_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 5132e78c95c8f81ffae55e348619f7ffe0e6698f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:54:52 2019 -0700

    s3: VFS: vfs_syncops. Remove mknod_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 9ba187a5fc8d8e180245ee5741728322ff581103
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:54:02 2019 -0700

    s3: VFS: vfs_snapper. Remove mknod_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit b3fa9ccfdd4aacf13690060c5efbd606d26730f5
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:53:22 2019 -0700

    s3: VFS: vfs_shadow_copy2. Remove mknod_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 331cfa1100cc5edfba7f00ba7876a2319d048f5a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:52:04 2019 -0700

    s3: VFS: vfs_media_harmony. Remove mknod_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 50880f3d4a34354f0dca7b01e35cdc187b0975f0
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:48:50 2019 -0700

    s3: VFS: vfs_glusterfs. Remove mknod_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit c15c9eb31f239587f4b9cc44aa015709f572444a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:47:54 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Remove mknod_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 0e701ce3152fb71bc0d7e3271602fef067be7bcd
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:45:52 2019 -0700

    s3: VFS: vfs_ceph. Remove mknod_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 0d606ef6c4ce5948424c779fe951f6cbc2cae021
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 13:45:02 2019 -0700

    s3: VFS: vfs_cap. Remove mknod_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 7237517c8b46a578aa38da167e42b6619f3ae68c
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 12:15:01 2019 -0700

    s3: smbd: Make smb_unix_mknod() call SMB_VFS_MKNODAT() instead of SMB_VFS_MKNOD()
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 74127f5675381bdd8f77492321ee62080aa212de
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 12:11:44 2019 -0700

    s3: torture: Change cmd_mknod to call SMB_VFS_MKNODAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit a9099618eb68b0a23b1260902b5df87428201a91
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 12:09:24 2019 -0700

    s3: VFS: vfs_time_audit. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 6db33e35a868511fc4f9c602978b71fc115aae0c
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 11:36:48 2019 -0700

    s3: VFS: vfs_full_audit. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 5f115eca9261a568e0a65164af211c6be254e8b0
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 11:08:27 2019 -0700

    s3: VFS: vfs_unityed_media. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit a07ce6ead61b7fce545d151bb2ae34ccfda17bc5
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 11:06:17 2019 -0700

    s3: VFS: vfs_syncops. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 4ce3cd31004f42296f7672301c4230842d483044
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 11:03:41 2019 -0700

    s3: VFS: vfs_snapper. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 1aead2fe2516c237fb128ef03c4ad309c928f846
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 20 16:57:24 2019 -0700

    s3: VFS: vfs_shadow_copy2. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 574d76c03f637df06918a56999945105c406900e
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 20 16:55:55 2019 -0700

    s3: VFS: vfs_media_harmony. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit b32f345f14a79287280e877072da2a42c95ab24d
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 20 16:54:05 2019 -0700

    s3: VFS: vfs_glusterfs. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit a1c06667d6e2653801a34aae6a5f2dd952a86ae2
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 20 16:52:36 2019 -0700

    3: VFS: vfs_ceph_snapshots. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 2aaadbdda12628258d6bd41b0277758d338cb6a2
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 20 16:50:57 2019 -0700

    s3: VFS: vfs_ceph. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 8b27087d9cfbaf9e74538ed2d987531a7ae44d67
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 20 16:33:57 2019 -0700

    s3: VFS: vfs_cap. Implement mknodat().
    
    Currently identical to mknod().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit e2246876d1ebdde2eaa2bd635e8907f1671b4159
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 20 16:31:00 2019 -0700

    s3: VFS: Add SMB_VFS_MKNODAT().
    
    Currently identical to SMB_VFS_MKNOD().
    
    Next, add to all VFS modules that implement
    mknod and eventually remove mknod.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit e4c4af64fa7fde3ff116390182628235a2fb7185
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 20 16:28:18 2019 -0700

    s3: smbd: Add sys_mknodat() wrapper call.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit c68671bb949159de77170d8b73883171c50c9d96
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 21 14:38:03 2019 -0700

    s3: VFS: Remove extraneous enum/struct values for removed SMB_VFS_OP_LINK.
    
    Forgot this in removal of SMB_VFS_LINK() patch previously pushed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit ad24b7cf4dc61fd78de59539aef1ab73ff3b017d
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date:   Mon Aug 19 13:18:23 2019 +0200

    s3:net: load registry shares too in 'net vfs stream2adouble'
    
    Signed-off-by: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Aug 22 17:41:20 UTC 2019 on sn-devel-184

commit 39e06c49aebddaa208a149233cf35159588ebfdc
Author: Björn Jacke <bj at sernet.de>
Date:   Thu Aug 22 13:51:59 2019 +0200

    docs-xml: fix problamatic quotes from panic action example
    
    those quotes work for smbd but do not work for the samba binary. Without quotes
    it works with both.
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Thu Aug 22 13:46:14 UTC 2019 on sn-devel-184

commit 436423162592a684d52634e6db05f20bce6a5362
Author: Björn Jacke <bj at sernet.de>
Date:   Thu Jul 4 20:38:50 2019 +0200

    python: use os.urandom, which is available in python by definition
    
    os.urandom also uses CSPRNG methods like getrandom() when the underlying OS
    provides those.
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a7383889282d3b92a9c2eaded85a5ba20e828134
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 19 13:09:25 2019 +0200

    lib: free popt context in texpect
    
    If done with popt context it should be free'd.
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Aug 22 01:41:37 UTC 2019 on sn-devel-184

commit 5e1c7c084c85ea51f6843b95defee12ba6a8f0a0
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 19 14:33:33 2019 +0200

    s4: free popt context in dnsserver
    
    If done with popt context it should be free'd.
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 24aa50170bb7824c753e6b56c112cec3db02d8af
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 19 14:31:23 2019 +0200

    s4: free popt context in utils
    
    If done with popt context it should be free'd.
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 72d3604a9c4ee4325fef9b3a160445dc961c863e
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 19 14:29:22 2019 +0200

    s4: free popt context in client
    
    If done with popt context it should be free'd.
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 42123c11c4f279045189226d0a24aaa3eea5695c
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 19 14:18:06 2019 +0200

    s4: free popt context in torture
    
    If done with popt context it should be free'd.
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 355c9f5aca2af8db793bc3e695dc9b0d37e86483
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 19 14:11:54 2019 +0200

    rpcclient: free popt context when done
    
    If done with popt context it should be free'd.
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 968f72041021ccc0301220833f987dad8e3b9364
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 19 13:29:03 2019 +0200

    s3: free popt context in utils
    
    If done with popt context it should be free'd.
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit a7e7a62f7d3697660ba3575b94276e3a0489b57b
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 5 11:19:49 2019 +0200

    torture: fix mem leak found by ASAN (smb2_connect)
    
    Direct leak of 96 byte(s) in 1 object(s) allocated from:
        #0 0x7f0b16624c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
        #1 0x7f0b15e4ba5c in __talloc_with_prefix ../../lib/talloc/talloc.c:782
        #2 0x7f0b15e4ba5c in __talloc ../../lib/talloc/talloc.c:824
        #3 0x7f0b15e4ba5c in _talloc_named_const ../../lib/talloc/talloc.c:981
        #4 0x7f0b15e4ba5c in talloc_named_const ../../lib/talloc/talloc.c:1748
        #5 0x55ffdd30d591 in torture_smb2_connect ../../source4/torture/smb2/connect.c:199
        #6 0x7f0b12723772 in wrap_simple_test ../../lib/torture/torture.c:633
        #7 0x7f0b1272775e in internal_torture_run_test ../../lib/torture/torture.c:442
        #8 0x7f0b12728543 in torture_run_tcase_restricted ../../lib/torture/torture.c:507
        #9 0x7f0b12728dd5 in torture_run_suite_restricted ../../lib/torture/torture.c:357
        #10 0x7f0b12729434 in torture_run_suite ../../lib/torture/torture.c:339
        #11 0x55ffdd10c54a in run_matching ../../source4/torture/smbtorture.c:93
        #12 0x55ffdd10df56 in torture_run_named_tests ../../source4/torture/smbtorture.c:143
        #13 0x55ffdd11199d in main ../../source4/torture/smbtorture.c:691
        #14 0x7f0b0aa45412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Aug 21 15:42:43 UTC 2019 on sn-devel-184

commit 71ad473ba805abe23bbe6c1a1290612e448e73f3
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Aug 13 14:45:33 2019 +1000

    ctdb-tests: Clear deleted record via recovery instead of vacuuming
    
    This test has been flapping because sometimes the record is not
    vacuumed within the expected time period, perhaps even because the
    check for the record can interfere with vacuuming.  However, instead
    of waiting for vacuuming the record can be cleared by doing a
    recovery.  This should be much more reliable.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    RN: Fix flapping CTDB tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Wed Aug 21 13:06:57 UTC 2019 on sn-devel-184

commit 45b9e02f8f67cba9885e95a0c0af73373d39bafd
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Aug 7 16:58:37 2019 +1000

    ctdb-tests: Wait for child process when killing cluster mutex helper
    
    The following test sometimes fails:
    
    ==================================================
    Running "cluster_mutex_test lock-unlock-lock-unlock ./tests/var/cluster_mutex.lockfile"
    --------------------------------------------------
    Output (Exit status: 134):
    --------------------------------------------------
    LOCK
    UNLOCK
    CONTENTION
    NOLOCK
    cluster_mutex_test: ../../tests/src/cluster_mutex_test.c:307: test_lock_unlock_lock_unlock: Assertion `dl2->mh != NULL' failed.
    --------------------------------------------------
    Required output (Exit status: 0):
    --------------------------------------------------
    LOCK
    UNLOCK
    LOCK
    UNLOCK
    
    FAILED
    ==========================================================================
    TEST FAILED: tests/cunit/cluster_mutex_001.sh (status 1) (duration: 0s)
    ==========================================================================
    
    This is due to a race in the test.  For the first UNLOCK a signal is
    sent to the cluster mutex handler but the test tries to retake the
    lock before that process is scheduled and the signal is processed.
    Therefore, the fcntl() lock is still held and contention is seen.
    
    After unlocking, tests need to wait until the child has gone, so build
    this into ctdb_kill().  This is one of the only places where the PID
    is accessible.
    
    Outside of testing, on a real system, nothing will never try
    to (re)take the lock so quickly.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ca4df06080709adf0cbebc95b0a70b4090dad5ba
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 29 17:22:50 2019 +1000

    ctdb-tests: Strengthen volatile DB traverse test
    
    Check the record count more often, from multiple nodes.  Add a case
    with multiple records.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5d655ac6f2ff82f8f1c89b06870d600a1a3c7a8a
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Aug 21 14:35:09 2019 +1000

    ctdb-recoverd: Only check for LMASTER nodes in the VNN map
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 53daeb2f878af1634a26e05cb86d87e2faf20173
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 29 16:45:07 2019 +1000

    ctdb-tests: Don't retrieve the VNN map from target node for notlmaster
    
    Use the VNN map from the node running node_has_status().
    
    This means that
    
      wait_until_node_has_status 1 notlmaster 10 0
    
    will run "ctdb status" on node 0 and check (for up to 10 seconds) if
    node 1 is in the VNN map.
    
    If the LMASTER capability has been dropped on node 1 then the above
    will wait for the VNN map to be updated on node 0.  This will happen
    as part of the recovery that is triggered by the change of LMASTER
    capability.  The next command will then only be able to attach to
    $TESTDB after the recovery is complete thus guaranteeing a sane state
    for the test to continue.
    
    This stops simple/79_volatile_db_traverse.sh from going into recovery
    during the traverse or at some other inconvenient time.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit bff1a3a548a2cace997b767d78bb824438664cb7
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 29 16:43:09 2019 +1000

    ctdb-tests: Handle special cases first and return
    
    All the other cases involve matching bits.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit bb59073515ee5f7886b5d9a20d7b2805857c2708
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 29 15:45:41 2019 +1000

    ctdb-tests: Inline handling of recovered and notlmaster statuses
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 9b09a87326af28877301ad27bcec5bb13744e2b6
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 29 15:40:16 2019 +1000

    ctdb-tests: Drop unused node statuses frozen/unfrozen
    
    Silently drop unused local variable mpat.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 52227d19735a3305ad633672c70385f443f222f0
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 29 15:31:55 2019 +1000

    ctdb-tests: Reformat node_has_status()
    
    Re-indent and drop non-POSIX left-parenthesis from case labels.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14085
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit c3f969817553dc9c9db88741bad51100b4d24604
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Mar 15 14:54:13 2019 +0100

    lib:crypto: Do not build AES-CMAC if we use GnuTLS that supports it
    
    This requires GnuTLS >= 3.6.5.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Aug 21 11:14:11 UTC 2019 on sn-devel-184

commit 70ff03ecb6826525727d87ef8807428f91f4e506
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 15:50:03 2019 +1200

    libcli/smb: Use gnutls_error_to_ntstatus() in smb2_signing_check_pdu()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 1490f9260060104b31beefac9e61addd36b1919a
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Mar 15 16:58:21 2019 +0100

    libcli:smb: Use GnuTLS AES128 CMAC in smb2_signing_check_pdu()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9d8ffc81a53b6b3d7c29f0da8fd71e696ca7e9d8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 15:47:49 2019 +1200

    libcli/smb: Use gnutls_error_to_ntstatus() in smb2_signing_sign_pdu()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ee11e3ffd8d801cb5988bb73dbccd1e2f0cbe7b0
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Feb 27 14:40:30 2019 +0100

    libcli:smb: Use GnuTLS AES128 CMAC in smb2_signing_sign_pdu()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adapted by Andrew Bartlett to followup from earlier patch to
    allow compile without GnuTLS over the whole series.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 69be6b8416198cfa8e2404a0a62ce6432425adef
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Feb 27 14:40:07 2019 +0100

    waf: Check for AES128 CMAC support in GnuTLS
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 33bca1fb8087f7392a8ff0d295a5bdc01f1012e7
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Feb 26 18:11:27 2019 +0100

    s3:smbd: Use GnuTLS for AES constants
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adapted to remove Samba AES
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit b51c4293f7430b5ce6a81599fb0c7be5dc444c46
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 14 10:10:34 2019 +0100

    s3:smbd: Use smb2_signing_key structure for the decryption key
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 95e1c85a47e925fdb9105b85f0e1dbea1ff09950
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 14 10:02:27 2019 +0100

    s3:smbd: Use smb2_signing_key structure for the encryption key
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 87832f6140aa5afb42983a1291ba6faa250c7ea3
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 14 09:48:54 2019 +0100

    libcli:smb: Use a smb2_signing_key for storing the decryption key
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 48116a30d51d9bac6201a8b94262aa78b451ad63
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 14 09:34:23 2019 +0100

    libcli:smb: Use a smb2_signing_key for storing the encryption key
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 37dc63e8afab8e1f88dc8a4b77c6ef3337933eb1
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 14 09:26:04 2019 +0100

    libcli:smb: Add gnutls_aead_cipher_hd_t to smb2_signing_key structure
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adapted to remove Samba AES support
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 1b384f378c95f550718ac697271327442e3d09dd
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Feb 26 18:12:57 2019 +0100

    libcli:smb: Use GnuTLS for AES constants
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adapted to remove Samba AES support
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 43a941f51b2954ffa1a7ab8a9d5c4a18e654b9f6
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Feb 26 18:06:46 2019 +0100

    libcli:smb: Define SMB2_AES_128_CCM_NONCE_SIZE
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 068da56a20a2712e498fb3724407836bda2f977b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Aug 15 17:28:30 2019 +1200

    build: Remove explicit check for HAVE_GNUTLS_AEAD as we require GnuTLS 3.4.7
    
    We strictly require it and if this were to fail we would want the compile to fail.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 85a1c4973921fdf9412ec56a3ed6a77f3ab84116
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Jul 31 16:37:00 2019 +1200

    s4-samdb: Remove duplicate encrypted_secrets code using internal Samba AES
    
    We now rely on GnuTLS 3.4.7 or later.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e9859ad356b42f39585dcef1a38def97a50a3744
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Aug 15 14:23:35 2019 +1200

    lib/crypto: Remove unused RC4 code from Samba
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 2d54559aad9af81cf21d223dad28b48184c59f44
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 16:08:57 2019 +1200

    s4-rpc_server/backupkey: consistently check error codes from GnuTLS
    
    This uses the new gnutls_error_to_werror()
    
    This should resolve Coverity 1452111 as forwarded by Volker.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 52b91cb33c281aeecc6270824cadac6cefbcb136
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Jul 31 16:13:38 2019 +1200

    s4-rpc_server: Remove Heimdal-based BackupKey server
    
    We rely on a modern GnuTLS now.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 974cebdf953259f41ecfc7375bc31d72af53f51e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Aug 15 14:25:41 2019 +1200

    build: Set minimum GnuTLS version at 3.4.7
    
    This will soon be required for encrypted_secrets in the AD DC, the BackupKey server
    and SMB2 as we remove use of the internal AES code.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 1f6104f09a30cf3816fd5a580ce1b4be5b94848c
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Mar 15 14:54:13 2019 +0100

    lib:crypto: Prepare not to build AES or AES-CMAC if we use GnuTLS support it
    
    Samba will soon require GnuTLS >= 3.4.7.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adjusted by Andrew Bartlett from an earlier more comprehensive patch by Andreas
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit fa8eddc39b4ea9d316201019b603025df5c2fa5e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 15:45:43 2019 +1200

    auth/gensec: Use gnutls_error_to_ntstatus() in netsec_do_seal()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 025f6a135f930264ddcf1cd1b9e1004464618194
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Mar 18 16:24:54 2019 +0100

    auth:gensec: Use GnuTLS AES CFB8 in netsec_do_seal()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3b27fd8a490f29cbc94b8ac377b3a2cb6db7598c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 15:43:01 2019 +1200

    auth/gensec: Use gnutls_error_to_ntstatus() consistently in schannel
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 58c781dc93e24895b2c4b97fa311c66af30e278e
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Mar 1 17:55:02 2019 +0100

    auth:gensec: Use GnuTLS AES128 CFB8 in netsec_do_seq_num()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fefd95091cc52f5e2655fa392312a8b1fa1d35fd
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 14:29:45 2019 +1200

    auth/credentials: Check NTSTATUS return from netlogon_creds_aes_encrypt()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 1aa249e7f4a1c4222b4cc79bac64c8b95c89d868
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 14:22:42 2019 +1200

    s3-librpc: Remove unused init_netr_CryptPassword()
    
    Unused since 38d4dba37406515181e4d6f1a1faffc18e652e27 in 2013
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 1e427f55d71350b25a8a26e94a5cb7895d8efdf6
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 14:15:45 2019 +1200

    s4-rpc_server: Check NTSTATUS return value from netlogon_creds_aes_decrypt()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 2f827bec8ca831fb486c8ebedc6b89b7f1cb99e2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 14:05:38 2019 +1200

    s3-rpc_server: Check NTSTATUS return value from netlogon_creds_aes_decrypt()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d515b255aa67186ff375af0b465c49722eb56427
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 13:55:49 2019 +1200

    libcli:auth Check NTSTATUS from netlogon_creds_aes_{en,de}crypt()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 5ae119e7e9ddcfb3473e14585ba6079147a307bd
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 13:52:36 2019 +1200

    crypto: Update REQUIREMENTS file with new minimum version
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8ec796f1a1daa444bba06f34a50d2b62ee4a2ef9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 12:34:28 2019 +1200

    libcli:auth Return NTSTATUS from netlogon_creds_aes_decrypt()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a96728586150768957b88a0714b15f13ee9f81af
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Mar 18 15:13:08 2019 +0100

    libcli:auth: Use GnuTLS AES128 CFB for netlogon_creds_aes_decrypt()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit ded5aad21b54b8783f7390fb2eca483d3861eeff
Author: Andreas Schneider <asn at samba.org>
Date:   Wed May 29 16:38:09 2019 +0200

    libcli:auth: Return NTSTATUS for netlogon_creds_aes_encrypt()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Adapted by Andrew Bartlett to use gnutls_error_to_ntstatus()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 054efd118d7500e28f118722312aaae0df2749b0
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Mar 1 17:41:11 2019 +0100

    libcli:auth: Use GnuTLS AES128 CFB for netlogon_creds_aes_encrypt()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cd97c47873007bfc502926070a758b520d95abf1
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Mar 1 17:33:01 2019 +0100

    libcli:auth: Use netlogon_creds_aes_encrypt() in netlogon_creds_step_crypt()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 20a42459df4fdd57cdf1807a3d97dc5b1c553476
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Mar 1 17:35:02 2019 +0100

    waf: Check for GNUTLS AES CFB support
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d46e538d52433f5f30a5696e5b18bc4b82101951
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Feb 26 18:33:09 2019 +0100

    s4:samdb: Only include necessary header files in encrypted_secrets
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7bf3c5d7640daaf5dc799eaf698618903ec09127
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Feb 26 18:32:34 2019 +0100

    s4:samdb: Remove dual-stack mode from (test_)encrypted_secrets
    
    Now we either build with GnuTLS or Samba crypto. If a modern GnuTLS
    version is detected that will be used and Samba crypto wont be
    available.
    
    This removes the dual-stack mode that encrypted with one and decrypted
    with the other in the testsuite.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Commit message clarified by Andrew Bartlett
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 92b9cdf99da1f8657c166d413c5136c8db938a9e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Aug 15 15:27:30 2019 +1200

    encrypted_secrets: Add known and expected value test
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit feccdebe1532030e984e788a6a2c306c0f5c38c5
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jul 29 09:21:11 2019 +0200

    s4:samdb: Add test_gnutls_value_decryption()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1b599e5c0d076f49b8debc35f6888a7612d69599
Author: Marco Wang <m.aesophor at gmail.com>
Date:   Wed Aug 14 14:05:05 2019 +0800

    s3: net: net_ads: fix a typo in comment
    
    Signed-off-by: Marco Wang <m.aesophor at gmail.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Aug 21 08:39:43 UTC 2019 on sn-devel-184

commit fc4ad5b6dfdcfb859f92dcca868a043e31a051b0
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Thu Aug 15 14:43:22 2019 +0200

    talloc: ASAN fix for test_magic_protection
    
    Direct leak of 1152 byte(s) in 1 object(s) allocated from:
         #0 0x7f06393dfc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
         #1 0x7f06392cfd59 in __talloc_with_prefix ../../talloc.c:782
         #2 0x7f06392cfd59 in _talloc_pool ../../talloc.c:837
         #3 0x7f06392cfd59 in talloc_pool ../../talloc.c:859
         #4 0x40b83c in test_magic_protection ../../testsuite.c:1960
         #5 0x40b83c in torture_local_talloc ../../testsuite.c:2164
         #6 0x402603 in main ../../testsuite_main.c:32
         #7 0x7f063908a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit d0933ec62c113a6da5209a556fad8819febe4ec2
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Thu Aug 15 14:39:58 2019 +0200

    talloc: ASAN fix for test_rusty
    
    Direct leak of 100 byte(s) in 1 object(s) allocated from:
         #0 0x7f06393dfc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
         #1 0x7f06392d1af3 in __talloc_with_prefix ../../talloc.c:782
         #2 0x7f06392d1af3 in __talloc ../../talloc.c:824
         #3 0x7f06392d1af3 in __talloc_strlendup ../../talloc.c:2455
         #4 0x7f06392d1af3 in talloc_strdup ../../talloc.c:2471
         #5 0x40b4f0 in test_rusty ../../testsuite.c:1543
         #6 0x40b4f0 in torture_local_talloc ../../testsuite.c:2146
         #7 0x402603 in main ../../testsuite_main.c:32
         #8 0x7f063908a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit 6c3e8a0a9f0636467af5678c04d5aecc9c3dbf7a
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Thu Aug 15 14:36:59 2019 +0200

    talloc: ASAN fix for test_pool_nest
    
    Direct leak of 96 byte(s) in 1 object(s) allocated from:
        #0 0x7f06393dfc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
        #1 0x7f06392d0c45 in __talloc_with_prefix ../../talloc.c:782
        #2 0x7f06392d0c45 in __talloc ../../talloc.c:824
        #3 0x7f06392d0c45 in _talloc_named_const ../../talloc.c:981
        #4 0x7f06392d0c45 in talloc_named_const ../../talloc.c:1748
        #5 0x40901e in test_pool_nest ../../testsuite.c:1451
        #6 0x40901e in torture_local_talloc ../../testsuite.c:2096
        #7 0x402603 in main ../../testsuite_main.c:32
        #8 0x7f063908a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit 878e804df6377ffa120ae62b9abb182c957c10a6
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Thu Aug 15 14:33:32 2019 +0200

    talloc: ASAN fix for test_talloc_free_in_destructor
    
    Indirect leak of 104 byte(s) in 1 object(s) allocated from:
        #0 0x7f06393dfc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
        #1 0x7f06392d0c45 in __talloc_with_prefix ../../talloc.c:782
        #2 0x7f06392d0c45 in __talloc ../../talloc.c:824
        #3 0x7f06392d0c45 in _talloc_named_const ../../talloc.c:981
        #4 0x7f06392d0c45 in talloc_named_const ../../talloc.c:1748
        #5 0x409edd in test_talloc_free_in_destructor ../../testsuite.c:1256
        #6 0x409edd in torture_local_talloc ../../testsuite.c:2138
        #7 0x402603 in main ../../testsuite_main.c:32
        #8 0x7f063908a412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit 616646a0c4c5709ab334a11907642e710f912697
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Thu Aug 15 14:22:46 2019 +0200

    talloc: ASAN fix for test_realloc_on_destructor_parent
    
    Direct leak of 96 byte(s) in 1 object(s) allocated from:
        #0 0x7fd52c00dc08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
        #1 0x7fd52befec45 in __talloc_with_prefix ../../talloc.c:782
        #2 0x7fd52befec45 in __talloc ../../talloc.c:824
        #3 0x7fd52befec45 in _talloc_named_const ../../talloc.c:981
        #4 0x7fd52befec45 in talloc_named_const ../../talloc.c:1748
        #5 0x4099bd in test_realloc_on_destructor_parent ../../testsuite.c:1000
        #6 0x4099bd in torture_local_talloc ../../testsuite.c:2129
        #7 0x402603 in main ../../testsuite_main.c:32
        #8 0x7fd52bcb8412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit f42642e54e560f8a6328cbc035b0bbcfdffcf728
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:40:37 2019 -0700

    s3: VFS: Complete the replacement of SMB_VFS_LINK() -> SMB_VFS_LINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Aug 20 22:26:17 UTC 2019 on sn-devel-184

commit fb75a3d5e98e2ae3210f4fc68f0fabbc27f09c18
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:29:11 2019 -0700

    s3: VFS: vfs_time_audit. Remove link_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the rename_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 1b2440107f5e987cf6ffe2806d6516547b593fd8
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:21:42 2019 -0700

    s3: VFS: vfs_full_audit. Remove link_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the rename_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit d31d52f16d1554c6fb2f9426a39461206d8eb53d
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:28:16 2019 -0700

    s3: VFS: vfs_unityed_media. Remove link_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 295aa5bd24ac113913e0ec9f22c59c8f56ba3ddc
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:27:25 2019 -0700

    s3: VFS: vfs_syncops. Remove link_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3c3e62b79ee791209d3696d1d84641e6f3f99981
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:26:34 2019 -0700

    s3: VFS: vfs_snapper. Remove link_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit a5911429560fad0585bdc5b9084ad77070abbf96
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:25:37 2019 -0700

    s3: VFS: vfs_shadow_copy2. Remove link_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 38da902351b933bb6bb99e724e2f49987a8770d8
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:24:53 2019 -0700

    s3: VFS: vfs_media_harmony. Remove link_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 751852ced401fa1b3a6fe6c30bc89a23c342def0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:24:38 2019 -0700

    s3: VFS: vfs_glusterfs. Remove link_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit f9c3b0b3cf43ee08abd001f48307dbb7a332870f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:21:04 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Remove link_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 228423811c97d4ee99df924699ae4c003df3e2f9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:19:22 2019 -0700

    s3: VFS: vfs_ceph. Remove link_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 45851ead18ab687218648237e8651887e4d809fa
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:18:34 2019 -0700

    s3: VFS: vfs_cap. Remove link_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit ea637f002d0b0e30c29814fc6d8c137103deaa23
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:16:48 2019 -0700

    s3: smbd: Make hardlink_internals() call SMB_VFS_LINKAT() instead of SMB_VFS_LINK()
    
    Use conn->cwd_fsp as current src and dst fsp's.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit d4f3d6ce12b2e2d504dcdbbb9b670ceff5cf3243
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:14:03 2019 -0700

    s3: torture: Change cmd_link to call SMB_VFS_LINKAT().
    
    Use conn->cwd_fsp as current src and dst fsp's.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 6b6298b02392e30044efd9fbc236d9ffb8f1ec1a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:08:22 2019 -0700

    s3: VFS: vfs_unityed_media. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit a14d825a2507726f54ac3b4249e10968a2e35bd0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:05:55 2019 -0700

    s3: VFS: vfs_time_audit. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 571624b866d82bb1e9317c1f099049e0483bd1cc
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:04:02 2019 -0700

    s3: VFS: vfs_syncops. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit dad377dbe4795f110da35bb751f800d6658fa7c0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 16:01:22 2019 -0700

    s3: VFS: vfs_snapper. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit c55b43ba13a162d07befc27361632cdf2ef8aeb2
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 15:59:27 2019 -0700

    s3: VFS: vfs_shadow_copy2. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 6e96b98f6436289d1804b6a2a767b411edeb291b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 16 15:57:15 2019 -0700

    s3: VFS: vfs_media_harmony. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit d75177454c5612c7c68f637571f1bd3a3d34f220
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 14 13:01:39 2019 -0700

    s3: VFS: vfs_glusterfs. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 8e5634260632654b82f99170518b1086a2d9b9f1
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 14 11:45:35 2019 -0700

    s3: VFS: vfs_full_audit. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 2f989023259c92d3d5da7e0359a31f1a10c1dbb3
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 14 11:38:23 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 7d2ba253adaa3c6a57bd7048498e91a1ee0db712
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Aug 14 11:32:30 2019 -0700

    s3: VFS: vfs_ceph. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 648e771a61d2d327ed3fe0f3a4eb0837a714b280
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 13 14:59:05 2019 -0700

    s3: VFS: vfs_cap. Implement linkat().
    
    Currently identical to link().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 6c3928e4e5b724190843f75bec3e697af77a01a0
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Aug 12 16:49:26 2019 -0700

    s3: VFS: Add SMB_VFS_LINKAT().
    
    Currently identical to SMB_VFS_LINK().
    
    Next, move add to all VFS modules that implement
    link and eventually remove link.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 098486da91bdf431489879154e297591edef7f83
Author: Anoop C S <anoopcs at redhat.com>
Date:   Mon Aug 5 10:45:01 2019 +0530

    vfs_glusterfs: Enable profiling for file system operations
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14093
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Aug 20 19:25:28 UTC 2019 on sn-devel-184

commit 60cba7b3a17104da1543d59609f50c6638880dd1
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Aug 20 14:55:27 2019 +0200

    tdb: Release tdb 1.4.2
    
    * Build fixes
    * Improve the performance by inlining the tdb_oob() checks
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Tue Aug 20 14:45:41 UTC 2019 on sn-devel-184

commit e9f2e205ee89f4f3d6302cc11b4d0eb2efaf0f53
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 19 21:48:04 2019 +1000

    ctdb-daemon: Make node inactive in the NODE_STOP control
    
    Currently some of this is supported by a periodic check in the
    recovery daemon's main_loop(), which notices the flag change, sets
    recovery mode active and freezes databases.  If STOP_NODE returns
    immediately then the associated recovery can complete and the node can
    be continued before databases are actually frozen.
    
    Instead, immediately do all of the things that make a node inactive.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14087
    RN: Stop "ctdb stop" from completing before freezing databases
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Tue Aug 20 08:32:27 UTC 2019 on sn-devel-184

commit 91ac4c13d8472955d1f04bd775ec4b3ff8bf1b61
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Aug 20 11:29:42 2019 +1000

    ctdb-daemon: Drop unused function ctdb_local_node_got_banned()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14087
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 0f5f7b7cf4e970f3f36c5e0b3d09e710fe90801a
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 19 21:52:57 2019 +1000

    ctdb-daemon: Switch banning code to use ctdb_node_become_inactive()
    
    There's no reason to avoid immediately setting recovery mode to active
    and initiating freeze of databases.
    
    This effectively reverts the following commits:
    
      d8f3b490bbb691c9916eed0df5b980c1aef23c85
      b4357a79d916b1f8ade8fa78563fbef0ce670aa9
    
    The latter is now implemented using a control, resulting in looser
    coupling.
    
    See also the following commit:
    
      f8141e91a693912ea1107a49320e83702a80757a
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14087
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a42bcaabb63722411bee52b80cbfc795593defbc
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 19 21:47:03 2019 +1000

    ctdb-daemon: Factor out new function ctdb_node_become_inactive()
    
    This is a superset of ctdb_local_node_got_banned() so will replace
    that function, and will also be used in the NODE_STOP control.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14087
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit f8e79be2c155f26abfa7e5e3fddd2f453c2f943a
Author: David Disseldorp <ddiss at samba.org>
Date:   Sun Aug 18 11:24:37 2019 +0200

    build: fix mandatory typo in zlib configure check
    
    This ensures that waf correctly fails during configure if zlib is
    missing.
    msg can also be dropped as it matches the waf validate_cfg() default
    (ignoring the quotes).
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Aug 20 06:58:12 UTC 2019 on sn-devel-184

commit b6516dbd24df8c78ed909c7ef9058b0844abb917
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Wed Jul 31 10:54:29 2019 +1200

    ldb: Free memory when repacking database
    
    The msg for each database record is allocated on the module context, but
    never freed. The module seems like it could be a long-running context (as
    the database would normally get repacked by the samba executable).
    
    Even if it's not a proper leak, it shouldn't hurt to cleanup the memory.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>
    
    Autobuild-User(master): Garming Sam <garming at samba.org>
    Autobuild-Date(master): Tue Aug 20 04:57:10 UTC 2019 on sn-devel-184

commit ee6537c29e747206ee607493ce15d4532fb670c8
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Wed Jul 31 10:33:49 2019 +1200

    ldb: Log the partition we're repacking
    
    Firstly, with Samba AD this looks a little weird because we log the same
    message 5 times (once for every partition). If we log that we're doing
    this to records in different partitions, hopefully someone with a little
    Samba knowledge can figure out what's going on.
    
    Secondly, the info about what partitions are actually changing might be
    useful. E.g. if we hit a fatal error repacking the 3rd partition, and
    the transaction doesn't abort properly, then it would be useful to know
    what partitions were repacked and which ones weren't.
    
    There doesn't appear to be a useful name for the partition
    (ldb_kv->kv_ops->name() doesn't seem any more intelligible to a user),
    so just log the first record that we update. We can use that to infer
    the partition database).
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit 5fee9388422e259c2a56e4dccbf44d22ba426ca3
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Tue Jul 30 16:40:55 2019 +1200

    ldb: Log pack format in user-friendly way
    
    The "format 0x26011968" log confused me (and I'm a developer).
    We can subtract the base offset from the pack format to get a more
    user-friendly number, e.g. v0 (not actually used), v1, v2, etc.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit 38e3e7cd328edac302e95ac8839e858c4a225485
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Tue Jul 30 15:15:40 2019 +1200

    ldb: Change pack format defines to enum
    
    The main reason is so that any future pack formats will continue
    incrementing this number in a sequential fashion.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit d427bd6c775d8117504e76eed42cd2c383512e34
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Tue Jul 30 15:02:25 2019 +1200

    ldb: Move where we update the pack format version
    
    Store it on the repack context so that we can log a more informative
    message "Repacking from format x to format y".
    
    While this is not really a big deal currently, it could be worth
    recording for potential future scenarios (i.e. supporting three or more
    pack versions), where upgrades could potentially skip an intermediary
    pack format version.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit a2b0fc7c00360f37ed6819f21380294b70d4a195
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Tue Jul 30 16:40:55 2019 +1200

    ldb: Always log when the database pack format changes
    
    LDB_DEBUG_WARNING gets logged by Samba as level 2, whereas the default
    log level for Samba is 0. It's not really fair to the user to change the
    format of their database on disk and potentially not tell them.
    
    This patch adds a log with level zero (using a alias define, as this
    technically isn't a fatal problem).
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit 6dcf00ba0a470ba25aabae06b409ec95404c246f
Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
Date:   Mon Jul 22 13:35:21 2019 +1200

    downgradedatabase: installing script
    
    Installing downgrade script so people don't need the source tree for it.
    
    Exception added in usage test because running the script without arguments
    is valid. (This avoids the need to knownfail it).
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit c89df3862b17fad9c4648b5d9c6805120d732df8
Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
Date:   Mon Jul 22 13:35:21 2019 +1200

    downgradedatabase: Add man-page documentation
    
    A man-page is needed so that we can install this tool as part of the
    Samba package.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit fdaaee8d3aac77d91642a7d75d4bcd15d4df8657
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Mon Jul 29 13:39:04 2019 +1200

    downgradedatabase: rename to samba_downgrade_db
    
    Just so that it's slightly less of a mouthful for users.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit a8cdbe0b824f57f73eee09143148f009a9c58582
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Mon Jul 29 13:35:08 2019 +1200

    tests: Avoid hardcoding relative filepath
    
    If we move the test file, the test will break.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit c4aebb15001c830a46d5a6ad8ea11a6f9ea4fd04
Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
Date:   Mon Jul 22 15:29:03 2019 +1200

    downgradedatabase: comply with samba.tests.source
    
    In next commit we'll install the script, samba.tests.source picked up the
    lack of a copyright message and some whitespace errors, so this patch
    fixes that stuff first.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059
    
    Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>

commit 8a05d2b074d588a481aa372f2923f55cfb3e3a23
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 13 16:56:58 2019 +0200

    smbd: Move lease type detection in delay_for_oplock()
    
    Walk the share_modes array only once.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Aug 20 00:33:12 UTC 2019 on sn-devel-184

commit 9a11f361cc19d3b8da3469424697486d0fd8dd6d
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Aug 10 21:23:24 2019 +0200

    smbd: Merge grant_fsp_oplock_type() into delay_for_oplock()
    
    This is a preparation for the next commit: Only walk the share_modes[]
    array once when handling oplocks and leases.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7a6fa34130e8e6bea4672d08637af49097654119
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Aug 10 21:17:05 2019 +0200

    smbd: Move delay_for_oplock() down
    
    We'll merge grant_fsp_oplock_type() into this function. This makes the next
    commit smaller, and the newly extended delay_for_oplocks will for example
    reference static file_has_brlocks() above. Make forward declarations
    unnecessary.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a4192bc70d7717a5072ccdd8e53b7dda7e6d9c98
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Aug 10 21:15:22 2019 +0200

    smbd: Make delay_for_oplock() return NTSTATUS
    
    A further commit will merge grant_fsp_oplock_type (returning NTSTATUS)
    into delay_for_oplock(). Make that commit smaller.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 10679b67d1372bde37a1cdd639bebcc5f79a9c1b
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 9 13:39:34 2019 +0200

    smbd: Slightly simplify grant_fsp_oplock_type()
    
    This is never called with INTERNAL_OPENs anymore
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d1cb71fa500ede015600ace58411c857b051794e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 9 13:38:40 2019 +0200

    smbd: Slightly simplify delay_for_oplock()
    
    This is never called for INTERNAL_OPENs anymore, see
    handle_share_mode_lease()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 385a7fb196f7a6bdcdeb74b6e8553da7c810c1ca
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 7 12:15:45 2019 +0200

    smbd: Introduce handle_share_mode_lease()
    
    This consolidates the core share_mode_lock access of open_file_ntcreate
    into one routine.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d4e98b8ae5f08d6e332b15d868e7bf85995974f3
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 6 16:28:29 2019 +0200

    smbd: Move set_share_mode() out of grant_fsp_oplock_type()
    
    This shows that "req", "share_access" and "access_mask" are not needed
    for the core logic of grant_fsp_oplock_type() and it separates
    concerns a bit: open_directory() also does the set_share_mode() in the
    main open routine, not in a helper like grant_fsp_oplock_type()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5c6163d3e664c20034fb41969e886372e3c88aa6
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 16:31:17 2019 +0200

    smbd: Move grant_fsp_oplock_type() close to delay_for_oplock()
    
    Note that this is not a cut&paste: Instead of fsp->access_mask we use
    the access_mask the client requested. At the new code location
    fsp->access_mask (a.k.a. open_access_mask) might have FILE_WRITE_DATA
    from O_TRUNC (a.k.a. FILE_OVERWRITE).
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3ecfa36e777cf377a4ae06644b0880fef4867452
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 2 15:24:16 2019 +0200

    smbd: Slightly simplify open_file_ntcreate()
    
    There is no reference to "file_existed" after this point anymore
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3bd7b119e6882aee04badc92f2ddbcbc1964c115
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 2 15:21:49 2019 +0200

    smbd: Remove a late ref to "file_existed" in open_file_ntcreate()
    
    If you follow "existing_dos_attributes" through the routine, this can
    only ever be !=0 if SMB_VFS_GET_DOS_ATTRIBUTES() was successful. This
    can only have been successful if the file existed.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f8fe0116c1158d8fdf0401ca46e8f12b84c04738
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 11:52:21 2019 +0200

    smbd: Move resetting "oplock_request" to before delay_for_oplock()
    
    It seems to make little sense to me to do the oplock break with one
    setting and then later on grant_fsp_oplock_type with another
    one. Survives tests, I can't think of any scenario where this (to me)
    simplification would break anything
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 002c6d0efb7bb41c158fc9056a176c5cce72f393
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Aug 18 08:57:38 2019 +0200

    smbd: For kernel-oplocked files don't call delay_for_oplock()
    
    The kernel has already sent the signal. We don't have to send another
    message. Instead, just directly wait for the downgrade to happen via
    the watch on the share mode lock assuming it's there. Also setup the
    polling interval: I could imagine that in some race situation the file
    has already been closed and re-opened by a nonsamba process while we
    were waiting.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 706f0af2e4b5012644da742c94fc12eb756054fd
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Aug 18 08:55:14 2019 +0200

    smbd: Optionally wait for a share mode record in setup_poll_open()
    
    This will be used when waiting for a oplock break that has been
    signalled via a kernel oplock break.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4d6f89c9883abaf7e9152887b7fa13449579c09c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 21:27:53 2019 +0200

    smbd: Simplify has_other_nonposix_opens()
    
    We pick quite some information from "fsp" already, so from an API design
    perspecitve it's only fair to only use its implicit server_id. This is
    what all the callers did anyway.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 6be8057317a05b247169b8a30f968d1d2c085562
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 21:39:50 2019 +0200

    smbd: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 28868d24576dbd437329b7a59104cb7c15ee4624
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Aug 10 15:01:24 2019 +0200

    smbd: Simplify delay_for_oplock()
    
    Use is_same_lease()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 021e2d01e68714556bd811ff2bc2a04c71a6c1fd
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Aug 10 15:01:00 2019 +0200

    smbd: Move is_same_lease() up in the file
    
    The next commit will need it there
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 71c9fd73d42e092cf65de25fb7773fc1395ff601
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Aug 10 14:28:51 2019 +0200

    smbd: Simplify is_same_lease()
    
    It does not use "struct share_mode_data"
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 9034cb39d7c0d8d6387f4977f894349db187d6b5
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Aug 10 14:44:08 2019 +0200

    smbd: Optimize delay_for_oplock()
    
    get_lease_type() can involve a database access. Do that only if
    necessary, and that is at most once in this loop.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 38463a91aafa2643551b4e4508c3e575d9e914a1
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Aug 10 16:45:30 2019 +0200

    lib: Remove a duplicate function prototype
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit aeb4265ec2f5d75250b1bc4d884628426df28dca
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 9 13:48:53 2019 +0200

    smbd: Remove a misleading comment
    
    open_mode_check() is done before the oplock breaks.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit d09bd5f8fd4b2de28efcefc5839bd69bb088b88f
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 12 12:12:48 2019 +0200

    smbd: Merge two DEBUGs into one
    
    This looks easier to understand to me, less lines in logfiles
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 13fb42ac40067d1b335511e48354169ee15f29b3
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 12 11:44:39 2019 +0200

    smbd: Avoid casts in share_conflict()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit a0b0ea8f356ac3a788d7b33d249ed6ec3eecc4bb
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Aug 10 22:15:05 2019 +0200

    smbd: Save two lines in find_share_mode_entry
    
    Directly initialized variables give compilers less reason to complain
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 58b5bfba11a66d250267efe901dfba76f82005f8
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 13 14:43:08 2019 +0200

    lib: Micro-optimization for db_tdb_do_locked()
    
    We don't need the tdb lock for the talloc_free(buf) anymore
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 7d96ed632260d7246f1729ee7efb696abc29fd6c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 20:58:32 2019 +1200

    third_party: Remove historical tombstone about zlib divergance
    
    Now this has been recorded in the git history, we can remove it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sat Aug 17 05:10:48 UTC 2019 on sn-devel-184

commit 2b7224ab7c555fdaacd0a84649b533e4edb377da
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Aug 16 17:43:51 2019 +1200

    third_party: Remove zlib from third_party
    
    We require zlib 1.2.3.
    
    We stopped requring a patched zlib with 5631a1b9bc03d6cf31af66b13872255f18979fe8
    
    As discussed on samba-technical here:
    
    https://lists.samba.org/archive/samba-technical/2019-May/133476.html
    
    In short, zlib contains some (old, now broken) crypto code that while not compiled
    in Samba is best left out of our tarball to ease crypto audits.  It is also very
    very out of date and is a slightly modified copy of something otherwise very
    likely available on our supported host OSs.  It would be strange to say that
    GnuTLS and dependencies are an acceptable burden to install but say zlib is
    a step to far.
    
    So it is removed from Samba's third_party with this commit.
    
    The diff between zlib in Samba and official zlib 1.2.3 is included
    in third_party/zlib/last-samba-from-1.2.3.diff
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4be5ffdca620c38e65ca955039acbdcf72829c67
Author: David Mulder <dmulder at suse.com>
Date:   Tue Aug 6 11:31:08 2019 -0600

    Prevent samba-tool online backup crash
    
    On some GPOs, getting a files ntacl throws an
    NT_STATUS_ACCESS_DENIED. Catch and log the
    failure when this happens.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14088
    
    Signed-off-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Tim Beale <timbeale at samba.org>

commit 73c850eda4209b688a169aeeb20c453b738cbb35
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Aug 13 17:08:43 2019 +1000

    ctdb-tcp: Mark node as disconnected if incoming connection goes away
    
    To make it easy to pass the node data to the upcall, the private data
    for ctdb_tcp_read_cb() needs to be changed from tnode to node.
    
    RN: Avoid marking a node as connected before it can receive packets
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Fri Aug 16 22:50:35 UTC 2019 on sn-devel-184

commit 8c98c10f242bc722beffc711e85c0e4f2e74cd57
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Aug 9 15:33:05 2019 +1000

    ctdb-tcp: Only mark a node connected if both directions are up
    
    Nodes are currently marked as up if the outgoing connection is
    established.  However, if the incoming connection is not yet
    established then this node could send a request where the replying
    node can not queue its reply.  Wait until both directions are up
    before marking a node as connected.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 7f4854d9643a096a6d8a354fcd27b7c6ed24a75e
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Aug 15 15:57:31 2019 +1000

    ctdb-tcp: Create outbound queue when the connection becomes writable
    
    Since commit ddd97553f0a8bfaada178ec4a7460d76fa21f079
    ctdb_queue_send() doesn't queue a packet if the connection isn't yet
    established (i.e. when fd == -1).  So, don't bother creating the
    outbound queue during initialisation but create it when the connection
    becomes writable.
    
    Now the presence of the queue indicates that the outbound connection
    is up.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit d80d9edb4dc107b15a35a39e5c966a3eaed6453a
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Aug 15 15:45:16 2019 +1000

    ctdb-tcp: Use TALLOC_FREE()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit c68b6f96f26664459187ab2fbd56767fb31767e0
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Aug 9 15:29:36 2019 +1000

    ctdb-tcp: Move incoming fd and queue into struct ctdb_tcp_node
    
    This makes it easy to track both incoming and outgoing connectivity
    states.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit c06620169fc178ea6db2631f03edf008285d8cf2
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Aug 9 15:06:34 2019 +1000

    ctdb-tcp: Rename fd -> out_fd
    
    in_fd is coming soon.
    
    Fix coding style violations in the affected and adjacent lines.
    Modernise some debug macros and make them more consistent (e.g. drop
    logging of errno when strerror(errno) is already logged.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 3acb8e9d1c854b577d6be282257269df83055d31
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Aug 8 16:20:44 2019 +1000

    ctdb-daemon: Add function ctdb_ip_to_node()
    
    This is the core logic from ctdb_ip_to_pnn(), so re-implement that
    that function using ctdb_ip_to_node().
    
    Something similar (ctdb_ip_to_nodeid()) was recently removed in commit
    010c1d77cd7e192b1fff39b7b91fccbdbbf4a786 because it wasn't required.
    Now there is a use case.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14084
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5cb539d8adedadee2089edd334ffc8c0bd3e4c77
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Aug 12 10:34:37 2019 -0700

    s3: VFS: vfs_default. Convert underlying system call to renameat().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Aug 16 21:10:14 UTC 2019 on sn-devel-184

commit 6acf4c35b46e8e7860209be00b688c631f0155bf
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:28:32 2019 -0700

    s3: VFS: Complete the replacement of SMB_VFS_RENAME() -> SMB_VFS_RENAMEAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f0ac39d56156257275048a55f101665e32905da9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:14:14 2019 -0700

    s3: VFS: vfs_time_audit. Remove rename_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the rename_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7aadbe5608e0322fbb627b4da4382613fa9dd25d
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:04:35 2019 -0700

    s3: VFS: vfs_full_audit. Remove rename_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the rename_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5db3edba41421f826f9a5a07efb17734c6c24969
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:38:11 2019 -0700

    s3: VFS: vfs_virusfilter. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d45daf1ce86801e5800203e64abcaca0e7381805
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:13:16 2019 -0700

    s3: VFS: vfs_unityed_media. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 33a243b7a2cf0bbcfde5a52dd70cef670164027c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:12:25 2019 -0700

    s3: VFS: vfs_syncops. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 110aff0caae03593e53a980c6c9074354f813a64
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:11:43 2019 -0700

    s3: VFS: vfs_streams_xattr. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c661a5fbe6e7ff27effb084519b539b9c9819f0c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:29:58 2019 -0700

    s3: VFS: vfs_streams_depot: Change to using SMB_VFS_RENAMEAT() instead of SMB_VFS_RENAME().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 46d61e203c73092ae300e75c6c56e5769cb67609
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:10:57 2019 -0700

    s3: VFS: vfs_streams_depot. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8e6a283a16f10f9d83e66d41271ccef536c85f0b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:10:06 2019 -0700

    s3: VFS: vfs_snapper. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d080085273f8c723dd1a844743904cf1cd9822a1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:08:53 2019 -0700

    s3: VFS: vfs_shadow_copy2. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 055fda0830e2fe470ed23ccd963e29b4a8bb711b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:07:53 2019 -0700

    s3: VFS: vfs_netatalk. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ca4e66cbd3a04407353974a751f0c6de19bdc5a5
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:07:14 2019 -0700

    s3: VFS: vfs_media_harmony. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8afb453edc37b352d4d7447049798399332e2490
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:06:11 2019 -0700

    s3: VFS: vfs_glusterfs. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7486b3c9f57b8e1353e93d51cd4597ad6f449509
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:03:11 2019 -0700

    s3: VFS: vfs_fruit. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0464730ee2a1f17ce0944df4bfd9f6aa56678117
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:01:57 2019 -0700

    s3: VFS: vfs_extd_audit. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ba25d8fbb16a1c11880e7434803b6c92b23647ee
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:59:54 2019 -0700

    s3: VFS: vfs_crossrename. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 52960225fa8727f9dfe91f76e921a3c56168347c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:59:05 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 086a7d7835081447424153331acc32360642e65b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:58:11 2019 -0700

    s3: VFS: vfs_ceph. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9cedbbe88cb26e79371c28b017a4078d7091f517
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:56:59 2019 -0700

    s3: VFS: vfs_catia. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e591d92e98c2ddd6f98e2f9aa57f830ab573bf44
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:55:48 2019 -0700

    s3: VFS: vfs_cap. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ef0d50c27225f3a6cb570ed364ce17ffbae3506a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:41:59 2019 -0700

    s3: VFS: vfs_audit. Remove rename_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d439c2bab4a3b1b8c4f3cee0cfe4110f8ea3f88c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:27:49 2019 -0700

    s3: VFS: vfs_recycle. Use SMB_VFS_RENAMEAT() instead of SMB_VFS_RENAME().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 20564183966e36756b33c3b4e36d89a6932475e1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:26:10 2019 -0700

    s3: smbd: vfs_virusfilter: Use SMB_VFS_RENAMEAT() instead of SMB_VFS_RENAME.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 25c1b853cf42b6e56090c1588d5696d24141829a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:40:47 2019 -0700

    s3: torture: Change cmd_vfs to call SMB_VFS_RENAMEAT().
    
    Use conn->cwd_fsp as current src and dst fsp's.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 74ecfe28a96f2be960bd2d12a33f09a69582c54a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:38:32 2019 -0700

    s3: smbd: Change rename_internals_fsp() to call SMB_VFS_RENAMEAT().
    
    Use conn->cwd_fsp as current src and dst fsp's.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d2fc9b136b7c632be92b078fa99a83d025b3d26e
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 16:36:32 2019 -0700

    s3: VFS: vfs_virusfilter. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7978814d3b5a0b41b00b7c6043b9a12b88ca5b12
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:36:52 2019 -0700

    s3: VFS: vfs_unityed_media. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 16a455d3c3816a0a0fa82af8b04fa1c6fe6947a1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:34:52 2019 -0700

    s3: VFS: vfs_time_audit. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 588e64ddd02cb6b63184d5edffe7b5f2432232d8
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:33:08 2019 -0700

    s3: VFS: vfs_syncops. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 251bb56d1b064cbc90729cc58d0549e8f561b4bd
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:31:03 2019 -0700

    s3: VFS: vfs_streams_xattr. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7ec34e6ab86c53e51896b717ede24bf1a9c0a14a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:28:56 2019 -0700

    s3: VFS: vfs_streams_depot. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a85433f4bdeaf493e5c4cbf1c4c0feb5b34a415a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:28:34 2019 -0700

    s3: VFS: vfs_snapper. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a2d27f9113cef750a2e9fe2aac3c70dc7191dada
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:13:24 2019 -0700

    s3: VFS: vfs_shadow_copy2. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9193cd402ff33caa853f341b90c7a9e25ebb5785
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:03:44 2019 -0700

    s3: VFS: vfs_netatalk. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e61da4989946ff283e77c73cb201ab875de7d264
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:03:06 2019 -0700

    s3: VFS: vfs_media_harmony. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 318461eb7d3e1aa8651b6add54db10ea864bb380
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 15:02:35 2019 -0700

    s3: VFS: vfs_glusterfs. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4d74ed6f567832a43dbf04a868efe0f30cb53752
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 14:25:21 2019 -0700

    s3: VFS: vfs_full_audit. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8d8faa53fc7ef2163a3095ab29430fba06c8455a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 14:22:03 2019 -0700

    s3: VFS: vfs_fruit. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ca298af67cebee4c3efebf24f4b9d0ef1e73b047
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 14:19:09 2019 -0700

    s3: VFS: vfs_extd_audit. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c36ba3aff88bbb93ea5048906775bcedfaeac221
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 14:16:12 2019 -0700

    s3: VFS: vfs_crossrename. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4a415f63e6383ef4a293240ab77ec4ba92f25b4e
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 13:49:46 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ab74d8d5bd4636405731c9d2aa2d32880844b349
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 13:45:32 2019 -0700

    s3: VFS: vfs_ceph. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5528bcd44750cd989e051f6db6908e061e714f91
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 16:35:54 2019 -0700

    s3: VFS: vfs_catia. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9859102b204b5ba9a348e4df30aff9d3afc6aae3
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 16:13:20 2019 -0700

    s3: VFS: vfs_cap. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 365b81238e261bae2b4f4ffe968a11cb3c0ff50a
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:30:54 2019 -0700

    s3: VFS: vfs_audit. Implement renameat().
    
    Currently identical to rename().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 606398a3a6da349877eb1d6f585e3f58778624b2
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:22:31 2019 -0700

    s3: VFS: Add SMB_VFS_RENAMEAT().
    
    Currently identical to SMB_VFS_RENAME() - uses
    AT_FDCWD for both src and dst directories.
    
    Next, move add to all VFS modules that implement
    rename and eventually remove rename.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 75f98a19537c4d0791108ebfea82f3f9d4606cb3
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Aug 15 15:53:32 2019 +0200

    s3: VFS: change connection_struct cwd_fname to cwd_fsp
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b535f78897eb5989666501f9543df478af420ecc
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Aug 15 14:43:07 2019 +0200

    vfs_full_audit: pass conn to smb_fname_str_do_log()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c9b38eb79c99ad054231950e6d56a86da1061f8c
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Aug 15 15:15:30 2019 +0200

    s3:smbd: modernize conn_new()
    
    Split the monstrous if into individual allocations. I'm going to add more talloc
    allocations in a subsequent commit, so it's time to split this up.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 04f5dbb168a6b91aecb60ebb398a5f5297b288d5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 14:38:24 2019 -0700

    s3: smbd: Reformatting. Use helper variable for SMB_VFS_RENAME call.
    
    Will make replacement with renameat() clearer later.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3ee78cc9979a72ebbe65a16c60967a1735a0d208
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Aug 14 10:11:15 2019 +0200

    vfs_glusterfs: initialize st_ex_file_id, st_ex_itime and st_ex_iflags
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14090
    RN: vfs_glusterfs: initialize st_ex_file_id, st_ex_itime and st_ex_iflags
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Aug 16 01:07:23 UTC 2019 on sn-devel-184

commit 442a7c9ad8b020b2e88e41fea8a911d244023cb9
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Aug 14 10:06:00 2019 +0200

    vfs_default: use correct flag in vfswrap_fs_file_id
    
    Luckily using the wrong flag ST_EX_IFLAG_CALCULATED_ITIME currently results in
    the same semantics as using the correct ST_EX_IFLAG_CALCULATED_FILE_ID, as in
    vfs_default the non-calculated file_id is based a non-calculated itime.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14089
    RN: vfs_default: use correct flag in vfswrap_fs_file_id
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ec05edcceed96f4a17ce7e45c4554b0500946ce0
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Aug 13 13:45:48 2019 -0700

    smbd: Make sys_disk_free static
    
    The function is only called from the same file.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Wed Aug 14 17:47:33 UTC 2019 on sn-devel-184

commit f77c6c8be6b19880fb46fb5524a39cea03ef7bd5
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Aug 13 13:44:52 2019 -0700

    selftest: Add test for quota query on directory with SGID
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit bbb259e7acb2485232359191f9d799e4c87bcbae
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Aug 13 13:37:22 2019 -0700

    vfs_fake_dfq: Add option to fake stat information
    
    Add an option to allow faking the gid and the SGID bit in the returned
    stat buffer. That will be used to verify quota queries on folders with
    SGID set.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 72c4e33decbaa19f9e7845240fdcf02029ded82c
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Aug 7 10:42:26 2019 -0700

    vfs_gpfs: Check group quota for directory when SGID is set
    
    On directories with the "set group id" (SGID) bit is set, new files and
    subfolders will be created with the group of the directory, and not with
    the primary group of the user. Checking for free space in this case
    should query the group quota for the gid of the directory.
    
    This is the same change as the common smbd code, but since vfs_gpfs
    still has its own check for available space and quotas, add it here as
    well. A future goal would be to use the common free space check instead
    of duplicating code in vfs_gpfs.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 02b7e6c79b866ba0d339cad6c4fc9eb0d0be8968
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Aug 13 13:40:48 2019 -0700

    quotas: Check group quota for directory when SGID is set
    
    On directories with the "set group id" (SGID) bit is set, new files and
    subfolders will be created with the group of the directory, and not with
    the primary group of the user. Checking for free space in this case
    should query the group quota for the gid of the directory.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 9b7825d2d387bcb2515154418a990669ab96358d
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Aug 12 19:07:15 2019 +0200

    auth:ntlmssp: Use generate_random_buffer() for session keys
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
    Autobuild-Date(master): Wed Aug 14 16:26:47 UTC 2019 on sn-devel-184

commit 6fa3e4de7c168dc7c869ec9966729a36bda27f57
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Aug 12 18:57:06 2019 +0200

    s3:passdb: Use generate_secret_buffer() for generating passwords
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit a3e36dd8f43a5c06969ae158fa54fbc649f44d03
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Aug 12 18:56:35 2019 +0200

    s4:samdb: Use generate_nonce_buffer() for AEC GCM nonce
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 93196dd823e114f260a68d28bb59eac3909c30d8
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Aug 12 18:55:56 2019 +0200

    lib:util: Use generate_secret_buffer() for long term passwords
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit d73be972ea58d564c770698bf6374a6074f111fe
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Aug 12 18:50:02 2019 +0200

    Revert "s4:rpc_server: Use generate_secret_buffer() to create a session key"
    
    This reverts commit 4b2480518bd3887be3a6cfb713523ac084e09fd5.
    
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 38b0695ddac244c67b2a33eb927ad3e95d2e8bd6
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Aug 12 18:49:52 2019 +0200

    Revert "s4:rpc_server: Use generate_secret_buffer() for backupkey wap_key"
    
    This reverts commit 5a62056b4530e4c509444be9164a1fca1dce193f.
    
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 1c68085404cd467c217640e3eabfc4b7f8b1ce9f
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Aug 12 18:49:37 2019 +0200

    Revert "s4:rpc_server: Use generate_secret_buffer() for netlogon challange"
    
    This reverts commit a21770cfdffd2a21045a1bc87e489af0f4c6f130.
    
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 689760f26521fe5b4c8964a25ddd3ab1c9e9977c
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Aug 12 18:49:31 2019 +0200

    Revert "libcli:auth: Use generate_secret_buffer() for netlogon challenge"
    
    This reverts commit c3ba556f52b15dd80efc26e4fb8f43ce2ee3a7f0.
    
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 97c441d7c28feb29168e81ebbc5c55b09a845087
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Aug 12 16:10:20 2019 +0200

    lib:util: Fix documentation for random number functions
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4d276a93fc624dc04d880f5b4157f272d3555be6
Author: Alexander Bokovoy <ab at samba.org>
Date:   Sat Aug 10 11:53:12 2019 +0300

    smbtorture: extend rpc.lsa to lookup machine over forest-wide LookupNames
    
    Add a simple test to resolve DOMAIN\MACHINE$ via LSA LookupNames3
    using LSA_LOOKUP_NAMES_UPLEVEL_TRUSTS_ONLY2 level. This level would pass
    zero lookup flags to lookup_name().
    
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
    Autobuild-Date(master): Wed Aug 14 13:07:42 UTC 2019 on sn-devel-184

commit 685bb03de6ab733590831d1df4f5fd60d2ac427d
Author: Alexander Bokovoy <ab at samba.org>
Date:   Thu Aug 1 15:48:58 2019 +0300

    lookup_name:  allow own domain lookup when flags == 0
    
    In 2007, we've added support for multiple lookup levels for LSA
    LookupNames family of calls. However, forest-wide lookups, as described
    in MS-LSAT 2.2.16, never worked because flags passed to lookup_name()
    were always set to zero, expecting at least default lookup on a DC to
    apply. lookup_name() was instead treating zero flags as 'skip all
    checks'.
    
    Allow at least own domain lookup in case domain name is the same.
    This should allow FreeIPA DC to respond to LSA LookupNames3 calls from a
    trusted AD DC side.
    
    For the reference, below is a request Windows Server 2016 domain
    controller sends to FreeIPA domain controller when attempting to look up
    a user from a trusted forest root domain that attemps to login to the
    domain controller. Notice the level in the lsa_LookupNames3 call and
    resulting flags in lookup_name().
    
    [2019/08/03 07:14:24.156065,  1, pid=23639, effective(967001000, 967001000), real(967001000, 0), class=rpc_parse] ../../librpc/ndr/ndr.c:471(ndr_print_function_debug)
           lsa_LookupNames3: struct lsa_LookupNames3
              in: struct lsa_LookupNames3
                  handle                   : *
                      handle: struct policy_handle
                          handle_type              : 0x00000000 (0)
                          uuid                     : 0000004c-0000-0000-455d-3018575c0000
                  num_names                : 0x00000001 (1)
                  names: ARRAY(1)
                      names: struct lsa_String
                          length                   : 0x000a (10)
                          size                     : 0x000c (12)
                          string                   : *
                              string                   : 'XS\ab'
                  sids                     : *
                      sids: struct lsa_TransSidArray3
                          count                    : 0x00000000 (0)
                          sids                     : NULL
                  level                    : LSA_LOOKUP_NAMES_UPLEVEL_TRUSTS_ONLY2 (6)
                  count                    : *
                      count                    : 0x00000000 (0)
                  lookup_options           : LSA_LOOKUP_OPTION_SEARCH_ISOLATED_NAMES (0)
                  client_revision          : LSA_CLIENT_REVISION_2 (2)
    [2019/08/03 07:14:24.156189,  6, pid=23639, effective(967001000, 967001000), real(967001000, 0), class=rpc_srv] ../../source3/rpc_server/rpc_handles.c:339(find_policy_by_hnd_internal)
      Found policy hnd[0] [0000] 00 00 00 00 4C 00 00 00   00 00 00 00 45 5D 30 18   ....L... ....E]0.
      [0010] 57 5C 00 00                                        W\..
    [2019/08/03 07:14:24.156228,  4, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/smbd/sec_ctx.c:215(push_sec_ctx)
      push_sec_ctx(967001000, 967001000) : sec_ctx_stack_ndx = 2
    [2019/08/03 07:14:24.156246,  4, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/smbd/uid.c:552(push_conn_ctx)
      push_conn_ctx(0) : conn_ctx_stack_ndx = 0
    [2019/08/03 07:14:24.156259,  4, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/smbd/sec_ctx.c:319(set_sec_ctx_internal)
      setting sec ctx (0, 0) - sec_ctx_stack_ndx = 2
    [2019/08/03 07:14:24.156273,  5, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../libcli/security/security_token.c:53(security_token_debug)
      Security token: (NULL)
    [2019/08/03 07:14:24.156285,  5, pid=23639, effective(967001000, 967001000), real(967001000, 0)] ../../source3/auth/token_util.c:865(debug_unix_user_token)
      UNIX token of user 0
      Primary group is 0 and contains 0 supplementary groups
    [2019/08/03 07:14:24.156311,  5, pid=23639, effective(0, 0), real(0, 0), class=rpc_srv] ../../source3/rpc_server/lsa/srv_lsa_nt.c:244(lookup_lsa_sids)
      lookup_lsa_sids: looking up name XS\ab
    [2019/08/03 07:14:24.156327, 10, pid=23639, effective(0, 0), real(0, 0)] ../../source3/passdb/lookup_sid.c:112(lookup_name)
      lookup_name: XS\ab => domain=[XS], name=[ab]
    [2019/08/03 07:14:24.156340, 10, pid=23639, effective(0, 0), real(0, 0)] ../../source3/passdb/lookup_sid.c:114(lookup_name)
      lookup_name: flags = 0x00
    
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 317bc6a7342edfa2c503f5932142bf5883485cc9
Author: Alexander Bokovoy <ab at samba.org>
Date:   Thu Aug 1 21:08:52 2019 +0300

    torture/rpc/lsa: allow testing different lookup levels
    
    Convert torture/rpc/lsa LookupNames/LookupSids code to allow testing
    different LSA_LOOKUP_NAMES_* levels. Keep existing level 1
    (LSA_LOOKUP_NAMES_ALL) for the current set of tests.
    
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 2dd7ebe072acdad56f9bab8237cc9421f230f67e
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 10:26:59 2019 +0200

    smbd: Fix CID 1452293 Incorrect expression (NO_EFFECT)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Aug 14 11:48:42 UTC 2019 on sn-devel-184

commit 6c9d1f855ea3fe3d12f712678b7b4347f8982977
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Aug 1 10:58:42 2019 +1000

    ctdb-daemon: Avoid signed/unsigned comparison by casting
    
    Compiling with -Wsign-compare complains:
    
     1047 |  &&  (call->call_id == CTDB_FETCH_WITH_HEADER_FUNC)) {
          |                     ^~
    
    struct ctdb_call is a protocol element, so we can't simply change it.
    
    Found by csbuild.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Wed Aug 14 10:29:59 UTC 2019 on sn-devel-184

commit 4bdfbbd8d4fb681d509d702a8a357b11c8dddcac
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Aug 1 10:55:39 2019 +1000

    ctdb-daemon: Avoid signed/unsigned comparison by declaring as unsigned
    
    Compiling with -Wsign-compare complains:
    
    ctdb/server/ctdb_call.c:831:12: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
      831 |  if (count <= ctdb_db->statistics.hot_keys[0].count) {
          |            ^~
    
    and
    
    ctdb/server/ctdb_call.c:844:13: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
      844 |   if (count <= ctdb_db->statistics.hot_keys[i].count) {
          |             ^~
    
    Found by cs-build.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5a3d99dc7ad49717252d8c9625e0f8d064cffcd8
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Aug 1 10:46:36 2019 +1000

    ctdb-common: Return value of ctdb_queue_length() should be unsigned
    
    Compiling with -Wsign-compare complains:
    
    ctdb/server/ctdb_daemon.c: scope_hint: In function ‘daemon_queue_send’
    ctdb/server/ctdb_daemon.c:259:40: warning: comparison of integer expressions of different signedness: ‘int’ and ‘uint32_t’ {aka ‘unsigned int’} [-Wsign-compare]
    ...
    
    The struct ctdb_queue member out_queue_length is actually uint32_t, so
    just return that type.
    
    Found by csbuild.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit f7f9f57d2e13e7ced1f2237273965af8dfc29335
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jul 26 11:15:50 2019 +1000

    ctdb-tests: Use select_test_node() in ctdb setdebug simple test
    
    There is no requirement for IP addresses here.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 3ea95ab4cb70224b96a3f40fed9bb6dcc2abedf7
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jul 26 11:15:05 2019 +1000

    ctdb-tests: Add function select_test_node()
    
    Should be used when public IP addresses are not assigned.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a074dbf6454cc37ec9cda92dd897316cc27cd630
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Aug 1 16:16:31 2019 +1000

    ctdb-tools: Fix usage for "ctdb cattdb"
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 695b3a965b856b2bffa5809d4bb71b9d827c392c
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 11:52:16 2019 +1000

    ctdb-tests: Don't print summary on failure if -e option is specified
    
    If there is a failure it will always be the last test run.  Don't
    obscure this by following it with a summary.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 7c01bf3d37b1b21550ee6aabbad266acc34056a2
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 11:50:21 2019 +1000

    ctdb-tests: Drop mention of non-existent -s option
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit b3b44ae532a19348a93b16314c44b983070a78c0
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 11:48:13 2019 +1000

    ctdb-tests: Add -I <count> option for iterating tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 91e6fc209be07c13db1d85fb268d4ff56b257973
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 11:19:30 2019 +1000

    ctdb-tests: Factor out main test loop into run_tests()
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit da33fb27ab4f858689d4e93760edadd2018b9068
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 12 15:13:47 2019 +1000

    ctdb-tests: Add shellcheck test for some test scripts and includes
    
    These files now pass, so we might as well keep them in good shape.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 027b7ca0036db952d647df41e87498dc66a40054
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Aug 13 10:57:47 2019 +1000

    ctdb-tests: New variable CTDB_SCRIPTS_TESTS_BIN_DIR
    
    This can be used to find ctdb_run_tests and ctdb_local_daemons.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ba55306fce0025023e6deea637fa8eb13aa73ad2
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Aug 13 10:53:48 2019 +1000

    ctdb-tests: Rename CTDB_SCRIPTS_TESTS_BINDIR to CTDB_SCRIPTS_TESTS_LIBEXEC_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 061656d383772b27607b8feb4a4ea9c988ce17d8
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 12 22:10:41 2019 +1000

    ctdb-tests: Simplify test_wrap script
    
    Given other improvements, this is now needlessly complex.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit b1d36e94d2edbab89d7db5055b13689d94b128ad
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 10:28:52 2019 +1000

    ctdb-tests: Avoid shellcheck warning SC2045
    
    SC2045 Iterating over ls output is fragile. Use globs.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 7d95cb22a4e8638d71072e3d377076e9e01877ed
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 10:22:36 2019 +1000

    ctdb-tests: Avoid shellcheck warning SC2034
    
    SC2034 summary appears unused. Verify use (or export if used externally)
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit b198de03dce559decc25fd3ba65ee457fe6cb0ef
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 10:21:16 2019 +1000

    ctdb-tests: Avoid shellcheck warning SC2230
    
    SC2230 which is non-standard...
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 93b3b01032781b75b3d7002f05ddbe2ffc38168d
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 10:19:13 2019 +1000

    ctdb-tests: Avoid shellcheck warning SC2188
    
    SC2188 This redirection doesn't have a command...
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 45c9fe3abbf02646b68fe47dd89357bd055feb09
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 10:18:08 2019 +1000

    ctdb-tests: Avoid shellcheck warning SC2155
    
    SC2155 Declare and assign separately to avoid masking return values
    
    The wscript changes require an identical change in local_daemons.sh.
    
    While touching the lines in wscript, escape the backslashes to make
    them literal backslashes.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 664968e523c1533e0fd420d5a0961c7ae1790cff
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 10:14:22 2019 +1000

    ctdb-tests: Avoid shellcheck warning SC2004
    
    SC2004 $/${} is unnecessary on arithmetic variables
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 034f4cfab8b6690e07f5b9cfaaa5cb31ac29336e
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 10:12:23 2019 +1000

    ctdb-tests: Avoid shellcheck warning SC2164
    
    SC2164 Use 'cd ... || exit' or 'cd ... || return' in case cd fails
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 83f73b5abcef860a5a80b685337e5947c7c41b24
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 5 10:09:34 2019 +1000

    ctdb-tests: Avoid shellcheck warning SC2086
    
    SC2086 Double quote to prevent globbing and word splitting
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 758962a0d435fa595e3917b860a8fd266d122550
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 12 16:11:13 2019 +1000

    ctdb-tools: Drop 'o' option from getopts command
    
    Commit 90de5e0594b9180226b9a13293afe31f18576b3d remove the processing
    for this option but forgot to remove it from the getopts command.
    
    Versions of ShellCheck >= 0.4.7 warn on this, so it is worth fixing.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14086
    RN: Fix onnode test failure with ShellCheck >= 0.4.7
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit dee721af72ec68f45c7a230ea0c1a0a3ebe1c7f6
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 08:41:03 2019 +0200

    torture: Fix CID 1452288 Null pointer dereferences  (NULL_RETURNS)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Aug 14 08:59:23 UTC 2019 on sn-devel-184

commit 77ae0429c91c03163eaf7545888a7ca7d76ace11
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 08:39:10 2019 +0200

    lib: CID 1452289: API usage errors  (USE_AFTER_FREE)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f1b749eebda720ecf97ed6016faeba7116e99996
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 08:37:00 2019 +0200

    smbd: Fix CID 1452290 Null pointer dereferences  (REVERSE_INULL)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 02eb2c9225287ac1fed740f68e014aff52ab5fc9
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 08:36:00 2019 +0200

    smbd: Fix CID 1452291 Null pointer dereferences  (NULL_RETURNS)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a3dad84630e58d380f5c735123fba7f67ce1d180
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 14 08:34:18 2019 +0200

    librpc: Fix CID 1452292 Null pointer dereferences  (REVERSE_INULL)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f2472f48f536daa5a21ba2787c342fceb3b400d3
Author: David Disseldorp <ddiss at samba.org>
Date:   Mon Aug 12 14:35:37 2019 +0200

    s3/pdb: fix debug message typos
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Aug 13 00:42:09 UTC 2019 on sn-devel-184

commit 5e9a25ae28f465fb47f18184983cc74d75e15353
Author: David Disseldorp <ddiss at samba.org>
Date:   Mon Aug 12 14:32:47 2019 +0200

    ctdb/doc: fix some double-word typos
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c3ba556f52b15dd80efc26e4fb8f43ce2ee3a7f0
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 31 15:44:24 2019 +0200

    libcli:auth: Use generate_secret_buffer() for netlogon challenge
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Aug 12 10:42:35 UTC 2019 on sn-devel-184

commit a21770cfdffd2a21045a1bc87e489af0f4c6f130
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 31 15:42:26 2019 +0200

    s4:rpc_server: Use generate_secret_buffer() for netlogon challange
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5a62056b4530e4c509444be9164a1fca1dce193f
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 31 15:41:29 2019 +0200

    s4:rpc_server: Use generate_secret_buffer() for backupkey wap_key
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4b2480518bd3887be3a6cfb713523ac084e09fd5
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 31 15:40:12 2019 +0200

    s4:rpc_server: Use generate_secret_buffer() to create a session key
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit bf52ab7d2982de84a68a1b9c6d2f68250b7e7cca
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 31 15:38:50 2019 +0200

    lib:util: Add better documentation for generate_secret_buffer()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2b2df6cd398c9cb62989710f9b1642665ec89406
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 31 15:28:34 2019 +0200

    s3:smbd: Use generate_nonce_buffer() for AES-CCM and AES-GCM nonce
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b2506f2407429efb40c3e4e4c360f5817ac13d27
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 31 15:25:35 2019 +0200

    libcli:smb: Use generate_nonce_buffer() for AES-CCM and AES-GCM nonce
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 70ff216935acc099b762b527033b6191ba3307d0
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 31 15:16:37 2019 +0200

    lib:util: Add generate_nonce_buffer()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e6b7d782020e86fc8e28438c969a2e9e1da288f1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:32:41 2019 -0700

    s3: VFS: vfs_snapper: Make setxattr return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Mon Aug 12 01:18:45 UTC 2019 on sn-devel-184

commit 3beffd18adddbf7f4c1e01e68440a760e866183f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:31:38 2019 -0700

    s3: VFS: vfs_snapper: Make removexattr return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 5d791718532502ce1ec79aaaaccd2a9b129f73a5
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:30:19 2019 -0700

    s3: VFS: vfs_snapper: Make chflags return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 2022338b7f9d6e44c43f3d8c4280cfcca346514c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:29:23 2019 -0700

    s3: VFS: vfs_snapper: Make rmdir return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 6539d3be92f044174b862e6cbb04b5ca47651ff4
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:27:25 2019 -0700

    s3: VFS: vfs_snapper: Make mkdir return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit f5dbda6f32771afbd44db6dc0d865d3c221b22b4
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:26:20 2019 -0700

    s3: VFS: vfs_snapper: Make mknod return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 78b3784f3ffd1c76a4a41f95cbcc6fe4c68b012f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:25:14 2019 -0700

    s3: VFS: vfs_snapper: Make ntimes return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 872cd6fbda959936d6b0c3b3e403377837c3abba
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:24:11 2019 -0700

    s3: VFS: vfs_snapper: Make chown return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 8eb79cd0524e4a9792017ca7999085b5cd6f01c4
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:19:31 2019 -0700

    s3: VFS: vfs_snapper: Make chmod return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 0b64e84c01a36302a2298c1d1af4c7f4c41ed6eb
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Aug 9 10:07:04 2019 -0700

    s3: VFS: vfs_snapper: Make unlink return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 9f193b747f399f7d8be42a198f81b0cafa67341d
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 5 10:58:53 2019 +0200

    loadparm: fix mem leak found by ASAN
    
    ==24948==ERROR: LeakSanitizer: detected memory leaks
    
    Indirect leak of 232 byte(s) in 1 object(s) allocated from:
        #0 0x7fc44b971c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
        #1 0x7fc44a2fe7b0 in __talloc_with_prefix ../../lib/talloc/talloc.c:782
        #2 0x7fc44a2fe7b0 in __talloc ../../lib/talloc/talloc.c:824
        #3 0x7fc44a2fe7b0 in _talloc_named_const ../../lib/talloc/talloc.c:981
        #4 0x7fc44a2fe7b0 in _talloc_array ../../lib/talloc/talloc.c:2764
        #5 0x7fc44a1239bc in str_list_make_v3 ../../lib/util/util_strlist_v3.c:58
        #6 0x7fc44a123e3b in str_list_make_v3_const ../../lib/util/util_strlist_v3.c:127
        #7 0x7fc44b14cc1a in init_globals ../../source3/param/loadparm.c:547
        #8 0x7fc44b14deef in lp_load_ex ../../source3/param/loadparm.c:3876
        #9 0x7fc44b14f97c in lp_load_initial_only ../../source3/param/loadparm.c:4025
        #10 0x7fc44b479235 in cmdline_messaging_context ../../source3/lib/cmdline_contexts.c:34
        #11 0x557cf59d642c in process_options ../../source3/utils/smbpasswd.c:200
        #12 0x557cf59d642c in main ../../source3/utils/smbpasswd.c:633
        #13 0x7fc4419f5412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sat Aug 10 20:42:39 UTC 2019 on sn-devel-184

commit dbf26d7e0c9b46ff3b8da7af0d51080bbf17a9d6
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 5 11:15:59 2019 +0200

    torture: fix mem leak found by ASAN (smb2_scan)
    
    Direct leak of 96 byte(s) in 1 object(s) allocated from:
        #0 0x7f63e6938c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
        #1 0x7f63e615fa5c in __talloc_with_prefix ../../lib/talloc/talloc.c:782
        #2 0x7f63e615fa5c in __talloc ../../lib/talloc/talloc.c:824
        #3 0x7f63e615fa5c in _talloc_named_const ../../lib/talloc/talloc.c:981
        #4 0x7f63e615fa5c in talloc_named_const ../../lib/talloc/talloc.c:1748
        #5 0x55609e7530cf in torture_smb2_scan ../../source4/torture/smb2/scan.c:203
        #6 0x7f63e2a37772 in wrap_simple_test ../../lib/torture/torture.c:633
        #7 0x7f63e2a3b75e in internal_torture_run_test ../../lib/torture/torture.c:442
        #8 0x7f63e2a3c543 in torture_run_tcase_restricted ../../lib/torture/torture.c:507
        #9 0x7f63e2a3cdd5 in torture_run_suite_restricted ../../lib/torture/torture.c:357
        #10 0x7f63e2a3cf25 in torture_run_suite_restricted ../../lib/torture/torture.c:362
        #11 0x7f63e2a3d434 in torture_run_suite ../../lib/torture/torture.c:339
        #12 0x55609e3a154a in run_matching ../../source4/torture/smbtorture.c:93
        #13 0x55609e3a2f56 in torture_run_named_tests ../../source4/torture/smbtorture.c:143
        #14 0x55609e3a699d in main ../../source4/torture/smbtorture.c:691
        #15 0x7f63dad59412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1610476860576effa3c05fc10c753c6183f6d9e9
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Aug 5 11:07:53 2019 +0200

    torture: fix mem leak found by ASAN
    
    ==14507==ERROR: LeakSanitizer: detected memory leaks
    
    Direct leak of 112 byte(s) in 1 object(s) allocated from:
        #0 0x7f3c76fe5c08 in __interceptor_malloc (/lib64/libasan.so.5+0xefc08)
        #1 0x7f3c7680df33 in __talloc_with_prefix ../../lib/talloc/talloc.c:782
        #2 0x7f3c7680df33 in __talloc ../../lib/talloc/talloc.c:824
        #3 0x7f3c7680df33 in _talloc_named_const ../../lib/talloc/talloc.c:981
        #4 0x7f3c7680df33 in _talloc_zero ../../lib/talloc/talloc.c:2422
        #5 0x7f3c7680e2a5 in _talloc_zero_array ../../lib/talloc/talloc.c:2775
        #6 0x557a50d4a09f in torture_bench_treeconnect ../../source4/torture/raw/tconrate.c:165
        #7 0x7f3c730e4772 in wrap_simple_test ../../lib/torture/torture.c:633
        #8 0x7f3c730e875e in internal_torture_run_test ../../lib/torture/torture.c:442
        #9 0x7f3c730e9543 in torture_run_tcase_restricted ../../lib/torture/torture.c:507
        #10 0x7f3c730e9dd5 in torture_run_suite_restricted ../../lib/torture/torture.c:357
        #11 0x7f3c730ea434 in torture_run_suite ../../lib/torture/torture.c:339
        #12 0x557a50c1b54a in run_matching ../../source4/torture/smbtorture.c:93
        #13 0x557a50c1cf56 in torture_run_named_tests ../../source4/torture/smbtorture.c:143
        #14 0x557a50c2099d in main ../../source4/torture/smbtorture.c:691
        #15 0x7f3c6b406412 in __libc_start_main (/lib64/libc.so.6+0x24412)
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 99b4791cfe423b19f1f21d5f9fb42157336019f1
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Wed Jul 31 10:27:37 2019 +0200

    ldb: Fix mem-leak if talloc_realloc fails
    
    In case of a failing talloc_realloc(), the only reference
    to the originally allocated memory is overwritten.
    Instead use a temp var until success is verified.
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5eb4d705396faa5e5de90aaa86f7115b0f005589
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Aug 8 08:18:55 2019 +0200

    gitlab-ci: Install compat-gnutls34 on CentOS7
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b81cb04d03d57b8175d862ba48ac476fedf23636
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Aug 8 13:14:45 2019 +0200

    s3:modules: Link vfs_acl_common against gnutls
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 6bf6cb1643ae5e8fff66a7cbec50f58ede632666
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Aug 8 11:57:02 2019 +0200

    libcli:smb: Add forward declaration for gnutls_hmac_hd_t
    
    This file is basically included everywhere. So use a forward declaration
    for gnutls_hmac_hd_t. This way we don't have to link everthing against
    gnutls to get access to the header path.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fe26ff6e911f835808ac3f465822f86260407020
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 24 17:39:59 2019 +0200

    smbd: Simplify fd_open_atomic()
    
    * Assign *file_created on every exit.
    
    * Directly assign curr_flags without &= / |=
    
    Both of these changes make the routine easier to understand for me,
    less jumping around in the code to see where the values came from.
    
    * Do the retry in a "positive" if-clause
    
    Normally I'm a big fan of early returns, but this single retry is so
    simple that to me it's easier to understand this way.
    
    Overall, 13 lines less code. YMMV :-)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sat Aug 10 00:07:28 UTC 2019 on sn-devel-184

commit 16b56549d2ca6aad68467116ca08829c1144a41b
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 24 15:48:50 2019 +0200

    smbd: FTRUNCATE regular files only
    
    I don't really have a test case, but to me a positive test for a
    regular file makes more sense here than just ruling out FIFOs. While
    we probably only ever hit regular files (or FIFOs), there might be
    more that we catch and don't properly handle.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2c20954af5d55ed3537de7d3b22340c8305ad1a3
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 7 22:00:11 2019 +0200

    smbd: Make "lease" const in SMB_VFS_CREATE_FILE()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c2a779f50e8694f20fb06b6e05bc24678d47b7d6
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 7 21:41:22 2019 +0200

    smbd: Make "lease" const in create_file_default()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 665e3f022f215ea7dcaabedee950be134039cd7a
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 7 21:37:31 2019 +0200

    smbd: Make "lease" const in create_file_unixpath()
    
    This is the one place where *lease actually got modified. We can
    easily make a copy, "struct smb2_lease" is not too large, and this
    case is pretty rare anyway.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bfa604541edeea4aa91c81f510716d5bb476a3f7
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 7 21:36:25 2019 +0200

    smbd: Make "lease_key" const in lease_match()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 91b479fb6cf7bc7bc2287e8f5cd835e4b1894458
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 7 21:30:56 2019 +0200

    smbd: Make "lease" const in open_file_ntcreate()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d2aaef2e9c90b35e52369e8f229591b06c75bb27
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 7 21:29:14 2019 +0200

    smbd: Make "lease" const in grant_fsp_oplock_type()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e2572242986903b1d7e8468dc9528ba4a74ea6bc
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Aug 7 21:27:42 2019 +0200

    smbd: Nobody uses the changed "lease" from grant_fsp_oplock_type
    
    .. except for the DEBUG message
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 64e594e5dc774cc51ec0bdf9b1c5537c4b66e8ce
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:59:15 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make setxattr return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Aug  9 18:08:03 UTC 2019 on sn-devel-184

commit a7921ded299d138430ab9b37c3f1e1e064f6b3fa
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:58:10 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make removexattr return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 0ebb15a6e236bf920ee9ff901b81b264212c4c37
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:56:59 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make chflags return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit b3a5c50a51a610957a671a2f42bb4269eb8039e2
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:56:01 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make rmdir return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 9c2c941492a363a96482fe17cfafff1494586b31
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:55:04 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make mkdir return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 5b1f545589e0027e53d56058cbaaaa8c97eaf35d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:53:51 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make mknod return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit eac2ca755f5d09483465732e51ec5b51072628b2
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:52:14 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make ntimes return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit d1d3d8f37021bc18d30c8c97f99f1e0d28fdd646
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:48:54 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make chown return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit a5af9ac8288af1e8cd3ca080eb966d0b9ff34dc2
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:47:44 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make chmod return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 9f457799a92c34bf8c881142b308a37648bea943
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 8 15:45:10 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Make unlink return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 76bf8a1ac438056691fef667bf214f9fe7bafe14
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 9 08:02:41 2019 +0200

    mdssvc: Fix the clang build
    
    clang complains about "%lu" not to match size_t on 32-bit FreeBSD
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Fri Aug  9 07:34:05 UTC 2019 on sn-devel-184

commit 64f182412a5b7bdb1f8eccffaee296e7c8554a95
Author: Ralph Boehme <slow at samba.org>
Date:   Mon May 6 14:19:31 2019 +0200

    s3:mdssvc: fix slrpc_fetch_attributes() when CNID is not known
    
    Samba currenlty fails the whole RPC request, macOS returns returns a nil entry
    for the requested CNID:
    
    DALLOC_CTX(#1): {
    	sl_array_t(#3): {
    		uint64_t: 0x0000
    		CNIDs: unkn1: 0xfec, unkn2: 0x6b000020
    			DALLOC_CTX(#1): {
    				uint64_t: 0xe4bbf314c03b1e
    			}
    		sl_filemeta_t(#1): {
    			sl_array_t(#2): {
    				nil
    				nil
    			}
    		}
    	}
    }
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Aug  8 21:43:14 UTC 2019 on sn-devel-184

commit b2bf13ecf7b5406665f27487cb892e4f15fb28c4
Author: Ralph Boehme <slow at samba.org>
Date:   Mon May 6 14:18:27 2019 +0200

    s3:mdssvc: close mdssvc rpc command must return in handle
    
    Checked against macOS mdssvc.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a5e705504bf5a9cade2e57a18b068f654fa27a32
Author: Ralph Boehme <slow at samba.org>
Date:   Mon May 6 14:14:26 2019 +0200

    s3:mdssvc: failing the RPC request if the mdssvc policy handle is not found
    
    Turns out macOS mdssvc doesn't fail the RPC request if the policy handle is all
    zero. Also, if it fails with a non-all-zero handle, it returns a different RPC
    error, namely DCERPC_NCA_S_PROTO_ERROR, not DCERPC_FAULT_CONTEXT_MISMATCH (or
    rather their mapped NT_STATUS codes).
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 63366996879fab5b1729de6d6224ca167bdb05b0
Author: Ralph Boehme <slow at samba.org>
Date:   Mon May 6 14:11:31 2019 +0200

    s3:mdssvc: the open command must work on shares with Spotlight disabled
    
    Move the implementation of this setting down to the actual search query
    processing. macOS has no notion of "spotlight = false" at the DCERPC layer and
    the open request will always succeed even on all shares.
    
    When later the client issues search requests on such shares, we ensure we use
    the noindex backend.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 520175e2275abfabfdb5a62e192c4936a6c74d35
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 16 19:32:52 2019 +0200

    s3:mdssvc: use an early return if spotlight is not enabled.
    
    No change in behaviour, best viewed with git show -w.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 68a9d1205e54d2f447baad5481ff20dfb184dfe6
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Apr 17 07:38:53 2019 +0200

    s3:mdssvc: update a few debug macros to modern style
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 940c3b31dd1fd68c9d7c9f4e9989d725dc77af4a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon May 6 14:07:53 2019 +0200

    s3:mdssvv: don't fail the RPC request if the share name is unknown
    
    Taken from macOS. We have to return an empty share_path and an empty policy
    handle, but not fail the RPC request.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fef3a4c75f9cad1a81201257f0208b241a93f6c9
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 16 19:25:09 2019 +0200

    s3:mdssvc: initialize the returned share_path with the empty string
    
    macOS returns the empty path for an unknown share. This paves the way for that
    change. Currently we still fail the RPC request if the share is not known with
    DCERPC_FAULT_CANT_PERFORM, but this is wrong and is going to be changed in the
    next commit.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c4b2dc95d5dfb4e875ea58ff6568b89dacf8b916
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 16 19:23:25 2019 +0200

    s3:mdssvc: macOS returns the client values in the open command
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a3cb4fca864b6e872f453d60b5e58591da3624b1
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 16 19:14:39 2019 +0200

    s3:mdssvc: macOS returns UINT64_MAX, not 0 for closeQueryForContext mdscmd
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5750f38ca7834254268a93193d72184d03990c1b
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 16 14:17:11 2019 +0200

    s3:mdssvc: fix error handling of mdssvc RPC requests
    
    It seems for certain error cases macOS just sends an empty response
    blob. So if our mdssvc request processing fails, we should just return an empty
    response blob, but not fail the mdssvc request at the DCERPC layer.
    
    Example, passing "xxx" as sharename which does not exist at the server:
    
      $ bin/rpcclient -U slow%pass macmini -c "fetch_attributes xxx /foo/bar 123" -d 10
      ....
      Got pdu len 56, data_len 32
      rpc_api_pipe: got frag len of 56 at offset 0: NT_STATUS_OK
      rpc_api_pipe: host macmini returned 32 bytes.
      mdssvc_cmd: struct mdssvc_cmd
         out: struct mdssvc_cmd
             fragment                 : *
                 fragment                 : 0x00000000 (0)
             response_blob            : *
                 response_blob: struct mdssvc_blob
                     length                   : 0x00000000 (0)
                     size                     : 0x00010000 (65536)
                     spotlight_blob           : *
                         spotlight_blob: ARRAY(0)
             unkn9                    : *
                 unkn9                    : 0x00000000 (0)
      ...
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 017af5d583175ff9f15c64fa7cc631eb4512367b
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 16 16:54:21 2019 +0200

    torture: beginning of a mdssvc RPC service test-suite
    
    Yikes! Most tests fail atm.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b45a09f0e1ada1b5fa4a16fb652871f9ae973e2e
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Mar 8 07:57:57 2015 +0100

    rpcclient: add some simple commands for Spotlight RPC
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2cb978b6498c42947377a50fa8a5748f596d9114
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 16 16:07:13 2018 +0100

    rpcclient: domain_sid is only needed for SAMR
    
    This allows using rpcclient commands with servers that don't implement LSA
    QueryInfoPolicy.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4162ba78f8146ad9b39d0749a36fab674197c78e
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 16 16:46:43 2019 +0200

    lib:torture: add torture_assert_u32_[not_]equal[_goto] macros
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b34fd5b9978904ef0b316ba11564691fdac5316c
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Aug 7 14:02:12 2019 +0200

    s3:mdssvc: fix unmarshalling of empty CNID array
    
    len=0 is invalid, len=8 is an empty array, len>8 is an array with members, so
    for the len=8 case we must add the empty cnid array.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 29ef0306241da38356ffa1ee927e1b343564426e
Author: Ralph Boehme <slow at samba.org>
Date:   Fri May 3 22:52:33 2019 +0200

    s3:mdssvc: marshalling: fix unpacking empty CNID structure
    
    Pass the correct tag member tag.size to sl_unpack_CNID(), not
    tag.length. tag.size is the size actually used in a buffer of size tag.length.
    
    Cf other users of tag.size that already do this correctly, this was only wrong
    in this place.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d67c98184a176805c0406ea4d6d56bcde78bb26d
Author: Ralph Boehme <slow at samba.org>
Date:   Fri May 3 22:52:56 2019 +0200

    s3:mdssvc: marshalling: fix unpacking empty filemeta structure
    
    This is how a correct dump of an empty sl_filemeta_t container should look like:
    
    DALLOC_CTX(#1): {
    	sl_array_t(#3): {
    		uint64_t: 0x0023
    		CNIDs: unkn1: 0x0, unkn2: 0x0
    			DALLOC_CTX(#0): {
    			}
    		sl_filemeta_t(#0): {
    		}
    	}
    }
    
    This is basically the response from macOS mdssvc for a query that yields no
    results: sl_filemeta_t is empty, the CNIDs array as well.
    
    Looking at the raw packet data, the empty sl_filemeta_t container as a size of 8
    bytes which fails the following check in sl_unpack_cpx():
    
            case SQ_CPX_TYPE_FILEMETA:
                    ...
    		if (tag.size < 16) {
    		        *boom*
                    }
    
    Only tag.size=0 is invalid, tag.size=8 denotes an empty container and tag.size>=16
    denotes a sl_filemeta_t container with actual content must be unpacked by
    calling sl_unpack(). Note that size is always a muliple of 8.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ed37f2d3c478da34dd9b80171ec603be3c23e37b
Author: Ralph Boehme <slow at samba.org>
Date:   Sat May 4 11:10:37 2019 +0200

    s3:mdssvc: marshalling: add a newline to a DEBUG message
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c282d76d556ae3744cae3f113afeda746b93949f
Author: Ralph Boehme <slow at samba.org>
Date:   Sat May 4 08:53:48 2019 +0200

    torture: start of a mdssvc packet (un)marshalling testsuite
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9d6794df728d772e6bae611f782d70ed97e5c5aa
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jul 15 16:44:08 2019 +0200

    librpc: add RPC_NDR_MDSSVC
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 12ef7b38437f4a4211fa3dce3e3c1e76a3d3df78
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Apr 17 16:42:20 2019 +0200

    s3:wscript: enable Spotlight by default
    
    Now that we have a no-op backend that is always available, we can compile mdssvc
    by default.
    
    The new behaviour is:
    
    option not used       Default: build mdsvc with available backends
                          from autodetection
    --disable-spotlight   Do not build mdssvc
    --enable-spotlight    Build mdssvc and require a real backend
    		      (currently Tracker, in the future also Elasticsearch)
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 25c5012c53f4d8efbe04ee8d3c8af256fec592a7
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 30 15:39:38 2019 +0200

    s3:mdssvc: avoid strncpy when marshalling strings
    
    Avoids failure when at O3 level:
    
      [2082/4232] Compiling source3/rpc_server/mdssvc/marshalling.c
    
      ==> /builds/samba-team/devel/samba/samba-o3.stderr <==
      In file included from /usr/include/string.h:494,
                       from /usr/include/bsd/string.h:30,
                       from ../../lib/tevent/../replace/replace.h:164,
                       from ../../source3/include/includes.h:23,
                       from ../../source3/rpc_server/mdssvc/marshalling.c:21:
      In function ‘strncpy’,
          inlined from ‘sl_pack_string’ at ../../source3/rpc_server/mdssvc/marshalling.c:493:2,
          inlined from ‘sl_pack_loop’ at ../../source3/rpc_server/mdssvc/marshalling.c:607:13:
      /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ output
      truncated before terminating nul copying as many bytes from a string as its
      length [-Werror=stringop-truncation]
        106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
            |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      ../../source3/rpc_server/mdssvc/marshalling.c: In function ‘sl_pack_loop’:
      ../../source3/rpc_server/mdssvc/marshalling.c:458:8: note: length computed here
        458 |  len = strlen(s);
            |        ^~~~~~~~~
      cc1: all warnings being treated as errors
    
    Marshalled strings are not 0 terminated.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9e706ee5737bffd6f0a699ce68a75bbd0f7fd7dd
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Apr 21 08:38:23 2019 +0200

    unittest: workaround dependency problem in test_lib_util_modules
    
    waf somehow screws the dependencies and the module ends up with a bunch of
    missing RPC related symbols once an RPC service has special dependencies like
    the mdssvc RPC service.
    
      $ bin/test_lib_util_modules
      test: test_samba_module_probe
      success: test_samba_module_probe
      test: test_samba_module_probe_dummy
      Error loading module '/home/samba/src/bin/modules/rpc/test_dummy_module.so':
      /home/samba/src/bin/modules/rpc/test_dummy_module.so: undefined symbol:
      rpc_service_mode
      failure: test_samba_module_probe_dummy [
      NT_STATUS_IS_OK(status)
      ../../testsuite/unittests/test_lib_util_modules.c:39: error: Failure!
      ]
      test: test_samba_module_probe_slash
      success: test_samba_module_probe_slash
    
    This is currently not noticed as mdssvc is not enabled in selftest, but that is
    going to change with a subsequent commit.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0b1d9d40c249ca7f893cbcc54587ae8fc93f15ee
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 16 14:04:16 2019 +0200

    s3:mdssvc: supposed status field is in fact a fragment indicator
    
    Spotted this in mdssvc response that containied many results for a search
    request: if the mdssvc response blob is larger then ~32k, the server fragments
    the response in 32k fragments and sets the "fragment" field to 1.
    
    Note that mdssvc implemenets result set "fragmentation" at the result set layer,
    not at the marshalled response buffer layer. Therefor mdssvc always sets this
    field to 0.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c742ab7a4c78db4101499d15ada1a6635d5cc35b
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Apr 17 11:00:52 2019 +0200

    s3:mdssvc: add noindex backend
    
    Add a new default backend that, while allowing mdsvc RPC and search queries from
    clients, always returns no results.
    
    Shares using this backend will behave the same way as shares on a macOS SMB
    server where indexing is disabled.
    
    This change will later also allow us to compile the Spotlight RPC service by
    default which is a big step in the direction of adding tests to CI.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e5a4114bb563b1ebf8ce7cad2a335bf24dbbdd32
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 16 11:24:02 2019 +0200

    s3:mdssvc: log inode number in ino_path_map_destr_cb()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2d98fb57e05ebe16c3a3d8256281830435320607
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Mar 8 08:01:06 2015 +0100

    s3:mdssvc: move some code to a subsystem
    
    We need this in a later patchset when adding a mdssvc client library and for
    unit tests.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f58026b30b2bf9d60222d39947d07ee858ee5756
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 16 14:24:35 2018 +0100

    s3:mdssvc: mds_dalloc_dump() -> dalloc_dump()
    
    Move mds_dalloc_dump() to dalloc and rename it to dalloc_dump().
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b5731a94bbc95fa001059d488a2c16a988127619
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 9 11:19:43 2019 +0200

    s3:mdssvc: add Unicode normalisation
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1b897df4f7489c6ac7663ca4830dc4c129dd2457
Author: Ralph Boehme <slow at samba.org>
Date:   Mon May 6 15:03:02 2019 +0200

    s3:mdssvc: new option "spotlight backend"
    
    Currently there's only the tracker backend, but subsequent commits will add
    other backends.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 66b8d86d71551ab8c615428211294ca110608645
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Apr 12 12:15:56 2019 +0200

    s3:mdssvc: pass down sharename and SNUM
    
    Not used for now, will be needed in the upcoming Elasticsearch backend.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1ef96e09071458322845b4323fa59cf4e7475783
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Mar 14 07:38:20 2019 +0100

    s3-mdssvc: factor out Tracker backend logic
    
    This moves all Tracker backend logic into a modularized component.
    
    This should not result in any change in behaviour, it just paves the way
    for adding additional backends. Currently the only available backend is
    Gnome Tracker.
    
    slq_destroy_send/recv is not needed anymore as the problem is solved now by
    correctly checking if an async Tracker request was cancelled and we got
    G_IO_ERROR_CANCELLED in tracker_con_cb() or tracker_query_cb() and avoid using
    user_data in that the case.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f80f8c5f99f6b5949d14ee62261a7dd448e9b0fe
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Aug 7 11:59:39 2019 +0200

    s3:mdssvc: move debug macro to header file
    
    This is going to be used from other parts of the code soon.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 17f29fa86772a3fe9c03ecee6813c377d85dde6c
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Aug 7 11:55:44 2019 +0200

    s3:mdssvc: README.Coding fixes, long lines, modernize debug macros
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9e0b6f667f055ab74389759471c0b7181aaf4973
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Mar 13 15:42:51 2019 +0100

    s3:rpc_server: factor out rpc_mdssvc_sources
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3bf915846f77d7df451728d115eaa25613532063
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Jul 29 15:46:15 2019 +0200

    tfork: Free memory in torture test to satisfy sanitizer
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Aug  8 11:33:32 UTC 2019 on sn-devel-184

commit f9a32767b690532ed897730e8179dcc84473d148
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Jul 29 14:55:10 2019 +0200

    ldb: Free memory in torture test to satisfy sanitizer
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit 84e519f36559f783af7e1143175ae6b316bd1e75
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Jul 29 10:47:20 2019 +0200

    util: Free memory in charset torture test to satisfy sanitizer
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit bb8cc5956f7bac9afedcba2744d691b2d8485b62
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Jul 29 10:23:14 2019 +0200

    ndr: Free memory in torture test to satisfy sanitizer
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit 235288acaedf39ea386121347343d56df3d1d858
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Jul 29 10:00:26 2019 +0200

    util: Free memory in genrand torture test to satisfy sanitizer
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit d167fb40899c8b2f9919455f40e95e00adc8e1e9
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Jul 29 09:50:24 2019 +0200

    ldb: Fix mem allocation in torture test to satisfy sanitizer
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit a16477e6e62b5525f6d8ddc297da2ec1ac176acc
Author: Swen Schillig <swen at linux.ibm.com>
Date:   Mon Jul 29 15:27:58 2019 +0200

    registry: Free memory at the end of each loop run to prevent mem leak
    
    Found during torture test runs with enable address-sanitizer.
    
    Signed-off-by: Swen Schillig <swen at linux.ibm.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Aug  8 06:44:12 UTC 2019 on sn-devel-184

commit 897c36f2cb7de561394ab15e8134fb6e5b91ae63
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 1 14:47:41 2019 +0200

    torture: SMB1 unlink needs delay for a stream's SHARING_VIOLATION
    
    Survives against W2k12R2
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Aug  8 01:05:38 UTC 2019 on sn-devel-184

commit 4c08043ee54350c7c66a963882d4e14c24472986
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 14:54:40 2019 +0200

    smbd: Move handling the 1sec sharing_violation delay into smb1 code
    
    Simplify the flow in open_file_ntcreate, streamline it for SMB2
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c7e110e51afea9a36a060bff62506c53e86c8aab
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 14:54:18 2019 +0200

    smbd: Add defer_sharing_violation_smb1
    
    This is close to what Windows SMB1 does: Instead of waiting for the
    share entry causing the SHARING_VIOLATION to disappear, retry every
    200msec up to one second. Windows does it a little differently: Retry
    up to 5 times. But up to one second should be close enough.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 305ea37c81c2eeafb0ae259d4bd319af183a4611
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 2 11:54:11 2019 +0200

    smbd: Get "req->request_time" early in create_file_default()
    
    This is necessary for the following case:
    
    We want to delete a file with an open stream that is not open with
    FILE_SHARE_DELETE. In SMB1, we need to defer the sharing violation
    reply (we don't do that right now, test to follow). However, when we
    move that sharing violation delay to where it belongs, into the outer
    layers, only very deep in the nested open_streams_for_delete smb1
    sharing violation delay handling call we will hit the sharing
    violation in the 1-second retry case. However, that
    open_streams_for_delete itself is INTERNAL_OPEN_ONLY and thus not
    deferred itself. This means that it will not overwrite
    req->request_time at all.
    
    Exec summary: We only have one request_time now, set it properly as
    early as possible.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1bc7d18b5f97d9b7e299df2107321601178aed83
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 2 14:33:22 2019 +0200

    smbd: Do not exceed the req's max timeout in setup_poll_open()
    
    This will become important in the next commits when the SMB1 sharing
    violation delay will use this. We want to be able to reduce the
    timeout to less than 200msec, see the next commits.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 50a3d08673ad5a62ff5769af429e2cc1730a1659
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 14:51:00 2019 +0200

    smbd: Make setup_poll_open() return bool
    
    This is for callers who don't want to call open_was_deferred()
    afterwards
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 832b9eb6df520b3ba9f60e8559c2bb9bef2b4ad4
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 14:00:17 2019 +0200

    smbd: Make setup_kernel_oplock_poll_open() more general
    
    This is a generic "open retry without locking.tdb waiter" loop: Take
    the specific timeouts as parameters.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 939a1097504540779343dd53fad6cdec581b0e2c
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 13:41:17 2019 +0200

    smbd: Avoid exit_server() in setup_kernel_oplock_poll_open()
    
    Failure to postpone a request is not really fatal: We just don't retry
    as wanted but return an error to the client that might have resolved
    itself after a few seconds. From my point of view such a spurious and
    rare error, which is highly unlikely anyway does not justify to kill
    that client's connection.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2c653515f39e341d7b104cef75f8109410bc90c7
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jul 26 12:09:14 2019 +0200

    smbd: Remove access check on SHARING_VIOLATION
    
    This piece of code predates our user-space access checks, which we
    nowadays always do in open_file()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 551e3590f98393879ab4c97e7fa734602d4e9f7c
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:40:43 2019 -0700

    s3: VFS: Make setxattr return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Aug  7 17:59:25 UTC 2019 on sn-devel-184

commit fc405e919d606a3cdb59d557cadeeb953534c1b5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:39:42 2019 -0700

    s3: VFS: Make removexattr return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5ed5d5445f3bc8c9a864af6f0731ba389d53a511
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:35:47 2019 -0700

    s3: VFS: Make chflags return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d81570e5fb201181134e2f601a53f49c035bdfab
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:33:27 2019 -0700

    s3: VFS: Make rmdir return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9d35f74766fb0feee7cdbc24f5ca0364ef4b62b9
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:32:32 2019 -0700

    s3: VFS: Make mkdir return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2e43661a1b907209a3ae165f1ec2b4bcb1c93ddf
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:31:01 2019 -0700

    s3: VFS: Make mknod return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 15761609ee9bf5b1276992103f3b4ebbda9c5e83
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:29:54 2019 -0700

    s3: VFS: Make ntimes return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 68330458e6e3ccc0e5a62d3fa5b99a66d02771ac
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:25:37 2019 -0700

    s3: VFS: Make chown return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e8e1b00aef923c701b122cdcc6de16a05b9915ca
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:23:48 2019 -0700

    s3: VFS: Make chmod return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2e3f644f0aa78a255df41325ea6f3bee7f733208
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 1 13:18:42 2019 -0700

    s3: VFS: Make unlink return errno = EROFS on a shadow copy path.
    
    smbd has no business modifying a shadow copy filesystem, it should be read-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 959b77988d02731c032b5fcc91f7a62fd9b96340
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Aug 6 18:21:12 2019 +0200

    s4:librpc/rpc: Use generic roh_connect_channel_send/recv
    
    The HTTP connection code is common to in and out channels.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Aug  7 14:12:40 UTC 2019 on sn-devel-184

commit 7189eb44d7f8a6514bb48645da89d7f9b148d599
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Aug 6 18:12:41 2019 +0200

    s4:librpc/rpc: Add roh_connect_channel_send/recv
    
    Generic function to connect a ROH channel. The use comes later to avoid
    duplicated code.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit fc0371b932286d4f50f8650b1e7a7132f83e565c
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 2 18:34:24 2019 +0200

    s4:lib/http: move to the toplevel
    
    This is going to be used from the s3 RPC server soon...
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at suse.de>

commit a0065c57601a16011dc1a90688a724ae8acb3377
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Apr 3 14:33:12 2019 +0200

    s4:lib/http: add support for http POST
    
    Even though GET would work as well, only adding POST, as that's the only method
    that's going to be exersized in code and tests (RPC mdssvc elasticsearch
    backend).
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at suse.de>

commit 5ae515245c235427c5d07f473cf53015701ce4e1
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 6 12:33:40 2019 +0200

    s4:lib/http: use http_conn in http_send_request_send() and http_read_response_send()
    
    Works, tested with
    
      $ bin/smbtorture -W RIVERSIDE --realm=RIVERSIDE.SITE -s /dev/null \
        -U Administrator%Passw0rd \
        ncacn_http:10.10.11.164[HttpProxy=10.10.11.164:593,HttpUseTls=false,HttpAuthOption=basic,HttpConnectOption=UseHttpProxy] \
        rpc.epmapper.epmapper.Lookup_simple
    
    I get an ACCESS_DENIED error, but I get it over HTTP. :)
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at suse.de>

commit 53007b77116c510e296995c8a0a8b836b88d7770
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Mar 28 15:36:00 2019 +0100

    s4:librpc/rpc: use http_connect_send/recv in ncacn_http
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at suse.de>

commit 94fe9afae42ee09974b8c5ab802868e703318d95
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Mar 26 15:04:28 2019 +0100

    s4:lib/http: remove stream and send_queue from state
    
    They're not used, so remove them.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at suse.de>

commit ab389bca9c6d0e1723b471eb1a2e8d38648efbc4
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Mar 26 14:53:21 2019 +0100

    s4:lib/http: move struct http_read_response_state to the implementation
    
    This is only used by the implemementation of http_send_request_send/recv, no
    need to have this in the header file.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at suse.de>

commit 3ffd74e915f579bcf759f17c32aedb0c5a9f152b
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Mar 26 14:53:21 2019 +0100

    s4:lib/http: move struct http_send_request_state to the implementation
    
    This is only used by the implemementation of http_send_request_send/recv, no
    need to have this in the header file.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at suse.de>

commit 314043828b3e3d70600f0f365caad37dbf171d1a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Mar 25 14:39:59 2019 +0100

    s4:lib/http: add http_[dis]connect_send and recv
    
    Not used for now, that comes later.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at suse.de>

commit 2a90202052558c945e02675d1331e65aeb15f9fa
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 9 13:34:39 2019 +0200

    charset: add tests for Unicode NFC <-> NFD conversion
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Aug  7 07:25:39 UTC 2019 on sn-devel-184

commit 107020793c7ea44e5e776a1401bbf4f8ccb9bd85
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 9 11:21:57 2019 +0200

    charset: add support for Unicode normalisation with libicu
    
    This adds a direct conversion hook using libicu to perform NFC <-> NFD
    conversion on UTF8 strings. The defined charset strings are "UTF8-NFC" and
    "UTF8-NFD", to convert from one to the other the caller calls smb_iconv_open()
    with the desired source and target charsets, eg
    
      smb_iconv_open("UTF8-NFD", "UTF8-NFC");
    
    for converting from NFC to NFD.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 323f852147524b950bab4628a2824aa2273cb577
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Apr 23 16:47:45 2019 +0200

    torture: add torture_assert_errno_equal_goto()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 39e2f6d59fa2e839c8ef40934790b34dbdfc8f29
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Thu Apr 4 01:10:11 2019 +0200

    Add fuzzing binary for oLschema2ldif
    
    Use the oLschema2ldif library functions introduced in commit
    0c7c44a284a26790081c000f5b8f4ed32f9f21d7 to implement a fuzzing utility.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 404278d9472c28fedc200d385667a0d2cc1c992d
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Thu Apr 4 01:03:58 2019 +0200

    Add fuzzing binary for tiniparser
    
    The "tiniparser_load" function is made into a wrapper for the newly
    added "tiniparser_load_stream" function which accepts a FILE pointer.
    This way no actual files have to be opened for fuzzing (memfd_create(2)
    isn't readily available on all systems yet).
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit dd5f8732d8b2ac6cd86e5d7dc8a9498d2b951a43
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Thu Apr 4 00:23:07 2019 +0200

    Add fuzzing support to build system
    
    LibFuzzer, Honggfuzz and other programs implement simple interfaces for
    fuzzing appropriately prepared code. Samba contains quite a lot of
    parsing code, often a good target for fuzzing.
    
    With this change the build system is amended to support building fuzzing
    binaries (added in later changes).
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit aab17124785b6e4c004368b69bee28fb6cad55c3
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 6 17:27:12 2019 +0200

    smbd: Assert that INTERNAL_OPEN_ONLY never gets real oplocks
    
    Slightly simplify assumptions in the code
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Aug  6 23:06:41 UTC 2019 on sn-devel-184

commit 5e05686e392107b0e75ca9db6a735eef90245665
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 07:20:42 2019 +0200

    smbd: Remove deferred_open_record_create()
    
    This hides a talloc off the NULL context: The caller needs to make sure
    this is put on a real talloc context later. Make that more
    obvious. Also, it passes down a boolean flag, making its purpose a bit
    opaque to the caller sites.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 718c4e27cd502ebb74da41c9911e8d752ac45922
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 07:16:12 2019 +0200

    smbd: Remove "delayed_for_oplocks" from deferred_open_record_create()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fc09be5b51fa99bacf6ad761217c9d422a8753d1
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jul 29 21:42:12 2019 +0200

    smbd: Remove "deferred_open_record->delayed_for_oplocks"
    
    Nobody used this
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 61765c7e15b52df9c18541cf8604887f2d558bde
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jul 26 19:18:37 2019 +0200

    smbd: Remove "id" from deferred_open_record_create()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 67c5034531dca175a70772eedd1489333d511fb4
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jul 26 19:16:09 2019 +0200

    smbd: Remove "deferred_open_record->id"
    
    Nobody used this
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fbc367595418dee16333f3334381a226d37d4e25
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Aug 6 10:45:27 2019 +0200

    smbd: Clean up leases.tdb if set_share_mode() fails
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6e7d28c8e03a832bd0704e7f72b25e448746c35a
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 5 18:50:08 2019 +0200

    smbd: Factor out remove_lease_if_stale()
    
    remove_lease_if_stale() does not have the check
    
    		if (e == e2) {
    			/* Not ourselves. */
    			continue;
    		}
    
    that remove_share_mode_lease() had. However, remove_share_mode_lease()
    has already set e->op_type=NO_OPLOCK, so that the
    
    		if (e->op_type != LEASE_OPLOCK) {
    			continue;
    		}
    
    statement has the same effect.
    
    Why? The next commit will need it for proper error path cleanup.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2d4e2ea24947c4d2eb647c98b36d9cebb54d434d
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 5 18:18:41 2019 +0200

    smbd: Inline remove_oplock_under_lock() into its only caller
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e28c2ee903855627bc71924a6449267725a7f75d
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 5 17:05:20 2019 +0200

    smbd: Make remove_oplock_under_lock static
    
    We have support for nested get_share_mode_lock calls, so we can avoid
    this additional function.
    
    It's one more talloc/free per close, but I hope this can't be
    measurable. Our open/close path is pretty expensive anyway.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e4d5c53e8083406552f361d2df27528d1c2ea061
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 5 14:59:18 2019 +0200

    smbd: Slightly simplify set_share_mode()
    
    The fsp carries all required information also for leases. There's no
    need to pass that as additional parameters
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3851062916cbee2114f6aa5154cdc89425724d87
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Aug 5 14:57:28 2019 +0200

    smbd: Move fsp_client_guid() to locking/
    
    Yes, this adds another peek from locking/ back into smbd/proto.h, but
    locking/locking.c does the same already.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e94ebc705542ffca536d15e28fc99e023f4748bc
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jul 26 16:20:17 2019 +0200

    smbd: Slightly optimize reply_open_and_X()
    
    Well, this is just a drive-by patch: We don't use "mtime" if we
    exit early. So it's not really a worthwhile optimization, to me
    it's more a code clarity thing.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ef0cf081603b4f23c7fcdbde1ac6be7b7fd58a48
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 16:22:51 2019 +0200

    smbd: Remove "share_access" from fcb_or_dos_open()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c56be509f1f7957057243047470f7bbf26186b2c
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 16:20:04 2019 +0200

    smbd: Remove "share_access" from dup_file_fsp()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 13921645c4856ddc325a0f8c8a64d0bbecab119d
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 16:15:46 2019 +0200

    smbd: Remove "share_access" from files_struct
    
    Nobody used this (except vfs_gpfs, which did not need it really). If
    you *really* need this, you can always look in locking.tdb, but this
    should never happen in any hot code path, as no runtime decisions are
    made on the share access after the open is done.
    
    Bump VFS interface number to 42.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 81731c91414fdf32b150e6be120741dc3a3fdde3
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 14:50:35 2019 +0200

    vfs_gpfs: Avoid "fsp->share_access" in vfs_gpfs_kernel_flock()
    
    This was in vfs_gpfs.c from day one, no idea why both "share_mode" and
    "fsp->share_access" were used as if they were two different things.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 71c6da46eee4acc245bd326865f84336f457f538
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 16:08:35 2019 +0200

    smbd: Pass share_access/access_mask explicitly to grant_fsp_oplock_type()
    
    Why? While restructuring open_file_ntcreate() I found the data flow for
    these values confusing: grant_fsp_oplock_type() depends on
    fsp->access_mask, which changes its value inside
    open_file_ntcreate(). I find the data flow easier to follow if it
    happens in explicit variables.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 41ab2b8ec5d398ef6187562c7620c359837f3899
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 15:01:37 2019 +0200

    smbd: Pass share_access/access_mask explicitly to set_share_mode()
    
    Makes the interface more obvious to me. Also, I want to remove
    fsp->share_access, which is not really used anywhere after the fsp has
    been fully established.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1d9970735ced7adae24f4926a4eeed902d132426
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jul 26 16:28:39 2019 +0200

    smbd: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a7d4d5effa5e3e6c2e09e16ad1ce303e31b61544
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 23 17:46:22 2019 +0200

    smbd: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 303c4829e1c28a889293aad312ea50d380fbd043
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Aug 2 12:02:24 2019 +0200

    smbd: Enhance debugging in push_deferred_open_message_smb()
    
    Real timestamps are easier to read
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 88768fdecdf4aea12a8a0edfdbe22345ff05be20
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 1 13:24:49 2019 +0200

    smbd: Use timeval_str_buf() in defer_open()
    
    Also make this a hires timestamp for better debugging.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit aedfee8f49b643ae7d1ee4f0bc53f2a835652f30
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 07:10:28 2019 +0200

    smbd: Fix a signed/unsigned warning
    
    For whatever reason, "st_size" in "struct stat" is an off_t, which is a
    signed integer. Negative sizes don't really make sense, so this cast
    should be safe.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2181221d6f06b3285a57bcf57ef263770ef0ccb0
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 06:55:45 2019 +0200

    smbd: Fix a signed/unsigned comparison
    
    In the 2nd for-loop we need a signed int as we are comparing to >=0.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4c6f12c3239c926a34e6b93fa6d0ec167a62c63d
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 12:04:49 2019 +0200

    smbd: Remove a false comment
    
    Looking at the code we do respect the kernel_flock failure.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit df1caf29fbb745927f94a26598ee8e01ba8d9807
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 11:39:19 2019 +0200

    torture3: Don't duplicate set_blocking()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e049ef3e787d8e7939b70d67a167766e89a04083
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jul 25 11:38:36 2019 +0200

    lib: Remove a duplicate prototype for set_blocking()
    
    This is now in lib/util/blocking.h
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 04dcae23ab47a31a7348f0246cc2cf434d4e5fc6
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 12:19:24 2019 +0200

    build: Only check rpc/xdr.h in tirpc if required
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 42e72f1a30db9090d53669ca68cc71bbe784758d
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 12:18:42 2019 +0200

    vfs: Fix the nfs4acl build on FreeBSD
    
    FreeBSD needs rpc/types.h before rpc/xdr.h
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d2d4e03b962d22875d6a3b170880c588fdc2688b
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 12:14:03 2019 +0200

    build: Correctly detect rpc/xdr.h on FreeBSD
    
    FreeBSD needs rpc/types.h included before rpc/xdr.h
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9bae499da78b7978a8145bd6c3499d047b1afe68
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 11:45:31 2019 +0200

    wscript: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a8e034794beaed00205ba198cbb77c5705767eb1
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 11:40:20 2019 +0200

    winbind: Fix the clang build
    
    clang complains that lm_resp and nt_resp is used uninitialized. This
    is true for the "goto done;" in line 2644. This directly calls
    log_authentication without having initialized those two blobs.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d103af280afd29d633b1958620e7b3beddfd6087
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 11:37:59 2019 +0200

    vfs: Fix the FreeBSD nfs4acl build
    
    I get error messages telling SMB4ACL_T isn't defined in the
    prototype. Take the easy way to just define that anonymously.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d8ae28115200196546ace109e338b55a7ae72a93
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 11:08:40 2019 +0200

    dsdb: Fix the FreeBSD build
    
    My FreeBSD install does not have __compar_fn_t. libreplace has the
    QSORT_CAST for systems that do.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a8a1ca3f83dce6d725392989cbc97271cbf52f4a
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 10:42:24 2019 +0200

    smbd: Fix the build with clang
    
    clang correctly complains that "close_fsp" is used uninitialized if
    "get_posix_fsp" fails and we end up in "goto out;".
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3ca52f11dcc27de0cbd67c8f030d2984869c3085
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 1 17:00:45 2019 +0200

    smbd: Pass in "struct smb_request" to request_timed_out()
    
    It seems more natural to pass in a request to a routine called
    request_timed_out(), and it's a few bytes less .text
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bb81b9a75ad66ad8a78f146d217e74c3bf7cc7f8
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 1 16:42:59 2019 +0200

    smbd: Use "req->request_time" in schedule_async_open()
    
    All callers passed that in
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit af97381b11572befe35dc0cb32ccce59a3f4beaa
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 1 16:42:59 2019 +0200

    smbd: Use "req->request_time" in schedule_async_open()
    
    The one caller passed that in.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2d05524e846cf75b1a5482855b0afc9092040b17
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 1 16:42:59 2019 +0200

    smbd: Use "req->request_time" in setup_kernel_oplock_poll_open()
    
    Both callers passed that in.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d5b5ef3e2fa56a67fec4265384508c74e41f1ca5
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 1 16:42:59 2019 +0200

    smbd: Use "req->request_time" in defer_open()
    
    Both callers passed that in.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e5ad2d372027fea64d62deaffe6baf95df36f58a
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 1 16:42:59 2019 +0200

    smbd: Use "req->request_time" in schedule_defer_open()
    
    Both callers passed that in.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2ef382fa764da3dae9f251925c2d9057bb7bb260
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Aug 1 16:36:48 2019 +0200

    smbd: Avoid a separate "request_time" variable in open_file_ntcreate
    
    We have "smb_request->request_time" that is already set up by
    init_smb_request().
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f5735e2c666a5a494131c1d25f7ba5c7fbeae923
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Aug 4 18:26:05 2019 +0200

    tdb: Inline the common part of tdb_oob
    
    When you set
    
    in tdbtorture.c to make it more similar to locking.tdb use,
    
    bin/tdbtorture -m -n 1 -l 100000 -s
    
    becomes twice as fast. This is a pretty extreme case, but all other
    tests that I did improve significantly as well.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 897bffa8166f643eb9063a848bb0c02455663317
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Aug 4 12:18:19 2019 +0200

    tdb: Speed up tdb_oob()
    
    This is common between both implementations of tdb_oob(). It's
    faster if we don't have to dereference function pointers.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5a388453e0cb038fa3ed5fb46f972470f7793566
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Aug 4 12:15:14 2019 +0200

    tdb: Introduce tdb_oob()
    
    Initially just encapsulate the pointer dereferences
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 885ba572efaac6c20388b8e119315c837e8f5236
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Aug 4 12:10:03 2019 +0200

    tdb: Rename tdb_oob() to tdb_notrans_oob()
    
    tdb_oob() will become a public function encapsulating the pointer
    dereferences.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fe9b12b274028a1310ac6c59cc56ac36bb40ef5e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Aug 1 23:29:55 2019 +0000

    pidl/ndr/python: avoid memory errors in getsetters
    
    This:
    
       $ python3 -c'from samba.dcerpc import lsa; x = lsa.EnumAccounts(); x.in_handle'
    
    should not raise a MemoryError, which is very unfriendly given that
    'x.in_handle' is just named, not called, as far as the user is
    concerned. Returning None is the proper thing.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Tue Aug  6 18:17:11 UTC 2019 on sn-devel-184

commit d6a82edd19b82d99401a27dbc6fe10121142e431
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Aug 1 16:02:05 2019 +1200

    s4/messaging/py: don't DECREF borrowed references
    
    This made Message.deregister() a decref machine, with talloc crashes
    and segfaults available thus:
    
        from samba import messaging
        m = messaging.Messaging()
        for i in range(20):
            m.deregister(m)
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit b136f153b83d80a91ec9d5350fdf08412d881964
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Mar 8 12:12:00 2019 +1300

    ldb_dn: free dn components on explode failure
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit 5d4aa6e867044e6b58b45acde32ac35e1d0a7765
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Aug 5 11:11:14 2019 +0200

    s3:smbd: Fix sync dosmode fallback in async dosmode codepath
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14070
    RN: Fix sync dosmode fallback in async dosmode codepath
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Aug  6 15:40:18 UTC 2019 on sn-devel-184

commit ea17bd5539eb0be7a446b99c8b6baa4aa1ab273f
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Aug 5 10:59:22 2019 +0200

    s3:smbd: Incomplete conversion of former parametric options
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14069
    RN: Incomplete conversion of former parametric options
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit f5388f97792ac2d7962950dad91aaf8ad49bceaa
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Jul 12 10:49:13 2019 +0200

    ctdb: fix compilation on systems with glibc robust mutexes
    
    On older systems like SLES 11 without POSIX robust mutexes, but with glib robust
    mutexes where all the functions are available but have a "_np" suffix,
    compilation fails in:
    
    ctdb/tests/src/test_mutex_raw.c.239.o: In function `worker':
    /root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:129: undefined reference to `pthread_mutex_consistent'
    ctdb/tests/src/test_mutex_raw.c.239.o: In function `main':
    /root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:285: undefined reference to `pthread_mutex_consistent'
    /root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:332: undefined reference to `pthread_mutexattr_setrobust'
    /root/samba-4.10.6/bin/default/../../ctdb/tests/src/test_mutex_raw.c:363: undefined reference to `pthread_mutex_consistent'
    collect2: ld returned 1 exit status
    
    This could be fixed by using libreplace system/threads.h instead of pthreads.h
    directly, but as there has been a desire to keep test_mutex_raw.c standalone and
    compilable without other external depenencies then libc and libpthread, make the
    tool developer build only. This should get the average user over the cliff.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14038
    RN: Fix compiling ctdb on older systems lacking POSIX robust mutexes
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 37bb6229ad48b7a443eefa19a1845ce92a5bf546
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Aug 4 09:29:44 2019 +0200

    s3: smbd: fix a comment in fd_close()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3e0cafc2b545f16b84f2f46a270e62a541fc4e49
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Aug 4 09:21:55 2019 +0200

    s3: smbd: inline dptr_close_internal()
    
    There's now only one caller left.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7d72cf02e799502bf7df93183d325a3d50433569
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Aug 4 09:15:47 2019 +0200

    s3: smbd: simplify dptr_CloseDir()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6d0924d8ea0391c5b6414a79d25e15ddfd7dd448
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Aug 4 09:13:34 2019 +0200

    s3: smbd: remove redundant smb_dname arg from dptr_create()
    
    Now that dptr_create() is handle based, we can simply used the fsp name.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d84c048ea5350418cff87d5bf12f2f583d592994
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 14:59:00 2019 -0700

    s3: smbd: Remove call to dptr_closecnum() on connection shutdown.
    
    Now all client enumerations use fsp file handles we will
    aleady close them in file_close_conn() above.
    
    The only user of dptr_closecnum() is for the strange old OS/2
    semantics, so I can't get rid of it until SMB1 is removed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 043c232144830d4da12cae877994caa16ec91c6d
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 14:58:25 2019 -0700

    s3: smbd: Remove dptr_close().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 196fe53ede8743ab02a2a29d574cfd27632ceb3f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 14:56:42 2019 -0700

    s3: smbd: Remove dptr_close() from dptr_closecnum().
    
    Now we're handle-based close_file() already does
    what is needed to shut down directory enumeration.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a8ca5dc467c40619722b165a22fdf13b9b474c86
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:55:25 2019 -0700

    s3: smbd: Remove dptr_close() from reply_findclose().
    
    Now we're handle-based close_file() already does
    what is needed to shut down directory enumeration.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 779dd3f1e6bc462057a8f367d6c7cbb5cd75d4ba
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:54:43 2019 -0700

    s3: smbd: Remove dptr_close() from call_trans2findnext().
    
    Now we're handle-based close_file() already does
    what is needed to shut down directory enumeration.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 269fbc9164615d0e6034b873a76552cb138b24ea
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:53:33 2019 -0700

    s3: smbd: Remove dptr_close() from call_trans2findfirst().
    
    Now we're handle-based close_file() already does
    what is needed to shut down directory enumeration.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 63e1220a2bb984a89b2f6e20c37f16d15f1a8814
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:37:02 2019 -0700

    s3: smbd: Remove dptr_close() from reply_fclose().
    
    Now we're handle-based close_file() already does
    what is needed to shut down directory enumeration.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 24722da0b1f2602c111026b7e6af82360d60a637
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:35:57 2019 -0700

    s3: smbd: Remove dptr_close() from reply_search().
    
    Now we're handle-based close_file() already does
    what is needed to shut down directory enumeration.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f5eebfc725136d1fdf2d6c9f66db59f24338f9c2
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:45:16 2019 -0700

    s3: smbd: Remove dptr_fsp(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 37e1dd5af3b30f1c7a76cced215b440bedc1ba4b
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:43:43 2019 -0700

    s3: smbd: Replace dptr_fsp() with dptr_fetch_lanman2_fsp() in reply_findclose().
    
    Now we have no users of dptr_fsp() left.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b4431ad3051aa22347455fd3bcb181d17026d501
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:28:53 2019 -0700

    s3: smbd: Remove dptr_fetch_lanman2() - unused.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d6e709c43ea8d8ecbe43a6a499fa5e3ed956bce6
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:26:40 2019 -0700

    s3: smbd: Convert call_trans2findnext() to use dptr_fetch_lanman2_fsp().
    
    dptr_fetch_lanman2() is now no longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b922f6e7045fc7906ea60cd715b156ff61d477e2
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:20:08 2019 -0700

    s3: smbd: Add dptr_fetch_lanman2_fsp() - to replace dptr_fetch_lanman2().
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e63400841e9d3372b8960b8764d45729926fb02f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:16:37 2019 -0700

    s3: smbd: Remove dptr_fetch() - replace internals with dptr_fetch_fsp().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a2ef44b71bffb8500dd88538b1e617497816f608
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:11:57 2019 -0700

    s3: smbd: Replace dptr_fetch() with dptr_fetch_fsp() in reply_search().
    
    We now no longer use dptr_fetch().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 68e403fa587b4c6a27e6d0f2b901942a01e42ea6
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:07:33 2019 -0700

    s3: smbd: Replace dptr_fetch() with dptr_fetch_fsp() in reply_fclose().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 96e8175dc81b32ba065ad393f8413373937d41cb
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 13:05:43 2019 -0700

    s3: smbd: Add dptr_fetch_fsp() for SMB1 code. We will use this to replace dptr_fetch().
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5a7aaa8060fdcfc2e066f1ef859634bc115699db
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Jul 16 09:44:25 2019 -0700

    s3: smbd: Remove now unused dptr_activecnum().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 916afa3746aebe07a06d512db72a852df2f26b9c
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Jul 16 09:43:04 2019 -0700

    s3: smbd: All directory enumeration is now via file handles - remove unneeded code in idle connections.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit de2167668eaff6b896b4f2e255f37b8755aa3fba
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Jul 16 09:41:39 2019 -0700

    s3: smbd: Remove now unused dptr_closepath().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 492b322237db42b025d2c3c16ae0e6c78b736838
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Jul 16 09:39:54 2019 -0700

    s3: smbd: Now we properly open file handles for directory enumerations, we don't need this code in SMB1rmdir.
    
    The share mode exclusion will prevent deletion of open directory
    enumeration handles.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 247515982f01db25b484e707621b56c836663a08
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 15:25:11 2019 -0700

    s3: smbd: Now we are always using fsp handle-based client searches, simplify smb_Dir_destructor().
    
    We know we always have a dir_hnd->dir and dir_hnd->fsp.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 84312fc5c289c926e189504b144bf9655491f706
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 15:21:21 2019 -0700

    s3: smbd: Now we're using OpenDir_fsp() all the time, make sure we don't leak file handles.
    
    We must always set dir_hnd->fsp, even in the fallback to
    SMB_VFS_OPENDIR() case. Remember if we had to fall back
    and fix the destructor to close the additional file
    descriptor if we did.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d485c43cc74c5550d151fe728ddc53b02ab23df8
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 11:21:12 2019 -0700

    s3: smbd: Now we always use handle for directory enumeration, we can delete the fallback code.
    
    The code inside open_dir_safely() is root safe
    and can replace the deleted open_dir_with_privilege()
    fallback code.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a130760f70960de559b845fffb1b70dc11db6f24
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 15 17:13:33 2019 -0700

    s3: smbd: Convert SMB1 reply_search() to use handle-based directory enumeration.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 043443ee33bcd8ad61ec59574aaacdde511656da
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 15 17:06:52 2019 -0700

    s3: smbd: Convert SMB1 call_trans2findfirst() to use handle-based directory enumeration.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5388df783e4b60082113086ce6c94e47a841055f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 10:46:09 2019 -0700

    s3: smbd: Prepare for SMB1 directory handle opens in call_trans2findnext()
    
    Call close_file() on any SMB1 directory handle once the dptr is closed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 264d6b408e09c2a1758466ec22adb3386f623777
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 10:45:14 2019 -0700

    s3: smbd: Prepare for SMB1 directory handle opens in call_trans2findfirst()
    
    Call close_file() on any SMB1 directory handle once the dptr is closed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 61c239fcec1589d078678e729a19920adfe198f6
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 10:42:21 2019 -0700

    s3: smbd: Prepare for SMB1 directory handle opens in reply_findclose()
    
    Call close_file() on any SMB1 directory handle once the dptr is closed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b055f1ac7b69ede807eead360b7ffb9c65dea53c
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 10:40:51 2019 -0700

    s3: smbd: Prepare for SMB1 directory handle opens in reply_fclose()
    
    Call close_file() on any SMB1 directory handle once the dptr is closed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e686e7b6b3f6d8e8ac1cd71979e59d1382c2124a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 10:38:45 2019 -0700

    s3: smbd: Prepare for SMB1 directory handle opens in reply_search()
    
    Call close_file() on any SMB1 directory handle once the dptr is closed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit aa3a087193b23001bd7a17e30644b5cbeb0119eb
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 10:36:20 2019 -0700

    s3: smbd: Prepare for SMB1 directory handle opens in dptr_closecnum().
    
    Call close_file() on any SMB1 directory handle once the dptr is closed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a5f8769c25ec119805586c145c09f6a63603bc36
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 15 16:06:09 2019 -0700

    s3: smbd: Change dptr_closecnum() to use dptr_close() instead of dptr_close_internal().
    
    This will allow us to close any outstanding handles on
    an SMB1 connection as later commits move us to using directory
    handles instead of pathname directory opens.
    
    This is inefficient, as it means walking the list twice,
    but this will only be called with active dptrs in the
    OS/2 -1 case, in the connection shutdown case the
    directory handles will already have been closed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5a038f511413fdfaa26e41ceee35c1523185b071
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 12:57:00 2019 -0700

    s3: smbd: Make dptr_close() safe to call with an fsp handle stored in dptr->dir_hnd.
    
    SMB1 doesn't currently do this, but subsequent changes will add handle based
    calls to SMB1 so dptr_close() has to be able to cleanly remove any back pointers.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2ba48f76ecaab3ddcd5d030a1dab3b5a889532b6
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 11:00:06 2019 -0700

    s3: smbd: Add dptr_fsp() to return any stored files_struct pointer.
    
    Will allow [find/search]_next() calls to find and close any associated
    fsp. This function is temporary and will eventually go away once I
    modify dptr_fetch() to return an fsp.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f61dae7635971bcbae4d191219ccb5365984d059
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 15 15:57:48 2019 -0700

    s3: smbd: Move the strange OS/2 directory key == -1 close semantics to the caller.
    
    This will allow us to change dptr_closecnum() to close outstanding fsp
    handles for SMB1 later.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 23d0555c0d0ff2efc62e80dde58f146de97cc27b
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 15 14:58:21 2019 -0700

    s3: smbd: dptr_close() can only be called from SMB1 code.
    
    SMB_ASSERT this is the case.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit eebcc88ddf93466a3c98c023e86de23aba9875c1
Author: Björn Jacke <bjacke at samba.org>
Date:   Mon Aug 5 17:16:32 2019 +0200

    doc: improve vfs objects parameter description
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Karolin Seeger <kseeger at samba.org>
    
    Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(master): Tue Aug  6 13:40:21 UTC 2019 on sn-devel-184

commit bed7fc5a1b5fbea7664aced72dac08846cce6ebc
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Mar 12 11:48:06 2014 +0100

    wafsamba: change --picky-developer into --disable-warnings-as-errors
    
    By default we're using -Werror now if --enable-developer is
    specified.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Tue Aug  6 07:50:14 UTC 2019 on sn-devel-184

commit 0df28b3d143db93971ea7c5253a9caf4a7a9d61e
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Nov 11 14:55:55 2014 +0100

    script/autobuild.py: remove explicit --picky-developer"
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>

commit 81186651eebf20e1ed7baf0116d5dbbc16d3d995
Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
Date:   Wed Jul 24 11:46:01 2019 +1200

    ldb: skip indexes on full_search
    
    Use iterate_range kv op to skip the index section of the database when
    running a full search. Quick local testing showed 18% improved throughput
    on a full search with no results on a 50k database. With more results,
    improvement is smaller but still noticeable.
    
    Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Aug  2 02:29:42 UTC 2019 on sn-devel-184

commit 4b88e1d997cdb39c4b4e71ea742168598fbb2dff
Author: Günther Deschner <gd at samba.org>
Date:   Wed Aug 31 15:55:10 2016 +0200

    tests/dcerpc/raw_protocol: Add more tests for DCERPC_AUTH_LEVEL_PACKET
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Aug  1 16:59:02 UTC 2019 on sn-devel-184

commit e0e68ea25514fdb05921eabec6a4cdd587a9844e
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 1 13:04:16 2019 +0200

    tests/dcerpc/raw_protocol: split test_spnego_integrity_request into 2 parts
    
    This can be a generic test that can be used for more auth_levels.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ff2f20439c403340ec886bf31f055355dfbfcdbf
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Aug 1 13:04:16 2019 +0200

    tests/dcerpc/raw_protocol: split test_spnego_connect_request() into 2 parts
    
    This can be a generic test that can be used for more auth_levels.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit c226dc6e8a18343031829c35552e557903593daf
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 14:17:02 2019 +0200

    smbd: Fix use-after-free from exit_server_common()
    
    We need to keep the smbXsrv_connection structures around until all
    pending requests have had their chance to clean up behind them. If you
    look at srv_send_smb(), it's exactly prepared already to just drop
    anything on the floor when the transport has been declared dead:
    
    	if (!NT_STATUS_IS_OK(xconn->transport.status)) {
    		/*
    		 * we're not supposed to do any io
    		 */
    		return true;
    	}
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14064
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Thu Aug  1 15:39:13 UTC 2019 on sn-devel-184

commit 10e140d25cd3cad8428e3b080ef28dd237d903d5
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 31 10:52:40 2019 +0200

    s3:torture: Fix the FreeBSD build
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14060
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 21f6cece543dd791e0f4636458bfe9819823420c
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Jul 25 14:38:26 2019 +0200

    libcli/smb: send SMB2_NETNAME_NEGOTIATE_CONTEXT_ID
    
    Note: Unlike the current documentation, the utf16 string
    is not null-terminated, that matches Windows Server 1903
    as a client.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14055
    RN: Add the target server name of SMB 3.1.1 connections
    as a hint to load balancers or servers with "multi-tenancy"
    support.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Aurelien Aptel <aaptel at suse.com>

commit e10b90f33bb812600886656a1124e2d434416563
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Jul 25 14:37:31 2019 +0200

    libcli/smb: add new COMPRESSION and NETNAME negotiate context ids
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14055
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Aurelien Aptel <aaptel at suse.com>

commit f258cfaa1d07af6ac6e996006f6e59955cfe34ce
Author: Michael Adam <obnox at samba.org>
Date:   Thu Aug 1 00:47:29 2019 +0200

    vfs:glusterfs_fuse: build only if we have setmntent()
    
    FreeBSD and other platforms that don't have setmntent() and friends can
    not compile this module. This patch lets changes the build to only
    compile this module if the setmntent() function is found.
    
    This is the a follow-up fix to the actual fix for bug #13972.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13972
    
    Signed-off-by: Michael Adam <obnox at samba.org>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Thu Aug  1 09:49:04 UTC 2019 on sn-devel-184

commit 464fef34d1d047d73be347cd446b74e0f5eb2370
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Jul 31 01:14:42 2019 +0000

    tests/ldap: Use TLDAP to check the extended DN return
    
    Tests commit 9f6b87d3f6cc9930d75c1f8d38ad4f5a37da34ab
    
    To run: make test TESTS="samba3.smbtorture_s3.plain.TLDAP"
    
    Reverting the above commit makes this test fail:
    
    'GUID format in control (no hyphens) doesn't match output
    tldap_search with extended dn (no val) failed: LDAP error 0 (TLDAP_SUCCESS),
    TEST TLDAP FAILED!'
    
    This behaviour couldn't be tested via LDB libraries because they never
    deal with the underlying DN string.
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Aug  1 06:20:28 UTC 2019 on sn-devel-184

commit 85a7b594c56f7729bdfa194fee9299a08f6b4785
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Jul 31 15:29:07 2019 +1200

    tests/tldap: Actually check the paging return code
    
    The test never worked correctly because the code was overlooked. It was
    also the case that the connection was never authenticated, and so an
    LDAP BIND call has now been added.
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029

commit bff466943e01540b4d3210392e0fd5b1c882c0b9
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Jul 31 13:39:13 2019 +1200

    tldap: Paged searches fail when they get to the end
    
    The normal case hit the goto label, and should have just returned.
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029

commit e5452a37425484a95f90604a3e58e8a731460793
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Jul 31 01:08:23 2019 +0000

    tldap: Make memcpy of no controls safe
    
    Static analyzers sometimes complain about this case.
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029

commit 1a7f2a230d509df6f1f91bfea80c9b4b2c0df1bd
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Jul 31 12:08:58 2019 +1200

    dsdb: Quiet CID 1452117 1452119 1452114 (STRAY_SEMICOLON)
    
    Try to make clear what is being done here, we are trying to count the partitions so that
    we can then walk them in reverse.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 0c001a7bf644d53cd0db4f4cc901e74d87cfcb35
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Jul 31 10:20:07 2019 +1200

    CID 1452121: dsdb/mod/partition: protect whole function with NULL check
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Jul 31 04:08:48 UTC 2019 on sn-devel-184

commit a5ec857abe99748dd478cdc988fa3399401334dc
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Jul 31 10:16:37 2019 +1200

    CID 1452109: dsdb/util: do not check for NULL after deref
    
    This is all strictly unnecessary, as ret is always != LDB_SUCCESS when
    res is NULL, but we want to make peace between clang and converity.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 35c54007e6183829d9d85a24b3bd95f469739ad3
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Jul 24 14:53:33 2019 +1200

    tests/drs_no_dns: Check dbcheck and ldapcmp pass
    
    When joining a DC without DNS partitions, make sure that the alternate
    flow of creating them afterwards results in a database with everything
    that is necessary.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14051
    RN: Allow a DC join without DNS partitions, to add them later
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7d2875bd70cf727730be8dc705bfd01eacaaaa6f
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Jul 24 15:13:43 2019 +1200

    tests: Add samba_upgradedns to the list of possible cmds
    
    This will be used to test the replication scenario with no DNS partitions
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14051
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d90ccce59754bc833027c06683afac25f7a8d474
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Jul 24 15:18:40 2019 +1200

    netcmd: Allow drs replicate --local to create partitions
    
    Currently, neither the offline (--local) or online (normal replica sync)
    methods allow partition creation post-join. This overrides the Python
    default to not create the DB, which allows TDB + MDB to work.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14051
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2b590e16bcb4f4e1f1f0bf049a863db38e634beb
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 30 12:24:53 2019 +0200

    smbd: Fix retry for kernel-oplocked files
    
    This now removed comment describes the bug correctly:
    /*
     * As this timer event is owned by req, it will
     * disappear if req it talloc_freed.
     */
    
    In smb1, "req" disappears once the reply_whatever routine is done. Thus
    the timer goes away and we never look at "req" again.
    
    This change moves the valid data (xconn and mid) to
    deferred_open_record, and changes the talloc hierarchy such that the
    timer is now a child of open_rec, which is a child of the deferred
    message.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14060
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Jul 31 00:12:34 UTC 2019 on sn-devel-184

commit ef582ffcf3a220b73f678d9bce0fd37800f76c54
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jul 29 20:45:51 2019 +0200

    smbd: Always open files with O_NONBLOCK
    
    It's perfectly possible that someone else takes a kernel oplock and
    makes us block, independent of our own kernel oplock setting.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14060
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 57695ad44bf10d6ae1dc466551358bd826dac923
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jul 29 17:14:00 2019 +0200

    torture3: Add oplock5 kernel-oplock test
    
    Show that the current smb1 server does not properly retry a nonblocking
    open of a kernel-oplocked file
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14060
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ea7708d8c7fa674111ccea58b3cd0757765c702a
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 8 16:35:57 2019 +1000

    ctdb-scripts: Simplify 01.reclock.script
    
    The "init" event is only run once so don't bother caching the
    configured value of the recovery lock.  Add some extra error checking.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Fri Jul 26 04:52:04 UTC 2019 on sn-devel-184

commit 38898775e6f1fb25171c920f2d8bcce24ec51476
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 8 13:30:06 2019 +1000

    ctdb-scripts: Drop monitoring of recovery lock
    
    The fcntl helper now does a more meaningful check.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5701f4aecafcd4efeba5bc12ace5da3101ea49d9
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 8 16:37:41 2019 +1000

    ctdb-tests: Add some 01.reclock.script init event tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ecef4411302113b0513db30169a8481a0a521316
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 8 16:17:27 2019 +1000

    ctdb-tests: Fix 01.reclock.script tests for non-default lock
    
    These tests currently do not do what is expected.  They test the
    default case.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 2bd316d01d3ddf733787eba6092f5880b7feb65a
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jul 19 13:41:30 2019 +1000

    ctdb-tests: Add tests for cluster mutex lost handling
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 41cd44724e2d035d006645407ed623600d0ec6d8
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Jun 27 16:14:26 2019 +1000

    ctdb-mutex: Add support for exiting if the lock file disappears
    
    If the lock file is inaccessible or the inode number changes then the
    lock is lost, so exit.  This allows the recovery daemon to trigger an
    election.  The ensuing recovery will re-take the lock.
    
    By default the lock file is checked every 60 seconds.  A lot can
    happen in 60 seconds but being more aggressive and accessing the lock
    too often could result in a performance issue for the cluster
    filesystem.
    
    An new optional 2nd argument is added, which is the lock file re-check
    time in seconds.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit af8de1bcfd4cfb2b2517b5badcc9ab564276fb92
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Jun 27 14:13:50 2019 +1000

    ctdb-mutex: Add an intermediate asynchronous computation for waiting
    
    This will allow more conditions to be waited on via additional
    sub-requests.  At the moment this just completes when the parent wait
    completes.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit fae8e438f019e7c1d20582f167b3adeac781ddbe
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Jun 27 13:45:01 2019 +1000

    ctdb-mutex: Change parent checking to use an asynchronous computation
    
    Put the checking for the process being immediately re-parented into
    the computation too.  This will be very rare and doing it
    consistently makes testing saner.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 2f768a090e0a1f34660227e1aedc0ed03ea98534
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jul 5 15:39:23 2019 +1000

    ctdb-mutex: Exit immediately if the lock isn't taken
    
    There is no need to wait until the parent kills the helper.  The
    parent will get the initial response, indicating contention or
    similar, and will then get a separate event indicating that the pipe
    is gone.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit d716be19ea14f15984eab8ce3388eb90bbb49d0a
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 8 20:51:11 2019 +1000

    ctdb-tests: Add test to confirm need for cluster mutex lock file rechecking
    
    Remove the lock and a second locker can take the it.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit adcf313c49cbd4e411d6f3fb50e90642f3b7531c
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Jul 4 21:52:00 2019 +1000

    ctdb-tests: Add cluster mutex tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 2b6f1a8ee648017dcdb595aacc0469d28e30d00e
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jul 19 11:14:43 2019 +1000

    ctdb-mutex: Drop dependency on ctdb_set_helper
    
    This makes the code more explicit and makes testing easier due to less
    dependencies.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 76ab0a2b82db76ee48e98ae9ca6a4af18a99f68c
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Jul 17 13:31:27 2019 +1000

    ctdb-mutex: Drop unneeded assignment
    
    clang warns:
    
      ctdb/server/ctdb_mutex_fcntl_helper.c:61:3: warning: Value stored to 'fd' is never read
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 98169241ef74d92beb433639834dfc0decc52a75
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jul 5 13:13:16 2019 +1000

    ctdb-mutex: Update to use modern debug macro
    
    One of these had a missing space, so this implicitly fixes it.  It
    also drops the need to unnecessarily include common.h, which comes
    with some dependency baggage.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit c276723dd89995100ec42402eee65d6e3a623d03
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 9 12:42:24 2019 +1000

    ctdb-tests: Set LANG=C for consistency of command output
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 6fe963c3f72680ecbed1b6f9c70a7af003115666
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 16 08:58:33 2019 +1000

    ctdb-recoverd: Periodically log recovery master of incomplete cluster
    
    Only do this if the recovery lock is unset.  Log every minute for the
    first 10 minutes, then every 10 minutes, then every hour.
    
    This is useful for determining whether a split brain occurred.  It is
    particularly useful if logging failed or was throttled at startup, so
    there is no evidence of the split brain when it began.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit f2559ef8ce01a46b33a9295e67da920a327f3929
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Jul 15 09:15:04 2019 +1000

    ctdb-recoverd: Log the master at the end of elections
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 6b7b1e8080096ccf64bfa236db597cec0856e6b7
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Jul 25 15:15:43 2019 +1000

    ctdb-tests: Add tests for empty values in config file
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit efd0c45a8b152eb4716193bea6cf95e9e0b97d8b
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Jul 25 15:14:32 2019 +1000

    ctdb-common: Fix empty value handling in conf
    
    In tini, allow_empty_value=false causes the parser to ignore the lines
    without '=' sign, but lines with nothing after '=' sign are allowed and
    cause empty string ("") to be passed as a value.
    
    This is counter-intuitive, so conf requires special handling for empty
    values (which are treated as invalid).
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 242ea955e672799c45aba47f454900a5a52ce9f6
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Jul 25 15:15:23 2019 +1000

    ctdb-tests: Use required_error instead of required_result
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 1f923e067dbe358c17cbccfe179baa811aa3b8b3
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 16 16:13:17 2019 +0200

    s3:rpc_server: Only dump passwords in developer builds
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Jul 26 03:05:01 UTC 2019 on sn-devel-184

commit 93d424528f1c3d0d50ebd8a784f4624b2721d416
Author: David Disseldorp <ddiss at samba.org>
Date:   Fri Jul 12 17:29:23 2019 +0200

    netlogon: Fix potential use of uninitialized variable
    
    The _netr_NetrEnumerateTrustedDomains()->dcerpc_lsa_open_policy2() error
    path checks the policy handle and closes it if non-empty. The policy
    handle may be uninitialized in this code-path - fix this.
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1c84bda361678cb6c4685cff17a2d5a5026f2bce
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 16 16:02:12 2019 +0200

    s3:rpc_server: Use a stackframe for temporary memory
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 52b3f921ad2d04cb30232a6aadf261c9fc9aafb2
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 16 15:49:43 2019 +0200

    s3:utils: Use a stackframe for temporary memory
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9158a6ba8693070f3b2b71dd15089488869ab6cd
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 16 15:45:51 2019 +0200

    s3:rpcclient: Use a stackframe for temporary memory
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fa09e811ca6fb08a66940380b310ce9794397071
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 16 15:20:23 2019 +0200

    s3:lib: Use the passed mem_ctx instead of talloc_tos()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9ede63fbada7842cd9ae120936bc6bd4b6ad16ac
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Feb 22 13:28:01 2019 +0100

    lib:crypto: Don't build RC4 if we have GnuTLS >= 3.4.7
    
    We have a GnuTLS DCEPRC backupkey implementation for the server and the
    test. However this is only working with GnuTLS >= 3.4.7. So we need to
    keep this around till we can require at least GnuTLS in a newer version.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 14c4a075875860e709a9e2e52aad83aa4c58a5ad
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Feb 26 18:18:36 2019 +0100

    lib:crypto: Remove arcfour.h from crypto.h
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fc4ae06001fbb0045318a8cec7af6af81241c60e
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Feb 22 12:59:13 2019 +0100

    lib:crypto: Use GnuTLS RC4 in py_crypto
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 301544ab2b0c85752d5307f2daab59652c08e1e0
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Feb 22 13:06:34 2019 +0100

    s4:torture: Use init_samr_CryptPassword in testjoin RPC test
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5740e9516f3587e3a9f72cf52cfe1eedd940b2a9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Jul 25 13:07:48 2019 +1200

    s4:torture: Use samba_gnutls_arcfour_confounded_md5() in test_ChangePasswordRandomBytes
    
    This ensures GnuTLS is used as the underlying RC4 crypto engine
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 82a6480611f791a3c26fcf70975e6f8b3b1757ad
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 16:01:31 2019 +0200

    s4:torture: Use GnuTLS RC4 in test_ChangePasswordRandomBytes
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 19d9c2c01a54957bc3852e2565d92c1cdd89498b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Jul 25 17:43:23 2019 +1200

    s4:torture: Use init_samr_CryptPassword in test_ChangePasswordRandomBytes
    
    This allows the use of GnuTLS for the underlying RC4 crypto
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8380668be7963b74cbbd31bfab3d01d1f3089034
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Jul 25 17:18:50 2019 +1200

    s4:torture: clarify comments and variable names in "ChangePasswordUser3 tests
    
    There is no session key here, the buffers are directly encrypted
    with the long-term passwords.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 5b7c21fca576bf6e44233d69b47273058b9197c8
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 16:01:02 2019 +0200

    s4:torture: Use init_samr_CryptPassword in test_ChangePasswordUser3
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a476a2e3322a550e2857cb5a66096fa3e46416d3
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 16:00:32 2019 +0200

    s4:torture: Use GnuTLS RC4 in test_ChangePasswordUser2_ntstatus
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9cbdf7b2e5f734e9b5e0e447d54d720d18977950
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 16:24:18 2019 +0200

    s4_torture: Use GnuTLS RC4 in test_ChangePasswordUser2
    
    This uses STR_ASCII as string encodings.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1b1c302a7db23bf4377b8fa742ebf7ae913e3511
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Jul 25 16:52:41 2019 +1200

    s4:torture: Use init_samr_CryptPassword in test_ChangePasswordUser2_ntstatus
    
    This allows the use of GnuTLS for the RC4 crypto operation
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit dfda49472e0b4a81653963e80d8d65788f80a591
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Jul 25 16:46:06 2019 +1200

    s4:torture: Use init_samr_CryptPassword in test_ChangePasswordUser2
    
    This allows the use of GnuTLS for the RC4 crypto operation
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit b512b5974494fe41010800f60df0f248b8ea850e
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 16:49:53 2019 +0200

    s4:torture: Use GnuTLS RC4 in test_OemChangePasswordUser2
    
    This uses STR_ASCII for password encoding!
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f45ba47afb11c1f7bbb8c5c84670395500e1afc1
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 15:59:19 2019 +0200

    s4:torture: Use init_samr_CryptPassword in test_SetUserPass_level_ex
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3b9496d905408b75c21919b35b2105e2b0b0325f
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 15:58:38 2019 +0200

    s4:torture: Use init_samr_CryptPassword in test_SetUserPass_25
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e398ecbd8e32bb428073f3635d9178abfae28255
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 15:58:06 2019 +0200

    s4:torture: Use init_samr_CryptPassword in test_SetUserPassEx
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b0b9cabc4de64497140d33d0fdaf2927f2915987
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 15:57:25 2019 +0200

    s4:torture: Use init_samr_CryptPassword in test_SetUserPass_23
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 70e05d7eb78a0c363dbd72cbbf4f3a264636c840
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 15:56:08 2019 +0200

    s4:torture: Use init_samr_CryptPassword in test_SetUserPass
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 80f5beb4804c694ee6e5f5b450e751f538677593
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Feb 21 10:21:39 2019 +0100

    s4:torture: Use init_samr_CryptPassword(Ex) in samba3rpc test
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 811c412da5c24d7274f9aa4c7d653bbb1191e6a6
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Feb 20 15:52:49 2019 +0100

    s4:torture: Use GnuTLS RC4 for RAP SAM test
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4326e7de6ba0ce02ab23af7297d2f7242988daa4
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Feb 19 17:40:29 2019 +0100

    s4:rpc_server: Use GnuTLS RC4 for samr password
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9363abfb5fcfeff30295ce0cf94c18941a6c4e9f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Jul 25 12:50:57 2019 +1200

    s4:rpc_server: Use samba_gnutls_arcfour_confounded_md5() in samr_set_password_ex()
    
    This allows the use of GnuTLS for the underlying RC4 crypto operations.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 359ae5be0d21e7ab235035aab65710c9459e9593
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Jan 17 12:40:21 2019 +0100

    s3:utils: Use GnuTLS RC4 in ntlm_auth
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cd0b5e5d9377bc79b4468081f3999ad39be3cb8f
Author: Andreas Schneider <asn at samba.org>
Date:   Wed May 15 14:04:31 2019 +0200

    s3:rpc_server: Use GnuTLS RC4 to decrypt samr password buffers
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d31f6a6803c86b8de0a97927731091f5a7bee4f1
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jan 16 17:40:13 2019 +0100

    s3:rpc_server: Use GnuTLS RC4 in samr password check
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a95647e12ac75ffda42d95b41144596a078aebd6
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jan 16 12:41:32 2019 +0100

    s3:rpc_client: Use init_samr_CryptPassword in cli_samr rpc_client
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0947d8388def40b01b322d0deee4dba386983410
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jan 15 18:14:17 2019 +0100

    s3:libsmb: Use GnuTLS RC4 in clirap
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7bd502dcdb44c7d0f8a56b2ba489ae8cf2b886bd
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 6 18:11:14 2018 +0100

    auth:ntlmssp: Use GnuTLS RC4 for ntlmssp signing
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cb4025a50232f24139f21d87e50b6e6ea69238ba
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Nov 9 12:29:55 2018 +0100

    auth:ntlmssp: Use GnuTLS RC4 in ntlmssp client
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit bcf7808d3aa8a5932a40955e4b764f55061e07d7
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jul 8 18:21:18 2019 +0200

    libcli:auth: Use samba_gnutls_arcfour_confounded_md5() in decode_wkssvc_join_password_buffer()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 85e2a3c96ad9acc1a85db189f6418c9d880b4718
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jul 8 18:03:00 2019 +0200

    libcli:auth: Use samba_gnutls_arcfour_confounded_md5() in encode_wkssvc_join_password_buffer()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f4a16bfba8d87de883d3d2e54cdc825fc5e01c2b
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jul 8 17:36:58 2019 +0200

    libcli:auth: Add test for (encode|decode)_wkssvc_join_password_buffer
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 576bcf61555fb641b2919ad84a6b26b242b57061
Author: Andreas Schneider <asn at samba.org>
Date:   Wed May 29 15:50:45 2019 +0200

    libcli:auth: Return WERROR for encode_wkssvc_join_password_buffer()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9ea736590d9b22a7518f86b18e8c55b0d0e213d5
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Jul 25 15:15:46 2019 +1200

    s4:libnet: Use GnuTLS RC4 in libnet_ChangePassword_samr()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cdb4e12765266ae767021d932870fbfcd55ccbf6
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Feb 1 13:38:21 2019 +0100

    s4:libnet: Use GnuTLS RC4 in libnet_SetPassword_samr_handle_23()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 18937f9ceb5aca23899555c5a34fe359f6fcb126
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Feb 1 13:38:21 2019 +0100

    s4:libnet: Use GnuTLS RC4 in libnet_SetPassword_samr_handle_24()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e44ba0397c7558e1da6a46cc38237a3b0e5cef49
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 9 13:11:54 2019 +0200

    s4:libnet: Use encode_rc4_passwd_buffer() in libnet_SetPassword_samr_handle_25()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5afa402bb7ba11a8eefc6e14047eeec1f3327681
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 9 13:01:49 2019 +0200

    s4:libnet: Use encode_rc4_passwd_buffer() in libnet_SetPassword_samr_handle_26()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f0c0cf299eb99e7b78be2f04141b6d415bf525e2
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jul 24 11:44:51 2019 +0200

    s3:rpc_client: Use encode_rc4_passwd_buffer() in init_samr_CryptPasswordEx()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fe00b3735a7e8ae16fb6443965769f1e947a6aa6
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 9 13:06:49 2019 +0200

    libcli:auth: Add test for encode_rc4_passwd_buffer()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 06d46c447e69a6b384c0089863c343b4924c7caf
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 9 13:01:10 2019 +0200

    libcli:auth: Add encode_rc4_passwd_buffer()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 79ca72ec3d13fea5d2ad608415757ca9870035a3
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jul 9 12:53:31 2019 +0200

    libcli:auth: Pass samr_CryptPasswordEx to decode_rc4_passwd_buffer()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 89f8b028e2d595348f9996854488d7aa552ae905
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jul 5 10:12:43 2019 +0200

    libcli:auth: Rename encode_or_decode_arc4_passwd_buffer()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dea160820a393be51985a4e761a3f73da83972e7
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jul 5 10:09:32 2019 +0200

    libcli:auth: Use samba_gnutls_arcfour_confounded_md5() for rc4 passwd buffer
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 95db9a81db093488e625b4ef385a184a5e517ede
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Jan 16 13:15:08 2019 +0100

    s3:rpc_client: Use GnuTLS RC4 in init_samr_CryptPassword()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2075019ca90d7d474003c87b2f0202239891eba5
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Jul 4 16:22:48 2019 +0200

    s3:rpc_client: Use samba_gnutls_arcfour_confounded_md5 in init_samr_CryptPasswordEx
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7ccc76f951a626a25d553ac85c5bf30eb29ffa2b
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jul 5 09:39:02 2019 +0200

    libcli:auth: Add test for decoding an RC4 password buffer
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 57dd415ba49b9621deddf604a5bf148c10ebc37e
Author: Andreas Schneider <asn at samba.org>
Date:   Wed May 29 14:57:52 2019 +0200

    libcli:auth: Return NTSTATUS for encode_or_decode_arc4_passwd_buffer()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7915a48e53c8f72ba56da2f433427b961feeb16f
Author: Andreas Schneider <asn at samba.org>
Date:   Wed May 29 17:16:26 2019 +0200

    s3:rpc_client: Return NTSTATUS for init_samr_CryptPasswordEx()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4b9b1dbe9c8c988a39b1318a4f7aac031bc1ea8b
Author: Andreas Schneider <asn at samba.org>
Date:   Wed May 29 16:22:11 2019 +0200

    s3:rpc_client: Return NTSTATUS for init_samr_CryptPassword()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit baa96ef20945638fb5ee76b03543c7b611e9c7d7
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Jul 18 13:33:54 2019 +0200

    lib:crypto: Document samba_gnutls_arcfour_confounded_md5()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e43678b84a3434b977f44b265599f1d9207d3b78
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Jul 18 13:27:57 2019 +0200

    lib:crypto: Document gnutls_error_to_werror()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5e62358fbf9ed107ed4a5eb82b62e82ae5638262
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Jul 18 09:03:51 2019 +0200

    lib:crypto: Document gnutls_error_to_ntstatus()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3913b9a4088b83d6ed7f94d136a26ecfa7e16b35
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 16:07:09 2019 +0000

    s3/lib: clang: Fix 'access to field results in a deref of a null pointer'
    
    Fixes:
    
    source3/lib/ctdbd_conn.c:1953:6: warning: Access to field 'operation' results in a dereference of a null pointer (loaded from variable 'hdr') <--[clang]
            if (hdr->operation != CTDB_REPLY_CALL) {
                ^~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Wed Jul 24 22:50:27 UTC 2019 on sn-devel-184

commit 81f8cbfba358b61e7b394887d23f751691eb8388
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 16:05:37 2019 +0000

    s3/lib: clang: Fix 'function call argument is an uninitialized value'
    
    Fixes:
    
    source3/lib/ctdbd_conn.c:1066:3: warning: 3rd function call argument is an uninitialized value <--[clang]
                    DEBUG(0,("ctdbd_control failed: %s, %d\n", strerror(ret),
                    ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 1d651a8d5847c1ecd87d5f1bbfc7714e078d60f2
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 16:02:47 2019 +0000

    s3/lib: clang: Fix 'Acces to field results in a deref of a null pointer'
    
    Fixes:
    
    source3/lib/ctdbd_conn.c:415:6: warning: Access to field 'operation' results in a dereference of a null pointer (loaded from variable 'hdr') <--[clang]
            if (hdr->operation == CTDB_REQ_MESSAGE) {
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit be2b69fecebd35d7a60057d6515e4401d3ce1294
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 15:06:30 2019 +0000

    lib/addns: clang: Fix 'Assigned value is garbage or undefined'
    
    Fixes:
    
    lib/addns/dnsquery.c:222:10: warning: Assigned value is garbage or undefined <--[clang]
            *numdcs = num_srvs;     /* size_t->int */
                    ^
    1 warning generated.
    
    Also fixes the out param being modified even on failure
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit da4c1c5f39669274bf8ff5a0974b4111f80be798
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 14:50:24 2019 +0000

    lib/addns: clang: Fix 'Value stored to 'err' is never read'
    
    Fixes:
    
    /home/samba/samba/lib/addns/dnsmarshall.c:406:2: warning: Value stored to 'err' is never read <--[clang]
            err = ERROR_DNS_NO_MEMORY;
            ^     ~~~~~~~~~~~~~~~~~~~
    /home/samba/samba/lib/addns/dnsmarshall.c:447:3: warning: Value stored to 'err' is never read <--[clang]
                    err = buf->error;
                    ^     ~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 6baf0208eb85e834138f666153f94e8327e84996
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 14:45:52 2019 +0000

    libcls/nbt: clang: Fix 'initialization value is never read'
    
    Fixes:
    
    libcli/nbt/nbtsocket.c:65:27: warning: Value stored to 'req' during its initialization is never read <--[clang]
            struct nbt_name_request *req = nbtsock->send_queue;
                                     ^~~   ~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 637cd1a6c4175c527caa144767f3543156c66ed5
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 14:42:46 2019 +0000

    s3/lib/dbwrap: clang: Fix 'Access to field results in a deref of a null'
    
    Fixes:
    
    source3/lib/dbwrap/dbwrap_ctdb.c:530:39: warning: Access to field 'm_write' results in a dereference of a null pointer (loaded from field 'transaction') <--[clang]
            if (pull_newest_from_marshall_buffer(ctx->transaction->m_write, key,
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 6858c83dc625ab2d4c02c702f8f5351805df0ae1
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 14:13:13 2019 +0000

    s3/lib/dwrap: clang: Fix 'Value stored to 'ret' is never read'
    
    Fixes:
    
    source3/lib/dbwrap/dbwrap_ctdb.c:95:2: warning: Value stored to 'ret' is never read <--[clang]
            ret = ctdbd_init_connection(mem_ctx,
            ^     ~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 849ffbc8251aa193cfcab043ab7c818a666a4a68
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 14:08:49 2019 +0000

    lib/adnss: clang: Fix The left operand of '!=' is a garbage value
    
    Fixes:
    
    lib/addns/dnssock.c:143:3: warning: The left operand of '!=' is a garbage value <--[clang]
                    TALLOC_FREE(conn);
                    ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 90e36ef72992a073ba92e736f4533a10f3f5248f
Author: Noel Power <noel.power at suse.com>
Date:   Tue Jul 9 14:04:34 2019 +0000

    libcli/smb: clang: Fix Value stored to 'next_offset' is never read
    
    Fixes:
    
    ibcli/smb/smb2_negotiate_context.c:117:3: warning: Value stored to 'next_offset' is never read <--[clang]
                    next_offset += next_pad;
                    ^              ~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e77237bb46cb1e39433c04d3f4552c4f0ddd4f96
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Jul 24 15:43:46 2019 +1200

    s4/dsdb/replmd: use incoming_dn_should_be_renamed() 2/2
    
    In replmd_replicated_handle_rename().
    
    The helper function was introduced two commits ago and consists of
    a large common stretch of this and the function modified in the previous
    commit.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Jul 24 11:21:50 UTC 2019 on sn-devel-184

commit b9dab848de066a8a3821c30261de8d6cccd77370
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Jul 24 15:21:10 2019 +1200

    s4/dsdb/replmd: use incoming_dn_should_be_renamed() 1/2
    
    In replmd_op_possible_conflict_callback().
    
    The helper function was introduced in the previous commit and consists
    of a large common stretch of this and replmd_replicated_handle_rename().
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5d75ab3ebf48f876f4fb462e0d18c71f931a27c2
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Jul 24 15:16:36 2019 +1200

    s4/dsdb/replmd: add a helper for common calculations
    
    We currently do exactly this work, in exactly these words (ignoring
    formatting) in two different places. The next two commits will make
    those places use this helper function. We do this over three commits
    so that we can more easily compare the next two and be sure they are
    doing the same thing.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e7a6c70953daa84b88004e791e67b9a45f086946
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Apr 24 21:30:07 2019 +1200

    s4/dsdb/replmd: replicated_handle_rename free temp_ctx
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4db886db066c53386aaa16a415c081bd50193af9
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:55:58 2019 -0700

    s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
    
    Fixes SearchDir(). No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Jul 24 08:57:05 UTC 2019 on sn-devel-184

commit 3d95064ceba82a43f6edd5c4b250a22461986480
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:53:40 2019 -0700

    s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
    
    Fixes TellDir(). No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a5b876f3dbdd2dc17407ec08340b5d192b374098
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:52:41 2019 -0700

    s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
    
    Fixes RewindDir(). No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ec072f1a971faba9c140bae0f7792e5fc154189f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:51:07 2019 -0700

    s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
    
    Fixes ReadDirName(). No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit cc4ac86b950f443b4dd23ca997d872549c80a484
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:47:31 2019 -0700

    s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
    
    Fixes OpenDir_fsp(). No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8ad519c4089df71a9fc9191cead68e4eabf844f1
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:44:56 2019 -0700

    s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
    
    Fixes OpenDir_internal(). No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8e65157edf4fe5a9e7c4abdd6c0f2a8d5b8c43b2
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:42:45 2019 -0700

    s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
    
    Fixes DirCacheAdd(). No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 79eae9e38ac2ef967671b43fc2eb76d8b195eee8
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:40:04 2019 -0700

    s3: smbd: Naming consistency. Change all uses of struct smb_Dir * variables to be dir_hnd.
    
    Fixes smb_Dir_destructor(). No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit eb5fa8ac8465e621c95da1f03b68da8aae73f6b0
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:31:46 2019 -0700

    s3: smbd: Use a separate simple destructor for the OpenDir() codepath.
    
    This will help greatly in understanding the code changes later.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d1441089722b7985df417494f6542e6560e99330
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 09:11:25 2019 -0700

    s3: smbd: Move the setting of the destructor of struct smb_Dir * up two levels.
    
    Previously, open_dir_safely() called OpenDir_internal() which
    set the destructor.
    
    Move setting the destructor into the callers of open_dir_safely()
    as this will allow us to have different destructors for handle-based
    calls.
    
    The reason this is important is that I have a follow up patchset
    that depends on this which makes all client directory enumerations
    handle-based, calling OpenDir_fsp() only, and so the destructor there
    will take care of the fsp back pointer.
    
    Trying to keep a common destructor for handle-based and non-handle
    based calls broke my brain when trying to separate the handle-based
    calls from the non-handle based ones in my later patchset.
    
    NB. The change in OpenDir_fsp() isn't a logic change as instead
    of doing an early return from a function that sets the destructor,
    we now fallthrough to setting the destructor then return, which
    is identical.
    
    Eventually the whole codepath using the fallback for non-handle
    opens inside dptr_create() will go away and this simplifies the
    code immensely. Some short term pain for long-term gain :-).
    
    Added doxygen documentation as requested.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 41c94b8b1f0ba312711b5b6c2ba2f27c696b445b
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Jul 17 08:56:49 2019 -0700

    s3: smbd: OpenDir() is merely a wrapper around open_dir_safely().
    
    Preparatory work.
    
    Separate these out internal to source3/smbd/dir.c so I can
    give the internal and external uses separate destructor functions
    to allow all client requested directory enumeration to move to handle
    based functions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 9d2fd08249881702a4b4b881688d91576cc71ede
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Wed Jul 24 14:17:06 2019 +1200

    netcmd: Better error message for backup with no RID pool
    
    Add a better error message (and what to do about it) if the user tries
    to back up a DC that hasn't initialized its RID pool yet.
    
    Seems to be a fairly common problem hit by users.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14048
    RN: Added more informative error message if the 'samba-tool domain
    backup' command fails due to no RID pool being present on the DC.
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Jul 24 07:07:01 UTC 2019 on sn-devel-184

commit 6c691bf84e41b1edd3228c219f7a94e108795d28
Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
Date:   Mon Jul 15 13:32:41 2019 +1200

    partition: reversing partition unlocking
    
    Unlock partition databases in the reverse order from which they were
    acquired. This is separated from the previous commit for future
    bisecting purposes, since the last commit was made to fix specific CI
    failures, while this one is a speculative fix made based on code
    inspection.
    
    Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7f4bc0ea81f2b34607849911f1271b030be8ca02
Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
Date:   Thu Jul 11 17:12:06 2019 +1200

    partition: correcting lock ordering
    
    A schema reading bug was traced to a lock ordering issue in partition.c.
    This patch fixes the problem by:
    1. Releasing locks/transactions in the order they were acquired.
    2. Always lock/start_trans on metadata.tdb first, before any other
    databases, and release it last, after all others. This is so that we are
    never exposed to MDB's lock semantics, which we don't support.
    
    Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 54af94ff21a7f395133bcc13458cc2e1f52183be
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 5 11:34:25 2019 +0000

    s4/source4/common: clang: Fix 'Dereference of undefined pointer value'
    
    Fixes:
    
    source4/dsdb/common/util.c:3131:6: warning: Dereference of undefined pointer value <--[clang]
            if (res->count < 1) {
                ^
    
    /source4/dsdb/common/util.c:3207:6: warning: Dereference of undefined pointer value <--[clang]
            if (res->count < 1) {
                ^~~~~~~~~~
    source4/dsdb/common/util.c:4004:39: warning: Dereference of undefined pointer value <--[clang]
            (*wkguid_dn) = talloc_steal(mem_ctx, res->msgs[0]->dn);
                                                 ^
    source4/dsdb/common/util.c:4191:35: warning: Dereference of undefined pointer value <--[clang]
            ouv_value = ldb_msg_find_ldb_val(r->msgs[0], "replUpToDateVector");
    
    source4/dsdb/common/util.c:5757:13: warning: 1st function call argument is an uninitialized value <--[clang]
            same_nc = (ldb_dn_compare(source_nc, target_nc) == 0);
                       ^
    This fix also fixes the associated 'Access to field 'xyx' results in a
    dereference of a null pointer' warnings that also will happen when this
    is fixed
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Wed Jul 24 05:49:14 UTC 2019 on sn-devel-184

commit c7c40e205d432342457b20312f3ebf94e15b9ff6
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 5 11:16:45 2019 +0000

    s4/dsdb/common: clang: Fix 'Value stored to 'cps_stdin' is never read'
    
    Fixes:
    
    source4/dsdb/common/util.c:2125:4: warning: Value stored to 'cps_stdin' is never read <--[clang]
                            cps_stdin = -1;
    
                            ^           ~~
    source4/dsdb/common/util.c:2132:3: warning: Value stored to 'cps_stdin' is never read <--[clang]
                    cps_stdin = -1;
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 55f18757aae0f7fb137217e42ced6e2e08bfbfa2
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 5 11:07:07 2019 +0000

    s4/dsdb/common: clang: Fix 'Access results in a deref of a null pointer'
    
    Fixes:
    
    source4/dsdb/common/util.c:2000:6: warning: Access to field 'count' results in a dereference of a null pointer (loaded from variable 'res') <--[clang]
            if (res->count != 1) {
                ^~~
    
    source4/dsdb/common/util.c:3281:28: warning: Access to field 'msgs' results in a dereference of a null pointer (loaded from variable 'res') <--[clang]
            el = ldb_msg_find_element(res->msgs[0], attr);
                                      ^~~
    source4/dsdb/common/util.c:3568:6: warning: Access to field 'count' results in a dereference of a null pointer (loaded from variable 'res') <--[clang]
            if (res->count != 1 || ret != LDB_SUCCESS) {
                ^~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit bd86df913b14070e157b6a9178438f71321c8872
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 5 11:04:10 2019 +0000

    s4/dsdb/common: clang: Fix 'The left operand of '&' is a garbage value'
    
    Fixes:
    
    source4/dsdb/common/util.c:1964:18: warning: The left operand of '&' is a garbage value <--[clang]
            return (options & DS_NTDSDSA_OPT_IS_GC) != 0;
                    ~~~~~~~ ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 79d585689e206dc0e04a4d30f75a38dc4490d96b
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 5 10:42:54 2019 +0000

    s4/dsdb/common: clang: Fix 'function call argument is an uninitialized value'
    
    Fixes:
    
    source4/dsdb/common/util.c:1804:8: warning: 3rd function call argument is an uninitialized value <--[clang]
            ret = samdb_reference_dn(ldb, mem_ctx, server_ref_dn, "rIDSetReferences", dn);
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 6f733b5891db344ec9f3f996322213d8ac2075e5
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 5 10:41:19 2019 +0000

    s4/auth/kerberos: clang: Fix Value stored to 'code' is never read
    
    Fixes:
    
    source4/auth/kerberos/kerberos_util.c:645:3: warning: Value stored to 'code' is never read <--[clang]
                    code = 0;
                    ^      ~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 765fc314e4aee455bae0f391a7d388584b48bb4a
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 5 10:24:53 2019 +0000

    s4/auth/kerberos: clang: Fix 'value stored to 'ret' is never read '
    
    Fixes:
    
    source4/auth/kerberos/kerberos_pac.c:116:2: warning: Value stored to 'ret' is never read <--[clang]
            ret = smb_krb5_make_pac_checksum(mem_ctx,
            ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 256684c7a86301d26d6cf7298fb70e647bf45cf5
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Wed Jul 24 11:00:01 2019 +1200

    join: Use a specific attribute order for the DsAddEntry nTDSDSA object
    
    Joining a Windows domain can throw an error if the HasMasterNCs
    attribute occurs before msDS-HasMasterNCs. This patch changes the
    attribute order so that msDS-HasMasterNCs is always first.
    
    Previously on python2, the dictionary hash order was arbitrary but
    constant. By luck, msDS-HasMasterNCs was always before HasMasterNCs, so
    we never noticed any problem. With python3, the dictionary hash order
    now changes everytime you run the command, so the order is
    unpredictable.
    
    To enforce a order, we can change to use an OrderedDict, which will
    return the keys in the order they're added.
    
    I've asked Microsoft to clarify the protocol requirement here WRT
    attribute order. However, in the meantime we may as well fix the problem
    for users.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14046
    RN: When trying to join a Windows domain (with functional level 2008R2)
    as an AD domain controller, the 'samba-tool domain join' command could
    throw a python exception: 'RuntimeError ("DsAddEntry failed")'. When
    this problem occurred, you would also see the message "DsAddEntry failed
    with status WERR_ACCESS_DENIED info (8363, 'WERR_DS_NO_CROSSREF_FOR_NC')"
    in the command output. This issue has now been resolved. Note that this
    problem would only occur on Samba v4.10 when using the Python3 packages.
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Jul 24 04:18:21 UTC 2019 on sn-devel-184

commit 630857c71eff6332a6c94292ee840fa86a727f10
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Thu Jun 20 09:20:09 2019 +1200

    traffic_replay: Avoid DB full scans in LDAP searches
    
    When generating LDAP search traffic, a full DB scan can be very costly.
    Avoiding full-scan LDAP searches means that we can run traffic_replay
    against a 100K user DB and get some sane results.
    
    Because the traffic_learner doesn't record the LDAP search filter at all,
    the traffic_replay LDAP searches default to being full scans.
    Doing full scans meant that the LDAP search was usually the first packet
    type to exceed the max latency and fail the test. It could also skew
    results for the other packet types by creating big demands on memory/CPU/
    DB-lock-time.
    
    It's hard to know for sure exactly what real-world LDAP searches will
    look like, but let's assume full scan searches will be fairly rare.
    In traffic-model files we've collected previously, some of the
    attributes are fairly unique (e.g. pKIExtendedKeyUsage), and as there
    are some LDAP queries specified in MS specs (such as MS-GPOL and
    MS-WCCE), it allows us to infer what the search filter might be.
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7abfa6778f309bc3c1cfdb45042f708e81cfad9d
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Jul 18 15:29:26 2019 +1200

    traffic replay test: Populate total_converations and instance_id
    
    Ensure that the total_conversations and instance_id attributes are
    assigned a value in the replay contexts passed to test cases.
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 6d6fe4993876d3374ae7ffeaf55d660ffa6b450b
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Jul 18 13:39:20 2019 +1200

    traffic replay: Store the instance id in the replay context
    
    Store the traffic runner instance id in the replay context.  Will be
    used in subsequent commits.
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 6b1f9b4a5ff5450b0858d27dcc1af3021694be7d
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Thu Jun 13 16:18:27 2019 +1200

    traffic_replay: Make use of SCOPE_BASE explicit
    
    i.e. avoid hard-coded numbers.
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9f504fd5a320edcbd3d763d4e0464f3cf7d270e1
Author: Tim Beale <timbeale at catalyst.net.nz>
Date:   Thu Jun 13 16:04:46 2019 +1200

    traffic_replay: Store total conversations on the replay context
    
    This is useful info to know, and will be used in subsequent commits.
    
    Signed-off-by: Tim Beale <timbeale at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a073799ded5d26dfc7b37b82e7309e06034f95b1
Author: Christof Schmitt <cs at samba.org>
Date:   Thu Jul 18 11:16:33 2019 -0700

    nfs4_acls: Use fsp stat buffer in smb_fget_nt_acl_nfs4
    
    Instead of having a local buffer for the stat data, update the one kept
    in the fsp. With this change the local stat buffer and the helper
    function smbacl4_fGetFileOwner are no longer needed and can be removed.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Tue Jul 23 19:45:05 UTC 2019 on sn-devel-184

commit d28b55198a823f94399698843fa62967bb197a7b
Author: Christof Schmitt <cs at samba.org>
Date:   Thu Jul 18 10:59:14 2019 -0700

    WHATSNEW: Document change of default for nfs4:acedup parameter
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f466f4d3e8435a2e0a4a7ec2ca50e02df1f7869e
Author: Christof Schmitt <cs at samba.org>
Date:   Thu Jul 18 10:22:28 2019 -0700

    docs: Update vfs_gpfs manpage for the new default of nfs4:acedup
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f81191d51bb345ac13402dc4c8100576b4b381cb
Author: Christof Schmitt <cs at samba.org>
Date:   Thu Jul 18 10:13:48 2019 -0700

    nfs4_acls: Change default of nfs4:acedup to "merge"
    
    All tutorials i could find that configure Samba with NFSv4 ACLs set this
    parameter to "merge". As this seems to be the main usecase, make this
    setting the default.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4aac7d37278d7707ac366c48e49f6d7b49ac5380
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jul 17 10:46:45 2019 -0700

    docs: Update manpages for deprecated nfs4:acedup settings
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b52b5de76a87a332d7eb74d77e93180c723bf0b9
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jul 17 10:51:18 2019 -0700

    nfs4_acls: Mark nfs4:acedup ignore and reject as deprecated
    
    The default setting for nfs4:acedup is "dontcare". The only
    recommendation i could find is setting this to "merge". The setting of
    "ignore" is dangerous as it would silently drop ACEs. "reject" also
    seems less useful as it would disallow setting of ACLs that can easily
    be stored.
    
    Report "ignore" and "reject" as deprecated. Maybe these can be removed
    in the future to simplify the code.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ab4e91d24df19ce820bc092cb91cede42d11037d
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jun 19 13:56:57 2019 -0700

    docs: Update nfs4:mode example for vfs_zfs
    
    nfs4:mode special has been deprecated. Switch the example to "simple" to
    avoid the deprecated setting in the example.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit de4a11589f15bd983d9f610f532636ac6233d05c
Author: Christof Schmitt <cs at samba.org>
Date:   Thu Jul 18 12:06:06 2019 -0700

    nfs4_acls: Update copyright header
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 728de59740925665d55c72c7f67c85c7b6b4a5e1
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jun 19 13:53:54 2019 -0700

    nfs4_acls: Add warning for deprecated setting nfs4:mode special
    
    The documentation states this has been deprecated for years. Add logging
    a warning when this is set. Maybe this can be removed in the future.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 54a0b1ca664dcde017dcc46c4398c7c3806ec4c3
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 9 14:41:01 2019 -0700

    nfs4_acls: Use C99 initializer instead of ZERO_STRUCTP for params struct
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3a71d619a935b57acacb6a8ba7c80b0ae938eacd
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jun 19 13:42:19 2019 -0700

    nfs4_acls: Change type of smbacl4_substitute_simple to void
    
    The function always returned true and the return code was never checked,
    so simply change to void.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8f3ebad2e84317997a9be705c809695529455eb6
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jun 19 11:14:20 2019 -0700

    nfs4_acls: Remove unused SMB_ACLTYPE_ defines
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c1770ed96fd3137f45d584ba9328333d5505e3af
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 9 13:39:55 2019 -0700

    vfs_gpfs: Implement special case for denying owner access to ACL
    
    In GPFS, it is not possible to deny ACL or attribute access through a
    SPECIAL_OWNER entry. The best that can be done is mapping this to a
    named user entry, as this one can at least be stored in an ACL. The same
    cannot be done for inheriting SPECIAL_OWNER entries, as these represent
    CREATOR OWNER entries, and the limitation of not being able to deny
    owner access to ACL or attributes remains.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit fbf3a090a9ec94262b2924461cc1d6336af9919c
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 9 13:08:35 2019 -0700

    vfs_gpfs: Move mapping from generic NFSv ACL to GPFS ACL to separate function
    
    This is not functional change. It cleans up the code a bit and makes
    expanding this codepath in a later patch easier.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8bd79ecc37376dbaa35606f9c2777653eb3d55e3
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jul 10 11:06:19 2019 -0700

    docs: Remove gpfs:merge_writeappend from vfs_gpfs manpage
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0aca678fcf1788a76cf0ff11399211c795aa7d2f
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 9 12:04:35 2019 -0700

    vfs_gpfs: Remove merge_writeappend parameter
    
    All supported GPFS versions now support setting WRITE and APPEND in the
    ACLs independently. Remove this now unused parameter to simplify the
    code.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 86f7af84f04b06ed96b30f936ace92aa0937be06
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jul 17 15:29:06 2019 -0700

    nfs4_acls: Use correct owner information for ACL after owner change
    
    After a chown, the cached stat data is obviously no longer valid. The
    code in smb_set_nt_acl_nfs4 checked the file correctly, but did only use
    a local buffer for the stat data. So later checks of the stat buffer
    under the fsp->fsp_name->st would still see the old information.
    
    Fix this by removing the local stat buffer and always update the one
    under fsp->fsp_name->st.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1a137a2f20c2f159c5feaef230a2b85bb9fb23b5
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jul 10 13:14:32 2019 -0700

    nfs4_acls: Add test for merging duplicates when mapping from NFS4 ACL to DACL
    
    The previous patch introduced merging of duplicates on the mapping path
    from NFS4 ACL entries to DACL entries. Add a testcase to verify the
    expected behavior of this codepath.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9c88602128592ddad537bf70cbe3c51f0b2cebe5
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 15:08:11 2019 -0700

    nfs4_acls: Remove duplicate entries when mapping from NFS4 ACL to DACL
    
    The previous patch added an additional entry for IDMAP_TYPE_BOTH. When
    mapping back to a DACL, there should be no additional entry. Add a loop
    that will check and remove entries that are exact duplicates.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 169812943de23cf2752289c63331d786b0b063bd
Author: Christof Schmitt <cs at samba.org>
Date:   Thu Jul 18 11:49:29 2019 -0700

    nfs4_acls: Rename smbacl4_fill_ace4 function
    
    As this function now maps the ACE and also adds it to the NFSv4 ACE,
    change the name to better describe its behavior.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b796119e2df38d1935064556934dd10da6f3d339
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jul 17 10:49:47 2019 -0700

    nfs4_acls: Add additional owner entry when mapping to NFS4 ACL with IDMAP_TYPE_BOTH
    
    With IDMAP_TYPE_BOTH, all entries have to be mapped to group entries.
    In order to have the file system reflect the owner permissions in the
    POSIX modebits, create a second entry for the user. This will be mapped
    to the "special owner" entry.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit aa4644193635d846c2e08e8c1e7b512e8009c2ef
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 16 15:56:12 2019 -0700

    nfs4_acls: Remove redundant pointer variable
    
    The previous patch introduced a pointer to a local variable to reduce
    the amount of lines changed. Remove that pointer and adjust all usage
    accordingly.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7ab0003ffc098247c3ee3962d7061f2af5a2d00e
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 16 15:50:36 2019 -0700

    nfs4_acls: Remove redundant logging from smbacl4_fill_ace4
    
    Logging flags in case they do not match seems unnecessary. Other log
    messages should show the flags as well.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit abb58b17599bd3f9a06037e208dcc5033c7fdd8b
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 16 15:30:36 2019 -0700

    nfs4_acls: Move adding of NFS4 ACE to ACL to smbacl4_fill_ace4
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3499d97463110f042415d917160bc2743805a544
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 16 15:20:25 2019 -0700

    nfs4_acls: Move smbacl4_MergeIgnoreReject function
    
    This static function will be called earlier in later patches.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 44790721e4f2c6ee6f46de7ac88123ce1a9f6e39
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jul 15 14:43:01 2019 -0700

    nfs4_acls: Remove i argument from smbacl4_MergeIgnoreReject
    
    This is only used for logging of a rejected ACL, but does not provide
    additional useful information. Remove it to simplify the function a bit.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ba73d2363d93a376ba4947963c9de45a7e683f02
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 13:20:44 2019 -0700

    nfs4_acls: Add missing braces in smbacl4_win2nfs4
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 336e8668c1cc3682cb3c198eb6dc49baf522a79a
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jun 26 13:20:17 2019 -0700

    nfs4_acls: Add helper function for checking INHERIT flags.
    
    This avoids some code duplication. Do not make this static, as it will
    be used in a later patch.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmit <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3b3d722ce579c19c7b08d06a3adea275537545dc
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jun 25 15:21:06 2019 -0700

    nfs4_acls: Use correct type when checking ownerGID
    
    uid and gid are members of the same union so this makes no difference,
    but for type correctness and readability use the gid to check for
    ownerGID.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f198a0867e71f248d4887ab0b6f2832123b16d11
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jul 15 13:15:32 2019 -0700

    nfs4_acls: Use switch/case for checking idmap type
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d9a2ff559e1ad953141b1118a9e370496f1f61fa
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Jun 26 13:24:16 2019 -0700

    nfs4_acls: Use sids_to_unixids to lookup uid or gid
    
    This is the newer API to lookup id mappings and will make it easier to
    add to the IDMAP_TYPE_BOTH case.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 38331b00521ef764893a74add01758f14567d901
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 13:04:44 2019 -0700

    test_nfs4_acls: Add test for mapping from DACL to NFS4 ACL with IDMAP_TYPE_BOTH
    
    When id mappings use IDMAP_TYPE_BOTH, the NFSv4 ACL mapping code is not
    aware whether a particular entry is for a user or a group. The
    underlying assumption then is that is should not matter, as both the ACL
    mapping maps everything to NFSv4 ACL group entries and the user's token
    will contain gid entries for the groups.
    
    Add a testcase to verify that when mapping from DACLS to NFSv4 ACL
    entries with IDMAP_TYPE_BOTH, all entries are mapped as expected.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 86480410aec1d2331c65826a13f909492165a291
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 12:50:42 2019 -0700

    test_nfs4_acls: Add test for mapping from NFS4 ACL to DACL with IDMAP_TYPE_BOTH
    
    When id mappings use IDMAP_TYPE_BOTH, the NFSv4 ACL mapping code is not
    aware whether a particular entry is for a user or a group. The
    underlying assumption then is that is should not matter, as both the ACL
    mapping maps everything to NFSv4 ACL group entries and the user's token
    will contain gid entries for the groups.
    
    Add a testcase to verify that when mapping from NFSv4 ACL entries to
    DACLs with IDMAP_TYPE_BOTH, all entries are mapped as expected.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 829c5ea99685c0629fd67ed0528897534ff35b36
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 12:23:02 2019 -0700

    test_nfs4_acls: Add test for mapping from NFS4 to DACL in config mode special
    
    The mapping code between NFSv4 ACLs and security descriptors still has
    the deprecated config setting "nfs4:mode = special". This should not be
    used as it has security problems: All entries matching owner or group
    are mapped to "special owner" or "special group", which can change its
    meaning when being inherited to a new file or directory with different
    owner and owning group.
    
    This mode should eventually be removed, but as long as it still exists
    add testcases to verify the expected behavior. This patch adds the
    testcase for "nfs4:mode = special" when mapping from the NFS4 ACL to the
    DACL in the security descriptor.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7ae06d96eb59722154d30e21949f9dba4f2f0bc6
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 12:16:08 2019 -0700

    test_nfs4_acls: Add test for mapping from DACL to NFS4 ACL with config special
    
    The mapping code between NFSv4 ACLs and security descriptors still has
    the deprecated config setting "nfs4:mode = special". This should not be
    used as it has security problems: All entries matching owner or group
    are mapped to "special owner" or "special group", which can change its
    meaning when being inherited to a new file or directory with different
    owner and owning group.
    
    This mode should eventually be removed, but as long as it still exists
    add testcases to verify the expected behavior. This patch adds the
    testcase for "nfs4:mode = special" when mapping from the DACL in the
    security descriptor to the NFSv4 ACL.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f55cdf42a14f314102f2e13cb06d4db48c08ad4b
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 12:09:04 2019 -0700

    test_nfs4_acls: Add test for matching DACL entries for acedup
    
    The NFSv4 mapping code has a config option nfs4:acedup for the mapping
    path from DACLs to NFSv4 ACLs. Part of this codepath is detecting
    duplicate ACL entries. Add a testcase with different ACL entries and
    verify that only exactly matching entries are detected as duplicates and
    treated accordingly.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9671bf2b9f055012057620207624aa2f4ea6833e
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 12:07:36 2019 -0700

    test_nfs4_acls: Add test for acedup settings
    
    The NFSv4 ACL mapping code has a setting nfs4:acedup. Depending on the
    setting, when mapping from DACLs to NFSv4 ACLs, duplicate ACL entries
    are either merged, ignored or rejected. Add a testcase that has
    duplicate ACL entries and verify the expected behavior for all possible
    settings of the nfs4:acedup option.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 30677df4dac4ebfcf4e3198db33f14be37948197
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 12:02:58 2019 -0700

    test_nfs4_acls: Add test for 'map full control' option
    
    "map full control" when enabled adds the DELETE_CHILD permission, when
    all other permissions are present. This allows Windows clients to
    display the "FULL CONTROL" permissions.
    
    Add a testcase that verifies this mapping when mapping from NFSv4 ACL to
    the DACL in the security descriptor. Also verify that switching the
    option off disables this behavior.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3c9cda0f6d80258ef0c2a80d6e24dfb650fea1b1
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:57:45 2019 -0700

    test_nfs4_acls: Add test for mapping from NFS4 to DACL CREATOR entries
    
    Add testcase for mapping from NFSv4 ACL entries for "special owner" and
    "special group" to DACL entries in the security descriptor. Each NFSv4
    entry here with INHERIT_ONLY maps directly to a CREATOR OWNER or CREATOR
    GROUP entry in the DACL. Entries without INHERIT_ONLY map to the CREATOR
    entry and an additional explicit entry granting permission on the
    current object.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit bfcc19b705f83bdd5cf665fd4daf43e7eae997a9
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:55:59 2019 -0700

    test_nfs4_acls: Add test for mapping CREATOR entries to NFS4 ACL entries
    
    Add testcase for mapping DACL entries CREATOR OWNER and CREATOR GROUP
    with inheritance flag in the security descriptor to NFSv4 "special
    owner" and "special group" entries. This is the correct mapping for
    these entries as inheriting "special owner" and "special group" grants
    permissions to the actual owner and owning group of the new file or
    directory, similar to what CREATOR entries do.
    
    The other side is that CREATOR entries without any inheritance flags do
    not make sense, so these are not mapped to NFSv4 ACL entries.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1f1fa5bde2c76636c1beec39c21067b252ea10be
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:53:15 2019 -0700

    test_nfs4_acls: Add test for mapping from DACL to special NFS4 ACL entries
    
    Add testcase for mapping from entries in the DACL security descriptor to
    "special" entries in the NFSv4 ACL. Verify that the WORLD well-known SID
    maps to "everyone" in the NFSv4 ACL. Verify that the "Unix NFS" SID is
    ignored, as there is no meaningful mapping for this entry. Verify that
    SID entries matching the owner or group are mapped to "special owner"
    or "special group", but only if no inheritance flags are used. "special
    owner" and "special group" with inheritance flags have the meaning of
    CREATOR OWNER and CREATOR GROUP and will be tested in another testcase.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f86148948c7f89307a34e31f6ddede6923149d34
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:46:23 2019 -0700

    test_nfs4_acls: Add test for mapping of special NFS4 ACL entries to DACL entries
    
    In addition to entries for users and groups, NFSv4 ACLs have the concept
    of entries for "special" entries. Only the "owner", "group" and
    "everyone" entries are currently used in the ACL mapping.
    
    Add a testcase that verifies the mapping from NFSv4 "special" entries to
    the DACL in the security descriptor. Verify that only "owner", "group"
    and "everyone" are mapped and all other "special" entries are ignored.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e4840e680744bd860beedeb5123704c3c0d6a4d7
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:35:34 2019 -0700

    test_nfs4_acls: Add test for mapping permissions from DACL to NFS4 ACL
    
    Add testcase for mapping the permission flags from the DACL in the
    Security Descriptor to a NFSv4 ACL. The mapping is straight-forward as
    the same permission bits exist for Security Descriptors and NFSv4 ACLs.
    In addition, the code also maps from the generic DACL permissions to a
    set of NFSv4 permissions, also verify this mapping.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1767027b44a9e4ebd865022e3f8abb0c72bf15c6
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:33:29 2019 -0700

    test_nfs4_acls: Add test for mapping permissions from NFS4 ACL to DACL
    
    Add testcase for mapping permissions from the NFSv4 ACL to DACL in the
    security descriptor. The mapping is simple as each permission bit exists
    on both sides.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit bccd2612761e26ee2514935d56927b2c0c000859
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:30:12 2019 -0700

    test_nfs4_acls: Add test for flags mapping from DACL to NFS4 ACL
    
    Add testcase for the mapping of inheritance flags from the DACL in the
    security descriptor to the NFSv4 ACL. The mapping is different for files
    and directories as some inheritance flags should not be present for
    files. Also other flags are not mapped at all, verify this behavior.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 16eb61a900c6749c2554d635ce2dd903f5de1704
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:28:31 2019 -0700

    test_nfs4_acls: Add test for flags mapping from NFS4 ACL to DACL
    
    Add testcase for the mapping of inheritance flags when mapping from a
    NFSv4 ACL to a DACL in the security descriptor. The mapping is different
    between files and directories, as some inheritance flags should never be
    present for files. Some defined flags like SUCCESSFUL_ACCESS are also
    not mapped at this point, also verify this behavior.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit dd5934797526ebb4c6f3027a809401dad3abf701
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:25:33 2019 -0700

    test_nfs4_acls: Add tests for mapping of ACL types
    
    Add testcases for mapping the type field (ALLOW or DENY) between NFSv4
    ACLs and security descriptors.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 00f494b25f4e1d1aecf6191523e30f20a90b1e4f
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:23:40 2019 -0700

    test_nfs4_acls: Add tests for mapping of empty ACLs
    
    This is a fairly simple test that ensures the mapping of empty ACLs
    (without any ACL entries) is always done the same way.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8fb906a1860452a320c79ac87917a97303729c19
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jul 2 11:22:13 2019 -0700

    selftest: Start implementing unit test for nfs4_acls
    
    Existing smbtorture tests set and query ACLs through SMB, only working
    with the DACLs in the Security Descriptors, but never check the NFSv4
    ACL representation. This patch introduces a unit test to verify the
    mapping between between Security Descriptors and NFSv4 ACLs. As the
    mapping code queries id mappings, the id mapping cache is first primed
    with the mappings used by the tests and those mappings are removed again
    during teardown.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a06486bb110d04a90b66a0bca4b1b600ef3c0ebf
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Jun 11 16:15:10 2019 -0700

    nfs4_acls: Remove fsp from smbacl4_win2nfs4
    
    Only the information whether the ACL is for a file or a directory is
    required. Replacing the fsp with a flag is clearer and allows for unit
    testing of the mapping functions.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 42bd3a72a2525aa8a918f4bf7067b30ce8e0e197
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jun 7 12:55:32 2019 -0700

    Revert "nfs4acl: Fix owner mapping with ID_TYPE_BOTH"
    
    This reverts commit 5d4f7bfda579cecb123cfb1d7130688f1d1c98b7.
    
    That patch broke the case with ID_TYPE_BOTH where a file is owned by a
    group (e.g. using autorid and having a file owned by
    BUILTIN\Administrators). In this case, the ACE entry for the group gets
    mapped a to a user ACL entry and the group no longer has access (as in
    the user's token the group is not mapped to a uid).
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14032
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0348dd4b31062b2cf12d19ec5515a309d1d9b470
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Jul 10 16:24:46 2019 +1200

    dcerpc: use anon creds for unknown transport
    
    Otherwise we get a segfault when the NULL creds are dereferenced in cli_credentials_is_anonymous()
    
     $  python3 -c"from samba.dcerpc.dnsserver import dnsserver; d = dnsserver('addc')"
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Mon Jul 22 23:37:57 UTC 2019 on sn-devel-184

commit 3d33e336267f54e1fe344bf1a83af88092c5ad43
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Jul 9 22:52:33 2019 +1200

    s4/auth/py: avoid null deref with bad python arguments
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 936c96620743b75d3177b787cd50478d346c5870
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Jul 9 22:52:19 2019 +1200

    s4/gensec/py: avoid null deref with bad python arguments
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f3b65ff4e5e27e65574a69ee72ac017cd6b3f93c
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Jul 9 22:51:38 2019 +1200

    s3/smbd/py: avoid null deref with bad python arguments
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a2680b44358b2e85354c88c3fdd525327835e43a
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Jul 9 22:51:18 2019 +1200

    s3/libsmb/py: avoid null deref with bad python arguments
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 57fc8b6c5369d99b544ff0f43720b9670e018a2a
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Jul 7 17:23:23 2019 +1200

    s4/auth/pygensec: don't segfault when reporting bad types
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a5e8a5e05bcb89a3fc36044ce89ac49df2f00d03
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Jul 9 23:07:18 2019 +1200

    auth/pycreds/encrypt_netr_crypt_password: don't pretend arg is optional
    
    The "|O" signature is saying the password argument is optional, which
    makes no sense in terms of the funxtion and immediately leads to a
    TypeError (or until last commit, segfault). Removing the "|" leaves it
    with a TypeError, but it is better worded and faster.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f8fb6f326129267c7742947943df3f920c8cb54f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Jul 7 13:47:51 2019 +1200

    auth/pycreds/encrypt_netr_crypt_password: don't segfault
    
    Non-talloc objects were treated as talloc objects, to no good effect
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 95a5140db3e84478b903f9e96fc34e87db2c07c6
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Jul 7 12:14:50 2019 +1200

    pysecurity: use unsigned int, not int to approximate uint32_t
    
    the "I" flag for unsigned int has been available since Python 2.3
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0d0a88fc6a4371bf3666186792f253cacf2f1378
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Jul 6 19:09:57 2019 +1200

    pycredentials.h: use import to ensure python type correctness
    
    Because we include pyrpc_util.h, pycredentials doesn't need its own
    PyStringFromStringOrNull().
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c9c1d444881d4464842cfc19fcb5ddd41c58dfa9
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Jul 6 19:07:11 2019 +1200

    auth/pycredentials: always check self is a Credentials object
    
    This prevents a segfault with
    
        credentials.Credentials.guess(x)
    
    where x is not a Credentials object.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2d1c269a9e4b4bdf8bffc91fcb63778e03097b3e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jul 5 23:01:39 2019 +1200

    s4/rpc/py_security: don't deref NULL for invalid values
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5405f2ad7edc0dc04707e2c7472705c534cb11e8
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jul 4 22:21:36 2019 +1200

    s4/py_dsdb: avoid NULL deref in set_domain_sid()
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 99c43354ef5387b708cf0f527f39a86b43c0e979
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Jul 9 09:45:03 2019 +0000

    libcli/pysecurity: use pytalloc_get_name to avoid NULL deref
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cd20e3876c368556781ff0c8c14527b9339d3cad
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Jul 22 13:42:37 2019 +1200

    talloc: Release talloc 2.3.0
    
    * add pytalloc_get_name() to safely access te talloc name in Python bindings
    * Use a new minor version to allow talloc updates in the 4.11 release stream
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz

commit ac23eeb41c3d27d710722f94e22dd84410d183d3
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Jul 7 12:34:37 2019 +1200

    talloc/py_util: remove tautologically dead code
    
    Being careful is good and all, but if we don't trust the
    
           static PyTypeObject *type = NULL;
    
    two lines up, we need to reconsider our entire software universe.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dc20e7c6df7a230c3b3cd9ae7de79e4cacc36eb4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Jul 9 09:44:12 2019 +0000

    talloc: pytalloc_get_checked_type: survive non-talloc objects
    
    If the python object is not a talloc object, we will end up
    with a NULL pointer. We weren't checking for that properly
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4496e073cbd0f78bcaa2cf340336e1a14bd6e8e6
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Jul 9 08:59:19 2019 +0000

    talloc: add pytalloc_get_name() helper
    
    In several places we go
    
       talloc_get_name(pytalloc_get_ptr(py_obj))
    
    which is a certain NULL derefernce if py_obj is not a talloc object.
    
    This is a helper function that chooses to say "non-talloc object"
    rather than crash.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3383390b4b82e49865792b839af1e8fb798113ca
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jul 5 09:37:13 2019 +1200

    tests/py-segfault: add messaging.deregister()
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c3a52e4c40a819ccaa5b4dab41f74afc8bff3d5c
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jul 4 22:19:55 2019 +1200

    py segfault test: registry.open_hive
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c1e649fd473885c0cb779344fc7089a245c7b17d
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 26 13:38:40 2019 +0100

    s3:rpc_server: Call server exit routines in sigterm handler
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Mon Jul 22 18:04:53 UTC 2019 on sn-devel-184

commit ee6fb27c59ba33967f6c8ea473b6938c501f71b6
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 26 13:35:09 2019 +0100

    s3:rpc_server: Call epmapper RPC shutdown function from server exit routines
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 63a39ef605176f6d6adef7dd95ae430d344a36bb
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 26 13:33:12 2019 +0100

    s3:rpc_server: Call fsrvp RPC shutdown function from server exit routines
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7a167b3751c5e955d757b7397f4d596e5b93c140
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 26 13:24:33 2019 +0100

    s3:rpc_server: Call server exit routines in sigterm handler
    
    The exit server routines already call rpc shutdown functions
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6be10e6d439dbeadeac7cb8b11c32c13ea6b8b83
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 26 13:59:54 2019 +0100

    s3:rpc_server: Improve debug messages
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a2c943f52d39cedd5b7d9cbb3ed1f34fe62988fc
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Feb 27 16:52:20 2019 +0100

    s3:rpc_server:spoolssd: Move socket creation to its own function
    
    The function also handles the registration in the endpoint mapper.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit dde08e8f262633c017c8288991c9e894cb72d0d8
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 21:06:02 2019 +0100

    s3:rpc_server: Return NTSTATUS in is_known_pipename function
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f7529fffce6de70a6914e17f91876d721e02b219
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 21:04:00 2019 +0100

    s3:rpc_server: Make make_external_rpc_pipe_p and np_proxy_state private
    
    This function and struct is not used outside rpc_ncacn_np.c
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4d42b7cde208982f2344e0519ebbf6de5da2ec32
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Feb 14 14:22:49 2019 +0100

    s3:rpc_server: Check pointer before dereference
    
    The debug message dereference the pointer, but as close_policy_by_pipe
    is called from pipes_struct destructor it may be not initialized yet if
    an error occur in the initialization code.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 0c04daf52351b105fd8e8dd28703c290f369a3cd
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 11 11:47:56 2019 +0100

    s3:rpc_server: Rename dcesrv_handle struct
    
    The name conflicts with the S4 name.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit cdaf06abadc92796d6c84f0e95172519071f1fa5
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 20:28:05 2019 +0100

    s3:rpc_server: Unify RPC client disconnect and termination functions
    
    These functions are used by endpoint mapper to delete the endpoints
    when a NCALRPC connection from an external daemon is lost and by
    preforked childs to accept the next client as soon as the current
    connection terminates. We can use the same function for both purposes.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5865cf4dd98bfe9c780d4ed4b8fe630a4a9949d0
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 20:27:31 2019 +0100

    s3:spoolss: Set remote and local address for accepted connections
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5d8e13413c3ce6c68c6bc06f77194e3098ccaf56
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Feb 13 10:48:54 2019 +0100

    s3:rpc_server: Return NTSTATUS in make_internal_rpc_pipe_p
    
    Also make it static as it is not used outside rpc_ncacn_np.c
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6f07f46771a741142f603635d988394de5e17e66
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 5 19:27:58 2019 +0100

    s3:rpc_server: Set debug class in all rpc server related files
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 01c6602dd250b62234e20bd79a46241782863ba0
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Feb 27 16:54:49 2019 +0100

    s3:rpc_server: Initialize auxiliary variable checked in error path
    
    The auxiliary variable is checked in the function's exit code so reset
    it after each usage.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6964348bbfc8781be76ebd6a9f931648843a22f9
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Jan 28 10:57:53 2019 +0100

    s3:prefork: Allow to associate private data with listening socket
    
    Prepare for merger RPC server codebase, where it will be necessary to
    stablish an association between the listening socket and the
    dcesrv_endpoint that the socket is serving.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 85201cc76b4990b287681bd248c3c1b91a9f97be
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 19:38:08 2019 +0100

    s3:rpc_server: Remove named_pipe_client struct and use dcerpc_ncacn_conn
    
    Now NCACN_NP connections run the same loop as NCACN_IP_TCP and NCALRPC
    connections.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 82759189d16449d7e4cb23a353d99e2254437898
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 19:34:38 2019 +0100

    s3:rpc_server: Check remote address supplied to dcerpc_ncacn_accept
    
    Check if the supplied tsocket_address is valid before changing the
    talloc chunk parent to the ncacn_conn struct.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit c976d456d2f564764cd1a12f2d1fe37ae4023d17
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 19:33:29 2019 +0100

    s3:rpc_server: Make dcerpc_ncacn_packet_process public
    
    In preparation to remove the named_pipe_client struct, this function
    will be set as tevent callback from rpc_ncacn_np.c
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 2e938e22ac9484ccefd266ceed590cfbf5c01599
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 19:31:04 2019 +0100

    s3:rpc_server: Add a function to initialize the dcerpc_ncacn_conn struct
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 52c3bebd23e0343dfc1b34bbe2e894ca62974be1
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 19:24:54 2019 +0100

    s3:rpc_server: Split dcerpc_ncacn_accept to deal with tstream_npa
    
    In preparation to remove the named_pipe_client struct split the function
    if two parts and build the tstream context as soon as possible, as it
    will take care of closing the socket when the tstream_context is freed.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 61fb17f85bf7c6a33253d9b34a044d614b733c2b
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 18:48:57 2019 +0100

    s3:rpc_server: Add termination function and data to dcerpc_ncacn_conn
    
    In preparation to remove the named_pipe_client structure, this function
    will be called from ncacn_conn destructor passing the private data pointer
    as argument. It is mainly used by preforked childs in "process model" to
    attend the next client as soon as the previous client ends the connection.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit cc6342e7a5e955c55319021ec3cd2ed5800c40f6
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 18:25:48 2019 +0100

    s3:rpc_server: Move dcerpc_ncanc_conn to header file
    
    Next commits will remove named_pipe_client and dcerpc_ncacn_connection
    will be used in its place. It has to be moved to a header file as it
    will be used by functions in rpc_server.c and rpc_ncacn_np.c.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d8d7c981218ca2daac3234330b03b011efc9d5ba
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 5 13:34:39 2019 +0100

    s3:rpc_server: Set dcerpc_ncacn_connection destructor
    
    And call disconnection callback from there if it is set.
    Additionally change named_pipe_termination_fn to have * in typedef.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fdfa0e0a01a4f202a0166f878b160dc7aa430633
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 31 21:57:04 2019 +0100

    s3:epmapper: Rename conflicting struct
    
    Rename an epmapper internal struct which will conflict when merging s3
    and s4 rpc servers.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6ac170267ca269bea80cfa16207b3670f1e4a26d
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Sun Feb 3 22:33:53 2019 +0100

    s3-prefork: Add header inclusion guards
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d1d37a0a6e79f448fbf7443a4554e16e49b44131
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 31 16:42:35 2019 +0100

    s3:rpc_server: Return NTSTATUS in rpc_ep_setup and setup functions
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7ee4dff9da219d666a8286623ab556b6b5504bd6
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 17:28:34 2019 +0100

    s3:rpc_server: Fix hidden strict aliasing issues
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8cb921d2550e4880d29ea7daf13b57fcb7d31936
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 17:27:46 2019 +0100

    lib:tsocket: New function to build a tsocket_context from samba_address
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 0a65fa8a9a720029b20037259e2e76525bcfafef
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 17:09:14 2019 +0100

    s3:utils: New struct to fix strict aliasing issues with sockets API
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 60b7b791876ef8affce8c770fb6bf11030ab2c50
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 18 17:05:54 2019 +0100

    s3:rpc_server: Fix code formatting and improve debug messages
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f527964f72af3c31ba16de40756ab468da5924c9
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Feb 20 09:28:55 2019 +0100

    s3:rpc_server: Set the endpoint name to "IP" on ncacn_ip_tcp listener
    
    This matchs what lsasd and mdssd does.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fd62ab62aed2702c5646242b6400455f9fa4e391
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Feb 6 09:11:47 2019 +0100

    s3:spoolss: Exit if fork call fails
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 2cb4a9c6e8d31249131b0ba19579c5879c956104
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 17:04:32 2019 +0200

    s3:rpc_server: Use talloc_zero for dcerpc_ncacn_listen_state
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1f2caa4101a29736db38c22036268f0a612420cb
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 17:02:18 2019 +0200

    s3:rpc_server: Use new debug macros in dcesrv_setup_ncalrpc_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5a544864245d06630684a173d6a27aa605b79f34
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 17:00:30 2019 +0200

    s3:rpc_server: Return NTSTATUS for dcesrv_setup_ncalrpc_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1a1f31e0820d33edc600d9ad1dc53d63c68f3d4e
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 16:56:17 2019 +0200

    s3:rpc_server: Rename setup_dcerpc_ncalrpc_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit cbf497dc0956f4685c8991b4499d3d6c56a5214a
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 16:50:38 2019 +0200

    s3:rpc_server: Use new debug macros in dcesrv_setup_ncacn_ip_tcp_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ae14c51080c6b69edb0364b79a9cecde62e2684f
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 16:45:07 2019 +0200

    s3:rpc_server: Return NTSTATUS for dcesrv_setup_ncacn_ip_tcp_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a6b5899853c95b6b9c3f438af86c5103c0dc4a9d
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 16:39:36 2019 +0200

    s3:rpc_server: Rename setup_dcerpc_ncacn_tcpip_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 3f4be0b9dbdf89d09358ab6897feadad477f0ed1
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jan 22 16:32:51 2019 +0100

    s3:rpc_server: Rename rpc_create_tcpip_sockets
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit edc8ef722c86055abbb5438dc6b4df236a465b96
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jan 22 16:20:38 2019 +0100

    s3:rpc_server: Rename dcerpc_ncacn_tcpip_listener
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6b2aefc579f584c22a4b64c189f883222d8e928c
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 16:20:52 2019 +0200

    s3:rpc_server: Use new debug macros for dcesrv_create_ncacn_ip_tcp_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e3999a14daa40ccdfab379aa84da615b47e0f447
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 16:16:36 2019 +0200

    s3:rpc_server: Return NTSTATUS for dcesrv_create_ncacn_ip_tcp_socket
    
    Additionally to the fd number, check the port number has been correctly
    assigned. This check was performed by the callers of this function.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b7817eaf3d3120a41e38d913d41e4fa3433f78d3
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 16:02:54 2019 +0200

    s3:rpc_server: Rename create_tcpip_socket
    
    Additionally move function declaration from proto.h to rpc_server.h
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5ed7ee7279911fc98b9f81dddc6f396d368ab2c8
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jun 4 14:12:56 2019 +0200

    s3:rpc_server: simplify the error checking of create_tcpip_socket() callers
    
    create_tcpip_socket() never returns a valid fd and left port as 0.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit b52d58d6e1841f4c0d3d9f6c386e60e761ef4b1e
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jan 22 15:50:38 2019 +0100

    s3:rpc_server: Rename named_pipe_listener
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fc3d582ccab2bbb7ca04b2fddf57db1ad7e7016e
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 15:48:27 2019 +0200

    s3:rpc_server: Switch to new debug macros for dcesrv_setup_ncacn_np_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e05ce7b9e75b8fc36f04c25f51f21dcdc463c737
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 15:46:03 2019 +0200

    s3:rpc_server: Return NTSTATUS for dcesrv_setup_ncacn_np_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b6537c15c1623c3141e64537b2998ddae8cc6db9
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 15:34:11 2019 +0200

    s3:rpc_server: Rename setup_named_pipe_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 3fdd4dc03adad694f01cf1fb3fe9e3a7cd666dac
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 15:23:22 2019 +0200

    s3:rpc_server: Switch to new debug macros for dcesrv_create_ncacn_np_socket
    
    Additionally messages are improved.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4a5c440b089d1232fe3c11e42ec39d96c3cc0e0a
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 15:15:11 2019 +0200

    s3:rpc_server: Return NTSTATUS for dcesrv_create_ncacn_np_socket
    
    The 'fd' state struct member is initialized after allocation because it
    is checked in the error path.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7f8f857dfea7a2474bd109339f3ba7627f0e0e65
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 14:39:03 2019 +0200

    s3:rpc_server: Rename create_named_pipe_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit af576d335adc75a4bca03fd42d9e510eae841e27
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jan 22 14:34:17 2019 +0100

    s3:rpc_server: Rename dcerpc_ncalrpc_listener
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 05507d4d19804dfd57b85dd7e20bdad4b3d9781e
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 14:21:11 2019 +0200

    s3:rpc_server: Switch to new debug macros for dcesrv_create_ncalrpc_socket
    
    Additionally new debug messages are added and the existing ones improved.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 3153814db4a4ad667218f47ff610c5b43678aabf
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 14:17:03 2019 +0200

    s3:rpc_server: Return NTSTATUS for dcesrv_create_ncalrpc_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit c0b1884c99e1e89f2a7864e72a7064c0c62fad46
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Jun 4 13:59:23 2019 +0200

    s3:rpc_server: Rename create_dcerpc_ncalrpc_socket
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 0bcfc550b1a902e3a6a766b06603ac9285d0ff63
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Thu Jul 18 14:50:57 2019 +1200

    gp_inf: Read/write files with a UTF-16LE BOM in GptTmpl.inf
    
    Regression caused by 16596842a62bec0a9d974c48d64000e3c079254e
    
    [MS-GPSB] 2.2 Message Syntax says that you have to write a BOM which I
    didn't do up until this patch. UTF-16 as input encoding was marked much
    higher up in the inheritance tree, which got overriden with the Python 3
    fixes. I've now marked the encoding much more obviously for this file.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14004
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Fri Jul 19 02:20:47 UTC 2019 on sn-devel-184

commit b0fc1ca65abd49d5391ea1213c78c2bc22641c36
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jul 17 21:52:55 2019 +0200

    lib: Fix the 32-bit build
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Jul 18 12:55:30 UTC 2019 on sn-devel-184

commit 664eed2e926f8f572b81e6d7c8e09b7ccbafb908
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Mar 18 17:03:30 2019 +0100

    lib:util: Use GnuTLS random number generator in genrand.c
    
    FIPS requires that a random number generator from a certified crypto
    library is used.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Jul 18 01:30:20 UTC 2019 on sn-devel-184

commit 69cca061a4e176c3d23f5f0771893011adafc940
Author: Volker Lendecke <vl at samba.org>
Date:   Wed May 1 15:34:22 2019 +0200

    lib: Optimize file_compare
    
    Triggered by two coverity false positives. Loading both files into
    talloc'ed memory seems inefficient to me. Rely on stdio to do proper
    buffering. This removes the restriction from ae95d611: "It is meant for
    small files".
    
    This is more lines, but to me it has less implicit complexity.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    
    Autobuild-User(master): Uri Simchoni <uri at samba.org>
    Autobuild-Date(master): Wed Jul 17 12:45:51 UTC 2019 on sn-devel-184

commit 79e3b1c71f59591c54e87299984e50d2ffb00b6b
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 9 20:04:03 2019 +0200

    smbd: Increase a debug level
    
    This is not a real error, it happens when the share mode record is not
    around.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit ee2fe56ba0ef6626b634376e8dc2185aa89f8c99
Author: Aaron Haslett <aaronhaslett at catalyst.net.nz>
Date:   Tue Nov 27 11:07:44 2018 +1300

    drepl: memory leak fix
    
    Fixes a memory leak where schema reference attached to ldb
    instance is lost before it can be freed.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14042
    
    Signed-off-by: Aaron Haslett <aaronhaslett at catalyst.net.nz>
    
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>
    
    Autobuild-User(master): Garming Sam <garming at samba.org>
    Autobuild-Date(master): Wed Jul 17 06:17:10 UTC 2019 on sn-devel-184

commit c4613521723e3ab9b462d75485a514ca16595226
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 11:50:18 2019 +0000

    s3/lib/smbconf: clang: 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/lib/smbconf/smbconf_reg.c:123:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
            WERROR werr = WERR_OK;
                   ^~~~   ~~~~~~~
    source3/lib/smbconf/smbconf_reg.c:178:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
            WERROR werr = WERR_OK;
                   ^~~~   ~~~~~~~
    source3/lib/smbconf/smbconf_reg.c:444:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
            WERROR werr = WERR_OK;
                   ^~~~   ~~~~~~~
    source3/lib/smbconf/smbconf_reg.c:583:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
            WERROR werr = WERR_OK;
                   ^~~~   ~~~~~~~
    source3/lib/smbconf/smbconf_reg.c:712:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
            WERROR werr = WERR_OK;
                   ^~~~   ~~~~~~~
    source3/lib/smbconf/smbconf_reg.c:995:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
            WERROR werr = WERR_OK;
                   ^~~~   ~~~~~~~
    source3/lib/smbconf/smbconf_reg.c:1103:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
            WERROR werr = WERR_OK;
                   ^~~~   ~~~~~~~
    7 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Wed Jul 17 00:07:48 UTC 2019 on sn-devel-184

commit b388c217d4fa0d2451a5d949b4fdf5a778d814a1
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 11:45:01 2019 +0000

    s3/lib: clang: 'Value stored to 'rta' is never read'
    
    Fixes:
    source3/lib/addrchange.c:217:2: warning: Value stored to 'rta' is never read <--[clang]
            rta = IFA_RTA(ifa);
            ^     ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 963f58fb622f20d58f9dab2d5f474c7eec58a8e2
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 11:35:35 2019 +0000

    s3/registry: clang: Fix 'initialization value is never read'
    
    Fixes:
    
    source3/registry/reg_backend_db.c:853:9: warning: Value stored to 'result' during its initialization is never read <--[clang]
            WERROR result = WERR_OK;
                   ^~~~~~   ~~~~~~~
    
    source3/registry/reg_backend_db.c:1677:2: warning: Value stored to 'len' is never read <--[clang]
            len = 0;
            ^     ~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 80e57a10164cc8482f0611cbce4086521051ec9b
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 11:26:06 2019 +0000

    s3/registry: clang: Fix 'initialization value is never read'
    
    Fixes:
    
    source3/registry/reg_api.c:139:14: warning: Value stored to 'result' during its initialization is never read <--[clang]
            WERROR          result = WERR_OK;
                            ^~~~~~   ~~~~~~~
    ource3/registry/reg_api.c:958:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
            WERROR werr = WERR_OK;
                   ^~~~   ~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e3e9330609b527a101dfde9a1109da7cb389ed32
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 11:22:43 2019 +0000

    s3/lib: clang: Fix 'passed-by-value struct argument contains uninit-ed data'
    
    Fixed:
    
    g_lock.c:358:21: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'pid') <--[clang]
            state->watch_req = dbwrap_watched_watch_send(
                               ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 6ea9c795b138ebaee40f0ab7d7741cab236cec96
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 10:46:44 2019 +0000

    libcli/smb: clang: Fix ' 2nd function call argument is an uninitialized value'
    
    Fixes:
    
    /home/samba/samba/libcli/smb/smbXcli_base.c:5120:8: warning: 2nd function call argument is an uninitialized value <--[clang]
                    rc = gnutls_hash(hash_hnd,
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit fb49e411aa3ca397b19ea57528c2f67f9b85c877
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 10:41:29 2019 +0000

    libcli/smb: clang: Fix 'Dereference of null pointer'
    
    Fixes:
    
    smbXcli_base.c:4885:20: warning: Dereference of null pointer <--[clang]
            body = (uint8_t *)iov[1].iov_base;
                              ^~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 3594c3ae202688fd8aae5f7f5e20464cb23feea9
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 10:37:34 2019 +0000

    libcli/smb: clang: Fix 'Array access results in a null pointer deref'
    
    Fixes:
    
    smbXcli_base.c:4393:10: warning: Array access (from variable 'inhdr') results in a null pointer dereference <--[clang]
            flags = CVAL(inhdr, HDR_FLG);
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 7a86c99ccb6912effdbb0ffbdc5c66eccf8c1aa2
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 10:22:49 2019 +0000

    libcli/smb: clang: Fix 'array access results in a null pointer deref'
    
    Fixes:
    
    smbXcli_base.c:1239:9: warning: Array access (via field 'pending') results in a null pointer dereference <--[clang]
                    req = conn->pending[0];
                          ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 7b8ec24ccfb06c1d499bf500183c0dc24de553a0
Author: Noel Power <noel.power at suse.com>
Date:   Thu Jul 11 12:00:27 2019 +0000

    s4/libcli/raw: Fix 'Value stored to 'p' is never read'
    
    Fixes:
    
    source4/libcli/raw/clitree.c:138:3: warning: Value stored to 'p' is never read <--[clang]
                    p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->tconx.out.fs_type,
                    ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4f61a9980dbd23774e7d0c205e59dc6c593067dd
Author: Noel Power <noel.power at suse.com>
Date:   Thu Jul 11 11:36:46 2019 +0000

    s3/param: clang: Fix 'Value stored to 'bRetval' is never read'
    
    Fixes:
    
    source3/param/loadparm.c:2770:2: warning: Value stored to 'bRetval' is never read <--[clang]
            bRetval = false;
            ^         ~~~~~
    source3/param/loadparm.c:3868:2: warning: Value stored to 'bRetval' is never read <--[clang]
            bRetval = false;
            ^         ~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 06c3a493d99846af62c185a9db1a6823726ac1fc
Author: Noel Power <noel.power at suse.com>
Date:   Thu Jul 11 11:33:18 2019 +0000

    s4/libcli/raw: clang: Fix 'initialization value is never read'
    
    Fixes:
    
    source4/libcli/raw/rawnegotiate.c:157:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit be319e24bb96ac4acbf55f36403f37af08107660
Author: Noel Power <noel.power at suse.com>
Date:   Thu Jul 11 11:31:03 2019 +0000

    s4/libcli: clang: Fix 'initialization value is never read'
    
    Fixes:
    
    source4/libcli/smb_composite/fetchfile.c:91:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a901c5768accd49b40b17b3350613ca7819a2854
Author: Noel Power <noel.power at suse.com>
Date:   Thu Jul 11 11:28:58 2019 +0000

    libcli/cldap: clang: Fix 'Dereference of null pointer'
    
    Fixes:
    
    libcli/cldap/cldap.c:144:8: warning: Dereference of null pointer <--[clang]
                    ev = c->searches.list->caller.ev;
                         ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 9cfdb9f190688682dd62d7c148f1d801921a3b92
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 16:34:56 2019 +0100

    libcls/netlogon: clang: Fix 'initialization value is never read'
    
    Fixes:
    
    libcli/netlogon/netlogon.c:183:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    libcli/netlogon/netlogon.c:224:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_INVALID_NETWORK_RESPONSE;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Note: although use of default seems unecessary but gcc
    (with --picky-developer) detects the possibiliy still that status
    may be undefined (presumably by a non enum value leaking
    into the switch)
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 8aed7e9aae13b3fc64a2af1fbdf835f12038ac9b
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 16:13:38 2019 +0100

    s4/libcli/ldab: clang: Fix 'Access results in a deref of a null pointer'
    
    Fixes:
    
    source4/libcli/ldap/ldap_client.c:1023:6: warning: Access to field 'type' results in a dereference of a null pointer <--[clang]
            if ((*msg)->type != type) {
                ^~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 80f5461ae6c9e7b443b6845ca9dc341d530a04dd
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 16:07:35 2019 +0100

    s3/lib: clang: Fix 'Value stored to 'b' is never read'
    
    Fixes:
    
    source3/lib/substitute.c:516:7: warning: Value stored to 'b' is never read <--[clang]
            for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
                 ^   ~~~~~~~~~~~~
    source3/lib/substitute.c:709:7: warning: Value stored to 'b' is never read <--[clang]
            for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
                 ^   ~~~~~~~~~~~~
    source3/lib/substitute.c:811:7: warning: Value stored to 'b' is never read <--[clang]
            for (b = s = a_string; (p = strchr_m(s, '%')); s = a_string + (p - b)) {
                 ^   ~~~~~~~~~~~~
    3 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 0ca6d34a69d308ad756f3697f8f44a8e642b27f0
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 15:55:48 2019 +0100

    s3/lib/dwrap: clang: Fix 'Array access results in a null pointer dereference'
    
    Fixes:
    
    source3/lib/dbwrap/dbwrap_watch.c:55:3: warning: Array access (from variable 'wkey') results in a null pointer dereference <--[clang]
                    SIVAL(wkey, 0, db_id_len);
                    ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 57e9b358ec836e8d8133242c0f6ce4d896531a40
Author: Noel Power <noel.power at suse.com>
Date:   Wed Jul 10 15:49:11 2019 +0100

    s3/lib: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/lib/messages.c:483:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 9cf3379a1409b95714a1d96bf75c0bc08104ed1f
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jul 15 10:32:49 2019 +0200

    third_party: Update uid_wrapper to version 1.2.7
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Jul 16 17:20:31 UTC 2019 on sn-devel-184

commit da9472a934bf242c7dec1a7a355fb4eb043e5b15
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Jul 11 09:31:31 2019 +1200

    prefork tests: re-enable restart tests for MIT Kerberos
    
    Previously the restart back off tests were disabled for MIT Kerberos, as
    they used the kdc, which is not run in that case.  Tests now use the
    echo server.
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Jul 16 10:10:23 UTC 2019 on sn-devel-184

commit 1c4b9ba36c724b6fcc26a51af5202483ab3f1c23
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Jul 11 09:28:30 2019 +1200

    prefork restart tests: Use echo server for back off
    
    Use the echo server for the restart back off tests in the
    samba.tests.prefork_restart tests instead of the kdc.  The kdc is not enabled
    when the ADDC is built to run MIT Kerberos.  Changing the test to use
    the echo server means it can be run when MIT Kerberos is enabled.
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 15196c7561ff3afdb3d61afd6951d22e4cf698c7
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Jul 11 09:29:28 2019 +1200

    s4 echo_server: Enable prefork process model
    
    Enable the prefork process model, for the echo server.  This is allows
    it to be used in the prefork_restart tests.
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 5522aa1a4c34ee1a1e81db73cf41594bb10bd989
Author: Michael Adam <obnox at samba.org>
Date:   Sat May 18 11:28:54 2019 +0200

    vfs:glusterfs_fuse: ensure fileids are constant across nodes
    
    Instead of adding a new gluster-specific mode to the fileid module,
    this patches provides a fileid algorithm as part of the glusterfs_fuse
    vfs module. This can not be configured further, simply adding the
    glusterfs_fuse vfs module to the vfs objects configuration will enable
    the new fileid mode.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13972
    
    Signed-off-by: Michael Adam <obnox at samba.org>
    Signed-off-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Sat Jul 13 22:54:56 UTC 2019 on sn-devel-184

commit 36b48aa783743c86da21f8a896eac0f774fed27a
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jul 11 16:23:53 2019 +0200

    s3:net: add 'net vfs getntacl' command
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Jul 12 22:59:58 UTC 2019 on sn-devel-184

commit bb37a88e63660f885121703419f183f9c3e85827
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Jul 5 17:35:50 2019 +0200

    s4/torture: add a vfs_fruit unconversion test
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 17496a39b1c6f6c703219d559254e894a40d0117
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jul 10 16:03:17 2019 +0200

    s3:net: add 'vfs' hierarchy with 'stream2adouble' command
    
    This adds a new top-level command hierarchy 'vfs' that can be used to add
    commands that access the smbd VFS stack.
    
    The first command to be implemented is 'stream2adouble' which can be used to
    convert stream metadata to AppleDouble files.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a331b15e2b4eeda7b206f70ddad04bcac4243e4f
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jul 4 11:43:34 2019 +0200

    adouble: add ad_unconvert()
    
    This collects a file's stream data and packs it into a AppleDouble file.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 145c54e4de7435810eb82c9299aaccaedd9898f0
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 9 19:26:01 2019 +0200

    s3: move fruit catia string replace mappings to s3/lib/
    
    This will be needed by another component soonish.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>

commit cd3b4187266a49ceaf5ce176abfdd17c741d4caf
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 9 19:10:14 2019 +0200

    s3:{modules => lib}/string_replace.[c|h]
    
    This is now also consumed by something outside source3/modules/.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1acdca751937186b9b114961bd045b9a022e39b5
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 9 19:07:30 2019 +0200

    vfs_fruit: remove duplicate catia mappings
    
    0x0d:0xf00d is already given a few lines above.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2bd926accd7a4649fb83eb2a262f962277566b45
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 9 18:05:09 2019 +0200

    s3:modules: pass a TALLOC_CTX to string_replace_init_map()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f820647fa1be39c700b6989418e379114ec7ea3b
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Jul 7 13:50:49 2019 +0200

    adouble: ensure stat info is marked invalid on new path
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a2a30e63d509ac3bca0ae56c9babb63942450699
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Jul 5 11:42:11 2019 +0200

    adouble: remove xattrs after successfull conversion
    
    This ensure the subsequent ad_fset() does not attempt to put back the xattrs on
    disk in the AppleDouble file. It's not yet a problem as we don't have the code
    that would do that, but that will be added in the next commit...
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0f5fde7bed4dbf01736ee583fe790db99c7d4561
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jul 4 11:43:01 2019 +0200

    adouble: add some ASCII art
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1c464232f8848e6d3a28f49f7721f4ac076c5645
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jul 4 11:37:10 2019 +0200

    adouble: use runtime size when writing out AppleDouble header
    
    We're calling SMB_VFS_NEXT_PWRITE() to write out the AppleDouble header
    data. Until now this header always had a fixed sizeof AD_DATASZ_DOT_UND bytes,
    but a subsequent commit will change that. Use the correct size which is the
    offset of the begining of the resource fork data.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5e52d9ebf0638ce40130dc72c8225c5b7e25ee22
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jul 4 11:35:19 2019 +0200

    adouble: pass VFS handle and fsp to ad_pack()
    
    Unused for now, that comes next.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 79e0110e461e56750ab4683900737f1712798575
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jul 4 10:46:46 2019 +0200

    adouble: remove redundant calls to ad_pack()
    
    ad_fset() calls ad_pack() anyway...
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3093c374f2fe16efd765b485bf86599feff1f6a7
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jul 1 15:53:36 2019 +0200

    s3:lib: move Mac streams util functions to s3/lib
    
    While at it, change the functions to work on the stream name directly instead of
    struct smb_filename. A later commit wants to use the function on the resulting
    stream names coming from vfs_streaminfo().
    
    Also use the simple string compare version, not the multibyte ones, as the afp*
    stream names are simple ASCII string, so there's no need to become fancy.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dbc840e740a447b3e7771bbe0c607a4623518e98
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 9 13:10:00 2019 +0200

    vfs_fruit: move AppleDouble functionality to a dedicated subsystem
    
    It's still tied to the VFS, therefor it lives in source3/modules/. Reduces code
    bloat in vfs_fruit and makes it possible to use it from other parts of the
    codebase in future.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f9df2b67ced95bfad4bdac925dc200ca7daf111e
Author: Ralph Boehme <slow at samba.org>
Date:   Mon May 27 17:55:07 2019 +0200

    vfs_fruit: pass catia mappings as argument to ad_convert()
    
    This removes the direct use of fruit_catia_maps from ad_convert(), to make it
    possible to move the whole AppleDouble functionality to a dedicated subsystem.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1bf4175a23db4e8a91b64bff73f43e325ee6a517
Author: Ralph Boehme <slow at samba.org>
Date:   Mon May 27 16:57:51 2019 +0200

    vfs_fruit: add flags to ad_convert()
    
    A subsequent commmit will move all AppleDouble related functionality, including
    ad_convert(), to a different compilation unit. We must therefor remove the
    dependency on struct fruit_config_data.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c7bb524438afd08ed25e121ef2a8afd70777f2d4
Author: Ralph Boehme <slow at samba.org>
Date:   Fri May 24 17:50:52 2019 +0200

    vfs_fruit: convert adouble accessor macros to functions
    
    The functions will be moved to a different compilation unit in a subsequent
    commit and struct adouble will become a private struct so callers can't access
    it directly.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9f6b87d3f6cc9930d75c1f8d38ad4f5a37da34ab
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Mon Jul 8 16:59:33 2019 +1200

    ldap_server: Regression in 0559430ab6e5c48d6e853fda0d8b63f2e149015c
    
    Extended DN requests seem to have been incorrectly handled.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14029
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Thu Jul 11 05:25:26 UTC 2019 on sn-devel-184

commit fa551bf0a4ae5a6687a1ee638dc3c495a30a2e19
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 8 15:19:51 2019 +0000

    libcl/smb: clang: Fix 'Value stored to 'next_offset' is never read'
    
    Fixes:
    
     libcli/smb/smb2_create_blob.c:146:3: warning: Value stored to 'next_offset' is never read <--[clang]
                    next_offset += next_pad;
                    ^              ~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 71943ab53ee67dab0bb47753b78074917f38749e
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 8 15:16:57 2019 +0000

    libcli/smb: clang: Fix 'value stored to 'p' is never read'
    
    Fixes:
    
    libcli/smb/smb1cli_session.c:226:2: warning: Value stored to 'p' is never read <--[clang]
            p += ret;
            ^    ~~~
    libcli/smb/smb1cli_session.c:517:2: warning: Value stored to 'p' is never read <--[clang]
            p += ret;
            ^    ~~~
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f004f8a23493fba882324131e68a046ef84b8de5
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 8 13:52:26 2019 +0000

    auth/gensec: clang: Fix 'Value stored to 'status' is never read'
    
    Fixes:
    
    auth/gensec/spnego.c:877:2: warning: Value stored to 'status' is never read <--[clang]
            status = sub_status;
            ^        ~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit d6c67f7c886c67363c4c1ef139cc366aadf90142
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 8 13:49:30 2019 +0000

    s4/auth/gensec: clang: Fix 'initialization value is never read'
    
    Fixes:
    
    source4/auth/gensec/gensec_gssapi.c:431:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
            NTSTATUS nt_status = NT_STATUS_LOGON_FAILURE;
                     ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 3a59a70dab359c4a1e992625b7adaa15f37a10ca
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 8 13:46:39 2019 +0000

    nsswitch/libwbclient: clang: Fix Value stored to 'wbc_status' is never read
    
    Fixes:
    
    nsswitch/libwbclient/wbc_util.c:123:3: warning: Value stored to 'wbc_status' is never read <--[clang]
                    wbc_status = WBC_ERR_SUCCESS;
                    ^            ~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit c38a7745b18ff83ad0097e604967a2501e88d1e1
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 8 13:43:20 2019 +0000

    s4/dsdb/common: clang: Fix access results in null pointer deref.
    
    Fixes:
    
    source4/dsdb/common/util_trusts.c:2915:21: warning: Access to field 'sid' results in a dereference of a null pointer (loaded from field 'tdo') <--[clang]
            d->di.domain_sid = d->tdo->sid;
                               ^  ~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit c19f1c9a3e7fc103754703dff11aa3b63b1edb95
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 8 12:12:59 2019 +0000

    nsswitch/libwbclient: clang Fix Potential leak of memory
    
    Fixes:
    
    nsswitch/libwbclient/wbc_sid.c:848:2: warning: Potential leak of memory pointed to by 'extra_data'
            free(extra_data);
            ^
    1 warning generated.
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit c80606274fdb1f1736e74e8da26d918bf259922e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Jul 7 12:49:57 2019 +1200

    ldb ABI bump for pyldb_Ldb_AsLdbContext change
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Wed Jul 10 05:48:52 UTC 2019 on sn-devel-184

commit fdb9a59069c5fea131669510b59901cbe3d9e58e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jul 4 16:43:12 2019 +1200

    pyldb: ldb.register_module() checks arguments a little bit
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 192386ede62c4a72c0fbc173240f02357455c609
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jul 4 16:29:56 2019 +1200

    pyldb: remove ldb.open, which was never survivable
    
    There was no way to call ldb.open without evoking signal 11, so it is
    unlikely anyone was using it.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 3af57daa8404476773cef3be544a82ac419f961d
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jul 4 03:59:42 2019 +0000

    py segfault test: ldb.open
    
    There seems to be no way of using ldb.open without causing a segfault
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 545e95386f6a37009975718f2f5ad03390d9296d
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jul 4 03:59:11 2019 +0000

    py segfault test: ldb.register_module
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 1d6b472cdcddbd6892741a381f33faf0b4ddc847
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Apr 27 13:15:01 2018 +1200

    pyldb: rename pyldb_Dn_AsDn() to pyldb_Dn_AS_DN()
    
    Following the python/C convention for checking vs non-checking
    convertors.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 339f8bbdda04a23460e7fa908d60857b95271c6e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu May 3 11:17:55 2018 +1200

    pyldb: check for errors in PyLdb_GetPyType()
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e075f52a7508979b744fde463d6184405d7a3772
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Apr 20 16:23:42 2018 +1200

    pyldb: fork pyldb_Ldb_AsLdbContext macro to reflect unsafeness
    
    In the Python/C API, conversion functions which check the types of their arguments
    have names like:
    
    double PyFloat_AsDouble(PyObject *pyfloat);
    
    while conversion macros that don't check have names like:
    
    PyFloat_AS_DOUBLE(pyfloat)
    
    The pyldb_Ldb_AsLdbContext() macro looks like one of the checking functions
    but it actually isn't. This has fooled us more than once. Here we fork
    the macro into two -- one which performs checks and keeps the camel
    case, and one with a shouty name that keeps the check-free behaviour.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f5e0339a0de71dc7d07f3ba95e6573076efe9efd
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu May 3 12:10:21 2018 +1200

    pyldb: add pyldb_check_type()
    
    This will be used by pyldb_Ldb_AsLdbContext().
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 19a13cbe0681b3996c33f7449f69b0fb0dc5d640
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Jul 6 23:24:43 2019 +1200

    ldb: do not allow adding a DN as a base to itself
    
    If you try to add a dn to itself, it expands as it goes. The resulting
    loop cannot end well.
    
    It looks like this in Python:
    
        dn = ldb.Dn(ldb.Ldb(), 'CN=y,DC=x')
        dn.add_base(dn)
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 09ddad6c14db6e3310b663f6203582104d85db45
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:28:51 2019 -0700

    s3: smbd: Remove ifdef'ed out dptr_close_oldest().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Jul 10 00:28:51 UTC 2019 on sn-devel-184

commit 6134922f7b4d0141e40286c5c5acad05272fa267
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:26:59 2019 -0700

    s3: smbd: Remove the 'close oldest' logic in SMB1 trans2 search processing.
    
    Will be removed in next commit.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 1376dc3b840561cd782cd5f228eb1c43aa96f22d
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:23:57 2019 -0700

    s3: smbd: Remove the 'close oldest' logic in SMB1search processing.
    
    Expect the client to manage their handles properly.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ff8c8b34b91ffc5fa9742d57190580cbf64a1afd
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:20:42 2019 -0700

    s3: smbd: Remove now unused parameter 'forclose' to dptr_get().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e21b75168d382500370591b678d1558265b18771
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:16:21 2019 -0700

    s3: smbd: globals - remove dirhandles_open from internal search struct.
    
    It wasn't used for SMB2 anyway, and isn't useful for anything.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d9d00ad068c5814e13c68c7fe42d75242f899f0d
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:15:24 2019 -0700

    s3: smbd: We no longer need to keep a count of dirhandles open.
    
    It's not per-connection struct anyway, so doesn't
    help for anything.
    
    Remove now unused variable struct smbd_server_connection *sconn
    otherwise we get compile errors.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 096a98f6eab3ba4be9e24e1f4cc9c6477983c282
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:06:30 2019 -0700

    s3: smbd: Add a note explaining MAX_DIRECTORY_HANDLES only applies to SMB1.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ab65fa9af0ba97fdc5f0e44eea9652212f0f7cd0
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:06:07 2019 -0700

    s3: smbd: Remove now unused MAX_OPEN_DIRECTORIES define.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 288d71678b02effdb910e8ebb811d0f502a75166
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:35:20 2019 -0700

    s3: smbd: Remove unused dptr_idleoldest() and dptr_idle() functions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7b6129d14e4d22728c009ec72529f6f18010db68
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:34:41 2019 -0700

    s3: smbd: Remove SMB1 idle unused directory handles code.
    
    This is only needed for broken SMB1 DOS clients, and
    we're a long way from needing this anymore.
    
    ifdef out dptr_idleoldest() and dptr_idle()
    functions as otherwise we get "unused function"
    compile errors. Remove in next commit.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7b98319f3057bea2e78be7b540f640fc476c770c
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 15:01:43 2019 -0700

    s3: smbd: Remove MAX_OPEN_DIRECTORIES check in dptr_create().
    
    This is a bug in that it's artificially limiting the number
    of open directories an SMB2 client can have. If this code
    was needed it should by SMB1 specific.
    
    However we should allow the clients to decide for themselves
    how many directory handles they need, not limit to MAX_OPEN_DIRECTORIES.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a43e6771348127dd2e3fd3efcc8e0b5691916862
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 14:58:44 2019 -0700

    s3: smbd: Remove now unused dptr_idlecnum().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 80ae1eba8cb5121172cb3478326e6990d1dc3f4e
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 14:57:17 2019 -0700

    s3: smbd: Remove unused DPTR_IDLE_TIMEOUT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 609c9a58cebd27c2b3ed2c73a8b9dd1b8880a895
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 14:56:13 2019 -0700

    s3: smbd: Don't idle SMB1 directory scans after DPTR_IDLE_TIMEOUT.
    
    Only broken SMB1 clients leave directory scans hanging
    and we shouldn't support that.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 461001cbc13727b46b0ff3fb8ea347bfc199a9e4
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 14:55:09 2019 -0700

    s3: smbd: Don't idle connections with active SMB1 directory scans.
    
    When all scans are via file handles this code can
    be removed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit abc58a4a128810294040cca849aad324b9c22fa5
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Jul 8 14:46:20 2019 -0700

    s3: smbd: Add dptr_activecnum(), not yet used.
    
    Will be used to help remove the SMB1 idle directory
    code.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ccf3e76625c42f5aceea0882971a232a9f56a971
Author: Andreas Schneider <asn at samba.org>
Date:   Wed May 15 08:41:12 2019 +0200

    s3:profile: Allow profile subsystem to use SHA1 in FIPS mode
    
    This is non-cryptographic use.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Jul  9 13:31:46 UTC 2019 on sn-devel-184

commit 31a943fa0890438cffc67a566373f36c94c0a5a8
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jul 5 10:38:44 2019 +0200

    lib:crypto: Add GNUTLS_FIPS140_SET_(LAX|STRICT)_MODE to helpers
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a31a40b41a18ae09a4e2e76f41c95b011ed30bea
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Jul 5 16:28:27 2019 +0200

    lib:crypto: Fix path to header file in gnutls_helpers.h
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6fe2193b17ac2d57c559d3b936b37238d06d6be8
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Jul 1 16:54:15 2019 +0200

    s3:profile: Use SHA1 for hashing in profiling functions.
    
    This can use SHA NI instructions if the CPU supports it.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14031
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 36f021f74d9739a9c73b95fc7d6f821bbf7cafdd
Author: Karolin Seeger <kseeger at samba.org>
Date:   Tue Jul 9 12:04:27 2019 +0200

    WHATSNEW: Start release notes for Samba 4.12.0pre1.
    
    Signed-off-by: Karolin Seeger <kseeger at samba.org>

commit 9cb028d6d1630b20dab5bd456c69052e877d6fcf
Author: Karolin Seeger <kseeger at samba.org>
Date:   Tue Jul 9 12:02:07 2019 +0200

    VERSION: Bump version up to 4.12.0.
    
    Signed-off-by: Karolin Seeger <kseeger at samba.org>

commit 42c299b090ed9bcf3540c49d337348c1374e77c2
Author: Karolin Seeger <kseeger at samba.org>
Date:   Tue Jul 9 11:47:48 2019 +0200

    VERSION: Bump version up to 4.12.0pre1...
    
    and re-enable GIT_SNAPSHOT.
    
    Signed-off-by: Karolin Seeger <kseeger at samba.org>

-----------------------------------------------------------------------


-- 
Samba Shared Repository



More information about the samba-cvs mailing list