[SCM] Samba Shared Repository - branch v4-12-stable created

Stefan Metzmacher metze at samba.org
Tue Jan 21 13:31:37 UTC 2020


The branch, v4-12-stable has been created
        at  85478847a1f6bf8027a1a91df23ae746042620db (commit)

- Log -----------------------------------------------------------------
commit 85478847a1f6bf8027a1a91df23ae746042620db
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Dec 20 18:16:13 2019 +1100

    WHATSNEW: Add CTDB changes for 4.12
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Tue Jan 21 13:05:00 UTC 2020 on sn-devel-184

commit aa2977e1519b76b2c70871032bbc5ab85f8a0c45
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 10 14:25:39 2020 +1100

    ctdb-mutex: Change default re-check time for fcntl helper to 5s
    
    Testing against a commonly used cluster filesystem has shown no
    performance impact, as expected.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 14b1dffc27def76f1c69ff820f4e03dc50ddf4b6
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 10 15:45:48 2020 +1100

    ctdb-tests: Add some tests to check recovery from recovery lock issues
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 64501f519319f83fb6281da50c76275782ee1f6c
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 10 14:04:14 2020 +1100

    ctdb-tests: Put recovery lock for local daemons into a subdirectory
    
    This makes it more like the way it works with a cluster filesystem.
    It also allows the subdirectory to be manipulated in tests.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 93fc31858f91c1b4080a223fed905eaac66a90d2
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 17 15:30:01 2020 +1100

    ctdb-tests: Add local_daemons.sh option for recovery lock recheck interval
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 13658324a3ab30213ff50c21308f287ef3a131fd
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Mon Dec 16 13:57:47 2019 +1300

    CVE-2019-19344 kcc dns scavenging: Fix use after free in dns_tombstone_records_zone
    
    ldb_msg_add_empty reallocates the underlying element array, leaving
    old_el pointing to freed memory.
    
    This patch takes two defensive copies of the ldb message, and performs
    the updates on them rather than the ldb messages in the result.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14050
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(master): Tue Jan 21 11:38:38 UTC 2020 on sn-devel-184

commit 34a8cee348d3dfea18e92a4ae829ae797a652192
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 29 20:58:47 2019 +1300

    CVE-2019-14907 lib/util: Do not print the failed to convert string into the logs
    
    The string may be in another charset, or may be sensitive and
    certainly may not be terminated.  It is not safe to just print.
    
    Found by Robert Święcki using a fuzzer he wrote for smbd.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14208
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 86023642c3961f00d0e4e6c71086739d9d568276
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 18:26:11 2019 +1300

    repl_meta_data: Only reset replMetaData entry for name if we made a conflict name here
    
    We previously set it for any rename
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 9e126852a6912e545641a506491f425a987e3b80
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 18:15:16 2019 +1300

    repl_meta_data: Do not set *rename = true unless there has been a conflict on the incoming DN
    
    The normal case of a partner-sent rename is not a cause for updating the replPropertyMetaData
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 512ea17983e7cca78778d493c75b4401a438dfbb
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 17:55:13 2019 +1300

    repl_meta_data: Add comment explaining what is being renamed after the conflict is resolved
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 2b1828276b365a30131ac6ea543ac344941b8088
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 12 14:44:57 2019 +1300

    CVE-2019-14902 dsdb: Change basis of descriptor module deferred processing to be GUIDs
    
    We can not process on the basis of a DN, as the DN may have changed in a rename,
    not only that this module can see, but also from repl_meta_data below.
    
    Therefore remove all the complex tree-based change processing, leaving only
    a tree-based sort of the possible objects to be changed, and a single
    stopped_dn variable containing the DN to stop processing below (after
    a no-op change).
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit b7030f9a8bd67f454c17d065d9af9199748aa6d3
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 18:26:42 2019 +1300

    CVE-2019-14902 repl_meta_data: Set renamed = true (and so do SD inheritance) after any rename
    
    Previously if there was a conflict, but the incoming object would still
    win, this was not marked as a rename, and so inheritence was not done.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 4c62210098df44c6c4cbd0a3d41734e11286106c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 26 15:50:35 2019 +1300

    CVE-2019-14902 repl_meta_data: Fix issue where inherited Security Descriptors were not replicated.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 520d2ae187e83b1cefb4d0c9bf823a051db6b14f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 18:05:54 2019 +1300

    CVE-2019-14902 repl_meta_data: schedule SD propagation to a renamed DN
    
    We need to check the SD of the parent if we rename, it is not the same as an incoming SD change.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 3f3791765c6fd554b8f7708df0101d3c58339a27
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 17:54:23 2019 +1300

    CVE-2019-14902 dsdb: Ensure we honour both change->force_self and change->force_children
    
    If we are renaming a DN we can be in a situation where we need to
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 5d714c1cea1beadc9ca07935217e0174d9d48ac6
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 26 16:17:32 2019 +1300

    CVE-2019-14902 dsdb: Add comments explaining why SD propagation needs to be done here
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 545d205e5b203983855c10558ad3a326c13b712e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 26 15:44:32 2019 +1300

    CVE-2019-14902 dsdb: Explain that descriptor_sd_propagation_recursive() is proctected by a transaction
    
    This means we can trust the DB did not change between the two search
    requests.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit febe15ab2e109721a7f8ef996c3fe4d82106c42c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Dec 16 11:29:27 2019 +1300

    selftest: Add test to confirm ACL inheritence really happens
    
    While we have a seperate test (sec_descriptor.py) that confirms inheritance in
    general we want to lock in these specific patterns as this test covers
    rename.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit d64670bab82f21fc16fb9ffb32f713c0cae2f9e3
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Dec 10 15:16:24 2019 +1300

    CVE-2019-14902 selftest: Add test for a special case around replicated renames
    
    It appears Samba is currently string-name based in the ACL inheritence code.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 7b19e221aeefb4a93990aa589636df471cb8d47e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 28 17:16:16 2019 +1300

    CVE-2019-14902 selftest: Add test for replication of inherited security descriptors
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12497
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 558bd7c83d08523a9e88414195d9703df38e9af2
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 1 13:52:38 2019 +1000

    util: Add detection of libunwind
    
    The current detection doesn't seem to work, so libunwind doesn't seem
    to be used.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Tue Jan 21 08:12:17 UTC 2020 on sn-devel-184

commit 5ff83809a2be567b69714373ab13bde09f72705c
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Jan 17 13:47:02 2020 +1100

    s3: lib: dbwrap_ctdb: Ensure value_valid is set when creating empty record
    
    Fixes:
    
      PANIC: assert failed at ../../lib/dbwrap/dbwrap.c(82): rec->value_valid
      PANIC (pid 902392): assert failed: rec->value_valid
      BACKTRACE: 16 stack frames:
       #0 bin/shared/libsamba-util.so.0(log_stack_trace+0x30) [0x7fb161f69cb0]
       #1 bin/shared/libsmbconf.so.0(smb_panic_s3+0x23) [0x7fb1619f4863]
       #2 bin/shared/libsamba-util.so.0(smb_panic+0x2f) [0x7fb161f69daf]
       #3 bin/shared/private/libdbwrap-samba4.so(dbwrap_record_get_value+0x27) [0x7fb160a04c57]
       #4 bin/shared/libsamba-passdb.so.0(+0x2d27c) [0x7fb1618e627c]
       #5 bin/shared/libsamba-passdb.so.0(pdb_add_aliasmem+0x33) [0x7fb1618db663]
       #6 bin/shared/libsamba-passdb.so.0(+0x1edbb) [0x7fb1618d7dbb]
       #7 bin/shared/libsamba-passdb.so.0(create_builtin_administrators+0x167) [0x7fb1618d8217]
       #8 bin/shared/private/libauth-samba4.so(finalize_local_nt_token+0x39d) [0x7fb16194bd5d]
       #9 bin/shared/private/libauth-samba4.so(create_local_nt_token_from_info3+0x304) [0x7fb16194c3f4]
       #10 bin/shared/private/libauth-samba4.so(create_local_token+0x3d6) [0x7fb161945106]
       #11 bin/shared/private/libauth-samba4.so(+0x154b4) [0x7fb1619474b4]
       #12 bin/shared/private/libauth-samba4.so(init_guest_session_info+0x58) [0x7fb161947798]
       #13 ./bin/smbd(main+0x80f) [0x55944ef8f91f]
       #14 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7fb161076bbb]
       #15 ./bin/smbd(_start+0x2a) [0x55944ef90f8a]
    
    This is a similar, additional fix to commit
    36ea1e188d5ea8d40c47ffc466a494c1160e471c.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Jan 20 04:25:57 UTC 2020 on sn-devel-184

commit 4dd026d0d33ab5d3c6cc22d63a74917c1c2c2f27
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 17 16:00:18 2020 +0100

    smbd: Fix claiming version
    
    We now have to do an explicit DOWNGRADE when we want to change from
    G_LOCK_WRITE to G_LOCK_READ.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sun Jan 19 19:58:01 UTC 2020 on sn-devel-184

commit 25bcf0e7890a690f5f573dc5e8392807c403948c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 8 16:07:30 2020 +0100

    lib: Use closefrom() in smbrun.c
    
    INSURE is never defined or used.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 42a3e2e503baef456082d40617a7639a9e226491
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 17 11:28:31 2020 +0100

    ctdbd: Use struct initialization
    
    2 lines less
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b274bc698ed26c6897beee6051532244bc30d2ec
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 19 12:29:56 2020 +0100

    dsdb: Use write_data() to write to the password check script
    
    A simple write() might be interrupted or do short writes. Highly
    unlikely, but if it happens, it will be impossible to diagnose.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 229518ec01b495e0133d83d3560a432a08307c0b
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 19 12:29:39 2020 +0100

    dsdb: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 37eb87d2be88e0e47c72287033e9c829e9625d41
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 19 11:50:57 2020 +0100

    lib: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cffcc39f185031bc85bcf0c770892b115058a831
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Jan 18 18:35:42 2020 +1000

    heimdal_build: Remove bashism from --address-sanitizer build rule
    
    export FOO=bar is a Bash extension, and is not required in this case, we only need the asn1_compile
    to run under the variable, there are no further commands in this sub-shell.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Sat Jan 18 12:25:16 UTC 2020 on sn-devel-184

commit 7606800b798a31d62e69f61d441201e5db2f0d8a
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Jan 17 10:56:00 2020 +0100

    smbd: avoid calling vfs_file_id_from_sbuf() if statinfo is not valid
    
    When we're about to create a file, the stat info will be all zero, so
    vfs_file_id_from_sbuf() would return a bogus file_id. This is normally not a
    problem, as open_file() itself also calls vfs_file_id_from_sbuf() after having
    created the file.
    
    This is however a problem when using the VFS module fileid, as that is doing
    caching of /etc/mtab and failing to find smb_fname->st.st_ex_dev (all zero in
    this case when creating a new file) in the mtab cache will trigger a mtab reload
    which can be *very* expensive.
    
    Copying many small files to a Samba server in this situation will result in
    abysimal performance.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14237
    
    Pair-Programmed-With: Jeremy Allison <jra at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Jan 17 22:38:14 UTC 2020 on sn-devel-184

commit c9adf47ac5a5aa0dd12572c34b08cc51f15b2e97
Author: Anoop C S <anoopcs at redhat.com>
Date:   Wed Aug 14 18:03:01 2019 +0530

    vfs_glusterfs: Return fake fd from pipe() during open
    
    GlusterFS currently doesn't have an API implementation to set flags on
    open file descriptor. Thus we use pipe() to provide valid file descriptor
    from the system.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14241
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Fri Jan 17 17:14:43 UTC 2020 on sn-devel-184

commit 6c7b722b3fa3d6383a22fb517d3cb5572115c365
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 17 10:19:32 2020 +1300

    fuzz_oLschema2ldif: check multiple possible NULLs
    
    Address sanitizer will object to a theoretically possible NULL dereference
    so we can't ignore these checks in set-up.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Jan 17 14:33:18 UTC 2020 on sn-devel-184

commit 6786ec2c9638f13efed8cba156e174644804a61e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 17 09:59:26 2020 +1300

    fuzzing: check for NULL on ldb_init()
    
    We simply return 0 because failure here is not a problem with the code we
    are actually trying to fuzz. Without this asan is unhappy.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 75367e4b0675047c6b21447473c779547d6b51b6
Author: Günther Deschner <gd at samba.org>
Date:   Thu Jan 16 14:53:19 2020 +0100

    librpc: add clusapi_GroupSetControlCode enum
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Jan 16 21:34:27 UTC 2020 on sn-devel-184

commit ac5b7427022333a312b504cdde9d725676274c93
Author: Günther Deschner <gd at samba.org>
Date:   Thu Jan 16 14:38:56 2020 +0100

    s4-torture: increase various bufsizes to better deal with Windows 2019 clusters
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 83bbc5cc42ee33e93bb583886b09c38bde767570
Author: Günther Deschner <gd at samba.org>
Date:   Thu Jan 16 11:19:52 2020 +0100

    s4-torture: fix copy/paste error in clusapi group test
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit edf21f5e3034b104cfe99e97f62478194d23283e
Author: Günther Deschner <gd at samba.org>
Date:   Mon Jan 13 14:37:40 2020 +0100

    s4-torture: add clusapi GroupSet tests
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 21157c66abb349c97d02a1a104a6e1cfcb577542
Author: Günther Deschner <gd at samba.org>
Date:   Mon Jan 13 18:30:14 2020 +0100

    s4-torture: fix asserts in clusapi_NodeControl tests
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit efe353edf486ee2ab351735a8f927fe607046bb1
Author: Günther Deschner <gd at samba.org>
Date:   Mon Jan 13 16:11:26 2020 +0100

    s4-torture: save cluster version in clusapi test context
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8dca8aaf95bd5fe74c71dc2530a6e57feeee6416
Author: Günther Deschner <gd at samba.org>
Date:   Fri Jan 10 16:44:39 2020 +0100

    librpc: add various new clusapi functions and types
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4bc481c5cb7d772f473171949a3d522788bb7dcf
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jan 16 14:12:02 2020 +1300

    samba-tool gpo: improve UNC parsing
    
    The "UNC doesn't start with \\\\ or //" message was unreachable due to
    a logic error, and an UNC starting with \\ would have been split on
    / if there were enough /s in the string.
    
    The unreachable exception was first noticed by Gerhard Lausser in a
    github pull request (https://github.com/samba-team/samba/pull/123),
    but that patch no longer applies with this more thorough rewrite.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ebced94a8721ffd25386bda452a1857fa92b9899
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:13:17 2020 +0100

    torture: Test smbcontrol close-denied-share
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Jan 15 22:51:14 UTC 2020 on sn-devel-184

commit 5394885167fac40a910613272f10b7077e59f05c
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jan 13 15:19:58 2020 +0100

    smbd: Add close-denied-share message
    
    This is like close-share, but kicks out only active users where share
    access controls are changed such that now access would be denied
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c9850e3d80320a5d13a69194246cce3f09f4ba3e
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jan 13 15:37:25 2020 +0100

    smbd: Move sharename check of conn_force_tdis() into a callback
    
    Next commit will have an additional check
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 733f798074b76ed8b96272a29c8cb91eef7a7118
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 15 12:40:38 2020 +0100

    texpect: Avoid duplicate sys_write()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4fabe1d1072147c609f2e8a2c86da04724564cb2
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 15 12:37:59 2020 +0100

    texpect: Reformat long line
    
    There will be more deps soon
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4371982619d4fb0b784813950055a0f19e0e8667
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Jan 15 12:37:22 2020 +0100

    texpect: Use lib/replace's closefrom()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2198da1b9bf79e86112aeeb8e9653f6a82f69e8d
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Jan 14 17:12:33 2020 +0100

    s3:libsmb: Fix querying all names registered within broadcast area
    
    Wait for additional replies until timeout when '*' is given to nmblookup
    as name.
    
    Introduced by 8da8c36b53cc115f0d446b666fc24fc9423d808e.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=8927
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0fcc2e93192b8737b0a711ed2ca118e4e833f3fe
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 15:44:27 2020 +1300

    fuzz: add nmblib/parse_packet target
    
    We want to ensure that parse_packet() can parse a packet without
    crashing, and that that parsed packet won't cause trouble further down
    the line.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Wed Jan 15 21:24:31 UTC 2020 on sn-devel-184

commit f4bafcca863f1f11b07dfec960495a84184f2317
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 17:33:03 2020 +1300

    fuzz: ldb binary decode/enode
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit da4786003fef39737734e1a5cbf752442f7793b1
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 12:35:54 2020 +1300

    fuzz: add ldb ldif fuzzer
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 13bd82db64be827c3472255531ee79501f07f129
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 12:35:30 2020 +1300

    fuzz: ldb_dn parsing
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 79460b1b9f3452d6d68014b84f4a9dc3988bd916
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Tue Jan 14 14:42:26 2020 +1300

    lib ldb common: Fix memory leak
    
    TALLOC_FREE the ldb_control allocated in ldb_parse_control_from_string
    when none of the cases match.
    
    Credit to OSS-Fuzz
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 6b8a683884950603a690a2e7e3b267c21e458d6b
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Jan 14 15:19:40 2020 +0100

    tests: Test samba-tool user setprimarygroup command
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Jan 15 13:30:53 UTC 2020 on sn-devel-184

commit fd1c905ec3b21f7fcc61f9bc827a56e3a3038381
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Jan 14 15:10:09 2020 +0100

    tests: Test samba-tool user getgroups command
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d73a9d1a8d81bf7d7bc9aeab5198931b2a7fb582
Author: Björn Baumbach <bb at sernet.de>
Date:   Wed Dec 18 11:56:03 2019 +0100

    selftest: create working directory for blackbox test
    
    Required to run test separately.
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a77f758df117638ea22b7589323b71d5f5261bd9
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed May 16 13:00:16 2018 +0200

    samba-tool: implement user getgroups command
    
    samba-tool user getgroups command to list a users group memberships.
    
    Pair-programmed-with: Björn Baumbach <bb at sernet.de>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8403527bbd132ee639fdd3926bf55d15bd8dea56
Author: Björn Baumbach <bb at sernet.de>
Date:   Wed May 16 10:19:16 2018 +0200

    samba-tool: implement user setprimary group command (set primaryGroupID)
    
    Introduce an option to set the primaryGroupID attribute of a user account.
    
    Pair-programmed-with: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d512b27563b32f7bcb35da21781e87473830c906
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Jan 13 16:43:21 2020 +0100

    clitar: use modern DBG macros
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Jan 14 20:42:10 UTC 2020 on sn-devel-184

commit 199f44ff87504b5e323bcccb0b3e7922c328ad38
Author: Björn Jacke <bj at sernet.de>
Date:   Tue Jan 7 12:04:49 2020 +0100

    smbtar: adopt for new tar verbose option
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d2d5007936ba4f48edad61c7613bed07c31da463
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Jan 4 21:47:59 2020 +0100

    smbclient/tar: add verbose mode
    
    A verbose mode got lost with the introduction of libarchive support.
    
    The verbose mode is optional, default is quiet mode.
    
    The output format is close to the verbose output format of POSIX tar
    implementations and should be good parsable.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=11642
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9e67b6b9515d1bc456c9f0f4edd0aea430b6d870
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jan 13 15:23:45 2020 +0100

    smbd: Protect against non-string "close-share" sharenames
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit be0a5ab852a66a041f0d6c6a96abbe296476b13a
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:10:05 2020 +0100

    test3: Fix usage check for test_sharesec.sh
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 46565a049ed7e3ba0ead9b756960e400142db7b0
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:05:00 2020 +0100

    lib: Avoid an unnecessary include
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8100b56b55352983c0965f99c6f8ba515e55a929
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:03:45 2020 +0100

    lib: Remove "msg_ctx" from server_id_watch_send()
    
    Not needed
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4546aff887c3bf9babb663f014d147dc2052a463
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 13:02:27 2020 +0100

    lib: Use tevent version of timeval_current_ofs()
    
    We have tevent available anyway, use that infrastructure
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 75ddd1d6ab84028a422d4be1c115880fc564c089
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jan 14 11:21:01 2020 +0100

    nfs4acl: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dc74b437c2ed245a7baeee633efba37909761d4b
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Jan 14 14:36:52 2020 +0100

    docs-xml: 'mangled names = illegal' is the new default
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Jan 14 15:18:02 UTC 2020 on sn-devel-184

commit de768710e1677c591bf1b360a5de1321ad3a4d91
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Jan 13 13:02:29 2020 +0100

    tests/DNS: add MX/SRV record tests with multiple spaces
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13788
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Björn Baumbach <bb at samba.org>
    
    Autobuild-User(master): Björn Baumbach <bb at sernet.de>
    Autobuild-Date(master): Tue Jan 14 11:58:20 UTC 2020 on sn-devel-184

commit af7a0e3371e1ae219239a91cb665097abbd50f3e
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Jan 13 00:21:41 2020 +0100

    samba-tool: fix adding of dns SRV/MX/SOA records
    
    Thanks to Denis Cardon for finding
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13788
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Björn Baumbach <bb at samba.org>

commit 89ed960b1da48ddcc459514871963b87503fd9ad
Author: Björn Jacke <bj at sernet.de>
Date:   Mon Jan 13 12:49:42 2020 +0100

    tests/DNS: \n.COM shouldn't be a valid DNS record
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13788
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Björn Baumbach <bb at samba.org>

commit b07eff31de43adb0cd6eab217ca85cd5ba6f3621
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 16:06:33 2020 +1300

    net_ads_gpo: remove old '#if 0' blocks
    
    I think the dump_gpo() calls do enough, and this code has done nothing
    for a decade.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Mon Jan 13 23:52:26 UTC 2020 on sn-devel-184

commit 7c01a44f18b679709d141b2d05e576ee084039b4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Jan 10 15:45:45 2020 +1300

    libgpo: parse_gp_ext: do not crash upon no ext_strings
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a18ffe26b3be13e45622172c4ade258cfc8fa783
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jan 6 10:14:11 2020 +0100

    smbd: RIP user_struct
    
    At last, the nail in the coffin. :)
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Jan 13 21:09:01 UTC 2020 on sn-devel-184

commit 5f85090d78c11c9c4ef58954b947a8bc71481e18
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:24:47 2020 +0100

    smbd: use smbXsrv_session_info_lookup() in become_user_without_service()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cdab99ba1e7ef48faeacf7ec45651ce5b48dc5d4
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:21:06 2020 +0100

    smbd: remove using vuser from smbd_smb2_tree_connect()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1d797a839d4f96da649ff13bf8c6c7ea4b52ae44
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:16:38 2020 +0100

    smbd: don't use vuser in make_connection()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 758c42ec5dd3dd8bba7b4f74741dc9b02cfb0d73
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:09:26 2020 +0100

    smbd: remove unused vuser arg from make_connection_smb2()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 893aba4d65b6f2bdcd49ba3618f882fad0d5df49
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:07:23 2020 +0100

    smbd: remove unused vuser arg from make_connection_smb1()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9ef30c75b065876fee05103a4ad1b0d70d2d86c6
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 17:06:23 2020 +0100

    smbd: use req->session instead of vuser->session in make_connection_smb1()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8be0ca8e19b861d13038769289325537c101072b
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 16:26:03 2020 +0100

    smbd: remove use of user_struct from reply_ulogoffX()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4b89100dc8d7620657fa1e6335d47df97188c102
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 14:47:51 2020 +0100

    smbd: use smbXsrv_session_local_traverse() in id_in_use()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 18b43aeb5747f0982e4296960f23986a5f536960
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 11:42:05 2020 +0100

    smbd: add smbXsrv_session_local_traverse()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d2b5f85d221626ce505143c7c129c41603dcb24a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jan 6 10:12:32 2020 +0100

    smbd: remove enum server_allocated_state magic from get_valid_user_struct()
    
    This has been obsoleted a long time ago by
    a129e271b5385853fb39a8e54b56b508b00a3e41.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c3d22018679c6aa83c4a5ae3e480532a3f5eccca
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jan 6 08:20:14 2020 +0100

    smbd: use get_valid_smbXsrv_session() in invalidate_vuid()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dd9735b1da73b6c27feda32230e3fc843746fd2b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Jan 6 08:19:18 2020 +0100

    smbd: add get_valid_smbXsrv_session()
    
    In memory of get_valid_user_struct() and functionally equivalent it only returns
    the session if session setup was successfully completed and
    session->global->auth_session_info is valid.
    
    This function is similar to smbXsrv_session_local_lookup() and it's wrappers,
    but it doesn't implement the state checks of those. get_valid_smbXsrv_session()
    is NOT meant to be called to validate the session wire-id of incoming SMB
    requests, it MUST only be used in later internal processing where the session
    wire-id has already been validated.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a22b503819ce19f8857484bb6c2ee21ce6b75a7f
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Jan 2 08:07:31 2020 +0100

    smbd: use session->global->auth_session_info in switch_message()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 54d626cc77e33c47912489d234df667d3d394f75
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 18:38:59 2020 +0100

    smbd: remove dependency on session->compat in smbXsrv_session_logoff()
    
    This is not needed anymore because a previous commit changes this to use
    session->global->session_wire_id insteaf of session->compat->vuid, so we're not
    depending on session->compat anymore.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 25524c8e78b0a927bcea5851d7282af0f0a0654e
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 15:20:05 2020 +0100

    smbd: use smbXsrv_session_info_lookup() in api_reply()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c3f890fb1e982603c7f24033fc1e5d73535fbbb8
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 12:15:29 2020 +0100

    smbd: use smbXsrv_session_info_lookup() in api_WWkstaUserLogon()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 46f51912aea157433537af27097a0127c7626085
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 09:47:38 2020 +0100

    smbd: share level security is long gone...
    
    vuid will always be valid as will be vuser.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 57d4689273f01bb458c33ff6577e1ac3f179ece9
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 01:06:45 2020 +0100

    smbd: use smbXsrv_session_info_lookup() in change_to_user_and_service()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e80aca04278e6bfd35744ca852549669cee8a8e2
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jan 1 01:06:24 2020 +0100

    smbd: introduce smbXsrv_session_info_lookup()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 96fd0ddd02eae05024102b5ed8dc7fb158ed1785
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 30 10:28:25 2019 +0100

    smbd: remove vuser arg from make_connection_snum()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c1d0a70d19ec03f8a1fd770e53db7a921af1282d
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 30 10:26:26 2019 +0100

    smbd: use session->global->auth_session_info in make_connection_snum()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 61fa0f99768bf3519cafd2c49d0b774bc4c22841
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 14:33:00 2019 +0100

    smbd: remove vuid from struct user_struct
    
    The previous commit removed all users of struct user_struct.vuid.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bcadd7d798e0cc9bb58835ecac1799dfea8a4cb8
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 14:33:00 2019 +0100

    smbd: use session->global->session_wire_id instead of session->compat->vuid
    
    session->compat->vuid is set to session->global->session_wire_id after a
    successful session setup, so both variables will always carry the same value. Cf
    the next commit which removes vuid from user_struct.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5992f8fa93adfcd6fc9e5c0632fc36f02ce271ca
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 14:34:42 2019 +0100

    smbd: pass smbXsrv_session to make_connection_snum()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8aae1ef5c0b9c50f892e01316fdac5dc6504ecbb
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 08:31:45 2019 +0100

    smbd: move homes_snum from struct user_struct to struct smbXsrv_session
    
    No change in behaviour. A first step in removing user_struct.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit aa27bceff194bf1d6665bcb66dd3ba750a59b598
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 29 08:30:22 2019 +0100

    smbd: add session to struct smb_request
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 15ee379ef11d86670aeea7fa4b8bf740dd259593
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jan 10 15:55:29 2020 -0800

    s3: lib: dbwrap. Cleanup. Add a couple of missing 'return NULL' statements on talloc fail.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 36ea1e188d5ea8d40c47ffc466a494c1160e471c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Jan 10 15:52:31 2020 -0800

    s3: lib: dbwrap_ctdb: Ensure value_valid is set true if we find the record in the marshall buffer.
    
    Found by "Christopher O Cowan - Christopher.O.Cowan at ibm.com" <Christopher.O.Cowan at ibm.com>
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit c6d880a115095c336b8b74f45854a99abb1bbb87
Author: Alexander Bokovoy <ab at samba.org>
Date:   Tue Jan 7 19:25:53 2020 +0200

    s3-rpcserver: fix security level check for DsRGetForestTrustInformation
    
    Harmonize _netr_DsRGetForestTrustInformation with source4/ logic which
    didn't change since DCE RPC channel refactoring.
    
    With the current code we return RPC faul as can be seen in the logs:
    
    2019/12/11 17:12:55.463081,  1, pid=20939, effective(1284200000, 1284200000), real(1284200000, 0), class=rpc_parse] ../librpc/ndr/ndr.c:471(ndr_print_function_debug)
           netr_DsRGetForestTrustInformation: struct netr_DsRGetForestTrustInformation
              in: struct netr_DsRGetForestTrustInformation
                  server_name              : *
                      server_name              : '\\some-dc.example.com'
                  trusted_domain_name      : NULL
                  flags                    : 0x00000000 (0)
    [2019/12/11 17:12:55.463122,  4, pid=20939, effective(1284200000, 1284200000), real(1284200000, 0), class=rpc_srv] ../source3/rpc_server/srv_pipe.c:1561(api_rpcTNP)
      api_rpcTNP: fault(5) return.
    
    This is due to this check in processing a request:
            if (!(p->pipe_bound && (p->auth.auth_type != DCERPC_AUTH_TYPE_NONE)
                           && (p->auth.auth_level != DCERPC_AUTH_LEVEL_NONE))) {
                    p->fault_state = DCERPC_FAULT_ACCESS_DENIED;
                    return WERR_ACCESS_DENIED;
            }
    
    and since we get AuthZ response,
    
      Successful AuthZ: [netlogon,ncacn_np] user [EXAMPLE]\[admin] [S-1-5-21-1234567-890123456-500] at [Wed, 11 Dec 2019 17:12:55.461164 UTC]
      Remote host [ipv4:Y.Y.Y.Y:59017] local host [ipv4:X.X.X.X:445]
    [2019/12/11 17:12:55.461584,  4, pid=20939, effective(0, 0), real(0, 0)] ../lib/audit_logging/audit_logging.c:141(audit_log_json)
      JSON Authorization: {"timestamp": "2019-12-11T17:12:55.461491+0000",
       "type": "Authorization", "Authorization": {"version": {"major": 1, "minor": 1},
       "localAddress": "ipv4:X.X.X.X:445", "remoteAddress": "ipv4:Y.Y.Y.Y:59017",
       "serviceDescription": "netlogon", "authType": "ncacn_np",
       "domain": "EXAMPLE", "account": "admin", "sid": "S-1-5-21-1234567-890123456-500",
       "sessionId": "c5a2386f-f2cc-4241-9a9e-d104cf5859d5", "logonServer": "SOME-DC",
       "transportProtection": "SMB", "accountFlags": "0x00000010"}}
    
    this means we are actually getting anonymous DCE/RPC access to netlogon
    on top of authenticated SMB connection. In such case we have exactly
    auth_type set to DCERPC_AUTH_TYPE_NONE and auth_level set to
    DCERPC_AUTH_LEVEL_NONE in the pipe->auth. Thus, returning an error.
    
    Update the code to follow the same security level check as in s4 variant
    of the call.
    
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Mon Jan 13 15:05:28 UTC 2020 on sn-devel-184

commit beb386b584bdff25c714feb7f76d73b65ed072e7
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jan 9 17:40:02 2020 +1300

    fuzz: add a fuzzer for parsing ldb controls
    
    We have had issues here in the past.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sun Jan 12 21:21:30 UTC 2020 on sn-devel-184

commit 16ca385013ae588e8f2b696af03013980926cac1
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jan 9 19:19:56 2020 +1300

    ldb controls: fix typo in bypassoperational message
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1d35962128c93c48cd477601359182b63610ab69
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Jan 9 17:01:22 2020 +1300

    fuzz_ldap_decode: do not print to stdout
    
    The fuzzer doesn't care and it slows things down
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e1c6e7d18b446b55634bb4807c6d1a9e9346bd6c
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Dec 13 12:08:47 2019 +1300

    decode_ndr_X_crash: always find pipe in honggfuzz file
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e61ddeef4cc35402b623dbb655ab06058866bfc4
Author: David Disseldorp <ddiss at samba.org>
Date:   Thu Jan 9 16:01:22 2020 +0100

    vfs_ceph: drop support for pre-hammer libcephfs versions
    
    The last Ceph Hammer release (0.94.10) came in Feb 2017, as is no longer
    supported upstream. Drop support for building Samba vfs_ceph against
    version prior to 0.94.0.
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at samba.org>
    
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Sat Jan 11 14:59:36 UTC 2020 on sn-devel-184

commit 888002f99e113bceec5329b0962b4068e0df49ce
Author: David Disseldorp <ddiss at samba.org>
Date:   Thu Jan 9 17:11:39 2020 +0100

    vfs_ceph: drop support for building without statx
    
    libcephfs statx became available with the Kraken (11.2.0) release of
    Ceph in Jan 2017. Versions prior to this are no longer supported
    upstream, so we can drop support within Samba vfs_ceph.
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at samba.org>

commit 748379c66bc3d5131a9346c4c7a973d514b35563
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 14:21:46 2020 -0800

    s3: smbd: msdfs: Change create_msdfs_link() to call SMB_VFS_CREATE_DFS_PATHAT().
    
    No change in the (rather strange) logic.
    
    First step in abstracting MSDFS storage from direct symlink calls.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Jan 10 21:05:25 UTC 2020 on sn-devel-184

commit 54f9da44356b16efca56cc85f2552624bbe81876
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 13:36:08 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in time_audit.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 23df92810b3367b58e8a629d7ee42cf7d167373d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 13:33:23 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in full_audit.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 51fd875661640a7d305b87961b3a0201be350414
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 13:13:29 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in snapper.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 6a46c5f207d1792be048e0233f173286cde0560e
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 13:06:36 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in shadow_copy2.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 235e59481d9ca8e1a522e966399266fde1feb708
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 14:48:33 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in gluster.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 421d26a890f0e09feb94d9b445a51fc14ca24615
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 14:39:43 2020 -0800

    s3: VFS: Implement create_dfs_pathat() in ceph.
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit b0b9dd2f8693edc87840f04259e8f31fb55f601c
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Jan 9 10:13:14 2020 -0800

    s3: VFS: Add SMB_VFS_CREATE_DFS_PATHAT().
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 86a31defbf212d188281d5d963b12eedf1960e8b
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Wed Jan 8 09:39:30 2020 +1300

    ndr basic: Check ndr_token_store return code
    
    Fix for
    
    *** CID 1457529:  Error handling issues  (CHECKED_RETURN)
    /librpc/ndr/ndr_basic.c: 786 in ndr_push_full_ptr()
    ...
    ID 1457529:  Error handling issues  (CHECKED_RETURN)
        Calling "ndr_token_store" without checking return value (as is done
        elsewhere 14 out of 17 times).
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Thu Jan  9 21:49:00 UTC 2020 on sn-devel-184

commit 60b72f589e2a912682516f1d28c84cc713248a0a
Author: David Disseldorp <ddiss at samba.org>
Date:   Thu Jan 9 18:20:39 2020 +0100

    vfs_ceph: assert renameat() fsps match cwd
    
    As discussed with Jeremy in bug 14232, the vfs_ceph.renameat_fn
    implementation currently ignores srcfsp and dstfsp. As a result,
    relative smb_fname_src/smb_fname_dest paths will be processed as
    relative to cwd.
    This is currently a valid assumption, as srcfsp and dstfsp should
    always match conn->cwd_fsp. Add an assert to clarify this.
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Jan  9 20:20:05 UTC 2020 on sn-devel-184

commit 4b95ea37cb3d080f22d5c748364dd3b233b76e50
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 5 14:11:54 2020 +0100

    ntlm_auth: Add type-safety instead of a simple cast
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 91f069cc16bedf7a89c488afed7c6b705aefb03c
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Jan 5 14:11:20 2020 +0100

    ntlm_auth: Add a NULL check
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d78b4a841e2ea7b279ae1f3039216723d24220d4
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 9 14:43:02 2020 +0100

    printing: Avoid EBADF from EPOLL_CTL_DEL
    
    TALLOC_FREE the fde before closing the fd. Otherwise the fde
    destructor tries to remove a nonexisting fd from the epoll set.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1cd20731ab1e10d1b68b649c8588bbccb624c07e
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 9 14:42:43 2020 +0100

    printing: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 17e692a9fa6b1475855aef5e425c4e4d6b1fd3bc
Author: Günther Deschner <gd at samba.org>
Date:   Mon May 9 12:10:22 2016 +0200

    s3-rpcclient: add clusapi_resume_node command.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Jan  9 01:15:34 UTC 2020 on sn-devel-184

commit c9077f16283bdc04068ee669baa99baca8238532
Author: Günther Deschner <gd at samba.org>
Date:   Mon May 9 12:07:47 2016 +0200

    s3-rpcclient: add clusapi_pause_node command.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 94157af26107fc12af5c10bedb4ca5af6eeed73e
Author: Günther Deschner <gd at samba.org>
Date:   Wed Jan 8 17:25:13 2020 +0100

    s3-rpcclient: give slightly better descriptions to clusapi commands
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c433dac59818d580bdccb0d0e0daac71ccf01ee2
Author: Günther Deschner <gd at samba.org>
Date:   Mon Dec 23 16:53:37 2019 +0100

    librpc: pidlify spoolss_EnumPerMachineConnections
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c9bebbcc464e98abeeb008551657532a1831a96f
Author: Günther Deschner <gd at samba.org>
Date:   Tue Jan 7 14:58:15 2020 +0100

    librpc/ndr: provide infrastructure for NDR_SPOOLSS_{PUSH|PULL}_ENUM macros
    
    The new macros allow the same macro convenience for enum functions without
    level discriminator.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1038613878b7c40d4d313697cc0e4e527582afdb
Author: Günther Deschner <gd at samba.org>
Date:   Mon Dec 23 16:50:28 2019 +0100

    librpc: better naming for NDR_SPOOLSS_{PUSH|PULL}_ENUM variants
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 210a8f35b66326263e8466a5b58dffa6e0405c56
Author: Günther Deschner <gd at samba.org>
Date:   Fri Dec 20 13:43:25 2019 +0100

    s4-torture: add test for spoolss_EnumPerMachineConnections
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0a76a7c3c258aa84fab96d03347f8e6e8d067fa8
Author: Günther Deschner <gd at samba.org>
Date:   Sun Sep 22 03:34:56 2019 +0200

    s4-torture: add test for spoolss AddPerMachineConnection
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d642c9a2a8df3002c30d420f3cd34b447a711212
Author: Günther Deschner <gd at samba.org>
Date:   Sun Sep 22 03:34:27 2019 +0200

    s3-rpcclient: add delpermachineconnection command
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d3c2833f1bb5622c438ec1c7b287e53fce83a6c2
Author: Günther Deschner <gd at samba.org>
Date:   Mon Dec 23 12:42:53 2019 +0100

    s3-rpcclient: add addpermachineconnection command
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ce00972afc205af4f93cde5c3e30a07ec222670c
Author: Günther Deschner <gd at samba.org>
Date:   Thu Dec 1 21:32:18 2016 +0100

    s3-rpcclient: add enumpermachineconnections command
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a340aecdd025352bd0cefc1be1aac7526dfe1748
Author: Günther Deschner <gd at samba.org>
Date:   Thu Dec 19 13:49:53 2019 +0100

    s3-rpcclient: properly check and initialize buffers in getdriverpackagepath
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 479cf55397062cf38d16d08e4c48b2d1e26ceb99
Author: Günther Deschner <gd at samba.org>
Date:   Thu Dec 1 21:31:52 2016 +0100

    librpc: add IDL for spoolss_EnumPerMachineConnections
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8ceddba1f3b1aad4c2935e5a1207277f591cace8
Author: Günther Deschner <gd at samba.org>
Date:   Mon Sep 19 17:03:44 2016 +0200

    s3-rpcclient: add cmd_spoolss_get_core_printer_drivers
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e17c8e1b405690d7d38443c8f18c489fc98c1011
Author: Günther Deschner <gd at samba.org>
Date:   Tue Jan 7 15:52:40 2020 +0100

    librpc: fix IDL for spoolss_GetCorePrinterDrivers()
    
    The charset determination makes it more difficult to deal with the real
    REG_MULTI_SZ nature of that element.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ba53e284e689987641f446fb71ddf1f31aee100b
Author: Anoop C S <anoopcs at redhat.com>
Date:   Wed Jan 8 10:24:24 2020 -0800

    s3: lib: dbwrap: Set rec->value_valid to avoid backtrace in `smbstatus`
    
    Following backtrace is observed on executing `smbstatus` with at least
    one SMB client connection established:
    
    PANIC: assert failed at ../../lib/dbwrap/dbwrap.c(82): rec->value_valid
    PANIC (pid 350270): assert failed: rec->value_valid
    BACKTRACE: 15 stack frames:
     #0 /usr/local/lib/libsamba-util.so.0(log_stack_trace+0x1f)
    [0x7fbbd9b32047]
     #1 /usr/local/lib/libsmbconf.so.0(smb_panic_s3+0x74) [0x7fbbd9c1e6ff]
     #2 /usr/local/lib/libsamba-util.so.0(smb_panic+0x28) [0x7fbbd9b32012]
     #3 /usr/local/lib/samba/libdbwrap-
    samba4.so(dbwrap_record_get_value+0x86) [0x7fbbd95800ac]
     #4 /usr/local/lib/samba/libsmbd-base-samba4.so(+0x28f563)
    [0x7fbbd999e563]
     #5 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x7851)
    [0x7fbbd92c7851]
     #6 /usr/local/lib/samba/libsamba-cluster-support-
    samba4.so(ctdbd_traverse+0x4ca) [0x7fbbd92cc641]
     #7 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x73eb)
    [0x7fbbd92c73eb]
     #8 /usr/local/lib/samba/libsamba-cluster-support-samba4.so(+0x7a52)
    [0x7fbbd92c7a52]
     #9 /usr/local/lib/samba/libdbwrap-samba4.so(dbwrap_traverse_read+0x35)
    [0x7fbbd9580de5]
     #10 /usr/local/lib/samba/libsmbd-base-
    samba4.so(smbXsrv_tcon_global_traverse+0xc5) [0x7fbbd999e7d9]
     #11 smbstatus(connections_forall_read+0x114) [0x55d17872b8ee]
     #12 smbstatus(main+0x7b2) [0x55d17872a2f3]
     #13 /lib64/libc.so.6(__libc_start_main+0xf3) [0x7fbbd93a21a3]
     #14 smbstatus(_start+0x2e) [0x55d17872894e]
    Can not dump core: corepath not set up
    
    Assertion on rec->value_valid fails as it is uninitialized in the
    following functions:
    
    traverse_read_callback
    traverse_persistent_callback_read
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Jan  8 23:24:58 UTC 2020 on sn-devel-184

commit 55fbd4c05b477e95920b53b94eda2572e075e6e1
Author: Björn Jacke <bjacke at samba.org>
Date:   Tue Jan 7 10:21:18 2020 +0100

    docs-xml/winbindnssinfo: clarify interaction with idmap_ad etc.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14122
    RN: docs: clarify interaction between winbind nss info and idmap backend
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Jan  8 15:37:46 UTC 2020 on sn-devel-184

commit 4ff13c0174605e45d7d3b26fbb4226d9613b1c98
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 16:08:56 2020 -0700

    vfs_gpfs: Update message for requesting sharemode on stream
    
    User newer debug macro and print full path to affected file.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Jan  8 01:26:46 UTC 2020 on sn-devel-184

commit 5c20ef88ab07f52b7354668873c5d51b58748d12
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:52:14 2020 -0700

    vfs_gpfs: Log failed gpfs_set_share call as error
    
    Any other error code from gpfs_set_share should never happen. Print a
    error message in case this is ever encountered.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 47a2c6707b2f9a9c42673629b82640122c53a609
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:49:39 2020 -0700

    vfs_gpfs: Print message when share modes are disabled in file system
    
    GPFS file systems can be configured without support for share modes. As
    this results in an unique error code, print a message explaining this
    situation and the required config changes.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 191e375d2071de5e44110155230da7e0c4b64d54
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:42:05 2020 -0700

    vfs_gpfs: Explicitly log when share mode has been denied
    
    As this denies access to a file, provide a better error message for
    easier troubleshooting.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a64978e0dc006b9b14541c60379d61e170355468
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:40:07 2020 -0700

    vfs_gpfs: Use early return in sharemode function
    
    This removes one level of indentation.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 03705f4c2fbac6534a925d7511749d4daa378b2e
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:25:22 2020 -0700

    vfs_gpfs: Switch share mode helper function to return int
    
    Follow the convention to return 0 on success and -1 when hitting an
    error.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f03c4485a2e50d496875fb157d5405e2afa7a0f5
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:23:41 2020 -0700

    vfs_gpfs: Remove logging for unsupported file system
    
    The gpfs_set_share API call has been around for a long time and
    definitely all supported GPFS versions have it. Remove the check and
    fallback for old versions without this API.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ef52a907fe80fdb1cd199a21a68126a7bf9b33cb
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:14:17 2020 -0700

    vfs_gpfs: Only clear sharemode on close when sharemode has been taken
    
    This avoids a redundant error message in case the call to acquire the
    sharemode had failed before.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c993480eeff7ff6aee7c4f90f103dcb8d1cd3c6f
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:07:29 2020 -0700

    vfs_gpfs: Log error if clearing of sharemode fails on close
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d912895590170bdd8c720304c664a2259d6a9228
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 14:00:32 2020 -0700

    vfs_gpfs: Add comment explaining why sharemode is dropped in close call.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 56cf9b15f0a42323d94a407a4de7fae9b039a326
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Jan 6 13:53:13 2020 -0700

    vfs_gpfs: Remove unncessary check from close function
    
    The fsp has a valid file descriptor when this function is called. No
    need for the additional check.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5d5763ea8ce14f81107462e7f2dff09b6aec1fbc
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:56:07 2020 -0700

    vfs_gpfs: Cleanup debug message file system share mode
    
    Use the newer debug macro and the full variable names.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit eff66787c646e6ce6375929f7d61e9f1b5a0e202
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 11:40:50 2020 -0700

    vfs_gpfs: Cleanup clearing file system share mode
    
    The VFS flock function is called with a zero access_mask to indicate
    that the share mode should be cleared. Adjust the check to directly
    check the access_mask and provide a better message to indicate this
    case.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 79a50e75b24e7c236f7a5422c7676d45bbe93365
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Dec 30 15:39:43 2019 -0700

    vfs_gpfs: Move mapping to sharemode deny to helper function
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 05c54b72c5ad3c8bce18f9a38413032e5224e644
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Dec 30 15:33:03 2019 -0700

    vfs_gpfs: Move mapping from access mask to sharemode allow to helper function
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 208007b86c407e98a796dfae30affade05abe4f7
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Dec 30 15:20:05 2019 -0700

    vfs_gpfs: Remove check for open file in share mode function
    
    The calling code already ensures that the file is open with a valid file
    descriptor.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 00fb46c7f2f678aa601e4def2b53702d6fabf2e5
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:52:48 2020 -0700

    vfs_time_audit: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b306a7361e9d8e2f50f87e8904fc622da799864e
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:51:17 2020 -0700

    vfs_streams_xattr: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 86c2578a55507804f7ccd7d3a9656ceaa90fb302
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:45:06 2020 -0700

    vfs_gpfs: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0d5794f6f92dbfc2400b73ed3a0376a050b28b50
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:41:00 2020 -0700

    vfs_glusterfs: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4667399457fee5b49c931c81cb963c6771f03a8d
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:38:00 2020 -0700

    vfs_full_audit: Rename argument of flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 83f59ac00e965a63b81873026e0e8d1c5a72f939
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:09:23 2020 -0700

    vfs_ceph: Rename argument for flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 537d226ed93fdbccf236b7f79bb32802254a2356
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:08:38 2020 -0700

    vfs_catia: Rename argument for flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 974aae418f68e7dac1e9277d8b8df4b41f0cfa8c
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:06:40 2020 -0700

    vfs_not_implemented: Rename argument for flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e8d9a21435ae4266093e355feda1c9bac6f9956e
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 12:05:57 2020 -0700

    vfs: Rename argument for kernel_flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ad8e6863c3791e50bc80418bc94f4970ed6b0e68
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jan 3 11:58:38 2020 -0700

    system: Rename argument for kernel_flock function
    
    MS-SMB2 and the smbd code refer to this field as share_access. Use the
    same name in the function argument.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7f75dec865256049e99f7fcf46317cd2d53e95d1
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 22:58:06 2020 +0100

    auth: Simplify struct auth4_context
    
    The fake async code has been pushed down into the 3 users, remove the sync
    callback. Overall it's more lines of code, but the central interface is
    simplified.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Jan  6 23:34:00 UTC 2020 on sn-devel-184

commit add8fd21c08f1225191b0794a92206f5c9248d23
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 17:22:36 2020 +0100

    ntlm_auth: Replace winbind_pw_check() by _send and _recv
    
    This is just fake async, but it avoids one use of a sync function
    pointer in auth4_context
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 066c4eeaa4fc36052eb30c3aeb6d0be4c82ae1ef
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 17:22:36 2020 +0100

    ntlm_auth: Replace local_pw_check() by _send and _recv
    
    This is just fake async, but it avoids one use of a sync function
    pointer in auth4_context
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d3d2e6df9c17202c37e8f6beeb0da2738838181c
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 17:22:36 2020 +0100

    auth3: Replace auth3_check_password() by _send and _recv
    
    This is just fake async, but it avoids one use of a sync function
    pointer in auth4_context
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 004e553174623422e68055f727098b0a711eb1a2
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Jan 3 15:39:34 2020 +0100

    winbindd_pam.c: split winbindd_dual_pam_auth_samlogon
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Jan  6 20:33:55 UTC 2020 on sn-devel-184

commit e4ad0013787a726bfc3d1ba3644b60a6c77ace37
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:24:13 2020 +0100

    auth: Avoid casts in ntlm_check.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Gary Lockyer <gary at samba.org>
    Autobuild-Date(master): Mon Jan  6 03:12:20 UTC 2020 on sn-devel-184

commit e02d24c0875eb04a53c19119148f5203374382e0
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:04:02 2020 +0100

    auth: Check for talloc failure in smb_sess_key_ntlmv2()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4014d91b9a68aa2161421896a82d84e4211e480e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:10:00 2020 +0100

    auth: Slightly simplify smb_pwd_check_ntlmv1()
    
    Do an early return for the failure case
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 2bd941cc12245728b374edc0f71f5938c887a566
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:04:02 2020 +0100

    auth: Check for talloc failure in smb_pwd_check_ntlmv1()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit b78cc8210d3fe75af5236a16841060bbcc553cde
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:10:00 2020 +0100

    auth: Slightly simplify smb_pwd_check_ntlmv2()
    
    Do an early return for the failure case
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 8ec4e4b668d009f9c79ce324dce0d512e16d4cb9
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 14:04:02 2020 +0100

    auth: Check for talloc failure in smb_pwd_check_ntlmv2()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 59cb155a27f21a55bdc588d38c8080cd29562a7e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 13:47:14 2020 +0100

    auth: Remove the "typedef auth_methods"
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 33d4d482718fca10030b5a569f17cb1a2637fc8a
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 12:42:03 2020 +0100

    winbind: Fix CID 1456624 Uninitialized scalar variable
    
    Coverity does not get that for (rc!=0) gnutls_error_to_ntstatus()
    never returns NT_STATUS_OK
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit d034e839df0898d9db0dc00c1ccf2f113f1787f1
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 15:02:44 2020 +0100

    auth3: Avoid a casts in auth3_check_password()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit bcf944445837e7cdd611dc89fe931575fa771017
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 12:51:04 2020 +0100

    auth3: Simplify auth_get_ntlm_challenge()
    
    Use generate_random_buffer() directly on the talloc'ed buffer
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit b2f070349326bbdb69415524f0a9fa8d54c18049
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 12:41:16 2020 +0100

    auth3: Check for talloc failure
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 7283413a3faf4048a46e77c4ac5ed7a8bb804ff6
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Jan 3 12:28:49 2020 +0100

    tests: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 03b42aeb811ae7260a9a9e197212767877484a78
Author: Björn Jacke <bj at sernet.de>
Date:   Fri Jan 3 15:29:34 2020 +0100

    python/loadparm: check for AD DC required VFS modules
    
    same as the previous commit, just for python's testparm code
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10560
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Fri Jan  3 22:19:47 UTC 2020 on sn-devel-184

commit 4d4443d1e539c1ce0f7245fbcffbf22df8355b2d
Author: David Disseldorp <ddiss at samba.org>
Date:   Fri Jan 3 14:31:28 2020 +0100

    loadparm: check for AD DC required VFS modules
    
    When Samba is running as a domain controller and the "vfs objects"
    parameter is not set, then the dfs_samba4 and acl_xattr modules are
    automatically enabled.
    However, if the "vfs objects" is defined, then the setting is left
    as-is. This means that attempts to us other VFS modules have the side
    effect of disabling the dfs_samba4 and acl_xattr modules, causing
    unexpected behaviour, which is then blamed on the VFS modules that were
    explicitly defined.
    
    This change ensures that when running as a domain controller, Samba logs
    an error if the required VFS modules are not enabled by an explicit
    "vfs objects" definition.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10560
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Björn Jacke <bjacke at samba.org>

commit 1d0ffcf30e625e7570daa800cf5adf3113c99ce5
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 22 18:20:12 2019 +0100

    smbd: Remove an unused parameter from defer_open()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Fri Jan  3 01:30:24 UTC 2020 on sn-devel-184

commit ed3ee452549f5c25800dd7da1c6dc30a826fe28f
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Dec 16 16:47:38 2019 +0100

    smbd: Avoid a "? True : False"
    
    VALID_STAT() already is a boolean expression
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 5954a0688ae7fa992f8b5a19793b8662ca2794e1
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Dec 7 14:13:04 2019 +0100

    lsasd: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit fd406528b79a2fe4aefe0e04495cdaebe381e3d1
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 1 16:21:12 2019 +0100

    dsdb: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit f53c8fbd7ff2be62c1c488cd56507516d85c670d
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 1 16:10:18 2019 +0100

    audit_log: Align integer types
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 605bb4e9077aca1fa06c1c5beca42ca3b91308f7
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Dec 30 13:56:14 2019 +0100

    ntlm_auth: Fix a DEBUG message
    
    This is not routine auth_generic_prepare
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit ba97f408d81e98863732a8c6bcb59de7a8fedd6b
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 2 11:15:48 2020 +0100

    lib: Remove an unused variable from security_token_debug()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 9edf15afc219a1a782ec1e4d29909361bbabc744
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Nov 28 14:00:58 2019 +1100

    ctdb-tests: Skip some tests that don't work with IPv6
    
    See the comments added to the tests.
    
    It may be possible to rewrite these so they do something sane for
    IPv6... some other time.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14227
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Fri Jan  3 00:00:55 UTC 2020 on sn-devel-184

commit 693080abe4d8bec96280af5a6aa668251a98ec5d
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Dec 13 11:09:04 2019 +1100

    ctdb-scripts: Strip square brackets when gathering connection info
    
    ss added square brackets around IPv6 addresses in versions > 4.12.0
    via commit aba9c23a6e1cb134840c998df14888dca469a485.  CentOS 7 added
    this feature somewhere mid-release.  So, backward compatibility is
    obviously needed.
    
    As per the comment protocol/protocol_util.c should probably print and
    parse such square brackets.  However, for backward compatibility the
    brackets would have to be stripped in both places in
    update_tickles()...  or added to the ss output when missing.  Best to
    leave this until we have a connection tracking daemon.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14227
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit df5040b186753acf72600042753d312bd5945429
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Jan 1 10:05:07 2020 +0100

    Happy New Year 2020!
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Wed Jan  1 12:04:52 UTC 2020 on sn-devel-184

commit 40ecc2f6f015b86b49326bff4b1cbcab8263f1ac
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 20 16:20:00 2019 +0100

    lib: Fix contending with a READ lock
    
    When contending a WRITE with an existing READ, the contender puts
    himself into the exclusive slot, waiting for the READers to go
    away. If the async lock request is canceled before we got the lock, we
    need to remove ourselves again. This is done in the destructor of the
    g_lock_lock_state. In the successful case, the destructor needs to go
    away.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sun Dec 22 18:57:17 UTC 2019 on sn-devel-184

commit 12638d48a63e90d7d5568d00e39c7041f96675ae
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 22 14:05:17 2019 +0100

    torture3: Add a test that contends with a READ, not a WRITE lock
    
    This walks different code paths in the subsequent locker. And the one
    that we did not test so far is in fact buggy
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bc00eaca703be97709d0706f746930b3a13bb44b
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 22 14:01:07 2019 +0100

    torture3: Parametrize lock4_child()s locktype
    
    We'll call it twice soon
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bf592a1905984042aeb57ddef654229ffb2ee39b
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Dec 21 10:47:37 2019 +0100

    torture3: Introduce "key" helper variable
    
    Call string_term_tdb_data() once instead of three times
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 30f9e1dd596a0dc4894f17b07a7e2e58dcb75c16
Author: awalker <awalker at ixsystems.com>
Date:   Fri Aug 30 15:30:57 2019 -0400

    vfs_zfsacl: fix issue with ACL inheritance in zfsacl
    
    Add parameter zfsacl:map_dacl_protected to address issue preventing Windows Clients
    from disabling inheritance on ACLs. FreeBSD does not currently expose the ACL_PROTECTED
    NFS4.1 flag, but it does expose ACE4_INHERITED_ACE. When the parameter is enabled,
    map the absence of ACE4_INHERITED_ACE to SEC_DESC_DACL_PROTECTED.
    
    See also the discussion at
    
    https://gitlab.com/samba-team/samba/merge_requests/719
    
    Signed-off-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Dec 20 23:24:54 UTC 2019 on sn-devel-184

commit 063fadd322e54ee12689485457ce15a1bb8c0769
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Oct 19 15:37:45 2019 +0200

    vfs_zfsacl: pass config to zfs_get_nt_acl_common()
    
    Not used for now, that comes next.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cd313d0ade15556875ebec060b047a2c6e087b62
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Oct 19 15:36:15 2019 +0200

    vfs_zfsacl: pass nfs4_params to smb_set_nt_acl_nfs4()
    
    Now that we parse nfs4_params in the VFS connect in this module, we can pass it
    to smb_set_nt_acl_nfs4() which avoids having smb_set_nt_acl_nfs4() parse
    it *every time* it's called.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2c7699e7202bef6b8d40c829a4e1515a838f0f6d
Author: awalker <awalker at ixsystems.com>
Date:   Fri Aug 30 15:17:26 2019 -0400

    vfs_zfsacl: add manpage entry for zfsacl:denymissingspecial
    
    Signed-off-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 31d5e945a44e5b8a59933b3516f4235e6057ceb7
Author: awalker <awalker at ixsystems.com>
Date:   Fri Aug 30 15:15:37 2019 -0400

    vfs_zfsacl: load parameters on connect
    
    Convert zfsacl:denymissingspecial so that the parameter loads on connect.
    
    Signed-off-by: Andrew Walker <awalker at ixsystems.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 33212832b0e61b3c5176b819c34957adeaf6fe5e
Author: David Mulder <dmulder at suse.com>
Date:   Tue Dec 10 13:49:28 2019 -0700

    Convert samba4.base.rw1 test to smb2
    
    Signed-off-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 946beafb621c6a5353a87c40264f53a253249c52
Author: David Mulder <dmulder at suse.com>
Date:   Tue Dec 10 07:47:12 2019 -0700

    Convert samba4.base.*attr tests to smb2
    
    Signed-off-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 670205acab186448e175433225bfebacf3500900
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 10:17:38 2019 +0100

    s3: remove unused session_keystr from struct user_struct
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Fri Dec 20 13:06:20 UTC 2019 on sn-devel-184

commit 5db4a881f6ae74561d0ffd309992896f6681712d
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 22 18:08:56 2019 +0100

    s3: remove unused macro FSP_BELONGS_CONN()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1fa05e5c76e718142326915f8671299217a093df
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 15:24:23 2019 +0100

    s3: simplify create_conn_struct_as_root()
    
    Now that all callers pass in a valid session_info, we can remove handling of
    session_info=NULL. Add an assert(session_info != NULL) just in case... :)
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ee5bf29662ebb164e4be8811c2fcc9bfde88add3
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:58:57 2019 +0100

    pysmbd: add "session_info" arg tp py_smbd_create_file()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7121d475794b951d9bee13d50e6be125f8cc7c2f
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:57:53 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_mkdir()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5cef3a13b880ee058f633e68a9b35996365b5c29
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:56:18 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_get_sys_acl()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a9184a109902bc899920411b7a8893f934c2fd27
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:54:40 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_set_sys_acl()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9b2c415d2c614c8980fc800fa1cf967d69eb7975
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:52:49 2019 +0100

    pysmbd: make "session_info" arg to py_smbd_get_nt_acl() mandatory
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 437af4d07944f201c26cd0ebc4a5622e342d0f4c
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:49:42 2019 +0100

    pysmbd: make "session_info" arg to py_smbd_set_nt_acl() mandatory
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a4f3860da31a42c3905cdd8f7ff7103bf901394d
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:14:45 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_unlink()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit da2a9857d0397d75ac45fc62440ad29bbd0388a1
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:14:07 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_chown()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e6d40e6f9c022c5e571255cd4ff248d5a188b45f
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:13:30 2019 +0100

    pysmbd: add "session_info" arg to py_smbd_set_simple_acl()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9807d69ef4178d4a2c974fed5708ad2d487d0c19
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 15:32:17 2019 +0100

    python/tests: use a system session_info in posixacl.py
    
    Previously posixacl.py passed None as session_info object from
    get_session_info().
    
    That meant that the if/else branch referring to session_info:
    
            if nwrap_winbind_active or session_info:
                 self.assertEquals(posix_acl.acl[1].a_perm, 7)
             else:
                 self.assertEquals(posix_acl.acl[1].a_perm, 6)
    
    must be tweaked to take into account that session info is now either
    
    * a system session_info in which case we must continue to use the if branch in
      the code, or
    
    * a user session_info in which case we must continue to go through the else
      branch
    
    Using
    
      is_user_session = not session_info.security_token.is_system()
    
    in place of just "session_info" does the trick.
    
    Cf the classes SessionedPosixAclMappingTests and
    UnixSessionedPosixAclMappingTests in posixacl.py, those are the ones that
    trigger test execution with a user session.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 927c87d253c42282e8f62038363399f7643fcc76
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:58:32 2019 +0100

    pysmbd: reformat py_smbd_create_file() kwnames
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d80259d819ecdb149ec5d7b9f90eb44eca421320
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:57:20 2019 +0100

    pysmbd: reformat py_smbd_mkdir() kwnames
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9ff378677afbe3298293779c9168769e15f2d021
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:55:54 2019 +0100

    pysmbd: reformat py_smbd_get_sys_acl() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit af1f6e9fd165223505c7c5ec59d94bbc3a41dc55
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:54:04 2019 +0100

    pysmbd: reformat py_smbd_set_sys_acl() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 33f33dc08e3ece38cf20924c0513f0857f8eb6d8
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:21:03 2019 +0100

    pysmbd: reformat py_smbd_get_nt_acl() kwnames
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 59a6c9a4ce01ce1762be6cf0191db4df211d3b06
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 14:16:52 2019 +0100

    pysmbd: reformat py_smbd_have_posix_acls() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b08c955ae92db8aae57f821c4080d225b6b01944
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 12:59:32 2019 +0100

    pysmbd: reformat py_smbd_unlink() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 399ebb56865202414cd2b5a8f1880d8c3e8a697a
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 12:58:08 2019 +0100

    pysmbd: reformat py_smbd_chown() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9796ebcec4f98d81608e8e3d500745b1dc5f9101
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 17 12:54:11 2019 +0100

    pysmbd: reformat py_smbd_set_simple_acl() kwnames and PyArg_ParseTupleAndKeywords() call
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit cfc0ca73374c8a0c418d6738753a10ab872688f6
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 18:00:26 2019 +0100

    python: move system_session_unix to new auth_util.py
    
    system_session_unix() will be used by many more callers soon.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 459233b96238e319d8b37c471359bdeb4d26aadf
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 14:42:04 2019 +0100

    smbd: pass session_info to create_conn_struct_tos()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d68d8c6538287a8b6a4bbe4b43bf0621440592d8
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 14:41:03 2019 +0100

    s3:rpc_server: pass session_info to get_nt_acl_no_snum()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7fb188c119274a0e84b279ac13a0d696c4884c78
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 16 14:40:21 2019 +0100

    s3:rpc_server: pass session_info to elog_check_access()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 0e57dbb8466f06c0992dd207acddc8fece47309c
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:19:37 2019 +0100

    smbd: pass session info to create_conn_struct_tos_cwd()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 10fa50a8454f0d7a68f17b26e00e0787325f2dfe
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:53:36 2019 +0100

    smbd: pass session_info to form_junctions()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d6a5aa6d0fdc6f6057a07e8421b71e40d0f845f9
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:51:16 2019 +0100

    smbd: pass session info to count_dfs_links()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 457c91406aae65689db4df12dd236d2359d7eb88
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:31:04 2019 +0100

    s3: pass session_info to enum_msdfs_links()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8d457a83dd126ac46f498c19a15089c2314625e1
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:27:51 2019 +0100

    smbd: pass session_info to junction_to_local_path_tos()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e12a724f0ddf0280b43cbd8107d34fe316585795
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:25:44 2019 +0100

    s3: pass session_info to remove_msdfs_link()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8a0ad072ac0e056ccd34f59f49c6391a50c17c74
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:23:38 2019 +0100

    s3: pass session_info to create_msdfs_link()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8517bb109c886fcc0b281dd715934138075bab1b
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 13 16:19:03 2019 +0100

    s3: pass session info to get_referred_path()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a85d257c1ec3a4505f2a4fcbec0f7e1f60dbff91
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 20 10:50:09 2019 +1300

    librpc: Do not access name[-1] trying to push "" into a dnsp_name
    
    This simply matches the behaviour from before e7b1acaddf2ccc7de0301cc67f72187ab450e7b5
    when the logic for a trailing . was added.  This matches what is added in
    the dnsRecord attribute for a name of "." over the dnsserver RPC
    management interface and is based on what Windows does for that name
    in (eg) an MX record.
    
    No a security bug because we use talloc and so name will be just the
    end of the talloc header.
    
    Credit to OSS-Fuzz
    
    Found using the fuzz_ndr_X fuzzer
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Fri Dec 20 11:33:52 UTC 2019 on sn-devel-184

commit 16557e4480a7502d45186854546d502479be156f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 20 11:34:38 2019 +1300

    selftest: Confirm parse of dnsProperty records
    
    This confirms a name of "." will round-trip correctly.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 49197368d4dc6925ce7713d46d8adb93c51da433
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 20 16:33:54 2019 +1300

    WHATSNEW: Celebrate the end of smbdes and the almost-end of in-tree AES
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 30cbc5b90e4951a0ea924c204ff73e15c9750ace
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 19 11:20:30 2019 +1300

    s4-smbd: Also restart prefork children lost to SIGKILL (-9)
    
    Samba 4.10 and later versions have a process restart capability to greatly
    reduce the impact of crashes due to a NULL pointer de-reference or abort().
    
    However SIGKILL was deliberatly omitted.
    
    Sadly this is the most likely case, due to the OOM killer, as raised here:
    
    https://lists.samba.org/archive/samba-technical/2019-November/134529.html
    
    Subsequent discussion (offline) has been to agree that we should restart in
    this case.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14221
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b28d1dca86d33efac9d03b35c5c9804e02ddfb9a
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 16 16:45:38 2019 +0100

    librpc: Add test for ndr_string_length()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Dec 20 09:01:30 UTC 2019 on sn-devel-184

commit f11e207e01c52566c47e350ff240fe95392de0c3
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 16 15:50:17 2019 +0100

    librpc: Fix string length checking in ndr_pull_charset_to_null()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14219
    
    Pair-Programmed-With: Guenther Deschner <gd at samba.org>
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0bd479140c18ab79479ced4f25f366744c3afe18
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Dec 19 16:31:46 2019 +1300

    upgradedns: ensure lmdb lock files linked
    
    Ensure that the '-lock' files for the dns partitions as well as the data
    files are linked when running
      samba_dnsupgrade --dns-backend=BIND9_DLZ
    failure to create these links can cause corruption of the corresponding
    data file.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14199
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f0cebbe4dd0317e2abfcbe252977383e6f37f3bd
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Dec 19 16:31:24 2019 +1300

    test upgradedns: ensure lmdb lock files linked
    
    Add tests to check that the '-lock' files for the dns partitions as well as
    the data files are linked when running
        samba_dnsupgrade --dns-backend=BIND9_DLZ
    failure to create these links can cause corruption of the corresponding
    data file.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14199
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1cf2397226d1ba6d0ff91c58da77b989e30b0420
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in chgdcpass
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Fri Dec 20 07:34:42 UTC 2019 on sn-devel-184

commit 2e5188f520d0d452c7ac211ef7cf2791a320ec1f
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in rodc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 629254ec5b0d60a342f071aa1e67c22822d940a4
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in fl2008r2dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 3518151cb2474ff9000b87e9f08d13290adfadae
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in fl2003dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit bd141ead0dd238834aa13f0801463de8563f1dde
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in fl2000dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit fbcf1ab7087e6d80aa1336aa0cad5c6e7fec62ee
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in vampire_dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit db24892d0e1f5b87dc1b4fb297fde07c919f1dfb
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 09:50:48 2019 +0100

    selftest: don't use NTVFS fileserver in promoted_dc
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 01141d06af858cefdd9a98364122a923cbd312b3
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 13:03:28 2019 +0100

    selftest: make fl2008dc an alias for ad_dc, not ad_dc_ntvfs
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit bba0cafa951eee2cbe3a0e87e486c600a24818db
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 13:03:28 2019 +0100

    selftest: make ad_dc_slowtests an alias for ad_dc, not ad_dc_ntvfs
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8d1206c92094fce98d42d379bcd07275a51fd50c
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 13:32:04 2019 +0100

    selftest: make ad_dc_default an alias for ad_dc, not ad_dc_ntvfs
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ac115db1fcaae7913dd1e62a5558272e235264e6
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 17:43:37 2019 +0100

    selftest: run samba.tests.samba_tool.user against ad_dc_ntvfs:local explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f3f22851ff12014452202c1eba4d96ac8db33645
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 16:52:41 2019 +0100

    selftest: run samba.ldap.referrals against ad_dc_ntvfs explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 0f5b66230d08f27af0ae6f53038271462053ab25
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 16:52:29 2019 +0100

    selftest: run samba4.ldap.dirsync.python against ad_dc_ntvfs explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 88a381389c370b697d194c1217d1609bea854c23
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 16:49:34 2019 +0100

    selftest: run samba.tests.dcerpc.srvsvc against ad_dc_ntvfs explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7974e55024f9d0479a375ffc990293941ff90303
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 16:14:49 2019 +0100

    selftest: run rpc.srvsvc and rpc.mgmt against ad_dc_ntvfs explicitly
    
    No change in behaviour.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 9174968b01565a13b046a14a46e9cb77ea4cb5c2
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 13:39:31 2019 +0100

    selftest: hardcode ad_dc_ntvfs for the rpc.netlogon testsuite
    
    The rpc.netlogon testsuite has a test that verifies LSA over netlogon which is
    only enabled in the ad_dc_ntvfs env.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 2d2809be7b17afd0a6054e93c9e5491a31356a1d
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 13:35:29 2019 +0100

    selftest: make testenv name logic more flexible for the rpc testcases
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit c20179a4f86bbaad75b0f87376257080760c650b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 25 14:17:50 2019 +0100

    selftest: use ad_dc_ntvfs env instead of ad_dc_default for samba4.ldb.ldaps
    
    ad_dc_default is currently an alias for ad_dc_ntvfs, so this is currently no
    change in behaviour, but this is going to change.
    
    As the ad_dc_ntvfs env specifies "ldap server require strong auth =
    allow_sasl_over_tls" and this is needed for the test, we have to let the test
    use the ad_dc_ntvfs env explicitly.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8b04590e4d8f817ad6d194bb9d622c18734e3011
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 25 11:11:13 2019 +0100

    libsmbclient: If over SMB1 first try to do a posix stat on the file.
    
    Disable in future, if server doesn't support this.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Dec 19 15:44:25 UTC 2019 on sn-devel-184

commit b3e3cb3bbd86a53b48ee009adf811d48dd50dc8b
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 25 11:10:49 2019 +0100

    s3:libsmb: Add a setup_stat_from_stat_ex() function
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0fe9dc5219beaf605da9c7922053f7324507b50e
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 25 11:09:52 2019 +0100

    s3:libsmb: Return a 'struct stat' buffer for SMBC_getatr()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bf9a3a7aa1913238ae2c997ce00369d0dbae3a08
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 25 11:06:57 2019 +0100

    s3:libsmb: Add try_posixinfo to SMBSRV struct. Only enable for SMB1 with UNIX for now.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ea51a426e506bd6456814ecddcb63441859f9d89
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Dec 18 13:27:26 2019 +0100

    s3:libsmb: Generate the inode only based on the path component
    
    Currently we use the full smb url which includes also username and
    password.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14101
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dd694bdc643ad294475ddf2dd42b537ffeb7e8dc
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 26 08:21:27 2019 +0100

    s3:script: Try to fix a Perl warning
    
    Scalar value @ENV{"BASH_ENV"} better written as $ENV{"BASH_ENV"} at
    /tmp/samba-testbase/b23/samba-ad-dc-1/source3/script/tests/printing/modprinter.pl
    line 134.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1bfb384018deb2ee5c27dbea9fa2cdd98901fdcc
Author: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Date:   Mon Dec 16 10:28:53 2019 +0100

    source4/utils/oLschema2ldif: include stdint.h before cmocka.h
    
    This fix the following build failure:
    
    In file included from /home/fabrice/buildroot/output/host/opt/ext-toolchain/lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/include/stdint.h:9:0,
                     from /home/fabrice/buildroot/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/inttypes.h:27,
                     from ../../lib/replace/../replace/replace.h:64,
                     from ../../source4/include/includes.h:23,
                     from ../../source4/utils/oLschema2ldif/test.c:25:
    /home/fabrice/buildroot/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27: error: conflicting types for ‘uintptr_t’
     typedef unsigned long int uintptr_t;
                               ^
    In file included from ../../source4/utils/oLschema2ldif/test.c:23:0:
    /home/fabrice/buildroot/output/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/cmocka.h:132:28: note: previous declaration of ‘uintptr_t’ was here
           typedef unsigned int uintptr_t;
    
    Fixes:
     - http://autobuild.buildroot.org/results/9507739b3d5d51024ee9c60b74c2f85d5004e7e2
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14218
    
    Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Dec 18 16:57:52 UTC 2019 on sn-devel-184

commit f8799bf076d647d73aa749f3864d022a366c3904
Author: Fabrice Fontaine <fontaine.fabrice at gmail.com>
Date:   Sun Dec 15 17:08:24 2019 +0100

    lib/ldb/tests: include stdint.h before cmocka.h
    
    This fix the following build failures:
    
    [2466/3864] Linking bin/default/lib/ldb/ldbmodify
    In file included from /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/include/stdint.h:9:0,
                     from ../../lib/tevent/tevent.h:31,
                     from ../../lib/ldb/include/ldb.h:51,
                     from ../../lib/ldb/tests/test_ldb_dn.c:25:
    /home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27: error: conflicting types for 'uintptr_t'
     typedef unsigned long int uintptr_t;
                               ^
    In file included from ../../lib/ldb/tests/test_ldb_dn.c:23:0:
    /home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/cmocka.h:132:28: note: previous declaration of 'uintptr_t' was here
           typedef unsigned int uintptr_t;
                                ^
    
    In file included from /home/buildroot/autobuild/instance-0/output-1/host/opt/ext-toolchain/lib/gcc/mips64el-buildroot-linux-uclibc/5.5.0/include/stdint.h:9:0,
                     from ../../lib/tevent/tevent.h:31,
                     from ../../lib/ldb/tests/ldb_key_value_test.c:48:
    /home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/stdint.h:122:27: error: conflicting types for 'uintptr_t'
     typedef unsigned long int uintptr_t;
                               ^
    In file included from ../../lib/ldb/tests/ldb_key_value_test.c:43:0:
    /home/buildroot/autobuild/instance-0/output-1/host/mips64el-buildroot-linux-uclibc/sysroot/usr/include/cmocka.h:132:28: note: previous declaration of 'uintptr_t' was here
           typedef unsigned int uintptr_t;
                                ^
    
    Fixes:
     - http://autobuild.buildroot.org/results/9507739b3d5d51024ee9c60b74c2f85d5004e7e2
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14218
    
    Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f0eb1e623f76d3dbd0c22f96cabebd1041c147df
Author: Torsten Fohrer <torsten.fohrer at sbe.de>
Date:   Sun Dec 15 16:58:40 2019 +0100

    Avoiding bad call flags with python 3.8, using METH_NOARGS instead of zero.
    
    (C) SBE network solutions GmbH
    
    Signed-off-by: Torsten Fohrer <torsten.fohrer at sbe.de>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Dec 18 14:33:58 UTC 2019 on sn-devel-184

commit 5fd65edc91b0f56e044428a32676b079aec9377d
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Aug 13 13:15:58 2019 +0200

    samba_kcc: avoid ValueError when local connections are less than 2
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Björn Baumbach <bb at sernet.de>
    Autobuild-Date(master): Wed Dec 18 11:37:53 UTC 2019 on sn-devel-184

commit f8f3b33ea58a03dc3c17b03256530b6990ce9191
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Dec 14 18:35:51 2019 +0100

    lib/replace: prefer <sys/xattr.h> over <attr/xattr.h>
    
    This prevents the following compile error that may happens if "system/filesys.h"
    is included before "system/capability.h" on Ubuntu 16.04:
    
      [1802/4407] Compiling source3/lib/system.c
      In file included from ../../lib/replace/system/filesys.h:112:0,
                       from ../../source3/include/vfs.h:29,
                       from ../../source3/include/smb.h:150,
                       from ../../source3/include/includes.h:284,
                       from ../../source3/lib/system.c:23:
      /usr/include/x86_64-linux-gnu/sys/xattr.h:32:3: error: expected identifier before numeric constant
         XATTR_CREATE = 1, /* set value, fail if attr already exists.  */
         ^
    
    The above error is from compiling a source tree which includes a change that
    adds an include "system/filesys.h" to the top of "source3/include/vfs.h".
    
    "source3/lib/system.c" has the following includes:
    
      #include "includes.h"
      #include "system/syslog.h"
      #include "system/capability.h"
      #include "system/passwd.h"
      #include "system/filesys.h"
      #include "../lib/util/setid.h"
    
    The first include of "includes.h" pulls in "vfs.h" which will pull in
    "system/filesys.h" with the mentioned change. "system/filesys.h" pulls in
    <attr/xattr.h> which has this define
    
      #define XATTR_CREATE  0x1
    
    Later in "source3/lib/system.c" "system/capability.h" is included which includes
    <sys/xattr.h> on Ubuntu 16.04 (not in later versions of glibc). This defines the
    XATTR_* values as an enum:
    
      enum {
        XATTR_CREATE = 1,     /* set value, fail if attr already exists.  */
        XATTR_REPLACE = 2     /* set value, fail if attr does not exist.  */
      };
    
    The previous define of XATTR_CREATE as 1 makes this
    
      enum {
        1 = 1,     /* set value, fail if attr already exists.  */
        2 = 2     /* set value, fail if attr does not exist.  */
      };
    
    which is invalid C. The compiler error diagnostic is a bit confusing, as it
    prints the original enum from the include file.
    
    See also:
    
    <https://bugs.freedesktop.org/show_bug.cgi?id=78741>
    <https://bugs.launchpad.net/ubuntu/+source/attr/+bug/1288091>
    <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756097>
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Björn Baumbach <bb at samba.org>

commit ad9a81c6a933558e8ae5ccbdcb329e9effc82bb0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 15:56:55 2019 +1300

    librpc: Move winstation.idl to the top level and exclude from fuzzing
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Dec 18 08:05:05 UTC 2019 on sn-devel-184

commit 5eac5813cc42ab4f17858e61cc512bace4d3bad2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 15:34:34 2019 +1300

    lib/fuzzing and librpc: Do not generate fuzzers for pointless targets
    
    We need to focus the fuzzing effort on reachable code, and these IDL
    are just historical artifacts, many are entirely [todo] and have
    no samba client nor server.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit bbc4ebbcaf3e602cf11816a24e58f4dc3eed7d8d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 14:48:38 2019 +1300

    lib/fuzzer: Allow coverage build for oss-fuzz
    
    This still does not seem to be enough but it is one step towards a working
    coverage build.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4d9753dfbd8a2d66d86f60aabee627826247aa38
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Wed Dec 18 11:17:51 2019 +1300

    lib ldb: fix use after free
    
    Fix ASAN detected use after free.  No security implications as  the
    talloc_free is followed immediately by the print statement and the value
    printed is an integer
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0e651b4508d44e4343c83e1c157d919150aee489
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 12:19:37 2019 +1300

    librpc: Fix manually written printer for drsuapi_DsAttributeValue
    
    Credit to OSS-Fuzz
    
    Found using the ndr_fuzz_X target.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 5ccb5e23c96a6555e03fac66a382780df56bcfe6
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 12:20:35 2019 +1300

    sefltest: Demonstrate crash in manually written printer for drsuapi_DsAttributeValue
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 5a989d6670911e16aed9061a8c6a74676f4c8a8e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 12:01:01 2019 +1300

    lib/fuzzing: Allow load of fuzz inputs as files on the command line
    
    This is easier to put under gdb.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 66d12eb98aba10948f829d08b4144969ead5ddbb
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 13 22:41:10 2019 +1300

    lib/fuzzing: Initialise st buffer in fuzz_ndr_X
    
    An NDR pull of a function will fill in either the in. or out.
    elements of this structure, but never both.
    
    However, some structures have size_is() in the out. that reference
    the in. elements.  This is the reason for the --context-file option
    in ndrdump.
    
    We have a special handler in the fuzzing case embedded in the
    pidl-generated output to cope with this, by filling in pointers
    for elements declared [ref,in] but it relies on the in-side
    (at least) of the buffer being zeroed.
    
    So zero the buffer before we start.  Sadly this means things
    like valgrind can not find a use of uninitialised data, but that
    is a price we have to pay.
    
    Credit to OSS-Fuzz
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 1141fbe9842c57fca7ee1175665638a0c1f5a181
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Dec 11 16:19:59 2019 +0100

    smbd: Convert share_mode_data->num_share_modes into a boolean8
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Dec 18 00:05:13 UTC 2019 on sn-devel-184

commit 4a60e577db51b0ee5b450d643872463d6939ccee
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Dec 11 10:02:54 2019 +0100

    smbd: Don't store "num_share_modes" in locking.tdb
    
    With the last commit we don't store the share mode entry count
    anymore. With this commit we go one step further and avoid storing
    it. If there's valid record in locking.tdb, there is a corresponding
    record in share_entries.tdb, so there's no point storing that once
    more explicitly.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9734bad37b8bc4b2815f2bff4c0f48d33fb76c4d
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 18:15:40 2019 +0100

    smbd: Use share_mode_data->num_share_modes as a boolean
    
    This is a micro-commit showing that we don't actually need
    share_mode_data->num_share_modes as a number *counting* the share mode
    entries in share_entries.tdb anymore. Instead, we are only using it as
    an indication for share_mode_lock_destructor() to see whether share
    entries are around or not, i.e. whether it's worth keeping or deleting
    the record in locking.tdb.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 42ce74994e98dda95c32d3fcbd66d825f6d84519
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 17 14:23:16 2019 +0100

    smbd: Avoid a direct access to share_mode_data->num_share_modes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 15977f5df85980ff0adbb372e4a4f0d51dde39dc
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 17 14:20:48 2019 +0100

    smbd: Introduce share_mode_have_entries()
    
    This hides a use of share_mode_data->num_share_modes in
    share_mode_lock.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0df06f51ffbc200b0525e175e7ac58795fd93bab
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 14:41:57 2019 +0100

    smbd: Avoid a reference to share_mode_data->num_share_modes
    
    share_mode_data->num_share_modes will go away soon, count the values
    directly while walking the array.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5a2fa45741db6d157705f81a8830907e34f07120
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 10:39:12 2019 +0100

    smbd: Avoid a reference to share_mode_data->num_share_modes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 21eff9d18d23ddc232a566eca51a6f32e30f0c11
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 10:36:21 2019 +0100

    smbd: Pass num_share_modes to share_mode_entry_do() callback
    
    mark_share_mode_disconnected_fn() will need this, the information is
    easily available and should not hurt the other callers.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3e5f1be8eace95cffa9d7e4cfd55eedca9ce2ceb
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 15:46:20 2019 +0100

    net: Use share_mode_count_entries()
    
    Avoid a reference to share_mode_data->num_share_modes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 28d9c418605356db65e90b1386d890308f3ab41f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 15:45:22 2019 +0100

    smbd: Add share_mode_count_entries()
    
    In order to not write the share mode on every open/close, we need to get rid of
    share_mode_data->num_share_modes. "net tdb" needs this information precisely
    though, and it's pretty cheap to calculate.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 54293f92cd83efc3a5a78fc29a85643921da9d32
Author: David Disseldorp <ddiss at samba.org>
Date:   Thu Dec 12 22:14:50 2019 +0100

    vfs_ceph_snapshots: fix root relative path handling
    
    For file paths relative to root, ceph_snap_get_parent_path() may return
    an empty parent dir string, in which case the CephFS snashot path should
    be ".snap".
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14216
    
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fca2d3e0d1fa5af59e7b729f7c1d126f7b81e149
Author: Anoop C S <anoopcs at redhat.com>
Date:   Tue Nov 12 19:58:43 2019 +0530

    s3: VFS: glusterfs: Reset nlinks for symlink entries during readdir
    
    On receiving an already initialized stat_ex buffer for readdir() call we
    invoke readdirplus() GlusterFS API, an optimized variant of readdir(),
    which then returns stat information along with dir entry result. But for
    symlink entries we don't know if link or target info is needed. In that
    case it is better to leave this decision back to caller by resetting
    nlinks value inside stat information to make it invalid.
    
    This was also preventing us from displaying msdfs link as directories
    inside the share.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14182
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Günther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Dec 17 21:53:07 UTC 2019 on sn-devel-184

commit 2241ce8e86f35f9bcfd4567aeb8e8a00cb53f7d7
Author: Simo Sorce <idra at samba.org>
Date:   Mon Dec 16 16:23:41 2019 -0500

    mit-kdb: Fix license on header file
    
    Signed-off-by: Simo Sorce <idra at samba.org>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Dec 17 09:24:56 UTC 2019 on sn-devel-184

commit 5d34c8874d6732ffb95458b79b742664744ef605
Author: Günther Deschner <gd at samba.org>
Date:   Fri Aug 26 15:39:56 2016 +0200

    s3-rpc_server: always print the full PDU.
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 97ad50544aaecd07b4a8f39cd329ed484aa38d6e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 14:40:03 2019 +0100

    smbd: Use explicit share_mode_wakeup_waiters()
    
    We don't need to unparse the locking.tdb record, we just need to wake
    up waiters when removing an oplock
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Dec 16 20:27:59 UTC 2019 on sn-devel-184

commit 1c188c3716a76a290e9e7f529ead782bea936690
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 14:40:03 2019 +0100

    smbd: Use explicit share_mode_wakeup_waiters()
    
    We don't need to unparse the locking.tdb record, we just need to wake
    up waiters when downgrading a lease
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6abcc83366f5f3203e9454b444c7d0ada7fed41e
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 18:55:39 2019 +0100

    smbd: Explicitly state when modifying share_mode_data
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fe7f241225db97d02a060118a342c824ab51e471
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 16:31:35 2019 +0100

    torture4: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 810fd90a6fb3cd95f0025321d080aad04afa994d
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 16:06:43 2019 +0100

    smbd: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f42e089a6efa36adc0d835cb51a1a612b40fa1c9
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 13 16:05:05 2019 +0100

    smbd: Avoid casts in open_directory()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit af2d54bfce8e389473cdb546155dc58d547011f9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Dec 13 11:48:05 2019 -0800

    s3: smbd: msdfs: Factor out the code to create a msdfs:referral,list into a separate function.
    
    This will allow it to be called from other places once the get/set_msdfs
    calls are moved into being first class VFS functions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Mon Dec 16 15:32:08 UTC 2019 on sn-devel-184

commit cc1ec0a9f135ec32c05ae04d0b3bd47fdef5d47d
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Dec 13 09:52:31 2019 -0800

    s3: smbd: cleanup. Change 'int referral_count' -> 'size_t referral_count' in struct junction_map.
    
    This is a non-negative count. Fix remaing code to not mix int and size_t.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2048ff3adc4dbff659dfb5d747f0cb93baad06ee
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Dec 13 09:39:55 2019 -0800

    s3: smbd: msdfs: Cleanup, don't mix int and size_t types for a count variable.
    
    Add integer wrap check.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 48ed60d7fd0b567c2450020b8ccaa2c6ff8913e3
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 12 10:46:21 2019 +0100

    lib/replace: work around an API conflict between ncurses and XFS xattr API
    
    Compile error:
    
      [4530/4693] Compiling source3/utils/regedit_list.c
      In file included from ../../source3/utils/regedit_list.h:24,
                       from ../../source3/utils/regedit_list.c:20:
      /usr/include/curses.h:611:28: error: conflicting types for ‘attr_get’
        611 | extern NCURSES_EXPORT(int) attr_get (attr_t *, NCURSES_PAIRS_T *, void *); /* generated */
            |                            ^~~~~~~~
      compilation terminated due to -Wfatal-errors.
    
    Both ncurses and XFS xattr API provide a get_attr() function. As a workaround
    avoid including <sys|attr/attributes.h> if <attr|sys/xattr.h> is present.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Dec 12 20:22:51 UTC 2019 on sn-devel-184

commit 82aff583b7f7e018ad4a1db92dc635df8e5ebe7b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 12:45:42 2019 +1300

    libndr: Return enum ndr_err_code from ndr_{pull,push}_steal_switch_value()
    
    This breaks the ABI so we merge this into the unreleased libndr-1.0.0.
    
    The advantage of the new functions is there (except for print, which
    is unchanged) is an error raised when the token is not found, so
    we can be confident in the changes to the token behaviour.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Dec 12 03:56:23 UTC 2019 on sn-devel-184

commit d30c377d8c4e8a83b2722b771aa72d219eb69b46
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 27 15:20:32 2019 +1300

    librpc/ndr: Remove ndr_{push,pull}_get_switch_value()
    
    By removing this we know we do not need to worry about this list
    growing without bounds.  We merge this into the recently created but
    not yet released ABI 1.0.0
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a44717394df9dc14a87eb2b9b8d23e2532e6f4c9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 27 16:36:04 2019 +1300

    librpc: Remove last callers of ndr_push_get_switch_value()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit b880bda589aa136bb954a757f25f8763b74aefd4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 26 18:35:36 2019 +1300

    librpc: Remove last callers of ndr_pull_get_switch_value()
    
    By removing this we know we do not need to worry about this list
    growing without bounds.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 92a7c5a7262cb78fb6307e9168a540154cbe2f71
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 19 17:38:50 2019 +1300

    librpc: Do not follow a NULL pointer when calculating the size of a union
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 456cdb7fa35f2b5778c7a5c852acc6180cbe03b4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 15 20:04:41 2019 +1300

    pidl: Mismatch between set and get of relative base pointers
    
    The set was within the switch, the get was before the switch.
    
    The difference is shown when there is an empty default element.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 362d70ff2fb6fb6265fce03da6b09dd4756dc604
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 19 16:58:57 2019 +1300

    librpc: Do not follow a NULL pointer when calculating the size of a structure
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 5eb560d25e9104dc02477a6bf819d0c37e8afb86
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 15 20:04:41 2019 +1300

    pidl: Mismatch between set and get of relative base pointers
    
    The set was within the switch, the get was before the switch.
    
    The difference is shown when there is an empty default element.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e08461b2845183224b9775b54be4acaaba705ecd
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 12:02:03 2019 +1300

    pidl: Add and use ndr_print_steal_switch_value(), removing ndr_print_get_switch_value()
    
    This avoids really long token lists for switch values
    that will not be needed past this point.
    
    The function name is changed to clarify what exactly is being
    done here, and the old function is removed to ensure it is
    not being used anywhere else.
    
    Merge the removal of ndr_print_get_switch_value into
    just-tagged librpc/ABI/ndr-1.0.0.sigs as this
    has not been put into any release yet.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit e1a15710a4c1c96c9d9fdf932357749cc5ed4d7a
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 27 16:01:02 2019 +1300

    librpc/ndr: Add ndr_push_steal_switch_value()
    
    This will allow generated code to instead push and pop union values onto the
    switch_list stack, which is more memory efficient than creating a single large
    list to be scannned and eventually discarded.
    
    Merge into unreleased ABI 1.0.0
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 603f23b19c90d6a1be4ac50e5984e6f9c8a63ba2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 15 16:59:12 2019 +1300

    pidl: Generate and consume the switch level token for both NDR_SCALARS and NDR_BUFFERS in ndr_pull()
    
    This means what was previously a list becomes a single variable that
    could be passed as a function paraemter, but this is avoided for now
    because it would change the ABI and be more intrusive.
    
    Before this, a client could cause a NDR token containing the swith level
    to be allocated for each and every element in the array that they
    promised they were sending (without having to actually send them).
    
    Found by Michael Hanselmann using Honggfuzz and an fuzzer for Samba's
    NDR layer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f7bcf227f7bac1817ecabbe3dccaebdd9a81a2f9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 15:30:55 2019 +1300

    librpc: Set the switch_value before NDR_BUFFERS to prepare for new libndr behaviour
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit a22a22e4a8a2efad86833d21958bc6abf57f74e7
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sun Nov 17 19:32:50 2019 +1300

    negoex: Set the switch_value before NDR_BUFFERS to prepare for new libndr behaviour
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit ae43093b79ad59a090e72c22249a65b54a2a6a97
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 16 09:37:30 2019 +1300

    s4-libcli/rap: Set the switch_value before NDR_BUFFERS to prepare for new libndr behaviour
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 7a0ed44b0e65e742a778915d493e17f04c43b2ef
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 16 07:59:58 2019 +1300

    ndr: Restrict size of ndr_token lists to avoid memory abuse by malicious clients
    
    This is designed to stop a very large number of tokens from being stored for
    arrays of structures containing relative pointers in particular.
    
    This was one part of the minimum patch for CVE-2019-14908 before
    being downgraded as not a security-release worthy issue.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 4501663f6e523a988f4edd287a1374cab3c9a127
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 10:38:01 2019 +1300

    libndr: Do not overwrite token list with NULL on allocation failure
    
    This was one part of the minimum patch for CVE-2019-14908 before
    being downgraded as not a security-release worthy issue.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit bcffdc9a895c8aa572819ddd4fca451038990402
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 16:56:44 2019 +1300

    selftest: Add test for ndr_size_struct() faulting on a NULL pointer
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit f56fa3bb6a0e2275114a6f4dd27640af1e15018b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 16:49:13 2019 +1300

    selftest: Add test for ndr_size_union() faulting on a NULL pointer
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 6ef50145494125c8e67c034ddb1816a567524984
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 16:02:31 2019 +1300

    selftest: Add example xattr_NTACL packets to demonstrate switch/union behaviour
    
    This is a good example with both buffers and scalars in the union.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit cf83eec565f2879c06874cdd390ab3a043c132f8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 14:46:32 2019 +1300

    selftest: Add test for structure with NDR_BUFFERS only in a union
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13876
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>

commit 3f69c6b1328cda318f78620d19616411705b7034
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Mar 7 11:35:07 2019 +0100

    selftest: Do not force the endpoint for fsrvp tests
    
    The test suite will bind to the srvsvc interface, let it find the
    correct endpoint through the endpoint mapper.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Dec 12 02:00:19 UTC 2019 on sn-devel-184

commit 4a608b281cf945b0550d1bf81971f690a5e7ed8a
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Nov 4 18:39:10 2019 +0100

    s4:torture/rpc: Fix torture comment in mdssvc.c
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e24ce0023fa00a33d22f5f475e9280a8cad612c3
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Fri Sep 6 15:16:01 2019 +0200

    pidl:NDR/Server: Allow to define endpoint server shutdown functions
    
    The next commits will register legacy api_struct when the endpoint server
    is initialized. This commit adds a shutdown function which will be used
    to unregister the legacy api_struct.
    
    The shutdown function will be also used to replace the rpc_srv_callbacks
    struct shutdown member used, for example, by the spoolss service to
    cleanup before exiting.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 79af978c815e6ad94797742c8755f4fe8142160e
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 1 16:59:07 2019 +0200

    librpc:core: Add a function to reinitialize the dcesrv_context
    
    Clears all registered endpoints and interfaces, association groups and
    broken connections.
    
    To be used by S3 forked daemons.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 90eb485cf9d8eaecfab31044e52e8f41b3a51452
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Fri Sep 6 14:38:29 2019 +0200

    librpc:core: Add public functions to initialize endpoint servers
    
    The dcesrv_init_registered_ep_servers() will be used by the S3 server to
    initialize all registered endpoint servers (for embedded services), and
    the dcesrv_init_ep_server() function will be used by the external
    daemons to initialize the required ones.
    
    As serveral S3 services may require to initialize another one before
    itself (svcctl and eventlog for example require winreg) a boolean flag is
    added to track the initialization status.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 39dfc5c82b2345f2eee7d14f6f2cc3ee8b2aef3d
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 5 18:54:02 2019 +0100

    librpc:core: Split dcesrv context init and endpoint servers init
    
    The S4 server will initialize the endpoint servers specified in smb.conf,
    but the S3 server need to initialize all registered endpoint servers (the
    embedded ones).
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fee5c6a4247aeac71318186bbff7708d25de5912
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Dec 2 11:20:31 2019 +1300

    librpc/idl/dnsserver.idl: Ensure DnsProperty id matches what is pulled from the stored buffer
    
    There are two concerns here, assuming the attacker can place arbitary values
    in a dnsProperty attribute over LDAP (eg is a DNS administrator).
    
    This comes from the fact that id is used as the switch value at the C layer
    but at the NDR layer the wDataLength value is considered first.
    
    One concern is that a pull/push round-trip could include server memory:
    
     The previous switch_is() behaviour could store the server memory back
     into the attribute.
    
     However this pattern of pull/push only happens in ndrdump and fuzzing tools, as
     dnsserver_db_do_reset_dword() operates only on the uint32/bitmap union
     arms, and fully initialises those.
    
    The other is that a pull of the attacker-supplied value could
    cause the server to expose memory.
    
     This would be over the network via DNS or the RPC dnsserver protocols.
     However at all times the ndr_pull_struct_blob is passed zeroed memory.
    
    The final concern (which fuzz_ndr_X found) is that in the ndr_size_dnsPropertyData()
    the union descriminent is only id.
    
     This has no impact as only zeroed memory is used so there will be a
     zero value in all scalars, including data->d_ns_servers.AddrArray.
    
     Therefore the server will not crash processing the attacker-supplied blob
    
    [MS-DNSP] 2.3.2.1 dnsProperty has no mention of this special behaviour.
    https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dnsp/445c7843-e4a1-4222-8c0f-630c230a4c80
    
    This was known as CVE-2019-14908 before being triaged back to a normal bug.
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X fuzzer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14206
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit ee4617ec5f4017e7ee3bbc29102054e7b64f3e3a
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Mon Dec 9 09:19:47 2019 +1300

    librpc dnsp test: Ensure length matches union selector
    
    Ensure that a dnsp_DnsProperty is rejected if the length data does not not
    correspond to the length indicated by the union id.  It was possible for
    the union to be referencing memory past the end of the structure.
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X fuzzer.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=14206
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 049f0c3870179aa4977f5d9c49e18566f166412e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 12 07:35:55 2019 +1300

    lib/krb5_wrap: Remove unused smb_krb5_get_allowed_weak_crypto()
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Wed Dec 11 22:18:47 UTC 2019 on sn-devel-184

commit 545711ffeaaa12689a4e9a14f23ba5a4afef2180
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 11 14:09:25 2019 +1300

    lib/fuzzing: Fix argument order to ldb_filter_from_tree in fuzz_ldb_parse_tree
    
    Found by the oss-fuzz CI tooling.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Dec 11 04:21:28 UTC 2019 on sn-devel-184

commit e6fc8e79aee289f79b5fba7b7c2974d476702b1e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 11 13:03:43 2019 +1300

    lib/fuzzing: Split up automatically build fuzzers into TYPE_{IN,OUT,STRUCT}
    
    The advise is that a fuzz target should be as small as possible
    so we split this up.  Splitting up by function would build too
    many fuzzers, but this should help a little.
    
    See for example:
    https://github.com/google/fuzzing/blob/master/docs/good-fuzz-target.md#large-apis
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit 6e5aefc2d3095f0fb6535e6ab3a4ec12b898794f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 11 12:48:24 2019 +1300

    lib/fuzzing: Ensure mem_ctx is freed each time fuzz_ldb_parse_tree is run
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit 0be0c044b6769da39b0feb8d7b655a2760413086
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 22:52:06 2019 +1300

    autobuild: extend autobuild with samba-fuzz job to build the fuzzers in AFL mode using oss-fuzz scripts
    
    This helps ensure the build_samba.sh file keeps working and the fuzzers build
    (because they are excluded from the main build).
    
    This is not in the default autobuild because it uses too much
    space on sn-devel (4GB).
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit d349d344f8872e25526fdb76a38523477baa4366
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Dec 10 10:59:49 2019 +1300

    autobuild.py: Avoid listing jobs twice
    
    We use the tasks table instead, to avoid the issue shown in the previous commit.
    
    Now we just have to keep .gitlab-ci.yml and the tasks table in sync.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit df38d511045311b9b7c68c94aad800c69088e331
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Dec 10 10:58:47 2019 +1300

    autobuild.py: Add missing samba-simpleserver job
    
    This was missed when the job was split out in f0e8dd1a08698884209873bb84002d7b34db016c.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit de02a553999903058dd69ea8aaff2e248a6ad55c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Dec 10 10:47:12 2019 +1300

    .gitlab-ci.yml: Align tasks with "pages" dependency to get comprehensive code coverage
    
    These two lists can get out of skew very easily.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit fbd97ee822337534006ffcd14e08c8068e178266
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 10:56:44 2019 +0100

    smbd: Fix a leases.tdb record leak
    
    If we set e->stale=true in the share_mode_forall_entries() callback,
    the share entry will be removed directly. Thus further down
    share_mode_forall_leases() won't find anything anymore. Only find
    possibly still connected entries in the first walk, and then remove
    the share_entries.tdb record straight away after the leases and
    brlocks have been removed.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Dec 10 21:57:05 UTC 2019 on sn-devel-184

commit 7535359602e8b33e38ef1e0e38dc070773a39ea8
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 11:48:07 2019 +0100

    torture: Run durable_v2_reconnect_delay_msec with leases
    
    This will show a leases.tdb record leak. If you SIGSTOP the smbtorture
    process while it's in the 10-second wait, you will find locking.tdb
    and share_entries.tdb empty after the scavenger has cleaned up. But
    there will be an entry in leases.tdb left.
    
    I have no clue how to test this properly, or how to have a reasonably
    cheap assert in smbd during normal operations. The problem is that
    this leak can't really be distinguished from a "normal" leak that a
    crashed smbd would leave behind. Possibly we need a background job
    walking leases.tdb to clean this up properly.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 79b2ee8dc2382354750601ee3d57912442c09817
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 10 11:31:22 2019 +0100

    torture4: Use generate_random_u64() instead of random()
    
    random() returns an int, which is not necessarily a uint64
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 20b9cae63d5a5881cc6100a2533fab683cc307aa
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Dec 10 18:06:29 2019 +0100

    lib:crypto: Build intel aes-ni only if GnuTLS doesn't provide AES CMAC
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Dec 10 20:30:57 UTC 2019 on sn-devel-184

commit 6713617724bfe4cba633f0e61052a703c4ca9f3e
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Dec 10 18:03:57 2019 +0100

    lib:crypto: Only build AES code if we need AES CMAC
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 337c51c9f503adef58c9b875bfb4f522cfb7d9ae
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Dec 10 18:01:43 2019 +0100

    lib:crypto: Remove our implementation of AES GCM
    
    We require GnuTLS >= 3.4.7 which provides AES GCM.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c3250ff7ab66fb45c9b5a66c7e3a9453fb22777b
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Dec 10 17:52:36 2019 +0100

    lib:crypto: Remove our implementation of AES CCM
    
    We require GnuTLS >= 3.4.7 which provides AES CCM.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit bc0c876a9ebbec1a31856a9e7147a481c69ba434
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 5 11:37:05 2019 +1300

    pidl:NDR/Parser: only include structs in ndr_interface_public_struct
    
    We only have ndrdump and the fuzzers set up for structures, not BITMAPS,
    ENUMS etc.
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Tue Dec 10 17:45:46 UTC 2019 on sn-devel-184

commit 238d08b07d0178940c28839518c9f1afbc605378
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Dec 6 11:00:57 2019 +1300

    selftest: Confirm that ndrdump struct mode is not available for enums
    
    These are not passed by pointer so the structure dump system does not work
    for these.  It is best to dump the containing structure instead.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 73f436260620a97e307110ec45311e9e5dd321ce
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 11:12:48 2019 +0100

    CVE-2019-14870: mit-kdc: enforce delegation_not_allowed flag
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(master): Tue Dec 10 10:44:01 UTC 2019 on sn-devel-184

commit 84de46f5347288a3683ba083f529137efa8028e9
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Oct 28 02:54:09 2019 +0200

    CVE-2019-14870: heimdal: enforce delegation_not_allowed in S4U2Self
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>

commit df72956adee55fbe60d49bd9d58d9df53d4f2198
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Oct 30 15:59:16 2019 +0100

    CVE-2019-14870: heimdal: add S4U test for delegation_not_allowed
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>

commit aa17d5fcaf7fe0f628856cda902cbd8be7e6ecb4
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sun Oct 27 14:02:00 2019 +0200

    samba-tool: add user-sensitive command to set not-delegated flag
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>

commit aaf037dfb3454cea048489b23ad96c415096dddf
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Oct 30 11:50:57 2019 +1300

    CVE-2019-14861: Test to demonstrate the bug
    
    This test does not fail every time, but when it does it casues a segfault which
    takes out the rpc_server master process, as this hosts the dnsserver pipe.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit defb23732515e3c638d0081f5e4043fbb35d303c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 29 14:15:36 2019 +1300

    CVE-2019-14861: s4-rpc/dnsserver: Avoid crash in ldb_qsort() via dcesrv_DnssrvEnumRecords)
    
    dns_name_compare() had logic to put @ and the top record in the tree being
    enumerated first, but if a domain had both then this would break the
    older qsort() implementation in ldb_qsort() and cause a read of memory
    before the base pointer.
    
    By removing this special case (not required as the base pointer
    is already seperatly located, no matter were it is in the
    returned records) the crash is avoided.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 4333e41c2243781ae788db8ee7fa6897b0a7e334
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Oct 21 12:12:10 2019 +1300

    CVE-2019-14861: s4-rpc_server: Remove special case for @ in dns_build_tree()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit a25a2e4513e48d0408b1f5e78ada0b3569d3426d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 29 17:25:28 2019 +1300

    CVE-2019-14861: s4-rpc/dnsserver: Confirm sort behaviour in dcesrv_DnssrvEnumRecords
    
    The sort behaviour for child records is not correct in Samba so
    we add a flapping entry.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14138
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 8b06cabc7d735f8a780b832ddb7d5ab2989e661f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Dec 7 17:35:26 2019 +1300

    bootstrap: Add chrpath as a required package
    
    This is used to test build.sh, part of the oss-fuzz integration, and so also that we
    correctly build our fuzzers.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Dec 10 09:15:43 UTC 2019 on sn-devel-184

commit 96184c10b8d048a67e57b7b838a1da2a1588455c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Dec 7 13:37:10 2019 +1300

    build: Skip build of python bindings when in fuzzing mode
    
    This will just save a bit of time and space.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 4c8388fb19865c7e0aa6facf43b6cbd1906a6b2c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sun Dec 8 07:45:58 2019 +1300

    lib/fuzzing Truncate the original files after RUNPATH manipulation in build.sh
    
    This saves space on the rackspace runners in particular.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 5e5d18c5b1e710a747ede56efe10792957f11552
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sun Dec 8 07:44:45 2019 +1300

    lib/fuzzing Add comments to explain RUNPATH manipulation in build.sh
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 5bb9ecdf15febb492bf9b65f5811ca0b59fefec8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Dec 7 13:01:58 2019 +1300

    lib/fuzzing: Support an oss-fuzz build with either address or undefined behaviour sanitizers
    
    Add handler for $SANITIZER in build.sh
    
    This allows a build with the undefined behaviour sanitizer.
    
    Otherwise we fail the oss-fuzz CI because the UBSan build links with ASan.
    
    Once this in in then https://github.com/google/oss-fuzz/pull/3094
    can be merged to oss-fuzz.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit f79caf3b6bf4b3c4942874af70cfa8c912959faa
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sun Dec 8 07:22:33 2019 +1300

    lib/fuzzing: Remove oss-fuzz build.sh stub from the Samba repo
    
    We need to ship the stub build.sh in the oss-fuzz repo, not ours.
    This is because otherwise the travis CI checks skip the build
    (it thinks we are not set up yet, or have been disabled).
    
    See https://github.com/google/oss-fuzz/pull/3094 for the PR
    creating a similar file there.  This is very similar to how
    janus-gateway operates, so this is an accepted pattern.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 8382fa6408ef5efc45260e332579a6d9ee648d87
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Dec 7 12:06:37 2019 +1300

    oss-fuzz: Align build.sh sh parameters with pattern from the oss-fuzz project
    
    We should run build_samba.sh with -eux to ensure we exit on failure,
    refuse to use an unset varible and print the commands we are running.
    
    (The suggested build.sh on the oss-fuzz side uses -eu).
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 47c7f549955b8c01d5fbe09a0f9ccc3503b94c63
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Dec 6 11:10:05 2019 +1300

    fuzz/decode_ndr_X_crash: -f to filter crashes by regex
    
    If you go:
    
    $ ./lib/fuzzing/decode_ndr_X_crash -H HONGGFUZZ_REPORT.txt -f 'SIG[^V]' > ./crash.sh
    
    you will get all the crashes and not the timeouts (which have SIGVTALARM).
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1d98ced841f83d7305a570297908fd1270de42e0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 21:23:06 2019 +1300

    lib/fuzzing: Add mode for the AFL fuzzer
    
    This is helpful for ensuring the fuzzers still compile in autobuild as no
    library support is required.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit f4ff9a079414953b17f49857ecfca6c0e479c32f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 22:07:26 2019 +1300

    lib/fuzzing: Also confirm we can make a string filter from the parsed tree in fuzz_ldb_parse_tree
    
    This also avoids tree being an unused variable.
    
    This is similar to doing an ndr_push() in ndr_fuzz_X, it
    catches some of the cases where the parse is successful but
    the application code could misinterpret the structure.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 000d86f537866a3c83f06d7b128532119df45dd9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Dec 4 21:39:49 2019 +1300

    lib/fuzzing: Tell the compiler we know we are ignoring errors in fuzz_reg_parse
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit a9a8bcf731659f0898f70759e78a9909f018ae48
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 30 20:23:18 2019 +1300

    lib/fuzzer: Allow building a fuzz binary for just one interface
    
    This helps direct the fuzzer at a particular function that we are concerned about.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit c16e4dcad9cb8dc16ceacb94b9ba6ce094f4e507
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 30 20:22:26 2019 +1300

    lib/fuzzer: Remove rudundent install=False flag from fuzz_ndr_X build rule
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 6f7a9e87887e50160df6a06b09d8454eef9208a1
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 29 12:07:34 2019 +1300

    lib/fuzzing: Link only the required NDR_ subsystems into ndr_fuzz_X binaries
    
    This reduces the binary size and shows that we are linked against the correct
    ndr_table_ global variable.  This might help the fuzzing engine know there
    is not much more of the binary to find if unreachable code is not included.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 3ca76f59070020ea188bea88bece38d8c9036f59
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 29 12:06:01 2019 +1300

    librpc: Fill in full deps for NDR_* subsystems
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit c35fe03a63cae908d879328fe4238ed1df1b158d
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Dec 4 11:57:02 2019 +1300

    fuzzing/decode_ndr_X: read crashes from a HONGGFUZZ report
    
    In theory, you should be able to run honggfuzz and go
    
    $ lib/fuzzing/decode_ndr_X_crash -H HONGGFUZZ-REPORT.txt > crash-crash-crash.sh
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit afe866086c00d433e270a94c782f551e5b00263b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Dec 4 11:35:40 2019 +1300

    lib/fuzzing/decode_ndr_X: print less by default, avoid pipe
    
    ndrdump can now take base64 input directly.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c0043e2352691e5ee3885558e5c1894dda342a70
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Nov 5 14:26:56 2019 +1300

    fuzzing: Add script decode_ndr_X_crash to decode crash results
    
    This interprets a file that crashes an fuzz_ndr_X binary
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e737988641905180d7d9a4e5cc88a85637deaab6
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Nov 6 17:27:08 2019 +1300

    dcerpc: developer option to save ndr_fuzz_X seeds
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Pair-programmed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7b265830ad6796dbbe721f7abfd62a19c2185b65
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Oct 31 16:28:28 2019 +1300

    lib/fuzzing: add fuzz_ndr_X
    
    This NDR fuzzer links with each "interface" in the IDL files to
    create avsingle binary.  This tries to matches what the fuzzing
    engines desire.
    
    It started as a copy of ndrdump but very little of that remains
    in place.
    
    The fancy build rules try to avoid needing a lof of boilerplate
    in the wscript_build files and ensure new fuzzers are generated
    and run when new IDL is added automatically.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Pair-programmed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit ef5d79e24ba8aec226419e594de0cf91c24d7fc4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:44:52 2019 +1300

    pidl/tests/samba-ndr.pl: remove duplicate import
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Dec 10 04:16:31 UTC 2019 on sn-devel-184

commit fbe402edf55cc4dda8820645c7c4e20862969803
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:43:52 2019 +1300

    pidl s4::Python: silence warnings
    
    - do not redeclare variables in the same scope.
    - use $1 instead of \1, which perl just prefers.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 51a11afecf590a26b784c1d2e484829330efa44f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:43:02 2019 +1300

    pidl Parse::Pidl::NDR: silence two warnings about undefined strings
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3c90c9de6f45af60d9db5f40ec0dad6318e53e3d
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:42:22 2019 +1300

    pidl Parse::Pidl::NDR: add HRESULT alignment
    
    this is a guess
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 33255102acd755cacceafd2a082722ed0fbc695f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 00:41:42 2019 +1300

    pidl Parse::Pidl::NDR: warn of unknown scalar alignments
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4de002a0f77dba8345ca6c395a855a5c053a8dd4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 23:05:56 2019 +1300

    pidl s4::NDR::Parser: silence a warning
    
    At level 0 there is no previous level so $pl is undefined thus so is ->{TYPE}
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit aefce8e7c0d82241ab6ecfab7d714338b331bc52
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 22:52:23 2019 +1300

    pidl s4::NDR::Parser: correct has_fast_array logic
    
    Here we fix two bugs that cancelled each other out completely, so this
    patch leaves us with exactly the same functionally as before.
    
    Bug 1: In perl, return is *syntactically* a function.
    
    That means 'return X or Y' is read as 'return(X) or Y', as in the
    'open(X) or die "..."' construct -- Y is only evaluated if return
    returns false. But return never returns, so Y is dead code. If in
    doubt, try these:
    
    perl -e "sub x {return 0 or die;} x"
    perl -e "sub x {return (0 or die);} x"
    
    What we *meant* here is 'return (X or Y)', BUT it turns out we were
    confused -- the Y case was bogus.
    
    Bug 2: string arrays never had "fast array logic" in the first place.
    
    The fast array logic is for arrays of bytes, and can be fast (i.e.
    memcpy) because there is no endianness to worry about. A string array
    is an array of pointers not bytes.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2765b5c1a27232b990537415718e98449617641b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 23:37:08 2019 +1300

    pidl s4::NDR::Parser: read hex numbers as numbers for ranges
    
    Hex numbers in IDL are not parsed as numbers, resulting in warnings
    like
    
    Argument 0x2000 isn't numeric in numeric lt (<) at /home/douglas/src/samba/pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm line 981
    
    not to mention problematic code. We add a utility function to convert
    these numbers to numbers.
    
    A typical difference this makes is:
    
     --- old/default/librpc/gen_ndr/ndr_dcerpc.c     2019-11-30 23:40:32.915816967 +1300
     +++ new/default/librpc/gen_ndr/ndr_dcerpc.c     2019-11-30 17:00:09.055733660 +1300
     @@ -1893,7 +1893,7 @@
             if (ndr_flags & NDR_SCALARS) {
                     NDR_CHECK(ndr_pull_align(ndr, 4));
                     NDR_CHECK(ndr_pull_uint32(ndr, NDR_SCALARS, &r->ReceiveWindowSize));
     -               if (r->ReceiveWindowSize > 0x40000) {
     +               if (r->ReceiveWindowSize < 8192 || r->ReceiveWindowSize > 262144) {
                             return ndr_pull_error(ndr, NDR_ERR_RANGE, "value out of range");
                     }
                     NDR_CHECK(ndr_pull_trailer_align(ndr, 4));
    
    Where the minimum ("0x2000" == 8192) was read as a string, thus
    treated as zero.
    
    The treatment as zero was introduced in 142b2a61f8a77b3065ce4c78b459ab714d6d190a
    accidentially, which shows why warnings are important.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit efef4366f18515ec78cb025928c20fb7986cd98f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 22:34:54 2019 +1300

    pidl: use perl warnings
    
    Warnings are good. If we turn on warnings with 'use warnings', we will
    see bugs that have lain latent for years.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b6913830bf626c8d7059f4cda3a4fc1bb3081973
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 5 09:56:44 2019 +1300

    librpc/ndr: Do not follow a client-supplied NULL pointer in _print_drsuapi_DsAttributeValue_attid()
    
    This is not a security issue as it only happens when printing the structure
    during debugging, not normal production.
    
    Found by Michael Hanselmann using an NDR fuzzer and Hongfuzz.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit f786cdf5e84f70c9a0ca206c761d453d42e72251
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Dec 5 11:10:14 2019 +1300

    selftest: Add ndrdump tests for malformed drsuapi traffic
    
    Thanks to Douglas Bagnall for the samples, produced from seeds
    generated by Samba's make test traffic, fuzzed by ndr_fuzz_X
    and Hongfuzz.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 83ffe6752d589180eac96d7b8e7d1a54e3476bfd
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 13:48:52 2019 +0100

    pidl: Remove Parse/Yapp/Driver.pm
    
    This file is provided by Parse::Yapp and on install we overwrite the
    orignal file.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Dec 10 01:54:02 UTC 2019 on sn-devel-184

commit fe2577a40c19c99c29dd54c7c43e12f3d43493be
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Oct 21 20:03:04 2019 +0300

    smbdes: remove old unused DES builtin-crypto
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b5d8f1f78a04719c6a5d15aa92ae398be326fe56
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 15:13:19 2019 +0100

    sess_crypt_blob can only crypt blobs whose size divides by 8
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a75ca8d5d515aef1229acf5a30489ee5f5ced3e1
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 14:02:03 2019 +0100

    session: convert sess_crypt_blob to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dcc33103d5c0927bb3757974d4663df888dce95e
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 16:02:16 2019 +0100

    smbdes: convert des_crypt112_16 to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 254739137bdaebca31163f1683bfd7111dfefe67
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 15:41:02 2019 +0100

    smbdes: convert des_crypt112 to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dce944e8a1119034f184336f6b71a28080152a0a
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 15:28:39 2019 +0100

    smbdes: convert E_old_pw_hash to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c57f429574243adbcd43dca4f35d125df8d69ba0
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Nov 8 17:49:48 2019 +0100

    smbdes: convert des_crypt128() to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a5548af018643f2e78c482e33ef0e6073db149e4
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Nov 8 15:40:01 2019 +0100

    smbdes: convert E_P24() and SMBOWFencrypt to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2eef12904f2c08257394a2ee869960f7c2e09112
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Nov 8 12:04:48 2019 +0100

    smbdes: remove D_P16() (not used)
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9fb6361a8b09fd575bab2f5572fa9e10bd538eed
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 7 16:16:26 2019 +0100

    smbdes: convert E_P16() to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit ecee1998034b84026ab604dbe4400d9e53dcafd4
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 7 18:40:03 2019 +0100

    smbdes: convert sam_rid_crypt() to use gnutls
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit bbcf568f317960229caa7486322858093f5d0d04
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 7 13:39:20 2019 +0100

    SMBsesskeygen_lm_sess_key: use gnutls and return NTSTATUS
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 38189f76d8b958fff8a6351f3fb21f6ed04b76da
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 7 12:53:52 2019 +0100

    netlogon_creds_des_encrypt/decrypt_LMKey: use gnutls and return NTSTATUS
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0f855f1ab955e3ecf47689c5e4578eb67ebe8f27
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sat Oct 19 23:48:19 2019 +0300

    smbdes: add des_crypt56_gnutls() using DES-CBC with zeroed IV
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2c470c8035be6d70ce3fc8d1e12be284566a7037
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 23:44:10 2019 +0100

    selftest: test sess_crypt_blob
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 6c5f153e4793c0613dd843b1566bd27632912a7c
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 20 00:14:31 2019 +0100

    selftest: test SMBsesskeygen_lm_sess_key
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a4ec427e54b52307ee2e22079449ff3e59279298
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 20:02:49 2019 +0100

    selftest: test des_crypt112_16
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 394debac6b2f0838cde5d850335e0cdff14b411d
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 19:49:09 2019 +0100

    selftest: test des_crypt112 and fix (unused) decryption
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e2f8f686d1e3fce91f10aadb9667854cf2a1219a
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 19:10:18 2019 +0100

    selftest: test des_crypt128
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 8f042ba532fc645f2389a0a9d3e83d27c070fde4
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 18:49:58 2019 +0100

    selftest: test E_old_pw_hash
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dfad082596a53a7c6225da427447922fd4b7f0e2
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 18:26:13 2019 +0100

    selftest: test E_P24 and SMBOWFencrypt
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0923f94bdc21a80cbf40aaa65c4928c13c298d82
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 16:08:49 2019 +0100

    selftest: test sam_rid_crypt
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7044a41a30e43dda34eecb6df3da82ed5d568eec
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 19 09:46:18 2019 +0100

    selftest: test E_P16
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 07b4606f893fabd50c2685307d58e86f55defae5
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sat Nov 9 17:47:33 2019 +0100

    libcli/auth: test des_crypt56() and add test_gnutls to selftest
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 01f531ba6ba1306e99d2e4715dadae073eb0a8ec
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Dec 6 08:49:54 2019 +0100

    auth:tests: Only enable torture_gnutls_aes_128_cfb() on GnuTLS >= 3.6.11
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1c65f1fddba77e94edc5338af81c9a25e0d4e970
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Dec 6 08:12:34 2019 +0100

    auth:tests: Improve debug output of test_gnutls
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit adfdcc4791b9a5706c48789bfbb46f256ee10538
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 10:47:46 2019 +0100

    s3:lib: Move NULL check before messaging_dgm_out_rearm_idle_timer()
    
    We dereference out in messaging_dgm_out_rearm_idle_timer().
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 8753d5f4567e1bc39c25ea11d444bed6d0afea46
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 10:45:31 2019 +0100

    s3:smbd: Fix possible NULL deref in smbd_do_qfilepathinfo()
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cfa0526100575a7684879bb64f5e492c578bef87
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 10:35:55 2019 +0100

    s3:torture: Do not segfault if cli is NULL
    
    This can happen if we fail early and cli hasn't been initialized yet.
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 94c3c12df11dccdc34ef91f3065240f34a7244be
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 10:22:52 2019 +0100

    s3:rpc_server: Fix string compare for utmp entries
    
    The members of struct utmp are marked as nonstring. This means they
    might not be nil-terminated.
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c2e55821bc5db1a33ecd2f7550a75ebdbe7613f9
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Dec 9 09:58:42 2019 +0100

    s4:lib: Make sure we close fd's in error path
    
    Found by covscan.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit bb2296f68a36a3b85a5702062a5e488f9d6616dc
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Dec 9 13:49:47 2019 +0100

    build: Fix the build without system gssapi headers
    
    source4/heimdal/lib/gssapi/gssapi/gssapi_krb5.h and gssapi_spnego.h
    have an #include <gssapi.h> which they need to find via the -I paths
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Tue Dec 10 00:29:55 UTC 2019 on sn-devel-184

commit a5e3db5b5125c2f9921a51837ac8d696b8f4260e
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 9 18:56:59 2019 +0100

    lib: spelling fix
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Richard Sharpe <realrichardsharpe at gmail.com>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Mon Dec  9 19:23:10 UTC 2019 on sn-devel-184

commit f2a91426b791d1fc1b1655dfd4b8af5d50142d08
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 21:26:24 2019 +0100

    smbd: Give a better error message for non-existing share modes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Mon Dec  9 17:33:42 UTC 2019 on sn-devel-184

commit b6ffbc7d923cbe8c51a02e70d7ea8d2b8035b10e
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 15:45:56 2019 +0100

    net: Extend some debug information
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 37fa97b20e30c13cd59f2a58f61d09a3ff761ac4
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 13:23:06 2019 +0100

    smbd: Call reopen_logs() in the notifyd
    
    If you have per-process logfiles with %d, the notifyd will get its
    own logfile
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 27c69b58929ea45bd7108372468cf6c63b80c449
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 13:22:06 2019 +0100

    smbd: Call reopen_logs() in the smbd scavenger
    
    If you have per-process logfiles with %d, the scavenger will get its
    own logfile
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a34d75f6f7e56a76b4e3d5399742e5ac837bafdd
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 12:52:09 2019 +0100

    torture: Use sizeof() where appropriate
    
    One magic number less that needs to be verified manually
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f576c02bf9365ff538a46dadfe8ce1f1aa19664c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Dec 4 14:43:02 2019 +0100

    smbd: Use NULL instead of 0 for a pointer type
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e1230f6e45bb076af9f6efda04405b0874430681
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 6 16:48:19 2019 +0000

    lib: add a comment to nt_time_to_full_timespec()
    
    Add a hint explaining why and how -1 should be treated differently in the
    future. Also make use of the helper function make_omit_timespec().
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f0813cbf4f507462b5b9aa0e913483232e51bea5
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 6 16:45:04 2019 +0000

    lib: harden full_timespec_to_nt_time()
    
    This protects against overflows when tv_sec is less then
    TIME_FIXUP_CONSTANT_INT.
    
    It also correctly limits the range of returned values to be
    [NTTIME_MIN, NTTIME_MAX].
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 99d153fad120e0a9335ec474296f55a2e258561a
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 6 16:44:37 2019 +0000

    lib: add NTTIME_MAX, NTTIME_MIN, NTTIME_OMIT and NTTIME_FREEZE definitions
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 67f455c3d576a0bc3174fd10cf4f3244621b6b13
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Nov 29 08:28:28 2019 +0100

    s3:smbspool: Leave early if we print as root
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Mon Dec  9 14:18:11 UTC 2019 on sn-devel-184

commit c95d32f685d989c91e62a734229d2bd241291315
Author: Mikhail Novosyolov <m.novosyolov at rosalinux.ru>
Date:   Sun Nov 3 01:47:51 2019 +0300

    s3:smbspool: print a hint about smbspool_krb5_wrapper
    
    When I first met with the situation that Kerberos kredentials cache of root
    user was looked for instead of the one of the printing task creator,
    it took a lot of time to understand that smbspool_krb5_wrapper will resolve this.
    
    Signed-off-by: Mikhail Novosyolov <m.novosyolov at rosalinux.ru>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 58a90358e2e8ff70c65eb49a21d00c5ce775ba54
Author: Mikhail Novosyolov <m.novosyolov at rosalinux.ru>
Date:   Sun Nov 3 01:28:13 2019 +0300

    s3:smbspool_krb5_wrapper: ignore unknown values of AUTH_INFO_REQUIRED
    
    To make smbspool_krb5_wrapper usable as a default destination for symlink
    /usr/lib/cups/backend/smb in Linux ditros, it has to be well-prepared
    for any possible values of AUTH_INFO_REQUIRED set by cupsd and correctly
    pass printing tasks to smbspool if it sees that Kerberos authentication
    is not needed.
    
    Discussed here: https://lists.samba.org/archive/samba-technical/2019-October/134470.html
    
    Signed-off-by: Mikhail Novosyolov <m.novosyolov at rosalinux.ru>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 6201b30421f616ec3f118321fd2998435792a4cc
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 28 09:38:08 2019 +0100

    s3:smbspool_krb5_wrapper: Map AUTH_INFO_REQUIRED=none to anonymous
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 1b42ccfc23eaa8f5b007928bc8bb65b944359f36
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 28 09:35:34 2019 +0100

    s3:smbspool: Map AUTH_INFO_REQUIRED=none to anonymous connection
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 8987d7eef4f2e1cb1ed29c3607bb6218f6cf668d
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Nov 8 14:32:44 2019 +0100

    s3:selfest: Do not print the env twice
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Dec  9 11:57:52 UTC 2019 on sn-devel-184

commit b05be655a9218add833d41a1765166de92431897
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 6 14:54:45 2019 +0000

    s3:tests: Remove the -I SERVER_IP so that Kerberos auth works
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit 241f3709de5bc8db39ec47976428e0284b79fb16
Author: Richard Sharpe <realrichardsharpe at gmail.com>
Date:   Fri Dec 6 00:07:11 2019 -0500

    docs-xml/Samba-Developers-Guide/vfs.xml: Fix incorrect VFS func names.
    
    Use SMB_VFS_P{READ,WRITE} since the others have been retired.
    
    Also, fix up the definitions.
    
    Signed-off-by: Richard Sharpe <realrichardsharpe at gmail.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sun Dec  8 21:50:52 UTC 2019 on sn-devel-184

commit 5b8b9cd1c4d0065d6987658fdd8e9ec0a7c37a6b
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Dec 6 10:27:22 2019 +0000

    s4:smbtorture: also test for date >> UINT32_MAX in timestamps test
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9c81aa9dabc3dcb96fef169521bc7cb6e601a2e9
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 21:27:09 2019 +0100

    smbd: Fix a share_entries.tdb record leak
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8435128582adf81a18e9d929970074d4f2326d20
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 21:33:28 2019 +0100

    smbd: Test cleanup of disconnected durable handle records
    
    Right now this panics the scavenger daemon, preventing it from doing
    its work. The reopen we expect to fail with
    NT_STATUS_OBJECT_NAME_NOT_FOUND thus succeeds. I know that we should
    more precisely detect the scavenger crash and with Jeremy's pattern in
    46899ecf836 this would be possible. However, this is C code right now,
    and scanning the logfile for the panic is more I have time for right
    now. The test successfully indicates failure, as the next commit will
    show.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f3802023feb9e5dfa82d2174437b7576470f575b
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 15:34:25 2019 +0100

    selftest: Make durable_v2_delay more specific
    
    It will grow another subtest soon
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0bc3e7499b9a8a9d360f6c9454210f3cad334f90
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Dec 3 12:44:18 2019 +0100

    smbd: Panic if there's a leak in share_entries.tdb
    
    Hopefully dbwrap_tdb's dbwrap_exists is cheap enough for this to not
    impact performance too much. I could not measure any difference in an
    open/close benchmark, but at some point things might pile up and we
    might have to make this a #ifdef DEVELOPER
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 415fb7d2df4fdefd8aa78edde29abf64a008341b
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:30:05 2019 +0100

    build: Trim the deps of 'smbconf'
    
    This does not pull in gensec anymore
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4ff3e8ee8e1ec0d21db9d103dd6fb04c24c3eaaa
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:49:55 2019 +0100

    build: util_cmdline depends on cli_credentials
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cf9a029758459399a9ad93f6bd1e393cee644fdc
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:48:20 2019 +0100

    build: secrets3 need E_md4hash and kerberos functions
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 61b86d30d0218aab274601dd8d7d5c1ff6b5cf4f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:25:21 2019 +0100

    smbd: Make lp_use_sendfile() static to reply.c
    
    This is the only place where it's used. Also, via
    smb_signing_is_active it pulls in the dependency on
    'cli_smb_common' (which pulls in all of gensec) into the 'smbconf'
    library. Without this, 'smbconf' is happy with just 'samba-hostconfig'
    instead of 'cli_smb_common'
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9e640226621e11c2bd44450c3c284d9f72bfa714
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:20:36 2019 +0100

    build: Explicitly depend on samba-modules where needed
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cec30b2e063a4965fee2d4d9e8a50979a4f7647d
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:18:07 2019 +0100

    build: gencache.c in 'samba3core' needs crc32()
    
    This comes from zlib, make the dependency explicit
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2f2961a1170cd6fcd0f95e30bd243c051276c125
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:16:44 2019 +0100

    build: libcli/http does not need samba3core, only gensec
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 42035d1159718a39bd00a3289300c91ec62ecf50
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:40:00 2019 +0100

    build: messaging.c uses talloc_report_printf()
    
    This used to be talloc_report_str()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 63600b4f7841e0a81e40599947dbc62e07078aa2
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Dec 6 13:39:18 2019 +0100

    build: Multi-line a long list of deps
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e79e943824ad0960916585d09d0dd6061f7518f9
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 17:17:42 2019 +0100

    ldb:tests: Add missing null check for ldb_kv_private
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Dec  6 11:13:24 UTC 2019 on sn-devel-184

commit 9323b5c50042738b4afbea3dc0db0ddbc096f99c
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 17:15:01 2019 +0100

    ldb:tests: Add missing size check for tdb
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit e464e40c977cd6592240763c7dbb9c45ff16470f
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 17:14:31 2019 +0100

    ldb:tests: Use assert_in_range() in test_get_size()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit 9a1072ddb6b5ddf7916496068cf9c155eb7762c8
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Dec 5 17:02:39 2019 +0100

    ldb: Avoid a possible NULL pointer dereference
    
    Found by cppcheck.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>

commit fe2901e1074afbc488e92a6b930a9430f09063d9
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 3 18:46:25 2019 +0100

    WHATSNEW: document SMB_VFS_NTIMES() interface change
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Dec  6 01:45:21 UTC 2019 on sn-devel-184

commit 69691dd0cd5fac292bfb1c1dc28136ae253bbc76
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 2 16:30:50 2019 +0100

    smbd: fix handling of sentinel timestamp values
    
    This implements two core changes:
    
    * use NTTIME instead of struct timespec at the database layer
    
    * use struct timespec { .tv_nsec = SAMBA_UTIME_OMIT } as special sentinel
      value in smbd when processing timestamps
    
    Using NTTIME at the database layer is only done to avoid storing the special
    struct timespec sentinel values on disk. Instead, with NTTIME the sentinel value
    for an "unset" timestamp is just 0 on-disk.
    
    The NTTIME value of 0 gets translated by nt_time_to_full_timespec() to the
    struct timespec sentinel value { .tv_nsec = SAMBA_UTIME_OMIT }.
    
    The function is_omit_timespec() can be used to check this.
    
    Beside nt_time_to_full_timespec(), there are various other new time conversion
    functions with *full* in their name that can be used to safely convert between
    different types with the changed sentinel value.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6e58cfab98d958c8008c77b0d909a3384de28d7b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Dec 2 16:21:42 2019 +0100

    s3: add init_smb_file_time()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c6beb71813c015fddda02190e8093c335a2de411
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 1 09:01:20 2019 +0100

    smbclient: use cli_setpathinfo_ext() in utimes command
    
    This allows correct processing of sentinel date values.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1b9c31ef6ae8ffe1ee052b34d5013032cd37838a
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Dec 1 09:01:13 2019 +0100

    libsmb: add cli_setpathinfo_ext()
    
    This takes a struct timespec instead of just time_t as cli_setpathinfo_basic()
    does. This is needed to pass sentinel values -1 in the smbclient utime command.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2a82caf57ed10e8c838c157314248a124848c571
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 3 18:36:38 2019 +0100

    smbclient: use full_timespec_to_nt_time()
    
    Needed to support dates corresponding to (time_t)0 and (time_t)-1.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 02f18a3980cfa10ccb8448f0f125ae9164648997
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 29 16:17:08 2019 +0000

    s3:lib: use nt_time_to_full_timespec() in interpret_long_date()
    
    interpret_long_date() is now only used in the client. To enable correct
    processing of dates before the UNIX epoch, call nt_time_to_full_timespec().
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7d4be660bbd90c04657ffb3e46b585f164657c5a
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Dec 3 09:55:47 2019 +0100

    smbd: use pull_long_date_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e8c9559847503f20cf87f1dbe353ee7d9796ad64
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 15:26:07 2019 +0100

    s3:lib: add pull_long_date_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 572d4e3a56eef00e29f93482daa21647af7310d0
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Nov 30 21:29:07 2019 +0100

    smbd: use put_long_date_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b1a3445e3dbd9c08bc733377f7c3b95a9e8d2755
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 29 15:28:54 2019 +0000

    s3:lib: add put_long_date_full_timespec()
    
    put_long_date_full_timespec() will be used in the fileserver to marshall struct
    timespec timestamps that are sent to the client. By using
    full_timespec_to_nt_time() which supports tv_sec=0 and negative values, we can
    return timestamps to clients with a date before the UNIX epoch.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e3ad7e36a3fc8f5bd000481ac34c8fd3d2d747fd
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 28 15:46:27 2019 +0000

    s3:lib: let round_timespec() handle SAMBA_UTIME_OMIT
    
    This ensures callers are not required to do the check themselves and we don't
    clobber omit-timespecs in this function.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f2af647e7dd9fce537ce1c82e965486eee79aa27
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 29 08:43:21 2019 +0000

    lib: canonicalize pull_dos_date3()
    
    Returns 0xFFFFFFFF as (time_t)-1. This avoids misenterpreting 0xFFFFFFFF as a
    valid time_t value (0xFFFFFFFF = Sun 07 Feb 2106 06:28:15 AM GMT) on 64-bit
    platforms where time_t is 64-bit.
    
    Currently direct and indirect callers of pull_dos_date3() rely on the fact that
    the resulting time_t is checked with null_time() which also checks for
    0xFFFFFFFF as sentinel value amongst 0 and -1:
    
            return t == 0 ||
                    t == (time_t)0xFFFFFFFF ||
                    t == (time_t)-1;
    
    By returning -1 instead of 0xFFFFFFFF, callers can safely pass the result to
    unix_to_nt_time() which *doesn't* check for 0xFFFFFFFF, only -1.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7a69f642d7b138255a73ef42ab6dd9a5e50e5309
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Dec 4 15:05:19 2019 +0100

    lib: add time_t_to_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 928694af7e79edd0a48e43bb48af6fab9d32da89
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 27 15:31:50 2019 +0000

    lib: add timespec_string_buf()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2b938b4d339de095c670661600431bd6383a747b
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Nov 22 11:47:22 2019 +0100

    lib: use nt_time_to_unix_full() in nt_time_string()
    
    This enables printing time values before the UNIX epoch coming in over the wire
    in smbclient allinfo command.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2e687d0e4dba9a0f94e532726e1f3dceaa3ed840
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 15:07:51 2019 +0100

    lib: add nt_time_to_full_time_t()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6f9a824fdad1deb9e738850638328d04731b9d7a
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Dec 4 12:46:11 2019 +0100

    lib: add full_timespec_to_time_t()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit af142df467fd434d5d45d55a3fd4c017bf673c7e
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 15:00:19 2019 +0100

    lib: add nt_time_to_full_timespec()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7c1d8957353867470bbcb32cae19467b06f0e25d
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 21 16:47:33 2019 +0100

    torture: add a timestamps torture testsuite
    
    Add a test that shows that setting timestamps to the special
    values (time_t) 4294967295, 0, -1 and anything below is broken.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b5dc6aa7202957d6a68eb27150796ef669e81369
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Dec 4 12:11:05 2019 +0100

    lib: add full_timespec_to_nt_time()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit eb42beeb1bf06aa78a67407bd74216230b8b0ef5
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 26 17:22:17 2019 +0000

    lib: add functions dealing with struct timespec UTIME_OMIT
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 96418cb15606a0969a50096e1c0e5de9c9e48d9a
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 27 11:28:30 2019 +0000

    lib: provide UTIME_NOW|OMIT defines under our own namespace
    
    We may want to add additional defines in the future in order to deal with
    NTTIME(-1) and NTTIME(-2) coming in over the wire. They have special semantics
    attached to them, -1 requests "no automatic write time updates" on a filehandle
    and -2 reenables them.
    
    We could use something like
    
      #define SAMBA_UTIME_FREEZE (SAMBA_UTIME_OMIT - 1)
      #define SAMBA_UTIME_THAW (SAMBA_UTIME_FREEZE - 1)
    
    in the future.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5fe42bdcde1d686c885445a718f181a49953c918
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 27 11:28:08 2019 +0000

    replace: ensure UTIME_NOW and UTIME_OMIT are always available
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d95be9135890279a845cc6712a15236aaa87e4d7
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 21 16:44:37 2019 +0100

    s3:tests: add a blackbox test that confirms broken timestamp behaviour
    
    This blackbox test confirms that Samba returns NTTIME=0 when a filesystem object
    has a UNIX timestamp value of 0, ie UNIX epoch start 1.1.1970.
    
    Here's an example output from running smbstatus allinfo on such a file:
    
      $ bin/smbclient -U slow%x //localhost/test -c "allinfo time_0_1970"
      altname: T11662~T
      create_time:    NTTIME(0)
      access_time:    NTTIME(0)
      write_time:     NTTIME(0)
      change_time:    NTTIME(0)
      attributes:  (80)
      stream: [::$DATA], 0 bytes
    
    If you look at it with smbclient ls command, it munges the output to be 1970 so
    you don't notice the problem:
    
      $ bin/smbclient -U slow%x //localhost/test -c "ls time_0_1970"
        time_0_1970                         N        0  Thu Jan  1 01:00:00 1970
    
    The test also test other time_t values -1 and 4294967295 that are used as
    sentinel values in Samba code and shows that handling these values is equally
    broken.
    
    Same for time_t values < -1.
    
    Note that I'm adding a blackbox test *and* a torture test, as with this blackbox
    test I can directly control the server side, but with smbtorture I have to go
    through the SMB stack to create the files which doesn't work currently.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=7771
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 397ecd1feb3c46b861df7d37228b3033f27a06fa
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 21 12:29:51 2019 +0100

    s3:lib: remove unused uint64s_nt_time_to_unix_abs()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit eefc8ee8e31c108114b6114df4ad006d33af1f4b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Dec 4 12:10:27 2019 +0100

    bootstrap: add debian10 support
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Fri Dec  6 00:16:45 UTC 2019 on sn-devel-184

commit 41f6248effa5f5c0606a13da289c8a77abb30bce
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Dec 4 19:52:56 2019 +0100

    bootstrap: use runners with 'docker' and 'gce' tags for the image creation
    
    As we currently have the 'shared' tag on our private runners, they
    maybe selected for image creation, but it fails there.
    
    A lot of shared runners provide 'docker' and 'gce' and they are able to
    generate the images.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 809247973d9441c3d5249a7143cde6e858935d79
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 28 10:18:29 2019 +0000

    s3:locking: simplify code in get_share_mode_lock()
    
    The call to get_static_share_mode_data() is identical in the if/else branches,
    so move it behind them.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Dec  5 20:12:23 UTC 2019 on sn-devel-184

commit e30607aff3149395ce908d8ebfcac0fe56daa1ae
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 20 16:32:59 2019 +0000

    s4/smb_server: Fix handling of SMB2 messages after Netbios session setup
    
    On receiving a special NBT packet (e.g. session setup) the samba daemon
    effectively sets up SMB1 as the negotiated protocol (in terms of
    software handling of the messages) even though no SMB protocol
    has yet been negotiated. If the next message after the nbt session setup
    is a SMB2 message it will be handled by the SMB1 callbacks and will be
    rejected. This is evident when using smbclient (with -p 139) option
    in an env where SMB1 cannot be negotiated [*]
    
    This change doesn't set up the SMB1 callbacks on receipt of NBT special
    messages but lets the generic callback in place. Once either SMB1 (or)
    SMB2 is established (by receipt of a 'real' SMB or >=SMB2 message) then
    the proper callbacks will be set as normal.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Thu Dec  5 18:44:40 UTC 2019 on sn-devel-184

commit 5010535ec14d4e1f4dd83450432fc51a8ab53646
Author: Noel Power <noel.power at suse.com>
Date:   Fri Nov 22 17:01:45 2019 +0000

    s3/utils: Make sure we can negotiate protocol based on smb.conf settings
    
    net_rpc_check was hardcoded to check for rpc using SMB1 only. We
    should negotiate protocols based on the client max|min protocol settings
    
    this commit also removes the entry for
       samba3.blackbox.net.misc.lookup share list
    
    from knownfails as this test should now pass following this change.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 66443fe9340f1ae3894016fd7be51780f4c631b4
Author: Noel Power <noel.power at suse.com>
Date:   Fri Nov 22 16:53:08 2019 +0000

    s3/script/tests: Add simple test for net share list
    
    Adding a test for the net share list command. Currently this
    command will fail because of a bug in the net command when it tries
    to see if rpc is supported. This change adds a known fail to swallow
    this error. A future commit will fix the net command and remove the
    known fail
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit aca1c949023bf4ac620fe8d21a5e2a6e12c48dae
Author: Noel Power <noel.power at suse.com>
Date:   Tue Nov 19 12:38:18 2019 +0000

    s3/utils: net time always hardcoded to use SMB1
    
    net time ... cmd ignores any configuration to do with min/max protocols
    and connects allways with smb1
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 921f9f797f125d5e7cfe5505cd4287d23c2ae8f9
Author: Noel Power <noel.power at suse.com>
Date:   Thu Nov 21 12:31:31 2019 +0000

    s3/script/tests: Use protocol param passed to selectively run tests
    
    samba3.blackbox.smbclient_s3 passes NT1 or SMB3 to run tests however
    the PROTOCOL param is not used consistently within the script which
    results in NT1 and SMB3 traffic being produced during testing. This
    obviously causes issues when running the tests in an test environment
    where SMB1 cannot be negiotiated. These changes fix this
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a6451609993639616edcb6ee262381d5155774a1
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 27 20:06:10 2019 +0000

    s3/selftest: allow samba3.blackbox.smbclient_ntlm.plain run SMB1 & SMB3
    
    samba3.blackbox.smbclient_ntlm.plain used test SMB3 & NT1 protocols
    in one test. These changes:
      *  modify the test driver script test_smbclient_ntlm.sh to take a
         protocol as param
      *  modify the test description generators to pass NT1 & SMB3
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 980f7736fc0c569af6142288ac444775941426c3
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 27 19:44:23 2019 +0000

    s3/selftest: run samba3.blackbox.preserve_case with SMB1 & >=SMB2
    
    adjust test generators to run SMB1 & >=SMB2 versions of
    samba3.blackbox.preserve_case test.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f26c678a2ca550de6207634a8ea1461699cf54d6
Author: Noel Power <noel.power at suse.com>
Date:   Tue Nov 19 15:45:35 2019 +0000

    s3/script/tests: Allow test script to accept option protocol list
    
    test_preserve_case.sh tests a range of protocols, this however
    fails when running against the normal test env (which have min
    protocol of SMB2) because one of the protocols is NT1. This change
    allows tests to pass the protocol (or list of protocols) so that
    tests can be split.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f56314a97c508e105cd2b981730cd4fd25b0c6e4
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 11:05:57 2019 +0100

    s3/selftest: Run samba3.blackbox.net.misc with smb1/smb2
    
    samba3.blackbox.net.misc now can run with >=SMB2 or SMB1 protocols,
    adjust previous test definition and add new one
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d4d2e0175a4fef00566efa276a779a4ec23794d2
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 27 19:37:26 2019 +0000

    s3/selftest: split SMB1 & SMB2 parts of samba3.blackbox.dfree_quota
    
    samba3.blackbox.dfree_quota was almost exclusively a SMB3 test, only
    one part was testing legacy SMB1 behaviour, this change splits this
    out so the SMB1 part can be run independantly.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7c0ccbe1a004b96ccf726bda01262e5394c4d0b6
Author: Noel Power <noel.power at suse.com>
Date:   Tue Nov 19 14:11:21 2019 +0000

    s3/script/tests: Prepare to split samba3.blackbox.net.misc for SMB1/SMB2
    
    modify test_net_misc.sh to accept optional protocol, no protocol
    specified and it behaves more or less as before (expect this time the
    client max protocol is explicitly speficied)
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b4b25128b878cc4c41973de9c5ef5e9d0109a6a4
Author: Noel Power <noel.power at suse.com>
Date:   Wed Nov 27 19:25:49 2019 +0000

    s3/selftest: allow samba3.blackbox.dfree_command run NT1 & SMB3 tests
    
    samba3.blackbox.dfree_command was a single test that run both NT1 &
    SMB3 tests together. This allow the protocol to be passed into the test
    script so the test can be divided into SMB1 & >=SM2 tests.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2ffccf9c016a91818e6617a53c5f9d54f5c70c8b
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Dec 5 10:38:17 2019 +0100

    selftest: fix a flapping test
    
    The previous approach of using ls | grep $NAME for testing whether the previous
    directory removal succeeded will fail in case $NAME is a substring of any
    directory entrie's name.
    
    Eg
    
      NAME=tmp.123
    
    and the directory contains an unrelated entry
    
      tmp.123456
    
    Using allinfo instead should fix this.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ea1c62f3c7180e9ad5024bfcaea2d905f0b7996f
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Dec 4 13:54:04 2019 +0100

    ldb:tests: Allow test filtering in ldb_mod_op_test
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Dec  5 17:13:36 UTC 2019 on sn-devel-184

commit 520bb70dfd65d0a5236aa83cb8d662be62169e54
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Dec 4 13:29:26 2019 +0100

    ldb:tests: Avoid that the debug function overwrites memory
    
    We are setting ldb_debug_string() as the ldb debug function. The context
    we give it is only valid as long as we're in that function.
    
    On failure, we jump to the teardown function. The pointer for
    debug_string isn't valid anymore, but the ldb debug system still points
    to that address, and when we store the location of the allocated string,
    we overwrite memory, in that case something from talloc and a
    talloc_free() then jumps into the nirvana.
    
    Thanks to Florian Weimer who helped debugging this.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>

commit 8db0c1bff6f42feabd2e4d9dfb13ae12cc29607b
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:53:09 2019 -0800

    s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol].proto_reply_fn() succeeds.
    
    Otherwise we can end up with negprot.done set, but
    without smbXsrv_connection_init_tables() being called.
    
    This can cause a client self-crash.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Dec  4 21:27:24 UTC 2019 on sn-devel-184

commit 46899ecf836d350c0c29b615869851da7d0ad6fb
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Dec 2 17:23:21 2019 -0800

    python: tests. Add test for fuzzing smbd crash bug.
    
    Mark knownfail for now.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e84910d919e02feab2a297fccbbf95f333e32119
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:46:16 2019 -0800

    s3: smbd: Ensure we exit if supported_protocols[protocol].proto_reply_fn() fails.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit f4caa4159bd3db5127e114718e606867348a4f47
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:43:25 2019 -0800

    s3: smbd: Change (*proto_reply_fn()) to return an NTSTATUS.
    
    That way the caller can know if the negprot really
    succeeded or not.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 836219c479b047403d2b0839a6b92ad637dbaea0
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:21:06 2019 -0800

    s3: smbd: Change reply_smb20xx() to return NTSTATUS.
    
    Not yet used.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit a2d81d77c111379cbb6bd732c717307974eace0a
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:17:29 2019 -0800

    s3: smbd: Ensure we exit on smbd_smb2_process_negprot() fail.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 868bc05cf5d575e20edcce241e3af1d0fa6d9824
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Nov 26 12:14:29 2019 -0800

    s3: smbd: Allow smbd_smb2_process_negprot() to return NTSTATUS as it can fail.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit eddd6c52678b28131d5dba67e6a8eaf4e5696a92
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 22:41:06 2019 +1300

    pidl: don't export parser class methods
    
    These methods are not used or usable as exported functions. The
    correct (and actual) usage is along these lines;
    
        require Parse::Pidl::Samba3::ClientNDR;
        my $generator = new Parse::Pidl::Samba3::ClientNDR();
        my ($c_code,$h_code) = $generator->Parse($ndr, $header, $c_header);
    
    where the methods are either explicitly referenced (new A::B::C),
    or are called from the blessed object, neither of which need
    exporting.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Dec  4 06:35:06 UTC 2019 on sn-devel-184

commit 8429418a88e803592f57e1997bfbe0f639f422c0
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:59:31 2019 +1300

    pidl s4/TDR: use Parse::Pidl::Base
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 12f6698f76e29854d5097a266fb4e1658d88ae96
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sun Dec 1 17:43:20 2019 +1300

    pidl s4/TDR: use conventional ->{res} name
    
    rather than ->{ret}, meaning this class can be moved to a Pidl::Base subclass
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fd68ba8a10adf7439f842a787943b1ec4580d837
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:55:15 2019 +1300

    pidl: s4/NDR/Parser uses Pidl::Base
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 574c8db54cf1ba06516a5036269bffd81e20d602
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:49:06 2019 +1300

    pidl s4/NDR/Client: use Pidl::Base
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3fc222a1225658706444fd8118f9477b6a4baba4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:37:43 2019 +1300

    pidl s4/NDR/Client: fix pidl_both()
    
    This function was clearly meant to be adding output to both the .c and
    .h files, but was only adding it to the .h due to a typo.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 803d9cf8dd7d1767a7d9ac6e846450eb99ba8d5e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:31:27 2019 +1300

    pidl s4::Python uses Pidl::Base
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5513558bb422132632da08574d02f3a568622138
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:30:48 2019 +1300

    pidl:: adjust s4::Python pidl_hdr() to be the same as others
    
    The common case is for pidl_hdr() to add a "\n", which we can
    easily do here, allowing this to be merged into the Pidl::Base borg.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4f0fba18867faa0578d63c26054d04afd7f8b019
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:25:54 2019 +1300

    pidl Samba3::ClientNDR uses Pidl::Base
    
    We need to modify the '@ISA = ' line, because it overwrites
    the inheritance from Pidl::Base.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a78f69cb7d374adae470ac5e3dd9f3ac8175292e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 16:22:22 2019 +1300

    pidl: optionally annotate output for debug purposes
    
    It can sometimes be hard to tell which bit of pidl generated which bit
    of C. This commit wants to help.
    
    If the PIDL_DEVELOPER environment variable is set (via waf
    --pidl-developer or some other means), pidl will annotate *most* C
    indicating which lines were generated by which bits of pidl. It looks
    something like this:
    
    _PUBLIC_ enum ndr_err_code ndr_push_auth_session_info(struct ndr_push *ndr, int ndr_flags, const struct auth_session_info *r)
    {  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseTypePushFunction  lib/Parse/Pidl/Samba4/NDR/Parser.pm:3079
    	NDR_PUSH_CHECK_FLAGS(ndr, ndr_flags);  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseStructPush  lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
    	if (ndr_flags & NDR_SCALARS) {
    		NDR_CHECK(ndr_push_align(ndr, 5));  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseStructPushPrimitives  lib/Parse/Pidl/Samba4/NDR/Parser.pm:1448
    		NDR_CHECK(ndr_push_unique_ptr(ndr, r->security_token));  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParsePtrPush  lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
    		NDR_CHECK(ndr_push_unique_ptr(ndr, r->unix_token));
    		NDR_CHECK(ndr_push_unique_ptr(ndr, r->info));
    		NDR_CHECK(ndr_push_unique_ptr(ndr, r->unix_info));
    		NDR_CHECK(ndr_push_uint3264(ndr, NDR_SCALARS, 0));
    		/* [ignore] 'torture' */  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseElementPushLevel  lib/Parse/Pidl/Samba4/NDR/Parser.pm:729
    		NDR_CHECK(ndr_push_DATA_BLOB(ndr, NDR_SCALARS, r->session_key));  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseDataPush  lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
    		NDR_CHECK(ndr_push_uint3264(ndr, NDR_SCALARS, 0));  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParsePtrPush  lib/Parse/Pidl/Samba4/NDR/Parser.pm:604
    		/* [ignore] 'credentials' */  //:PIDL: Parse::Pidl::Samba4::NDR::Parser::ParseElementPushLevel  lib/Parse/Pidl/Samba4/NDR/Parser.pm:729
    
    The comments starting with '//:PIDL:' have the function name, the filename,
    and line number. The comment follows the ordinary output, and uses the '//'
    style so as not to interfere with multiline /* */ comments if they happen
    to exist.
    
    A '//:PIDL:' comment is added whenever the pidl function or indentation
    level changes, and very occasionally at other places if pidl runs for a
    while without either of these things happening.
    
    This does not affect pidl parsers that do not inherit from Parse::Pidl::Base,
    and is careful to have no performance impact on non-debug generation.
    
    This may help with semi-automated flow analysis.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0cb2e6ac4c730e504cf40ec328e90874a2267d7e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 30 15:22:16 2019 +1300

    pidl: add a base class for PIDL parsers
    
    There are about 5 object-oriented parsers, all with their own
    effectively identical but differently spelt versions of pidl(),
    pidl_hdr(), indent(), and deindent(). With this commit we add a base
    class that they can all use.
    
    The ultimate aim is to be able to add some debugging instrumentation
    that benefits all[1] the parsers.
    
    [1] The parsers (e.g. Samba::ServerNDR) which use global scope rather
    than objects will not be affected.
    
    The versions of the functions in this file follow the most
    sophisticated versions of the soon-to-be subclasses. For example, the
    pidl() function avoids spurious whitespace and puts #define at column
    0, following the Python parser.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 12cccf3447333dfd4f5e437cd57ca5ec68724fdd
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Dec 3 11:17:26 2019 +1300

    pygpo: use correct method flags
    
    The METH_KEYWORDS argument must always be combined with METH_VARARGS.
    
    In Python up to 3.7 this was checked at runtime, and as we had no callers to
    get_unix_path() in Python we never noticed. In Python 3.8 it is checked at
    import time, and everyone notices even if they aren't directly using GPOs.
    
    Found and reported by Val Kulkov.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14209
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d15a3797c7949140c872e82cc42d4f7301a9bf82
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 14:19:24 2019 +1300

    librpc: Avoid spinning on string_array elements with a short input
    
    Without this protection we will spin during decode of a string_array or nstring_array
    that is terminated by only a single NUL byte, not two as required by UTF-16.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13874
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit bf8063e369a227eecc902f90277fc59d9d0ad167
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Mon Dec 2 15:54:08 2019 +1300

    librpc ndr: Tests for ndr_pull_string
    
    Tests to ensure that ndr_pull_string handles zero and one byte length
    data correctly for both character strings and UTF-16 strings.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=13874
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7127a615cbd742695cea5865533c1ee7098ecc10
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Wed Dec 4 08:46:57 2019 +1300

    librpc ndr: Infinite loop parsing Suplemental creds
    
    Fuzzing by Michael Hanselmann found an infinite loop parsing a malformed
    supplemental credentials structure.  There are no server-side
    network-accessible calls using this code.
    
    This patch adds an ndrdump blackbox test to replicate the issue.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=13874
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 787adfbcc9381b19330f1f73c95e34d25613f6b6
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Dec 2 13:21:57 2019 +0100

    s4:heimdal_build: move krb5-types.h into include/krb5-types.h
    
    source4/heimdal_build/include/ contains public headers,
    which are needed by callers.
    
    source4/heimdal_build/*.h should only be used for building the
    in tree heimdal itself.
    
    Without this an '#include "replace.h"' can catch 'config.h' from
    source4/heimal_build/config.h before bin/default/include/config.h.
    This #defines HAVE_CLOSEFROM unconditionally before replace.h can define
    the replacement for rep_closefrom() on systems without libbsd.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Tue Dec  3 23:36:17 UTC 2019 on sn-devel-184

commit 1b583bff72cb47860abc5168cc96d9087df16604
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Dec 1 10:07:06 2019 +0100

    auth3: Remove auth_script
    
    Did this ever really work?
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Dec  2 22:47:24 UTC 2019 on sn-devel-184

commit a82ab4a7b3baaafab91b3e8f0746de70b07c306d
Author: Puran Chand <pchand at vmware.com>
Date:   Thu Oct 31 21:02:47 2019 +0530

    s3: smbclient doc fix
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 77d3a98aa63f37a8ced01c65fdb9b05ca68c6281
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 15:44:00 2019 +0100

    smbd: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4cd6c87a3d54e37b86c03b5d4bc0c24386fdfffb
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 14:00:51 2019 +0100

    libndr: Fix a talloc context leak
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8d8d2bdfa4f988bf5fdc9e05f7f3d1b4b6c54d0d
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 29 21:30:39 2019 +0100

    smbd: Avoid leaking share_entries.tdb records
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 18d7bb0698361900593bfe33c8655ba32a3671cd
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Nov 28 16:07:40 2019 +0100

    smbd: Use share_mode_do_locked() in smbd_do_unlocking()
    
    We don't really need the share mode data here
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 39f9618316946783bf7ceb5baf8667e139f3301c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 19:02:43 2019 +0100

    lib: Remove unused smb_xvasprintf()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 6d1ce7dc1723e0c9f63b6b5ec08141f198049a56
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 19:00:26 2019 +0100

    winbind: Use vasprintf() in winbindd_cache
    
    Don't need to panic, we can do explicit checks in these few callers
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 34c269ad02cbb6fae0d9b9db43d6700d06de1842
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 18:55:53 2019 +0100

    lib: Remove a duplicate fdprintf() prototype
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 6ab4b87a7e61d5af6e7980380c0f307bc310e5f0
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 08:36:59 2019 +0100

    lib: Remove duplicate get_pass() prototypes
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 7093356440d0828f133fe652b090125af51cd01a
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 27 08:35:05 2019 +0100

    lib: Make stdin_new_passwd() static
    
    It's only used in one place
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martins at samba.org>

commit 27fc062d7ea2207242d5a2c9933f3de5fa206488
Author: Uri Simchoni <uri at samba.org>
Date:   Sun Oct 20 21:36:11 2019 +0300

    heimdal-build: avoid hard-coded /usr/include/heimdal in asn1_compile-generated code.
    
    This fixes a cross-compilation issue, as cross-compilers (rightly)
    complain if host include directories are in the include path.
    
    The fix is taken from buildroot (https://github.com/buildroot/buildroot/blob/8b11b96f41a6ffa76556c9bf03a863955871ee57/package/samba4/0006-heimdal_build-wscript_build-do-not-add-host-include-.patch) where it was applied by Bernd Kuhls <bernd.kuhls at t-online.de>.
    
    This reverts some of 3fe2bfddda6149f6bf7402720226e9285f479fef, but
    building Samba's bundled Heimdal with a system roken is not supported
    anyway.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13856
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sun Dec  1 10:22:01 UTC 2019 on sn-devel-184

commit 7c4341c736c875d048ca622217f762b895a945ba
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Wed Nov 27 23:25:52 2019 +0000

    Split winbindd into library and binary
    
    The winbindd program was built in a single target with many source file,
    making reuse of parts elsewhere impossible. With this change the
    majority of the code is built as a subsystem and included in the binary
    as a dependency.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cddc229a4689f1d1757f427cd58816c1af2e628f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 18:55:47 2019 +1300

    selftest: Test partial parse behaviour in ndrdump
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Nov 29 02:09:11 UTC 2019 on sn-devel-184

commit b866018c2c89f6118c18d7a3527a0fa6d9916b9e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 18:54:28 2019 +1300

    ndrdump: Do not run the validate step after a failure
    
    This avoids ending a failed parse with 'dump OK'
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit ef0257b1055cfea3ca0bee69d8848f5719300911
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 18:54:04 2019 +1300

    ndrdump: Improve error message when the pipes fail to dump
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit bbae56411c716d8678687cf7c559488b618e8935
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 18:53:09 2019 +1300

    ndrdump: Show the actual struct/function name in the print, not just what it was called
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 674d2cfd04e79fc35317198c5e9e88734b14a5b9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 21 11:28:36 2019 +1300

    librpc/ndr: Remove unused ndr_cab_generate_checksum()
    
    This function is not just unused, it is a problem because there is no
    enforced connection between r->ab.length and r->cbData.
    
    The last caller was removed in the previous commit.
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit bd81733bb7c5af3fb2f98bf475d53507c3955b31
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 19 16:07:50 2019 +1300

    librpc: Make CFDATA private to cab.idl and remove pull and push functions
    
    We can do this because ndr_{pull,push}_CFDATA is unused.
    
    The earlier commit 466d5e814727046dd630d5503b43874ec46a365e removed
    the link between "uint16 cbData" and the size of "DATA_BLOB ab" so
    when the new ndr_fuzz_X fusser pushed a new structure this allowed
    a read beyond the end of allocated memory.
    
    The ndr_push_cab_file() function is also manually written and
    does not rely on the value of cbData to calculate the checksum.
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer, which like ndrdump's struct mode uses the public structure
    tables.  (This is how it found the unused functions to test).
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 12b3f26eee88ac810d08197d64019f5c4cfa2a03
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Nov 26 10:56:15 2019 +0100

    samba-tool tests: re-add tests for attribute value verification using samba-tool
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 6d1a0eb8d11dc0ad62500d977fafc7411d6f39ed
Author: Björn Baumbach <bb at sernet.de>
Date:   Mon Nov 25 14:13:37 2019 +0100

    samba-tool {user,group,computer,contact} show: avoid base64 encoded strings if possible
    
    Be more user friendly and use clear text argument strings if possible.
    
    Signed-off-by: Björn Baumbach <bb at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0b04d9f2ec85f10dac8cd8723deea3a18925deea
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Nov 26 10:41:29 2019 +0100

    samba-tool tests: prepare tests for new samba-tool functionality
    
    Use ldbsearch instead of "samba-tool user show" to get base64 encoded
    attribute. Used to verify that the attribute value has been changed
    successfully.
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit c35b3ef2e1e79559c4293a413f5d422908546919
Author: Björn Baumbach <bb at sernet.de>
Date:   Mon Nov 25 20:53:35 2019 +0100

    samba-tool tests: remove duplicate definitions of test functions
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9983caaa47de2dd983f704867fad509f4d7196b1
Author: Björn Baumbach <bb at sernet.de>
Date:   Mon Nov 25 16:36:03 2019 +0100

    samba-tool group show: fix a copy-paste mistake
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2b88890adada76b1146591d62eb3898096f9105c
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Nov 22 22:39:09 2019 +0100

    krb5: move disabling dns-canon to lower level init calls
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Wed Nov 27 12:24:16 UTC 2019 on sn-devel-184

commit d9d6ce6eca6ca79fec95e93ce55d6e40da993de5
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 19:44:05 2019 +0100

    krb5: remove "set_dns_canonicalize" conf option
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

commit 609a1d1d6b491c8efc1436c65b75ebf5b0003a03
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 19:26:57 2019 +0100

    Revert "selftest: system-heimdal: workaround upstream "host" canon bug"
    
    This reverts commit 15ddd95d94688ed742a2965c4b269d7c84e2d858.
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ef1c852f975e98e034cefc7fc0c2da9eb8d5a46f
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Nov 21 21:05:24 2019 +0100

    heimdal: invoke gsskrb5_set_dns_canonicalize(false) in gse_context_init()
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>

commit 5114f73ea72bda2b4268fece9a5d61214d7afd20
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 7 11:40:07 2019 +0100

    param: remove now unused lp_string()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 31b06f412e91f44e074241564766d9c4869fff9d
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 7 11:37:47 2019 +0100

    param: remove FN_LOCAL_STRING
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b5c6964a50be03999432fa5620be39dcb7093ad8
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 7 11:01:05 2019 +0100

    s3:param: make "servicename" a substituted option
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit eddc63be868434d3aa5a66b514b692f4d7b8833a
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Nov 7 09:50:37 2019 +0100

    printing: use lpcfg_substituted_string() in print_run_command()
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 24905ba82d2f1b9e01df7a6e03d853c5138bc148
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 19 11:53:50 2019 +0100

    docs-xml: remove explicit "constant"
    
    The constant mark applied to types "string" and "ustring". The previous patches
    in this patchset already markes all string options as either constant or
    substituted, but it's still possible to add options or change existing ones to
    be neither constant nor substituted.
    
    In order to enforce strings to be either constant or substitued, remove the
    explicit constant marker. Instead, any option that is not marked as substituted
    is implicitly made constant.
    
    This patch doesn't change behaviour and all generated files are the same before
    and after this change.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 3e81d9460bf4f0640ef7c679cd539e614929343e
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 19 10:30:46 2019 +0100

    param: remove now unused FN_GLOBAL_STRING macro
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ad2c824b1f1ab3947176924074f4264fa0f44edd
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 6 14:24:58 2019 +0100

    docs-xml: remove SWAT specific flags
    
    Most of the SWAT stuff was removed in 4a6a010e78721624813a84bfefa7a1b80eaf0abb,
    somehow these two crept back in afterwards.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ca72c4b39c8d025f237af558fbeba485d09864a0
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:20:22 2019 +0100

    smbdotconf: mark "usershare template share" with constant="1"
    
    The code uses Globals.usershare_template_share directly anyway.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9aca11aec9fd129d5636f985969d55db209cb768
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:55:12 2019 +0100

    smbdotconf: mark "rpc server dynamic port range" with constant="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 564b0b5be31593de01e6d53388ee69e48645effa
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:53:54 2019 +0100

    smbdotconf: mark "mangling method" with constant="1"
    
    From the manpage:
    
      ... controls the algorithm used for the generating
      the mangled names. Can take two different values, "hash" and
      "hash2". ...
    
    No need for variable substitution support in this option, declare it const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6f618b7c95830b73ac636032e136b11c957139be
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 19:27:41 2019 +0100

    smbdotconf: mark "ldap user suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
    directly, variable substitution isn't supported anyway, so we can just mark this
    const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9ed8292a7b2fa08e16e5d98147ecdbe859d85e77
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 19:27:41 2019 +0100

    smbdotconf: mark "ldap machine suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
    directly, variable substitution isn't supported anyway, so we can just mark this
    const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b48d30e0e12a2ddf52429b69599850c670e68160
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 19:27:41 2019 +0100

    smbdotconf: mark "ldap idmap suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
    directly, variable substitution isn't supported anyway, so we can just mark this
    const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 71e9c6e48b57f568b04eb829511492aff41745b9
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 19:27:41 2019 +0100

    smbdotconf: mark "ldap group suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix is returned
    directly, variable substitution isn't supported anyway, so we can just mark this
    const.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ca2e49fe42087678f971bde26ca05c91fb6f95b3
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 09:46:21 2019 +0100

    smbdotconf: mark "ldap suffix" with constant="1"
    
    Due to the use of append_ldap_suffix() where Globals.ldap_suffix was used
    directly in the dependent options like "ldap group suffix", we can just mark
    this option as const thereby removing substitution from "ldap suffix".
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 050c28364aa1b476d33ea726ecb6cbd9d26af5d8
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:54:23 2019 +0100

    smbdotconf: mark "ldap admin dn" with constant="1"
    
    All the other LDAP related options like "ldap user suffix" don't support
    variable substitution, so I guess it's safe to remove support for it from this
    one as well.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4d2a3c8a791a42e2162ef957de2937673d536f53
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:21:58 2019 +0100

    smbdotconf: mark "wins hook" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 2dae6473fa0dabc2e12ffcf766f81117a10944b4
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:14:37 2019 +0100

    smbdotconf: mark "usershare path" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b635c445ad5a283bce28ae7eb7a60067d8802d6c
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:12:51 2019 +0100

    smbdotconf: mark "username map script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 3c68114e73421b5b89b57582defd53faef275ca4
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:11:54 2019 +0100

    smbdotconf: mark "username map" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a0185c7efbdba9405bcfade9ad89675532a43ffe
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:07:21 2019 +0100

    smbdotconf: mark "shutdown script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fd72181fd0d9275b8b2972cf0393fd0cc4b94088
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:01:45 2019 +0100

    smbdotconf: mark "set quota command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 434d2632cb95cfe6170f554afa7c31810b298037
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 12:00:49 2019 +0100

    smbdotconf: mark "set primary group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7dc7b9e55491267794548f96acc2e45244cf6eac
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:58:43 2019 +0100

    smbdotconf: mark "server string" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8077804c36c44631ba09d52308fe9ad213ae7eb5
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:51:56 2019 +0100

    smbdotconf: mark "root directory" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1439c19ceef3682782a7c337302ef9b7310687ef
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:49:28 2019 +0100

    smbdotconf: mark "rename user script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6d0db70ef7379ab722daed78ff5a877b48efd083
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:46:23 2019 +0100

    smbdotconf: mark "remote browse sync" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit dbc82a9f19e2fb4b7f9d9d708a7c5ed0eb4f0778
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:39:27 2019 +0100

    smbdotconf: mark "remote announce" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5c5dbcc397f96bb9960786a3f91b7d2f4012aeff
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:24:16 2019 +0100

    smbdotconf: mark "perfcount module" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 299718ccd4f301f0ab90d2d65b05725c45b40c3a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 18 18:39:53 2019 +0100

    s3: remove a prototype that is generated by loadparm
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1743ff48ba3e0c738b5909206cfcbd2111221443
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 18 18:28:27 2019 +0100

    smbdotconf: mark "passwd program" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4551dd27840a4bd0f84a78da1920acc7ba204f88
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:13:30 2019 +0100

    smbdotconf: mark "passwd chat" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ea61dd917e671f2eee225e55aaed285a43ec7523
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:04:39 2019 +0100

    smbdotconf: mark "panic action" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f3cfef87854ccc27e037501c578fccb712791385
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 11:03:23 2019 +0100

    smbdotconf: mark "os2 driver map" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f47b710b2c97d60d5f8b088a8d8be26c2a1f7d79
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:59:40 2019 +0100

    smbdotconf: mark "message command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e46ea02939a13ef41b36500874baa90fa29e973e
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:52:56 2019 +0100

    smbdotconf: mark "log nt token command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4d7eaed58600342f618a3ea0307208dff0591ad0
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:50:32 2019 +0100

    smbdotconf: mark "log level" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9910b5e1da337e84479421a599badf53c1853ea9
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:36:53 2019 +0100

    smbdotconf: mark "logging" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fa5033cfb7e9b65c23fe2c0c391c59b70d8415c3
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Nov 5 10:34:11 2019 +0100

    smbdotconf: mark "logfile" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f2a1f0c705bc2e1f0400e23892fde45de00032b4
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:52:37 2019 +0100

    smbdotconf: mark "iprint server" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9f3c05d009a7b6daf720e535e06e33a5ea13bf6b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:50:59 2019 +0100

    smbdotconf: mark "homedir map" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 330f4ac1ca6b04bd86f50489227f9d4b88d03949
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:49:47 2019 +0100

    s3:lib: add missing TALLOC_CTX parameter in call to lp_homedir_map()
    
    This seems to be dead (at least dying) code,
    is WITH_NISPLUS_HOME ever defined?
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 25039641490fdc33d7e81959bc462b5a2916d95e
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:43:45 2019 +0100

    smbdotconf: mark "get quota command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 6e678cba77dac7bab2866bbfe393d624643fce1a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:42:38 2019 +0100

    smbdotconf: mark "enumports command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 1377e66edfc1c6cdd40417a0b3b986bc106b6a3f
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:35:22 2019 +0100

    smbdotconf: mark "delete user script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7547d837ec62c0e019122d503097ffe6d080a3ca
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:31:57 2019 +0100

    smbdotconf: mark "delete user from group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 28391f0b61b6cfe75d8042dbb5f811fdfada3b99
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:30:37 2019 +0100

    smbdotconf: mark "delete share command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d035f850deb5e7b3eb1f1c0d86f09ea6ec2e4cc4
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:26:29 2019 +0100

    smbdotconf: mark "deleteprinter command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b1c27e724665a5fea8da3a0f15ab87f01e86aa26
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:25:09 2019 +0100

    smbdotconf: mark "delete group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 736cb9d80c9fdba0369bd740aa82d88e45e0c4b9
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:21:34 2019 +0100

    smbdotconf: mark "defaultservice" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4b1de86de2b84afda280b862d4d6e7234ebb3de8
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 17:19:58 2019 +0100

    smbdotconf: mark "cups server" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit fb434275164c21494bbb8be7d0f36c7289b20ce0
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 16:50:41 2019 +0100

    smbdotconf: mark "next configfile" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 12e97ee3e86d72b9edad9a2ac37249ffa0d28331
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 15:27:43 2019 +0100

    smbdotconf: mark "check password script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit bf9c63a28008883a6722a129e6b0f5a6695ed6a7
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 15:24:16 2019 +0100

    smbdotconf: mark "change share command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 5e8d600bc6cc12019d986f54d1dd7483a940dacd
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 15:11:04 2019 +0100

    smbdotconf: mark "auto services" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8445454008a65581c3cf684a902072324894ea67
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 15:10:28 2019 +0100

    s3:param: let lp_add_auto_services() take a const char *
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 00c4d9ec1a67c9ed0a9827a9cb2982b335ab7a9a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 14:17:43 2019 +0100

    smbdotconf: mark "add user to group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4c345289baa1d18abd9975e2079a40b8f38bb384
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 14:12:08 2019 +0100

    smbdotconf: mark "add user script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 390f53cb038ad2f64cb3eae295643656b431b12f
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 13:58:28 2019 +0100

    smbdotconf: mark "add share command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 39f8014275c34d935bdbc5e272e60f2e4ed6b426
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 13:53:49 2019 +0100

    smbdotconf: mark "addprinter command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a5db3443a2e2aa25d7f58d999bacc297cc40b14a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 13:51:47 2019 +0100

    smbdotconf: mark "addport command" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b0198b18314074495eaffd590799e1f0aa098a2c
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:49:10 2019 +0100

    smbdotconf: mark "add machine script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 9e35015739d790ed0d44cd74ad9f8bb308f2d35d
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:43:06 2019 +0100

    smbdotconf: mark "add group script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit db75b5d6fcc3dbdf10ceace57011ede629382da8
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 16:56:47 2019 +0100

    smbdotconf: mark "abort shutdown script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 8834eafcacaa01d497f488851fe4f6b339be0e30
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:33:55 2019 +0100

    smbdotconf: mark "volume" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 18bd0c38f506876fd51c2bf54672b4e257364023
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:30:58 2019 +0100

    smbdotconf: mark "veto oplock files" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 73082f938ed6673eb5a0a3a3dbf12f306c13ee24
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:29:44 2019 +0100

    smbdotconf: mark "veto files" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 17726dab60fef0c28ecaf4edb03e320d74b74470
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:20:21 2019 +0100

    smbdotconf: mark "root preexec" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b92038072f3e5debd519eda0ab07182f46e06e56
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:19:24 2019 +0100

    smbdotconf: mark "root postexec" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b98e1ad7711aac4f8914b960199c9ae3aa7cea69
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 12:14:34 2019 +0100

    smbdotconf: mark "printername" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit e95e1c2d4f8faf9dee82e7f51f95ca8451163336
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 11:30:22 2019 +0100

    smbdotconf: mark "preexec" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 4f2ee224ce8a518ae0328e152addd2a1cdcca298
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Nov 4 11:23:18 2019 +0100

    smbdotconf: mark "postexec" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f7619ac22b50bf3bac96825e72e9910946d7f4d2
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 19:14:02 2019 +0100

    smbdotconf: mark "path" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 95f0f22ca5150642c77bbbbe40a921ac50861e1c
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:56:10 2019 +0100

    smbdotconf: mark "msdfs proxy" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 223c1f725a5d48f226110f6b2decd1451ea8c526
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:49:07 2019 +0100

    smbdotconf: mark "magic script" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 595685c1655fb71e64ba94bca504349cb25561b2
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:47:43 2019 +0100

    smbdotconf: mark "magic output" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 86843529210e55c57327909e770259bcd8f656d2
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:44:25 2019 +0100

    smbdotconf: mark "hide files" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 78593e2f0073bbdf6225c2e5d5bbff5cc7688f5a
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 18:40:53 2019 +0100

    smbdotconf: mark "force user" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 2cf62e85e5fec7e977779587ab6ae051fad009aa
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 17:56:56 2019 +0100

    smbdotconf: mark "force group" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 79cff6295d11d1c708bb997d458e9d982cddd480
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 17:51:06 2019 +0100

    smbdotconf: mark "dont descend" with substitution="1"
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7e918fad6e974b06a43357ba08ea5ef7ecd7f3b5
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:54:45 2019 +0200

    smbdotconf: mark "cups options" with substitution="1"
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7973c873442ed093b71bd42ca1397c5bfd65c820
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:54:45 2019 +0200

    smbdotconf: mark "dfree command" with substitution="1"
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8e86ac18e7d6c3b3e9c5786138d1c90e699843c8
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:54:45 2019 +0200

    smbdotconf: mark "comment" with substitution="1"
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c23e3564fc2c7c9dc53c2d26ecbacb1d9682aba6
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:54:45 2019 +0200

    smbdotconf: mark "aio write behind" with substitution="1"
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ef1f0e9ffe76eaee4b92241ea39d81ea553fa841
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 16:52:30 2019 +0200

    param: add FN_{GLOBAL,LOCAL}_SUBSTITUTED_STRING support
    
    Pair-Programmed-With: Ralph Boehme <slow at samba.org>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>

commit 3215d357e6af97ac05266b6ab5c8861d7f124815
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 14:05:24 2019 +0200

    s3:parm: remove unused lp_parm_talloc_string()
    
    Callers should use lp_parm_substituted_string()
    directly or just use lp_parm_const_string().
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit cea386de159c6bea141aa507e7b67723fac2f007
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 14:04:27 2019 +0200

    s3:vfs_glusterfs: make use of lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f6747ccc3b7ba14834bb2c62087203129f84feed
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 14:00:29 2019 +0200

    s3:vfs_nfs4acl_xattr: make use of lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 48c7d777f220d5c82cc5c456f86f760c42e3cf7e
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 13:58:48 2019 +0200

    s3:vfs_streams_depot: make use of lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5170fc24218f387c61bf24b13a414ce7d685b2d0
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 13:56:44 2019 +0200

    s3:vfs_tsmsm: make use of lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 564049fbc949827ccbfddcdbc5f560fc4ccae4ad
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 13:38:16 2019 +0200

    s3:mdssvc: make use of lp_parm_const_string()
    
    We don't need any substitution for elasticsearch options.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 236857b43453a2460d508fb4a2d7915a5055d195
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 12:29:08 2019 +0200

    s3:param: split out lp_parm_substituted_string()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 063c4b25b1529987eb2e59ac53cd0ad23a8f5669
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 12:07:17 2019 +0200

    s3:param: split out loadparm_s3_global_substitution from lp_string()
    
    The idea is to get rid of the global state that's
    currently used for the substitution in lp_string().
    
    In the end all callers need to pass an explicit
    const struct loadparm_substitution *sub_ctx,
    which contains all relevant information
    for the substitution. At that point lp_string() can be removed.
    
    For now we provide loadparm_s3_global_substitution()
    for callers to keep the current bahavior unchanged.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 741bbfd252c272f796d535d653c39abee3569c93
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Nov 6 16:25:00 2019 +0100

    lib/param: introduce loadparm_substitution infrastructure
    
    Pair-Programmed-With: Ralph Boehme <slow at samba.org>
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Signed-off-by: Ralph Boehme <slow at samba.org>

commit c36dd5931850ae7ed6290718ecae7c3ebf257eb4
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 15:12:35 2019 +0100

    s3:param: rename lp_string() argument ctx to mem_ctx
    
    Minimizes diff of subsequent patch.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 57fa96b47654e899808b5159579b46f4059b5971
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 10:15:41 2019 +0200

    s3:lib: remove unused str_list_substitute()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 848cd4c460a52c459bba5ff14a8b72f126378066
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 15 10:15:14 2019 +0200

    s3:lib: remove unused str_list_sub_basic()
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ff35160dc6415e1ef5d57717d7636f38ea25a8f0
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Nov 20 11:39:20 2019 -0700

    net: Delete share ACL from 'net conf delshare'
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Nov 26 22:55:38 UTC 2019 on sn-devel-184

commit 9dddb28a1719c753e84e2631ef1e1f12460cc3df
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Nov 26 09:59:15 2019 -0700

    selftest: Add test for 'net conf delshare' also removing share ACL
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cb907fbee8373666100984693f004e37cb20cacf
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Nov 26 09:58:32 2019 -0700

    selftest: Make net command available in sharesec test
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6bf6e5364a9ad3e5d8186f1226c83ecf16637a37
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Sep 18 13:37:32 2019 -0700

    sharesec: Return NTSTATUS from delete_share_security
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1f304fc16c675f402c61f95601481e7a3e27db04
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Sep 18 13:20:35 2019 -0700

    sharesec: Return NTSTATUS from set_share_security
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6dfa5bb64fce1ddd054966bd89b07e43034c6edb
Author: Christof Schmitt <cs at samba.org>
Date:   Tue Sep 17 12:11:59 2019 -0700

    sharesec: Return NTSTATUS from share_info_db_init
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 39f21a58b0c196ef32e66a27051837e4395bb958
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 22 12:02:22 2019 +0100

    g_lock: Speed up sync g_lock_lock()
    
    The comment "this is used in very hot code paths" is not true right now, but
    will get true soon....
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ba852a3d92fd762e0a4d4e1b3a8177a30b5e34d5
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 22 11:56:55 2019 +0100

    g_lock: Move a variable inside the block were it's used
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f849d8c0cf7b8f04dd53cad4f633628c41565d2c
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 22 11:55:52 2019 +0100

    g_lock: Factor out g_lock_cleanup_shared()
    
    This function will find a second user soon
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 038549608709d4a1b7a1650041a57d201fb6a643
Author: Guenther Deschner <gd at samba.org>
Date:   Tue Nov 26 13:10:47 2019 +0100

    s3:winbind: Also set the cmd name for bool dispatch table
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Nov 26 14:14:51 UTC 2019 on sn-devel-184

commit 97d43cf6982a4bc1bbba70997990b017b6bca213
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 26 12:45:24 2019 +0100

    s3:winbind: Print priv pipe location
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 7eb171f6e36a3f1b3101398bb8a99aab99bb5c4f
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 26 13:32:53 2019 +0100

    gitignore: Add .build.log
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 9aa03be946467698ac7509251f366e165672feaa
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 20 16:03:37 2019 +0100

    torture: Test g_lock deadlock detection
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sat Nov 23 01:25:12 UTC 2019 on sn-devel-184

commit d734547488c6fab8d136239a95db640df57dbb97
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 17:29:18 2019 +0100

    lib: Change the g_lock data model
    
    Now we have one fixed field for the exclusive lock holder and an array
    of shared locks. This way we now prioritize writers over readers: If a
    pending write comes in while readers are active, it will put itself
    into the exclusive slot. Then it waits for the readers to vanish. Only
    when all readers are gone the exclusive lock request is granted. New
    readers will just look at the exclusive slot and see it's taken. They
    will then line up as watchers, retrying whenever things change.
    
    This also means that it will be cheaper to support many shared locks:
    Granting a shared lock just means to extend the array. We don't have
    to walk the array for possible conflicts.
    
    This also adds explicit UPGRADE and DOWNGRADE operations for better
    error checking.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit effad89f6224fbaeed5ef67016bd23e645763bc9
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 5 16:36:44 2019 +0100

    lib: Add g_lock_ctx_init_backend()
    
    This will allow using the g_lock.c logic on other databases as well
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 859148479b98678ee4bfa8084a6dc56bcc10a4c5
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Oct 28 13:50:09 2019 +0100

    torture: g_lock will allow duplicate READ locks soon
    
    In the future, g_lock will not check for duplicate READ locks anymore,
    as there might be many of them and the check might be expensive
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 97ba1ee2f94e5529839a1c0852f50544dbbb83cf
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 15:31:57 2019 +0100

    lib: Make struct g_lock_rec private to g_lock.c
    
    This is no longer exposed in the API
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c9b34cd2057c05e9965464ca5e9e28b423cb418b
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Oct 25 13:35:39 2019 +0200

    g_lock: Change prototype of g_lock_dump
    
    Soon the g_lock database format will change. There will be one
    exclusive entry and an array of shared entries. In that format,
    there's no need to attach a lock_type to each entry in the g_lock
    database. Reflect this change in the g_lock_dump API
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 06b0bcdf8d0abba2f0625ff458adb56bf471b9e0
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 13:13:02 2019 +0100

    smbd: Remove share_mode_data->record
    
    In the future, there won't be a record anymore
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0a66c9735456dbcee4b59e2bf8cd91402884b894
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 13:10:54 2019 +0100

    smbd: Pass the db_record down to share_mode_data_store()
    
    Remove a dependency on share_mode_data->record
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 24f56aefb487a6b269baf55b6840670666fbf0f3
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 13:06:20 2019 +0100

    smbd: Use share_mode_watch_send()
    
    This removes some dependencies on share_mode_data->record
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2379dc29bc73bdd1598a4ddaf47240cea5fd0697
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 12:57:35 2019 +0100

    smbd: Add share_mode_watch_send/recv
    
    For now this is a simple wrapper around dbwrap_watched_watch_send()
    that will make the direct db_record reference in struct
    share_mode_data unnecessary.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 341223a00596ef1cdc63d9eb0a0b2e496bd6f0f4
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 21:46:55 2019 +0100

    dbwrap_watch: Don't store in-RAM caches
    
    The history of this file is a mess with lots of bugs. Most of the bugs
    I believe are based on the cache of database contents we maintain in
    struct dbwrap_watch_rec. This patch removes that cache and does all
    modifications directly in the backend database.
    
    This means we have to mess with the database format in a few more
    places, but I think the format is simple enough that this does not
    really hurt.
    
    I tried for a few days to split this up into small pieces that are
    easier to understand, but every time I separated out individual chunks
    I found difficult to track down bugs that are all resolved in the
    final code presented here. It's more lines of code, but I hope it's more
    robust.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e5c28fec6f900dd1d8f1ee81d2cd008a93207a1a
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 13:43:13 2019 +0100

    dbwrap_watch: Simplify struct dbwrap_watched_watch_state
    
    With the wakeup messages changed, we don't need to store what used to
    be the old message in the struct dbwrap_watched_watch_state
    anymore. We still need to store the key that is watched for removal of
    our watch entry in the request destructor
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a793cc2276ef2123bfec1bc1828224372fcd3d93
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 13:36:58 2019 +0100

    dbwrap_watch: Simplify the wakeup messages
    
    The instance ID per process globally identifies a watch instance
    across databases. It's not necessary to send the database ID and the
    watched key across, the uin64_t instance ID is sufficient.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7349612c59a518a2858a4a7bb268fa1ad14016d3
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 13:23:52 2019 +0100

    dbwrap_watch: Add a uin64_t instance to watchers
    
    Initially used for debugging purposes only
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 053405719a5bd4121a2ca1f756dc7859ebb91faf
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 18 12:37:21 2019 +0100

    dbwrap_watch: Encapsulate watchers in "struct dbwrap_watcher"
    
    Next patch will extend this structure
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 7cea5fec29a0d425263a7ecb79d89a4f13de3f7e
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Nov 17 16:45:45 2019 +0100

    dbwrap_watch: Prevent two watchers per fetch_locked sequence
    
    This can lead to very confusing bugs, and the code right now does not
    deal with it well.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 79dcabfbabb9503eff9efe7cd32b1cb431d3ee69
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 16 13:20:14 2019 +0100

    torture3: Test the next patch: No two waiters in one do_locked()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e341911ddad078c3c0c95f7e0ec16701510cb273
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 16 12:41:13 2019 +0100

    torture3: Consolidate dbwrap_watch test initialization
    
    More lines, but less error-prone copy&paste
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ca8c23bb42e501d5fe7f47f6c59feb5e7524a0cf
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 23 12:19:38 2019 +0200

    dbwrap: Don't set rec->value in dbwrap_do_locked()
    
    We pass that via the callback now
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ffe4933c776bc89ab8a6bb09f74288b8bf7b1310
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Nov 17 14:50:51 2019 +0100

    locking: Remove a call to dbwrap_record_get_value()
    
    This makes a copy of the record values TDB_DATA.
    
    In this case, it is okay: We only do a dbwrap_record_storev modifying
    the value that we retrieved from the share_mode_lock destructor.
    
    This patch is necessary because the next commit will make the "value"
    argument to the dbwrap_do_locked() callback the only source of the
    record value. Thus for a nested share_mode_do_locked() call we have to
    maintain the record value explicitly.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1dc3c168245366d219fc8c3b116f4f5904a9cb07
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 24 16:41:47 2019 +0200

    dbwrap: Protect against invalid db_record->value
    
    After dbwrap_record_storev()/delete(), dbwrap_record_get_value()
    information is stale. Assert on the attempt to re-fetch data after it
    became stale. This can't protect against someone copying the result
    from dbwrap_record_get_value() somewhere else, but it's better than
    nothing.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5291208836ea85b1b02f5b31b577fcc9050fa8b9
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 16:02:32 2019 +0200

    vfs: Use dbwrap_do_locked() in vfs_offload_token_db_store_fsp()
    
    Less malloc
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dbf24bcb1baa588295313e4d37ce84ee6db80168
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 15:13:05 2019 +0200

    vfs: Use dbwrap_parse_record() in vfs_offload_token_db_fetch_fsp()
    
    Less malloc
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 78c96f6995aa0cb8e0ec0872bdc00bb452bc2d36
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 23 11:21:16 2019 +0200

    g_lock: Pass "data" down to g_lock_trylock()
    
    Avoid a call to dbwrap_record_get_value(), dbwrap_do_locked() already
    gave us the value.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit caef82b1fe6ae7732abcd04a3696756274c935ea
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 23 11:34:47 2019 +0200

    dbwrap: Pass "value" to dbwrap_do_locked() callback
    
    I want to reduce dbwrap_record_get_value(). It makes the caller believe it can
    make a copy of the TDB_DATA returned and that the value remains constant. It's
    not, as you can always do a dbwrap_record_store().
    
    This patch removes one requirement for getting the value out of a
    db_record via dbwrap_record_get_value(). You can still make a copy, but from an
    API perspective to me it's more obvious that "value" as a parameter to the
    callback has a limited lifetime.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a58633f64ea4e43dd3f860b4176ebae080a0a4f1
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 17:17:07 2019 +0200

    dbwrap_tdb: Return correct error from db_tdb_storev()
    
    Don't lose information to NT_STATUS_UNSUCCESSFUL
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit bc2fc51abef823090f178de7e39890bdd91f9067
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 16 15:29:28 2019 +0200

    dbwrap_tdb: Avoid includes.h
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e7f0e858e00a76976c3d84c8808e9296254b42a5
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 20 11:27:10 2019 +0100

    s3:printing: Use httpConnect2 from CUPS
    
    This fixes deprecation warnings.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Fri Nov 22 19:54:55 UTC 2019 on sn-devel-184

commit 6107c79c90fdff3fe60e0d0ef3efe57b52b21262
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 22 10:06:57 2019 +1300

    build: Do not build selftest binaries for builds without --enable-selftest
    
    Add new for_selftest option to SAMBA_BINARY() and SAMBA3_BINARY()
    
    This allows us to be much more consistent (at least in the core Samba)
    and documents clearly why the binary should not be installed.
    
    Not modified are
     - test_lp_load
     - notifyd-tests
     - gendrandperf
     - test* from examples/libsmbclient
     - dbwrap_torture
     - split_tokens
     - locktest2
     - msgtest
     - msg_sink
     - msg_source
     - versiontest
     - rpc_open_tcp
     - test_headers
    
    As these are not tested in selftest so any change would also be
    untested.  Of course they probably should be added in a different
    MR.
    
    Also not modified (because they are not tests, nor part of the
    build system) are:
     - smb2mount
     - notifydd
     - log2pacp
     - debug2html
     - smbfilter
     - destroy_netlogon_creds_cli
     - spotlight2*
     - tevent_glib_tracker
    
    These do however appear to be untested.
    
    For now, the source4 forked client tools are left unchanged:
     - smbclient4
     - nmblookup4
    
    Finally, the heimdal binaries are left as install=False as
    they are either part of the build system or end-user tools
    that we just don't want to install.  These are however tested.
    
    The motivation is commit like c34ec003b7d45aa4196ff93a0ac29694b25e5309
    and da87fa998ab71328f30bcdf5b41aee8675aee48a, which are both totally
    correct but are not needed if the selftest is not run on MacOS.
    
    There are likely other platforms or build environments where building
    our test binaries is more pain than valuable, see for example also
    https://lists.samba.org/archive/samba/2019-November/227137.html
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Fri Nov 22 11:48:59 UTC 2019 on sn-devel-184

commit f8947538b5e445ab9c1931d1f7826771ee582385
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 21 10:21:54 2019 +1300

    lib/fuzzing: Add oss-fuzz info to README.md
    
    Note that Samba has not been accepted yet, but will be soon once some requirements
    are addressed per:
    
    https://github.com/google/oss-fuzz/pull/2993
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Thu Nov 21 00:45:33 UTC 2019 on sn-devel-184

commit cc128c788562d6d86c24cbcb784e1e8fca1f06a1
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 14:22:07 2019 +1300

    lib/fuzzing/oss-fuzz: copy required libraries to the build target
    
    This is an alternative to static linking as we do not have static source
    libraries for all the things we depend on.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 4946811eb67c6e4e6abdfd64a552e7a2686feeec
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 17:17:40 2019 +1300

    lib/fuzzing/oss-fuzz: Install chrpath as we use it in the build.sh script to set -rpath
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit fbb2377d51f00617e9065a8a3daecc8f5c340ca0
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Nov 21 09:59:24 2019 +1300

    lib/fuzzing/oss-fuzz: Add build_image.sh using Samba's bootstrap tools
    
    Google's oss-fuzz environment is Ubuntu 16.04 based so we can
    just use the maintained bootstrap system rather than a manual
    package list here that will get out of date.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    Pair-programmed-by: Andrew Bartlett <abartlet at samba.org>

commit ec4f6f8fd36edfda8b949dcf7451c153f6599427
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 21 10:29:57 2019 +1300

    lib/fuzzing/oss-fuzz: add stub build.sh that will not change often
    
    This makes local development of build_samba.sh easier as it will remain in the source tree.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit f57c0238e91061698787e4a4b18fb549cc2c86f2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 14:03:13 2019 +1300

    lib/fuzzing/oss-fuzz: Add build_samba.sh for oss-fuzz
    
    We work hard to put the primary logic for oss-fuzz here, and
    where possible into waf, so that only a tiny stub needs to
    be maintained in the Google oss-fuzz repo.
    
    This will be called by build.sh (not copied directly because
    it is too easy to forget to copy in an updated version when
    doing development in the docker image).
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 92ee647858331db012db06314d98e08fe1e5eb5b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 6 12:24:18 2019 +1300

    lib/fuzzing: Use --fuzz-target-ldflags if specified
    
    This makes integration with oss-fuzz possible.  Only the fuzzer binaries should be
    linked with libFuzzer, not things like asn1_compile, so this can not be done via
    the global ADDITIONAL_LDFLAGS.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit cb240510977e60fd46ef0f35b3da77f00733829a
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Nov 1 17:18:24 2019 +1300

    build: Set fuzzer=True on fuzzer binaries
    
    This ensures that the binaries are the only binaries built
    when configured for fuzzing.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9e51bb77f82292800c6f0c0563124954d8f0c524
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Nov 15 13:34:08 2019 +0100

    s4:rpc_server: Return the status code from dcesrv_transport_session_key()
    
    Normally this returns the right status code, which normally is:
    
       NT_STATUS_NO_USER_SESSION_KEY
    
    This is consitent with the source3 samr server implmentation.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Isaac Boukris <iboukris at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Wed Nov 20 22:29:35 UTC 2019 on sn-devel-184

commit e7cab18c8b03cdc325f6e29a98b0889ab7647779
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 20 11:08:06 2019 +0100

    vfs: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Nov 20 15:23:10 UTC 2019 on sn-devel-184

commit f7f92803f600f8d302cdbb668c42ca8b186a797f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 19 17:38:50 2019 +1300

    librpc: Check for NULL pointer in value() in ntlmssp_AUTHENTICATE
    
    This allows ndrdump --validate to avoid following a NULL pointer when re-pushing
    a valid but unusual input.
    
    It also avoids an issue if the Samba server code were to provide a response
    without an EncryptedRandomSessionKey.
    
    At this stage ntlmssp.idl is not used for this, instead the packets are
    generated with msrpc_gen().
    
    Found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Nov 20 06:06:29 UTC 2019 on sn-devel-184

commit 33e9021cbee4c17ee2f11d02b99902a742d77293
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 12:14:52 2019 +1300

    selftest: Test repushing an ntlmssp AUTHENTICATE_MESSAGE
    
    This demonstrates a bug found by Douglas Bagnall using Hongfuzz and the new fuzz_ndr_X
    fuzzer where the value() evaluatuion could segfault if it was made to follow a NULL
    pointer.
    
    This also demonstrates that the --base64 mode works on file inputs.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit ac1be895d2501dc79dcff2c1e03549fe5b5a930c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 11:40:51 2019 +1300

    selftest: Confirm that NDR bugs are fixed in DCOM code
    
    Test input provided by Michael Hanselmann and found using Hongfuzz.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13875
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 1aec742575252d1efcc47a8e9023889bfb0e5709
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Oct 31 09:35:19 2019 +1300

    pidl: check the size of pulled arrays of arrays
    
    We were accidentally checking the memory just past the array instead of
    checking each member.
    
    This could have led to the size of some arrays not being checked.
    
    Found by Michael Hanselmann using Honggfuzz and an fuzzer for Samba's
    NDR layer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13877
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 536a84935ce7647f43528d6d376f6762c5e8eb78
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Oct 30 15:02:49 2019 +1300

    ndr_orpc: properly allocate empty DUALSTRINGARRAY
    
    When there is no data we still need to allocate for the terminating NULL.
    
    Found by Michael Hanselmann using Honggfuzz and an fuzzer for Samba's
    NDR layer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13875
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b1eda993b658590ebb0a8225e448ce399946ed83
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:56:14 2019 +1300

    selftest: Confirm that --base64-input and --input work and a PIDL bug is fixed.
    
    The PIDL bug is in the handling of arrays of arrays.
    
    Test input provided by Michael Hanselmann and found using Hongfuzz.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13875
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 24fa3374e041f9ad26b6f124aed0c5a61a7d551e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:55:18 2019 +1300

    python: Return the stdout when also checking error codes
    
    This will aid in checking that ndrdump behaves as expected when
    failing to parse
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 2da54d11f1e9744885558a64e72bf93b6009ae0e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:45:02 2019 +1300

    ndrdump: Still print --dump bytes after parse failure
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 0491f1727513137a5cf86073d11608b7dd8a2056
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 13:26:11 2019 +1300

    ndrdump: Invert sense of --stop-on-parse-failure into --print-after-parse-failure
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit c83ad13e5893889852cbd7d2208bf45c2b72b07c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:39:54 2019 +1300

    ndrdump: Return a different error code for ndr_pull() failures
    
    This may assist in distinguishing between "runner" and "pull" failures.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 6f0d30fd5cc921dedbc0f0741e3959b4ebc4027d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 10:00:52 2019 +1300

    ndrdump: Allow for base64-encoded input in a file and on the command line
    
    It has become customary to provide reproduction steps for fuzzing failures
    in terms of an ndrdump command line.  This allows the input to be provided
    as a argument or in a file rather than via base64 -d.  This makes reproducing
    the issue easier as everything can be put in a plaintext bug report.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit d4eabfb763b7c0ea6b112ea3a129977a68466977
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 09:59:07 2019 +1300

    ndrdump: Check for input decode failures
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 3194baaf88d78f86cbf821600cd69712e1cc02a2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 09:58:15 2019 +1300

    ndrdump: Add const
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit c90bc75df8446c79a9e251c7b07a59674d828505
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 13:46:53 2019 +1300

    ndrdump: TALLOC_FREE() on each exit path to allow running with leak detection
    
    This allows us to learn if there are other memory leaks not on the mem_ctx
    during the processing of the packet.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 8a6f1de67b1c2e925cce8fb20b6657a425cbaedb
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 13:44:02 2019 +1300

    ndrdump: print structure name when failing to setup
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit db6c12f1584215c21cd5e56bef13c6d1c8b608ce
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 20 12:17:37 2019 +1300

    ndrdump: Fix one more NTSTATUS rather than friendly ndr message
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 1af1ebe54aefd436b6ed80cb99a30282d5abd495
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 11 15:02:30 2019 +1300

    librpc: Unify packet dumping on ndr_pull() failure
    
    There were two duplicate implementations of packet dumping just for the s4 RPC server!
    
    This unifies them and makes them easier to find because they are not triggered
    from the generated server stub any more.
    
    The behaviour have unified on setting "dcesrv:stubs directory" and
    being compiled with --enable-developer.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Samuel Cabrero <scabrero at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Nov 20 02:14:56 UTC 2019 on sn-devel-184

commit 7ae46019df1c5369cfd15f99448b94e425eddcc4
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Sep 18 15:41:13 2019 -0700

    vfs_gpfs: Use update_stat_ex_create_time
    
    Make the code a bit easier to read by avoiding direct access to the
    statex struct.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Tue Nov 19 22:44:53 UTC 2019 on sn-devel-184

commit f2339fe0dde2daedfab07d51709d7584c7f00e60
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Aug 19 16:23:11 2019 -0700

    vfs_gpfs: Create fileid from filesystem metadata
    
    MacOS SMB clients require that file ids are not quickly reused when
    files are deleted and new files are created with the same name. Inode
    numbers do not satisfy that requirement, as they will be quickly reused.
    
    To address this problem, create a unique id from the available file
    system specific metadata. As that id is larger than the available 64bit,
    use a hash to generate a 64bit id for usage as fileid.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit ba5d4803bab3f8fd980a5776f375b4e57b82cc85
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Aug 19 16:06:57 2019 -0700

    vfs_gpfs: Use gpfs_fstat_x in vfs_gpfs_fget_dos_attributes
    
    This is no functional change, but allows to use additional metadata
    later on.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 2c3436f05d7f728d5993e9ac9f3de18518647a8a
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Aug 19 15:41:45 2019 -0700

    vfs_gpfs: Use gpfs_stat_x in vfs_gpfs_get_dos_attributes
    
    This is no functional change, but allows to use additional metadata
    later on.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 586ffd5b6010b833b4d5b743f69b1629c36b6e7d
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Aug 19 15:35:18 2019 -0700

    gpfswrap: Add wrappers for gpfs_fstat_x and gpfs_stat_x
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit b68b7d51681955d925b746173ad45f4319171522
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 14:29:52 2019 +0100

    vfs: Fix CID 1455914 Unused value
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Nov 19 17:37:42 UTC 2019 on sn-devel-184

commit 55b0011aaf6b9c46bece711089d89bb1a6317cfa
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 14:23:52 2019 +0100

    smbd: Fix CID 1455912 Logically dead code
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit b9e74928ab99a169c76dcd3b401da70cbd1b3985
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 14:20:14 2019 +0100

    winbind: Fix CID 1455915 Resource leak
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 51f16ec578987506a2ea07401b287b731c08c3a1
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 19 14:17:38 2019 +0100

    librpc: Fix CID 1455913 Use after free
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d2b5aa16500835471692c8e1fe6cd1584da89785
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Nov 18 15:00:03 2019 +0100

    whatsnew: announce removal of DES encryption type in Kerberos
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Isaac Boukris <iboukris at samba.org>
    Autobuild-Date(master): Tue Nov 19 16:12:39 UTC 2019 on sn-devel-184

commit 389d1b979b8a4235033a298a56e6c10294a515fe
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sat Nov 16 23:03:34 2019 +0100

    heimdal: do not compile weak crypto
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a53fa8ffe3e36f7921baf5d31a1052747f90aa7d
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sat Nov 16 22:46:19 2019 +0100

    selftest: allow any kdc error in mitm-s4u2self test
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 151f8c0f31d3d17b9418db3793ec14ba7dbf2143
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Nov 12 12:00:34 2019 +0100

    selftest: mitm-s4u2self: use zlib for CRC32_checksum calc
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 88bf0c572008ac9bc84f334e4c9373817499486b
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Sep 16 15:17:08 2019 +0300

    machine_account_secrets: do not generate single DES keys
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 80f1901de0c34ba0f9993d304ccc193b88e89693
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 24 19:04:51 2019 +0300

    kerberos_keytab: do not add single DES keys to keytab
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 982aa328f6502f28cc117e15bf0f936a132ddeca
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 24 18:32:37 2019 +0300

    password_hash: do not generate single DES keys
    
    Per RFC-6649 single DES enctypes should not be used.
    
    MIT has retired single DES encryption types, see:
    https://web.mit.edu/kerberos/krb5-1.12/doc/admin/advanced/retiring-des.html
    
    As a workaround, store random keys instead, making the usage of signle DES
    encryption types virtually impossible.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e8015d8a3485092e12d610e565c8c4ee2be937b6
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 24 18:53:34 2019 +0300

    kdc/db-glue: do not fetch single DES keys from db
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit ad9016d579aa3f6d53c656fd539d821ccfbf592f
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 24 12:20:05 2019 +0300

    kerberos: remove single DES enctypes from ENC_ALL_TYPES
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 13655e59e2c76561155ded0f65a46ce34129dd7b
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 31 19:41:46 2019 +0100

    selftest: exclude msDS-SupportedEncryptionType in ldapcmp
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Pair-Programmed-With: Alexander Bokovoy <ab at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 41b40f0e557608403ff5b19704fd5363d149444a
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Nov 6 09:17:52 2019 +0100

    selftest/remote_pac: remove test_PACVerify_workstation_des
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14202
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 42ac80fb46cfb485e8c4a26d455fa784fdd1daed
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Sat Nov 16 08:54:42 2019 +1300

    ndr: Include the caller location in ndr_{pull,push}_error() messages
    
    This should aid in debugging NDR parse failures.
    
    Use the ABI bump to again exclude ndr_table_misc incorrectly
    added in ABI 0.2.1.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Nov 19 14:47:46 UTC 2019 on sn-devel-184

commit 183da1f9fda6f58cdff5cefad133a86462d5942a
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 18 16:02:39 2019 +1300

    witness.idl: Change array type in IDL for the print function
    
    It is important that the generated print function checks r->messages
    before de-referencing r->messages[num] as r->num can be non-zero
    while r->messages is NULL.
    
    There is not witness server in Samba and print functions are only
    used during debugging and ndrdump in any case.
    
    The change in the IDL does not change the header and the IDL
    function is already nopull,nopush so only the print function changes.
    
    Found by Douglas Bagnall using Honggfuzz and a new fuzzer for
    Samba's NDR layer.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit c34ec003b7d45aa4196ff93a0ac29694b25e5309
Author: Robert Scott <code at humanleg.org.uk>
Date:   Sat Nov 16 17:46:51 2019 +0000

    utils: only compile test_oLschema2ldif if fmemopen exists
    
    in the vein of da87fa998ab71328f30bcdf5b41aee8675aee48a
    
    Signed-off-by: Robert Scott <code at humanleg.org.uk>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Tue Nov 19 06:12:29 UTC 2019 on sn-devel-184

commit 71816984c31cd1a392355afdbfdadb0da2d05765
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 16:33:23 2019 +0100

    s4:lib:tls: Fix cert and privkey types
    
    ../../source4/lib/tls/tlscert.c:42:2: warning: ‘gnutls_x509_crt’ is
        deprecated [-Wdeprecated-declarations]
       42 |  gnutls_x509_crt cacrt, crt;
          |  ^~~~~~~~~~~~~~~
    ../../source4/lib/tls/tlscert.c:43:2: warning: ‘gnutls_x509_privkey’ is
        deprecated [-Wdeprecated-declarations]
       43 |  gnutls_x509_privkey key, cakey;
          |  ^~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e19b115dd27891896364f5e943b0ce7fcc89344e
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 10:29:55 2019 +0100

    libcli:auth: Remove unused E_md5hash()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4199d1040f09b5d95522d0cbdbaeec78b7d7b9a6
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 10:28:59 2019 +0100

    s3:winbind: Replace E_md5hash() with GnuTLS calls
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 10499507c4fd91751898696b866ce32b1e38f605
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 10:24:56 2019 +0100

    s3:winbindd: Replace E_md5hash() with GnuTLS calls
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a377214dce2e9d71f880949fe745d799c75f57a9
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 18 10:21:06 2019 +0100

    s3:rpc_server: Replace E_md5hash() with GnuTLS calls
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 93b9fc3da86a09be8244859ee62063b75e002b23
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Nov 15 13:38:43 2019 +1100

    build: add missing crypt dependency for auth4_unix
    
    Commit dc5788056bc removed crypt library from replace.  This breaks the
    build on fedora 30 ppc64.
    
      [2439/3956] Linking bin/default/source4/auth/ntlm/libauth4-samba4.so
      /usr/bin/ld: source4/auth/ntlm/auth_unix.c.5.o: in function `password_check':
      auth_unix.c:(.text+0x7e0): undefined reference to `crypt'
    
    crypt library is required to build ntlm auth_unix.c.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Tue Nov 19 04:47:47 UTC 2019 on sn-devel-184

commit d6fbfb276ce89ad40f47784300fb99cee9d4aac9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 16:52:48 2019 +1300

    lib/fuzzing: Free memory after successful load in fuzz_tiniparser
    
    Otherwise we have a memory leak and so fail the Google oss-fuzz check_build test.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Nov 18 21:02:52 UTC 2019 on sn-devel-184

commit 43bc0b2c763284ec63ca1e750602f6a9b354f9ae
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 15:08:18 2019 +1300

    lib/fuzzing: Avoid NULL pointer de-ref from 0-length input
    
    fmemopen() does not like 0-length input.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4aea5c0972de53c143530cc42ef6d3b8cfafb973
Author: Uri Simchoni <uri at samba.org>
Date:   Sat Nov 16 23:54:31 2019 +0200

    tevent: Release tevent 0.10.2
    
    * Upgrade waf to version 2.0.18 to fix a cross-compilation issue
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Uri Simchoni <uri at samba.org>
    Autobuild-Date(master): Mon Nov 18 11:44:08 UTC 2019 on sn-devel-184

commit 28e4ac0e7ae965745fde628d7a675e337aa45341
Author: Uri Simchoni <uri at samba.org>
Date:   Sat Nov 16 23:52:33 2019 +0200

    tdb: Release tdb 1.4.3
    
    * Upgrade waf to version 2.0.18 to fix a cross-compilation issue.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3e2eafeb4460c8b6b3c3dbf64bbc967ae1d601d0
Author: Uri Simchoni <uri at samba.org>
Date:   Sat Nov 16 23:45:51 2019 +0200

    talloc: Release talloc 2.3.1
    
    * Upgrade waf to 2.0.18 to fix a cross-compilation issue
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e856877ef88bf273cbf814ff17abad900ba7ea27
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Sat Nov 16 21:25:11 2019 +1300

    ndrdump: avoid use after free
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Sun Nov 17 23:54:11 UTC 2019 on sn-devel-184

commit 816869ecea06b0b936e3ead4074bb754ee8650ca
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 15 19:25:54 2019 +1300

    ndrdump: Use human-readable strings for NDR decode errors
    
    These make much more sense than the NTSTATUS values they can be forced
    to map to.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit b3bdb17a35380237f7b46cc2b453b6b6b7c7a4f8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 14 13:49:48 2019 +1300

    selftest: Test fix for ndrdump of structures by number
    
    This requires that misc.GUID not move in the IDL, so a comment is added.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 2bb642d98e1c26064907f8f671c1de864f2d8c2f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Nov 14 13:14:08 2019 +1300

    ndrdump: correctly find the public strict by number
    
    We were finding a function that happened to have the same ordinal
    number.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f1fa0d3b9dfef17a5129b53695fa454f1a8b8b68
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 11 13:53:33 2019 +1300

    librpc: Use the fact that file_save() now uses O_EXCL in dcerpc_log_packet()
    
    This avoids a race with file_exist() and demostrates a better
    way to use this function.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Nov 15 18:48:27 UTC 2019 on sn-devel-184

commit 5e63e54f589b25af550f0d4e28e3c28e0a337c0d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 11 13:52:22 2019 +1300

    lib/util: change file_save_mode() to use O_EXCL
    
    Almost all the callers are debug tools or developer debugging aids
    and these callers clearly expect to create a new file.
    
    Unchanged in behaviour is:
     - TLS certificate creation.  This already confirms the files do no exist
       prior to generation.
    
    These will now no longer overwrite the given filename
     - net ads pac save
     - net eventlog export
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 55b2cb47a9701376aa9e844390c8c4ee2d7fa6e9
Author: Björn Baumbach <bb at sernet.de>
Date:   Fri Nov 15 13:21:48 2019 +0100

    s3-build: add missing gnutls dependency
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8e8313b2b57f3e760876feb5b732d1d2774baa18
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 15:41:47 2019 +0100

    third_party: Update nss_wrapper to version 1.1.7
    
    This adds missing support for Address Sanitzer.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Nov 14 23:50:06 UTC 2019 on sn-devel-184

commit 4320196977012e02765f4804070438149d858e22
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 13 16:29:17 2019 +0100

    lib: Fix an error path memleak in schannel_get_creds_state()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b1143a0c7e9080996bb47b52df9124d296e4345b
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 13 16:02:11 2019 +0100

    vfs: Use dbwrap_delete() in acl_tdb_delete()
    
    Use the wrapper function that's already available for exactly this
    purpose.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0c2a706a11c0ac89476c07f7d7d2554ffd7c342b
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 13 16:02:11 2019 +0100

    vfs: Use dbwrap_store() in store_acl_blob_fsp()
    
    Use the wrapper function that's already available for exactly this
    purpose.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5852bb96584afab61cf2635aa25033fd5b9f3a15
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Nov 13 15:59:54 2019 +0100

    vfs: Use direct struct assignment in store_acl_blob_fsp()
    
    2 lines less code
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f38077ea5ee0a8d3d18970e3e183c3ee516fa121
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 29 21:19:05 2019 +0000

    pidl: Handle obtaining objects from a fixed-size array
    
    Previously we would assume the array head was the talloc context
    however this is not the case if the array is a fixed size inline array
    within the parent struct.
    
    In that case the overall object's talloc context is the correct
    context to reference.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Pair-programmed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Thu Nov 14 17:36:49 UTC 2019 on sn-devel-184

commit 1261894ecaebc1a3340c42e818be25caa69f6364
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Oct 29 11:58:32 2019 +1300

    pidl/python: allocate objects with ref pointers
    
    Struct members that are marked as ref pointers need to have an object
    allocated for them.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>

commit 7e19779b66d7329e4208eaa5801cec0b6feb3754
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Oct 29 22:11:41 2019 +0000

    pytests/segfault: pidl inline arrays
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit 272e20adbbbaebd7bbf94c79f44f1ff42d2831d8
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Tue Oct 29 12:02:04 2019 +1300

    pytests/segfaults: dcerpc ref elements segfault
    
    These are just a couple of examples.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit 4dd725b1b599968fb787c93f6eb3a42af007b21c
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Thu Oct 24 10:41:28 2019 +1300

    pytests: rpc echo should not segfault
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit 220cf67776f16467488805ecd6d1905c708eaa17
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Jul 24 17:50:35 2019 +1200

    s4/rpc/dcerpc_connect: no crash on NULL dest_host
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Noel Power <npower at samba.org>

commit 963a639101f4c55467e33667a698fffb350a931f
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 18:32:49 2019 +1100

    ctdb-tests: Add tests for cmdline_add() api
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Thu Nov 14 12:03:46 UTC 2019 on sn-devel-184

commit e469d6c1191ab9fa78e1ced6d7aa7b37dce7c5a9
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 17:32:50 2019 +1100

    ctdb-common: Add api to add new section/commands to cmdline
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 977a6f7fad8d2985e8e898bd8dc7d3d376164e9d
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 17:29:26 2019 +1100

    ctdb-common: Change cmdline implementation to support multiple sections
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 7a008c6b74e559a3e677257be3ea57a5821e3e9c
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 17:05:53 2019 +1100

    ctdb-tests: Update cmdline tests for section name
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b2b24c91fae30edf797ed30e3c45c259aee00853
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Nov 11 17:01:43 2019 +1100

    ctdb-common: Add section to group commands in cmdline
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 29948d7b1eb1337c7e3d91dc53bb3e1e42de6dd3
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Jul 9 15:37:52 2018 +1000

    ctdb-common: Generate usage message from cmdline_parse()
    
    If any of the option parsing or command parsing fails, generate usage
    message.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 0361a26e395723296899c3d48cff86d532372710
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 14 11:16:09 2019 +1300

    libcli:auth Check return code of netlogon_creds_aes_encrypt()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Nov 14 09:25:36 UTC 2019 on sn-devel-184

commit 32e75bb4cca994af80bb8440009446e4a0ff5d40
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:13:53 2019 +0100

    libcli:auth: Check return code of netlogon_creds_step_crypt()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 05f59cbcf803d57ab41b4c7fa4f81da50cd02cd6
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:12:41 2019 +0100

    libcli:auth: Check return code of netlogon_creds_step()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit a64a5b7e17d80a4363774d4e35d3ee676ecf426d
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:06:20 2019 +0100

    s4:librpc: Check return code of netlogon_creds_client_authenticator()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0906848936c410f49b26f7688df7ce1a0e1097f5
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:06:20 2019 +0100

    libcli:auth: Check return code of netlogon_creds_client_authenticator()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d3fffca5e9ab45b43fa3f460ad6051356c9a00a9
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 10:06:20 2019 +0100

    auth:pycreds: Check return code of netlogon_creds_client_authenticator()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7c7dc855ba982a37cb5040752ca473aab3446d6c
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 09:52:53 2019 +0100

    libcli:auth: Return NTSTATUS for netlogon_creds_client_authenticator()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0ed92e3e60684bfb02b01479d985535d525a5be5
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 09:44:32 2019 +0100

    libcli:auth: Check return status of netlogon_creds_first_step()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e4ae1ba451d408b3b5c74d303493cb7c38e6e1c8
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 09:41:18 2019 +0100

    libcli:auth: Check return status of netlogon_creds_init_64bit()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 2c21cd6d49d56611acb2f364473d8c2e73e74545
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 09:39:19 2019 +0100

    libcli:auth: Check return value of netlogon_creds_init_128bit()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit fbfb11b0f7ebd69cc4b1b545b398a367720d5473
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 14:01:46 2019 +0100

    s4:torture: Remove calls to gnutls_global_(de)init() in backupkey test
    
    This is handled by the gnutls library constructor/destructor.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0e159b725ecf2f9a6d026170253e2d1eb73ed0c2
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 13:59:30 2019 +0100

    s4:lib: Remove gnutls_global_(de)init() from libtls
    
    This is handled by the gnutls library constructor/destructor.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit afb5cb669ceeb68bf93ef8db07abcc5d424580cd
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 13:57:53 2019 +0100

    s4:rpc_server: Remove gnutls_global_(de)init()
    
    This is done by the gnutls library constructor/destructor.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3db2ca2dcf367a6c57071a76668d19f3cbf62565
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 12:52:44 2019 +0100

    libcli:auth: Check return code of SMBOWFencrypt_ntv2()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit dc75a5f27eb32caf2f2adc289bc82fb0f8042cb3
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 12:48:18 2019 +0100

    libcli:auth: Return NTSTATUS for SMBOWFencrypt_ntv2()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0914824684b3a69a9926402d447e1d5781f2ec02
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 12:45:04 2019 +0100

    libcli:auth: Check return codes of SMBsesskeygen_ntv2()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 045b9eb3f088c66e20bd19e144a2ce3597328d93
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 13 12:40:02 2019 +0100

    libcli:auth: Return NTSTATUS for SMBOWFencrypt_ntv2()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14195
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 83b1c21dd0fb932b81491065067a973398bdca91
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 13 15:51:08 2019 +1300

    librpc: Do not return an NDR table for a zero GUID
    
    The source3 RPC server will do a lookup by GUID and should
    not be returned a table for a zero GUID.
    
    Thankfully such a pipe would also need to have been registered
    but regardless this is not a determinsitic result so should
    be avoided.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e45feaf28da27653e9df36c7c50cbd54a792a2aa
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Nov 12 12:14:18 2019 +1100

    ctdb-tcp: Simplify freeing of transport data on shutdown
    
    The type-checking is superfluous and gets in the way of readability.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Thu Nov 14 03:45:44 UTC 2019 on sn-devel-184

commit 750f3938e4fcd6743954db6b1132751a90ee6107
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Nov 12 12:12:46 2019 +1100

    ctdb-daemon: Rename ctdb_context private_data to transport_data
    
    This gives a casual reader a useful clue.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 53f8492caafa8556d0c2d3f272d08ce5ce098c25
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Nov 12 12:04:22 2019 +1100

    ctdb-daemon: Rename ctdb_node private_data to transport_data
    
    This gives a casual reader a useful clue.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a6d99d9e5c5bc58e6d56be7a6c1dbc7c8d1a882f
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Nov 7 15:26:01 2019 +0100

    ctdb-tcp: Close inflight connecting TCP sockets after fork
    
    Commit c68b6f96f26 changed the talloc hierarchy such that outgoing TCP sockets
    while sitting in the async connect() syscall are not freed via
    ctdb_tcp_shutdown() anymore, they are hanging off a longer-running structure.
    Free this structure as well.
    
    If an outgoing TCP socket leaks into a long-running child process (possibly the
    recovery daemon), this connection will never be closed as seen by the
    destination node. Because with recent changes incoming connections will not be
    accepted as long as any incoming connection is alive, with that socket leak
    into the recovery daemon we will never again be able to successfully connect to
    the node that is affected by this leak. Further attempts to connect will be
    discarded by the destination as long as the recovery daemon keeps this socket
    alive.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
    RN: Avoid communication breakdown on node reconnect
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 231397f45ee7a328ea41214b1367632298339e44
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Nov 1 12:33:23 2019 +0100

    smbd: Make share_mode_do_locked() pass TDB_DATA instead of a record
    
    No callback used (and should not use) the record directly, this is all
    handled within share_mode_lock.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Nov 13 21:41:09 UTC 2019 on sn-devel-184

commit 5343cec5f0a5531af85d72021dba30c31a4a3f1b
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 14:24:58 2019 -0700

    gitlab-ci: Run samba-fileserver-heimdalkrb5
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Wed Nov 13 19:14:25 UTC 2019 on sn-devel-184

commit 2efc243f1ad09eae46f6f99fb0646ecd4356c3f9
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 13:49:55 2019 -0700

    bootstrap: Add heimdal-multidev for Debian and Ubuntu
    
    This is required for testing the build with the
    configure option --with-system-heimdalkrb5.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 7965a204d68196acddf553959bb3407125baf31d
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 13:45:55 2019 -0700

    autobuild: Add test for build with system heimdal library
    
    The configure option --with-system-heimdalkrb5 requires --without-ad-dc.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 85d23236200dbe013c09a4f23d982ef1baac240d
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Nov 11 13:37:25 2019 -0700

    krb5_plugin: Fix developer build with newer heimdal system library
    
    Newer heimdal versions provide a different locator plugin interface. The
    function pointer for the old method has been renamed. Use an ifdef to
    initialize the correct pointer.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1aef796e302058ad3327613964fa89abaf940c1c
Author: Christof Schmitt <cs at samba.org>
Date:   Mon Nov 11 13:08:28 2019 -0700

    krb5_plugin: Use C99 initializer
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 15ddd95d94688ed742a2965c4b269d7c84e2d858
Author: Isaac Boukris <iboukris at samba.org>
Date:   Sat Nov 9 15:36:32 2019 +0000

    selftest: system-heimdal: workaround upstream "host" canon bug
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Isaac Boukris <iboukris at samba.org>
    Reviewed-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit be2d90b60d19eca408b60fe4e1b49f9b418f1b97
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 13:15:48 2019 -0700

    wscript: Fix build with system heimdal
    
    Ubuntu has heimdal include files in /usr/include/heimdal. As the
    kerberos include files are pulled into many files through indirect
    includes, add the discovered include paths to EXTRA_INCLUDES to
    always have them available.
    
    Also set USING_SYSTEM_KRB5 when enabling the system heimdal build,
    to correctly handle the inclusion of the krb5-types.h file.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14179
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 63f8d7732756b8a8452ab22ca205a29b27b7d1f1
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Oct 30 14:57:02 2019 -0700

    bootstrap: Remove nettle-devel from package list
    
    nettle is required as dependency for newer gnutls libraries. The gnutls
    development package already depends on the nettle development package,
    no need to explicitly list it.
    
    Signed-off-by: Christof Schmit <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 816205027a12d16b5de7c1fd78b4bed468a94fbb
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Tue Nov 12 14:14:53 2019 +1100

    ctdb-ib: Fix build errors for infiniband transport
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Wed Nov 13 13:31:10 UTC 2019 on sn-devel-184

commit 86e418f992e1bb1faaa099567e0f80f280d391b6
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 12 17:17:02 2019 +1300

    build: Refuse to build if ADDITIONAL_LDFLAGS or ADDITIONAL_CFLAGS do not work
    
    This avoids these being silently ignored.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Nov 13 10:29:00 UTC 2019 on sn-devel-184

commit dc5db1e8d819f442060015bc93a132cc4b3f7ad9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 14:42:24 2019 +1300

    heimdal_build: Recurse to bld.SAMBA_BINARY()
    
    This reduces a little of the duplication added when it was thought
    that having a distinct waf wrapper on heimdal might allow this to be
    ported upstream.
    
    It will also streamline building a dedicated fuzzing mode in Samba.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 92ce387ed0e02bc3ebc673bcfd7ffbb55c04f57d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 17:07:44 2019 +1300

    build: Remove workaround for missing os.path.relpath in Python < 2.6
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit dc5788056bcbccdc320aeaad4f35f726632a91a4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 6 15:44:45 2019 +1300

    build: Only link against libcrypt where needed
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 01bb7cff023719705d7442ae497c52a3f797edf4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 12 12:11:53 2019 +1300

    ndrdump: check bounds when passed functions/structs by integer
    
    The function or struct number should be >= 0 ans the underlying
    number it is compared to is uint32_t.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-programmed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Wed Nov 13 01:55:33 UTC 2019 on sn-devel-184

commit 3b9e983b648bd3738d8a5e1d53f29cd21ba63387
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 5 16:15:38 2019 +1300

    ndrdump: Fix new "struct" feature
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 78521577eb11d2d601768f3c521549793341a450
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:15:26 2019 +1300

    pidl: Generate compatability wrappers for ndr_print functions
    
    This creates wrappers that are compatible with the functions called by
    ndrdump which have an extra "int flags" parameter for NDR_IN and
    NDR_OUT.  This will make ndrdump of public structures work again.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 1bd1ae0593a233465cbd5c381199bd0fc2cb476f
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:19:29 2019 +1300

    pidl: Generate the trailing ndr_table even if the UUID is not set
    
    This allows ndrdump to dump many more public structures because most
    of these are not in files with a UUID as they are not RPC protocols.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 7299b9ba907d3c55897453ad2102500b94a21b82
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Nov 7 11:30:52 2019 +1300

    librpc: Allow registration of ndr tables with a zero UUID
    
    This helps ndrdump find public structures to dump
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 1b6ae21fff9a649d451c30df90f167c33452975c
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:20:19 2019 +1300

    build: Prepare for pidl to generate ndr_table entries for more IDL
    
    These IDL files will soon create ndr_table entries so need to be
    linked into the ndr-table subsystem.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit dd8dfa16dea73da3e07c0e84c308f74246cc5d13
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:12:02 2019 +1300

    s3-build: Skip building the ndr_table at the tail of ndr_libnetapi.c
    
    This is not a real protocol and all the functions are set to nopull,nopush
    but do not supply replacement functions.
    
    This is the best was I could find to skip compiling the table as otherwise
    it would point to undefined functions.
    
    This does not happen until we generate the ndr_table for idl files without
    a UUID, but we will shortly do that.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit dddef1b8224a2977c6e8b56af83429b36d6119ad
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 12:17:41 2019 +1300

    pidl: Allow the compilation of the ndr_table to be skiped
    
    libnetapi.idl defines a large number of functions a nopull,nopush and
    no replacement is provided.
    
    This will allow the ndr_table to be generated for all other IDL files
    that may have public structures that could usefully be dumped by
    ndrdump.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 5e0442efbe738c1e1d12a237b4c0abe8a472a176
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Nov 6 15:33:24 2019 +1300

    build: Allow warning on compile of libnetapi PIDL
    
    This not-protocol only uses the print functions, but this means some other functions
    are now unused, and as this is a special case it is better to just allow warnings
    here.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit e45e342624da1b7f5df42c34c6fdccf32fc7b0e2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 11:52:27 2019 +1300

    librpc: Do not include the ndr_table for libnet_join.idl and libnetapi.idl in the global list
    
    These are not wire protocols, there are no structures to parse.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 88c8cd7a1e7bc48a758bd00e91ca58ca91eed9d0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 4 11:51:11 2019 +1300

    librpc: Do not place the ndr_table for windows_event_ids.idl in the global list
    
    This is just a list of event IDs, there are no structures to parse.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-progammed-with: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 88373c472c52ddc1191c1c20e74bff7776d0e805
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Nov 11 16:39:13 2019 +1300

    selftest: Add expected-output tests for the ndrdump struct mode
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit dfbb3049585186230a0d28a581ad22de7276614c
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Wed Oct 30 03:05:22 2019 +0000

    ndrdump: add --stop-on-parse-failure
    
    If a data stream fails to parse as an NDR object, the default ndrdump
    action is to try to print those structures anyway, resulting perhaps in
    a NULL dereference. Sometimes you don't want to see that because it isn't
    very interesting and makes it harder to distinguish a crash in the parse
    routines. So --stop-on-parse-failure will skip the print and validate
    stages altogether if the parse failed.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>

commit a106ceb7bfe588b1888001fbba5f500c2d33e5f8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 5 09:46:13 2019 +1300

    librpc: Match interface name and file name for bkupblobs.idl
    
    This helps generate fuzzers for this IDL.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 666dbc61f1a32f78a4096373e7b94733e06bd86d
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Nov 5 10:12:01 2019 +1300

    librpc: Match interface name and file name for winsrepl.idl
    
    This helps generate fuzzers for this IDL.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 8a627b5d65b65e926f739272bb8f8191cd1a25b3
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Nov 1 17:18:37 2019 +1300

    librpc: Fix typo in "quota" name in IDL
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 3fea05e01f845588eb0de63af435bfec670593be
Author: Volker Lendecke <vl at samba.org>
Date:   Mon May 27 11:24:14 2019 +0200

    smbd: Remove write cache
    
    Since this was written, our write path has changed significantly. In
    particular we have gained very flexible support for async I/O, with the
    linux io_uring in the pipeline. Caching stuff in main memory and then
    doing a blocking pwrite nowadays does not belong into the core smbd
    code. If someone wants it back, it should be doable in a VFS module.
    
    Removes: "write cache size" parameter.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Nov 13 00:20:55 UTC 2019 on sn-devel-184

commit a0aaf5c3345239959221d6c2e9cd949b8ccdf233
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:13:52 2019 +0100

    lib: Remove unused file_id_string()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Nov 12 22:18:40 UTC 2019 on sn-devel-184

commit fea35840b0504ac2fc8a3d85cb044f3d9fb345dd
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:11:38 2019 +0100

    smbd: Use file_id_str_buf() in share_mode_cleanup_disconnected()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6fe211c85d93910960438c48b86614baac7db7de
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:08:15 2019 +0100

    smbd: Use file_id_str_buf() in share_mode_memcache_fetch()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0d246a156da8047b86a8cfab00f5760a840eec60
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:05:41 2019 +0100

    smbd: Use file_id_str_buf() in share_mode_memcache_store()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c229c0508bc64bb6e2d8d29be7a7bde58d86c86e
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 21:01:12 2019 +0100

    lib: Remove unused file_id_string_tos()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 64349ce7176c7079ffaace037c1a58a0f24abf29
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 20:58:26 2019 +0100

    torture3: Use file_id_str_buf() in print_brl()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 79291056c5b550c0afa8e4089758ad5e44e15cf0
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 20:57:14 2019 +0100

    smbd: Use file_id_str_buf() in linux_release_kernel_oplock()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f7dc0334810723de5321f021e2d2be9d85a73939
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 20:55:29 2019 +0100

    smbd: Use file_id_str_buf() in linux_oplock_signal_handler()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b0a486fabefaabd63cd2838e503360c0865e21dc
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 18:53:19 2019 +0100

    smbd: Use file_id_str_buf() in scavenger_add_timer()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0dd11a83dc2d4487315f6654f57e7a43ba6ef98e
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 18:32:07 2019 +0100

    smbd: Use file_id_str_buf() in file_find_dif()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 420cb1778d8bb7233465459f269002b254049def
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 18:30:37 2019 +0100

    smbd: Use file_id_str_buf() in scavenger_timer()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 215e7f1fe414c38bbde1c896c16ab21f98943ef1
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 9 18:27:30 2019 +0100

    smbd: Use file_id_str_buf() in scavenger_schedule_disconnected()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1f5ea9d1d523cdf40c6b2c370abc7f9fa335f5cf
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Nov 7 09:16:44 2019 -0800

    s3: smbd: smb2 cleanup - restructure smbd_smb2_request_pending_timer() encrypt code to look the same as smbd_smb2_request_reply().
    
    This makes code changes in both (if needed) much easier
    to spot.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit c133a1fd6765908e49e2b1808818b515c987ab72
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Nov 7 09:13:12 2019 -0800

    s3: smbd: smb2 cleanup - remove variable tf_len - this is a constant SMB2_TF_HDR_SIZE.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit eae1a45d09ef54dd6b59803eedca672ae9433902
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Nov 7 12:02:13 2019 -0800

    s3: smbd: SMB2 - Ensure we use the correct session_id if encrypting an interim response.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14189
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 30e8f513a8bae58d7d4e88fad8f8d5497076c553
Author: David Mulder <dmulder at suse.com>
Date:   Fri Nov 8 17:10:47 2019 +0000

    Detect when command line max protocol < min protocol
    
    Due to the increased default minimum protocol
    level to SMB2, some users notice that
    specifying smbclient -m NT1 fails with
    NT_STATUS_CONNECTION_DISCONNECTED, with no SMB
    traffic on the wire. Report when the max protocol
    is set less than the min protocol.
    
    Signed-off-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Noel Power <npower at samba.org>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Tue Nov 12 17:52:28 UTC 2019 on sn-devel-184

commit 6cf443ab1f9d0d939d721f58386669202d2fb56e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Oct 25 06:59:45 2019 +1300

    s4-libcli: Remove unused header from composite/composite.c
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14170
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Sun Nov 10 22:27:47 UTC 2019 on sn-devel-184

commit 74533b151825416d98912ca8d291637324ccc499
Author: Heiko Baumann <heibau at gmail.com>
Date:   Tue Sep 3 16:30:24 2019 +0200

    Make sure backup temp directory gets deleted on exception
    
    This fix ensures that the samba-tool backup temp directory is removed
    if an exception occurs (e.g. LDAP_INVALID_CREDENTIALS).
    
    Signed-off-by: Heiko Baumann <heibau at gmail.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit f9eaf4dc713bab48703a053c9446b6becabe18dc
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 8 13:30:18 2019 +0200

    dns: Always return SOA record for records we should know
    
    Regression introduced by commit 4b54e14b7cf456e327b176b365e8471e0899210b,
    where the number of returned records is not set by talloc_array_length
    when the record is not found.
    
    Found by DELL EMC at SDC SMB3 plugfest trying to perform a secure DNS
    update.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Samuel Cabrero <scabrero at samba.org>
    Autobuild-Date(master): Fri Nov  8 12:31:30 UTC 2019 on sn-devel-184

commit 8dbb8643499c495474f28071750cbfc2da5b60f0
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 8 13:29:28 2019 +0200

    dns: Extend DNS tests to check the SOA record is always returned
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f5f89b1b990a3de0e9366beef81cf1a2ce8374da
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Nov 7 12:12:45 2019 +0100

    ctdb: Use TALLOC_FREE() in a few places
    
    We have a macro for NULLing out the pointer
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Fri Nov  8 01:35:11 UTC 2019 on sn-devel-184

commit 8846887a55b0c97a1639fc6ecb228941cf16b8f2
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:46:38 2019 +0100

    s3:printing: Fix %J substition
    
    print_run_command() uses lp_print_command() which internally performs basic
    substition by calling talloc_sub_basic(). As a result. any of the variables in
    the "basic set", including "%J" are already substituted.
    
    To prevent the unwanted subtitution, we declare all affected configuration
    options as const, which disabled the basic substition.
    
    As a result print_run_command() can run manual substitution on all characters,
    including %J, in the variadic argument list *before* calling lp_string() to run
    basic substition which we had disabled before with the const.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Nov  7 16:01:21 UTC 2019 on sn-devel-184

commit ede00779ab2d881e061adb9d861879e8c68e272b
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:03:31 2019 +0100

    s3:printing: add a DEBUG statement
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 41ab92b62fbf029374b89f9d0ddf7578981f37cf
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 11:57:39 2019 +0100

    s3:lib: factor out talloc_sub_advanced() from talloc_sub_full()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 4736623c24503b3ca09c76c9dbb134ef833b2f80
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:45:44 2019 +0100

    s3: rename talloc_sub_advanced() to talloc_sub_full()
    
    We currently have the following substitution functions:
    
      talloc_sub_basic()
      talloc_sub_advanced()
    
    talloc_sub_basic() currently substitutes a subset of talloc_sub_advanced().
    
    We'll need a function X that only substitutes what talloc_sub_advanced()
    substitutes *without* what talloc_sub_basic() does.
    
    To get there rename talloc_sub_advanced() to talloc_sub_full(). A subsequent
    commit will then bring back talloc_sub_advanced() as described above.
    
    Examples with fictional replacement letters A and B. Currently:
    
      talloc_sub_basic:    A
      talloc_sub_advanced: AB
    
    New:
    
      talloc_sub_basic:    A
      talloc_sub_advanced:  B
      talloc_sub_full:     AB
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a591de28659919d2afd7ed55106cded6a0d9ab35
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 10:19:13 2019 +0100

    s3: remove unused function standard_sub_advanced()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 81ae199bb72886f2f1ed87b22b4c75b6b99c72f6
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:44:45 2019 +0100

    s3: replace standard_sub_advanced with talloc_sub_advanced in one place
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit dcb555c06a6341871b691dab3758e7de04110282
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 31 12:43:25 2019 +0100

    s3:printing: fix a long line
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13745
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 18cc62b98d47c349d542b435e603d8de72a67200
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 5 21:56:44 2019 +0100

    vfs: Use file_id_str_buf() in vfs_delay_inject_brl_lock_timer()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Nov  6 21:58:52 UTC 2019 on sn-devel-184

commit 2d5aba4d8633d9cf62f6ed7847dad9ebc41f46ce
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Nov 5 21:54:21 2019 +0100

    smbd: Use struct initialization instead of ZERO_STRUCT()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 001371f45e5a069aa9cfaef9c35dc47b371935a8
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    vfs: Use file_id_str_buf() in smb_full_audit_file_id_create()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3f80b8abac3e4a59371017b841cc43dfe486f18e
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in set_write_time()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d04581bfe926013bda2df2beefd836555e53e8f9
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in rename_open_files()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1bbdae2234487393e4a964d59b4d772a8a758eff
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in contend_level2_oplocks_begin_default()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 56f93f21114588e7cef8cf837a57ceaad9f9b8bc
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in process_kernel_oplock_break()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6018cc5a078fbe042910d6bb07850c21d2ffd923
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in process_oplock_break_message()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 75962acade60530ff99663ffbc1ca9d0eb79ccc0
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in initial_break_processing()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6e521461c5d57ddf01904e75b80602d662da9057
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in downgrade_lease()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8dd7b129138d9b89368eb0b5f8f04300672f2e98
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in downgrade_oplock()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c7731649fde2b2336bba3de7e38a9281b3330414
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Nov 4 07:39:48 2019 +0100

    smbd: Use file_id_str_buf() in set_file_oplock()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d6f952f4c7ca03829d199a3cf9c5b2998146462e
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Nov 3 18:52:07 2019 +0100

    smbd: Use file_id_str_buf() in set_file_oplock()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2651463e19cac9cd346e282b9b6316952c683b2e
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 2 14:08:00 2019 +0100

    ntlm_auth: Fix nonempty line endings
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 995de9c2d2e95a782b81c215efc8d4ab4b3d54b9
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 2 14:01:10 2019 +0100

    ntlm_auth: Simplify session generation
    
    We don't need to parse a text sid, we have those as binary available
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8ec9e97666653469e5bd56ef0576fb0af1406a82
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Nov 2 13:56:49 2019 +0100

    auth: Simplify session generation
    
    We don't need to parse a text sid, we have those as binary available
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dd8aba30483649ea28199241fbc2410b1b4595a5
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 10 16:30:14 2019 +0200

    lib: Avoid includes.h in g_lock.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8febbc2bcd2a136281ad9b4b90537028b6d5c4e2
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 10 13:40:44 2019 +0200

    lib: Remove g_lock_do()
    
    This puts too much logic into this lowlevel infrastructure module,
    given the two minor external users.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9dd65d1f991722bf6686ae21e4607192fc2bf327
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 10 13:38:17 2019 +0200

    net: Avoid the use of g_lock_do()
    
    g_lock_do() does too much in g_lock.c, and it's rarely used.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d9bd074cc8c0859f4f6333080d457a551e6367a4
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Oct 10 10:27:54 2019 +0200

    net: Avoid the use of g_lock_do()
    
    g_lock_do() does too much in g_lock.c, and it's rarely used.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit aaad4d012d83b2e203b7974f56b3f6f72d1c9141
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 21:38:42 2019 +0200

    g_lock: Avoid sys_random(), use generate_random()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d6223677bfded0aed659df4a78f318ffc180003c
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 16 15:27:49 2019 +0200

    dbwrap_tdb: Avoid a use of talloc_stackframe()
    
    For really large keys (that probably don't exist), use dump_data()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 54d673742f3a81ecdfb98f66a928d119293697ba
Author: Volker Lendecke <vl at samba.org>
Date:   Wed Oct 9 21:38:04 2019 +0200

    lib: Remove #define serverid_equal server_id_equal
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b749c923373c7ccdc68ba2aed42c614e6a11d353
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 13:28:11 2019 -0700

    s3: smbd: SMB1 UNIX extensions - remove dead code.
    
    We no longer set delete_on_fail on return from mknod.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Nov  6 19:31:00 UTC 2019 on sn-devel-184

commit b784aee40ffceae8332ff3aaa74c20539857ded6
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 13:39:00 2019 -0700

    s3: smbd: SMB1 UNIX extensions - POSIX mknod should just create the object, not change attributes after.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit d8567d46bd7e371de83e4d1ee1592639eb6f0c06
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 15:04:39 2019 -0700

    s3: smbd: SMB1 UNIX extensions - only allow size change on regular file.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 4b25299c0d00b23c22be1e2a4eed3be5572e623a
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 13:35:44 2019 -0700

    3: smbd: SMB1 UNIX extensions - For POSIX mknod we can only create blk/chr/fifo/sock objects.
    
    Fail requests to create other object types.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 4ca0fcb2d4eec29fc75a285947a77974a0555bea
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 15 13:25:14 2019 -0700

    s3: smbd: SMB1 UNIX extensions - Ensure POSIX mknod is root-only.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 35bb734d638e273f2fd1a19220db5f200d3e7489
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Nov 6 08:43:05 2019 +0100

    bootstrap: Fix centos7 image creation
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Nov  6 13:35:17 UTC 2019 on sn-devel-184

commit 6a3b19fb170d13aaed92645866af75cc508d0991
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 5 10:39:16 2019 +0100

    bootstrap: Add Fedora 31
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 1ba0a32e707618012dcf9f06ff48bb15783cf106
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Nov 5 10:38:48 2019 +0100

    bootstrap: Remove Fedora 28 which is already EOL
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit bf99f82077876fc107adb1ed4f07dd7e1351fff9
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Nov 5 15:34:18 2019 +1100

    ctdb-tests: Make process exists test more resilient
    
    This can fail as follows:
    
    --==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--
    Running test ./tests/UNIT/tool/ctdb.process-exists.003.sh (02:26:30)
    --==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--==--
    ctdb.process-exists.003      - ctdbd process with multiple connections on node 0
    Setting up fake ctdbd
    <10||0|
    OK
    <10|PID 26107 exists
    |0|
    OK
    ==================================================
    Running "ctdb -d NOTICE process-exists 26107 0x1234567812345678"
    PASSED
    ==================================================
    Running "ctdb -d NOTICE process-exists 26107 0xaebbccdd12345678"
    Registered SRVID 0xaebbccdd12345678
    --------------------------------------------------
    Output (Exit status: 1):
    --------------------------------------------------
    PID 26107 with SRVID 0xaebbccdd12345678 does not exist
    --------------------------------------------------
    Required output (Exit status: 0):
    --------------------------------------------------
    PID 26107 with SRVID 0xaebbccdd12345678 exists
    
    FAILED
    connection to daemon closed, exiting
    ==========================================================================
    TEST FAILED: ./tests/UNIT/tool/ctdb.process-exists.003.sh (status 1) (duration: 0s)
    ==========================================================================
    
    This happens when dummy_client has not registered the SRVID (for its
    10th connection) before the 2nd simple_test.
    
    Change the initial wait to ensure that the SRVID is registered.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Wed Nov  6 02:46:24 UTC 2019 on sn-devel-184

commit dd9d5ec5c8de82f343369ec4b26c0f24d465ce24
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 15:22:38 2019 +1100

    ctdb-tests: Improve code quality in ctdb_init()
    
    Improve quoting and indentation.  Print a clear error if the cluster
    goes back into recovery and doesn't come back out.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 3b5ed00054e7d1e34cf33706c670e17a188c67d1
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 15:11:31 2019 +1100

    ctdb-tests: No longer retry starting the cluster
    
    Retrying like this hides bugs.  The cluster should come up first time,
    every time.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit bf47bc18bb8a94231870ef821c0352b7a15c2e28
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 17:28:22 2019 +1100

    ctdb-tcp: Drop tracking of file descriptor for incoming connections
    
    This file descriptor is owned by the incoming queue.  It will be
    closed when the queue is torn down.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
    RN: Avoid communication breakdown on node reconnect
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit d0baad257e511280ff3e5c7372c38c43df841070
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 15:29:11 2019 +1100

    ctdb-tcp: Avoid orphaning the TCP incoming queue
    
    CTDB's incoming queue handling does not check whether an existing
    queue exists, so can overwrite the pointer to the queue.  This used to
    be harmless until commit c68b6f96f26664459187ab2fbd56767fb31767e0
    changed the read callback to use a parent structure as the callback
    data.  Instead of cleaning up an orphaned queue on disconnect, as
    before, this will now free the new queue.
    
    At first glance it doesn't seem possible that 2 incoming connections
    from the same node could be processed before the intervening
    disconnect.  However, the incoming connections and disconnect occur on
    different file descriptors.  The queue can become orphaned on node A
    when the following sequence occurs:
    
    1. Node A comes up
    2. Node A accepts an incoming connection from node B
    3. Node B processes a timeout before noticing that outgoing the queue is writable
    4. Node B tears down the outgoing connection to node A
    5. Node B initiates a new connection to node A
    6. Node A accepts an incoming connection from node B
    
    Node A processes then the disconnect of the old incoming connection
    from (2) but tears down the new incoming connection from (6).  This
    then occurs until the originally affected node is restarted.
    
    However, due to the number of outgoing connection attempts and
    associated teardowns, this induces the same behaviour on the
    corresponding incoming queue on all nodes that node A attempts to
    connect to.  Therefore, other nodes become affected and need to be
    restarted too.
    
    As a result, the whole cluster probably needs to be restarted to
    recover from this situation.
    
    The problem can occur any time CTDB is started on a node.
    
    The fix is to avoid accepting new incoming connections when a queue
    for incoming connections is already present.  The connecting node will
    simply retry establishing its outgoing connection.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit e62b3a05a874db13a848573d2e2fb1c157393b9c
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 29 15:25:26 2019 +1100

    ctdb-tcp: Check incoming queue to see if incoming connection is up
    
    This makes it consistent with the reverse case.  Also, in_fd will soon
    be removed.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14175
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ff47cc661d432a9337ade9a232a4f49164652812
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 31 14:38:35 2019 -0700

    s3: libsmb: Ensure return from net_share_enum_rpc() sets cli->raw_status on error.
    
    Convert net_share_enum_rpc() to return an NTSTATUS and ensure the
    status is set correctly on error so SMBC_errno() can return it.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14176
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Nov  5 12:36:48 UTC 2019 on sn-devel-184

commit a58c93318d592d931d232a1a25e37abdd27a825d
Author: Jones Syue <jonessyue at qnap.com>
Date:   Fri Nov 1 15:50:29 2019 +0800

    s3:libads: Fix mem leak in ads_create_machine_acct
    
    Use 'goto done' instead of 'return' to fix machine_escaped leak.
    
    Signed-off-by: Jones Syue <jonessyue at qnap.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Nov  4 22:48:50 UTC 2019 on sn-devel-184

commit 831796b2d7c1ee13d17238b5b4a2c3d56ab6eaaf
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 4 07:47:15 2019 +0100

    gitlab-ci: Run 'samba' tests also with MIT Kerberos
    
    This runs the tests of the ktest environment.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Nov  4 14:19:17 UTC 2019 on sn-devel-184

commit 176d0f0364bc1deb3c8df2f3bb928e01f89f216b
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Nov 4 08:40:34 2019 +0100

    libcli:smb: Do not use gnutls_aead_cipher_encryptv2() with GnuTLS 3.6.10
    
    The gnutls_aead_cipher_encryptv2() implementation was released with a
    bug. This wont be fixed before 3.6.11.
    
    See https://gitlab.com/gnutls/gnutls/merge_requests/1085
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 03205663b3e5939896c1aad93c4a45cd769b06b4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 15 15:44:34 2019 +1300

    CVE-2019-14847 dsdb: Correct behaviour of ranged_results when combined with dirsync
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14040
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Thu Oct 31 23:29:15 UTC 2019 on sn-devel-184

commit e62c535d5b7d357bed9cb998f523e7c007c59910
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Oct 15 16:28:46 2019 +1300

    CVE-2019-14847 dsdb: Demonstrate the correct interaction of ranged_results style attributes and dirsync
    
    Incremental results are provided by a flag on the dirsync control, not
    by changing the attribute name.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14040
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit 4ae0f9ce0f5ada99cf1d236377e5a1234c879ae3
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Nov 1 06:53:56 2019 +1300

    s4-torture: Reduce flapping in SambaToolDrsTests.test_samba_tool_replicate_local
    
    This test often flaps in Samba 4.9 (where more tests and DCs run in the environment)
    with obj_1 being 3.  This is quite OK, we just need to see some changes get
    replicated, not 0 changes.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

commit fe60eef9781f9970d2fa0705e10a6e8e309f839e
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 28 08:34:16 2019 +0100

    docs-xml: Update krb5_ccache_type in pam_winbind.8
    
    This is a copy from pam_winbind.conf.5
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14173
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Oct 31 19:32:55 UTC 2019 on sn-devel-184

commit 0de9dad9ebc88ab044f4b946ef44f63ae2281649
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Oct 31 17:10:59 2019 +0100

    docs-xml: Improve krb5_ccache_type documentation
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit c714c996017b4167e9a7424e1aecd4437deeed22
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    docs-xml/manpages/pam_winbind.conf.5.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Thu Oct 31 02:18:12 UTC 2019 on sn-devel-184

commit 4b198163d03e97790a3c242f25bbd9949ab0aba1
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    docs-xml/manpages/pam_winbind.8.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 81df8aa7bea88f90d7ad18b00788fec8d2744a91
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    docs-xml/Samba-Developers-Guide/unix-smb.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit a456c2bb02af56ab3d966d673421aab976e632ad
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    ctdb/utils/smnotify/smnotify.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 1e73161bdd791fe97053dc2faa85b28e7ef55327
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    ctdb/utils/scsi_io/scsi_io.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit f3754b64876e7d0c073d86bb6d2e29425d9e8d31
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    ctdb/server/ctdb_daemon.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 5d2a257c2e4a929bb70e4e2a2f31ed243c2efa51
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/server/ctdb_client.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 7722bd80fcde69d13b25a1b120fd3f9ecf6dd7dd
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/server/ctdb_call.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 9fa37484c30b83bc36b1607a82c76a77fe639b71
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/include/ctdb_private.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 493705dc2746ee64a4e2cf1dc290009185853db2
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/ib/ibwrapper_test.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 540325d3cb4eee1964fc59a63d51289552293902
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/ib/ibw_ctdb.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b9d7b85afdf96b6ca443861700b9a22c6145dc6d
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/doc/readonlyrecords.txt: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit cb867b29c9ca2ef7ea7c9f80228f60b32329dd6f
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/doc/ctdb.1.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 93859b3394d87f1521f757111eb8e55633c8cde3
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/doc/ctdb-tunables.7.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 37398acca58ac9d224aa5d841197b378e1d26e68
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/doc/ctdb-statistics.7.xml: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 1b51b444874bc254fbe7b865fab7e416f898e46a
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/common/srvid.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c71a1df18aa1b38c194e6b200b81ac44f6d6770f
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    ctdb/client/client.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 522697331fc143bb04cc5136d60178533ae61afc
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    buildtools/wafsamba/wscript: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit e6cd8884256e5f433b16b4132ed825054af867e5
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:08 2019 +0200

    buildtools/wafsamba/samba_install.py: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit e781db805e53959150c8a385ac60d55f601dde71
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:10 2019 +0200

    source4/scripting/bin/samba_upgradeprovision: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 9092120b0dbcd45149975a11f32073d3877da406
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source4/rpc_server/lsa/lsa_lookup.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b4e0c0d38f501f5b477ac384b900fb2651a44e4d
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source4/libcli/libcli.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 7f41f1374264f854a3c7fc74d10a6a691e2f5f64
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source4/libcli/clireadwrite.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 60fcfa506db3d66b7f51ce1c25b55cb62100c763
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source4/dsdb/schema/schema_description.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 1ca79e64d8c28edcb3c9bdea3470e5a7eb8003ea
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/winbindd/winbindd_util.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 616f9d04660f14c9ccb2dab01442c56e377aa37e
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/utils/net_rpc.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 65d0ea769043637a91cb3b1c6ab9b18ff5e48060
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/smbd/reply.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b61e3233273411d693da0e516e4da09423ca92db
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/registry/reg_parse.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 9f4e97a4d5d044e5be29b503254684197ca244ee
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/registry/reg_import.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c7ceca8451f0ff7f4b0650084faed0614332b86e
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/registry/reg_format.h: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 07b506c213a965c900b8002766350ebb38e3c9e4
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/modules/vfs_virusfilter.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 12e71a745aedf6906b54dd03ff9d9a18c9d6b523
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    source3/modules/vfs_recycle.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 08ffb9388ec39514a24ca87391ffe715db68db88
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    python/samba/upgradehelpers.py: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c259190db2d232a9db6d25d7cdbca649a56bd26f
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    python/samba/netcmd/gpo.py: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 6e91c52bbb9a5fe0a4057e15cd52ab56ff6682b6
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    python/samba/dbchecker.py: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 5915a40b25cebf7a480b51543cae93021fb091de
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    librpc/ndr/ndr_compression.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b0deb6799c8d40f7c4c8824e11d37594d52e7bd5
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    libgpo/gpo_filesync.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 96c7653ee774eb6f0c08a0cbb473f4c4a42a526e
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    lib/tdb/docs/tracing.txt: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit ba1887d37422f39bd36d0ab17dd1ef8efa56cb63
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    lib/replace/xattr.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c93f06b12d07783104ea833e463f7fd94c0ccb0f
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    examples/VFS/skel_transparent.c: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c2794780ad09b0fa9d63e4ad31a8ae3c67fa453d
Author: Björn Jacke <bj at sernet.de>
Date:   Sat Oct 26 02:41:09 2019 +0200

    dynconfig/wscript: typo fixes
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 2b060f935026e68d7ad7a5d4e614452a5119dae8
Author: Puran Chand <pchand at vmware.com>
Date:   Mon Oct 21 11:39:18 2019 +0530

    s3:smbclient added ABI signature file
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Oct 30 22:18:15 UTC 2019 on sn-devel-184

commit fe7737135a8f4b28cadc0f79e4de5363a8855a38
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 11:44:07 2019 -0700

    s4: torture: Add additional smbc_readdirplus2() tests into readdirplus_seek().
    
    Make sure we haven't broken anything :-).
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a5f850a93f5e2eb371ca0a628c94e28c3d033e0f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 11:29:19 2019 -0700

    s4: torture Add a test for smbc_readdirplus2()
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit abbbbbff376877bbe92f3695e480472a4070937a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 10:29:48 2019 -0700

    s3: libsmb: Added new API smbc_readdirplus2()
    
    Returns the same as smbc_readdirplus() but also
    can return a struct stat if passed in by the caller.
    
    struct stat is synthesized from the data
    returned by the SMB server.
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e26487aab01096492ec5ed4251039147963a8d1b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 09:45:33 2019 -0700

    s3: libsmb: Add missing ino field to internal struct smbc_dirplus_list.
    
    This should have been added to struct libsmb_file_info, but
    this is user-visible so I don't want to change this now. Adding
    it to the containing struct allows us to synthesise a struct stat
    to return from smbc_readdirplus2() to return all the info from
    the server to callers.
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 1f0715c0e5e6ff371e3b393a0b35222c8b6f49bc
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 10:48:55 2019 -0700

    s3: libsmb: Move setting all struct stat fields into setup_stat().
    
    That way we only have one place where a struct stat is synthesised
    for libsmbclient callers.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7d3b4f47be0359b496087fc40f89b815c7958dd6
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 09:34:02 2019 -0700

    s3: libsmb: Move setting st->st_ino into setup_stat.
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d44a84295b46cc6c540a9730a615a59c1f22a277
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 18 09:24:38 2019 -0700

    s3: libsmb: Change generate_inode()/setup_stat() to modern coding standards.
    
    Change setup_stat() to be void. It doesn't return anything. Export
    so it can be used by upcoming smbc_readdirplus2() call.
    
    Remove unused SMBCCTX *context parameters.
    Remove unused talloc_stackframe().
    
    Signed-off-by: Puran Chand <pchand at vmware.com>
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f30b8b3aa1309e9daeb9a3601b537dead81e5dbb
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 29 12:11:49 2019 -0700

    s3: utils: smbtree. Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.
    
    Last unprotected call of cli_RNetShareEnum(). Not a libsmbclient
    bug here but might as well fix the last caller as part of the
    fix for the bug.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1cfcad6283da855d3e97237a7a6fd6f4d2436ee2
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 29 12:11:01 2019 -0700

    s3: libsmb: Ensure we don't call cli_RNetShareEnum() on an SMB1 connection.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14174
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 41edeff416407d3eae21c7ad43d891dbacc32662
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Oct 30 15:05:13 2019 +0100

    s3:smb2_server: add message mid to SMB2 request done log message
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Oct 30 18:42:35 UTC 2019 on sn-devel-184

commit dcf51b5aa58752ddfa4fc8814c7432e34fef4330
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Oct 30 14:23:20 2019 +0100

    s3:smb2_server: modernize a debug statement
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f3df83a2c346d945487a27a9d258ee6331ea7dbb
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 24 17:15:18 2019 +0200

    lib/adouble: pass filesize to ad_unpack()
    
    ad_unpack() needs the filesize, not the capped IO size we're using in the caller
    to read up to "size" bystem from the ._ AppleDouble file.
    
    This fixes a regression introduced by bdc257a1cbac7e8c73a084b618ba642476807483
    for bug 13968.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    RN: vfs_fruit returns capped resource fork length
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Oct 30 14:52:34 UTC 2019 on sn-devel-184

commit 9a3da6bebcdb924ca2027337544d79ac2088677e
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Oct 25 15:21:32 2019 +0200

    lib/adouble: drop ad_data reallocate logic
    
    Simply set the buffer size to AD_XATTR_MAX_HDR_SIZE. When reading the
    AppleDouble file, read up to AD_XATTR_MAX_HDR_SIZE from the file.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit baaaf59e948df625b01fa8b6317ab5c3babb4e8f
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 24 17:26:08 2019 +0200

    lib/adouble: README.Coding fix: multi-line if expression
    
    Also remove a TAB.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit f0c8ac47a4608eabeae334d39885aab98198b753
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Oct 24 17:17:28 2019 +0200

    lib/adouble: fix a long line
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit b63069db9fb6efb33b7b917cd5b0ee06b0da9cdc
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Oct 25 15:41:40 2019 +0200

    torture: expand test "vfs.fruit.resource fork IO" to check size
    
    Reveals a bug where the resource fork size is capped at 65454 bytes.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14171
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit ef58222616fc3175f189417ce878d8413ba2d294
Author: Björn Baumbach <bb at sernet.de>
Date:   Tue Aug 6 16:32:32 2019 +0200

    CVE-2019-14833 dsdb: send full password to check password script
    
    utf8_len represents the number of characters (not bytes) of the
    password. If the password includes multi-byte characters it is required
    to write the total number of bytes to the check password script.
    Otherwise the last bytes of the password string would be ignored.
    
    Therefore we rename utf8_len to be clear what it does and does
    not represent.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12438
    
    Signed-off-by: Björn Baumbach <bb at sernet.de>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(master): Tue Oct 29 11:58:45 UTC 2019 on sn-devel-184

commit d524c7ddee92a457ba680853b6c25c877d881ff8
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Thu Sep 19 11:50:01 2019 +1200

    CVE-2019-14833: Use utf8 characters in the unacceptable password
    
    This shows that the "check password script" handling has a bug.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12438
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>

commit 7ccc302b4bb9e0a9b695074959dc45e6fc4902bb
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Aug 6 12:08:09 2019 -0700

    CVE-2019-10218 - s3: libsmb: Protect SMB2 client code from evil server returned names.
    
    Disconnect with NT_STATUS_INVALID_NETWORK_RESPONSE if so.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14071
    
    Signed-off-by: Jeremy Allison <jra at samba.org>

commit 9f7a622b2bd4a42fad3e669e83fe07c5d7115dc6
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Aug 5 13:39:53 2019 -0700

    CVE-2019-10218 - s3: libsmb: Protect SMB1 client code from evil server returned names.
    
    Disconnect with NT_STATUS_INVALID_NETWORK_RESPONSE if so.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14071
    
    Signed-off-by: Jeremy Allison <jra at samba.org>

commit 2669cecc51f8f7d6675b4dac9b345b3c5a7fc879
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Sep 13 10:56:10 2019 +0300

    libnet_join: add SPNs for additional-dns-hostnames entries
    
    and set msDS-AdditionalDnsHostName to the specified list.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Fri Oct 25 10:43:08 UTC 2019 on sn-devel-184

commit db7560ff0fb861552406bb4c422cff55c82f58bf
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Sep 17 21:38:07 2019 +0300

    docs-xml: add "additional dns hostnames" smb.conf option
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 3e65f72b141a7ee256ae581e5f48f1d930aed76a
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 18 23:15:57 2019 +0300

    libnet_join_set_machine_spn: simplify adding uniq spn to array
    
    and do not skip adding a fully qualified spn to netbios-aliases
    in case a short spn already existed.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit b8e1264ececf38681ca9a519a51e8336044673f0
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 18 21:29:47 2019 +0300

    libnet_join_set_machine_spn: simplify memory handling
    
    and avoid a possible memory leak when passing null to
    add_string_to_array() as mem_ctx.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4cbad1eb46896bbd74c5b19dbb0a8937ffde90c2
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 18 20:00:34 2019 +0300

    libnet_join_set_machine_spn: improve style and make a bit room for indentation
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 05f7e9a72a1769af9d41b1ca40fe6a14b3f069d1
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Aug 30 00:22:15 2019 +0300

    libnet_join: build dnsHostName from netbios name and lp_dnsdomain()
    
    This make the join process much more reliable, and avoids "Constraint
    violation" error when the fqdn returned from getaddrinfo has already
    got assigned an SPN.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14116
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit d0f566c4ad32d69a1cf896e2dde56fc2489bb7fc
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Oct 4 14:57:40 2019 +0200

    s4:dirsync: fix interaction of dirsync and extended_dn controls
    
    Azure AD connect reports discovery errors:
      reference-value-not-ldap-conformant
    for attributes member and manager.
    The key is that it sends the LDAP_SERVER_EXTENDED_DN_OID without
    an ExtendedDNRequestValue blob, which means the flag value should
    be treated as 0 and the HEX string format should be used.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14153
    RN: Prevent azure ad connect from reporting discovery errors:
    reference-value-not-ldap-conformant
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Oct 24 11:06:58 UTC 2019 on sn-devel-184

commit 6d43d82b49c8cd47da2f1489fe8b52d5a873a19c
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Oct 22 12:12:32 2019 +0200

    s4:tests/dirsync: add tests for dirsync with extended_dn
    
    This demonstrates a problems that the extended_dn returned
    by the dirsync module always uses the SDDL format for GUID/SID
    components.
    
    Azure AD connect reports discovery errors:
      reference-value-not-ldap-conformant
    for attributes member and manager.
    The key is that it sends the LDAP_SERVER_EXTENDED_DN_OID without
    an ExtendedDNRequestValue blob, which means the flag value should
    be treated as 0 and the HEX string format should be used.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14153
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 9471508391fd3bcf199b1e94f8d9ee2b956e8f8e
Author: Ralph Boehme <slow at samba.org>
Date:   Sat May 4 12:12:48 2019 +0200

    s3: remove now unneeded call to cmdline_messaging_context()
    
    This was only needed as dbwrap_open() had a bug where it asked for the ctdb
    connection before initializing messaging. The previous commit fixed that so we
    can now safely remove the calls to cmdline_messaging_context() from all tools
    that don't use messaging.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=13925
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Oct 24 09:33:47 UTC 2019 on sn-devel-184

commit ca95d7f41b683b4d7ac59ed6ee709d44abfe2019
Author: Ralph Boehme <slow at samba.org>
Date:   Sat May 4 12:12:04 2019 +0200

    s3:dbwrap: initialize messaging before getting the ctdb connection
    
    This is a better fix for bug #13465.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=13925
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ab71d72138fffff5fc89b246b67cc4b82ca24f05
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Oct 22 09:32:58 2019 +0200

    waf: Symlink the compile database to the source dir for clangd
    
    https://github.com/ycm-core/YouCompleteMe
    https://github.com/abingham/emacs-ycmd
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Oct 24 08:11:19 UTC 2019 on sn-devel-184

commit b28d06be7a0b730fb893b2f208af4ff864cda166
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Sep 25 18:13:26 2018 +0200

    waf: Create clang compilation database
    
    http://clang.llvm.org/docs/JSONCompilationDatabase.html
    
    This can be used by ymcd or clangd.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6de5706b4dbe70c66872abc80dd9301dccb2ee7c
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Aug 14 15:26:25 2019 +1000

    ctdb-tests: Add vacuuming tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Thu Oct 24 05:28:21 UTC 2019 on sn-devel-184

commit 49262a6bc4d5f8b81aa341294bfe04a22a6b32b6
Author: Martin Schwenke <martin at meltin.net>
Date:   Sun Sep 29 08:27:33 2019 +1000

    ctdb-tests: Add handling of process clean-up on a cluster node
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit b9654085f5facfe8a3d64667d65793146563d7f5
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 12 21:02:47 2019 +1000

    ctdb-tests: Factor out function check_cattdb_num_records()
    
    This can be use in multiple vacuuming tests.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5a6d319eea6b281e9f4c35cf6c8889856234a9fd
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Aug 1 15:33:52 2019 +1000

    ctdb-tests: Add ctdb-db-test tool
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 439ef65d290357e513103530183091a9a6fed197
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 27 16:49:01 2019 +1000

    ctdb-client: Factor out function client_db_tdb()
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 41a41d5f3e2b8e16e25221e14939dc5962997ac7
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 14:17:11 2019 +1000

    ctdb-daemon: Implement DB_VACUUM control
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit d462d64cdf001fd5d1cbf2a109df62e087ad0c49
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Oct 15 16:36:44 2019 +1100

    ctdb-vacuum: Only schedule next vacuum event if vacuuuming is scheduled
    
    At the moment vacuuming is always scheduled.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 13cedaf0195c6bda3a3820aedb1ee65f36dfc23e
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 14:16:13 2019 +1000

    ctdb-daemon: Factor out code to create vacuuming child
    
    This changes the behaviour for some failures from exiting to simply
    attempting to schedule the next run.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5539edfdbe69d1d5f084d06753cce8ed6e524999
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Oct 4 12:06:21 2019 +1000

    ctdb-vacuum: Simplify recording of in-progress vacuuming child
    
    There can only be one, so simplify the logic.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 496204feb0e2b6eb2f3d9a74e45596a3e74ad9b1
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 10:52:05 2019 +1000

    ctdb-protocol: Add marshalling for control DB_VACUUM
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a896486b62bbcf9915727ba7bfc768fb5383f0c7
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 16:59:37 2019 +1000

    ctdb-protocol: Add marshalling for struct ctdb_db_vacuum
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit b314835341e4028f0770fa7f9a37d2d21448ddfd
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Jul 30 10:34:03 2019 +1000

    ctdb-protocol: Add new control CTDB_CONTROL_DB_VACUUM
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit d0cc9edc05b6218a8e20a0a8009cbb9918ff4d02
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Tue Oct 1 15:05:10 2019 +1000

    ctdb-vacuum: Avoid processing any more packets
    
    All the vacuum operations if required have an event loop to ensure
    completion of pending operations.  Once all the steps are complete,
    there is no reason to process any more packets.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 680df07630a94b3e76edefe98ee0986e7e5e1f12
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Wed Jun 6 15:47:13 2018 +0200

    ctdb-daemon: Avoid memory leak when packet is deferred
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit c6427dddf5425b267d8c09e8df18653a48679646
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:17:38 2018 +1100

    ctdb-recoverd: No need for database detach handler
    
    The only reason for recoverd attaching to databases was to migrate
    records to the local node as part of vacuuming.  Recovery daemon does
    not take part in database vacuuming any more.
    
    The actual database recovery is handled via the recovery_helper and
    recovery daemon should not need to attach to the databases any more.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit fc81729dd2d8eddea1e60e22b183894d6541c7dc
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:13:35 2018 +1100

    ctdb-recoverd: Drop VACUUM_FETCH message handling
    
    This is now implemented in the ctdb daemon using VACUMM_FETCH control.
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 498932c0e8e8614bd52f3270c4d63e2b5f9e26a4
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:01:21 2018 +1100

    ctdb-vacuum: Replace VACUUM_FETCH message with control
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 86521837b684df3b7c5a0a1e3b7e606c8b91f63e
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:00:40 2018 +1100

    ctdb-vacuum: Add processing of fetch queue
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit da617f90d90151f955ee354c57bdc4bc6f6498f2
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 15:30:13 2018 +1100

    ctdb-daemon: Add implementation of VACUUM_FETCH control
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 36f9b4953a8def40681a6f02f6576795a1ba5fbe
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Fri Feb 16 17:28:49 2018 +1100

    ctdb-tests: Add marshalling tests for new control
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit b71d8cd80f84169bacf2dd1e753e468a305c50ce
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Feb 15 11:57:44 2018 +1100

    ctdb-protocol: Add marshalling for new control VACUUM_FETCH
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 0872c52ef0497f96f53318cf7e4d31be0854adde
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Feb 15 11:57:24 2018 +1100

    ctdb-protocol: Add new control VACUUM_FETCH
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 913bd331f65e9fe3d7cb16e041cd37b01987841f
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Feb 15 12:28:11 2018 +1100

    ctdb-tests: Drop code releated to obsolete controls
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 688567f080156892270cbfb2907cd712cb77cb7a
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Feb 15 12:13:53 2018 +1100

    ctdb-protocol: Drop code related to obsolete controls
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit 9f41a9fc1ee10a28d379c8fda49ccfd295d66770
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 8 13:02:41 2019 +0200

    ctdb: Avoid malloc/memcpy/free in ctdb_ltdb_fetch()
    
    Make use of tdb_parse_record()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>

commit 6e8c3ae6e9be38fdd1d1693b93c8629391799b19
Author: Heinz Hoelzl <heinz.hoelzl at gvcc.net>
Date:   Thu Oct 10 10:14:15 2019 +1300

    samba-tool: py3 compatiblity in 'user syncpasswords --daemon'
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14154
    
    Signed-off-by: Heinz Hölzl <heinz.hoelzl at gvcc.net>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Björn Baumbach <bb at sernet.de>
    
    Autobuild-User(master): Björn Baumbach <bb at sernet.de>
    Autobuild-Date(master): Wed Oct 23 15:54:43 UTC 2019 on sn-devel-184

commit 263bec1b8d0744da73dd92e4a361fb7430289ab3
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 21 17:08:08 2019 +0200

    replace: Only link libnsl and libsocket if requrired
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14168
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct 23 08:23:13 UTC 2019 on sn-devel-184

commit 1b69795c5bbc2ed24c54f8295fd3d9e4e0a0f938
Author: Christian Ambach <ambi at samba.org>
Date:   Tue Oct 22 11:02:05 2019 +0200

    s3:lib:wins fix a compile warning on Ubuntu 18.04
    
    gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1) with -O2 puts up a warning here:
    ../../source3/lib/wins_srv.c: In function ‘wins_srv_tags’:
    ../../source3/lib/wins_srv.c:235:3: error: assuming signed overflow does not
    occur when simplifying conditional to constant [-Werror=strict-overflow]
       for (j=0;j<count;j++) {
       ^~~
    cc1: all warnings being treated as errors
    
    Signed-off-by: Christian Ambach <ambi at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    
    Autobuild-User(master): Uri Simchoni <uri at samba.org>
    Autobuild-Date(master): Wed Oct 23 04:57:09 UTC 2019 on sn-devel-184

commit f37b913348e921afee3e578ff0f14b731157eb03
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Oct 21 14:38:47 2019 +0200

    smbd: Save 520 bytes of writable memory from every smbd
    
    Move what can be const from the "data" to the "text" segment
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Martin Schwenke <martins at samba.org>
    Autobuild-Date(master): Wed Oct 23 02:37:12 UTC 2019 on sn-devel-184

commit 0559701478d42e969c8c779d765163271ca9141e
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Oct 21 14:37:04 2019 +0200

    smbd: Remove an unused #define from mangle_hash2.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit ccc486ca1184962df57e380954747f1593317bb5
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 22 08:30:01 2019 +0200

    smbd: Mark #else/#endif with the if-#define
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit aa37668218024aff6bb6518386d4e17a91407633
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 16:42:36 2019 +1100

    ctdb-tests: Add -l option to set number of local daemons
    
    This is the only place where setting an environment variable by hand
    is recommended, so remove the anomaly.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Oct 22 21:02:11 UTC 2019 on sn-devel-184

commit fe80038d074d220487782dc837ea4bd779a6aad0
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 16:33:48 2019 +1100

    ctdb-tests: Prefix remaining environment variables with CTDB_
    
    Now they are clearly all part of CTDB.
    
    TEST_SOCKET_WRAPPER_SO_PATH gets too long in
    integration_local_daemons.bash, so change it to
    CTDB_TEST_SWRAP_SO_PATH instead of just prefixing.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit e8dc125ed2e502234135e12fe32fb387baa11a79
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 16:19:58 2019 +1100

    ctdb-tests: Drop setting of test state directory for testonly target
    
    This is the default and deciding this should be left to run_tests.sh.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit fc16b8dbc69130a039f8492563fcc5ffded2000e
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 16:19:33 2019 +1100

    ctdb-tests: Enable printing of logs on failure in autobuild
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 787662604d4f578f10981845997ccd995f11d853
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 17 15:53:09 2019 +1100

    ctdb-tests: Add run_tests.sh option to print logs on test failure
    
    Implement this for local daemons integration tests, dumping last 100
    lines of logs.  This makes it possible to debug some failures in
    automated tests where the logs are unavailable for analysis.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5ae330e5a56553b8809f710230101acf044c98e3
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Oct 16 17:21:51 2019 +1100

    ctdb-tests: Avoid running valgrind under valgrind
    
    When run from integration tests $CTDB already includes $VALGRIND, if
    set.  So only add $VALGRIND if $CTDB is not set.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit b8461b422d94b836eb952a3a5363cf03eb347e95
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Oct 14 10:15:07 2019 +1100

    ctdb-tests: Simplify tool unit test runner
    
    There is no good reason why the code needs to be this way.  The
    intervening code was removed years ago leaving a more complex version
    of something very simple.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ce3fdc4dee373a2f9ab55ffa83a97ac690109b09
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Mon Sep 2 04:26:08 2019 -0500

    samba-tool domain: fix an unhandled exception
    
    Uncaught exception on running 'samba-tool domain schemaupgrade'
    
    ERROR(<class 'ModuleNotFoundError'>): uncaught exception - No module named
    'markdown' File "/usr/lib64/python3.7/site-packages/samba/netcmd/__init__.py",
    line 185, in _run return self.run(*args, **kwargs) File
    "/usr/lib64/python3.7/site-packages/samba/netcmd/domain.py", line 4157, in run
    from samba.ms_schema_markdown import read_ms_markdown File
    "/usr/lib64/python3.7/site-packages/samba/ms_schema_markdown.py", line 26, in
    <module> import markdown
    
    Signed-off-by: Amit Kumar amitkuma at redhat.com
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 799b05cf7f9e49db71a731fdf9264311703fd3cf
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Tue Jul 16 02:29:44 2019 +0530

    net: 'net ads gpo getgpo' command not dumping gpo
    
    We have passed dump_gpo(debuglevel=1), hence gpo is not
    dumped at debuglevel=0. But end user will expect gpo
    to be dumped without setting debug flag.
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 6ebd0ba735e6fdddc4d7ded57879d85a42aabf05
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:57:22 2019 +0100

    s3/libsmb: clang: Fix 'the left operand of '-' is a garbage value'
    
    Fixes:
    
    source3/libsmb/clifile.c:360:19: warning: The left operand of '-' is a garbage value <--[clang]
            if (data[num_data-1] != '\0') {
                     ~~~~~~~~^
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Oct 22 18:48:43 UTC 2019 on sn-devel-184

commit 4ef40d41f606f631411991101ed826733a74a8b7
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:55:13 2019 +0100

    s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
    
    Fixes:
    
    source3/libsmb/clirap.c:1490:9: warning: Assigned value is garbage or undefined <--[clang]
                    *mode = attr;
                          ^ ~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 61621009980a4c4a8b64bde8e03370152df0cdce
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:52:46 2019 +0100

    s3/libsmb: clang: Fix 'Value stored to 'p' is never read'
    
    Fixes:
    
    source3/libsmb/clirap.c:145:3: warning: Value stored to 'p' is never read <--[clang]
                    p = rdata;
                    ^   ~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 764bb47a370c6a5d5d73b8855d141c2d4cbd6f58
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:43:30 2019 +0100

    s3/libsmb: clang: Fix 'Assigned value is garbage or undefined'
    
    Fixes:
    
    source3/libsmb/smbsock_connect.c:786:13: warning: Assigned value is garbage or undefined <--[clang]
                    state->fd = fd;
                              ^ ~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4995a0e7e05c4affc9f1f7992cef54e57d9efdc0
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:36:56 2019 +0100

    s3/libsmb: clang: Fix 'Value stored to 'create_options' is never read'
    
    It looks like the create_options are accumulated as the depending on the
    failure reasons returned for cli_smb2_create_fnum (except for when a
    directory is encountered) this looks like a mistake
    Fixes:
    
    source3/libsmb/cli_smb2_fnum.c:1870:3: warning: Value stored to 'create_options' is never read <--[clang]
                    create_options |= FILE_DIRECTORY_FILE;
                    ^
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 25a256bedf2992771b6ea1263fb5e730b27a53dc
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:27:35 2019 +0100

    s3/libsmb: clang: Fix 'Dereference of undefined pointer value'
    
    Fixes:
    
    source3/libsmb/clidfs.c:350:3: warning: Dereference of undefined pointer value <--[clang]
                    DLIST_ADD_END(referring_cli, cli);
                    ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7a4da41c1efb62f5e528907a2e6c0aab766994e1
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:22:37 2019 +0100

    s3/libsmd: clang: Fix some uninitialized value errors
    
    Fixes:
    
    source3/libsmb/clilist.c:534:14: warning: 1st function call argument is an uninitialized value <--[clang]
            num_finfo = talloc_array_length(finfo);
                        ^
    source3/libsmb/clilist.c:1007:13: warning: The right operand of '<' is a garbage value <--[clang]
            for (i=0; i<num_finfo; i++) {
                       ^~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e9dd8821adf1696f2ab292275cc0ee859e4a24c4
Author: Noel Power <noel.power at suse.com>
Date:   Tue Aug 13 15:18:10 2019 +0100

    s3/libsmb: clang: Fix 'Value stored to 'p' is never read'
    
    Fixes:
    
    source3/libsmb/climessage.c:73:2: warning: Value stored to 'p' is never read <--[clang]
            p += hlen;
            ^    ~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6a9041ba437464bbe32738ae807e4053c4a5f1ef
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Oct 22 11:49:22 2019 +0200

    autobuild: rename samba-ad-member-* to samba-admem-*
    
    Needed to come around MAX pathlen limit for UNIX domain socket triggered by
    the new samba-ad-member-mitkrb5 target added in samba-ad-member-mitkrb5.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Martin Schwenke <martin at meltin.net>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Oct 22 14:53:17 UTC 2019 on sn-devel-184

commit 1722e5fb1c3df34fd8eb3f7d215b6d9a913ee45f
Author: Marco Wang <m.aesophor at gmail.com>
Date:   Wed Aug 28 17:29:31 2019 +0800

    s3: include: printing: align function parameters
    
    Signed-off-by: Marco Wang <m.aesophor at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Oct 21 16:01:56 UTC 2019 on sn-devel-184

commit 31563f5759f9aeab35b566e77e6ec20b0c4589e1
Author: Marco Wang <m.aesophor at gmail.com>
Date:   Wed Aug 28 17:28:26 2019 +0800

    s3: include: printing: fix indentation of struct printif
    
    Signed-off-by: Marco Wang <m.aesophor at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 073dc735b4e286ff1c57cb2634832eb04a78baac
Author: Marco Wang <m.aesophor at gmail.com>
Date:   Wed Aug 28 17:26:14 2019 +0800

    s3: include: printing: move copyright notice to beginning
    
    Signed-off-by: Marco Wang <m.aesophor at gmail.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit fd5cf415a7536c9f020fff57a707caa703c33b9c
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Sep 28 14:51:43 2017 +0200

    s4:kdc: fix the principal names in samba_kdc_update_delegation_info_blob
    
    We need the target service without realm, but the proxy services with realm.
    
    I have a domain with an w2008r2 server and a samba and now both generate
    the same S4U_DELEGATION_INFO.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 90bdaaf09d9c5595170272bd0bfebaac0a90ae01
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Sun Oct 13 22:32:36 2019 +0300

    selftest: add a test for PAC delegation-info blob in S4U2Proxy
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d6a4eea5fd284755d181426dba84ddd5c1ba9769
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Oct 16 00:55:04 2019 +0300

    selftest/remote_pac: split test_PACVerify() in two
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13133
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 5216fd2287260eeb4864a465121ff7870896e697
Author: Christian Schulz <chris at schocktools.de>
Date:   Mon Oct 14 15:27:36 2019 +0200

    smbstatus: fix column length for DenyMode
    
    Signed-off-by: Christian Schulz <chris at schocktools.de>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Oct 21 01:26:29 UTC 2019 on sn-devel-184

commit 7b1466cc1e0c25930ca4f8296b31f33e3a7cce2f
Author: Christian Schulz <chris at schocktools.de>
Date:   Mon Oct 14 15:24:20 2019 +0200

    smbstatus: use display print function
    
    Signed-off-by: Christian Schulz <chris at schocktools.de>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c1349c44d94b3f16daa7286a2762ad05567d8563
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Oct 18 13:31:38 2019 +0200

    s3:waf: Remove check for fdatasync
    
    This is already checked by libreplace as replace also provides it.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Sun Oct 20 14:52:40 UTC 2019 on sn-devel-184

commit 649d15bb969b6d27fd4554f49600366bb3df4712
Author: Uri Simchoni <uri at samba.org>
Date:   Wed Oct 9 21:53:43 2019 +0300

    autobuild: harden samba-xc test suite
    
    Add more checks which directly test the behavior of
    --cross-answers and --cross-execute.
    
    Previous test tested things in a round-about way, checking
    that running in all three modes (native, cross-execute,
    cross-answers) yields the same result. It was vulnerable
    to a degradation in which cross-compilation modes didn't
    work at all and were running native tests, which is
    what happened with the upgrade of waf.
    
    The added tests check the following:
    - That cross-excute with cross-answers sets the cross-answers file
    - That the content of cross-answers file actually affects the build
      configuration
    - That a missing line in cross-answers fails the build
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Uri Simchoni <uri at samba.org>
    Autobuild-Date(master): Sun Oct 20 13:29:58 UTC 2019 on sn-devel-184

commit fdfd69840902f4b13db2a204a0ca87a578b61b85
Author: Uri Simchoni <uri at samba.org>
Date:   Mon Oct 7 00:37:41 2019 +0300

    wafsamba: pass environment to cross-execute tests
    
    This can come in handy for cross-execute scripts in general, and
    is particularly required by the samba-xc test for cross-answers /
    cross-execute, because Samba sets LD_LIBRARY_PATH during rpath
    checks, and the test program needs that in order to successfully
    run.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 5a4ade953420a4122c80d291ac53310abd6a279c
Author: Uri Simchoni <uri at samba.org>
Date:   Mon Oct 7 00:37:31 2019 +0300

    wafsamba: avoid pre-forking if cross-compilation is enabled
    
    Waf supports pre-forking to run configuration tests, but this
    doesn't play well with Samba's cross-compilation support, because
    Samba monkey-patches the actual fork+exec, which doesn't happen
    in a pre-forked process pool.
    
    This patch emulates the impact of WAF_NO_PREFORK env var when
    cross-compilation is enabled.
    
    The blueprint for the solution has been suggested by Thomas Nagy
    in https://bugzilla.samba.org/show_bug.cgi?id=13846#c7 (item #2)
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit e00e93350288dc212fed3f1be2adf78dcb6e58e7
Author: Uri Simchoni <uri at samba.org>
Date:   Mon Oct 7 00:37:17 2019 +0300

    wafsamba: use test_args instead of exec_args to support cross-compilation
    
    exec_args seems to have been a custom addition to Samba's copy of waf.
    Upstream Waf has an identically-purposed parameter called test_args.
    
    This parameter is being used for addiing runtime args to test programs that
    are being run during configuration phases.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 09e282ec8173f2935bdb579e0396f269ce712e0d
Author: Uri Simchoni <uri at samba.org>
Date:   Mon Oct 7 00:36:42 2019 +0300

    waf: upgrade to 2.0.18
    
    This is required to get the new test_args parameter to conf.check, which
    facilitates passing arguments to configuration test programs.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13846
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 0afd655e80262ea8505a2e6d0dd9cc453fbdfd8c
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 15 10:56:54 2019 +0200

    dbwrap_watch: Fix cleaning up dead watchers
    
    "wrec->num_watchers" changes in dbwrap_watch_rec_del_watcher(). In
    32d6cc84c I forgot to update the copy of that variable.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Oct 18 22:28:07 UTC 2019 on sn-devel-184

commit 75433f60522b935adb8c14fc6d0caa14c85281b3
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 15 10:55:25 2019 +0200

    dbwrap_watch: Test cleanup of dead watchers
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 50f69b60549b5d963e83a96315953e074517c096
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:53:32 2019 +0200

    librpc:core: Make dcesrv_find_endpoint public
    
    Will be used from s3 implementation when a connection is passed to other
    process where a particular association group was created.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Oct 18 17:30:39 UTC 2019 on sn-devel-184

commit e10028a05000f6b7a2a8252352ad5f720ad23e86
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:51:53 2019 +0200

    librpc:core: Return NTSTATUS for dcesrv_find_endpoint
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 08c663828c9482767b5128820f8204fd0fe4654e
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:46:59 2019 +0200

    librpc:core: Rename find_endpoint to dcesrv_find_endpoint
    
    This function will be public and available for s3 and s4 implementations.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 73948df2f1a5dbef0f073933be549e4320013913
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:44:10 2019 +0200

    librpc:core: Initialize static variable
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 6a6546b565793341f3be6a6fcf30a40a186f9ae9
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 1 16:48:01 2019 +0200

    librpc:core: Allocate struct dcesrv_interface with talloc
    
    The S3 implementation needs to reinit the dcesrv_context and free the
    endpoints list with their registered interfaces.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 52727543b05c80742e187014ce1048fe7b104bdc
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Mon Feb 4 17:37:01 2019 +0100

    librpc:core: Set debug class
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 491102b5b2ca56375d5a58e98f1c037298aa89f3
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 19:38:31 2019 +0200

    s4:rpc_server: Move core functions to core library
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 076ec9173efc2b666be36630e38beab4624638a8
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 18:39:58 2019 +0200

    s4:rpc_server: Move core structures and prototypes to core library
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 3f33fdf2e36742ec98e3406f2ecaaa4758ce2a51
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 18:05:04 2019 +0200

    librpc: Add new dcerpc server core library
    
    Next commits will move the core of s4 rpc server to this library.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 480dd6163b28d97ba89ceccbf84d7a730d7017aa
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 20:55:27 2019 +0100

    s4:rpc_server: Make functions public
    
    These functions will be moved to core dcerpc library and called from
    s4 and s3 implementations.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 0523f0b4d28ca125c207448167608d170b9c0909
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 15:59:04 2019 +0100

    s4:rpc_server: Add public function dcesrv_connection_loop_start
    
    This function starts the server loop and will be called from s3 and s4
    implementations.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 85de73354d982861cc863b4682a8043c22797faa
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 20:25:58 2019 +0100

    s4:rpc_server: Add transport termination function pointer
    
    As the dcesrv_terminate_connection function will be moved to the shared
    rpc server core library, hide the stream_terminate_connection call behind
    a function pointer.
    
    The s3 implementation will define its own termination function.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 55ad4ae7ffcb3221675070b9cb939c29e00f25f4
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 17:35:03 2019 +0200

    s4:rpc_server: Find association groups through context callbacks
    
    Split the association group management from the server code, the s3 and
    s4 implementation will handle differently.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit b0ecc8ef55dc7e8c7ce9f7f3ca325358f62debfb
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 17:26:54 2019 +0200

    s4:rpc_server: inline the dcesrv_assoc_group_find function
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 6fe23fa071d2dc6e348b175b514c99a6ce82b6f4
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 20:34:03 2019 +0100

    s4:rpc_server: Hide gensec prepare behind function pointer
    
    This function will be different for s3 and s4
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit bf097719534be55abaab931ca03b8be23ef1fe0a
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 20:03:44 2019 +0100

    s4:rpc_server: Add dcesrv_context_callbacks to dcesrv_context
    
    Add a new struct dcesrv_context_callbacks in dcesrv_context to hold pointers
    to functions whose implementation will differ between S3 and S4.
    
    The log_successful_dcesrv_authz_event implementation will differ as it
    requires an imessaging_context.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 6fcf8038e49ed7f0996ad21fb9f516de30131df7
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 16:59:49 2019 +0200

    s4:rpc_server: Do not include s4 librpc headers in dcerpc core
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 63b78894618a9badac595fbc59cea0f097feeded
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 12:03:45 2019 +0100

    librpc: Move dcerpc_log_packet from s4 librpc to common librpc
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ae9956a65e6913a73dfa68e2b5deebfeaf52c0e5
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 16:44:36 2019 +0200

    librpc: Move dcerpc_ncacn_push_auth from s4 librpc to common librpc
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit b6c8afa98c5c1f9853b09fd83b039aacc79700db
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Oct 3 16:40:53 2019 +0200

    s4:librpc: Rename ncacn_push_auth to dcerpc_ncacn_push_auth
    
    Next commit will move this function to common librpc
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 83def9a945f40892aaf0e4ea6ea7845d74bbaf7c
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Jan 23 20:52:50 2019 +0100

    s4:rpc_server: Split dcerpc_generic_session_key for server and client
    
    Split the common bits of dcerpc_generic_session_key to librpc and rename
    client the specific part to dcecli_generic_session_key.
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f402b937f4862843015686b8e28504fe588d0c5f
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Jan 23 20:41:54 2019 +0100

    s4:rpc_server: Remove server_id from dcerpc core structs
    
    Add a helper function to retrieve it from the stream connection.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 3d7167f4f43f5cf8ca4393d8d852bd146bf05cde
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Wed Jan 23 20:37:21 2019 +0100

    s4:rpc_server: Remove imessaging_context from dcerpc core structs
    
    Add a helper function to retrieve the imessaging_context from the
    stream connection.
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 3d529762df48205f91e4089178f7aeae240d0da8
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Thu Jan 24 13:38:29 2019 +0100

    s4:rpc_server: Rename common/reply.c to dcesrv_reply.c
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 4d7a916189c8d910c22eb46c9fe0f061d83cab59
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Mon Sep 30 23:35:55 2019 +0200

    s4:rpc_server: Cleanup includes
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d572219e1bfcd9342f0841b4faa446fd41bbb42d
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Fri Jan 25 09:54:03 2019 +0100

    s4:rpc_server: Fix debug string printing duplicated function name
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 61aaebaa356102eccd996b6c6cd2641354caa2d3
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 19 12:43:02 2019 +0100

    s4:torture: Assert connection
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e4b1354066f302475975006f5dfa8736ca34396e
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 19 12:42:11 2019 +0100

    s4:torture: Fix torture comment
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f43e08259c0f41d598f6c7632195e67f80a1f82b
Author: Samuel Cabrero <scabrero at suse.de>
Date:   Tue Feb 19 12:41:38 2019 +0100

    s4:torture: Add braces
    
    Signed-off-by: Samuel Cabrero <scabrero at suse.de>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 27b01d0aa362b3b226696b9ab7df855fe6fd1ab9
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Mon Sep 30 23:33:09 2019 +0200

    tstream_npa: Set local server name in auth requests
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit e70dbe7d8aad650c6f14e7d78dca522d1ac9d898
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 1 17:21:00 2019 +0200

    s3:printing: Add spoolssd header file
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8b761b126c1a476a2ac36c90c87d0183ba34f4a8
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Tue Oct 1 17:14:04 2019 +0200

    s3:printing: Add header inclusion guards in queue_process.h
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8bc228900e8cbc271543add56a2fc98002548a55
Author: Samuel Cabrero <scabrero at samba.org>
Date:   Thu Sep 12 19:05:57 2019 +0200

    s3:smbd: Add header inclusion guards in globals.h
    
    Signed-off-by: Samuel Cabrero <scabrero at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 9a02c31deb1a295a5cf403aba378057dfcd44268
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Fri Oct 18 21:11:13 2019 +1300

    lib: Explicitly refuse to truncate unix domain socket paths
    
    This avoids creating a socket like:
    
    .../winbindd_privileged/p
    
    instead of
    
    .../winbindd_privileged/pipe
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 8e55a8562951924e4b1aad5a6d67fc8b309590c1
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 17 12:41:08 2019 -0700

    s3: torture: Ensure SMB1 cli_qpathinfo2() doesn't return an inode number.
    
    Piggyback on existing tests, ensure we don't regress on:
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14161
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d495074ee27a5f528d5156a69800ee58d799b1eb
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 17 11:39:02 2019 -0700

    s3: libsmb: Ensure SMB1 cli_qpathinfo2() doesn't return an inode number.
    
    The info level it uses doesn't return that, previously we
    were using the field that is returned as the EA size as
    the inode number (which is usually zero, so the code in
    libsmbclient would then synthesize an inode number from
    a hash of the pathname, which is all it can do for SMB1).
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14161
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7c83b1ade7a79770689d876e985e245f5af276ad
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Oct 16 16:47:26 2019 +1300

    dsdb: Change LDB_TYPESAFE_QSORT() to TYPESAFE_QSORT() in operational module
    
    This call does not use the context argument so no additional parameter is needed.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Oct 18 10:58:45 UTC 2019 on sn-devel-184

commit 5bc35614253b4769590813249274355fd3d2ae53
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Oct 16 16:39:35 2019 +1300

    s4-rpc_server: Change LDB_TYPESAFE_QSORT() to TYPESAFE_QSORT() in getncchanges
    
    This call does not use the context argument so no additional parameter is needed.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 517342399c0a558fc016d06ce7728f3c56ef952e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Oct 16 16:38:38 2019 +1300

    dsdb: Change LDB_TYPESAFE_QSORT() to TYPESAFE_QSORT() in repl_meta_data module
    
    This call does not use the context argument so no additional parameter is needed.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 25b1e478ec5e8ac40d41013a824311824482fa67
Author: Anoop C S <anoopcs at redhat.com>
Date:   Wed Oct 16 14:33:06 2019 +0530

    s3/dump_core: Have a newline towards the end of log message
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>
    
    Autobuild-User(master): Uri Simchoni <uri at samba.org>
    Autobuild-Date(master): Fri Oct 18 08:54:04 UTC 2019 on sn-devel-184

commit c4e902be7226e596d7bbba8baf4389eeab0ca8b6
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Fri Apr 12 00:46:49 2019 +0200

    Add fuzzing binary for ldb_parse_tree
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit de7c78335de63f95f97f946aec287b7bb87f6b47
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Wed Apr 10 01:20:36 2019 +0200

    Add fuzzing binary for ldap_decode
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit f9c39237adfaf1ea223e5c810d019f433af95cf0
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Wed Apr 10 00:36:03 2019 +0200

    Add fuzzing binary for lzxpress
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit a42a5a42f79cc886d752de1645638e24c600c4d0
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Thu Apr 4 02:26:26 2019 +0200

    Add fuzzing binary for regfio
    
    Checksums are better ignored during fuzzing, hence a flag is added to
    the regfio parser to disable checksums.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 6b6df73b4ce20286b1b7370750d11d0d648d7752
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Mon Sep 23 21:53:55 2019 +0000

    regfio: Allow ignoring of checksum
    
    In order to get good coverage fuzzing code has to either calculate
    checksums correctly or to disable their verification. This change
    implements the latter for the "REGF_FILE" structure used by the
    "regfio_*" family of functions.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit e477a94ffd3795d7d8aa83e899e9b0f2f9860a79
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Fri Apr 5 00:50:09 2019 +0200

    Add fuzzing binary for reg_parse
    
    A temporary file is used to store the fuzzing input.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 799a1f65f6cc80256b6e140b7763396d76d4a830
Author: Michael Hanselmann <public at hansmi.ch>
Date:   Mon Sep 23 21:47:51 2019 +0000

    Build registry parsing code into subsystem
    
    Fuzzing code will make use of the "reg_parse_fd" function. By building
    it into the "SMBREGISTRY" subsystem it can just be linked and
    "reg_parse.c" doesn't need to be explicitly included.
    
    Signed-off-by: Michael Hanselmann <public at hansmi.ch>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Uri Simchoni <uri at samba.org>

commit 68155811aba10a498cc07bf8a1c6f3a092e6147c
Author: Rowland Penny <rowland at devstation.samdom.example.com>
Date:   Tue Jul 2 13:41:34 2019 +0100

    samba-tool: Add facility to add rfc2307 attributes to an already created user or group
    
    Signed-off-by: Rowland Penny <rpenny at samba.org>
    Reviewed-by: David Mulder <dmulder at suse.com>
    Reviewed-by: Andrew Bartlet <abartlet at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Oct 17 12:21:55 UTC 2019 on sn-devel-184

commit aacbd383b9e843b5d36b91ef75f6f2d2724a438b
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Fri Jun 28 04:51:57 2019 +0530

    samba-tool: Update 'samba-tool gpo list <>' description
    
    We have a command to get gpo listing from Active Directory.
    samba-tool gpo list <username>
    
    This command can list GPOs for both username and machinename,
    But command help only shows 'username'.
    
    This PR
    - Updates the option presented in help.
    - Updates name of variable used to retrieve GPO so that it's
     not misleading if someone reads code later on
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14016
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Oct 17 09:21:20 UTC 2019 on sn-devel-184

commit 6bd2f0e9c4da1cad10a778da0c86e14d69ad5036
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Fri Sep 27 01:42:20 2019 -0500

    docs: modifies 'net ads dns gethostbyname -h' Changes server to nameserver and name to hostname.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14009
    
    Signed-off-by: Amit Kumar amitkuma at redhat.com
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit dd43bb96fda3c030662b810fd82bafb03ac93aa2
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Wed Jun 26 01:18:52 2019 +0530

    docs: Add 'ads dns command' text in man net
    
    This change adds contents to man net for 'ads dns' command set.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14009
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit aed4d0637675629a33585a0198c8cbbb64371638
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Thu Jun 6 08:40:42 2019 +1200

    libcli smb smb1cli_trans: fix ubsan warning
    
    Fix ubsan warning null pointer passed as argument 2 when the source
    pointer is NULL.  The calls to memcpy are now guarded by an
    if (len > 0)
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct 16 18:00:31 UTC 2019 on sn-devel-184

commit 50cce842a230f82018be62fca8fe1374b9b0dcd1
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Thu Jun 6 01:54:31 2019 +0530

    docs: Add 'net gpo command' text in man net
    
    This change adds contents to man net for 'net ads gpo' command
    set based on results got after executing:
    '# net ads gpo help' and subcommands
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13986
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit eb093c5d2ac77889215356ffabb915861cd4e9d5
Author: Amit Kumar <amitkuma at redhat.com>
Date:   Fri May 31 18:57:52 2019 +0530

    s3:winbind: Don't abort when receiving a NULL SID
    
    Source code in winbind_rpc.c states that if the trusted domain
    has no SID, winbindd just aborts the session. This happens with
    MIT Kerberos realm added as trust to AD and winbindd just returns
    without processing further as there is no SID returned for the
    Linux system having kerberos support.
    
    This fix makes winbindd to skip the domain having NULL SID instead
    of aborting the request completely.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13913
    
    Signed-off-by: Amit Kumar <amitkuma at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d023b29876dc1449014c3cf5d19abb6f186e166c
Author: Gary Lockyer <gary at catalyst.net.nz>
Date:   Tue May 21 08:49:08 2019 +1200

    selftest: Disable RTLD_DEEPBIND if running with ASAN
    
    Disable the RTLD_DEEPBIND option for dlopen in LDB and Socket Wrapper when
    running with  AddressSanitizer. The RTLD_DEEPBIND option is not compatible
    with Address Sanitizer see
    https://github.com/google/sanitizers/issues/611
    
    Signed-off-by: Gary Lockyer <gary at catalyst.net.nz>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct 16 15:41:41 UTC 2019 on sn-devel-184

commit f0abf62adcf4bda6dd7b36ce74695f8ac8ec79f6
Author: Bryan Mason <bmason at redhat.com>
Date:   Wed Sep 25 18:49:56 2019 -0700

    s3:tests: Add smbspool test for CUPS-like "sanitized" Device URI in argv[0]
    
    Before calling a backend like smbspool, CUPS will set argv[0] to the
    "sanitized" Device URI (the Device URI with username/password
    information removed).  These changes are intended to catch problems
    with smbspool that may be created by this behavior (like
    https://bugzilla.samba.org/show_bug.cgi?id=14128).
    
    source3/script/tests/smbspool_argv_wrapper.c: added to emulate
    CUPS-like behavior by setting argv[0] to the device URI before
    exec()ing smbspool.
    
    source3/script/tests/test_smbspool.sh: updated to use
    smbspool_argv_wrapper to test the CUPS-like behavior described above.
    
    Signed-off-by: Bryan Mason <bmason at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct 16 10:55:04 UTC 2019 on sn-devel-184

commit 7259197bf716f8b81dea74beefe6ee3b1239f172
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Oct 15 17:01:48 2019 +0300

    s3:libsmb: Link libsmb against pthread
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit d473f1e38c2822746030516269b4d70032cf9b2e
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Tue Oct 15 13:52:42 2019 +0300

    nsswitch: Link stress-nss-libwbclient against pthread
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit b01169ff32188939752c064e2eb803f57a837522
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:35:37 2019 -0700

    s3: VFS: Complete the removal of SMB_VFS_CHOWN()
    
    No longer used anywhere.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Oct 15 20:07:51 UTC 2019 on sn-devel-184

commit e2863a7e395bc5b73f8d9ef7bca7c21f20c7eeb3
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:30:42 2019 -0700

    s3: VFS: vfs_full_audit: Remove chown_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the chown_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit bd807d4684b48047ab2241602bb46af38a9d0f33
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:29:30 2019 -0700

    s3: VFS: vfs_time_audit: Remove chown_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the chown_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit ce63e83a6af38a0ac5e353a0cfd6c6cc1d2daa13
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:28:38 2019 -0700

    s3: VFS: vfs_cap: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 04e70da30b2166a5cfc73484cb156c66d4e1faf5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:27:36 2019 -0700

    s3: VFS: vfs_snapper: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 1516e9e2859bb33bec5e829c1ca9011c2563d801
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:26:59 2019 -0700

    s3: VFS: vfs_shadow_copy2: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3e2c2fdf0271e48538d8004ef03aac7e9d6eec3f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:26:12 2019 -0700

    s3: VFS: vfs_media_harmony: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3e8f319606b898b803c1368154c87ee41dc2c78b
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:25:31 2019 -0700

    s3: VFS: vfs_glusterfs: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3a853a1d3b5b6c8d82a7887b35fd383bab0c6c1b
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:24:46 2019 -0700

    s3: VFS: vfs_fruit: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 774b8f9ffb287c6011518caf341fed4538bc8eb5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:24:00 2019 -0700

    s3: VFS: vfs_fake_acls: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 3f8f797975931854e485fbf649b75897f0d6f775
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:23:15 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 95a6505e1bcbe89d0d39286668b04b948b1bed4f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:22:35 2019 -0700

    s3: VFS: vfs_ceph: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 48335c1f69076ffa7bdbca99a5025f61148506fd
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:21:51 2019 -0700

    s3: VFS: vfs_catia: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 2eca6d5b9551bd387e809fc77e496a2dc2c1595a
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:20:02 2019 -0700

    s3: VFS: vfs_cap: Remove chown_fn().
    
    No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 177f15ebb9e29a4cc6843a300f3da0ba7530332d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:18:32 2019 -0700

    s3: torture: Remove cmd_chown() - can be replicated by cmd_open()->cmd_fchown().
    
    Last user of SMB_VFS_CHOWN() in the codebase.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 634a4d13e197e01ae509c88bd6c6487008a86f71
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 10 14:14:13 2019 -0700

    s3: pysmbd: Change py_smbd_chown() to use SMB_VFS_FCHOWN() internally.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 99bfdb6e81925760af2a6e89fc6ac55768c88b78
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 8 13:46:02 2019 -0700

    s3: smbd: Remove vfs_chown_fsp().
    
    No longer used. This gets rid of another case
    where we were playing directory changing games
    that are eliminated by just using a file handle.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit 2dbc68e2c0212e3e14f304e359d4d0b1ab514ce2
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Oct 8 13:45:45 2019 -0700

    s3: smbd: set_nt_acl(). Now we know we always have a valid file handle, always use VFS_FCHOWN.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Böhme <slow at samba.org>

commit c16cc9a7ef3dc50df511d6a39437347ebc36383e
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Oct 11 08:28:30 2019 +0200

    audit_logging: Don't spam the logs if dsdb_event is not found
    
    This gets only registered by our tests.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at catalyst.net.nz>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Oct 14 07:41:52 UTC 2019 on sn-devel-184

commit 123584294cfd153acc2d9a5be9d71c395c847a25
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 16:32:47 2019 +0200

    s3:libads: Do not turn on canonicalization flag for MIT Kerberos
    
    This partially reverts 303b7e59a286896888ee2473995fc50bb2b5ce5e.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14155
    
    Pair-Programmed-With: Isaac Boukris <iboukris at redhat.com>
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Sat Oct 12 17:39:13 UTC 2019 on sn-devel-184

commit 93c2b446755bd89c7ace8c6ee0445a361f8e17ca
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 16:59:59 2019 +0200

    testprogs: Add test for kinit with canonicalization
    
    Pair-Programmed-With: Isaac Boukris <iboukris at redhat.com>
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 0cad882380cc361a4106dc12aeb0582a6dccdd88
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 16:57:11 2019 +0200

    s4:selftest: Do not print the target env twice
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 46068d5f289948a7d478c23391e0036f69d693a4
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 15:55:50 2019 +0200

    gitlab-ci: Run several AD tests with MIT KDC
    
    This will avoid introducing regressions in either client or server code.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit a06889f6d774ba62be2103da2340b98b3ada6654
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Oct 10 09:14:24 2019 +0200

    s4:selftest: Do not print the target env twice
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d888655244b4d8ec7a69a042e0ff3c074585b0de
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 9 20:11:03 2019 +0200

    lib:krb5_wrap: Do not create a temporary file for MEMORY keytabs
    
    The autobuild cleanup script fails with:
    
    The tree has 3 new uncommitted files!!!
    git clean -n
    Would remove MEMORY:tmp_smb_creds_SK98Lv
    Would remove MEMORY:tmp_smb_creds_kornU6
    Would remove MEMORY:tmp_smb_creds_ljR828
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 23ea12e98ed34d41aee78d8afbe574dfc7e0ff74
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 4 17:04:12 2019 +0300

    spnego: fix server handling of no optimistic exchange
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Sat Oct 12 15:51:42 UTC 2019 on sn-devel-184

commit 8a96359977249e8b19f50e5f2fe3f6ad7b7da52f
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Fri Oct 11 00:20:16 2019 +0300

    python/tests/gensec: add spnego downgrade python tests
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Pair-Programmed-With: Andreas Schneider <asn at samba.org>
    
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit eee1e8b6ac622e22a34ebfb684e70626cdd20fc1
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Oct 11 13:23:17 2019 +0200

    python/tests/gensec: make it possible to add knownfail tests for gensec.update()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 02f538816b409f1a122fae8fd08d761e3617e798
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 4 16:39:43 2019 +0300

    selftest: add tests for no optimistic spnego exchange
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit d7e57ef7dd7d583cffb7abbe42d71f4f33f2a9af
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Wed Sep 4 16:31:21 2019 +0300

    spnego: add client option to omit sending an optimistic token
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 90f557f3a1ed0a49e88ab0db29999f1289486cfe
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Mon Oct 7 23:51:19 2019 +0300

    selftest: s3: add a test for spnego downgrade from krb5 to ntlm
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 7e36de99d7d028a01d4c52c2974d990ef91017bb
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Oct 10 16:18:21 2019 +0200

    s3:libsmb: Do not check the SPNEGO neg token for KRB5
    
    The list is not protected and this could be a downgrade attack.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Pair-Programmed-With: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 37daeb220e461b842ad9708497699f15c5fa5df3
Author: Isaac Boukris <iboukris at gmail.com>
Date:   Thu Oct 3 13:09:29 2019 +0300

    spnego: ignore server mech_types list
    
    We should not use the mech list sent by the server in the last
    'negotiate' packet in CIFS protocol, as it is not protected and
    may be subject to downgrade attacks.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14106
    
    Signed-off-by: Isaac Boukris <iboukris at redhat.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit efb43ecb8e3994171efeb8f8b4231fdd420ace0b
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 30 11:52:06 2019 +0200

    wscript: split function check to one per line and sort alphabetically
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Oct 10 20:13:25 UTC 2019 on sn-devel-184

commit 834d528213d60a0fc5daed46ed0e51dad578b877
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 30 11:49:28 2019 +0200

    wscript: remove all checks for _FUNC and __FUNC
    
    Those where historic artifacts not needed anymore.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 04b9369656d4a7cec1c12ea614286fbfc5495eb0
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Oct 1 17:38:57 2019 +0200

    WHATSNEW: Mention performance improvements for SMB3 encryption
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Thu Oct 10 09:41:26 UTC 2019 on sn-devel-184

commit d7bb9f54250f170ea18aad08a98862f7054d8579
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 17:08:56 2019 +1200

    librpc: Remove server build of oxidresolver.idl
    
    We do not have a server for this DCOM component so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b273924b8a2dd32a949f37be8ff53298bff81bb4
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:58:35 2019 +1200

    librpc: Remove client and server build of w32time.idl
    
    We do not have a server for the Win32 Time Server so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c46191b8781b076ed872f14e01592997def44f89
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:57:48 2019 +1200

    librpc: Remove client and server build of rot.idl
    
    We do not have a client or server for this DCOM component so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 091e8fe14b51c550ea9d8360651378ebb0e3491b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:47:48 2019 +1200

    librpc: Remove s4 server build of dfs
    
    We do not have a source4 varient of the dfs server, so do not generate
    the code for it.
    
    DFS is very closely tied to SMB so we use the DFS server in
    smbd.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 718f9da0a7fb9f48660016a7baafecdb3ed6e4e0
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:40:47 2019 +1200

    librpc: Remove s3 server build of unixinfo
    
    We do not have a source3 varient of the unixinfo server, so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 83fae584867babbb602da7096160bdc811dcf337
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:39:11 2019 +1200

    librpc: Add commnets on the split out of IDL files
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 759660b16a75a43b910001f9e8502d180a4ba89e
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:37:31 2019 +1200

    librpc: Remove server build of remact.idl
    
    We do not have a server for the DCOM Remote activation service, so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6250fe29dd63e803d0dc3cbd8cef5944bf9911d2
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:34:19 2019 +1200

    librpc: Remove s4 server build of ntsvcs
    
    We do not have a source4 varient of the ntsvcs server, so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8216c2187f1efa9cf114f705252a452e5b6721d1
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:32:38 2019 +1200

    librpc: Remove s4 server build of initshutdown
    
    We do not have a source4 varient of the initshutdown server, so do not generate
    the code for it.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f45ceb0df99afd7cdbf05cb8d0f00b0a1b5bdd0a
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Mon Sep 23 16:31:07 2019 +1200

    librpc: Remove unused build of atsvc server
    
    This avoids building server-side code we do not use and so makes the build
    smaller and code auditing easier.
    
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 81fbba8f649e4115961eb77462ca450e7a30611e
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:41:21 2019 -0700

    s3: VFS: Complete the removal of SMB_VFS_RMDIR()
    
    All users now use SMB_VFS_UNLINKAT(..., AT_REMOVEDIR).
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Thu Oct 10 07:26:43 UTC 2019 on sn-devel-184

commit 5bf96b1f0b61847771aab7be35121a1d5c15554e
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:23:44 2019 -0700

    s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the rmdir_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4fcd20cd6bfc646f4ee9319aae0bf6306f1c1a7c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:22:19 2019 -0700

    s3: VFS: vfs_time_audit: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 14e24881c4e2839e896c3b6e8b94ecc7a990947f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:21:21 2019 -0700

    s3: VFS: vfs_syncops: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ffa09e09e87ff82d0091529230d9122358d70e96
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:17:32 2019 -0700

    s3: VFS: vfs_streams_depot: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a940c4c5ac180acf15d005fb3d4fa4a0b3e9b448
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:10:58 2019 -0700

    s3: VFS: vfs_snapper: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8bb2c7b8989411ac7ebd06ef6621b2a38acf7243
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:10:07 2019 -0700

    s3: VFS: vfs_shadow_copy2: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8e65a8c2e7ddbc3a53f7adf240cb2a31eb4fdc51
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:09:00 2019 -0700

    s3: VFS: vfs_posix_eadb: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ae28488fb0447d1e3135d5f9569a633fe75c4661
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:52:18 2019 -0700

    s3: VFS: vfs_media_harmony: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5e1e58a1e7734f0b607c24b4f71a6f6224994bab
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:51:15 2019 -0700

    s3: VFS: vfs_glusterfs: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ea386e13fc41cd1c42d6708b9898e74bfc8bb375
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:49:54 2019 -0700

    s3: VFS: vfs_extd_audit: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 09d33f5b31f591c18a29be2265a4b536f3348c2b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:44:48 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 882babe6de7b6410434868294541492181b3b4aa
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:44:08 2019 -0700

    s3: VFS: vfs_ceph: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b79c7d28738e5e9a33d5f7db9db61116295ac5d5
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:43:11 2019 -0700

    s3: VFS: vfs_catia: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b222c486b36e4cff7d827aedb90f5bfa5c3a9fd3
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:42:26 2019 -0700

    s3: VFS: vfs_cap: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8a18518edead4c828a62615365c99624e4315e69
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:41:26 2019 -0700

    s3: VFS: vfs_audit: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 26eb0e70bc8aa12890cdc23c3ea6c2e0d408848b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:40:26 2019 -0700

    s3: VFS: vfs_acl_xattr: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 19a4c5a99334ac38becdf6197e154f98c0455ff6
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:39:30 2019 -0700

    s3: VFS: vfs_acl_tdb: Remove rmdir_fn(). No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 060eb647f437f4fefb4e511061e48dd62d0c3099
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:14:17 2019 -0700

    s3: VFS: vfs_fruit: Remove rmdir_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 44f9adc155fc59836580e1d9bc4820d547082fbd
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:01:55 2019 -0700

    s3: VFS: vfs_unityed_media: Remove rmdir_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 305f2b8d01c5e9ecaa599372f75656169e777c7f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 13:53:13 2019 -0700

    s3: VFS: vfs_xattr_tdb: Remove rmdir_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4ce152f1c43a2eb5c96da2f24b3829e4118774e2
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 13:51:09 2019 -0700

    s3: smbd: Change rmdir_internals() to call SMB_VFS_UNLINKAT() in rmdir cases.
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit ca5e8938ce36835b5f381379560e77fb6cf9cf90
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 12:54:05 2019 -0700

    s3: smbd: Change recursive_rmdir() to call SMB_VFS_UNLINKAT() in rmdir case.
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7991a12e3f2b76220ab9885a98f4b427f035af81
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 12:51:06 2019 -0700

    s3: cmd_vfs: Change cmd_pathfunc() to call SMB_VFS_UNLINKAT() in rmdir case.
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 576a143deb3aa2ab4ba183a8e81874d6210e9026
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:03:39 2019 -0700

    s3: VFS: vfs_fruit: Change fruit_rmdir_internal() to call UNLINKAT instead of RMDIR.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c6235f297e7da35411c0effa2394bdc679e433c9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:40:34 2019 -0700

    s3: VFS: vfs_streams_depot: Change RMDIR -> UNLINKAT inside streams_depot_unlink_internal().
    
    No logic change.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9c5dc89c0b1a3c33840428d04034abe4dcfbbd7b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:38:45 2019 -0700

    s3: VFS: vfs_streams_depot: Change RMDIR -> UNLINKAT inside stream_dir().
    
    No logic change.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d9091d8fa96645886e7fb35ac95ed0f5b2f5c72a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:14:21 2019 -0700

    s3: VFS: vfs_streams_depot: Add a dirfsp parameter to streams_depot_rmdir_internal().
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 48ad93aec53e547de5919ec13056c7a4fd5cbf02
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:12:30 2019 -0700

    s3: VFS: vfs_streams_depot: Rename streams_depot_rmdir() to streams_depot_rmdir_internal().
    
    Make rmdir_fn() a wrapper function. This will
    allow us to add the dirfsp parameter.
    
    Fix DEBUG statement so it doesn't print the wrong function name.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 881ee37c81c0b94c62c92cd4debf2fe52ad7cd63
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:16:06 2019 -0700

    s3: VFS: vfs_posix_eadb: Convert streams_depot_rmdir_internal() to call UNLINKAT() instead of RMDIR().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a8507856ef1fc005a0fefa6e764663b48ec8ea1b
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:07:46 2019 -0700

    s3: VFS: vfs_posix_eadb: Convert posix_eadb_rmdir_internal() to call UNLINKAT() instead of RMDIR().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3221bab80feff7f9e3af05c08f13ecb3a0cf8cde
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:06:23 2019 -0700

    s3: VFS: vfs_posix_eadb: Add a dirfsp parameter to posix_eadb_rmdir_internal().
    
    Not yet used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4e028aeaff99b4fee71925bca8d3eae0a4841947
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 15:04:02 2019 -0700

    s3: VFS: vfs_posix_eadb: Rename posix_eadb_rmdir() to posix_eadb_rmdir_internal().
    
    Make rmdir_fn() a wrapper function. This will
    allow us to add the dirfsp parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0df3371e7a483fd286e96f95c8a4c227e2b686ab
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:37:01 2019 -0700

    s3: VFS: vfs_acl_common: Convert rmdir_acl_common() to use UNLINKAT instead of RMDIR.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7f54bc8794b7dc48b1f0b4c500a144c830f3da74
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:34:41 2019 -0700

    s3: VFS: Change rmdir_acl_common() to take a files_struct *dirfsp pointer.
    
    Pass in the passed dirfsp if available, else handle->conn->cwd_fsp.
    
    No logic changes.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1c0c3b61038631f06795fcd9a1424a666b117db1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:25:00 2019 -0700

    s3: VFS: vfs_acl_common: Change acl_common_remove_object() to use UNLINKAT instead of RMDIR.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9290510fe4d2b5ce88a6085e7047f1e6fafd6f5a
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Oct 4 14:31:59 2019 -0700

    s3: VFS: vfs_acl_xattr. Wrap rmdir_acl_common() by acl_xattr_rmdir() so we don't call it directly.
    
    This will allow adding the extra dirfsp parameter to
    rmdir_acl_common().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b4cbdddfb8729b6aa4729ea31da6090dd9e71383
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 8 17:37:56 2019 +0200

    smbd: Fix an uninitalized variable
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Oct 10 01:04:33 UTC 2019 on sn-devel-184

commit c9b6298249cd2f670e6953c9c3ef2e977f8bc565
Author: Ralph Boehme <slow at samba.org>
Date:   Fri Aug 23 18:43:02 2019 +0200

    mdssvc.idl: pass policy_handle as pointer
    
    No change in behaviour, this just changes all functions to take the
    policy_handle argument as pointer instead of passing it by value.
    This is how all other IDLs pass it.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Oct  9 15:52:55 UTC 2019 on sn-devel-184

commit 63cbeaf0e7472a7321f27327091217c909864100
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 20 17:00:49 2019 +0200

    s3:mdssvc: fix service startup in deamon mode
    
    Changes:
    
    * Don't initialize the RPC service by calling setup_rpc_module() in the parent
      mdssd. This is not needed in the parent, only in the worker childs.
    
    * In the worker childs call setup_rpc_module() instead of init_rpc_module()
      which ensures rpc_mdssvc_init() is called with the mdssvc callback which is
      needed to initialize mdssvc via mdssvc_init_cb() -> init_service_mdssvc()
    
    * Finally rpc_setup_mdssvc() is adjusted to be a noop if mdssvc is configured to
      as external and when called by the main parent smbd via dcesrv_ep_setup() ->
      setup_rpc_modules()
    
    I've manually tested all 4 combinations of external=yes|no X module=yes|no with
    the new mdfind command.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 78a2d95511357a5ea34473e6a6d98515b4344fb5
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 20 16:50:52 2019 +0200

    s3:mdssvc: use a helper variable for the service type
    
    No change in behaviour. Simplifies a subsequent logical change.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 91f397bec0dbc24b60f74e80ee413642d955d7bc
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 20 17:00:12 2019 +0200

    mdssd: fix a debug message
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit bf02a935083c858490b9aecd8949f8a57918615a
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Aug 19 15:50:36 2019 +0200

    s3: rpc_server: enable mdssvc by default
    
    Now that mdssvc is built by default and also tested in CI, enable it by default,
    running as embedded service.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit fa4c3fd9341412a9fc4a53923bf52f7433c08079
Author: Ralph Boehme <slow at samba.org>
Date:   Sat Aug 17 11:36:55 2019 +0200

    selftest: add mdfind blackbox test
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit c85cd5c4311512fff18b04267408eb60d7c8ecdf
Author: Ralph Boehme <slow at samba.org>
Date:   Thu May 2 21:33:46 2019 +0200

    s3:utils: add mdfind
    
    A small command line tool to run macOS Spotlight searches against an SMB server
    that runs the Spotlight mdssvc RPC service, including macOS and Samba.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit da7dec0a50fa5d9f6b92403d8703cd6b7a42159c
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Jul 28 15:25:54 2019 +0200

    selftest: add end-to-end tests for mdssvc with a fake HTTP server
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit f0e8dd1a08698884209873bb84002d7b34db016c
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 30 12:00:18 2019 +0200

    selftest: split fileserver testenv into simpleserver and fileserver
    
    The simpleserver testenv continues to be built with minimal
    dependencies. fileserver otoh will be built with bells and whistles including
    JSON which I need for using the env as target for Spotlight tests.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit f479e010961e652230c7e33876058c8fb82e9019
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Jul 30 12:47:03 2019 +0200

    s3:mdssvc: add unit tests for the Spotlight to Elasticsearch parser
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit f5510d7db3816c6a18dc333e1ae7f505fca69815
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Aug 5 16:25:01 2019 +0200

    s3:mdssvc: add Elasticsearch backend
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit c338bdf5a4aef16cb3048b18c77a0095f3fc3e53
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 13 14:16:07 2019 +0200

    s3:mdssvc: add missing mds_ctx deallocation
    
    The mds_ctx object was created in _mdssvc_open() as a talloc child of the pipe
    which means as long as the pipe is connected it's not freed.
    
    To ensure we do proper rundown of all resources including backend connections
    and pending queries, we must free the mds_ctx object.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit eb740b571d1ed5d55619c059160f236126351bd5
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 13 14:13:20 2019 +0200

    s3:mdssvc: fix a long line
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit ba899694e45aa2e691cf44098846fc0ddf3e79fd
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 13 14:11:23 2019 +0200

    s3:mdssvc: modernize a few DEBUG macros
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 08cb82d26f8f1a0dc66fadfcdee4f487ea06e010
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Aug 13 12:55:33 2019 +0200

    s3:mdssvc: remove unused snum from struct sl_query
    
    Looks like this was never used, it's also available via mds_ctx->snum.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit afc90321ecd47ec1a8b6196c9b4aa15c2c654d41
Author: Ralph Boehme <slow at samba.org>
Date:   Fri May 10 18:49:20 2019 +0200

    build: add SAMBA_DATADIR as "samba" subdirectory of DATADIR
    
    DATADIR should have been set to this path from the beginning, too late to change
    that now as ut's used as parent for two other directory varialbles: SETUPDIR and
    CODEPAGEDIR.
    
    From <https://www.gnu.org/prep/standards/html_node/Directory-Variables.html>:
    
      datadir
    
        The directory for installing idiosyncratic read-only
        architecture-independent data files for this program. This is usually the
        same place as ‘datarootdir’, but we use the two separate variables so that
        you can move these program-specific files without altering the location for
        Info files, man pages, etc.
    
        This should normally be /usr/local/share, but write it as
        $(datarootdir). (If you are using Autoconf, write it as ‘@datadir@’.)
    
        The definition of ‘datadir’ is the same for all packages, so you should
        install your data in a subdirectory thereof. Most packages install their
        data under $(datadir)/package-name/.
    
    Currently Samba doesn't install any application specific data files, but I'm
    going to do just that in a subsequent commit.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 213ca6e4cc981b4a9550042ce927c677883810be
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Jul 28 15:08:29 2019 +0200

    s3: add mdscli Python bindings
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit b27d9afa29435b7af6335f228b8a315701b2607a
Author: Ralph Boehme <slow at samba.org>
Date:   Thu May 2 07:45:39 2019 +0200

    s3:rpc_client: add a mdssvc client library
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 873aa1e6c8495c04eb21cfc38fc5a4ad401f80fd
Author: Ralph Boehme <slow at samba.org>
Date:   Sun Jul 28 15:05:13 2019 +0200

    librpc: add Python mdssvc bindings
    
    Not used for now, but soon.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Noel Power <noel.power at suse.com>

commit 459b43e5776180dc1540cd845b72ff78747ecd6f
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Aug 22 16:31:30 2019 +0200

    testprogs: Add test for 'net ads join createcomputer='
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Oct  9 08:26:17 UTC 2019 on sn-devel-184

commit 14f320fa1e40ecc3a43dabb0cecd57430270a521
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Aug 8 14:40:04 2019 +0200

    s3:libads: Just change the machine password if account already exists
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13884
    
    Pair-Programmed-With: Guenther Deschner <gd at samba.org>
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 39b8c8b30a5d5bd70f8da3a02cf77f7592788b94
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Aug 14 10:15:19 2019 +0200

    s3:libnet: Improve debug messages
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit ce7762935051c862ecdd3e82d93096aac61dd292
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Aug 13 16:34:34 2019 +0200

    s3:libads: Fix creating machine account using LDAP
    
    This implements the same behaviour as Windows.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13884
    
    Pair-Programmed-With: Guenther Deschner <gd at samba.org>
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit b755a6438022579dab1a403c81d60b1ed7efca38
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Aug 14 12:17:20 2019 +0200

    s3:libads: Don't set supported encryption types during account creation
    
    This is already handled by libnet_join_post_processing_ads_modify()
    which calls libnet_join_set_etypes() if encrytion types should be set.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4f389c1f78cdc2424795e3b2a1ce43818c400c2d
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Aug 14 13:01:19 2019 +0200

    s3:libads: Fix detection if acount already exists in ads_find_machine_count()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 35f3e4aed1f1c2ba1c8dc50921f238937f343357
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Aug 21 12:22:32 2019 +0200

    s3:libads: Use a talloc_asprintf in ads_find_machine_acct()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 8ed993789f93624b7b60dd5314fe5472e69e903a
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Aug 13 16:30:07 2019 +0200

    s3:libads: Cleanup error code paths in ads_create_machine_acct()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit b84abb3a46211dc84e52ef95750627e4dd081f2f
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Aug 13 17:41:40 2019 +0200

    s3:libnet: Require sealed LDAP SASL connections for joining
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 456322a61319a10aaedda5244488ea4e5aa5cb64
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Aug 13 17:06:58 2019 +0200

    s3:libads: Use ldap_add_ext_s() in ads_gen_add()
    
    ldap_add_s() is marked as deprecated.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 320b5be4dce95d8dac4b3c0847faf5b730754a37
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Aug 8 14:35:38 2019 +0200

    testprogs: Fix failure count in test_net_ads.sh
    
    There are missing ` at the end of the line.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13884
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4a24d9499757dea377b4e3d8beb7f2c10fd5c5d0
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Aug 23 09:12:21 2019 +0200

    libcli:smb: Use gnutls_aead_cipher_decryptv2() for AES GCM or CCM
    
    This is a new call which has been added with GnuTLS 3.6.10 and will
    recuduce memory allocations and copying of data.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Simo Sorce <idra at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Oct  8 14:12:44 UTC 2019 on sn-devel-184

commit 70fdd4821aa811f90944bee17cc85e3ae9302279
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Aug 23 08:54:54 2019 +0200

    libcli:smb: Use gnutls_aead_cipher_encryptv2() for AES GCM or CCM
    
    This is a new call which has been added with GnuTLS 3.6.10 and will
    recuduce memory allocations and copying of data.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Simo Sorce <idra at samba.org>

commit fa255a36df87e41717d9630ea96ac9439e186062
Author: Andreas Schneider <asn at samba.org>
Date:   Fri Aug 23 08:40:00 2019 +0200

    waf: Check for gnutls_aead_cipher_encryptv2()
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Simo Sorce <idra at samba.org>

commit 5a084994144704a6c146b94f8a22cf57ce08deab
Author: Alexander Bokovoy <ab at samba.org>
Date:   Mon Oct 7 18:24:28 2019 +0300

    samba-tool: create working private krb5.conf
    
    DNS update tool uses private krb5.conf which should have enough details
    to authenticate with GSS-TSIG when running nsupdate.
    
    Unfortunately, the configuration we provide is not enough. We set
    defaults to not lookup REALM via DNS but at the same time we don't
    provide any realm definition. As result, MIT Kerberos cannot actually
    find a working realm for Samba AD deployment because it cannot query DNS
    for a realm discovery or pick it up from the configuration.
    
    Extend private krb5.conf with a realm definition that will allow MIT
    Kerberos to look up KDC over DNS.
    
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 0abd1189a60eea4501b5279ebc4bff2b5689f888
Author: Anoop C S <anoopcs at redhat.com>
Date:   Fri Sep 27 12:07:40 2019 +0530

    s3: VFS: Use SMB_VFS_FCNTL to set fd flags in open_file()
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Tue Oct  8 09:57:19 UTC 2019 on sn-devel-184

commit 5084a69de14f24e9d804998580eefcba773fdd5a
Author: Anoop C S <anoopcs at redhat.com>
Date:   Fri Sep 27 11:19:37 2019 +0530

    s3: VFS: Add SMB_VFS_FCNTL
    
    Signed-off-by: Anoop C S <anoopcs at redhat.com>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c9d302f20b066267a8fd2d7ce4dc171161c9c40c
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 7 11:28:24 2019 +0200

    gitlab-ci: Add CentOS 8 to CI
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Oct  8 08:27:50 UTC 2019 on sn-devel-184

commit 9cd0d15370142b3694a51fa9b6cfffdb8e08e886
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 7 13:28:07 2019 +0200

    bootstrap: We can only build docker images on gitlab shared runners
    
    Our rackspace runners don't provide a running docker.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 42edab7bd76022dd4d5338012f29aed29a2a2d89
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Oct 7 11:50:58 2019 +0200

    bootstrap: Remove pyhton2 packages
    
    We dropped support for python2 in Samba already.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 7bceafe8401fdbf67c065d6799ea91d9667fd096
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 14:48:54 2019 +0000

    s3/passdb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_ldap.c:1933:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
                     ^~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/passdb/pdb_ldap.c:4094:11: warning: Value stored to 'ntstatus' during its initialization is never read <--[clang]
            NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Oct  8 02:40:24 UTC 2019 on sn-devel-184

commit 78161550bac4bdbbea7f187b70413c55ef62fad2
Author: Gordon Ross <gwr at nexenta.com>
Date:   Mon May 9 13:45:07 2016 -0400

    torture: Allow running on FS that does not support EAs
    
    Signed-off-by: Gordon Ross <gordon.w.ross at gmail.com>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Mon Oct  7 22:05:59 UTC 2019 on sn-devel-184

commit 222f2538636d247f6ca067e0f8a174799143b155
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Oct 2 14:27:41 2019 +0200

    replace: Improve sys/sysctl.h check to catch warning on glibc >= 2.30
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Oct  7 11:48:24 UTC 2019 on sn-devel-184

commit 7c2745d41e808b7240358f5d0702dfe7abdc93a1
Author: Günther Deschner <gd at samba.org>
Date:   Sat Sep 28 13:10:32 2019 +0200

    libcli/auth: add gnutls test for aes-128-cfb8 cipher bug
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Mon Oct  7 09:31:35 UTC 2019 on sn-devel-184

commit f988756599c2f7253989f2ca1dea2975dd89e6ea
Author: Günther Deschner <gd at samba.org>
Date:   Tue Sep 17 22:37:06 2019 +0200

    auth/gensec: fix AES schannel seal and unseal
    
    Workaround bug present in gnutls 3.6.8:
    
    gnutls_cipher_decrypt() uses an optimization
    internally that breaks decryption when processing
    buffers with their length not being a multiple
    of the blocksize.
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Pair-Programmed-With: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 709d54d68a9c2cb3cda91d9ab63228a7adbaceb4
Author: Günther Deschner <gd at samba.org>
Date:   Fri Sep 20 18:32:43 2019 +0200

    auth/gensec: fix non-AES schannel seal
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14134
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 7eae4280d23404be7d27f65a0c817bea2e0084b6
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 25 23:44:49 2019 +0200

    libcli/auth: add test for gensec_schannel code
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ea82bca8cef0d736305a7a40b3198fc55ea66af8
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Oct 3 14:02:13 2019 -0700

    s3: smbclient: Stop an SMB2-connection from blundering into SMB1-specific calls.
    
    Fix in the same way this was done in SMBC_opendir_ctx() for libsmbclient.
    This fix means the admin no longer has to remember to set 'min client protocol ='
    when connecting to an SMB2-only server (MacOSX for example) and trying to
    list shares.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14152
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 4b62c4f7addba3ce47f1d0d5f2b64103602b7ca2
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Oct 4 10:40:18 2019 +0200

    lib/replace: Remove libaio support
    
    io_uring is the way to go these days, libaio was never really useful
    for Samba
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Oct  4 18:18:41 UTC 2019 on sn-devel-184

commit bcbadeb82656fafb68b506a3067999c03c481cd2
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Oct 4 10:36:30 2019 +0200

    ntvfs: Remove pvfs_aio.c
    
    This uses the Linux libaio that does not meet Samba's needs. If
    someone wanted to add async I/O to ntvfs, the io_uring API is the way
    to go. Second option would be to use a pthreads-based API.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 0bddee8dac095016e892731abe9e5a668c38375d
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Oct 3 17:25:10 2019 +1000

    ctdb-tests: Rename functions to test_header() and test_footer()
    
    That's all they do now.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Fri Oct  4 10:58:10 UTC 2019 on sn-devel-184

commit 435d903ad84e72e8223ae53ca46bb47c1cfe1293
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Sep 10 10:51:31 2019 +1000

    ctdb-tests: Move test duration calculation to ctdb_test_run()
    
    It makes sense to do this in one place in case other headers/footers
    are added.
    
    Reindent ctdb_test_begin() while touching this function.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 23982477f3d486815974edce08a247d7280c9578
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 12:36:05 2019 +1000

    ctdb-tests: Add handling for skipped tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 473a6fed11a2e63d9cd557f63fdb646bd040deda
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 12:31:10 2019 +1000

    ctdb-tests: Add a special failure code when a test error occurs
    
    Use it when a test is not executable.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 55dd0f047f58f9be2d1a317dfcbebe18e22201a0
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 20:57:42 2019 +1000

    ctdb-tests: Move test status interpretation to ctdb_test_run()
    
    It makes sense to do this in one place in case other headers/footers
    are added.
    
    Simplify ctdb_test_end() accordingly, reindenting because nearly all
    lines are modified.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 47c9b79262ee4101d29c977d98933bfcf22f7426
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 12:25:06 2019 +1000

    ctdb-tests: Move use of show_progress() into ctdb_test_run()
    
    This allows more variables to be set in this function because they are
    no longer in a sub-shell.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit e7e6f4067e4a0de1ccfc8650fb0e87b8b6e0d620
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 20:51:51 2019 +1000

    ctdb-tests: Simplify ctdb_test_run()
    
    Only the test file name is ever passed.
    
    Reindent while touching many existing lines.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit dc8ddbb0843abdc547055d57184e6cd1ba8e3147
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 16:08:41 2019 +1000

    ctdb-tests: Switch TEST_CLEANUP and TEST_TIMEOUT to script variables
    
    These are not used outside this script so they do not need to be
    environment variables.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 0ec83f32faddf6ef9f5fdd11ecd6d651459dd650
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Aug 12 21:01:20 2019 +1000

    ctdb-tests: Add new test functions for running commands on nodes
    
    * ctdb_onnode()
    * testprog_onnode()
    * function_onnode()
    
    These encapsulate familiar patterns found when running
    try_command_on_node().  The new function names are more concise and
    encourage more readable tests.  Test writers can do less thinking
    about the subtleties of running different types of commands on nodes.
    For example, these functions ensure that $CTDB and $VALGRIND are used
    in the correct contexts.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 38b838b59cbece5c6a7bda40e8d411a6c56d1458
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Aug 13 21:43:32 2019 +1000

    ctdb-tests: try_command_on_node() should return status of command
    
    There is no point folding this down to 1.  Tests should be able to see
    the original value, if required.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit e494eb3e8c054a7aa56d2f201459934d1248642a
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 12 12:21:13 2019 +1000

    ctdb-tests: Drop unused function ctdb_test_check_real_cluster()
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 38138b42f7c42aca01dccd7b61784f0ddc2570f2
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 11 16:07:49 2019 +1000

    ctdb-tests: Update preamble for CLUSTER tests
    
    The main change is to source cluster.bash instead of integration.bash.
    
    While touching the preamble, the following additional changes are also
    made:
    
    * Drop test_info() definition and replace it with a comment
    
      The use of test_info() is pointless.
    
    * Drop call to ctdb_test_check_real_cluster()
    
      cluster.bash now does this.
    
    * Drop call to cluster_is_healthy()
    
      This is a holdover from when the previous test would restart daemons
      to get things ready for a test.  There was also a bug where going
      into recovery during the restart would sometimes cause the cluster
      to become unhealthy.  If we really need something like this then we
      can add it to ctdb_test_init().
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 653b35764a2b4e999dbe6a71c1de2c9554d6fc4d
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 11 15:44:20 2019 +1000

    ctdb-tests: Add cluster.bash include file
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 5ad356c282044db251c395db06900b249ff07544
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 11:43:53 2019 +1000

    ctdb-tests: Add function ctdb_test_skip_on_cluster()
    
    Use it in relevant tests.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 59055f4da1ac4747c771a8acf2392b5e4599679b
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Oct 2 15:08:18 2019 +1000

    ctdb-tests: Add function ctdb_test_on_cluster()
    
    This centralises this logic.  Use it in a subset of tests - there are
    other cases but these will be cleaned up soon.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 65ca431c95e53e8686c2887d8c8ddaf67999305b
Author: Martin Schwenke <martin at meltin.net>
Date:   Tue Sep 17 16:00:13 2019 +1000

    ctdb-tests: Add functions for terminating tests on failure, skip, error
    
    This allows standard exit codes for failed and skipped tests, and test
    errors.
    
    Skipped tests currently just succeed and a test error is the same as a
    failure.  These can be easily changed later when run_tests.sh is ready
    to handle them.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 2c54f6df7164d6263624a1ed72485bf4e6690bb6
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Oct 2 17:52:31 2019 +1000

    ctdb-common: Mark VacuumLimit tunable as obsolete
    
    Use of this tunable was dropped over 5 years ago in commit
    16837bc309aa9a86fc21d7f59a8fce0b947428a3.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Fri Oct  4 07:07:21 UTC 2019 on sn-devel-184

commit 815ae644006a11301c1ee81fdd4dcbf13de38141
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Oct 2 17:51:12 2019 +1000

    ctdb-vacuum: Drop debug level of repacking message to NOTICE
    
    This occurs rarely but can adversely impact performance, so it is
    worth logging it more frequently.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a8c4e7d1f6b3375e2cdac962133919cce91f7c1d
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 23 16:11:00 2019 +1000

    ctdb-protocol: Initialise request->rdata.opcode where missing
    
    Otherwise it is uninitialised, so...
    
    ==22889== Conditional jump or move depends on uninitialised value(s)
    ==22889==    at 0x12257B: ctdb_req_control_data_len (protocol_control.c:39)
    ==22889==    by 0x1228E9: ctdb_req_control_len (protocol_control.c:1786)
    ==22889==    by 0x12A51C: ctdb_client_control_send (client_control.c:101)
    ==22889==    by 0x138BE1: ctdb_tunnel_setup_send (client_tunnel.c:100)
    ==22889==    by 0x10EE4F: tunnel_test_send (tunnel_test.c:135)
    ==22889==    by 0x10EE4F: main (tunnel_test.c:463)
    
    and similar.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 33f1c9d9654fbdcb99c23f9d23c4bbe2cc596b98
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Mon Sep 30 16:34:35 2019 +1000

    ctdb-vacuum: Process all records not deleted on a remote node
    
    This currently skips the last record.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14147
    RN: Avoid potential data loss during recovery after vacuuming error
    
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>
    Reviewed-by: Martin Schwenke <martin at meltin.net>

commit fe41238097f4354f18130c43ea3c5db0293097c7
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 19:24:18 2019 -0700

    rpcclient: Remove unused global domain sid
    
    For the auth_log tests using rpcclient this means one message less
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Oct  3 17:59:13 UTC 2019 on sn-devel-184

commit 8a094672212eb49291ff6c8c9441a0a6c71c1561
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 19:22:55 2019 -0700

    rpcclient: Remove domain sid check
    
    The samr calls can take care of this on their own
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit cb0b54d9acb4a0021a09f90299fec1bad3b63107
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 19:20:17 2019 -0700

    rpcclient: Make cmd_samr.c independent of global domain_sid
    
    Pure SAMR allows us to figure out the domain sid, we don't need LSA
    for this.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit dd108a171fe807b67fe8186cf96af18836bea451
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 19:19:47 2019 -0700

    rpcclient: Fix a comment
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3cac5c1bd4d47d143071891a0f21e242a28bd99f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 18:49:33 2019 -0700

    rpcclient: Move rpccli_try_samr_connects() to cmd_samr.c
    
    That's the only user, make it static to cmd_samr.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f74442b4b795d9c282cdf36e6e8ebc312bfe27ca
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 17:32:31 2019 -0700

    rpcclient: Remove rpcclient_cli_state
    
    An unneeded global
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8ca4fe65238f9b086cae842da13111596b9d0114
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 17:25:55 2019 -0700

    rpclient: Remove cmd_test
    
    I can't even properly find why this went in. It's the only user of the
    global rpcclient_cli_state, which can go if we remove this.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 398cb8a56d83a7978836ee0b65b4747d190ab630
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 26 12:37:15 2019 -0700

    s3: smbd: Fix the SMB2 server to pass SMB2-PATH-SLASH.
    
    [MS-FSA] 2.1.5.1 Server Requests an Open of a File
    
    Windows pathname specific processing.
    
    Always disallow trailing /, and also \\ on FILE_NON_DIRECTORY_FILE.
    
    We need to check this before the generic pathname parser
    as the generic pathname parser removes any trailing '/' and '\\'.
    
    Currently this is SMB2 only, but we could also add this
    check to the SMB1 NTCreateX calls if ultimately neded.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Oct  2 09:31:40 UTC 2019 on sn-devel-184

commit 5642f288c895467e32a39430af709cc48198e7c1
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 26 12:36:18 2019 -0700

    s3: torture: Add MS-FSA style terminating '/' and '\\' test - SMB2-PATH-SLASH.
    
    [MS-FSA] 2.1.5.1 Server Requests an Open of a File.
    
    Checks how to behave on both files and directories.
    
    Tested against Windows 10 server - passes. Currently smbd fails this.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 32d6cc84cf8e0cf278b5715b8a9d66b7c0a2a6d2
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 30 11:39:11 2019 +0200

    dbwrap_watch: Don't alert ourselves, fix raw.oplock.batch26 race
    
    This fixes the following flaky test:
    
    UNEXPECTED(failure): samba3.raw.oplock.batch26(nt4_dc)
    REASON: Exception: Exception: (../../source4/torture/raw/oplock.c:3718): wrong value for break_info.count got 0x2 - should be 0x1
    
    You can reproduce it with two small msleeps, which means it's a race
    condition:
    
    diff --git a/source3/smbd/open.c b/source3/smbd/open.c
    index 20b5a3e294c..126c7fc021d 100644
    --- a/source3/smbd/open.c
    +++ b/source3/smbd/open.c
    @@ -1917,6 +1917,14 @@ NTSTATUS send_break_message(struct messaging_context *msg_ctx,
     	DATA_BLOB blob;
     	NTSTATUS status;
    
    +	{
    +		static bool sent = false;
    +		if (sent) {
    +			smb_msleep(500);
    +		}
    +		sent = true;
    +	}
    +
     	if (DEBUGLVL(10)) {
     		struct server_id_buf buf;
     		DBG_DEBUG("Sending break message to %s\n",
    diff --git a/source3/smbd/oplock.c b/source3/smbd/oplock.c
    index b3da84b1269..d9c4dbb9487 100644
    --- a/source3/smbd/oplock.c
    +++ b/source3/smbd/oplock.c
    @@ -858,6 +858,8 @@ static void process_oplock_break_message(struct messaging_context *msg_ctx,
     	uint16_t break_to;
     	bool break_needed = true;
    
    +	smb_msleep(100);
    +
     	msg = talloc(talloc_tos(), struct oplock_break_message);
     	if (msg == NULL) {
     		DBG_WARNING("talloc failed\n");
    
    15a8af075a2 introduced a bug where we immediately wake up ourselves
    after doing a watch_send, leading to two inter-smbd oplock break
    messages for this case. In theory, this should not matter, as in the
    oplock break handler in the destination smbd we check
    
    (fsp->sent_oplock_break != NO_BREAK_SENT)
    
    so that the break does not get sent twice. However, with the above two
    sleeps the oplock holding client could send out its oplock downgrade
    while the second inter-smbd break messages was on its way.
    
    The real fix would be to note in the share mode array that the
    inter-smbd message has already been sent, but as other users of
    dbwrap_watched_watch_send might also be affected by this bug, this fix
    should be sufficient to get rid of this flaky test.
    
    Unfortunately, dbwrap_watch.c is now pretty complex and needs some
    serious refactoring to become understandable again. But that's
    something for another day, sorry.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 64da66a75c688b0443b5d5afa4f73ac51b96c504
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 30 11:32:26 2019 +0200

    dbwrap_watch: Remove "addwatch" handling from dbwrap_watched_save()
    
    This has been moved to dbwrap_watched_watch_send()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 491b71f29b966d1fed65d5db1463353a19306db8
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 30 11:25:59 2019 +0200

    dbwrap_watch: Move reallocating watchers to dbwrap_watched_watch_send()
    
    Before 15a8af075a2 we did not have a separately allocated watchers
    array and dbwrap_watched_save() could play (too) smart tricks with
    dbwrap_record_storev(). Now that we always have watchers talloc'ed, we
    can remove those smart tricks from dbwrap_watched_save() in the next
    commit.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 88f8edf69ba04b4df28d4986199fa13730d3a165
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Sep 30 07:48:34 2019 +0200

    dbwrap_watch: Slightly simplify dbwrap_watched_fetch_locked()
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 86672659c6a757263c7bf64d152f95d89222a3e7
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 27 17:20:26 2019 -0700

    epmapper: Fix printf specifiers
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e3e5894b854b9fe5680f1028f2bcbb2a2cc01069
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 11:53:31 2019 -0700

    torture: Fix a comment
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 9dc2cd86f6993fd681513b1b251f5bbdb01212d4
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 10:51:38 2019 -0700

    lib: Fix a typo
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 5d8493f5b459a7b91f9a5ca9dee00c968fab3d67
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 10:29:07 2019 -0700

    rpc_client: Don't pass a NULL string to talloc_asprintf
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 34a35ac15efee431a7848da51409f7dcdf95b48b
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 09:51:08 2019 -0700

    smbd: Fix CID 1453984: Null pointer dereferences (REVERSE_INULL)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b66b8a74b100be85101a7383c634d0d96cf6b0ee
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 09:24:54 2019 -0700

    lib: Fix CID 1453985: Null pointer dereferences (FORWARD_NULL)
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f21af2ace2261fb6e4d4762bcd70784135b62ddb
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Sep 24 07:30:15 2019 -0700

    lib: Remove some unneeded #includes from tftw.c
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 993d327f5d24305d96781afeb11855487323975d
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 10:31:51 2019 -0700

    s3:smbd: use is_named_stream() in a a few places
    
    This simplifies (and corrects) things in the VFS as there the caller is only
    interested in whether a name is pointing to a real named stream most of the times.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 4b2e44a6ed7de9b1a25c3bf08de24dd49c7f6c1d
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 12:19:31 2019 -0700

    vfs_default: use is_named_stream() for stream check
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c190f3efa9eb4f633df28074b481ff884b67e65f
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 10:41:37 2019 -0700

    s3:smbd: add a comment explaining the File-ID semantics when a file is created
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 90a14c90c4bcede1ef5414e0800aa4c84cbcf1c9
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Sep 24 12:49:38 2019 -0700

    s3:smbd: ensure a created stream picks up the File-ID from the basefile
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 091e3fdab61217251de1cf5111f070ff295d1649
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 10:05:40 2019 -0700

    s3:lib: add is_named_stream()
    
    Add a new utility functions that checks whether a struct smb_filename points to
    a real named stream, excluding the default stream "::$DATA".
    
      foo           -> false
      foo::$DATA    -> false
      foo:bar       -> true
      foo:bar:$DATA -> true
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 780a8dcba998471bb154e8bae4391786b793e332
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 11:29:04 2019 -0700

    s3:lib: use strequal_m() in is_ntfs_default_stream_smb_fname()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 3f8bc1ce3e094f943363921c46803fd5ec9f73bb
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 11:19:26 2019 -0700

    s3:lib: implement logic directly in is_ntfs_default_stream_smb_fname()
    
    This allows changing the semantics of is_ntfs_stream_smb_fname() in the next
    commit.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2584b4cdeae3f83962cd11538cd4e441104c8274
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 26 10:38:06 2019 -0700

    s3:lib: expand a comment with the function doc for is_ntfs_stream_smb_fname
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit f9fdb8a2a6b9ad0fbb89a9734e81a8b1f527966f
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 10:18:03 2019 -0700

    s3:lib: factor out stream name asserts to helper function
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6c1647ca7a2f68825c34e9ccc18b86ef911e14ac
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 10:15:27 2019 -0700

    s3:lib: assert stream_name is NULL for POSIX paths
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit d7dc85990a177954925644f9ff332b3481a03cc7
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Sep 25 08:53:29 2019 -0700

    s3:lib: rework a return expression into an if block
    
    Needed to add additional stuff after the if block in the next commit.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 49a754b82d33fb523cda4151a865584ae52a2e2f
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 23 15:16:58 2019 -0700

    s3:smbd: when storing DOS attribute call dos_mode() beforehand
    
    This is required to ensure File-ID info is populated with the correct on-disk
    value, before calling file_set_dosmode() which will update the on-disk value.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit e1dfaa2b038d91e43d8d34bf1526b7728dba58a5
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 23 15:15:31 2019 -0700

    s3:smbd: change the place where we call dos_mode() when processing SMB2_CREATE
    
    This is needed for ordinary file or directory opens so the QFID create context
    response gets the correct File-ID value via dos_mode() from the DOS attributes
    xattr.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 300b47442b023532bd65417fcec04d811f40ef76
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Sep 24 13:09:03 2019 -0700

    torture:smb2: add a File-ID test on directories
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 432202413f4d11d761c62f46a50747fcb9b6f0cf
Author: Ralph Boehme <slow at samba.org>
Date:   Mon Sep 23 15:15:01 2019 -0700

    torture:smb2: extend test for File-IDs
    
    This now hopefully covers most possible combinations of creating and opening
    files plus, checking the file's File-ID after every operation.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14137
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 84fae0ed1bb7f2ec1fad8011d42211582e46565a
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 27 08:07:24 2019 +0100

    s3: passdb: ret doesn't seem to be needed at all
    
    I was looking at the wrong hunk when examining this, ret seems redundant
    and the existing status can cover things
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Oct  1 00:28:44 UTC 2019 on sn-devel-184

commit ee6300470dc6113ac4d8a9fbb450da876eb0b07a
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 14:50:33 2019 +0100

    s3/libsmb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/libsmb/cliconnect.c:1877:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_NO_MEMORY;
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 63c9147f8631d73b52bdd36ff407e0361dcf5178
Author: Michael Adam <obnox at samba.org>
Date:   Fri Jan 11 10:44:30 2019 +0100

    winbind: provide passwd struct for group sid with ID_TYPE_BOTH mapping (again)
    
    https://git.samba.org/?p=samba.git;a=commitdiff;h=394622ef8c916cf361f8596dba4664dc8d6bfc9e
    originally introduced the above feature.
    
    This functionality was undone as part of "winbind: Restructure get_pwsid"
    https://git.samba.org/?p=samba.git;a=commitdiff;h=bce19a6efe11980933531f0349c8f5212419366a
    I think that this semantic change was accidential.
    
    This patch undoes the semantic change and re-establishes the
    functionality.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14141
    
    Signed-off-by: Michael Adam <obnox at samba.org>
    Reviewed-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Fri Sep 27 17:25:29 UTC 2019 on sn-devel-184

commit 485874d6bb328c50c9a98785e85270f28ade7497
Author: Christof Schmitt <cs at samba.org>
Date:   Wed Sep 25 17:19:27 2019 -0700

    selftest: Test ID_TYPE_BOTH with idmap_rid module
    
    ID_TYPE_BOTH means that each user and group has two mappings, a uid and
    gid. In addition the calls to getpwent, getpwuid, getgrent and getgrgid
    always return some information, so that uid and gid can be mapped to a
    name. Establish a test to verify that the expected information is
    returned.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14141
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>

commit 18e2d6b0098232c2bd8d51320095d35bd7301920
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 14:30:29 2019 +0100

    s3/libsmb: clang: Fix 'warning: Value stored to 'p' is never read'
    
    Fixes:
    
    source3/libsmb/cliconnect.c:649:2: warning: Value stored to 'p' is never read <--[clang]
            p += ret;
            ^    ~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Sep 26 19:59:24 UTC 2019 on sn-devel-184

commit 1ca110b547622f788d94530e0e3432845c2943bf
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 14:42:41 2019 +0000

    s3/passdb: clang: Value stored to 'c' is never read
    
    source3/passdb/pdb_smbpasswd.c:405:4: warning: Value stored to 'c' is never read <--[clang]
                            c = '\0';
                            ^   ~~~~
    /home/samba/samba/source3/passdb/pdb_smbpasswd.c:809:4: warning: Value stored to 'c' is never read <--[clang]
                            c = '\0';
                            ^   ~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2138bd93bb258f2dde2c279a0ba80f9a40737aed
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 14:16:57 2019 +0000

    s3/libsmb: clang: value stored to 'idx_current' is never read
    
    Fixes:
    
    source3/libsmb/trusts_util.c:602:2: warning: Value stored to 'idx_current' is never read <--[clang]
            idx_current = idx;
            ^             ~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 388f280448b9ea459d8d884dbbbce54ab930da7b
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 13:46:40 2019 +0000

    s3/passdb: clang: Fix warning: Value stored to 'acct_ctrl' is never read
    
    Fixes:
    
    source3/passdb/pdb_ldap.c:922:3: warning: Value stored to 'acct_ctrl' is never read <--[clang]
                    acct_ctrl |= ACB_NORMAL;
                    ^            ~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6ae0fd5a348224b2a7942c81c4ef21bf11205d62
Author: Noel Power <noel.power at suse.com>
Date:   Tue Sep 17 14:43:20 2019 +0000

    s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/lib/netapi/user.c:1290:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    source3/lib/netapi/user.c:1610:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    
    source3/lib/netapi/user.c:2990:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    source3/lib/netapi/user.c:3184:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    source3/lib/netapi/user.c:3522:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9c16d8fb246911d7bbd576d7e6bce0c8fb39929f
Author: Noel Power <noel.power at suse.com>
Date:   Tue Sep 17 14:20:03 2019 +0000

    s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/rpc_client/cli_winreg.c:728:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    /source3/rpc_client/cli_winreg.c:897:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 58400d6e65f70a256ebd900c3eca1c945b71be10
Author: Noel Power <noel.power at suse.com>
Date:   Tue Sep 17 08:13:00 2019 +0000

    lib/talloc: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    ib/talloc/pytalloc_util.c:245:8: warning: Value stored to 'type_obj' during its initialization is never read <--[clang]
            void *type_obj = talloc_check_name(ptr, type_name);
                  ^~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 32d487d0746b0fc8888ed37dfbfae3245b269dd7
Author: Noel Power <noel.power at suse.com>
Date:   Tue Sep 17 08:05:28 2019 +0000

    s3/libads: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/libads/ldap.c:370:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/libads/ldap.c:417:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/libads/ldap.c:1783:13: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
                       ^~~   ~~~~~~~~~~~~~~~~~~~~~~~
    source3/libads/ldap.c:1862:13: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            ADS_STATUS ret = ADS_ERROR(LDAP_SUCCESS);
                       ^~~   ~~~~~~~~~~~~~~~~~~~~~~~
    4 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit a3b9986fac270797be4dbd3d453add9d2107e953
Author: Noel Power <noel.power at suse.com>
Date:   Mon Sep 16 10:43:54 2019 +0000

    s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/lib/netapi/getdc.c:173:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 25c92111dcb646f8537d89fc2d091ee3c5753d56
Author: Noel Power <noel.power at suse.com>
Date:   Mon Sep 16 10:35:49 2019 +0000

    s3/lib/netapi: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/lib/netapi/group.c:1383:11: warning: Value stored to '
    status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    samba/source3/lib/netapi/group.c:1521:11: warning: Value stored to '
    status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    samba/source3/lib/netapi/group.c:1718:11: warning: Value stored to '
    status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    3 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 8ea0835a6cbe8721780929b9946de65cd87dc26d
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 13 13:57:16 2019 +0000

    s3/auth: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/auth/auth.c:38:35: warning: Value stored to 'entry' during its initialization is never read <--[clang]
            struct auth_init_function_entry *entry = auth_backends;
                                             ^~~~~   ~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 9759e96ff1dc8741222eb6794dc01bd5b65c282d
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 13 13:54:11 2019 +0000

    s3/auth: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/auth/auth_util.c:283:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
                     ^~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/auth/auth_util.c:2005:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
            NTSTATUS nt_status = NT_STATUS_OK;
                     ^~~~~~~~~   ~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 50ff6c965f23457bfdefa53cd043166fdec899a5
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 14:59:51 2019 +0000

    s3/libsmb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/libsmb/dsgetdcname.c:1012:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    source3/libsmb/dsgetdcname.c:1099:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit eb3ba3eeaa200660c7b48253083bffbe39d41a96
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 14:50:37 2019 +0000

    s3/libads: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/libads/ldap_utils.c:52:13: warning: Value stored to 'status' during its initialization is never read <--[clang]
            ADS_STATUS status = ADS_SUCCESS;
                       ^~~~~~   ~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 35e0122e7c7f2cdfa0f6ac4f18a8cc7c42edab24
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 13:00:05 2019 +0000

    s3/libads: clang: Fix 'Value stored to 'nt_status' is never read'
    
    Fixes:
    
    source3/libads/sasl.c:219:2: warning: Value stored to 'nt_status' is never read <--[clang]
            nt_status = NT_STATUS_MORE_PROCESSING_REQUIRED;
            ^           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fba666cf2a5c83ee76432f0d0d44e867c62231ba
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 15:40:50 2019 +0000

    s3/passed: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/passdb/passdb.c:2502:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_INTERNAL_ERROR;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit b08ec1903d2ebfdcdb83c0f6e042a6d3b06992c9
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 14:48:47 2019 +0000

    s3/rpc_client: clang: 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/rpc_client/util_netlogon.c:71:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    
    source3/rpc_client/util_netlogon.c:199:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit ae2e9ce5c36c9e05f785b3fa7be22074fdc4213d
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 14:22:02 2019 +0000

    s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/rpc_client/cli_lsarpc.c:182:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 38aafe0d6bba0b7651600edfe2a799dcf7d1ed2d
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 13:40:16 2019 +0000

    s3/passdb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/passdb/lookup_sid.c:836:11: warning: Value stored to 'result' during its initialization is never read <--[clang]
            NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 299eff4ac906846e8f7f605815792a9d4418f071
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 13:36:22 2019 +0000

    s3/passdb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_interface.c:65:34: warning: Value stored to 'entry' during its initialization is never read <--[clang]
            struct pdb_init_function_entry *entry = backends;
                                            ^~~~~   ~~~~~~~~
    
    /source3/passdb/pdb_interface.c:140:11: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
            NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 2d47067c86303c43f3d7267394ef8a9ce49593d3
Author: Noel Power <noel.power at suse.com>
Date:   Thu Sep 5 13:34:05 2019 +0000

    s3/passdb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_tdb.c:718:18: warning: Value stored to 'nt_status' during its initialization is never read <--[clang]
            NTSTATUS        nt_status = NT_STATUS_UNSUCCESSFUL;
                            ^~~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 752f5b63d0c4e0a7cdab74128ea54ade461d18d0
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 16:25:27 2019 +0100

    s3/passdb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_util.c:41:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit c534b05c8d464940cd4d46c43d6549e86014143b
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 15:57:26 2019 +0100

    s4/winbind: clang: Fixes 'Value stored during its initialization is never read'
    
    Fixes:
    
    source4/winbind/idmap.c:214:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_NONE_MAPPED;
    
    source4/winbind/idmap.c:397:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_NONE_MAPPED;
                     ^~~~~~   ~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6831b6ba6f52dd865ecf09c575e4862f6dd3424b
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 15:32:13 2019 +0100

    s3/rpc_client: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/rpc_client/cli_pipe.c:397:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_OK;
                     ^~~   ~~~~~~~~~~~~
    
    source3/rpc_client/cli_pipe.c:1234:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_OK;
                     ^~~   ~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 368d0cecc0bc859e321335f46b22d4334e092da1
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 15:29:03 2019 +0100

    s3/groupdb: clang: 'Value stored during its initialization is never read'
    
    Fixes:
    
    source3/groupdb/mapping_tdb.c:460:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 6055134330d9e4226deb298c506dc6f792bf5d33
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 15 14:16:52 2019 +0100

    s3/groupdb: clang: Fix 'Value stored during its initialization is never read'
    
    Fixes:
    
    ource3/groupdb/mapping.c:648:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
            NTSTATUS status = NT_STATUS_OK;
                     ^~~~~~   ~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 5550367e46d2ebb2bb0bb35fa51f34ca178d2907
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 25 06:53:34 2019 +0200

    s4-torture: remove duplicate NDR_PRINT
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit fd20153e8b095fa9a82a024c3f7bebd809ba132f
Author: Günther Deschner <gd at samba.org>
Date:   Tue Aug 30 19:37:18 2016 +0200

    s4-torture: dump ndr packet in ndr tests with high log level
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 86a0e4850e02efc406ae5e1ee7cdc6a61eebef76
Author: Günther Deschner <gd at samba.org>
Date:   Tue Sep 24 23:10:50 2019 +0200

    librpc/ndr: add ndr_print_netlogon_samlogon_response()
    
    Guenther
    
    Signed-off-by: Guenther Deschner <gd at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

commit 1ec030398bdc6f912d9beb3bcd0db7860a92eede
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 10:04:03 2019 -0700

    s3: VFS: Complete the replacement of SMB_VFS_UNLINK() -> SMB_VFS_UNLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Thu Sep 26 18:40:53 UTC 2019 on sn-devel-184

commit f7f09377919cf39ccc803556b42b024874a92a2b
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:23:04 2019 -0700

    s3: VFS: vfs_full_audit: Remove unlink_fn. No longer used.
    
    NB, this will now fail smb_vfs_assert_all_fns()
    until we remove the unlink_fn() from the VFS definitions.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit eeec2b8003fb0c069188591249415077d8792d0a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 10:02:16 2019 -0700

    s3: VFS: vfs_acl_tdb: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7222d63d42fb5812197ad8f64a6af1557bd0a043
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 10:01:32 2019 -0700

    s3: VFS: vfs_acl_xattr: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6f9b6a78671491055c9ce4b05039ba698a28abb1
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 10:00:43 2019 -0700

    s3: VFS: vfs_posix_eadb: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 467251ccf97561e9717d62080c0e81bfd2a1e11f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:59:54 2019 -0700

    s3: VFS: vfs_ceph: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f856d6f41d199f93ba57c93f075a21efc89b27ec
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:59:03 2019 -0700

    s3: VFS: vfs_glusterfs: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 314358b28a573fce13750e17dd0b124a8d6a0a0e
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:57:59 2019 -0700

    s3: VFS: vfs_streams_depot: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6f68049fff82e86554eb2ef8249a38e2ba4de2f7
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:56:53 2019 -0700

    s3: VFS: vfs_syncops: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4dc8c378193f8a4a6fbb913fbb419a7949acc393
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:54:10 2019 -0700

    s3: VFS: vfs_fruit: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 55df30d5a6345b333ee312d43b548ae50107471f
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 18 09:22:38 2019 -0700

    s3: VFS: vfs_recycle: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7c814ef4299178f2d313ee12ea4a38429bbe991c
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:18:07 2019 -0700

    s3: VFS: vfs_unityed_media: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3bc8527cdc7a7958c8906044dbb0e7ad21f5e336
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:16:31 2019 -0700

    s3: VFS: vfs_xattr_tdb: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 36f4d0f76e6b71a6f79ca0f3cab84b55c40028ec
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:15:38 2019 -0700

    s3: VFS: vfs_virusfilter: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b2f1b3d972602d0305b0e728200092567051def4
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:14:22 2019 -0700

    s3: VFS: vfs_time_audit: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit fc29eb2b8581019b9505c8646f1d3c2cda161554
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:13:05 2019 -0700

    s3: VFS: vfs_streams_xattr: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit eacfeac62ba086e7f615bb2849785b7d354a7d48
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:05:27 2019 -0700

    s3: VFS: vfs_snapper: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 74ec7c804d8b3305f3a494b435d0d6ecec8cd4d7
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:04:38 2019 -0700

    s3: VFS: vfs_shadow_copy2: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 64854db8ac270acf16fa98f1b6ce26d19885795d
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:04:06 2019 -0700

    s3: VFS: vfs_media_harmony: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6f9ede8ad82487c27e9253fe18eb9c20ad2918ab
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:03:10 2019 -0700

    s3: VFS: vfs_extd_audit: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 84255a99384e62dc9a950e978e85bd7c9987af98
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:02:06 2019 -0700

    s3: VFS: vfs_ceph_snapshots: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 257137ee583d98b93ca09453d00931f7927ac32a
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:01:26 2019 -0700

    s3: VFS: vfs_catia: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d4c4c688dd31ec3b27c1f6001fcc7baabb2d2f04
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 18:00:31 2019 -0700

    s3: VFS: vfs_cap: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1e51128424749eb68634376b01f87362d67b1186
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:59:25 2019 -0700

    s3: VFS: vfs_audit: Remove unlink_fn. No longer used.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0535656284db66dc7bc90fea2f15b1d00a13fe10
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 15:15:05 2019 -0700

    s3: lib: adouble: Add dirfsp to ad_convert_delete_adfile(). Use UNLINKAT instead of UNLINK.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7691ce3a4b34b6a0b3f6cc2379f2f4d2b4392047
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:52:00 2019 -0700

    s3: lib: adouble: Add struct files_struct *dirfsp parameter to ad_convert().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6a55e676aa63f5ca86c53f849bab3d8fce877bc0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:21:28 2019 -0700

    s3: VFS: vfs_fruit. Change delete_invalid_meta_stream() to use UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit a3bd45212607aad0df244db9178153b949cd97ad
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:19:21 2019 -0700

    s3: VFS: vfs_fruit. Change fruit_pread_meta_stream() to use UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit be586203fa5a1ecfece1d7f5390011c952d821df
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:11:46 2019 -0700

    s3: VFS: vfs_fruit. Add struct files_struct *dirfsp parameter to fruit_unlink_rsrc_adouble() and convert to UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3b1d97555910a9782987a6ab6b0b09e8ac50b792
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:10:16 2019 -0700

    s3: VFS: vfs_fruit. Add struct files_struct *dirfsp parameter to fruit_unlink_rsrc_stream() and convert to UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e79ff5dcfe8455ab956f58c31cfffeede50d9bd3
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 14:08:08 2019 -0700

    s3: VFS: vfs_fruit. Add files_struct *dirfsp parameter to fruit_unlink_rsrc().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 04ea1232996ddabe0ddb4a9dba56a7b8ba5262a2
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:46:00 2019 -0700

    s3: VFS: vfs_fruit. Add struct files_struct *dirfsp parameter to fruit_unlink_meta_stream() and convert to UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7f49bb9f6ffc67fe40020344700b5f9ef657a7a0
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:44:21 2019 -0700

    s3: VFS: vfs_fruit. Add files_struct *dirfsp parameter to fruit_unlink_meta().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit cb5e52377ae344c63d0e28dc0531075cd1d77d6c
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:43:29 2019 -0700

    s3: VFS: vfs_fruit: Convert fruit_rmdir_internal() to UNLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 92d8b3b847794ca5c5cd02c3c28b5f3d96540fdc
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:30:19 2019 -0700

    s3: VFS: vfs_fruit: Add dirfsp files_struct pointer parameter to fruit_rmdir_internal().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 96842316788615a368b30f3808a0333678266453
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:24:23 2019 -0700

    s3: VFS: vfs_fruit: Wrap fruit_rmdir() so we can add parameters.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 41a740f25120872e67240440f1f8c2f0c8763bbb
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:20:36 2019 -0700

    s3: VFS: vfs_fruit. Change fruit_unlink_internal() to call UNLNKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 762b95743c1f60249451562251b7bbc0769eeab1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:18:28 2019 -0700

    s3: VFS: vfs_fruit. Add files_struct *dirfsp to fruit_unlink_internal() so we can call UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1e6a8a3093ab118a4dc21344bfb4f41da18adc25
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 13:16:19 2019 -0700

    s3: VFS: vfs_fruit. Wrap Convert fruit_unlink() -> fruit_unlink_internal() so we can add parameters.
    
    Make fruit_unlink() a wrapper calling the internal version.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3bf8181f159c142a45287e996167d11980508dd6
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 12:34:31 2019 -0700

    s3: smbd: Change rmdir_internals() to call SMB_VFS_UNLINKAT() in 2 places.
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2adc0e0fdcd639a46008edff18371f181da93ed1
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 12:29:41 2019 -0700

    s3: smbd: Change recursive_rmdir() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f8cff71e5f9edb97a3817bc259c0aeec6fbdba7f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 12:25:10 2019 -0700

    s3: smbd: Change close_remove_share_mode() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7f7ad9bbfd65f813f59b55e043c9e75859cb71e9
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 12:23:02 2019 -0700

    s3: smbd: Change delete_all_streams() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 24516e78eebbb30df09f85cdeacf6d1ad2635d32
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 11:33:53 2019 -0700

    s3: smbd: Change smb_set_file_unix_basic() to call SMB_VFS_UNLINKAT() in 3 places.
    
    Use conn->cwd_fsp as current fsp. This is horrible code and must
    be removed.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 56b355d07959923381e60c3fc51136cc4703876f
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 11:22:06 2019 -0700

    s3: pysmbd: Change py_smbd_unlink() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 3d6a8d9ae0d55d92068c06651f6722b8158c25c8
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 11:20:36 2019 -0700

    s3: smbd: Change remove_msdfs_link() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 66d86efb9a19285a09940f4f359c80dfd59cddd6
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 11:17:45 2019 -0700

    s3: smbd: Change create_msdfs_link() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp. Rework to modern standards.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 244c3820a87e4273b1135959d197ec9fd30866a7
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 10:56:30 2019 -0700

    s3: cmd_vfs: Change cmd_pathfunc() to call SMB_VFS_UNLINKAT().
    
    Use conn->cwd_fsp as current fsp.
    
    No logic change for now.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f8bdf5db6eb97458450392e2646db746a78b4d81
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:54:00 2019 -0700

    s3: VFS: vfs_acl_common: Convert unlink_acl_common(), acl_common_remove_object() to UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 63d814047f7cf04be2ab0ab2b235d58d22cfbaa2
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:50:17 2019 -0700

    s3: VFS: vfs_acl_common: Add dirfsp, flags parameters to unlink_acl_common().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6ef40bdb94093f2a7afdd0d69bf0467d86660ec8
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:44:33 2019 -0700

    s3: VFS: vfs_acl_xattr: Don't call unlink_acl_common() directly.
    
    Use a wrapper function so we can change the parameters.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 96aeaed858164bb1387c41c954e841e911ba561c
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:41:10 2019 -0700

    s3: VFS: vfs_virusfilter: Change UNLINK -> UNLINKAT in infected_file_action_delete()
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 88249762a4b430e67d7d677b2258389351cc7099
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 19 10:32:41 2019 -0700

    s3: VFS: vfs_posix_eadb: Wrap posix_eadb_unlink() into a call to posix_eadb_unlink_internal().
    
    Allows UNLINKAT parameters to be passed. Change posix_eadb_unlink_internal()
    to call UNLINKAT instead of UNLINK.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 488c65672350819e35a543313ca6c876befd1d6e
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:57:25 2019 -0700

    s3: VFS: vfs_audit. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1023ec61a9deca7a81e0cb4960b51e9b2b917c51
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:16:55 2019 -0700

    s3: VFS: vfs_virusfilter. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 70f5cbc54d7c99ea3709b77487d62ea565a99490
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:14:01 2019 -0700

    s3: VFS: vfs_unityed_media. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit b355a9565dcf67304db12aa827ca582d1dd80b89
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:11:20 2019 -0700

    s3: VFS: vfs_time_audit. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 83e0cf6dc9a9017232c910940a46f8d196a2e641
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:09:27 2019 -0700

    s3: VFS: vfs_syncops. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d69a9ba7e3065ae57b7de588cf08fc1324ae5d07
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:10:24 2019 -0700

    s3: VFS: vfs_streams_xattr: Convert streams_xattr_unlink_internal() to use UNLINKAT.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0b3b83c15314859a121ebd4b1983b643fb3a490c
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:08:26 2019 -0700

    s3: VFS: vfs_streams_xattr. Wrap Convert streams_xattr_unlink() -> streams_xattr_unlink_internal() so we can add parameters.
    
    Make streams_xattr_unlink() a wrapper calling the internal version.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit d7e763ef0558473a81cecd12abc0d50dd77c0b9f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 14:00:24 2019 -0700

    s3: VFS: vfs_streams_xattr. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit e73caaed8226b5ca0c2603930928e36a5a97396d
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:26:13 2019 -0700

    s3: VFS: vfs_streams_depot: Change streams_depot_unlink_internal() to call UNLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 7b2fda0576c76b1a63d08a9266620fe87a2ad587
Author: Jeremy Allison <jra at samba.org>
Date:   Tue Sep 17 19:23:31 2019 -0700

    s3: VFS: vfs_streams_depot. Wrap Convert streams_depot_unlink() -> streams_depot_unlink_internal() so we can add parameters.
    
    Make streams_depot_unlink() a wrapper calling the internal version.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c81932fdfea44f466afc4726e5facd23ac92bbfa
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 13:41:10 2019 -0700

    s3: VFS: vfs_streams_depot. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 62f92f8b29a4d860ee0062de27edb466f699633d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 13:21:41 2019 -0700

    s3: VFS: vfs_snapper. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 43b9d9adfe3ac5135bee4918e2769cf912e12b7d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 13:19:39 2019 -0700

    s3: VFS: vfs_shadow_copy2. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6f0cc51b1f5fc72734b7766302eb245b484dafc2
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:30:49 2019 -0700

    s3: VFS: vfs_recycle: Change recycle_unlink_internal() to call UNLINKAT().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1f8bdb3974c5eade55bf307077fb71bf0fac8147
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Sep 16 17:22:58 2019 -0700

    s3: VFS: vfs_recycle: Wrap recycle_unlink() into a call to recycle_unlink_internal().
    
    Allows UNLINKAT parameters to be passed.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8d9ff50f85cbcfb361ab6c4f78892ab09f60209f
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 12:55:49 2019 -0700

    s3: VFS: vfs_recycle. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 8c43f6179a92d8aab22de314626692eb1a9c8ab4
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 11:51:09 2019 -0700

    s3: VFS: vfs_media_harmony. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 1ee6c9d8a42c9702914acf4d6f10342951cce7d5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 11:04:18 2019 -0700

    s3: VFS: vfs_glusterfs. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 6c28a7749bb8c7c45db86647f5046d2df654653e
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:50:06 2019 -0700

    s3: VFS: vfs_full_audit. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2a4eb0782b179d621821a8ecf020f9d0278a289d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:46:02 2019 -0700

    s3: VFS: vfs_fruit. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 0c16e77ae1ea0ef565c66e24297031db0b114710
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:07:40 2019 -0700

    s3: VFS: vfs_extd_audit. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 34d7b18cdeda87b0d14e94b56bfc5664b2c9356d
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:05:00 2019 -0700

    s3: VFS: vfs_ceph_snapshots. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 797f24fd4df288d9dee98c3bfdc0df1dd410931c
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 10:03:05 2019 -0700

    s3: VFS: vfs_ceph. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit f372f2f58c28ff08df3d47f810a9d4d6685662e5
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 09:38:42 2019 -0700

    s3: VFS: vfs_catia. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 4794e8dbb108d8fe7e09a11a5bf651dcdf55c2a2
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 09:36:34 2019 -0700

    s3: VFS: vfs_cap. Implement unlinkat().
    
    This is identical to unlink(), as there
    are no special cases needed for rmdir().
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 95197108becd184dbff61dc9929606f62460e98d
Author: Jeremy Allison <jra at samba.org>
Date:   Fri Sep 13 10:12:38 2019 -0700

    s3: VFS: vfs_xattr_tdb. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 19c8cfa2871050c857c4ad8eecc8dd0f99cfafdb
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Sep 12 12:01:42 2019 -0700

    s3: VFS: vfs_posix_eadb. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2a7e472e5ca02bb3c6685e38042b23ee27422a5a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 11 16:49:38 2019 -0700

    s3: VFS: vfs_acl_xattr. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 2c90d2b4f0d61174a9cd35160ed0ae5d7cb2af6d
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 11 16:42:01 2019 -0700

    s3: VFS: vfs_acl_tdb. Implement unlinkat().
    
    Note this isn't identical to unlink() as
    this must cope with (flags & AT_REMOVEDIR),
    which is identical to rmdir(). It calls
    either unlink or rmdir depending on the
    flags parameter.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit c58692cee919259edc4b95009925d516384bbc6a
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Sep 11 14:37:31 2019 -0700

    s3: VFS: Add SMB_VFS_UNLINKAT().
    
    Currently identical to SMB_VFS_UNLINK().
    
    Next, add to all VFS modules that implement
    unlink and eventually remove unlink.
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

commit 24f04c1cc561d9f4b7fada1ca87f52bed2167f8d
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 18 16:32:40 2019 +1000

    ctdb-tests: Update README
    
    Bring this up to date.  Drop descriptions of command-line options
    because these tend to bit-rot - refer to "run_tests.sh -h" instead.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Thu Sep 26 06:01:33 UTC 2019 on sn-devel-184

commit 8a5c4a60e156170f8aaa738672ed6dc50712a929
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 16:00:52 2019 +1000

    ctdb-tests: Move simple tests to INTEGRATION/ subdirectory
    
    Split some tests out into database/ and failover/ subdirectories.
    Rename the remaining tests in simple/.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 658068184ff9437c11e5260e24a632439adb3d27
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 15:59:31 2019 +1000

    ctdb-tests: Move complex tests to CLUSTER/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit df6800e330d1c1fd47ce3d2f7a5814597ed46229
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 5 14:01:20 2019 +1000

    ctdb-tests: Convert local daemons include file into top-level include
    
    Do the same with the alternative code for real clusters.
    
    Both of these can now be used by other test suites.
    
    Fix some basic shellcheck warnings (e.g. avoid word-splitting by
    quoting) while moving code and add the new files to the shellcheck
    test.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 384381fbff5ca900af031fb0606a270f572f5b9e
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 15:01:49 2019 +1000

    ctdb-tests: Drop use of array in run_tests()
    
    This doesn't accomplish anything.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit c438e0db45dd803523802055cb988c10ff277063
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 14:59:38 2019 +1000

    ctdb-tests: Drop custom handling for unit tests
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 4046baad5c3a5155c18566f853a9a08eb7fa431a
Author: Martin Schwenke <martin at meltin.net>
Date:   Wed Sep 25 16:37:46 2019 +1000

    ctdb-tests: Skip README files in test directories/collections
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 75393cab0f87635e829b45b200cc771a0463b6f4
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 14:47:26 2019 +1000

    ctdb-tests: Recurse into directories instead of explicitly looping
    
    run_tests() already has a loop, so use it.
    
    This means collections of test suites can be handled - but explicitly
    check valid collection names to avoid running junk.
    
    Add special cases for simple and complex.  These will be removed when
    those test suites are moved to collections.  This seems to be the
    smallest amount of churn to support bisection.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 4947fa5ffa8784c93f3c570e246b106b35f96a80
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 11:40:21 2019 +1000

    ctdb-tests: Fold find_and_run_one_test() in to run_tests()
    
    The additional function makes the logic harder to understand.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 1061bdf29dce60251a53dcc0623efb8815b144ae
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:51:17 2019 +1000

    ctdb-tests: Move tool tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 9585ece00c8c7eb215da9928e54dae92f55eaac0
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:49:53 2019 +1000

    ctdb-tests: Move takeover_helper tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit cf0b87f9b7876bc4637c3ed57782c35251d2f965
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:49:17 2019 +1000

    ctdb-tests: Move takeover tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 010c1a85fa9719b726d26c48aa3373f2e328e8f0
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:48:05 2019 +1000

    ctdb-tests: Move shellcheck tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit a3cbb7eb21be56346b9357649579728d294cf3b4
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:47:21 2019 +1000

    ctdb-tests: Move onnode tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 8ed075d396ba5f6f7b7686fb0593984850923f55
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:44:45 2019 +1000

    ctdb-tests: Move eventscript tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 330a106aaa0c91074d5e64978ed6b2e84702336e
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:43:38 2019 +1000

    ctdb-tests: Move eventd tests to UNIT/ subdirectory
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 43ed3a6eb3ddf3434790bed2cb6abf08c5ce4c56
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 10:42:11 2019 +1000

    ctdb-tests: Move cunit tests to UNIT/ subdirectory
    
    The UNIT subdirectory directory will contain all unit tests.  Use an
    uppercase name to avoid conflicts with source code subdirectories.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit ab232ca77f8f08879d99f88cfcd554500717075e
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 17:21:51 2019 +0200

    waf: Use waf function to add for -Wl,--as-needed
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Sep 25 16:56:40 UTC 2019 on sn-devel-184

commit 9499db075b72b147e2ff9bb78e9d5edbaac14e69
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 16:53:12 2019 +0200

    waf:replace: Do not link against libpthread if not necessary
    
    On Linux we should avoid linking everything against libpthread. Symbols
    used my most application are provided by glibc and code which deals with
    threads has to explicitly link against libpthread.  This avoids setting
    LDFLAGS=-pthread globally.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit bd0cd8e13234d684da77a65f6fdaea2572625369
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 17:40:13 2019 +0200

    third_party: Link uid_wrapper against pthread
    
    uid_wrapper uses pthread_atfork() which is only provided by libpthread.                                                                                   │····················
    So we need an explicit dependency.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 68d8a02ef57cce29e4ff3ef1b792adfc10d0b916
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 17:39:29 2019 +0200

    third_party: Link nss_wrapper against pthread
    
    nss_wrapper uses pthread_atfork() which is only provided by libpthread.
    So we need an explicit dependency.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 36e8d715bc8dc1e8466f5a5c9798df76310b7572
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 17:04:57 2019 +0200

    third_party: Only link cmocka against librt if really needed
    
    cmocka also uses clock_gettime().
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 4b28239d13b17e42eb5aa4b405342f46347f3de4
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 16:10:35 2019 +0200

    pthreadpool: Only link pthreadpool against librt if we have to
    
    This calls clock_gettime() which is available in glibc on Linux. If the
    wscript in libreplace detected that librt is needed for clock_gettime()
    we have to link against it.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 480152dd6729d4c58faca6f3e4fa91ff4614c272
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 15:14:24 2019 +0200

    replace: Only link against librt if really needed
    
    fdatasync() and clock_gettime() are provided by glibc on Linux, so there
    is no need to link against librt. Checks have been added so if there are
    platforms which require it are still functional.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 952e1812fa9bdc1bac2a7ae5ebb5532f1ea31447
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 23 15:18:55 2019 +0200

    s3:waf: Do not check for nanosleep() as we don't use it anywhere
    
    We use usleep() in the meantime.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14140
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Isaac Boukris <iboukris at gmail.com>
    Pair-Programmed-With: Isaac Boukris <iboukris at gmail.com>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>

commit 3bb7ccb4635535cb9dd9333220222dcfffb2aed9
Author: Philipp Gesang <philipp.gesang at intra2net.com>
Date:   Thu Sep 19 09:03:45 2019 +0200

    s4:scripting: make samba-gpupdate heed --disable-python
    
    Signed-off-by: Philipp Gesang <philipp.gesang at intra2net.com>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Noel Power<npower at samba.org>
    
    Autobuild-User(master): Noel Power <npower at samba.org>
    Autobuild-Date(master): Wed Sep 25 11:06:04 UTC 2019 on sn-devel-184

commit 018c93f35a80daef74e44e32ff0ff7437eed8547
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 13:15:14 2019 +0000

    s3/librpc/crypto: clang: Fixes Value stored to 'ret' is never read
    
    Fixes:
    
    source3/librpc/crypto/gse_krb5.c:63:3: warning: Value stored to 'ret' is never read <--[clang]
                    ret = smb_krb5_kt_free_entry(krbctx, &kt_entry);
                    ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 40ddcf7bdcec547acdba090f43651cc5b953aded
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 13:12:39 2019 +0000

    s3/libads: clang: Fix Array access results in a null pointer dereference
    
    Fixes:
    
    source3/libads/cldap.c:400:6: warning: Array access (from variable 'responses') results in a null pointer dereference <--[clang]
            if (responses[0] == NULL) {
                ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit d3371d8545bb4303e866e991453a0bbb05dd7656
Author: Noel Power <noel.power at suse.com>
Date:   Fri Aug 2 10:45:48 2019 +0000

    s3/librpc/crypto: clang: warning: Value stored to 'gss_maj' is never read
    
    Fixes: Value stored to 'gss_maj' is never read
    
    source3/librpc/crypto/gse.c:562:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                    gss_maj = gss_release_buffer(&gss_min, &out_data);
                    ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source3/librpc/crypto/gse.c:687:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                    gss_maj = gss_release_buffer(&gss_min, &out_data);
                    ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source3/librpc/crypto/gse.c:739:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                    gss_maj = gss_release_buffer(&gss_min, &msg_min);
                    ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source3/librpc/crypto/gse.c:742:3: warning: Value stored to 'gss_maj' is never read <--[clang]
                    gss_maj = gss_release_buffer(&gss_min, &msg_maj);
                    ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    4 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit f755de54135ab5900209d093a45d9b824687a3bf
Author: Noel Power <noel.power at suse.com>
Date:   Thu Aug 8 15:10:30 2019 +0100

    s4/libcli/clideltree.c: clang: Value stored to 'status' is never read
    
    Fixes:
    
    source4/libcli/clideltree.c:113:3: warning: Value stored to 'status' is never read <--[clang]
    
    status = smbcli_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL, 0);
                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/clideltree.c:131:3: warning: Value stored to 'status' is never read <--[clang]
                    status = smbcli_setatr(dstate.tree, dname, FILE_ATTRIBUTE_NORMAL, 0);
                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit ba55c0220767358656be125e6cecedef97317e9f
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 29 11:44:26 2019 +0000

    s4/libcli/smb2: clang: Fix 'value stored to 'status' is never read'
    
    Fixes:
    
    source4/libcli/smb2/util.c:134:3: warning: Value stored to 'status' is never read <--[clang]
                    status = smb2_util_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL);
                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/smb2/util.c:187:5: warning: Value stored to 'status' is never read <--[clang]
                                    status = smb2_util_setatr(tree, name, FILE_ATTRIBUTE_NORMAL);
                                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/smb2/util.c:209:3: warning: Value stored to 'status' is never read <--[clang]
                    status = smb2_util_setatr(tree, dname, FILE_ATTRIBUTE_NORMAL);
                    ^        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    3 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 076216da7968b77e2a16cf21f879e9f159bc14da
Author: Noel Power <noel.power at suse.com>
Date:   Mon Jul 29 11:22:29 2019 +0000

    s4/libcli/smb2: clang: Fix Passed-by-value arg contains uninitialized data
    
    Fixes:
    
    source4/libcli/smb2/getinfo.c:222:11: warning: Passed-by-value struct argument contains uninitialized data (e.g., field: 'data') <--[clang]
            status = smb_raw_fsinfo_passthru_parse(b.out.blob, mem_ctx, io->generic.level, io);
                     ^
    1 warning generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 088a345f6acd84d888759c935a92737255e17b3f
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 26 16:23:45 2019 +0000

    s4/libcli/raw: clang: Fix 'Value stored to 'p' is never read'
    
    Fixes:
    
    source4/libcli/raw/clisession.c:198:4: warning: Value stored to 'p' is never read <--[clang]
                            p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->old.out.domain, p, -1, STR_TERMINATE);
                            ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/raw/clisession.c:212:5: warning: Value stored to 'p' is never read <--[clang]
                                    p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->nt1.out.domain, p, -1, STR_TERMINATE);
                                    ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    source4/libcli/raw/clisession.c:232:3: warning: Value stored to 'p' is never read <--[clang]
                    p += smbcli_req_pull_string(&req->in.bufinfo, mem_ctx, &parms->spnego.out.workgroup, p, -1, STR_TERMINATE);
                    ^    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit a1a448b19b9565a00e3077690dbda44ed727b2e4
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 26 16:18:49 2019 +0000

    s4/libcli/raw: clang: Fix 'Dereference of null pointer'
    
    Fixes:
    
    source4/libcli/raw/rawfileinfo.c:597:2: warning: Dereference of null pointer <--[clang]
            SMBCLI_CHECK_WCT(req, 10);
            ^
    source4/libcli/raw/rawfileinfo.c:639:2: warning: Dereference of null pointer <--[clang]
            SMBCLI_CHECK_WCT(req, 11);
            ^
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 55c6e4bcc1b084fc391c21b387694a099a015c83
Author: Noel Power <noel.power at suse.com>
Date:   Fri Jul 26 15:06:54 2019 +0000

    s4/libcli/raw: clang: Fix 'Access to field results in a deref of a null ptr
    
    Fixes:
    
    source4/libcli/raw/rawfileinfo.c:301:56: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang]
        parms->standard.out.create_time = raw_pull_dos_date2(session->transport,
                                                                             ^
    source4/libcli/raw/rawfileinfo.c:314:55: warning: Access to field 'transport' results in a dereference of a null pointer (loaded from variable 'session') <--[clang]
        parms->ea_size.out.create_time = raw_pull_dos_date2(session->transport,
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Andreas Schneider <asn at samba.org>

commit 517ec63004f6708c9e6b29cb33bd789b1936997b
Author: Ralph Boehme <slow at samba.org>
Date:   Tue Sep 3 15:33:42 2019 +0200

    vfs_fileid: add "fsname_norootdir_ext" option
    
    This can be used to deliberately break lock coherency between all smbd processes
    in the whole cluster for the root directory of a share.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow at samba.org>
    Autobuild-Date(master): Wed Sep 25 00:48:45 UTC 2019 on sn-devel-184

commit 929555b7c8e987a98b704c102323546a2034bea7
Author: Ralph Boehme <slow at samba.org>
Date:   Thu Sep 12 14:36:17 2019 +0200

    vfs_fileid: add extid mapping hooks
    
    For this always ends up calling fileid_extid_mapping_zero(), so no change in
    behaviour. This will change in a subsequent commit.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>

commit 0ee085b594878f5e0e83839f465303754f015459
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 08:10:26 2019 +0200

    selftest/Samba3.pm: use "winbind use krb5 enterprise principals = yes" for ad_member
    
    This demonstrates that can do krb5_auth in winbindd without knowning about trusted domains.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    
    Autobuild-User(master): Günther Deschner <gd at samba.org>
    Autobuild-Date(master): Tue Sep 24 19:51:29 UTC 2019 on sn-devel-184

commit e2737a74d4453a3d65e5466ddc4405d68444df27
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 08:02:38 2019 +0200

    selftest/Samba3.pm: use "winbind scan trusted domains = no" for ad_member
    
    This demonstrates that we rely on knowning about trusted domains before
    we can do krb5_auth in winbindd.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit ad6f0e056ac27ab5c078dbdbff44372da05caab2
Author: Stefan Metzmacher <metze at samba.org>
Date:   Sat Jun 10 14:38:40 2017 +0200

    selftest/tests.py: test pam_winbind for trusts domains
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 13e3811c9510cf213881527877bed40092e0b33c
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Mar 20 11:39:41 2017 +0100

    selftest: Export TRUST information in the ad_member target environment
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit f07b542c61f84a97c097208e10bf9375ddfa9a15
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 14:03:34 2019 +0200

    selftest/tests.py: test pam_winbind with a lot of username variations
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 36e95e42ea8a7e5a4091a647215d06d2ab47fab6
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 08:08:57 2019 +0200

    selftest/tests.py: test pam_winbind with krb5_auth
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 72daf99fd1ffd8269fce25d69458de35e2ae32cc
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 01:25:23 2019 +0200

    selftest/tests.py: prepare looping over pam_winbindd tests
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 3d38a8e9135bb72bc4ca079fab0eb5358942b3f1
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 01:25:58 2019 +0200

    test_pam_winbind.sh: allow different pam_winbindd config options to be specified
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 653e90485854d978dc522e689cd78c19dcc22a70
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 20 08:13:28 2019 +0200

    tests/pam_winbind.py: allow upn names to be used in USERNAME with an empty DOMAIN value
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit cd3ffaabb568db26e0de5e83178487e5947c4f09
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 08:04:42 2019 +0200

    tests/pam_winbind.py: turn pypamtest.PamTestError into a failure
    
    A failure generated by the AssertionError() checks can be added
    to selftest/knownfail.d/*.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit a77be15d28390c5d12202278adbe6b50200a2c1b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Jul 19 15:10:09 2019 +0000

    s3:winbindd: implement the "winbind use krb5 enterprise principals" logic
    
    We can use enterprise principals (e.g. upnfromB at B.EXAMPLE.COM@PRIMARY.A.EXAMPLE.COM)
    and delegate the routing decisions to the KDCs.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 9520652399696010c333a3ce7247809ce5337a91
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 11 16:44:43 2019 +0200

    docs-xml: add "winbind use krb5 enterprise principals" option
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 3bdf023956e861485be70430112ed38d0a5424f7
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 15:52:25 2019 +0200

    krb5_wrap: let smb_krb5_parse_name() accept enterprise principals
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 303b7e59a286896888ee2473995fc50bb2b5ce5e
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 16:04:30 2019 +0200

    s3:libads: ads_krb5_chg_password() should always use the canonicalized principal
    
    We should always use krb5_get_init_creds_opt_set_canonicalize()
    and krb5_get_init_creds_opt_set_win2k() for heimdal
    and expect the client principal to be changed.
    
    There's no reason to have a different logic between MIT and Heimdal.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 162b4199493c1f179e775a325a19ae7a136c418b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 16:04:30 2019 +0200

    s4:auth: kinit_to_ccache() should always use the canonicalized principal
    
    We should always use krb5_get_init_creds_opt_set_canonicalize()
    and krb5_get_init_creds_opt_set_win2k() for heimdal
    and expect the client principal to be changed.
    
    There's no reason to have a different logic between MIT and Heimdal.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 5d0bf32ec0ad21d49587e3a1520ffdc8b5ae7614
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 16:04:30 2019 +0200

    krb5_wrap: smb_krb5_kinit_password_ccache() should always use the canonicalized principal
    
    We should always use krb5_get_init_creds_opt_set_canonicalize()
    and krb5_get_init_creds_opt_set_win2k() for heimdal
    and expect the client principal to be changed.
    
    There's no reason to have a different logic between MIT and Heimdal.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 0bced73bed481a8846a6b3e68be85941914390ba
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 13 16:04:30 2019 +0200

    s3:libads/kerberos: always use the canonicalized principal after kinit
    
    We should always use krb5_get_init_creds_opt_set_canonicalize()
    and krb5_get_init_creds_opt_set_win2k() for heimdal
    and expect the client principal to be changed.
    
    There's no reason to have a different logic between MIT and Heimdal.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 6ed18c12c57efb2a010e0ce5196c51b48e57a4b9
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Sep 17 08:49:13 2019 +0200

    s3:libsmb: let cli_session_creds_prepare_krb5() update the canonicalized principal to cli_credentials
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 361fb0efabfb189526c851107eee49161da2293c
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Sep 17 10:08:10 2019 +0200

    s3:libsmb: avoid wrong debug message in cli_session_creds_prepare_krb5()
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit bc473e5cf088a137395842540ed8eb748373a236
Author: Stefan Metzmacher <metze at samba.org>
Date:   Mon Sep 16 17:14:11 2019 +0200

    s3:libads: let kerberos_kinit_password_ext() return the canonicalized principal/realm
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit db8fd3d6a315b140ebd6ccd0dcdfdcf27cd1bb38
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Sep 17 08:05:09 2019 +0200

    s4:auth: use the correct client realm in gensec_gssapi_update_internal()
    
    The function gensec_gssapi_client_creds() may call kinit and gets
    a TGT for the user. The principal provided by the user may not
    be canonicalized. The user may use 'given.last at example.com'
    but that may be mapped to glast at AD.EXAMPLE.PRIVATE in the background.
    
    It means we should use client_realm = AD.EXAMPLE.PRIVATE
    instead of client_realm = EXAMPLE.COM
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=14124
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit acbf922fc2963a42d6cbe652bb32eee231020958
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Sep 18 13:58:46 2019 +0200

    nsswitch: add logging to wbc_auth_error_to_pam_error() for non auth errors
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>

commit 4f5c4df316dc029f7b5ed6e8e48636dc61ecfe22
Author: Björn Jacke <bj at sernet.de>
Date:   Fri Aug 23 02:19:20 2019 +0200

    wscript_build: string concatenation efficiency cleanup
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>
    
    Autobuild-User(master): Björn Jacke <bjacke at samba.org>
    Autobuild-Date(master): Tue Sep 24 13:40:21 UTC 2019 on sn-devel-184

commit c9088c6aa847685613ec34d61b61e31fe0395035
Author: Björn Jacke <bj at sernet.de>
Date:   Fri Aug 23 02:21:17 2019 +0200

    pfm_verif: string concatenation efficiency cleanup
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit c7fa030aecd1de5ed32e2509ecd83828aa42c1a3
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:10:19 2019 +0200

    scripting: avoid inefficient string redefinition
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit 5ad629dcb957e45637f3a71309fa51abd87b267d
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:09:19 2019 +0200

    wscript: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit b3b6b700c47ba771baf632b3a165106c21c9ae04
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:08:18 2019 +0200

    s3/wscript: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit 32d1c3f873fc8bd89a7dc985cb8258e990dc12cd
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:07:48 2019 +0200

    posixacl.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Matthias Dieter Wallnöfer <mdw at samba.org>

commit dd9e0f0ae1cca23920883a0e04fe5862663e400e
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:07:13 2019 +0200

    auth_log_winbind.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit cf51f73e02cab85f508bcbef362ff75a7ae18d7f
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:06:19 2019 +0200

    schema.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit d2d8ebcca1cc4539a7a6b48fa364e03adda1db6c
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:06:00 2019 +0200

    user.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit ce56d336f234febfd4cb3da11dd584842c24ce1d
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:05:31 2019 +0200

    gpo.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 1825a7f4e2a39d03f01da37b68ba4f65dbafd04a
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:05:10 2019 +0200

    kcc_utils.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit 4c34a2d72569f31d59b904c3ca1c140f6084b3dd
Author: Björn Jacke <bj at sernet.de>
Date:   Sun Aug 25 23:04:25 2019 +0200

    traffic.py: avoid inefficient string concatenations
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>

commit b8f4f141a2d7aed9a8af572b27e2afcc1365bf3b
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 17:59:15 2019 +1000

    ctdb-tests: Switch TEST_VAR_DIR to a local script variable
    
    This is now local to run_tests.sh.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Tue Sep 24 03:46:59 UTC 2019 on sn-devel-184

commit e78c1a0ca2254b533ffa1ab27184e73e79819962
Author: Martin Schwenke <martin at meltin.net>
Date:   Mon Sep 9 16:13:45 2019 +1000

    ctdb-tests: Use CTDB_TEST_TMP_DIR in integration.bash
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 263890b36dbe23460a3d38050250d6d792907426
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 5 13:57:35 2019 +1000

    ctdb-tests: Switch simple tests to use CTDB_TEST_TMP_DIR
    
    CTDB_TEST_TMP_DIR repaces SIMPLE_TESTS_VAR_DIR.  local.bash no longer
    needs to ensure that TEST_VAR_DIR is set, since it longer uses this
    variable.  Drop the comment because state has not been maintained
    between tests for some time.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit def929954aa26116fc5356203b313b50fcb6d7a8
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 21:35:39 2019 +1000

    ctdb-tests: Switch takeover helper unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 1934f673dc7aadf8eb288d4ac1b46876d442e039
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 21:35:16 2019 +1000

    ctdb-tests: Switch tool unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 18ecdbfb02e64ae7942378efb69df7541b5859f0
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 19:58:46 2019 +1000

    ctdb-tests: Switch onnode unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 3b16aa2016e499af96c4cbb3de4cb38515e86284
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 20:13:19 2019 +1000

    ctdb-tests: Switch eventscript unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit 96aa807f79df99c0fd64ea66d7f83527d5a490c2
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 21:35:54 2019 +1000

    ctdb-tests: Switch eventd unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit cbd27c0a14247477acdf158cc40864afe91e5900
Author: Martin Schwenke <martin at meltin.net>
Date:   Fri Sep 6 21:47:52 2019 +1000

    ctdb-tests: Switch cunit unit tests to use CTDB_TEST_TMP_DIR
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>

commit cec8f3907ef7b324035b59f9a965c198b5d03de6
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Sep 5 13:42:26 2019 +1000

    ctdb-tests: Add new variable CTDB_TEST_TMP_DIR
    
    This is a subdirectory of TEST_VAR_DIR th