[SCM] Samba Shared Repository - branch master updated

[Alexander Bokovoy]

The branch, master has been updated
       via  3be17c891b6 s3 rpc server: set on-wire handle type explicitly
      from  954d877a2ee smbd: remove unneeded parent_dir variable from mkdir_internal()

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 3be17c891b61a7cbe3b529a2dc0d68753e81de35
Author: Alexander Bokovoy <ab at samba.org>
Date:   Wed Apr 29 11:54:07 2020 +0300

    s3 rpc server: set on-wire handle type explicitly
    
    Since wire_handle.handle_type is uint32_t, we can simply assign uint8_t
    handle type to it without using SIVAL() macros. Further unify with s4
    RPC server code flow.
    
    Fixes CID 1462616
    >>> CID 1462616:    (CONSTANT_EXPRESSION_RESULT)
    >>> "(uint32_t)handle_type >> 16" is 0 regardless of the values of its operands. This occurs as a value.
    284             SIVAL(&rpc_hnd->wire_handle.handle_type, 0 , handle_type);
    
    Signed-off-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
    Autobuild-Date(master): Thu Apr 30 07:09:55 UTC 2020 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_server/rpc_handles.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/rpc_handles.c b/source3/rpc_server/rpc_handles.c
index d215a6a6d88..8ae9d970ced 100644
--- a/source3/rpc_server/rpc_handles.c
+++ b/source3/rpc_server/rpc_handles.c
@@ -281,7 +281,7 @@ static struct dcesrv_handle_old *create_rpc_handle_internal(
 		pol_hnd_high++;
 	}
 
-	SIVAL(&rpc_hnd->wire_handle.handle_type, 0 , handle_type);
+	rpc_hnd->wire_handle.handle_type = handle_type;
 
 	/* second bit is incrementing */
 	SIVAL(&rpc_hnd->wire_handle.uuid.time_low, 0 , pol_hnd_low);


-- 
Samba Shared Repository