[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Tue Oct 8 02:41:03 UTC 2019


The branch, master has been updated
       via  7bceafe8401 s3/passdb: clang: Fix 'Value stored during initialization is never read'
      from  78161550bac torture: Allow running on FS that does not support EAs

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 7bceafe8401fdbf67c065d6799ea91d9667fd096
Author: Noel Power <noel.power at suse.com>
Date:   Fri Sep 6 14:48:54 2019 +0000

    s3/passdb: clang: Fix 'Value stored during initialization is never read'
    
    Fixes:
    
    source3/passdb/pdb_ldap.c:1933:11: warning: Value stored to 'ret' during its initialization is never read <--[clang]
            NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
                     ^~~   ~~~~~~~~~~~~~~~~~~~~~~
    source3/passdb/pdb_ldap.c:4094:11: warning: Value stored to 'ntstatus' during its initialization is never read <--[clang]
            NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
                     ^~~~~~~~   ~~~~~~~~~~~~~~~~~~~~~~
    2 warnings generated.
    
    Signed-off-by: Noel Power <noel.power at suse.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Oct  8 02:40:24 UTC 2019 on sn-devel-184

-----------------------------------------------------------------------

Summary of changes:
 source3/passdb/pdb_ldap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/passdb/pdb_ldap.c b/source3/passdb/pdb_ldap.c
index e9b01e57c6c..22050fa828c 100644
--- a/source3/passdb/pdb_ldap.c
+++ b/source3/passdb/pdb_ldap.c
@@ -1930,7 +1930,7 @@ static NTSTATUS ldapsam_delete_sam_account(struct pdb_methods *my_methods,
 
 static NTSTATUS ldapsam_update_sam_account(struct pdb_methods *my_methods, struct samu * newpwd)
 {
-	NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
+	NTSTATUS ret;
 	struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
 	int rc = 0;
 	char *dn;
@@ -4091,7 +4091,7 @@ static NTSTATUS ldapsam_get_account_policy(struct pdb_methods *methods,
 					   enum pdb_policy_type type,
 					   uint32_t *value)
 {
-	NTSTATUS ntstatus = NT_STATUS_UNSUCCESSFUL;
+	NTSTATUS ntstatus;
 
 	if (cache_account_policy_get(type, value)) {
 		DEBUG(11,("ldapsam_get_account_policy: got valid value from "


-- 
Samba Shared Repository



More information about the samba-cvs mailing list