[SCM] Samba Shared Repository - branch master updated
Jeremy Allison
jra at samba.org
Mon Nov 4 22:49:02 UTC 2019
The branch, master has been updated
via a58c93318d5 s3:libads: Fix mem leak in ads_create_machine_acct
from 831796b2d7c gitlab-ci: Run 'samba' tests also with MIT Kerberos
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit a58c93318d592d931d232a1a25e37abdd27a825d
Author: Jones Syue <jonessyue at qnap.com>
Date: Fri Nov 1 15:50:29 2019 +0800
s3:libads: Fix mem leak in ads_create_machine_acct
Use 'goto done' instead of 'return' to fix machine_escaped leak.
Signed-off-by: Jones Syue <jonessyue at qnap.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Mon Nov 4 22:48:50 UTC 2019 on sn-devel-184
-----------------------------------------------------------------------
Summary of changes:
source3/libads/ldap.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
mode change 100644 => 100755 source3/libads/ldap.c
Changeset truncated at 500 lines:
diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
old mode 100644
new mode 100755
index 90d402abb4e..a630c5a0345
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -2370,7 +2370,8 @@ ADS_STATUS ads_create_machine_acct(ADS_STRUCT *ads,
/* Make sure to NULL terminate the array */
spn_array = talloc_realloc(ctx, spn_array, const char *, num_spns + 1);
if (spn_array == NULL) {
- return ADS_ERROR_LDAP(LDAP_NO_MEMORY);
+ ret = ADS_ERROR(LDAP_NO_MEMORY);
+ goto done;
}
spn_array[num_spns] = NULL;
--
Samba Shared Repository
More information about the samba-cvs
mailing list