[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Thu Mar 21 16:42:02 UTC 2019


The branch, master has been updated
       via  52bf5c25261 s3:script: Fix running cp in modprinter.pl
       via  883436839ae s3:script: Fix running rsync in fake_snap.pl
       via  312e408cfde s3:lib: Increase debug level for messaging_send_buf message
      from  81648d576d5 ldb: Release ldb 1.6.3

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 52bf5c25261e343d3c1d4ea1a414ab74cf75d76c
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 21 16:06:05 2019 +0100

    s3:script: Fix running cp in modprinter.pl
    
    We need to unset BASH_ENV or we get:
        Insecure $ENV{BASH_ENV} while running setgid
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Thu Mar 21 16:41:33 UTC 2019 on sn-devel-144

commit 883436839aeb97b68ca18ae211199faa4448b5a0
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 21 14:37:28 2019 +0100

    s3:script: Fix running rsync in fake_snap.pl
    
    We need to unset BASH_ENV or we get:
        Insecure $ENV{BASH_ENV} while running setgid
    
    This probably only happens on recent perl versions.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>

commit 312e408cfde01ae8f5aab4c269becb119385f1bf
Author: Andreas Schneider <asn at samba.org>
Date:   Thu Mar 21 10:22:26 2019 +0100

    s3:lib: Increase debug level for messaging_send_buf message
    
    This is spamming the console when running 'make test' and we set the log
    level to 1 by default in selftest.
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Ralph Boehme <slow at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/messages.c                      | 2 +-
 source3/script/tests/fake_snap.pl           | 2 ++
 source3/script/tests/printing/modprinter.pl | 2 ++
 3 files changed, 5 insertions(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/messages.c b/source3/lib/messages.c
index dd19173b973..699282cff88 100644
--- a/source3/lib/messages.c
+++ b/source3/lib/messages.c
@@ -895,7 +895,7 @@ static int send_all_fn(pid_t pid, void *private_data)
 	status = messaging_send_buf(state->msg_ctx, pid_to_procid(pid),
 				    state->msg_type, state->buf, state->len);
 	if (!NT_STATUS_IS_OK(status)) {
-		DBG_WARNING("messaging_send_buf to %ju failed: %s\n",
+		DBG_NOTICE("messaging_send_buf to %ju failed: %s\n",
 			    (uintmax_t)pid, nt_errstr(status));
 	}
 
diff --git a/source3/script/tests/fake_snap.pl b/source3/script/tests/fake_snap.pl
index 18bbcb7142e..d88307eaecc 100755
--- a/source3/script/tests/fake_snap.pl
+++ b/source3/script/tests/fake_snap.pl
@@ -22,6 +22,8 @@ sub _create_snapshot
 	my $snap_path = $base_path . "/.snapshots/\@GMT-" . $time_str;
 	my $ret;
 
+	delete @ENV{'BASH_ENV'};
+
 	$ENV{'PATH'} = '/bin:/usr/bin'; # untaint PATH
 	POSIX::mkdir($base_path . "/.snapshots", 0755);
 
diff --git a/source3/script/tests/printing/modprinter.pl b/source3/script/tests/printing/modprinter.pl
index ec1ebcd7ab8..fc71e665451 100755
--- a/source3/script/tests/printing/modprinter.pl
+++ b/source3/script/tests/printing/modprinter.pl
@@ -131,6 +131,8 @@ if ($opt_delete && ($found_section == 0)) {
 	die "share $share_name not found";
 }
 
+delete @ENV{'BASH_ENV'};
+
 $ENV{'PATH'} = '/bin:/usr/bin'; # untaint PATH
 system("cp", "$tmp", "$smb_conf_file");
 unlink $tmp;


-- 
Samba Shared Repository



More information about the samba-cvs mailing list