[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Fri Jun 15 02:40:03 UTC 2018


The branch, master has been updated
       via  f4f3abf ldb_tdb: Use mem_ctx and so avoid leak onto long-term memory on duplicated add.
      from  5ef6775 smbd: don't call change_to_root_user() before change_to_guest()

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit f4f3abfa0e18bb4968b37b1cac40cd8c185c8d7b
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Wed Jun 13 11:20:00 2018 +0200

    ldb_tdb: Use mem_ctx and so avoid leak onto long-term memory on duplicated add.
    
    After a duplicated add a small amount of memory can be leaked onto a
    long-term context.
    
    Found by Andrej Gessel https://github.com/andiges
    
    https://github.com/samba-team/samba/commit/e8fb45125e6a279b918694668e0d4fbddac10aee#commitcomment-29334102
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13471
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Jun 15 04:39:41 CEST 2018 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 lib/ldb/ldb_tdb/ldb_tdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/lib/ldb/ldb_tdb/ldb_tdb.c b/lib/ldb/ldb_tdb/ldb_tdb.c
index 8581604..51d6087 100644
--- a/lib/ldb/ldb_tdb/ldb_tdb.c
+++ b/lib/ldb/ldb_tdb/ldb_tdb.c
@@ -626,7 +626,7 @@ static int ltdb_add_internal(struct ldb_module *module,
 			if (mem_ctx == NULL) {
 				return ldb_module_operr(module);
 			}
-			ret2 = ltdb_search_base(module, module,
+			ret2 = ltdb_search_base(module, mem_ctx,
 						msg->dn, &dn2);
 			TALLOC_FREE(mem_ctx);
 			if (ret2 == LDB_SUCCESS) {


-- 
Samba Shared Repository



More information about the samba-cvs mailing list