[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Fri Jun 8 11:24:03 UTC 2018


The branch, master has been updated
       via  7ddbf60 s4-heimdal: Fix the format-truncation errors.
      from  ae4e545 WHATSNEW.txt: Updated with VFS ABI changes for 4.9.0.

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 7ddbf6035dfec6806536f99d0257245f70661363
Author: Günther Deschner <gd at samba.org>
Date:   Wed May 30 09:27:49 2018 +0200

    s4-heimdal: Fix the format-truncation errors.
    
    ../source4/heimdal/lib/com_err/compile_et.c: In function ‘generate_h’:
    ../source4/heimdal/lib/com_err/compile_et.c:138:33: error: ‘%s’ directive output may be truncated writing up to 127 bytes into a region of size 126 [-Werror=format-truncation=]
         snprintf(fn, sizeof(fn), "__%s__", hfn);
                                     ^~     ~~~
    ../source4/heimdal/lib/com_err/compile_et.c:138:5: note: ‘snprintf’ output between 5 and 132 bytes into a destination of size 128
         snprintf(fn, sizeof(fn), "__%s__", hfn);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../source4/heimdal/lib/com_err/compile_et.c: In function ‘main’:
    ../source4/heimdal/lib/com_err/compile_et.c:234:35: error: ‘.h’ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
         snprintf(hfn, sizeof(hfn), "%s.h", Basename);
                                       ^~
    ../source4/heimdal/lib/com_err/compile_et.c:234:5: note: ‘snprintf’ output between 3 and 130 bytes into a destination of size 128
         snprintf(hfn, sizeof(hfn), "%s.h", Basename);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../source4/heimdal/lib/com_err/compile_et.c:235:35: error: ‘.c’ directive output may be truncated writing 2 bytes into a region of size between 1 and 128 [-Werror=format-truncation=]
         snprintf(cfn, sizeof(cfn), "%s.c", Basename);
                                       ^~
    ../source4/heimdal/lib/com_err/compile_et.c:235:5: note: ‘snprintf’ output between 3 and 130 bytes into a destination of size 128
         snprintf(cfn, sizeof(cfn), "%s.c", Basename);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cc1: some warnings being treated as errors
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
    
    Guenther
    
    Signed-off-by: Günther Deschner <gd at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Fri Jun  8 13:23:51 CEST 2018 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 source4/heimdal/lib/com_err/compile_et.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/heimdal/lib/com_err/compile_et.c b/source4/heimdal/lib/com_err/compile_et.c
index c72abde..5841eca 100644
--- a/source4/heimdal/lib/com_err/compile_et.c
+++ b/source4/heimdal/lib/com_err/compile_et.c
@@ -60,8 +60,8 @@ extern int yydebug = 1;
 #endif
 
 char *filename;
-char hfn[128];
-char cfn[128];
+char hfn[130];
+char cfn[130];
 
 struct error_code *codes = NULL;
 
@@ -128,7 +128,7 @@ static int
 generate_h(void)
 {
     struct error_code *ec;
-    char fn[128];
+    char fn[134];
     FILE *h_file = fopen(hfn, "w");
     char *p;
 


-- 
Samba Shared Repository



More information about the samba-cvs mailing list