[SCM] Samba Shared Repository - branch master updated

Stefan Metzmacher metze at samba.org
Wed Jul 25 23:30:02 UTC 2018


The branch, master has been updated
       via  4e711d1 smbd: don't client->connections without checking client != NULL first in exit_server_common()
      from  5ab0b4a examples/VFS/skel_transparent: make vfs_fn_pointers static

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 4e711d18c8e9953aca2ca64179c3d0b305a41c62
Author: Ralph Boehme <slow at samba.org>
Date:   Wed Jul 25 20:02:23 2018 +0200

    smbd: don't client->connections without checking client != NULL first in exit_server_common()
    
    exit_server_common() can be called also in smbd processes without a
    smbXsrv_client structure, e.g. the parent or some background tasks.
    
    Signed-off-by: Ralph Boehme <slow at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Thu Jul 26 01:29:38 CEST 2018 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/server_exit.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/server_exit.c b/source3/smbd/server_exit.c
index 149cd86..cc8ea18 100644
--- a/source3/smbd/server_exit.c
+++ b/source3/smbd/server_exit.c
@@ -96,6 +96,7 @@ static void exit_server_common(enum server_exit_reason how,
 
 	if (client != NULL) {
 		sconn = client->sconn;
+		xconn = client->connections;
 	}
 
 	if (!exit_firsttime)
@@ -108,7 +109,7 @@ static void exit_server_common(enum server_exit_reason how,
 	/*
 	 * Here we typically have just one connection
 	 */
-	for (xconn = client->connections; xconn != NULL; xconn = xconn_next) {
+	for (; xconn != NULL; xconn = xconn_next) {
 		xconn_next = xconn->next;
 		DLIST_REMOVE(client->connections, xconn);
 


-- 
Samba Shared Repository



More information about the samba-cvs mailing list