[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Wed Jan 31 23:34:03 UTC 2018


The branch, master has been updated
       via  925dc87 talloc_zero libnet_context on init
      from  21eb516 vfs_virusfilter: Fix CID 1428738 Macro compares unsigned to 0

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 925dc87a2ae47ba67e33d46b059fd9a57772dabf
Author: Swen Schillig <swen at vnet.ibm.com>
Date:   Fri Jan 26 09:12:12 2018 +0100

    talloc_zero libnet_context on init
    
    Zero the libnet_context on initialization
    preventing an uninitalized cli_credentials struct.
    
    Signed-off-by: Swen Schillig <swen at vnet.ibm.com>
    Reviewed-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Feb  1 00:33:34 CET 2018 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 source4/libnet/libnet.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/libnet/libnet.c b/source4/libnet/libnet.c
index 32df85d..a590893 100644
--- a/source4/libnet/libnet.c
+++ b/source4/libnet/libnet.c
@@ -33,8 +33,8 @@ struct libnet_context *libnet_context_init(struct tevent_context *ev,
 		return NULL;
 	}
 
-	/* create brand new libnet context */ 
-	ctx = talloc(ev, struct libnet_context);
+	/* create brand new libnet context */
+	ctx = talloc_zero(ev, struct libnet_context);
 	if (!ctx) {
 		return NULL;
 	}
@@ -48,14 +48,8 @@ struct libnet_context *libnet_context_init(struct tevent_context *ev,
 	/* name resolution methods */
 	ctx->resolve_ctx = lpcfg_resolve_context(lp_ctx);
 
-	/* connected services' params */
-	ZERO_STRUCT(ctx->samr);
-	ZERO_STRUCT(ctx->lsa);	
-
 	/* default buffer size for various operations requiring specifying a buffer */
 	ctx->samr.buf_size = 128;
 
-	ctx->server_address = NULL;
-
 	return ctx;
 }


-- 
Samba Shared Repository



More information about the samba-cvs mailing list