[SCM] Samba Shared Repository - branch master updated
Björn Jacke
bjacke at samba.org
Wed Dec 19 19:59:02 UTC 2018
The branch, master has been updated
via 49dc04f9f55 samba-tool: don't print backtrace on simple DNS errors
from fe7ab7d5132 tests/ntlm_auth: Port ntlm_auth_diagnostics tests to python
https://git.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit 49dc04f9f553c443c78c8073c07ea2a38cde61b2
Author: Björn Jacke <bj at sernet.de>
Date: Tue Dec 18 12:58:53 2018 +0100
samba-tool: don't print backtrace on simple DNS errors
samba-tool throws backtraces even for simple DNS error
messages, we should not frighten users for no good reason.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13721
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Wed Dec 19 20:58:52 CET 2018 on sn-devel-144
-----------------------------------------------------------------------
Summary of changes:
python/samba/netcmd/dns.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
Changeset truncated at 500 lines:
diff --git a/python/samba/netcmd/dns.py b/python/samba/netcmd/dns.py
index b50e7b7dd0c..b7459a71acd 100644
--- a/python/samba/netcmd/dns.py
+++ b/python/samba/netcmd/dns.py
@@ -780,7 +780,7 @@ class cmd_zonedelete(Command):
None)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_ZONE_DOES_NOT_EXIST:
- self.outf.write('Zone does not exist and so could not be deleted.')
+ raise CommandError('Zone does not exist and so could not be deleted.')
raise e
self.outf.write('Zone %s deleted successfully\n' % zone)
@@ -860,7 +860,7 @@ class cmd_query(Command):
None, record_type, select_flags, None, None)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_NAME_DOES_NOT_EXIST:
- self.outf.write('Record or zone does not exist.')
+ raise CommandError('Record or zone does not exist.')
raise e
print_dnsrecords(self.outf, res)
@@ -940,7 +940,7 @@ class cmd_add_record(Command):
0, server, zone, name, add_rec_buf, None)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_NAME_DOES_NOT_EXIST:
- self.outf.write('Zone does not exist; record could not be added.\n')
+ raise CommandError('Zone does not exist; record could not be added.')
raise e
self.outf.write('Record added successfully\n')
@@ -1011,7 +1011,7 @@ class cmd_update_record(Command):
del_rec_buf)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_NAME_DOES_NOT_EXIST:
- self.outf.write('Zone does not exist; record could not be updated.\n')
+ raise CommandError('Zone does not exist; record could not be updated.')
raise e
self.outf.write('Record updated successfully\n')
@@ -1066,7 +1066,7 @@ class cmd_delete_record(Command):
del_rec_buf)
except WERRORError as e:
if e.args[0] == werror.WERR_DNS_ERROR_NAME_DOES_NOT_EXIST:
- self.outf.write('Zone does not exist; record could not be deleted.\n')
+ raise CommandError('Zone does not exist; record could not be deleted.')
raise e
self.outf.write('Record deleted successfully\n')
--
Samba Shared Repository
More information about the samba-cvs
mailing list