[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Wed Dec 19 11:41:03 UTC 2018


The branch, master has been updated
       via  b1ad5a880fd krb5_wrap: Fix bit shifting
      from  5118985841a lib/util: Count a trailing line that doesn't end in a newline

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit b1ad5a880fd571c970a0fff33e20f4ea0c469f4c
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Dec 12 10:10:08 2018 +0100

    krb5_wrap: Fix bit shifting
    
    lib/krb5_wrap/enctype_convert.c:93:27: runtime error: left shift of 1 by
    31 places cannot be represented in type 'int'
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Gary Lockyer <gary at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Dec 19 12:40:40 CET 2018 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 lib/krb5_wrap/enctype_convert.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/lib/krb5_wrap/enctype_convert.c b/lib/krb5_wrap/enctype_convert.c
index b78304f6bf0..a658911190a 100644
--- a/lib/krb5_wrap/enctype_convert.c
+++ b/lib/krb5_wrap/enctype_convert.c
@@ -90,7 +90,7 @@ krb5_error_code ms_suptypes_to_ietf_enctypes(TALLOC_CTX *mem_ctx,
 		return ENOMEM;
 	}
 	for (i = 0; i < (8 * sizeof(enctype_bitmap)); i++) {
-		uint32_t bit_value = (1 << i) & enctype_bitmap;
+		uint32_t bit_value = (1U << i) & enctype_bitmap;
 		if (bit_value & enctype_bitmap) {
 			(*enctypes)[j] = ms_suptype_to_ietf_enctype(bit_value);
 			if (!(*enctypes)[j]) {


-- 
Samba Shared Repository



More information about the samba-cvs mailing list