[SCM] Samba Shared Repository - branch master updated

Douglas Bagnall dbagnall at samba.org
Fri Aug 10 07:28:02 UTC 2018


The branch, master has been updated
       via  7528749 samba-tool drs showrepl tests: improve debugging for mystery error
      from  1a86733 provision: Add support for BIND 9.12.x

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 75287495f2e16e333ce1afe9d1b168b951350053
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date:   Fri Aug 10 16:11:58 2018 +1200

    samba-tool drs showrepl tests: improve debugging for mystery error
    
    Under some circumstances the samba-tool command is failing with no
    stdout output at all, leaving few clues in the logs.
    
    Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    Reviewed-by: Garming Sam <garming at catalyst.net.nz>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Fri Aug 10 09:27:03 CEST 2018 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 source4/torture/drs/python/samba_tool_drs_showrepl.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source4/torture/drs/python/samba_tool_drs_showrepl.py b/source4/torture/drs/python/samba_tool_drs_showrepl.py
index 54c38c0..8c8d647 100644
--- a/source4/torture/drs/python/samba_tool_drs_showrepl.py
+++ b/source4/torture/drs/python/samba_tool_drs_showrepl.py
@@ -311,7 +311,13 @@ class SambaToolDrsShowReplTests(drs_base.DrsBaseTestCase):
 
         except samba.tests.BlackboxProcessError as e:
             print("Good, failed as expected after %d rounds: %r" % (i, e.cmd))
-            self.assertIn('There are failing connections', e.stdout)
+            self.assertIn('There are failing connections', e.stdout,
+                          msg=('stdout: %r\nstderr: %r\nretcode: %s'
+                               '\nmessage: %r\ncmd: %r') % (e.stdout,
+                                                            e.stderr,
+                                                            e.returncode,
+                                                            e.msg,
+                                                            e.cmd))
             self.assertRegexpMatches(
                 e.stdout,
                 r'result 845[67] '


-- 
Samba Shared Repository



More information about the samba-cvs mailing list