[SCM] Samba Shared Repository - branch master updated

Björn Jacke bjacke at samba.org
Wed Apr 25 11:56:02 UTC 2018


The branch, master has been updated
       via  35f2afe printing: return the same error code as windows does on upload failures
      from  d7cfb12 lib: #include "util_event.h" only where needed

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 35f2afe411a3b22fb1befadb3bee8da1bc14753c
Author: Björn Jacke <bjacke at samba.org>
Date:   Thu Apr 19 16:14:38 2018 +0200

    printing: return the same error code as windows does on upload failures
    
    Some print drivers inf files are broken and cause driver installation to fail
    on Samba servers. Windows returns WERR_APP_INIT_FAILURE in that case, we should
    do the same. Windows machines are less unlucky with that.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13395
    
    Signed-off-by: Bjoern Jacke <bjacke at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    
    Autobuild-User(master): Björn Jacke <bj at sernet.de>
    Autobuild-Date(master): Wed Apr 25 13:55:25 CEST 2018 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 source3/printing/nt_printing.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index 241af37..54357b7 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -1217,7 +1217,7 @@ static WERROR move_driver_file_to_download_area(TALLOC_CTX *mem_ctx,
 				 "to rename [%s] to [%s]: %s\n",
 				 smb_fname_old->base_name, new_name,
 				 nt_errstr(status)));
-			ret = WERR_ACCESS_DENIED;
+			ret = WERR_APP_INIT_FAILURE;
 			goto out;
 		}
 	}


-- 
Samba Shared Repository



More information about the samba-cvs mailing list