[SCM] Samba Shared Repository - branch master updated

Alexander Bokovoy ab at samba.org
Fri Apr 20 16:19:02 UTC 2018


The branch, master has been updated
       via  a18b510 s3/security.c undefined value
       via  c67a2f8 ldb_wrap.c missing header
      from  9985947 s3:passdb: Do not return OK if we don't have pinfo set up

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit a18b51000ef2ab5c9c111490394ce0e2425edee2
Author: William Brown <william at blackhats.net.au>
Date:   Thu Apr 19 09:39:33 2018 +1000

    s3/security.c undefined value
    
    s3/security.c had an NTSTATUS status that was undefined and with the configure
    option --address-sanitizer this caused uninitialised value error.
    
    Signed-off-by: William Brown <william at blackhats.net.au>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Simo Sorce <idra at samba.org>
    
    Autobuild-User(master): Alexander Bokovoy <ab at samba.org>
    Autobuild-Date(master): Fri Apr 20 18:18:25 CEST 2018 on sn-devel-144

commit c67a2f85a7b9331feaef1489cbaaba11de4f9748
Author: William Brown <william at blackhats.net.au>
Date:   Thu Apr 19 09:39:17 2018 +1000

    ldb_wrap.c missing header
    
    ldb_wrap.c was missing unistd.h causing implicit symbol declaration and error
    during compilation.
    
    Signed-off-by: William Brown <william at blackhats.net.au>
    Reviewed-by: Alexander Bokovoy <ab at samba.org>
    Reviewed-by: Simo Sorce <idra at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 lib/ldb-samba/ldb_wrap.c        | 1 +
 source3/libgpo/gpext/security.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/lib/ldb-samba/ldb_wrap.c b/lib/ldb-samba/ldb_wrap.c
index 143e128..3d3eb8b 100644
--- a/lib/ldb-samba/ldb_wrap.c
+++ b/lib/ldb-samba/ldb_wrap.c
@@ -37,6 +37,7 @@
 #include "../lib/util/dlinklist.h"
 #include "lib/util/util_paths.h"
 #include <tdb.h>
+#include <unistd.h>
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_LDB
diff --git a/source3/libgpo/gpext/security.c b/source3/libgpo/gpext/security.c
index 29e7bb7..b6b7ca0 100644
--- a/source3/libgpo/gpext/security.c
+++ b/source3/libgpo/gpext/security.c
@@ -150,7 +150,7 @@ static NTSTATUS security_process_group_policy(TALLOC_CTX *mem_ctx,
 					      const struct GROUP_POLICY_OBJECT *deleted_gpo_list,
 					      const struct GROUP_POLICY_OBJECT *changed_gpo_list)
 {
-	NTSTATUS status;
+	NTSTATUS status = NT_STATUS_OK;
 	char *unix_path = NULL;
 	struct gp_inifile_context *ini_ctx = NULL;
 	const struct GROUP_POLICY_OBJECT *gpo;


-- 
Samba Shared Repository



More information about the samba-cvs mailing list