[SCM] Samba Shared Repository - branch v4-6-test updated

Karolin Seeger kseeger at samba.org
Fri Sep 22 11:37:02 UTC 2017


The branch, v4-6-test has been updated
       via  96a8f4c torture/ioctl: test set_compression(format_none)
      from  bb54467 VERSION: Bump version up to 4.6.9...

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-6-test


- Log -----------------------------------------------------------------
commit 96a8f4c7167c3f45856b8166c092430efd417e57
Author: David Disseldorp <ddiss at samba.org>
Date:   Thu Jan 5 17:10:42 2017 +0100

    torture/ioctl: test set_compression(format_none)
    
    This test case was overlooked in the previous bso#12144 update -
    set compression requests with format=COMPRESSION_FORMAT_NONE should
    succeed if the server / backing storage doesn't offer compression
    support.
    Confirm that Samba matches Windows Server 2016 ReFS behaviour here.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=12144
    
    Reported-by: Nick Barrett <nick at barrett.org.nz>
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    (cherry picked from commit 6fde123176409e261d955e24b3d28e5124f33bed)
    
    Autobuild-User(v4-6-test): Karolin Seeger <kseeger at samba.org>
    Autobuild-Date(v4-6-test): Fri Sep 22 13:36:22 CEST 2017 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 source4/torture/smb2/ioctl.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source4/torture/smb2/ioctl.c b/source4/torture/smb2/ioctl.c
index 01cc150..54a36a8 100644
--- a/source4/torture/smb2/ioctl.c
+++ b/source4/torture/smb2/ioctl.c
@@ -2608,7 +2608,16 @@ static bool test_ioctl_compress_notsup_set(struct torture_context *torture,
 					 COMPRESSION_FORMAT_DEFAULT);
 	torture_assert_ntstatus_equal(torture, status,
 				      NT_STATUS_NOT_SUPPORTED,
-				      "FSCTL_GET_COMPRESSION");
+				      "FSCTL_SET_COMPRESSION default");
+
+	/*
+	 * Despite not supporting compression, we should get a successful
+	 * response for set(COMPRESSION_FORMAT_NONE) - like WS2016 ReFS.
+	 */
+	status = test_ioctl_compress_set(torture, tmp_ctx, tree, fh,
+					 COMPRESSION_FORMAT_NONE);
+	torture_assert_ntstatus_ok(torture, status,
+				   "FSCTL_SET_COMPRESSION none");
 
 	smb2_util_close(tree, fh);
 	talloc_free(tmp_ctx);


-- 
Samba Shared Repository



More information about the samba-cvs mailing list