[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Thu May 5 06:34:03 UTC 2016

The branch, master has been updated
       via  d4d14b1 lib:talloc. Fix memory leak when destructors reparent children.
      from  2fe2e66 autobuild: fix typo in autobuild success subject line


- Log -----------------------------------------------------------------
commit d4d14b15b6734e99f8527136ec007a97024ac348
Author: Saji VR <saji.vr at nutanix.com>
Date:   Wed May 4 15:14:55 2016 -0700

    lib:talloc. Fix memory leak when destructors reparent children.
    If a destructor reparents a child, we shouldn't exit the
    loop freeing children as there may be others to process.
    Signed-off-by: Saji VR <saji.vr at nutanix.com>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Richard Sharpe <rsharpe at samba.org>
    Reviewed-by: Ira Cooper <ira at samba.org>
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu May  5 08:33:53 CEST 2016 on sn-devel-144


Summary of changes:
 lib/talloc/talloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Changeset truncated at 500 lines:

diff --git a/lib/talloc/talloc.c b/lib/talloc/talloc.c
index 90b9d96..48d2033 100644
--- a/lib/talloc/talloc.c
+++ b/lib/talloc/talloc.c
@@ -1528,7 +1528,7 @@ static inline void _talloc_free_children_internal(struct talloc_chunk *tc,
 				 * Destructor already reparented this child.
 				 * No further reparenting needed.
-				return;
+				continue;
 			if (new_parent == null_context) {
 				struct talloc_chunk *p = talloc_parent_chunk(ptr);

Samba Shared Repository

More information about the samba-cvs mailing list