[SCM] Samba Shared Repository - branch master updated

Douglas Bagnall dbagnall at samba.org
Fri Jun 3 09:03:03 UTC 2016


The branch, master has been updated
       via  82a1094 samba_spnupdate: do not interpret failure count as unix error code
       via  5c008e0 samba_dnsupdate: do not interpret failure count as unix error code
      from  469fdcd Efficient xattr handling for VxFS Signed-off-by: Abhidnya Joshi <Abhidnya.Joshi at veritas.com>

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 82a10942d4e88b474b2e87f53cf2d82977e596e0
Author: Bob Campbell <bobcampbell at catalyst.net.nz>
Date:   Fri Jun 3 14:32:10 2016 +1200

    samba_spnupdate: do not interpret failure count as unix error code
    
    Signed-off-by: Bob Campbell <bobcampbell at catalyst.net.nz>
    Pair-programmed-with: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
    
    Autobuild-User(master): Douglas Bagnall <dbagnall at samba.org>
    Autobuild-Date(master): Fri Jun  3 11:02:26 CEST 2016 on sn-devel-144

commit 5c008e0216d8fc92d9081781895fbc9c008ce5cc
Author: Bob Campbell <bobcampbell at catalyst.net.nz>
Date:   Fri Jun 3 13:56:23 2016 +1200

    samba_dnsupdate: do not interpret failure count as unix error code
    
    Signed-off-by: Bob Campbell <bobcampbell at catalyst.net.nz>
    Pair-programmed-with: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>

-----------------------------------------------------------------------

Summary of changes:
 lib/util/util_runcmd.c        |  4 ++--
 source4/dsdb/dns/dns_update.c | 21 +++++----------------
 2 files changed, 7 insertions(+), 18 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/util/util_runcmd.c b/lib/util/util_runcmd.c
index cc194fc..02de77e 100644
--- a/lib/util/util_runcmd.c
+++ b/lib/util/util_runcmd.c
@@ -304,8 +304,8 @@ static void samba_runcmd_io_handler(struct tevent_context *ev,
 				return;
 			}
 			status = WEXITSTATUS(status);
-			DEBUG(3,("Child %s exited with status %d - %s\n",
-				 state->arg0, status, strerror(status)));
+			DEBUG(3,("Child %s exited with status %d\n",
+				 state->arg0, status));
 			if (status != 0) {
 				tevent_req_error(req, status);
 				return;
diff --git a/source4/dsdb/dns/dns_update.c b/source4/dsdb/dns/dns_update.c
index 292a825..0591e34 100644
--- a/source4/dsdb/dns/dns_update.c
+++ b/source4/dsdb/dns/dns_update.c
@@ -284,15 +284,10 @@ static void dnsupdate_nameupdate_done(struct tevent_req *subreq)
 
 	ret = samba_runcmd_recv(subreq, &sys_errno);
 	TALLOC_FREE(subreq);
-	if (ret != 0) {
-		service->nameupdate.status = map_nt_error_from_unix_common(sys_errno);
-	} else {
-		service->nameupdate.status = NT_STATUS_OK;
-	}
 
-	if (!NT_STATUS_IS_OK(service->nameupdate.status)) {
-		DEBUG(0,(__location__ ": Failed DNS update - %s\n",
-			 nt_errstr(service->nameupdate.status)));
+	if (ret != 0) {
+		DEBUG(0,(__location__ ": Failed DNS update - with error code %d\n",
+			 sys_errno));
 	} else {
 		DEBUG(3,("Completed DNS update check OK\n"));
 	}
@@ -314,14 +309,8 @@ static void dnsupdate_spnupdate_done(struct tevent_req *subreq)
 	ret = samba_runcmd_recv(subreq, &sys_errno);
 	TALLOC_FREE(subreq);
 	if (ret != 0) {
-		service->nameupdate.status = map_nt_error_from_unix_common(sys_errno);
-	} else {
-		service->nameupdate.status = NT_STATUS_OK;
-	}
-
-	if (!NT_STATUS_IS_OK(service->nameupdate.status)) {
-		DEBUG(0,(__location__ ": Failed SPN update - %s\n",
-			 nt_errstr(service->nameupdate.status)));
+		DEBUG(0,(__location__ ": Failed SPN update - with error code %d\n",
+			 sys_errno));
 	} else {
 		DEBUG(3,("Completed SPN update check OK\n"));
 	}


-- 
Samba Shared Repository



More information about the samba-cvs mailing list