[SCM] Samba Shared Repository - branch master updated

Andrew Bartlett abartlet at samba.org
Wed Jul 6 02:28:03 UTC 2016


The branch, master has been updated
       via  20319ba gensec: Change log level for message when obtaining PAC from gss_get_name_attribute failed
      from  77f3730 auth: fix a memory leak in gssapi_get_session_key()

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 20319ba51e0df60e1dc7787b81f7078467d64878
Author: Christof Schmitt <cs at samba.org>
Date:   Fri Jul 1 11:52:15 2016 -0700

    gensec: Change log level for message when obtaining PAC from gss_get_name_attribute failed
    
    This is the second part for the issue from commit 8bb4fccd. A KDC that
    does not return a PAC first triggers this message, then the "resorting
    to local user lookup" one. Change the log level for the "obtaining PAC
    via GSSAPI gss_get_name_attribute" message as well to avoid spamming the
    logs during normal usage. While changing this message, also remove the
    discard_const since it is no longer required.
    
    Signed-off-by: Christof Schmitt <cs at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Wed Jul  6 04:27:03 CEST 2016 on sn-devel-144

-----------------------------------------------------------------------

Summary of changes:
 auth/kerberos/gssapi_pac.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/auth/kerberos/gssapi_pac.c b/auth/kerberos/gssapi_pac.c
index 74c199a..bcc1ba4 100644
--- a/auth/kerberos/gssapi_pac.c
+++ b/auth/kerberos/gssapi_pac.c
@@ -112,12 +112,10 @@ NTSTATUS gssapi_obtain_pac_blob(TALLOC_CTX *mem_ctx,
 		&pac_buffer, &pac_display_buffer, &more);
 
 	if (gss_maj != 0) {
-		DEBUG(0, ("obtaining PAC via GSSAPI gss_get_name_attribute failed: %s\n",
-			  gssapi_error_string(mem_ctx,
-					      gss_maj,
-					      gss_min,
-					      discard_const_p(struct gss_OID_desc_struct,
-							      gss_mech_krb5))));
+		DBG_NOTICE("obtaining PAC via GSSAPI gss_get_name_attribute "
+			   "failed: %s\n", gssapi_error_string(mem_ctx,
+							       gss_maj, gss_min,
+							       gss_mech_krb5));
 		return NT_STATUS_ACCESS_DENIED;
 	} else if (authenticated && complete) {
 		/* The PAC blob is returned directly */


-- 
Samba Shared Repository



More information about the samba-cvs mailing list