[SCM] Samba Shared Repository - branch v4-4-stable created
Stefan Metzmacher
metze at samba.org
Tue Jan 26 11:40:45 UTC 2016
The branch, v4-4-stable has been created
at 6a24cccd804eb8b89023fa0265d548fd722d909f (commit)
- Log -----------------------------------------------------------------
commit 6a24cccd804eb8b89023fa0265d548fd722d909f
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 12:01:44 2016 +0100
s3:smbd: only process fsctl_network_iface_info if multi channel is enabled
This effectively disables it for now.
Ultimately, we may want to remove this restriction.
Hence a separate patch.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Jan 26 10:40:44 CET 2016 on sn-devel-144
commit e8a051f58a8f785ba8df66d263a1c632603f3650
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Jun 13 17:42:00 2014 +0200
s3:smbd: implement fsctl_network_iface_info
The ioctl used for detecting interfaces for multi-channel.
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 99d3dbee9952d2947e64a68380686b12c6a1e7f5
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 16:35:12 2016 +0100
docs:smb.conf: document new extra syntax for interfaces.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9fcf87419f3f68429bb365ffb605be3eacc97e15
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 16:22:57 2016 +0100
s4:lib:socket: skip extra data in interpret_interface()
This is currently smbd-specific.
No need to duplicate the extended parsing
while these functions have not been merged yet.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8284b34f95639ad7c2e3a97b514529201c20e2ed
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 03:38:54 2016 +0100
s3:lib: extend interpret_interface() to optionally read speed, caps, and index from config
New syntax for interfaces parameter:
interfaces = address[;key=value[,key=value[,...]]]
- keys can be 'speed', 'capability', and 'if_index'.
- speed is in bits per second.
- capability can be RSS and RDMA.
- if_index should be used with care, because
these indexes should not conicide with indexes
the kernel sets...
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3785be8d4e66f1bf01ec1b64a8e2325e4de08196
Author: Michael Adam <obnox at samba.org>
Date: Sun Jan 24 13:26:35 2016 +0100
s3:lib: remove an unmotivated comment from interpret_interface()
This seems to be a left-over from historic code.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e569ffd83138952454ba9b9fb38ee7d852293697
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 14:09:37 2016 +0100
s3:lib: copy speed, cap, and index in add_interface()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9f9d6ac8c1594f0c090a176d189c99fba3c31966
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 03:38:16 2016 +0100
smb.h: add linkspeed, capability, and if_index to interface struct
Pair-Programmed-With: Anoop C S <anoopcs at redhat.com>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 549a9abc7e037442dd8955b52caaaf11a1e4bc02
Author: Anoop C S <anoopcs at redhat.com>
Date: Fri Jan 22 20:51:55 2016 +0530
lib:socket: detect link speed with ethtool ioctl in get_interfaces (on linux)
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1862aa6c259ebe6de86b220208e315a22515b453
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 03:30:39 2016 +0100
build: detect support for ethtool
Pair-Programmed-With: Anoop C S <anoopcs at redhat.com>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 64be8e73ff73bfb546d4753b58937d53898412cb
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 03:38:31 2016 +0100
lib:socket: set defaults for linkspeed and capability in get_interfaces()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 235f37baa7df03ef44f71aea50d72603297a611d
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 12:23:40 2016 +0100
lib:socket: get interface index from kernel
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d392e0a66d941eb66c1973cfa3e54653f5e7d240
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 03:38:05 2016 +0100
lib:socket: add linkspeed, capability and if_index to iface_struct
Pair-Programmed-With: Anoop C S <anoopcs at redhat.com>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit bc9e1fc70cda0dffd8a4959db4d51bc0bc136206
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 25 03:37:38 2016 +0100
librpc:idl: define FSCTL_NET_IFACE_NONE_CAPABLE in ioctl.idl
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a2894cf4e0c733b14e645ae492b8cd1c13878900
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 21 12:46:40 2016 +0100
s3:lib: add braces around if-block in my_sam_name()
Clean-up after moving the function.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Jan 26 03:19:18 CET 2016 on sn-devel-144
commit d67d8e194b221315cde56f4728935071eecb378b
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 21 12:45:42 2016 +0100
s3:lib: remove supefluous comments from map_my_name()
cleanup after moving
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 6eaf40f5a4ac2e7fe3b40176932acf7abd51279a
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 21 12:44:19 2016 +0100
s3:lib: fix white spaces in my_sam_name()
Clean-up after function has been moved.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit dee38e04d217a868721b622b5c9c22d3ba381790
Author: Uri Simchoni <uri at samba.org>
Date: Tue Nov 3 13:21:58 2015 +0200
vfs_shadow_copy2: documentation for snapsharepath
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit bbb5a8a9d545b4e3014bdcb96dd7c7d48cf0b8f7
Author: Uri Simchoni <uri at samba.org>
Date: Tue Nov 3 11:15:52 2015 +0200
vfs_shadow_copy2: add tests for snapsharepath
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 84333884ff34a75ceec8f966c1f7e6ad5566a4d2
Author: Uri Simchoni <uri at samba.org>
Date: Tue Nov 3 10:57:13 2015 +0200
vfs_shadow_copy2: add snapsharepath parameter
This new parameter defines how to get from the snapshot's
root directory to the share's root directory. It is an
alternative to the "basedir" parameter, but functionally
is a superset of basedir.
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 57dab2028d1e2616b65da0c315388233cfd36c1f
Author: Uri Simchoni <uri at samba.org>
Date: Tue Nov 3 09:15:12 2015 +0200
vfs_shadow_copy2: remove basedir state variable
Remove the basedir state variable from the module-specific data
of vfs_shadow_copy2 - this variable is not being used.
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 500bc01478881cab89f0e691427e34a405bb0003
Author: Alexander Bokovoy <ab at samba.org>
Date: Fri Jan 22 11:44:03 2016 +0200
s3-parm: clean up defaults when removing global parameters
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11693
When globals are re-initialized, they are cleared and globals' talloc
context is freed. However, parm_table still contains a reference to the
global value in the defaults. This confuses lpcfg_string_free() after
commit 795c543d858b2452f062a02846c2f908fe4cffe4 because it tries to
free already freed pointer which is passed by lp_save_defaults():
....
case P_STRING:
case P_USTRING:
lpcfg_string_set(Globals.ctx,
&parm_table[i].def.svalue,
*(char **)lp_parm_ptr(NULL, &parm_table[i]));
....
here &parm_table[i].def.svalue is passed to lpcfg_string_free() but it
is a pointer to a value allocated with previous Globals.ctx which
already was freed.
This specifically affects registry backend of smb.conf in lp_load_ex()
where init_globals() called explicitly to re-init globals after
lp_save_defaults() if we have registry backend defined.
Reviewed-by: Uri Simchoni <uri at samba.org>
Signed-off-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Mon Jan 25 23:58:42 CET 2016 on sn-devel-144
commit 62c68bd8c8f7a7e057e38a461707f1c195e62df0
Author: Andreas Schneider <asn at cryptomilk.org>
Date: Tue Jan 12 15:17:22 2016 +0100
s3-client: Add a KRB5 wrapper for smbspool
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11690
We need a wrapper for smbspool to be able to authenticate with Kerberos.
This needs to replace the cups smb backend. The permission need to be
0700 and the owner root.
Note that Kerberos support is broken in CUPS 2.1.2 maybe earlier
versions. It works with 1.6.3.
Signed-off-by: Andreas Schneider <asn at cryptomilk.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Jan 25 19:58:46 CET 2016 on sn-devel-144
commit 1bf7905065760c289560c71106fd2b2b205f0683
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Jan 25 20:29:35 2016 +1100
WHATSNEW: Documentation CTDB changes for v4.4
Signed-off-by: Martin Schwenke <martin at meltin.net>
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Mon Jan 25 16:47:54 CET 2016 on sn-devel-144
commit b7da062cba6303cd84f947a312404cffde7fa3c1
Author: Christian Ambach <ambi at samba.org>
Date: Sun Jan 24 11:57:01 2016 +0100
s3:utils/smbget make use of bool for flags
convert flags stored as int to bool
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Jan 25 13:33:12 CET 2016 on sn-devel-144
commit 76f16796ccf378c2d0d6a1a46ed127bf72ad0e4b
Author: Christian Ambach <ambi at samba.org>
Date: Sun Jan 24 11:45:59 2016 +0100
s3:utils/smbget use C99 format identifiers
for ssize_t and off_t variables
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 4d033bac766e5c7bae09447e6b3a1f23b03af998
Author: Christian Ambach <ambi at samba.org>
Date: Sun Jan 24 11:17:20 2016 +0100
s3:utils/smbget code format
adopt the code to latest README.Coding standards
e.g. curly braces everywhere, blanks before braces,
obey 80 character limit (except for the popt definitions)
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ec802d27ce4dc6dd9b5e5ebd6992f90364d855a2
Author: Christian Ambach <ambi at samba.org>
Date: Wed Dec 30 21:25:13 2015 +0100
s3:utils/smbget fix recursive download
get_auth_data is called multiple times (once for the directory listing and then
for every file to be downloaded). Save the obtained values across multiple calls
to make smbclient use the correct username for each download.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=6482
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit c8a5ab9ed2cdde3958000d00e634955e437afa05
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Jan 25 12:52:43 2016 +1100
WHATSNEW: CTDB_NATGW_SLAVE_ONLY is no longer used
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Mon Jan 25 10:23:49 CET 2016 on sn-devel-144
commit df6cca2bc03df2208a76126fa98b1c4d2306b67f
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Jan 5 15:58:29 2016 +1100
ctdb-tools: Drop support for setting and viewing NAT gateway capability
This is no longer used.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 3b64c27ca6def4f0ec7f6c5b543977f9a48647f9
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Jan 5 15:53:50 2016 +1100
ctdb-scripts: No longer set the NAT gateway capability
Nothing checks it anymore.
This means that the NAT gateway capability in the daemon is now
unused.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 411ccb98c3e1c3d6bd26e74874c03acb0d470454
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Jan 21 12:53:43 2016 +1100
ctdb/tools: Update ctdb CLI tool to call ctdb_natgw
The "natgwlist" command is no longer marked "auto all" and is also
marked "without daemon". That latter is not strictly true because
ctdb_natgw needs the daemon so a subsequent invocation of "ctdb
nodestatus" will work. However, "without daemon" is used here because
the top-level "ctdb natgwlist" does not need to open a connection to
the daemon. It just needs to invoke ctdb_natgw.
Update tests to suit.
It would make sense to make "ctdb natgw" generally call out to
ctdb_natgw, passing all argument. However, that can be done later.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit e515968a51b9a8c1bb8ad59fb010a8736e2c6bd0
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Jan 21 19:35:46 2016 +1100
ctdb-tests: Drop some unnecessary NAT gateway tests
These tests deal only with timeouts that can occur retrieving
capabilities. The NAT gateway capability is going away so drop the
tests now to simplify future commits.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit bae9feacf2c3a1117f7b9001b95398142479e1c7
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Dec 14 21:37:44 2015 +1100
ctdb: Call out to ctdb_natgw helper from 11.natgw
To keep this commit comprehensible, 11.natgw and the CTDB CLI tool are
temporarily inconsistent. The tool will be made consistent in a
subsequent commit.
ctdb_natgw_slave_only() is reimplemented to check for the option in
the appropriate line in $CTDB_NATGW_NODES.
Update unit tests and documentation.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit f1265f0ebec6a41eff38d4c3b3e5211015748c9c
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Jan 22 11:04:22 2016 +1100
ctdb-tests: NAT gateway slave-only changes
Handle the "slave-only" option in the unit test setup. Reindent
function while touching it.
Also drop a test that no longer makes sense. Specifying both "master"
and "slave-only' is now much more obvious, since they need to be on
the same line, and is now punishable by undefined behaviour.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 7095c9bcd061cdc8ac4728c137a974b815773e3d
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Jan 5 13:09:05 2016 +1100
ctdb-scripts: New function ctdb_natgw_slave_only()
This allows future changes to be more self-contained.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 3a2eebfe19e9c90271d68b17f588192c4d2f3d91
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Dec 14 21:08:03 2015 +1100
ctdb-tests: Test ctdb CLI tool via a stub
Some features, such NAT gateway and LVS support, can be implemented
without daemon and (internal) ctdb CLI tool support. These are
non-core features that don't need incredible performance and they
don't need to be in the core code. They can easily be reimplemented
in scripts, along with some configuration changes.
For continuity, the ctdb CLI tool code will call out to helper scripts
so that the current status information can still be provided. Those
helper scripts may then reinvoke the ctdb CLI tool to gather
information.
So, redo the tool testing using a "ctdb" stub command. This will
swallow standard input and feed it to the test program each time the
"ctdb" stub is called.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 1538fc458568c9d5b29125256957f8d6de580d4c
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Dec 14 11:34:41 2015 +1100
ctdb-tools: Add standalone ctdb_natgw tool script
This is intended to replace the use of "ctdb natgwlist" in 11.natgw
and provide different views of the NAT gateway status.
It replaces the use of CTDB_NATGW_SLAVE_ONLY=yes with a "slave-only"
keyword in the NAT gateway nodes file. This means the nodes file must
be consistent on all nodes in a NAT gateway group.
Note that this script is not yet integrated, so there are no behaviour
or documentation changes.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit d71f747f5c1c7e937fa76e77167cc87fddd37403
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Dec 18 16:23:04 2015 +1100
ctdb-scripts: Tests for monitoring of CTDB_NATGW_PUBLIC_IFACE
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 638117c01a7883f9a15735fd6cb573a5d8f1aa12
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Dec 18 16:22:14 2015 +1100
ctdb-scripts: Move monitoring of CTDB_NATGW_PUBLIC_IFACE to 11.natgw
The NAT gateway code should be self-contained.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit df5845c641b7b883ecc73147ff913f90af3743f5
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Jan 20 19:14:15 2016 +1100
ctdb-scripts: CTDB_PARTIALLY_ONLINE_INTERFACES incompatible with NAT gateway
This has always been the case. Now it is documented and enforced.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 06901f4aeb877a261d45e44fc58dcb2b830dd2cb
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Jan 15 21:22:16 2016 +1100
ctdb-scripts: Rename variable: fail -> down_interfaces_found
Now its name describes its usage and the code reads better.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit d0f2143fe86da5f3de15b374a26bdfba5935f838
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Jan 15 21:20:26 2016 +1100
ctdb-scripts: Drop functions mark_up() and mark_down()
Each is now used in only one place and the logic is more obvious
without them.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 85316c04154466b18f266de90362eb08cbec64ee
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Dec 18 15:43:33 2015 +1100
ctdb-scripts: Move interface monitoring code to functions file
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit fe64e76aa01eca5c206efa421abc2274240ddcd8
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Dec 18 15:37:31 2015 +1100
ctdb-scripts: Rename get_real_iface() -> interface_get_real()
Now suitably named for move to functions file.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 6f212aacf8d9798c7f923df277e9a40f379fea7a
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Dec 18 15:30:18 2015 +1100
ctdb-scripts: Refactor function interface_monitor() to monitor one interface
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit cd86f20e245cc1b0cb3be5d6cb1b45c45e2a45a8
Author: Ralph Boehme <slow at samba.org>
Date: Wed Jan 20 17:46:38 2016 +0100
s4:torture: add SMB2 test for directory creation initial allocation size
Test that directory creation with an initial allocation size > 0
succeeds.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11684
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Sun Jan 24 01:20:52 CET 2016 on sn-devel-144
commit 78ccbb07170c3e49a084d31434310f973e3d6158
Author: Ralph Boehme <slow at samba.org>
Date: Wed Nov 25 15:23:26 2015 +0100
s3:smbd: Ignore initial allocation size for directory creation
We reject directory creation with an initial allocation size > 0 with
NT_STATUS_ACCESS_DENIED. Windows servers ignore the initial allocation
size on directories.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11684
Pair-Programmed-With: Volker Lendecke <vl at samba.org>
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a1a8746174dff0b80ef4620894001a610b78f208
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 21 18:59:34 2016 +0100
s3:smb2_sesssetup: implement SMB3 session bind (disabled)
This is disabled for now. It will be possible to enabled it
via a config switch once the underpinnings are complete.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Pair-Programmed-With: Guenther Deschner <gd at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Sat Jan 23 03:22:18 CET 2016 on sn-devel-144
commit edd781d5a886aab4a5002280321006cfbc2c7bc9
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jul 29 17:05:52 2015 +0200
s3:smb2_sesssetup: treat BINDING in smbd_smb2_session_setup_auth_return
This adds smbd_smb2_bind_auth_return(), a
variant of auth_return for session binding.
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 91770e3fa76d23b522929c09aa5b587a8d9ffd4f
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 21 00:16:33 2016 +0100
s3:smb2_negprot: announce multi channel support (disabled)
This disabled for now. Will be enabled by config setting
once underpinnings are ready.
Pair-Programmed-With: Guenther Deschner <gd at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d60ffcfe440c17f30be9e97d7049650d988c9395
Author: Michael Adam <obnox at samba.org>
Date: Fri Jan 22 12:51:15 2016 +0100
smbXsrv: introduce bool smbXsrv_client->server_multi_channel_enabled
defaulting to false.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3e084695daff377da6f6e4a6fcb10c05f2a6dd03
Author: Uri Simchoni <uri at samba.org>
Date: Thu Jan 21 11:14:36 2016 +0200
build: fix ldbsearch panic on FC22
add dependency that fixes ldbsearch panic due to conflict -
function read_data() is implemented both by libtspi.so.1, which
is a dependency of gnutls on FC22, and by an internal samba
shared lib.
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Sat Jan 23 00:06:59 CET 2016 on sn-devel-144
commit 8ec92e50736053a5f4104888e3ad54cdb3e3f54b
Author: Andreas Schneider <asn at cryptomilk.org>
Date: Tue Jan 12 15:16:43 2016 +0100
smbspool: Add string representation of nt_status
Signed-off-by: Andreas Schneider <asn at cryptomilk.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Jan 22 20:59:36 CET 2016 on sn-devel-144
commit c3aaf6492f40319db84124617002362fd6d0f890
Author: Andreas Schneider <asn at cryptomilk.org>
Date: Fri Jan 22 13:27:27 2016 +0100
waf: Only build the backupkey rpc test with AD DC enabled
Signed-off-by: Andreas Schneider <asn at cryptomilk.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit f69b6dd9053fe763235d0453a00c9363491bce32
Author: Andreas Schneider <asn at samba.org>
Date: Thu Jan 14 10:32:57 2016 +0100
tests: Only execute heimdal tests if we build with heimdal
This is a preparation for MIT Kerberos support in the AD server.
Pair-Programmed-With: Alexander Bokovoy <ab at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Signed-off-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Jan 22 14:13:42 CET 2016 on sn-devel-144
commit 30419f296602ca37eeb3cd9ca8e97c14527c0c3c
Author: Andreas Schneider <asn at samba.org>
Date: Thu Jan 14 10:32:11 2016 +0100
tests: Rename heimdal blackbox tests
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit b74bef8f7d3452f9a5aee4c934c9ff62afc2b2bd
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 30 17:03:26 2015 +0100
smbstatus: add support for SMB1 signing and CIFS UNIX extensions encryption
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Fri Jan 22 11:06:05 CET 2016 on sn-devel-144
commit f95549957ec73a67bee0093a17e84808adfe97de
Author: Ralph Boehme <slow at samba.org>
Date: Thu Dec 3 12:17:50 2015 +0100
libcli/smb: add define SMB_ENCRYPTION_GSSAPI for CIFS encryption type
Add a define for the CIFS UNIX extensions encryption type. We store this
in smbXsrv_channel and use it in smbstatus for showing the
CIFS/SMB2/SMB3 encryption cipher used.
The SMB3 encryption cipher constants start at 1, carefully choosing the
highest available bit for the CIFS UNIX extensions encryption cipher
should avoid collisions and leaves room for many SMB3 ciphers in the
future.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1e60a3f009649df4b22ce09828a9f3c82848cee0
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 30 11:20:43 2015 +0100
smbstatus: show signing state of sessions and tcons
Show the signing state of sesssions tcons in smbstatus. This is SMB2/3
only. SMB1 support will be added in a later commit.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8d8af479e22f3a8b394c72d36a49715cd5de6ca0
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 30 11:14:34 2015 +0100
s3:lib/conn_tdb: store the connection dialect
This will be used in a subsequent commit that will print the signing
cipher in smbstatus. We need the connection dialect for that.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9d284431fc478bc6e19ac2d98b3c330800521ad3
Author: Ralph Boehme <slow at samba.org>
Date: Sun Nov 15 11:12:34 2015 +0100
s3:smb2_server: add signing state tracking flags
Add flags that track the signing state of all incoming and outgoing SMB2
packets and a helper function that can be used to determine whether a
session of tcon can be considered "signed".
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fe5353c82ee41ef620aa8340acd4748dd3bc795f
Author: Ralph Boehme <slow at samba.org>
Date: Sun Nov 15 10:49:38 2015 +0100
s3:smb2_server: convert signing_required bool to flags bitmap
Use a flags bitmap for storing the signing state. This is in preparation
of a subsequent patch that adds more flags to the bitmap.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 780743d1b28d92352fa91322f9a14dc86055ea08
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 9 17:26:51 2015 +0100
smbstatus: show encrpytion state of tree connects
Show the encrpytion state of tcons in smbstatus. This is SMB3 only. CIFS
UNIX extensions encryption will be added in a later commit.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 83a557dfad713c0ab30c071ae4cdab0713337928
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 9 18:01:47 2015 +0100
smbstatus: align tree connect header and output
Align output and use timestring() instead of time_to_asc(). The latter calls
asctime() which forces a \n into the time string.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e0fc93112f4eaaba7eae8c7bf1a2276e46ce3673
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 9 17:17:17 2015 +0100
smbstatus: show encrpytion state of sessions
Show the encrpytion state of sessions in smbstatus. This is SMB3
only. CIFS UNIX extensions encryption will be added in a later commit.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5d750787eb3da0e25d54554a8542a116bf244334
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 9 17:02:38 2015 +0100
smbstatus: align session list header and ouput
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 603f1de9cf9bc18998c735529abfe9ad79153af3
Author: Ralph Boehme <slow at samba.org>
Date: Thu Nov 19 15:54:17 2015 +0100
smbstatus: pass talloc context to traverse_connections
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c2443d608ad3c698951af80819a7428634cf5365
Author: Ralph Boehme <slow at samba.org>
Date: Thu Nov 19 10:40:29 2015 +0100
smbstatus: pass talloc context to traverse_sessionid
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f59ef038eda8f52ade832e8c5790629e47059984
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 30 10:48:12 2015 +0100
smbstatus: rework connection dialect printing
In a later change I want to print the signing cipher which depends upon
the connection dialect. So let's store the connection dialect in the
sessionid struct and move the code that maps dialect integers to strings
to smbstatus.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e501c733ecdba2bae2da3f5b9a27b69be89ac228
Author: Ralph Boehme <slow at samba.org>
Date: Fri Nov 13 10:30:50 2015 +0100
s3:smb2_server: add encryption state tracking flags
Add two encryption state tracking flags that can be used to tell whether
a session or tcon is "encrypted" and add a helper function to calculate
the encryption state from those flags.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 736cd36d36ea4985c7bcff19c683bc140566da4c
Author: Ralph Boehme <slow at samba.org>
Date: Fri Nov 13 10:35:58 2015 +0100
s3:smb2_server: store encryption cipher in the channel
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bfdffea0fa8e6af57c2b3e51472bab46d46fbaca
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 9 17:23:29 2015 +0100
s3:smb2_server: convert encryption desired and required bools to flags
This adds a bitmap smbXsrv_encrpytion_flags with flags to the
smbXsrv_session_global.tdb and smbXsrv_tcon_global.tdb that we use
instead of bools for desired and required.
We need this info in the smbXsrv tdbs for smbstatus. Subsequent commits
for smbstatus will use it.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 63a13f40cfe31c58c57373ae384b3c067a4d5498
Author: Ralph Boehme <slow at samba.org>
Date: Fri Nov 13 17:00:29 2015 +0100
smbstatus: remove obsolete verbose message
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ef269c9ddc865a450f4e594ec9133e1f304452a7
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 21 12:42:14 2016 +0100
substitute: Fix talloc_sub_basic for %G in the case of a local user.
This fixes a regression introduced by the fix for bug 10286.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10286
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Jan 22 05:03:25 CET 2016 on sn-devel-144
commit 2f2b57a648624dee346dbc9481a36d38c5d21ec3
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 21 12:41:43 2016 +0100
passdb: change ABI version to 0.25.0 due to removed symbol.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8ff3257c4c129a941f50e78ede4905bae3712f33
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 21 12:40:33 2016 +0100
s3:passdb: move my_sam_name() from passdb to util_name.c
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a929913cb1dd3fd94676c0b417a663c064961be9
Author: Michael Adam <obnox at samba.org>
Date: Fri Jan 15 17:34:43 2016 +0100
s4-torture: let smb2.replay.replay5 test deal with scale out shares.
Scale out shares don't hand out batch or exclusive oplocks.
Hence no durable handles either.
The important point here is that the behaviour tested
does largely not rely on the fact that we had a durable
handle but that we were using a durable handle create
context to specify a CreateGUID.
Pair-Programmed-With: Guenther Deschner <gd at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c9218c40e6037e4f38a719aa0b47c3040cdf2080
Author: Michael Adam <obnox at samba.org>
Date: Tue May 19 12:19:22 2015 +0200
smbd:smb2_close: remove an irritating blank line
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 718007b2236084113163e4c40b33a95d7d247ec3
Author: Michael Adam <obnox at samba.org>
Date: Thu Jan 21 10:39:35 2016 +0100
docs:smbdotconf: fix tabs/space mixup in logon parameter metadata
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6ed39851827f86a6a062942bf6fd82d045f0a1d4
Author: Uri Simchoni <uri at samba.org>
Date: Tue Nov 3 10:42:00 2015 +0200
vfs_shadow_copy2: check crossmountpoints against snapdirseverywhere
If crossmountpoints is enabled, verify that snapdirseverywhere is
enabled too, since crossmountpoints has no meaning otherwise.
This obviates the check of crossmountpoints against other config
variables.
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Jan 22 01:54:06 CET 2016 on sn-devel-144
commit 6cff00954763a7b266db5bab229b989e89abcee0
Author: Uri Simchoni <uri at samba.org>
Date: Wed Jan 20 09:34:26 2016 +0200
smbcacls: fix uninitialized variable
An uninitialized variable causes "numeric" mode to be
used without the -n option.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11682
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Wed Jan 20 12:12:12 CET 2016 on sn-devel-144
commit d90517912712f2e8021733ecaabed903cb2d0aed
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Nov 6 17:08:18 2015 +1100
ctdb-client: Use ctdb_rec_buffer_init() to initialize ctdb_rec_buffer
... instead of talloc_zero(). This sets the db_id correctly.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Wed Jan 20 07:28:42 CET 2016 on sn-devel-144
commit a7d54bb2c15e280143455289236884be1a402dda
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Nov 6 15:20:15 2015 +1100
ctdb-client: Add missing initialization for h->ev in transaction_start
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 5d5d88e0bb082cc82fab355b687b7cb34a8bd059
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Nov 5 17:09:11 2015 +1100
ctdb-client: Do not delete reqid explicitly
The reqid will be deleted when the client control state is freed.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 8ca76adaeaa284601424e2d3ec4cc4bd044ed0de
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 14 15:36:55 2015 +1100
ctdb-client: Add a disconnect callback for ctdb client
This allows the client code to optionally clean up and/or re-connect to
CTDB daemon when it the daemon goes away. If no disconnect callback is
registered and CTDB daemon goes away, then the client will terminate.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 555237f2a8bd42f7223397f73e62a2a3786484c5
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 14 15:30:14 2015 +1100
ctdb-client: Close ctdb socket connection when client context goes away
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e59712b2c311c4d5fff82bc62f86a83ea4e86cbd
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Nov 10 18:32:05 2015 +1100
ctdb-client: Use ctdb_ltdb_header_extract()
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 0ed60d757d3cb134eb74e559bc3288b44cf74a6f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Nov 26 13:50:14 2015 +1100
ctdb-protocol: Fix marshaling of seqnum
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 006d4c1dc3a3446f8a1ae6593487a13e712396ed
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Jan 14 12:16:51 2016 +0100
docs: Bump version up to 4.4.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Tue Jan 19 21:34:14 CET 2016 on sn-devel-144
commit d51a63554f5cf385af5b6e4d7aa1fc64dde3641f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Jan 15 12:24:04 2016 +1100
ctdb-build: Fix -O3 developer build
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Jan 18 14:32:05 CET 2016 on sn-devel-144
commit 594778e580474d48b954866da06cc2d505f1d1ef
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Mon Dec 7 10:07:26 2015 +1300
ldb-samba: Expand testing of recursive search
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Jan 18 07:49:43 CET 2016 on sn-devel-144
commit 10e32377a41d66566d8860cd5f02243feff61ce0
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Tue Jan 12 13:11:03 2016 +1300
ldb-samba: Correct error reporting to match Windows
In some cases instead of replying with an error Windows instead returns
0 results.
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 1d05f3bae722fe82db8160b76ec6e49771d687cc
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Thu Jan 7 10:28:12 2016 +1300
ldb-samba: Reenable recursive search
In order for the recursive search module to work, we first
must stop asserting that any extended match rule is a DN (to be modified
per the extended DN munging), as this is not the case for this particular rule.
This reverts commit 8cacd5b8113fa30fb4ccaaf3193839660feb285f.
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit a52bcaaf2062e5e48695032e25b68aeff33ea301
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Fri Jan 8 15:15:07 2016 +1300
ldb-samba: critical bugfix on original recursive search implementation
In the original patch (listed previously), when the search recurses it
will inevitably reallocate the visited list to a new array in memory.
When this happens the original patch didn't update it's reference to the
array.
This patch adds an extra level of indirection on the visited list in
order to fix this bug.
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 177ac584c9bc444b951596f0ca740c04182c9db8
Author: Samuel Cabrero <samuelcabrero at kernevil.me>
Date: Fri Oct 24 17:52:47 2014 +0200
ldb-samba: Implement transitive extended matching
Documented in [MS-ADTS] section 3.1.1.3.4.4.3 LDAP_MATCHING_RULE_TRANSITIVE_EVAL
This allows a search filter such as:
member:1.2.840.113556.1.4.1941:=cn=user,cn=users,dc=samba,dc=example,dc=com
This searches not only the member attribute, but also any member
attributes that point at an object with this member in them. All the
various DN syntax types are supported, not just plain DNs.
Signed-off-by: Samuel Cabrero <samuelcabrero at kernevil.me>
(abartlet: Fixed compile error: return makes integer from pointer without a cast)
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
(returned to Samba by revert of
dc2d5ccd56ff8c59f3686a652ec3082069914bb4, returning the original
commit 2a22ba34cd6f28950246b54c6577c922c61f4fdb)
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit a2d49fa74f2a4b3cf8b22f4b5686d18f3204fcfb
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 18 15:53:15 2016 +1300
pidl: Change PyGetSetDef in generated python bindings to use C99 initialisers
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit cff17f0a8ccf697d2836fe5b32b621995a9fc432
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jan 15 16:22:26 2016 -0800
s3: smbd: Remove one more use of lp_posix_pathnames().
Slowly removing them...
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Sun Jan 17 02:07:23 CET 2016 on sn-devel-144
commit ecc7022d7c3cd481b0caf6c9c48c72ea3e7ac822
Author: Günther Deschner <gd at samba.org>
Date: Fri Jan 15 14:43:48 2016 +0100
s3-util: skip S-1-18 sids in token generaion in sid_array_from_info3().
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11677
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Jan 16 01:24:04 CET 2016 on sn-devel-144
commit a92420911d4786e6fe58091f9641e2b193513f0c
Author: Günther Deschner <gd at samba.org>
Date: Fri Jan 15 14:43:12 2016 +0100
s3-util: add helper functions to deal with the S-1-18 domain.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11677
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit cf163ac359ee8414dd34723bdce79c33e225d3c9
Author: Günther Deschner <gd at samba.org>
Date: Fri Jan 15 14:46:07 2016 +0100
security: Add Asserted Identity sids (S-1-18)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11677
definitions taken from [MS-DTYP]: Windows Data Types,
2.4.2.4 Well-Known SID Structures.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d1235c79ec8dbd4a79d0d14442098fc427f79ac3
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 14 21:10:39 2016 +0100
ldb: Fix CID 1348110 Uninitialized scalar variable
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Jan 15 07:12:06 CET 2016 on sn-devel-144
commit cf05ba5b3210e9258dd4a1126bd29a1e696ec957
Author: Justin Maggard <jmaggard10 at gmail.com>
Date: Wed Jan 13 16:25:34 2016 -0800
s3-libads: Use the configured LDAP page size.
We already allow the user to configure LDAP page size, and use it in pdb_ldap.
But then we hard-code the initial LDAP page size value to 1000 in ads_init, so
it doesn't take effect there. So let's use the configured LDAP page size value
in ads_init also, which defaults to 1000.
Signed-off-by: Justin Maggard <jmaggard at netgear.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Jan 15 03:59:16 CET 2016 on sn-devel-144
commit 8c2609f3186d40afb5954737dc174ce190cd368a
Author: Justin Maggard <jmaggard10 at gmail.com>
Date: Wed Jan 13 16:25:33 2016 -0800
Change default LDAP page size to 1000.
This matches Windows' Active Directory maximum page size.
Signed-off-by: Justin Maggard <jmaggard at netgear.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 19fffeb75a5b9e352f67cfdfbd45d0ac8ad5e4a3
Author: Michael Adam <obnox at samba.org>
Date: Tue Jan 12 18:59:15 2016 +0100
ctdb-scripts: further untangle logic for success of interface monitoring
Reduces intentation by using early returns.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Thu Jan 14 22:41:29 CET 2016 on sn-devel-144
commit 93e48df86cb007ebd6ed14a425b9220dbb4d0ba6
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 14 11:20:21 2016 +0100
ctdb: Fix the O3 developer build
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 0f57acc531792684b57c2e4906551e776dc8ceac
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date: Wed Jan 13 12:53:26 2016 -0800
s4:acl LDB module - fix error message
Signed-off-by: Matthias Dieter Wallnöfer <mdw at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Jan 14 04:54:26 CET 2016 on sn-devel-144
commit 39bc356ccb3fdfb9bd69c33ccf0fb1cb76f3c090
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Dec 11 16:07:51 2015 +1100
ctdb-ipalloc: Document the steps involved in a takeover run
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Wed Jan 13 23:27:01 CET 2016 on sn-devel-144
commit e320725f0206c56f5fe8b8b580d677c2aa56ca47
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Nov 23 16:18:16 2015 +1100
ctdb-ipalloc: Split IP allocation into its own build subsystem
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 19d3fd190e039a9cd84bb93c2c2ea1b21f77583e
Author: Andreas Schneider <asn at cryptomilk.org>
Date: Wed Jan 13 12:36:54 2016 +0100
s4-rpc_server: Add missing include for ROLE_ACTIVE_DIRECTORY_DC
Signed-off-by: Andreas Schneider <asn at cryptomilk.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Wed Jan 13 20:17:20 CET 2016 on sn-devel-144
commit 7362c27a62e3802fc8df975ce50115b683811f4a
Author: Uri Simchoni <uri at samba.org>
Date: Thu Oct 29 22:24:30 2015 +0200
vfs_shadow_copy2: add a blackbox test suite
Add a blackbox test suite for vfs_shadow_copy2, testing
parameters mountpoint, basedir, snapdir, snapdirseverywhere,
and testing correct wide-link processing.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11580
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Jan 13 17:11:38 CET 2016 on sn-devel-144
commit 8a49a63a5a5d8014d32179df1789186223443b35
Author: Uri Simchoni <uri at samba.org>
Date: Mon Nov 2 09:08:53 2015 +0200
vfs_shadow_copy2: fix case where snapshots are outside the share
Adjust the connect path to the root of the share in the snapshot,
or to the root of the snapshot if the snapshot is "inside" the
share.
This way snapshot symlink regarded as "wide links" if and only if
they point outside the snapshot or they were wide links when
the snapshot was taken.
This allows mounting the snapshots outside the share's root.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11580
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3703bca4d9e494aec0b40243add3e076cf353601
Author: Uri Simchoni <uri at samba.org>
Date: Sun Nov 1 22:28:46 2015 +0200
vfs_shadow_copy2: add shadow_copy2_do_convert()
Add a new routine shadow_copy2_do_convert() which is
like shadow_copy2_convert(), but beside calculating the
path of the snapshot file, it also returns the minimum length
of the subpath which is both inside the share and inside the
same snapshot as the file in question, i.e. (at least in the
classical case) the subdirectory of the the snapshot file's
snapshot directory that corresponds to the file's share root.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11580
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit fba90fd8fe5e3082a67db52b351c2d3ed2d05268
Author: Michael Adam <obnox at samba.org>
Date: Wed Sep 9 15:08:56 2015 +0200
s3:smbd_smb2_reauth_generic_return: make use of smb2req->xconn
More specifically move from smb2req->sconn to smb2req->xconn->client->sconn
to avouid using smb2req->sconn directly.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Jan 13 14:02:21 CET 2016 on sn-devel-144
commit 490a27b69bc2a1ca4c22dcc2e239a0acedfee637
Author: Michael Adam <obnox at samba.org>
Date: Tue Sep 8 18:25:02 2015 +0200
pam_winbind: check != PAM_SUCCESS and != NULL explicitly
...instead of using "if (ret)" or similar.
This is just a code cleanup, no changes in behaviour.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit e8e9e7f2fe33d1e158202df4eb91d3738c9eb266
Author: Michael Adam <obnox at samba.org>
Date: Wed Jan 13 01:37:24 2016 +0100
vfs:shadow_copy2: fix a debug message
The debug message for the mountpoint option was the
wrong way around. This fixes it, also converting
the message to use DBG_WARNING() while we're touching it.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Wed Jan 13 10:56:42 CET 2016 on sn-devel-144
commit 25243affa961e5c1650ec0ba9059fb6b51eb95c4
Author: Michael Adam <obnox at samba.org>
Date: Wed Jan 13 01:46:25 2016 +0100
docs: fix copy'n'paste error in vfs_shadow_copy2 manpage
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit f7583be4429b9353d84ab6bdaba9edad42d46b96
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 11 21:41:22 2016 +0100
asn1: Make asn1_peek_tag_needed_size static
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit 2aa1cf48fc9913e512b340f933d3747327326843
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 11 21:38:20 2016 +0100
asn1: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit 5e1a84c43ed0c69ca97499370d97c182e5d903e1
Author: Volker Lendecke <vl at samba.org>
Date: Mon Dec 28 17:01:47 2015 +0100
winbind: Properly error check init_lsa_ref_domain_list
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit 5a2c30564337bfc8ba991c45ce8db6eee1831ace
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 27 19:55:40 2015 +0100
idmap: Fix whitespace
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit 9039f1f29eb971894d6c0276f99a39a140fe2013
Author: Volker Lendecke <vl at samba.org>
Date: Thu Dec 17 15:42:33 2015 +0100
libcli: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit 812e07418eae036f079bec7835516a86ae89f86e
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 15 21:52:38 2015 +0100
libsmb: Remove ip_service based resolve_lmhosts
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit c29188f501936f986470821064032d6681622ca5
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 15 21:43:50 2015 +0100
libsmb: Convert resolve_hosts to sockaddr_storage
Eventually I want to get rid of struct ip_service.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit da8674c72ab1f2dc8458434d714c61530630f51e
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Jan 4 01:01:53 2016 +0000
Rename 'errors' to 'samba-errors' and make it public.
This is necessary because it has public headers.
Signed-off-by: Jelmer Vernooij <jelmer at jelmer.uk>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Jelmer Vernooij <jelmer at samba.org>
Autobuild-Date(master): Wed Jan 13 07:47:04 CET 2016 on sn-devel-144
commit 218f96f2bf10f7f03ec964c4515f6e248fc31ad8
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Jan 4 00:56:10 2016 +0000
libcli: Make headers for private libraries private.
Signed-off-by: Jelmer Vernooij <jelmer at jelmer.uk>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit ffbd9c4584d83c56e58901bc91effa75ebdcbb02
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Dec 28 22:21:11 2015 +0000
Add a new header file for functions in lib/util/util.c.
This allows public headers to not include samba_util.h, but rather
specific header files under lib/util.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit 512d15de56ed3f5a0abf9a7b98934ed42f211306
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Dec 28 22:19:21 2015 +0000
Make libcli-smb-raw private, for now.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit 773cfba9af34e64b96e843b1b60afa5a0b0dec32
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Dec 28 19:01:54 2015 +0000
Avoid including libds/common/roles.h in public loadparm.h header.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit ce32f26647391df0e088b8850f5afc1120190a72
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Dec 28 18:57:26 2015 +0000
ldb: Only set public headers field when installing as a public library.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit 1860e98d31fc85f02e57cb9d035d664321f90db3
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Jan 4 01:07:27 2016 +0000
time_basic.h: Remove unnecessary dependency on replace.h
Forward declare struct timeval
Signed-off-by: Jelmer Vernooij <jelmer at jelmer.uk>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit 620d5cbe1705fa5787b865ea469ac0688ab0cfeb
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Thu Jan 28 15:21:21 2016 +0000
Remove public library dcerpc-atsvc.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit 232726a4b414ff1a51e454545bca58052400316b
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Thu Jan 28 15:21:21 2016 +0000
Make libregistry private, for now.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit 2f7dde3af769fb367679f42494d30c298adacfec
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Thu Jan 28 15:21:21 2016 +0000
Make libtorture private, for now.
Signed-Off-By: Jelmer Vernooij <jelmer at jelmer.uk>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit c46a8cf258bec3ae0300493ad7ca61b356945dac
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Thu Jan 28 15:21:21 2016 +0000
Make gensec private, for now.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit 5d67d555f0ecdbc92e83dbccc4b6f0539cb1395f
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Jan 4 15:21:21 2016 +0000
talloc: Only set public headers field when installing as a public library.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
commit 3eb90650a8aba68305e5c0b32c83be268c122b0e
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Dec 28 00:04:02 2015 +0000
Error when private libraries have public headers.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit 68a3576629d48eea851a4c048208a4ee4b6e2aa7
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Jan 4 15:21:02 2016 +0000
tdb: Only set public headers field when installing as a public library.
Signed-Off-By: Jelmer Vernooij <Jelmer at samba.org>
commit 48ebeaa4aa5bab0bf1692d18a57f84ea97ca436b
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Sun Dec 27 22:07:59 2015 +0000
Add private_headers flag to SAMBA_*() functions.
While this argument is correctly ignored, it does mean that we can
associate private headers with specific subsystems/libraries.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
Reviewed-By: Andrew Bartlett <abartlet at samba.org>
Reviewed-By: Stefan Metzmacher <metze at samba.org>
commit 2cba4918dbe82fb9d0455c73d35aa551dccc924f
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Mon Jan 4 23:01:26 2016 +0000
tevent: Only set public headers field when installing as a public library.
Signed-off-by: Jelmer Vernooij <jelmer at jelmer.uk>
commit fddca39f1949bdfab89077de20d09a426ee34043
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Tue Jan 5 23:11:08 2016 +0000
samdb: Add explicit dependency on ldb.
This is needed to pull in the right -I flags.
Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
commit 3123e2c66a29aaabad7408107bcf4a0e841a93ec
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Sat Jan 9 20:25:17 2016 +0000
Simplify handling of dependencies on external libraries in test_headers.
Signed-off-by: Jelmer Vernooij <jelmer at jelmer.uk>
commit 4ab7a00ac4f74df42baf9c6b5367421bf7794aed
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Sat Jan 9 21:55:53 2016 +0000
Use full path to dlinklist.h in includes.
Signed-off-by: Jelmer Vernooij <jelmer at jelmer.uk>
commit 6f3656c47d8ae6a3ac10591ffd7a60797775b469
Author: Christof Schmitt <cs at samba.org>
Date: Thu Jan 7 13:27:49 2016 -0700
Revert "winbind: Retry after SESSION_EXPIRED error in ping-dc"
This reverts commit a2670f15dea27c10e3827216adf572f9c3894f85.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670
cm_connect_netlogon now handles the retry for an expired session.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Jan 13 03:35:57 CET 2016 on sn-devel-144
commit aa3883eae6e7891efb1e6f9ec74e6073bee43250
Author: Christof Schmitt <cs at samba.org>
Date: Tue Jan 5 15:10:45 2016 -0700
winbindd: Retry on expired session in cm_connect_netlogon
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 276d604aa5ccc32d18b69c04ae13e2dc7c21f3ee
Author: Christof Schmitt <cs at samba.org>
Date: Thu Jan 7 15:03:22 2016 -0700
winbindd: Retry on expired session in cm_connect_sam
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3b6b5456424be6997b32c23b7c149c8060c3102d
Author: Christof Schmitt <cs at samba.org>
Date: Wed Jan 6 14:15:30 2016 -0700
winbindd: Retry on expired session in cm_connect_lsa
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4c6804e414087fb61e66133cefbe5590d1d9b283
Author: Christof Schmitt <cs at samba.org>
Date: Tue Jan 5 14:42:09 2016 -0700
winbindd: Remove double retry from some ADS methods
The retry through the new reconnect_ads layer is enough. This structure
also makes the distinction between retry layer and actual methods call a
bit clearer.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e4adf55e242aa5f000570bf554fcd15d7e86c126
Author: Christof Schmitt <cs at samba.org>
Date: Tue Jan 5 14:37:30 2016 -0700
winbindd: Add retry also for ADS method calls
RPC calls can return IO_DEVICE_ERROR on expired SMB2 sessions. Retrying
on a new connection avoids surfacing this error to winbindd clients.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fb5b0cec3c0c2e0cf9cb04f8b52ee910ac245aeb
Author: Christof Schmitt <cs at samba.org>
Date: Tue Jan 5 13:39:25 2016 -0700
winbindd: Reset connection for expired session before reconnecting
A RPC call on a expired SMB2 session returns IO_DEVICE_ERROR. In this
case, reset the connection before issuing the same call
again.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11670
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3ac2d4b59eff58f06af1eef19cef0d444f4257ca
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Dec 1 15:32:07 2015 +1100
ctdb-tests: Fix some incorrect memory allocations
These allocate enough memory but things get confusing if they're used
as a guide when updating the code.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Jan 12 22:19:16 CET 2016 on sn-devel-144
commit a7ce00cc0392cbbc009e2dbe8d58258d6ba0566f
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Dec 10 15:03:46 2015 +1100
ctdb-scripts: Use more unique temporary file names
Consider this sequence of events:
1. Instance of script running update_tickles() hangs
2. Script debugging is launched asynchronously
3. New instance of script is launched, creates temporary file(s)
4. Original hung script makes progress before asynchronous script
debugging kills it, so it removes temporary file(s)
5. New instance of script produces error due to missing files(s)
This is obviously rare.
Use more unique filenames to avoid step (4) removing the file(s)
belonging to other instances of the script.
This requires some extra cleanup to avoid too many temporary files
(which is why unique filenames were not originally usd). It is
sufficient to remove files modified at least 10 minutes ago.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4afe822397a0fe8f3e528077089577c89c9895e5
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Dec 10 14:58:53 2015 +1100
ctdb-scripts: Don't remove temporary files before use
They will be clobbered by the redirect anyway.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 20838833f3fe3053c7f6aed8ac598319a3ecc346
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Dec 18 13:16:27 2015 +1100
ctdb-scripts: Superficial clean-ups to 10.interface
Whitespace and indentation improvements.
Remove comments describing events, since the README covers that much
better.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c23744c61db321a911653d58ed258a3003cf798b
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Dec 16 19:18:49 2015 +1100
ctdb-scripts: Clarify logic for success of interface monitoring
The current code uses so many shell idioms that it is difficult to
follow.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d8e4c5a468286ecc1c38ecd66a3606e84db02373
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Dec 18 15:33:38 2015 +1100
ctdb-scripts: Fix regression in updateip code
Regression introduced in commit
6471541d6d2bc9f2af0ff92b280abbd1d933cf88.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 18b0aeaae0ba42549a9542b8c08923211e2976ad
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Dec 1 14:38:48 2015 +1100
ctdb-ipalloc: Fix a memory leak
Commit cfa0ffe78073f9e3a014bb127fb9a4b7ad95fceb introduced a memory
leak. Never assume...
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 24160ee6a4a0727840d73955b99aef690450f345
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Jan 11 13:41:30 2016 +1100
ctdb-daemon: Don't leak memory if not using recovery lock
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 56ce230de72dbf14ccddb3f7b26b8b7f16986dfc
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Jan 11 17:23:12 2016 +1100
ctdb-recoverd: Fix some uninitialised memory issues
The first element of these structures is a 32-bit PNN. On 64-bit
systems this field can be followed by 32-bits of padding. When the
structures are copied this can cause uninitialised memory to be
copied.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8f73ae03cc50f26e85b78e35bf22e40eb1ff7684
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Dec 17 12:27:58 2015 +1100
ctdb-daemon: Drop the "schedule for deletion" messages to DEBUG level
Thousands of these can be generated each second, rendering INFO level
debugging useless.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9790abd6a402243179003a47026769d2576e9626
Author: Karolin Seeger <kseeger at samba.org>
Date: Mon Jan 11 11:43:49 2016 +0100
ctdb/web: Fix typo.
assinged -> assigned
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Jan 11 21:40:36 CET 2016 on sn-devel-144
commit 7c4d802370ab94cb150d23292cb7bc998a03f8f8
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Jan 11 19:49:14 2016 +1100
talloc: Fix a documentation typo
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Jan 11 18:34:53 CET 2016 on sn-devel-144
commit 7cec3092ffd8fa6f0f14194be7856ab087ac75a9
Author: Michael Adam <obnox at samba.org>
Date: Wed Dec 16 17:47:04 2015 +0100
nss_wrapper: bump version to 1.1.2
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Jan 11 15:30:49 CET 2016 on sn-devel-144
commit da292b606230190e65f7ef17d23f8c7a65135ecb
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 17 08:46:33 2015 +0100
nwrap: Fix segfaults while reloading hosts file
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 19b2dcbeb230adc956d023dfea0d1aad9bb2a1ca
Author: Andreas Schneider <asn at samba.org>
Date: Tue Nov 24 17:32:47 2015 +0100
nwrap: Don't fail if we want to add an existing entry
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 9b7902090d2d594d25d517759dba78ced0f9124b
Author: Andreas Schneider <asn at samba.org>
Date: Mon Nov 23 08:33:02 2015 +0100
nwrap: Fix the build on Solaris
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5f621977fd52b6da94707733bc273636a7ba2fde
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 20 09:38:16 2015 +0100
nwrap: Don't leak memory from gethostbyname*() functions
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b54bbb2b832570070c1310b22792d0c6586cde85
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 20 08:51:49 2015 +0100
nwrap: Fix the build on FreeBSD
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 766e795518127bf0febd3c0da436adb1a376771d
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 20 09:01:01 2015 +0100
nwrap: fix a copy and paste error in the destructor.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 554963d8877d2260ec36ff4bc097499606386d11
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 19 09:02:46 2015 +0100
nwrap: Cleanup shadow getspnam() memory
Signed-off-by: Andreas Schneider <asn at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 159fdb01856d26d118e7862cd30175571c973682
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 19 01:00:16 2015 +0100
nwrap: fix leaking the entlists
Track the list heads in a vector in the newrap_he_global
struct and free the structures upon nwrap_he_unload.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit bf496153bc280ed58ee25de599b08446bebf738e
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 19 00:34:54 2015 +0100
nwrap: catch error to add item to vector in nwrap_he_parse_line()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 736fa61a9546c48d03cbd75897f7e6956ed48c0e
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 19 00:30:17 2015 +0100
nwrap: rename nwrap_he.entdata to nwrap_he.entries
That's what is is the list of entries. In the guise
nwrap_entdata structures but the code reads more
naturally this way.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit e94a7c5a56b60056f0638223150df55b95b0b342
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 19 00:24:14 2015 +0100
nwrap: remove unused member list from struct nwrap_he
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 16b71aecab5233138dd609fffbc9296abe3628c5
Author: Robin Hack <hack.robin at gmail.com>
Date: Mon Nov 16 23:38:51 2015 +0100
nwrap: Small code shift in nwrap_ed_inventarize_add_to_existing()
Allocate memory only when necessary.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit db0ef5cc9e1a7aedb62ade34cd25e71f745dacc7
Author: Andreas Schneider <asn at samba.org>
Date: Mon Nov 16 10:19:27 2015 +0100
nwrap: Cast max_hostents to avoid warnings
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8fad97bc3428879f4c4b16b56c3d8c5f55c9f33b
Author: Andreas Schneider <asn at samba.org>
Date: Mon Nov 16 10:17:39 2015 +0100
nwrap: Fix initialization of e entry
This fixes a compiler warning.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f1acb0e29657fcc97ab2d45b11c579392388f5d0
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 10:20:37 2015 +0100
nwrap: remove ai_tail argument from nwrap_files_getaddrinfo()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit d198cdaefde851db80ff9e179bbecb5185c0ff82
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 11:35:07 2015 +0100
nwrap: rewrite the loop for duplication ai entries if socktype not given
This loop reads much more naturally now. It inserts the
duplicated entry right after the entrie that is being
duplicated. It does not need a ai_tail any more.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ab2f41bed6e239ce09ed593995b473e8e0800599
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 11:17:21 2015 +0100
nwrap: add an explaining comment for the ai duplicating loop
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 062c97be191ef6b912af46e209941e858b0be3fd
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 11:15:03 2015 +0100
nwrap: move setting of ai_{flags|socktype|protocol} into nwrap_convert_he_ai
This makes the code in nwrap_getaddrinfo() more readable
and also treats all ai stuctures in the linked list, not
just the first one!
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit a66606cd0215b973d768b61444858db38c501f69
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 11:08:47 2015 +0100
nwrap: use symbols IPPROTO_TCP and IPPROTO_UDP
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit bf65160ed2c9f07527151823d7ac38b187060643
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 09:47:59 2015 +0100
nwrap: rename _ai -> ai_new in nwrap_files_getaddrinfo()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit a42f6589c795673cb89cdf9909d2f48de5048c75
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 09:46:29 2015 +0100
nwrap: fix a memleak in nwrap_files_getaddrinfo()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 07b6925242bc7fb33a8b4d63dec74a82c73a1cae
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 09:45:50 2015 +0100
nwrap: rename ai_prev -> ai_cur in nwrap_files_getaddrinfo()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit b996f0a60c05b2bfbf39c2b88cc665c7f7b7909f
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 08:34:39 2015 +0100
nwrap: Fix inventarization of IPs when loading hosts
Use nwrap_ed_inventarize() instead of nwrap_add_ai().
This not only removes code duplication, but also
more correctly adds more than one line for a given
IP address in a list behind this address.
The original code would only have inventarized
the first line for an IP found.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 07f1bef632af79ff75033e08d3d69937523d40c5
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 08:29:57 2015 +0100
nwrap: refactor nwrap_add_hname_* into one nwrap_ed_inventarize.
This reduces code duplication and abstracts the logic out.
It was not special to hname or hname_alias.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 55e9606e68c56e942055b16d5624dbd9cad2f5da
Author: Michael Adam <obnox at samba.org>
Date: Mon Nov 9 00:29:23 2015 +0100
nwrap: treat AI_NUMERICHOST correctly in getaddrinfo.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11477
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 34cff9e72947bbed536be185de814dfccaf40204
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 08:16:18 2015 +0100
nwrap: fix treatment of EAI_ADDRINFO in nwrap_files_getaddrinfo
Checking whether the passed in name (node) is a valid IPv6 or IPv4
address, we can do the checking for these two error conditions
properly up front.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 154080ce8549174a858a6170137d2355f9d31cb0
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 12 08:01:57 2015 +0100
nwrap: correctly track EAI_ADDRINFO in nwrap_files_getaddrinfo
When looping through the entry list and remember the
EAI_ADDRINFO case, so that we can differentiate
the cases
- no entry found at all
- an entry found buy wrong address type
Adapt return codes accordingly.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 0dc34ea56afec67472af29dbb4c361dd27c7841b
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 13:04:15 2015 +0100
nwrap: in nwrap_files_getaddrinfo, treat failure of nwrap_convert_he_ai as error
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 18be46d87c468d6aae297f7d49e3ef6fb9170cfe
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 13:02:59 2015 +0100
nwrap: convert nwrap_files_getaddrinfo() to return EAI error codes
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 6078126eb5d60053811582c2f7bc267bc3bd41c9
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 12:47:15 2015 +0100
nwrap: use the error code from nwrap_files_cache_reload() in callers
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit fe7e1635154aed2eec9b4298fc6b5af1cf2c105e
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 12:33:12 2015 +0100
nwrap: turn nwrap_files_cache_reload() into a bool function
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 4919f1cd210ce75116f7443f9a6a99bf379d2b6a
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 12:30:36 2015 +0100
nwrap: better error propagation in nwrap_he_parse_line()
Use the return codes of nwrap_add_hname() and nwrap_add_ai().
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ccb407630997757c3d73798f7bfab81cf5de6950
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 12:29:55 2015 +0100
nwrap: log NULL alias name at ERROR level in nwrap_add_hname()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit f6e4c58663cea850b25ec2a006e2644a25deb320
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 12:28:58 2015 +0100
nwrap: better error propagation in nwrap_add_hname()
Use return codes from called functions.
Remove now unneeded asserts.
Make failure to add an entry for an alias an error.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ddd0ca82bb3c74de3996a8ddbe85b6d29e14f552
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 12:27:33 2015 +0100
nwrap: better error propagation in nwrap_add_hname_alias
use return codes from the called function.
Remove asserts becaus the cases are caught
by the called functions.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 7ec5aaeb027c7b37ef9d1d522b194b939499647a
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 12:26:02 2015 +0100
nwrap: catch NULL list in nwrap_add_hname_add_to_existing
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 2974cef3d80aaa71d766524f1e89e371182f0b08
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 12:25:30 2015 +0100
nwrap: catch null h_name in nwrap_add_hname_add_new
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit be8c7dc5af31d9da05b276dd65c2fe8dfe85df52
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 12:24:53 2015 +0100
nwrap: catch NULL ip in nwrap_add_ai
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit a725bd7728e079fc9f54c9d06cdd49f43daeb4e7
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 11:56:59 2015 +0100
nwrap: turn nwrap_add_hname_add_to_existing() into bool
for better error propagation.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit d681a084d993c2f1a96a8dfc749108eea1c69822
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 10:38:31 2015 +0100
nwrap: simplify nwrap_file_getaddrinfo: remove a variable
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 28f0a8b5a96bedec35e4f6a5266940769d652568
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 10:36:07 2015 +0100
nwrap: simplify nwrap_files_gethostbyname: remove a variable
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 54c825b1cbc76e5d5df6e8e021e6eaab26b7a8c6
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 11:30:13 2015 +0100
nwrap: log hash table full message at error level
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 95025358d80c3c93476b934467d7ada7d6c060ed
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 10:27:50 2015 +0100
nwrap: rewrite linked-list datastructures to be properly separated.
The data structures were wrong:
- The nwrap_entdata structures reflects one line of the hosts
file, with ip, fqdn and aliases.
But they also had a linked list structure.
- Now the hash table was used to point each
ip address, fqdn and alias name occurring in the hosts
file to the list of lines (entdata structs) that contain
this name/address.
The problem was that these list heads were pointing to the same
entdata structures, while the list should actually be individual
for each entity (ip, fqdn, alias). This lead to wrong assiciations
of lines to IP addresse and also endless loops in the list, when
one line was put into one list twice starting from two different
points.
This patch fixes this by lifting the linked list structure to
a layer nwrap_entlist above nwrap_entdata. The entlist
entries just contain pointers to the entdata, and hence
each line can be referenced independetly by several lists.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 19d54157a479a0fa45720a1f2e64b26d9e1eb31d
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 10:21:30 2015 +0100
nwrap: remove superfluous comments from nwrap_add_hname()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 4ec47e739c024bbd2cb9ebcc310964011333eca4
Author: Michael Adam <obnox at samba.org>
Date: Wed Nov 11 10:21:10 2015 +0100
nwrap: remove superfluous comments from nwrap_add_hname_alias()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 69af963f8e7268842b51e147a6d68a84b271fda4
Author: Michael Adam <obnox at samba.org>
Date: Tue Nov 10 12:32:20 2015 +0100
nwrap: remove a superfluous comment from nwrap_add_hname_add_new()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 3cc12ec5548eb1eaaf9a11e2903a477ae5de7540
Author: Michael Adam <obnox at samba.org>
Date: Mon Nov 9 17:41:43 2015 +0100
nwrap: move var into scope in nwrap_add_hname()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit f7b28bd655d0b819830fa13d0f92bab96bd9037c
Author: Michael Adam <obnox at samba.org>
Date: Mon Nov 9 17:36:37 2015 +0100
nwrap: simplify nwrap_add_hname
This is never given an alias name, so remove
the h_name_a argument.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 8f62cda726c6fd471b4c929c5fb757443fa08842
Author: Michael Adam <obnox at samba.org>
Date: Mon Nov 9 17:36:07 2015 +0100
nwrap: simplify nwrap_add_hname_alias
This always uses the provided h_name_a alias name.
No need to fall back to the fqdn name from the entry.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 067978d785231670d24eabe30d0559cf7873365f
Author: Michael Adam <obnox at samba.org>
Date: Mon Nov 9 17:35:29 2015 +0100
nwrap: initialize some variables in nwrap_files_getaddrinfo
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit be182bab2e05290d525e25c59c406d350d3ed70e
Author: Michael Adam <obnox at samba.org>
Date: Mon Nov 9 00:55:00 2015 +0100
nwrap: slightly clean flow by removing an else branch in nwrap_getaddrinfo
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 559ed74a5aae5254b8b702a039b360a800af6d5c
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 6 11:43:04 2015 +0100
nwrap: in nwrap_getaddrinfo, only call libc_getaddrinfo if we need it.
Instead of calling libc_getaddrinfo on spec and throwing
away the result when we are certain that we don't need it,
call libc only if we really need it.
This fixes another memleak for the libc result.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 9927e499f2a4f0f19ffd609eacc6d799da9861cd
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 6 11:52:08 2015 +0100
nwrap: slightly simplify logic in nwrap_getaddrinfo()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit b0569d40ce7e2e94095315e34d505f6d04e58a9f
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 6 11:48:40 2015 +0100
nwrap: simplify logic in nwrap_getaddrinfo, calling nwrap_files_getaddrinfo
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 53e633e4017cfb3270a4c81d7bb33b437f80ed97
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 6 11:31:09 2015 +0100
nwrap: improve code readability in nwrap_getaddrinfo()
Untangle a (a ? b : c) statement and add an explanatory
comment, since the intention is not immediately obvious.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 8da2110a84922e495dcaa28c794922cf94fb9758
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 6 11:28:35 2015 +0100
nwrap: remove code duplication in nwrap_getaddrinfo
The three formerly distinct cases now are all the same.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 5bea2dc13f56b1cb52a3724c2fb1cc2007926a5b
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 6 11:00:54 2015 +0100
nwrap: fix return code for getaddrinfo in case service is not valid
If the specified service is not a valid service name (or port number),
EAI_NONAME should be returned.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 40f9bf7835d2119bc127520f2f2d355787567f0a
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 6 10:45:15 2015 +0100
nwrap: fix return code of getaddrinfo for AI_NUMERICSERV in error case
If the AI_NUMERICSERV flag is specified, the the port number
has to specified as a string representing a decimal number
or left NULL.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 522631b739821fd53d996d986197af1fb837ef2a
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 6 10:22:10 2015 +0100
nwrap: fix numeric port detection in nwrap_getaddrinfo
Only a string that can be converted to a number, is
allowed as a numeric port specification. Trailing
characters are not allowed.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 72764a6fd31da438cfe4d117dc2cafc1c8907c2d
Author: Robin Hack <hack.robin at gmail.com>
Date: Tue Oct 13 14:41:14 2015 +0200
nwrap: Better check service string sanity.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11501
Patch use strtol() instead of atoi() to convert strings to numbers.
This helps better check sanity of service input string.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 200f5bf138ede63ad446c70ac291e79020262054
Author: Robin Hack <hack.robin at gmail.com>
Date: Mon Oct 12 10:36:04 2015 +0200
nwrap: Fix memory leak in nwrap_gethostbyname_r()
Fix reimplements how memory is used.
Results from vector are copied to user provided buf.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 43d470a06fdc55f8ad2e91d92572c9125da8cf3d
Author: Robin Hack <hack.robin at gmail.com>
Date: Thu Oct 8 15:27:47 2015 +0200
nwrap: Fix memory leak in nwrap_files_gethostbyname()
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 853b2ff08e8bd62a592e31f4627fb0ef09e2ff9d
Author: Robin Hack <hack.robin at gmail.com>
Date: Thu Oct 8 15:00:33 2015 +0200
nwrap: Fix memory leak in nwrap_he_unload()
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3cae3e55e7d575bf859ebbbb2827512012362007
Author: Robin Hack <hack.robin at gmail.com>
Date: Thu Oct 8 14:09:11 2015 +0200
nwrap: Rename cont to vector in nwrap_vector_add_item()
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e1bb0094d49224f3f0aae6de3753a04382b560f7
Author: Robin Hack <hack.robin at gmail.com>
Date: Thu Oct 8 14:02:56 2015 +0200
nwrap: Fix memory leak inside nwrap_getaddrinfo()
Memory leak was introduced by deep copy code.
Item ai_tmp->ai_addr should not have deep copy.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 0f1ffb9b5b76b9b009e895d67241d3b4b61c6c75
Author: Robin Hack <hack.robin at gmail.com>
Date: Thu Oct 8 14:00:38 2015 +0200
nwrap: Use nwrap_vector_foreach instead of for loop
Replace for loop by nwrap_vector_foreach in nwrap_lines_unload().
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9d71542cd96f1fd1d835db690042a34d50ec513a
Author: Robin Hack <hack.robin at gmail.com>
Date: Thu Oct 8 11:36:33 2015 +0200
nwrap: Fix memory leak when getline() is used.
getline() allocates memory even if return code is < 0.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4505dcd64650f395baa4ca737e89c116bd2dada1
Author: Robin Hack <hack.robin at gmail.com>
Date: Tue Mar 24 17:54:34 2015 +0100
nwrap: Add basic locking for support multithreaded applications
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 1017031a295512e50c8aa8fe6d60be06efc0f368
Author: Robin Hack <hack.robin at gmail.com>
Date: Fri Mar 27 15:51:11 2015 +0100
nwrap: Add BSD libc support for gethost*_r functios.
BSD libc stores data in thread local storage.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 960345e617301f2695c9090a6a0feae3fd362c9f
Author: Robin Hack <hack.robin at gmail.com>
Date: Thu Jul 16 16:10:20 2015 +0200
nwrap: Use nwrap vectors as memory backend for getaddrinfo() and gethostbyname()
Previous patches introduced nwrap vectors and hash functions.
This patch will join all together.
Main purpose of this patch is:
- support more records per hostname.
For example: hostname now can have associated IPv4 and IPv6 address.
- better handling of big number of hostname records
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 090dec2fd1b99c7c3d6e145cb826b04b3d07e280
Author: Robin Hack <hack.robin at gmail.com>
Date: Tue Mar 24 15:14:35 2015 +0100
nwrap: Add string manipulation functions.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 270d6f94dbacba10bbcb46372f2eb03c647a5198
Author: Robin Hack <hack.robin at gmail.com>
Date: Wed Jul 15 15:05:28 2015 +0200
nwrap: Add nwrap_add_hname() and nwrap_add_hname_alias().
Functions adds a hostname or an alias to the hash table.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 442fc3fcd27f849a7792f6d8d5cbf36cd8c35f82
Author: Robin Hack <hack.robin at gmail.com>
Date: Wed Jul 15 15:04:32 2015 +0200
nwrap: Add function nwrap_add_ai
This adds an ip to the hash table.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 15c14536d0e4055a7a9c4906b968ead5283e21a8
Author: Robin Hack <hack.robin at gmail.com>
Date: Wed Jul 15 15:01:48 2015 +0200
nwrap: Add a hash table to the nwrap structure
The hash table will hold hostnames and ips internally. The new
environment variable which is introduced is NSS_WRAPPER_MAX_HOSTENTS. It
sets the maximum count of hostent (hostnames and ips) structs which the
hash table can hold.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f3da6e4905320bff56db5dba8fd5a2873d829e1c
Author: Robin Hack <hack.robin at gmail.com>
Date: Mon Mar 23 14:39:28 2015 +0100
nwrap: Simplify file loading.
Lines are stored into vectors now.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ff65d01333ef9e0c9dd53144186381b6b44c64af
Author: Robin Hack <hack.robin at gmail.com>
Date: Mon Mar 23 14:10:18 2015 +0100
nwrap: Add nwrap vector memory management functions
Nwrap vectors are just more inteligent arrays.
They can look like very simple version of
vectors from C++.
TESTS: Add nwrap_vector tests.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6706ee485660e6e5360d750adef8fdb3b75e2415
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 6 10:34:20 2015 +0200
nwrap: Check for setspent and getspnam functions
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 22f159f45f791ef2b1664ebfbdf0867d5d8ce97f
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 6 10:19:48 2015 +0200
src: Add configure check for shadow.h
This is the first part to fix FreeBSD.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 088887bda9cd8c25342d5bcf104536a888c48699
Author: Andreas Schneider <asn at samba.org>
Date: Thu Sep 17 10:39:15 2015 +0200
nwrap: Add support for getspnam()
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 608fa2063a498bea66df1fb0c1336a2a649986b2
Author: Andreas Schneider <asn at samba.org>
Date: Thu Sep 17 10:38:49 2015 +0200
nwrap: Add (set|get|end)spent functions
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e971a44299057e9f6baece4a376baa6998dc0d3d
Author: Andreas Schneider <asn at samba.org>
Date: Thu Sep 17 10:37:50 2015 +0200
nwrap: Add nss_wrapper_shadow_enabled() function
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4be5853b4cbf460d6203dcc0c3297bf45e57eacb
Author: Andreas Schneider <asn at samba.org>
Date: Thu Sep 17 10:33:58 2015 +0200
nwrap: Add shadow file parser
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2a5335217e9e9d1c34c192f4a00c9a77bdacc112
Author: Andreas Schneider <asn at samba.org>
Date: Thu Sep 17 10:32:46 2015 +0200
nwrap: Remove unused struct member in nwrap_main
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 90585c46ebad3af67d39152dc7b79ce2b36da74c
Author: Andreas Schneider <asn at samba.org>
Date: Fri Sep 11 13:37:57 2015 +0200
nwrap: Implement nwrap_files_initgroups()
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 80abc70bc9685857af0dae6ea2e0c3904e854c9d
Author: Andreas Schneider <asn at samba.org>
Date: Mon Sep 14 14:57:40 2015 +0200
nwrap: Remove unneeded memcpy in getgrouplist()
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a104389de2798189cb2729042f5dd60ca626019d
Author: Andreas Schneider <asn at samba.org>
Date: Mon Sep 14 14:52:51 2015 +0200
nwrap: Avoid a string comparsion in getgrouplist()
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 1c346a07ff85805a616f07682ecf2c4afb311dec
Author: Robin Hack <hack.robin at gmail.com>
Date: Wed Jul 15 15:00:02 2015 +0200
nwrap: Use ssize_t for aliases_count
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 02b5410466c89de404e4a406f79459448f9e12f3
Author: Robin Hack <hack.robin at gmail.com>
Date: Wed Mar 25 09:36:10 2015 +0100
nwrap: Prevent compilation failure on machine without IPv4
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 90dbe7beb87771e9f598c3ec4f783f90f19b4e62
Author: Robin Hack <hack.robin at gmail.com>
Date: Sat Nov 29 13:22:46 2014 +0100
nwrap: Replace free() calls by SAFE_FREE macro where possible.
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ea741de64a92e4d1cf62c7a2539fefabbcb38a81
Author: Andreas Schneider <asn at samba.org>
Date: Wed Oct 1 17:15:35 2014 +0200
nwrap: Fix the handle loops for older gcc versions.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 77d0fce7b75f6cb4b43850fd914829b0a94316c6
Author: Michael Adam <obnox at samba.org>
Date: Sat Jan 9 00:19:03 2016 +0100
torture: add torture comment output of name/ip to WinsBy{Ip,Name} tests
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 71ffd3b90b5c19ba8596dee86ed49881a22371cc
Author: Michael Adam <obnox at samba.org>
Date: Fri Dec 18 19:11:43 2015 +0100
torture: Fix winbind.wbclient.ResolveWinsByIp test
The test gets handed a name, so we first need
to resolve the name to an IP before we can
pass that on to ResolveWinsByIp.
Bug uncovered by the new nss_wrapper code (1.1.2).
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fcb1ca86542831f226de4a8a0b8e51d6831d8895
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 17 13:59:58 2015 +0100
torture: fix check_pw_with_krb5 in the rpc:lsa test
Don't use AI_NUMERICHOST for getaddrinfo.
This is so that a host*NAME* handed in will get properly resolved.
Bug uncovered by the new nss_wrapper code (1.1.2) which fixed
the handling of the AI_NUMERICHOST flag in getaddrinfo.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 688590f07f67047a47dd5ce47c7311745a3a7615
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 17 13:59:40 2015 +0100
torture: fix check_dom_trust_pw in the rpc:lsa test
This makes sure a host*NAME* handed in will get properly resolved.
Bug uncovered by the new nss_wrapper code (1.1.2) which fixed
the handling of the AI_NUMERICHOST flag in getaddrinfo.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 38c2305fe535c12c1737acd456a857a7f793aef3
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 17 13:58:12 2015 +0100
torture: fix the ldap.netlogon-udp test
This makes sure a host*NAME* handed in will get properly resolved.
Bug uncovered by the new nss_wrapper code (1.1.2) which fixed
the handling of the AI_NUMERICHOST flag in getaddrinfo.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9b443d2f4ba850582f3a888ad89322f626e0e750
Author: Michael Adam <obnox at samba.org>
Date: Thu Dec 17 13:56:16 2015 +0100
torture: fix the ldap.cldap test
This makes sure a host*NAME* handed in will get properly resolved.
Bug uncovered by the new nss_wrapper code (1.1.2) which fixed
the handling of the AI_NUMERICHOST flag in getaddrinfo.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2e2d4be953e9a4f70054011a44bc1dff71b6bf3b
Author: Michael Adam <obnox at samba.org>
Date: Mon Jan 11 00:02:49 2016 +0100
s3:wscript: fix spaces
- replace tabs (of different length) by spaces
- remove trailing spaces
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Mon Jan 11 05:04:28 CET 2016 on sn-devel-144
commit 551e268ac307bd352b2d45d3089319294261c9cd
Author: Volker Lendecke <vl at samba.org>
Date: Mon Dec 21 21:29:13 2015 +0100
tldap: Use struct initializer in tldap_search
Avoids a call to ZERO_STRUCT
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Mon Jan 11 01:31:59 CET 2016 on sn-devel-144
commit 8842235a82bbf8fb65d23fa38d87c16c58040dce
Author: Volker Lendecke <vl at samba.org>
Date: Mon Dec 21 11:17:28 2015 +0100
tldap: Avoid includes.h
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 093a89f6ecf706e1cc4ea838b09b2a83ed4cbe10
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 10 12:00:52 2016 +0100
tldap.h: References DATA_BLOB
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 5021974f2ab8a1318e2a0e7f51a8a988cd1820cb
Author: Volker Lendecke <vl at samba.org>
Date: Mon Dec 21 10:50:59 2015 +0100
lib: Introduce util_tsock.h
This avoids includes.h in source3/lib/util_tsock.c
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 3df9e9c7aeb95ee5f5292c35bf0628b51b32b8b1
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 22 13:44:02 2015 +0100
tldap: tevent_req_create NULLs out "state"
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit e48184935e1f4c6a3876a054ed4031b23ed0df7a
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 10 11:29:40 2016 +0100
tldap: Use "size_t" for talloc_array_length result
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 8215409153d15cbf96ac9103d355c8c5ea71ea13
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 10 11:33:01 2016 +0100
tldap: Remove an unneeded "return;"
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 245064d5a3b46491d446dbf2186412b1a0933ef9
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 27 15:31:58 2015 +0100
tldap: Remove unneeded vars
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 657610a0e423aa0cd17f9137845a335b02217884
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 7 21:33:18 2016 +0100
smbd: Fix 240393 Uninitialized pointer read
If we run into the "This is a stream on the root of the share" case,
in old line 409 (new line 417) we "goto done;". If then in old line 1027
(new line 1035) "build_stream_path" fails, "start" is uninitialized.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Jan 8 05:44:15 CET 2016 on sn-devel-144
commit fc4c2dcd526851fa938f6d8edb15b58fbb644a45
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 7 21:17:43 2016 +0100
bind_dlz: Fix CID 1347318 Unchecked return value
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0cb8b9d113b322f784100365669d2be8b7fa635a
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 7 21:14:05 2016 +0100
ctdb: Fix CID 1347319 Unchecked return value
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4a3ad425b92122f5b5e61b140eb52d3fe06b724e
Author: Volker Lendecke <vl at samba.org>
Date: Thu Jan 7 21:10:24 2016 +0100
samdb: Fix CID 1347320 Dereference null return value
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 78e9f1effb0d8f5fd4eb170ff44af428bc5c2315
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 6 12:28:44 2016 +1300
build: Add space before -D option
This ensures that it is not concatonated with the previous option
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Jan 8 02:36:47 CET 2016 on sn-devel-144
commit 0e58705a5bc11a9556d0774f9cb2fbb3897839c8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 13:23:50 2016 +1300
python: Remove Python 2.4 support macros
We require Python 2.6
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 8bac96de8265b82815276a14aaba3295d19845aa
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 13:07:49 2016 +1300
ntvfs/python: Adjust to use of PY_SSIZE_T_CLEAN
This changes the type used for # arguments to PyArg_ParseTuple
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 516ec3005a18770bceb25aa6e49799fe407ceff5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 13:07:08 2016 +1300
pyrpc: Adjust to use of PY_SSIZE_T_CLEAN
This changes the type used for # arguments to PyArg_ParseTupleAndKeywords
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 5c7822a1e4e89a9f175c55b6e9913779452136c2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 13:06:31 2016 +1300
pyregistry: Adjust to use of PY_SSIZE_T_CLEAN
This changes the type used for # arguments to PyArg_ParseTuple
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 6a6aec78c52fad1b6fdd92834444c29992142ce6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 13:05:44 2016 +1300
pymessaging: Adjust to use of PY_SSIZE_T_CLEAN
This changes the type used for # arguments to PyArg_ParseTupleAndKeywords
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 0064f1d3a63ebb3f819f680a5e209d011ec43cc4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 13:04:46 2016 +1300
pylibsmb: Adjust to use of PY_SSIZE_T_CLEAN
This changes the type used for # arguments to PyArg_ParseTupleAndKeywords
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 638c611796f6bb692e9a4500644d8875adc5c3c8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 13:03:39 2016 +1300
pidl: Use PY_SSIZE_T_CLEAN
This changes the type used for # arguments to PyArg_ParseTupleAndKeywords
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 4894811dafafc57de98bf5271b3ee133622cefb6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 12:42:06 2016 +1300
ldb: Adjust to PY_SSIZE_T_CLEAN and use Py_ssize_t consistently with PyArg_ParseTuple*()
This was inconsistent after dd7baa2ae2f98d5c1e82fa97f223925025da5ca0,
and may be the cause of test errors on s390x. (The change to
py_ldb_dn_set_component() kept the Py_ssize_t type for 'size' without
setting the PY_SSIZE_T_CLEAN macro to have PyArg_ParseTuple() expect
a Py_ssize_t. Instead, PyArg_ParseTuple() expected an int.
See in particular debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808769
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 46b8d7fc522f2fa084b56451ce3775e7138e2bca
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jan 6 11:57:39 2016 +1300
python: Assert that we use Py_ssize_t consistently for PyParseArgs*()
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 11de99a6d83c0ec34481847d2adff9a99f41385d
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jan 5 22:00:58 2016 +0100
asn1: Clean up includes
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Jan 7 19:12:22 CET 2016 on sn-devel-144
commit fe3c270ea6e9e58100f97833119a1e6d9f8b1de9
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 14 11:49:57 2015 +0200
smbcontrol: Use procid_is_local
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2948fb347a8cd44deb358b65ad95125ab2b60c42
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 14 11:49:57 2015 +0200
net: Use procid_is_local
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8108f0d320013c560339723d8d70ab601350d0c4
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jan 6 15:03:47 2016 -0800
s3: smbclient: asn1_extract_blob() stops further asn1 processing by setting has_error.
Don't call asn1_has_error() after asn1_extract_blob() has been successful
otherwise we get an "Failed to build negTokenInit at offset" message
on success.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Jan 7 16:00:02 CET 2016 on sn-devel-144
commit 8ca6fe6d75f296f70a51513063466e48691028d9
Author: Michael Adam <obnox at samba.org>
Date: Wed Jan 6 23:38:23 2016 +0100
docs:smbdotconf: fix the description of 'machine password timeout'
This parameter also covers 'security = ads'.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 0cae2270089bfd8aa4b3f71ba6038ee3db766988
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 7 16:06:20 2016 +1300
selftest: Add tests for ntlm-server-1 and --password mode in ntlm_auth
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Jan 7 07:41:22 CET 2016 on sn-devel-144
commit bfe4163f17d1c0fcf7167ebea0885d30b4a95ca1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jan 7 12:33:11 2016 +1300
ntlm_auth: Allow --password force a local password check for ntlm-server-1 mode
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit eda6aaf1533b69d093ba67ff5e22fcda0073dd3f
Author: Christian Ambach <ambi at samba.org>
Date: Mon Jan 4 23:12:25 2016 +0100
s3:smbd/oplock obey kernel oplock setting when releasing oplocks
otherwise smbd asks the kernel to release an oplock that was never requested
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11400
Signed-off-by: Christian Ambach <ambi at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Jan 6 08:58:56 CET 2016 on sn-devel-144
commit 3e1b26bd6d0998c3af3d77f94eaac469434389be
Author: Uri Simchoni <uri at samba.org>
Date: Wed Jan 6 00:12:36 2016 +0200
selftest: more dfree command and smbclient disk usage tests
Add tests that cover disk usage printing by smbclient, as well
as passing directory info to the "dfree command" script.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11662
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Jan 6 03:58:59 CET 2016 on sn-devel-144
commit 275da6c5c7e7c5dd0581e919912eb82102903a46
Author: Uri Simchoni <uri at samba.org>
Date: Wed Jan 6 00:08:25 2016 +0200
smbclient: query disk usage relative to current directory
When querying disk usage in the "dir" and "du" commands,
use the current directory. This behavior is compatible
with Windows command shell "dir" command.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11662
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d865ed20062cc5fc62313c25e7a6cb90763d0158
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jan 3 21:26:50 2016 +0100
asn1: Make 'struct asn1_data' private
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 44c56fc66788adf7b58f1d77a1e7d79d840ea9f6
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 4 10:42:11 2016 +0100
asn1: Remove a reference to asn1_data internals
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3c340d81d8bf2e7b8488b150452bbcc4e3b521b6
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 4 10:30:35 2016 +0100
libcli: Remove a reference to asn1->ofs
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b7f0e29fd2c30024d5a7da7aa6a1f0084612f9d2
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jan 5 10:55:44 2016 +0100
lib: Use asn1_current_ofs()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 927bbed6aaed9d454e8750aa053c5fa9fb1f1005
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 4 10:25:41 2016 +0100
asn1: Add asn1_current_ofs()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1282f6063d53b2b86c91cf80c9b0d6a2cdb4ad7b
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 4 10:24:01 2016 +0100
lib: Use asn1_has_nesting
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2a5141a772f531ca113b9c2649ad79400c283749
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 4 10:23:20 2016 +0100
asn1: Add asn1_has_nesting
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a93946b2fee6d6fedb9830d1dec593fca15fefc8
Author: Volker Lendecke <vl at samba.org>
Date: Sat Jan 2 20:10:53 2016 +0100
lib: Use asn1_extract_blob()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7b7aa016df35ed7f8388a9df08d66a816adc1bf7
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 4 21:53:23 2016 +0100
asn1: Add asn1_extract_blob()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8cfb6a313937964902940a7ebada7bacab7dbbb8
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 4 21:51:07 2016 +0100
lib: Use asn1_set_error()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 94b44598a581539958d8f537742fcab44d21de4c
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jan 4 21:50:49 2016 +0100
asn1: Add asn1_set_error()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 57a0bc9a9f3a02f809153dc19537110c4c796338
Author: Volker Lendecke <vl at samba.org>
Date: Sat Jan 2 18:11:00 2016 +0100
lib: Use asn1_has_error()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fa207fe9d17d27060e5e2989c19980103fd4778d
Author: Volker Lendecke <vl at samba.org>
Date: Sat Jan 2 17:58:21 2016 +0100
asn1: Add asn1_has_error()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ef8049b24353ea657d6fba989a294939c58895cb
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 27 11:18:47 2015 +0100
asn1: Make "struct nesting" private
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f908e6560bcb06938bee9019d43b622eb31fb2c3
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 27 10:57:07 2015 +0100
asn1: Add some early returns
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 249202d8c04fae245ee373e7926484e33822c905
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 22 13:50:54 2015 +0100
asn1: Add overflow check to asn1_write
Found by pure code reading :-)
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ad630a681e345cc7765f2a2f2dc1ba25ee0200c2
Author: Volker Lendecke <vl at samba.org>
Date: Mon Dec 21 10:41:39 2015 +0100
asn1: Make asn1_peek_full_tag return 0/errno
We don't need the full power of NTSTATUS here. This was the only
NTSTATUS in asn1.h, so I think it's worth removing it.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 45800223fd5fb8d35770d101882cfb2b19465944
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 20 21:49:26 2015 +0100
asn1: Remove an unused asn1 function
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a44e4e932347c4c73bfcd9ee227a5105b5db09f2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 12:13:40 2016 +1300
ldb: validate ldb_dn_set_component input parameters even more strictly
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Jan 6 00:33:21 CET 2016 on sn-devel-144
commit 30e92d0a325d3829fa90d19e1b7af35a3db859f1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 12:13:04 2016 +1300
ldb: Explain why this use of talloc_memdup() is safe
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 084bab5a06fda352df5c8b902aa36068b7bcc396
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 12:12:37 2016 +1300
ldb: Be strict about talloc_memdup() and passed in buffers in ldb_dn_set_component()
This ensures we do not over-read the source buffer, but still NUL terminate.
This may be related to debuain bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=808769
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit ff94a01e19604ae6275672e70edd25121df79bbf
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon May 4 13:44:45 2015 +1200
travis: Add metadata file for the Travis CI Open Source cloud build/test service
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Jan 5 12:21:40 CET 2016 on sn-devel-144
commit 05c34810a8184a67d2836fcae51ec8de8c4a46fc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 22 14:57:10 2015 +1300
autobuild: Use make -j on samba-libs/samba-static build as well
We need this build to be fast when split out as a seperate VM
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit af89d18c141b2ea15cd661860db087bc40c0ec20
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 22 10:35:47 2015 +1300
autobuild: Put the static build in another stanza
This will allow it to run on a different VM in travis-ci and so keep
us below the 50min limit.
Because we do not rebuild the libs (and real world static builds are
likely to have internal libs), this changes us to build them
internally.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit cce16123feedfbf0e325182c6e301377d8a60749
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jan 4 14:20:54 2016 +1300
autobuild: Use cp --recursive --link --archive
This works on waf based builds as source files are not modified during the build
TODO: In order to make sure build doesn't influence each other,
we need to add something like:
try:
if options.rebase is not None:
rebase_tree(options.rebase, rebase_branch=options.branch)
+ run_cmd("find -type f | xargs chmod -w", show=True, dir=test_master)
except Exception:
But that means we need to change the way 'make distcheck' works for the
standalone libraries.
For now this will help to reduce the (mem)disk usage of an autobuild a lot.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9a91fce2deccfe0445363b2a35f2cfb72fdff766
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 21 14:35:33 2015 +1300
autobuild: Give a clearer failure message
This helps when autobuild.py is used in --tail mode and
where there is neither e-mail nor access to the logs.tar.gz
Working back to find where the error happened is typically
quite difficult, as many failures are actually due to the
cleanup.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d60465cfec53a0476ea26b11cc857210ffdfc585
Author: Thomas Nagy <tnagy at waf.io>
Date: Sat Dec 5 12:09:33 2015 +0100
build:wafsamba: Use the upstream version of gccdeps
This removes the duplicate gccdeps file provided in the Samba tree.
The two files buildtools/wafsamba/gccdeps.py and thirdparty/wafadmin/3rdparty/gccdeps.py
are identical except for the whitespaces (compare them with `diff -burN`)
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Sat Jan 2 22:31:56 CET 2016 on sn-devel-144
commit 88969d75295421386de339d2501965c0db685756
Author: Thomas Nagy <tnagy at waf.io>
Date: Sat Dec 5 12:04:29 2015 +0100
thirdparty:waf: Update gccdeps from upstream
The version from upstream was updated. It is not used at this moment
in Samba because there is a copy kept in builtools/wafsamba/gccdeps.py
which will be removed soon.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit 1bc806a4738d705b45d954060dcd9fd2ab70ddfd
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Jan 1 00:17:59 2016 +0100
Happy New Year 2016!
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Jan 1 03:23:14 CET 2016 on sn-devel-144
commit 73f01cd2f11029bde5cd789f1923342cbb1b065a
Author: Michael Adam <obnox at samba.org>
Date: Tue Dec 29 00:44:11 2015 +0100
torture:smb2: fix copy'n'paste error in durable-open:open2:lease test
Checking against the correct smb2_create object also lets us
check the correct create action (EXISTED vs CREATED).
Observed when this showed up in flakey test results.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Dec 29 08:34:03 CET 2015 on sn-devel-144
commit 1be7e8b9d89fb061ca5707831b6a1151def89be4
Author: Uri Simchoni <uri at samba.org>
Date: Sun Dec 27 07:17:58 2015 +0200
smbd: remove function name from a DBG_INFO in a recent commit
We now have <function_name:> embedded automatically into DBG_XXX-
generated messages.
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Dec 29 04:18:19 CET 2015 on sn-devel-144
commit d4c2395e6428312854b8570064bddab3a7f188ff
Author: Uri Simchoni <uri at samba.org>
Date: Thu Dec 24 08:10:11 2015 +0200
smbd: do not disable "store dos attributes" on-the-fly
Smbd would disable "store dos attributes" on-the-fly if the
attempt to set/get user.DOSATTRIB fails with ENOTSUP or ENOSYS.
The rationale behind it was that the file system does not support
extended attributes, so there's no need to fill up the log with
failure messages.
However, a "wide symlink" could point to a spot that doesn't support
extended attributes. Even with the default banned wide links, we
currenly allow stat'ing those files and follow the symlink, and this
in turn would disable "store dos attributes" for the whole share.
The user.DOSATTRIB attribute also stores file creation time,
so that is also affected.
Another case where this behavior would turn storage of DOS attributes
off is that of the ".." entry at the root of the share, if the parent
folder for the share's root path does not support extended attributes.
On the other hand, the information on the file system and its support
of extended attributes is readily available, so the fix for explosion
of the log should be not to configure "store dos attributes" on
such a share.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11649
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Dec 25 13:20:58 CET 2015 on sn-devel-144
commit 5b1a87e344f192ae6c43e11c5e62e5cabf8520d3
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Dec 23 12:44:31 2015 +1300
dsdb subnets: warn when an IPv6 address is in IPv4 embedding range
We fail on these ones, and it isn't immediately obvious why. Windows
also fails on *most* of them, but succeeds on "::ffff:0:0" which is a
bit strange but there you go.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Pair-programmed-with: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Dec 24 07:16:25 CET 2015 on sn-devel-144
commit 906a53f442797942e29c899fb7a54a92f970e67e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Sep 23 15:10:56 2015 +1200
samldb: ensure subnets have proper net ranges
A subnet name needs to be a valid CIDR address range -- that's the
ones that look like 10.9.8.0/22, where the number after the /
determines how many bits are in the address suffix. It can be IPv4 or
IPv6. There are a few odd constraints (see MS-ADTS v20150630
6.1.1.2.2.2.1 "Subnet Object") -- for example, with IPv4, the implied
bit mask can't equal the address. That is, you can't have a subnet
named "255.255.255.0/24" in a Windows subnet. This rule does not apply
to IPv6.
Windows and Samba both make some ensure that subnets have a unique
valid name, though unfortunately Windows 2008R2 is rather slack when
it comes to IPv6. We follow Windows 2012R2, which roughly follows
RFC5952 -- with one caveat: Windows will allow an address like
"::ffff:0:1:2", which translates to the IPv4 address "0.1.0.2" using
the SIIT translation scheme, and which inet_ntop() would render as
"::ffff:0:0.1.0.2". In the Samba implementation we use an inet_pton()/
inet_ntop() round-trip to establish canonicality, so these addresses
fail. Windows wisely does not allow the SIIT style addresses (the
acronym is widely agreed to be off-by-one in the second letter), and
it will regard "::ffff:0:1:2" as simply "::ffff:0:1:2" and allow it.
We would like to do that too.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit cbb93977cd0e427ba83c2f3dff31668901ad4699
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Oct 28 12:20:37 2015 +1300
samba-tool: add sites subnet subcommands
This allows you to add, remove, or shift subnets.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8e6f2d923c9fc4249d162c8731fbbf5b44e87936
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Sep 17 18:16:49 2015 +1200
samba-tool tests: Add command line tests for sites
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 12813ea55518f7f953a80041e8d5dd1ae2107510
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 29 16:34:27 2015 +1300
python/sites: Rework site DN construction
This new routine is safe against escape characters and works
against Windows 2012R2.
The dn= filter in the old code was samba-specific.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit dbcb13cb055f47926901e442d09ecb6fa77d1502
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Oct 29 14:54:15 2015 +1300
python.sites tests: remove excessive transaction management
These are atomic anyway.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit bdb03c52296ba2af20c2d8c1bd0f017d9f01b9cc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 28 15:26:12 2015 +1300
selftest: Allow sites test to run against a remote ldap:// host
The previous code was just broken
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 9ac5e3cf30c62d4a83122e5b9c1b3ef253f126e8
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Sep 17 18:07:32 2015 +1200
samba.sites: reduce code duplication in Exception classes
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 358c0f20ccad2063bfab1b4c05a0709951960389
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Sep 17 18:28:09 2015 +1200
dsdb.tests.sites: don't use global database, tidy long lines
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b27dcb5bcabf3289de6a81b4a6e740e3c4f7d469
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Sep 17 18:10:03 2015 +1200
samba.sites: improve grammar in an error message
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit f26b227041e90b48c3ad659b461b82fed4fe0bfe
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Sep 17 11:35:55 2015 +1200
dsdb.tests.sites: merge interdependent tests
The delete test deleted the site made by the create test, which worked
because "delete" sorts after "create" alphabetically. By themselves,
"delete" would fail and "create" would neglect its duty to clean up.
This would be an issue if the order of tests changes, if one of the
tests is not run, or if another test appears in between. Everything is
fine if they give up the pretense of independence.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit fa2c6685c933e44bd504ff98200dc21d3167285a
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Sep 16 14:17:25 2015 +1200
samba-tool sites: use -H to set URL with standard handling
samba-tool sites was defaulting to the local database, but we might
want to use another URL. This allows that case while defaulting to
the old behaviour.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit bb64abf9540118b739ac981eb7f7f2537aceafdd
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Sep 17 18:30:28 2015 +1200
sambatool sites: PEP8/flake8 improvements
We were nearly there, so lets make the jump. This involves removing
some unused variables.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 149c0756b47bbf39a87545caabbb16866319871e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Dec 22 14:18:19 2015 +1300
torture/gentest time_skew(): don't use labs() on unsigned NTTIME
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit d098e9c4ba90f23589611efbe38c6f5ac4368e16
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Dec 21 16:40:28 2015 +1300
repl: Skip new subdomains and partitions when replicating
These will need to be handled later, but probably via reading the cross-ref objects.
This avoids total failure when cloning a DC that has
subdomains.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 8091f84fa472dd46c48d20b0487b275162790be9
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date: Fri Mar 14 17:54:48 2014 +0100
s4:samba-tool domain raise tool - make it aware of newer domain function levels
http://msdn.microsoft.com/en-us/library/Cc223742.aspx
Signed-off-by: Matthias Dieter Wallnöfer <mdw at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Matthias Dieter Wallnöfer <mdw at samba.org>
Autobuild-Date(master): Thu Dec 24 04:08:04 CET 2015 on sn-devel-144
commit 33ed975398e2904bb3f9b94f1119662a40508009
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date: Fri Mar 14 17:36:17 2014 +0100
s4:samba-tool domain raise tool - handle Windows 2000 mode AD domains correctly
Considering http://msdn.microsoft.com/en-us/library/cc220262.aspx they do not
provide any "msDS-Behavior-Version" attributes.
gulikoza <gulikoza at users.sourceforge.net> noticed this correctly.
Signed-off-by: Matthias Dieter Wallnöfer <mdw at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ada59ec7b3a5ed0478d11da2fe0c90991d137288
Author: Michael Adam <obnox at samba.org>
Date: Wed Dec 23 18:01:23 2015 +0100
s3:smbd: fix a corner case of the symlink verification
Commit 7606c0db257b3f9d84da5b2bf5fbb4034cc8d77d fixes the
path checks in check_reduced_name[_with_privilege]() to
prevent unintended access via wide links.
The fix fails to correctly treat a corner case where the share
path is "/". This case is important for some real world
scenarios, notably the use of the glusterfs VFS module:
For the share path "/", the newly introduced checks deny all
operations in the share.
This change fixes the checks for the corner case.
The point is that the assumptions on which the original
checks are based are not true for the rootdir "/" case.
This is the case where the rootdir starts _and ends_ with
a slash. Hence a subdirectory does not continue with a
slash after the rootdir, since the candidate path has
been normalized.
This fix just omits the string comparison and the
next character checks in the case of rootdir "/",
which is correct because we know that the candidate
path is normalized and hence starts with a '/'.
The patch is fairly minimal, but changes indentation,
hence best viewed with 'git show -w'.
A side effect is that the rootdir="/" case needs
one strncmp less.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11647
Pair-Programmed-With: Jose A. Rivera <jarrpa at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Dec 24 00:57:31 CET 2015 on sn-devel-144
commit 2efa2e08a440579827e18bbe14225e4f2513c232
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 14:46:36 2015 -0800
s3: smbd: Replace lp_posix_pathnames() with req->posix_pathnames in dir.c. Only one remaining.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Dec 23 21:27:46 CET 2015 on sn-devel-144
commit 52bae7927cecbf43d98f29c57da45d49873a15dd
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 14:09:52 2015 -0800
s3: smbd: Remove lp_posix_pathnames() checks on paths sent in via old Win9X RPC calls.
No unix client makes these.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 398ee270de106e3cb8d5ca01282aa7692ac1d815
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:55:21 2015 -0800
s3: smbd: Replace lp_posix_pathnames() with smbreq->posix_pathnames in smb2_query_directory.c.
Currently SMB2/3 doesn't do posix pathname processing, leave this
as a placeholder for when SMB2 unix extensions are added.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 944e94013c1367d65766cab83eccbacc79326445
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:52:10 2015 -0800
s3: smbd: smb2_create.c - remove all uses of lp_posix_pathnames().
Currently SMB2/3 doesn't do POSIX pathname processing.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit a2f025e26bb10e6574ea9b8d877eff75697e469e
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:49:55 2015 -0800
s3: smbd: Convert all but one use of lp_posix_pathnames() into req->posix_pathnames in trans2.c
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 3cd1b185bd49da6c61b2df24d097c99bc8fee032
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:45:30 2015 -0800
s3: smbd: Remove *all* uses of lp_posix_pathnames() from open.c
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 865bd48f3ac5072f9f69521d56338f1c74b861f7
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:44:10 2015 -0800
s3: smbd: Replace most uses of lp_posix_pathnames() with req->posix_pathnames in nttrans.c
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 6db6bc204fc911106d36d5690de765dc4d61e34b
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:41:45 2015 -0800
s3: smbd: Replace most uses of lp_posix_pathnames() with req->posix_pathnames in reply.c
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 40df6f23f33348761a6fbd39c73de1b6e2ed190c
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:36:57 2015 -0800
s3: smbd: Now struct smb_request has a bool posix_pathnames, remove the lp_posix_pathnames() call inside srvstr_get_path_req_wcard().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 4587d83f075a82665a48b52087b2704d2105882e
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:35:10 2015 -0800
s3: smbd: VFS change. Add new field bool posix_pathnames into struct smb_request.
Initialize from lp_posix_pathnames() global.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit cc729ae47d87a4659590af86e5389f37d17a523f
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:27:55 2015 -0800
s3: smbd: srvstr_get_path() is now only called when lp_posix_pathnames() is false.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 88bb4801c0c7632caf6b1b059aa07d56cf215c60
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:26:49 2015 -0800
s3: smbd: Split all calls to srvstr_get_path() to calls to srvstr_get_path_posix() or srvstr_get_path() depending on lp_posix_pathnames().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit c78d73986d69f52699d576c3d0cad157feef13a8
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:18:03 2015 -0800
s3: smbd: Add srvstr_get_path_posix().
Not yet used, will be plumbed into existing callers of srvstr_get_path()
when lp_posix_pathnames() is true.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 5740761e78711b59b1b7734bbbc76ddb55c3abc8
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:14:41 2015 -0800
s3: smbd: We now know that srvstr_get_path_wcard() is only called when lp_posix_pathnames() is false.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 41d62dfcb6179ff760a35e38d73009ae3761c533
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:13:44 2015 -0800
s3: smbd: Split all calls to srvstr_get_path_wcard() into srvstr_get_path_wcard_posix() or srvstr_get_path_wcard() depending on lp_posix_pathnames().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit eb7198f9991c5baba241dd2897107ba80dd6a817
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:07:49 2015 -0800
s3: smbd: Add srvstr_get_path_wcard_posix().
Allows us to call this directly and eventually remove the lp_posix_pathnames() call
from inside of srvstr_get_path_wcard().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit db36ee422bc45147169997c0217ea43b104efcec
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:04:11 2015 -0800
s3: smbd: Move lp_posix_pathnames() out into srvstr_get_path_req_wcard().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 5a340698755fa591f0d2b7a63d50f41c051e487b
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 13:01:08 2015 -0800
s3: smbd: Move lp_posix_pathnames() out into srvstr_get_path().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit 4a6d7e1e1599634d4bcfa7cf00eb6f5f4a4aa177
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 12:52:58 2015 -0800
s3: smbd: Move lp_posix_pathnames() out of srvstr_get_path_wcard_internal().
Pass as parameter. Part of moving this switch out to the external request
parsing code.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <Volker.Lendecke at SerNet.DE>
commit f33224dbcfb69d5c503b2037c91efba4d85e56fb
Author: Volker Lendecke <vl at samba.org>
Date: Wed Dec 23 11:32:04 2015 +0100
net: Fix Coverity ID 241039 Unchecked return value
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Wed Dec 23 17:17:53 CET 2015 on sn-devel-144
commit 431cf20160b9c5db524441055a2a67b668374707
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:49:44 2015 -0800
s3: smbd: open_file: use FSP_POSIX_FLAGS_PATHNAMES
Start using FSP_POSIX_FLAGS_PATHNAMES instead of the kitchen sink
FSP_POSIX_FLAGS_OPEN.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Dec 23 10:37:07 CET 2015 on sn-devel-144
commit 58bebcb4bc9b88c2229be0676e1d63597accca52
Author: Ralph Boehme <slow at samba.org>
Date: Sat Dec 12 22:31:24 2015 +0100
smbd: file_struct: factor out POSIX pathname processing out of POSIX open
Factor out another POSIX cabability from file_struct.posix_flags
FSP_POSIX_FLAGS_OPEN.
Places that still use FSP_POSIX_FLAGS_OPEN when dealing with pathnames
can be converted later, because for the time being we always set
FSP_POSIX_FLAGS_ALL in file_struct.posix_flags.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 035bd5feb854143c8dd784623a04f0a12e4c94aa
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:32:20 2015 -0800
s3: smbd: Remove lp_posix_pathnames() from filename.c
Now correctly passed in everywhere as the UCF_POSIX_PATHNAMES flag.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Dec 23 06:31:28 CET 2015 on sn-devel-144
commit 993122aa2c9137db31e748f6a69c491e10c25efb
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:31:20 2015 -0800
s3: smbd: In trans2.c, add in UCF_POSIX_PATHNAMES to the ucf_flags if lp_posix_pathnames() requested.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit 274e8b5409600dc294457f35405c6bb870703d6d
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:27:39 2015 -0800
s3: smbd: In smb2_query_directory.c.c, add in UCF_POSIX_PATHNAMES to the ucf_flags if lp_posix_pathnames() requested.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit 31212e958787c4a60ca8afa03f92109373d77c92
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:26:18 2015 -0800
s3: smbd: In smb2_create.c, add in UCF_POSIX_PATHNAMES to the ucf_flags if lp_posix_pathnames() requested.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit dae4b3751492d8dc2486d4dfd908132ead9e3538
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:25:16 2015 -0800
s3: smbd: In reply.c, add in UCF_POSIX_PATHNAMES to the ucf_flags if lp_posix_pathnames() requested.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit 6694c82c9aa537ee7959283bec15f23c4d76c2f1
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:19:23 2015 -0800
s3: smbd: In open.c, add in UCF_POSIX_PATHNAMES to the ucf_flags if lp_posix_pathnames() requested.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit 4ce5de5fd9e2aaa4f21e63fbd32b245f280c47ab
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:18:19 2015 -0800
s3: smbd: In srv_srvsvc_nt.c, add in UCF_POSIX_PATHNAMES to the ucf_flags if lp_posix_pathnames() requested.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit 7641c69563a105f6a2263f563c2d09c8a895850b
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:16:27 2015 -0800
s3: smbd: In nttrans2.c, add in UCF_POSIX_PATHNAMES to the ucf_flags if lp_posix_pathnames() requested.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit acf66001329ec31e18a52497b6ad9c817f4a0e2f
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:12:34 2015 -0800
s3: smbd: In smb2_query_directory.c Use ucf_flags variable instead of passing as parameter.
This will allow us to move lp_posix_pathnames() out of unix_convert()
later.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit c783db3ac92c78ad7b07392bfb49f021963dd7ff
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:08:38 2015 -0800
s3: smbd: In smb2_create.c Use ucf_flags variable instead of passing as parameter.
This will allow us to move lp_posix_pathnames() out of unix_convert()
later.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit 5d03e7550bde784df0e691447d925a4d0af76e3a
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:07:16 2015 -0800
s3: smbd: In srv_srvsvc_nt.c Use ucf_flags variable instead of passing as parameter.
This will allow us to move lp_posix_pathnames() out of unix_convert()
later.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit f3f3426f689d80102fbbdc6b69aec1633a74a835
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 11:05:46 2015 -0800
s3: smbd: In trans2.c Use ucf_flags variable instead of passing as parameter.
This will allow us to move lp_posix_pathnames() out of unix_convert()
later.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit b2c813f176493605bc6a46d1f52b7e16cfa1209c
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 10:58:44 2015 -0800
s3: smbd: In reply.c Use ucf_flags variable instead of passing as parameter.
This will allow us to move lp_posix_pathnames() out of unix_convert()
later.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit e5db6763d2e9ccccba1bcfcd1a642c81ae794e05
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 10:51:35 2015 -0800
s3: smbd: In open.c Use ucf_flags variable instead of passing as parameter.
This will allow us to move lp_posix_pathnames() out of unix_convert()
later.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit 5c183b22d1b00b99e0deda3c6e6e1c08d0b7149c
Author: Jeremy Allison <jra at samba.org>
Date: Tue Dec 22 10:49:08 2015 -0800
s3: smbd: Use ucf_flags variable instead of passing as parameter.
This will allow us to move lp_posix_pathnames() out of unix_convert()
later.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <rb at sernet.de>
commit 5f407e3fb829ca790549d672a2625a15f337616c
Author: Marc Muehlfeld <mmuehlfeld at samba.org>
Date: Tue Dec 22 21:13:52 2015 +0100
Fix typo in winbindd_cm.c
Signed-off-by: Marc Muehlfeld <mmuehlfeld at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 00e952e3c6daa9fe51cc7e79b5d5e6dd37831246
Author: Ralph Boehme <slow at samba.org>
Date: Mon Nov 2 16:33:34 2015 +0100
s3: fix encryption help messages
Encryption is a SMB3 feature and not tied to UNIX extensions, so fix the
help messages of various utilities.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Dec 22 02:22:50 CET 2015 on sn-devel-144
commit b165d520374cc2ae77acfd813b528e55acfc2f7e
Author: Ralph Boehme <slow at samba.org>
Date: Fri Dec 18 17:14:41 2015 +0100
s4:torture:vfs_fruit: add test test_read_afpinfo
This works against any SMB server and test basic IO on the AFP_AfpInfo
stream.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 21d4b5cea8e4dec729912915d60922edaea0f418
Author: Ralph Boehme <slow at samba.org>
Date: Sat Dec 19 18:44:18 2015 +0100
s4:torture:vfs_fruit: add tests for AFP_Resource delete-on-close and eof
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ee431fc5254dc735662d152dd19a81d439ca5e44
Author: Ralph Boehme <slow at samba.org>
Date: Sat Dec 19 18:27:06 2015 +0100
vfs_fruit: ignore delete on the AFP_Resource stream
OS X ignores deletes on the AFP_Resource stream. This was discovered by
torture tests against OS X SMB server.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit decde0b4812eba5f80b717fd2ae868558a022753
Author: Ralph Boehme <slow at samba.org>
Date: Sat Dec 19 11:10:54 2015 +0100
s4:torture:vfs_fruit: update AFP_AfpInfo IO tests
When reading from the AFP_AfpInfo stream, OS X ignores the offset from
the request and always reads from offset=0.
The offset bounds check has a off-by-1 bug in OS X, so a request
offset=60 (AFP_AfpInfo stream has a ficed size of 60 bytes), len=1
returns 1 byte from offset 0 insteaf of returning 0.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f569fd5e44300ab41aa7298b3efdcac99cd330f2
Author: Ralph Boehme <slow at samba.org>
Date: Sat Dec 19 11:06:19 2015 +0100
vfs_fruit: fix offset and len handling for AFP_AfpInfo stream
When reading from the AFP_AfpInfo stream, OS X ignores the offset from
the request and always reads from offset=0.
The offset bounds check has a off-by-1 bug in OS X, so a request
offset=60 (AFP_AfpInfo stream has a ficed size of 60 bytes), len=1
returns 1 byte from offset 0 insteaf of returning 0.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 666a55b7060542ef78ff5f22d368f2ebc4c3318f
Author: Ralph Boehme <slow at samba.org>
Date: Sun Dec 20 19:55:06 2015 +0100
s4:torture:vfs_fruit: test nulling out AFP_AfpInfo stream
This must delete the stream.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e94b17715ea8049df8819b472178170b8e987946
Author: Ralph Boehme <slow at samba.org>
Date: Thu Dec 17 20:08:35 2015 +0100
vfs_fruit: writing all 0 to AFP_AfpInfo stream
When writing all 0 to AFP_AfpInfo stream we can remove the underlying
storage object. This beaviour of OS X SMB server was found with a
torture test.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e5588b463ee77aac3b396774e68c10b13a9f6f04
Author: Ralph Boehme <slow at samba.org>
Date: Thu Dec 17 19:47:18 2015 +0100
s4:torture:vfs_fruit: add tests for AFP_AfpInfo delete-on-close and eof
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4024153894a07b7b1115dbe1699cba94fee13f23
Author: Ralph Boehme <slow at samba.org>
Date: Mon Dec 14 16:09:54 2015 +0100
vfs_fruit: handling of ftruncate() on AFP_AfpInfo stream
With help of some torture tests I verified the following behaviour of OS
X SMB server:
* ftruncate AFP_AfpInfo stream > 60 bytes results in an error
NT_STATUS_ALLOTTED_SPACE_EXCEEDED
* ftruncate AFP_AfpInfo stream <=60 returns success but has no effect
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6f8c188dfc81a6d22bd54f248327b787e0b48f09
Author: Ralph Boehme <slow at samba.org>
Date: Sun Dec 20 18:42:23 2015 +0100
s4:torture:vfs_fruit: file without AFP_AfpInfo
Opening the AFP_AfpInfo on a file that doesn't have that stream must
return ENOENT.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0af7bf4249419ff7c88c5beece915db0a3697b72
Author: Ralph Boehme <slow at samba.org>
Date: Thu Dec 17 20:05:04 2015 +0100
vfs_fruit: stat AFP_AfpInfo must fail when it doesn't exist
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 748adea77f95d7d6114f96b7850f384b77d6f7d2
Author: Ralph Boehme <slow at samba.org>
Date: Fri Dec 11 17:27:50 2015 +0100
vfs_fruit: fix some debug messages
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1650e793edb42b07501d7467aa64c80eacf33eb6
Author: Ralph Boehme <slow at samba.org>
Date: Thu Dec 17 19:16:43 2015 +0100
s3:lib/errmap_unix: map EOVERFLOW to NT_STATUS_ALLOTTED_SPACE_EXCEEDED
vfs_fruit returns the correct error NT_STATUS_ALLOTTED_SPACE_EXCEEDED
when an attempt is made to extend the AFP_AfpInfo stream beyond 60
bytes.
This will be used in a subsequent commit in vfs_fruit.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ba00884e8a67420cf8d6c2530a778b9cee6e86b8
Author: Ralph Boehme <slow at samba.org>
Date: Sat Dec 19 18:56:24 2015 +0100
s4:torture:vfs_fruit: fix flakey test_write_atalk_rfork_io with OS X
Adjust desired_access to prevent flaky test with OS X SMB server.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 363260983f7ec85ecd3a2b35e6b07eeb5416bdc5
Author: Ralph Boehme <slow at samba.org>
Date: Fri Dec 18 17:25:07 2015 +0100
s4:torture:vfs_fruit: fix test_rename_dir_openfile() to work with OS X
OS X allows renaming of directories with open files regardless of AAPL
negotiation. Samba will only allow this after negotiating AAPL.
The first check in this test is that renaming fails without AAPL, so
skip this test if the server is OS X.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0fc2ed8f01f2e510ee58ad2ea9209d2fec10fd3f
Author: Ralph Boehme <slow at samba.org>
Date: Fri Dec 18 17:23:40 2015 +0100
s4:torture:vfs_fruit: fix test_aapl() to work with OS X
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 56bf27667cc8f2fad0cad96d796bdd2f172326a8
Author: Ralph Boehme <slow at samba.org>
Date: Fri Dec 18 17:24:12 2015 +0100
s4:torture:vfs_fruit: skip test_stream_names() without "localdir"
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 987e12b7a7518e498c47dd8dfee32aed148f8cd7
Author: Ralph Boehme <slow at samba.org>
Date: Fri Dec 18 17:22:32 2015 +0100
s4:torture:vfs_fruit: skip test_adouble_conversion() without "localdir"
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0a9a7c21073227c539fc1ced331e837c1c1f4bc4
Author: Ralph Boehme <slow at samba.org>
Date: Fri Dec 18 17:10:18 2015 +0100
s4:torture:vfs_fruit: skip test test_read_atalk_metadata() without "localdir" and rename it
The test is Netatalk specific. Skip the test if "localdir" is not
specified.
Use torture_assert() to check the result from check_stream().
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 155397e83173e13baebfc507ad9659d0ed213b5b
Author: Ralph Boehme <slow at samba.org>
Date: Fri Dec 18 17:18:41 2015 +0100
s4:torture:vfs_fruit: add explicit cleanup of testfiles
smb2_deltree() doesn't work with OS X (looks like OS X doesn't handle
FILE_NON_DIRECTORY_FILE correctly). As a workaround, use explicit
cleanup of all testfiles and directories.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3c0ac9b3899aa06315e592253c858f31d4bd2ae3
Author: Ralph Boehme <slow at samba.org>
Date: Fri Dec 18 17:08:32 2015 +0100
s4:torture:vfs_fruit: add --option=torture:osx for enable_aapl()
Check if the server is OS X and don't check the AAPL context size if it
is.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fdf937e77da29ec47002855db69d9e3f95005479
Author: Ralph Boehme <slow at samba.org>
Date: Thu Dec 17 19:22:12 2015 +0100
s4:torture:vfs_fruit: enhance check_stream
Don't sleep when create fails and use torture_ macros.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8694da43442abe3ae6ac3b6a16c524e455ae1a65
Author: Ralph Boehme <slow at samba.org>
Date: Thu Dec 17 16:51:10 2015 +0100
s4:torture:vfs_fruit: use AFPINFO_STREAM_NAME
I got erratic results from OS X SMB server with AFPINFO_STREAM
(":AFP_AfpInfo:$DATA") in some tests. Using AFPINFO_STREAM_NAME
(just the ":AFP_AfpInfo" part) instead fixed this.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8e0cf77ee230c0eaef01a2dc2316fc65aabd5a59
Author: Ralph Boehme <slow at samba.org>
Date: Thu Dec 17 13:31:12 2015 +0100
s4:torture:vfs_fruit: tweak check_stream_list()
Modify check_stream_list() to open the basefile (or directory) itself
insteaf of having the callers pass in a filehandle. Removes some code
duplication in the callers.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1d13744547474592285eacab84d1217af46e0086
Author: Ralph Boehme <slow at samba.org>
Date: Sun Dec 20 10:18:31 2015 +0100
s4:torture:vfs_fruit: rename tree1 -> tree
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9d28f82484e8b34c8d8f35f596fdb63614b103d2
Author: Ralph Boehme <slow at samba.org>
Date: Sun Dec 20 10:16:25 2015 +0100
s4:torture:vfs_fruit: remove unused tree2
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11347
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7ba9f8239dc6be25ff8bf3473393184c7333eaa2
Author: Günther Deschner <gd at samba.org>
Date: Fri Dec 18 13:16:28 2015 +0100
s4-torture: add a negoex ndr pullpush test.
Guenther
Signed-off-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Dec 21 01:37:29 CET 2015 on sn-devel-144
commit dbd87b94aafcae214053116321497941bacc7cad
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Nov 9 14:10:11 2015 +1300
tdb: Refuse to load a database with hash size 0
This just ensures we reject (rather than div-by-0) a corrupt
DB with a zero hash size.
Found with american fuzzy lop
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Dec 18 08:26:25 CET 2015 on sn-devel-144
commit bffcc175676657064c44f37f90fe95d3675276fc
Author: Volker Lendecke <vl at samba.org>
Date: Wed Dec 16 21:44:50 2015 +0100
libads: Remove "foreign" from ads_struct
AFAICS this was never actually used
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bf1fa9e080c48ce02d2a83b1095854485d00d5f0
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 7 09:31:03 2015 +0100
negoex.idl: use DATA_BLOB for negoex_BYTE_VECTOR
That's much easier for the callers.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Dec 18 04:07:56 CET 2015 on sn-devel-144
commit a4fa4897058e32c81e3c1cac3cb321757a967ebc
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Dec 7 09:30:47 2015 +0100
negoex.idl: initial version
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit d7feb1879ee711598540049c2c5eccc80fd6f1e5
Author: Jeremy Allison <jra at samba.org>
Date: Wed Dec 16 11:04:20 2015 -0800
s3: libsmb: Correctly initialize the list head when keeping a list of primary followed by DFS connections.
Greatly helped by <shargagan at novell.com> to
track down this issue.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11624
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Dec 18 01:02:55 CET 2015 on sn-devel-144
commit f27ba17fcf1cf6a8559ef7d77c08efe648fd49e5
Author: Jose A. Rivera <jarrpa at samba.org>
Date: Thu Dec 17 08:19:22 2015 -0600
vfs_glusterfs: Fix a memory leak in AIO
Signed-off-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
Autobuild-User(master): Ira Cooper <ira at samba.org>
Autobuild-Date(master): Thu Dec 17 20:55:22 CET 2015 on sn-devel-144
commit 55d8bfca9b08d62587eb00deebf7fe4d165451cd
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 9 12:25:46 2015 +0100
s3:libsmb: remove unused spnego related includes
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Dec 17 17:49:14 CET 2015 on sn-devel-144
commit fbcc30931caedaa8363c0dc62502c7c54f83c902
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 9 12:25:46 2015 +0100
s3:smbd: remove unused spnego related includes
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit e242d7264e50b1f13b95497d9cb759205931e7a2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Dec 7 13:32:25 2015 +1300
selftest: Ensure that if the SAMBA_PID is not set, that the env is not OK
This ensures that we must instead start the selftest environment, it is not already running
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Dec 17 06:27:14 CET 2015 on sn-devel-104
commit b0aa686eb6a36857a5f2687d159ed4caf2f3a62e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Dec 7 13:18:38 2015 +1300
selftest: Do not start tests on an environment that has failed to start up
This avoids debugging subsequent test failures, which may not be as clear
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit af16d52f7dbf2ed8c13b6a52abb6d88ef08d9ff6
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Fri Aug 14 14:27:03 2015 +1200
ldb torture: test ldb_unpack_data_only_attr_list
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11602
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 8644dd4e52e402256f030276de675a9031495031
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Tue Sep 1 13:33:52 2015 +1200
lib/ldb: Use talloc_memdup() because we know the length of the attribute already
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11602
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 8731e0c6cd267dbf23e9834d0022713d3a17d791
Author: Garming Sam <garming at catalyst.net.nz>
Date: Thu Dec 17 11:41:13 2015 +1300
lib/ldb: Rename variable for clarity
The variable p is the same as attr at this point since p is only
incremented when a continue is invoked in the loop.
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 315049e083814d529af6973be263e296ed78ca75
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Nov 13 18:45:23 2015 +1300
lib/ldb Add checks for overflow during ldb pack and parse
Both as requested by Jeremy Allison <jra at samba.org> during
patch review and as found by american fuzzy lop.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11602
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 486fd453805770e1cd17cce380f497781dfeca33
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Tue Sep 1 13:27:52 2015 +1200
lib/ldb: Use better variable names in ldb_unpack_only_attr_list
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11602
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 000249fa110d3fb9ca1658b2bcdd8f75728cb358
Author: Garming Sam <garming at catalyst.net.nz>
Date: Thu Dec 17 11:53:12 2015 +1300
ldb: increment version due to added ldb_unpack_data_only_attr_list
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11602
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 61a84ca583412bba1c9b18a57808e46268abe8f5
Author: Garming Sam <garming at catalyst.net.nz>
Date: Thu Dec 17 11:24:44 2015 +1300
lib/ldb: Clarify the intent of ldb_data_unpack_withlist
This patch renames the function to indicate that you are unpacking with respect to some
attribute list, as well as adding some comments.
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11602
commit abcd35f942468e8e51dbc7b976055232df41d421
Author: Matthieu Patou <mat at matws.net>
Date: Thu Dec 27 21:38:29 2012 -0800
ldb: introduce ldb_unpack_data_withlist to unpack partial list of attributes
When provided with non NULL list ldb_unpack_data_withlist will only
unpack attributes that are specified in the list (+ distinguished name)
ldb_unpack_data is changed to call ldb_unpack_data_withlist behind the
scene.
(for modifications found by testing, and re-indentation requested in review)
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Sadly a signed-off-by was not available from Matthieu Patou for the original
version of this patch posted to samba-technical for comment, so instead:
(for supervision of Adrian)
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11602
commit 1595f56634a8950c4493799b30c2dbe254466751
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Nov 18 17:36:21 2015 +1300
CVE-2015-8467: samdb: Match MS15-096 behaviour for userAccountControl
Swapping between account types is now restricted
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11552
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Dec 16 16:03:18 CET 2015 on sn-devel-104
commit bc2d8592f4e22dd91790bcd78e7a1a99b8a83de5
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 30 21:23:25 2015 +0200
CVE-2015-5296: libcli/smb: make sure we require signing when we demand encryption on a session
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11536
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit aef4113823a48cffc429ed6b7eb2c01e80fd639a
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 30 21:17:02 2015 +0200
CVE-2015-5296: s3:libsmb: force signing when requiring encryption in SMBC_server_internal()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11536
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f8b0f7fd94cf3c7630a108b80ea745d3e4e947be
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 30 21:17:02 2015 +0200
CVE-2015-5296: s3:libsmb: force signing when requiring encryption in do_connect()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11536
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit acbb4ddb6876c15543c5370e6d27faacebc8a231
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 23 14:54:31 2015 -0700
CVE-2015-5299: s3-shadow-copy2: fix missing access check on snapdir
Fix originally from <partha at exablox.com>
https://bugzilla.samba.org/show_bug.cgi?id=11529
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
commit cc137fa3868c9f84519a9c3aa047aefacc0c4878
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jul 9 13:57:58 2015 -0700
CVE-2015-5252: s3: smbd: Fix symlink verification (file access outside the share).
New tests for fix.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11395
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 7606c0db257b3f9d84da5b2bf5fbb4034cc8d77d
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jul 9 10:58:11 2015 -0700
CVE-2015-5252: s3: smbd: Fix symlink verification (file access outside the share).
Ensure matching component ends in '/' or '\0'.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11395
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 067640b04a6a95927b6aea40bf2a48a3637aff8d
Merge: 2058ce2 b63e3b9
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Dec 16 12:31:33 2015 +0100
Merge tag 'ldb-1.1.24' into master
ldb: tag release ldb-1.1.24
commit 2058ce246ea5008202e737f64fbdd9b586b2d7d4
Author: Ralph Boehme <slow at samba.org>
Date: Tue Dec 15 13:13:02 2015 +0100
smbd: make "hide dot files" option work with "store dos attributes = yes"
When using "store dos attributes = yes", the function that reads the
attributes from the xattr get_ea_dos_attribute() will overwrite the
attribute previously set for "hide dot files".
According to smb.conf, "store dos attributes = yes" should only
overwrite the "map XXX" options, but not "hide dot files".
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11645
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Dec 16 07:21:10 CET 2015 on sn-devel-104
commit 0fd68d0cf5a8e6b968b4b0fad5cff97ebad2c7aa
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 15 22:12:11 2015 +0100
librpc: Fix typos
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit 6aaa8b695e0005dfa93fc96eb02cc2c681f222cd
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 15 14:43:46 2015 +0100
lib: Remove ntstatus.h from gencache.h
No clue why I put it there, sorry for the noise...
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 4767291cb9b57c57b13f8d02bc8632c794baa825
Author: Ira Cooper <ira at samba.org>
Date: Tue Dec 15 07:20:38 2015 -0500
vfs_glusterfs: Attach missing destructor.
This activates the new AIO code's cancellation logic.
Signed-off-by: Ira Cooper <ira at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Dec 15 23:33:12 CET 2015 on sn-devel-104
commit 0062177d8128036afdc172d713fbf3b8d0e88af7
Author: Volker Lendecke <vl at samba.org>
Date: Tue Dec 15 11:06:35 2015 +0100
smbd: Fix CID 1343333 Uninitialized variables
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5a72a2ed0d28004d51039313e84047554c0a8f63
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 07:40:50 2015 +0200
dns_server: Remove unused handle_question
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Tue Dec 15 17:50:32 CET 2015 on sn-devel-104
commit 6adec9339dee488e41c7552451eca45ebae4b917
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 07:39:31 2015 +0200
dns_server: Add handle_authoritative_send()
An async version of handle_question
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9409
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
commit 3b7f99e6f4996cfd97220b3a6d5cceeab6ab5b79
Author: Volker Lendecke <vl at samba.org>
Date: Sat Aug 8 14:36:43 2015 +0200
dns_server: Add add_dns_res_rec()
Same as add_response_rr(), but it copies over a dns_res_rec
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
commit b6aaf77897082c6ac447e9514260b435ac3ad854
Author: Volker Lendecke <vl at samba.org>
Date: Sat Aug 8 07:20:26 2015 +0200
dns_server: Convert "ask_forwarder" params
Usually we have mem_ctx and ev first when doing a _send function
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
commit 4b54e14b7cf456e327b176b365e8471e0899210b
Author: Volker Lendecke <vl at samba.org>
Date: Sat Aug 8 06:54:11 2015 +0200
dns_server: Simplify array length handling
talloc objects carry an implicit length
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
commit 3f2cbb616f8b0becf8a3479e72dda11433126e65
Author: Volker Lendecke <vl at samba.org>
Date: Sat Aug 8 06:49:16 2015 +0200
dns_server: Simplify talloc handling
By making sure that the answers are always allocated, we don't have
to pass an explicit mem_ctx anymore
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
commit 9de59c7e3f01c578831a8e352ff8e9ee2312c77f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Aug 7 08:27:19 2015 +0200
dns_server: Consolidate talloc_realloc
This puts the talloc_realloc into add_response_rr instead of before
create_response_rr. It is a bit less efficient, but as we do not expect
hundreds of answers, I think this code is a bit easier to understand.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Kai Blin <kai at samba.org>
commit 4807577d30133bcd5150f3c9c1c7a576acbd93ce
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Nov 26 13:59:33 2015 +1300
Fix bug 10881 Wrong keytab permissions when joining additional DC with BIND backend
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10881
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Dec 15 11:47:21 CET 2015 on sn-devel-104
commit dc20c307cc1f0a5f245ff47757e8f0afe3ab8353
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Nov 26 13:57:36 2015 +1300
samba_upgradedns: Set correct permissions on secrets.keytab for BIND9
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 308d645f3428660b0466dbe273b995a887af68da
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Nov 26 13:50:21 2015 +1300
samba_upgradedns: Improve search for existing accounts in secrets.ldb
We should actually check for the combination of both an account in secrets.ldb
and sam.ldb, but this is at least an improvement.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit d38e22184ea036dfcbe851352729c469a494cb29
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 10 12:15:04 2015 +1200
samba_dnsupdate: Simplify logic and add more verbose debugging
By reducing the intendation this code is a little clearer
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 9bbb468dcb2dfec965076eadfac905e5e65a5d30
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 10 12:05:19 2015 +1200
samba_dnsupdate: Expand output when --verbose is set
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 67b6346e736fc04f66affa3025afe34ff1e4cd71
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Mar 4 17:49:36 2015 +1300
python: Give a more helpful error message when we do not have an smb.conf
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit ab1ebb1d1c650396841e4ba4a18b3c08689d4f52
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Dec 1 13:48:59 2015 +1300
password_lockout: test creds.get_kerberos_state()
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Garming Sam <garming at samba.org>
Autobuild-Date(master): Tue Dec 15 03:17:52 CET 2015 on sn-devel-104
commit 795f4729ca94029fcee750fbebbe9bc3ea43a214
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Fri Oct 23 16:57:56 2015 +1300
auth: keep track of lastLogon and lastLogonTimestamp
lastLogon is supposed to be updated for every interactive or kerberos
login, and (according to testing against Windows2012r2) when the bad
password count is non-zero but the lockout time is zero. It is not
replicated.
lastLogonTimestamp is updated if the old value is more than 14 -
random.choice([0, 1, 2, 3, 4, 5]) days old, and it is replicated. The
14 in this calculation is the default, stored as
"msDS-LogonTimeSyncInterval", which we offer no interface for
changing.
The authsam_zero_bad_pwd_count() function is a convenient place to
update these values, as it is called upon a successful logon however
that logon is performed. That makes the function's name inaccurate, so
we rename it authsam_logon_success_accounting(). It also needs to be
told whet5her the login is interactive.
The password_lockout tests are extended to test lastLogon and
lasLogonTimestamp.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 909ebe0191a409c107904df658dc9111dd5de669
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Oct 22 16:54:19 2015 +1300
password_lockout tests: add assertLoginFailure()
In a few places where a login should fail in a particular way, an
actual login success would not have triggered a test failure -- only
the wrong kind of login failure was caught.
This makes a helper function to deal with them all.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit d097e813fff3aaed261a18d8066e6bd11f12abad
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Oct 22 09:45:26 2015 +1300
auth: increase resolution for password grace period calculation
This changes the resolution of "now" from 1s to 100ns.
It should have little effect in practice, unless users are in the
habit of playing chicken with the grace period.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 8b26559aeb6d1c2c12e2ea374c30e4082ece7ec3
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Dec 1 13:17:18 2015 +1300
pycredentials: add get_kerberos_state() method
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 203f0233827e620eb89d68f7e9d2a72e0fbecafd
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Dec 11 08:52:59 2015 +0100
s4:torture/winbind: add more debug output to samba4.winbind.struct.domain_info
With this we hopefully find the reason for the following flakey test:
[1566(10157)/1882 at 1h47m18s] samba4.winbind.struct(ad_member:local)
Running WINBINDD_DOMAIN_INFO (struct based)
DOMAIN 'BUILTIN' => '' [ ] [S-1-5-32]
DOMAIN 'LOCALADMEMBER' => '' [ ] [S-1-5-21-4121020324-2900821022-46155812]
DOMAIN 'SAMBADOMAIN' => 'samba.example.com' [ PR AD NA ] [S-1-5-21-929009974-669086582-3038401809]
DOMAIN 'TORTURE300' => 'torturedom300.samba._none_.example.com' [ AD NA ] [S-1-5-21-97398-379795-300]
DOMAIN 'TORTURE301' => 'torturedom301.samba._none_.example.com' [ AD NA ] [S-1-5-21-97398-379795-301]
DOMAIN 'TORTURE302' => 'torturedom302.samba._none_.example.com' [ AD NA ] [S-1-5-21-97398-379795-302]
DOMAIN 'TORTURE303' => 'torturedom303.samba._none_.example.com' [ AD NA ] [S-0-0]
UNEXPECTED(failure): samba4.winbind.struct.domain_info(ad_member:local)
REASON: Exception: Exception: ../source4/torture/winbind/struct_based.c:460:
Expression `ok' failed: SID's doesn't match
With the changes we get:
[1566(10158)/1882 at 1h47m51s] samba4.winbind.struct(ad_member:local)
Running WINBINDD_DOMAIN_INFO (struct based)
LIST[0] 'BUILTIN' => '' [S-1-5-32]
LIST[1] 'LOCALADMEMBER' => '' [S-1-5-21-734569583-677146317-1850798319]
LIST[2] 'SAMBADOMAIN' => 'samba.example.com' [S-1-5-21-1870621479-3245899124-866531092]
LIST[3] 'TORTURE300' => 'torturedom300.samba._none_.example.com' [S-1-5-21-97398-379795-300]
LIST[4] 'TORTURE301' => 'torturedom301.samba._none_.example.com' [S-1-5-21-97398-379795-301]
LIST[5] 'TORTURE302' => 'torturedom302.samba._none_.example.com' [S-1-5-21-97398-379795-302]
LIST[6] 'TORTURE303' => 'torturedom303.samba._none_.example.com' [S-1-0-0]
LIST[7] 'TORTURE304' => 'torturedom304.samba._none_.example.com' [S-1-0-0]
LIST[8] 'TORTURE305' => 'torturedom305.samba._none_.example.com' [S-1-0-0]
LIST[9] 'TORTURE306' => 'torturedom306.samba._none_.example.com' [S-1-5-21-97398-379795-306]
LIST[10] 'TORTURE307' => 'torturedom307.samba._none_.example.com' [S-1-5-21-97398-379795-307]
LIST[11] 'TORTURE308' => 'torturedom308.samba._none_.example.com' [S-1-5-21-97398-379795-308]
LIST[12] 'TORTURE309' => 'torturedom309.samba._none_.example.com' [S-1-5-21-97398-379795-309]
LIST[13] 'TORTURE310' => 'torturedom310.samba._none_.example.com' [S-1-5-21-97398-379795-310]
LIST[14] 'TORTURE311' => 'torturedom311.samba._none_.example.com' [S-1-5-21-97398-379795-311]
DOMAIN[0] 'BUILTIN' => '' [ ] [S-1-5-32]
DOMAIN[1] 'LOCALADMEMBER' => '' [ ] [S-1-5-21-734569583-677146317-1850798319]
DOMAIN[2] 'SAMBADOMAIN' => 'samba.example.com' [ PR AD NA ] [S-1-5-21-1870621479-3245899124-866531092]
DOMAIN[3] 'TORTURE300' => 'torturedom300.samba._none_.example.com' [ AD NA ] [S-1-5-21-97398-379795-300]
DOMAIN[4] 'TORTURE301' => 'torturedom301.samba._none_.example.com' [ AD NA ] [S-1-5-21-97398-379795-301]
DOMAIN[5] 'TORTURE302' => 'torturedom302.samba._none_.example.com' [ AD NA ] [S-1-5-21-97398-379795-302]
DOMAIN[6] 'TORTURE303' => 'torturedom303.samba._none_.example.com' [ AD NA ] [S-0-0]
UNEXPECTED(failure): samba4.winbind.struct.domain_info(ad_member:local)
REASON: Exception: Exception: ../source4/torture/winbind/struct_based.c:471: Expression `ok' failed: SID's doesn't match [S-1-0-0] != [S-0-0]
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Mon Dec 14 23:26:40 CET 2015 on sn-devel-104
commit 79f946cdb6733ccd616e6add8dab9f759937d6e5
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 13 21:21:47 2015 +0100
lib: Remove unused talloc_append_blob
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8ca3a58ec923d9e3f69c2a8971873acedce761d6
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 13 21:16:36 2015 +0100
gencache: Refactor gencache_set_data_blob
Replace 3 calls into talloc with 1. Add an overflow check.
With this change, it will be easier to avoid the talloc call for small
blobs in the future and do it on the stack.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 640870ee2089536d2f7bda035668c96e8b364e54
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 13 16:32:52 2015 +0100
lib: Separate out xx_path() & callers
We should not have to #include proto.h just for cache_path() or so
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c281573399584228e2a1b567a5507f459c94f6ad
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 13 15:27:15 2015 +0100
lib: Use directory_create_or_exist in xx_path
directory_create_or_exist is a little different: It does the lstat first and
sets the umask properly, but I think this is more correct than the xx_path()
version before.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d547d030e0e3a9fb250f9d185f6a304064ab716b
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 13 15:17:27 2015 +0100
gencache: True->true, False->false
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5ef91849645d6c1fa8eadee08c77ebfc03c7a71b
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 13 15:14:18 2015 +0100
lib: Add gencache.h
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f3d140fcaf7b2efba1309361c23e6beb73bf1270
Author: Christof Schmitt <cs at samba.org>
Date: Tue Dec 8 12:04:22 2015 -0700
docs-xml: Update idmap_rfc2307 manpage for new realm handling
Now there is only "realm" as a config option; it replaces "cn_realm" and
"ldap_realm".
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Dec 14 15:43:55 CET 2015 on sn-devel-104
commit 7cd99b42075f09ee297569f1d030048c9e887d50
Author: Christof Schmitt <cs at samba.org>
Date: Tue Dec 8 11:52:41 2015 -0700
idmap_rfc2307: Fix handling of cn realm
When cn_realm was set, the idmap_rfc2307 module tried to determine the
realm from the AD connection struct. In case of referring to a different
domain using the ldap_domain config option, the wrong realm was used.
Since the LDAP-server case already requires having the realm in the
config, extend that to the AD case to fix the issue: Having LDAP records
with @realm in the cn, now always requires having the realm in the
config.
Now cn_realm and ldap_realm always would have to be specified together,
so replace the two options with a single "realm" option.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit b36c6214f02d99c758395cb93e67ca2eda8b83a7
Author: Ralph Boehme <rb at sernet.de>
Date: Sun Dec 13 09:52:50 2015 -0800
s3: smbd: When requesting posix open in open_file_ntcreate() we need to set all posix flags.
Fixes POSIX rename problem introduced in d698cec1c7e700e57cab46d33df0dde13303b318
Signed-off-by: Ralph Boehme <rb at sernet.de>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Mon Dec 14 02:03:12 CET 2015 on sn-devel-104
commit 07c4967d6ced0a7c7f6ebb6448d8c5cc7df0a0ce
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:55:10 2015 -0800
s3: smbd: Moving lp_posix_pathnames() out of the lower-level code.
Remove lp_posix_pathnames() out of ms_has_wild().
NB. The usage of ms_has_wild() inside set_namearray()
should *never* have been looking at lp_posix_pathnames()
anyway, as this is a config option that needs to look
at wildcards. This was probably an old (but never
triggered) bug.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit dea2addab1c04860a27e1e0a2de04d51c89541da
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:53:30 2015 -0800
s3: smbd: Moving lp_posix_pathnames() out of the lower-level code.
Prepare to remove lp_posix_pathnames() out of ms_has_wild().
Check before calls to ms_has_wild().
Fix smbd_smb2_query_directory_send().
No SMB2 client uses unix extensions yet, but this is a placeholder
for when we move the POSIX pathnames bit into the SMB2 request
when moving to handle based code.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 0db1ad97f8f9540e45813c3f4140c5f51f65d3a2
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:51:58 2015 -0800
s3: smbd: Moving lp_posix_pathnames() out of the lower-level code.
Prepare to remove lp_posix_pathnames() out of ms_has_wild().
Check before calls to ms_has_wild().
Fixup reply_search().
Don't think any client makes this call with POSIX extensions
on, but this keeps the same old behavior.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 82fa4ecec5be82924295febbaecc3c5677ef67ec
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:49:44 2015 -0800
s3: smbd: Moving lp_posix_pathnames() out of the lower-level code.
Prepare to remove lp_posix_pathnames() out of ms_has_wild().
Check before calls to ms_has_wild().
Fix open_file().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit cad35c5183c22faa1d88f5dbe2f522999a25962e
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:45:37 2015 -0800
s3: smbd: Moving lp_posix_pathnames() out of the lower-level code.
Prepare to remove lp_posix_pathnames() out of ms_has_wild().
Check before calls to ms_has_wild().
Fixup reply_ntrename().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit c19eaf3e25b43c4168293b0bffd5a1116e3a8952
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:41:38 2015 -0800
s3: smbd: Moving lp_posix_pathnames() out of the lower-level code.
Prepare to remove lp_posix_pathnames() out of ms_has_wild().
Check before calls to ms_has_wild().
Fixup unix_convert().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit cc13120a4c37c6a4c4bce728dd9ff7ef8a6a251e
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:38:49 2015 -0800
s3: smbd: Moving lp_posix_pathnames() out of the lower-level code.
Prepare to remove lp_posix_pathnames() out of ms_has_wild().
Check before calls to ms_has_wild().
Fixup check_parent_exists().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit a1deced2a4f5fcfa442b10e07b0644e23fd8404a
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:36:33 2015 -0800
s3: smbd: Moving lp_posix_pathnames() out of the lower-level code.
Prepare to remove lp_posix_pathnames() out of ms_has_wild().
Check before calls to ms_has_wild().
Fix determine_path_error().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit c808a6370058c7d94d088fa39e85480b4e50168c
Author: Jeremy Allison <jra at samba.org>
Date: Fri Dec 11 14:33:22 2015 -0800
s3: smbd: Moving lp_posix_pathnames() out of the lower-level code.
Ensure we set posix_pathnames early.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 7fb3d286d2c586d7779a18d5ee5bd825274ec7d6
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Dec 7 15:50:23 2015 +1100
ctdb-client: Only get capabilities from active nodes
This is used by the recovery daemon to validate the current recovery
master. Don't risk being unable to elect a new master if the current
master is inactive but unresponsive.
Note that this client call is currently not used by any other callers.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Sun Dec 13 03:17:10 CET 2015 on sn-devel-104
commit 36813a42036af906e2a02a90e42fd10aebf3d6a3
Author: Ira Cooper <ira at samba.org>
Date: Fri Dec 11 06:27:17 2015 -0500
vfs_glusterfs: Move vfs_gluster_write and vfs_gluster_pwrite.
Move the functions to a more logical location.
Signed-off-by: Ira Cooper <ira at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Dec 12 01:03:40 CET 2015 on sn-devel-104
commit 8d3b9009e5dd9fe1b55bba92d3d69423eed3c649
Author: Ira Cooper <ira at samba.org>
Date: Fri Dec 11 07:37:53 2015 -0500
vfs_glusterfs: Add white space so vfs_glusterfs_pread_send and vfs_glusterfs_pwrite_send match.
These two functions are basically the same thing, so they should be
formatted the same.
Signed-off-by: Ira Cooper <ira at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 640ecbbcd04e8dcc96dcfae7f22e457df024b6cc
Author: Ira Cooper <ira at samba.org>
Date: Wed Nov 18 11:09:06 2015 -0500
vfs_glusterfs: Fix AIO crash on smb.conf reload.
This fixes an issue where we couldn't handle cancellation properly
so when smb.conf was reloaded we crashed.
Signed-off-by: Ira Cooper <ira at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 79df4caed3b819cc1cd67c4033f3ac700086ab99
Author: Karolin Seeger <kseeger at samba.org>
Date: Fri Dec 11 10:23:28 2015 +0100
docs: Fix typos in man vfs_gpfs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11641
Duplicate "acl map full control" entry in man vfs_gpfs
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit defa49e00c5921ab44fdab53de73918d0732aeda
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 3 18:26:09 2015 +0100
s4-torture: Remove obsolte code in backupkey_heimdal rpc test
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Dec 10 11:54:00 CET 2015 on sn-devel-104
commit 39bd6f06660f1c4daf8020f78a9e66335a5b9425
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 3 18:25:11 2015 +0100
s4-torture: Improve backupkey test to validate the self signed cert
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit eb11fbaaf71310ec4869f1ca64319012503b11fc
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 3 18:21:03 2015 +0100
s4-torture: Add a GnuTLS based backupkey rpc test
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 59c11db03d4c3e0c53b27d685e406de16c52e2a3
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 3 18:10:51 2015 +0100
s4-torture: Rename backupkey test to backupkey_heimdal
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 97765d48f625738135b6cfe9fb55fa9bc6eba5e0
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 3 18:04:02 2015 +0100
s4-rpc_server: Add a GnuTLS based backupkey implementation
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 53e8feeb6ad06c2345936a69b47769d1117e5e59
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 3 17:47:14 2015 +0100
waf: Check for GnuTLS 3.4.7
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 8e096698af8f9fb35fbca5da20c552bf486d2b5e
Author: Andreas Schneider <asn at samba.org>
Date: Wed Dec 9 08:29:45 2015 +0100
s4-rpc-bkrp: Do not set the ca status
Windows doesn't have any CA data set on the certificate.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit e8ce1f247762c74cf1a33414afaaeb30cd9293db
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 3 17:12:05 2015 +0100
s4-rpc_server: Rename dcesrv_backupkey to dcesrv_backupkey_heimdal
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 39ec70862214a9810cbbb63f7e99daecbeed6608
Author: Günther Deschner <gd at samba.org>
Date: Fri Nov 13 11:15:41 2015 +0100
s4-torture: make sure we always verify ndr pull and push of bkrp_exported_RSA_key_pair struct.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 2f16675a2294c8197ad45862c3e8a4fa2061d2e9
Author: Ralph Boehme <slow at samba.org>
Date: Sun May 10 01:39:16 2015 +0200
ping_pong: add -l option
Add a new option -l to check whether POSIX byte range locks are
working. Usage:
node1$ touch /path/to/cluster-fs/FILE
node1$ ./bin/ping_pong -l /path/to/cluster-fs/FILE
Holding lock, press any key to continue...
You should run the same command on another node now.
node2$ ./bin/ping_pong -l /path/to/cluster-fs/FILE
Output can either be:
Holding lock, press any key to continue...
This means POSIX byte range locks are *not* working.
If you see this instead:
file already locked, calling check_lock to tell us who has it locked...:
check_lock failed: lock held: pid='27375', type='1', start='0', len='0'
Working POSIX byte range locks
Congrats, you have a cluster fs with functional byte range locks!
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Dec 10 08:48:38 CET 2015 on sn-devel-104
commit b63e3b9f3e7d50ea128d7e4f675abe8fbadbd69e
Author: Ralph Boehme <slow at samba.org>
Date: Tue Dec 8 12:08:14 2015 +0100
ldb: version 1.1.24
* fix for CVE-2015-5330, bug 11599
* fix for CVE-2015-3223, bug 11325
* move ldb_(un)pack_data into ldb_module.h for testing
* fix installation of _ldb_text.py
* fix propagation of LDB errors through TDB
* fix bug triggered by having an empty message in database during search
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11325
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11599
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11636
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f36cb71c330a52106e36028b3029d952257baf15
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Nov 26 11:17:11 2015 +1300
CVE-2015-5330: ldb_dn_explode: copy strings by length, not terminators
That is, memdup(), not strdup(). The terminators might not be there.
But, we have to make sure we put the terminator on, because we tend to
assume the terminator is there in other places.
Use talloc_set_name_const() on the resulting chunk so talloc_report()
remains unchanged.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11599
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
Pair-programmed-with: Garming Sam <garming at catalyst.net.nz>
Pair-programmed-with: Stefan Metzmacher <metze at samba.org>
Pair-programmed-with: Ralph Boehme <slow at samba.org>
commit 538d305de91e34a2938f5f219f18bf0e1918763f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Nov 24 13:54:09 2015 +1300
CVE-2015-5330: next_codepoint_handle_ext: don't short-circuit UTF16 low bytes
UTF16 contains zero bytes when it is encoding ASCII (for example), so we
can't assume the absense of the 0x80 bit means a one byte encoding. No
current callers use UTF16.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11599
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit a118d4220ed85749c07fb43c1229d9e2fecbea6b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Nov 24 13:49:09 2015 +1300
CVE-2015-5330: strupper_talloc_n_handle(): properly count characters
When a codepoint eats more than one byte we really want to know,
especially if the string is not NUL terminated.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11599
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit ba5dbda6d0174a59d221c45cca52ecd232820d48
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Nov 24 13:47:16 2015 +1300
CVE-2015-5330: Fix handling of unicode near string endings
Until now next_codepoint_ext() and next_codepoint_handle_ext() were
using strnlen(str, 5) to determine how much string they should try to
decode. This ended up looking past the end of the string when it was not
null terminated and the final character looked like a multi-byte encoding.
The fix is to let the caller say how long the string can be.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11599
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 0454b95657846fcecf0f51b6f1194faac02518bd
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Nov 24 13:09:36 2015 +1300
CVE-2015-5330: ldb_dn_escape_value: use known string length, not strlen()
ldb_dn_escape_internal() reports the number of bytes it copied, so
lets use that number, rather than using strlen() and hoping a zero got
in the right place.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11599
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 7f51ec8c4ed9ba1f53d722e44fb6fb3cde933b72
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Nov 24 13:07:23 2015 +1300
CVE-2015-5330: ldb_dn: simplify and fix ldb_dn_escape_internal()
Previously we relied on NUL terminated strings and jumped back and
forth between copying escaped bytes and memcpy()ing un-escaped chunks.
This simple version is easier to reason about and works with
unterminated strings. It may also be faster as it avoids reading the
string twice (first with strcspn, then with memcpy).
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11599
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Pair-programmed-with: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit aa6c27148b9d3f8c1e4fdd5dd46bfecbbd0ca465
Author: Jeremy Allison <jra at samba.org>
Date: Tue Jun 9 14:00:01 2015 -0700
CVE-2015-3223: lib: ldb: Use memmem binary search, not strstr text search.
Values might have embedded zeros.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11325
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit ec504dbf69636a554add1f3d5703dd6c3ad450b8
Author: Jeremy Allison <jra at samba.org>
Date: Tue Jun 9 12:42:10 2015 -0700
CVE-2015-3223: lib: ldb: Cope with canonicalise_fn returning string "", length 0.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11325
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 3c6ea3293c6aac67bc442f47185fd494714e4806
Author: Quentin Gibeaux <qgibeaux at iris-tech.fr>
Date: Thu Oct 29 13:48:27 2015 +0100
lib/param: handle (ignore) substitution variable in smb.conf
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10722
The function handle_include returns false when trying to include
files that have a substitution variable in filename (like %U),
this patch makes handle_include to ignore this case, to make
samba-tool work when there is such include in samba's configuration.
Error was :
root at ubuntu:/usr/local/samba# grep 'include.*%U' etc/smb.conf
include = %U.conf
root at ubuntu:/usr/local/samba# ./bin/samba-tool user list
Can't find include file %U.conf
ERROR(runtime): uncaught exception - Unable to load default file
Signed-off-by: Quentin Gibeaux <qgibeaux at iris-tech.fr>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Dec 9 02:05:30 CET 2015 on sn-devel-104
commit ea6de66b9c6c8f5d7e90c24ff02fe4626801a57c
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 6 11:32:46 2015 +0100
libdns: Small cleanup
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit dfceb51da87f1ebc2b75aaa714729bfbafcb1a2f
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 6 11:31:23 2015 +0100
libdns: Convert dns_udp_request to 0/errno
Replaces 5 calls to unix_to_werror with just one
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 190e2c013b9b478b9e8686afe1c54a81d80130e6
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 6 11:20:24 2015 +0100
libdns: Properly set ENOMEM
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a0fcb7bd80f176319e1c6a3cfc447dd6ce88092f
Author: Volker Lendecke <vl at samba.org>
Date: Sun Dec 6 11:19:46 2015 +0100
libdns: tsocket returns -1 and sets errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 557169d1a0607d606284bdbaab6de930d661a058
Author: Volker Lendecke <vl at samba.org>
Date: Sat Dec 5 18:46:34 2015 +0100
lib: Use GUID_buf_string in discover_dc_dns
One talloc call less..
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9bc3f482981c30c62ba8ceb1c66f25685fcfefd9
Author: Volker Lendecke <vl at samba.org>
Date: Sat Dec 5 13:49:55 2015 +0100
lib: Lift lp_disable_netbios one level
This should fix an error code when neither DS_IS_FLAT_NAME nor
DS_IS_DNS_NAME are specified. If netbios is disabled and the DC
can't be found via DNS we should not return NOT_SUPPORTED but
DOMAIN_CONTROLLER_NOT_FOUND.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7e5b4cd0974fd075bc8cbb408d73336ea7031c7d
Author: Volker Lendecke <vl at samba.org>
Date: Sat Dec 5 13:00:07 2015 +0100
lib: make debug_dsdcinfo_flags static
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2bb0b473c1255152291c3c43f82b1cc45fa83b00
Author: Volker Lendecke <vl at samba.org>
Date: Sat Dec 5 12:59:49 2015 +0100
lib: Avoid a includes.h
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 17bc0fab767e59976c6360739d31aa9ad2febc5b
Author: Jeremy Allison <jra at samba.org>
Date: Mon Dec 7 08:55:27 2015 -0800
Revert "s3: smbd: Tear down global_smbXsrv_client in the correct order."
Wrong fix for the problem that was actually fixed in the dbwrap_rbt
code with commits:
590507951fc514a679f44b8bfdd03c721189c3fa
0f46da08e160e6712e5282af14e1ec4012614fc7
This reverts commit 8024e19b70047865249305bceddd4473d6e60051.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Mon Dec 7 21:09:04 CET 2015 on sn-devel-104
commit fbcf1d2b0f2f50a62fc54cb6b509c3325d6ca54c
Author: Rowland Penny <repenny241155 at gmail.com>
Date: Sat Nov 21 09:16:51 2015 +0000
samba-tool: user create examples show 'add' instead of 'create'
Signed-off-by: Rowland Penny <repenny241155 at gmail.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4735e5f5e35bdff88bf59d56ecf1980cdabc3c83
Author: Rowland Penny <repenny241155 at gmail.com>
Date: Mon Nov 23 18:40:19 2015 +0000
samba-tool: fsmo.py throws an uncaught exception if no
fSMORoleOwner attribute
This will fix bug 11613 where a user got the uncaught exception when trying
to seize an FSMO role that didn't have the required attribute.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11613
Signed-off-by: Rowland Penny <repenny241155 at gmail.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Sun Dec 6 00:33:10 CET 2015 on sn-devel-104
commit dd9b12ad45e0b2d9013c0843c54c306479efc220
Author: Wolfgang Ocker <weo at recco.de>
Date: Fri Dec 4 11:05:30 2015 +0100
ntlm_auth: Add --offline-logon
Signed-off-by: Wolfgang Ocker <weo at recco.de>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Sat Dec 5 01:24:56 CET 2015 on sn-devel-104
commit bd569c36e892b22880e76e761803e94e528e08f0
Author: Christof Schmitt <cs at samba.org>
Date: Thu Dec 3 15:47:24 2015 -0700
docs-xml: Document range parameter for idmap_autorid
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Christof Schmitt <cs at samba.org>
Autobuild-Date(master): Fri Dec 4 22:09:09 CET 2015 on sn-devel-104
commit fe918572cb7330b9413eb88035eb133476d58a99
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Nov 6 16:27:17 2015 +1100
ctdb-ipalloc: Rename top level IP allocation algorithm functions
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Fri Dec 4 12:25:14 CET 2015 on sn-devel-104
commit 821aa24ffdda78eed13397767c3d76869238bf7e
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Nov 6 16:25:32 2015 +1100
ctdb-ipalloc: Rename ctdb_takeover_run_core() to ipalloc()
It just does IP allocation...
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 99abcc108c3c3379230684a81862f7da8e0a0131
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Nov 6 16:20:53 2015 +1100
ctdb-ipalloc: Fold force_rebalance_candidates into IP allocation state
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 13aa583ea46d7d2468ed4e9c58124259b7176fe0
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Nov 6 15:55:07 2015 +1100
ctdb-ipalloc: Fold all IPs list into IP allocation state
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit fb662321557ab0de4df60e8630e332b21b671edf
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Nov 6 13:02:04 2015 +1100
ctdb-ipalloc: Tidy up some of the IP allocation functions
Shorter temporary variables for compactness/readability. "tmp_ip" is
5 characters longer than "t". In each for statement it is used 4
times, so costs 20 characters. Save those extra characters so that
future edits will avoid going over 80 columns.
Tweak whitespace for readability, rewrap some code.
No functional changes.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 5dcc1d7a69b0123fb8490a13a8852e7044e1ad88
Author: Martin Schwenke <martin at meltin.net>
Date: Fri May 22 00:13:48 2015 +1000
ctdb-daemon: Don't delete connection information for released IP
As per the comment:
If the IP address is hosted on this node then remove the connection.
Otherwise this function has been called because the server IP
address has been released to another node and the client has exited.
This means that we should not delete the connection information.
The takeover node processes connections too.
This doesn't matter at the moment, since the empty connection list for
an IP address that has been released will never be pushed to another
node. However, it matters if the connection information is stored in
a real replicated database.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 4261d6e70ad2f03d80ae263a04216e0728139520
Author: Martin Schwenke <martin at meltin.net>
Date: Thu May 21 22:42:13 2015 +1000
ctdb-daemon: Move VNN lookup out of ctdb_remove_tcp_connection()
In a subsequent commit ctdb_takeover_client_destructor_hook() needs to
know the VNN. So just have both callers of
ctdb_remove_tcp_connection() do the lookup and pass in the VNN.
This should cause no change in behaviour.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 473f1a77e1791cbe3a079ba7b20dd85a1797ee61
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Mar 27 15:30:16 2015 +1100
ctdb-daemon: Do not process tickle updates for hosted IP addresses
Tickle list updates are broadcast to all connected nodes and are
accepted even when received on the same node that sent them. This
could actually lead to lost connection information when information
about new connections is received while an update is in-flight.
Instead, return early when the IP is hosted on the current node, since
it is the only one that could have sent the update.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 80c05114210ac78841a34a0e44765166f1501364
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Nov 26 19:30:20 2015 +1100
ctdb-docs: Rewrite event script documentation
Move information about TCP connection tracking and resetting into
ctdb.7.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Pair-programmed-with: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit d7424f97c91618a2077cd6754151ec6a61ee8801
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Sep 2 09:38:04 2015 +1000
ctdb-scripts: Add exportfs cache to NFS Linux kernel callout
exportfs can hang when, for example, DNS is flakey. Given that
exports don't change much, it makes sense to cache them.
Don't try to add error handling when exportfs fails but do print a
warning. Proper error handling can be added separately.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit bd7c94d5ac27174a2bff03e3409127d042b7f26d
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Nov 26 19:31:28 2015 +1100
ctdb-recoverd: Drop function unban_all_nodes()
It hasn't worked since commit cda5f02c7c3491917d831ee23b93278dfaa5c82b
in 2009, which reworked the banning code. Since then
ctdb_control_modflags() has contained a comment saying:
/* we don't let other nodes modify our BANNED status */
Unbanning all nodes originally occurred here when the recovery master
role moved to a new node. The logic could have been meant for the
case when the old recovery master was malfunctioning, so got banned.
If any other nodes had been banned by this recovery master then they
would be unbanned. However, this would also unban the old recovery
master, which is probably suboptimal. The logic would also trigger if
a node was banned for a good reason and then the recovery master was
stopped. So, apart from doing nothing, the logic is too simplistic so
might as well be removed.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit ad6685847b18f63acb27d1bd998f0e757a6302eb
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Jul 29 19:34:23 2015 +1000
ctdb-daemon: Drop handling of ban control sent to unexpected node
The banning code caters for the case where the node specified in the
bantime data is not the node receiving the control. This never
happens. There are 2 places where ctdb_ctrl_set_ban() is called: the
ctdb CLI tool and the recovery daemon. Both pass the same node in the
bantime data that they are sending the control to. There are no plans
to do anything more elaborate, so just delete the handling of this
special case.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit e153501474be47d8a6bdfa0dbf8fbb72ff74e319
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Tue Sep 1 09:54:09 2015 +1200
ldb torture: Test ldb unpacking and printing
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11602
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Autobuild-User(master): Garming Sam <garming at samba.org>
Autobuild-Date(master): Fri Dec 4 09:16:22 CET 2015 on sn-devel-104
commit 5137daa10efe3f1b88dbf01bf6605cc37f4779f0
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Tue Sep 1 09:53:12 2015 +1200
ldb: Move ldb_(un)pack_data into ldb_module.h for testing
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11602
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 60dc26bfe1573265dcbd87b9dd3439f945e57d97
Author: Andreas Schneider <asn at samba.org>
Date: Thu Dec 3 12:07:27 2015 +0100
ldb: Fix installation of _ldb_text.py
_ldb_text.py is installed as part of the ldb package and also if you
compile Samba with the system ldb version. This way we have have the
file twice in the same location and run into file confilcts.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 2a55a0b370affaef0455320ddfd78bae4e413743
Author: Guillaume Gomez <guillaume1.gomez at gmail.com>
Date: Thu Dec 3 16:01:05 2015 +0100
Fix little typo in README file
Reviewed-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit c505076422522f2b61bb7397d8dc56d309ce4570
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Thu Dec 3 16:30:59 2015 +1300
Fix propagation of LDB errors through TDB.
Returning a non-zero value from a tdb_traverse callback indicates that tdb_traverse
should stop traversing the database. This error code IS NOT propagated back to the
caller, so LTDB must record the error otherwise. This patch corrects LTDB for this
misunderstanding.
Naturally exposing these errors changes the behaviour of some tests. This commit fixes
that as well.
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 99b2fd4f5be9dca1ef66c8a8096e3e75fee84a7f
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Wed Nov 18 15:25:20 2015 +1300
ldb: Fix bug triggered by having an empty message in database during search.
Previously if the message had 0 elements, Talloc would reallocate the projected
array to NULL, fooling LDB into thinking that it failed to reallocate. This fix
corrects LDB to be able to handle the case where the message has no attributes
in common with the filter.
Also the realloc call resized the array to the number of elements in the message,
not the number of elements in common with the filter -- it essentially did nothing.
Unlike talloc_realloc, talloc_array always returns a non-null pointer. This would
help protect against possible errors.
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit c118fbc680f84622c12997cf347f3194d532ddbc
Author: Björn Jacke <bj at sernet.de>
Date: Thu May 28 14:55:28 2015 +0200
clitar: cope with functions of older versions of libarchive
the feature of automatic decompression in extract mode is only supported in
libarchive 3, so we use this only when available now.
The changed config checks for that also fix this bug:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11296
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Thu Dec 3 16:09:08 CET 2015 on sn-devel-104
commit f25d09a6eb8274fd62d23def8d494d4af0178bf5
Author: Björn Jacke <bj at sernet.de>
Date: Thu Dec 3 10:23:09 2015 +0100
selftest: fix tar test with Pax format archives
we need to skip PaxHeader pseudo files
Signed-off-by: Bjoern Jacke <bj at sernet.de>
commit 412cefc7c8222ccc77e15099a162f9fb7bb01c57
Author: Volker Lendecke <vl at samba.org>
Date: Wed Dec 2 08:50:02 2015 +0100
client: Fix parameter mixup
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11628
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Dec 2 21:01:14 CET 2015 on sn-devel-104
commit 0583d5b74171cdd018ba22abdf79147e6a53fe04
Author: Ralph Boehme <slow at samba.org>
Date: Sun Nov 29 15:55:43 2015 +0100
vfs: remove posix_flags hack, bump interface version to 34
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Dec 1 23:48:37 CET 2015 on sn-devel-104
commit 0f0693d0fa5fa991bb573525f332eba5ceb6ece6
Author: Ralph Boehme <slow at samba.org>
Date: Sat Nov 28 19:26:47 2015 +0100
s4:torture:vfs_fruit: add a test for POSIX rename
Signed-off-by: Ralph Boehme <slow at samba.org>
commit 1d7bef5a75403f5baec13aa6264dfe763a4b278a
Author: Ralph Boehme <slow at samba.org>
Date: Thu Jan 22 10:07:56 2015 +0100
vfs_fruit: enable POSIX directory rename semantics
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11065
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 89a7394d679b383920d73fef0d178b8f84bc393f
Author: Ralph Boehme <slow at samba.org>
Date: Wed Nov 25 09:12:55 2015 +0100
vfs_fruit: add a flag that tracks whether use of AAPL was negotiated
Add a flag that tracks whether use of AAPL was negotiated, ensuring we
don't enable AAPL features for clients that didn't negotiate it.
Torture test that need AAPL must call the new function enable_aapl().
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11065
Signed-off-by: Ralph Boehme <slow at samba.org>
commit bf1957584e341473edcd5025b7f77766440d408b
Author: Ralph Boehme <slow at samba.org>
Date: Thu Jan 22 10:00:15 2015 +0100
s3:smbd: file_struct: seperate POSIX directory rename cap from POSIX open
We need more fine grained control over which POSIX semantics we'd like
to enable per file handle. Currently POSIX_FLAGS_OPEN is a kitchensink
for all kinds of stuff like:
- POSIX unlink
- POSIX byte-range locks
- POSIX rename
- delayed writetime update
- more...
For CIFS UNIX extensions we use POSIX_FLAGS_ALL so semantics are
preserved. OS X clients will enable POSIX rename via AAPL.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11065
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d698cec1c7e700e57cab46d33df0dde13303b318
Author: Ralph Boehme <slow at samba.org>
Date: Fri Nov 27 18:29:55 2015 +0100
s3:smbd: convert file_struct.posix_open to a bitmap with flags
This is in preperation of a more fine grained control of POSIX behaviour
in the SMB and VFS layers.
Inititally we use an uint8_t for the flags bitmap and add a define
posix_flags as posix_open in order to avoid breaking the VFS ABI.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11065
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d2a0806cbd24f6211b55a5454e2e62fc61a4c4b6
Author: Anoop C S <anoopcs at redhat.com>
Date: Tue Dec 1 17:41:35 2015 +0530
s4:torture/basic: Fix misleading test case names in aliases test
Previously, "QFILEINFO aliases" was running qfsinfo_aliases and
"QFSINFO aliases" was running qfileinfo_aliases. This change
is to make sure that each of them point towards correct test cases.
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Tue Dec 1 20:44:54 CET 2015 on sn-devel-104
commit 632114584d3be0d4660e97a6c9e69e577a7bc1e2
Author: Günther Deschner <gd at samba.org>
Date: Tue Dec 1 14:39:37 2015 +0100
lib/async_req: do not install async_connect_send_test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 3bbd8d3614af641535ab0925303ad07c03c4e094
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 27 18:19:38 2015 +0100
libcli/smb: fix BUFFER_OVERFLOW handling in tstream_smbXcli_np
The special error is not NT_STATUS_BUFFER_TOO_SMALL, but STATUS_BUFFER_OVERFLOW.
Tested using TSTREAM_SMBXCLI_NP_MAX_BUF_SIZE == 20 and running
the following commands against a Windows 2012R2 server:
bin/smbtorture ncacn_np:SERVER[] rpc.lsa-getuser
bin/smbtorture ncacn_np:SERVER[smb2] rpc.lsa-getuser
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11623
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Dec 1 03:42:52 CET 2015 on sn-devel-104
commit 0e8d33fb5ffd6fdb0e503c5ff59e3635bbf10041
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 27 19:10:01 2015 +0100
libcli/smb: correctly handle STATUS_BUFFER_OVERFLOW in smb1cli_readx*
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11623
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 68850f3f56e9b28b298c1bc3a6249f9c26602217
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 27 19:10:01 2015 +0100
libcli/smb: correctly handle STATUS_BUFFER_OVERFLOW in smb2cli_query_info*
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11623
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b47bfce6781ea3be2b85cbef348107eda4f98860
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 27 19:10:01 2015 +0100
libcli/smb: correctly handle STATUS_BUFFER_OVERFLOW in smb2cli_read*
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11623
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 91e12e04fc05a0b09b70ca2986aab9b96a8a035c
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Nov 27 17:31:04 2015 +0100
libcli/smb: make sure we have a body size of 0x31 before dereferencing an ioctl response
Found by valgrind, reported by Noel Power <nopower at suse.com>:
==7913== Invalid read of size 1
==7913== at 0xC4F23EE: smb2cli_ioctl_done (smb2cli_ioctl.c:245)
==7913== by 0x747A744: _tevent_req_notify_callback (tevent_req.c:112)
==7913== by 0x747A817: tevent_req_finish (tevent_req.c:149)
==7913== by 0x747A93C: tevent_req_trigger (tevent_req.c:206)
==7913== by 0x7479B2B: tevent_common_loop_immediate
(tevent_immediate.c:135)
==7913== by 0xA9CB4BE: run_events_poll (events.c:192)
==7913== by 0xA9CBB32: s3_event_loop_once (events.c:303)
==7913== by 0x7478C72: _tevent_loop_once (tevent.c:533)
==7913== by 0x747AACD: tevent_req_poll (tevent_req.c:256)
==7913== by 0x505315D: tevent_req_poll_ntstatus (tevent_ntstatus.c:109)
==7913== by 0xA7201F2: cli_tree_connect (cliconnect.c:2764)
==7913== by 0x165FF7: cm_prepare_connection (winbindd_cm.c:1276)
==7913== Address 0x16ce24ec is 764 bytes inside a block of size 813 alloc'd
==7913== at 0x4C29110: malloc (in
/usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==7913== by 0x768A0C1: __talloc_with_prefix (talloc.c:668)
==7913== by 0x768A27E: _talloc_pool (talloc.c:721)
==7913== by 0x768A41E: _talloc_pooled_object (talloc.c:790)
==7913== by 0x747A594: _tevent_req_create (tevent_req.c:66)
==7913== by 0xCF6E2FA: read_packet_send (async_sock.c:414)
==7913== by 0xCF6EB54: read_smb_send (read_smb.c:54)
==7913== by 0xC4DA146: smbXcli_conn_receive_next (smbXcli_base.c:1027)
==7913== by 0xC4DA02D: smbXcli_req_set_pending (smbXcli_base.c:978)
==7913== by 0xC4DF776: smb2cli_req_compound_submit (smbXcli_base.c:3166)
==7913== by 0xC4DFC1D: smb2cli_req_send (smbXcli_base.c:3268)
==7913== by 0xC4F2210: smb2cli_ioctl_send (smb2cli_ioctl.c:149)
==7913==
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11622
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 58d4e77a85c125106973be54e8229b79fee8ffe6
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 30 21:40:22 2015 +0100
smbd: Fix a comment
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 797be479dd6fc90030438b2364bee0e2d36d3d7c
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 30 16:22:07 2015 +0100
smbd: Simplify a boolean expression
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 49912f21475368f686d726f075042de1bdd0365a
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 30 16:20:58 2015 +0100
smbd: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b3a9b88702c7440c43699255517310ea380a36db
Author: Andreas Schneider <asn at samba.org>
Date: Wed Nov 25 12:35:59 2015 +0100
librpc: Fix a possible array out of bounds access
Reported by gcc 5.1.1.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 87f8bddffee554bc9e385e084741525abd2bab79
Author: Andreas Schneider <asn at samba.org>
Date: Wed Nov 25 12:20:23 2015 +0100
lib: Fix an array subscript is above array bounds error
gcc 5.1.1 complains with:
lib/util/idtree.c:184:15: error: array subscript is above array bounds
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c2de8425d9a33baeb743a611c8169131b975f179
Author: Ralph Boehme <slow at samba.org>
Date: Thu Nov 26 11:10:38 2015 +0100
s3:talloc_dict: fix a SIGBUS when dereferencing unaligned pointers
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Mon Nov 30 22:31:16 CET 2015 on sn-devel-104
commit a84eed532549c1dbad43f963838bc5f13c4fe68d
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Nov 28 10:32:05 2015 +0100
lib/param: add a fixed unified lpcfg_string_{free,set,set_upper}() infrastructure
This reduces the memory footprint of empty string options.
smbd -d1 -i with 1400 shares in smb.conf under x64 valgrind massif before this
patch has 7,703,392 bytes peak memory consumption and after this patch
3,321,200 bytes.
This fixes a regression introduced by commit
2dd7c890792cf12049ec13b88aa4e9de23035f9d.
BUG:
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11625
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Nov 30 17:41:28 CET 2015 on sn-devel-104
commit 0548fc52f99f3f222b4e58f587dd07f92be6707c
Author: Garming Sam <garming at catalyst.net.nz>
Date: Mon Nov 30 14:39:38 2015 +1300
docs: change pdbedit --set-nt-hash to be consistent
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Garming Sam <garming at samba.org>
Autobuild-Date(master): Mon Nov 30 06:54:11 CET 2015 on sn-devel-104
commit 93689174ff02c1f408a42e366e300c2b8881d39d
Author: Garming Sam <garming at catalyst.net.nz>
Date: Mon Nov 30 14:18:55 2015 +1300
passdb: Change ABI version to 0.24.2
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 576b92abc32ab74a256fb42820219be428bfae03
Author: Garming Sam <garming at catalyst.net.nz>
Date: Mon Nov 30 14:24:06 2015 +1300
pdb: add a blackbox test for setting password with hash
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1c9117746b616fcb8ab251834888b57c4a1c29bf
Author: Alberto Maria Fiaschi <alberto.fiaschi at estar.toscana.it>
Date: Wed Jun 10 15:26:58 2015 +0200
Add --set-nt-hash option to pdbedit to update user password from nt-hash hexstring.
Useful to take in sync password from other repository.
(Modify MASK_USER_GOOD to include new flag BIT_PWSETNTHASH)
pdbedit -vw show also password hashes .
Split pdb_set_plaintext_passwd in two function:
pdb_set_plaintext_passwd and pdb_update_history.
pdb_update_history update password history and is call from
pdb_set_plaintext_passwd.
Signed-off-by: Alberto Maria Fiaschi <alberto.fiaschi at estar.toscana.it>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit bb9f13ab4165f150e01a88ddcc51605a7c176f5d
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 25 00:13:17 2015 +0100
s3:torture: add traverse testing to LOCAL-RBTREE
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11375
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11394
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Fri Nov 27 13:16:59 CET 2015 on sn-devel-104
commit 0f46da08e160e6712e5282af14e1ec4012614fc7
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 25 09:22:08 2015 +0100
dbwrap_rbt: fix modifying the db during traverse
We delete and add of records rebalace the tree, but our
traverse code doesn't handle that and skips records
randomly.
We maintain records in a linked list for now
in addition to the rbtree and use that list during
traverse.
This add a bit overhead, but at least it works reliable.
If someone finds a way to do reliable traverse with the
rebalanced tree, we can replace this commit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11375
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11394
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 590507951fc514a679f44b8bfdd03c721189c3fa
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 25 09:22:08 2015 +0100
dbwrap_rbt: add nested traverse protection
Multiple dbwrap_traverse_read() calls are possible.
store() and delete() on a fetch locked record
are rejected during dbwrap_traverse_read().
A dbwrap_traverse() within a dbwrap_traverse_read()
behaves like a dbwrap_traverse_read().
Nested dbwrap_traverse() calls are not possible.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11375
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11394
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit f3d1fc1d06822a951a2a3eeb5aa53748b9b5b299
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Nov 25 10:17:34 2015 +0100
dbwrap_rbt: use talloc_zero_size() instead of a partial ZERO_STRUCT()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11375
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11394
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 257ec9c6e28b1ddc32bd554ff8259f8a067dd44e
Author: Karolin Seeger <kseeger at samba.org>
Date: Thu Nov 26 11:28:34 2015 +0100
docs: Fix some typos in the idmap backend section.
Signed-off-by: Karolin Seeger <kseeger at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Nov 26 14:47:17 CET 2015 on sn-devel-104
commit 1ee7053180057ea526870182b5619a206b4d103b
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Nov 6 17:07:35 2015 +1100
ctdb-protocol: Fix marshalling for struct ctdb_rec_data
If the header is specified, then the datalen should be incremented.
There are two ways of marshalling ctdb_rec_data:
1. ctdb_rec_data->header is NULL and ctdb_rec_data->data embeds both
the header and the value. Used in recovery for push/pull of records.
2. ctdb_rec_data->header is not NULL and ctdb_rec_data->data embeds
only the value. Used everywhere else.
In both cases, the wire format includes the header and the value.
There is nothing in the wire format to inform the unmarshalling code
whether to extract the header separately or not.
In the current code the header is extracted depending on whether the
header argument to the extractor routine is NULL or not. This is insane
and highly error-prone.
So in the new API, unmarshalling code never extracts the header. If the
caller requires the header, then it can be extracted separately using
special function ctdb_ltdb_header_extract().
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Wed Nov 25 13:21:48 CET 2015 on sn-devel-104
commit 8ded8e81b0f0da8a3ea79d63d575b6493e4a87f3
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Nov 10 18:29:39 2015 +1100
ctdb-protocol: Add API to extract ctdb_ltdb_header from TDB_DATA
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5f5b3193a32dbbe2030f69a6a6c44a51af9901aa
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Nov 6 14:27:33 2015 +1100
ctdb-protocol: Fix marshalling of struct ctdb_public_ip_list
There can be 0 public addresses.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5498b71b3d544fcc76cc69e476f4cd5cc45ae5cd
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Nov 6 13:06:26 2015 +1100
ctdb-protocol: Fix marshalling of struct ctdb_addr_info
ctdb_addr_info->iface can be NULL.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 587817774a2747c8494fcab3e7edf78dbcfa50ae
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Nov 5 17:08:46 2015 +1100
ctdb-protocol: Do not expect a reply for SHUTDOWN control
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3fc6a895489a9990405f86b0c01dfb7dec8eb4ef
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Nov 9 15:58:56 2015 +1100
ctdb-protocol: Add marshalling for TDB_DATA
This is required when ctdb client wants to send arbitrary data as part
of CTDB_REQ_MESSAGE.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3d84399f5ec12954db9638627fd1d747cc4acb71
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Nov 2 16:24:15 2015 +1100
ctdb-protocol: Add utility function ctdb_sock_addr_to_string
This is a duplicate function to ctdb_addr_to_str, but ctdb-util cannot
be linked with the code using new API mainly because it code in ctdb-util
requires struct ctdb_context.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit af13e56271d4352a28352a89b651d569afda2314
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Nov 2 16:03:29 2015 +1100
ctdb-system: Use protocol/protocol.h instead of ctdb_private.h
Since this code does not need any private structures defined in
ctdb_private.h, protocol/protocol.h should suffice.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2bad37db9832baa6201eca737c84f7c0976449eb
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Nov 2 17:54:45 2015 +1100
ctdb-include: Make client header self contained
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 28fb8993e0b2645449223aa1f40cf410063a6de6
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Nov 2 16:01:13 2015 +1100
ctdb-include: Make protocol headers self contained
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8024e19b70047865249305bceddd4473d6e60051
Author: Jeremy Allison <jra at samba.org>
Date: Tue Nov 24 12:00:10 2015 -0800
s3: smbd: Tear down global_smbXsrv_client in the correct order.
The talloc heirarchy looks like this:
global_smbXsrv_client
| |
V V
session_table sconn
|
V
session (destructor references global_smbXsrv_client->sconn)
So don't free global_smbXsrv_client->sconn before the
session destructor fires.
------------------------------------------------
6 <signal handler called>
7 0x00007f47ba82da1a in file_close_user (sconn=0x0, vuid=1584077283) at ../source3/smbd/files.c:250
8 0x00007f47ba922a74 in smbXsrv_session_logoff (session=0x7f47be8bbf80) at ../source3/smbd/smbXsrv_session.c:1404
9 0x00007f47ba921912 in smbXsrv_session_destructor (session=0x7f47be8bbf80) at ../source3/smbd/smbXsrv_session.c:1068
10 0x00007f47b784e2fc in _talloc_free_internal () from /usr/lib/libtalloc.so.2
11 0x00007f47b784f495 in _talloc_free_children_internal () from /usr/lib/libtalloc.so.2
12 0x00007f47b784e49f in _talloc_free_internal () from /usr/lib/libtalloc.so.2
13 0x00007f47b784f495 in _talloc_free_children_internal () from /usr/lib/libtalloc.so.2
14 0x00007f47b784e49f in _talloc_free_internal () from /usr/lib/libtalloc.so.2
15 0x00007f47b784f88e in _talloc_free () from /usr/lib/libtalloc.so.2
16 0x00007f47ba92b2f1 in exit_server_common (how=SERVER_EXIT_NORMAL, reason=0x0) at ../source3/smbd/server_exit.c:234
------------------------------------------------
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11375
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Nov 25 03:40:46 CET 2015 on sn-devel-104
commit 2b0df3788aaadcf907de15a6b6a518244c59aa81
Author: Jeremy Allison <jra at samba.org>
Date: Tue Nov 24 08:45:50 2015 -0800
s3: docs: Fix "strict rename" doc to match code.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11065
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Nov 24 23:47:19 CET 2015 on sn-devel-104
commit 16f202871ca850bec87e0ec243644b2c20266c44
Author: Jeremy Allison <jra at samba.org>
Date: Tue Nov 24 08:43:14 2015 -0800
s3: smbd: Change semantics of strict rename to search the file open db.
Without strict rename just look in local process. POSIX renames are
already dealt with above.
Documentation change to follow.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11065
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 158200611271bd80d80280c88578dfd5380f8fd0
Author: Jeremy Allison <jra at samba.org>
Date: Mon Nov 23 14:00:56 2015 -0800
s3: smbd: have_file_open_below() fails to enumerate open files below an open directory handle.
There are three issues:
1). The memcmp checking that the open file path has the open
directory path as its parent compares using the wrong length
(it uses the full open file path which will never compare as
the same).
2). The files_below_forall() function doesn't fill in the
callback function or callback data when calling share_mode_forall(),
leading to a crash (which we never saw, as the previous issue (1)
meant the callback function would never be invoked).
3). When invoking the callback function from files_below_forall_fn()
we were passing in the wrong private_data pointer (needs to be
the one from the state, not the private_data passed into
files_below_forall_fn()).
Found when running the torture test smb2.rename.rename_dir_openfile
when fixing bug #11065.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11615
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Nov 24 19:36:20 CET 2015 on sn-devel-104
commit 9883599fc94fbf7a490fd773e6661613bf4d6ba8
Author: Michael Adam <obnox at samba.org>
Date: Tue Nov 24 11:30:05 2015 +0100
smbd:dir: remove an extra empty line in files_below_forall()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Nov 24 15:59:47 CET 2015 on sn-devel-104
commit 3b2ae078a56975951997822060e899c497acf62b
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 19 01:55:43 2015 +0100
build:wafsamba: Ensure that check_group_ordering can be overridden
Group ordering verifications are performed by default in Waf 1.8,
so this method will be redundant. The purpose of this change is
to make it easier to disable check_group_ordering as it contains
code that is very specific to Waf 1.5.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Nov 24 08:03:29 CET 2015 on sn-devel-104
commit 735cf0683dab129950e2ccddea4d1182bbe3bd4e
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 19 01:44:43 2015 +0100
build:wafsamba: Ensure that target clones get a different name
Changing the 'target' attribute results in a different file name,
which is visibly necessary. Yet the 'name' attribute should also
be modified even if invisible as it is used to query targets
(uselib for example). Failing to do so results in errors in Waf 1.8.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit cc4f7e393300d6a2ebcf19afbe0d9cb195320418
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 19 01:36:47 2015 +0100
build:wafsamba: Specify whether node objects or flat lists in ant_glob
The changes enable the ant_glob declaration to be compatible with
more recent versions of Waf.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 22386dc39673f66de2dd57596447acf3c6c00ef7
Author: Uri Simchoni <uri at samba.org>
Date: Sun Nov 15 13:34:03 2015 +0200
samba-tool: replace use of os.popen
The netcmd/domain.py module uses os.popen() on user-supplied
parameters. This opens up the way to code injection.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11601
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Mon Nov 23 22:19:34 CET 2015 on sn-devel-104
commit e6f88c1451f8843fca9ca361cd2dbdf3e77ff47c
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 6 14:05:15 2015 +0200
libads: Fix picky const warning with krb5_set_password_using_ccache
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Mon Nov 23 18:20:31 CET 2015 on sn-devel-104
commit 0733ce3c6ed1e8d97690c9ec80c2768a05690dfd
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 6 13:25:49 2015 +0200
gensec: Fix picky unused variable errors
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit ab0cbf9bbac6c7a9450f26e2eeb4f8e794db8d89
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 6 13:24:41 2015 +0200
auth: Fix picky const warnings in gssapi_pac
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit e0504a80dcf70ec9da0e8fa9f2d5bd7f042468f6
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 6 13:03:41 2015 +0200
s4-auth: Fix picky unused variable warning
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit e9e306b1d57e9d9c40cd37d3fbb981606ca87223
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 6 13:03:19 2015 +0200
krb5_wrap: Fix picky const compiler warnings
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit bf10446a69b0f328441ab334a8e35ad14c3d47e8
Author: Andreas Schneider <asn at samba.org>
Date: Mon May 12 16:45:55 2014 +0200
selftest: Fix Samba::bindir_path() with a valid directory.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 8aab4426a5235c60d3febabad075985e1f9777f0
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 20 14:00:54 2015 +0200
dbwrap_tdb: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Mon Nov 23 15:16:19 CET 2015 on sn-devel-104
commit 33084a1c2ce74464e9b6b3e8241a7265c1cfbb66
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Nov 3 16:41:55 2015 +1100
ctdb-ipalloc: Drop unnecessary struct ctdb_ipflags
This can be easily decomposed into 2 separate arrays.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Mon Nov 23 05:34:55 CET 2015 on sn-devel-104
commit e73496d0dc2b8485a808f57d149856baf8a93b72
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Nov 3 16:36:34 2015 +1100
ctdb-ipalloc: Move memory allocation into ipalloc_state_init()
This puts all of the memory allocation for ipalloc_state into its init
function. This also simplifies the code because
set_ipflags_internal() can no longer fail because it no longer
allocates memory.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 47c5e5aa14328a4cbe147dd1ef77f6fd9c69fd5c
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Nov 3 16:30:23 2015 +1100
ctdb-ipalloc: Have set_ipflags_internal() set ipalloc_state->ipflags
This is cleaner than returning ipflags and assigning them into
ipalloc_state afterwards.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit dd163e26d90ad8de064496cae6849c0fe83abffc
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Nov 2 16:50:05 2015 +1100
ctdb-ipalloc: Fold IP flags into IP allocation state
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 22a930a0454ef9b98d7d004f65fb15359910a3f6
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Nov 3 15:29:30 2015 +1100
ctdb-ipalloc: Use number of nodes from IP allocation state
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 13162419be0f01ea67749390b03466f97fa2df80
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Nov 3 15:26:34 2015 +1100
ctdb-ipalloc: Allocate memory off IP allocation state
Instead of local or passed temporary contexts.
This has the side effect of making ipalloc_state available inside the
modified functions, making future use of ipalloc_state simpler.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 921e17d81ebbcc5ec4531925f108cff37e562845
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 30 11:47:22 2015 +1100
ctdb-ipalloc: Add error handling to IP allocation
The only likely failure is out of memory, so just return boolean
value.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 25c10936eb5a800e7f0a5874a4093581ac5da9af
Author: Martin Schwenke <martin at meltin.net>
Date: Sat Oct 31 06:48:23 2015 +1100
ctdb-ipalloc: Drop CTDB context argument from set_ipflags_internal()
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 0111773310ea1ef63ab0d7b256f29aa7e27b545b
Author: Rowland Penny <repenny241155 at gmail.com>
Date: Mon Nov 16 16:22:31 2015 +0000
samba-tool:provision: fix bug 11600
If you join a second DC after changing the name of
the 'Default Domain Policy' or 'Default Domain Controllers
Policy' the join will fail as the search is hardcoded to
these names, this fix changes the search to the objects name.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11600
Signed-off-by: Rowland Penny <repenny241155 at gmail.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Sat Nov 21 04:44:58 CET 2015 on sn-devel-104
commit 8fdda6fa96df35e02ac8ed1f7add46efc528683e
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Nov 19 08:35:17 2015 +1100
ctdb-scripts: Drop creation of database directories
These should be created elsewhere. If not then something is wrong, so
don't hide the problem.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Fri Nov 20 04:40:26 CET 2015 on sn-devel-104
commit 5b7bb6056b366a2bd834dfb09d2a37009ae38c29
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Oct 29 21:08:07 2015 +1100
ctdb-ipalloc: ctdb_takeover_run_core() takes ipalloc_state
As do the functions called below it. They no longer need a CTDB
context.
create_merged_ip_list() now takes both a CTDB context and an
ipalloc_state.
Drop ipalloc_state from CTDB context. So the substitution in the
code is:
ctdb->ipalloc_state -> ipalloc_state
Tweak the test code to match.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 5fba874a2edd3b892f3a3c5670971b9bbe8afa81
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Oct 29 20:46:54 2015 +1100
ctdb-ipalloc: Tidy up create_merged_ip_list()
Simplify with TALLOC_FREE() and fix some whitespace.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 837483c8d3f8c44f9709074932a9dd7ebfac90ce
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 21:17:47 2015 +1100
ctdb-ipalloc: Move IP list creation out to ctdb_takeover_run()
For various reasons create_merged_ip_list() needs a CTDB context.
This is difficult to resolve now for a few reasons, including:
* The ip_tree needs somewhere to live.
It isn't very useful in its current form. However, in the future
real remote IP monitoring will probably be added back, so leave it
around.
* It uses node flags from the ctdb_node structure.
This could be changed by putting a node map into ipalloc_state
and referencing that.
For now, it is easier to move it out to where there will be a CTDB
context available for the forseeable future. ctdb_takeover_run() will
need one as long as the current client interface is used.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit cc1637b17c9ae89bcc00d95f9cdfd00f67c88bc3
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Oct 29 19:53:25 2015 +1100
ctdb-ipalloc: Add no_ip_failback to ipalloc_state
The IP allocation algorithms need the value of this tunable, so copy
it to avoid needing the CTDB context.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 47ddd623581477bf0a40bd8330dfaf4d8f551752
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Oct 29 19:41:10 2015 +1100
ctdb-ipalloc: New enum ipalloc_algorithm in ipalloc_state
Algorithm-related tunables from the CTDB context no longer need to be
accessed in the allocation logic.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit cfa0ffe78073f9e3a014bb127fb9a4b7ad95fceb
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Oct 29 16:49:44 2015 +1100
ctdb-ipalloc: Move IP allocation state into its own struct
Most of the IP allocation code does not need a CTDB context. However,
temporarily hang this off the CTDB context and make only the changes
relating to known/available IP address. This makes those logic
changes obvious without burying them in function type changes.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit d7739d8a7f2d72c5cf6d77272d11f5dd859b6010
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 22:59:18 2015 +1100
ctdb-ipalloc: node_ip_coverage() doesn't need CTDB context
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit d451bbaee2e025d4135f686c0f220d6337dbf38e
Author: Uri Simchoni <uri at samba.org>
Date: Tue Nov 17 23:14:36 2015 +0200
selftest: add test for force user and well-known primary group
Add a test for connecting to a share with a "force user" whos
primary unix gid maps to a well-known alias.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11608
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Nov 19 23:20:36 CET 2015 on sn-devel-104
commit d8717a038ef82caf05fff611c7cf92aecc436563
Author: Uri Simchoni <uri at samba.org>
Date: Tue Nov 17 23:05:10 2015 +0200
auth: consistent handling of well-known alias as primary gid
When a local user has its primary group id mapped to a well-known
alias or a builtin group, smbd accepts logins of such a user, but
fails tree-connects to shares with a "force user" set to this user
with an error of NT_STATUS_INVALID_SID.
This fix causes the connect to succeed and the NT token to resemble
the token that would have been created in a login.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11608
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 42b7d48f76189b1e138f5cac6489a4d018598c87
Author: Uri Simchoni <uri at samba.org>
Date: Tue Nov 17 21:43:44 2015 +0200
auth: remove a line that has no effect
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11608
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7e9aaecec552ca53c50fc0c731419af467f76a00
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 19 17:00:49 2015 +0100
winbind: Don't crash on invalid idmap configs
We should not leave NULL in idmap_domains[]. This will lead to NULL
ptr deferences in idmap_find_domain().
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11612
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Nov 19 20:16:44 CET 2015 on sn-devel-104
commit 5036c6e7447b7ad53886c759a7a3f5c29ae57779
Author: Thomas Nagy <tnagy at waf.io>
Date: Sat Nov 14 15:23:27 2015 +0100
build:wafsamba: remove check_orphaned_targets
The function check_orphaned_targets is not used and has
no specification, so it can be removed safely.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Nov 19 13:10:53 CET 2015 on sn-devel-104
commit 155eeac5ac9db6742b51ba9da57ef6eb0a796aed
Author: Volker Lendecke <vl at samba.org>
Date: Wed Nov 18 13:13:57 2015 +0100
lib: Fix memalign_array overflow protection
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Nov 19 10:05:08 CET 2015 on sn-devel-104
commit 69e427ecee84777906b46ddbf63a7d0bb3b8ed39
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 16 16:23:10 2015 +0100
idl: Some CC can't find indented #defines
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 12b9b770283c47f307e4ea7a8683762a25b35de5
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 16 16:11:48 2015 +0100
idl: Avoid // style comments
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 5f6c4fa4860f794d25f1fcc2e557ca81cbe90183
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jun 30 15:46:21 2014 +0200
libreplace: Only check for malloc.h if needed
OpenBSD complains that malloc.h is deprecated on every gcc invocation.
That hides a lot of real warnings. malloc and friends nowadays are
typically defined in stdlib.h, only check there.
We need memalign. On OpenBSD this does not exist, so libreplace replaces
it. The wscript test in libreplace only checks whether memalign can
link. Unfortunately in glibc memalign comes from malloc.h.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit b64f24971c5930ff382af6f69ab1fd84b4024fbf
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jun 30 15:15:37 2014 +0200
libreplace: Put the malloc.h check on a line of its own
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 4dfa4edd1bf3cca42deec514e30e6962c6794647
Author: Volker Lendecke <vl at samba.org>
Date: Mon Jun 30 13:52:02 2014 +0200
libreplace: Only check malloc.h once
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit bf06a5166ed29e82c4efdb86cf2634f424c29931
Author: Jelmer Vernooij <jelmer at jelmer.uk>
Date: Wed Nov 18 02:59:37 2015 +0000
Set LD_LIBRARY_PATH during tests.
Without this, tests fail ir libtevent is not installed on the system.
Signed-Off-By: Jelmer Vernooij <jelmer at jelmer.uk>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Nov 18 21:40:26 CET 2015 on sn-devel-104
commit 39d0a81ed87c58836335ec10af22b36c9961f91e
Author: Jeremy Allison <jra at samba.org>
Date: Tue Nov 17 09:13:41 2015 -0800
lib: tevent: Whitespace cleanup.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Nov 18 15:54:03 CET 2015 on sn-devel-104
commit 2be3dd1407eabe3df360ede2eab178848e34733c
Author: Jeremy Allison <jra at samba.org>
Date: Tue Nov 17 10:28:50 2015 -0800
lib: tevent: Fix bug in poll backend - poll_event_loop_poll()
If the (pfd->revents & POLLNVAL) case is triggered,
we do DLIST_REMOVE(ev->fd_events, fde); and then
use fde->next in the loop above.
Save off fde->next for loop interation before
this so we can't use a deleted ->next value.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit d9677894b7aa2248e1884ab9e21667879bf1e3c4
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Nov 17 14:57:44 2015 +1100
ctdb-scripts: Fix CTDB_DBDIR=tmpfs support
Various scripts (including debug_locks.sh, 00.ctdb, 05.system) need
CTDB_DBDIR to point to the right place... but it doesn't.
Move the rewriting of CTDB_DBDIR to loadconfig() so that it happens
for all scripts. Have this code set internal variable
CTDB_DBDIR_TMPFS_OPTIONS so that ctdbd_wrapper can do the mount.
This loses the generality that was present in dbdir_tmpfs_start() but
it wasn't being used anyway. If it is needed in the future then it
will be in the git history.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Wed Nov 18 11:51:54 CET 2015 on sn-devel-104
commit 3968e33acf6695558da93b368fc45fe7ac0a4bb0
Author: Christof Schmitt <cs at samba.org>
Date: Wed Sep 23 16:11:51 2015 -0700
ctdb: Remove unused ctdb_set_process_name
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Wed Nov 18 07:12:50 CET 2015 on sn-devel-104
commit 03b27bd13915b3ed4befe39216f62c15eb82dcf9
Author: Christof Schmitt <cs at samba.org>
Date: Wed Sep 23 16:10:59 2015 -0700
ctdb: Use prctl_set_comment from lib/util
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 9ec09385902d70e4f3d54b14781b2de858f83c97
Author: Christof Schmitt <cs at samba.org>
Date: Wed Sep 23 16:02:27 2015 -0700
lib/util: Move util_process from util to util-core
Make the common prctl_set_comment function available to both ctdb
builds.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit fd05d617a8860e6ed2db90c0396fdca9c15ef4a3
Author: Christof Schmitt <cs at samba.org>
Date: Wed Oct 21 12:04:47 2015 -0700
libcli/smb: Use helper function for finding session
This removes some duplicated code.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Nov 18 04:04:17 CET 2015 on sn-devel-104
commit 8f9bf74fbfc15cae10d4cf1249280f82e7410fab
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 15:19:31 2015 +0100
smbd: Simplify check_access()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Nov 17 22:58:10 CET 2015 on sn-devel-104
commit c2d5fdb629ecdeaaa284fdbe69e9d061b7f835a2
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 15:13:41 2015 +0100
smbd: Use check_access_fsp where appropriate
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c056daf7abc63569fad90b47e02e38acfebfe985
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 15:10:42 2015 +0100
smbd: Factor out check_access_fsp() from check_access()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c8485ddbac397f50c68f6d76468d5c7679da9082
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 14:57:50 2015 +0100
smbd: Refactor check_access()
This is a micro-patch to make the next ones just obvious
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b8467dc4923a9efb905fc1e8db3c3029766cdc59
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 13:49:30 2015 +0100
smbd: Early return from dos_mode_debug_print
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b367dbc7bda1d0c33b2b8aba9a6e07c01c0a84d8
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 13:44:30 2015 +0100
smbd: Add hex value to dos_mode_debug_print
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0f5c98fac90c6aca0d082687b12657e4acf58e87
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 13:43:10 2015 +0100
smbd: Use dos_mode_debug_print in get_ea_dos_attribute
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 313986bb7521da354bd3beb32bfc289e37c06550
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 13:41:29 2015 +0100
smbd: Use dos_mode_debug_print in dos_mode_from_sbuf
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 053cf16a3bd7c9c167a2cff9b56576fb94a50cc6
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 13:37:14 2015 +0100
smbd: Use dos_mode_debug_print in dos_mode_msdfs
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 89deffb65a251e612e615074525009957123172d
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 17 13:21:13 2015 +0100
smbd: Streamline dos_mode_debug_print
One line per flag is a bit overkill
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5943f92d2a58473f0526bd564dead78e1528b5be
Author: Andreas Schneider <asn at samba.org>
Date: Wed Nov 11 11:49:12 2015 +0100
s4-backupkey: Don't use deprecated data structures
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Nov 17 19:52:33 CET 2015 on sn-devel-104
commit f4da06803b07de76ed26355b17f81dbdfd1dc926
Author: Andreas Schneider <asn at samba.org>
Date: Thu Nov 12 11:35:39 2015 +0100
s4-torture: Rename issuer unique id in backupkey test
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3de59437c3195f61281fb765b3c944258a259d1d
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 13 14:14:10 2015 +0100
s3-vfs_snapper: Fix a possible use without init warning
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f7e2399926a0c6531acaa8f4567b6fa67f69c6de
Author: Andreas Schneider <asn at samba.org>
Date: Fri Nov 13 13:40:25 2015 +0100
s4-param: Make sure newname is not used uninitialized
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b486398d06b1c5d82a1e9728d757c79ccc401875
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 16 08:11:20 2015 +0100
smbd: Move a message_send_all to the cleanupd
message_send_all traverses serverid.tdb, which can be expensive
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Nov 16 17:55:36 CET 2015 on sn-devel-104
commit de6fe2a1dd6ab03b1c369b61da17fded72305b2d
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 16 08:08:46 2015 +0100
smbd: Move cleanupd revalidate to a separate fn
Simple preparation for the next patch...
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit bbeabd346de1e339b1cafbad03d892ac48b3cb25
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 7 20:18:52 2015 +0100
smbd: Move brl_validate to the cleanupd
This walks brlock.tdb, which can be time-consuming.
This adds a new includes.h include. It's too much of a pain for me now to
make locking/proto.h clean to include on its own.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 14fc9018aa8abfd3255f0f3a1b2b5541e8a9dc61
Author: Volker Lendecke <vl at samba.org>
Date: Fri Nov 6 17:01:02 2015 +0100
smbd: Move serverid_deregister() to the cleanupd
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 99833c94288a99d9f106252227842fe991763d56
Author: Volker Lendecke <vl at samba.org>
Date: Fri Nov 6 15:32:46 2015 +0100
smbd: Move messaging_cleanup() to the cleanupd
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 1dddba5f173c5db288957ceb448b19c56163b240
Author: Volker Lendecke <vl at samba.org>
Date: Fri Nov 6 15:21:59 2015 +0100
smbd: Move smbprofile_cleanup() to the cleanupd
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit b4b4fd0ba0f838cc30d7c331dae33335015096f7
Author: Volker Lendecke <vl at samba.org>
Date: Fri Nov 6 14:55:35 2015 +0100
smbprofile: Add dst pid to smbprofile_cleanup
The consolidation will soon be done by a separate process. We need to
avoid the getpid() call in smbprofile_cleanup().
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit e3e0a295c3fc25391260a8bb7d7d29137f7129fa
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 2 12:47:13 2015 +0100
smbd: Implement a cleanup daemon
We do way too much stuff in the parent smbd in remove_child_pid(). In
particular accessing ctdbd is not a good idea when ctdbd is stuck in something.
We've had a case where smbd exited itself with "ctdb timeout" being set to 60
seconds. ctdb was just stuck doing recoveries, and the parent smbd was sitting
in serverid_exists trying to retrieve a record for a child that had exited. Not
good.
This daemon sits there as parent->cleanupd and receives MSG_SMB_NOTIFY_CLEANUP
messages that hold the serverid and exit status of a former child. The next
commits will step by step empty remove_child_pid in the parent and move the
tasks to the helper.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit db99742d8b15cc1c48421a4720a43dff72c6ba1b
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 12 00:27:31 2015 +0100
build:wafsamba: Waf 1.8 compatible declaration of 'mandatory' configuration tests
The configuration tests raise exceptions by default in later Waf versions,
but the samba tests do not specify whether the errors should be raised or
not. This changes lifts the ambiguity.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Nov 16 14:50:39 CET 2015 on sn-devel-104
commit 7c0575d7ba29d79d8d287a862d6c88a4c5e65631
Author: Thomas Nagy <tnagy at waf.io>
Date: Sun Nov 8 18:50:55 2015 +0100
build:wafsamba: Install named.conf only once
The wildcard *.conf already lists named.conf. Adding files
more than once will cause unnecessary rebuilds and raise
errors in later Waf versions.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit cfe8becb9e62b9e15119107d186628c784a3d38c
Author: Thomas Nagy <tnagy at waf.io>
Date: Sat Nov 7 00:57:36 2015 +0100
build:wafsamba: Replace Options.is_install by bld.is_install
Options.is_install is a deprecated module variable that is more
verbose than bld.is_install and complicates the Waf 1.8 upgrade.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 44bf7c2a12e0bd806552f8cbe0b013a5d07e0218
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 27 16:43:07 2015 +1100
ctdb-recoverd: Factor out recovery master validation
Starting to untangle cluster management, database recovery and public
IP allocation. This is a non-trivial subset of the cluster management
code that runs in the recovery daemon on all nodes.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Mon Nov 16 11:47:45 CET 2015 on sn-devel-104
commit e44957fc8ba67e90f5ded77c6e9ae59ad59b42a0
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 27 15:09:33 2015 +1100
ctdb-recmaster: Update capabilities before calling first election
Capabilities are used when computing an election result so having them
up-to-date seems like a good idea.
Also update several instances of an ambiguous comment.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit c5e50a474b6ddac05cab0116da42c62a615c6c79
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 27 14:35:09 2015 +1100
ctdb-recoverd: Move VNN map retrieval to where it is needed
The VNN map is only needed on the recovery master, so no need for all
recovery daemons to retrieve it.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit d1f996a50f1da36e7046fe28cdb97285e7cf00a5
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 27 14:32:48 2015 +1100
ctdb-recoverd: Drop explicit check for recovery lock
This is already handled in update_recovery_lock(), which is called
immediately before.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 1499f3e301db856d10e481adf5be9b01999a08e4
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 23 16:00:55 2015 +1100
ctdb-recoverd: Simplify using TALLOC_FREE()
The only non-obvious part here is dropping the setting of the nodemap
local variable to NULL. If the following control succeeds then it is
set, otherwise return and it doesn't matter.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 050e64b6478fb17e3c69ba24cf68f630da9f691a
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 23 15:27:12 2015 +1100
ctdb-recoverd: Clarify that recmaster is being set on the current node
That is, using CTDB_CURRENT_NODE makes this more obvious.
Also fix incorrect error messages.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 0833e478c36761b546be5f9ceadac81573825b22
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 23 15:05:08 2015 +1100
ctdb-recoverd: Do not sanity check recovery master with local daemon
Each recovery daemon knows who the recmaster is and is in sync with
its local daemon. The recovery master is running this check so do not
bother checking with its local daemon - both agree that it is the
recovery master.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit d8decd0b1d6446ab079b41e4b8d99e88b34c6e6d
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 23 15:33:01 2015 +1100
ctdb-recoverd: Don't retrieve recovery master from local daemon
The recovery daemon already knows which node is the master. This
relies on rec->recmaster being correctly initialised and correctly set
during elections.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit e90cab70739cc7c39600c065389f7bdad6038031
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Nov 10 13:54:47 2015 +1100
ctdb-recoverd: Explicitly set initial recovery master to unknown
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 018077f3b024b4d2862a8c1ae6758b88b7889b3e
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Oct 22 21:54:58 2015 +1100
ctdb-recoverd: Do not set recovery master during recovery
Recovery should not do cluster management functions. Setting the
recovery master should only be done via an election.
Main loop will determine if recovery master is inconsistent across the
cluster and force an election if necessary.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 4b37cc7cf659bec33c8a4c1bb9d5b3eaccc7c9e5
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 23 14:32:41 2015 +1100
ctdb-recoverd: Have recovery daemon remember election result
The recovery daemon pushes knowledge of recovery master election
progress/result to local daemon. It then retrieves that information
again.
Instead, have the recovery daemon reliably track election
progress/result in rec->recmaster so it doesn't need to be retrieved.
Be careful to maintain consistency by only doing this when the local
daemon has been updated.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 6f8837528f43519a98d82aa85424c1e145dc98ee
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 21 16:19:00 2015 +1100
ctdb-recoverd: Clarify recovery master validation logic
There can be no holes in the nodemap. Even if a node has been deleted
it will take a slot in the nodemap. The only exception is that the
nodemap shrinks if nodes are deleted from the end. That should never
include the master because a node should be shutdown before being
deleted, and an election should already have take place.
To avoid walking off the end of the nodemap nodes array just confirm
that the master node's PNN is a valid index into the array. No need
to walk through the nodemap.
After this, in this section of the code j is now invalid. So use the
master's PNN to index into the nodemap. This is safe.
In the process, clean up some log messages to avoid saying "Force
reelection". It's just an "election".
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 74fa62c685069425e6e15783a0eb290e0778ce65
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Nov 13 15:23:14 2015 +1100
WHATSNEW: Document CTDB tunable change
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 9166c30a41997b8d94222abe551053dacd2ca0fa
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 17:03:01 2015 +1100
ctdb-daemon: Rename EventScriptTimeoutCount to MonitorTimeoutCount
This only applies to monitor events so renaming clarifies this.
Note that this change is not backward compatible. Users with
CTDB_SET_EventScriptTimeoutCount=<n>
in their configuration will get failures when starting CTDB but the
cause will be clearly logged.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 55ad4d80d491af5964429c5a6ac65ac515309060
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 16:51:59 2015 +1100
ctdb-daemon: Move script timeout count into monitor state
It is only used by the monitoring code.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 0d5db1c0072cf56904ab34aded73a13dc78a4153
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 16:42:41 2015 +1100
ctdb-daemon: Reset script timeout count in monitor code
This is the only place it is used.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit a33b50d07f10b3541dc6f6c8148416bb95871f8c
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 16:39:18 2015 +1100
ctdb-daemon: Do not bother printing script timeout count
It is only updated for monitor events, so it is meaningless here.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 134ede80e8165c4a1fe8a660c56bbd0e751d7565
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 27 15:18:25 2015 +1100
ctdb-doc: Correct documentation for tunables for script timeout
* The defaults for EventScriptTimeout and EventScriptTimeoutCount are
wrong.
* EventScriptTimeout is the total time for all enabled scripts that
are run for an event, not a single event script.
* EventScriptTimeoutCount only applies to monitor events.
* EventScriptUnhealthyOnTimeout is obsolete, so remove it.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit bda2d9de2b188a3f3804ed198e9b59ffec5ef066
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 22:15:00 2015 +1100
ctdb-ipalloc: Don't consider runstates in the IP takeover code
Checking runstates is unnecessary now that nodes that are not RUNNING
will return no available IP addresses. I have no idea why I didn't do
it this way originally.
Tweak the test code to cope with this.
Note that this is a backward-incompatible change. If new and old
versions of CTDB are running together in a cluster and a new node
takes over as recovery master then old nodes will be able to host
public IP addresses before they are in RUNNING runstate. This is
mitigated by the bias towards recovery master stability in elections.
If it is important that nodes do not host IPs until they are RUNNING
then do not restart nodes running the old version.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 9ea318847a3ec2a18ce897833b8a5fcf6d8c4205
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 22:11:33 2015 +1100
ctdb-ipalloc: Check for available IPs, not runstate, in takeover run
The available IPs list is now only non-empty for nodes that are in
RUNNING runstate. So, to avoid running the IP allocation algorithm
when there are no available available IPs, explicitly check for
available IPs rather than checking runstates.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 66574c9fda26ee72f04426b2f7c96fe617332620
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 20:41:08 2015 +1100
ctdb-ipalloc: A VNN can only host IPs if node is in RUNNING runstate
This will allow wonderful simplification (i.e. removal) of some of the
runstate checking in the takeover run code.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 6b4a961d02aeb4e7d5b8eea0b5323919a9ed64fb
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 16:52:30 2015 +1100
ctdb-build: Remove ctdb-common-util subsystem
Include system_util.c in ctdb-system subsystem.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Mon Nov 16 03:51:36 CET 2015 on sn-devel-104
commit 0fffdc1901a7773d60111ad74aadec34741403e1
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 16:43:44 2015 +1100
ctdb-daemon: Remove unused ctdb_logging.[ch]
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 27bc80cf6a6b3a3c27b5b4553bfb529bd83a1da2
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 16:40:41 2015 +1100
ctdb-tool: Use new debug level API
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9c16aec72f0f371a7aa76147f6ab202006326ff0
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 15:19:41 2015 +1100
ctdb-common: Use new debug level API
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8b1bf86dc52f7f5812cba7e49dc3dbc5defb5ba6
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 16:33:43 2015 +1100
ctdb-tests: Build in common/logging.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 17577550d803eb6313d1a8f43a854b0cce523466
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 16:00:23 2015 +1100
ctdb-tests: Replace ctdb_logging.h with common/logging.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 921d815da0f0e3a3520cf1bef082188d09fae1b9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 15:22:52 2015 +1100
ctdb-transport: Replace ctdb_logging.h with common/logging.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f50db5cba526182dafe73ddf7cebc21357ddcb2e
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 15:41:10 2015 +1100
ctdb-server: Replace ctdb_logging.h with common/logging.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3f314154fe0474cfe716e1d8e66e87ecf2404fe4
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 15:19:17 2015 +1100
ctdb-common: Replace ctdb_logging.h with common/logging.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7258e1d9c9815e62129a34acf4bedfe54743ea18
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 15:17:56 2015 +1100
ctdb-client: Replace ctdb_logging.h with common/logging.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 145da0b68fb668f53d79f3aa302120b26f2e5ba6
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 14:43:56 2015 +1100
ctdb-system: Replace ctdb_logging.h with common/logging.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7e376f0dbc2047f44060c81aff8de059160a0f4e
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 15:10:38 2015 +1100
ctdb-logging: Remove duplicate definitions
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit dd7d2a400e59e661c217d4fa6f93d814651dabc8
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Nov 13 12:03:43 2015 +1100
ctdb-tests: Update test to set numeric debug levels
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3d8c1ca80aab82823b7cf9360cdc742e80a86e8f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Nov 12 09:15:08 2015 +1100
ctdb-logging: Allow numeric specification of debug level
This makes the function compatible with parse_debug().
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2ddc5274ba9d171d4693d994168eb7072c911568
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 16:17:51 2015 +1100
ctdb-logging: Allow sub-string matching for debug level strings
This allows for backward compatibility with the current code where
DEBUG_ERR corresponds to "ERR".
Fix the test that relies on "ERR" instead of "ERROR".
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 64ef27b27f7d343707d30902c70ae63540547d69
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Nov 12 09:14:32 2015 +1100
ctdb-logging: Fix for loop condition
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8534408e03a11f96b681601c886eccd0d60d6b60
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 14:45:08 2015 +1100
ctdb-logging: Add APIs to convert debug_level to and from integer
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c170cdbc75c86af6b4c566966b60f172d677c8a6
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 14:31:41 2015 +1100
ctdb-logging: Move debug_extra definition to server/ctdb_logging.c
This variable is used for adding a prefix to log entries from various
child processes.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7dd2f1c35a916ae5eff8f1bf77b6f7feff802b81
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 14:26:53 2015 +1100
ctdb-daemon: Move ctdb_fork.c to server
These functions are only used in the ctdb daemon code.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 848da801527828979751c0c42b701bd99ff674e1
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Nov 11 14:18:51 2015 +1100
ctdb-daemon: Move switch_from_server_to_client() to ctdb_daemon.c
This function can only called from ctdb daemon.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit eee4af5c76be9b8ab0cee4e0721eeb438d0a8f5d
Author: Christof Schmitt <cs at samba.org>
Date: Fri Nov 13 11:47:32 2015 -0700
WHATSNEW: Add async SMB2 flush and new aio parameter
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Nov 14 00:39:17 CET 2015 on sn-devel-104
commit 90469a3d214b1ee0990fb2f7efb7d4d21ef28e4a
Author: Christof Schmitt <cs at samba.org>
Date: Fri Nov 13 11:46:33 2015 -0700
docs: Update doc for 'strict sync' parameter for async SMB2 flush
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c4be0b7ff4f1d2a3e5c1664e4735f35381f78a5e
Author: Jeremy Allison <jra at samba.org>
Date: Thu Nov 12 13:23:30 2015 -0800
s3: smbd: Change aio_pending_size static variable to a new "aio max threads" smb.conf parameter.
Removes accessor functions as now this parameter is set
under user control in smb.conf. Default is 100.
Note that this doesn't limit the number of outstanding
aio requests, it just causes them to go onto the
pthreadpool queue.
Now we need to prioritize pthreadpool pipe replies
ahead of incoming SMB2 requests, but that's a patch
for another day.
Based on ideas from Volker.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c83ecbb51bddb1642eb4ee10c24f6b721af66c45
Author: Jeremy Allison <jra at samba.org>
Date: Thu Nov 12 13:07:21 2015 -0800
s3: smbd: Remove checks causing fallback to sync on pread/pwrite/fsync.
Rely on pthreadpool queueing instead of falling back.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5327c6004997e6b3cf235a1a292cc8f2ea1ff698
Author: Jeremy Allison <jra at samba.org>
Date: Thu Nov 12 12:44:50 2015 -0800
s3: smbd: Remove --with-aio-support. We no longer would ever prefer POSIX-RT aio, use pthread_aio instead.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e05d69f0ba26fbca7d558d22984fd9daa6ff27da
Author: Michael Adam <obnox at samba.org>
Date: Fri Nov 13 16:30:33 2015 +0100
docs: correct the name of the idmap config group of parameters
"idmap config DOMAIN : OPTION" is the pattern used.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Nov 13 19:55:33 CET 2015 on sn-devel-104
commit 0aca421136049cf56f978e4f75cd185deafa459e
Author: Volker Lendecke <vl at samba.org>
Date: Sat Nov 7 20:18:32 2015 +0100
ctdb: Fix the O3 developer build
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Nov 13 12:42:22 CET 2015 on sn-devel-104
commit f9b92cfea69eb10b61ae2f99540097c202fb82bf
Author: Christof Schmitt <cs at samba.org>
Date: Wed Nov 11 13:28:09 2015 -0700
selftest: Use strict sync = yes
This enables the codepaths calling fsync for FLUSH requests during
selftest.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Christof Schmitt <cs at samba.org>
Autobuild-Date(master): Fri Nov 13 04:47:00 CET 2015 on sn-devel-104
commit c737fae5f79fa76118a914940e59408fd329037a
Author: Christof Schmitt <cs at samba.org>
Date: Wed Nov 11 13:31:15 2015 -0700
smbd: Issue fsync for SMB2 FLUSH asynchronously
SMB2 FLUSH mainly calls fsync and there is already code in place to
handle fsync asynchronously, so use the asynchronous code path for SMB2
FLUSH. This avoids a SMB2 FLUSH stalling other requests processing.
Signed-off-by: Christof Schmitt <cs at samba.org>
Signed-off-by: Jeremy Allison <jra at samba.org>
commit 17f4110c47d53148979a3617e80b29fe3bd41efc
Author: Jeremy Allison <jra at samba.org>
Date: Thu Nov 12 09:25:41 2015 -0800
s3: smbd: Remove outstanding_aio_calls from globals.
Access via functions only.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Christof Schmitt <cs at samab.org>
commit 803938260dadef63d2685860bb63a700c95424e0
Author: Jeremy Allison <jra at samba.org>
Date: Thu Nov 12 09:20:05 2015 -0800
s3: smbd: Remove aio_pending_size from globals.
Access via functions only.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Christof Schmitt <cs at samba.org>
commit 0137105c862073f5a4422bcd424a51de33e58d37
Author: Günther Deschner <gd at samba.org>
Date: Thu Sep 24 20:45:04 2015 +0200
s4-auth: Fix some debugging and crash in error cases
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Nov 13 01:43:36 CET 2015 on sn-devel-104
commit c4267ce124427fb856f13b636af10ec0314d5b79
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 12 21:09:35 2015 +0100
smbd: Remove dead code
94f0716fff has removed the dcelogin_atmost_once variable.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0886637a5eb4a5244631070abfa96e31e2610685
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 20:04:41 2015 +1100
ctdb-recoverd: Reload remote IPs as part of takeover run
This is currently done before each IP takeover run, so just factor it
in.
ctdb_reload_remote_public_ips() becomes static.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Thu Nov 12 09:28:45 CET 2015 on sn-devel-104
commit 8cdae3ade65780ebdd975ff9660bddf3d475cb82
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Oct 29 11:50:24 2015 +1100
ctdb-recoverd: Move ctdb_reload_remote_public_ips() to ctdb_takeover.c
This will help to untangle known and available public IP lists from
the CTDB context.
verify_remote_ip_allocation() needs a forward declaration.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit c37e3c05b0e522da27c3e1d16533ebdd382d7ea3
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 20:33:29 2015 +1100
ctdb-recoverd: Remote IP validation can't cause a takeover run
Remote IP validation is only called when a takeover run is about to
happen anyway, so don't bother flagging one. Given that a takeover
run isn't being triggered, also drop the test that checks if takeover
runs are disabled. These are the only uses of the rec argument, so
drop it.
One possible further simplification would be to remove this function
because it doesn't accomplish anything. However, it is worth leaving
it as a reminder that remote IP validation should be done properly at
some time in the future.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 8b7b153cf640c311d46f5e0c3297aaf8fa4149d6
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Oct 29 10:42:29 2015 +1100
ctdb-recoverd: Drop culprit argument from ctdb_reload_remote_public_ips()
It is only used by the caller to print a message that includes the
culprit. However, ctdb_reload_remote_public_ips() already prints
perfectly good messages and they include the culprit.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 1d7d5abd31fbe73cea048de4b673a12cdddd108c
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 19:56:02 2015 +1100
ctdb-recoverd: Trigger takeover run after rebalance timeout
No need to do it immediately. It will happen in less than a second.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit a7e8687b6d6035faffff5d26dc737589ccdd7dd9
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 19:52:37 2015 +1100
ctdb-recoverd: Remove unnecessary assignments of need_takeover_run
do_takeover_run() unsets this if it succeeds.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit d608862c5a72fb491330623ae75b011fe85610fc
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 28 19:47:03 2015 +1100
ctdb-recoverd: Do not run recovery-related events around IP takeover
This is not a recovery, so do not run "startrecovery and "recovered"
events. There are other IP takeover runs where these are not run.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit bd0befa529c88173926bb8739d19ce9639d32bdf
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Nov 9 15:32:58 2015 +1100
ctdb-recoverd: Drop some sanity checking in local IP verification
The recovery start/end times used in the checks at the top of
verify_local_ip_allocation() are set by the START_RECOVERY and
END_RECOVERY controls. A couple of takeover runs escape the checks
because they were added later and are not surrounded by these
controls.
Recovery and IP allocation need to be untangled from each other, so
recovery-related events should not be relied on for IP allocation.
This means the solution is not to add these where they are "missing".
The concern that the checks are addressing is to avoid local IP
verification when IP addresses are in a state of flux. Takeover runs
on non-master nodes are already disabled while a takeover run is in
progress, so local IP verification is already skipped in that case.
The other case is the master node, which will be busy with the
takeover run, rather than running main_loop().
The other issue is races. verify_local_ip_allocation() takes a
non-zero amount of time to fetch IP addresses from the local CTDB
daemon and during this time a recovery or takeover run can start, but
a takeover run can still be triggered. The current tests do not stop
this.
Apart from all of this, with most reasonable public IP address
configurations, an extra takeover run will be a no-op so is not a
cause for concern.
It is safe to drop these checks.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit ceb0988e14c5b3f0050ba94d9f97fcbd4fcfae8b
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 23 16:03:38 2015 +1100
ctdb-recoverd: Simplify using TALLOC_FREE()
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 8936281bcc9bef19ede99146475dd867ed5d3873
Author: Richard Sharpe <rsharpe at samba.org>
Date: Tue Nov 10 20:50:18 2015 -0800
gss: samba member server returns incorrect error code with some versions of krb5
As per Simo's comments in https://bugzilla.redhat.com/show_bug.cgi?id=1279249
we need Samba to return the correct thing to the client when gss_accept_sec_context
returns a token along with an error.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11592
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Nov 12 01:44:08 CET 2015 on sn-devel-104
commit 6e6436a2f050dd204218868e673a3396ad758ad1
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Nov 10 10:14:56 2015 +1100
ctdb-build: Don't try to install unavailable prebuilt manpages
Commit 3ddd35142ab86de431d00f93de2fb6a2b371317d tries to
unconditionally install pre-built manpages if xsltproc is unavailable.
However, these only exist in a tarball, not in a git repo. That can
make the installation fail.
If xsltproc does not exist then check for each pre-built manpage at
configure time. This should cover all the possible cases.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Wed Nov 11 06:23:48 CET 2015 on sn-devel-104
commit 85a2a2c9119d75b7bd502c46d1fec85d5f7ba943
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Nov 10 14:49:30 2015 +1100
ctdb-tests: Try to connect few times before failing in comm_client_test
cunit/comm_test_002.sh requires that the comm_server_test is started
before comm_client_test. Since comm_server_test is started in background,
it's possible for comm_client_test to run before comm_server_test has
bound to the unix domain socket.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 42d5b06d7ab2226598e98ebf3df94723f2f9b093
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 9 10:14:26 2015 +0100
vfs: Remove smb_traffic_analyzer
Holger Hetterich told me in a personal email that he does not have
time to care about this project anymore and that he is fine to
remove it from Samba.
Why the removal? It contains homegrown crypto that would need to
be thoroughly audited and/or fixed. And if it's neither maintained
nor widely used I'd rather have it removed.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Nov 11 00:23:35 CET 2015 on sn-devel-104
commit 2d6dca8797afb02083c86ec7d8d220fa6a60d333
Author: Ralph Boehme <slow at samba.org>
Date: Tue Nov 10 17:59:09 2015 +0100
smbstatus: always initialize a messaing context
Recent changes (b542ce7db394de3023b95288b0c40c4533c02cb1) to serverid
code made serverid_exists() call messaging_dgm_get_unique() which means
we depend on a valid messaging context that initializes
global_dgm_context.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c701e46431782fd7843fb25256418f6690a09da9
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 10 09:56:56 2015 +0100
lib: Fix CID 1338432 Unchecked return value
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 609a92362e89c9b0a0f35d7488ae788382d893f1
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 9 10:01:59 2015 +0100
dns_server: Fix a clang warning
clang complains that '\0' is converted to a NULL pointer. This seems
to work fine, so make this pointer explicitly NULL. If instead we
need a "" here, we could of course do that too.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Nov 10 10:13:18 CET 2015 on sn-devel-104
commit 4749aec513e4409d4c6a0f0cb4e6121175a1c50d
Author: Amitay Isaacs <amitay at gmail.com>
Date: Sat Nov 7 23:21:34 2015 +1100
s3-build: Avoid setting CTDB specific include path
The include paths for CTDB are set via ctdb/wscript.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Mon Nov 9 14:31:24 CET 2015 on sn-devel-104
commit be670ef0103878d8d939de5972b567c4db404082
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 23 14:04:04 2015 +1100
ctdb-scripts: Add support for CTDB_DBDIR in tmpfs
The tmpfs is mounted and unmounted by ctdbd_wrapper. Format is
CTDB_DBDIR=tmpfs:<tmpfs-options>. The only default for the tmpfs is
mode=700 - to override, specify a different value in <tmpfs-options>.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Nov 9 10:58:32 CET 2015 on sn-devel-104
commit f05c6d32cce334d29e373f1e74f0b52cab14409d
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 23 14:04:04 2015 +1100
ctdb-scripts: Improve CTDB wrapper shutdown code
This will make it easier to run things after CTDB is stopped.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3a7c73ff7ba8d66b5e0430c188e8ba0657252cea
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Oct 30 13:06:24 2015 +1100
ctdb-tests: Fix "setreclock" test
1. Waiting for generation to change isn't enough. It now changes
early in recovery and reclock might not have been set on all nodes.
So wait until recovery is complete before checking reclock.
2. Use onnode -p when setting reclock on all nodes. That will cause
it to be set quickly on all nodes, to avoid the situation where the
recovery master is the late in the list and resets the reclock on
earlier nodes back to the old value. This shouldn't matter if (1)
is done but it can't hurt.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 1ed577efa0e99ee55d78a261ffb9c6497701173f
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Nov 9 11:35:03 2015 +1100
ctdb-tests: Fix the name of the "setreclock" test
It currently claims to test "setrecmaster".
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit af26da1e479c05090023e7066a1dfb0806e14ea4
Author: Volker Lendecke <vl at samba.org>
Date: Sun Nov 8 11:34:40 2015 +0100
vfs_acl_*: Only sha256 needed
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit dee23e94722e9b5243619711ae10d38820c4fd66
Author: Volker Lendecke <vl at samba.org>
Date: Sun Nov 8 10:43:59 2015 +0100
vfs_cap: Fix a warning
clang warns about increased alignment cast. talloc_size does align properly.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9b2a4b1fb1d4291cc0b1e9a9f8078eb15f4b8d68
Author: Volker Lendecke <vl at samba.org>
Date: Mon Nov 2 12:46:35 2015 +0100
lib: messages.h references struct iovec
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c66592bcf75e205fcf8c3c09897f5db4f71824d6
Author: Volker Lendecke <vl at samba.org>
Date: Fri Nov 6 16:59:44 2015 +0100
lib: Move some procid functions out of util.c
Including proto.h just for pid_to_procid() is a pain...
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f0bfd61556f9fce1e7543e96e1c14b730226ee4c
Author: Volker Lendecke <vl at samba.org>
Date: Fri Nov 6 15:39:45 2015 +0100
lib: Increase a debuglevel
We do this every time when a process exits. If that process has
properly cleaned up after itself, we spit out this message.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c526f5f28cac1aeda4cbe4ac2d70c0f2e9a65a4d
Author: Volker Lendecke <vl at samba.org>
Date: Sun Nov 8 10:16:04 2015 +0100
vfs_fruit: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c315fce17ef11a23c24fc92b7475ac3a3ac55032
Author: Mathieu Parent <math.parent at gmail.com>
Date: Sun Jul 26 23:02:57 2015 +0200
Fix various spelling errors
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Nov 6 13:43:45 CET 2015 on sn-devel-104
commit f3033a1943462f98e994f095ed5805be27acadd0
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 5 19:00:18 2015 +0100
build:wafsamba: Remove the print_commands code from the build scripts
Using the print_commands tool makes it easier to upgrade to Waf 1.8.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Uri Simchoni uri at samba.org
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 7c5a92a1043d5990d415014f081c8cd560fd3caa
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 5 18:57:14 2015 +0100
build:wafsamba: Include the print_commands.py tool from upstream
The tool 'print_commands' is provided by default in Waf 1.8. Keeping
the old code in Samba complicates the Waf upgrade.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Uri Simchoni uri at samba.org
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 963ccff806cf58898cdc8808138453d95df41b01
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 5 02:06:42 2015 +0100
build:wafsamba: Remove samba_utils.runonce
The decorator order matters in the following:
"""
@runonce
@conf
function()
"""
First, the @conf decorator binds the function to the configuration context
and then returns the same function. The @runonce decorator then takes
the output function and replaces it by another that performs caching. This new
function remains in the current script and is never bound to the configuration
context, so caching never occurs.
The declaration would have been correct if written like this:
"""
@conf
@runonce
function()
"""
Yet the decorator @run_once does not keep the function name (__name__), so the
annotation with @conf would fail. The straightforward approach is to remove
all the incorrect @runonce occurrences.
Besides that, the function Utils.run_once is already present in the Waf library,
and is sufficient for the current needs of the Samba code (it caches only the
first argument). Therefore samba_utils.runonce can be safely replaced by
Utils.run_once, which is also present in Waf 1.8.
Note: at runtime, only SETUP_BUILD_GROUPS seems to actually use caching.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Uri Simchoni uri at samba.org
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1f4f081b7aa7cbb8c9f92f0c5e39a870a5c1c6a3
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 5 00:41:38 2015 +0100
build:wafsamba: Remove the unnecessary intltool module dependency
The 'intltool' module is completely unnecessary for the build process,
and it does not exist in waf 1.8
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Uri Simchoni uri at samba.org
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 973197909887ccd38eb5b5aaf48235dea09fdc81
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 5 00:39:25 2015 +0100
build:wafsamba: Moved samba_before_apply_obj_vars to samba_utils
The function samba_before_apply_obj_vars serves to remove system paths,
it is certainly not an optimisation and has no place in that module.
By optimisation, we mean that the build process could run without it.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Uri Simchoni uri at samba.org
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 40a2deb52099c6149a072c545010093d11b0b1a7
Author: Thomas Nagy <tnagy at waf.io>
Date: Thu Nov 5 00:34:03 2015 +0100
build:wafsamba: Removed unnecessary and misleading variables
There is no 'allow_duplicates' attribute anywhere.
The function 'check_duplicate_sources' always returns True unless it raises an exception
There is no list of source files to use
The variable 'tstart' is unused
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Uri Simchoni uri at samba.org
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit bae51eb24eaf40a3bd46420945b3a5bcca2b3099
Author: Richard Sharpe <rsharpe at samba.org>
Date: Thu Nov 5 15:30:18 2015 -0800
Fix up some aesthetics ... ie, align things as they were intended.
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Nov 6 10:36:37 CET 2015 on sn-devel-104
commit 278c257b6897ac507027781cdbea8201afeef543
Author: Alexander Bokovoy <ab at samba.org>
Date: Wed Nov 4 17:58:42 2015 +0200
spec files: remove pam_smbpass
Remove remaining pam_smbpass options from RHEL spec file templates.
Signed-off-by: Alexander Bokovoy <ab at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 21d0082169bb61417aa7a564050f930808764ac8
Author: Alexander Bokovoy <ab at samba.org>
Date: Wed Nov 4 17:50:15 2015 +0200
source3/wscript: remove pam_smbpass option as it was removed
pam_smbpass module was removed in 3c00e8d76a2ef6194a8ce522c15853e5b8e9262b
but corresponding configure option wasn't removed.
Signed-off-by: Alexander Bokovoy <ab at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c6ae462a020648c851fe6f6724ae9cf32c9d0ab8
Author: Michael Adam <obnox at samba.org>
Date: Thu Nov 5 16:43:34 2015 +0100
doc: fix a typo in the smb.conf manpage, explanation of idmap config
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Fri Nov 6 06:26:34 CET 2015 on sn-devel-104
commit 23663b9719877e1c87af258aba1ab1c69eb5768b
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 5 13:22:33 2015 +0100
vfs_gpfs: Re-enable share modes
is_ntfs_default_stream_smb_fname returns false for a NULL stream name, so for
streamless filenames we do not set gpfs share modes without this patch.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11243
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Nov 6 03:21:01 CET 2015 on sn-devel-104
commit 2515ad78a75dd19a5147410db29b16bfcbbe71bd
Author: Volker Lendecke <vl at samba.org>
Date: Thu Nov 5 13:35:23 2015 +0100
vfs_gpfs: Fix the build with -Werror=declaration-after-statement
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11243
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ce8068e70b11a3ce5634c56f43a035713c5ea2ed
Author: Noel Power <noel.power at suse.com>
Date: Thu Oct 29 11:11:00 2015 +0000
remove many valgrind errors for base.lock test
mostly "Conditional jump or move depends on uninitialised value" &
"Use of uninitialised value of size 8" errors, suspect this is
related to compiler padding for the struct
Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Nov 6 00:16:53 CET 2015 on sn-devel-104
commit 7ade51901381507beaeac92e9b0d2f0d424123a9
Author: Noel Power <noel.power at suse.com>
Date: Wed Oct 28 21:17:42 2015 +0000
fix uninitialised read in process_host_announce
Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 17482d52160acc869af9f7a2029d5b595d33a12d
Author: Noel Power <noel.power at suse.com>
Date: Wed Oct 28 19:53:49 2015 +0000
fix writev(vector[...]) points to uninitialised bytes in call_trans2findnext
Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 0f2f8a4f772ff22d00a9e87dafa97a431af8f6da
Author: Noel Power <noel.power at suse.com>
Date: Wed Oct 28 17:08:28 2015 +0000
fix 'Invalid read of size 1' in reply_search
Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 9b2aba1b7aa7386dfc64bcefafa83374b6525354
Author: Noel Power <noel.power at suse.com>
Date: Wed Oct 28 15:42:06 2015 +0000
fix writev(vector[...]) points to uninitialised bytes in call_trans2findfirst
Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 8a40da8184c7b441af3cb3de8253f57704c23c2e
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 6 22:59:26 2015 +0200
ldb: version 1.1.23
* Test improvements
* Improved python3 bindings
* Minor build fixes
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Nov 5 21:11:35 CET 2015 on sn-devel-104
commit 0d36d6d84271f97df82a1f0c9c6c6412833575be
Author: Petr Viktorin <pviktori at redhat.com>
Date: Fri Aug 21 10:22:22 2015 +0200
pyldb: Improve test coverage
Add tests for:
- ldb.Dn.{get,set}_{extended_,}component_{name,value}
- ldb.Dn.{get,set}_rdn_{name,value}
- ldb.Dn.get_casefold
- ldb.Dn.get_linearized
- ldb.Dn.canonical_str
Add negative test for Dn.__contains__
Add a helper function to register a dummy DN extension for testing.
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit dd7baa2ae2f98d5c1e82fa97f223925025da5ca0
Author: Petr Viktorin <pviktori at redhat.com>
Date: Fri Aug 21 10:10:28 2015 +0200
pyldb: Fixes and Python3 compat for Dn component accessors
Use "s#"/"z#" argument specifiers in set_component and
set_extended_component instead of converting strings manually.
(Under Python 3, This means both text strings and bytes are accepted.)
Raise error on set_component(None), instead of crashing.
Return text strings from get_{extended}_component under Python 3.
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a4d9c87cedeacbf3b4bbb5214a5b76e0def03540
Author: Petr Viktorin <pviktori at redhat.com>
Date: Fri Aug 21 10:07:17 2015 +0200
pyldb: Prevent segfault when first module is NULL
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2a29e36e4fc72e7ac460aafbbcf88e0106fb0cf6
Author: Petr Viktorin <pviktori at redhat.com>
Date: Fri Aug 14 12:43:41 2015 +0200
ldb: Build for two Python versions at once
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e95838591b7d5f66ffde248022136f23eed5bc33
Author: Petr Viktorin <pviktori at redhat.com>
Date: Wed Jul 29 12:45:43 2015 +0200
pyldb: Adapt tests to Python 3
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d584d5ee2af98cb4874d1a91e3bc092c5941d34b
Author: Petr Viktorin <pviktori at redhat.com>
Date: Tue Jun 9 17:44:40 2015 +0200
pyldb: Split text/byte strings for compatibility with Python 3
Compatibility with Python 2, and backwards compatibility on Python 2,
is kept.
Under Python 3, DNs, attribute names, filters, controls are always text
(unicode) strings, encoded to/from UTF-8 for storage.
Attribute values are byte strings.
When creating DNs and attribute values, both text and bytes are accepted.
This allows creating messages from homogeneous dicts.
LDB Messages and MessageElements have a .text attribute, which offers
a text view on the contents: any value retrieved from it will be a text
string. The wrapper is implemented in a new Python module.
Thanks to Stefan Metzmacher for const warning fixes
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0b384f60ddc0d1844f5953a974eb9266ebbdd7bb
Author: Petr Viktorin <pviktori at redhat.com>
Date: Wed Jun 10 10:21:24 2015 +0200
pyldb: Modernize test suite
This gets rid of deprecation warnings for the old method names.
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit b509cbd8fcc7faedf8b66305d68b1cf58c834396
Author: Petr Viktorin <pviktori at redhat.com>
Date: Tue Jun 9 10:36:26 2015 +0200
pyldb: Add Python 3 compatibility (except strings)
- Use a macro for adding constants to module
(This also ensures that the Python constants have the same
name as the C ones. One existing misspelling is retained.)
- Use new module initialization for Python 3
- Use rich comparison for ldb objects
- Prepare tests for Python 3
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a04cfaa179248f4483d4201acb05f02f75130047
Author: Petr Viktorin <pviktori at redhat.com>
Date: Wed Jun 10 15:40:34 2015 +0200
pyldb: DECREF old debug function when resetting it
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2e298c131ec3b9e2b4f17fb21536b1d1f7eece73
Author: Petr Viktorin <pviktori at redhat.com>
Date: Wed Jun 10 15:41:57 2015 +0200
pyldb: Don't use the internal macro PyObject_REPR
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7935796c4849568948be31d0c00cb0c68828b017
Author: Petr Viktorin <pviktori at redhat.com>
Date: Thu Jun 11 10:16:48 2015 +0200
pyldb: Properly increase refcount of returned values
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c54fc3f2b6479a5c48d801626fb01f68da6894c7
Author: Petr Viktorin <pviktori at redhat.com>
Date: Mon Jun 8 14:17:12 2015 +0200
ldb: Run the Python testsuite
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9884a8fa58ffc8ddff0977c069aedda3beb6415f
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Aug 24 15:47:51 2015 +0200
tevent: version 0.9.26
* New tevent_thread_proxy API
* Minor build fixes
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 68077c617b0a456baea56349fbf502307318c487
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jul 22 11:52:06 2015 -0700
lib: tevent: docs: Add tutorial on thread usage.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Ralph Boehme <slow at samba.org>
commit a132320b4c434ae9c2188377951d092f7309e63c
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jul 24 09:27:21 2015 -0700
lib: tevent: tests: Add a second thread test that does request/reply.
Both tests run cleanly with valgrind --tool=drd and
valgrind --tool=helgrind
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Ralph Boehme <slow at samba.org>
commit 187aebb25b970a3679a72109def8e8b85622722e
Author: Jeremy Allison <jra at samba.org>
Date: Fri Jul 24 08:50:31 2015 -0700
lib: tevent: Initial test of tevent threaded context code.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Ralph Boehme <slow at samba.org>
commit 49bddd8e4756ef52b05b850aec4864749fcf31cb
Author: Jeremy Allison <jra at samba.org>
Date: Thu Jul 23 15:23:50 2015 -0700
lib: tevent: Initial checkin of threaded tevent context calling code.
Adds 2 new functions:
struct tevent_thread_proxy *tevent_thread_proxy_create(
struct tevent_context *dest_ev_ctx);
void tevent_thread_proxy_schedule(struct tevent_thread_proxy *tp,
struct tevent_immediate **pp_im,
tevent_immediate_handler_t handler,
void *pp_private_data);
Brief doc included. Tests, docs and tutorial to follow.
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit bb0050a332ceb77382c276d2c8bc3638369c16d0
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Aug 24 15:41:33 2015 +0200
tdb: version 1.3.8
* Fix broken build with --disable-python
* Minor build fixes
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 4f6eb583812adbf6e262d061a4d2bc97e759cc7a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Aug 24 15:47:18 2015 +0200
talloc: version 2.1.5
* Minor build fixes
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit fae40ec5b4702dd55905e66d896a73c356c95374
Author: Andreas Schneider <asn at samba.org>
Date: Wed Nov 4 12:54:05 2015 +0100
uwrap: Bump version to 1.2.0
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Nov 5 12:30:02 CET 2015 on sn-devel-104
commit 2dae19c43b2db4f4fe39d93cdb6918ae8a7dcc49
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:41:47 2015 +0100
uwrap: Fix build warning with release build
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3328bcede7b2950f9d1ec4c0c9d8acf684b77d30
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:41:18 2015 +0100
uwrap: Add the EINVAL check to setegid()
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6e30b2e63854c9c7067f176c84468aece17641f7
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:40:45 2015 +0100
uwrap: Allow setgid calls only for privileged users
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit be0cb8ab4d68680f0c4b1ec1db994781056d61b2
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:40:18 2015 +0100
uwrap: Allow setregid calls only for privileged users
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6b388799e1c834d74584dc6982155c731f56a49a
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:39:55 2015 +0100
uwrap: Allow setresgid calls only for privileged users
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2232db817336787c520ad32a1d3179a628d53e06
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:39:30 2015 +0100
uwrap: Move the EINVAL check down in seteuid()
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 56970b467b65ac00001132b499ab61b40ba1efa3
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:39:02 2015 +0100
uwrap: Allow setuid calls only for privileged users
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 253f42c83721085ceb19a7f1efd5810a36ca122a
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:38:32 2015 +0100
uwrap: Allow setreuid calls only for privileged users
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 5a9c80da7f4c6a9ab3d9d328dff9eb0568e270b9
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:37:51 2015 +0100
uwrap: Allow setresuid calls only for privileged users
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 656f0db652969bd0cd8faf145479e78356fc7252
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:37:11 2015 +0100
uwrap: Fix a possible null pointer dereference
If uid_wrapper is loaded but not enabled (UID_WRAPPER environment
variable not set), then we dereference a NULL pointer while forking.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit aad7019e2db23521772542cc2da2b1d8bc863024
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:36:39 2015 +0100
uwrap: Improve debug output
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8922654f840c09a2f33a722048a8f3f326da3a4c
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 13:36:04 2015 +0100
uwrap: Fix debug line in uwrap_init()
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e821e4596a9798bb06573fcb277bbc8b8b80631f
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 13 14:43:08 2015 +0200
ntvfs: Add error debug statements for set_unix_security
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3d7fdb8dbc1457aab5b2fe9580115bd518a93c1f
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 13 13:02:07 2015 +0200
selftest: Start Samba AD DC as root
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3b7cbc2eeb74ff9a5090d1e21506cf5a351e27a9
Author: Andreas Schneider <asn at samba.org>
Date: Wed Nov 4 10:15:13 2015 +0100
s4-rpc_server: Get the real initial uid for selftest
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 796a05b810bd8d6b817ae7259f80ec675a1e4568
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 14:30:58 2015 +0100
selftest: Start smbd, nmbd and winbindd as root
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6361063995ed457a6005eb048eef2c55f1b8ae87
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 14:31:33 2015 +0100
s3-lib: Get the real initial uid for selftest
We need this that if we connect as the user who started smbd, we are
able to perform privileged operation like creating a user.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 77eb8e0a4b83d46d854337dbf4f6ace76d557e85
Author: Uri Simchoni <uri at samba.org>
Date: Wed Nov 4 21:18:20 2015 +0200
vfs_offline: add documentation
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Nov 5 01:22:48 CET 2015 on sn-devel-104
commit b3f3ffe35d50886cce730b6f78ed22e1e62959a1
Author: Uri Simchoni <uri at samba.org>
Date: Wed Nov 4 12:06:03 2015 +0200
vfs_offline: add a blackbox test
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b37ecbd06d7a625d6889a9e8eaa66c807bb2a839
Author: Uri Simchoni <uri at samba.org>
Date: Wed Nov 4 08:44:29 2015 +0200
vfs_offline: add vfs_offline module
This module marks all file in the share as offline.
It can be useful for shares mounted on top of a remote file
system (either through a samba VFS module or via FUSE).
Offline files change the behavior of Windows explorer, and
prevent it from peeking inside folders just for the sake of
drawing a nice icon of them. This greatly reduces the number
of requests Windows Explorer makes, and improves user experience
when dealing with remote file systems.
The offline bit also has an effect on the behavior of Windows
redirector.
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 89940f39c6d2db03b3a468942d686e762f126f9f
Author: Noel Power <noel.power at suse.com>
Date: Mon Nov 2 09:59:12 2015 +0000
s3: rpcclient: Prevent null ptr access by returning error if no creds available
Prevent rpccli_netlogon_password_logon being called with 'NULL' credentials.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11569
Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e8fab02773892812f563eea7098847618df76e1b
Author: Noel Power <noel.power at suse.com>
Date: Thu Oct 22 12:37:17 2015 +0100
s3: winbind: Prevent null ptr access by returning error if no creds available
Prevent rpccli_netlogon_network_logon/rpccli_netlogon_password_logon
being called with 'NULL' credentials
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11569
Signed-off-by: Noel Power <noel.power at suse.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit aa3cc0b459124c66de0aad8ff41908e1bf261222
Author: Jeremy Allison <jra at samba.org>
Date: Wed Nov 4 09:34:57 2015 -0800
s3: smbd: If EA's are turned off on a share don't allow an SMB2 create containing them.
Otherwise a create that should have failed may succeed.
Based on an original patch from John Mulligan <phlogistonjohn at asynchrono.us>
and comments from Uri Simchoni <uri at samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11589
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Wed Nov 4 22:14:22 CET 2015 on sn-devel-104
commit b06544da6f466affaa0ef6681e78673ef05b2c1e
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 27 10:47:05 2015 +0200
wafsamba: detect programmer errors in CHECK_BUNDLED_SYSTEM()
All prerequisite libraries of CHECK_BUNDLED_SYSTEM[_PKG](onlyif='lib1 lib2')
need to be checked before.
That means conf.env['FOUND_SYSTEMLIB_lib1'] and conf.env['FOUND_SYSTEMLIB_lib2']
need to exist independed of its value (True or False). Otherwise this is a logic error.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11458
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Nov 4 18:38:18 CET 2015 on sn-devel-104
commit c474173a83f3200ce64379f96c1e2367061aa2ca
Author: Andreas Schneider <asn at samba.org>
Date: Tue Oct 20 15:54:39 2015 +0200
tests: Add tests for net ads (join|leave)
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Wed Nov 4 15:35:57 CET 2015 on sn-devel-104
commit 23932d38dd2c83460a34030dcbad2d70a5e0157d
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 18:28:29 2015 +1100
ctdb-build: Add ctdb/ directory to include path for top-level build
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Wed Nov 4 03:52:27 CET 2015 on sn-devel-104
commit 38d92788d621745213e38986834b9ee0b2fdfb55
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 17:51:52 2015 +1100
ctdb-include: Use new protocol definitions
This gets rid of the duplicate definitions from ctdb_protocol.h.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 8b84a82eab2af34a29533d9bced347f672f02c0b
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 18:37:42 2015 +1100
ctdb-protocol: Rename G_LOCK_READ/WRITE to CTDB_G_LOCK_READ/WRITE
to avoid clash with definitions from source3/include/g_lock.h.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b8b737c77ac3240d63afa441aeba195a915c2353
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 17:55:35 2015 +1100
ctdb-client: Rename g_lock datatypes as per new protocol.h
struct server_id => ctdb_server_id
enum g_lock_type => ctdb_g_lock_type
struct g_lock_rec => ctdb_g_lock
struct g_lock_recs => ctdb_g_lock_list
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 03c69d8400f6a50f614ab2800c1988b90f4ba60a
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 17:36:23 2015 +1100
ctdb-include: Remove unused definitions
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 3b71d0592752295e6f1f642cb647ca965e2abfe9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 19:52:02 2015 +1100
ctdb-tools: Use replace headers instead of system headers
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 409c92b6c6dc54a072743dc2bb6bcaa533cc5110
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 19:52:53 2015 +1100
ctdb-daemon: Remove explicit include of ctdb_protocol.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 44e611ddcf8b929cbee48bc83b066d88174bf121
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 19:43:48 2015 +1100
ctdb-daemon: Rename struct ctdb_control_get_ifaces to ctdb_iface_list_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit ecfaef503191ab45317cc6a851201ec992d7fb11
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 19:39:51 2015 +1100
ctdb-daemon: Rename struct ctdb_control_public_ip_info to ctdb_public_ip_info_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit c4e9d616ae4c87aecbd98a3c4387742bbf44a2e7
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 19:37:17 2015 +1100
ctdb-daemon: Rename struct ctdb_control_iface_info to ctdb_iface
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 417077c8a722b628d4db17f0f1799c70639d5d17
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 19:22:23 2015 +1100
ctdb-daemon: Rename struct ctdb_control_transdb to ctdb_transdb
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 1278a5a4ed527f3fe0f7150854d53b40835121ad
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 19:18:02 2015 +1100
ctdb-daemon: Rename struct ctdb_control_set_tunable to ctdb_tunable_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 64d8bb626bd17910628efe80835912299ec7c6a9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 19:10:53 2015 +1100
ctdb-daemon: Rename struct ctdb_control_pulldb to ctdb_pulldb
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit f8c2dc32206ed5e6244f9a9dc3e9dbdd24f7e194
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 14:47:54 2015 +1100
ctdb-daemon: Rename struct ctdb_control_gratious_arp to ctdb_addr_info_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 357bc609472902d10ea8324bd9892b1bab889379
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 14:46:21 2015 +1100
ctdb-daemon: Rename struct ctdb_control_ip_iface to ctdb_addr_info_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit cb0be4126ff7b8db94b34f2b115db35cddbf137e
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 18:51:22 2015 +1100
ctdb-daemon: Rename struct ctdb_tunable to ctdb_tunable_list
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit ca481354c0edcb2afb022ee088010334826fd783
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 18:44:19 2015 +1100
ctdb-daemon: Rename struct ctdb_control_tcp_tickle_list to ctdb_tickle_list_old
Also remove unnecessary struct ctdb_tcp_wire_array.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e34afd85161d462ee67ff5baa0ce1016c8b74438
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 18:23:13 2015 +1100
ctdb-daemon: Rename struct srvid_request_data to ctdb_disable_message
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit cf1ac77b3a96f2d9214e132a5a18966d31322880
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 14:32:49 2015 +1100
ctdb-daemon: Rename struct srvid_request to ctdb_srvid_message
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit d4de4527b070ab0039ffdf7d2fdd3a105c198b5d
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 18:18:33 2015 +1100
ctdb-daemon: Rename struct ctdb_ban_time to ctdb_ban_state
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 92a6ac18ae943c09ebcde7ea2879c7347bc59512
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 18:14:21 2015 +1100
ctdb-daemon: Rename struct ctdb_tcp_connection to ctdb_connection
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit a82ee238b5ade4315baa9835744dac8f5362bdf8
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 14:25:34 2015 +1100
ctdb-daemon: Rename struct ctdb_control_tcp_addr to ctdb_connection
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 699ee0df94dda5a4f2fe97efe3fd03f9a15f7b75
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 14:16:45 2015 +1100
ctdb-daemon: Rename struct ctdb_server_id_list to ctdb_client_id_list_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit d858c210a7d7498e539a9d76ece1a6b162e64c10
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 17:47:03 2015 +1100
ctdb-daemon: Rename struct ctdb_server_id to ctdb_client_id
This is to avoid clash with samba structure server_id.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 22c84ff746eebb205d98014f5e4c3cf5b0438673
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 14:12:11 2015 +1100
ctdb-daemon: Rename enum ctdb_server_id_type to ctdb_client_id_type
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 645cd43200f16403baec61ec4829770ce50ed70f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 17:46:05 2015 +1100
ctdb-daemon: Rename struct ctdb_dbid_map to ctdb_dbid_map_old
Match struct ctdb_dbid as per protocol/protocol.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 563f51828367499cca0dad986f78a996a9b11e0b
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 17:47:03 2015 +1100
ctdb-daemon: Remove struct ctdb_client_notify_deregister
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b93614595186db2d9c33dc58d6736e4978d9664b
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 17:43:20 2015 +1100
ctdb-daemon: Rename struct ctdb_client_notify_register to ctdb_notify_data_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 6e37bb7c3a6231ffd47d9821819add84c69d35b4
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 17:36:14 2015 +1100
ctdb-include: Remove unused structure definitions
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit a9f335fcc2af906770212abaedfceb30a81ad409
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 17:34:24 2015 +1100
ctdb-daemon: Rename struct ctdb_iface to ctdb_interface
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 75572bd2a3e85114e83cbb16cad56cbf29da124d
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 17:33:09 2015 +1100
ctdb-daemon: Rename struct ctdb_db_statistics to ctdb_db_statistics_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b45bc4ce4bd521380c08bcf2f934f3e98be4d292
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 20:09:40 2015 +1100
ctdb-daemon: Rename struct ctdb_statistics_wire to ctdb_statistics_list_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b99436e425ec8574f88f6ef778be4e06013f01ae
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 17:30:30 2015 +1100
ctdb-daemon: Rename struct ctdb_rec_data to ctdb_rec_data_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 9bf7d0dc447bd43c5a977bd3da5ccda258be8b00
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 17:18:24 2015 +1100
ctdb-daemon: Rename struct latency_counter to ctdb_latency_counter
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 04eaa077aac4c82c334c01fea730de97220c8c1e
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 17:16:24 2015 +1100
ctdb-daemon: Rename struct ctdb_all_public_ips to ctdb_public_ip_list_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 2b76e580321d050bf17d4999ee288c86669d6401
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 17:10:54 2015 +1100
ctdb-daemon: Rename struct ctdb_public_ip_list to public_ip_list
A private structure need not have ctdb_ prefix.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit afc5d8a4420c7c235ab54f938a3f3a77d4309665
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 17:22:48 2015 +1100
ctdb-daemon: Rename struct ctdb_node_map to ctdb_node_map_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit c43b381b71140913a59471d8000e3b2c804bf3f4
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 16:58:02 2015 +1100
ctdb-include: Remove unnecessary typedefs
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e8f8c633610469d631782deaa6ef0eabae735b20
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 16:45:41 2015 +1100
ctdb-daemon: Rename struct ctdb_req_keepalive to ctdb_req_keepalive_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 1c828b4ed6127e0022f4512f65a4b8c1280aa36a
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 16:44:08 2015 +1100
ctdb-daemon: Rename struct ctdb_reply_control to ctdb_reply_control_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e1fed53e2abafcae8a5da9a3b24ee8db38b97441
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 16:42:05 2015 +1100
ctdb-daemon: Rename struct ctdb_req_control to ctdb_req_control_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit acf858defbe8672c91265e6e2afe45476ef0fba6
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 16:36:30 2015 +1100
ctdb-daemon: Rename struct ctdb_req_message to ctdb_req_message_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 296d9f4cdafdf5770c64f9f75effd250b1f9972e
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 16:34:01 2015 +1100
ctdb-daemon: Rename struct ctdb_reply_dmaster to ctdb_reply_dmaster_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 555a2f3f4f6ee5fca6d741a987b88b42f5504c06
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 16:32:09 2015 +1100
ctdb-daemon: Rename struct ctdb_req_dmaster to ctdb_req_dmaster_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e23a2891d90b040c41d8c8dc1cf18e76d501aaab
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 16:30:31 2015 +1100
ctdb-daemon: Rename struct ctdb_reply_error to ctdb_reply_error_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 277c21f0cd86510c421642eae9267c6fae44df78
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 16:29:01 2015 +1100
ctdb-daemon: Rename struct ctdb_reply_call to ctdb_reply_call_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e0c42c5698f32ea6a3ec8aa93c380969bd110117
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Oct 29 16:26:29 2015 +1100
ctdb-daemon: Rename struct ctdb_req_call to ctdb_req_call_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit f55889d2c9630e088ae9b8058d29f9df6fb2a007
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 16:54:10 2015 +1100
ctdb-daemon: Rename enum ctdb_eventscript_call to ctdb_event
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e7c9e509168c3f26e83fb2083ee9bc4eb9841480
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 20:02:45 2015 +1100
ctdb-daemon: Rename struct ctdb_scripts_wire to ctdb_script_list_old
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b9b4bfa33070a9c89e5466e5d1883b89aab06e14
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 28 16:49:47 2015 +1100
ctdb-daemon: Rename struct ctdb_script_wire to ctdb_script
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 18879dab9affffd79a647a4de697512c03e04425
Author: Marc Muehlfeld <mmuehlfeld at samba.org>
Date: Tue Nov 3 10:09:13 2015 +0100
Changing log level of two entries to DBG_NOTICE
On domain members using RFC2307, machine acccounts without an uidNumber
attribute are not retrieved via idmap_ad. This leads to many of the following
two error messages:
Username DOMAIN\machineaccountname$ is invalid on this system
and
Failed to map kerberos principal to system user (NT_STATUS_LOGON_FAILURE)
Machine accounts don't have an uidNumber attribute, if not set manually. To
avoid flooding the logs, setting message from debug level 1 to DBG_NOTICE.
Bugreport: https://bugzilla.samba.org/show_bug.cgi?id=9912
Signed-off-by: Marc Muehlfeld <mmuehlfeld at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Nov 4 00:46:15 CET 2015 on sn-devel-104
commit d5cdfa0f82e82b41490450571a155acfad66e85c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Nov 3 12:00:56 2015 +0100
backupkey: Fix CID 1338078 (RESOURCE_LEAK)
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4f84372aa8beb7649111af5d2ee62112bcee5328
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Nov 3 12:14:41 2015 +1100
notifyd: Do not include CTDB headers without CLUSTER_SUPPORT enabled
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Nov 3 15:15:56 CET 2015 on sn-devel-104
commit ed1e6463a7809b12b105d03b15da158c3075478c
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Nov 3 12:37:38 2015 +1100
smbd: Do not include CTDB headers without CLUSTER_SUPPORT enabled
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit af92f1b0629acecc31b78bba67e0bb8d707e3606
Author: Anoop C S <anoopcs at redhat.com>
Date: Tue Oct 13 14:25:20 2015 +0530
s4.torture.smb2/session : Replace CHECK_VAL with torture macros
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Nov 3 03:17:14 CET 2015 on sn-devel-104
commit ad85c8905184d125a2a38569f7955ccbf443ebcd
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Nov 2 13:40:24 2015 +0100
s3:smb2_server: make the logic of SMB2_CANCEL DLIST_REMOVE() clearer
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11581
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d66863b1fff862aa2ae21a06116bc2a2b2f7a6ce
Author: YvanM <yvan.masson at openmailbox.org>
Date: Sun Nov 1 11:53:45 2015 +0100
manpage: corrected small typo error
Corrected mistakes, probably comming from a too fast
"copy and paste", in the smb.conf manpage.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11584
Signed-off-by: YvanM <yvan.masson at openmailbox.org>
Reviewed-by: Björn Jacke <bj at sernet.de>
Reviewed-by: Karolin Seeger <kseeger at samba.org>
Autobuild-User(master): Karolin Seeger <kseeger at samba.org>
Autobuild-Date(master): Mon Nov 2 14:43:15 CET 2015 on sn-devel-104
commit 861018f1432d6d601e4fcecf444fe8eca219ef65
Author: Thomas Nagy <tnagy at waf.io>
Date: Sat Oct 31 14:39:35 2015 +0100
build:wafsamba: Remove the now unneeded special treatment of rpath flags
The flags parsing fixes were backported to waf 1.5 from waf 1.8. There is no reason
to keep the flags parsing fixes in Samba.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Nov 2 03:35:31 CET 2015 on sn-devel-104
commit 77afc1baa24df00cd8d283ab1f19c53e01e4343e
Author: Thomas Nagy <tnagy at waf.io>
Date: Sat Oct 31 14:38:10 2015 +0100
build:wafsamba: Update waf/wafadmin/Tools/config_c.py from upstream
The upstream version features the flags processing fixes present in Waf 1.8.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9ef47d25317947248b0796059e6f0a851ba3cb07
Author: Petr Viktorin <pviktori at redhat.com>
Date: Fri Aug 14 12:17:48 2015 +0200
buildtools: Ignore exact Python version for ABI checking
Utilities for Python libraries are built for a specific Python
version. Starting with Python 3, the Python version is recorded
in the shared library filename as an ABI tag, e.g. "pytalloc.cpython-34m.so.
The exact version doesn't matter for Samba's ABI check.
Replace the ABI tag with a simpler one that just records the major
version of Python.
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Sun Nov 1 01:09:06 CET 2015 on sn-devel-104
commit 2f619066fbf2e8310e0a21b6680212c3e676b6ea
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 27 11:44:23 2015 +0200
s4:heimdal_build: also use check_system_heimdal_lib() for "com_err"
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit 3cb1d6e7c5e0735ee75ec54b987dbccf1da0db7a
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 27 11:40:09 2015 +0200
s4:heimdal_build: handle CHECK_BUNDLED_SYSTEM returning False in check_system_heimdal_lib()
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit db04752f3ecefc19fbf199930931fa31dde1632c
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 27 11:05:08 2015 +0200
script/autobuild.py: exclude !pytalloc-util and !pyldb-util from bundling in samba-libs
We need to make sure we're really not bundling any of these.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11458
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jelmer Vernooij <jelmer at samba.org>
commit a19bb29a0814bc31c3f377a983c1503f63a6bc42
Author: Felix Janda <felix.janda at posteo.de>
Date: Thu Oct 22 12:42:07 2015 +0200
s3: Remove unnecessary __P() macro
__P() is used for compatibility with old K&R C compilers. With
ANSI C this macro has no effect. Since we are assuming ANSI C in
the rest of the code, the macro is not necessary.
This fixes a compilation error with musl libc because of undeclared
__P().
Signed-off-by: Felix Janda <felix.janda at posteo.de>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 89d254ddca20a36001c9dfdcfa6d8b9767f0f897
Author: Felix Janda <felix.janda at posteo.de>
Date: Thu Oct 22 12:37:55 2015 +0200
lib/replace: Make sure that replacement strto[u]ll does not reset errno unexpectedly
Fix the replacement functions for strtoll and strtoull to not set errno
to 0 if errno is EINVAL before calling, strto[u]ll does not modify errno
and the base is ok.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11455
Signed-off-by: Felix Janda <felix.janda at posteo.de>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8343c707533e9acd53898778f386a1d93d57763f
Author: Felix Janda <felix.janda at posteo.de>
Date: Thu Oct 22 12:32:48 2015 +0200
lib/replace: Replace BSD strtoull by wrapping strtoull instead of strtouq
Same as commit e50bf6d537ef09e936d19d6e0bf63f9bbc5d4818 but for strtoull
instead of strtoll.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11455
Signed-off-by: Felix Janda <felix.janda at posteo.de>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f30a8a28322b1a83909388f983800f99a8c77c14
Author: Anoop C S <anoopcs at redhat.com>
Date: Mon Oct 26 16:33:11 2015 +0530
s4.torture.smb2/session: Add torture assert for close
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Sat Oct 31 15:52:22 CET 2015 on sn-devel-104
commit e8a2ddafe40f46ca89d699ee770d2b399e87af3f
Author: Anoop C S <anoopcs at redhat.com>
Date: Thu Oct 29 20:20:52 2015 +0530
s4.torture.smb2/session: Add torture assert for unlink
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9582a484b41b94ec8a6451ac98822d781598eaac
Author: Anoop C S <anoopcs at redhat.com>
Date: Thu Oct 8 19:02:06 2015 +0530
s4.torture.smb2/session : Replace CHECK_STATUS with torture macros
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9e87465a750e625e8a3801346922981cb4871547
Author: Volker Lendecke <vl at samba.org>
Date: Thu Oct 29 14:27:32 2015 +0100
smbd: Fix/simplify scavenger routines
Use read_data/write_data, "ofs" was not incremented
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Oct 30 22:53:56 CET 2015 on sn-devel-104
commit db9e10d071793b91b3f3d40225a8634e3c34f65e
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 30 09:01:28 2015 +0100
s3-smbd: Fix use after issue in smbd_smb2_request_dispatch()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11581
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Oct 30 19:49:47 CET 2015 on sn-devel-104
commit d8f3b490bbb691c9916eed0df5b980c1aef23c85
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 30 14:25:50 2015 +1100
ctdb-banning: Do not set recovery mode to ACTIVE in daemon
When a node gets banned, it should go into recovery and freeze all
databases. We rely on the recovery daemon to detect the banned state
and put the node in recovery and freeze all databases.
Recent change in b4357a79d916b1f8ade8fa78563fbef0ce670aa9 took explicit
freezing out of banning code but left the setting of recovery mode
to ACTIVE. Recovery daemon will freeze databases only if the recovery
mode is NORMAL. Recovery mode set to ACTIVE is an indication that the
freeze has started.
Do not set the recovery mode to ACTIVE in banning. Let recovery daemon
take care of it.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Fri Oct 30 10:32:38 CET 2015 on sn-devel-104
commit 30a6a2247b3d9e177398779544ef0d3e17e2bef7
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 27 17:34:06 2015 +1100
ctdb-include: Order function prototypes as per ctdb_client.c
This makes sure that all function prototypes in ctdb_client.h are in
the same order of functions defined in ctdb_client.c.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Fri Oct 30 05:04:49 CET 2015 on sn-devel-104
commit d2bd076a0fee9f94d936a0002ad44bd22fa5949f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 27 16:45:12 2015 +1100
ctdb-include: Remove unused structures and prototypes
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 03beaa3d3daa51826361f06ec1a05c8791a096e2
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 27 15:34:30 2015 +1100
ctdb-include: Move client function prototypes to ctdb_client.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 404c91eeefb49b73f5a6f357dd18ab692306977c
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 27 16:29:36 2015 +1100
ctdb-include: Move protocol structures from ctdb_private.h to ctdb_protocol.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 1e782e6995639729a31afdd2ec03717ba866dff1
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 27 15:32:12 2015 +1100
ctdb-include: Move protocol structures from ctdb_client.h to ctdb_protocol.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 6ce1aa916e6c5b9abf3421cb3afe1e44a4fef0fb
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 16:00:39 2015 +1100
ctdb-include: Group function prototypes from server/eventscript.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 819f8626f7f83f9f5685dcbec3a74ea5dc2e8747
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:49:32 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_vacuum.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 860f2edc61ceb808b06a73f1f1f293fa5f3a3574
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:46:49 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_uptime.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit bdce6c4256ddc107c46e48c58fd73c8181f75a3e
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:45:55 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_update_record.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit a24e2ae0987cf7ac220d4eddf17069719cc6702d
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:44:21 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_tunables.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 7ffd56d3dde7fde33350ac530d9b1be70f879f21
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:42:50 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_traverse.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 28b33b5b2cf892b7509bd7c9e40a98edb0138691
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:40:19 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_takeover.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 2d0f917be963921d3655b942a582f2da72aa1010
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:31:34 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_statistics.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b0f10a46f1b9bb419c3b60fbbbb7ed44e60f82e4
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:30:37 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_serverids.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit beadc5039da28c9578c9afd4d2784e41dcddf45c
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:28:56 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_server.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit c0a20b9e803ab86c7fe1b03c05e8ab3f41e74ed9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:57:25 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_recoverd.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit af95b2f7020dd0ae6065b5d1046b108a052145a5
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:54:59 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_recover.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 19f87a0292bd52ac0e401cf045d1a2aa9bf457f8
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:25:24 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_persistent.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 9bb5e7dfab7d204b7a82e50c5bde88c5884e1634
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:23:18 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_monitor.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 3723eed63e3e1a18f173b581a5196f90237c1c72
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:21:13 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_ltdb_server.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit ae35699615b6719cfdb4844e406a867cacfbfd67
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:15:28 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_logging_syslog.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 930a620d80d376f44e2be992c8081b7fd094b642
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:14:53 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_logging_file.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit bc14982eda393e3dcf01bbfbf87127d5d20a736a
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:13:54 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_logging.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 8a4b342e0ebf22e22ea33cb88ddddb8384c27aa2
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:10:48 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_lock.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 568a4ce74b3fb872286cbc7e0ab98118ecb038e3
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:08:51 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_keepalive.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit d85e13bf441c3ef420d712e437e8ea2593d7c7e9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:08:05 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_freeze.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 9c52c3df1ccdce3e98371a70dd0503d2bf4fdd58
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 15:04:17 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_daemon.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 740bb903878af4dfbd52d8575d4bc710134cbed6
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 14:58:14 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_control.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 171299d14886482f1641411c7719fec6977602f9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 14:56:00 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_call.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 3132720ee8b8a4da9d09bcbab3469b18d4359123
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 14:48:44 2015 +1100
ctdb-include: Group function prototypes from server/ctdb_banning.c
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 8558b765726588e5712ff655c6a8c0f12a5dda3c
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 14:47:09 2015 +1100
ctdb-include: Group function prototypes from tcp and ib
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 46477877732f4fc6a0ed6603ead66d063ca5e5ce
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 14:17:34 2015 +1100
ctdb-daemon: Separate prototypes for common client/server functions
This groups function prototypes for common client/server functions in
common/common.h and removes them from ctdb_private.h.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit f1b9d8faf86c1b52206bfff7469740f0f9dcd919
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 27 15:26:26 2015 +1100
ctdb-common: Add missing prototype for ctdb_cmdline_client()
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit ded94c426b2e7758735a57ec2b5c7c62a1b4fc65
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 13:05:20 2015 +1100
ctdb-build: Calculate correct version when building from tarball
When building standalone ctdb from git repo, samba_version_file correctly
includes git sha in VERSION string. When building standalone ctdb from
tarball, samba_version_file puts UNKNOWN in the VERSION string.
Use the packaged include/ctdb_version.h file to set the correct git sha.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit f50ac680340ad2981ffac2b7ac0e2c746a17882c
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 13 17:57:49 2015 +1100
ctdb-daemon: Remove unused header file include/internal/includes.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 01c6c90e9818a52854a44e2303362fc39631df2a
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Oct 26 16:50:46 2015 +1100
ctdb-daemon: Remove dependency on includes.h
Instead of includes.h, include the required header files explicitly.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 2fdb332fad541efd34be749e55a07569ce2b4ef4
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Oct 26 16:50:09 2015 +1100
ctdb-daemon: Stop using tevent compatibility definitions
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 7084cb92e2b30134b2d5c9017a558f9e7b7696fe
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 13 15:19:59 2015 +1100
ctdb-include: Move include/internal/cmdline.h to common/
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b900adc55ce2609faf0b8acb62ab88507cddee42
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 14:11:53 2015 +1100
ctdb-daemon: Separate prototypes for system specific functions
This groups function prototypes for system specific functions in
common/system.h and removes them from ctdb_private.h.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 4346fe6a0259e326bd5254a9d192f0807b27331e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Jun 23 16:38:29 2015 +1200
KCC: allow --test-all-reps-from to work with --import-ldif
The ldif files lack information that a normal database has, which means
the ldif import function has to use some trickery to set the local DSA.
Once the local DSA is thus set, the fake database is a bit useless from
the point of view of other DSAs. We get around this by re-importing it
each time.
This is doing something slightly different than the normal samdb
--test-all-reps-from, in that the changes are not preserved between each
DSA's run. With the samdb database (unless using --readonly), the later
DSA's will see changes the early ones made. The ordering is arbitrary.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Oct 29 08:11:54 CET 2015 on sn-devel-104
commit 8bdfb256d6c4fdeaaa118fc6da841daebc1c377d
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Jun 23 16:38:29 2015 +1200
KCC: samba_kcc --tmpdb X won't run if X already exists
Part of an ongoing safety campaign, making it harder to overwrite
your valuable things while keeping it easy enough to test crazy schemes.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e29fba640b7d543f1e7177aa9357c82f590b6b07
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Jun 23 16:38:29 2015 +1200
KCC: with --import-ldif, don't default to standard DB url
Before samba_kcc would always assume `-H /usr/local/whatever`, and this
interacted badly with the likes of `--test-all-reps-from` and
`--forget-intersite-links`. When I say badly, I mean it crashed because
the file is absent on my dev machine.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 46ac3a5308dfc5d03173bbae03734ba327f0e570
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Jun 23 16:38:29 2015 +1200
KCC: kcc.import_ldif doesn't need creds
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6f93ffaf0c446cd72478317636c0dcd7e0f4f4b8
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Jun 23 16:38:29 2015 +1200
KCC: remove NTDSConnection API methods that are never used
These are not used, and using them would not be considered Pythonic. The
flags they alter are always changed directly.
The similar set_modified() method IS used.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit b93205ebe4cb54175642ee60e18354f7bfb4c0fd
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Jun 23 16:38:29 2015 +1200
KCC: whitespace for pep8
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 1d5bb5996e7df31aac746375a5cc24a91ee52d7e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Tue Jun 23 16:38:29 2015 +1200
KCC: fix pep8 line length in load_ip_transport()
You are right to sigh about this one.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ab63f1a9839c286cf7f345cc62207d9b95a5af62
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Mon Jun 22 16:38:29 2015 +1200
KCC: Correct capitalisation of KCCError
previously we had "raise KccError", which of course would raise a
NameError.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e9f0799a18955e9fec1478a6019a333f588b26cc
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Mon Jun 22 16:38:29 2015 +1200
KCC: raise KCCError, not Exception, in multiple places
"except Exception" lines will still catch them, but more fine-grained
control is possible.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 26384192d56d765a8ea4667fac7c9b7ad2e3d415
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Mon Jun 22 16:38:29 2015 +1200
KCC: NTDSConnection.load_connection() requires objectGUID
If there is no GUID, that is an error, so we raise an exception instead
of stepping around it.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8f5936261f221f6a83fc294e308160d9fb9562e3
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Mon Jun 22 16:38:29 2015 +1200
KCC: remove debug print statements from intrasite and intersite
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8fe9992cffed82e9e26ebe8185f372c8a1dfb3a9
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Mon Jun 22 16:38:29 2015 +1200
KCC: load samdb before calling kcc.run()
kcc.run() is a mega-function that does nearly everything, including
loading the database. The --list-valid-dsas and --test-all-reps-from
tasks also want to load the database, but not do all that other run()
stuff, so it makes sense to pull it out. When the samdb has not been
loaded, run() will still load it -- this avoids having to change all
the tests.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 47b3334f48f21118ba1f61e841eb95920f384ee4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Mon Jun 22 16:38:29 2015 +1200
KCC: load the object GUID with --import-ldif
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 30330b4df8e1542a2c9fd2ca256cb58029b6cbf4
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Mon Jun 22 16:38:29 2015 +1200
KCC: avoid logging alarming things about exected events
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ad009be3297ec9343fd07ea86a197dc11ab8890f
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 17 16:38:29 2015 +1200
KCC: shift --test-all-reps-from call to after kcc loading
This is in an effort to allow --test-all-reps-from to work with
--import-ldif (though so far it doesn't for other reasons). Rather than
replicate all the ldif loading logic within test_all_reps_from, we just
wait delay the test_all_reps_from() call.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a9ddca042c51de5c95327f41e3a31c178f5ab85b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 17 16:38:29 2015 +1200
KCC: Simplify RNG seeding logic, dropping the default value
There is no particular justification for the previous default, other
than being deterministic makes testing more reliable. The algorithms
using randomness do not assume determinism.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e442726c3d59bf861058ac81735653d9f91610a2
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 17 16:38:29 2015 +1200
KCC: more debug info when --import-ldif goes badly
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit acd77283ccf3253bb7d5d048465bbf8e77a89982
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 17 16:38:29 2015 +1200
KCC: default to not loading new samdb when we already have one
This should make things simpler in the --import-ldif case.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 76f195a2792d0c4cd86a337881d1ce01194113af
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 17 16:38:29 2015 +1200
KCC: fix typo in error path
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6f78ad24506928f48f5a26bf87f3d4de460f0cde
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 10 16:38:29 2015 +1200
KCC: better explain our confusion in colour_vertices comment
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 310aa2f3408800498876768091f3533e3332b75b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 10 16:38:29 2015 +1200
KCC: clarify debugging messages in bridgehead finding code
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5f60c4bf33cd94c84cad0ba5768474435a515af0
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 10 16:38:29 2015 +1200
KCC: keep track of IP transport for dsa.new_connection()
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 059e2838c8a61ffbb0865e665694c02bb531758b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 10 16:38:29 2015 +1200
KCC: set system flags for new intrasite connections
These flags are mandatory for intrasite connections.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 704fd83bcf5bba3bf5e67ea8060aff148aacea32
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 10 16:38:29 2015 +1200
KCC: correctly use dsa.new_connection() system_flags argument
The dsa.system_flags attribute is important and gets saved in the
database, but was never getting altered because we were setting dsa.flags
instead.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 4bf95b6b32dfc8ecc0aac92971e173b826e2d4ac
Author: Garming Sam <garming at catalyst.net.nz>
Date: Fri Jun 26 16:38:29 2015 +1200
KCC: Use detect_failed in create_connections
Without this, dead DCs were treated as live, and could be used in the
tree. If they're in the tree they can split the network.
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 0f8f99f6af2785d6774ca9436b6eef2078a246df
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Jun 25 16:38:29 2015 +1200
KCC: remove useless comments and simplify get_dsa_for_implied_replica()
These comments are a close reflection (or possibly copy/paste) of the
spec, but our code here no longer resembles the spec. We end up just
glazing over when we see comments and losing track of the flow of code.
If you want the spec just look at the spec.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 24ae662eaee03a0e5d1046acf6882bc6842f518a
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Jun 25 16:38:29 2015 +1200
KCC: stop --forget-intersite-links forgetting local links
It will still forget intrasite links on other sites, but that in theory
should not matter.
It will still break your network, and is only useful for debugging.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit eec0d119ac755b72f8e881728608a849ad12b66b
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Jun 25 16:38:29 2015 +1200
KCC: simplify get_dsa_for_implied_replica(), using IP invariant
We only do IP transports. Therfore the long list of alternatives...
(not n_rep.is_domain() or
n_rep.is_partial() or
cn_conn.transport_dnstr is None or
cn_conn.transport_dnstr.find("CN=IP") == 0)
that ends with the equivalant of "is this IP?" always evaluates to True.
If we leave it there it will confuse people for ever.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 5bbcbe380b8b5cb7a9f479e585f46040f2d99ad5
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Jun 25 16:38:29 2015 +1200
KCC: Share commit wrapper between forget_ntdsconn and intrasite
The wrapper is only to create DEBUG output in read-only mode --
normally it amounts to `dsa.commit_connections(self.samdb)`.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 03e352268a80a4671b50855a977a655b095ddf18
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Jun 25 16:38:29 2015 +1200
KCC: pull apart remove_unneeded_ntdsconn(), fixing intersite
The confusing big mess was hiding bugs. Firstly, intersite links on
non-intersite-topology-generators were not getting looked at. Secondly,
the logic around superseding intersite links was missing.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 472735f26c3bc67d4a04d08038d1f63c1b275986
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jun 17 15:11:20 2015 +1200
KCC: shift common is_generated() check out of branches
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 6e3cb6b24ff53453c52251965bcf955e2e59fa37
Author: Michael Adam <obnox at samba.org>
Date: Wed Oct 28 20:41:33 2015 +0100
s4:torture: fix a comment typo.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Oct 29 00:42:49 CET 2015 on sn-devel-104
commit 1466e27fa612b0e09e78dea75c65516e76529ff6
Author: Thomas Nagy <tnagy at waf.io>
Date: Wed Oct 28 21:04:28 2015 +0100
build:wafsamba: Removed hard-coded class names from build scripts
Using hard-coded class names prevents subclassing and make it hard
to reason about the workflow. The wscript files read during the build
must be read during the installation phase as well.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6404c07266be0a2986473aacec7079c5849f3703
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 23 18:29:53 2015 +0200
ldb: Fix a "ignoring return value" warning
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Oct 28 19:04:15 CET 2015 on sn-devel-104
commit c17df7c0b19819fa05c41fcfbb01e92a79d5b897
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jul 12 14:33:55 2015 +0200
messages: messages.h needs data_blob.h
Normally it somehow comes via includes.h, but if you want to directly
include messages.h you need this
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7e45bec38fe31be3fdad1d42bfdd7136c1663ba5
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jun 30 20:41:55 2015 +0200
examples: Fix unchecked result warnings
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit af03f5b4e838003b1d9f2e77239f28e1e363d463
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jul 12 18:45:18 2015 +0200
lib: Remove a includes.h reference
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e11008ea4e2b104dd58e276c38030667f5c6c182
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jul 12 18:43:35 2015 +0200
lib: Include samba_util.h in server_id_db.h
Usually this came in via server_id.h's includes.h. This will go.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 58418df6794059c83c681f59dcc2095736d021ec
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 28 12:29:50 2015 +0100
lib: dbwrap_local_open references loadparm_context
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit ed833d518ab6aa352c77d5a21085d61cfcf9cdcf
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 28 12:04:56 2015 +0100
smbd: Fix a comment
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f33e618879ae3b154158258c8771478ee2b323ee
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 13 15:36:38 2015 +1100
ctdb-include: Remove unused header file include/ctdb_typesafe_cb.h
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Oct 28 15:59:02 CET 2015 on sn-devel-104
commit 20b82ea28ebf51cd82923f95b7f29aff86079a84
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 13 15:22:57 2015 +1100
ctdb-include: Remove unused header file include/ctdb.h
This was part of libctdb which has been removed.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 2666d06f292303a57643a8ced87b8a91df2ffce1
Author: Thomas Nagy <tnagy at waf.io>
Date: Tue Oct 27 20:46:46 2015 +0100
build:wafsamba: removed most import * statements
The 'import *' statements make it more difficult to reason about
the modules and tends to conceal bugs. These changes enable running
pyflakes against most of the build scripts.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlet <abartlet at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Oct 28 12:52:17 CET 2015 on sn-devel-104
commit 859e3415b38538ff6c023e4a56570d94a4fe4432
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 27 17:08:50 2015 -0700
lib: util: Make non-critical message a warning.
Non-root utilities (e.g. bin/net) call this via messaging_init().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11566
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 86111fcdce48dc25c46177b63ca12f55afee5f04
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 21 14:18:22 2015 +1100
ctdb-scripts: Fix an incorrect comment
Since commit 84f5528d9b526b1e9cb02c245e816c0c5e54c3bc, CTDB will not
remove an existing socket if it can connect to the existing one.
Instead it will fail to start.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Wed Oct 28 09:44:37 CET 2015 on sn-devel-104
commit b9903d72d3d53376ddca7e2f2f902195307b395c
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 21 14:12:40 2015 +1100
ctdb-scripts: Remove PID file only if it existed
If 2 attempts are made to start CTDB in quick succession then it is
possible for the 2nd attempt to remove a newly created PID file from
the 1st.
If the PID file existed then the PID/SID from ctdbd_is_running() will
be passed to kill_ctdbd(). If the PID file did not exist then there
is no point removing it.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 0a90ed51245d4a7acb23d22e47ee3fd5b83819b0
Author: Michael Adam <obnox at samba.org>
Date: Tue Oct 27 10:20:31 2015 +0100
ctdb: open the RO tracking db with perms 0600 instead of 0000
While 0000 is possible from the UNIX/POSIX point of view,
these permissions create problems in an environment with
selinux enabled, which is more strict.
This aligns the perms of the read only tracking db with other
internal dbs.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11577
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Wed Oct 28 06:13:09 CET 2015 on sn-devel-104
commit cbae31c7946fc13c3a00bc81a102e90fdec00018
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 27 12:06:25 2015 +1100
build: --picky-developer implies --enable-developer
Have --picky-developer enable --enable-developer too, instead of
requiring both options to be specified. This makes it obey the
principle of least surprise.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Tue Oct 27 07:19:33 CET 2015 on sn-devel-104
commit 151a7dabd5f6bf7560c701cc1cfcde4c63f5b6d9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Oct 26 15:58:36 2015 +1100
ctdb-build: Define CTDB_SOCKET at configure time
Currently only Samba is built with CTDB and since CTDB headers are not
public any more, no other application can build with CTDB. So define
CTDB_SOCKET only during build.
In future CTDB will have public API and proper way of figuring out
CTDB_SOCKET.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit af99846ac58fed268bee8b35e331a05174f547e0
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 14:24:48 2015 +1100
ctdb-tool: Remove repack command
The databases are repacked automatically during vacuuming when the
freelist size grows beyond configured threshold (RepackLimit).
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 47cddb699a28560556ed7db8eb829628407f2e22
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 13 16:19:21 2015 +1100
ctdb-ib: Fix build for infiniband transport
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 42b1d30fbb3fc6bbc06c3a9a1802cab6f2cc769c
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 23 19:10:28 2015 +1100
ctdb-daemon: Keep protocol.h in sync with ctdb_protocol.h
ctdb_protocol.h was modified to update default capabilities without
corresponding changes in protocol.h.
(Patch dfc84fdd45a9bd763289b4965bc2d0a3e7071ff0)
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 84b7a9f939f43baf33de4384a8c06687dd4e9c2b
Author: Thomas Nagy <tnagy at waf.io>
Date: Sun Oct 25 13:30:59 2015 +0100
build:wafsamba: dead code removal in gettext detection
Since the --gettext-location command-line option has no effect, the misleading
code is removed. The samba functions ADD_CFLAGS must also be used in the future
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Oct 27 03:34:28 CET 2015 on sn-devel-104
commit f9d6be3b749313a03e9097d848ce078f19197a0a
Author: Uri Simchoni <uri at samba.org>
Date: Mon Oct 26 07:38:08 2015 +0200
selftest: Avoid system krb5.conf in "none" test env
Some torture tests do not perform Kerberos activity and do not
run against a server (hence the "none" test env), but do create
a krb5 context, and that causes the Kerberos libs to read
krb5.conf and choke if they don't understand it.
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 8d3106b1a4d9da5bf8b127fa70a77076d3dfeca8
Author: Uri Simchoni <uri at samba.org>
Date: Sun Oct 25 15:02:17 2015 +0200
selftest: Avoid system krb5.conf in some test envs that don't use kerberos
Some test envs don't use kerberos (e.g. nt4_dc). However, the client
tools are built with Kerberos support and may get upset if hitting
a krb5.conf file they don't understand.
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 63c891938a2d3e1c222898d6dea5c640822b0191
Author: Uri Simchoni <uri at samba.org>
Date: Sat Oct 24 00:41:23 2015 +0300
selftest: Avoid system krb5.conf in testenv provisioning
Some provisioning commands don't necessarily need a krb5.conf,
but they still must cause samba's Kerberos libraries to avoid
looking at the system krb5.conf, as this file may not be understood
by samba's Kerberos libs and fail the env provisioning.
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 843cb8ec5b92ef72421952d5503c1deec1559fe8
Author: Scott Lovenberg <scott.lovenberg at gmail.com>
Date: Tue Oct 20 12:20:10 2015 -0700
Documentation : Add GitHub notes to README.
Signed-off-by: Scott Lovenberg <scott.lovenberg at gmail.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 53509452db3c61db78eeafb8201ab5fdd7e4b5e0
Author: Andreas Schneider <asn at samba.org>
Date: Mon Oct 26 19:53:58 2015 +0100
WHATSNEW: Describe nss_wins changes
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Oct 27 00:27:22 CET 2015 on sn-devel-104
commit 5ab1452436a5be5fbdf892343a4fc710f387eabf
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 23 12:31:43 2015 +0200
nss_wins: Use libwbclient to query wins server
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11563
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 0abbfb2e4d5bcd847983ef7981840f1eab7b917c
Author: Andreas Schneider <asn at samba.org>
Date: Fri Oct 23 15:28:23 2015 +0200
nss_wins: Use lp_global_no_reinit()
This avoids that we run into use after free issues when we access memory
allocated on the globals and the global being reinitialized.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11563
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 0d962e010ea834c0479f403a4c8b38b05b7a0409
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 23 15:38:23 2015 +1300
selftest: Confirm a demote of a real network works
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Oct 26 08:17:47 CET 2015 on sn-devel-104
commit be2e0e6ff7e7388711c1d1570057ec0dfd36c39d
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 23 15:05:25 2015 +1300
selftest: Add sample provision of master-c596ac6 with multiple DCs
This will let us test demoting a DC from a multi-DC network
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
commit 97577fd0888feefc72365c534c8adbff69467404
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 22 12:01:48 2015 +1300
Add samba4.smb2.create.mkdir-dup(ad_dc_ntvfs) as flapping
This test sometimes succeeds, depending on the build environment.
(Corrects earlier patch to also remove from knownfail)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11486
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 55a13e17b36adc69eb4ec7d706cb9a55906f8275
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 20 13:48:07 2015 +1300
samba-tool domain demote: Add support for removing by NTDS GUID
This would help remove a DC that is a conflict record, for example
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit e57dcddfe8ca4c2b5591cf3e1687d1ef89112c1a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 16 13:47:29 2015 +1300
samba-tool domain demote: Add --verbose and --quiet options
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 642de9193fa0f9ad54a1881c8657354fec87b6ac
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 16 13:00:20 2015 +1300
samba-tool domain demote: Remove dns-SERVER object as well
This object is not in standard AD, but Marc Muehlfeld
correctly notes that Samba creates it for BIND9_DLZ
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 145bb6fd7b0e7c9364005ea140c8ea7bc9b65395
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 14 16:57:31 2015 +1300
samba-tool domain demote: Remove all references to the demoted host, even in DNS
We search the in-directory DNS records for entries that point to the
name or IP that the dead DC was using, and remove them
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 3226077627c9301bd27b9bdff6ea5db4c1579659
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 14 16:56:41 2015 +1300
pydns: Add replace_by_dn()
This allows us to find a DNS record by searching LDB and unpacking the dnsRecord
but replace the record using the common code that will create a tombstone
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit a3b92a50d13a0a0d444b156c6dcffa0eebb9c03b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 23 13:12:03 2015 +1300
samba-tool domain demote: Use dn.add_base/dn.add_child
This is done primarilly to set the pattern that we should manipulate ldb.Dn values
with the helper routines, not just by concatonation via format strings.
We also restrict our exception hadling to only the expected errors, not
all errors.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 00ffb67be2c73582502ef1d2931853ec9899a9ef
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 23 13:05:24 2015 +1300
samba-tool domain demote: Remove correct DNs and from the correct locations
The previous code missed the CN=DFSR-GlobalSettings children and did
not cope with subdomains. The root DN may not be the domain DN if
we are a subdomain.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit fff09dae6d299a2b45bda44264c98cfde2348880
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 14 11:59:26 2015 +1300
dns_server: Give WERR_DNS_ERROR_NAME_DOES_NOT_EXIST on empty records
When not looking for tombstones, a record without a dnsRecord value may as
well not be present, so just return WERR_DNS_ERROR_NAME_DOES_NOT_EXIST
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 27039a7b1cfe16f40e07c6179887d2ab4f4967a5
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 13 16:41:44 2015 +1300
selftest: Add tests confirming the demote actually removes objects
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit e432c1b6826ecafeb355bd1d06e33f2eb67e58b8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 13 15:26:20 2015 +1300
samba-tool domain demote: Refuse to remove ourself
This ensures that a different server is the one being demoted from the local database
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 097435cfd9ba1bc3778e1637b55e78e5ba182061
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Oct 13 15:23:55 2015 +1300
selftest: Run samba-tool domain demote while we have a clone of the DB handy
This avoids needing to run the demote on the main replicated DB
of the selftest system
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 1f8835371328689b9ffff57f0ad77cca057e3f91
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Sep 24 14:07:51 2015 +1200
samba-tool domain demote: Rework to allow cleanup of partial demotion, catch more errors
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 8086900077a23c1c8d94afe691d99d180a297d81
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 22 15:51:33 2015 +1200
selftest: Make it clear that the first argument to KCC.run() is unused
This is unused because we have already provided a database via import_ldif
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 6965c981597896486caf9bddd1fe7b5674771004
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 22 15:40:00 2015 +1200
selftest: Run demote test against the RODC environment also
commit cf075f23816007694823c4ec6a4695e86f3471c6
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 22 15:39:19 2015 +1200
selftest: Reorder tests.py to ensure that demote, then dbcheck run last.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit f121173cbf46fe64746d73adf40015c43d5c55fc
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Oct 23 11:23:05 2015 +1300
samba-tool domain demote: Allow to operate on an RODC and a subdomain
On an RODC the local database cannot be modified, and the flags to remove
are different, we need instead to remove UF_PARTIAL_SECRETS_ACCOUNT.
If we are in a subdomain, then db.get_root_basedn() points to the
forest root, not the root of our domain
If the removeDsServer() fails with WERR_DS_DRA_NO_REPLICA
this may be reasonably considered to be success in this case.
Finally, the remove_dc.remove_sysvol_references() is reused
for objects not under the computer account.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
domain demote
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 1874f592006d8808aa8f3bc97c94d9464a7053cf
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 14 15:56:52 2015 +1200
samba-tool domain demote: Add --remove-other-dead-server
The new version of this tool now can remove another DC that is
itself offline. The --remove-other-dead-server removes
as many references to the DC as possible.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 2191fcaedc5efb703730839f09606fd0fd27da94
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 22 15:32:57 2015 +1200
dns_server: Add python method to extract a DNS entry from a ldb.MessageElement
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit b48776d78b446ad4abd4a6bc2ba6b488a29b11d2
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 22 15:25:30 2015 +1200
pydsdb: Also accept ldb.MessageElement values to dsdb routines
This shows the correct way to accept a value that may be a list of strings
or a proper ldb.MessageElement.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 87cd68c1dc0427521061f8febbcc18d73e21ab18
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 22 12:11:04 2015 +1200
dns_server: Add a python module directly accessing DNS records in sam.ldb
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 0504065948eec9bd65296d5956b5863d9af06e41
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 22 12:10:00 2015 +1200
dns_server: Put more code in common
This will allow a python module to be written to modify DNS entries in sam.ldb directly
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 2715805f4c617b9a5d9ae7d2252c6adb30ab6490
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 14 13:47:31 2015 +1200
selftest: Add tests for samdb_to_ldif_file
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit dadfffb51916ab26de51924733b31969173627a7
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Sep 14 13:48:04 2015 +1200
python/kcc: Write correct module list into the file during ldif_to_samdb
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 1c02f2801ecd05df23730eea2b6e162f4d5186f1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 14 13:49:01 2015 +1300
ldb: Fix python bindings to accept a string as a DN
This fixes add_base(), add_child() and is_child_of().
This removes a toally incorrect cast of struct ldb_dn to struct ldb_context.
A helper routine is used instead
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit ffe8090c898ac649b132fbfc7d79965dd98ff6c1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Oct 12 17:50:27 2015 +1300
samba-tool drs clone-dc-database: Require --targetdir
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 04512d1a9d9325ed6cd924b47ca22a7049cca8ac
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Aug 19 13:30:55 2015 +1200
repl: Use DSDB_REPL_FLAG_PRIORITISE_INCOMING in samba-tool drs replicate --local
Previously this would only be set when we did server-to-server replication
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit d1d5ec311a6dd2fabe92b7dd89c156a4288490e4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Aug 19 13:29:35 2015 +1200
samba-tool drs clone-dc: Add --include-secrets option
This allows the creation of domain clones that have no secrets,
and so make it safer to examine databases that demonstrate issues
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 4b25650577cd5c20729f3405c64c20ddf71b0ae3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Aug 19 13:26:41 2015 +1200
repl: Give an error if we get a secret when not expecting one
We should never get a secret from a server when we specify DRSUAPI_DRS_SPECIAL_SECRET_PROCESSING
This asserts that this is the case.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 6d301ad1c9ff0f1ccd4f97bd5f234b10707a15bf
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 17 15:33:31 2015 +1200
samba-tool: Add new command 'samba-tool drs clone-dc-database'
This command makes a clone of an existing AD Domain, but does not
join the domain. This allows us to test if the join would work
without adding objects to the target DC.
The server password will need to be reset for the clone to
be any use, see the source4/scripting/devel/chgtdcpass
(Based on patches written with Garming Sam)
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 80171ddcff792081415f4a4cb5614043338d9b81
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Aug 25 15:51:19 2015 +1200
samba-tool: Remove vampire subcommand and now unused libnet_Vampire()
This has been deprecated for a long time now
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 6cd8e79257a653e5df79c6bebb8689c0203a4f48
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Sep 24 14:08:37 2015 +1200
repl_meta_data: Print more detail into the LDB error string, not just DEBUG()
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Garming Sam <garming at catalyst.net.nz>
commit 0a924d13cf4bb570cce3955cf0de9d8678b37dbe
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 6 16:10:43 2015 +0200
smbd: Send SMB2 oplock breaks unencrypted
This is not what Windows server does, but it seems that Windows
clients expect. Windows->Windows never runs into this issue, because
an encryption-enabled SMB3 connection will always use leases, and lease
breaks *are* unencrypted...
You can reproduce the issue Windows->Windows by disabling leases on the
Windows server. Disable leases using the registry key:
HKLM\SYSTEM\CurrentControlSet\Services\LanmanServer\DisableLeasing
Dochelp confirmed that this is a valid workaround for Windows clients
dropping encrypted oplock breaks.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11570
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Oct 24 05:01:32 CEST 2015 on sn-devel-104
commit 11620aefac77ebeb58cce784d20d4415d227f4ee
Author: Anoop C S <anoopcs at redhat.com>
Date: Tue Oct 20 11:23:23 2015 +0530
smbd/quotas: Remove invalid quota status switch case
getquota_rslt structure from rquota.h defines the enum
named status whose values start from 1. But in quotas.c
we have an invalid check for status 0. This change is
to remove that particular switch case.
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Oct 24 01:31:21 CEST 2015 on sn-devel-104
commit 3e6af7109eb9d49328b426095580e4bfb2338ceb
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 22 13:54:41 2015 +1300
autobuild: Confirm we can build without --enable-developer
We also confirm that such builds do not contain the NTVFS file server
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d7cc5d459cbb063de9e5ff82487c383c00beb610
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 22 12:01:48 2015 +1300
Add samba4.smb2.create.mkdir-dup(ad_dc_ntvfs) as flapping
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 71dcc76b70d8e249624f9bf057fc4fd3a44125e1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Oct 10 09:30:17 2015 +1300
build: Enable NTVFS file server to be omitted
We now only build it by default with --enable-sefltest, or otherwise
if requested.
The NTVFS file server still has features not present in the smbd file
server, such as a CIFS/SMB proxy, and a radically different design,
but it is also not undergoing any ongoing development so this keeps it
in a safe state for care and maintaince, with less of a security risk
if such an issue were to come up.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0ccf842e12c0b5de52a89f1b6d74eba3a5e3feb5
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 20 12:38:38 2015 +1100
ctdb-scripts: Use "ctdb ip all" instead of "ctdb ip -n all"
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Fri Oct 23 06:44:45 CEST 2015 on sn-devel-104
commit 94898dd5b0770683181ece15a9ad9c9f5d9286e9
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 20 12:37:17 2015 +1100
ctdb-doc: Stop using "ctdb -n all ..."
This is deprecated. For many commands it doesn't make sense. Instead
of "ctdb ip -n all" use "ctdb ip all".
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit f7c414d4c972d388c8281f7306636db85d9fa1c4
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 20 12:28:16 2015 +1100
ctdb-tests: Change "ctdb ip -n all" to "ctdb ip all"
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 8c2048b9d56ae432ecb8400591ceefc73d7d8cc6
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 20 12:25:01 2015 +1100
ctdb-tools: Support "ctdb ip all" as equivalent to "ctdb ip -n all"
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 5d2c9436ed4824b3f381665361ab29c089f175c3
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Oct 20 12:12:39 2015 +1100
ctdb-tests: Do not test "ctdb nodestatus -n all"
This is low value and will no longer be supported.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit a94378e3f1a0f94c2910ed084a5d182f3c0e38e3
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Oct 19 16:51:48 2015 +1100
ctdb-tests: Drop use of "ctdb delip -n all" in simple tests
Add new function delete_ip_from_all_nodes(). Also
ctdb_get_all_pnns().
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit c607989d91b64d837253aae794b1a3d6013eb3e0
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Oct 19 16:05:44 2015 +1100
ctdb-tests: Drop simple uses of "ctdb -n all ..." from simple tests
None of these uses of -n are particularly useful. "-n all" will be
deprecated.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit c466ad47d53b1f3fbfc582a89f4b90a2c5dee2e9
Author: Tom Schulz <schulz at adi.com>
Date: Thu Oct 22 11:12:01 2015 +0200
texpect: undefined symbol rep_fprintf
Add libreplace dependency to texpect, fixes a linking error on Solaris.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11511
Signed-off-by: Tom Schulz <schulz at adi.com>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Thu Oct 22 14:28:17 CEST 2015 on sn-devel-104
commit d4059e1a53ea8940b1b147d797efa1b39a5cabd1
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 21 11:13:46 2015 -0700
auth: gensec: Parameters out_mem_ctx and ev are passed in the wrong order to gensec_spnego_server_try_fallback().
Fix suggested by <lev at zadarastorage.com>. Fixes a memory leak.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11565
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Oct 22 11:27:19 CEST 2015 on sn-devel-104
commit f1c49d7656b29b2e77e9373ccb863f07e19e5299
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 21 15:15:51 2015 +0200
messaging: Fix creating the dgm lockfile
There might be situations where the lock directory moves to a
location where a previous installation left the datagram sockets
(Yes, I just came across this). We can't really deal with it except
by just removing the socket without properly checking.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Oct 22 02:14:29 CEST 2015 on sn-devel-104
commit 3e705adcab8404ee6e5f71a38e98eeaca29a5b61
Author: Ralph Boehme <slow at samba.org>
Date: Wed Oct 21 16:08:00 2015 +0200
lib/tsocket: fix non-blockging connect() error handling
Non-blockging connect() either returns immediate success, or -1 with
errno EINPROGESS as indication that the connection is pending. All other
errnos indicate immediate failure.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 41fe3cfcb5fa2441da9180e57255a3b7fa23da12
Author: Christof Schmitt <cs at samba.org>
Date: Wed Oct 21 11:12:22 2015 -0700
README.Coding: Update section about debug macros
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b041a589ae680de38f4e9c8c4979c3972a4e7b07
Author: Christof Schmitt <cs at samba.org>
Date: Wed Oct 21 11:07:57 2015 -0700
Remove function name from callers of DBG_*
It is now added automatically.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1d3df7e18def05c4552f4647b3644f7b7952fc66
Author: Christof Schmitt <cs at samba.org>
Date: Wed Oct 21 11:07:35 2015 -0700
debug: Prefix messages from DBG_* with function name
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 38d547bc0d39b56a7491a5f220905f1756c1530a
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Oct 21 12:01:26 2015 +0200
dcerpc.idl: accept invalid dcerpc_bind_nak pdus
Older Samba versions (<= 4.1) had a bug in the dcerpc_bind_nak
idl, see commit f73ef3028c4f4583c81b611a9714608eae79360c.
Note: ndr_pull_dcerpc_bind_nak() was generated by pidl and
has been extended by the (_available == 0) check.
That's why we ignore the 80 char per line limit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11327
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Oct 21 20:34:28 CEST 2015 on sn-devel-104
commit 7cf45539da9cba25130457941814da12d0a828c3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 21 10:37:25 2015 +1300
selftest: Fix memset parameters in test for async_connect_send()
This fixes:
../lib/async_req/async_connect_send_test.c: In function ‘main’:
../lib/async_req/async_connect_send_test.c:88:3: error: ‘memset’ used with constant zero length parameter; this could be due to transposed parameters [-Werror=memset-transposed-args]
memset(&addr, sizeof(addr), 0);
^
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11564
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Wed Oct 21 17:31:00 CEST 2015 on sn-devel-104
commit f99d0b917419756b11f0ebfecbe84b3ebab7fa0a
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Oct 21 10:02:33 2015 +0200
script/release.sh: make it possible to create stable .x releases (x >= 1)
This version was used to create samba-4.3.1.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Karolin Seeger <kseeger at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Wed Oct 21 14:27:53 CEST 2015 on sn-devel-104
commit 800437c1b1dd036661b834abd764433ef1cffc06
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Wed Jul 1 10:45:47 2015 +1200
autobuild: add some system information to the autobuild tarball
When running multiple autobuilds on VMs with various parameters, you
can easily get confused about which was which, and the tarball doesn't
help much. This adds an extra file with information about the system.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f1835d85310dbb2f7e4617c9cc162a00e6641802
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Oct 21 14:10:57 2015 +1300
dynconfig: Use replace.h and memory.h directly, not via includes.h
includes.h brings in talloc.h, but this was recently removed as a dependency.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Wed Oct 21 11:26:38 CEST 2015 on sn-devel-104
commit e4054f211872168ac4cf022e2d961e8979610920
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 20 12:31:03 2015 -0700
s3-torture: Remove (incorrect) samba3-specific behavior in samba3.raw.unlink now the server is correct
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11452
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 618d3dd5990e7477d45220cf7183c5cdaa548f1a
Author: Jeremy Allison <jra at samba.org>
Date: Mon Oct 19 16:06:01 2015 -0700
s3-torture: Add WILDDELETE test to smbtorture3 to test old wildcard delete with zero attribute
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11452
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 1d51119f8acaa586e9ec09d14f10b43ed0053df5
Author: Jeremy Allison <jra at samba.org>
Date: Mon Oct 19 16:04:02 2015 -0700
s3-smbd: Fix old DOS client doing wildcard delete - gives a attribute type of zero
In the wildcard delete path we forgot to map 0 -> FILE_ATTRIBUTE_NORMAL
as we do in the non-wildcard delete path.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11452
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 7f8f1ab9a48cd0e90c0b18a73956c25afb528a99
Author: Ralph Boehme <slow at samba.org>
Date: Thu Oct 15 10:06:42 2015 +0200
net: print file path in serverid wipedbs --verbose
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Oct 21 03:10:28 CEST 2015 on sn-devel-104
commit f00dd4a8d13bb6806ac2b123a99ad9db8a8a2482
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Mar 17 16:05:37 2015 +1300
provision: Allow more OS levels in sambadns
While we do not support these yet, they make no difference to DNS, so permit up to 2012R2
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Oct 20 23:23:13 CEST 2015 on sn-devel-104
commit 35f267304e89d870cbd645dbba8ed06f88686e1a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Mar 17 16:02:52 2015 +1300
dsdb: Add functional levels for 2012 and 2012R2
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e8bab905d304158c63e6af54903aea10a63684e1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Aug 11 14:03:55 2015 +1200
samba_upgradedns: Remove unused variable
dnssecret is not used at any point later in the script
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5701b99b5c134ee6ffffa0f34c2797c9c814d280
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Aug 7 16:27:23 2015 +1200
samba-tool dns: Trap on conneciton errors and give useful info
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 751ea346bc9a1b915ec11b59d04f585647a2e385
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Aug 7 12:53:08 2015 +1200
selftest: Correct comment about MAX_WRAPPED_INTERFACES
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 56dd83b9f662cde99b7d00b8250e36cd5947a86c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 31 12:51:14 2015 +1200
torture: Add better debug message when tsocket_address_inet_from_strings fails
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 05d4dbda8357712cb81008e0d611fdb0e7239587
Author: Ralph Boehme <slow at samba.org>
Date: Sun Oct 18 22:21:10 2015 +0200
async_req: fix non-blocking connect()
According to Stevens UNIX Network Programming and various other sources,
the correct handling for non-blocking connect() is:
- when the initial connect() return -1/EINPROGRESS polling the socket
for *writeability*
- in the poll handler call getsocktopt() with SO_ERROR to get the
finished connect() return value
Simply calling connect() a second time without error checking is
probably wrong and not portable. For a successfull connect() Linux
returns 0, but Solaris will return EISCONN:
24254: 0.0336 0.0002 connect(4, 0xFEFFECAC, 16, SOV_DEFAULT) Err#150 EINPROGRESS
24254: AF_INET name = 10.10.10.143 port = 1024
24254: 0.0349 0.0001 port_associate(3, 4, 0x00000004, 0x0000001D,0x080648A8) = 0
24254: 0.0495 0.0146 port_getn(3, 0xFEFFEB50, 1, 1, 0xFEFFEB60) = 1 [0]
24254: 0.0497 0.0002 connect(4, 0x080646E4, 16, SOV_DEFAULT) Err#133 EISCONN
24254: AF_INET name = 10.10.10.143 port = 1024
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11564
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit aa96c75346a9bad60471a206d65c7b7049b9ca83
Author: Ralph Boehme <slow at samba.org>
Date: Sun Oct 18 22:23:20 2015 +0200
selftest: add a test for async_connect_send()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11564
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6c81ecc795d729fc049d42b4df6deff520edd81a
Author: Ralph Boehme <slow at samba.org>
Date: Tue Oct 20 12:01:22 2015 +0200
README.Coding: initialize pointers
Pointers must be initialized to NULL.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1dba49859348d01558d434bfa65734ff532b09c9
Author: Ralph Boehme <slow at samba.org>
Date: Tue Oct 20 11:35:23 2015 +0200
s4:lib/messaging: use a helper variable for tdb flags
Small refactoring that eliminates a nested function call. These are a
pita when stepping with gdb.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11562
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Oct 20 14:54:57 CEST 2015 on sn-devel-104
commit 79ec9cbff9b8b84ac80c6d2a8220b37561415271
Author: Ralph Boehme <slow at samba.org>
Date: Wed Oct 14 12:40:03 2015 +0200
s4:lib/messaging: use correct path for names.tdb
source3 messaging_init() calls server_id_db_init() (where names.tdb is
created) with lock_path. source4 imessaging_init() otoh wrongly used the
special lock_path subdirectory "msg.lock":
> find /opt/samba/ -name names.tdb
/opt/samba/var/lock/msg.lock/names.tdb
/opt/samba/var/lock/names.tdb
> tdbdump /opt/samba/var/lock/names.tdb
{
key(14) = "notify-daemon\00"
data(27) = "28609/12756565486113779780\00"
}
> tdbdump /opt/samba/var/lock/msg.lock/names.tdb
{
key(15) = "winbind_server\00"
data(8) = "28593/0\00"
}
With this patch both source3 and source4 messaging now use the same
names.tdb which is what we want:
> find /opt/samba/ -name names.tdb
/opt/samba/var/lock/names.tdb
> tdbdump /opt/samba/var/lock/names.tdb
{
key(15) = "winbind_server\00"
data(8) = "26434/0\00"
}
{
key(14) = "notify-daemon\00"
data(26) = "26452/3454520012124001687\00"
}
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11562
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 19a0a7f33ca71a39859706d726eaf70882362c93
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Sep 8 15:47:26 2015 +0200
script/release.sh: make it possible to create stable .0 releases
This version was used to create samba-4.3.0.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Karolin Seeger <kseeger at samba.org>
commit 3194a4d342605a0a21f4bda55cd43c6eb983f941
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 14 11:41:23 2015 +0200
lib: Remove unused serverid_get_random_unique_id
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Oct 19 15:12:22 CEST 2015 on sn-devel-104
commit 22b320caa02ea000314d9ff0c3c7fd8c6b9c4318
Author: Volker Lendecke <vl at samba.org>
Date: Wed Oct 14 11:31:07 2015 +0200
lib: Add some debug to dgm_ref
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 01d7e26f7faa82da55aa66af28c5b224c7caa792
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 21:30:30 2015 +0200
lib: Push down unique generation one level
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit a788fd306580952d83007319fca12635e431354c
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 20:59:57 2015 +0200
lib: Remove unused global my_unique_id
The unique_id is now always attached to a messaging_context.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 62f2b86f4fd262c1b299f8c7713e918f4e9a3be1
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 17:37:14 2015 +0200
lib: Remove unused procid_is_me()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit da88b0da6694936c2ea79ac59c4f902d6c5ffce0
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 17:28:14 2015 +0200
lib: Remove unused procid_self()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 6eb6622c13f74fd68ce0fe3fe9623bc967d3ce01
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 17:26:34 2015 +0200
lib: Remove procid_self() from messages.c
This together with the removal of procid_self obsoletes the global
my_unique.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit b9fd6e24847826bf948041ed56bfd8767ec5db78
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 16 11:36:48 2015 +0200
lib: Fix pid_to_procid()
Putting in my_unique_id is just wrong. Now that we have
a cheap way to read everyone's unique ids out of the lockfile,
we can fix it.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit ad924ab859f648587515304cde7054a1bf91b8a3
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 17:21:55 2015 +0200
winbindd: Remove reference to procid_self()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit bcc152166286b5d3c4c23d055482865da86ee07a
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 17:21:30 2015 +0200
fssd: Remove reference to procid_self()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 46308bb2a6729dbf6ad913bd1cfab18827c62835
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 17:20:48 2015 +0200
auth: Remove procid_self() from auth_samba4
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 7c483690ac6ed007798aeeb7b8549c9d55877e56
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 16 15:13:47 2015 -0700
smbd: Fix file name buflen and padding in notify repsonse
The array is uint16, doubling the file name length consumes twice the space
required.
As we're hand assembling this as a series of concatinated individual data_blobs,
we must take care to ensure the correct 4 byte alignment that was
being masked by the previous doubling of the filename length.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10634
Signed-off-by: Jeremy Allison <jra at samba.org>
Signed-off-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sun Oct 18 01:56:41 CEST 2015 on sn-devel-104
commit 2881679e3ecbaf07cdd82ba65af8d55e5e3be800
Author: Ralph Boehme <slow at samba.org>
Date: Mon Aug 24 17:45:14 2015 +0200
vfs_streams_xattr: fix and simplify streams_xattr_get_name()
streams_xattr_get_name() fails to chop off the stream type in case
config->store_stream_type is false and the passed stream name contains a
stream type.
Eg when the passed in stream name is ":mystream:$DATA", but
config->store_stream_type is false, we must generate a xattr name of
"mystream" or "user.mystream".
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11466
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Oct 16 23:27:01 CEST 2015 on sn-devel-104
commit fedd09662c889fb796135d86836c160171fac68d
Author: Ralph Boehme <slow at samba.org>
Date: Mon Aug 24 17:43:40 2015 +0200
vfs_fruit: hide the Netatalk metadata xattr in streaminfo
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11466
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c8ee1a059b4484575b03ac76b469df85cdabdd9a
Author: Ralph Boehme <slow at samba.org>
Date: Mon Aug 24 17:42:35 2015 +0200
vfs_fruit: add and use define for the Netatalk metadata xattr
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11466
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c4bdba97b4b09196765bb3a486b16294c28772b8
Author: Anoop C S <anoopcs at redhat.com>
Date: Fri Oct 9 11:32:52 2015 +0000
s3.lib: Remove invalid switch case from sysquotas_nfs
getquota_rslt structure from rquota.h defines the enum
named status whose values start from 1. But in
sysquotas_nfs.c we have an invalid check for status 0.
This change is to remove that particular switch case.
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2bad085305f8ddad5e46a567c63a244362699187
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 10 12:40:13 2015 +1200
build: Build *_wrapper without -DNDEBUG for in-tree use
These binaires are not installed, so are only used in make test,
and there we need debug output.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Oct 16 16:36:22 CEST 2015 on sn-devel-104
commit 8bb44c53b49b1131c5d3ff3b3eb0f5c635519fb5
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Oct 1 17:24:02 2015 +1300
ntlm auth: spelling fixes
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 7163e08caa154b2680eba850c9e6766d1929fb91
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Aug 20 10:00:11 2015 +1200
samba-tool --help: possessive pronoun "its" has no apostrophe
"it's" is reserved for the contraction of "it is".
This *is* somewhat illogical, which is how you know its proper
English.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6456b062948e1e3058c7900ff039016db3421df5
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Oct 14 15:06:56 2015 +1100
ctdb-scripts: Lock debugging should print kernel stack for process in D state
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit dfc84fdd45a9bd763289b4965bc2d0a3e7071ff0
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Oct 8 20:25:20 2015 +1100
ctdb-daemon: Change handling of default capabilities
Centrally define all the default capabilities to make the defaults
crystal clear. Capability-related command-line options now have a
direct correspondence rather than a reverse correspondence.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 5aab31a39a3589b910a78b96071d6aa5e6547696
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Oct 16 14:45:28 2015 +1100
ctdb-recovery: Update vnnmap before database recovery
Once the databases are recovered, all the pending calls are resent.
If the vnnmap is not updated, then the nodes can redirect calls to nodes
that are not part of the new vnnmap.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Fri Oct 16 09:31:34 CEST 2015 on sn-devel-104
commit 30460fc45ef7414ae6e23683f60d64edd5d3e9dc
Author: Anubhav Rakshit <anubhav.rakshit at gmail.com>
Date: Wed Oct 14 18:16:06 2015 +0530
s4:torture: Add test case for Replay of Persistent Handle on a Single Channel.
Signed-off-by: Anubhav Rakshit <anubhav.rakshit at gmail.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Oct 16 02:00:28 CEST 2015 on sn-devel-104
commit 8bcbb6fb16c13d20556fc50ea2744020cb895be3
Author: Jeremy Allison <jra at samba.org>
Date: Wed Oct 14 11:20:08 2015 -0700
s3: test: Fix standalone valid users fileserver test.
Test was originally added for bug #11320. At the time
I remarked the only way I could get this to reproduce
the issue was to use "+WORKGROUP\userdup" instead of
just "+userdup" (which was the actual problem reported),
but I didn't investigage enough to discover the underlying
problem which is actually bug:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11555
(lookup_names() logic for unqualified (no DOMAIN\
component) names is incorrect). On a standalone
fileserver "WORKGROUP\name" should not resolve,
but "NETBIOS-NAME\name" and just "name" should.
This corrects the test now that lookups for unqualified
names are now being done correctly.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Thu Oct 15 22:58:54 CEST 2015 on sn-devel-104
commit 2f6dc260ada6cd178a650ca003c2ad22e12697c1
Author: Jeremy Allison <jra at samba.org>
Date: Thu Oct 15 09:20:58 2015 -0700
s3: lsa: lookup_name() logic for unqualified (no DOMAIN\ component) names is incorrect.
Change so we only use unqualified name lookup logic if
domain component = "" and LOOKUP_NAME_ISOLATED flag is
passed in.
Remember to search for "NT Authority" *before* going
into unqualified name lookup logic.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11555
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit 23f674488a1f62fcc58bb94bed0abed98078b96d
Author: Ralph Boehme <slow at samba.org>
Date: Thu Oct 15 12:35:26 2015 +0200
s3:lib: validate domain name in lookup_wellknown_name()
If domain argument is not an empty string, only search the matching
wellknown domain name.
As the only wellknown domain with a name is "NT Authority", passing ""
to lookup_wellknown_name() will search all domains inlcuding "NT
Authority".
Passing "NT Authority" otoh will obviously only search that domain.
This change makes lookup_wellknown_name() behave like this:
in domain | in name | ok | out sid | out domain
========================================================
Dialup + S-1-5-1 NT Authority
NT Authority Dialup + S-1-5-1 NT Authority
Creator Authority Dialup - - -
Creator Owner + S-1-3-0 ""
Creator Authority Creator Owner - - -
NT Authority Creator Owner - - -
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11555
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
commit 808f29cb2f9de47dcf78b380cc8767e9546e1954
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 13 15:33:47 2015 -0700
s4: torture: Add SMB2 access-based enumeration test. Passes against Win2k12R2.
https://bugzilla.samba.org/show_bug.cgi?id=10252
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Oct 14 19:00:03 CEST 2015 on sn-devel-104
commit b1bd84e9c9867092055f29fe39279e1c767f570a
Author: Jeremy Allison <jra at samba.org>
Date: Fri Oct 9 15:08:05 2015 -0700
lib: cli: Add accessor function smb2cli_tcon_flags() to get tcon flags.
We need this to see if a share supports access-based enumeration.
https://bugzilla.samba.org/show_bug.cgi?id=10252
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit cc05f73872c36cd307da3d6fed200beb16d5c2a8
Author: Jeremy Allison <jra at samba.org>
Date: Tue Oct 13 16:49:41 2015 -0700
s3: smbd: Fix our access-based enumeration on "hide unreadable" to match Windows.
Torture test to follow.
https://bugzilla.samba.org/show_bug.cgi?id=10252
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 5538e2a867b67198fb4146ad4a13d14142c9491d
Author: Michael Adam <obnox at samba.org>
Date: Wed Oct 14 11:21:52 2015 +0200
ctdb: fix typos in wscript comment.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit cf89c7f42ef7f2a8954cb3a9920f80ee4fddfb5f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Oct 14 10:09:08 2015 +1100
ctdb-tests: Fix CID 1327218-1327221
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Oct 14 13:32:02 CEST 2015 on sn-devel-104
commit 880b79addc80486e857174b13e63bc98b13f208c
Author: Ralph Boehme <slow at samba.org>
Date: Tue Oct 13 19:08:00 2015 +0200
s3:lib/messages: fix error check in messaging_filtered_read_send()
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Oct 14 10:21:09 CEST 2015 on sn-devel-104
commit 74013aeee38a5c40e8c9c01d2ea46143593840b0
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 13 20:42:06 2015 +0200
ctdb: Fix CID 1327223 Unbounded source buffer
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Oct 14 05:22:28 CEST 2015 on sn-devel-104
commit 593bdb97840d9fd29a2eaf04fc265c9dcc66886c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 13 20:40:54 2015 +0200
ctdb: Fix CID 1327224 Unbounded source buffer
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 826bffc7e6fcb1585833acd0d7822e7b09063b0d
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 13 20:34:24 2015 +0200
lib: Fix CID 1327227 Uninitialized scalar variable
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8eedd5c48b95624eb61ab0b4b332ac35e05a98b7
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 22:10:51 2015 +0200
libdap: Fix a '\0' vs NULL mixup
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d527ab10940d58337e3972e6bbcf9d26f56b7e0d
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 16:52:49 2015 +0200
ctdbd: Fix a typo
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 65e4829e880f5c4cd548791d462352e39968be1c
Author: Marc Muehlfeld <mmuehlfeld at samba.org>
Date: Mon Oct 12 22:49:10 2015 +0200
Fixes for server role parameter in smb.conf manpage
The manpage says that the value for an AD DC is "ACTIVE DIRECTORY
DOMAIN CONTROLLER", not "DOMAIN CONTROLLER", like mentioned in
the example.
Additinally the correct value for BDC is "CLASSIC BACKUP DOMAIN CONTROLLER"
Signed-off-by: Marc Muehlfeld <mmuehlfeld at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Tue Oct 13 09:38:01 CEST 2015 on sn-devel-104
commit 96108058d0d89593ac9f59433213ed2f66663186
Author: Thomas Nagy <tnagy at waf.io>
Date: Sat Oct 3 22:29:15 2015 +0200
build:wafsamba: Enable feature-compatible declaration for Waf 1.8
In Waf 1.8 the declaration is features='c', not features='cc'. These changes
prepare the replacement of Waf 1.5 by Waf 1.8 for Samba.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: David Disseldorp <ddiss at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit e73ccc06efc3b489cac33e99b2cb86e022aabd7f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 00:27:22 2015 +0200
Rely on /dev/urandom
This removes quite a bit of code. All reasonable systems have /dev/urandom
these days. Linux, Solaris and the BSDs do. In case we find a system
without /dev/urandom, we will have to go hunting in other libraries.
The main reason for this is speed: On Ubuntu 14.04 doing direct reads from
/dev/urandom is 2-3 times faster than our md4 based code. On virtualized
FreeBSD 10 the difference is even larger.
My first approach was to use fopen/fread. It was even faster, but less
than twice as fast. So I thought we could save the additional complexity
when having to deal with throwing away buffers when forking and the
additional memory footprint per process.
With this simple generate_random_buffer it will be easier to adapt new
syscalls to get randomness.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Oct 13 04:25:39 CEST 2015 on sn-devel-104
commit 5380f7b63648e505d6da25dc75d2487658998fdb
Author: Volker Lendecke <vl at samba.org>
Date: Sat Oct 3 00:27:22 2015 +0200
lib: Add a little tool to perftest generate_random_buffer()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 258ce91f3175196610b9db98c409749d33123038
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 15:57:34 2015 +0200
lib: Move sys_rw* to lib/util
genrand.c will require it soon
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0ef9c67b56a0b493ed06f9a64ac2bc2233041aee
Author: Ralph Boehme <slow at samba.org>
Date: Mon Oct 12 12:28:04 2015 +0200
s3:locking: initialize lease pointer in share_mode_traverse_fn()
Initialize lease pointer to point to the share_mode_data leases array
entry at index lease_idx.
This fixes a bug in smbstatus where the lease info is not printed.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11549
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Oct 13 01:14:09 CEST 2015 on sn-devel-104
commit cd0c2a5eca43cea76491ae0d820414287c234c1a
Author: Ralph Boehme <slow at samba.org>
Date: Sun Oct 11 09:38:18 2015 +0200
s3:smbstatus: add stream name to share_entry_forall()
Add stream name argument to share_entry_forall machinery so smbstatus
can print the stream name of a file.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11550
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d643aafe59738890cb8b71e2e865c56ea1fe6539
Author: Ralph Boehme <slow at samba.org>
Date: Wed Oct 7 14:28:32 2015 +0200
s3:smbd: remove unused arg oplock_request
The use of oplock_request in calculate_open_access_flags() was removed
in 196da5925.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3c00e8d76a2ef6194a8ce522c15853e5b8e9262b
Author: Andrew Bartlett <abartlet at samba.org>
Date: Sat Oct 10 08:45:41 2015 +1300
pam_smbpass: REMOVE this PAM module
This pam module causes GPLv3, thread-unsafe Samba code to be directly loaded
into the address space of many system services. The code in question was not
expected to run in this context, and while using the Samba, rather than the system
password file is a admirable goal, this needs to be done over inter-process
communication, such as is done by pam_winbind.
pam_winbind is not a total replacement, as the migrate functionality used
to keep the Samba password up to date with the system password is not
present, but otherwise can provide essentially the same services.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8807ad18c2cc1a0cdc4f47c294d44123d2a53ec8
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 12:17:56 2015 +0200
dynconfig: Fix deps, no talloc required
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Mon Oct 12 17:06:04 CEST 2015 on sn-devel-104
commit b5cf80a7b58095fd711968ef03f84740d0119553
Author: Volker Lendecke <vl at samba.org>
Date: Mon Oct 12 12:06:50 2015 +0200
talloc: Fix the O3 developer build
Compilers can't see that the child exits. Thus "exit_status" is
used uninitialized in the child.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 2f7bee43d8bcb8cc5205b159862e57954e4fc26c
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 9 12:18:53 2015 +0200
wbinfo: make --verbose --pam-logon print sids
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Oct 12 14:01:50 CEST 2015 on sn-devel-104
commit b95b2be8451e7804704dc2046b6c3eb35f79220e
Author: Richard Sharpe <rsharpe at samba.org>
Date: Sat Oct 10 17:58:59 2015 -0700
A small improvement to the DEBUG message when pass-through authentication
fails with ACCESS_DENIED. Increased it to log level 1 so it will print out
and pointed to Restrict NTLM as the setting so people know what to look for.
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Sun Oct 11 06:28:05 CEST 2015 on sn-devel-104
commit 7b6d1a2a5d5561e641d9001901b9e43a64117681
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Fri Sep 4 12:59:57 2015 +1200
talloc: Test that talloc magic differs between processes.
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Oct 9 23:15:06 CEST 2015 on sn-devel-104
commit 2b9bfab36d9ae0f7fa2a989195129a1a6b62393b
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Fri Oct 9 13:32:55 2015 +1300
talloc: Increment minor version due to added talloc_test_get_magic.
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 906a26a2abc70f824b654f71678314648b28d058
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Fri Sep 4 12:03:33 2015 +1200
talloc: Provide tests access to talloc_magic
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f5135bda942ff13f0baf2c629147d0755eb96090
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Wed Sep 2 13:30:31 2015 +1200
talloc: Test magic protection measures.
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4a4664a80e20544097cdd075ca5d1423e6a9b364
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Feb 24 13:43:54 2015 +1300
lib/talloc: Provide multiple-loading detection for libtalloc via rand()
The use of rand() is strongly discrouanged, but here is it ideal, as we just want to select a different
set of random bytes if we are called again within the same process.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 30ea897194c68c149d4986b22a5d964454bec258
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Oct 17 10:30:23 2013 +1300
lib/talloc: Disrupt buffer overflow attacks on Samba by using random magic
By setting the talloc magic to a random value, we make it much harder to overwrite a talloc_chunk
in a valid way with a simple buffer overflow.
The flags are placed before more senstive variables so they have to be overwritten first.
Inspired by the exploit in: http://blog.csnc.ch/wp-content/uploads/2012/07/sambaexploit_v1.0.pdf
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1dc05386f20481596ee7360d6f4e628a16675d3f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Feb 24 13:26:29 2015 +1300
build: Move __attribute__ ((destructor)) and ((constructor)) tests to wafsamba
This allows us to use them in talloc as well.
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f25a5c9e84e802bc7005d6bd400cbf784fb30fdf
Author: Richard Sharpe <rsharpe at samba.org>
Date: Wed Oct 7 17:19:38 2015 -0700
Fix a few small spelling mistakes in DEBUG messages to reduce confusion
for those trying to debug stuff.
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
Autobuild-User(master): Richard Sharpe <sharpe at samba.org>
Autobuild-Date(master): Thu Oct 8 08:48:06 CEST 2015 on sn-devel-104
commit 5709dece4860f205e31309e31ec4e3e938d9f6a5
Author: Uri Simchoni <uri at samba.org>
Date: Wed Oct 7 22:44:11 2015 +0300
vfs_commit: set the fd on open before calling SMB_VFS_FSTAT
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11547
Signed-off-by: Uri Simchoni <uri at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Oct 8 02:56:41 CEST 2015 on sn-devel-104
commit 2bc55c5321a44e439a2e00309e979c0188c3fc75
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make messaging_send_iov_from return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 678ad954e8734fce52d283e95c0b7c5c9d0d1318
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make messaging_ctdbd_init return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7ae694372ca0037f38b82b5069a54edaeeedbd90
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 22:33:12 2015 -0700
lib: Use poll_intr_one_fd in ctdb_read_packet
This is an actual bug fix if someone sets "ctdb timeout" to something != 0
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a599b96f2928e5c5ec801a8e26b08ef0c082831a
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 22:30:35 2015 -0700
lib: Remove messaging_tevent_context() dependency from ctdbd_conn.c
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6cc1e660eeb730b30cbd7bc323648444144db904
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_probe return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a6ddb991331ae07e18b9d8d12cabd25f2d82965a
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdb_unwatch return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b02fd997d26d20c207052707cda96581d6a97edb
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdb_watch_us return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2d00fcda69152688427e59d63425f0969a95f971
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_control_local return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a039463d823ad4e7fbff5a3f8e4416c184e40f36
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_register_ips return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4caf48ecb35ca6f7b07f8b67ea94284445911e49
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_traverse return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b78c282a91779fe53caaefca2c5a610d77694891
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_parse return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4636912985e47f0562524b33ba457e5e4d33a0b9
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_migrate return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 210e1fb265e4c1dde6a67aecfb72951703df3cc0
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_db_attach return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fdfc7299a67b5c7d0eac2d084a6e9ac490f083f5
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_messaging_send_iov return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 546d8b4129cb782c38337ed37a80420c3e846306
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_messaging_connection return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9da6cce5c064338ce63f394d9c3a64c449f41b66
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_init_connection return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 03fd13f01a6f5b4fbb3f9ab846d3326e81fb561b
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make ctdbd_register_msg_ctx return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f3c88bd6c2190cbb32501d2721d04bfc81ef4d22
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make get_cluster_vnn return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 84ad1a13721da44cf55650e04780a64cefe5f8e0
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:42:05 2015 -0700
lib: Make register_with_ctdbd return 0/errno
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7b8853fc42b929e9f14bf249998a6111c10aad66
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:31:52 2015 -0700
lib: Rename ctdbd_control_unix to ctdbd_control
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit fd6293c987f1d8c97be4bddd08301bc78a754a60
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:29:56 2015 -0700
lib: Remove ctdbd_control
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 108b6270f7bf702b13344386b8838fd645c13929
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:08:53 2015 -0700
lib: Use ctdbd_control_unix in ctdbd_register_ips
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit dae02e9adb4099a37501d9f234a351f34aadaa93
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:08:53 2015 -0700
lib: Use ctdbd_control_unix in ctdbd_db_attach
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a44894506e904a6f0076eed54969bd5cfcc55b7a
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:08:53 2015 -0700
lib: Use ctdbd_control_unix in ctdbd_db_attach
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 24d0add465e90183a244272fe8220c85e2f9409b
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:08:53 2015 -0700
lib: Use ctdbd_control_unix in ctdbd_dbpath
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ab79b952de8b0887a3e19e0f5e467e40ae4e793f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:06:59 2015 -0700
lib: Use ctdbd_control_unix in ctdbd_working
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4d43101500fb9339fc49e3f95bc5e1a23eff1b42
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:05:15 2015 -0700
lib: Rename a variable
We'll have "int ret" in the next commit
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a8c035fb6dfd88abd5eebb4d79c9e927b51b5a0d
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:00:32 2015 -0700
lib: Use ctdbd_control_unix in get_cluster_vnn
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a5438e09af4148abb71d5de70f7e220f0cfbbbdf
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 20:00:32 2015 -0700
lib: Use ctdbd_control_unix in register_with_ctdbd
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 858af0b4473d02e24be76e4baf51dec03ed99045
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 19:54:31 2015 -0700
lib: Add ctdbd_control_unix
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7b9016ac6723438ed1930d144eb109e3eb88677a
Author: Volker Lendecke <vl at samba.org>
Date: Fri Oct 2 19:51:01 2015 -0700
lib: Fix error talloc leaks in ctdb_read_packet()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 01017482876defa74137295fa08ed7f27fc12f61
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 6 17:31:41 2015 +1100
ctdb-recoverd: Always check for recmaster before doing recovery
Recovery daemon checks if it is the recovery master before performing
certain checks. During those checks it's possible that re-election can
change the recmaster. In such a case, the recovery daemon should never
do a database recovery.
This is not complete fix since the recovery master can still change
while the recovery is going on. The correct fix is to abort recovery
if the recovery master changes.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Wed Oct 7 17:55:05 CEST 2015 on sn-devel-104
commit 3cf93d91361191a7accdf0ddf5e811212e0a5ca2
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 6 14:46:48 2015 +1100
ctdb-recoverd: Get rid of connected-ness comparison in election
The reason for favouring more connected node is to create a larger
cluster in case of a split brain. In split brain condition, the nodes
are not communicating across partitions and each partition will run its
own election. Among all the partitions, the node which holds the recovery
lock will eventually "win". All the other nodes which won election but
could not grab recovery lock will end up banning themselves.
This also prevents the recovery master role from bouncing between nodes
during startup when the entire cluster is restarted.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit fbd9c9fd2f9a4e3e4cf03af574b322752670d632
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Oct 6 11:52:06 2015 +1100
ctdb-recoverd: Do not freeze databases for election
If election occurs during SMB activity, then trying to freeze all the
databases can cause samba/ctdb deadlock which parallel database recovery
is trying to avoid.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit ffff66b011131c16c369b397d6fcdd5b75a6db4e
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Sep 21 17:12:25 2015 +1000
ctdb-call: Improve a log message
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e6ff36506c820523ab23b3749227bf6df6218d76
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Sep 17 16:22:38 2015 +1000
ctdb-recoverd: Add code for parallel database recovery
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit cbfabd8104f56599d0b1f0a2f17d5154144a9341
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Sep 17 16:14:51 2015 +1000
ctdb-daemon: Add parallel database recovery capability
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit f0613ac4f7b3d3721750b7ee187a40a8a185a74e
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Sep 17 16:13:55 2015 +1000
ctdb-daemon: Use a define for default capabilities
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 4b39a7706f910c2830e4869b5e6363c45fbb7804
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Sep 17 17:10:15 2015 +1000
ctdb-recoverd: Update flags on all nodes before database recovery
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 9843363629972f162f923e759c6060a712fac2d2
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Sep 17 16:07:37 2015 +1000
ctdb-recoverd: Update capabilities before the database recovery
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 14cacd2925a77a1f45b42ad102ce1eb9448e4d7c
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Sep 17 16:00:47 2015 +1000
ctdb-recovery: Factor out existing database recovery code
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 951431910dc6d00815c19e087bc2546b1daa591b
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Jun 29 14:56:53 2015 +1000
ctdb-recoverd: Add parallel database recovery helper
Parallel database recovery fixes the samba/ctdb deadlock during recovery.
Many times samba tries to grab multiple record locks in sequence.
Consider a case when samba is already holding a record lock on a database
and tries to get a record lock on second database. If the second record
is not available on the local node, samba asks ctdb to migrate the record.
If recovery occurs at this time (e.g. node becoming inactive), ctdb
cannot freeze all the databases since samba is already holding a lock
and waiting for the second lock. CTDB can process the second record
request only after the recovery is complete, thus causing a deadlock.
In parallel database recovery, each database is frozen and recovered
independent from each other. So as soon as the second database is
recovered, CTDB will resend all the pending migration requests and Samba
can get the second lock. Once samba releases both the locks, ctdb can
freeze the first database and recover it completing recovery process.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b04c48d2f5f0a5e64ccf75e7773b880c521ffef3
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Sep 9 12:29:54 2015 +1000
ctdb-client: Add client API for new database controls
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 81ac247c10c362b643c2b3ce57df4fe6ecae78dd
Author: Amitay Isaacs <amitay at gmail.com>
Date: Sat Aug 1 01:47:22 2015 +1000
ctdb-protocol: Add controls for parallel DB recovery
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit c6a50b97d4c91967c480e7077b66e149bc38dcf4
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Apr 15 00:14:25 2015 +1000
ctdb-client: Add new client API implementation
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 34a6c99776cd50dfa4f6c2e02a6439d6d59b045e
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Apr 14 17:20:05 2015 +1000
ctdb-protocol: Add ctdb protocol serialization routines
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 8b45badfdaa8d9b618d551fcbbe8a2f7d680c4f9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Apr 14 11:42:45 2015 +1000
ctdb-include: Remove unused structure definitions
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 54da5c6603059709529d50d4f5c5c39373ca4216
Author: Amitay Isaacs <amitay at gmail.com>
Date: Sat Aug 1 22:36:04 2015 +1000
ctdb-common: Add logging utilities
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 1543eedb8feaa85336216aa22df2145522425184
Author: Amitay Isaacs <amitay at gmail.com>
Date: Sat Apr 4 20:23:44 2015 +1100
ctdb-common: Add communication endpoint abstraction
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e01c0eed38335e7b421ab4f79410f08ab1d31482
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Apr 6 17:26:29 2015 +1000
ctdb-common: Add packet write abstraction
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit c77d3bb183a6e8109db8e4f5494adf899b01ccea
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Sep 2 22:32:50 2015 +1000
ctdb-common: Add packet read abstraction
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit facd3c864e0a2db29e6b838389111ba731e02078
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 8 17:58:54 2015 +1000
ctdb-packaging: Package public library and header for tevent-unix-util
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 606b909310fc49a5f793c5031372a08c3848685b
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 8 18:16:08 2015 +1000
ctdb-build: Placeholder for public headers from lib/util
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 670db6ac1d678babd25dd82c4467c0f094cfabc5
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 8 10:34:21 2015 +1000
lib/util: Create a new library for tevent_unix.c
This is required for ctdb. This avoids adding dependency on wstatus
and ntstatus to ctdb build.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 9c16fe43fc37d0804e5a0337726fccf4e1ab73f3
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 8 18:15:35 2015 +1000
ctdb-build: Set PKGCONFIGDIR for public libraries in standalone build
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 100917b169765821bc79ef322663948c5edd34ca
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 8 17:58:25 2015 +1000
ctdb-packaging: Install header files in ctdb subdirectory
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b25c1135a74f5d61da00847149587835bc2102c9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Mar 17 14:30:18 2015 +1100
ctdb-daemon: Use reqid abstraction
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 9fd4d07ca60e2e4a40662988ce8136efa6452ced
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Mar 17 13:29:44 2015 +1100
ctdb-common: Add request id abstraction
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit a7ea6b094e60a41e28df5a8f17b98bb3bd1058d9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Mar 17 13:41:36 2015 +1100
ctdb-include: Remove unused definition
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 7c6115e11b2112f5b4003be862f709cc9ffea615
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Apr 8 14:41:59 2015 +1000
ctdb-daemon: whitespace fix
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 9d75bf3a9ffaa1e0cd25f7ada57f9eef7de614c3
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Apr 8 14:41:12 2015 +1000
ctdb-daemon: formatting fix
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 62f1e2579a6e97e7e33f68be779694d5eceb36c0
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Apr 8 14:38:26 2015 +1000
ctdb-daemon: Replace ctdb_message with srvid abstraction
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 6272ef0d09930ffbff43c6223ea35858d13efffa
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Mar 16 23:25:27 2015 +1100
ctdb-common: Add srvid abstraction
Attempt to make common code independent and free from ctdb_context.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e5592f9fc018b4b22fbdba4f45526210f5f41692
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Mar 17 12:35:31 2015 +1100
ctdb-common: Add db_hash abstraction
A hash table implemented using in-memory tdb backend.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit acf5ebfa906b226d7db2051c9716dd9091d7ecb7
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Apr 8 14:25:12 2015 +1000
ctdb-daemon: whitespace fix
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 6672deea13b663dd43e82df76a3152887ddac1dd
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Apr 8 14:25:01 2015 +1000
ctdb-daemon: formatting fix
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit ba56d852cb156585e34b758f3065df7adcdb73ba
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Apr 8 14:24:31 2015 +1000
ctdb-daemon: Remove ctdb from traverse_callback
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 3f287ec47934225be5a72e9c7bf51421d22895a6
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Aug 3 15:38:32 2015 +1000
ctdb-build: Do not split ctdb-system subsystem
The functions defined in common/system_*.c depend on the functions
defined in common/system_common.c. So keep them together.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 90b633ea79291c85248f63493af64be7868763af
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Sep 30 11:38:52 2015 +1000
ctdb-build: Do not mark ctdb private headers public
These headers are used by the server code and should not be marked public.
Samba builds against the in-tree version of the headers and should not
be built with externally installed CTDB.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 42f772215178050a3f465440e79e1ec9bce0e34f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Sep 14 13:49:05 2015 +1000
ctdb-daemon: Remove freeze requirement for updating vnnmap
In the parallel database recovery model, all the database will not remain
frozen at the same time. So relax the condition to check if recovery
is active.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 3cbd0409f398828ee6415229b3c23781405176ea
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Sep 11 16:14:12 2015 +1000
ctdb-daemon: Add a check for database generation consistency
Before setting recovery mode to normal, confirm that all the databases are
recovered by matching the database generation with the global generation.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 0ff90f4fac74e61192aff100b168e38ce0adfabb
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 15 16:50:19 2015 +1000
ctdb-daemon: Check packet generation against database generation
CTDB verifies the generation in the packet header matches that of the
current generation. However, that check now needs to be done where
database context is available. So add in the check in handlers for
database requests (CTDB_REQ_CALL, CTDB_REQ_DMASTER, CTDB_REPLY_DMASTER
and CTDB_REPLY_CALL).
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit d701072c3e2309019a729c908b28c6657b28a2ca
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Sep 23 14:47:58 2015 +1000
ctdb-call: Delete old defer queue if recovery occurs
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 3d11efe3c63c884ebb78c5488c565d9ab5afb963
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 15 16:50:19 2015 +1000
ctdb-daemon: Use database generation in packet headers for database requests
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 1df25943866e1644d0f48c8980c7eafdea0b6366
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Sep 11 14:20:44 2015 +1000
ctdb-daemon: Introduce per database generation
The database generation for each database is updated only during recovery.
After recovery is complete the database generation would be the same as
the global generation.
The database generation is required for parallel database recovery.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b81d4ccc770fc0f691fb87becd991350d91d2bd6
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Sep 17 12:57:51 2015 +1000
ctdb-freeze: Use individual database freeze in blocking freeze
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 5d9dd4d400296a4182dadc70cb4ddf9ca0681a60
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Sep 16 18:49:00 2015 +1000
ctdb-freeze: Ensure all databases get frozen during freeze
It's possible that the databases can get attached after initial freeze.
This typically happens during startup as CTDB will only attach persistent
databases and go in to startup freeze. During recovery, the recovery
master will attach all the missing databases and then send freeze
controls.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 8a5039d96390742be5563e74b7e2778f7d388ed2
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Sep 16 18:23:23 2015 +1000
ctdb-freeze: Make function ctdb_start_freeze static
Since the banning code does not call this function anymore, it can be
made static.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b4357a79d916b1f8ade8fa78563fbef0ce670aa9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Sep 16 18:20:31 2015 +1000
ctdb-banning: Do not freeze databases on ban in the daemon
Once the node is marked as banned, the recovery daemon on that node will
start freezing the databases anyway. This check happens every second
in recovery daemon, so the delay in freezing the databases on ban would
be a second.
The main reason for freezing databases is to prevent any database access
from samba clients. However, banning code also drops the public IPs
and thus disconnecting the clients. In addition, the generation gets
set to INVALID_GENERATION, thus database record migration requests on
that node will not be processed.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit fafd35b68f8af41095cb41cd604c27495fa2b6a1
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 15 16:13:10 2015 +1000
ctdb-freeze: Fix a log message
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit d14ff2d87e95c4c8c9faef800fc81b8c049d16da
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 15 14:16:21 2015 +1000
ctdb-freeze: Use database specific information in wipe database
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 858056263a0000663c0b50da6f080a845dc4d766
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 15 15:13:50 2015 +1000
ctdb-freeze: Use single database transactions for global transactions
This cascades the global transaction controls to individual database
transaction operations. This ensures that the individual database state
is correctly set when processing global transaction controls.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 3d325e7fa1de48ec88487d31a657e6a876d2dd81
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Sep 9 15:38:36 2015 +1000
ctdb-daemon: Add controls for transactions on a single database
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 4f155e77a8210e43456239391c03a5804d01b828
Author: Amitay Isaacs <amitay at gmail.com>
Date: Wed Sep 9 15:02:49 2015 +1000
ctdb-daemon: Rename ctdb_control_wipe_database to ctdb_control_transdb
The same structure is required in new controls for database transactions.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 9f779f130fa275dcc43adcab03d4704663776dce
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Aug 28 16:59:52 2014 +1000
ctdb-freeze: simplify code with TALLOC_FREE
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 979f1c5ea116b8aac536ebe29d584730e8fe9a4b
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Aug 28 16:58:56 2014 +1000
ctdb-freeze: Improve log message to indicate subsequent freeze operation
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 66c7bcc777ff5cbc625da86384d8c29d34c66bf9
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Sep 14 14:53:45 2015 +1000
ctdb-daemon: Use database specific mark/unmark routines
Instead of marking all the databases with priority, mark only the database
which is currently being processed.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e0fa182d9362537f7081e215250ce2052a9a34c8
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 15 14:01:49 2015 +1000
ctdb-daemon: Use database specific freeze check routine
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e170bd4f1b3fcf988867d1dd00b49e8813c6ca7f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Sep 10 13:24:43 2015 +1000
ctdb-locking: Add mark/unmark functions for a single database
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit d139f87718e06aaae73652fdf52f2c1dd2dcbe99
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Aug 28 15:28:34 2014 +1000
ctdb-freeze: Use single database freeze/thaw code for existing controls
This changes the locking behaviour when the databases are frozen.
Instead of a single lock helper locking all databases with a priority,
a lock helper is launched for every database.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit fd7ceaf3ac59fc7dc70d34e81cfd75a171a2e6c0
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Aug 28 15:30:39 2014 +1000
ctdb-freeze: Move destructor closer to where it is used
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 5447864e5d31d433f9a54924f3bb01f1384620fd
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 14:16:29 2014 +1000
ctdb-daemon: Add controls to freeze/thaw a single database
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 7afabb1285f6778b5b2862e178315b03f54eb8ef
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Sep 15 12:22:17 2015 +1000
ctdb-daemon: Avoid the use of ctdb->freeze_handle variable
These variables are used for state information related to freezing
databases. Instead use the API functions to check if the databases
are frozen.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 8c58c7392fe342fb39fcaf81c2465762f1823b51
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Aug 21 12:32:02 2014 +1000
ctdb-daemon: Avoid the use of ctdb->freeze_mode variable
Use ctdb->freeze_mode only in ctdb_freeze.c and use the functions to
check if databases are frozen everywhere else.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 056c44fda3f3d84dc3eb9766e0ee04bdb6387ea5
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Aug 21 12:26:58 2014 +1000
ctdb-freeze: Refactor code to check if databases are frozen
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 6a212d13d046d9f3ff6a2423d55b24b8068498e3
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 14:42:00 2014 +1000
ctdb-call: Convert pending calls list to per database list
The pending calls are migration requests received from clients (over unix
domain socket) which are under processing. After a recovery is finished,
any requests which are under processing will be dropped since they do
not belong to the current generation. All the pending call requests
are resent with new generation to restart record migrations.
This is in preparation for parallel database recovery.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 2116c55b08288b3c59613ed0d088eeba1c29d682
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 17:13:22 2014 +1000
ctdb-freeze: Use ctdb_db_iterator to commit transaction on databases
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit bc9a68592e15068332a915270c6ebdc46f4542d0
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 17:02:28 2014 +1000
ctdb-freeze: Use ctdb_db_iterator to start transaction on databases
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 457618888a80d3f5733a9e3dd41d3ab64ace4ae5
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 17:02:07 2014 +1000
ctdb-freeze: Use ctdb_db_iterator to cancel transaction on databases
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 74f7eebc7911a4ec5f6ee68266b027a661579c68
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 16:23:21 2014 +1000
ctdb-freeze: Use ctdb_db_prio_iterator to cancel transaction on databases
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit fb237608d7bdb3faf471a7be8a96176a42826811
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 16:49:06 2014 +1000
ctdb-locking: Add ctdb_db_iterator to iterate through all databases
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit ecb858f54831a439544c7d40051ce91d4103c746
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 16:45:34 2014 +1000
ctdb-locking: Expose ctdb_db_prio_iterator function
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b1f468017750c4c91f80c5239a364546a1d35e72
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 16:43:11 2014 +1000
ctdb-locking: Rename ctdb_db_iterator to ctdb_db_prio_iterator
This iterator only iterates through databases of specified priority.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 8df0916520f2cf938cbdece28d83c8a7b1824934
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 16:37:43 2014 +1000
ctdb-locking: Remove unused priority argument from db_handler_t
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b15a65ecc8646f4bd65012005ee28d4aaf272836
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 16:23:47 2014 +1000
ctdb-freeze: Remove commented test code
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 036203e02a4926d8d465a3f83f6bc565ae451483
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Aug 5 15:35:57 2014 +1000
ctdb-freeze: Do an early exit if freeze is pending
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 6d37cd3d56cac1ac78f25394a72c68191e50e901
Author: Ralph Boehme <slow at samba.org>
Date: Wed Oct 7 06:55:44 2015 +0100
s3:smbd: pass expected_seq_low to smbd_initialize_smb2
This is in preparation of multi-channel connection passing. This commit
should have been part of 1bb46da.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Oct 7 11:29:11 CEST 2015 on sn-devel-104
commit 9893888c5195ea6ebb7566a0277c6723aa4c81a1
Author: Richard Sharpe <rsharpe at samba.org>
Date: Fri Sep 18 16:19:54 2015 -0700
Change the libreadline word-break character set to only space, TAB and NL so that we can attempt to do tab completion across backslashes.
This turned out to be all that was needed to enable cd to handle multiple
directory levels.
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Oct 7 04:16:24 CEST 2015 on sn-devel-104
commit 1bb46dae829d9cd74534669371246ada86b5841a
Author: Ralph Boehme <slow at samba.org>
Date: Sun Sep 27 02:01:47 2015 +0200
s3:smb3: rename smbd_smb2_first_negprot and pass expected seq_low
This is in preperation of connection passing where we have to set
seq_low to the mid from the negprot we've handed over.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Ralph Boehme <slow at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Oct 7 00:54:34 CEST 2015 on sn-devel-104
commit c0aa94ece086cb32df1819ef455343e9acb3832b
Author: Ralph Boehme <slow at samba.org>
Date: Sun Sep 27 01:58:46 2015 +0200
s3:smbd: add expected_seq_low arg to smbd_initialize_smb2
This is in preparation of connection passing for multichannel where we
have to set seq_low to the mid of the passed negprot.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Ralph Boehme <slow at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8de1ed6d6e660760483a17f34842979384a655f9
Author: Tom Schulz <schulz at adi.com>
Date: Mon Oct 5 22:19:49 2015 +0200
s4: fix linking smbtorture on Solaris.
Don't test getgrouplist if we do not have it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11512
Signed-off-by: Tom Schulz <schulz at adi.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Oct 6 19:15:22 CEST 2015 on sn-devel-104
commit 5d7eaf959a0f11be878f698305fcb8908d7ba047
Author: Ralph Boehme <slow at samba.org>
Date: Sun Sep 27 12:11:31 2015 +0200
vfs_fruit: return value of ad_pack in vfs_fruit.c
ad_pack() in vfs_fruit.c returns false on failure and 0 on success -
i.e. return value is interpreted as success even when it fails.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Uri Simchoni <uri at samba.org>
Autobuild-User(master): Uri Simchoni <uri at samba.org>
Autobuild-Date(master): Tue Oct 6 16:14:42 CEST 2015 on sn-devel-104
commit cc93469a047ef92036c3e0eed24933d3e2c1b353
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 6 09:57:59 2015 +0200
lib: Fix CID 1128553 Unchecked return value from library
At the same time, avoid chmod in favor of fchmod
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Oct 6 13:12:48 CEST 2015 on sn-devel-104
commit 0db470df9172bb855409f4ba51dfc95e87e90c55
Author: Volker Lendecke <vl at samba.org>
Date: Tue Oct 6 09:54:19 2015 +0200
lib: Fix CID 1325733 Uninitialized scalar variable
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 70dbba96e311449575f571db68710584fc991234
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Oct 5 15:57:42 2015 +0200
s3:ctdbd_conn: make sure we destroy tevent_fd before closing the socket
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Günther Deschner <gd at samba.org>
commit 97bb100a765e5dc3983315df11c9654798a76574
Author: Volker Lendecke <vl at samba.org>
Date: Fri Sep 25 16:52:58 2015 -0700
lib: Pass sockname and timeout to ctdbd_probe()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Oct 3 03:04:39 CEST 2015 on sn-devel-104
commit 770b0e40d27beaa8513aebd1590aa4783a4a7eed
Author: Volker Lendecke <vl at samba.org>
Date: Fri Sep 25 16:49:33 2015 -0700
lib: Pass sockname and timeout to ctdbd_messaging_connection
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 025fb48360028ec20f19858dab8d528c5abf1867
Author: Volker Lendecke <vl at samba.org>
Date: Thu Oct 1 12:28:21 2015 +0200
lib: Move lp_ctdbd_socket() to cluster_support.c
There we have a #ifdef CTDB_SOCKET anyway
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ccd31e0c18f3eea2a92cc683ab197b904fdb37dc
Author: Volker Lendecke <vl at samba.org>
Date: Fri Sep 25 16:09:23 2015 -0700
lib: Pass parameters to ctdbd_init_connection()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0bc244ee58ae9fce2574113dd244ffa03934f5d8
Author: Volker Lendecke <vl at samba.org>
Date: Fri Sep 25 15:49:16 2015 -0700
lib: Store sockname in ctdbd_connection
We'll need it in ctdbd_traverse()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6c8606245381262ed43c14dec403b5a8a0eee5b5
Author: Volker Lendecke <vl at samba.org>
Date: Fri Sep 25 14:39:41 2015 -0700
lib: Remove temporary ctdb_connection in ctdb_control
I can just assume this is a bad hack for a condition that should have been
fixed in a different way. Today we pretty much expect a messaging_context to be
properly initialized everywhere, and this includes a ctdb connection.
If something later fails due to this commit, we need to do a
messaging_init before the offending call
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2aedb2d0851a09ca63a886ae14ee666ead6f8702
Author: Volker Lendecke <vl at samba.org>
Date: Fri Sep 25 14:36:35 2015 -0700
lib: Store ctdb_timeout in ctdb_connection
This lifts the call to lp_ctdb_timeout() up
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 54c7b052832d59d4c373bdae81b1ee68b06d8218
Author: Volker Lendecke <vl at samba.org>
Date: Fri Sep 25 14:32:09 2015 -0700
lib: Lift lp_ctdbd_socket() call up one level
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6755376cedaf0c88230b47e04c584c7d9fce13e3
Author: Günther Deschner <gd at samba.org>
Date: Fri Oct 2 04:23:59 2015 +0200
kerberos: make sure we only use prompter type when available.
We also verified that we cannot simply remove the prompter as several older
versions of Heimdal would crash.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Fri Oct 2 07:29:43 CEST 2015 on sn-devel-104
commit e524ab9f7ee9f4aff50dd5bc42312f9000bf1c6e
Author: Volker Lendecke <vl at samba.org>
Date: Fri Aug 28 12:33:13 2015 +0200
winbind: Fix 100% loop
Thanks to "L.P.H. van Belle" <belle at bazuin.nl>
for help in reproducing the issue.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11038
From the bug report:
"With e551cdb37d3e re-applied the problem is gone with
and without kerberos. Moreover, if correctly configured,
sshd requests you to change your password at logon time,
which then succeeds.
The problem why I had this reverted was because I had not
gone through the pain to correctly configure all the PAM
services (in particular the "account" section), leading
to sshd letting the user in when the password had to be
changed."
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
(cherry picked from commit e551cdb37d3e8cfb155bc33f9b162761c8d60889)
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Oct 2 00:16:29 CEST 2015 on sn-devel-104
commit f9ceaf443991e0bb5db23eeced2841436f47359e
Author: Jeremy Allison <jra at samba.org>
Date: Wed Sep 30 17:12:11 2015 -0700
s3: smbd: Fix NULL pointer bug introduced by previous 'raw' stream fix (bug #11522).
Ensure dirpath can never be NULL.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11535
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Thu Oct 1 08:58:36 CEST 2015 on sn-devel-104
commit bec685fb13e7cbe3bb98e5647183720d31f1c522
Author: Ralph Boehme <slow at samba.org>
Date: Fri Sep 25 21:06:57 2015 +0200
s3: smbd: fix a crash in unix_convert()
Some error code paths may result in dirpath being NULL.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11535
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 00954a975b45cdb0dcf08c25850d2be26efabe48
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 27 00:36:23 2015 +0200
lib: We can do ACCRIGHTS style fdpassing
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11053
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Oct 1 05:55:42 CEST 2015 on sn-devel-104
commit 0499cee90307d9644271869c86fac2b5401df0e0
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 27 00:54:42 2015 +0200
lib: Support fd passing using the 4.3BSD way
This is required on Solaris
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11053
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit f4e06a9bce42d60f6c96a21307266a99d2785ae9
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 27 00:46:33 2015 +0200
lib: Move some routines around in msghdr.c
This way we only need one #ifdef for ACCRIGHTS
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11053
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 2c675aad40e3e0bb412f9fb8558de349ad62860a
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 27 00:35:45 2015 +0200
lib: We only need the fd-passing check once
unix_dgram_send will tell us as well
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11053
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b191632701c8b5fb8d89109494a2251416bd6a93
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 27 00:58:00 2015 +0200
lib: Fix the build on Solaris
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d9000cbc944fa58cc7b7bc509ce885d7b5f498af
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 27 00:57:50 2015 +0200
libreplace: Fix the build on Solaris
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 22c5699751d8a7b3eda33260c7ec9f0a8771d25b
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 29 20:24:10 2015 +0200
lib: Fix server_id_db_set_exclusive
For server_id_db_set_exclusive we need to store the unique id along
with the vnn:pid combo. I had tested all this just with some
smbtorture and net command tests, all of which have a unique id of
zero. When trying to exclusively register "notify-daemon" when smbd
is running, this fails because serverid_exists only tests with zero
unique id. notifyd does have a non-zero unique id, so server_id_exists
will think the existing notifyd is another non-samba process that
happened to claim notifyd's pid.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Oct 1 02:53:58 CEST 2015 on sn-devel-104
commit 2c12b516a98778baf6a0aa06c70e94bded1b48ed
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 29 20:16:56 2015 +0200
lib: Add "pid/unique" format for server_id_from_string
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a4f64500a5c3c89aae0c6eb15e994898d0ce38e7
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 29 20:08:48 2015 +0200
lib: Fix server_id_from_string
sscanf overwrites vars as numbers come in. So the first sscanf will
overwrite "vnn", although it can't scan the whole thing. This leads
to the string "1234" return .vnn=1234, pid=1234. Bad.
While there, save the temp variables. The SCNu32/64 thingies look
ugly, but it's actually c99.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8044e2dcc074ade554150ebc11b60d91db025f63
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 29 04:03:52 2015 +0200
lib: Add server_id_str_buf_unique
A representation including the unique id
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 620b7467adebb756e6658c6901232755a8c62d17
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 30 01:27:00 2015 +0200
lib: Remove ctdb_serverids_exist
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 103658ddd0992d00f5a4b1411dcb808d035cb917
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 30 01:14:33 2015 +0200
lib: Remove serverids_exist
The only reason for this complex monster was an overload of ctdbd.
When opening files, we unconditionally checked all share modes for
validity. This meant thousands of serverid_exists calls per second
for popular directories. This has long gone, now we only check for
validity if a conflict happens.
The only remaining caller is net serverid wipedbs, an administrative
command. If that loads ctdbd, so be it.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b542ce7db394de3023b95288b0c40c4533c02cb1
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 30 01:11:08 2015 +0200
lib: Use messaging_dgm_get_unique in serverid_exists
This is a relevant change: I was experimenting with
server_id_db_set_exclusive() in "net" and got failures all over the
place. The main reason was that "net" by default does not do a
serverid_register. With messaging_dgm we have the process' unique
id available via the lockfile contents. Using open/read/close is a
bit slower than local tdb access, but this version is safe for all
processes which have done messaging_init()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c793fb8a66e6837b2d2bc1f2f2d3ec5bc1edee84
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 30 01:01:46 2015 +0200
lib: Use serverid_exists in server_id_db_check_exclusive
If there's another process around there will typically be at most
one process. So there is no real need to run the plural version of
serverid_exists.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 37f01c869de14e0f0e6d609e2b8f3448167c11db
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 30 00:31:17 2015 +0200
messages_dgm: Add messaging_dgm_get_unique
To be able to read, we need to open the lockfile O_RDWR instead of O_WRONLY
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit beb7c6b9411cb02d873b5ce1b4210dc2a775e93d
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 29 23:39:46 2015 +0200
net: Add "serverid exists"
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e119f95532710f0c8d65cfb3dca54145c942e12c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 29 20:42:58 2015 +0200
net: Fix some tiny memleaks
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 348dd41871527768ac4b5386183930837e187976
Author: Michael Adam <obnox at samba.org>
Date: Tue Sep 22 01:27:48 2015 +0200
s3:lib:interface: break an overly long line
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d8b2421767fbfdb84572702cb77309550d27dc27
Author: Günther Deschner <gd at samba.org>
Date: Wed Sep 30 08:27:04 2015 +0200
s4-scripting: fix minor indent issue for hresult generation.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f5109dfcdb47432bc85ec3058d4f0f2b4fd15700
Author: Günther Deschner <gd at samba.org>
Date: Wed Sep 30 08:14:06 2015 +0200
s4-scripting: fix wrong indent that caused gen_ntstatus.py to fail.
Verified it now works again with:
./source4/scripting/bin/gen_ntstatus.py libcli/util/ntstatus.h MS-ERREF-2.3.1.NTSTATUS libcli/util/nterr.c
MS-ERREF-2.3.1.NTSTATUS as the copied content from
https://msdn.microsoft.com/en-us/library/cc704588.aspx.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit dea49cc7c07bb1206cf8600eeb9fa699c1ca0d75
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 18 22:25:25 2015 +0200
ldb: Fix CID 1034781 Unsigned compared against 0
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit edd18f7a1dc7df7a1c4cbefd0c2b460a82c6cb17
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 30 00:30:49 2015 +0200
messages_dgm: Fix an incorrect cast
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Wed Sep 30 17:36:32 CEST 2015 on sn-devel-104
commit cfca46a56568b8a83c7b2657821fd3c86918bba1
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 30 00:30:28 2015 +0200
messages_dgm: No includes.h necessary
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ae438675ddabbec7438ec90565d93a7e9ee86f82
Author: Günther Deschner <gd at samba.org>
Date: Mon Sep 21 19:17:59 2015 +0200
s4-torture: trying to make clusapi resource online/offline testing a bit more robust
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Sep 29 15:00:47 CEST 2015 on sn-devel-104
commit 6ef2d288a7327f356ab4694eca9b554796066257
Author: Günther Deschner <gd at samba.org>
Date: Mon Sep 14 17:12:58 2015 +0200
s3-rpcclient: protect against empty witness async notify messages.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 08e260e3e3e6b0c1266fcd5285e666d089e4e9e0
Author: Günther Deschner <gd at samba.org>
Date: Mon Sep 28 19:08:58 2015 +0200
librpc: properly quote uuids so that wireshark dissectors can be built from them.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 4827d49bd2a6a174f6c80c32ebc7b322da3a64c5
Author: Günther Deschner <gd at samba.org>
Date: Mon Sep 28 00:47:17 2015 +0200
clusapi: remove security.idl dependency from IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 71a168eb2bc9df448bab73ae55e2cd8b514b03cd
Author: Thomas Nagy <tnagy at waf.io>
Date: Mon Sep 28 21:47:16 2015 +0200
build:wafsamba: Set the default installation prefix for Waf 1.8
These changes enable the default installation prefix settings to
take effect in both Waf 1.5 and 1.8 with no additional code changes.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 875beefcedd2ef9d608c7f58cec18a86a3fd51e1
Author: Ralph Boehme <slow at samba.org>
Date: Sat Sep 26 01:16:50 2015 +0200
samba-tool: add command to dump dosinfo xattr from a file
Add a new command "getdosinfo" to samba-tool to dump dosinfo xattr from
a file.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Sep 29 06:00:49 CEST 2015 on sn-devel-104
commit 44aff1a1647b2a5e21b06750515410eb3ca03ab1
Author: Mathieu Parent <math.parent at gmail.com>
Date: Thu Sep 24 04:39:17 2015 +0200
ctdb-build: Use socket_wrapper only with selftest
Signed-off-by: Mathieu Parent <math.parent at gmail.com>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Sat Sep 26 16:52:28 CEST 2015 on sn-devel-104
commit d493ec1f795ffb4642a4ed8481b686056802859d
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 24 11:28:50 2015 -0700
s4: torture: Fix directory test against a server that actually uses index returns.
Who knew ? Finally found one that does this :-).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Jim McDonough <jmcd at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Sep 25 08:21:49 CEST 2015 on sn-devel-104
commit e224e622971853bddbe24df717ea5dcddef71b89
Author: Uri Simchoni <urisimchoni at gmail.com>
Date: Wed Sep 23 14:45:47 2015 +0300
net: fix a crash with net ads keytab create
Fix a crash that happens when executing "net ads keytab create"
and the machine account in AD does not have setvice principal names
attached to it.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11528
Signed-off-by: Uri Simchoni <urisimchoni at gmail.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1b8ea12aa7627ace735923e68e59bc3d5cce3676
Author: Günther Deschner <gd at samba.org>
Date: Thu Sep 24 06:40:39 2015 +0200
witness: fix length calculation in witness_IPaddrInfoList IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Autobuild-User(master): José A. Rivera <jarrpa at samba.org>
Autobuild-Date(master): Thu Sep 24 22:33:28 CEST 2015 on sn-devel-104
commit f2fcbf24576110c9feaf5cc07feb1c469fa9247c
Author: Günther Deschner <gd at samba.org>
Date: Thu Sep 24 06:40:19 2015 +0200
witness: fix IP address endianess in witness_IPaddrInfo IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
commit 23c17d95342dc335bab03112f1c615cd3e9ea0d7
Author: Günther Deschner <gd at samba.org>
Date: Thu Sep 24 02:47:35 2015 +0200
s4-torture: add test to verify WITNESS_NOTIFY_CLIENT_MOVE message marshalling.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
commit 2266e2400886d409aa5fa2fe76d83ea8a31e8019
Author: Christof Schmitt <cs at samba.org>
Date: Wed Sep 23 11:21:21 2015 -0700
smbd: Set process name for notifyd process
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Sep 24 11:02:44 CEST 2015 on sn-devel-104
commit 0b455a5c2da6b6076450eb5ab5f91b3ab6ca7379
Author: Christof Schmitt <cs at samba.org>
Date: Wed Sep 23 11:15:44 2015 -0700
smbd: Set process name for async echo handler
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 96c48b3c06034a64ee4fb90650dfd5a1059fe83a
Author: Christof Schmitt <cs at samba.org>
Date: Wed Sep 23 11:14:05 2015 -0700
s3: Move call to prctl_set_comment to reinit_after_fork
This save a few lines of code.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 6788a5f4491cccf5fbe0749d0d1542531e641fc3
Author: Christof Schmitt <cs at samba.org>
Date: Wed Sep 23 12:28:30 2015 -0700
lib: Fix prctl detection for prctl_set_comment
Include config.h to make HAVE_PRCTL available for the precompile check.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 969d043596c0a382325d54d16dbd5e049f884fa9
Author: Jeremy Allison <jra at samba.org>
Date: Tue Sep 22 18:01:22 2015 -0700
s4: torture: Test mkdir race condition.
Found by Max of LoadDynamix <adx.forum at gmail.com>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11486
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Sep 24 06:13:22 CEST 2015 on sn-devel-104
commit b1c823dc8c2824ec89921601d8e5e95f6d18fca8
Author: Jeremy Allison <jra at samba.org>
Date: Tue Sep 22 18:02:53 2015 -0700
s3: smbd: Fix mkdir race condition.
Found by Max of LoadDynamix <adx.forum at gmail.com>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11486
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit ce62124c6196f82dd543223bd646703479e5f328
Author: Christof Schmitt <cs at samba.org>
Date: Wed Sep 23 10:41:06 2015 -0700
docs: Fix references to async smb echo handler in smb.conf manpage
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit dec34db53e2cc38938ad2f404847f50be054d2f2
Author: Ralph Boehme <slow at samba.org>
Date: Tue Sep 22 03:15:14 2015 +0200
s4:torture: add a test for 0 byte sized streams
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Sep 22 23:46:00 CEST 2015 on sn-devel-104
commit e9c5b63167ef12b897c47a36e2fb48f8838ea499
Author: Herb Lewis <hlewis at panasas.com>
Date: Tue Sep 22 11:39:54 2015 -0700
s4: torture: Fix double-free on error.
Signed-off-by: Herb Lewis <hlewis at panasas.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a1187bb873009ea673b039bc7152c31f831f6366
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 20 18:25:20 2015 +0200
dbwrap: Remove talloc from dbwrap_watch_record_stored()
This happens on every store to locking.tdb for example, so we should
make it cheap.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Tue Sep 22 07:50:58 CEST 2015 on sn-devel-104
commit 1a8750a2c619ca3ab44c49e186a89893742f435f
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 20 17:32:24 2015 +0200
dbwrap: Convert dbwrap_record_watchers_key to not use talloc
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 2e0e06c3c51fc57bd021f24850e85e2394b3fa1c
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 20 17:06:22 2015 +0200
dbwrap: Simplify dbwrap_record_watchers_key()
It took a bit for me to figure out what the rec_key parameter to
dbwrap_record_watchers_key does. I think it's simpler to parse the watcher key
in dbwrap_record_watch_recv to retrieve the watched record key than to store it
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 9964d60e3e3a779bc2a6e72f4d677a72c59e09e4
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 20 16:26:06 2015 +0200
dbwrap: Make dbwrap_db_id return size_t
This will make an on-stack db-id easier
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 71a407edad9f3fc1cd1719d87123862698f12f2f
Author: Volker Lendecke <vl at samba.org>
Date: Mon Sep 21 12:32:47 2015 +0200
dbwrap: Remove talloc_reference()
We want to know (by crashing) when we free the database with records still
around. This would be a serious violation of our data structure hierarchies.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 225cba6e413758dcaff2ba275fa81b37485922f2
Author: Volker Lendecke <vl at samba.org>
Date: Sun Sep 20 20:25:53 2015 +0200
dbwrap: Remove unused dbwrap_hash_size()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 5d12eb890880c4d7e23a266f6817e40636fc81e6
Author: Volker Lendecke <vl at samba.org>
Date: Mon Sep 21 12:28:20 2015 +0200
dbwrap: Remove loadparm_context from db_open_tdb
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 1399198d51d1f79ff99304369442e04c015eef23
Author: Gustavo Zacarias <gustavo at zacarias.com.ar>
Date: Fri Sep 11 16:57:16 2015 -0300
build: improve stack protector check
Testing a toolchain for proper -fstack-protector must go beyond ensuring
the compiler and linker accept the option.
If the test C program does nothing with the stack then guards aren't
inserted and/or are optimized away giving the false impression that it
works when in fact the libc might not support it.
Update the check to a program that uses the stack, hence making a link
fail if proper support isn't available, for example in non-ssp enabled
uclibc toolchains like this:
test.c:(.text.startup+0x64): undefined reference to `__stack_chk_fail'
Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Böhme <rb at sernet.de>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Mon Sep 21 23:29:13 CEST 2015 on sn-devel-104
commit b4747b6364d9c49a3f146800921c44b3c39f59d1
Author: Anubhav Rakshit <anubhav.rakshit at gmail.com>
Date: Wed Sep 16 21:04:12 2015 +0530
s4:torture:smb2:rename: Fix typo in simple_nodelete testcase.
Signed-off-by: Anubhav Rakshit <anubhav.rakshit at gmail.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Sep 21 04:51:11 CEST 2015 on sn-devel-104
commit 25dcdc92709a46d87125bc454faae7cad43d6b71
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Sep 18 18:54:31 2015 +0200
lib/param: fix hiding of FLAG_SYNONYM values
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11526
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8262ecb98884cb71a59c6a18252aa632b8cbcc35
Author: Thomas Nagy <tnagy at waf.io>
Date: Sat Sep 12 09:49:41 2015 +0200
build:wafsamba: Use the samba-provided CHECK_CFG method in configuration tests
This is for forward compatibility with waf 1.8. All other tests
use CHECK_CFG, but check_cfg was re-introduced for some reason.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 34085911c65e9e6cec19aac447d28bb7335c74da
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Sep 9 17:06:50 2015 +1000
ctdb-doc: Fix a typo in the definition of CTDB_NODE_ADDRESS
Should be an IP address not a filename.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Sat Sep 19 16:39:23 CEST 2015 on sn-devel-104
commit a36a734717fc8cee2fe69f5822b2fc6aafb8dadd
Author: Ralph Boehme <slow at samba.org>
Date: Fri Sep 18 10:58:37 2015 +0200
Revert "tdb: Add tdbdump -u"
This reverts commit ea53e86c256bec08373dbe86e190a7f5a06eff9d.
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Fri Sep 18 14:03:12 CEST 2015 on sn-devel-104
commit 6ce3643e45bac6660ae69123738c4b39d7bc1864
Author: Jeremy Allison <jra at samba.org>
Date: Wed Sep 16 16:12:15 2015 -0700
s3: tests: smbclient test to ensure we can create and see a :foobar stream on the top level directory in a share.
Regression test for:
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11522
Remember to remove the ARCHIVE attribute from the toplevel
share when done (can only be done over SMB2+).
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Fri Sep 18 11:00:44 CEST 2015 on sn-devel-104
commit 74fd4f93efe92516fc507edf71a588660782879e
Author: Jeremy Allison <jra at samba.org>
Date: Wed Sep 16 12:03:34 2015 -0700
s3: smbd: Fix opening/creating :stream files on the root share directory.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11522
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 94e7e707783036b57babc73d320d2a3d8c0648d6
Author: Jeremy Allison <jra at samba.org>
Date: Wed Sep 16 12:42:46 2015 -0700
s3: smbd: Remove unused parameter from build_stream_path().
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit a47012d5429044c9a3616718bac21360f281aa81
Author: Jeremy Allison <jra at samba.org>
Date: Thu Sep 17 15:54:40 2015 -0700
s3: smbclient: Move cmd_setmode out of clitar.c and back into client.c
setmode <file> attribute is a valid smbclient command even if libarchive
isn't on the system and tarmode isn't compiled in.
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit ea53e86c256bec08373dbe86e190a7f5a06eff9d
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 15 17:08:24 2015 +0200
tdb: Add tdbdump -u
The reverse of tdbdump
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Sep 18 03:04:35 CEST 2015 on sn-devel-104
commit 1d2a1a685ebdf479c511e01764e5148dbcbb37c9
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 16 12:44:43 2015 +0200
s4:lib/messaging: use 'msg.lock' and 'msg.sock' for messaging related subdirs
In Samba 4.2, we used lock_path("msg") (with 0700) for the socket directory,
while we use lock_path("msg") (with 0755) for the lock file directory.
This generates a conflict that prevents samba, smbd, nmbd and winbindd
from starting after an upgrade.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11515
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Sep 17 09:04:59 CEST 2015 on sn-devel-104
commit 1aabd9298d59d4f57d321ecaee59e99d966089ff
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 16 12:44:43 2015 +0200
s3:lib/messages: use 'msg.lock' and 'msg.sock' for messaging related subdirs
In Samba 4.2, we used lock_path("msg") (with 0700) for the socket directory,
while we use lock_path("msg") (with 0755) for the lock file directory.
This generates a conflict that prevents samba, smbd, nmbd and winbindd
from starting after an upgrade.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11515
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit b0fa8316beefc7808b059f514448d41224d1c1fb
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Sep 16 12:42:48 2015 +0200
s3:lib/messages: add missing allocation check for priv_path
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11515
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 5866fcc1645366a56e68fc3d8065618131364337
Author: Tom Schulz <schulz at adi.com>
Date: Wed Sep 16 16:55:23 2015 -0700
s4: tests: Fix nss_tests build on Solaris.
Too many arguments for Solaris getpwent_r() and getgrent_r().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11508
Signed-off-by: Tom Schulz <schulz at adi.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ralph Böhme <rb at sernet.de>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Sep 17 05:01:07 CEST 2015 on sn-devel-104
commit 4276ec7a6c2379a0b906fab8e1dc9c080b3534bc
Author: Andreas Schneider <asn at samba.org>
Date: Tue Sep 15 16:20:48 2015 +0200
Makefile: Add option to list all tests
This allows you to run 'make testlist' to get a complete list of all our
tests available. You can limit it using 'make testlist TESTS=spoolss' to
only show spoolss tests for example.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Sep 15 21:57:50 CEST 2015 on sn-devel-104
commit f54b2f77583672bc560fd5b03ddb58943b84f089
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 15 10:19:03 2015 +0200
ctdb: Fix CID 1324447 Double close
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Tue Sep 15 16:20:07 CEST 2015 on sn-devel-104
commit 3ddd35142ab86de431d00f93de2fb6a2b371317d
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Sep 11 13:08:38 2015 +1000
ctdb-build: Install pre-built manpages when xsltproc not available
At the moment they are not installed at all if xsltproc is not
available.
They can still be filtered to have the paths match what was
configured.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Sep 15 11:57:44 CEST 2015 on sn-devel-104
commit f1bb641a3a0f923faa594937db55437caf446343
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 17 21:09:06 2015 +1000
ctdb-doc: Update out-of-date documentation for CTDB socket options
These still say /tmp/ctdb.socket, which is very out-dated. Update
with build-time location.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit b933b91a0b03969eea73bb986f94e6c1d2e4887c
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 17 20:47:58 2015 +1000
ctdb-scripts: Update important installed files to use build-time defaults
In this case: ctdbd_wrapper, onnode, ctdb_diagnostics, ctdb.sudoers.
Set sensible defaults from configure options.
Update documentation to match, trying to fix up anything that has been
missed before.
The onnode unit tests need a symlink to the functions file.
The simple integration tests need to set CTDB_BASE and also
need symlinks to functions/nodes.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
fixup
Signed-off-by: Martin Schwenke <martin at meltin.net>
commit 56fd37ba0dc26f14261dee5e12f1dbcddf8b6779
Author: Martin Schwenke <martin at meltin.net>
Date: Sat Aug 22 20:14:09 2015 +1000
ctdb-tools: Drop vacuum.log from ctdb_diagnostics
This hasn't existed for a long time.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 121d1a8571a36636ba6efda778d01ec8c9d1e671
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 17 14:12:15 2015 +1000
ctdb-scripts: Rename variable CTDB_ETCDIR to CTDB_SYS_ETCDIR
This variable points to /etc/ by default.
This distinguishes it from the different variable from wscript, which
points to /etc/ctdb/.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 014a1eb54008fc36890c8bcd4103fbd8053002e2
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 17 14:01:40 2015 +1000
ctdb-scripts: CTDB_BASE must be set when including functions file
Also fix an unused test to set CTDB_BASE.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit c58d582ffb8c03f67b6799a9783fe8061b404d5e
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 17 13:39:10 2015 +1000
ctdb-scripts: Factor out possible creation of rt_tables file
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 677467682a8866096e696191c4ac93249c9fb991
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Aug 13 15:57:52 2015 +1000
ctdb-scripts: Move remaining state files into CTDB_SCRIPT_VARDIR
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 3aa11b175ac2a09af292e187929212cfad4e0839
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Aug 13 15:54:20 2015 +1000
ctdb-scripts: New internal variable CTDB_SCRIPT_VARDIR
Clearly identifies where all state files from scripts should go and
allows that location to be easily changed. This patch should not
change any behaviour (outside of eventscript unit tests, where a
clearer location is now used).
CTDB_VARDIR should no longer be overridden. Continue to set
CTDB_DBDIR and similar to override database location in unit tests.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d064620f51f572b925e901feddb3ed649320fea7
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Aug 13 15:17:51 2015 +1000
ctdb-scripts: Properly set CTDB_VARDIR in scripts at install time
Have wscript do path substitution.
No need to export this and CTDB_ETCDIR here, but test scripts will
still need to do so.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit bd77a9797fc24587309b5c2873bd5f2b144f3ae6
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Aug 21 21:19:55 2015 +1000
ctdb-build: Add missing manual pages to pre-generate list for tarball
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 36a14730f18ef5a87f3d9095693cab0f06062414
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Aug 21 16:07:21 2015 +1000
ctdb-docs: Update "ctdb reloadnodes" documentation
Format instructions for adding/deleting nodes with appropriate XML and
simplify wording.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit e7a139bffe80b7111d8392bf25a50d528d5e42e7
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 10 16:11:18 2015 +1000
ctdb-scripts: Drop internal file-level variables referencing $CTDB_VARDIR
Using $CTDB_VARDIR at file scope is dangerous because it doesn't
respect the configuration. Uses of these variables are simple so just
drop the variables and use $CTDB_VARDIR inside functions where it is
safe.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 143ec9e4c2963039d08d4cd9835474412c5eb6c8
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 10 16:33:42 2015 +1000
ctdb-scripts: Drop file removal involving $ctdb_managed_dir
This directory has been under $CTDB_VARDIR for a long time, so is
already removed. The command is also potentially dangerous if
$ctdb_managed_dir is not set.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 353c27deab30a86c94d76f0b8197fb84ce260d99
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 10 16:03:05 2015 +1000
ctdb-scripts: Drop functions ctdb_checkstatus() and ctdb_setstatus()
They're not used outside of ctdb_standard_event_helper().
As a consequence, make ctdb_standard_event_helper() do nothing. It is
harder to remove because it is used in many places, perhaps by
external eventscripts where it has been copied from existing scripts.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 8c2948eba59d4ee24af1154c774c9fa79939bd91
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 10 15:34:29 2015 +1000
ctdb-scripts: Drop 62.cnfs eventscript
To get a similar effect just do something like this:
mmaddcallback ctdb-disable-on-quorumLoss \
--command /usr/bin/ctdb \
--event quorumLoss --parms "disable"
mmaddcallback ctdb-enable-on-quorumReached \
--command /usr/bin/ctdb \
--event quorumReached --parms "enable"
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Jose A. Rivera <jarrpa at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 9d49dfac5f336499131fca5143f0ffdb1932afc9
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Sep 2 09:27:58 2015 +1000
ctdb-scripts: New internal variable CTDB_NFS_CALLOUT_STATE_DIR
60.nfs sets this to a directory where the NFS callout can store state.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Mon Sep 14 08:36:34 CEST 2015 on sn-devel-104
commit 12153af85d34e4ced5eab76753f2e4cafba0156c
Author: Har Gagan Sahai <SHarGagan at novell.com>
Date: Thu Sep 10 16:04:27 2015 +0530
s3: dfs: Fix a crash when the dfs targets are disabled.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11509
Signed-off-by: Har Gagan Sahai <SHarGagan at novell.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ira Cooper <ira at wakeful.net>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Sep 11 06:39:19 CEST 2015 on sn-devel-104
commit b0f41c07ffe8600433c20a038b1612c04ed29e89
Author: Björn Jacke <bj at sernet.de>
Date: Thu Sep 10 21:31:03 2015 +0200
build: use as-needed linker flag also on OpenBSD
OpenBSD is unusable with binaries with many superfluous libs linked in.
samba-tool start times of 250 seconds without as-needed vs. 1.4 seconds with
as-needed.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11355
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Ralph Böhme <rb at sernet.de>
Autobuild-User(master): Björn Jacke <bj at sernet.de>
Autobuild-Date(master): Fri Sep 11 03:37:17 CEST 2015 on sn-devel-104
commit d3e51b9cfe3d56530253571e020af72da1877044
Author: Björn Jacke <bj at sernet.de>
Date: Thu Sep 10 14:35:32 2015 +0200
nss_winbind: fix hang on Solaris on big groups
The problem with large groups on Solaris in the the NSS winbind module is
Solaris wants the return value to be NSS_UNAVAIL if the buffer given is too
small for getgrnam_r. The current code return NSS_TRYAGAIN which causes
Solaris/Illumos to loop without trying to resize the buffer.
Thanks to Nathan Huff <nhuff at acm.org> for finding this out.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10365
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Ralph Böhme <rb at sernet.de>
commit a997c7780e69117bcc18b43834275d9bb332c4ad
Author: Björn Jacke <bj at sernet.de>
Date: Thu Sep 10 11:27:42 2015 +0200
nss_wins: add module for FreeBSD
Thanks to Timur Bakeyev <timur at FreeBSD.org> for the patch.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11493
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Ralph Böhme <rb at sernet.de>
commit b7eb72529261aed822ed649651f8f4132a132e7d
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jun 25 16:09:04 2014 +0200
smbXsrv_session: factor smbXsrv_session_add_channel() out of smbXsrv_session_create()
This allows to create more than one channel.
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Sep 10 21:33:47 CEST 2015 on sn-devel-104
commit 57053c5cb9c9296e96918ee8a32c264285d694c1
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jul 29 17:44:37 2015 +0200
s3:smb2_sesssetup: let smbd_smb2_reauth_generic_return() cope with channels
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 69d2af10d49733f40c7496dd535abd6e3092b6fa
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 29 17:42:55 2015 +0200
s3:smb2_sesssetup: let smbd_smb2_auth_generic_return() cope with channels
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6f95bc502591bc44cd525a86bd0d97b51f78a8ad
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 29 17:07:29 2015 +0200
s3:smb2_sesssetup: change talloc hierarchy in smbd_smb2_session_setup_gensec_done
Only put session_info to the session->global context if we use it.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit cf5c28da00d46467bb4333e0f91822d37328cc20
Author: Andreas Schneider <asn at samba.org>
Date: Wed Sep 9 13:47:42 2015 +0200
replace: Fix check for gettimeofday()
The check does not include <sys/time.h> the test might fail with a
implicit function declaration error.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Sep 10 00:36:16 CEST 2015 on sn-devel-104
commit 36830db46aba8b5875666e684e00178245e49816
Author: Michael Adam <obnox at samba.org>
Date: Wed Sep 9 08:58:43 2015 +0200
net: reformat usage text for 'net ads join'
Make the items nicely aligned again and do not exceed 80 columns.
A few typos are fixed along the way.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit d7a617f2f00c4a2b5294523fa651915c85de0d8b
Author: Michael Adam <obnox at samba.org>
Date: Wed Sep 9 08:40:31 2015 +0200
docs: mention new --no-dns-updates parameter in manpage of net.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit ae81a40b1193ef93add61666ace6fff1a1e0676a
Author: Michael Adam <obnox at samba.org>
Date: Wed Sep 9 08:28:43 2015 +0200
net: add option --no-dns-updates for net ads join
If called with this option, 'net ads join' will not attempt
to perform dns updates.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit a44a0c47cb3d356b164b2f5cb54d6942c33f9d6f
Author: Anoop C S <anoopcs at redhat.com>
Date: Wed Sep 9 06:37:21 2015 +0000
libsmb: Fix CID 1034606 Incorrect pointer comparison
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Sep 9 21:33:49 CEST 2015 on sn-devel-104
commit b63b53c8426195a5f05dfe2b6e23a2f5af232058
Author: Anoop C S <anoopcs at redhat.com>
Date: Wed Sep 9 06:35:15 2015 +0000
libsmb: Fix CID 1034605 Incorrect pointer comparison
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 736397ec49974599bc038b097567e250cdb60cc6
Author: Anoop C S <anoopcs at redhat.com>
Date: Tue Sep 8 08:21:47 2015 +0000
winbindd: Fix CID 1273310 Remove structurally dead code
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 76ef9c17d3f0e7df49c342b7b57183720b69bd82
Author: Michael Adam <obnox at samba.org>
Date: Tue Jun 10 16:48:40 2014 +0200
build: line-break deps for 'param' subsystem
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Wed Sep 9 13:12:43 CEST 2015 on sn-devel-104
commit 123e6584ae064a513d0c1abc5137198e18a1d1bc
Author: Michael Adam <obnox at samba.org>
Date: Fri Jul 3 12:12:44 2015 +0200
build: fix quotation of deps for 'param' subsystem.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 7d49d9b4a135f97e6d94ffe14979259ecd3f0cae
Author: Michael Adam <obnox at samba.org>
Date: Tue Sep 8 10:01:31 2015 +0200
ctdb-server: fix a possible fd leak in ctdb_tcp_listen_automatic()
sockets are created in a loop until an unused address is found.
But the unused socket fds were not closed.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 4010c03e3dcea7d79ca6371f5c57d56b42043822
Author: Michael Adam <obnox at samba.org>
Date: Mon Sep 7 18:09:44 2015 +0200
ctdb: improve a misleading help text.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 3f402eb8cf5ea32321fb4cfb10b69f08c8c20220
Author: Michael Adam <obnox at samba.org>
Date: Tue Sep 8 10:08:20 2015 +0200
ctdb-doc: remove description of removed --syslog option from ctdbd manpage
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 7d84cd6e40024fd361ea21635f7befed40f0e41f
Author: Andreas Schneider <asn at samba.org>
Date: Tue Sep 8 16:48:08 2015 +0200
pam_winbind: Fix a segfault if initialization fails
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11502
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Sep 8 21:39:21 CEST 2015 on sn-devel-104
commit e7b6990284282e2bf89bb3753fdd0c5fa0bdc26c
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 25 17:22:09 2015 +0200
swrap: Bump version to 1.1.4
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Sep 8 16:49:23 CEST 2015 on sn-devel-104
commit 9fe5eac9e9b8db666bb1a9f1285d5da4bdf5795d
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 25 17:21:33 2015 +0200
swrap: Call dlclose() in the destructor
Signed-off-by: Andreas Schneider <asn at samba.org>
commit 5bd1ec1037339fbcf372fad10f7adbd6fd89927c
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 25 17:21:05 2015 +0200
swrap: Fix signed comparsion warnings
Signed-off-by: Andreas Schneider <asn at samba.org>
commit 830e3dd14f363620d153e66e23978c4738c919f0
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 25 17:20:20 2015 +0200
swrap: Add environment variable to specify mtu size
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 55432439e2b5947181b8185c4e21659068ca18be
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 25 17:19:43 2015 +0200
swrap: Fix TCP support with sendmsg/recvmsg
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 049b7c80224e1455c45c69b0affbfefa9325164e
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 25 17:19:02 2015 +0200
swrap: Correctly update the msg_name in recvmsg()
This has been found while debugging nsupdate.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 73a62af0df95b23129e3722c16593c85bfc7bebb
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 25 11:45:20 2015 +0200
rwrap: Bump version to 1.1.3
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 278facd19701fed42fcd7c8438185d8fb1019988
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 25 11:44:54 2015 +0200
rwrap: Fix strict aliasing warnings for symbol binding
Signed-off-by: Andreas Schneider <asn at cryptomilk.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fee843722c7e9bd84ad565eb2a005e41bbd05e64
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Aug 25 11:44:21 2015 +0200
Find the correct symbol when res_* is a define to __res_*
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andreas Schneider <asn at cryptomilk.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 48d4aac563d8980571ae504dd9e63c0620eee4c6
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 8 08:18:02 2015 +0200
fruit: Fix CID 1323186 Dereference before null check
In all other "goto fail;" paths we had already dereferenced fsp,
so the if-statement checking for fsp!=NULL was unnecessary. This
fix gives us an additional error message in case check_aapl fails.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Tue Sep 8 13:47:01 CEST 2015 on sn-devel-104
commit 04c86557195a014bd7e872014e6144c100ead0a1
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 8 07:47:55 2015 +0200
dsdb: Fix a confusing parameter
LDB_SCOPE_BASE is 0, so this works, but the corresponding parameter
is "struct ldb_control **controls", so I'd say NULL is more appropriate
here. Fixes a warning I just saw pass by.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit facb11b61a6cd322c8b4c42ca2caefe0c509c37c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 8 07:46:35 2015 +0200
samdb: Fix CID 1034736 Dereference after null check
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6b44ce64242a2f3fe879e59d2337c6801357390b
Author: Timur Bakeyev <timur at FreeBSD.org>
Date: Fri Sep 4 15:03:24 2015 +0200
configure: Fix aio_suspend detection
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11494
Signed-off-by: Timur Bakeyev <timur at FreeBSD.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit a7b6dd4f2f0583e24dff139f6f8e6a707585456d
Author: Volker Lendecke <vl at samba.org>
Date: Fri Sep 4 16:40:25 2015 +0200
libsmbclient: Fix 32-bit problems
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Mon Sep 7 15:13:08 CEST 2015 on sn-devel-104
commit e79877a230ebccee71609ef8ec7af4323875668d
Author: Martin Schwenke <martin at meltin.net>
Date: Sun Aug 16 13:26:21 2015 +1000
ctdb-tools: Add dbstatistics to ctdb_diagnostics
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Sep 7 10:00:54 CEST 2015 on sn-devel-104
commit bce6a386d3e231613c2a08094d8460f78ac9183e
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Mar 23 16:10:51 2015 +1100
ctdb-daemon: Drop struct ctdb_control_killtcp
Just use ctdb_tcp_connection. It is the same. There are no external
users.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit 2a8b21e5ae7e90f63c2fb87a7c747d8d1fc2c01e
Author: Volker Lendecke <vl at samba.org>
Date: Wed Sep 2 13:20:08 2015 +0200
vfs_gpfs: Avoid calling gpfs_is_offline on every i/o
Asks gpfs as long as a file is offline. Once it was reported online once,
we'll not ask anymore. This assumes that while we have a file open it
won't be migrated away. This might not *always* be true, but probably
close enough. And as long as we don't have a proper notification mechanism
and as long as polling is too expensive, this seems like a good strategy.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christof Schmitt <cs at samba.org>
Autobuild-User(master): Christof Schmitt <cs at samba.org>
Autobuild-Date(master): Sat Sep 5 01:50:09 CEST 2015 on sn-devel-104
commit 53a8cc7c0df37d68270a9e1877c14d40e96abf53
Author: Volker Lendecke <vl at samba.org>
Date: Thu Sep 3 12:10:35 2015 +0200
vfs_gpfs: Introduce vfs_gpfs_fsp_is_offline
This consolidates a few common calls
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Christof Schmitt <cs at samba.org>
commit 0fb8ea76527e26b97b8c03b15cc7b4bb847c7c92
Author: Jeremy Allison <jra at samba.org>
Date: Wed Sep 2 17:12:33 2015 -0700
winbind: Don't delete an existing krb5 ticket on cached logon.
Cached logon doesn't mean the ticket is bad, wait until we go
online again to determine that.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11198
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Sep 4 01:35:16 CEST 2015 on sn-devel-104
commit 239062a062bb70c50bf884885b58054c44c9ebf8
Author: Volker Lendecke <vl at samba.org>
Date: Thu Sep 3 16:25:02 2015 +0200
ctdb: Fix a 32-bit problem
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Sep 3 22:12:02 CEST 2015 on sn-devel-104
commit e4b0ea14250ab35db6fa7494d1e79c3e678696a5
Author: Har Gagan Sahai <SHarGagan at novell.com>
Date: Wed Sep 2 10:54:24 2015 -0700
Fix memory leak in dns resolution during spnego authentication using kerberos.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11471
Signed-off-by: Har Gagan Sahai <SHarGagan at novell.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Sep 3 19:11:22 CEST 2015 on sn-devel-104
commit 22a37c453d83c39634fbae72de592024d9b8ba4a
Author: Björn Jacke <bj at sernet.de>
Date: Wed Sep 2 12:37:12 2015 +0200
tls: increase Diffie-Hellman group size to 2048 bits
1024 bits is already the minimum accepted size of current TLS libraries. 2048
is recommended for servers, see https://weakdh.org/
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Sep 3 03:47:48 CEST 2015 on sn-devel-104
commit b49b1bd8dcc9a74440a2845f609024ee8bf173bf
Author: Björn Jacke <bj at sernet.de>
Date: Wed Sep 2 12:37:11 2015 +0200
doc: fix description of tls dh params file parameter
Signed-off-by: Bjoern Jacke <bj at sernet.de>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 2d0e3015b1974170d45be2f23bbf5ed1ab274da8
Author: Ralph Boehme <slow at samba.org>
Date: Fri Aug 7 15:48:33 2015 +0200
s4:torture:vfs_fruit: created empty resourceforks
Check for opens and creates, created empty resourceforks result in
ENOENT in subsequent opens.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11467
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Sep 2 06:50:16 CEST 2015 on sn-devel-104
commit c1e1891110bdaf562f1b8e47c1e81833b0c74152
Author: Ralph Boehme <slow at samba.org>
Date: Thu Aug 6 11:32:29 2015 +0200
s4:torture:vfs_fruit: add a resource fork truncation test
Truncating a resource fork to 0 bytes should make it inaccessible for
subsequent creates and return NT_STATUS_OBJECT_NAME_NOT_FOUND.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11467
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6263495b5b897aeaf059e306d1c3a30b1692356f
Author: Ralph Boehme <slow at samba.org>
Date: Tue Aug 25 17:06:52 2015 +0200
vfs_fruit: delete ._ file when deleting the basefile
0 byte resource fork streams are not listed by vfs_streaminfo, as a
result stream cleanup/deletion of file deletion doesn't remove the
resourcefork stream.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11467
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit db1c074435e8365bf3e36000e084465538b15e4c
Author: Ralph Boehme <slow at samba.org>
Date: Wed Aug 12 07:34:53 2015 +0200
vfs_fruit: split and simplify fruit_ftruncate
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11467
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 34759c8e7c9939c377f7b9e7486cc533daa28625
Author: Ralph Boehme <slow at samba.org>
Date: Sat Aug 8 20:21:39 2015 +0200
vfs_fruit: handling of empty resource fork
Opening the resource fork stream with O_CREAT mustn't create a visible
node in the filesystem, only create a file handle. As long as the
creator didn't write into the stream, other openers withour O_CREAT
MUST get an ENOENT error. This is way OS X SMB server implements it.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11467
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ba6c7df7f9d0c2d54b6b7e8b423b753cb7ccac31
Author: Thomas Nagy <tnagy at waf.io>
Date: Fri Jun 26 22:32:43 2015 +0200
build:wafsamba: Use the Waf 1.8 API get_tgen_by_name instead of name_to_obj
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Sep 2 03:49:51 CEST 2015 on sn-devel-104
commit ffea9a17d775005539692b1516eb4178d6c5234a
Author: Thomas Nagy <tnagy at waf.io>
Date: Fri Jun 26 20:48:43 2015 +0200
build:wafsamba: Close file handles in the build scripts too
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit da9eee80e4bf6a00694074d1a16438420b7c09f2
Author: Thomas Nagy <tnagy at waf.io>
Date: Fri Jun 26 20:17:06 2015 +0200
third_party:waf: fix a mis-merge - Utils.check_dir issue
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit bcf5f45d8731b713be7c34b50ff3f93974eac7f3
Author: Thomas Nagy <tnagy at waf.io>
Date: Fri Jun 26 20:13:09 2015 +0200
third_party:waf: Backport parts of the waf 1.8 API
This modifies our waf 1.5 wafadmin copy to resemble the waf 1.8
waflib API. It is a preparation to change to waf 1.8, decoupling
this change from changes in wafsamba.
Signed-off-by: Thomas Nagy <tnagy at waf.io>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 841845dea35089a187fd1626c9752d708989ac7b
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 1 08:41:04 2015 +0200
samr4: Use <SID=%s> in GetGroupsForUser
This way we avoid quoting problems in user's DNs
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Sep 1 23:49:14 CEST 2015 on sn-devel-104
commit b3f906f9323f2cfa7d6f16c417e5cca8103f8033
Author: Volker Lendecke <vl at samba.org>
Date: Tue Sep 1 17:13:36 2015 +0200
Revert "winbind: Fix 100% loop"
This reverts commit e551cdb37d3e8cfb155bc33f9b162761c8d60889.
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Sep 1 20:47:50 CEST 2015 on sn-devel-104
commit 5aefea842528d053b86b50ff2ed9047db1ca4594
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 1 15:00:30 2015 +1200
python/tests: Add more assertions that we get back the value we expect
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Sep 1 17:00:53 CEST 2015 on sn-devel-104
commit 1f50e194517b84ccc8d0208d563e83dabfb2327a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 1 14:58:20 2015 +1200
python/tests: Add tests for 64 bit signed integers
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e6fbeb860638ad1113914b9460a618025d950d08
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Sep 1 10:30:49 2015 +0200
pidl/python: also add a ndr_PyLong_FromLongLong() for symnetric reasons
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d1416d65a3cc61e4e56d1a43bb634d12f418ba0e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Sep 1 14:33:35 2015 +1200
pidl/python: Provide static inline helper function ndr_PyLong_FromUnsignedLongLong
This should isolate any coverity warnings on 64-bit platforms
(where LONG_MAX is larger than any possible 32 bit value) to
a single spot, or possibly eliminate it.
This is needed for the unsigned 64 bit case, and on 32 bit
systems, as PyInt_FromLong is limited to a signed "long" int.
The compiler should be able to eliminate many of these calls
with the embedded type knowlege.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c2f4e324d9c1ced2e1da859594ef67ae9f645919
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Aug 28 11:46:56 2015 +1200
pidl/python: Calculate maximum integer values using a lookup table
This avoids a << of 64 bits in the unused end of the conditional expression.
This was flagged by Coverity and the fix was suggested by metze.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 88b27ebcc94da40783d01f5496bfcaad467e6048
Author: Garming Sam <garming at catalyst.net.nz>
Date: Tue Nov 18 12:41:30 2014 +1300
spoolss: handle SetPrinter for info level 4
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10770
Signed-off-by: Garming Sam <garming at catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Sep 1 03:33:13 CEST 2015 on sn-devel-104
commit 2947a7041ba22b52a8a4ce0ad5ebc6095ea09ea0
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 27 11:14:51 2015 +0200
ldb:wscript: make it possible to build samba with a system ldb again
This fixes a regression in commit fcf4a891945b22dc6eccdc71fd441f1a879f556a.
If we check for 'ldb' later the 'pyldb-util' can't depend on the 'ldb' check.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11458
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Mon Aug 31 18:53:16 CEST 2015 on sn-devel-104
commit 770fb8cd07bd047b5206a2a7fe01eb14d9077eea
Author: Ralph Boehme <slow at samba.org>
Date: Wed Aug 12 11:06:15 2015 +0200
selftest: add a check for disabled change notify
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11444
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Mon Aug 31 15:50:49 CEST 2015 on sn-devel-104
commit b9c561273b60ea8fe1ff047238013e5cc5411c04
Author: Ralph Boehme <slow at samba.org>
Date: Wed Aug 12 11:35:27 2015 +0200
selftest: add change notify = no to simpleserver env
A subsequent patch will use this env in a torture test.
The aren't any existing tests that make use of change notify, so
disabling change notify in this test environment doesn't impact existing
tests.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11444
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 098b8a5110b4e1b873196032098807b7922e232c
Author: Ralph Boehme <slow at samba.org>
Date: Tue Aug 11 16:49:46 2015 +0200
notify: check for valid notify_ctx in notify_remove
notify_ctx will be NULL when "change notify = no" is set in smb.conf.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11444
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c3647ec39e42e8dcdd3057dbab49918c2ccf5e9a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 31 11:08:45 2015 +1200
web_server: Fix server not to segfault on startup
Pair-programmed-with: Garming Sam <garming at catalyst.net.nz>
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Mon Aug 31 04:11:55 CEST 2015 on sn-devel-104
commit 615d9b734ef67f56ec77db05023b9244841ac1b8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 31 10:59:58 2015 +1200
web_server: Use talloc_get_type_abort()
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Pair-programmed-with: Garming Sam <garming at catalyst.net.nz>
commit ac25a8ac4fc314795f9a8a15a10d731e648deea7
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 31 10:48:08 2015 +1200
lib/tls: Ensure SSLv3 is disabled in the web server by default
By calling gnutls_priority_set_direct() the behaviour should now match the LDAP server
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11076
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Pair-programmed-with: Garming Sam <garming at catalyst.net.nz>
commit cdaa1224c4d518fd8e81a3e91ad4f80ba1503145
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 31 10:33:34 2015 +1200
lib/tls: Remove unused tls_init_client code
This is unused as the callers have now been migrated to tls_tstream
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11076
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Pair-programmed-with: Garming Sam <garming at catalyst.net.nz>
commit 4164d7bf3153a2fd9081b4d073bfa88fec1507ad
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Aug 18 15:22:23 2015 +1000
ctdb-scripts: Add default filesystem usage warnings
Always check filesystem usage for the database directories.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Sat Aug 29 20:08:48 CEST 2015 on sn-devel-104
commit 0f28ccf87af4e90867eaab213a640f6d0cdaa12d
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Aug 14 17:08:45 2015 +1000
ctdb-scripts: Add default system memory usage warnings
CTDB should warn by default if too much system memory or swap is used.
The tests have also been tweaked. In particular, the filesystem-only
tests need to initialise the memory information to avoid errors where
meminfo isn't set.
Document the defaults, warning against disabling them.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 2c601f189521ae65ec5ab867c6d8c88cb5d1ae8c
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Aug 6 15:59:06 2015 +1000
ctdb-scripts: Enable system monitoring eventscript by default
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit b18e4ae0c9536a549722aeef8bc6c095b12db962
Author: Martin Schwenke <martin at meltin.net>
Date: Wed Aug 5 20:42:16 2015 +1000
ctdb-scripts: Throttle system resource monitoring warnings
They are only printed when the percentage usage changes. This should
stop the logs from being filled with warnings.
Add a test for the throttling.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit e6b5163bc1c3551a808d3741b4cbac80e15d10d9
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 3 19:55:27 2015 +1000
ctdb-scripts: Don't shutdown CTDB when memory monitoring fails
Marking the node unhealthy should cause Samba processes to close,
possible freeing a stack of memory. If not, then it is somebody
else's problem.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit b6a0e4b85699241ba90f25f4c605cbb7a6fc2146
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 3 17:22:08 2015 +1000
ctdb-scripts: New consistent system memory and swap monitoring
New variables CTDB_MONITOR_MEMORY_USAGE and CTDB_MONITOR_SWAP_USAGE.
Both take a pair of <warn_threshold>:<unhealthy_threshold> where each
theshold is specified as a percentage.
This adds a callout to check_thresholds() that is run when the
unhealthy threshold is reached.
Add some combination tests.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 02fa6c3d106e8fbf0e685afafa5e6a9bc0c3d22d
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 3 16:20:40 2015 +1000
ctdb-scripts: Factor out new function check_thresholds()
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit b7b6e25b3e26210ed196be7fc5848e3320b5c35b
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 3 15:59:50 2015 +1000
ctdb-scripts: Memory monitoring uses thresholds expressed as percentages
CTDB_MONITOR_FREE_MEMORY and CTDB_MONITOR_FREE_MEMORY_WARN are now
percentages that specify thresholds of acceptable memory usage.
Memory/swap usage in tests also specified as percentages.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit bd2845d7ebe9e2970d4d5546e51c79c9b40ce9cb
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Jul 24 19:57:42 2015 +1000
ctdb-scripts: Use MemAvailable if it is in /proc/meminfo
Otherwise calculate, as before.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 99b8ef512162570504689b53adb14a52233f49b7
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Jul 20 20:50:56 2015 +1000
ctdb-scripts: Only use /proc/meminfo for memory checks, not "free"
No need to use 2 different sources of information for similar checks.
Also, output of free has been changed, whereas /proc/meminfo is a
kernel API, which will not change.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit ab58c7abd9c49325c3cee1e7178d04a3034e57d8
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Jul 20 16:08:13 2015 +1000
ctdb-scripts: Move system memory checking to 05.system
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit b27ff251aff6d7c5c59dbe9b1748b30587402aa3
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Aug 20 11:47:19 2015 +1000
ctdb-tests: Remove unwanted trailing whitespace
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 23acbd2f4b0079d1fab01a7dad135e3451efd6d7
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Jul 17 21:32:01 2015 +1000
ctdb-tests: Add tests for filesystem usage monitoring
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit fa1050690bd28cac8bc99047a900caf2e5fca22f
Author: Martin Schwenke <martin at meltin.net>
Date: Mon Aug 3 14:56:40 2015 +1000
ctdb-scripts: New configuration variable CTDB_MONITOR_FILESYSTEM_USAGE
This allows both errors (i.e. unhealthy) and warnings for different
thresholds. It replaces CTDB_CHECK_FS_USE.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 8f713c87c1359ef8780018718f6fa47bb0fa82a7
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Jul 24 19:56:06 2015 +1000
ctdb-scripts: Don't fail monitoring if sanity checks fail
Just log some warnings.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 6b4a46e5742732d7cbdf911b74ab0bb1fc8e3b97
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Jul 17 20:04:44 2015 +1000
ctdb-scripts: Move filesystem monitoring into a function, clean it up
Drop obvious comments. Use die() for less lines of code. Use a case
statement to avoid forking unnecessary processes for each filesystem
being checked. Drop parentheses around percentages in messages.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 47f7d1b1c8432ffdfb71176cf64cdd31e188e59c
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Jul 17 11:59:56 2015 +1000
ctdb-scripts: Rename 40.fs_use to 05.system
Will put all the system monitoring in here, simplifying 00.ctdb.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit e139f19327a2d958efd4cf940ba3ae6b7956a46a
Author: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Date: Fri Aug 28 14:42:32 2015 +0200
s3: add suport for SMB3_10 and SMB3_11 protocols in smbstatus
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11472
Signed-off-by: Ralph Wuerthner <ralph.wuerthner at de.ibm.com>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Aug 29 07:05:10 CEST 2015 on sn-devel-104
commit f1f47ac93431231cebb7933c6974c6a52e24fcb4
Author: Petr Viktorin <pviktori at redhat.com>
Date: Tue Jul 14 11:02:36 2015 +0200
python: Remove uuid module
The uuid module was only built for Python 2.4 and lower, which Samba
no longer supports.
Python 2.5+ includes uuid in its standard library.
Signed-off-by: Petr Viktorin <pviktori at redhat.com>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Sat Aug 29 04:03:49 CEST 2015 on sn-devel-104
commit e551cdb37d3e8cfb155bc33f9b162761c8d60889
Author: Volker Lendecke <vl at samba.org>
Date: Fri Aug 28 12:33:13 2015 +0200
winbind: Fix 100% loop
Thanks to "L.P.H. van Belle" <belle at bazuin.nl>
for help in reproducing the issue.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11038
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Aug 28 22:03:31 CEST 2015 on sn-devel-104
commit 16c14aef2a6dfd9cdcc6d86d55e1ea008505d6d8
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Aug 28 14:16:14 2015 +0200
s3:smb2_create: #if 0 unused variable
This fixes the build on ubuntu 14.04, which failed like this:
[2852/3952] Compiling source3/smbd/smb2_create.c
../source3/smbd/smb2_create.c: In function ‘smbd_smb2_create_send’:
../source3/smbd/smb2_create.c:678:28: error: variable ‘svhdx’ set but not used [-Werror=unused-but-set-variable]
struct smb2_create_blob *svhdx = NULL;
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e6c234d31ad22120d0890b561dac9b456f8f6530
Author: Richard Sharpe <rsharpe at samba.org>
Date: Tue Jul 28 19:08:02 2015 -0700
Move the error handling for svhdx to vfswrap_create to give VFS module writers a chance to handle RSVD opens if they want to.
Also handle a review comment by Metze.
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Aug 28 03:19:36 CEST 2015 on sn-devel-104
commit d9166eb2d7880d0717dbf231b02d50c2a331827e
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 12 12:58:49 2015 +0200
lib/crypto: make it possible to use only parts of aes.[ch]
This can be used in order to optimize some parts later.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Aug 27 23:23:54 CEST 2015 on sn-devel-104
commit aaad9e9618686066ed24fef43cb3872fb9861678
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 12 12:58:49 2015 +0200
lib/crypto: sync AES_cfb8_encrypt() from heimdal
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e9d3379d72f5698d579842d2f1aafa4fd0dde56f
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Aug 14 23:45:07 2015 +0200
lib/crypto: make use of aes_test.h in aes_gcm_128_test.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 965f04d5e6c34cc56809ab42abe506ae1a7530ce
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 12 00:59:58 2015 +0200
lib/crypto: optimize aes_gcm_128
- We avoid variables in order to do a lazy cleanup
in aes_ccm_128_digest() via ZERO_STRUCTP(ctx)
- We use the optimized aes_block_{xor,rshift}() functions
- Align AES_BLOCK_SIZE arrays to 8 bytes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7e8333dac3922104849da0fde9528e2c2c36b6c9
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 12 00:59:58 2015 +0200
lib/crypto: optimize aes_ccm_128
- We avoid variables in order to do a lazy cleanup
in aes_ccm_128_digest() via ZERO_STRUCTP(ctx)
- We use the optimized aes_block_xor() function
- We reuse A_i instead of rebuilding it everything completely.
- Align AES_BLOCK_SIZE arrays to 8 bytes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8795ad2030ade771145264be7c64d960dcfdbed7
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 12 00:59:58 2015 +0200
lib/crypto: optimize aes_cmac_128
- We avoid variables in order to do a lazy cleanup
in aes_cmac_128_final() via ZERO_STRUCTP(ctx)
- We avoid unused memcpy() calls
- We use the optimized aes_block_{xor,lshift}() functions
- Align AES_BLOCK_SIZE arrays to 8 bytes
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0824221b4ae18e7ccba3f8057090abc925a02b99
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 12 00:59:58 2015 +0200
lib/crypto: add optimized helper functions aes_block_{xor,lshift,rshift}()
These are typical operations on an AES_BLOCK used by different modes.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 77c3d504b218c451c091a3d3cb4797a9d0c65d2a
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Aug 14 13:13:21 2015 +0200
lib/crypto: add aes_ccm_128 tests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 80c8a1ca9577075d5917fb63ae820105cffebd57
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 27 13:44:56 2015 +0200
lib/crypto: verify 0 updates in aes_gcm_128 tests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 683eda2f92cd296e36c57d96d6f0b22dde1819f4
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Aug 14 13:12:13 2015 +0200
lib/crypto: run all aes_gcm_128 testcases
We should not skip the first one.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7c4117f5dadab8c52e15cb121f3c112a20b1646c
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Aug 11 16:31:25 2015 +0200
lib/crypto: add aes_cmac_128 chunked tests
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 64c6cc34d7cdc48443a9427d2448ede9727aad47
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 12 12:09:24 2015 +0200
s3:vfs_smb_traffic_analyzer: remove samba_ prefix from AES_* function calls
This should be an implementation detail in lib/crypto/aes.h.
In future we may add support for other implementations.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c9d97e3a2e7d2d9ca6612fdeb5fdf7a84781bbc1
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 26 10:52:44 2015 +0200
lib: Make sid_linearize take a uint8_t
We marshall into a binary buffer, uint8_t better reflects that.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Aug 27 00:40:58 CEST 2015 on sn-devel-104
commit de421d8826e9b0595350e15afa7c8bb1fd18d301
Author: Volker Lendecke <vl at samba.org>
Date: Mon Aug 24 16:50:44 2015 +0200
lib: Remove unused sid_blob_parse
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit aa38175e00d58e0708e06b7c1e3a1a8690569a0a
Author: Volker Lendecke <vl at samba.org>
Date: Mon Aug 24 16:46:12 2015 +0200
lib: Convert callers of sid_blob_parse to sid_parse
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4a442e2eb7e0b2c62bcc355d461dfd1aaf8c26e8
Author: Volker Lendecke <vl at samba.org>
Date: Mon Aug 24 12:33:28 2015 +0200
lib: Make sid_parse take a uint8_t
sid_parse takes a binary blob, uint8_t reflects this a bit
better than char * does
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit dba9e631bd1e1c7e00430b72f0c60b32ee4eeb33
Author: Richard Sharpe <rsharpe at samba.org>
Date: Mon Aug 24 20:26:42 2015 -0700
Prevent a crash in Python modules that try to authenticate by ensuring we reject cases where credendials fields are not intialized.
Signed-off-by: Richard Sharpe <rsharpe at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Aug 25 21:45:18 CEST 2015 on sn-devel-104
commit 4e178ed498c594ffcd5592d0b792d47b064b9586
Author: Roel van Meer <roel at 1afa.com>
Date: Tue Aug 4 16:50:43 2015 +0200
s3-util: Compare the maximum allowed length of a NetBIOS name
This fixes a problem where is_myname() returns true if one of our names
is a substring of the specified name.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11427
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit dcc657a2219498beac8bde6cbf999ee7cf6acae8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 3 13:50:08 2015 +1200
selftest: Add assertion that we actually fix the replPropertyMetaData sort order
This ensures that the dbcheck rule fixes the sort order (and only fixes the sort order).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10973
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Tue Aug 25 02:45:58 CEST 2015 on sn-devel-104
commit 5504502aa68f4901f52dc2e8f7ee8b3a9c74546e
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 3 11:25:02 2015 +1200
selftest: Add in steps to re-create this database
This may assist if this needs to be changed again
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10973
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit a6957ba5da3130994d2f35328aea6f4cd604147a
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 3 11:24:10 2015 +1200
Update release-4-1-0rc3 to include data using schema modifications
This allows us to know that the previous patches are correct.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10973
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6122acad0f1a7bc23b6f58862c16968e13da979d
Author: Matthieu Patou <mat at matws.net>
Date: Mon May 25 09:17:55 2015 -0700
ldb: create a cache of known wellknown objects instead of continously searching in the db
Profiling on dbcheck have shown that we spend 10% of the time looking
for wellknown objects.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10973
Change-Id: I13ed58e8062d1b7b6179d17b0e7e56f943572c6c
Signed-off-by: Matthieu Patou <mat at matws.net>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit c049106bf8267b30a9242d2d574661291cced780
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jul 27 15:11:56 2015 +1200
dbcheck: Use set() operations to make dbcheck more efficient
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10973
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fb88f9cbd969267aaffa021724cf34087c653ba8
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jul 27 15:44:56 2015 +1200
dbcheck: Try to avoid duplicate searches
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10973
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2ff9b171378922e68205d5f0eefd2231607b5b89
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Jul 28 16:11:54 2015 +1200
dbcheck: Add additional tests for the attributeID list
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10973
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 2766bad5ef1e1949746c059c29f179ddae476239
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jul 23 16:01:14 2015 +1200
dbcheck: Add explict tests for unknown and unsorted attributeID values
Unknown attributeID values would cause an exception previously, and
unsorted attributes cause a failure to replicate with Samba 4.2.
In commit 61b978872fe86906611f64430b2608f5e7ea7ad8 we started
to sort these values correctly, but previous versions of Samba
did not sort them correctly (we sorted high-bit-set values as
negative), and then after 9c9df40220234cba973e84b4985d90da1334a1d1
we stoped accepting these.
To ensure we are allowed to make this unusual change to the
replPropertyMetaData, a new OID is allocated and checked
for in repl_meta_data.c
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10973
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit e3cf25bdc04795f884fe2a4ce0605d5175b45e93
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jul 30 14:28:48 2015 +1200
pidl: Assert that python arrays will not overflow the C array
We do not write network services in Python, so this is not a security issue, but would cause
a crash or other odd behaviour if the length was changed
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11430
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit bed29f3c92861fb2b83ad03a5c759061e1c31eba
Author: Andrew Bartlett <abartlet at samba.org>
Date: Tue Jul 28 14:29:25 2015 +1200
pydsdb: Allow the full range of uint32_t values for attributeID
The high bit may be set in these integers, so we need an unsigned int to store it in
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 336d41155e94303d0e1fa0530874539339439fed
Author: Andrew Bartlett <abartlet at samba.org>
Date: Thu Jul 30 14:29:54 2015 +1200
python/tests: Add tests for integer overflow handling
This also documents an issue with our python bindings and lists, as changes to integers in a list
of integers are not preserved
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5206ccd002b015a16952d21bd2fa441ff2e39eab
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Jul 27 10:57:43 2015 +1200
pidl: Change PIDL to correctly use and validate python integer types
In particular, it is critical that we use unsigned integers of
sufficient size in python for unsigned C integers, and it is
critical that we check for overflow at both the python and C
level.
Otherwise, we may both represent and sort these incorrectly,
in particular when sorting attributeID values from DRSUAPI
which are represented as an signed enum in C and a uint32_t in IDL,
but which often has the high bit set (in schema extensions).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 3faa7dc5a7d39cfdfc908a51e38772fda801c1a3
Author: Andrew Bartlett <abartlet at samba.org>
Date: Wed Jul 29 15:25:09 2015 +1200
python: Use an unsigned integer for buf_size, not -1
This will fail once our python bindings correctly check value ranges
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11429
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 4ef468eecdbff27347280060636afe27ce3a0b87
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 3 13:33:40 2015 +1200
dnsserver: Remove incorrect and not required include of ldb_private.h
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 617bc3fe611266b8d3d0fd47b839d4ac8ad73f8f
Author: Volker Lendecke <vl at samba.org>
Date: Fri Aug 21 11:25:33 2015 +0200
winbind: Remove "have_idmap_config" from winbindd_domain
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Mon Aug 24 19:19:31 CEST 2015 on sn-devel-104
commit b62c7e26b4783cdff11e406e4d75bc2e0fba7933
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 19 13:48:17 2015 +0200
winbind: Do not look for the domain in wb_gid2sid
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit 2387d03b8ae9a471694503677667e623dff8ef88
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 19 13:48:17 2015 +0200
winbind: Do not look for the domain in wb_uid2sid
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit 8856555af43848830b7c1e47765d26ce59dfa62b
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 19 13:44:02 2015 +0200
idmap: Remove dom_name from wbint_Gid2Sid
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit d4730474da30c707339e21746c27eed5871cfdfe
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 19 13:44:02 2015 +0200
idmap: Remove dom_name from wbint_Uid2Sid
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit 2f4dad52c77c7d0aaad2a4ccc0cb7dff0d129612
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 19 13:34:58 2015 +0200
idmap: Remove "domname" from idmap_gid_to_sid
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit 0f8c9b8d7f9a3ca288e42d857d253137e048d4bc
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 19 13:34:58 2015 +0200
idmap: Remove "domname" from idmap_uid_to_sid
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit ac4cc243771fc3273872547087679db21c9bb1cb
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 18 17:34:29 2015 +0200
idmap: Remove "domname" from idmap_backends_unixid_to_sid
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit ad626b9e6b3c200c70b0d840c956f7b6fff20660
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 18 17:30:27 2015 +0200
idmap: Use a range search in idmap_backends_unixid_to_sid
This obsoletes the domain name in the xid2sid calls
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit ef0c91195533d95ba4fb7947ff5f69c20aa677b8
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 19 17:00:46 2015 +0200
idmap: Initialize all idmap domains at startup
So far we have initialized idmap domains on demand indexed by name.
For sid2xid this works okay, because we could do lookupsids before
and thus get the name. For xid2sid this is more problematic. We
have to rely on enumtrustdoms to work completely, and we have to
look at the list of winbind domains in the parent to get the domain
name. Relying on domain->have_idmap_config is not particularly nice.
This patch re-works initialization of idmap domains by scanning all
parametric parameters, scanning for :backend configuration settings.
This way we get a complete list of :range definitions. This means
we can rely on the idmap domain array to be complete. This in turn
means we can live without the domain name to find a domain, we can
do a range search by uid or gid.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit d36de86639b7782e1e959d61917d8f19fdfc902c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 18 16:58:02 2015 +0200
idmap: Move idmap_init() under the static vars
Just moving code, idmap_init will need to reference the variables
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit 443dd9bbbc641ede10a2a3708465f61ea3dfbde3
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 18 13:18:33 2015 +0200
loadparm3: Add lp_wi_scan_global_parametrics()
This routine takes a regex and goes through all parametric parameters
in [global], matching the regex. It can easily be extended to also
look at shares, but right now it will only be used to list all idmap
config domain names.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11464
commit f504681c830d1750642d3026ac54fc6593ba246e
Author: Andreas Schneider <asn at samba.org>
Date: Fri Aug 21 11:06:07 2015 +0200
uwrap: Bump version to 1.1.1
Signed-off-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Fri Aug 21 17:48:45 CEST 2015 on sn-devel-104
commit a71610cbfaa8e4e6790ab8041f5f2e6cc1e5071f
Author: Andreas Schneider <asn at samba.org>
Date: Fri Aug 21 11:05:24 2015 +0200
uwrap: Removed double newline
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fc68e845e23f2c83726cd9d658770c49296238cb
Author: Andreas Schneider <asn at samba.org>
Date: Fri Aug 21 11:04:49 2015 +0200
uwrap: Fix build if getres(uid|gid) are not available.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 6363c0232c2238e1a782e9c22ef762e3ff9b7563
Author: Andreas Schneider <asn at samba.org>
Date: Wed Aug 19 16:19:30 2015 +0200
s3-auth: Fix a memory leak in make_server_info_info3()
We call make_server_info(NULL) and it is possible that we do not free
it, because server_info is not allocated on the memory context we pass
to the function.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9862
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit e8c76932e4ac192a00afa3b9731f5921c4b37da6
Author: Andreas Schneider <asn at samba.org>
Date: Wed Aug 19 16:24:08 2015 +0200
s3-auth: Pass nt_username to check_account()
We set nt_username above but do not use it in this function.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9862
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 34965d4d98d172e848e2b96fad8a9e0b99288ba7
Author: Andreas Schneider <asn at samba.org>
Date: Wed Aug 19 16:11:47 2015 +0200
s3-auth: Fix 'map to guest = Bad Uid' support
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9862
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Guenther Deschner <gd at samba.org>
commit 53e8d527f3e2d9ff0173263531105d29e7eabb20
Author: Volker Lendecke <vl at samba.org>
Date: Mon Aug 17 21:12:56 2015 +0200
param: Use talloc_pooled_object
Reduce memory fragmentation a bit and obsolete NULL checks
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Fri Aug 21 14:45:58 CEST 2015 on sn-devel-104
commit 0f600c34599a61a4c338b1e10af438016bec0b14
Author: Volker Lendecke <vl at samba.org>
Date: Mon Aug 17 21:07:37 2015 +0200
param: Simplify set_param_opt()
"not_added" is not a very good boolean flag concept... An early
return serves the same purpose just as well.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 78d7512db9e0098c5ae16111b1338eaa80673d5e
Author: Volker Lendecke <vl at samba.org>
Date: Mon Aug 17 17:15:27 2015 +0200
lib: Remove unused parmlist code
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 59e955bfd136cbe798d155a4930f6ce4bfe00020
Author: Robin Hack <hack.robin at gmail.com>
Date: Fri Aug 21 13:54:03 2015 +1200
vfs_scannedonly: Remove vfs_scannedonly from samba source tree.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11459
Signed-off-by: Robin Hack <hack.robin at gmail.com>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Aug 21 07:17:35 CEST 2015 on sn-devel-104
commit ba4c9bd08c09e77df5f653dc7c39be9e2908cfc0
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 10:32:46 2015 +0200
script/autobuild.py: make sure --nonshared-binary=smbtorture,smbd/smbd keeps working
- It's very useful to have a static smbtorture binary that can be copied arround.
- It's sometimes also useful to have a static smbd binary in order avoid
runtime overhead via do_lookup_x() (in ld*.so), note that
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Thu Aug 20 19:10:19 CEST 2015 on sn-devel-104
commit 86fa1d9059f90bc62c64adeb25b9534517b9a960
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 17:38:43 2015 +0200
script/autobuild.py: test some --with-{static,shared}-modules combinations
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 3b1aa7a665215f6a95a2ee7c5caf361a4063e9c1
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Aug 14 08:40:37 2015 +0200
script/autobuild.py: use -Wmissing-prototypes and --picky-developer for samba-libs*
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 303032559d7b68d125642ea25a1ad68df3de8d6d
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 17:34:42 2015 +0200
script/autobuild.py: split out a samba_libs_configure variable
The avoids too long lines.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 43d1c92e6202b27db7f8b8820c55bffb2c486d4b
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 14:22:45 2015 +0200
s3:wscript: make --with-{static,shared}-modules options more flexible
'!module' disables a non-required module for a static/shared build.
'!DEFAULT' disables all modules defaulting to a static/shared build.
'!FORCED' disables all (non-required) modules forced to a static/shared build.
'ALL' switches the default for all non forced modules from static to shared
or from shared to static.
The most specific specification wins
e.g.
--with-static-modules='!FORCED,!DEFAULT' --with-shared-modules='!FORCED,!DEFAULT' will only
build modules which are required for the compilation. Might be useful
if someone only wants to use client utils.
--with-static-modules=ALL will build all modules statically linked.
--with-static-modules='!DEFAULT,ALL' --with-shared-modules='!DEFAULT,ALL'
might be useful for testing, it reverses the default build for all modules
which can be build shared or static.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit d830cecd03697c68bdcc5f8eaf325abb7f0c425e
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 18:57:19 2015 +0200
s3:wscript: simplify ABI matching for pdb_*_init()
The init functions of all static modules should be ignored.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit bbd82b0fee4cc4b8491ce30550b9ae8539116e3c
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 18:16:20 2015 +0200
s3:winbindd/idmap_*: make function prototypes available via static_decl_idmap;
This allows the static build of the modules.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 7b2ff4cbd31fec2cc601e349ebb63f66df004bed
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 18:16:20 2015 +0200
s3:modules/perfcount_*: make function prototypes available via static_decl_perfcount;
This allows the static build of the modules.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 37b2677648108e35a159dcf680cc7ffb581e9643
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 18:16:20 2015 +0200
s3:modules/vfs_*: make function prototypes available via static_decl_vfs;
This allows the static build of the modules.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit fd6eb8bd448f9e9d209ca407a494d4011b2e97f1
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 18:16:20 2015 +0200
examples/VFS: make function prototypes available via static_decl_vfs;
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 4451d0a5cda71b61f4d7a7529c14d831b91574bb
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 18:16:20 2015 +0200
examples/pdb: fix and validate pdb_test_init() prototype via static_decl_pdb;
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit f8fca7d3155e6ff92d40d9de1a3a2043aeb995ca
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 18:15:36 2015 +0200
s4:ntvfs/posix: fix forward declaration of struct pvfs_state
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 72e0885413d1de4206ceec2046b5e7a610116faf
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 18:15:03 2015 +0200
s3:wscript: remove leftover from vfs_notify_fam
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit a184951673ef6cd69c1356e6ea0ee4622bd01312
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 20:07:59 2015 +0200
s3:idmap: we need to allow undefined symbols in idmap_tdb
When idmap_tdb is build as shared module we need to allow undefined symbols
which callback into winbindd code.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 5134d29cbb2edcc2326de8896c5465afb3a0f392
Author: Stefan Metzmacher <metze at samba.org>
Date: Thu Aug 13 15:04:14 2015 +0200
s3:wscript: fix the build without any idmap module
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 345ef6b2adf20601e804cd67440f0540ea632a19
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 12 18:32:54 2015 +0200
smbd: Remove an unnecessary else branch
"goto out;" is sufficient before
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Aug 20 15:52:20 CEST 2015 on sn-devel-104
commit 22e1fb34669d91dacb1a08227896560aefbb19bb
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 12 17:48:41 2015 +0200
vfs: Add some {}
The "mode = " from a very casual view looked as if it was part of the
if-condition
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit 796c77d43dd1df8ff5df14397e787411d8407797
Author: Volker Lendecke <vl at samba.org>
Date: Fri Aug 14 11:40:51 2015 +0200
lib: Use dom_sid_equal where appropriate
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit 2146f39111add90b2f12aa9c29a2f9c1e12f25a5
Author: Volker Lendecke <vl at samba.org>
Date: Sun Aug 16 13:19:15 2015 +0200
ctdb: Use talloc_report_str in ctdb
This fixes CID 1125620 Insecure temporary file
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit a44a7c759888bf8d8b38ef26222d65b5a95c8e45
Author: Volker Lendecke <vl at samba.org>
Date: Mon Aug 17 11:55:26 2015 +0200
lib: Add the pointer itself to talloc_report_str
A ctdb test found this discrepancy to talloc_report_full :-)
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit 2fbce8ad0a90398b3499085f6e3dbf8e9aae24e5
Author: Volker Lendecke <vl at samba.org>
Date: Sun Aug 16 13:03:13 2015 +0200
gensec: Fix CID 242642 Unchecked return value
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit 62d08ea715d1664a7600250abbd1dc83f3a33a4c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 18 20:57:27 2015 +0200
replace: Fix bug 11455
Don't call rep_strtoull recursively
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11455
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Wed Aug 19 11:22:38 CEST 2015 on sn-devel-104
commit 963874279997b98c8b29bee6d2417f81a0e8b0d2
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 19 07:35:32 2015 +0200
ctdb: Fix some clang uninitialized errors
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 1d79f6c9e5423202d5275727e1ddc60acce65b4c
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 19 07:33:48 2015 +0200
ctdb: Fix the build on FreeBSD 10.1
We get sockaddr_in directly in parse_ipv4
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit e8c602dfa2f08a9ea43c84a7e7ae9fe17e007d60
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 12 09:24:42 2015 +0200
s4:torture/rpc: fix ndr_security.h include in fsrvp.c
We should not include ndr_security.c
This allows ./configure --nonshared-binary=smbtorture again.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Mon Aug 17 20:53:10 CEST 2015 on sn-devel-104
commit b2986dcb1dca6b3c46beb8c003aede18874c813c
Author: Stefan Metzmacher <metze at samba.org>
Date: Sat Aug 15 10:59:45 2015 +0200
release-scripts/build-manpages-nogit: run make realdistclean at the end
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit bd0ec51cfca2b3baed60d304125079c74815073a
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Aug 17 08:56:43 2015 +0200
s3:smb2_negprot: prefer AES128_CCM if the client supports it
Callgrind showed that we use 28,165,720,719 cpu cycles to send
a 100MB file to a client using aes-ccm.
With aes-gcm this is raises up to 723,094,413,831 cpu cycles.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 05dbd3b47a728acada971b545df458ae0e082ec5
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Aug 17 08:56:43 2015 +0200
libcli/smb: prefer AES128_CCM
Callgrind showed that we use 28,165,720,719 cpu cycles to send
a 100MB file to a client using aes-ccm.
With aes-gcm this is raises up to 723,094,413,831 cpu cycles.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11451
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit dc2d5ccd56ff8c59f3686a652ec3082069914bb4
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 17 16:03:10 2015 +1200
Revert "ldb-samba: Implement transitive extended matching"
This reverts commit 2a22ba34cd6f28950246b54c6577c922c61f4fdb.
selftest/knownfail entries are added to ensure 'make test' continues to pass
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10493
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8cacd5b8113fa30fb4ccaaf3193839660feb285f
Author: Andrew Bartlett <abartlet at samba.org>
Date: Mon Aug 17 16:09:35 2015 +1200
Revert "dsdb: Only parse SAMBA_LDAP_MATCH_RULE_TRANSITIVE_EVAL as a DN"
This reverts commit 1a012d591bca727b5cabacf6455d2009afb16bd7.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10493
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit ce3c77fb45ccf4d45a0fa655325e30e748d89245
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri Aug 14 12:54:00 2015 +0200
s3:lib: fix some corner cases of open_socket_out_cleanup()
In case of timeouts we retry the async_connect_send() and forgot
to remember it, this results in an abort() in async_connect_cleanup()
as the fd is already closed when calling fcntl(F_SETFL).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11316
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Volker Lendecke <vl at samba.org>
commit c93e2cdd1ef9f9e32e018c81b58f891cc95c0398
Author: Andreas Schneider <asn at samba.org>
Date: Fri Aug 14 10:59:05 2015 +0200
waf: Check for Linux has 32-bit credential calls
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Aug 14 18:04:53 CEST 2015 on sn-devel-104
commit e6c8452093cd169958668543872fd4bc13755240
Author: Volker Lendecke <vl at samba.org>
Date: Mon Aug 10 12:02:34 2015 +0200
libcli: Use iov_buflen in smb2_signing.c
This gives us overflow protection.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Aug 14 13:56:49 CEST 2015 on sn-devel-104
commit a431828460a8b069589662ad87e47c61c020eb9c
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Aug 14 16:43:41 2015 +1200
python:samba/upgrade.py Fix format string syntax in error condition
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11436
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Fri Aug 14 10:52:39 CEST 2015 on sn-devel-104
commit 5d141a32f34de1773c18f2f7752f495eb933940c
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 12 09:18:28 2015 +0200
lib: Remove some unused code
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit f0f23d6a927cf3fdde9cc2a3e89ccd4dbd89e9f3
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 12 09:14:35 2015 +0200
lib: Remove some unused code
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit f85c2a6852ad880c4df4882316ec0f6e13e87dad
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 12 08:58:31 2015 +0200
smbd: Use a struct initializer
Saves a few bytes of .text
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit ba116fa7cdcbc2ecd29d4af1a88a50a0ea6c15a8
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 12 08:55:56 2015 +0200
smbd: Remove a confusing comment
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit b5ce90e609164923dd3bb22d16e94ef998f08426
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 14:20:07 2015 +0200
nfs4acls: Remove type_name param from smbacl4_get_vfs_params
It is kindof unexpected that we get params for something else but
"nfs4:"
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Thu Aug 13 17:45:31 CEST 2015 on sn-devel-104
commit 173dca482b87c10bc68c8c2f55a9983f15e04c73
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 14:16:04 2015 +0200
nfs4acls: Fix a small memleak
We don't need the nt_ace_list beyond this function, make_sec_acl makes
a copy and make_sec_desc makes another one
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9287b6788d69f7fc481a4c857ba1e7646544072f
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 14:13:43 2015 +0200
nfs4acls: Introduce a helper variable
... triggered by removing a "==false" condition
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5caaf00e7b523759485a86d0940b91f538d1193c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 13:37:42 2015 +0200
nfs4acls: Remove a few unnecessary casts
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fafd0a0c693dc523452640f00b96114b9ffddbf7
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 13:36:45 2015 +0200
nfs4acls: Use talloc_realloc()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 7e630c32da6e3dd89325432c86e1e7870cbed9e1
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 13:34:35 2015 +0200
nfs4acls: Use talloc_zero_array()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 68c64c7b3012b964fdbc37cf9922f896aceb6f39
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 13:33:40 2015 +0200
nfs4acls: Use talloc_zero()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 8125503339bee667cda71edb476ce0ca1b7f9c54
Author: Volker Lendecke <vl at samba.org>
Date: Wed Aug 12 07:31:01 2015 +0200
nfs4acls: Use talloc_zero()
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1ba9bbd4f3165f5b793a30bd6bddc548f210f9e0
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 13:12:46 2015 +0200
nfs4acls: Remove get_validated_aceint
With the anonymous struct SMB4ACE_T we can rely on the compiler
to warn us
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit aeef82192dbdd1991aa6429b6aa0c93ff19f5263
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 13:12:46 2015 +0200
nfs4acls: Remove get_validated_aclint
With the anonymous struct SMB4ACL_T we can rely on the compiler
to warn us
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 45e1ef07b9c2730b6b092f77c85ae9d0ddad33a2
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 13:04:05 2015 +0200
nfs4acls: Remove the SMB_ACE4_INT_T typedef
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1d30e86a7e0c609147ed51725f879015d2ee2e0c
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 13:02:17 2015 +0200
nfs4acls: Remove the SMB_ACL4_INT_T typedef
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 33147171d346d18b210ae14d1d6246e67035004b
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 13:00:59 2015 +0200
nfs4acls: Use SMB4ACE_T instead of _SMB_ACE4_INT_T
We can make the _INT_ structure now be the representation of the
published anonymous struct
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 5a7997f43fb04eaf7d0402f6c42836ee468dbeb5
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 12:59:05 2015 +0200
nfs4acls: Use SMB4ACL_T instead of _SMB_ACL4_INT_T
We can make the _INT_ structure now be the representation of the
published anonymous struct
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit cf97ec56d26d03ddb1f182530e67c66dbc6c38fe
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 12:44:08 2015 +0200
nfs4acls: Remove an obsolete comment
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 157711cb4709d67603f4fc1abe8bea8dc84f8981
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 12:35:20 2015 +0200
nfs4acls: Use an anon struct for SMB4ACE_T
-typedef struct _SMB4ACE_T {char dontuse;} SMB4ACE_T;
+struct SMB4ACE_T;
Same as for ACL_T
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f15ad38d141c6654dd2a280b9289b8829dc06f0e
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 12:35:20 2015 +0200
nfs4acls: Use an anon struct for SMB4ACL_T
The relevant change:
-typedef struct _SMB4ACL_T {char dontuse;} SMB4ACL_T;
+struct SMB4ACL_T;
We can use anonymous structs to prevent direct use. This patch will
trigger a set of simplifications in the next patches
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9db523b169def3aef11664d7a297cd0bc44259fd
Author: Volker Lendecke <vl at samba.org>
Date: Tue Aug 11 12:12:53 2015 +0200
nfs4acls: Use ZERO_STRUCTP
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1fcad53d7ca1be619bbc9572100b38886114dee7
Author: Volker Lendecke <vl at samba.org>
Date: Fri Aug 7 08:29:17 2015 +0200
dns_server: Fix a small memleak
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Fri Aug 7 12:57:02 CEST 2015 on sn-devel-104
commit 938636886c0bb2c0cc66976c4c6dc763d589335c
Author: Volker Lendecke <vl at samba.org>
Date: Fri Aug 7 07:58:20 2015 +0200
dns_server: Don't call tevent_req_finish twice
Both tevent_req_werror and tevent_req_done call tevent_req_finish on a request.
This should not be done. We should only call either of both.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 7258061e5e9cd4b68f1c010c3667c3fd2b0663cc
Author: Ralph Boehme <slow at samba.org>
Date: Sun May 10 11:58:32 2015 +0200
s4:torture:vfs_fruit: add a test for stream names
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11278
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fe4909f1cab72f80715a996a63290462102aabc6
Author: Ralph Boehme <slow at samba.org>
Date: Thu Aug 6 13:48:54 2015 +0200
s4:torture:vfs_fruit: pass xattr name as arg to torture_setup_local_xattr()
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11278
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 1db11998bf1b0eef5f543377700b03ab8739338d
Author: Ralph Boehme <slow at samba.org>
Date: Sat May 9 15:12:41 2015 +0200
vfs_catia: run translation on stream names
With vfs_fruit option "fruit:encoding = native" we're already converting
stream names that contain illegal NTFS characters from their on-the-wire
Unicode Private Range encoding to their native ASCII representation.
Unfortunately the reverse mapping for stream names was not perfomed.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11278
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit fb9a64ea37dd4b0cd754fe6d421417a4c8ccbc57
Author: Ralph Boehme <slow at samba.org>
Date: Sat May 9 15:02:03 2015 +0200
vfs_streams_xattr: stream names may contain colons
With vfs_fruit option "fruit:encoding = native" we're already converting
stream names that contain illegal NTFS characters from their on-the-wire
Unicode Private Range encoding to their native ASCII representation.
As as result the name of xattrs storing the streams (via
vfs_streams_xattr) may contain a colon, so we have to use strrchr_m()
instead of strchr_m() for matching the stream type suffix.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11278
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit eba12122ccce602aede7756b8f91d34fe927d2c0
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Aug 4 17:03:50 2015 +1000
ctdb-tests: Add a policy routing test with misconfiguration
To support this, extend the "ip route add" stub to detect duplicate
routes.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Fri Aug 7 08:37:38 CEST 2015 on sn-devel-104
commit 5a6a9326e58c4ebabd351326493d5d320e0130e6
Author: Martin Schwenke <martin at meltin.net>
Date: Tue Aug 4 16:12:31 2015 +1000
ctdb-tests: Make fake gateway different to actual public IPs
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 7d04778c82a8f657b6ba0173c29529fa03ab7a25
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Jul 30 16:49:35 2015 +1000
ctdb-scripts: Improve error handling for 50.samba testparm failure
Also add tests. Update testparm stub to fake error and timeout. Add
timeout stub.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 6538ba5243a043bc727039a16a7a9d5d8027fa06
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Aug 3 15:36:06 2015 +1000
ctdb-pmda: Add missing prototype declaration for non-static function
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11434
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 7949ce103f2062aa703a24f72e11be96dc497a7a
Author: Amitay Isaacs <amitay at gmail.com>
Date: Thu Apr 2 13:53:09 2015 +1100
ctdb-daemon: Reset database statistics when resetting statistics
When the ctdb statistics is reset, reset per database statistics to keep
it consistent with ctdb statistics.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit d9030d8c10ebe6f95f33cbc691b5756d97395b0f
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Aug 3 15:02:43 2015 +1000
ctdb-system: Remove unused system specific calls
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit e45b0d49be2f487243bbe99afb6e6cd8a1f918ac
Author: Anoop C S <anoopcs at redhat.com>
Date: Mon Aug 3 14:01:58 2015 +0530
source3/rpc_client: Fix CID 1273041 Condition is redundant
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Aug 7 01:31:23 CEST 2015 on sn-devel-104
commit 661b4edd03c4f040ff6dda07d599ff74f1b2f08b
Author: Anoop C S <anoopcs at redhat.com>
Date: Mon Aug 3 13:59:33 2015 +0530
lib/talloc: Fix CID 1291639 Missing unlock
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit f57a235a1f2cda05918971127c039f0499b9658b
Author: Anoop C S <anoopcs at redhat.com>
Date: Mon Aug 3 13:57:19 2015 +0530
lib/talloc: Fix CID 1291640 Missing unlock
Signed-off-by: Anoop C S <anoopcs at redhat.com>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 9ae65b2546cb3d5c7662a37bf336dda38cfb3166
Author: Christof Schmitt <cs at samba.org>
Date: Wed Aug 5 13:31:44 2015 -0700
smbd: Log smb2 requests returning !OK with higher log level
This can be useful for narrowing down problems without taking a full
level 10 trace.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit d3ac3da98611e665dc0f4e825faa5f12f6c848ef
Author: Arvid Requate <requate at univention.de>
Date: Thu Aug 6 15:00:25 2015 +0200
s4:rpc_server/netlogon: Fix for NetApp
This patch fixes an issue where NetApp filers joined to a
Samba/ADDC cannot resolve SIDs. Without this patch the issue
can only be avoided by setting "allow nt4 crypto = yes" in smb.conf.
The issue is triggered by NetApp filers in three steps:
1. The client calls netr_ServerReqChallenge to set up challenge tokens
2. Next it calls netr_ServerAuthenticate2 with NETLOGON_NEG_STRONG_KEYS
set to 0. Native AD and Samba respond to this with
NT_STATUS_DOWNGRADE_DETECTED. At this point Samba throws away
the challenge token negotiated in the first step.
3. Next the client calls netr_ServerAuthenticate2 again, this time with
NETLOGON_NEG_STRONG_KEYS set to 1.
Samba returns NT_STATUS_ACCESS_DENIED as it has lost track
of the challenge and denies logon with the message
No challenge requested by client [CLNT1/CLNT1$], cannot authenticate
Git commit 321ebc99b5a00f82265aee741a48aa84b214d6e8 introduced
a workaround for a different but related issue. This patch makes a minor
adjustment to that commit to delay flushing the cached challenge until
it's clear that we are not in a NT_STATUS_DOWNGRADE_DETECTED
situation.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11291
Signed-off-by: Arvid Requate <requate at univention.de>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
Autobuild-Date(master): Thu Aug 6 20:29:04 CEST 2015 on sn-devel-104
commit 42f38fe8d9a34a9d3710dcddfe642257f41ece87
Author: Kai Blin <kai at samba.org>
Date: Fri Jul 17 15:27:51 2015 +0200
dns: always add authority records
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Kai Blin <kai at samba.org>
Autobuild-Date(master): Thu Aug 6 14:06:52 CEST 2015 on sn-devel-104
commit d9a3f197495951f2b85e042f1bc4525bab389879
Author: Kai Blin <kai at samba.org>
Date: Wed Oct 29 13:41:53 2014 +0100
dns: Add a SOA record to error replies
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit bda1a7320f72049cf7aad2233899eaf2a55d6973
Author: Kai Blin <kai at samba.org>
Date: Wed Oct 29 13:39:16 2014 +0100
dns: Also pass nsrecs to handle_question()
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 0e11c08d3e11c83b21e1366e9e91b6d841fbbd6c
Author: Kai Blin <kai at samba.org>
Date: Wed Oct 29 13:36:58 2014 +0100
dns: Just pass the name to create_response_rr
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit d7a54f33ef5d4f45127c9264f0c4f16a2a8a6541
Author: Kai Blin <kai at samba.org>
Date: Wed Oct 29 13:35:36 2014 +0100
dns: Add dns_get_authoritative_zone helper function
Signed-off-by: Kai Blin <kai at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 54cbecbe306eff1c36db5c98fdd106aeccdf096e
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Aug 5 15:41:29 2015 +0200
script/librelease.sh: this is replaced by script/release.sh now
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Thu Aug 6 03:49:40 CEST 2015 on sn-devel-104
commit 71128e0a3ceaec43824bc72e0c64d5ce415869a2
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Aug 4 11:33:26 2015 +0200
script/release.sh: This is a new script to do releases
This will replace script/librelease.sh and is more flexible
and powerful.
Usage: release.sh <PRODUCT> <COMMAND>
PRODUCT: ldb, talloc, tevent, tdb, samba-rc
COMMAND: fullrelease, create, push, upload, announce
GNUPGHOME=/path/to/private/gpg script/librelease.sh tdb
becomes
GNUPGHOME=/path/to/private/gpg script/release.sh tdb fullrelease
GNUPGHOME=/path/to/private/gpg script/librelease.sh samba
becomes
GNUPGHOME=/path/to/private/gpg script/release.sh samba-rc create
or later
GNUPGHOME=/path/to/private/gpg script/release.sh samba-stable create
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 9d9a767ef24a684ffe6e95bb95ecb80b8fbe11a9
Author: Stefan Metzmacher <metze at samba.org>
Date: Mon Aug 3 11:39:01 2015 +0200
wafsamba: don't add -DSTATIC_%s_MODULES* arguments for SAMBA_LIBRARY(pyembed=True)
Python helper libraries don't have any modules and having something like
'.cpython-34m' in the name, e.g. STATIC_pytalloc-util.cpython-34m_MODULES
breaks the build.
Another way to fix this would be removing PYTHON_SO_ABI_FLAG from the name.
This allows --extra-python=/usr/bin/python3 to work on Ubuntu 14.04.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit 711a420eef90026bc08c8630a8ccd0e0a78207ef
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Jun 26 19:15:31 2015 +1200
selftest: Add test for GSSAPI with no authenticator checksum mode
This was seen in the wild, with a Huawei Unified Storage System S5500 V3 against the AD DC
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11425
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Aug 5 09:43:40 CEST 2015 on sn-devel-104
commit ddee603b5e5325129ffacbfb18a260a3d807a6e1
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Jun 26 19:14:56 2015 +1200
heimdal/gssapi: Allow a NULL authenticator
Some non-GSSAPI implementations that instead try to create compatible packets by wrapping krb5_mk_req()
can trigger a NULL authenticator here. Assume this to be equvilent to specifying an all-zero
channel bindings and some reasonable (fixed) flags.
This was seen in the wild, with a Huawei Unified Storage System S5500 V3 against the AD DC
Original patch by Andrew Bartlett, restructured by Douglas Bagnall
Cherry-picked from upstream GIT 0a5de96d72cdea9e465412d7dba1e5d13e53dc09
which is the merge of https://github.com/heimdal/heimdal/pull/134
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11425
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 6224ac9cf4b04aa64fa2ee13267b76598319b042
Author: Andrew Bartlett <abartlet at samba.org>
Date: Fri Jun 26 19:14:13 2015 +1200
gensec: Add an option emulating another mode a client building GSSAPI/krb5 manually uses
This was seen in the wild, with a Huawei Unified Storage System S5500 V3 against the AD DC
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11425
Signed-off-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit 78075cfcda6e6899f6a7e147b8d35ec258c4bb7d
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 4 12:00:33 2015 +0200
waf: Add talloc as a dependency
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Wed Aug 5 04:08:30 CEST 2015 on sn-devel-104
commit 38d76178026761a871243c436d905664d2b6f57b
Author: Andreas Schneider <asn at samba.org>
Date: Mon Aug 3 13:10:28 2015 +0200
sdb: Assert if the HDB flags will change
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit ab0857540551648af28b6d1079d539e9b1b35e00
Author: Andreas Schneider <asn at samba.org>
Date: Tue Aug 4 11:35:45 2015 +0200
hdb-samba: Translate SDB errors to HDB errors
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
commit a3af16613f7b870a6cf7e2cfd83960076018962b
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 15:31:20 2015 +0200
s4-torture: add test for CLUSCTL_NODE_GET_ID in clusapi_NodeControl.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
Autobuild-User(master): José A. Rivera <jarrpa at samba.org>
Autobuild-Date(master): Tue Aug 4 22:14:33 CEST 2015 on sn-devel-104
commit 321fe41e552d1f6063d436f3828b70d2bb626c96
Author: Günther Deschner <gd at samba.org>
Date: Fri Jul 17 11:39:52 2015 +0200
s3-rpcclient: add client for create enum ex.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit 93572c9cba33d2cb84e131e0b6ac50e741b419e8
Author: Günther Deschner <gd at samba.org>
Date: Fri Jul 17 00:14:09 2015 +0200
s4-torture: add more ndr tests for property lists.
This data is derived from clusapi_NodeControl.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit d6a8e35a079f52c19101f0ffa76dd6ba60ee466b
Author: Günther Deschner <gd at samba.org>
Date: Thu Jul 16 23:28:33 2015 +0200
s4-torture: add torture test for clusapi_NodeControl.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit 7cea0aa6638379c94d6371ab927967fff7cf0588
Author: Günther Deschner <gd at samba.org>
Date: Thu Jul 16 23:22:18 2015 +0200
clusapi: add clusapi_NodeControlCode to IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit d6210991ccc7c1279847388a416404d7f5472cc8
Author: Günther Deschner <gd at samba.org>
Date: Thu Jul 16 17:40:37 2015 +0200
s4-torture: add tests for GroupControl.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit e1373ea464e278f94371cfaffd819ddc543e9f38
Author: Günther Deschner <gd at samba.org>
Date: Thu Jul 16 17:03:59 2015 +0200
clusapi: add clusapi_GroupControlCode enum to IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit 2654ac3d52bcc99a650b35f492af4ba2f857217d
Author: Günther Deschner <gd at samba.org>
Date: Thu Jul 16 08:21:27 2015 +0200
s4-torture: also test ClusterControl with a large initial buffer size.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit 0f125f836035e7458e5937652c1ffab0ce948a73
Author: Günther Deschner <gd at samba.org>
Date: Thu Jul 16 08:08:51 2015 +0200
clusapi: use winreg_Type in clusapi registry IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit 2a08aa04568202bea7db9061592d20a7bf3efee7
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 14 15:55:57 2015 +0200
s4-torture: add ndr testsuite for complex clusapi_PROPERTY_LIST structs.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit 5e009e13aaf9bcc05e357862b28aa6876f7c908c
Author: Günther Deschner <gd at samba.org>
Date: Mon Jul 13 21:09:16 2015 +0200
clusapi: use ClusterEnumType in clusapi_CreateEnumEx.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit d13535d968695a4069772696132b51291df98c1c
Author: Günther Deschner <gd at samba.org>
Date: Mon Jul 13 21:08:23 2015 +0200
s4-torture: add test for clusapi_CreateEnumEx().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit b37832976d7b1cbaa54dae7db7a060fe15b31cc7
Author: Günther Deschner <gd at samba.org>
Date: Fri Jul 10 15:49:33 2015 +0200
clusapi: add PROPERTY_LIST IDL.
Note this is hand-marshalled in Windows, seen in ClusterControl reqplies for a
CLUSCTL_CLUSTER_GET_RO_COMMON_PROPERTIES control.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit e68ce4b10fd1459ff9d5c01f5da56590b7b909d4
Author: Günther Deschner <gd at samba.org>
Date: Thu Jul 9 17:25:24 2015 +0200
s4-torture: add test for GetResourceNetworkName.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit bc144409bca4358ce4e59c661caf36cadeb6f807
Author: Günther Deschner <gd at samba.org>
Date: Thu Jul 9 17:23:32 2015 +0200
s3-clusapi: add test for GetResourceDependencyExpression.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit 1f516287ef0cbd5efe8969899c5a90c36c80ceef
Author: Günther Deschner <gd at samba.org>
Date: Wed Jul 1 16:58:06 2015 +0200
s4-torture: add more tests for clusapi_OpenResource().
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: José A. Rivera <jarrpa at samba.org>
commit 95eb6db580678a29b1f5f30a9567ea449a43d75a
Author: Ralph Boehme <slow at samba.org>
Date: Tue Aug 4 11:18:34 2015 +0200
s3-net: use talloc array in share allowedusers
Bug: https://bugzilla.samba.org/show_bug.cgi?id=11426
Signed-off-by: Ralph Boehme <slow at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Tue Aug 4 16:48:36 CEST 2015 on sn-devel-104
commit 9c48dbde06ac7d0c3cea52401ddf78e604e02b83
Author: Volker Lendecke <vl at samba.org>
Date: Sat Aug 1 17:59:14 2015 +0200
dns_server: Fix CNAME handling
recs[i].wtype is == DNS_TYPE_CNAME, and my understanding of the union is that
data.cname is filled. We get away with this, because ipv4 and ipv6 have the
same char * representation, but it's confusing.
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
Autobuild-User(master): Volker Lendecke <vl at samba.org>
Autobuild-Date(master): Tue Aug 4 13:41:17 CEST 2015 on sn-devel-104
commit 3fbcd78a75fc8312432dec38b7dfd1d6df80e8e0
Author: Volker Lendecke <vl at samba.org>
Date: Sat Aug 1 17:53:56 2015 +0200
dns_server: Add NULL check
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ira Cooper <ira at samba.org>
commit 28de101bb8a48c8279c633a362853f03b30d8c71
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Jul 9 18:16:56 2015 +1200
lib/util/debug.h uses va_list, needs stdarg.h
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Sat Aug 1 13:59:13 CEST 2015 on sn-devel-104
commit c64e3a8ff3297153fb2446194b924617fedc1a31
Author: Christof Schmitt <cs at samba.org>
Date: Thu Jul 30 15:52:08 2015 -0700
net: Print time of last password change in 'net ads info'
This is useful for debugging overwritten machine accounts, e.g. a
second machine is joined to a domain with the same name as the
first one.
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 487119d741b5e7a5d0805b785248b40f2b4548c8
Author: Christof Schmitt <cs at samba.org>
Date: Thu Jul 30 15:47:54 2015 -0700
secrets: Add function to fetch only password change timestamp
Signed-off-by: Christof Schmitt <cs at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3bbf3848948c6afd27cd32df9c39f58995e7831b
Author: Aurelien Aptel <aaptel at suse.com>
Date: Fri Jul 31 17:01:10 2015 +0200
doc: mention that `smbd -i` exits after first connection
Signed-off-by: Aurelien Aptel <aaptel at suse.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 10374dde0f9d2e13496198b90c0c6e592bfef86c
Author: Michael Adam <obnox at samba.org>
Date: Fri Jul 24 01:56:39 2015 +0200
param: update the README with instructions for adding a parameter
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Fri Jul 31 05:00:57 CEST 2015 on sn-devel-104
commit 3f5e874340b2546a4d0d714f6a448e9317dc888c
Author: Michael Adam <obnox at samba.org>
Date: Fri Jul 24 00:31:27 2015 +0200
param: remove the static param_table.
It is now auto-generated.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8ad079da0ce098f5711a42575d3f3e59b67a3e7b
Author: Michael Adam <obnox at samba.org>
Date: Fri Jul 24 01:29:37 2015 +0200
tests:docs: don't load or test the static param_table.
It is going to be removed for the generated table.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c102ac28967fa37335a7c42c3b20211b7846282c
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 23:56:11 2015 +0200
tests:docs: remove testing the diff between the static and generated table
This reverts commit 380e0769ad3563dc762fb0c9ebe57d8131846519.
This is in preparation of the removal of the committed param_table_static.c
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 33dfaf7ef9542a047e67dd7daa5619a7d597a823
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 18:40:27 2015 +0200
param: use the generated parameter table.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit cf16ae56338b59aaa517de5a85ea8c86c77bbaf7
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 16:29:23 2015 +0200
tests:docs: test the diff between the static and generated table
This proves that the committed and the generated parameter tables
are identical (modulo order).
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 93c8e8db89e38d3b8cf5572c6792e77de622ad78
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 23:15:38 2015 +0200
tests:docs: load the full data from the generated param_table
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5efa507e7aeb254b18ae6c2a8bf19cd92b616ba2
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 23:15:07 2015 +0200
tests:docs: load the full data from the existing param_table.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2ede42e413638a5492db75654c39670821cc48e0
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 23:10:16 2015 +0200
tests:docs: add a function to load the full data structures from the table
instead of just loading the list of parameter names.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a9187359cf7c6052146b0da1c6102a72ba0e94b1
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 16:25:45 2015 +0200
tests:docs: print more complicated structures than strings in the message.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3de5d2992588a6485e113034a39429c8dfb8fb75
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 15:16:16 2015 +0200
tests:docs: common initialization in docs test.
Just load the structures once at startup.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b138d57c4da208d256fcc003256841d67461e19a
Author: Michael Adam <obnox at samba.org>
Date: Tue Apr 28 11:45:43 2015 +0200
build: generate param_table_gen.c from docs in the build
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5deeba69d4dd72412a6e2e7969b3199bb26b207c
Author: Michael Adam <obnox at samba.org>
Date: Thu Jun 18 07:37:24 2015 +0200
generate_param: add a means to generate param_table_gen.c from the docs
This is triggered by the new argument PARAMTABLE.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bbd55f69a0eb28260a6b6340926e596cb67b9956
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 18:37:00 2015 +0200
param: move the actual table out into param_table_static.c
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0dfa9e29963805fe02e945268c9ce4ff040e076d
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 17:42:22 2015 +0200
docs:smbdotconf: change type to ustring where needed.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 955e77c173d89a5876dd4d699db7d6f3b1345de7
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 17:41:28 2015 +0200
docs:smbdotconf: change type to octal where needed
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0e6fe4c807a05a606cab1a4e59fd98c7999962ae
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 17:34:28 2015 +0200
docs:smbdotconf: change type to bytes where needed
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 46069ed06c97bf7f04442d5be6e57dd49be47588
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 17:19:19 2015 +0200
docs:smbdotconf: change type to cmdlist where needed.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 317bd295d8ad4d00d1cba2c5bcb735bb3b71e3cd
Author: Michael Adam <obnox at samba.org>
Date: Fri Jul 24 01:28:56 2015 +0200
tests:docs: teach the test the types cmdlist, bytes, octal, and ustring
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 223aad4f91eef2f1e9488bc4debf23bfd1b6a323
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 18:01:40 2015 +0200
generate_param: teach missing types cmdlist, bytes, octal, ustring.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ca861f2b7302c9c96b42843de68ae8f9bf77466e
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 18:00:41 2015 +0200
generate_param: more uniform formatting of various type dicts
This allows for easier extension later on (patch context-wise).
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 99d0c3b0dc8ffc064bd5ae31a59ed0eae56bea96
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 16:24:34 2015 +0200
docs:smbdotconf: add deprecated flags where missing.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2b7396b354a6074d98b672c21e6926cdc76770ea
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 14:39:27 2015 +0200
docs:smbdotconf: make preload a synonym of 'auto services'
It is this way around in internal data structures.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c6a81dc8124c806b0013ba4033f33642ecd4a0b0
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 20:45:07 2015 +0200
docs:smbdotconf: 'write ok' is a synonym of 'writeable' not of 'read only'
(It is a reverse synonym of 'read only'...)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3c35dd47eca3a7515c8731e36f599d353d405810
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 16:51:59 2015 +0200
param: don't list '-valid' and 'copy' as synonyms - they aren't
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 179d715350bdc092946051584f86788f1cc9eed7
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 16:42:48 2015 +0200
param: make 'timestamp logs' the default writing of 'debug timestamp'
This is how it used internally.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e5ac180fbe34cc3953de246dbd4b2136e2b014ac
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 23 13:59:26 2015 +0200
param: add SYNONYM flag where missing
thereby remove DEPRECATED flags: synonyms currently
only carry the syn flag. Other flags sit on the primary
entry.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c03891c0d5a1abe739791c7705d8aa82cc3614b4
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:47:22 2015 +0200
param: move dnsdomain from generate_param to EXTRA_GLOBALS
This is alongside realm_original which is of the same kind.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ff4134329d75c90405a56558eabfe02d074b578d
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:14:26 2015 +0200
generate_param: generate struct entries if we don't generate access functions.
This shrinks LOADPARM_EXTRA_GLOBALS/LOCALS.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 36abb6f2d32a5acf5ec44a7b397034c447502553
Author: Michael Adam <obnox at samba.org>
Date: Tue Apr 28 16:47:39 2015 +0200
generate_param: make it possible to handle generated and synonym flags in iteration
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d1615ab9dfa49fc6ca15a971d63aa54ba6140ef1
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:29:56 2015 +0200
docs:smbdotconf: add 'function' argument to writeable
This is to specify the storage place for this reverse boolean.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit df6c33954e9c8d556baeb6c2d4d8e328e0213ec6
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:29:16 2015 +0200
docs:smbdotconf: add 'function' parameter to enablespoolss
this is to specify the storage place for this reverse boolean.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f19ede5003222f880f701eec15b2110ab77311f2
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:26:46 2015 +0200
docs:smbdotconf: add 'function' parameter to valid
This is to differentiate the variable/function name from
the parameter name, which is the non-standard "-valid".
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 37234031c7a61b272df738bd30e760615c3ff187
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:13:55 2015 +0200
param: rename szIdmapGID -> idmap_gid
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3566e7de9339d268d1805745d76c3045bd625019
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:12:53 2015 +0200
param: rename szIdmapUID -> idmap_uid
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8c0217c2a2107230a034d514bd2cd0aa9a185d32
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:11:12 2015 +0200
param: rename szIdmapBackend -> idmap_backend
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6b1d1a471c2274d1b7212a7be0851ed30d2665a6
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:09:35 2015 +0200
param: rename szInclude -> include
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bd92bc04171939faa67c4d998ad23df461c8368a
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:08:15 2015 +0200
param: rename szCopy -> copy
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5820c31a7d1115bc54a9f77feb46a3f4ff96f440
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 19:06:39 2015 +0200
param: rename bAvailable -> available
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c644890fa689712b3b78c41cf44f624e2d0795b2
Author: Michael Adam <obnox at samba.org>
Date: Tue May 12 13:41:44 2015 +0200
param: make 'realm' use the standard 'realm' variable.
This way, the generated lp_realm() function matches the param_table.
realm_original is only treated in the special handler now.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4ae289c27127c2af1f77108863862990419ff7f8
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 16:22:40 2015 +0200
param: turn 'cups encrypt' into a generated function
Move the special stuff of the hand-written lp_cups_encrypt()
function into a handler that is called once at load time.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5c18d0013575acc0d8a4d5d75da78583c84668c8
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 16:21:35 2015 +0200
param: rename CupsEncrypt -> cups_encrypt
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 496f275a4b3ab568e3900ecedd3f141acbf28851
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 23:49:45 2015 +0200
param: make 'winbind max domain connections' a generated function.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 78e276a35d376e45333a6d2227c1e8beaf6e3cb5
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 23:42:09 2015 +0200
param: rename winbindMaxDomainConnections -> _winbind_max_domain_connections
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 866fd3b88924f109f7767751968b9a74b6f8cb5e
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 15:28:33 2015 +0200
param: turn 'wide links' into a generated funcion
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b7172b8f7c3d8c0dce117cc0f6738ce52c7ca89f
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 15:22:30 2015 +0200
param: rename bWidelinks -> wide_links
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 44619ad2611bd02419c4a81b5434ad587b2cb8a7
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 15:18:01 2015 +0200
param: turn 'smb2 max credits' into generated option
This is achieved by moving the special treatment from
the lp_smb2_max_credits() function in the the special
handler that is called only once upon lp_load().
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ea6d35ccdddaa692f66ac2cebd7a66110cd66c98
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 14:49:16 2015 +0200
param: treat negative values of 'smb2 max credits' as default.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a6e387d689b06e45282d1ad04d4a6af9d73ca6a4
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 14:34:11 2015 +0200
param: turn 'printcap name' into a generated function
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 373245680592f746e19e1218de9ded96f50b46c1
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 14:31:43 2015 +0200
param: rename szPrintcapName -> printcap_name
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b68d13ed7b387d715904612a32abf6a5f9f59067
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 14:23:47 2015 +0200
param: turn 'min receivefile size' into a generated function
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 863f7b93602e297211d75dcb8297296b0d4d51a1
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 14:21:26 2015 +0200
param: rename iminreceivefile -> min_receivefile_size
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 217ce6d93bb8c6e7fea3deb00c5b39ea2f6d11b9
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 14:09:35 2015 +0200
param: turn 'preferred master' into a generated function
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 20c84b8d03fffb92e26e69f7284e36b1b6dccf3b
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 14:07:25 2015 +0200
param: rename iPreferredMaster -> _preferred_master
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c377f630265856dbb6b3f581c3a6a227e4498129
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 12:29:54 2015 +0200
param: use lp[cfg]_max_print_jobs() in lp[cfg]_maxprintjobs()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 6fdffc826d5f5272b44007a32515619346d19420
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 12:22:02 2015 +0200
param: generate lp[cfg]_max_print_jobs()
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 521468edb6a4b57cf0d7b3245570042ad611d4b9
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 12:00:18 2015 +0200
param: rename variable of 'max print jobs' to default.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f1846fb16330c9f126dac3e2d4ca28e450baef6b
Author: Michael Adam <obnox at samba.org>
Date: Tue Jun 16 00:15:23 2015 +0200
param: turn ldap idmap suffix into a generated function
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 614a0b9eff00bc88f200dac86615f269b4ac750f
Author: Michael Adam <obnox at samba.org>
Date: Tue Jun 16 00:12:51 2015 +0200
param: rename szLdapMachineSuffix -> _ldap_machine_suffix
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a5ddd036d2aef6319b46afdd58f79200297200de
Author: Michael Adam <obnox at samba.org>
Date: Tue Jun 16 00:06:59 2015 +0200
param: turn ldap idmap suffix into a generated function
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit bbe74ae4587ab900d7206cc14578296a35a0c793
Author: Michael Adam <obnox at samba.org>
Date: Tue Jun 16 00:04:53 2015 +0200
param: rename szLdapIdmapSuffix -> _ldap_sz_idmap_suffix
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit e65b7ec877d7555136f0292d284a70841487c560
Author: Michael Adam <obnox at samba.org>
Date: Tue Jun 16 00:00:44 2015 +0200
param: turn ldap user suffix into a generated function
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 10b36db706a17dd92f25a01c475967a7106f9ae8
Author: Michael Adam <obnox at samba.org>
Date: Mon Jun 15 23:58:35 2015 +0200
param: rename szLdapUserSuffix -> _ldap_user_suffix
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit d4fd07dedc72e69d212a4f512166f1173104904d
Author: Michael Adam <obnox at samba.org>
Date: Mon Jun 15 23:47:37 2015 +0200
param: turn ldap group suffix into a generated function
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit cd0016d88c5594b72b61bc63d43578151bc9e8de
Author: Michael Adam <obnox at samba.org>
Date: Mon Jun 15 23:45:45 2015 +0200
param: rename szLdapGroupSuffix -> _ldap_group_suffix
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 63e3c75374fda5279bc965c2b3c8de0e0c27c390
Author: Michael Adam <obnox at samba.org>
Date: Tue Apr 28 11:46:21 2015 +0200
docs:smbdotconf: add enumlist property to parameters where missing
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit ba2ea7fe332d3d38f3a9351e09c57c2618bbb38e
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 09:43:23 2015 +0200
docs:smbdotconf: add param flag 'enumlist' to the DTD
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 31e106b0ad0ca383170e556f21b5c90ed94344bc
Author: Michael Adam <obnox at samba.org>
Date: Tue May 12 10:07:10 2015 +0200
docs:smbdotconf: add handler info to smbdotconf docs where missing
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4bc1f779ef2fb2b5bcf118e66b48bee033489626
Author: Michael Adam <obnox at samba.org>
Date: Tue May 12 12:24:46 2015 +0200
docs:smbdotconf: add param flags 'handler' and 'deprecated' to the DTD
These are already used in the docs.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 854bbaf814d3d182a5ae859a58eef248cc22bbc5
Author: Michael Adam <obnox at samba.org>
Date: Wed Apr 29 01:33:03 2015 +0200
docs:smbdotconf: add param flag 'synonym' to the DTD
It is already used in the param_table.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c72defc8aea64a3648e6eaaefcaf468d0d6181b5
Author: Michael Adam <obnox at samba.org>
Date: Wed May 20 10:44:17 2015 +0200
docs:smbdotconf: fix type to bool-rev for reverse synonyms.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3bd477e7eebadd5a23e07f0dc81a1c818ba3f6d1
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 22 10:31:46 2015 +0200
tests: teach the docs test about boolean-rev
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 9abf7b4f19004706e5a8fe1662b8498434119543
Author: Michael Adam <obnox at samba.org>
Date: Thu May 14 16:31:52 2015 +0200
docs:smbdotconf: fix context of 'include' in doc
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c3fc084bf4c130cff5c7ba983813ba05ccce508f
Author: Michael Adam <obnox at samba.org>
Date: Wed May 13 11:49:39 2015 +0200
docs:smbdotconf: fix type of "preferred master" parameter.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 64b720d28495c8b8f50681f85b944b830a6f6d2b
Author: Michael Adam <obnox at samba.org>
Date: Thu Apr 30 23:32:45 2015 +0200
docs:smbdotconf: make formatting of headers uniform.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a4aaea6910e400119b3f23397a99c793de692cb9
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 09:10:34 2015 +0200
s3:lib: remove unused dummyparam.c
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 04da5a8d4bc594d2c0b247d0bba16cabb5a1c48b
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 8 18:23:28 2015 +0200
param: accompany FN_LOCAL_PARM_CHAR with FN_LOCAL_CHAR
just like with the other FN_LOCAL_PARM macros.
FN_LOCAL_CHAR is the main definition.
This is also in preparation of a possible future
removal of the _PARM variants (when snum is no
longer used...).
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit eab9417f9e7a6017a5292669cd5b6e5ea92496a8
Author: Michael Adam <obnox at samba.org>
Date: Tue Jul 21 08:23:21 2015 +0200
param: make set_variable() static.
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7e60050194eedda925ece63fd20f0a8f64dd355e
Author: Günther Deschner <gd at samba.org>
Date: Wed Jul 22 00:17:51 2015 +0200
lib/dcom: use HRESULT in dcom_create_object.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 4e5ee7146be8e4f1897e50d43157eb7e3ff6257e
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 23:37:07 2015 +0200
s4-torture: fix ResolveOxid2 test, filling in missing ref,out pointers.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit f6f543837fef6a310223053cecd20382c7c9a17c
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 23:36:26 2015 +0200
s4-torture: fix ResolveOxid test, filling in missing ref,out pointers.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a0544cb82154ee7fc6652f1301b294050e66ba04
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 22:28:32 2015 +0200
remact: use imp_levels enum in RemoteActivation IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 195faed933cccfc6ef63aeda67948084d9e6490b
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 22:23:22 2015 +0200
remact: use HRESULT in RemoteActivation IDL and tests.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 04e1f2ea90e85e0e36804b66965a120cfbc93d03
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 22:21:46 2015 +0200
lib/torture: add torture_assert_hresult_{equal,ok} macros.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 03b59a8d9bf06d6059f7bbc839f2e719fe9457c1
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 21:32:53 2015 +0200
s4-torture: fix remact test from crashing.
RemoteActivation was missing all out,ref pointers.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 2ec59185b9cfd7954b8433bacd74284a4ae72d7e
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 22:38:25 2015 +0200
s4-torture: fix test for RemoteActivation.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 60be14a4abae60dbf3bb8a707212e9a8a3a651fa
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 22:37:34 2015 +0200
remact: fix IDL for RemoteActivation.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 0cf5c8992533354e12c475a6749a2de0ad7bd06d
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:35:14 2015 +0200
s4-torture: use torture_assert macros for RemoteActivation test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 7b155c3f95439db689b3e622daf3e4b0e3df6ba8
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:23:11 2015 +0200
oxidresolver: fix ServerAlive2 IDL and test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 08e6d241a9bf821dc9f455b2d7ba067be746ec03
Author: Günther Deschner <gd at samba.org>
Date: Wed Jul 22 00:07:22 2015 +0200
rot: fix indent in rot.idl
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 1baf31e065d7079ea16984bfcc109257a54e2643
Author: Günther Deschner <gd at samba.org>
Date: Wed Jul 22 00:06:00 2015 +0200
rot: remove trailing whitespace from rot.idl
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit abf0188d447f0a4ede1a433713b27c3b27fa4e17
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 21:07:25 2015 +0200
s4-torture: fix indent of remact test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 71051a973b3a46a42c464a0a98e8525639d7d808
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:54:17 2015 +0200
remact: fix indent of remact.idl
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b3b77018b42d1195ee8d0d9f93f51f6f67f783bb
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:53:24 2015 +0200
oxidresolver: fix indent in oxidresolver.idl
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 22c9f11cf212d741830e312664be2ea302d47ab7
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:49:22 2015 +0200
dcom: fix ident in dcom.idl.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 8b5536a31bb3d66555031bc4bc340e735b66b617
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:34:40 2015 +0200
oxidresolver: fix indent of ResolveOxid2 in IDL.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 3aaeaea13b5019f0d0d062a825cd2250de77c287
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:41:34 2015 +0200
s4-torture: remove trailing whitespace from remact test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 82be9581f281123edf222ef98197a191146c03e7
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:41:12 2015 +0200
s4-torture: remove trailing whitespace from oxidresolve test.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5bc2f91814457a0839c6c04b2fdaf4f7054d397c
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:40:30 2015 +0200
remact: remove trailing whitespace from remact.idl
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit a6976b24dabc3a4d6cfce6cf689a430fe2f20ea2
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:40:07 2015 +0200
oxidresolver: remove trailing whitespace from oxidresolver.idl
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit b36aa1e09cc17332bd3893992d7a1462a3b01e6e
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:39:40 2015 +0200
orpc: remove trailing whitespace from orpc.idl
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 5af738abe3a9464a295d969e9c4e78061585f4a2
Author: Günther Deschner <gd at samba.org>
Date: Tue Jul 21 20:39:15 2015 +0200
dcom: remove trailing whitespace from dcom.idl
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit 38136c151b734edfb1f4c7edd3ff1f7053daed2e
Author: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Date: Thu Jul 9 14:17:50 2015 +1200
source3 torture: don't segfault if filename query fails
If the query return status is not OK, the query answer pointer could
be uninitialised.
Signed-off-by: Douglas Bagnall <douglas.bagnall at catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Simo Sorce <idra at samba.org>
commit 86dd7b941c4bcb9b45d02f15386c1673c0052f69
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 29 16:16:29 2015 +0200
smbXsrv_session:idl: remove the preauth and gensec members
They are now taken from the pending_auth member (smbXsrv_session_auth0).
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Fri Jul 31 01:03:13 CEST 2015 on sn-devel-104
commit 321862d4ac89601fb9453e14a28db48b4f0dda9e
Author: Michael Adam <obnox at samba.org>
Date: Thu Jul 30 13:23:45 2015 +0200
s3:sesssetup: use session->pending_auth in smb1 session setup
(instead of session->gensec)
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
commit d391f6daeaeb915dd4ce9ef82c2415217c90f42f
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jul 29 16:48:55 2015 +0200
s3:smb2_sesssetup: use session->pending_auth
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 2c39036806c34eaaee5dbe2000e978a10c5af6c2
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jul 29 15:48:05 2015 +0200
smbXsrv_session: add smbXsrv_session_create_auth()
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit e9885cfd0e4abd6a6a8e276e11a57e6e58e873e6
Author: Stefan Metzmacher <metze at samba.org>
Date: Wed Jul 29 15:47:09 2015 +0200
smbXsrv_session: add smbXsrv_session_find_auth()
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit 5e463b553b467dab73bcd8816a0e415b96a5cf2d
Author: Michael Adam <obnox at samba.org>
Date: Wed Jun 25 13:30:59 2014 +0200
smbXsrv_session:idl: add smbXsrv_session_auth0
This contains various auth related items for a session,
in particular preauth. This is in preparation to take
the direct member preauth from smbXsrv_session and have
all session auth code operate on session->pending_auth
instead of session->preauth and friends.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 56f2f2b86d53f0a6bcef1977b42561071ce4af00
Author: Brad Hards <bradh at frogmouth.net>
Date: Thu Jul 30 11:34:33 2015 +1000
lib/param: move function typedef to after forward declaration of struct loadparm_context
Avoids a warning about the structure being declared inside the parameter list.
Signed-off-by: Brad Hards <bradh at frogmouth.net>
Reviewed-by: Michael Adam <obnox at samba.org>
Reviewed-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Thu Jul 30 19:25:12 CEST 2015 on sn-devel-104
commit a51ee19dc9deb7dd9c3404011c55272db4626f98
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 29 18:23:31 2015 +0200
s3:smb2_sesssetup: remove now unneeded declaration of smb2srv_session_lookup_raw
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit d49b4aafa81d121e9122f84b0e66fb566d70c3e9
Author: Günther Deschner <gd at samba.org>
Date: Thu May 8 17:13:04 2014 +0200
s4-kdc: Use sdb in db-glue and hdb-samba4
Guenther
Pair-Programmed-With: Andreas Schneider <asn at samba.org>
Signed-off-by: Guenther Deschner <gd at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Thu Jul 30 13:29:27 CEST 2015 on sn-devel-104
commit 99d3719e7d3073989442cffe635c3ac7a0bc200c
Author: Günther Deschner <gd at samba.org>
Date: Thu May 8 17:09:08 2014 +0200
s4-kdc: Introduce a simple sdb_hdb shim layer
Guenther
Pair-Programmed-With: Andreas Schneider <asn at samba.org>
Signed-off-by: Guenther Deschner <gd at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 85a041bab594d7b4e88995c9a7c6f509d8cc19f3
Author: Günther Deschner <gd at samba.org>
Date: Wed May 7 16:52:42 2014 +0200
s4-kdc: Introduce sdb a KDC backend abstraction
Guenther
Pair-Programmed-With: Andreas Schneider <asn at samba.org>
Signed-off-by: Guenther Deschner <gd at samba.org>
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 535035affc3297a89dc9e342c11ff119967dc271
Author: Günther Deschner <gd at samba.org>
Date: Mon May 12 10:40:24 2014 +0200
s4-kdc: PAC_GLUE does not depend on hdb anymore.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit b9203dc1571be66a6dd23c88a93d0efd6d305f03
Author: Andreas Schneider <asn at cryptomilk.org>
Date: Tue Feb 3 13:00:34 2015 +0100
krb5-wrap: Use the principal returned by the KDC to create the ccache
We request a TGT in uppercase from the KDC. We turned on
canonicalization for that so the KDC returns the principal in lowercase
cause of this. As we use the uppercase prinicpal to create the ccache we
fail to find the tickets we need later because it is stored in the
incorrect case. You have to use the princial returned by the KDC here.
Signed-off-by: Andreas Schneider <asn at cryptomilk.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 217d4c1531aab25a1a93962ce38ff7fe9ac1bb2c
Author: Günther Deschner <gd at samba.org>
Date: Fri Aug 1 13:11:41 2014 +0200
s4-auth: Call krb5_get_init_creds_opt_set_canonicalize() in MIT case.
Signed-off-by: Guenther Deschner <gd at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 80509dffdb7ebaa57e05589a9a896bf9a57a00e7
Author: Andreas Schneider <asn at samba.org>
Date: Tue May 5 16:53:24 2015 +0200
s3-auth: Add MIT return code for KDC not reachable
This fixes authentication with local credentials against its own server
using netbios domain name.
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 1c4dc00a5e7b3cf282a0ac79aafd702bcbf091ac
Author: Andreas Schneider <asn at samba.org>
Date: Fri Jul 24 17:48:08 2015 +0200
s4-kdc: Use smb_krb5_principal_get_(type|realm) in db-glue
Signed-off-by: Andreas Schneider <asn at samba.org>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
commit 3c0f9340e6c691e25ee2d188ac2a9c85feb797fe
Author: Jeremy Allison <jra at samba.org>
Date: Tue Jul 28 11:28:20 2015 -0700
tests: Add regression test for s3-passdb: Respect LOOKUP_NAME_GROUP flag in sid lookup.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11320
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Thu Jul 30 00:36:14 CEST 2015 on sn-devel-104
commit 8c41cbbf9ea9527b7482ec3ec44ef195dc0917c2
Author: Michael Adam <obnox at samba.org>
Date: Mon Jul 27 09:01:55 2015 +0200
s3:smb2_server: defer channel/session validation to the session setup code.
For session bind, and the channel is only to be bound to the given
session just now, so it is not valid. The early request validation
code can hence not check it, and hence validation is defered to the
actual session setup code, which can look at the session binding flags.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Michael Adam <obnox at samba.org>
Autobuild-Date(master): Wed Jul 29 21:31:09 CEST 2015 on sn-devel-104
commit 8ab4b05d3302d543037973e26609e2d27bb6bc15
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 29 11:19:55 2015 +0200
s3:smb2_sesssetup: check that the connection belongs to the session in sess.setup
Signed-off-by: Michael Adam <obnox at samba.org>
Reviewed-by: Michael Adam <obnox at samba.org>
commit 19ec5f3474efa5ce62f78ae723f1e41b87a7c51a
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 29 10:35:08 2015 +0200
smbXsrv: use smb2srv_session_lookup_client in smbXsrv_session_close_loop
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit f6816ae5bdaa0aceca154c16ad845afe781beb30
Author: Michael Adam <obnox at samba.org>
Date: Mon Jul 27 08:59:57 2015 +0200
smbXsrv: add smb2srv_session_lookup_client().
This is a variant of smb2srv_session_lookup_conn() that does
not verify the session on the channel.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit d6acf950e4bbff294fe8d6cabadee39717910d1e
Author: Michael Adam <obnox at samba.org>
Date: Wed Jul 29 10:23:14 2015 +0200
smbXsrv: rename smb2srv_session_lookup -> smb2srv_session_lookup_conn
This is in preparation of adding a variant that operates
on the client and does in particular not verify that the
connection belongs to a session as a channel.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit c765d11347048c46dc0e1cb5cc1e0da747b73524
Author: Michael Adam <obnox at samba.org>
Date: Fri May 8 23:15:51 2015 +0200
smbXsrv: add a smbXsrv_connection argument to smb2srv_session_lookup_raw
This way, we can verify that the session is valid on a channel.
Pair-Programmed-With: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
commit 66bf0e51bc864d87ef1db5b52dd54da28b75af52
Author: Stefan Metzmacher <metze at samba.org>
Date: Fri May 8 23:12:19 2015 +0200
smbXsrv: add a smbXsrv_connection argument to smbXsrv_session_local_lookup()
This way, we can verify that a session is valid on the channel.
Pair-Programmed-With: Michael Adam <obnox at samba.org>
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Michael Adam <obnox at samba.org>
commit d57e4ac3de5f53346a8d7c3f96825c1345b58f6a
Author: Björn Baumbach <bb at sernet.de>
Date: Mon Jul 27 15:15:07 2015 +0200
build: fix build with gpfs support - add missing dependency to samba-debug
Pair-programmed-with: Stefan Metzmacher <metze at samba.org>
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Wed Jul 29 13:38:59 CEST 2015 on sn-devel-104
commit b9bef361d95daf0f38363acbdec9c23f094ffaca
Author: Björn Baumbach <bb at sernet.de>
Date: Mon Jul 27 12:14:37 2015 +0200
configure: add --with-gpfs option for selecting directory with gpfs headers
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit cef8897f45f1b231d26342688542560bbe695276
Author: Björn Baumbach <bb at sernet.de>
Date: Mon Jul 27 13:20:43 2015 +0200
s3:wscript: fix indentation
Signed-off-by: Björn Baumbach <bb at sernet.de>
Reviewed-by: Alexander Bokovoy <ab at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 952a50485f68b3cffdf57da84aa9bb9fde630b7e
Author: Martin Schwenke <martin at meltin.net>
Date: Fri Jul 24 15:32:42 2015 +1000
ctdb-daemon: Check if updates are in flight when releasing all IPs
Some code involved in releasing IPs is not re-entrant. Memory
corruption can occur if, for example, overlapping attempts are made to
ban a node. We haven't been able to recreate the corruption but this
should protect against it.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
commit 8eb04d09b119e234c88150e1dc35fc5057f9c926
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Jul 27 16:51:08 2015 +1000
ctdb-banning: If node is already banned, do not run ctdb_local_node_got_banned()
This calls release_all_ips() only once on the first ban. If the node gets
banned again due to event script timeout while running release_all_ips(),
then avoid calling release_all_ips() in re-entrant fashion.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 1286b02e24a521dafa7061d09fb5c21d1ebb3011
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Jul 24 07:39:26 2015 +1000
ctdb-client: Return the correct status sent from the daemon
If a control fails and error message is set, the returned status of the
control is always set to -1 ignoring the status passed by the daemon.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit f07b746ad3f3ee2fcbb65a0d452ed80f07c9e8f9
Author: Jeremy Allison <jra at samba.org>
Date: Wed Jul 15 10:43:56 2015 -0700
lib: replace: Add strsep function (missing on Solaris).
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11359
Signed-off-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Ira Cooper <ira at wakeful.net>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Jul 29 02:24:55 CEST 2015 on sn-devel-104
commit dc99d451bf23668d73878847219682fced547622
Author: Justin Maggard <jmaggard at netgear.com>
Date: Tue Jul 21 15:17:30 2015 -0700
s3-passdb: Respect LOOKUP_NAME_GROUP flag in sid lookup.
Somewhere along the line, a config line like "valid users = @foo"
broke when "foo" also exists as a user.
user_ok_token() already does the right thing by adding the LOOKUP_NAME_GROUP
flag; but lookup_name() was not respecting that flag, and went ahead and looked
for users anyway.
Regression test to follow.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11320
Signed-off-by: Justin Maggard <jmaggard at netgear.com>
Reviewed-by: Jeremy Allison <jra at samba.org>
Reviewed-by: Marc Muehlfeld <mmuehlfeld at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Tue Jul 28 21:35:58 CEST 2015 on sn-devel-104
commit adbd6d32531a339046a2bcf73d3f22ee34d7184b
Author: Günther Deschner <gd at samba.org>
Date: Wed Jul 22 18:57:57 2015 +0200
pidl: merge multiple 'genpad' implementations into one.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Günther Deschner <gd at samba.org>
Autobuild-Date(master): Fri Jul 24 16:44:16 CEST 2015 on sn-devel-104
commit 3d0b23dbd443381be1f265305ddda5434c0580aa
Author: Günther Deschner <gd at samba.org>
Date: Wed Jul 22 14:52:06 2015 +0200
vfs: fix build warning in smb traffic analyzer.
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit 2443c34c91035778c36cc0eb4e51e9e922aeea1b
Author: Günther Deschner <gd at samba.org>
Date: Fri Jul 10 09:44:40 2015 +0200
s4-torture: don't build the lsa forest trust krb5 tests when building with MIT Kerberos.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11411
Guenther
Signed-off-by: Günther Deschner <gd at samba.org>
Reviewed-by: Andreas Schneider <asn at samba.org>
commit c596ac60a568fdcace8e73e9649e91faf6cba0c8
Author: Adrian Cochrane <adrianc at catalyst.net.nz>
Date: Mon Jun 8 16:31:38 2015 +1200
install_with_python: Secure Python download with sha256 checks.
Includes a fallback using md5sum and a refactor to ensure files are cleaned up on failure.
Signed-off-by: Adrian Cochrane <adrianc at catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet at samba.org>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
Autobuild-Date(master): Fri Jul 24 05:19:06 CEST 2015 on sn-devel-104
commit 509c37da1300b843e089dfcd6657e68fa8c8c746
Author: Martin Schwenke <martin at meltin.net>
Date: Thu Jul 23 09:47:24 2015 +1000
tdb: Fix broken build with --disable-python
With --disable-python, we should not install any python files.
Signed-off-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Amitay Isaacs <amitay at gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
Autobuild-Date(master): Thu Jul 23 18:50:25 CEST 2015 on sn-devel-104
commit 5f8bad2fe7bf2887ef04a73f109b59b6aa0ddb53
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jul 12 12:45:33 2015 +0200
tdb_wrap: Use a struct initializer
... this saves 3 lines a few bytes .text :-)
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
Autobuild-User(master): Ralph Böhme <slow at samba.org>
Autobuild-Date(master): Thu Jul 23 14:39:18 CEST 2015 on sn-devel-104
commit 28e4616e2094e9f3866547481b68e198892a409b
Author: Volker Lendecke <vl at samba.org>
Date: Sun Jul 12 12:37:43 2015 +0200
tdb_wrap: Use talloc_pooled_object
One malloc() less
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Ralph Boehme <slow at samba.org>
commit 00ec3c477eba50206801b451ae4eb64c12aba5db
Author: Amitay Isaacs <amitay at gmail.com>
Date: Tue Jul 21 16:37:04 2015 +1000
ctdb-daemon: Correctly process the exit code from failed eventscripts
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Wed Jul 22 15:03:53 CEST 2015 on sn-devel-104
commit 71b89b2b7a9768de437347e6678370b2682da892
Author: Amitay Isaacs <amitay at gmail.com>
Date: Mon Jul 20 16:37:58 2015 +1000
ctdb-tool: Correctly print timed out event scripts output
The timed out error is ignored for certain events (start_recovery,
recoverd, takeip, releaseip). If these events time out, then the debug
hung script outputs the following:
3 scripts were executed last releaseip cycle
00.ctdb Status:OK Duration:4.381 Thu Jul 16 23:45:24 2015
01.reclock Status:OK Duration:13.422 Thu Jul 16 23:45:28 2015
10.external Status:DISABLED
10.interface Status:OK Duration:-1437083142.208 Thu Jul 16 23:45:42 2015
The endtime for timed out scripts is not set. Since the status is not
returned as -ETIME for some events, ctdb scriptstatus prints -ve duration.
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
commit 45e3b05966ddd013ea931e65295978525261f7f4
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jul 21 09:51:09 2015 +0200
vfs: Fix CID 1312072 Failure to restore non-local value
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Jeremy Allison <jra at samba.org>
Autobuild-Date(master): Wed Jul 22 09:06:29 CEST 2015 on sn-devel-104
commit d7a33d8b3dd6042c15692ec83e3d633226f55189
Author: Volker Lendecke <vl at samba.org>
Date: Tue Jul 21 09:45:23 2015 +0200
vfs: Fix CID 1312073 Argument cannot be negative
Signed-off-by: Volker Lendecke <vl at samba.org>
Reviewed-by: Jeremy Allison <jra at samba.org>
commit c3c024f74e6763299d39cfc60e2fbce2093c517f
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Jul 21 13:56:51 2015 +0200
WHATSNEW: Clear release notes for Samba 4.4.0pre1.
Signed-off-by: Stefan Metzmacher <metze at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Jul 21 22:07:14 CEST 2015 on sn-devel-104
commit 8eb57316f040a445d47cff8de0ca9bf4e9280acb
Author: Stefan Metzmacher <metze at samba.org>
Date: Tue Jul 21 13:56:42 2015 +0200
VERSION: Bump version up to 4.4.0pre1
Signed-off-by: Stefan Metzmacher <metze at samba.org>
-----------------------------------------------------------------------
--
Samba Shared Repository
More information about the samba-cvs
mailing list