autobuild[sn-devel-104]: intermittent test failure detected

autobuild autobuild at samba.org
Tue Aug 16 14:08:53 UTC 2016


The autobuild test system (on sn-devel-104) has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-16-1608/flakey.log

The samba build logs are available here:

   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-16-1608/samba.stderr
   http://git.samba.org/autobuild.flakey.sn-devel-104/2016-08-16-1608/samba.stdout
  
The top commit at the time of the failure was:

commit 3e42b69d5e1216b6af570a09d58040d281bbbf17
Author: Uri Simchoni <uri at samba.org>
Date:   Sat Aug 13 00:19:33 2016 +0300

    smbd: look only at handle readability for COPYCHUNK dest
    
    This commits sets the stage for a change of behavior
    in a later commit.
    
    When checking FILE_READ_DATA on the COPYCHUNK dest handle,
    only check the handle readability and not the extra right
    that may have been added due to the FILE_EXECUTE right.
    
    The check for FILE_READ_DATA always seemed strange for the
    dest handle, which is not read. It turns out that in Windows,
    this check is not done at the SMB layer, but at a lower layer
    that processes the IOCTL request - the IOCTL code has bits
    that specify what type of access check needs to be done.
    
    Therefore, this lower layer is unaware of the SMB layer's
    practice of granting READ access based on the FILE_EXECUTE
    right, and it only checks the handle's readability.
    
    This subtle difference has observable behavior - the
    COPYCHUNK source handle can have FILE_EXECUTE right instead
    of FILE_READ_DATA, but the dest handle cannot.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=12149
    
    Signed-off-by: Uri Simchoni <uri at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Tue Aug 16 15:21:03 CEST 2016 on sn-devel-144



More information about the samba-cvs mailing list