[SCM] Samba Shared Repository - branch master updated

Garming Sam garming at samba.org
Wed Apr 20 07:13:03 UTC 2016

The branch, master has been updated
       via  2ef0c9a dbcheck: Avoid pathological behaviour in operational module
      from  052b855 cleanupd: restart as needed


- Log -----------------------------------------------------------------
commit 2ef0c9a8d4623d88414eaaf32cdd18c6ef17900a
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Wed Apr 20 15:25:45 2016 +1200

    dbcheck: Avoid pathological behaviour in operational module
    Because replPropertyMetadata was repeated for every object in the
    database, the attrs list became very long.
    This single line saves 20% of the time for make test TESTS=dbcheck.
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Autobuild-User(master): Garming Sam <garming at samba.org>
    Autobuild-Date(master): Wed Apr 20 09:12:47 CEST 2016 on sn-devel-144


Summary of changes:
 python/samba/dbchecker.py | 4 ++++
 1 file changed, 4 insertions(+)

Changeset truncated at 500 lines:

diff --git a/python/samba/dbchecker.py b/python/samba/dbchecker.py
index db0803b..bcefc26 100644
--- a/python/samba/dbchecker.py
+++ b/python/samba/dbchecker.py
@@ -1229,6 +1229,10 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base)))
         '''check one object'''
         if self.verbose:
             self.report("Checking object %s" % dn)
+        # If we modify the pass-by-reference attrs variable, then we get a
+        # replPropertyMetadata for every object that we check.
+        attrs = list(attrs)
         if "dn" in map(str.lower, attrs):
         if "distinguishedname" in map(str.lower, attrs):

Samba Shared Repository

More information about the samba-cvs mailing list