[SCM] Samba Shared Repository - branch master updated

Amitay Isaacs amitay at samba.org
Wed Oct 28 05:14:03 UTC 2015


The branch, master has been updated
       via  0a90ed5 ctdb: open the RO tracking db with perms 0600 instead of 0000
      from  cbae31c build: --picky-developer implies --enable-developer

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 0a90ed51245d4a7acb23d22e47ee3fd5b83819b0
Author: Michael Adam <obnox at samba.org>
Date:   Tue Oct 27 10:20:31 2015 +0100

    ctdb: open the RO tracking db with perms 0600 instead of 0000
    
    While 0000 is possible from the UNIX/POSIX point of view,
    these permissions create problems in an environment with
    selinux enabled, which is more strict.
    
    This aligns the perms of the read only tracking db with other
    internal dbs.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=11577
    
    Signed-off-by: Michael Adam <obnox at samba.org>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Wed Oct 28 06:13:09 CET 2015 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 ctdb/server/ctdb_ltdb_server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/ctdb/server/ctdb_ltdb_server.c b/ctdb/server/ctdb_ltdb_server.c
index 93e9041..3386bba 100644
--- a/ctdb/server/ctdb_ltdb_server.c
+++ b/ctdb/server/ctdb_ltdb_server.c
@@ -721,7 +721,7 @@ int ctdb_set_db_readonly(struct ctdb_context *ctdb, struct ctdb_db_context *ctdb
 	ctdb_db->rottdb = tdb_open(ropath, 
 			      ctdb->tunable.database_hash_size, 
 			      TDB_NOLOCK|TDB_CLEAR_IF_FIRST|TDB_NOSYNC,
-			      O_CREAT|O_RDWR, 0);
+			      O_CREAT|O_RDWR, 0600);
 	if (ctdb_db->rottdb == NULL) {
 		DEBUG(DEBUG_CRIT,("Failed to open/create the tracking database '%s'\n", ropath));
 		talloc_free(ropath);


-- 
Samba Shared Repository



More information about the samba-cvs mailing list