[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Sat Oct 24 03:02:02 UTC 2015

The branch, master has been updated
       via  0a924d1 smbd: Send SMB2 oplock breaks unencrypted
      from  11620ae smbd/quotas: Remove invalid quota status switch case


- Log -----------------------------------------------------------------
commit 0a924d13cf4bb570cce3955cf0de9d8678b37dbe
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Oct 6 16:10:43 2015 +0200

    smbd: Send SMB2 oplock breaks unencrypted
    This is not what Windows server does, but it seems that Windows
    clients expect.  Windows->Windows never runs into this issue, because
    an encryption-enabled SMB3 connection will always use leases, and lease
    breaks *are* unencrypted...
    You can reproduce the issue Windows->Windows by disabling leases on the
    Windows server. Disable leases using the registry key:
    Dochelp confirmed that this is a valid workaround for Windows clients
    dropping encrypted oplock breaks.
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=11570
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Sat Oct 24 05:01:32 CEST 2015 on sn-devel-104


Summary of changes:
 source3/smbd/smb2_server.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Changeset truncated at 500 lines:

diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 29131ea..a31a6e2 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -2994,7 +2994,7 @@ NTSTATUS smbd_smb2_send_oplock_break(struct smbXsrv_connection *xconn,
 	SBVAL(body, 0x08, op->global->open_persistent_id);
 	SBVAL(body, 0x10, op->global->open_volatile_id);
-	return smbd_smb2_send_break(xconn, session, tcon, body, sizeof(body));
+	return smbd_smb2_send_break(xconn, NULL, NULL, body, sizeof(body));
 NTSTATUS smbd_smb2_send_lease_break(struct smbXsrv_connection *xconn,

Samba Shared Repository

More information about the samba-cvs mailing list