autobuild[sn-devel-104]: intermittent test failure detected
autobuild
autobuild at samba.org
Thu Nov 26 12:04:31 UTC 2015
The autobuild test system (on sn-devel-104) has detected an intermittent failing test in
the current master tree.
The autobuild log of the failure is available here:
http://git.samba.org/autobuild.flakey.sn-devel-104/2015-11-26-1304/flakey.log
The samba build logs are available here:
http://git.samba.org/autobuild.flakey.sn-devel-104/2015-11-26-1304/samba.stderr
http://git.samba.org/autobuild.flakey.sn-devel-104/2015-11-26-1304/samba.stdout
The top commit at the time of the failure was:
commit 1ee7053180057ea526870182b5619a206b4d103b
Author: Amitay Isaacs <amitay at gmail.com>
Date: Fri Nov 6 17:07:35 2015 +1100
ctdb-protocol: Fix marshalling for struct ctdb_rec_data
If the header is specified, then the datalen should be incremented.
There are two ways of marshalling ctdb_rec_data:
1. ctdb_rec_data->header is NULL and ctdb_rec_data->data embeds both
the header and the value. Used in recovery for push/pull of records.
2. ctdb_rec_data->header is not NULL and ctdb_rec_data->data embeds
only the value. Used everywhere else.
In both cases, the wire format includes the header and the value.
There is nothing in the wire format to inform the unmarshalling code
whether to extract the header separately or not.
In the current code the header is extracted depending on whether the
header argument to the extractor routine is NULL or not. This is insane
and highly error-prone.
So in the new API, unmarshalling code never extracts the header. If the
caller requires the header, then it can be extracted separately using
special function ctdb_ltdb_header_extract().
Signed-off-by: Amitay Isaacs <amitay at gmail.com>
Reviewed-by: Martin Schwenke <martin at meltin.net>
Reviewed-by: Jeremy Allison <jra at samba.org>
Autobuild-User(master): Martin Schwenke <martins at samba.org>
Autobuild-Date(master): Wed Nov 25 13:21:48 CET 2015 on sn-devel-104
More information about the samba-cvs
mailing list