[SCM] Samba Shared Repository - branch master updated

Volker Lendecke vlendec at samba.org
Fri May 29 11:50:03 MDT 2015


The branch, master has been updated
       via  3073a2e ctdbd_conn: Fix CID 1301580 Explicit null dereferenced
      from  29546f2 KCC: test suite for the graph_utils

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 3073a2ee7e7e430631ec1516da4db2b311aea900
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Apr 23 18:06:17 2015 +0200

    ctdbd_conn: Fix CID 1301580 Explicit null dereferenced
    
    Coverity does not really tell me which code path it sees where we could leave
    hdr==NULL, but this check does not hurt.
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Ira Cooper <ira at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Fri May 29 19:49:30 CEST 2015 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/ctdbd_conn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/ctdbd_conn.c b/source3/lib/ctdbd_conn.c
index 66c87c5..3aa5ced 100644
--- a/source3/lib/ctdbd_conn.c
+++ b/source3/lib/ctdbd_conn.c
@@ -1295,7 +1295,7 @@ NTSTATUS ctdbd_parse(struct ctdbd_connection *conn, uint32_t db_id,
 		goto fail;
 	}
 
-	if (hdr->operation != CTDB_REPLY_CALL) {
+	if ((hdr == NULL) || (hdr->operation != CTDB_REPLY_CALL)) {
 		DEBUG(0, ("received invalid reply\n"));
 		status = NT_STATUS_INTERNAL_ERROR;
 		goto fail;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list