[SCM] Samba Shared Repository - branch master updated

Michael Adam obnox at samba.org
Thu Mar 26 15:22:03 MDT 2015


The branch, master has been updated
       via  32cbbed s3: libsmbclient: Add missing talloc stackframe.
       via  d932964 docs: fix duplicate word in explanation of parameter 'logging'.
      from  b0a9a69 libnetapi: Fix 241166 Fixing logically dead code

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 32cbbed979b931eeb5127629248a94d7e6f3fcfb
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Mar 26 10:09:46 2015 -0700

    s3: libsmbclient: Add missing talloc stackframe.
    
    Bug 11177 - no talloc stackframe at ../source3/libsmb/clifsinfo.c:444, leaking memory
    
    https://bugzilla.samba.org/show_bug.cgi?id=11177
    
    Signed-off-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Michael Adam <obnox at samba.org>
    
    Autobuild-User(master): Michael Adam <obnox at samba.org>
    Autobuild-Date(master): Thu Mar 26 22:21:30 CET 2015 on sn-devel-104

commit d932964d5b1235c4d682eefb621d43f622008cd4
Author: Michael Adam <obnox at samba.org>
Date:   Thu Mar 26 13:45:50 2015 +0100

    docs: fix duplicate word in explanation of parameter 'logging'.
    
    Signed-off-by: Michael Adam <obnox at samba.org>
    Reviewed-by: Christof Schmitt <cs at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 docs-xml/smbdotconf/logging/logging.xml | 2 +-
 source3/libsmb/libsmb_stat.c            | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/docs-xml/smbdotconf/logging/logging.xml b/docs-xml/smbdotconf/logging/logging.xml
index 41b6c08..a82496b 100644
--- a/docs-xml/smbdotconf/logging/logging.xml
+++ b/docs-xml/smbdotconf/logging/logging.xml
@@ -5,7 +5,7 @@
 		 xmlns:samba="http://www.samba.org/samba/DTD/samba-doc">
 <description>
 
-  <para>This parameter configures logging backends backends. Multiple
+  <para>This parameter configures logging backends. Multiple
     backends can be specified at the same time, with different log
     levels for each backend. The parameter is a list of backends,
     where each backend is specified as backend[:option][@loglevel].</para>
diff --git a/source3/libsmb/libsmb_stat.c b/source3/libsmb/libsmb_stat.c
index 94449e0..3c895ce 100644
--- a/source3/libsmb/libsmb_stat.c
+++ b/source3/libsmb/libsmb_stat.c
@@ -312,9 +312,11 @@ SMBC_statvfs_ctx(SMBCCTX *context,
         bool            bIsDir;
         struct stat     statbuf;
         SMBCFILE *      pFile;
+	TALLOC_CTX *frame = talloc_stackframe();
 
         /* Determine if the provided path is a file or a folder */
         if (SMBC_stat_ctx(context, path, &statbuf) < 0) {
+		TALLOC_FREE(frame);
                 return -1;
         }
 
@@ -322,6 +324,7 @@ SMBC_statvfs_ctx(SMBCCTX *context,
         if (S_ISDIR(statbuf.st_mode)) {
                 /* It's a directory. */
                 if ((pFile = SMBC_opendir_ctx(context, path)) == NULL) {
+			TALLOC_FREE(frame);
                         return -1;
                 }
                 bIsDir = true;
@@ -329,11 +332,13 @@ SMBC_statvfs_ctx(SMBCCTX *context,
                 /* It's a file. */
                 if ((pFile = SMBC_open_ctx(context, path,
                                            O_RDONLY, 0)) == NULL) {
+			TALLOC_FREE(frame);
                         return -1;
                 }
                 bIsDir = false;
         } else {
                 /* It's neither a file nor a directory. Not supported. */
+		TALLOC_FREE(frame);
                 errno = ENOSYS;
                 return -1;
         }
@@ -348,6 +353,7 @@ SMBC_statvfs_ctx(SMBCCTX *context,
                 SMBC_close_ctx(context, pFile);
         }
 
+	TALLOC_FREE(frame);
         return ret;
 }
 
@@ -365,6 +371,7 @@ SMBC_fstatvfs_ctx(SMBCCTX *context,
 	uint32 fs_attrs = 0;
 	struct cli_state *cli = file->srv->cli;
 	struct smbXcli_tcon *tcon;
+	TALLOC_CTX *frame = talloc_stackframe();
 
 	if (smbXcli_conn_protocol(cli->conn) >= PROTOCOL_SMB2_02) {
 		tcon = cli->smb2.tcon;
@@ -488,5 +495,6 @@ SMBC_fstatvfs_ctx(SMBCCTX *context,
         st->f_flags = flags;
 #endif
 
+	TALLOC_FREE(frame);
         return 0;
 }


-- 
Samba Shared Repository


More information about the samba-cvs mailing list