[SCM] Samba Shared Repository - branch master updated

David Disseldorp ddiss at samba.org
Fri Mar 6 09:39:03 MST 2015

The branch, master has been updated
       via  90d03a6 heimdal: Fix CID 1273430 Double free
      from  87b7a7d script/autobuild.py: build the samba target with --with-profiling-data


- Log -----------------------------------------------------------------
commit 90d03a65bcb2aae262ad113da420ae63bdf5b4b1
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Mar 5 21:17:31 2015 +0100

    heimdal: Fix CID 1273430 Double free
    I think Coverity is right here: Before the preceding call to
    krb5_make_principal we already krb5_free_principal(ctx, tmp_creds.server)
    without wiping out tmp_creds.server. The call to krb5_make_principal only
    stores something fresh when it also returns 0 a.k.a. success.
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: David Disseldorp <ddiss at samba.org>
    Autobuild-User(master): David Disseldorp <ddiss at samba.org>
    Autobuild-Date(master): Fri Mar  6 17:38:09 CET 2015 on sn-devel-104


Summary of changes:
 source4/heimdal/lib/krb5/get_cred.c | 1 -
 1 file changed, 1 deletion(-)

Changeset truncated at 500 lines:

diff --git a/source4/heimdal/lib/krb5/get_cred.c b/source4/heimdal/lib/krb5/get_cred.c
index 51550da..29ab6ea 100644
--- a/source4/heimdal/lib/krb5/get_cred.c
+++ b/source4/heimdal/lib/krb5/get_cred.c
@@ -839,7 +839,6 @@ get_cred_kdc_capath_worker(krb5_context context,
 	ret = krb5_make_principal(context, &tmp_creds.server,
 				  tgt_inst, KRB5_TGS_NAME, server_realm, NULL);
 	if(ret) {
-	    krb5_free_principal(context, tmp_creds.server);
 	    krb5_free_principal(context, tmp_creds.client);
 	    return ret;

Samba Shared Repository

More information about the samba-cvs mailing list