[SCM] Samba Shared Repository - branch master updated

[Volker Lendecke]

The branch, master has been updated
       via  8536022 README.Coding: Add hint for if-statments
      from  8466587 docs/idmap_rid: remove deprecated base_rid from example

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 8536022a512223f0fa4711abf1cf92a1991a53b5
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Jan 19 10:48:20 2015 +0100

    README.Coding: Add hint for if-statments
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Mon Jan 19 13:25:12 CET 2015 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 README.Coding | 46 +++++++++++++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 19 deletions(-)


Changeset truncated at 500 lines:

diff --git a/README.Coding b/README.Coding
index 0bbba9f..f19399e 100644
--- a/README.Coding
+++ b/README.Coding
@@ -298,25 +298,6 @@ Good Examples:
 	}
 
 
-Checking Pointer Values
------------------------
-
-When invoking functions that return pointer values, either of the following
-are acceptable. Use your best judgement and choose the more readable option.
-Remember that many other persons will review it:
-
-	if ((x = malloc(sizeof(short)*10)) == NULL ) {
-		fprintf(stderr, "Unable to alloc memory!\n");
-	}
-
-or:
-
-	x = malloc(sizeof(short)*10);
-	if (!x) {
-		fprintf(stderr, "Unable to alloc memory!\n");
-	}
-
-
 Primitive Data Types
 --------------------
 
@@ -364,6 +345,33 @@ Bad Example:
 	ret = some_function_my_name(get_some_name());
 	...
 
+Please try to avoid passing function return values to if- or
+while-conditions. The reason for this is better handling of code under a
+debugger.
+
+Good example:
+
+	x = malloc(sizeof(short)*10);
+	if (!x) {
+		fprintf(stderr, "Unable to alloc memory!\n");
+	}
+
+Bad example:
+
+	if ((x = malloc(sizeof(short)*10)) == NULL ) {
+		fprintf(stderr, "Unable to alloc memory!\n");
+	}
+
+There are exceptions to this rule. One example is walking a data structure in
+an iterator style:
+
+	while ((opt = poptGetNextOpt(pc)) != -1) {
+		   ... do something with opt ...
+	}
+
+But in general, please try to avoid this pattern.
+
+
 Control-Flow changing macros
 ----------------------------
 


-- 
Samba Shared Repository