[SCM] Samba Shared Repository - branch v4-1-test updated

Stefan Metzmacher metze at samba.org
Mon Aug 31 12:40:02 UTC 2015


The branch, v4-1-test has been updated
       via  711131e s3-util: Compare the maximum allowed length of a NetBIOS name
      from  0c640d0 s3-net: use talloc array in share allowedusers

https://git.samba.org/?p=samba.git;a=shortlog;h=v4-1-test


- Log -----------------------------------------------------------------
commit 711131ea3df7ab7decc33d035c0b395caadbfe5c
Author: Roel van Meer <roel at 1afa.com>
Date:   Tue Aug 4 16:50:43 2015 +0200

    s3-util: Compare the maximum allowed length of a NetBIOS name
    
    This fixes a problem where is_myname() returns true if one of our names
    is a substring of the specified name.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=11427
    
    Reviewed-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    (cherry picked from commit 4e178ed498c594ffcd5592d0b792d47b064b9586)
    
    Autobuild-User(v4-1-test): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(v4-1-test): Mon Aug 31 14:39:49 CEST 2015 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/util.c b/source3/lib/util.c
index 641a67e..0905ca2 100644
--- a/source3/lib/util.c
+++ b/source3/lib/util.c
@@ -1194,7 +1194,7 @@ bool is_myname(const char *s)
 	for (n=0; my_netbios_names(n); n++) {
 		const char *nbt_name = my_netbios_names(n);
 
-		if (strncasecmp_m(nbt_name, s, strlen(nbt_name)) == 0) {
+		if (strncasecmp_m(nbt_name, s, MAX_NETBIOSNAME_LEN-1) == 0) {
 			ret=True;
 			break;
 		}


-- 
Samba Shared Repository



More information about the samba-cvs mailing list