[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Mon Apr 13 21:38:03 MDT 2015


The branch, master has been updated
       via  a97507a spoolss: purge the printer name cache on name change
      from  2d4db4a s3: libsmbclient: After getting attribute server, ensure main srv pointer is still valid.

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit a97507a9a7ba01beead6a621e1210618e93a9f9c
Author: David Disseldorp <ddiss at samba.org>
Date:   Wed Apr 1 01:03:13 2015 +0200

    spoolss: purge the printer name cache on name change
    
    Currently the name cache is only cleared on printer deletion. This means
    that if a printer undergoes a name change, the old name remains in the
    cache and can be subsequently used incorrecly if another printer takes
    the same name as the old.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=11210
    
    Reported-by: Franz Pförtsch <franz.pfoertsch at brose.com>
    Signed-off-by: David Disseldorp <ddiss at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Tue Apr 14 05:37:50 CEST 2015 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_server/spoolss/srv_spoolss_nt.c | 6 ++++++
 1 file changed, 6 insertions(+)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/spoolss/srv_spoolss_nt.c b/source3/rpc_server/spoolss/srv_spoolss_nt.c
index d61b072c..65a805a 100644
--- a/source3/rpc_server/spoolss/srv_spoolss_nt.c
+++ b/source3/rpc_server/spoolss/srv_spoolss_nt.c
@@ -6479,6 +6479,9 @@ static WERROR update_dsspooler(TALLOC_CTX *mem_ctx,
 						 snum, printer->sharename ?
 						 printer->sharename : "");
 		}
+
+		/* name change, purge any cache entries for the old */
+		prune_printername_cache();
 	}
 
 	if (printer->printername != NULL &&
@@ -6515,6 +6518,9 @@ static WERROR update_dsspooler(TALLOC_CTX *mem_ctx,
 			notify_printer_printername(server_event_context(),
 						   msg_ctx, snum, p ? p : "");
 		}
+
+		/* name change, purge any cache entries for the old */
+		prune_printername_cache();
 	}
 
 	if (printer->portname != NULL &&


-- 
Samba Shared Repository


More information about the samba-cvs mailing list