[SCM] Samba Shared Repository - branch master updated

Andrew Bartlett abartlet at samba.org
Thu Sep 11 00:51:05 MDT 2014

The branch, master has been updated
       via  01d4c0e torture: Provide enough space for test EA name in raw.eas test
      from  1c00533 ctdb-build: Remove unnecessary lib/util include path from tests


- Log -----------------------------------------------------------------
commit 01d4c0e804e0c10fe6acfbdbe6747dcc5df6abc9
Author: Andrew Bartlett <abartlet at samba.org>
Date:   Tue Sep 2 14:38:11 2014 +1200

    torture: Provide enough space for test EA name in raw.eas test
    The issue is that previously bad_ea_name[5] was the last element on
    the array, and so when we later did a strlen() on it, we read past the
    end of the stack array.  We need bad_ea_name[5] to be the second-last
    element, followed by the \0 placed there by the strlcpy().
    Found by AddressSanitizer
    Change-Id: I871c08200aa2591c612dfa44da92b83132f83d88
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Kamen Mazdrashki <kamenim at samba.org>
    Autobuild-User(master): Andrew Bartlett <abartlet at samba.org>
    Autobuild-Date(master): Thu Sep 11 08:50:16 CEST 2014 on sn-devel-104


Summary of changes:
 source4/torture/raw/eas.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Changeset truncated at 500 lines:

diff --git a/source4/torture/raw/eas.c b/source4/torture/raw/eas.c
index 95a55d1..15bfb2f 100644
--- a/source4/torture/raw/eas.c
+++ b/source4/torture/raw/eas.c
@@ -51,7 +51,7 @@ static bool test_eas(struct smbcli_state *cli, struct torture_context *tctx)
 	union smb_open io;
 	const char *fname = BASEDIR "\\ea.txt";
 	bool ret = true;
-	char bad_ea_name[6];
+	char bad_ea_name[7];
 	int i;
 	int fnum = -1;

Samba Shared Repository

More information about the samba-cvs mailing list