autobuild: intermittent test failure detected
autobuild at samba.org
Tue Mar 18 23:19:07 MDT 2014
The autobuild test system has detected an intermittent failing test in
the current master tree.
The autobuild log of the failure is available here:
The samba build logs are available here:
The top commit at the time of the failure was:
Author: Jeremy Allison <jra at samba.org>
Date: Mon Mar 17 14:35:00 2014 -0700
s3: smbd: Fileserving share access checks.
Git commit 86d1e1db8e2747e30c89627cda123fde1e84f579
fixed share_access not being reset between users,
by changing make_connection_snum() to call a common
function check_user_share_access() in the same way
that change_to_user() (which can be called on any
incoming packet) does.
Unfortunately that bugfix was incorrect and
broke "force user" and "force group" as it
called check_user_share_access() inside
make_connection_snum() using the conn->session_info
pointer instead of the vuser->session_info pointer.
conn->session_info represents the token to use
when actually accessing the file system, and so
is modified by force user and force group.
conn->session_info represents the "pristine"
token of the user logging in, and is never modified
by force user and force group.
Samba 3.6.x checked the share access based on
the "pristine" token of the user logging in,
not the token modified by force user and force group.
This change restores the expected behavior.
Fixes bug #9878 - force user does not work as expected
Signed-off-by: Jeremy Allison <jra at samba.org>
Tested-by: Gerhard Wiesinger <lists at wiesinger.com>
Reviewed-by: Andreas Schneider <asn at samba.org>
Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
Autobuild-Date(master): Tue Mar 18 19:19:31 CET 2014 on sn-devel-104
More information about the samba-cvs