[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Wed Mar 12 17:22:15 MDT 2014

The branch, master has been updated
       via  29d779c smbreadline: switch to new-style readline typedef
      from  9c677ff s4: smbtorture: Add a proper change_notify going async followed by tdis test.


- Log -----------------------------------------------------------------
commit 29d779c7029f89e530994c45ae065707ffd62c43
Author: Gustavo Zacarias <gustavo at zacarias.com.ar>
Date:   Thu Mar 6 18:57:40 2014 -0300

    smbreadline: switch to new-style readline typedef
    Function, CPFunction, CPPFunction and VFunction typedefs are considered
    old-style (deprecated) starting from readline 4.2 (circa 2001).
    Compatibility typedefs have been in place up to readline 6.2 but were
    removed with the 6.3 release thus causing builds to break.
    Switch to the new-style specific prototyped typedef.
    Return value is unused so the callback should still be void (see
    readline/input.c around line 456 in version 6.3).
    Signed-off-by: Gustavo Zacarias <gustavo at zacarias.com.ar>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Thu Mar 13 00:21:47 CET 2014 on sn-devel-104


Summary of changes:
 libcli/smbreadline/smbreadline.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Changeset truncated at 500 lines:

diff --git a/libcli/smbreadline/smbreadline.c b/libcli/smbreadline/smbreadline.c
index cff25a7..80e10b0 100644
--- a/libcli/smbreadline/smbreadline.c
+++ b/libcli/smbreadline/smbreadline.c
@@ -141,7 +141,7 @@ char *smb_readline(const char *prompt, void (*callback)(void),
 	if (callback)
-		rl_event_hook = (Function *)callback;
+		rl_event_hook = (rl_hook_func_t *)callback;
 	ret = readline(prompt);
 	if (ret && *ret)

Samba Shared Repository

More information about the samba-cvs mailing list