[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Wed Jun 4 08:50:04 MDT 2014

The branch, master has been updated
       via  62b4d44 s3-winbind: Use strlcpy to avoid log entry.
      from  ed89624 docs: Update Roadmap


- Log -----------------------------------------------------------------
commit 62b4d442b9b43d40137ba82e9d00c864ef2d1c25
Author: Andreas Schneider <asn at samba.org>
Date:   Wed Feb 12 13:26:02 2014 +0100

    s3-winbind: Use strlcpy to avoid log entry.
    The full_name from Windows can be longer than 255 chars which results in
    a warning on log level 0 that we have a string overflow. This will avoid
    the warning. However we should fix this sooner or later on the protocol
    level to have no limit.
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Guenther Deschner <gd at samba.org>
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Wed Jun  4 16:49:11 CEST 2014 on sn-devel-104


Summary of changes:
 source3/winbindd/wb_fill_pwent.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

Changeset truncated at 500 lines:

diff --git a/source3/winbindd/wb_fill_pwent.c b/source3/winbindd/wb_fill_pwent.c
index c1f83e5..8c8f839 100644
--- a/source3/winbindd/wb_fill_pwent.c
+++ b/source3/winbindd/wb_fill_pwent.c
@@ -162,7 +162,10 @@ static void wb_fill_pwent_getgrsid_done(struct tevent_req *subreq)
-	fstrcpy(state->pw->pw_gecos, state->info->full_name);
+	/* FIXME The full_name can be longer than 255 chars */
+	strlcpy(state->pw->pw_gecos,
+		state->info->full_name != NULL ? state->info->full_name : "",
+		sizeof(state->pw->pw_gecos));
 	/* Home directory and shell */
 	ok = fillup_pw_field(lp_template_homedir(),

Samba Shared Repository

More information about the samba-cvs mailing list