[SCM] Samba Shared Repository - branch master updated

Volker Lendecke vlendec at samba.org
Tue Jul 22 07:32:04 MDT 2014


The branch, master has been updated
       via  a017280 messaging4: Fix a just-introduced error memleak
      from  478ef94 ctdb: Fix verbose_memory_names

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit a017280ca554a534d9422a055b1cfc0baa3eb8c6
Author: Volker Lendecke <vl at samba.org>
Date:   Tue Jul 22 10:34:08 2014 +0000

    messaging4: Fix a just-introduced error memleak
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    
    Autobuild-User(master): Volker Lendecke <vl at samba.org>
    Autobuild-Date(master): Tue Jul 22 15:31:38 CEST 2014 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/messaging/messaging.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/messaging/messaging.c b/source4/lib/messaging/messaging.c
index 137d859..4242b1c 100644
--- a/source4/lib/messaging/messaging.c
+++ b/source4/lib/messaging/messaging.c
@@ -969,6 +969,11 @@ NTSTATUS irpc_servers_byname(struct imessaging_context *msg_ctx,
 
 	count = rec.dsize / sizeof(struct server_id);
 	if (count == 0) {
+		/*
+		 * In a corrupted db we could end up with a record of size
+		 * less than a struct server_id. Don't leak in this case.
+		 */
+		free(rec.dptr);
 		return NT_STATUS_NOT_FOUND;
 	}
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list