autobuild: intermittent test failure detected

autobuild autobuild at samba.org
Mon Jul 14 01:43:10 MDT 2014


The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2014-07-14-0943/flakey.log

The samba build logs are available here:

   http://git.samba.org/autobuild.flakey/2014-07-14-0943/samba.stderr
   http://git.samba.org/autobuild.flakey/2014-07-14-0943/samba.stdout
  
The top commit at the time of the failure was:

commit 02bcdd109fb24a369c05dceabfdc1b5edd291aeb
Author: Michael Adam <obnox at samba.org>
Date:   Thu Jul 3 10:00:13 2014 +0200

    s3:smbd: initialize stat_ex buffer in smbd_dirptr_get_entry()
    
    This prevents random garbage in the vfs_private member.
    Usually it should not be a problem to leave initialization
    of the vfs_private to the vfs module who wants to use it,
    but further down in the directory listing code, in
    vfswrap_readdir, there is in optimization introduced
    with 2a65e8befef004fd18d17853a1b72155752346c8, to call
    fstatat if possible to already fill stat info in the
    readdir call.
    
    The problem is that this calls fstatat directly,
    not going through VFS, but still making the stat buffer
    valid, leaving vfs_private with random garbage.
    Hence a vfs module using vfs_private, like vfs_gpfs
    does for offline info (and winAttrs in general)
    does not have a chance to tell whether the vfs_private
    is valid if the stat buffer is marked valid.
    This is a reason for the "flapping offline flag" problem
    of the vfs_gpfs module.
    
    Initializing the vfs_private to 0 here will for the
    vfs_gpfs module result in files being marked online
    always in a directory listing. So this is not a real fix
    but it does at least make the problem less random.
    
    A real general fix might be to implement SMB_VFS_FSTATAT()
    and use it here.
    
    Signed-off-by: Michael Adam <obnox at samba.org>
    Reviewed-by: Christof Schmitt <cs at samba.org>
    
    Autobuild-User(master): Christof Schmitt <cs at samba.org>
    Autobuild-Date(master): Sun Jul 13 11:26:58 CEST 2014 on sn-devel-104


More information about the samba-cvs mailing list