autobuild: intermittent test failure detected

autobuild autobuild at samba.org
Fri Feb 14 15:59:55 MST 2014


The autobuild test system has detected an intermittent failing test in 
the current master tree.

The autobuild log of the failure is available here:

   http://git.samba.org/autobuild.flakey/2014-02-14-2359/flakey.log

The samba3 build logs are available here:

   http://git.samba.org/autobuild.flakey/2014-02-14-2359/samba3.stderr
   http://git.samba.org/autobuild.flakey/2014-02-14-2359/samba3.stdout

The source4 build logs are available here:

   http://git.samba.org/autobuild.flakey/2014-02-14-2359/samba.stderr
   http://git.samba.org/autobuild.flakey/2014-02-14-2359/samba.stdout
  
The top commit at the time of the failure was:

commit e0bf930f23fe20ee00d0006a5f6c2ba1a8f592a0
Author: Stefan Metzmacher <metze at samba.org>
Date:   Thu Jan 30 16:12:44 2014 +0100

    s3:smb2_notify: fix use after free on long living notify requests
    
    This is a hack, but it should fix the bug:
    
       change_notify_add_request() talloc moves smb_request away,
       which is not expected by the smb2_notify.c code...
    
       smbd_smb2_notify_reply() uses tevent_req_defer_callback()
       (in older versions an immediate event) to defer the response.
       This is needed as change_notify_reply() will do more things
       after calling reply_fn() (smbd_smb2_notify_reply is this case)
       and often change_notify_remove_request() is called after
       change_notify_reply().
    
       change_notify_remove_request() implicitly free's the smb_request
       that was passed to change_notify_add_request().
    
       smbd_smb2_fake_smb_request() added the smb_request as smb2req->smb1req,
       which is expected to be available after smbd_smb2_notify_recv() returned.
    
    The long term solution would be the following interface:
    
    struct tevent_req *change_notify_request_send(TALLOC_CTX *mem_ctx,
                                                  struct tevent_context *ev,
                                                  struct files_struct *fsp,
                                                  uint32_t max_length,
                                                  uint32_t filter,
                                                  bool recursive);
    NTSTATUS change_notify_request_recv(struct tevent_req *req,
                                        TALLOC_CTX *mem_ctx,
                                        DATA_BLOB *buffer);
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=10442
    
    Signed-off-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Stefan Metzmacher <metze at samba.org>
    Autobuild-Date(master): Fri Feb 14 11:18:15 CET 2014 on sn-devel-104


More information about the samba-cvs mailing list