[SCM] Samba Shared Repository - branch master updated

[Jeremy Allison]

The branch, master has been updated
       via  9c34ae4 winbindd: Use the right flags in dsgetdcname
       via  938bbff regedit_valuelist.c: Coverity fix; Initialize a variable.
      from  e0bf930 s3:smb2_notify: fix use after free on long living notify requests

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 9c34ae4e42efd7a6080dd3d34d30bcda04cc4f6f
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Feb 14 10:14:15 2014 +0000

    winbindd: Use the right flags in dsgetdcname
    
    Signed-off-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Fri Feb 14 21:59:22 CET 2014 on sn-devel-104

commit 938bbff1243400401d534174301939fdd2c59cb9
Author: Christopher R. Hertel (crh) <crh at samba.org>
Date:   Fri Feb 14 11:41:24 2014 -0600

    regedit_valuelist.c: Coverity fix; Initialize a variable.
    
    The <tmp> variable is tested at the end of the function to determine the
    return value, but <tmp> is never initialized and there are conditions
    under which it may be tested before a value is set.
    
    This patch initializes <tmp> to NULL, which means that WERR_NOMEM will
    be returned if the registry lookups fail.
    
    CID:  1168007
    
    Signed-off-by: Christopher R. Hertel (crh) <crh at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>

-----------------------------------------------------------------------

Summary of changes:
 source3/utils/regedit_valuelist.c       |    2 +-
 source3/winbindd/winbindd_dsgetdcname.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/utils/regedit_valuelist.c b/source3/utils/regedit_valuelist.c
index 4d21be5..b135159 100644
--- a/source3/utils/regedit_valuelist.c
+++ b/source3/utils/regedit_valuelist.c
@@ -169,7 +169,7 @@ static bool string_is_printable(const char *s)
 
 static WERROR append_data_summary(struct value_item *vitem)
 {
-	char *tmp;
+	char *tmp = NULL;
 
 /* This is adapted from print_registry_value() in net_registry_util.c */
 
diff --git a/source3/winbindd/winbindd_dsgetdcname.c b/source3/winbindd/winbindd_dsgetdcname.c
index 003301c..dcf574d 100644
--- a/source3/winbindd/winbindd_dsgetdcname.c
+++ b/source3/winbindd/winbindd_dsgetdcname.c
@@ -57,7 +57,7 @@ struct tevent_req *winbindd_dsgetdcname_send(TALLOC_CTX *mem_ctx,
 	DEBUG(3, ("[%5lu]: dsgetdcname for %s\n", (unsigned long)cli->pid,
 		  request->data.dsgetdcname.domain_name));
 
-	ds_flags = get_dsgetdc_flags(request->flags);
+	ds_flags = get_dsgetdc_flags(request->data.dsgetdcname.flags);
 
 	status = GUID_from_string(request->data.dsgetdcname.domain_guid,
 				  &state->guid);


-- 
Samba Shared Repository