[SCM] Samba Shared Repository - branch master updated

Kamen Mazdrashki kamenim at samba.org
Sun Feb 9 18:27:04 MST 2014


The branch, master has been updated
       via  9f2e6f5 s4:samba-tool/testparm: add a warning when acting as an AD-DC and not using UTF-8
      from  a397967 param: rename lp function and variable from "nis_home_map" to "nis_homedir"

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 9f2e6f532d085d864f44351e99212a63bc6a66ee
Author: Garming Sam <garming at catalyst.net.nz>
Date:   Fri Jan 3 11:14:13 2014 +1300

    s4:samba-tool/testparm: add a warning when acting as an AD-DC and not using UTF-8
    
    Signed-off-by: Garming Sam <garming at catalyst.net.nz>
    Signed-off-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Andrew Bartlett <abartlet at samba.org>
    Reviewed-by: Kamen Mazdrashki <kamenim at samba.org>
    
    Autobuild-User(master): Kamen Mazdrashki <kamenim at samba.org>
    Autobuild-Date(master): Mon Feb 10 02:26:28 CET 2014 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 python/samba/netcmd/testparm.py |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/python/samba/netcmd/testparm.py b/python/samba/netcmd/testparm.py
index 7825d25..9af141d 100644
--- a/python/samba/netcmd/testparm.py
+++ b/python/samba/netcmd/testparm.py
@@ -156,6 +156,14 @@ class cmd_testparm(Command):
                 "membership.")
             valid = False
 
+        role = lp.get("server role")
+        charset = lp.get("unix charset").upper()
+
+        if role in ["active directory domain controller", "domain controller", "dc"] and charset not in ["UTF-8", "UTF8"]:
+            logger.warning(
+                "When acting as Active Directory domain controller, "
+                "unix charset is expected to be UTF-8.")
+
         return valid
 
     def allow_access(self, deny_list, allow_list, cname, caddr):


-- 
Samba Shared Repository


More information about the samba-cvs mailing list