[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Tue Dec 16 10:55:02 MST 2014


The branch, master has been updated
       via  10fdf4f smbstatus: Tell the user that smbstatus can only be run as root.
      from  af570c2 Revert "script/autobuild.py: build the samba target with --with-profiling-data"

https://git.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 10fdf4f5eb1f1c0a0f12050fe8241c3e92f715d9
Author: Andreas Schneider <asn at samba.org>
Date:   Tue Dec 16 15:52:43 2014 +0100

    smbstatus: Tell the user that smbstatus can only be run as root.
    
    In the meantime smbstatus tries to collection information from tdb's
    which are only accessible by root as they contain sensitive information
    like session keys and other secrets. This means smbstatus can no longer
    be executed as a user.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=11012
    
    Signed-off-by: Andreas Schneider <asn at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    
    Autobuild-User(master): Andreas Schneider <asn at cryptomilk.org>
    Autobuild-Date(master): Tue Dec 16 18:54:41 CET 2014 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/utils/status.c | 7 +++++++
 1 file changed, 7 insertions(+)


Changeset truncated at 500 lines:

diff --git a/source3/utils/status.c b/source3/utils/status.c
index cd6a988..61efa93 100644
--- a/source3/utils/status.c
+++ b/source3/utils/status.c
@@ -386,6 +386,13 @@ int main(int argc, const char *argv[])
 		goto done;
 	}
 
+	if (getuid() != 0) {
+		d_printf("smbstatus only works as root!\n");
+		ret = 1;
+		goto done;
+	}
+
+
 	pc = poptGetContext(NULL, argc, argv, long_options,
 			    POPT_CONTEXT_KEEP_FIRST);
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list