[SCM] Samba Shared Repository - branch master updated

Amitay Isaacs amitay at samba.org
Wed Aug 20 08:55:03 MDT 2014


The branch, master has been updated
       via  47e7440 replace: Remove unused item returned by FAILED()
      from  953c883 s4:torture:vfs_fruit: add tests for resource fork IO

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 47e7440be9ab422b3b2544c0b071fb8717a7a915
Author: Martin Schwenke <martin at meltin.net>
Date:   Thu Jul 31 11:03:59 2014 +1000

    replace: Remove unused item returned by FAILED()
    
    The (return) value of FAILED() is a constant 1.  However, it is never
    used, so the compiler complains when run with -Wall:
    
      lib/replace/test/os2_delete.c: In function ‘cleanup’:
      lib/replace/test/os2_delete.c:39:163: warning: right-hand operand of comma expression has no effect [-Wunused-value]
       FAILED("system");
    
    So just get remove the ", 1" since it is the bit that does nothing and
    is never used.
    
    Signed-off-by: Martin Schwenke <martin at meltin.net>
    Reviewed-by: Amitay Isaacs <amitay at gmail.com>
    
    Autobuild-User(master): Amitay Isaacs <amitay at samba.org>
    Autobuild-Date(master): Wed Aug 20 16:54:31 CEST 2014 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 lib/replace/test/os2_delete.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/replace/test/os2_delete.c b/lib/replace/test/os2_delete.c
index a11ed3b..9e2115b 100644
--- a/lib/replace/test/os2_delete.c
+++ b/lib/replace/test/os2_delete.c
@@ -22,7 +22,7 @@
 
 static int test_readdir_os2_delete_ret;
 
-#define FAILED(d) (printf("failure: readdir [\nFailed for %s - %d = %s\n]\n", d, errno, strerror(errno)), test_readdir_os2_delete_ret = 1, 1)
+#define FAILED(d) (printf("failure: readdir [\nFailed for %s - %d = %s\n]\n", d, errno, strerror(errno)), test_readdir_os2_delete_ret = 1)
 
 #ifndef MIN
 #define MIN(a,b) ((a)<(b)?(a):(b))


-- 
Samba Shared Repository


More information about the samba-cvs mailing list