[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Tue Aug 12 20:37:03 MDT 2014


The branch, master has been updated
       via  f34ffd0 Fixed a memory leak in cli_set_mntpoint().
      from  c2f66e7 messaging3: Include messages_dgm.h only in messages.c

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit f34ffd0d0993f997f2b4e3b992338def367cc49b
Author: Har Gagan Sahai <SHarGagan at novell.com>
Date:   Wed Aug 6 14:32:35 2014 +0530

    Fixed a memory leak in cli_set_mntpoint().
    
    Fixes bug #10759 - Memory leak in libsmbclient in cli_set_mntpoint function
    
    https://bugzilla.samba.org/show_bug.cgi?id=10759
    
    Signed-off-by: Har Gagan Sahai <SHarGagan at novell.com>
    Reviewed-by: Stefan Metzmacher <metze at samba.org>
    Reviewed-by: Volker Lendecke <vl at samba.org>
    Reviewed-by: Jeremy Allison <jra at samba.org>
    
    Autobuild-User(master): Jeremy Allison <jra at samba.org>
    Autobuild-Date(master): Wed Aug 13 04:36:50 CEST 2014 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source3/libsmb/clidfs.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libsmb/clidfs.c b/source3/libsmb/clidfs.c
index 80fba23..93f04c5 100644
--- a/source3/libsmb/clidfs.c
+++ b/source3/libsmb/clidfs.c
@@ -280,13 +280,15 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
 
 static void cli_set_mntpoint(struct cli_state *cli, const char *mnt)
 {
-	char *name = clean_name(NULL, mnt);
+	TALLOC_CTX *frame = talloc_stackframe();
+	char *name = clean_name(frame, mnt);
 	if (!name) {
+		TALLOC_FREE(frame);
 		return;
 	}
 	TALLOC_FREE(cli->dfs_mountpoint);
 	cli->dfs_mountpoint = talloc_strdup(cli, name);
-	TALLOC_FREE(name);
+	TALLOC_FREE(frame);
 }
 
 /********************************************************************


-- 
Samba Shared Repository


More information about the samba-cvs mailing list